github.com/shurcooL/issuesapp/...

Email is only sent to Actor #31

Closedkeegancsmith opened this issue 3 years ago
keegancsmith commented 3 years ago

If you are subscribed to a thread, you won't receive the email (unless you commented, etc). We need to fetch a list of subscribers here and pass them in as Recipients.

Write Preview Markdown
keegancsmith commented 3 years ago

I didn't actually get an email for this action, so it's possible emails are not being sent for some reason.

Write Preview Markdown
dmitshur commented 3 years ago

There's no API in notification center to get a list of subscribers currently, but we can discuss and change that as needed.

I'd suggest leaning in favor trying to move email sending into notification center itself, since I think that's the end goal. But that might be up for discussion too. It seems like we're already having that discussion at https://dmitri.shuralyov.com/issues/github.com/shurcooL/notificationsapp/7, so perhaps let's continue that discussion there.

Write Preview Markdown
dmitshur commented 3 years ago

It seems like we're already having that discussion at https://dmitri.shuralyov.com/issues/github.com/shurcooL/notificationsapp/7, so perhaps let's continue that discussion there.

Closing here to avoid duplicate issue.

Write Preview Markdown
dmitshur closed this 3 years ago
to comment.