github.com/shurcooL/issuesapp/...

"Create Issue" button doesn't show up if user isn't logged in. #40

Closeddmitshur opened this issue 2 years ago
dmitshur commented 2 years ago

This is what a logged in user sees:

Image

A logged out user doesn't see the "Create Issue" button:

Image

This is because the "create-issue" template currently displays the "Create Issue" button only if there's a logged in user:

https://github.com/shurcooL/issuesapp/blob/9e2c196c3359f4fbbf7e14b005ef54bcae83a768/assets/_data/issues.html.tmpl#L30

This is not ideal. What it should ideally be checking is whether the issue tracking service supports issues being created (most do). If so, the button should be displayed. Clicking it will give an unauthenticated response, which can be intercepted by redirecting to a login prompt, and then back to the new issue page.

There are some read-only service implementations, such as github.com/shurcooL/issues/maintner, used by golang.org/x/build/maintner/cmd/maintserve, that we shouldn't break while fixing this.

Write Preview Markdown
dmitshur commented 2 years ago
Write Preview Markdown
dmitshur closed this 2 years ago
to comment.