Gophers Activity Stream (prototype)
Today
shurcooL commented on Text to Emoji Translation in github.com/go-london-user-group/hacknights3h
Related:
- https://meowni.ca/emoji-translate/
- https://dmitri.shuralyov.com/projects/hash-emoji/
shurcooL commented on How can I render a circle (dot) ico… in github.com/primer/octicons4hThere are many ways to make a circle, there's no single one right way.
You could define your own SVG element that creates a circle of the right size, that's likely the easiest way.
shurcooL commented on Add preview support to Topics API in github.com/google/go-github4hYou can see the comment was in the right place on the [original commit where I left it](https://github.com/google/go-github/pull/672/commits/43efbcca65900900ec7cda9ccf16dcbf8d47364e).
shurcooL commented on Add preview support to Topics API in github.com/google/go-github4hThis is a github bug... 😞 I left this comment in the right place, and after a new commit was pushed which resolved the issue, github incorrectly associated my comment with this wrong place instead…
shurcooL commented on Add preview support to Topics API in github.com/google/go-github4h@gmlewis The reason the generated methods disappeared is because they're only generated for pointers, but those fields were changed to slices. CI is passing.
dlsniper commented on Renaming doesn't rename commented m… in github.com/go-lang-plugin-org/go-lang-idea-plugin9h
@bronze1man I understand it's a problem for you but I cannot debug: it's slow and stupid. Please help me reproduce the issue so that it stops being slow and stupid.
dlsniper commented on Renaming doesn't rename commented m… in github.com/go-lang-plugin-org/go-lang-idea-plugin9h> If you try rename some name like Error, you will find it slow and stupid.
Slow and stupid is not something actionable. If you do find something that's an issue, please try and provide steps to r…
dlsniper commented on Renaming doesn't rename commented m… in github.com/go-lang-plugin-org/go-lang-idea-plugin12h> Is there any way to make Gogland refactor works as this plugin ?
Yes, you can send a PR to it because I'm not going to work on it and there's no other active maintainer for the plugin. I don't w…
dlsniper commented on Not able to install go lang plugin … in github.com/go-lang-plugin-org/go-lang-idea-plugin12hThere are currently no plans to make this plugin compatible with 2017.2 as far as I know. The JetBrains maintained one is not going to compatible with the community version. You can use https://www.j…
shurcooL commented on Add preview support to Topics API in github.com/google/go-github14hMinor, but I think it'd be more consistent/logical to move this new case under the `searchType == "commits"` case. It's more similar to that one.
shurcooL commented on Add preview support to Topics API in github.com/google/go-github14hUse `t.Fatalf` here as well, for same reason as above.
shurcooL commented on Add preview support to Topics API in github.com/google/go-github14hI think you meant "Repositories. ListAllTopics" in the error message, not "Repositories.ReplaceAllTopics".
Also, use `t.Fatalf` instead of `t.Errorf` here. If `err != nil`, that's a fatal error, w…
Yesterday
shurcooL commented on tests/integration: Get rid of integ… in github.com/google/go-github19hThe importance of this issue has been reduced with d4206f97f4cbd4c357e2b825c886ad7bcacc184c.
shurcooL commented on Move general reflect logic to inter… in github.com/google/go-cmp19hFor GitHub, not that I know of.
For git, I think you can adjust the `
--find-renames[=<n>]` (aka `-M[<n>]`) flag of `git diff`, see https://git-scm.com/docs/git-diff. You may be able to get it to…
shurcooL commented on Add preview support to Topics API in github.com/google/go-github19hMove `want` just above this line. It's pretty common to get the value of `got`, then define `want` and check if they're not equal. See tests above.
```Go
want := ...
if !reflect.DeepEqual(topics…
shurcooL commented on Add preview support to Topics API in github.com/google/go-github19h@RaviTezu, you should edit your PR description (or commit message) to include `Fixes #670.` instead of just `Issue Link: #670`, since you intend for this PR to resolve the entire issue. That way, whe…
bradleyfalzon commented on malformed clienthello packet in github.com/bradleyfalzon/tlsx20h
Yeah @mholt the first byte looks OK to me, but the byte immediately after should be a 2 byte version and that doesn't match anything (SSLv3, TLS1.0, 1.1, 1.2 or 1.3), so immediately it's suspicious.
shurcooL commented on test/integration: Update for API ch… in github.com/google/go-github23hAll right.
> Also, I didn't know why `go install` was used instead of `go build`.
For posterity, `go install` and `go build` effectively do the same thing, but the latter tends to throw away it…
shurcooL commented on net/http: Redirect documentation re… in github.com/golang/go23h[CL 49712](https://golang.org/cl/49712) implements the fix and is valid.
However, it got me thinking. Perhaps a better, alternative fix should be considered.
Go favors clarify of API documentat…
shurcooL commented on test/integration: Update for API ch… in github.com/google/go-github1dHave you seen my comment above at https://github.com/google/go-github/pull/674#issuecomment-316196325? Does it answer your question, or should I elaborate?
Note that `go test` is a superset of `go…
shurcooL commented on test/integration: Update for API ch… in github.com/google/go-github1d> Hmm, it might be possible to make it so that the integration test is verified to build successfully, but not run the tests. Let me do that.
I originally tried to just test that the package build…
shurcooL commented on test/integration: Update for API ch… in github.com/google/go-github1dNote, CI is meaningless for this change. It doesn't do anything about `./test/integration` because it's an empty package unless `integration` build tag is manually specified.
Hmm, it might be poss…
dominikh commented on simple: suggest simplifying closure… in github.com/dominikh/go-tools1d
It may be a dup. However, @shurcooL provides a nice example for a case that's trivial to implement – unlike the more general case of #40. If the anonymous function isn't closing over any variables,…
dominikh commented on add go-guru-definition-other-window in github.com/dominikh/go-mode.el1dMerged as 3f02a165dba38295ae4b961482fe50e012a2112a, thank you.
dominikh commented on add go-guru-definition-other-window in github.com/dominikh/go-mode.el1dFor now: KISS.
dominikh commented on Cutstom go installation confusing t… in github.com/dominikh/go-tools1dI'm going to close this issue. I don't think there's anything we can do here.
dominikh commented on SA9004: time equality check in github.com/dominikh/go-tools1d> Is this check viable?
No, it is not. Thanks for linking to prior discussion that I was utterly incapable of finding myself.
shurcooL commented on SA9004: time equality check in github.com/dominikh/go-tools1dIs this check viable? Will it skip cases where `==` operator must be used, e.g., when `time.Time` is a map key?
See #47 for previous discussion of this check (before Go 1.9 changes were finalized).
dominikh commented on Enhance project README in github.com/dominikh/go-tools1d`To install or update all of the tools, run`
dominikh commented on Enhance project README in github.com/dominikh/go-tools1dI'm with @shurcooL on this one.
dominikh commented on SA9004: time equality check in github.com/dominikh/go-tools1dDrop the tests involving pointers. People shouldn't be passing around pointers to times like this.
dominikh commented on SA9004: time equality check in github.com/dominikh/go-tools1dSay `should use time.Time.Equal instead` instead of `prefer Time.Equal`
dominikh commented on SA9004: time equality check in github.com/dominikh/go-tools1dWrap operators and identifiers in backticks
dominikh commented on SA9004: time equality check in github.com/dominikh/go-tools1dReword the message to read `should use time.Time.Equal when comparing time.Time values`
dominikh commented on SA9004: time equality check in github.com/dominikh/go-tools1dFile needs a newline at the end.
dominikh commented on simple: flag unnecessary conversion… in github.com/dominikh/go-tools1dMerged as 5e9ab3832584b6fe46a9a39748c985e835b3764b
shurcooL commented on Support preview Repository API - re… in github.com/google/go-github1dFeel free to go for it, @RaviTezu, and thanks!
Take a look over https://github.com/google/go-github/blob/master/CONTRIBUTING.md to be familiar with contributing guidelines.
bradleyfalzon commented on Support preview Repository API - re… in github.com/google/go-github1dLet me know how you go @RaviTezu, I'm interested in this functionality. I have a work around, so no pressure.
bradleyfalzon commented on malformed clienthello packet in github.com/bradleyfalzon/tlsx1dOK, had a quick look, and it doesn't look like a client hello at all. The first byte suggests it's a TLS handshake, but the rest of it doesn't look right at all:
```
Version: 0xf2c8 (unknown)
Ha…
bradleyfalzon commented on malformed clienthello packet in github.com/bradleyfalzon/tlsx1dThanks, I can take a quick look, but did you happen to see what's wrong?
This Week
shurcooL pushed to github.com/shurcooL/go-cmp1d
083afec4Travis: Use latest patch of 1.6; don't run vet on it.shurcooL pushed to github.com/shurcooL/go-cmp1d
0e844f7fTravis: Use latest patch of 1.6; don't run vet on it.shurcooL commented on Travis: Run go vet; use race detect… in github.com/google/go-cmp1dYes, I believe that (or something along those lines) would work.
You could make it a little nicer by using the `TRAVIS_GO_VERSION` env var which includes version only without prefix/suffix, as des…
shurcooL commented on Travis: Run go vet; use race detect… in github.com/google/go-cmp1dEverything is succeeding on Go 1.8 and tip, but `go tool vet .` is failing on Go 1.6.
In general, I think the best thing to do is to run `go vet` and similar checks on latest version of Go only, a…
shurcooL pushed to github.com/shurcooL/go-cmp1d
43453df4Travis: Run go vet; use race detector during tests.shurcooL commented on Perform additional checks in Travis… in github.com/google/go-cmp1dOhhh, I found it! @dsnet, you were the person who made the suggestion. 😆
See https://github.com/golang/lint/pull/279#issuecomment-283166030.
shurcooL commented on Perform additional checks in Travis… in github.com/google/go-cmp1d> Suggested script LGTM, but avoid the go get step for now. It is intended for this package to have no dependencies other than the standard library. We can add that in if this ever changes.
SGTM, …
shurcooL commented on Perform additional checks in Travis… in github.com/google/go-cmp1dFor reference, I sent a similar change to `.travis.yml` to `gorilla/mux` in 2015 and it was accepted there, see https://github.com/gorilla/mux/pull/134.