Activity
Yesterday
dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder12h
> Cleared. Let's see if it helps when the next task arrives...
You may also want to try running the swarming bot with `CIPD_ARCHITECTURE=mips64le` set in the environment, and see if that helps. See …dmitshur commented on lib/fips140: freeze FIPS 140-3 module v2.0.0-rc.121h
Also CC @dr2chase.dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.26.md: fixed typos in goroutine leak section21h
Thanks.dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder22h
The pool dimension value is fixed.
It might also be possible for us to override the incorrectly inferred cipd_platform value via configuration. Trying it out had effect, the https://chromium-swarm.a…dmitshur starred github.com/KaijuEngine/kaiju23h
This Week
dmitshur commented on golang.org/x/build: add LUCI linux-mips builder1d
Noting here that if a LUCI builder isn't added to provide test coverage for this port, it risks becoming broken without anyone noticing. There's signal provided by the legacy builders, but it's not v…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder1d
The builder page at https://chromium-swarm.appspot.com/bot?id=linux-mipsle-cip-united--1 shows its current state, and it's visible there that some of the dimensions will need adjustment:
1. Its "poo…dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder1d
Glad that you got to the bottom of the constant rebooting issue, and that the builder successfully connected.
The builder page at https://chromium-swarm.appspot.com/bot?id=linux-mips64le-cip-united-…dmitshur closed an issue runtime/pprof: StopCPUProfile causes SIGKILL on Linux kernel 6.121d
dmitshur commented on golang.org/x/debug/dwtest: add more loclist tests1d
Please note some of the new TestDwarfVariableLocations subtests aren't passing on longtest builders. See https://ci.chromium.org/b/8698385165148723409 as one example, and https://ci.chromium.org/p/go…dmitshur commented on debug/pe: (*File).ImportedSymbols seeking to virtual address lacks bounds check before using VirtualAddress2d
Also CC @golang/windows.dmitshur commented on debug/pe: (*File).ImportedSymbols's ImportDirectory decoding implicitly assumes it can decode LittleEndian values when data might be short2d
CC @golang/windows.Last Week
dmitshur commented on golang.org/x/pkgsite: pkg.go.dev/constraints works when maybe it should not5d
Thanks for reporting. That little triangle inside the "Latest" badge does say that the package doesn't exist in the latest version of the standard library, but admittedly it is small and pretty uncom…dmitshur commented on runtime: stack split at bad time in os/signal with Go 1.25.4 windows 3865d
CC @golang/windows.dmitshur commented on cmd/gofmt: trailing comments in composite literals are misaligned5d
CC @griesemer, @mvdan.dmitshur pushed to
master in github.com/andygrunwald/go-gerrit5ddmitshur merged a change github.com/andygrunwald/go-gerrit: Don't treat + as a special character for queries5d
dmitshur reviewed +2 on github.com/andygrunwald/go-gerrit: Don't treat + as a special character for queries5d
We have no new information about issue #18, so let's move forward with the (partial) revert of PR #22.dmitshur commented on io: add an `Err` field to `LimitedReader`5d
Yes, the `wait-release` is used to indicate that CL can be submitted for the next Go release, because we've now entered a release freeze for Go 1.26. See https://groups.google.com/g/golang-dev/c/Om8V…dmitshur fixed an issue access: Requesting TryBot access for "kiran.m.vijay@ibm.com"5d
Hi Kiran,
Thank you for your contributions, including helping maintain the s390x architecture, and for requesting trybot access. I've added you to the `may-start-trybots` group, so you should be abl…dmitshur commented on access: Requesting TryBot access for "kiran.m.vijay@ibm.com"5d
Hi Kiran,
Thank you for your contributions, including helping maintain the s390x architecture, and for requesting trybot access. I've added you to the `may-start-trybots` group, so you should be abl…dmitshur commented on golang.org/x/pkgsite: wrong section expanded when clicking a collapsable header5d
CC @golang/pkgsite.dmitshur commented on golang.org/x/website: playground execution doesn't finish normally, but no error message is shown5d
CC @findleyr, @golang/tools-team.dmitshur commented on all: exec: WaitDelay expired before I/O complete failures on Darwin and Windows6d
Added this to Test Flakes project, otherwise watchflakes won't post to it.
Note that some of the matching failures in #68788 were on netbsd/arm64, freebsd/riscv64, freebsd/amd64, maybe more. Perhaps…dmitshur commented on all: end support for ppc64/linux (big-endian, ELFv1) in Go 1.276d
Added this to Go 1.26 release blockers to add a pre-announcement to Go 1.26 release notes.dmitshur closed an issue : x/website:6d
dmitshur commented on cmd/go: env vars like GOPRIVATE should reject shell characters which suggest a human error6d
CC @golang/command-line.dmitshur commented on net/http: HTTP2: not-consistent invalid error when server closes connection, possible race condition6d
CC @neild.dmitshur commented on os: NewFile blocks if handle is blocked6d
Thanks for clarifying. Given the remaining fix might be complex, do you think it's worth trying to get it into Go 1.26, while we're still fairly early in the freeze? I applied the release-blocker lab…dmitshur commented on cmd/go: fix: apply fixes from modernizers, inline, and other analyzers6d
@adonovan Checking in on the status here as this is a Go 1.26 RC 1 blocker. Or perhaps if what is left here is safe for after RC 1, then it can have okay-after-rc1 label added. Thanks.dmitshur commented on golang.org/x/tools/internal/refactor/inline: inlining of { return new(x) } may change its type6d
@markus-kusano Checking in on the status here as this is currently marked as a Go 1.26 RC 1 blocker. Or perhaps this is safe after RC 1 and can have okay-after-rc1 label added. Thanks.dmitshur commented on runtime/metrics: do not count inactive cgo threads (/sched/goroutines/not-in-go:goroutines)6d
@mknyszek Checking in on the status here as this is a Go 1.26 RC 1 blocker. Or perhaps this is safe after RC 1 and can have okay-after-rc1 label added.dmitshur commented on crypto/tls: earlyTrafficSecret should use ClientHelloInner if ECH enabled [1.25 backport]6d
No problem, thanks! This was waiting for yesterday's minors to be released first anyway.dmitshur commented on crypto/tls: earlyTrafficSecret should use ClientHelloInner if ECH enabled [1.25 backport]6d
@rolandshoemaker Since you authored the original CL, would you like to create the backport CLs (for this and #76408)?dmitshur commented on github.com/udhos/update-golang: Change source in update-golang.sh1w
Yeah, that should be the next step to resolve this, though I'm not sure who maintains this script. CC @udhos.dmitshur commented on github.com/actions/setup-go: Failing to download latest go version 1.25.51w
This was previously reported in issue #664. PR https://github.com/actions/setup-go/pull/667 was created to resolve this for v4.
It is already resolved in v6 as of [v6.1.0](https://github.com/actions…Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change7modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust5y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle5ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)5y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur opened an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y
dmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Commit [5275a64a](https://dmitri.shuralyov.com/website/gido$commit/5275a64acd14885a8d67315e2b66570347b757af) has made this better. Directories are now determined by walking Go repositories at process…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6y