Activity

Today
dmitshur reviewed +2 on cmd/vet: add waitgroup analyzer2h
Thanks.
(1 comment) Thanks. It works out well since we want to update all golang.org/x dependencies regularly anyway (#36905).
(1 comment) Is this revert to v0.30.0 unintentional? If intentional, it needs to also be done for the cmd module to keep them both using the same x/sys version.
In your other comments you said "Fix applied". In order to apply that change, it does require adding a new "patch set". A patch set is what Gerrit refers to revisions, and a new one is needed to make…
Thanks. "net/http" is already listed under Security.Packages for the #72011 security fix. But "net/http" also has a bug (non-security) fix for issue #72103. Add it to the Bug.Packages list too? No…
Yesterday
No problem. Note there's still no patch set 2 available. If you have it as a draft, it there's a button you need to press to publish it.
Fixed via [crrev.com/c/6414930](https://crrev.com/c/6414930), which adds escaping for this character on the side of result_adapter. Filed #73116 in case there's something the go command can do bette…
Fixed via [crrev.com/c/6414930](https://crrev.com/c/6414930), which adds escaping for this character on the side of result_adapter. Filed #73116 in case there's something the go command can do bette…
This issue is meant to capture a small finding from #73086, and it's related to the cluster of proposals like #67562 (and its earlier version #45549), #27896, possibly more like #44970, #20209, #2021…
(1 comment) Did you mean to upload a new patch set, or do you mean something different by "Acknowledged"?
Thanks. ```suggestion internal/buildgo: fix use of wrong error ``` ```suggestion err has been checked, it is nil now, here should call sp.Done with remoteErr. ``` (See go.dev/wiki/CommitMessage.)
Last Week
dmitshur reviewed +2 on cmd/vet: add waitgroup analyzer3d
Thanks. This CL enables the implementation for this feature, documents it, and closes the issue in the Go1.25 milestone (via 'Fixes #18022'). That's 3 out of 4 things we need to be able to release G…
Yes, both of those approaches would work. Since the golang.org/x/tools/go/analysis/passes/waitgroup package is small (2 .go files), to me it seems fine to get it vendored in the next CL (i.e., the s…
Ready to take this step now, dropping hold.
One of Swarming Bot requirements is to have passwordless sudo reboot enabled. While here, also install unzip for x/build/cmd/racebuild, and nano for some interactive debugging convenience. For gola…
For golang/go#73086.
The x/text dashboard has turned red: https://ci.chromium.org/p/golang/g/x-text-gotip-by-go/console The text execution itself passes, but LUCI builds (for example, https://ci.chromium.org/b/87191676…
Thanks.
CC @matloob, @samthanawalla.
CC @golang/security.
Thanks. The value of `crl.Issuer.Organization` contains only one backslash character: ``` Organization:[]string{`VeriSign\`} ``` And the String method prints that one backslash in escaped format. H…
Thanks. go.dev is newer and shorter compared to golang.org. While they both work, it seems we should prefer writing down the former in new code and documentation. ```suggestion // Before implementi…
Hold for now. This is meant to be submitted later, after we're done iterating on the image and ready to proceed.
> What is that subset? As noted at https://staticcheck.dev/docs/configuration/, "Staticcheck tries to provide a good out-of-the-box experience, [...]", that is, this question is already being consid…
This change is ready for review.
For golang/go#72030.
For golang/go#72030.
For golang/go#72030.
CC @golang/vulndb.
CC @golang/security.
CC @golang/security.
In the issue report you mention "I use Go to parse this CRL file, Go interprets". Can you please provide a snippet of code for that? In particular, that code will help determine if the problem is in …
@JunyangShao Since you authored the original CL, would you like to create the cherry-pick CL for it too? The process is documented at https://go.dev/wiki/MinorReleases#making-cherry-pick-cls. Thanks.
CC @golang/security.
Earlier
@neild Both this issue (#72954) and issue #72140 say: > This is a regression in 1.24 caused by CL 637939 for #35892. And they both request a backport to 1.24, but as far I can tell, CL 637939 is on…
To clarify, is it intentional that the test2json line would exclude remaining TestEvent fields like "Time", "Package" (in contrast to https://github.com/golang/go/issues/71287#issuecomment-2737759645…
FreeBSD 12.3 is EOL'ed as noted in https://github.com/golang/go/issues/61095#issuecomment-2334940821. We ended up adding a newer FreeBSD 14.1 as part of that issue, so there's nothing more to do for …
It was possible to successfully build the image, and its swarming bot client successfully connects with `cipd_platform:openbsd-386`: https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Aopen…
The flakes in #54461 seem to happen on OpenBSD 7.2 builders only. [CL 654676](https://go.dev/cl/654676) replaces the previous OpenBSD 7.2 builders with the new 7.6 ones, so those those will go away. …
The builder is currently operational. Thanks for resolving this @bsiegert. Closing.
The builder is currently operational. Thanks for resolving this. Closing.
The builder is currently operational. Thanks for resolving this @n2vi. Closing.
This bot doesn't exist now. It existed briefly (see https://github.com/golang/go/issues/67299#issuecomment-2276610972) but has since been deleted because its cipd_platform was incorrectly computed. …
Fixed alongside #72851.
CC @golang/release. Fixed alongside #72851.
Fixed alongside #72851.
Fixed alongside #72851.
dmitshur deleted branch in rsc.io/rf2w
drop-go116
dmitshur pushed to main in rsc.io/rf2w
c71790db15004dd523d532f6a7daa6f12b3b81f6git-generate: modernize slightly
Thanks.
Whoops, that file wasn't present in the GCS bucket. (Thanks @cagedmantis for spotting the issue!) I've sent [CL 657995](https://go.dev/cl/657995) that adds it as a target and uploaded it now. Gomote…
@4a6f656c The CL above implements the change you requested, please feel free to review it when you get a chance. Leaving this to you, but please ping this issue if there's something we can do to help…
We can add tasks that run after the go directive maintenance happens as part of the major Go release relui workflow, here: https://cs.opensource.google/go/x/build/+/master:internal/relui/workflows.go…
This `contextVersion` parameter is unused, which prevents runTest(1) and runTest(2) from testing both WebGL 1 and 2 contexts. I filed #3719 for this and another issue related to RGBA16F that I spotte…
Consider the followin two pages: - WebGL drawingBufferStorage Conformance Tests - https://registry.khronos.org/webgl/sdk/tests/conformance/canvas/drawingbuffer-storage-test.html - WebGL2 drawingBuff…
dmitshur closed an issue iter: add `Push` function3w
I didn't spot problems in the client code, and based on what @aarzilli observed, it seems we can't discount the possibility of GitHub returning an incomplete issue list without also reporting an erro…
Timing seems to align with https://www.githubstatus.com/incidents/lb0d8kp99f2v: > Issues is experiencing degraded performance. > Searches for issues and pull-requests may be slower than normal and…
The problem doesn't reproduce when running watchflakes locally now: ``` […] watchflakes: 2025/03/07 11:24:53 readComments 60085 watchflakes: 2025/03/07 11:24:53 readComments 70602 watchflakes: 202…
From looking at https://ci.chromium.org/ui/p/golang/builders?q=openbsd-amd64_7.6, the openbsd/amd64 builder with OpenBSD 7.6 is still running into what looks like #66474, possibly less frequently aft…
As visible at https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64_7.6 (comparing it with https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64), there ar…
Given the change in #71294 is now implemented, we can't release Go 1.25 without having it also be documented and mentioned in release notes. Since that issue is already closed but this one's still op…
@fflewddur To clarify, that time when you saw it already posted, it must've been posted manually by someone else. The work of automating this hasn't been done yet, but this issue tracks progress on d…
I’m not familiar the specifics of why the `tlskyber` godebug was added in Go 1.23 and removed in 1.24, but I’ll note that https://go.dev/doc/godebug includes: > GODEBUG settings added for compat…
Also seeing at least one instance of this in #65482, and I most recently ran into it in the first trybot run of [CL 655037](https://logs.chromium.org/logs/golang/buildbucket/cr-buildbucket/8721234441…
Trying it again without any changes resulted in no errors this time: <details> ``` […] + pkg_add -iv -I bash curl git python%3 sudo--gettext […] git-2.46.1 (installing) Shell /usr/local/bin/git…
dmitshur closed an issue image: add `(*Uniform).SubImage`4w
@4a6f656c Thanks for the hint, it was right on. The output from my run of `VERSION=7.6 ARCH=amd64 ./make.bash` indeed included a line "pkg_add: Installation of python-3.11.10p1 failed, partial instal…
Closed by merging [CL 601555](https://go.dev/cl/601555) (commit 3b9d10cce787a6ab358a489b604edccb5414baf2).
> is it because I've said 1.23.6 in the body ? Yes; we should fix #27489.
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)
dmitshur pushed to main in dmitri.shuralyov.com/scratch11mo
5eb48b5f5d31d39777719edb35d37b724f183dc8quine: add load-bearing trailing space
dmitshur created package in dmitri.shuralyov.com/scratch/quine11mo
LGTM. Thanks, and congrats on your first new Go package here! Done in PS 2. Patch set 2 seems to resolve this.