Activity

Yesterday
9fa5ffeda4170de60f67f3aa0f824e426421ba724c21e133c1e35d6159ca1bec is the right sha256 checksum for the go1.25.4.linux-amd64.tar.gz file. It can be reproduced with distpack by building Go 1.25.4 from s…
Last Week
Thanks for preparing the CL. Closing since the decision in #75817 is not to backport.
Thanks for preparing the CL. Closing since the decision in #75818 is not to backport.
(1 comment) No, this was just a temporary hold to make it clear that this CL was waiting on a decision to happen in the backport issue #75818. If the backport issue were approved, the hold would be …
In this case since Go 1.25.4 is released by now, yes, it is better to create a new backport issue to track this CL. The issue can say it's a follow-up fix for issue #75989 and provide a brief rationa…
dmitshur starred github.com/u-root/cpu2d
@stevenh I agree that it shouldn't be needed to skip tests, but I think it's possible to update them not to rely on undocumented behavior, while still checking the property you're looking to test. Se…
I left a few suggestions on how the test cases can be updated to not run into issue golang/go#75157. It should work without needing to skip those tests. Consider this modified test case: ```diff …
Please see https://go.dev/wiki/MinorReleases. All backport CLs need an accompanying cherry pick issue with a rationale, which we'll need to review before the CL can land. I see the tip CL didn't hav…
Earlier
CC @golang/command-line.
That hostname should work well, thanks. Here is the corresponding certificate: [linux-mips64le-cip-united-1761320497.cert.txt](https://github.com/user-attachments/files/23127740/linux-mips64le-cip-un…
@Rongronggg9 Thank you for offering that builder to test the linux/mipsle port. Its hardware should work as long as it provides useful signal. Does all.bash pass on it with GOOS=linux GOARCH=mipsle a…
When the -json flag is used with `go tool dist test` (added in #37486), it's expected to only write JSON lines. There seems to be a path where some non-JSON is written to stdout too, which is a bug:…
Fixed in [CL 711920](https://go.dev/cl/711920).
Closing for now because the freebsd/riscv64 port is [marked broken](https://cs.opensource.google/go/go/+/master:src/cmd/dist/build.go;l=1830;drc=6f4c63ba63fdec6e4a42e2e19ac71937973dedef) at tip and […
Asked for a more detailed backport rationale in https://github.com/golang/go/issues/75763#issuecomment-3433007301.
Asked for a more detailed backport rationale in https://github.com/golang/go/issues/75763#issuecomment-3433007301.
@kolyshkin What's the reason to suggest backporting this issue? We'd need a bit more information to review the backport request. Our backporting criteria is documented at https://go.dev/wiki/MinorRe…
@MingcongBai Yes, please do. In general, you could reuse an existing open issue for a given GOOS/GOARCH pair and move on to step 2 at https://go.dev/wiki/DashboardBuilders#how-to-set-up-a-builder (g…
Also see tracking issues #67304 and #67306.
This is being reported by race builders across various ports at tip: ``` === RUN TestIssue69912 ================== WARNING: DATA RACE Write at 0x00c0001aa098 by goroutine 1118: cmd/compile/inter…
CC @golang/command-line.
CC @golang/runtime, @cherrymui.
Thanks for the report. Does the failure happen reproducibly or intermittently for you? It seems not to happen on the linux/amd64 builder ([here](https://ci.chromium.org/ui/p/golang/builders/ci/gotip…
CC @golang/command-line.
CC @golang/command-line.
CC @robpike, @rsc.
Thanks for doing that! From my perspective, changing download URLs from `https://storage.googleapis.com/golang/{file}` to `https://go.dev/dl/{file}` is the right thing to do, so I'll leave further…
Consider using https://go.dev/dl/ itself and following the redirects. It's likely that https://dl.google.com/go/ will remain current for a long time, but if it ends up changing in the future, this wi…
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…
The linux/arm64 trixie builder is up (with a known issue) and seems to be running into some problem with its C toolchain. Some of the packages fail with "running gcc failed [...] cannot find ‘ld’…
Package [go/version](https://pkg.go.dev/go/version) is documented to operate on Go versions in Go toolchain name syntax, which is defined at https://go.dev/doc/toolchain#name as: > The standard Go t…
Note that the official Go distributions can be downloaded (following redirects) using URLs at https://go.dev/dl/, which follow the pattern `https://go.dev/dl/{file name}`. Attempting to download thos…
Yes, "getgo" was an experimental tool that was deprecated and removed in 2024, see Go proposal golang/go#60951. It should work to download (following redirects) using the URLs at https://go.dev/dl/, …
Our current Debian sid builders were last updated at a time when they were close to Debian Trixie's release, and their reported OS dimension value is "Debian-13". This prevents us from adding stable …
I started [crrev.com/i/8675857](https://crrev.com/i/8675857) to add internal configuration for the new Debian Trixie builder images, and ran into an issue that our current Debian sid builder reports …
dmitshur pushed to main in dmitri.shuralyov.com/service/change5mo
6140fdcb140798fe4fda313c57be133bf235e796maintner, gerritapi: handle draft status
ce8900dcd6898d396808d962fd777dcf7be445e9gerritapi: pass context to Gerrit calls
96ed021e15235cb4abcdaa86b88cc271e47f04c1add minimal go.mod
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)
dmitshur pushed to main in dmitri.shuralyov.com/scratch1y
5eb48b5f5d31d39777719edb35d37b724f183dc8quine: add load-bearing trailing space
dmitshur created package in dmitri.shuralyov.com/scratch/quine1y
LGTM. Thanks, and congrats on your first new Go package here! Done in PS 2. Patch set 2 seems to resolve this.
Thanks! If it's ready to be submitted from your side, I can do that now.
dmitshur pushed to main in dmitri.shuralyov.com/html/belt1y
d8009a3578d1be4dafb93e9ee4894d2bbd2b5e3badd OnClick field to CommitID
63f3644d8635396fd13789affe363ee9f693e8ecadd dark mode support in Reference
They are. Although Go can make them too easy via `go:embed`. See some initial comments. I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…
Thanks! Congrats on your first change. :D See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …
dmitshur pushed to main in dmitri.shuralyov.com/go/generated2y
e1de015411532fa144166aada4201ee443800425add test case with no final newline
6904a2a3d88d6c3ad39737a7c5bf226f5ebbd482modernize test code slightly
dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl2y
85de2813cf6bd8d6d2f0240fdebf943cbffc2b8afix "supportsFamily not found" warning on macOS 10.13 and 10.14
dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl2y
b78c9fe623cca0431d866c9e206d3f83665bcf8bdeprecate FeatureSet and Device.SupportsFeatureSet
2a3c46a829b92964146abf7f6c2d649cd66cce97add GPUFamily and Device.SupportsFamily
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …
dmitshur pushed to master in dmitri.shuralyov.com/service/change3y
67e22b2f18a260a33a98c6a7d601726a58c53767maintner: update for GitCommit API change
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now. Done in PS 3. I'm following the Go style for commit messages, which chooses…
Shortened 'golang.org' to 'go.dev' here, and on line 24.
dmitshur pushed to master in dmitri.shuralyov.com/website/gido4y
f460621dc784d8a8f3a1593a068115b62baf214dadd support for multiple comma-separated import path patterns
be77a538f6a64b287e073b59d1b9f7e1314cf3a9upgrade to go-git v5
b5ce3c19e6b977800ee3c80bc722192f96ef657breplace mention of godoc.org with pkg.go.dev
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl4y
28db891af037715d8c1deec7652485a173c60e25all: add darwin/arm64 (macOS) support
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y
d2c7b7eec450806980d4eefb626ccf6df2ef99dcupdate release branches to be for Go 1.15 and 1.14
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y
a78bd3c7abc465e1864ecadce67a826711a27caeadd support for "golang.org/x/pkgsite/..." issues
dmitshur pushed to master in dmitri.shuralyov.com/html/belt5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y
b7141fef43ec3cefbd93cc444ab1f27bdc0a7725add support for "golang.org/dl/..." issues
1fdfe09b78364e4305cfc7fec4b2888fac391bb3update release branches to be for Go 1.14 and 1.13
dmitshur pushed to master in dmitri.shuralyov.com/go/prefixtitle5y
500817462677553a6769e268d66193c36b423cd6add support for "golang.org/dl/..." issues
This is a valid issue, but the root cause analysis was incorrect. > This happens because they're added using the original paths, without checking that those paths correspond to any existing director…
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y
a42bf6b4ae5ef58ce39d0a7705047c345c800b98update release branches to be for Go 1.13 and 1.12
b36d6d3cb7ee809e6244a5f67a571a2d70f46b4aadd to openChanges and closedChanges when len(paths) == 0 && root != ""
8224e12ba9aea8d30dbeb643dca121cefec05726refactor code that populates issues and changes
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated: ```Go func initExistingDirectories() error { …
dmitshur pushed to master in dmitri.shuralyov.com/app/changes5y
e22f40b3687320a8bfbc863f27da771ed17d7b05assets: regenerate after "Sign in with URL" change
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl6y
d42048ed14fdc83bd0e48f4b2a5e13c593e88cb6link to CoreGraphics framework
11308bd612348edeca0d8fddca07bc5a4dfbb35cexample/movingtriangle/internal/{ns,ca}: rename to appkit, coreanim
9364696d8c28dc804dcd7e099f0b7c6cb58ac824example/movingtriangle: remove unsafe.Unsafe conversion
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl6y
fec1b7b612ab0b81aa1d8b5c9a58c795f94fd767example/movingtriangle: update to GLFW v3.3
dmitshur pushed to master in dmitri.shuralyov.com/service/change6y
1161aef33b4aafec8f04c40d9863324a08f5c912gerritapi: display reviewer requests and removals
957083f7751c871f1d6ddba48c392eb3836786d8gerritapi: sort inline comments
813ec28aab09112bc09eecb553884b7aa962e696add LICENSE file
dmitshur pushed to master in dmitri.shuralyov.com/text/kebabcase6y
dmitshur pushed to master in dmitri.shuralyov.com/route/gerrit6y
dmitshur pushed to master in dmitri.shuralyov.com/state6y
dmitshur pushed to master in dmitri.shuralyov.com/scratch6y
dmitshur pushed to master in dmitri.shuralyov.com/app/changes6y
dmitshur pushed to master in dmitri.shuralyov.com/route/github6y
dmitshur pushed to master in dmitri.shuralyov.com/html/belt6y
dmitshur pushed to master in dmitri.shuralyov.com/route/github6y
7e79d56078638d1d7d4d6853af037d67de3f9589add IssueEventURL and PullRequestEventURL to Router
dmitshur pushed to master in dmitri.shuralyov.com/service/change6y
011d2fcff0d76baa0352ecae474a802553b46c52githubapi: omit states argument for "all" filter
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.