Activity
Today
dmitshur reviewed +2 on Revert "runtime: disable test for 78081"44m
Thanks.dmitshur commented on runtime: disable test for 780811h
Sounds good, thanks.dmitshur commented on spec: predeclared types are named, not defined types2h
TryBots did pass on patch set 1, and patch set 2 was a rebase. The result failed only because the rebase interrupted the trybots that started running. So, adding a bypass.dmitshur reviewed +2 on runtime: disable test for 780812h
Since trybots are passing at CL 757343, could it work okay to add TryBot-Bypass to CL 757342 and let them both submit, and then you don't need this CL? Or is the goal of this CL to avoid having a fai…dmitshur reviewed +2 on golang.org/x/benchmarks/x/benchmarks: add a sweet benchmark for distribution size2h
I'm not very familiar with the APIs and conventions of x/benchmarks; @mpratt@google.com or @drchase@google.com might have more useful review comments or suggestions.
That said, this seems reasonable…dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies failures during migration to pkgbits.V33h
dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies failures during migration to pkgbits.V33h
dmitshur commented on all: update to x/tools@5d7afbc08aec5h
Thanks.dmitshur reopened an issue internal/cpu: support windows/arm645h
Reopening this issue because [CL 740880](https://go.dev/cl/740880) was rolled back ([CL 757482](https://go.dev/cl/757482)).
Adding an import of golang.org/x/sys/windows inside the golang.org/x/sys/c…dmitshur reopened an issue internal/cpu: support windows/arm645h
Reopening this issue because [CL 740880](https://go.dev/cl/740880) was rolled back ([CL 757482](https://go.dev/cl/757482)).
Adding an import of golang.org/x/sys/windows inside the golang.org/x/sys/c…dmitshur commented on golang.org/x/sys/cpu: use IsProcessorFeaturePresent to calculate ARM64 on windows6h
This change unfortunately needed to be rolled back in CL 757482. I'll reopen #76791 for applying it again or other followup.dmitshur commented on all: update to x/tools@5d7afbc08aec6h
(1 comment)
Done in PS 3.dmitshur commented on golang.org/x/sys/cpu: roll back "use IsProcessorFeaturePresent to calculate ARM64 on windows"6h
Thanks. I'll reopen #76791 afterwards for the follow up.
To be clear, the discussion that happens may conclude that we should permit x/sys/cpu to import x/sys/windows, and then this exact same CL ca…dmitshur commented on go/build: latest version of x/sys/cpu is incompatible with dependency policy in the standard library6h
CC @golang/runtime, @golang/windows.dmitshur commented on all: update to x/tools@5d7afbc08aec6h
(2 comments)
It does seem that we may be very close to removing all remaining uses of bundle here, but at this moment it's still used in [3 places](https://cs.opensource.google/search?q=%22%2F%2Fgo:…dmitshur opened a change golang.org/x/sys/cpu: roll back "use IsProcessorFeaturePresent to calculate ARM64 on windows"6h
Roll back CL 740880 (commit fc646e489fd944b6f77d327ab77f1a4bab81d5ad)
because it adds a golang.org/x/sys/windows import to the cpu package.
The cpu package is vendored into the main Go tree and the p…dmitshur opened an issue go/build: latest version of x/sys/cpu is incompatible with dependency policy in the standard library7h
Currently at tip, the only package from x/sys vendored into the std module of the main Go repo is [x/sys/cpu](https://cs.opensource.google/go/go/+/master:src/vendor/modules.txt;l=19-20;drc=ca5ffe0092…dmitshur commented on cmd/internal/moddeps: TestAllDependencies/std(thorough) failures7h
[CL 757520](https://go.dev/cl/757520) will fix this.dmitshur opened a change all: update to x/tools@5d7afbc08aec8h
Pull in CL 757060 to get x/tools/cmd/bundle working again.
For #36905.
For #9859.
[git-generate]
cd src/cmd
go get golang.org/x/tools@v0.43.1-0.20260319213245-5d7afbc08aec # CL 757060
go mod tidy
…dmitshur opened a change golang.org/x/build/main.star: add x/website presubmit builder for all of GOROOT/doc8h
The GOROOT/doc directory contains a few HTML and Markdown files like
godebug.md, go_spec, asm.html and such. CL 746740 updates TestAll in
x/website to test the files in GOROOT/doc directory too. Upda…dmitshur fixed an issue golang.org/x/playground: error communicating with remote server on 2026-03-209h
That particular version of the 1.26 playground backend got into an unhealthy state for reasons that aren't yet understood. Since this is the first occurrence of this specific failure mode for the pla…dmitshur commented on golang.org/x/playground: error communicating with remote server on 2026-03-209h
That particular version of the 1.26 playground backend got into an unhealthy state for reasons that aren't yet understood. Since this is the first occurrence of this specific failure mode for the pla…dmitshur commented on golang.org/x/website/cmd/golangorg: catch instances of bad escaping due to template use9h
(1 comment)
This change is ready for review.
That CL landed so tip builders should pass now. I expect the 1.26/1.25 builders to still run into this until CL 757420 and CL 757421 land, but otherwise…dmitshur opened a change doc: [release-branch.go1.25] remove template use in godebug.md10h
This file used to be implicitly a template prior to CL 733500, but now
it's no longer a template. The only template use here can be trivially
expressed with pure Markdown syntax, so do that. (The alt…dmitshur opened a change doc: [release-branch.go1.26] remove template use in godebug.md10h
This file used to be implicitly a template prior to CL 733500, but now
it's no longer a template. The only template use here can be trivially
expressed with pure Markdown syntax, so do that. (The alt…dmitshur commented on doc: go.dev/doc/godebug page contains "{{raw" due to misconfigured template use10h
The fix is visible at https://tip.golang.org/doc/godebug now, but not yet at https://go.dev/doc/godebug. We still need to backport it, since go.dev serves content from a stable release branch. This i…dmitshur commented on golang.org/x/playground: error communicating with remote server on 2026-03-2011h
The immediate problem should be resolved. Thanks @dolmen for confirming.
I'll keep this issue open for some time since we're still looking more into what happened and what we can do to reduce chance…dmitshur commented on golang.org/x/playground: Error communicating with remote server11h
Thanks for reporting this. We're working on resolving this, and will update this issue once this is fixed.
As the original issue noted, "Go 1.25 and gotip backends are working at the moment.", so as…Yesterday
dmitshur commented on golang.org/x/crypto/ssh: respect signer's algorithm preference in pickSignatureAlgorithm1d
(1 comment)
Yes, fixing a bug doesn't need a proposal. It sounds like you should either update #746020 to describe the bug instead of the original proposal, or if the original proposal should still …dmitshur reviewed +2 on test/convert5: [release-branch.go1.26] skip mipsle1d
By now the builder is passing at tip, 1.25 release branch, x/ repos (all but x/tools), leaving 1.26 with only this test failure: https://ci.chromium.org/ui/p/golang/g/port-linux-mipsle/builders. Back…dmitshur commented on runtime: segmentation violation when debug and using race detector [1.26 backport]1d
Perhaps it could help to also include the test-only follow up in [CL 756780](https://go.dev/cl/756780).dmitshur commented on golang.org/x/build/maintner: add TrackGitHub method variant taking an oauth2.TokenSource1d
(1 comment)
Makes sense.
> seems like it!
To an extent. :) Issue #37603 is still applicable today. For instance, it's taken me a while to find time to review CL 726080 partly because managing risk…dmitshur commented on golang.org/x/build/maintner: migrate to bartventer/httpcache1d
(3 comments)
Will this work as is, or does this package also need to import `github.com/bartventer/httpcache/store/memcache` for side-effect or registering that store?
Reviewed the new dependency b…dmitshur reviewed +1 on debug/buildinfo: remove macho/elf DataStart fallback code1d
This generally looks good to me, leaving +1 so that Cherry can also look.
A side note: if you'd like, URLs like this can be shortened by using Go website's newer domain, such as go.dev/cl/173343. (T…dmitshur commented on golang.org/x/build: publish Go source code releases to the Checksum Database1d
Thanks for filing this feature request.
As background context, the golang.org/toolchain modules exist primarily to serve the internal needs of the cmd/go command and its https://go.dev/doc/toolchain…dmitshur reviewed +2 on cmd/go: make all script tests parallel1d
Thanks.
I understand the new state is that testsuite no longer supports testdata at all, since it doesn't support serial test execution at all anymore. The old phrasing in this Fatal message seems a…dmitshur commented on cmd/distpack: add a test on distribution size1d
Thanks for working on this. I left some high level comments to get your feedback; that said, please let me know if you'd find it useful to consider them out of scope for this issue/CL, and instead ai…This Week
dmitshur commented on doc: remove template use in godebug.md2d
Thanks.dmitshur commented on doc: fix 2 links in godebug.md2d
Thanks.
Done.dmitshur commented on doc: document the gotypesalias removal2d
(1 comment)
I think the intent here was to use markdown link syntax, which is `[text](url)`. [a][b] shows up as is, visible at https://tip.golang.org/doc/godebug#go-127. Sent CL 756580.dmitshur opened a change doc: fix 2 links in godebug.md2d
For #76349.dmitshur opened a change doc: remove template use in godebug.md2d
This file used to be implicitly a template prior to CL 733500, but now
it's no longer a template. The only template use here can be trivially
expressed with pure Markdown syntax, so do that. (The alt…dmitshur opened an issue doc: go.dev/doc/godebug page contains "{{raw" due to misconfigured template use2d
The https://go.dev/doc/godebug page has some unintended template use showing up:
<img width="481" height="37" alt="Image" src="https://github.com/user-attachments/assets/a052c838-6947-44bd-870f-9a5a…dmitshur opened a change golang.org/x/website/cmd/golangorg: support absolute paths in testTree2d
The use of strings.TrimPrefix on filepath.ToSlash output works on all
OSes when testTree is given a relative path like "../../_content",
but it doesn't work on Windows if testTree is given an absolut…dmitshur commented on golang.org/x/build/maintner: add TrackGitHub method variant taking an oauth2.TokenSource2d
(1 comment)
Can the potential latency be dealt with by wrapping with something like [oauth2.ReuseTokenSource](https://pkg.go.dev/golang.org/x/oauth2#ReuseTokenSource)?dmitshur reviewed +2 on golang.org/x/build/maintner: add TrackGitHub method variant taking an oauth2.TokenSource2d
Thanks.
I think we could start using `tok.SetAuthHeader(req)` here now that there's an `oauth2.Token`, if you want. But this should be equivalent at least for today's needs, so either way is fine. (…dmitshur commented on runtime: Windows crash with Go 1.26.0, 1.26.1 [1.26 backport]2d
Moving Critical label to [the upstream issue](https://github.com/golang/go/issues/77975#event-23683617381).dmitshur closed an issue golang.org/x/net/http2: TestTransportFailureErrorForHTTP1Response/with_enough_frame_size_to_start_reading failures3d
Merged into #72981.dmitshur commented on cmd/go/internal/verylongtest: check MustHaveGoBuild in TestGoBuildUmask3d
misccompile builder failure looks like #78081. It also passed in a [previous attempt](https://ci.chromium.org/b/8687137151622998929) on the same patch set. Importantly, noopt ran and passed. Bypassin…dmitshur commented on cmd/go/internal/test: enable stdversion by default3d
(1 comment)
@sean@liao.dev This seems like a change that should be in the release notes, right? If you don't mind, please add a note for it here. Thanks.dmitshur commented on golang.org/x/build/{influx,perf}: build Docker images via Cloud Build instead of local Docker3d
Thanks.dmitshur commented on golang.org/x/build/influx: move influx command to x/build/cmd/influx3d
Thanks.dmitshur commented on golang.org/x/build/perf: move perf command to x/build/cmd/perf3d
Thanks.dmitshur commented on : make `go test -buildmode=c-archive/c-shared` useful4d
@ethanmontgomery148-hub Please see https://go.dev/wiki/NoPlusOne. You've also left a lot of comments on other Go issues recently. Please be aware of the [Go Code of Conduct](https://go.dev/conduct), …Last Week
dmitshur commented on golang.org/x/benchmarks: add a benchmark for distribution size1w
@cherrymui, @prattmic Do you recall if there were plans (or maybe existing work) to incorporate binary size tracking into the performance dashboard or so? Adding a test in the main tree (as done in […dmitshur closed an issue golang.org/x/telemetry/cmd/gotelemetry/internal/view: unrecognized failures1w
dmitshur closed an issue golang.org/x/build/buildenv: unrecognized failures1w
dmitshur closed an issue golang.org/x/tools/benchmark/parse: unrecognized failures1w
dmitshur closed an issue golang.org/x/telemetry/cmd/stacks: unrecognized failures1w
dmitshur closed an issue cmd/go: go mod init wrong version1w
dmitshur closed an issue cmd/go: TestScript/version_build_settings failures1w
dmitshur commented on cmd/link: set darwin LC_BUILD_VERSION SDK version field higher by default1w
CC @golang/darwin.Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change10modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…