Activity
Today
dmitshur commented on cmd/internal/testdir: do not fail fast when running asmcheck2h
Yes, in general purple failures are due to something going wrong with the infrastructure, rather than a problem found in the CL. See https://go.dev/wiki/LUCI#infra-failed--purple-failure.
There was …dmitshur reviewed +2 on all: update to x/tools@b36d1d12a1a724eb9be6609c9789aec3d99e60302h
Thanks.dmitshur commented on crypto/internal/fips140/mldsa: add accumulated field functions test3h
(1 comment)
A style question: it seems in this case the code would compile both if expected is a variable (as is now) and if it's changed to a `const`. Is there a reason to prefer a variable here ev…Yesterday
dmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: PostEmptyEvent crashes if called first on non-main thread on macOS1d
The upstream GLFW issue https://github.com/glfw/glfw/issues/1649 was resolved in GLFW 3.4, and we now have v3.4/glfw package offering that version as of PR #414.
I've re-tested the original report, …dmitshur fixed an issue github.com/go-gl/glfw: v3.4 and supporting GLFW_MOUSE_PASSTHROUGH1d
dmitshur fixed an issue github.com/go-gl/glfw: v3.4 and supporting GLFW_MOUSE_PASSTHROUGH1d
The `MousePassthrough` hint was added in PR #414, and should be available now:
https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw#MousePassthrough
Closing as done in commit 8479a9b4422aab8f9d581ef4…dmitshur commented on github.com/go-gl/glfw: v3.4 and supporting GLFW_MOUSE_PASSTHROUGH1d
The `MousePassthrough` hint was added in PR #414, and should be available now:
https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw#MousePassthrough
Closing as done in commit 8479a9b4422aab8f9d581ef4…dmitshur commented on github.com/go-gl/glfw/README.md: remove -u flag from go get1d
Thanks.dmitshur merged a change github.com/go-gl/glfw/README.md: remove -u flag from go get1d
dmitshur opened a change github.com/go-gl/glfw/README.md: remove -u flag from go get1d
The -u flag was needed back in GOPATH mode to reliably fetch the latest version of the target package and its dependencies. There's no need for it in module mode, since the default [version query](ht…dmitshur created branch in github.com/go-gl/glfw1d
go-get-no-udmitshur commented on github.com/go-gl/glfw: Consider adding release tags1d
Made the first pre-release tag as discussed above:
https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw?tab=versionsThis Week
dmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: add support for GLFW version 3.4 (and future 3.4.x versions)1d
dmitshur closed a change github.com/go-gl/glfw: GLFW v3.41d
dmitshur pushed to
master in github.com/go-gl/glfw1ddmitshur merged a change github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)1d
dmitshur commented on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)1d
Done in commit cc44bab941ad35dfd2c2c7e34ba6ffb21519d7e7.dmitshur commented on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)1d
Done in commit fb51f1547102b67bbc96e40e0ed733a125c2dc49.dmitshur pushed to
master in github.com/go-gl/glfw1ddmitshur pushed to
master in github.com/go-gl/glfw1ddmitshur commented on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)1d
Marking as resolved; this note isn't meant to be in scope of this PR.dmitshur reviewed +2 on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)1d
Thanks very much @alexballas for getting this PR prepared and addressing remaining comments that were left on PR #400. Thank you @Geo25rey for getting PR #400 very far.
I've reviewed and been testin…Last Week
dmitshur commented on golang.org/x/build/env/netbsd-amd64: update build VM to 10.12d
(1 comment)
Sounds good. I sent you CL 762720 to fix a broken symlink in the meantime. Tools that try to read all files in this repository (such as 'gcloud builds submit' used during the [deploy pro…dmitshur opened a change golang.org/x/build/env/netbsd-386: make anita-2.10.tar.gz.sha1 a plain file2d
A file containing the expected sha1 for anita-2.10.tar.gz in
the netbsd-386 directory was a symbolic link pointing to the
same file that the netbsd-amd64 directory used to have until
that file was de…dmitshur commented on path/filepath: clarify Dir and Clean documentation for Windows3d
(1 comment)
Thanks for preparing this change. Issue #77314 has now been fixed. Is there anything more to do here, or okay to close this?dmitshur commented on path/filepath: document Dir behavior for Windows volume-only paths4d
Thanks.dmitshur reviewed +2 on golang.org/x/vulndb/report: export minimal Report definition as required by Go Security Releasing5d
Thanks.dmitshur commented on github.com/go-gl/gl: Which version of GLES is supported?6d
CC @hackbar.dmitshur pushed to
master in github.com/go-gl/gl6ddmitshur merged a change github.com/go-gl/gl: Add support for gles2 3.2.6d
dmitshur reviewed +2 on github.com/go-gl/gl: Add support for gles2 3.2.6d
It would've been better to keep the change that re-generates everything with the latest glow and XML files as a separate PR from the change add the OpenGL ES 3.2 support. But they're separate commits…dmitshur commented on github.com/go-gl/gl/update: README.md6d
The change to document Fedora/RHEL-based system requirements seems reasonable. See an inline comment about the other change.
Let's not include this. It wouldn't compile anyway because it doesn't hav…dmitshur pushed to
master in github.com/go-gl/glow6ddmitshur merged a change github.com/go-gl/glow: Add support for OpenGLES 3.26d
dmitshur reviewed +2 on github.com/go-gl/glow: Add support for OpenGLES 3.26d
Thanks.dmitshur reviewed +2 on cmd/go/internal/doc: follow up to CL 7332006d
(1 comment)
You probably want to either rebase past CL 761620 or use trybot-bypass given the only failures are unrelated to this change.dmitshur reviewed +2 on cmd/go: add more go tool documentation and show tool aliases in go tool6d
Thanks.
I'd expect this to be noAlias per https://go.dev/s/style#mixed-caps. Or is it meant to be a single word?
Aside that, maybe it could work well to name the map 'ambiguous' or something like t…dmitshur commented on golang.org/x/build/cmd/golangbuild: update code search link1w
This change is ready for review.dmitshur opened a change golang.org/x/build/cmd/golangbuild: update code search link1w
The previous link is shorter, but it's no longer indexed. Point to the
new view to golangbuild source code where search indexing is available.dmitshur closed an issue build: build failure on x_vulndb-gotip-linux-amd64-race1w
dmitshur closed an issue build: build failure on x_net-gotip-linux-arm64_debian131w
dmitshur reviewed +2 on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions1w
Thanks.
I'll note that it's somewhat unclear how exactly values would be represented in some of the fields because they're not documented: for example, `Changelists []string` might be a slice of URL…dmitshur commented on go/types: [release-branch.go1.26] handle unconstrained type parameters correctly in a few places1w
The release branch is currently frozen until the [Go 1.26.2 release](https://groups.google.com/g/golang-announce/c/2UyQAnUQKwc) is complete, added a temporary Hold+1.dmitshur closed an issue build: build failure on x_net-gotip-linux-arm64_debian131w
dmitshur reviewed +2 on golang.org/x/website/_content: in managing dependencies doc '-u' flag and mention '-modfile'1w
Thanks.dmitshur commented on golang.org/x/build/cmd/relui: update to ltbsky v0.4.21w
Thanks.dmitshur commented on github.com/go-gl/glow: Add support for OpenGLES 3.21w
This generally looks reasonable, thanks for working on it.
Have you had a chance to try generating the gles bindings afterwards, and does the generated output seem okay? I think it'd be a matter o…dmitshur reviewed +2 on golang.org/x/website/ref/mod: add more documentation for 'go tool' features.1w
Thanks. Minor comments.
Nit, https://go.dev/doc/contribute#first_line suggests leaving out the period; the period is a part of the "This change modifies Go to _____." sentence being completed.
```s…dmitshur reviewed +2 on image/jpeg: reject RGB and non-standard chroma subsampling1w
Thanks.
```suggestion
add support for non-standard chroma subsampling ratios" (CL 738280).
```
So that it's easier to get to if desired. Gerrit linkifies such CL mentions, and it's also possible to…Earlier
dmitshur starred znkr.io/diff1w
dmitshur commented on test/codegen: fix ppc64x rldicl bit test1w
It was another test failing, rangegen.go. It might've just been unlucky, it happens fairly often based on its history: https://ci.chromium.org/ui/test/golang/cmd%2Finternal%2Ftestdir%3A6_10.Test%2Fra…dmitshur opened a change golang.org/x/build/cmd/relui: update to ltbsky v0.4.21w
Pull in https://github.com/fflewddur/ltbsky/pull/5.dmitshur commented on simd/archsimd: Load*SlicePart panics with "checkptr: converted pointer straddles multiple allocations"1w
CC @golang/compiler.dmitshur commented on cmd/fix: `go fix` inline producing conflicting var names1w
Thanks for the report.
CC @golang/tools-team.dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip1w
(1 comment)
This isn't right: the known issue should keep this an optional security trybot. Done in PS 2.dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip1w
Thanks.dmitshur commented on cmd/internal/testdir:1_10: Test/codegen/bits.go failures [consistent failure]1w
This consistent failure on ppc64 and loong64 is due to https://go-review.googlesource.com/c/go/+/750200/comments/58cbcdce_f20cfeba.
CC @Jorropo, @golang/ppc64, @golang/loong64.dmitshur commented on crypto: disallow RegisterHash with hash value 01w
(1 comment)
FWIW since its value is actually 20, I understand this means "just use its value by picking a value that's higher than maxHash by some reasonable margin so that it'll be some time before…dmitshur reviewed +2 on cmd/go: specify full path to go command when running go tool covdata1w
Thanks.
Thanks for the clarification.dmitshur commented on crypto: disallow RegisterHash with hash value 01w
(1 comment)
Did something go wrong with your "gofmt-on-save"?dmitshur commented on cmd/go: specify full path to go command when running go tool covdata1w
(1 comment)
Or, maybe the problem being fixed is that once someone with an old toolchain upgrades _to_ 1.25.x or 1.26.x (via go.dev/doc/toolchain), this change (once backported to 1.25.x and 1.26.x)…dmitshur commented on cmd/go: specify full path to go command when running go tool covdata1w
(1 comment)
A question about this; I'm not sure I understood this sequence properly. In the issue comment you described the problem as affecting Go 1.24 and older toolchains upgrading to Go 1.25+. B…dmitshur opened a change golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip1w
Do keep a known issue for Go 1.26 and 1.25 release branches since
it doesn't work there yet (but may work soon).
For golang/go#74985.dmitshur reviewed +2 on golang.org/x/build/main.star: don't run newinliner builder by default in presubmit1w
Thanks.dmitshur reviewed +2 on debug/buildinfo: remove macho/elf DataStart fallback code1w
Thanks.
I think this is right. You can give some more time for another review since Cherry is more familiar with this code, up to you.dmitshur commented on cmd/link: use bfd ld 2.41+ on linux/arm64 instead of gold1w
net/smtp failures are likely #77504, so rebasing should resolve them.dmitshur commented on cmd/link: stop requiring gold on arm64 when GNU ld is fixed1w
@gopherbot Please consider backporting this issue (fixed by [CL 740480](https://go.dev/cl/740480) with a potential followup in [CL 747660](https://go.dev/cl/747660)). The linux/arm64 builder with Deb…dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue of simd builders1w
Thanks.
Sounds good. (It's possible to follow up in the unlikely case it does need attention.) Thanks for taking release branch into consideration when removing the known issue.dmitshur opened a change cmd/link: [release-branch.go1.25] use bfd ld 2.36+ on linux/arm64 instead of gold1w
The bfd linker has been fixed for a while. In the mean time gold got
deprecated and has stopped receiving new features. Add runtime version
checking and only use gold, if bfd ld 2.35 and lower is det…dmitshur commented on golang.org/x/build: add Debian Trixie builders1w
That problem was tracked in #22040, and [CL 740480](https://go.dev/cl/740480) resolved it. The [linux-arm64_debian13](https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-arm64_debian13) is no…dmitshur commented on runtime/race: TestOutput failures1w
A race reported during this test's execution. The test has otherwise been passing without reported races.
CC @golang/runtime.dmitshur commented on internal/godebugs: TestAll failures1w
It looks like the internal/godebugs package tests often come quite close to the 6 minute timeout, e.g., past runs have taken 325.885s and similar. And in this case it went over the time limit, causin…dmitshur commented on cmd/go: test failure due to unexpected telemetry files left behind in temporary directory1w
This looks similar to #55260, but in this case it is some telemetry files being left behind. So far only happened once on a linux-ppc64le builder.
CC @golang/command-line.dmitshur fixed an issue cmd/go: test failure due to unexpected vcstest files left behind in temporary directory1w
There haven't been any matches since 2023, so perhaps this is fixed by various cmd/go test refactoring. There is a new instance in #78397 but it's related to telemetry files rather than vcstest files…dmitshur commented on golang.org/x/sys/windows: GetNamedSecurityInfo crashes when GetNamedSecurityInfoW succeeds with NULL SECURITY_DESCRIPTOR1w
CC @golang/windows.dmitshur commented on cmd/compile: register allocation differs based on tail loop presence, affects performance1w
CC @golang/compiler.dmitshur commented on syscall: TestPidFD failures1w
This test timed out running for 323 seconds.
From looking at this [test history](https://ci.chromium.org/ui/test/golang/syscall.TestPidFD), it's almost always passing and usually takes something lik…dmitshur commented on cmd/compile: fallthrough prevents the elimination of some bounds checks1w
CC @golang/compiler.dmitshur commented on net/http: how to utilize sendfile() when send request via NewRequestWithContext1w
If this is a question, please see http://go.dev/wiki/Questions for places that are better suited for asking questions. The Go issue tracker is used for bugs, feature requests, optimization issues.
D…dmitshur commented on cmd/compile: channel operations require but do not use a type dictionary1w
CC @golang/compiler.dmitshur commented on cmd/compile: loop induction with `*` and `<<` induction operators1w
CC @golang/compiler.dmitshur commented on cmd/compile: closures in generic functions capture type dictionaries unconditionally1w
CC @golang/compiler.dmitshur commented on archive/zip: provide way to limit number of entries in an archive1w
CC @dsnet, @bradfitz.dmitshur commented on gccgo: internal compiler error in flatten_append on undefined variable in slice of append argument1w
CC @ianlancetaylor, @thanm, @cherrymui.dmitshur commented on gccgo: Compiler Segfault on non-integer argument to make of channel1w
CC @ianlancetaylor, @thanm, @cherrymui.dmitshur commented on cmd/compile: constant-string doubling plus []rune conversion can exhaust memory1w
CC @golang/compiler.dmitshur reviewed +2 on golang.org/x/build/main.star: add linux-amd64 SIMD builders1w
Thanks.dmitshur commented on govulncheck-action: Release current master to have tagged version utilizing the full commit SHAs of transitive actions1w
CC @golang/vulndb, @catzkorn, @lufia.dmitshur commented on os: running "go test os -short" command fails1w
CC @golang/windows, @ianlancetaylor.dmitshur commented on os/user: GroupIds fails when a member of more than 256 groups on macOS1w
CC @golang/darwin, @bradfitz, @kevinburke.dmitshur commented on golang.org/x/build/cmd/watchflakes: stop applying NeedsInvestigation label1w
This change is deployed now.dmitshur commented on build: build failure on x_vulndb-gotip-linux-amd64-race1w
Something went wrong with the builder infrastructure in this instance. The x/vulndb tests passed, but the task log failed at the end with:
```
RPC failed permanently: rpc error: code = DeadlineExcee…dmitshur closed a change math/big: [release-branch.go1.26] Improve performance of modular exponentiation, particularly for medium-sized inputs.1w
Release branches are used for backport CLs (https://go.dev/wiki/MinorReleases). Closing in favor of CL 751120, which is the same change that targets the main development branch.dmitshur closed a change net/url: [release-branch.go1.26] permit colons in the host subcomponent of non-http/https URLs1w
Replaced with CL 759662.dmitshur commented on net/url: [release-branch.go1.26] permit colons in the host subcomponent of non-http/https URLs1w
This change is ready for review.dmitshur commented on runtime/race: [release-branch.go1.26] apply LLVM zero-initialization fix1w
It seems ready now, so dropping hold.