Activity
Today
dmitshur opened an issue golang.org/x/build/cmd/relui: add support for making release announcement posts on Bluesky5m
During Go releases, relui takes on posting on 2 social sites using their APIs (#47403 and #65046). By now we have an account on one more social site, Bluesky, where we've also started to post links t…dmitshur commented on golang.org/x/build: catch problems in x/ repos gated by module go directive version sooner25m
Looks real; it reproduces consistently with go1.24rc2 darwin/arm64. Glad to see it paying off already!
<details>
```
tools $ go test -count=1 ./cmd/signature-fuzzer/internal/fuzz-generator
ok go…dmitshur reviewed +2 on golang.org/x/build/main.star: add tiplang builders1h
Woohoo! Thanks.Yesterday
dmitshur fixed an issue crypto/x509: usage of IPv6 zone IDs can bypass URI name constraints [CVE-2024-45341] [1.24 backport]1d
dmitshur closed an issue net: MPTCP support is not enabled when apps use `ListenTCP()` or `DialTCP()` [1.22 backport]1d
dmitshur closed an issue net: MPTCP support is not enabled when apps use `ListenTCP()` or `DialTCP()` [1.23 backport]1d
dmitshur commented on golang.org/x/build/main.star: stop setting GODEBUG=gotestjsonbuildtext=1 everywhere1d
Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes: add some script parsing tests1d
Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes/internal/script: lex !~ as a single token1d
Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes/internal/script: lex !~ as a single token1d
(1 comment)
Good idea, thanks. Added one for the error of using " instead of ` as required for regexp strings (in parent CL).This Week
dmitshur commented on golang.org/x/build/main.star: stop setting GODEBUG=gotestjsonbuildtext=1 in x/build2d
(1 comment)
It's rolled out now.
(A recent build has `Resolved package infra/tools/result_adapter/linux-amd64@latest => infra/tools/result_adapter/linux-amd64:qPfY22T0cvfxSwiUQo6e8ibkCvkiWMXfL3u-cm…dmitshur commented on golang.org/x/build/cmd/golangbuild: update result_adapter to handle Go 1.24's go test -json output2d
[crrev.com/c/6174231](https://crrev.com/c/6174231) updates result_adapter with better support for Go 1.24 structured build events.
After that's in, we can stop setting GODEBUG=gotestjsonbuildtext=1 …dmitshur opened a change golang.org/x/build/main.star: stop setting GODEBUG=gotestjsonbuildtext=1 in x/build2d
As part of a gradual rollout, apply the change to one repo first.
DO NOT SUBMIT until result_adapter is updated. (Fine to review now.)
For golang/go#70435.dmitshur commented on golang.org/x/playground/Revert "go.mod: update golang.org/x dependencies"2d
(1 comment)
This is not a clear reason for reverting a CL.
@aungko.use@gmail.com Please see https://go.dev/conduct#values. One of the values there is to be constructive. You've been asked not to se…dmitshur commented on golang.org/x/pkgsite/devtools/cmd/seeddb: apply -keep_going to versions check3d
(1 comment)
There used to be an err != nil check here, but the new code drops it in favor of unconditionally appending to errors or returning to caller. That doesn't seem to be intentended, and it s…dmitshur reviewed +2 on golang.org/x/build/main.star: set GOEXPERIMENT=synctest for x/net builders testing >=go1.243d
Thanks.
```suggestion
# of experiment names. Merge them. See https://pkg.go.dev/internal/goexperiment.
```
```suggestion
# Set GOEXPERIMENT=synctest in x/net for go1.24 and above.
`…dmitshur reviewed +2 on cmd/api: report error in test instead of crashing3d
(2 comments)
Thanks. Since you added Auto-Submit+1 to PS 4, I'll apply it to PS 5 too.
Interesting, thanks. I would've thought "unnecessary else" wouldn't apply since this code is still checking th…dmitshur reviewed +2 on cmd/api: report error in test instead of crashing3d
Thanks.
This paragraph should be taken out now, right?
(nit) These could be joined with `} else if err != nil {` since both if statements are handling the error returned from w.import_. But both wa…dmitshur commented on golang.org/x/tools/gopls/internal/telemetry/cmd/stacks: don't forward GOEXPERIMENT from env3d
Thanks.dmitshur reviewed +2 on cmd/api: report error in test instead of crashing3d
Thanks for improving the error reporting.
It's making it apparent that something in cmd/api's BenchmarkAll is going wrong when it's executed with `GOEXPERIMENT=synctest go test -count=1 -bench=. cmd…dmitshur commented on golang.org/x/tools/gopls/internal/telemetry/cmd/stacks: don't forward GOEXPERIMENT from env3d
(1 comment)
I considered that if the original GOEXPERIMENT value was available, it could be reused during the build. But as I understand it's not available, so no choice.dmitshur commented on golang.org/x/tools/gopls/internal/telemetry/cmd/stacks: add cmd/compile support to readPCLineTable3d
(1 comment)
Just wondering, is it possible to do `go install {subrepo path}@{version}` and skip the checkout? I could understand that the checkout would be needed if attempting to build non-released…dmitshur opened a change golang.org/x/tools/gopls/internal/telemetry/cmd/stacks: don't forward GOEXPERIMENT from env3d
The test being executed may have some GOEXPERIMENT set. When invoking
another go toolchain, since GOTOOLCHAIN is set to a different version
that might be older and not support the same GOEXPERIMENT v…dmitshur commented on doc: write release notes for Go 1.244d
@andig The `go help get` text describes the `go get` command and provides help on using it, but it doesn't attempt to provide complete coverage for all details. For that, it refers the reader to refe…dmitshur reviewed +2 on golang.org/x/build/main.star: set GOEXPERIMENT=synctest for builders testing >=go1.244d
Thanks.
FWIW it's not a question of "if"; there are already around 5 runmods that set GOEXPERIMENT.
Missed `["env"]`?dmitshur commented on golang.org/x/build: catch problems in x/ repos gated by module go directive version sooner4d
Yeah, determining it automatically without configuration, like for perf builders, sounds good. (If we later on realize we want more flexibility for some reason, we can add that flexibility afterwards…dmitshur commented on archive/zip: AddFS omits trailing slash in directory names5d
CC @songgao, @ianlancetaylor.Last Week
dmitshur commented on crypto/internal/fips140test: add hmac DRBG ACVP tests1w
Please note, while https://go.dev/s/release#may--november-week-4-release-freeze-begins says "During the freeze, only bug fixes, test-only changes, and doc updates are accepted.", we're now at https:/…dmitshur reviewed +2 on go.dev/wiki/Gardening: exclude Telemetry-Proposal from general issue triage1w
Thanks.dmitshur reviewed +2 on all: [release-branch.go1.24] merge master (9a44df6) into release-branch.go1.241w
Phew, that's a lot of CLs – I went over them quickly to check that they were making changes in scope of the release freeze and that there wasn't something accidentally submitted despite being clear…dmitshur reviewed +2 on cmd/go/testdata/script: fix TestScript/env_gocacheprog on Windows1w
Thanks.dmitshur commented on all: [release-branch.go1.24] merge master (f025d19) into release-branch.go1.241w
windows-amd64-longtest will likely fail - cmd/go.TestScript/env_gocacheprog seems to be failing consistently on the main branch starting with CL 640755 (FYI @matloob@golang.org).dmitshur reviewed +2 on internal/sync: fix typo of panic message1w
Thanks.dmitshur commented on golang.org/x/tools/internal/analysisinternal: check for interface recievers1w
(1 comment)
NP. If you wish to look this up again in the future, it's documented in detail at https://go.dev/wiki/SlowBots#using-slowbots as the "Blocking" way.dmitshur reviewed +2 on golang.org/x/website/_content/blog: update my surname1w
Whenver a CL is ready from your side, please comment and/or add it to the [attention set](https://gerrit-review.googlesource.com/Documentation/user-attention-set.html) of whoever left the +2 to submi…dmitshur reviewed +2 on golang.org/x/website/_content/blog: Update my surname.1w
Thanks. A minor nit for the commit message style.
```suggestion
_content/blog: update my surname
```
See https://go.dev/wiki/CommitMessage.dmitshur commented on golang.org/x/tools/internal/analysisinternal: check for interface recievers1w
(1 comment)
Since the test runs only on longtest builders, consider making at least one required (rather than optional) to pass:
```suggestion
Change-Id: I4f0542f2f9495cc373ad2d772736152b29dcc254
C…dmitshur commented on golang.org/x/tools/go/packages: run TestIssue70394 with Go 1.231w
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/gomoteserver: add configuration for GTS certificates1w
LGTM but note that I'm not closely familiar with these values. Thanks.dmitshur commented on golang.org/x/pkgsite/devtools/cmd/seeddb: -keep_going through version list errors1w
Note that the module proxy protocol specification (https://go.dev/ref/mod#goproxy-protocol) is clear about expected HTTP status codes:
> Successful HTTP responses must have the status code 200 (OK…dmitshur commented on golang.org/x/pkgsite/internal/proxy: clean versions returned with spaces1w
(2 comments)
The specification for the /@v/list at https://go.dev/ref/mod#goproxy-protocol says it's a list of known versions of the given module in plain text, one per line. It doesn't say anything…dmitshur commented on cmd/internal: add hash package1w
In case you haven't already seen it, the commit message of the next CL in the stack (CL 610596) has what appears to be the most complete description of the motivation, also mentioning two relevant is…dmitshur commented on cmd/go: clarify GODEBUG in go help environment1w
(1 comment)
(nit) On line 517 below, this sentence is also used and it's almost identical, except the word "with" is used here and "using" there. Maybe it'd be nicer not to make these two sentences …dmitshur commented on golang.org/x/tools/go/analysis/passes/framepointer: only stop on unconditional branches1w
(1 comment)
Is this comment for arm64Branch still up to date after the deletions below?dmitshur commented on golang.org/x/pkgsite/go.mod: update golang.org/x dependencies1w
kokoro rerunEarlier
dmitshur commented on golang.org/x/tools/go/packages: Load does not respect Go version consistently1w
@StevenACoffman What you’re describing may not necessarily be the same issue. This issue seems to be about inconsistency in go version used when “go1.N.M” binaries are used to run vs to build G…dmitshur commented on golang.org/x/build/cmd/watchflakes/internal/script: lex !~ as a single token1w
(1 comment)
Done in CL 640295.dmitshur opened a change golang.org/x/build/cmd/watchflakes: add some script parsing tests1w
Watchflakes so far had no tests at all. As part of fixing a bug in the
script parser, add some. The tests were based on test coverage present
in the go/build/constraint package (which parses a simila…dmitshur opened an issue golang.org/x/build/cmd/watchflakes: fails to parse the "!~" operator1w
Both of these scripts should parse successfully:
```
default <- pkg == "cmd/go" && output ~ `some regexp`
default <- pkg == "cmd/go" && output !~ `some regexp`
```
Yet the latter doesn't, pr…dmitshur commented on cmd/go: TestScript failures1w
@thepudds Thanks for looking at this too, and suggesting that workaround. I'll use it for now.
I should've posted a comment here sooner, but I think I followed a similar path and ended up with [CL…dmitshur commented on golang.org/x/build/cmd/watchflakes/internal/script: lex !~ as a single token1w
Thanks. I didn't find problems in quick testing, but I'll do a bit more before submitting next week. Hold for that.
I'll see what I can do next week.dmitshur opened a change golang.org/x/build/cmd/watchflakes/internal/script: lex !~ as a single token1w
Even though both ~ and !~ operators are documented as supported at
https://go.dev/wiki/Watchflakes, it seems only the former was ever
supported in practice. As it was uncovered when I tried the latte…dmitshur commented on golang.org/x/website: vulnerability GHSA-3xgq-45jj-v275/CVE-2024-21538 in cross-spawn dependency version 7.0.31w
I see it's a dependency in some of the golang.org/x repos:
https://cs.opensource.google/search?q=%22cross-spawn%22%20%227.0.3%22&ss=godmitshur commented on golang.org/x/website: vulnerability GHSA-3xgq-45jj-v275/CVE-2024-21538 in cross-spawn dependency version 7.0.31w
This is the issue tracker for the Go project. What is "cross-spawn" in your report? If it's referring to https://www.npmjs.com/package/cross-spawn, the issue tracker for that seems to be https://gith…dmitshur commented on golang.org/x/build: add LUCI openbsd-riscv64 builder1w
Okay, let's update the LUCI bot's coverage to match the previous one, then. I'll work on a CL for that.dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.61w
For the 386/amd64 builders that we run as VMs in GCE, this will first need to go through a process similar to what was recently done in #61095 (e.g., see [CL 616836](https://go.dev/cl/616836) which a…dmitshur commented on cmd/compile: gotypesalias=1 does not seem to get used correctly for deps on Go 1.231w
The Go 1.23 backport is tracked in another issue, Go 1.24 is already fixed, and I sent [CL 640017](https://go.dev/cl/640017) to remove the 1.23 skip in the x/tools test. @timothy-king Is there anythi…dmitshur commented on crypto/tls: TestVerifyConnection/TLSv12 failures [1.23 backport]1w
I tried creating backports, but there are some merge conflicts. @FiloSottile If you don't mind and have a chance, perhaps it's easier for you to resolve them and send the CLs for review. Thanks.
(…dmitshur opened a change golang.org/x/tools/go/packages: run TestIssue70394 with Go 1.232w
It's expected to pass now that the CL 631855 cherry-pick is submitted.
Also apply gofmt after CL 637961 while here.
For golang/go#70394.dmitshur commented on log/slog: Custom Handler breaks when using With() and loses parent attributes2w
CC @jba.dmitshur commented on cmd/go: "cannot access the file because it is being used by another process" flakes on Windows2w
> AFAICT, there is no tracking issue, just a sea of TestScript testflakes issues, with this specific message showing up about 3 weeks ago in #66337, which has a catch-all pkg == "cmd/go" && test == "…dmitshur commented on golang.org/x/build/cmd/gerritbot: adjust suggestions for wiki repo2w
Thank you @thepudds! That change is deployed now. Happy New Year to you as well!dmitshur commented on : proxy.golang.org 403 forbidden much like #481072w
CC @samthanawalla, @findleyr, @hyangah.dmitshur opened an issue github.com/nondebug/gamepad-explorer: Handling vibrationActuator field being null (instead of undefined)2w
Hello, thanks for offering this page.
The current code has some checks whether a gamepad's vibrationActuator field is undefined.
I've observed cases¹ where a gamepad's vibrationActuator field …dmitshur closed an issue cmd/cgo/internal/testsanitizers: TestTSAN/tsan13 failures2w
Merging into #67800.dmitshur commented on golang.org/x/net/route: ParseRIB fail to parse utun up InterfaceMessage2w
CC @neild, @ianlancetaylor.dmitshur commented on golang.org/x/crypto/ssh: `ParseRawPrivateKey` should return `PassphraseMissingError` for `ENCRYPTED PRIVATE KEY`2w
CC @drakkan, @golang/security.dmitshur commented on cmd/go/internal/modcmd: go.work local module fetching from remote by mistake2w
Thanks for the report. Are you able to share a go.work and other files needed to trigger the behavior you're seeing, preferably reduced to a minimal set? Also, Go 1.21.1 is a bit old, does this still…dmitshur commented on cmd/go: GOCACHEPROG asks to overwrite existing output ID with open file2w
CC @bradfitz, @matloob, @samthanawalla.dmitshur commented on encoding/binary: missing documentation for BigEndian and LittleEndian functions2w
CC @golang/tools-team for awareness of how gopls comes into play here.dmitshur commented on golang.org/x/build: add LUCI aix-ppc64 builder3w
@aclements You're referring to the legacy aix/ppc64 builder, right? This issue tracks the new LUCI builder which isn't [working yet](https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-…dmitshur reviewed +2 on rsc.io/gitfs/git: fix deprecated ioutil.ReadAll, remove unreachable code3w
Thanks. These changes LGTM, but I'm not sure when Russ will be able to get to this.dmitshur commented on rsc.io/gitfs/git: fix deprecated ioutil.ReadAll, remove unreachable code3w
Note that it would be better to delete the 2 lines above this line, and keep this line. Compare with golang/go#70688 and https://github.com/golang/website/commit/84bc8a71547811f19ea901d0c8e26f527c432…dmitshur commented on rsc.io/gitfs/git: fix deprecated ioutil.ReadAll, remove unreachable code3w
Closing the response body (`defer resp.Body.Close()`) is missed and could be added here. Compare with https://github.com/golang/website/commit/f65c3a961a9862aa95b34c56633e20a0818a8218#diff-9d934ba106…dmitshur commented on all: CI's enforcement of clean `go generate` is lacking3w
Some packages have their own test that checks that generated files are up to date (for example, see [here](https://cs.opensource.google/go/go/+/master:src/internal/platform/zosarch_test.go;l=21-23?q=…dmitshur commented on golang.org/x/tools/go/packages: TestTarget: "cannot find GOROOT directory: 'go' binary is trimmed and GOROOT is not set" (openbsd)3w
CC @golang/openbsd.dmitshur deleted branch in honnef.co/go/js/dom3w
pointer-and-datadmitshur pushed to
master in honnef.co/go/js/dom3w
dmitshur merged a change honnef.co/go/js/dom: add PointerID and PointerType to PointerEvent, as well as DataTransfer.SetData3w
dmitshur pushed to
pointer-and-data in honnef.co/go/js/dom3wdmitshur commented on github.com/yifanwu/blanknewtab: Get it to support Dark Mode4w
In case it helps, I've found the following 3 very simple files to work well in my testing. They support both light and dark modes, switching between them based on the OS-wide (or browser-wide) prefer…dmitshur commented on golang.org/x/build: LUCI support for plan94w
Great! Yes, as long as you're taking care of the swarming_bot instance separation carefully as you mentioned and you're not seeing problems as a result of it, reusing a single Linux machine as the pr…dmitshur pushed to
main in github.com/gopherjs/snippet-store4wdmitshur commented on go/doc: URL at end of sentence inside brackets causes trailing period to get incorrectly included in the URL4w
Indeed. Likely fixed during the Go 1.19 doc comment changes (https://go.dev/doc/go1.19#go-doc, issue #51082).dmitshur commented on golang.org/dl/gotip: enable configuring install path4w
I believe this is exactly the same as issue #26520. In that issue, one of the suggested names for a environment variable to control this was `GOSDK`.dmitshur commented on golang.org/x/build: LUCI support for plan94w
Ok, the [plan9-arm](https://chromium-swarm.appspot.com/bot?id=plan9-arm) bot has the target_ dimensions applied now, and I've submitted [CL 637437](https://go.dev/cl/637437). You should be able to pr…dmitshur commented on golang.org/x/build: LUCI support for plan94w
Ok, we should have a way to move forward. Instead of matching the individual Plan 9 builders for each of the GOARCH values by swarming bot id, which doesn't scale beyond 1 bot, we'll match by new tar…dmitshur closed an issue golang.org/x/build: use cloud build to deploy x/build services4w
Issue #70913 supersedes this.dmitshur commented on net/http: TestTransportIdleConnTimeout failures4w
@rsc The fix pending refers to [CL 633275](https://go.dev/cl/633275) from 2 weeks ago (via https://github.com/golang/go/issues/67450#issuecomment-2515255872 above; you might need to expand timeline).…dmitshur commented on golang.org/x/build: LUCI support for plan91mo
You're doing the "--02" suffix part right, but running into a limitation of the approach we used in https://github.com/golang/go/issues/62025#issuecomment-2135813578 that currently relies on the "id"…dmitshur commented on govulncheck-action: Support using a later patch release than what's in go.mod1mo
@kaovilai Thanks. I agree that absent of a toolchain directive, it's viable to pick either exactly the minimum toolchain that meets the 'go' directive requirement, or the latest minor release of the…dmitshur commented on govulncheck-action: Support using a later patch release than what's in go.mod1mo
I'm not sure I understand that point. The toolchain directive, in contrast to the go directive, applies only to the current module (the one defined by the go.mod file). It suggests the toolchain to b…dmitshur commented on govulncheck-action: Support using a later patch release than what's in go.mod1mo
The original issue reports:
> 1.22.0 go.mod results in 1.22.0 being used and no option to use later 1.22
I have a question about that – what is the behavior for the following go.mod file:
…dmitshur commented on golang.org/x/build/cmd/watchflakes: periodically restarts1mo
Watchflakes currently implements retries at the process level. That is, it has many code paths that handle errors with a log.Fatal (see [here](https://cs.opensource.google/search?q=fatal&ss=go%2Fx%2F…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder1mo
Thank you for offering to provide the builders, and apologies for the delay in getting back to these questions.
> Therefore it's hard to get any decent powerful hardware for CI stuff. Should those…dmitshur pushed to
pointer-and-data in honnef.co/go/js/dom1modmitshur opened a change honnef.co/go/js/dom: add PointerEvent.Pointer{ID,Type} and DataTransfer.SetData1mo
I plan to merge this in a few days. This PR exists so that it's possible to leave review comments before then, but a review is not required. Thanks.
References:
- https://developer.mozilla.org/…dmitshur created branch in honnef.co/go/js/dom1mo
pointer-and-datadmitshur commented on golang.org/x/website: automatic URL fragments for sub-sections of 'Minor changes to the library' are overly repetitive1mo
These headings are automatically generated rather than hand-written, and it's likely they got more repetitive after we switched to using Markdown for release notes instead of raw HTML (e.g., issue #6…