Activity
Today
dmitshur commented on cmd/compile: internal compiler error: panic during rewrite tern with GOEXPERIMENT=simd [1.26 backport]1h
@dr2chase This backport issue is still open but without CherryPickApproved nor CherryPickCandidate label. Should this go back to approved but with [CL 749241](https://go.dev/cl/749241) as the new CL …dmitshur commented on cmd/fix: stringscut rewrite changes behavior [1.26 backport]1h
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77737#event-23078589596 to this issue. (CC @dr2chase.)dmitshur commented on cmd/fix: stringscut rewrite changes behavior1h
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77737#event-23012415692).dmitshur commented on cmd/fix: stringscut rewrite changes behavior1h
This issue was marked as fixed by [CL 747900](https://go.dev/cl/747900), but that CL is in the main branch of x/tools. That's sufficient to fix the problem in time for Go 1.27, but this issue is curr…Yesterday
dmitshur reviewed +2 on go.dev/wiki/MinimumRequirements: drop requirements for unsupported Go versions16h
Thanks.
Maybe related that macOS 10.14 came out in Sept 2018, in between Go 1.11 (Aug 2018) and Go 1.12 (Feb 2019) releases. So they both probably worked, perhaps even older Go versions too given ma…dmitshur reviewed +2 on golang.org/x/build/cmd/gitmirror: remove reference to obsolete "apt-key"17h
Thanks. Some minor (optional) suggestions.
Splitting this long line to one-line-per-command for readability seems good, but maybe it's worth keeping the one-command-pipe-into-another together? I don…dmitshur reviewed +2 on golang.org/x/build/doc/deployment.md: include auth step in deployment process19h
In the past we may have previously relied on the CheckUserCredentials check to suggest this step if it wasn't already done (see [here](https://cs.opensource.google/go/x/build/+/master:buildenv/envs.g…dmitshur closed an issue cmd/compile: internal compiler error: 'main.func1': not lowered: v15, Load STRUCT PTR SSA [1.25 backport]22h
This Week
dmitshur reviewed +1 on builtin: incorporate all feedback into doc string for new1d
dmitshur closed a change builtin: update new documentation for Go 1.26 expression syntax1d
This change is already applied to the main tree (CL 746561), and issue #77584 is fixed. Closing.dmitshur reviewed +2 on all: [release-branch.go1.25] update x/sys1d
The alternative path would be to resolve the merge conflict in CL 746361, which involves a 2 line diff:
```diff
func SetEntriesInAcl(countExplicitEntries uint32, explicitEntries *EXPLICIT_A…dmitshur commented on cmd/fix: stringsbuilder ignores variables if they are used multiple times [1.26 backport]1d
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77659#event-23078585370 to this issue.dmitshur commented on cmd/fix: stringsbuilder ignores variables if they are used multiple times1d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77659#event-23004957221).dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: waitgroup leads to a compilation error1d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77754#event-23010399320).dmitshur commented on cmd/fix: minmax breaks select statements1d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77671#event-23007156867).dmitshur commented on cmd/fix: reflect.TypeOf(nil) transformed into reflect.TypeFor[untyped nil]()1d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77636#event-23009845781).dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes [1.26 backport]1d
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77482#event-23078592981 to this issue.dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes1d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77482#event-23054151261).dmitshur commented on cmd/fix: change -diff to exit 1 if diffs exist1d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77583#event-22768894147).dmitshur fixed an issue golang.org/x/build: bot linux-s390x-ibm--02 reported as broken1d
dmitshur commented on cmd/fix: rangeint uses target platform's type in the range expression, breaking other platforms2d
This is the main issue, so the CherryPickCandidate label doesn't apply here. There was already #77766 opened to track the Go 1.26.x backport.dmitshur commented on golang.org/x/build/chore: Migrate gsutil usage to gcloud storage2d
Thanks for sending the change. Part of the migration appear to be incomplete, and there are some failing tests reporting that. The Go project has conventions for how to write the commit message at ht…dmitshur opened a change golang.org/x/build/...: migrate to 'gcloud storage' from gsutil2d
At https://docs.cloud.google.com/storage/docs/gsutil#should-you-use it
is suggested to prefer using 'gcloud storage' instead of gsutil. Do so.
This was originally brought to my attention via the des…dmitshur commented on golang.org/x/build/cmd/genbotcert: add detail to hostname mismatch error2d
This change is ready for review.dmitshur opened a change golang.org/x/build/cmd/genbotcert: add detail to hostname mismatch error2d
Previously, if the CSR was somehow generated without a .bots.golang.org
suffix, the hostname check would catch that it didn't match but print a
message that's not very clear. Make it more detailed.
…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder3d
Thanks. Here's the new corresponding certificate: [linux-mipsle-hooc-ag-1771954236.cert.txt](https://github.com/user-attachments/files/25526903/linux-mipsle-hooc-ag-1771954236.cert.txt).dmitshur commented on golang.org/x/sync/errgroup: fix a typo in the documentation3d
(1 comment)
For posterity, this was a case of anchor format being different in the newer x/pkgsite doc viewer and that change not being backported the old doc viewer (compare https://pkg.go.dev/sync…dmitshur commented on golang.org/x/build/cmd/gopherbot: don't close cherry-pick issues on "For #123." references3d
Thanks.Last Week
dmitshur commented on runtime: regression segfault on linux 3.4 on mipsle5d
CC @golang/mips.dmitshur commented on gerrit: approver no longer grant AutoSubmit privileges5d
Submitting CLs on release-branches is limited to release managers. See https://go.dev/wiki/MinorReleases:
> The code review process is otherwise the same as regular CLs. Permission to submit to the …dmitshur commented on cmd/go: stdversion check should be on by default for `go test`5d
> I also wonder why this check wasn't added to go test once it was introduced; it seems like a simple (and presumably fast) check that should have zero false negatives.
I noticed that the accepted p…dmitshur closed an issue golang.org/x/build/cmd/gopherbot: don't mark issues as fixed if the “fix” verb is part of a larger sentence6d
dmitshur opened an issue golang.org/x/build/maintner: improve issue reference detection to report preceding verb (e.g., "Fixes", "For")6d
(Factored out a maintner improvement opportunity from the gopherbot-specific issue #29599.)
It'd be good if maintner's detection and reporting of issue references was improved. There is an existing …dmitshur opened a change golang.org/x/build/cmd/gopherbot: don't close cherry-pick issues on "For #123." references6d
Adding proper support to detect the verb in maintner is quite a bit of
work, and it needs to be done in a performant way because that code will
run unconditionally on all issue references.
On the ot…dmitshur commented on os: Go 1.25.x regression on RemoveAll for windows [1.25 backport]6d
Added release-blocker here since the go1.26.1 backport is done, so this isn't accidentally missed from go1.25.8.dmitshur commented on golang.org/x/build/cmd/gopherbot: close reopened cherry-pick issues6d
Thanks.
Got a chance to try this with https://go.dev/issue/77407#event-22892802277, and nothing unexpected came up.dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder6d
> To avoid any inconsistencies, I will generate a new private key and CSR for linux-mipsle-hooc-ag and request a fresh certificate.
Sounds good. I've revoked the previous certificate and can generat…dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: don't read GitHub issues if a query is given6d
Thanks.dmitshur reviewed +2 on golang.org/x/tools/go/analysis/unitchecker: update go fix, go vet error message1w
Thanks.
Noting this part of the comment as a nearby place that's a bit more targeted on vet (and its -vettool flag) and less so on fix (and its -fixtool flag). But that seems fine as above it does s…dmitshur fixed an issue golang.org/x/build: bot build9-m9 reported as broken1w
This is resolved.dmitshur commented on golang.org/x/build: bot build9-m9 reported as broken1w
This is resolved.dmitshur fixed an issue golang.org/x/build: bot mac-1236-g580 reported as broken1w
This is resolved.dmitshur commented on golang.org/x/build: bot mac-1236-g580 reported as broken1w
This is resolved.dmitshur fixed an issue golang.org/x/build: bot mac-328-h526 reported as broken1w
This builder is back online and idle, so this is resolved. It won't be receiving new work though as it was testing with macOS 11, and that stopped being needed after Go 1.24 became unsupported.dmitshur commented on golang.org/x/build: bot mac-328-h526 reported as broken1w
This builder is back online and idle, so this is resolved. It won't be receiving new work though as it was testing with macOS 11, and that stopped being needed after Go 1.24 became unsupported.dmitshur commented on golang.org/x/build: bot linux-ppc64-power10--01 reported as broken1w
Thanks for fixing it.dmitshur fixed an issue golang.org/x/build: bot linux-ppc64-power10--01 reported as broken1w
dmitshur fixed an issue golang.org/x/build: bot linux-ppc64-power10--01 reported as broken1w
dmitshur fixed an issue golang.org/x/build: bot mac-330-h526 reported as broken1w
Thanks. This builder is back and working okay now, so closing.dmitshur fixed an issue golang.org/x/build: bot mac-327-h526 reported as broken1w
This builder is back online and idle, so this is resolved. It's not receiving new work though as it has an old macOS version.dmitshur fixed an issue golang.org/x/build: bot mac-329-h526 reported as broken1w
This was resolved.dmitshur fixed an issue golang.org/x/build: bot linux-ppc64-power10--04 reported as broken1w
Thank you Paul.
https://chromium-swarm.appspot.com/bot?id=linux-ppc64-power10--04 is back and running okay, so closing this.dmitshur closed an issue golang.org/x/build: bot linux-s390x-ibm reported as broken1w
I believe this is expected because the builder gained a --01 suffix.
Closing in favor of #77709.dmitshur commented on golang.org/x/build: bot linux-s390x-ibm--02 reported as broken1w
Yes, I don't see any problem with that. For every builder name, such as `linux-s390x-ibm--02`, there should be only 1 running instance of the swarming client process (that bootstrapswarm runs), not …dmitshur fixed an issue golang.org/x/build: bot linux-loong64--01 reported as broken1w
This appears to be resolved. Thanks.dmitshur commented on cmd/go: change `go mod init` default go directive back to 1.N1w
@willfaught Thanks for the report and filing a proposal.
I'll reference a subset of https://go.dev/conduct#values here:
> - Be charitable.
> - [...]
> - When we do disagree, try to understand why…dmitshur reviewed +2 on golang.org/x/build/main.star: add presubmits and x repos to freebsd-amd64_15.01w
Thanks.dmitshur commented on golang.org/x/build: improve ability to look up current Go tree status ("open for development" or "frozen")1w
@seankhliao Thanks, that's a good idea to consider too. It sounds quite a bit simpler at a glance, though we'd still want to make sure we're able to maintain it to always be up to date (either manual…dmitshur commented on golang.org/x/build: improve ability to look up current Go tree status ("open for development" or "frozen")1w
We already have some dashboards at https://dev.golang.org/, including https://dev.golang.org/release, that can be candidates for this. Another idea to explore is whether we could also mirror the tree…dmitshur opened an issue golang.org/x/build: improve ability to look up current Go tree status ("open for development" or "frozen")1w
The Go tree regularly goes from "open for development" to "frozen for release" states, with 2 release cycles or 4 state transitions per year. During early tree reopening, there are some additional bu…dmitshur commented on cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))1w
The requested legacy slowbots keep not completing on patch set 1. Removing Run-TryBot+1 vote since it's not adding new information.dmitshur opened a change golang.org/x/website/cmd/golangorg: catch instances of bad escaping due to template use1w
The {{raw `…`}} sequence is commonly used in Markdown templates to
include a block as is. If such a sequence is used in a Markdown file
while its 'template' field in metadata is accidentally set to…dmitshur commented on cmd/fix: stringsbuilder breaks code when combining two `strings.Builder`s [1.26 backport]1w
@mrkfrmn Thanks. Note that I left a comment on [CL 746360](https://go.dev/cl/746360), I believe it already handles the vendoring for this backport issue as is, only its commit message does not curren…dmitshur reviewed +2 on go.dev/wiki/MinimumRequirements: simplify tinyconfig requirements1w
Thanks.dmitshur reviewed +2 on go.dev/wiki/Linux: update requirements to kernel 3.2 or later1w
I left a suggestion but overall this looks good. Thanks.dmitshur commented on go.dev/wiki/Linux: update requirements to kernel 3.2 or later1w
(1 comment)
Since 'drop requirements for unsupported Go versions' is a WIP CL that comes after this one, and I understand this table tries to capture the information when a given Kernel became requi…dmitshur commented on cmd/compile: internal compiler error on : "tried to free an already free register" with generic function and type >= 192 bytes [1.26 backport]1w
Moving the Critical label from here to #77604 (the upstream Go 1.27 tracking issue).dmitshur closed an issue cmd/fix: OOB panic in stringscut modernizer1w
dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: leave out space in stringsbuilder edit1w
Thanks.
I suspect this makes at most a tiny dent in the grand scheme of work to resolve issue #76476, but hopefully it helps more than not.dmitshur commented on golang.org/x/tools/gopls: fix typos1w
(1 comment)
Great. Thanks again.dmitshur commented on golang.org/x/build/cmd/gorebuild: leave out "you need to" suggestion1w
Thanks.dmitshur reviewed +2 on golang.org/x/website/_content/blog: minor edits to gofix.md1w
Thanks.
Was https://go-review.googlesource.com/c/website/+/745380/comment/fdba0ae1_5a22a858/ missed? It was about s/Repeat/Attempts/ rather than gofmt, since `type RequestJSON` definition above had …dmitshur reviewed +2 on golang.org/x/mobile/cmd/gomobile: update comments to explain why x86_64 is used for Arm641w
Thanks.Earlier
dmitshur commented on builtin: update new documentation for Go 1.26 expression syntax [1.26 backport]1w
Please see https://go.dev/wiki/MinorReleases for more information on the backport process. This cherry pick candidate is waiting to be reviewed first. We'll ask for your help with creating the backpo…dmitshur closed an issue : "go fix" produces invalid StringBuilder combination1w
I opened #77624 to backport the fix for this to Go 1.26.1.dmitshur commented on cmd/fix: stringsbuilder breaks code when combining two `strings.Builder`s [1.26 backport]1w
[CL 733180](https://go.dev/cl/733180) is already submitted on internal-branch.go1.26-vendor branch of x/tools, so what's left is to [vendor it](https://cs.opensource.google/go/go/+/release-branch.go…dmitshur commented on cmd/fix: stringsbuilder breaks code when combining two `strings.Builder`s1w
@gopherbot Please consider this for backport to Go 1.26. It's needed to prevent overlapping stringsbuilder fixes (#77620, #76983) from causing `go fix` to generate invalid code.dmitshur opened a change golang.org/x/tools/go/analysis/passes/modernize: leave out space in stringsbuilder edit1w
Applying the stringsbuilder suggestion in an editor previously ended up
inserting (or rather leaving behind) an extraneous space:
-s += "abc"
+s .WriteString("abc")
Adjust the edit to leave the s…dmitshur commented on : "go fix" produces invalid StringBuilder combination1w
Thanks for the report. This might be another instance of the known problem described in issue #76476 (and issue #76983).dmitshur commented on cmd/covdata: TestCovTool/{Textfmt,Subtract,MergeSimple} failures [consistent failure]1w
These test failures started with [CL 726800](https://go.dev/cl/726800). (CC @rudy-regazzoni-sonarsource.)dmitshur closed an issue cmd/covdata: TestCovTool/MergeSimple failures [consistent failure]1w
Joined into #77608.dmitshur closed an issue cmd/covdata: TestCovTool/Subtract failures [consistent failure]1w
Joined into #77608.dmitshur commented on github.com/OldUnreal/UT2004Patches: MacREADME.txt includes incorrect directory name in instructions (MacOS 3374 release)2w
> Thankfully the instructions on the website are correct.
It looks like they were fixed very recently, in commit de21bcf257f796c33ec3aa9ec7e20c55c0717993.dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count2w
> that means the intent of getting this fixed in go1.21.1 is recorded only in my head
It's okay to create the backport issue as soon as you think it should be considered for backport, before the iss…dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count2w
@adonovan Note that manually placing an issue in a Go minor release milestone can lead to it being missed in weekly backport review and in [minor release note](https://go.dev/doc/devel/release#go1.25…dmitshur commented on cmd/compile: go1.22+ cmd with go.mod 1.21 generates per-loop variable when using line directive [1.26 backport]2w
With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…dmitshur closed an issue runtime: netpollinit() incorrectly prints the error from `linux.Eventfd` [1.24 backport]2w
With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…dmitshur closed an issue cmd/go: CGO compilation fails after upgrading from Go 1.25.5 to 1.25.6 due to --define-variable flag in pkg-config [1.24 backport]2w
With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…dmitshur pushed to
main in dmitri.shuralyov.com/service/change9modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2y