Activity
Yesterday
dmitshur commented on cmd/link: remove typelinks10h
CL 740101 did fix linux/arm (32-bit).
There's also windows/arm64 that started failing as of this commit. The failures have "fatal error: out of memory" so they get picked up by #75417, but maybe it'…dmitshur commented on cmd/go: repository URL resolution behavior doesn't match documentation12h
CC @golang/command-line.dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: stringsbuilder fix could have fewer allocations12h
CC @adonovan.dmitshur commented on cmd/go: `go tool` and `go get -tool` could be documented better12h
CC @golang/command-line.dmitshur commented on all: switch linux-ppc64 target to ELFv2 ABI12h
(1 comment)
https://go.dev/wiki/CommitMessage suggests "Please don’t use alternate GitHub-supported aliases like Close or Resolves instead of Fixes.", if you don't mind changing it before submitti…dmitshur opened a change golang.org/x/build/main.star: delete sizespecializedmalloc builders for 1.25 and 1.2415h
The experiment exists only at tip and 1.26, not 1.25 and 1.24, so the
1.25 and 1.24 builders fail without producing useful signal. Since it
is being developed only at tip, it is probably fine to leav…dmitshur commented on golang.org/x/website: code in README.md is excessively HTML escaped16h
@qrasick I should be able to review it by tomorrow. From an early look, it looked good. Thanks for preparing it.dmitshur commented on golang.org/x/build/cmd/relui: automate upstreaming private-track security fixes on release day17h
(7 comments)
Good catch.
I took the existing wording we had in another similar "this needs your attention, an if everything looks acceptable and it's fine for relui to proceed, hit the approve butt…This Week
dmitshur commented on golang.org/x/pkgsite/...: add codereview.cfg1d
This change is ready for review.dmitshur opened a change golang.org/x/pkgsite/...: add codereview.cfg1d
For golang/go#9273.dmitshur commented on golang.org/x/vuln/...: add codereview.cfg1d
This change is ready for review.dmitshur opened a change golang.org/x/vuln/...: add codereview.cfg1d
For golang/go#9273.dmitshur commented on golang.org/x/pkgsite-metrics/...: add codereview.cfg1d
This change is ready for review.dmitshur opened a change golang.org/x/pkgsite-metrics/...: add codereview.cfg1d
For golang/go#9273.dmitshur commented on doc: write release notes for Go 1.261d
The Go 1.26 release notes draft seems ready. It's okay for this issue to stay open to track any further refinement and improvement leading up to the release, but removing the release-blocker label si…dmitshur fixed an issue cmd/go: unexpected code execution when invoking toolchain (CVE-2025-68119) [1.24 backport]1d
Closed by merging [CL 739421](https://go.dev/cl/739421) (commit 73fe85f0ea1bf2cec8e9a89bf5645de06ecaa0a6) to release-branch.go1.24.dmitshur commented on cmd/go: unexpected code execution when invoking toolchain (CVE-2025-68119) [1.24 backport]1d
Closed by merging [CL 739421](https://go.dev/cl/739421) (commit 73fe85f0ea1bf2cec8e9a89bf5645de06ecaa0a6) to release-branch.go1.24.dmitshur closed an issue cmd/go: TestScript/build_plugin_reproducible failures [consistent failure]1d
Merging into #77350.dmitshur commented on golang.org/x/pkgsite-metrics/...: require govulncheck at v1.1.5-0.20260127235021-3276fb946d411d
Thanks.dmitshur commented on lib/time: update tzdata before release1d
2025c still remains the latest available, and with Go 1.26 RC 3 planned for next week, Go 1.26.0 soon thereafter, moving this to the next milestone. We can always revisit if applicable.dmitshur commented on plugin: unrecognized failures [consistent failure]1d
@ianlancetaylor mailed [CL 739681](https://go.dev/cl/739681) for this. (CC @cherrymui.)dmitshur opened a change golang.org/x/pkgsite-metrics/...: require govulncheck at v1.1.5-0.20260127235021-3276fb946d411d
BuildGovulncheck builds the version of govulncheck specified in
the go.mod file of this module. Pull in the fix needed at gotip
that was recently applied in CL 739740.
For golang/go#77335.dmitshur opened a change golang.org/x/build/internal/task: use authentication for Gitiles in RealGerritClient1d
It was viable to make unauthenticated calls to Gitiles API previously
because it was only ever used with the public Gerrit host.
In the next CL, it will be used with the internal Gerrit host, too.
F…dmitshur commented on cmd/go: builds appear slower on openbsd/amd64 with Go 1.26rc2 (vs 1.25.6)2d
CC @golang/runtime.dmitshur commented on cmd/internal/obj/riscv: add Zvkned extension support2d
CC @golang/riscv64.dmitshur commented on golang.org/x/pkgsite: does not recognize the standard and recommended COPYING.LESSER filename for LGPL2d
CC @golang/pkgsite.dmitshur fixed an issue build: adopt Go 1.24 as bootstrap toolchain for Go 1.262d
We plan to take the reported friction and discussion here into account when doing this the next time, for Go 1.28. Filed #77341 for that.
At this point there's nothing more to do for Go 1.26, so clo…dmitshur commented on build: adopt Go 1.24 as bootstrap toolchain for Go 1.262d
We plan to take the reported friction and discussion here into account when doing this the next time, for Go 1.28. Filed #77341 for that.
At this point there's nothing more to do for Go 1.26, so clo…dmitshur opened an issue build: adopt Go 1.26 as bootstrap toolchain for Go 1.282d
This is the tracking issue for the Go 1.28 iteration of proposal #54265.
When it comes time to select what exact minor version of Go 1.26 to use as the minimum, we should take into account the infor…dmitshur fixed an issue golang.org/x/build/cmd/golangbuild: provide more useful signal when testing broken ports by using -force flag2d
This is done in [crrev.com/c/6854546](https://crrev.com/c/6854546).dmitshur commented on golang.org/x/build/cmd/golangbuild: provide more useful signal when testing broken ports by using -force flag2d
This is done in [crrev.com/c/6854546](https://crrev.com/c/6854546).dmitshur commented on golang.org/x/mobile: support for go/types.Aliases2d
The main Go tree is reopened for Go 1.27 development and the gotypesalias godebug is removed (in [CL 736441](https://go.dev/cl/736441)), so the [post-submit dashboard for x/mobile](https://ci.chromiu…dmitshur commented on golang.org/x/vuln/cmd/govulncheck: fails to build at tip due to use of gotypesalias setting2d
The release-blocker label here alone won't have effect since this is in x/vuln and in Unreleased milestone, but issue #76472 is still open and already in Go1.27 milestone. Added the label there too.dmitshur reviewed +1 on crypto/x509: fix single label excluded name constraints handling2d
Thanks. Leaving it to @dneil@google.com to +2.
Needs a [release-branch.go1.24] prefix, that'll satisfy the Matching-Subject-Prefix submit requirement.dmitshur reviewed +1 on crypto/x509: [release-branch.go1.25] fix single label excluded name constraints handling2d
Looks good, and leaving it to @dneil@google.com to +2. Thanks.dmitshur commented on crypto/x509: fix single label excluded name constraints handling2d
Restarting trybot to get more signal, the failure might be a rare unrelated flake.
Is this CL intended for release-branch.go1.25? If so, this needs a [release-branch.go1.25] prefix.
Does this need …dmitshur commented on golang.org/x/debug/dwtest: add more loclist tests2d
Filed #77338.dmitshur opened an issue golang.org/x/debug/dwtest: 10 TestDwarfVariableLocations subtests fail2d
There are a number of TestDwarfVariableLocations subtests failing on linux (amd64 and arm64), windows (amd64), and darwin (arm64 and amd64), as visible on the [x/debug post-submit dashboard](https://…dmitshur fixed an issue cmd/compile: OOM killed on linux/arm64 [1.25 backport]2d
Closed by merging [CL 710875](https://go.dev/cl/710875) (commit 738bc3a33c115e3ca48793117047390b3fe37392) to release-branch.go1.25.dmitshur commented on cmd/compile: OOM killed on linux/arm64 [1.25 backport]2d
Closed by merging [CL 710875](https://go.dev/cl/710875) (commit 738bc3a33c115e3ca48793117047390b3fe37392) to release-branch.go1.25.dmitshur commented on cmd/go: potential code smuggling using doc comments (CVE-2025-61732) [1.25 backport]2d
@neild Would you like to create the backport CL for this and its 1.24 equivalent?dmitshur opened an issue golang.org/x/vuln/cmd/govulncheck: fails to build at tip due to use of gotypesalias setting2d
The gotypesalias godebug is removed for Go 1.27 (in [CL 736441](https://go.dev/issue/736441)). This uncovered that the govulncheck command uses that godebug, causing it to fail to build at tip:
```
…dmitshur commented on golang.org/x/build/main.star: don't test the main branch on macOS 123d
Thanks.dmitshur commented on doc/go1.27: document macOS requirements3d
Thanks.dmitshur commented on runtime: garbage collector panic3d
CC @golang/runtime.dmitshur closed an issue golang.org/x/pkgsite: issue titles3d
dmitshur closed an issue golang.org/x/pkgsite: issue titles3d
The template questions are filled in, but the content doesn't seem related to what the questions are asking.dmitshur commented on path/filepath: documentation for Dir (and Clean) is misleading regarding Linux and Windows behavior3d
CC @robpike, @rsc.dmitshur commented on golang.org/x/sys: no way to call ioctl BLKGETSIZE64?3d
CC @golang/runtime.dmitshur commented on crypto/tls: automatically rotated ticket keys are valid for longer than documented3d
CC @golang/security.dmitshur commented on go/printer: printing const decl containing comment not attached to a const spec messes up indentation when using SourcePos mode3d
CC @griesemer, @mvdan.dmitshur commented on cmd/go: (on s390x with gcc-15) ThreadSanitizer: CHECK failed: tsan_platform_linux.cpp:571 "((thr_beg)) >= ((tls_addr))" (0x3ffac69e140, 0x3ffac69e240)3d
CC @golang/s390x.dmitshur commented on README.vendor: document release cycle considerations3d
Thanks.dmitshur commented on README.vendor: document release cycle considerations3d
Whoops, the new reviewer & CC were intended for the next CL in the stack.
Skipping trybots a second time, PS 2 merely added a missed word.dmitshur opened a change golang.org/x/build/main.star: clean up after dropping release-branch.go1.233d
Delete some code that's unused now that Go 1.23 is unsupported.
Generated files are unchanged.dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle3d
With [CL 738621](https://go.dev/cl/738621) (thanks @nicholashusin!) and [CL 739300](https://go.dev/cl/739300), the Go 1.27 start-of-freeze update round is done. Removing the early-in-cycle label to r…dmitshur opened a change README.vendor: document release cycle considerations3d
Write down a few more things relevant to the process of maintaining
the vendor directory for the std and cmd modules. This includes the
import path of the package containing a tree consistency check,…dmitshur commented on net/http: fix WaitGroup race in TestTransportNoReuseAfterEarlyResponse3d
(1 comment)
Yes, I addressed this in paragraph 3 of the commit message. Does that work, or do you prefer I take it out anyway?dmitshur reviewed +2 on cmd/compile: [release-branch.go1.25] during regalloc, fixedreg values are always available3d
Thanks.
I understand this part of the commit message isn't quite applicable to release-branch.go1.25, since CL 678620 was new to Go 1.26, but it's here anyway because the upstream commit had it.Last Week
dmitshur opened a change net/http: fix WaitGroup race in TestTransportNoReuseAfterEarlyResponse5d
The remaining race reported in go.dev/issue/66519 is that it's possible
for copying.Wait to start running before all copying.Add calls complete.
It happens infrequently as is, but padding both Wait a…dmitshur closed an issue golang.org/x/build: linux-mipsle/linux-mips64le builders are missing6d
Closing this in favor of the individual tracking issues that we have.
- #67306 (complete)
- #67304 (in progress)dmitshur commented on cmd/go: support for older versions of git broken again6d
Related to issue #26746 (about defining the minimum supported git version) mentioned above,
issue #26653 tracks adding a builder with that exact minimum git version.dmitshur reviewed +2 on golang.org/x/build/main.star: add runtimefreegc builder for the GOEXPERIMENT1w
Thanks.
Can you add a brief sentence with a criteria for when this should be deleted, similar to what we have for other builders intended to be tied to the rollout of an experiment? Having this cont…dmitshur commented on golang.org/x/build/gerrit: add Confirmed field to ReviewerInput1w
(1 comment)
Yes, that's right. Many golang.org/x repos provide packages meant for wide general use, but x/build is one of the exceptions to that. Also see the note in the README: https://cs.opensour…dmitshur commented on cmd/compile: fix mis-compilation for static array initialization1w
Sounds good. I'll add a wait-release and mark this thread as resolved so this can get submitted for 1.27 after the tree reopens, and we can re-title the 1.24 backport issue to be for 1.26 instead (or…dmitshur commented on github.com/dgraph-io/badger/v4/fix(aix): add aix directory synchronization support1w
> Is this still blocking the transition of the Go AIX CI instance?
Yeah, I re-checked https://github.com/golang/go/issues/67299#issuecomment-2285181258 and LUCI's cas dependency still fails to cro…dmitshur commented on cmd/compile: fix mis-compilation for static array initialization1w
@khr@golang.org Do you think this fix is safe enough, and we should proceed with at this point in the cycle? There's guidance at https://go.dev/s/release#june--december-week-2-release-candidate-1-iss…dmitshur commented on golang.org/x/build/devapp: move devapp command to x/build/cmd/devapp1w
pandora1mg@gmail.com There's no need to review changes that have already been submitted. If you'd like to contribute to Go, please see https://go.dev/doc/contribute. Thanks.dmitshur commented on golang.org/x/build/devapp: move devapp command to x/build/cmd/devapp1w
Thanks.dmitshur commented on golang.org/x/build/devapp: build Docker image via Cloud Build instead of local Docker1w
Thanks.dmitshur commented on golang.org/x/build/gerrit: add Confirmed field to ReviewerInput1w
(1 comment)
As noted here, new features are generally added to this package when something in x/build or another part of the Go project infrastructure needs it. Is this field needed for something?
…dmitshur commented on golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for release branches)1w
Thanks for offering. I suggest starting out with one of the issues already marked with a [`Suggested` or `help-wanted` label](https://github.com/golang/go/issues?q=is%3Aissue%20state%3Aopen%20(label%…dmitshur commented on github.com/ConradIrwin/font: Add support for TrueType Collection from font utility & tests1w
Yes, I would suggest removing `-u`. If someone wants that behavior and knows what they're doing, they can add it themselves, but otherwise a simple `go get import/path` is a good recommendation to …dmitshur commented on github.com/ConradIrwin/font: Add support for TrueType Collection from font utility & tests1w
Note that `-u` was needed to update the sfnt package itself in GOPATH mode, but in module mode `go get` alone will get the latest sfnt and its minimum required dependencies. See https://bsky.app/pr…dmitshur commented on golang.org/x/mobile/cmd/gomobile: -overlay build flag support1w
Ack. Marking this thread resolved, since there's nothing to do here. (CLs need all their conversation threads to get resolved in order to appear in the go.dev/s/needs-review for the Review-Enforceme…Earlier
dmitshur commented on golang.org/x/pkgsite: swap ?GOOS=darwin to arm64?1w
> A one-off non-scientific look at https://telemetry.go.dev/data/2025-03-15 has ~90% of darwin reports from darwin/arm64.
To expand on this, here are some counts of reports by GOOS/GOARCH pairs acro…dmitshur opened an issue golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for release branches)1w
By default, Go releases are built from the tip of their corresponding release branch, which gets modified only to update the content of the VERSION file during the release process. Doing this isn't v…dmitshur pushed to
main in dmitri.shuralyov.com/service/change8modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y