Activity
Last Week
dmitshur commented on runtime: [release-branch.go1.24] use one more address bit for tagged pointers2d
(1 comment)
This change is ready for review.
The 1.25 cherry pick was clean, but there's a conflict on 1.24 release branch.
It looks like it's because CL 667715, where defaultAddrBits was added, i…dmitshur opened a change runtime: [release-branch.go1.24] use one more address bit for tagged pointers2d
We use one extra bit to placate systems which simulate amd64 binaries on
an arm64 host. Allocated arm64 addresses could be as high as 1<<48-1,
which would be invalid if we assumed 48-bit sign-e…dmitshur opened a change runtime: [release-branch.go1.25] use one more address bit for tagged pointers2d
We use one extra bit to placate systems which simulate amd64 binaries on
an arm64 host. Allocated arm64 addresses could be as high as 1<<48-1,
which would be invalid if we assumed 48-bit sign-e…dmitshur commented on go/types: change and enforce lifecycle of Named.fromRHS and Named.underlying fields2d
Filed issue #75963 for it.dmitshur opened an issue cmd/compile/internal/importer: data race in TestIssue69912 as of CL 6959772d
This is being reported by race builders across various ports at tip:
```
=== RUN TestIssue69912
==================
WARNING: DATA RACE
Write at 0x00c0001aa098 by goroutine 1118:
cmd/compile/inter…dmitshur commented on go/types: change and enforce lifecycle of Named.fromRHS and Named.underlying fields2d
Note that as of submission of this CL, there's a data race reported fairly consistently on race builders in cmd/compile/internal/importer.TestIssue69912. For example, https://ci.chromium.org/b/870082…dmitshur opened a change golang.org/x/exp/cmd/gorelease: remove redundant fmt.Sprintf call2d
setNotValid already accepts a format string and uses
fmt.Sprintf internally so its caller doesn't need to.
Caught by the improved vet check as of CL 707135:
$ go vet ./cmd/gorelease
cmd/gorelease/r…dmitshur opened a change golang.org/x/website/cmd/screentest: escape % in format string2d
Caught by the improved vet check as of CL 707135:
$ go vet ./cmd/screentest
cmd/screentest/screentest.go:169:33: p format % o reads arg #1, but call has 0 argsdmitshur commented on cmd/compile/internal/ssa: add codegen for Zicond extension on riscv642d
@joel@sing.id.au Note that a Run-TryBot+1 vote by itself doesn't do anything by now, it only exists to be able to request legacy TRY= SlowBots. Removing it. For normal trybots, Commit-Queue+1 is the …dmitshur commented on golang.org/x/pkgsite: still no update for > 2h and counting after a new tag is available on proxy and requested2d
CC @golang/pkgsite.dmitshur commented on cmd/go: `go tool` doesn't list nm, objdump and pprof2d
CC @golang/command-line.dmitshur commented on cmd/pprof: incorrect CPU profile graph2d
CC @golang/runtime, @cherrymui.dmitshur commented on cmd/compile/internal/inline/inlheur: dumpscores test failure2d
Thanks for the report. Does the failure happen reproducibly or intermittently for you?
It seems not to happen on the linux/amd64 builder ([here](https://ci.chromium.org/ui/p/golang/builders/ci/gotip…dmitshur commented on cmd/go: work edit -json doesn't include the toolchain2d
CC @golang/command-line.dmitshur commented on compress/flate: size optimization of final deflate block (btype 0 -> btype 1)2d
CC @dsnet, @mdempsky.dmitshur commented on net/http/httputil: ReverseProxy stuck forever when handling request with expect: 100-continue header and upstream connection creation fails2d
CC @neild, @thatnealpatel.dmitshur commented on cmd/go: env should report GOPACKAGESDRIVER2d
CC @golang/command-line.dmitshur commented on os: on windows RemoveAll removing directories containing read-only files errors with `unlinkat ... Access is denied`2d
CC @golang/windows, @griesemer, @neild.dmitshur commented on path/filepath: improve `Rel`'s documentation2d
CC @robpike, @rsc.dmitshur commented on github.com/actions/setup-go: Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang2d
Thanks for doing that!
From my perspective, changing download URLs from `https://storage.googleapis.com/golang/{file}` to `https://go.dev/dl/{file}` is the right thing to do, so I'll leave further…dmitshur commented on github.com/actions/setup-go: Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang2d
Consider using https://go.dev/dl/ itself and following the redirects. It's likely that https://dl.google.com/go/ will remain current for a long time, but if it ends up changing in the future, this wi…dmitshur commented on github.com/actions/setup-go: storage.googleapis.com/golang no longer allows anonymous access causing 403 on Golang download fallback2d
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur commented on github.com/microsoft/azure-pipelines-tasks/[BUG]: gotooling task cannot download go distribution2d
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur commented on golang.org/x/build: add Debian Trixie builders2d
The linux/arm64 trixie builder is up (with a known issue) and seems to be running into some problem with its C toolchain. Some of the packages fail with "running gcc failed [...] cannot find ‘ld’…dmitshur commented on go/version: does not support the `X:` suffix from `go env GOVERSION`2d
Package [go/version](https://pkg.go.dev/go/version) is documented to operate on Go versions in Go toolchain name syntax, which is defined at https://go.dev/doc/toolchain#name as:
> The standard Go t…dmitshur commented on golang.org/x/build/main.star: add linux-arm64_debian13 builder2d
Thanks.dmitshur commented on github.com/coder/internal/flake: macOS Go setup failure - illegal byte sequence during tar extraction2d
Note that the official Go distributions can be downloaded (following redirects) using URLs at https://go.dev/dl/, which follow the pattern `https://go.dev/dl/{file name}`. Attempting to download thos…dmitshur commented on github.com/google/oss-fuzz: base images not building2d
Yes, "getgo" was an experimental tool that was deprecated and removed in 2024, see Go proposal golang/go#60951. It should work to download (following redirects) using the URLs at https://go.dev/dl/, …dmitshur opened a change golang.org/x/build/main.star: add linux-arm64_debian13 builder3d
For golang/go#74985.dmitshur opened an issue golang.org/x/build: update Debian sid builder past trixie3d
Our current Debian sid builders were last updated at a time when they were close to Debian Trixie's release, and their reported OS dimension value is "Debian-13". This prevents us from adding stable …dmitshur commented on golang.org/x/build: add Debian Trixie builders3d
I started [crrev.com/i/8675857](https://crrev.com/i/8675857) to add internal configuration for the new Debian Trixie builder images, and ran into an issue that our current Debian sid builder reports …dmitshur commented on golang.org/x/net/internal/quic/cmd/interop: support ChaCha20 interop test (server)4d
CC @neild.dmitshur commented on govulncheck-action: pin action dependencies by sha4d
CC @golang/vulndb.dmitshur commented on golang.org/x/vuln: govulncheck -format=sarif generates invalid sarif with duplicate tags4d
CC @golang/vulndb.dmitshur closed an issue golang.org/x/mobile: fatal error: bulkBarrierPreWrite: unaligned arguments4d
If this issue is already fixed by [CL 692935](https://go.dev/cl/692935), there's nothing more to do here. Let's use #46893 as the canonical issue for this problem.
Go 1.26 is expected to be released…dmitshur opened an issue golang.org/x/build/cmd/relui: use http.CrossOriginProtection5d
[`http.CrossOriginProtection`](https://pkg.go.dev/net/http#CrossOriginProtection) was added in Go 1.25 and relui should take advantage of it to reject non-safe cross-origin browser requests. This is …dmitshur commented on golang.org/x/tools: make API changes visible during code review5d
The scope of the [proposal process](https://github.com/golang/proposal#scope) includes "API changes in the main repo and all* golang.org/x repos" (almost all, there are some x/ repos that are not in …Earlier
dmitshur commented on golang.org/x/net/http2: data race in TestGoroutineLock1w
Oh, trying the same repro on a different darwin/arm64 machine, this reproduced within a minute 3 out of 3 times. Unless it's a coincidence, the only difference is that the no-repro machine has M1 Pro…dmitshur commented on golang.org/x/net/http2: data race in TestGoroutineLock1w
Thanks for the report. How quickly does it typically reproduce for you? Also, to confirm, does `git status` print that there are no local code changes for you? In my case, 10 minutes of running didn'…dmitshur closed an issue golang.org/x/tools/gopls: converge gopls support window with top-level Go support window1w
dmitshur commented on spec: Go1.25 spec should be dated closer to actual release date1w
Closing this since there's nothing more to do for the Go 1.26 milestone - the language version and its date are for Go 1.26 there. The change on release-branch.go1.25 will be tracked in #75777.dmitshur pushed to
main in dmitri.shuralyov.com/service/change5modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl4ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust5y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle5ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)5y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes5ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim5y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit5y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/service/change5ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase5ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit5ydmitshur pushed to
master in dmitri.shuralyov.com/state5ydmitshur pushed to
master in dmitri.shuralyov.com/scratch5ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes5ydmitshur pushed to
master in dmitri.shuralyov.com/route/github5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6y