Activity
Last Week
dmitshur commented on runtime: don't count nGsyscallNoP for extra Ms in C1d
Note that clang15 and darwin builders need attention, see https://ci.chromium.org/b/8696287140314584433 for example.dmitshur opened a change all: [release-branch.go1.26] merge master (7453497) into release-branch.go1.261d
Merge List:
+ 2025-12-05 745349712e runtime: don't count nGsyscallNoP for extra Ms in C
+ 2025-12-05 f3d572d96a cmd/go: fix race applying fixes in fix and vet -fix modes
+ 2025-12-05 76345533f7 runt…dmitshur commented on golang.org/x/build/cmd/updatestd: remove -d flag from go get invocation1d
Thanks.dmitshur opened a change golang.org/x/build/cmd/updatestd: remove -d flag from go get invocation1d
The -d flag is deprecated and setting it to true is a no-op by now.
Removing it stops a warning from being printed when updatestd runs.dmitshur commented on golang.org/x/build/internal/task: add suggestion to opt in to Go telemetry in RCs1d
(1 comment)
Done in PS 4.dmitshur commented on all: fix some comment issues1d
Thanks.dmitshur commented on golang.org/x/build/internal/task: add suggestion to opt in to Go toolchain telemetry in RCs1d
(1 comment)
Hmm, the https://go.dev/doc/telemetry page consistently uses "Go telemetry", and including toolchain might be misleading since "Go telemetry is only intended for use in programs maintain…dmitshur commented on golang.org/x/build/internal/task: add suggestion to opt in to Go toolchain telemetry in RCs1d
Thanks.dmitshur commented on golang.org/x/pkgsite: pkg.go.dev/constraints works when maybe it should not1d
Thanks for reporting. That little triangle inside the "Latest" badge does say that the package doesn't exist in the latest version of the standard library, but admittedly it is small and pretty uncom…dmitshur commented on runtime: stack split at bad time in os/signal with Go 1.25.4 windows 3861d
CC @golang/windows.dmitshur commented on cmd/gofmt: trailing comments in composite literals are misaligned1d
CC @griesemer, @mvdan.dmitshur pushed to
master in github.com/andygrunwald/go-gerrit2ddmitshur merged a change github.com/andygrunwald/go-gerrit: Don't treat + as a special character for queries2d
dmitshur reviewed +2 on github.com/andygrunwald/go-gerrit: Don't treat + as a special character for queries2d
We have no new information about issue #18, so let's move forward with the (partial) revert of PR #22.dmitshur opened a change all: update vendored x/tools2d
Pull in the following x/tools changes:
- CL 726000: go/analysis/passes/modernize: omitzero: suppress on kubebuilder
- CL 726621: internal/refactor/inline: built-ins may affect inference
- CL 727041:…dmitshur commented on io: add an `Err` field to `LimitedReader`2d
Yes, the `wait-release` is used to indicate that CL can be submitted for the next Go release, because we've now entered a release freeze for Go 1.26. See https://groups.google.com/g/golang-dev/c/Om8V…dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.26-vendor] omitzero: suppress on kubebuilder2d
That CL finished propagating by now and so the 1.26 LUCI trybots should work. It looks like this CL just needed some change (such as your reply) to trigger them.dmitshur reviewed +2 on golang.org/x/website/_content/doc: fix typos and what looks like swapped paragraphs2d
Thanks.dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.26-vendor] omitzero: suppress on kubebuilder2d
@adonovan@google.com Legacy trybots don't contain any builders by default anymore.
Normal LUCI trybot will start working soon for internal-branch.go1.26, see CL 726860.dmitshur commented on golang.org/x/build/main.star: add NEXTUP_GO branch for Go 1.26 release candidate2d
Thanks.dmitshur commented on : [release-branch.go1.26] update codereview.cfg for release-branch.go1.262d
This change is ready for review.dmitshur opened a change : [release-branch.go1.26] update codereview.cfg for release-branch.go1.262d
dmitshur opened a change golang.org/x/build/main.star: add NEXTUP_GO branch for Go 1.26 release candidate2d
Similar to how it was done in CL 679715 previously.dmitshur fixed an issue access: Requesting TryBot access for "kiran.m.vijay@ibm.com"2d
Hi Kiran,
Thank you for your contributions, including helping maintain the s390x architecture, and for requesting trybot access. I've added you to the `may-start-trybots` group, so you should be abl…dmitshur commented on access: Requesting TryBot access for "kiran.m.vijay@ibm.com"2d
Hi Kiran,
Thank you for your contributions, including helping maintain the s390x architecture, and for requesting trybot access. I've added you to the `may-start-trybots` group, so you should be abl…dmitshur commented on golang.org/x/pkgsite: Wrong section expanded when clicking a collapsable header2d
CC @golang/pkgsite.dmitshur commented on golang.org/x/website: Playground execution doesn't finish normally, but no error message is shown2d
CC @findleyr, @golang/tools-team.dmitshur commented on all: exec: WaitDelay expired before I/O complete failures on Darwin and Windows2d
Added this to Test Flakes project, otherwise watchflakes won't post to it.
Note that some of the matching failures in #68788 were on netbsd/arm64 and freebsd/riscv64, too. Perhaps they can be merged…dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.26.md: add release note for goroutine leak profiles3d
Thanks.
Maybe include a leading slash here, so it's clear that's the absolute path of that endpoint. Including the leading slash seems to be the pattern followed at https://go.dev/pkg/net/http/pprof…dmitshur commented on all: end support for ppc64/linux (big-endian, ELFv1) in Go 1.273d
Added this to Go 1.26 release blockers to add a pre-announcement to Go 1.26 release notes.dmitshur closed a change golang.org/x/crypto/x509roots/fallback: update bundle3d
Closing this in favor CL 723803, which was an identical change generated at a later time.dmitshur closed an issue : x/website:3d
dmitshur reviewed +2 on golang.org/x/proposal/design: fix issue number in go15bootstrap.md3d
Thanks.
In this case, this is okay. It's a simple typo fix and the issue contains enough context.dmitshur commented on cmd/go: env vars like GOPRIVATE should reject shell characters which suggest a human error3d
CC @golang/command-line.dmitshur commented on net/http: HTTP2: not-consistent invalid error when server closes connection, possible race condition3d
CC @neild.dmitshur commented on os: NewFile blocks if handle is blocked3d
Thanks for clarifying. Given the remaining fix might be complex, do you think it's worth trying to get it into Go 1.26, while we're still fairly early in the freeze? I applied the release-blocker lab…dmitshur commented on cmd/go: fix: apply fixes from modernizers, inline, and other analyzers3d
@adonovan Checking in on the status here as this is a Go 1.26 RC 1 blocker. Or perhaps if what is left here is safe for after RC 1, then it can have okay-after-rc1 label added. Thanks.dmitshur commented on golang.org/x/tools/internal/refactor/inline: inlining of { return new(x) } may change its type3d
@markus-kusano Checking in on the status here as this is currently marked as a Go 1.26 RC 1 blocker. Or perhaps this is safe after RC 1 and can have okay-after-rc1 label added. Thanks.dmitshur commented on runtime/metrics: do not count inactive cgo threads (/sched/goroutines/not-in-go:goroutines)3d
@mknyszek Checking in on the status here as this is a Go 1.26 RC 1 blocker. Or perhaps this is safe after RC 1 and can have okay-after-rc1 label added.dmitshur commented on crypto/tls: earlyTrafficSecret should use ClientHelloInner if ECH enabled [1.25 backport]3d
No problem, thanks! This was waiting for yesterday's minors to be released first anyway.dmitshur commented on crypto/tls: earlyTrafficSecret should use ClientHelloInner if ECH enabled [1.25 backport]3d
@rolandshoemaker Since you authored the original CL, would you like to create the backport CLs (for this and #76408)?dmitshur commented on doc/next: added release notes for goroutine leak profiles3d
Thanks for working on this release note change.
At this time the release note fragments need to be assembled and moved to x/website, as part of preparing for Go 1.26 RC 1. Unfortunately that means y…dmitshur commented on net/http: use math/rand/v2 instead of math/rand3d
This change doesn't seem to be working towards increasing stability of Go 1.26 or resolving its release blockers, so it's probably okay to leave for Go 1.27.dmitshur reviewed +2 on doc/next/6-stdlib/99-minor/go/ast/76031.md: add BasicLit caveat3d
Thanks.
The release note fragments need to be assembled and moved to x/website soon. If there's more follow up here, please aim to do in the soon to be merged [x/website/_content/doc/go1.26.md](http…dmitshur reviewed +2 on doc/next: pluralize 'result'3d
Thanks.dmitshur commented on github.com/udhos/update-golang: Change source in update-golang.sh4d
Yeah, that should be the next step to resolve this, though I'm not sure who maintains this script. CC @udhos.dmitshur commented on github.com/actions/setup-go: Failing to download latest go version 1.25.54d
This was previously reported in issue #664. PR https://github.com/actions/setup-go/pull/667 was created to resolve this for v4.
It is already resolved in v6 as of [v6.1.0](https://github.com/actions…dmitshur commented on golang.org/x/build/maintner: migrate to bartventer/httpcache4d
Thanks for preparing this CL. I haven't looked closely at the new package yet, just leaving an initial comment in go.mod.
We need to keep x/build's go directive at 1.24 for a few months longer, whil…dmitshur reviewed +2 on doc: mention stack allocation of slices4d
Thanks.dmitshur commented on compress/gzip: performance bottleneck impacting Kubernetes4d
We are indeed past the code freeze for Go 1.26, so enhancements and optimization CLs that haven't already been submitted do need to wait for the tree to reopen for Go 1.27 (expected in [late January]…dmitshur commented on crypto/x509: excluded subdomain constraint doesn't preclude wildcard SAN (CVE-2025-61727)4d
@rolandshoemaker Checking on the status here, what is left to resolve this issue (for Go 1.26)? Thanks.dmitshur commented on crypto/x509: prevent HostnameError.Error() from consuming excessive resource4d
The linux-amd64-race race builder failed due to a timeout while testing the runtime package on first try. It doesn't seem to be related to this change and it passed on second try, so bypassing.dmitshur opened a change crypto/x509: prevent HostnameError.Error() from consuming excessive resource4d
Constructing HostnameError.Error() takes O(N^2) runtime due to using a
string concatenation in a loop. Additionally, there is no limit on how
many names are included in the error message. As a result…dmitshur opened a change golang.org/x/website/internal/history: document Go 1.25.5 and 1.24.11 releases4d
This describes the fix in internal/syscall/windows (CL 718000) as a fix
to package os, as that is the public package whose behavior is affected.dmitshur opened a change crypto/x509: [release-branch.go1.24] prevent HostnameError.Error() from consuming excessive resource4d
Constructing HostnameError.Error() takes O(N^2) runtime due to using a
string concatenation in a loop. Additionally, there is no limit on how
many names are included in the error message. As a result…dmitshur opened a change crypto/x509: [release-branch.go1.25] prevent HostnameError.Error() from consuming excessive resource4d
Constructing HostnameError.Error() takes O(N^2) runtime due to using a
string concatenation in a loop. Additionally, there is no limit on how
many names are included in the error message. As a result…dmitshur commented on github.com/gravitational/teleport: Building Teleport does not work anymore because Go cannot be downloaded anonymously4d
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur commented on github.com/udhos/update-golang: Change source in update-golang.sh4d
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur reviewed +2 on github.com/andygrunwald/go-gerrit: Bump actions/setup-go from 5 to 65d
dmitshur commented on github.com/WillAbides/setup-go-faster: `https://storage.googleapis.com/golang` now returns a 403 for anonymous access5d
This is resolved in actions/setup-go by now, see https://github.com/actions/setup-go/releases/tag/v6.1.0. Copying what I posted at https://github.com/actions/setup-go/issues/664#issuecomment-34166816…dmitshur reviewed +2 on internal/runtime/cgroup: remove duplicate readString definition5d
Thanks.dmitshur commented on cmd/link: ~1% regression in link time for ts-go5d
CC @ianlancetaylor.dmitshur closed an issue golang.org/x/mobile: android support 1kb page size5d
It sounds like this is resolved, but for future issue reports, please include answers to questions in the template. For questions, there's a list of better suited forums linked at [go.dev/wiki/Questi…dmitshur commented on simd: Less/Greater methods produce inconsistent results5d
CC @golang/compiler.dmitshur commented on runtime: TestReadMetricsSched failures on s390x since CL 7210025d
CC @golang/s390x.dmitshur reviewed +2 on doc: document go tool pprof -http default change5d
Thanks.dmitshur commented on os: NewFile blocks if handle is blocked5d
@qmuntal The commit message of [CL 724640](https://go.dev/cl/724640) contained "This avoids potential deadlocks during os package initialization" and "Updates #76391", so this issue is still open. Is…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle5d
The Go 1.26 start-of-freeze update round is complete.dmitshur commented on doc/next: clean up some Go 1.26 release notes5d
Yep. This CL correctly shows up in https://go.dev/s/needs-review so someone will get to it soon.dmitshur fixed an issue cmd/pprof: make flamegraph page the starting one in http UI5d
This change happened upstream, and this is now done for cmd/pprof via [CL 725500](https://go.dev/cl/725500). (CC @prattmic.) Added this issue to the Go1.26 milestone.dmitshur opened a change cmd/pprof: update vendored github.com/google/pprof5d
Pull in the latest published version of github.com/google/pprof
as part of the continuous process of keeping Go's dependencies
up to date.
For #36905.
[git-generate]
cd src/cmd
go get github.com/go…dmitshur opened a change all: update vendored dependencies5d
The Go 1.26 code freeze has recently started. This is a time to update
all golang.org/x/... module versions that contribute packages to the
std and cmd modules in the standard library to latest maste…dmitshur reviewed +2 on vendor/golang.org/x/tools: update to 1ad6f3d5d
Thanks.
I'll also update other x repo packages for #36905 soon.
It's also in line with "The release freeze applies to the entire main repository as well as to the code in subrepositories that is ne…Earlier
dmitshur fixed an issue golang.org/x/build/cmd/coordinator: format %q has arg of wrong type [consistent failure]1w
Fixed by [CL 725080](https://go.dev/cl/725080).dmitshur closed an issue golang.org/x/build/internal/task: unrecognized failures1w
dmitshur closed an issue golang.org/x/build/internal/secret: unrecognized failures1w
dmitshur closed an issue golang.org/x/telemetry/counter/countertest: unrecognized failures [consistent failure]1w
dmitshur fixed an issue golang.org/x/pkgsite/internal/postgres/search: Errorf format %q has arg got of wrong type InputType1w
Fixed by [CL 725300](https://go.dev/cl/725300).dmitshur fixed an issue golang.org/x/text/transform: Errorf format %q has arg nDst of wrong type int1w
Fixed by [CL 725061](https://go.dev/cl/725061).dmitshur commented on os: on Unix, Readdirnames skips directory entries with zero inodes1w
@vasi Does this problem apply to Go 1.24 too? If so, we'll need to consider them both per [Go release policy](https://go.dev/issue/34536#issuecomment-572188389).dmitshur closed an issue runtime:cpu2: TestAppendByteCapInLoop failures1w
Merging into #76567.dmitshur closed an issue runtime:cpu1: TestAppendByteCapInLoop failures1w
Merging into #76567.dmitshur opened an issue golang.org/x/build/cmd/watchflakes: default to creating new issues per test (instead of per subtest) and per package (instead of per package:variant)1w
When watchflakes encounters a new failure mode that none of the existing issues in the Test Flakes project match, it creates a new issue for it. When it creates the issue, it creates a pattern for th…dmitshur commented on golang.org/x/website: typo in blog/generic-interfaces1w
Thanks for reporting. If you'd like, you can contribute a fix. See https://go.dev/doc/contribute.dmitshur commented on cmd/link: package tests fail to build on AIX with "unknown outer symbol with name go:funcrel.*"1w
CC @golang/aix, @ianlancetaylor.dmitshur commented on golang.org/x/tools/gopls/internal/test/marker: Test/*.txt failures1w
Widened the pattern here to catch all Test/*.txt failures, otherwise watchflakes defaults to creating too many individual ones. (If their failure modes end up being different, they can be split up as…dmitshur opened an issue cmd/go/internal/modfetch/codehost: TestReadZip failures1w
```
#!watchflakes
default <- pkg == "cmd/go/internal/modfetch/codehost" && test ~ `^TestReadZip`
```
An issue for watchflakes to track flaky failures of this test.
CC @golang/command-line.dmitshur opened an issue net/http: TestClientConnReserveAndConsume failures1w
```
#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientConnReserveAndConsume`
```
Example ([log](https://ci.chromium.org/b/8697100027836472289)):
```
=== RUN TestClientConnReserveAnd…dmitshur opened an issue build: freebsd/riscv64 port is broken1w
The Go porting policy has a section on broken ports, https://go.dev/wiki/PortingPolicy#broken-ports. The GOOS=freebsd GOARCH=riscv64 port was marked broken in August 2025 ([CL 691835](https://go.dev/…dmitshur commented on golang.org/x/build: gotip-freebsd-riscv64 builder is missing1w
@mengzhuo Thanks for working on this. The freebsd/riscv64 builder has passing runs on [some golang.org/x repos](https://ci.chromium.org/ui/p/golang/g/port-freebsd-riscv64/builders), but the main Go r…dmitshur commented on lib/time: update tzdata before release1w
2025b is still the latest available version, so tentatively adding okay-after-rc1 since nothing here blocks the Go 1.26 RC 1 at this time.dmitshur commented on all: announce end of support for old Windows releases1w
Nothing about old versions of Windows to pre-announce in Go 1.26 release notes, moving to the next.dmitshur commented on all: announce end of support for old Linux versions1w
Nothing to pre-announce in Go 1.26 release notes, moving to the next.dmitshur commented on all: announce end of support for old macOS releases1w
[CL 723080](https://go.dev/cl/723080) added a pre-announcement to the Go 1.26 release notes. Moving to the next milestone.dmitshur pushed to
main in dmitri.shuralyov.com/service/change6modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.