Activity
This Week
dmitshur starred github.com/usbarmory/go-boot1d
dmitshur commented on golang.org/x/build/internal/relui: replace httprouter use with http.ServeMux1d
Thanks. Hold for now, I'll get this submitted in the new year when I'm around, in case I missed something that needs follow up.dmitshur commented on golang.org/x/build/internal/relui: replace httprouter use with http.ServeMux1d
(1 comment)
This seems to work as is, but I noticed net/http docs suggest putting the $ in {}. Done in PS 2.dmitshur commented on golang.org/x/build/cmd/watchflakes: double the memory allocation1d
Done.
This helps reduce frequency of OOMs (down from a handful over a few days to 0 over a few days), so submitting this now. If it still happens with the bigger limit we can revisit then.dmitshur opened a change golang.org/x/build/cmd/coordinator: lower the memory allocation1d
The coordinator was previously given more memory so that it could get
through its peaks during releases and not crash. By now, it's not used
for running tests during the release process, and it's als…dmitshur opened a change golang.org/x/build/internal/relui: fix URL path segment escaping for task names1d
url.PathEscape can be used to escape a string so it can be safely placed
inside a URL path segment. Do so, which after migrating to http.ServeMux
and its pattern matching makes it possible to success…dmitshur closed an issue errors: errors.Join behavior changed in 1.25 [1.26 backport]1d
Backport issues are used for minor releases. For Go 1.26.0 itself, this is already tracked in #76961, and there's no backport CL needed since we're still in the freeze before early tree reopening. Se…dmitshur closed an issue errors: errors.Join behavior changed in 1.25 [1.26 backport]1d
Backport issues are used for minor releases. For Go 1.26.0 itself, this is already tracked in #76961, and there's no backport CL needed since we're still in the freeze before early tree reopening. Se…dmitshur reviewed +2 on golang.org/x/pkgsite/cmd/internal/doc: increase x/pkgsite dependency to CL 7299001d
Thanks.
By now there are newer commits, but I understand they don't have similar notable changes and that's why they're not being included here.
(nit) Inconsistent leading space here (2 tabs vs 4 s…Last Week
dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.26: add note for lower go mod init go directive version4d
Thanks. I left optional suggestions, but feel free to leave out any that don't work out well.
(nit) Maybe s/sets/defaults to/ here, if that helps put slightly more emphasis on the fact that this is …dmitshur commented on rsc.io/github: allow no labels in CreateIssue5d
Thanks.dmitshur opened a change golang.org/x/build/cmd/watchflakes: pull in fix for creating issues with no labels5d
As of CL 730922, watchflakes sometimes tries to create an issue without
setting any labels on it. Doing that uncovered the issue rsc/github#18,
which has since been fixed. Pull in a version that incl…dmitshur reviewed +2 on cmd/go/internal/doc: update pkgsite version5d
Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes: set GOMEMLIMIT in container5d
The recent crashing spree was a good opportunity to test this idea, and setting GOMEMLIMIT explicitly seemingly helped quite a bit. So let's keep it.
Thanks.dmitshur commented on golang.org/x/tools/gopls/internal/server: disable TestCheckGoModDeps for js and wasm6d
(1 comment)
Consider @hxjiang@golang.org's [suggestion](https://go.dev/issue/76894#issuecomment-3672203117) of using `testenv.NeedsExec(t)`: it will handle additional test environments where execute…dmitshur opened a change rsc.io/github: allow no labels in CreateIssue6d
If `labelIDs` remains at its zero value of `([]string)(nil)`, then it can't be used with a GraphQL type `[ID!]!`. The createIssue mutation call uses the GraphQL type `[ID!]` for its [`labelIds`](http…dmitshur commented on golang.org/x/tools/gopls/internal/server: TestCheckGoModDeps/user_dismisses_prompt fails on js, wasip1 because they don't support Executable [consistent failure]6d
CC @golang/js.
This test is probably missing a skip for when os.Executable is not available (such as for GOOS=js).dmitshur opened an issue rsc.io/github: CreateIssue fails when attempting to create an issue with no labels6d
It seems this package doesn't currently support creating an issue with no labels. It works fine when there's at least one label, otherwise the Client.CreateIssue call errors out with:
```
graphql er…dmitshur commented on golang.org/x/build/cmd/watchflakes: leave NeedsInvestigation out on consistent failures6d
Thanks.dmitshur opened a change golang.org/x/build/cmd/watchflakes: leave NeedsInvestigation out on consistent failures1w
Consistent failures typically need more time-sensitive action than
flaky tests. They happen less often (hopefully) and so it might be
acceptable to include them in the go.dev/s/untriaged queue so tha…dmitshur opened a change golang.org/x/build/internal/migration: stop running linux-mips64le-rtrk builder1w
This builder has been migrated to LUCI.
For golang/go#67306.dmitshur opened a change golang.org/x/build/main.star: delete windows/arm (32-bit ARM) builders1w
There is no running builder for windows/arm. The port was marked broken
in Go 1.24, and it's removed in Go 1.26. At this point no one will be
adding this builder, so remove its definition.
For golan…dmitshur closed a change golang.org/x/tools/internal/stdlib: update stdlib index for Go 1.26 Release Candidate 11w
Replaced by CL 730540.dmitshur commented on cmd/go: Go 1.26rc1 go mod init creates a 1.24.0 module1w
> I think we definitely need to do some more education about this.
It looks like this change never made it to the Go 1.26 release notes draft? Not seeing it at https://tip.golang.org/doc/go1.26#go-c…dmitshur opened an issue golang.org/x/build/cmd/relui: simplify HTTP route handling code by using net/http's pattern matching1w
The route handling code in relui was added before net/http was enhanced with pattern matching in Go 1.22 (https://go.dev/doc/go1.22#enhanced_routing_patterns). Relui can rely on 1.22+ being available…dmitshur commented on build: build failure on x_tools-go1.24-linux-arm64_c4as16-perf_vs_gopls_0_111w
CC @golang/tools-team, @mknyszek.
Though it seems this 1.24 issue can be closed as obsolete. The perf builder only runs for the latest released Go branch (1.25 at this time) as noted in https://gith…dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder1w
Overriding the output of `platform.machine()` to fix swarming bot's cipd_platform computation like that is a nice workaround. There is some chance of it breaking down the road, and you'd have to adap…dmitshur opened an issue golang.org/x/build/maintner: update serving of frozen mutation log fragments1w
As visible at https://maintner.golang.org/logs, maintnerd currently serves only the latest growing mutation log fragment itself, and otherwise points maintner clients to fetch the frozen mutation log…Earlier
dmitshur fixed an issue rsc.io/rf: Tests are failing with go1.19 and newer1w
This should be resolved by now. PR #39 updated to the latest stable version and tests are passing with it ([example run](https://github.com/rsc/rf/actions/runs/18895679490/job/53932491920)). CC @jits…dmitshur opened an issue golang.org/x/build: add darwin builders with macOS 26 (macOS Tahoe)1w
This is a tracking issue for adding darwin/arm64 and darwin/amd64 builders with macOS 26 (macOS Tahoe).
CC @golang/release, @golang/darwin.dmitshur commented on runtime: race detector crash on ppc64le2w
The original report said that tests started to fail after [go.dev/cl/712720](https://go.dev/cl/712720), which is new to 1.26, so does this apply to older releases? If so, is it only 1.25 that needs t…dmitshur closed an issue os: tests fail on ext4 with 128byte inodes due to insufficient time precision [1.25 backport]2w
Closing this for now as the upstream issue isn't resolved. Once that happens, we can revisit the backport request if it's still needed.dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder2w
> Cleared. Let's see if it helps when the next task arrives...
You may also want to try running the swarming bot with `CIPD_ARCHITECTURE=mips64le` set in the environment, and see if that helps. See …dmitshur commented on lib/fips140: freeze FIPS 140-3 module v1.1.0-rc12w
Also CC @dr2chase.dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder2w
The pool dimension value is fixed.
It might also be possible for us to override the incorrectly inferred cipd_platform value via configuration. Trying it out had effect, the https://chromium-swarm.a…dmitshur starred github.com/KaijuEngine/kaiju2w
dmitshur commented on golang.org/x/build: add LUCI linux-mips builder2w
Noting here that if a LUCI builder isn't added to provide test coverage for this port, it risks becoming broken without anyone noticing. There's signal provided by the legacy builders, but it's not v…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder2w
The builder page at https://chromium-swarm.appspot.com/bot?id=linux-mipsle-cip-united--1 shows its current state, and it's visible there that some of the dimensions will need adjustment:
1. Its "poo…dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder2w
Glad that you got to the bottom of the constant rebooting issue, and that the builder successfully connected.
The builder page at https://chromium-swarm.appspot.com/bot?id=linux-mips64le-cip-united-…dmitshur closed an issue runtime/pprof: StopCPUProfile causes SIGKILL on Linux kernel 6.122w
dmitshur commented on debug/pe: (*File).ImportedSymbols seeking to virtual address lacks bounds check before using VirtualAddress2w
Also CC @golang/windows.dmitshur commented on debug/pe: (*File).ImportedSymbols's ImportDirectory decoding implicitly assumes it can decode LittleEndian values when data might be short2w
CC @golang/windows.dmitshur commented on golang.org/x/pkgsite: pkg.go.dev/constraints works when maybe it should not2w
Thanks for reporting. That little triangle inside the "Latest" badge does say that the package doesn't exist in the latest version of the standard library, but admittedly it is small and pretty uncom…dmitshur pushed to
main in dmitri.shuralyov.com/service/change7modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust5y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle5ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)5y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y