Activity
Yesterday
dmitshur commented on golang.org/x/website: sha256sum for go1.25.4.linux-amd64.tar.gz download does not match14h
9fa5ffeda4170de60f67f3aa0f824e426421ba724c21e133c1e35d6159ca1bec is the right sha256 checksum for the go1.25.4.linux-amd64.tar.gz file. It can be reproduced with distpack by building Go 1.25.4 from s…Last Week
dmitshur closed a change path/filepath: [release-branch.go1.24] return cleaned path from Rel1d
Thanks for preparing the CL. Closing since the decision in #75817 is not to backport.dmitshur closed a change path/filepath: [release-branch.go1.25] return cleaned path from Rel1d
Thanks for preparing the CL. Closing since the decision in #75818 is not to backport.dmitshur commented on path/filepath: [release-branch.go1.25] return cleaned path from Rel1d
(1 comment)
No, this was just a temporary hold to make it clear that this CL was waiting on a decision to happen in the backport issue #75818. If the backport issue were approved, the hold would be …dmitshur commented on internal/syscall/windows: [release-branch.go1.25] fix ReOpenFile sentinel error value1d
In this case since Go 1.25.4 is released by now, yes, it is better to create a new backport issue to track this CL. The issue can say it's a follow-up fix for issue #75989 and provide a brief rationa…dmitshur starred github.com/u-root/cpu2d
dmitshur commented on os: ReadDir on regular file returns non nil slice on Windows3d
@stevenh I agree that it shouldn't be needed to skip tests, but I think it's possible to update them not to rely on undocumented behavior, while still checking the property you're looking to test. Se…dmitshur commented on github.com/stevenh/tracktools/chore: update modules3d
I left a few suggestions on how the test cases can be updated to not run into issue golang/go#75157. It should work without needing to skip those tests.
Consider this modified test case:
```diff
…dmitshur commented on internal/syscall/windows: [release-branch.go1.25] fix ReOpenFile sentinel error value3d
Please see https://go.dev/wiki/MinorReleases.
All backport CLs need an accompanying cherry pick issue with a rationale, which we'll need to review before the CL can land. I see the tip CL didn't hav…Earlier
dmitshur starred github.com/makeworld-the-better-one/dither/v21w
dmitshur commented on cmd/go: behaviour of "go doc" in module mode is not documented2w
CC @golang/command-line.dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder2w
That hostname should work well, thanks. Here is the corresponding certificate: [linux-mips64le-cip-united-1761320497.cert.txt](https://github.com/user-attachments/files/23127740/linux-mips64le-cip-un…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder2w
@Rongronggg9 Thank you for offering that builder to test the linux/mipsle port. Its hardware should work as long as it provides useful signal. Does all.bash pass on it with GOOS=linux GOARCH=mipsle a…dmitshur opened an issue cmd/dist: test -json emits some non-JSON lines for packages without tests2w
When the -json flag is used with `go tool dist test` (added in #37486), it's expected to only write JSON lines.
There seems to be a path where some non-JSON is written to stdout too, which is a bug:…dmitshur closed an issue cmd/compile: any(func(){})==any(func(){}) does not panic but should [1.24 backport]2w
dmitshur fixed an issue golang.org/x/build/internal/relui: TestRelease/major failures2w
Fixed in [CL 711920](https://go.dev/cl/711920).dmitshur closed an issue riscv64: can't build on FreeBSD with cgo [1.24 backport]2w
Closing for now because the freebsd/riscv64 port is [marked broken](https://cs.opensource.google/go/go/+/master:src/cmd/dist/build.go;l=1830;drc=6f4c63ba63fdec6e4a42e2e19ac71937973dedef) at tip and […dmitshur commented on path/filepath: Rel returns non-Clean'ed path. [1.24 backport]2w
Asked for a more detailed backport rationale in https://github.com/golang/go/issues/75763#issuecomment-3433007301.dmitshur commented on path/filepath: Rel returns non-Clean'ed path. [1.25 backport]2w
Asked for a more detailed backport rationale in https://github.com/golang/go/issues/75763#issuecomment-3433007301.dmitshur commented on path/filepath: Rel returns non-Clean'ed path2w
@kolyshkin What's the reason to suggest backporting this issue? We'd need a bit more information to review the backport request.
Our backporting criteria is documented at https://go.dev/wiki/MinorRe…dmitshur commented on builders: linux-mipsle/linux-mips64le builders are missing2w
@MingcongBai Yes, please do.
In general, you could reuse an existing open issue for a given GOOS/GOARCH pair and move on to step 2 at https://go.dev/wiki/DashboardBuilders#how-to-set-up-a-builder (g…dmitshur commented on builders: linux-mipsle/linux-mips64le builders are missing2w
Also see tracking issues #67304 and #67306.dmitshur opened an issue cmd/compile/internal/importer: data race in TestIssue69912 as of CL 6959773w
This is being reported by race builders across various ports at tip:
```
=== RUN TestIssue69912
==================
WARNING: DATA RACE
Write at 0x00c0001aa098 by goroutine 1118:
cmd/compile/inter…dmitshur commented on golang.org/x/pkgsite: still no update for > 2h and counting after a new tag is available on proxy and requested3w
CC @golang/pkgsite.dmitshur commented on cmd/go: `go tool` doesn't list nm, objdump and pprof3w
CC @golang/command-line.dmitshur commented on cmd/pprof: incorrect CPU profile graph3w
CC @golang/runtime, @cherrymui.dmitshur commented on cmd/compile/internal/inline/inlheur: dumpscores test failure3w
Thanks for the report. Does the failure happen reproducibly or intermittently for you?
It seems not to happen on the linux/amd64 builder ([here](https://ci.chromium.org/ui/p/golang/builders/ci/gotip…dmitshur commented on cmd/go: work edit -json doesn't include the toolchain3w
CC @golang/command-line.dmitshur commented on compress/flate: size optimization of final deflate block (btype 0 -> btype 1)3w
CC @dsnet, @mdempsky.dmitshur commented on net/http/httputil: ReverseProxy stuck forever when handling request with expect: 100-continue header and upstream connection creation fails3w
CC @neild, @thatnealpatel.dmitshur commented on cmd/go: env should report GOPACKAGESDRIVER3w
CC @golang/command-line.dmitshur commented on os: on windows RemoveAll removing directories containing read-only files errors with `unlinkat ... Access is denied`3w
CC @golang/windows, @griesemer, @neild.dmitshur commented on path/filepath: improve `Rel`'s documentation3w
CC @robpike, @rsc.dmitshur commented on github.com/actions/setup-go: Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang3w
Thanks for doing that!
From my perspective, changing download URLs from `https://storage.googleapis.com/golang/{file}` to `https://go.dev/dl/{file}` is the right thing to do, so I'll leave further…dmitshur commented on github.com/actions/setup-go: Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang3w
Consider using https://go.dev/dl/ itself and following the redirects. It's likely that https://dl.google.com/go/ will remain current for a long time, but if it ends up changing in the future, this wi…dmitshur commented on github.com/actions/setup-go: storage.googleapis.com/golang no longer allows anonymous access causing 403 on Golang download fallback3w
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur commented on github.com/microsoft/azure-pipelines-tasks/[BUG]: gotooling task cannot download go distribution3w
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur commented on golang.org/x/build: add Debian Trixie builders3w
The linux/arm64 trixie builder is up (with a known issue) and seems to be running into some problem with its C toolchain. Some of the packages fail with "running gcc failed [...] cannot find ‘ld’…dmitshur commented on go/version: does not support the `X:` suffix from `go env GOVERSION`3w
Package [go/version](https://pkg.go.dev/go/version) is documented to operate on Go versions in Go toolchain name syntax, which is defined at https://go.dev/doc/toolchain#name as:
> The standard Go t…dmitshur commented on github.com/coder/internal/flake: macOS Go setup failure - illegal byte sequence during tar extraction3w
Note that the official Go distributions can be downloaded (following redirects) using URLs at https://go.dev/dl/, which follow the pattern `https://go.dev/dl/{file name}`. Attempting to download thos…dmitshur commented on github.com/google/oss-fuzz: base images not building3w
Yes, "getgo" was an experimental tool that was deprecated and removed in 2024, see Go proposal golang/go#60951. It should work to download (following redirects) using the URLs at https://go.dev/dl/, …dmitshur opened an issue golang.org/x/build: update Debian sid builder past trixie3w
Our current Debian sid builders were last updated at a time when they were close to Debian Trixie's release, and their reported OS dimension value is "Debian-13". This prevents us from adding stable …dmitshur commented on golang.org/x/build: add Debian Trixie builders3w
I started [crrev.com/i/8675857](https://crrev.com/i/8675857) to add internal configuration for the new Debian Trixie builder images, and ran into an issue that our current Debian sid builder reports …dmitshur pushed to
main in dmitri.shuralyov.com/service/change5modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl4ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust5y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle5ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)5y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes5ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.