Activity
Yesterday
dmitshur commented on 
github.com/go-gl/glfw: disable unsupported setting of window icon on wayland13h
github.com/go-gl/glfw: disable unsupported setting of window icon on wayland13h
This line seems to be malformed. Maybe it was intended to be `// +build`. In any case, I think it should be removed. All current versions of Go can handle build constraints specified via just the `//…dmitshur commented on github.com/go-gl/glfw: GLFW v3.413h
Thanks for working on this.
> I used the short Custom Cursor program for testing. It would probably be a good idea to test with other programs, as well. Does anyone have such test programs?
It'…Last Week
dmitshur commented on golang.org/x/build/...: modernize build constraints2d
Thanks.dmitshur opened a change golang.org/x/build/main.star: remove known issue for darwin-amd64_14 security builder3d
By now everything should be set up for it to work okay.
For golang/go#67073.dmitshur reviewed +2 on golang.org/x/build/cmd/relui: switch back to hardcoded private gerrit3d
Thanks.
Given we moved towards aligning the repo names between the public and internal Gerrit hosts (i.e., it's just "go", "net", etc., in both), this can stay as "go". But it's also harmless to giv…dmitshur commented on golang.org/x/build/main.star: update protobuf deps to v27.0-rc13d
Thanks for doing this update.
A few notes about what's changed on our side since the last time:
- you can now run `go generate` to regenerate (under the hood, it runs main.star, so either way is ok…dmitshur commented on golang.org/x/build/cmd/makemac: add first security macOS trybot3d
Thanks.dmitshur commented on cmd/vendor: update x/tools to v0.20.1-0.20240429173604-74c9cfe4d22f3d
For future reference: this comment had no effect—you can tell because there's no 'gotip-linux-amd64-longtest' builder in the Checks tab.
My review comment didn't make it very clear, sorry, but tha…dmitshur closed a change cmd/vet: vendor stdversion analyzer3d
The stdversion analyzer is vendored via CL 582555, and the minor release note change can be done in a future release note edit pass.dmitshur commented on cmd/vet: vendor stdversion analyzer3d
Hold since CL 582556 is on its way to be reverted (and this shouldn't be submitted then).dmitshur commented on cmd/vendor: update x/tools to v0.20.1-0.20240429173604-74c9cfe4d22f3d
(1 comment)
Sounds good. FWIW at least the Go repo tests passed in CL 582995. I'll put a hold on it since it shouldn't be submitted while this is reverted.dmitshur reviewed +2 on Revert "cmd/vet: add stdversion analyzer"3d
Thanks.
https://go.dev/wiki/CommitMessage#reverts suggests:
> Gerrit will generate a description for you. Edit the description to add the Gerrit CL number being rolled back next to or instead of th…dmitshur commented on cmd/vet: vendor stdversion analyzer3d
The failed test has a history of occasionally failing (#66427); it's not caused by the changes in this CL.dmitshur reviewed +2 on cmd/vendor: update x/tools to v0.20.1-0.20240429173604-74c9cfe4d22f3d
LGTM modulo a rebase and having a longtest builder. Thanks.
Longtest builders should be added automatically here since go.mod is modified (see CL 547596), but for some reason they're not. For now, l…dmitshur commented on cmd/vet: vendor stdversion analyzer3d
Oh, I see why trybots didn't catch this. That CL was tested on top of CL 582555 which did vendor this package, but hasn't been submitted yet. Feel free to proceed with that CL instead of this one.dmitshur opened a change cmd/vet: vendor stdversion analyzer3d
Vendor the package that's imported by cmd/vet as of CL 582556.
Also use the main pkg.go.dev instance in the release note.
For #46136.dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: remove obsolete build tag3d
Thanks.
We have quite a few more instances of go1.16. It was added back when Go 1.15 was still supported generally, but we were okay with making coordinator require 1.16 sooner. No one got around to…dmitshur opened a change golang.org/x/build/...: modernize build constraints3d
We've only ever used build constraints to increase the minimum required
Go version. For example, CL 336390 in 2021 bumped them to go1.16 to use
//go:embed sooner. By now, the 'go' directive in go.mod…dmitshur reviewed +2 on golang.org/x/build/recipes: autoroll dependencies3d
dmitshur reviewed +2 on golang.org/x/build/main.star: add infra failure notifications for netbsd-arm*3d
Thanks.
Is it fairly harmless to add this now, before the builder has been finished (#63698)? I.e., confirming that it won't start sending INFRA_FAILURE mail on each commit now, since that doesn't s…dmitshur reviewed +2 on golang.org/x/build/tricium_simple: remove HTTPS checker3d
Thanks.
Consider mentioning the tracking issue for adding checks (#18548), even though this instance happens to be moving into the opposite direction for now.dmitshur commented on golang.org/x/build/main.star: permit makemac to list security bots4d
Thanks.dmitshur opened a change golang.org/x/build/main.star: permit makemac to list security bots5d
It needs read-only access to list bots in chrome-swarming, so it
can know whether to launch or renew or destroy MacService leases.
For golang/go#67073.dmitshur commented on golang.org/x/build/main.star: add darwin-amd64_14 builder to the internal host5d
Thanks.dmitshur reviewed +2 on os: remove ineffective else branch6d
Thanks.dmitshur commented on golang.org/x/build: add LUCI openbsd-ppc64 builder6d
As long as you still have `LUCI_MACHINE_TOKEN` set as needed in the environment, you should be able to drop the `-token-file-path` flag. It used to be required to set both to the same value, and the …dmitshur pushed to
main in github.com/shurcooL/githubv41w
Earlier
dmitshur closed a change runtime/atomic: fix TestAnd64 and TestOr64 on 32-bit architectures1w
Thanks for sending this change. CL 581916 ended up applying the same change as here, so there's nothing more to do here.dmitshur reviewed +2 on testing: use time.Since in highPrecisionTime1w
dmitshur reviewed +2 on testing: use time.Since in highPrecisionTime1w
Thanks.
Please add a mention of the tracking issue, so this change will be easier to find:
```
For #31160.
```dmitshur commented on testing: use QueryPerformanceCounter on Windows1w
(1 comment)
Is it intentional this is implemented as `time.Now().Sub(b.now)` instead of `time.Since(b.now)`? As far as I can tell, that skips over the optimization in https://cs.opensource.google/go…dmitshur reviewed +2 on go.dev/wiki/CodeReview.md: remove RELNOTE=1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/relnote: improve todo subcommand1w
Thanks.
If you install the latest version of the codereview hooks, and amend:
```
go install golang.org/x/review/git-codereview@latest && \
git codereview hooks && \
git commit --amend --no-edit
``…dmitshur closed an issue golang.org/x/build/devapp: support R= annotations in commit messages1w
The Gerrit hashtag `wait-release` has replaced the old R=go1.N syntax (see https://github.com/golang/go/issues/24836#issuecomment-497090827), and so R= isn't used anywhere by now. Issue #24836 tracks…dmitshur commented on golang.org/x/build/cmd/relnote: improve todo subcommand1w
(1 comment)
Probably a good time to update the package comment to refer to its new behavior.dmitshur commented on golang.org/x/build/cmd/relnote: improve todo subcommand1w
As a first pass, looks good. Tests don't build now; I'll look again after you update it for that.
```suggestion
if rn == "yes" || rn == "y" {
```
To match https://cs.opensource.google/go/x/bui…dmitshur closed an issue doc: write release notes in the same CL as the code change1w
This is implemented as of the Go 1.23 cycle by @jba, see issue #64169 and a [golang-dev thread](https://groups.google.com/g/golang-dev/c/Ia9VoYBTRoI).dmitshur commented on golang.org/x/build/cmd/makemac: add first security macOS trybot1w
(1 comment)
Done. Also granted access to makemac's service account.dmitshur commented on golang.org/x/build/cmd/makemac: add first security macOS trybot1w
(1 comment)
Adding a hold to create these secrets.dmitshur opened a change golang.org/x/build/cmd/makemac: add first security macOS trybot1w
For golang/go#67073.dmitshur opened a change golang.org/x/build/main.star: add security-only known issues1w
The next CL adds the darwin-amd64_14 builder type to the security trybot
environment. I'd like it to have a known issue set to begin with, so add
a SECURITY_KNOWN_ISSUE_BUILDER_TYPES dictionary and p…dmitshur opened a change golang.org/x/build/main.star: add darwin-amd64_14 builder to the internal host1w
A new distinct set of VMs will be used for security pre-submit
and release testing. Start with one builder with a known issue.
For golang/go#67073.dmitshur reviewed +2 on doc/README.md: discourage RELNOTE in CLs1w
Thanks.dmitshur opened an issue golang.org/x/build: add macOS security trybots to LUCI1w
We have macOS builders in LUCI, but they're not yet available as security trybots. This is the tracking issue for that.dmitshur closed an issue golang.org/x/build/cmd/gitmirror: service problem on 2024-04-231w
dmitshur commented on golang.org/x/build/cmd/gitmirror: service problem on 2024-04-231w
That error doesn't provide detail but suggests an internal problem in git, possibly related to insufficient resources. We hadn't increased gitmirror's resources in a while.
That said, after redepl…dmitshur opened an issue golang.org/x/build/cmd/gitmirror: service problem on 2024-04-231w
Reporting for posterity and in case this comes up again. https://farmer.golang.org/#health was reporting a problem with Git mirroring on 2024-04-23:
. So I agree it seems this needs more investigation. Also see past discussion in https://github.com/glfw/glfw/issues/2133 and htt…dmitshur commented on os/exec: calling Cmd.Start after setting Cmd.Path manually to absolute path without ".exe" no longer implicitly adds ".exe" in Go 1.221w
@joedian It was a draft CL associated with a review comment. Russ has [go.dev/cl/575255](https://go.dev/cl/575255) which is still open but needs attention.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1wdmitshur commented on go/format: line comment not indented properly after indented statement1w
This is similar to (or the same as) #12822 and likely some more gofmt issues. Also consider this instance:
```Go
switch {
case true:
// comment 1
// comment 2
// comment 3
// comment 4
/…dmitshur commented on github.com/go-gl/glfw: Remove warning/errors about undefined functions1w
Seems okay to me.
We had this in v3.2 but didn't propagate it forward to v3.3:
https://github.com/go-gl/glfw/blob/a69d953ea14231b2f19998f0b434b6c1e6c6f710/v3.2/glfw/build.go#L25-L26
(It was …dmitshur commented on github.com/sublimehq/sublime_merge: `safe.bareRepository = explicit` makes it impossible to "Edit Commit Message"1w
This still happens with Build 2096 for me.
I also noticed something strange: this happens reproducibly as soon as I change safe.bareRepository to explicit on my primary macOS machine (so I'm unabl…dmitshur closed an issue golang.org/x/vuln: TestGoModTidy failures1w
I've de-duplicated this into #58766; its pattern now also matches the failures from here.dmitshur commented on golang.org/x/vuln: TestGoModTidy failures1w
This is the same failure mode as in #58766. It's a problem only in the old build infrastructure.dmitshur closed an issue golang.org/x/build: gotip-windows-arm64 builders stops working1w
From what I can tell, SWARMING_NEVER_REBOOT has effect for most frequent reasons that would otherwise cause the reboot to happen, but it doesn't catch all. The swarming bot seems to occasionally trig…dmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1w
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1w
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur commented on golang.org/x/build: include all first-class ports in TryBot coverage for x repos against previous Go releases2w
[CL 568197](https://go.dev/cl/568197) added previous Go release coverage for 3 more first-class ports: linux/386, darwin/amd64, and windows/amd64.dmitshur starred github.com/emer/gosl/v22w
dmitshur commented on access: Application to join golang/mips maintainer team2w
Also CC @golang/mips (for completeness; almost everyone in it was already CC'ed).dmitshur commented on all: announce end of support for old macOS releases2w
[CL 563856](https://go.dev/cl/563856) added a note to Go 1.23 release notes, moving to the next.dmitshur starred github.com/nishanths/exhaustive2w
dmitshur opened an issue crypto/internal/mlkem768: TestPQCrystalsAccumulated fails on linux/s390x3w
[CL 550215](https://go.dev/cl/550215) added a new package. One of its tests, `TestPQCrystalsAccumulated`, is failing on the linux/s390x port:
```
--- FAIL: TestPQCrystalsAccumulated (0.07s)
…dmitshur commented on access: may-start-trybots and approvers3w
@panjf2000 The Auto-Submit+1 vote is documented at https://go.dev/wiki/GerritAccess#auto-submit. I meant you can ask the person who left the +2 vote to either submit or leave Auto-Submit+1 vote—but…dmitshur starred fyshos.com/fynedesk3w
dmitshur closed an issue access: may-start-trybots and approvers3w
Hi @panjf2000, thanks for contributing to the Go project and asking for approvers access again.
We considered this request. As documented at https://go.dev/wiki/GerritAccess, Gerrit "approvers" ac…dmitshur closed an issue time: clean up duplicate definitions `time.runtimeTimer` and `runtime.timer` that need to be kept in sync3w
This is fixed via [CL 568339](https://go.dev/cl/568339), which removed the duplication.dmitshur closed an issue access: go-assignees and go-editors3w
Hi @qiulaidongfeng, thanks for your interest and contributions to Go.
We considered this request. Similarly to https://github.com/golang/go/issues/66611#issuecomment-2052070282, when considering g…dmitshur closed an issue access: +2 approval in CLs3w
Hi @mauri870, thanks for contributing to the Go project and asking for this access.
We considered this request and felt your contribution history demonstrates enough signals for us to be close to …dmitshur closed an issue access: approvers3w
Hi @qiulaidongfeng, thanks for your interest and contributions to Go.
We considered this request (previously considered in #64255). As documented at https://go.dev/wiki/GerritAccess, Gerrit "appro…dmitshur closed an issue access: Requesting Try-Bots Access and Self-Assign Github Issues3w
Hi @raghvenders, thanks for your contributions to Go so far.
We discussed this request. We generally look for contributors to have a more established track record of contributions before consideri…dmitshur closed an issue golang.org/x/build/cmd/gomote: install builder dependencies by default3w
This is resolved as of [CL 569875](https://go.dev/cl/569875). (It didn't get closed automatically because the Fixes line didn't specify the `golang/go` repo quite right.)dmitshur starred github.com/aclements/go-obj3w
dmitshur commented on golang.org/x/net/http/httpguts: validation of header names, methods, and cookie names could be about twice as fast3w
@jub0bs Yes, your understanding is right and generally it's good to allow some time for discussion on the issue first, though it's still okay to send a change sooner. There are some more details abou…dmitshur starred github.com/cloudpilot-emu/cloudpilot-emu4w
dmitshur starred github.com/migueletto/PumpkinOS4w
dmitshur commented on golang.org/x/build: add LUCI wasip1-wasm32-wasmtime builder4w
Thanks. Confirming a few details.
`GOARCH` should be `wasm32` instead of `wasm`, is that right?
Related to the above—will `GOROOT/misc/wasm` be used for both `wasm` and `wasm32` exec helpers? Tha…dmitshur starred github.com/FiloSottile/FiloSottile4w
dmitshur closed an issue access: may-start-trybots1mo
Hi abner chenc,
Thanks for your contributions and helping maintain the linux/loong64 port. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybot…dmitshur commented on net/http: TestRequestLimit/h2 becomes significantly more expensive and slower after x/net@v0.23.0 [1.22 backport]1mo
> should backport the fix as well
To clarify, do you think the fix to be backported should include changes in [CL 576756](https://go.dev/cl/576756) and [CL 576895](https://go.dev/cl/576895)?dmitshur commented on go/types: issue with using const with implicit unint641mo
CC @griesemer, @findleyr.dmitshur commented on golang.org/x/website: release notes for Go 1.22 mentions inexistent math/rand/v2.Uint()1mo
Thanks for reporting this.
CC @rsc.dmitshur commented on cmd/compile: unnecessary runtime.growslice with provable capacity1mo
CC @golang/compiler.dmitshur commented on cmd/compile: unnecessary bounds check with slice offset1mo
CC @golang/compiler.dmitshur commented on go/types: Identical function doesn't work for SSA loaded type1mo
CC @griesemer, @findleyr.dmitshur commented on golang.org/x/build: add LUCI linux-ppc64_power8 builder1mo
Here's the certificate: [linux-ppc64-power8-1712341779.cert.txt](https://github.com/golang/go/files/14889449/linux-ppc64-power8-1712341779.cert.txt).
I'll also work on another CL needed for that h…dmitshur commented on golang.org/x/build: add LUCI linux-ppc64-power10 builder.1mo
@pmur Should this issue also be closed, or is there more to do for it?dmitshur commented on golang.org/x/build: add LUCI linux-ppc64le-power10 builder1mo
Thank you very much @pmur. I've mailed you [go.dev/cl/576917](https://go.dev/cl/576917) to remove its known issue.dmitshur opened an issue cmd/coordinator/internal/lucipoll: occasionally gets stuck (for upwards of 24 hrs)1mo
The `pollLoop` method that runs in a loop usually takes a minute, but sometimes seems to get stuck and eventually completes in just over 24 hours without any error. This is a tracking issue to sort t…dmitshur opened an issue golang.org/x/tools/gopls/internal/test/marker: 1mo
The definition/embed.txt, definition/misc.txt, and hover/sizeoffset.txt cases of `Test` are failing on linux/arm (32-bit) since they were introduced in [CL 573076](https://go.dev/cl/573076).
For e…dmitshur commented on net/http: data race in multiple tests1mo
The two instances above were on release-branch.go1.22.