Activity
Today
dmitshur reviewed +2 on cmd/go: return non-zero when go tool is interrupted56m
Thanks.
@olivier.mengue@gmail.com See comments Russ and I left on issue #13440 about why it's difficult to do better.
@sean@liao.dev This seems like a bigger question and discussion. `go run` could…Yesterday
dmitshur commented on os: running "go test os -short" command fails13h
@alexbrainman Your understanding above about longtest builders is right. Only builders with the "longtest" runtime modifier run `go test` without `-short` flag. All other builders run `go test -short…dmitshur commented on os: make tests pass even without Administrator account13h
(3 comments)
Consider changing this to:
```
// hasLink reports whether the test filesystem ...
func hasLink ...
```
Based on https://go.dev/s/style#mixed-caps.
Since the first two return values f…dmitshur closed a change golang.org/x/mobile: Create SECURITY.md18h
Last Week
dmitshur closed a change golang.org/x/mobile: Create SECURITY.md1d
dmitshur starred github.com/AlekSi/xfail1d
dmitshur reviewed +2 on cmd/go: return non-zero when go tool is interrupted1d
Thanks.
This is pretty minor so either one will do. `go 1.24.0` is fine because this go.mod file uses `tool` directives and those were introduced in Go 1.24, so it can't be lower than that. `go 1.26…dmitshur commented on golang.org/x/build/main.star: limit scope of slow openbsd-riscv64 host to go, net, sys1d
Thanks.dmitshur commented on golang.org/x/build/cmd/gopherbot: apply the FixPending label to issues with pending cls2d
(3 comments)
Have you tried running this task locally with -dry-run flag? Does the output match your expectations?
How long does it take to run? There's quite a bit of regexp matching. Some of the …dmitshur commented on golang.org/x/build/cmd/gopherbot: track Gerrit "Fixes" CLs by applying the "FixPending" label2d
This sounds like a useful automatic behavior. It would help make existing CLs (or lack thereof) easier to see, and it would reduce some of the toil involved in [issue gardening](https://go.dev/wiki/G…dmitshur reviewed +2 on golang.org/x/build/internal/task: remove leading newline in fake binary def2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: label Automation when opening a new issue2d
Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes: label open issues2d
I agree that -author:gopherbot is probably a reasonable way to filter out such issues. Still, since the Automation label exists and its description matches, watchflakes might as well use it.
Note th…dmitshur commented on cmd/go: return non-zero when go tool is interrupted2d
Thanks for finding where exactly in the tool layer the problem was. I left some minor suggestions.
I'm a bit surprised that this exported function isn't documented. https://go.dev/doc/comment sugges…dmitshur commented on golang.org/x/build: extend main Go repo's "every vet check is forcibly made high-confidence" behavior to golang.org/x modules2d
Yes, we can also implement it that way.dmitshur commented on golang.org/x/build: go vet std cmd2d
My recollection of the current behavior from issue #74011 is that:
- in the main Go repository, `go test` has a special case to run almost all vet checks that `go vet` would run, not only the usual …dmitshur commented on golang.org/x/build: extend main Go repo's "every vet check is forcibly made high-confidence" behavior to golang.org/x modules2d
It seems that the recent #79622 is another instance of friction caused by skew, though a slightly different case compared to the more common vendoring case described here.
Based on discussion above,…dmitshur commented on golang.org/x/build/devapp/owners: add primary owners for x/review2d
Thanks.
I interpret no comment from Austin as no objection, but otherwise I can follow up. Submitting. (Even if our code owner tracking system is imperfect, this should make it slightly more useful …dmitshur commented on go/types: add String methods2d
Note that the TestAPIConsistency test in golang.org/x/exp/typeparams starts to fail at tip as of this change:
```
=== RUN TestAPIConsistency
typeparams_test.go:46: "*Instance.String": got func…dmitshur reviewed +2 on .github: update PULL_REQUEST_TEMPLATE to match the latest instruction2d
Thanks for doing this. A few minor suggestions.
Let's remove 'under' to keep this in sync with the other template, and s/./,/ too.
```suggestion
+ Keep the title as short as possible, ideally 72 …dmitshur reviewed +2 on golang.org/x/dot-github/.github: add default PR template2d
Thanks.dmitshur reviewed +2 on golang.org/x/vulndb/...: bump x/net to 0.55.02d
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove get_404_meta net dependency2d
Thanks.
One of the https://pkg.go.dev/net/http#ResponseWriter behaviors is that:
> If WriteHeader is not called explicitly, the first call to Write will trigger an implicit WriteHeader(http.StatusO…dmitshur commented on golang.org/x/build/internal/task: don't consider misc-compile builder signal when tagging2d
Thanks.dmitshur opened a change golang.org/x/build/internal/task: don't consider misc-compile builder signal when tagging2d
Misc-compile builders are primarily intended for pre-submit, to help
quickly catch cases when a non-first class port (one that may not have
a builder in the default pre-submit builder set) starts to …dmitshur opened a change golang.org/x/build/main.star: remove known issue for x_net-gotip-linux-amd64-misccompile2d
It was fixed in CL 781920.
For golang/go#79605.
For golang/go#79607.dmitshur commented on golang.org/x/dot-github/.github: add default PR template2d
(1 comment)
Since this sentence talks about "repo other than golang/go", it might be more helpful to show an example of that. Maybe vscode-go is a reasonable example of a Go repo with its own dedica…dmitshur reviewed +2 on golang.org/x/dot-github/.github: add default PR template3d
Thanks.
Is the reason this file is placed in a .github/PULL_REQUEST_TEMPLATE directory so that if we want later on to add another template, the diff will be smaller? Right now it's a single template…dmitshur reviewed +2 on syscall: add export linknames for socketcall on S390X3d
Thanks.dmitshur reviewed +2 on syscall: add export linknames for socketcall on S390X3d
Thanks.
It's true that these are accessed via assembly in x/sys/unix (and in x/net/internal/socket) for linux/386. However, on linux/390x, they don't seem to be accessed in x/sys/unix at all, only i…dmitshur reviewed +1 on golang.org/x/vulndb/data/reports: add 1 first-party report3d
(1 comment)
The fix for the PUBLIC-track issue #78916 (CVE-2026-39824), CL 770080, was submitted on April 23rd. It got picked up when the monthly tagging workflow ran on May 8th and tagged x/sys at …dmitshur opened an issue golang.org/x/build/internal/task: TagXReposTasks.findMissingBuilders should consider individual ports within -misccompile builders3d
The tagging workflow's findMissingBuilders method already has logic to block on failures within first-class ports. A -misccompile builder may fail due to any number of port(s) running into a problem,…dmitshur opened an issue syscall, x/net/bpf, x/net/icmp, x/net/internal/socket, x/net/ipv{4,6}: package tests fail to build on linux/s390x at tip with "invalid reference to syscall.socketcall"3d
Based on https://ci.chromium.org/p/golang/g/x-net-gotip-by-go/console?limit=200, it seems that Go tip (1.27 to be) starting with [CL 761481](https://go.dev/cl/761481) runs into a build error in x/net…dmitshur reopened an issue runtime: `SIGSEGV` with a c-shared library and called from C#3d
Would it be worthwhile to try making the 32K → 16K change @ianlancetaylor suggested in https://github.com/golang/go/issues/78883#issuecomment-4310496625? It's hard to track this issue since it's cu…dmitshur reopened an issue runtime: `SIGSEGV` with a c-shared library and called from C#3d
Would it be worthwhile to try making the 32K → 16K change @ianlancetaylor suggested in https://github.com/golang/go/issues/78883#issuecomment-4310496625? It's hard to track this issue since it's cu…dmitshur fixed an issue cmd/link/internal/ld: TestAbstractOriginSanity failures4d
dmitshur fixed an issue cmd/link/internal/ld: TestAbstractOriginSanity failures4d
The original failure from Jan 8 was likely due to #77515,
and today's failures were handled by [CL 780760](https://go.dev/cl/780760)
(issue #79547 tracks the problem and removing the skip; CC @prattm…dmitshur commented on cmd/link/internal/ld: TestAbstractOriginSanity failures4d
The original failure from Jan 8 was likely due to #77515,
and today's failures were handled by [CL 780760](https://go.dev/cl/780760)
(issue #79547 tracks the problem and removing the skip; CC @prattm…dmitshur commented on cmd/go: clean should honor the -o flag as a build parameter so it can remove the final built artifacts4d
@matloob Is this intended to be a [proposal](https://go.dev/s/proposal)? It's in the Proposal milestone, but doesn't have a "proposal: " prefix in the title nor Proposal label. I fixed that assuming …dmitshur commented on cmd/dist: all.bash does not fail when run.bash fails4d
As a baseline, the `go test` command does return a non-zero exit code on Ctrl+C (SIGINT):
```shell
src $ go test all
ok archive/tar (cached)
ok archive/zip (cached)
ok bufio (cached)
^C
src $ …dmitshur opened an issue cmd/go: sending an interrupt signal (SIGINT) to a go tool invocation of a tool causes it to return with a zero exit code4d
Here's a small reproducer for `go tool` itself, found while looking into #79535:
```shell
$ cd $(mktemp -d)
$ go mod init test && go get go@1.26.0
$ mkdir -p cmd/importantwork && echo 'package main;…dmitshur commented on cmd/compile: Bug in rewrite rules for AMD64 causes SHL instruction overflow and miscompilation [1.25 backport]5d
The Critical label tracks upstream issues; it was applied there (https://github.com/golang/go/issues/79182#event-25767278742) so removing it here.dmitshur commented on cmd/compile: Bug in rewrite rules for AMD64 causes SHL instruction overflow and miscompilation [1.26 backport]5d
The Critical label tracks upstream issues; it was applied there (https://github.com/golang/go/issues/79182#event-25767278742) so removing it here.Earlier
dmitshur commented on net/http: deflake HTTP/3 tests1w
[CL 777921](https://go.dev/cl/777921) added a test skip for now, so removing release-blocker label (for Go 1.27) and moving to early-in-cycle Go 1.28.dmitshur commented on golang.org/x/text/unicode/bidi: DefaultDirection(LeftToRight) is silently ignored1w
@qsq8t65pxs It's important for backport requests to include a rationale - please see https://go.dev/wiki/MinorReleases. This issue is about a package in x/text; is there involvement of the standard l…dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes5y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6y