Activity
Yesterday
dmitshur commented on golang.org/x/tools/gopls/internal/debug: integrate flight recorder4h
For clarity, that CL is a merely an automated mechanical concatenation of .txt files. The API audit is tracked in an issue, #73918 in this case, and it's currently underway.
Note that the TestFlight…dmitshur closed an issue os: TestRootRemoveDot failing on Plan 96h
dmitshur commented on golang.org/x/website/_content/doc: update Go 1.25 release notes for spec changes9h
(1 comment)
(I meant for this to be a resolved comment; it's just for reference. Marked it resolved.)dmitshur reviewed +2 on golang.org/x/website/_content/doc: update Go 1.25 release notes for spec changes9h
Thanks.
For reference, this was the heading used in Go 1.24 (and older) release notes.
Just checking: in previous release notes this heading was typically named "Changes to the language". Is adding…dmitshur reopened an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs9h
Need to grant the gobot account a permission for the TryBot-Bypass label, since it is being used by it now. Reopening for that.dmitshur reviewed +2 on golang.org/x/arch/s390x/s390xasm: fix failing vet check for self assigment9h
Thanks.dmitshur reviewed +2 on golang.org/x/crypto/ssh/test: skip KEX test if unsupported by system SSH client10h
(1 comment)
Sorry, that suggestion should've been:
```suggestion
Change-Id: I3fac703ec70559e18b30d5fff88274335a7c3952
Cq-Include-Trybots: luci.golang.try:x_crypto-gotip-linux-amd64-longtest,x_crypt…dmitshur reviewed +2 on golang.org/x/crypto/ssh/test: skip KEX test if unsupported by system SSH client10h
Thanks.
Consider making at least these two longtest builders mandatory, which can be done with the `Cq-Include-Trybots` footer:
```suggestion
Change-Id: I3fac703ec70559e18b30d5fff88274335a7c3952
Cq…dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.25: add release note for go version -m -json11h
Thanks.dmitshur commented on all: update vendored dependencies [generated]11h
Thanks for confirming that the vet check is working as intended. So the next step for the x/arch problem is to fix it in x/arch and pull in the newer version.
> If the main repo requires that all it…dmitshur opened an issue golang.org/x/build: extend main Go repo's "every vet check is forcibly made high-confidence" behavior to golang.org/x packages that are vendored (or exclude vendored packages from it)11h
The `go test` command normally runs a select subset of vet checks, and fails the test if any of them fail.
In the main Go repo, to aid development, that behavior is forcibly modified to have all vet…dmitshur commented on golang.org/x/crypto/ssh: add server side support for Diffie Hellman Group Exchange11h
(1 comment)
@nicola.murino@gmail.com Note that this test is failing on Linux and macOS at Go 1.24 and at tip:
https://ci.chromium.org/p/golang/g/x-crypto-gotip/console
https://ci.chromium.org/p/gol…dmitshur opened a change golang.org/x/example/go.mod: update golang.org/x dependencies12h
Updating to a newer x/tools version fixes a build error at Go tip:
$ go version
go version go1.25-devel_eebae283b6 Mon Jun 2 15:28:33 2025 -0700 darwin/arm64 # CL 675736
$ go test -c -o=/dev/null .…dmitshur commented on golang.org/x/open2opaque/...: update golang.org/x dependencies12h
(1 comment)
I've looked a bit more and I have a better sense of what happened.
The [Go 1 compatibility promise](https://go.dev/doc/go1compat#expectations) says there are some ways that future relea…dmitshur commented on golang.org/x/text/go.mod: update tagx:ignore'd golang.org/x dependencies13h
It looks like the golang.org/x/example/gotypes packages are the only other remaining x/ repo that's running into this. I'll make an equivalent CL for it.dmitshur commented on golang.org/x/text/go.mod: update golang.org/x dependencies13h
Done in Ie6be2f827ba7e49f6d8469e9a53f314b4247759d.dmitshur commented on golang.org/x/text/go.mod: update golang.org/x dependencies13h
Thanks. This looks similar to CL 678895, I'll prepend a CL to fix it.This Week
dmitshur commented on all: update vendored dependencies [generated]1d
The mechanics of how this CL is generated are good, but there are test/vet failures that need attention: cmd/go.TestScript/test_json_build newly fails, and the vendored golang.org/x/arch/s390x/s390xa…dmitshur reviewed +2 on golang.org/x/website/_content: link to spec in header1d
I think it's subjective what should make the cut in that dropdown list, and what shouldn't, but this seems reasonable. Okay with me to try it. Thanks.dmitshur reviewed +2 on golang.org/x/website/_content/doc: fix broken links in go1.25 release notes1d
Thanks.dmitshur commented on golang.org/x/open2opaque/...: update golang.org/x dependencies1d
(1 comment)
Oh, I realized now I was thinking of the protobuf repo (whose canonical source of truth is on Gerrit) and missed this, and so this change might need to be done elsewhere instead of here.…dmitshur commented on golang.org/x/open2opaque/...: update golang.org/x dependencies1d
Thanks.
Thanks.dmitshur commented on golang.org/x/open2opaque/...: update golang.org/x dependencies1d
(1 comment)
This change is ready for review.
@adonovan@google.com I'm not sure if it's expected, but as visible at https://ci.chromium.org/p/golang/g/z-open2opaque-gotip-by-go/console, CL 675736 br…dmitshur opened a change golang.org/x/open2opaque/...: update golang.org/x dependencies1d
Updating to a newer x/tools version fixes a build error at Go tip:
$ go version
go version go1.25-devel_eebae283b6 Mon Jun 2 15:28:33 2025 -0700 darwin/arm64 # CL 675736
$ go test -c -o=/dev/null .…dmitshur commented on golang.org/x/build/cmd/watchflakes: use authenticated clients for Gerrit and LUCI too1d
Somewhat counter to my expectation, this seems not to completely eliminate quota errors. But it _should_ mean watchflakes runs into them less frequently, and we'd need authentication if wanted to pur…dmitshur commented on golang.org/x/build/cmd/watchflakes: annotate more errors1d
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
* LUCI-TryBot-Result+1 (copy condition: "**changekind:NO_CODE_CHANGE**")
\* The label has `labelCopyEnforcement` or `lab…dmitshur commented on golang.org/x/build/cmd/watchflakes: annotate more errors1d
Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes: no reports after May 19, 20251d
[CL 678816](https://go.dev/cl/678816) is working, and watchflakes has started posting again. I'll keep an eye on it in the short term, and issue #70743 still remains open to track unexpected restarts.dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.25: add release notes for go command features.1d
Thanks.
(Yay, no more need to separate these thanks to CL 638565.)
(nit) Might read slightly better if "now" is left out in this context, since this is a new feature rather than a change to an exis…dmitshur commented on golang.org/x/build/cmd/watchflakes: set GOMEMLIMIT in container1d
Hold for now. It was useful to try this out, but the underlying issue turned out to be due to a change in data causing 10x+ increase in memory requirement, so it was hard to see the effect of this ch…dmitshur commented on golang.org/x/build/cmd/watchflakes: use authenticated clients for Gerrit and LUCI too1d
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur opened an issue golang.org/x/exp/rand: isolate into nested module, tag, delete2d
This issue tracks a remaining subset of the accepted proposal #61716. Specifically:
> Once math/rand/v2 has shipped, we would tag and delete x/exp/rand. This would keep programs that already use x/e…dmitshur reviewed +2 on cmd/dist: don't install tools that won't be shipped in distribution2d
Thanks. PS 25 still looks good.
(nit) The comment refers to this as "binExesIncludedInDistpack", which matches the `binExes` variable there, but there's an extra 's' here.
I checked that this works…dmitshur commented on go/token: tweak comment2d
Bypassing since gotip-windows-386 succeeded on second attempt. This is also a comment-only change.dmitshur reviewed +2 on cmd/dist: don't install tools that won't be shipped in distribution2d
Thanks.
Now that the `toolchain` slice includes `cmd/preprofile` (added in CL 569424; CC @mpratt@google.com), should this comment be updated to include it?
(Otherwise it seems odd that it's include…dmitshur reviewed +2 on slices: explicitly discard results in benchmarks3d
Thanks.
Is there a tracking issue for this? It always helps to have something attached to CLs (fine not to for trivial typo fixes or doc fixes; see https://go.dev/doc/contribute#design), but even mo…Last Week
dmitshur commented on testing: add missing Output method to testing.TB5d
Indeed—freeze exceptions would be needed for changes that aren't in scope of the freeze (and ideally they need to be filed and approved before the freeze), but finding and resolving issues in new-t…dmitshur reviewed +2 on cmd/distpack: add test case for pack tool being excluded6d
Thanks.
This already covers that something like pack is excluded from source archives.
This covers binary archives.
If something like pack.exe were to be excluded from binary archive but still acc…dmitshur reviewed +2 on cmd/distpack: don't keep the pack tool6d
Thanks.
Is it worth adding an exclude rule for 'pack'? Up to you.dmitshur commented on cmd/distpack: don't keep the pack tool6d
(1 comment)
It's always helpful to connect CLs with an issue (i.e., https://go.dev/doc/contribute#design), but it's even more helpful during the freeze. (There's already an existing issue in the Go …dmitshur commented on access: please add new email to existing account6d
Great! I've also updated your email in the approvers group now, so everything should continue to work.
Just as a reminder, please be familiar with the rules for voting and submitting changes as desc…dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies/std(thorough) failures [consistent failure]6d
Latest instance fixed in [CL 663975](https://go.dev/cl/663975).dmitshur commented on golang.org/x/build: add darwin-arm64 longtest and race builders1w
The darwin-arm64-longtest builder is passing at tip and on the Go 1.24 release branch, but it has one failing test on the Go 1.23 release branch. I filed #73922 for it.
The darwin-arm64-race builder…dmitshur opened an issue cmd/go: TestScript/build_trimpath_cgo fails to decode dwarf on release-branch.go1.231w
### Go version
This affects Go 1.23.x only. The test passes on Go 1.24.x and at tip.
### Output of `go env` in your module/workspace:
```shell
GOOS='darwin'
GOARCH='arm64'
```
### What did you do…dmitshur commented on golang.org/x/build/cmd/watchflakes: no reports after May 19, 20251w
The problem appears to be due to a regression in the result_adapter command in [crrev.com/c/6554882](https://crrev.com/c/6554882) from May 19, 2025, which has a pending fix in [crrev.com/c/6598395](h…dmitshur opened an issue golang.org/x/build/cmd/watchflakes: no reports after May 19, 20251w
The most recent new issue watchflakes opened was #73775 on May 19, 2025. It appears to have gotten almost entirely stuck as of that date, and isn't producing reports. This is the tracking issue.
The…dmitshur reviewed +2 on golang.org/x/build/internal/task: allow retry with approval on promoting next APIs1w
Thanks.
```suggestion
user should do (and whether they should allow the step to proceed).
For golang/go#70655.
```
Yes, a relui redeploy causes the task to restart. It's possible the api/go1.n.txt…dmitshur commented on golang.org/x/build/cmd/watchflakes: double the memory allocation1w
Hold to try CL 676775 first.dmitshur opened a change lib/time: update to 2025b/2025b1w
Commit generated by update.bash.
For #22487.dmitshur opened a change golang.org/x/build/cmd/watchflakes: set GOMEMLIMIT in container1w
Some of the recent watchflakes restarts have OOMKilled as the reason.
watchflakes might not need as much memory in steady state as it does
during its peaks. Set GOMEMLIMIT to 90% of the container's …dmitshur opened a change golang.org/x/build/cmd/watchflakes: double the memory allocation1w
Some of the recent watchflakes restarts have OOMKilled as the reason.
For golang/go#70743.dmitshur commented on golang.org/x/build/cmd/watchflakes: use authenticated clients for Gerrit and LUCI too1w
This change is ready for review.dmitshur commented on access: please add new email to existing account1w
@ysmolski Glad to hear that you were able to update the email in your Gerrit account! It indeed shows up as expected at https://go-review.googlesource.com/dashboard/26536.
About the CLA page, in the…dmitshur opened a change golang.org/x/build/cmd/watchflakes: use authenticated clients for Gerrit and LUCI too1w
I saw that watchflakes had a fairly significant number of restarts,
and the most recent previous failure ended with:
watchflakes: 2025/05/27 22:10:26 ReadBoard oscar release-branch.go1.24
watchflake…dmitshur commented on golang.org/x/build/internal/task: find relnote tracking milestone and issue dynamically1w
Thanks.dmitshur commented on access: approvers1w
CC @4a6f656c, @Rongronggg9, @milanknezevic, @mengzhuo Since you're also members of [golang/mips](https://github.com/orgs/golang/teams/mips) and [golang/riscv64](https://github.com/orgs/golang/teams/r…dmitshur commented on golang.org/x/build/internal/task: find relnote tracking milestone and issue dynamically1w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: find relnote tracking milestone and issue dynamically1w
(1 comment)
Ack, that works.
This is part of making the GraphQL query, specifically setting the arguments. It's similar to the query below in `FetchMilestoneIssues` (lines 530-531), and was exercis…dmitshur commented on golang.org/x/build/internal/task: consider failing to set a review a soft failure, part 2/21w
Thanks.dmitshur opened a change golang.org/x/build/internal/task: find relnote tracking milestone and issue dynamically1w
The hard-coded constants were helpful to get the rest of this workflow
out sooner, but now's a good time to stop manually maintaining them.
For golang/go#70655.dmitshur closed an issue github.com/shurcooL/graphql: Please make "constructQuery" exported1w
The current implementation of `constructQuery` is very tailored to the needs of the rest of the graphql package. It doesn't take any options, like the ability to include spaces in formatting, and doe…Earlier
dmitshur commented on text/template: index/element switched for iter.Seq2 in range1w
Since it's not already mentioned here, the proposal for this was #66107, and the accepted plan there was:
> The proposal is to allow range over func and int the same as in Go.
The current implement…dmitshur commented on golang.org/x/tour/tour: Missing a period at the end of the last sentence.1w
For clarity, it looks like "Methods and interfaces" was referring to the section title:
dmitshur commented on golang.org/x/sync/...: replace deprecated ioutil1w
When you say "batch clean-up", how is what you mean different from what this CL is already doing, given it's applying this change to all package in the repo (based on the CL subject)? Is it a matter …dmitshur commented on golang.org/x/tools/internal/telemetry/cmd/stacks: support Delve1w
(1 comment)
In case you haven't already encountered it, note that [strings.CutPrefix](https://pkg.go.dev/strings#CutPrefix) (new to Go 1.20) can be handy to simplify code in situations like this to …dmitshur reviewed +2 on doc/next: add crudely processed todos1w
Thanks.dmitshur reviewed +2 on doc/next: add crudely processed todos1w
Thanks very much for doing this work!
This looks good to me. As part of reviewing, I left comments on a number of TODOs that I'm confident we can resolve by marking them as something we reviewed and…dmitshur reviewed +2 on golang.org/x/build/devapp/owners: update tools team ownership1w
Thank you.dmitshur reviewed +2 on doc: fix TBD mark2w
Thanks.dmitshur reviewed +2 on doc: mention stack allocation of variable-sized make calls2w
Thanks.
What does TBD (to be determined?) signal in this context?
I wanted to check that this is already documented somewhere (other than just in release notes, since their guideline is to note cha…dmitshur commented on golang.org/x/build/main.star: add dev.simd branch2w
(2 comments)
Thanks for clarifying that. Yeah, in that case a change is needed.
Ok, thanks. I mostly wanted to confirm that it's your intent to make dev.simd more of a "separate world" rather than …dmitshur commented on golang.org/x/build/main.star: add dev.simd branch2w
(2 comments)
Can you say a bit more about what this changing is intending to change (compared to the current steady state)? Presubmit builders should already work for any dev branch that tracks the …dmitshur commented on golang.org/x/build/maintner: add mutation source that only uses the on-disk cache2w
(1 comment)
Since x/build is exempt from the Go 1 compatibility (https://go.googlesource.com/build#go-build-tools), adding a new public API to x/build is less scary than usual because in theory we c…dmitshur commented on golang.org/x/build/maintner: fix retrying while offline2w
(3 comments)
Can you clarify what you mean by "the GetMutations > fetchAndSendMutations loop"? Is there existing code you're referring to that you could point to?
I ask because most maintner-using …dmitshur reviewed +2 on golang.org/x/build/maintner: abstract out network retry logic2w
Thanks.
It's a bit odd that locallyCachedSegments is now potentially retried by the retryNetwork loop. Previously it was an unconditional return from getNewSegments.
It's fairly harmless since it's…dmitshur reviewed +2 on golang.org/x/build/maintner: test segment cache2w
Thanks.
It often helps to have at least one issue attached to each non-trivial CL (i.e., https://go.dev/doc/contribute#design). I'm not sure what the end goal of the stack is, but this CL is improvi…dmitshur commented on cmd/compile/internal/escape: make escape analysis -m=2 logs more accessible2w
Thanks.dmitshur commented on golang.org/x/build/build/maintner: add mutation source that only uses the on-disk cache2w
(2 comments)
For this CL and the rest of the stack, no need for `build/` here before colon, just `maintner`, since that's the path relative to repo root. The 'x/build' prefix is for the issue tracke…dmitshur commented on golang.org/x/telemetry/internal/counter: write the weekends file atomically2w
(1 comment)
@rfindley@google.com This issue is in the Go 1.25 milestone - is the CL intended to be landed for it? If not, we can just update the issue. Asking in case this was missed.dmitshur commented on runtime/debug: [release-branch.go1.23] document DefaultGODEBUG as a BuildSetting2w
The sid failure is unrelated. Everything else passed. Bypassing.dmitshur commented on golang.org/x/build/internal/releasetargets: update for each upcoming major Go release2w
[CL 664215](https://go.dev/cl/664215) generated a preliminary list for Go 1.25. It's the same list as for Go 1.24 except the macOS minimum version became 12, and that's noted at https://tip.golang.or…dmitshur commented on cmd/link/internal/ld: use 12.0.0 OS/SDK versions for macOS linking2w
Thanks.dmitshur commented on cmd/link/internal/ld: use 12.0.0 OS/SDK versions for macOS linking2w
Copied Votes:
* Code-Review+1 (copy condition\*: "**is:ANY**")
Outdated Votes:
* Auto-Submit+1 (copy condition: "changekind:NO_CHANGE")
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CH…dmitshur commented on cmd/link/internal/ld: use 12.0.0 OS/SDK versions for macOS linking2w
(1 comment)
I went with 15 because the comment suggested "this can be the most recent supported macOS version", but making a minimal change of going to 12 today SGTM. From looking at the recent hist…dmitshur commented on cmd/link/internal/ld: use 15.0.0 OS/SDK versions for macOS linking2w
This change is ready for review.dmitshur commented on golang.org/x/benchmarks/sweet/harnesses: stop trimming "devel " prefix from Go version2w
Thanks.dmitshur commented on all: announce end of support for old Linux versions2w
There isn't anything to pre-announce in Go 1.25 release notes, moving to the next.dmitshur commented on all: announce end of support for old Windows releases2w
There isn't anything to pre-announce in Go 1.25 release notes, moving to the next.dmitshur commented on github.com/go-gl/gl: Problem with getting v2.1 gl2w
The package requires cgo, so it’s possible to get that error if you’ve disabled cgo. Does anything change if you use CGO_ENABLED=1?dmitshur reviewed +2 on reflect: turn off allocation test if instrumentation is on2w
Thanks. LGTM % fixing the build.
Looks like internal/msan and internal/race imports are the ones still needed.dmitshur reviewed +2 on runtime: disable stack allocation test when instrumentation is on2w
Thanks.dmitshur commented on access: please add new email to existing account2w
Hello.
If you're still able to login to your Gerrit account 26536, you should be able to add and verify a new email (and then make it your new primary preferred email, if desired). The reason you're…dmitshur commented on net/http: remove duplicate "net/url" import2w
(1 comment)
@zchee.io@gmail.com That was response to the original change (patch set 1). I'm still trying to understand the motivation for changing this in any way. Does removing a duplicate "net/url…dmitshur commented on cmd/go: build and run tools that are not necessary for builds as needed and don't include in binary distribution2w
Does this need a release note (#71661)?dmitshur reviewed +2 on cmd/dist: pass GO_GCFLAGS to cpuN runtime tests2w
Thanks.dmitshur commented on net/http: remove duplicate "net/url" import2w
(5 comments)
I'd like to ask to better understand: what's the motivation for this change?
The net/url package is imported and made available under two names in these files: as url and as urlpkg. Th…dmitshur commented on golang.org/x/mobile/...: replace deprecated io/ioutil package2w
Resolved in PS 2.
Done in PS 2.dmitshur reviewed +2 on golang.org/x/build/devapp/owners: remove myself from cmd/doc and text/template2w
Thank you.dmitshur pushed to
main in github.com/shurcooL/sanitized_anchor_name2w
dmitshur pushed to
main in github.com/shurcooL/frontend2w