Activity
Yesterday
dmitshur commented on access: Application to join golang/mips maintainer team17h
Also CC @golang/mips (for completeness; almost everyone in it was already CC'ed).dmitshur commented on golang.org/x/build/cmd/watchflakes: start posting20h
Tested this out now; no issues with the fine-grained token permissions so far. I'll keep an eye on it for some time. Submitting.dmitshur commented on all: announce end of support for old macOS releases21h
[CL 563856](https://go.dev/cl/563856) added a note to Go 1.23 release notes, moving to the next.dmitshur commented on golang.org/x/build/cmd/watchflakes: add deployment files21h
Thanks.
Yeah, I gave it fairly minimal resources to start. It mostly makes API calls in a loop, so it might not need much, and we can bump it later as needed. So far it's taking around 7-8 min per i…dmitshur commented on doc: make symbol links simpler for relnotes23h
Thanks.This Week
dmitshur commented on golang.org/x/build/cmd/watchflakes: use github.NewClient API1d
We ended up switching to sending only the token in an Authorization header ([docs](https://docs.github.com/en/graphql/guides/forming-calls-with-graphql#communicating-with-graphql)); updated according…dmitshur opened a change golang.org/x/build/cmd/watchflakes: use github.NewClient API1d
Thanks to Russ for adding it.
For golang/go#65353.dmitshur reviewed +2 on doc: simplify symbol links for relnotes1d
Thanks.dmitshur commented on all: update vendored golang.org/x/crypto3d
TRY=s390xdmitshur opened a change all: update vendored golang.org/x/crypto3d
Pull in CL 578715:
5defcc19 sha3: fix Sum results for SHAKE functions on s390x
Fixes #66804.dmitshur opened a change golang.org/x/pkgsite/static/frontend: use single quotes for strings3d
As a fixup for CL 574655, fix two problems that the devtools/ci/ci.sh
script reports under the 'Running CSS/JS linters' section:
/pkgsite/static/frontend/frontend.ts
131:68 error Replace `".go…dmitshur commented on golang.org/x/build/cmd/watchflakes: start posting3d
This change is ready for review.dmitshur commented on golang.org/x/build/cmd/watchflakes: apply minor fixes3d
(1 comment)
Need to also handle 404 Not Found, since it comes up when a log is not present in a build.
Done in PS 2.dmitshur opened a change golang.org/x/build/cmd/watchflakes: ignore failed builds without output properties3d
It turns out to be possible¹ for a build to fail early enough that it
doesn't get a chance to produce output properties, and not get marked
as an infrastructure failure (even though it should've bee…dmitshur commented on golang.org/x/build/cmd/watchflakes: return errors from LUCIClient to caller3d
(1 comment)
For some context on this change (and its author date): this CL is basically upstreaming some work to make the client more general that I had from earlier versions of the [lucipoll](https…dmitshur opened a change golang.org/x/build/cmd/watchflakes: return errors from LUCIClient to caller3d
Make some progress towards it being possible to handle unexpected errors
by logging them, waiting a bit, and trying again, instead of log.Fatalln
whenever anything unexpected happens, now that watchf…dmitshur starred github.com/nishanths/exhaustive3d
dmitshur opened a change golang.org/x/build/cmd/watchflakes: start posting3d
By now, everything's in place for watchflakes to post.
Fixes golang/go#65353.dmitshur opened a change golang.org/x/build/cmd/watchflakes: add deployment files3d
Add a fairly minimal set of files to deploy watchflakes as a service.
Use Cloud Build for building Docker images, so that it's possible to
perform deploys without having Docker as a local dependency.…dmitshur opened a change golang.org/x/build/cmd/watchflakes: fetch GitHub token from Secret Manager3d
Unfortunately, the only API that creates a github.Client requires that
credentials for api.github.com are available in $HOME/.netrc. It would
be nicer to be able to pass a custom *http.Client. For no…dmitshur opened a change golang.org/x/build/cmd/watchflakes: replace a sleep with a ticker3d
Make it run equally often, no matter how long a single iteration takes.
For golang/go#65353.dmitshur opened a change golang.org/x/build/cmd/watchflakes: apply minor fixes3d
Fix up struct field tag formatting, add missing error checks.dmitshur reviewed +2 on golang.org/x/build/...: fix function names in comment3d
Thanks.dmitshur commented on runtime: remove no-op slice operation in Caller3d
Thanks.
Resolved.dmitshur commented on runtime: remove no-op slice operation in Caller4d
(1 comment)
At least I can't think of why it would be. But this is also in package runtime, so there may be something I'm not taking into account.
I happened to look at the implementation of Caller…dmitshur opened a change runtime: remove no-op slice operation in Caller4d
rpc was an array prior to CL 152537, so it was necessary to slice
it since callers accepts a slice. Now that rpc is already a slice,
slicing it is no longer required.dmitshur reviewed +2 on golang.org/x/build/dashboard: stop linux-ppc64x builders4d
Thanks.
Done in PS 2.dmitshur reviewed +2 on golang.org/x/build/dashboard: stop linux-ppc64x builders4d
Thanks.
See inline comment about removing health checkers.
Otherwise, this should be it. This change will stop the builders from running in post-submit and as a trybot. Since it's a reverse builder…dmitshur commented on golang.org/x/build/dashboard: stop ported Wasm builders4d
Thanks.dmitshur opened a change golang.org/x/build/dashboard: stop ported Wasm builders4d
The Wasm builders have been ported to LUCI. Their previous coordinator
versions aren't being maintained and have stopped passing at tip after
CL 577135, because they're still using an old and unsuppo…Last Week
dmitshur opened an issue crypto/internal/mlkem768: TestPQCrystalsAccumulated fails on linux/s390x1w
[CL 550215](https://go.dev/cl/550215) added a new package. One of its tests, `TestPQCrystalsAccumulated`, is failing on the linux/s390x port:
```
--- FAIL: TestPQCrystalsAccumulated (0.07s)
…dmitshur commented on access: may-start-trybots and approvers1w
@panjf2000 The Auto-Submit+1 vote is documented at https://go.dev/wiki/GerritAccess#auto-submit. I meant you can ask the person who left the Code-Review+2 vote to either submit or leave Auto-Submit+1…dmitshur starred fyshos.com/fynedesk1w
dmitshur closed an issue access: may-start-trybots and approvers1w
Hi @panjf2000, thanks for contributing to the Go project and asking for approvers access again.
We considered this request. As documented at https://go.dev/wiki/GerritAccess, Gerrit "approvers" ac…dmitshur closed an issue time: clean up duplicate definitions `time.runtimeTimer` and `runtime.timer` that need to be kept in sync1w
This is fixed via [CL 568339](https://go.dev/cl/568339), which removed the duplication.dmitshur closed an issue access: go-assignees and go-editors1w
Hi @qiulaidongfeng, thanks for your interest and contributions to Go.
We considered this request. Similarly to https://github.com/golang/go/issues/66611#issuecomment-2052070282, when considering g…dmitshur closed an issue access: +2 approval in CLs1w
dmitshur commented on access: +2 approval in CLs1w
Hi @mauri870, thanks for contributing to the Go project and asking for this access.
We considered this request and felt your contribution history demonstrates enough signals for us to be close to …dmitshur closed an issue access: approvers1w
Hi @qiulaidongfeng, thanks for your interest and contributions to Go.
We considered this request (previously considered in #64255). As documented at https://go.dev/wiki/GerritAccess, Gerrit "appro…dmitshur closed an issue access: Requesting Try-Bots Access and Self-Assign Github Issues1w
Hi @raghvenders, thanks for your contributions to Go so far.
We discussed this request. We generally look for contributors to have a more established track record of contributions before consideri…dmitshur closed an issue golang.org/x/build/cmd/gomote: install builder dependencies by default1w
dmitshur commented on golang.org/x/build/cmd/gomote: install builder dependencies by default1w
This is resolved as of [CL 569875](https://go.dev/cl/569875). (It didn't get closed automatically because the Fixes line didn't specify the `golang/go` repo quite right.)dmitshur starred github.com/aclements/go-obj1w
dmitshur commented on golang.org/x/net/http/httpguts: validation of header names, methods, and cookie names could be about twice as fast1w
@jub0bs Yes, your understanding is right and generally it's good to allow some time for discussion on the issue first, though it's still okay to send a change sooner. There are some more details abou…dmitshur starred github.com/cloudpilot-emu/cloudpilot-emu1w
dmitshur starred github.com/migueletto/PumpkinOS1w
dmitshur commented on golang.org/x/build: add LUCI wasip1-wasm32-wasmtime builder1w
Thanks. Confirming a few details.
`GOARCH` should be `wasm32` instead of `wasm`, is that right?
Related to the above—will `GOROOT/misc/wasm` be used for both `wasm` and `wasm32` exec helpers? Tha…Earlier
dmitshur starred github.com/FiloSottile/FiloSottile1w
dmitshur closed an issue access: may-start-trybots2w
Hi abner chenc,
Thanks for your contributions and helping maintain the linux/loong64 port. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybot…dmitshur commented on net/http: TestRequestLimit/h2 becomes significantly more expensive and slower after x/net@v0.23.0 [1.22 backport]2w
> should backport the fix as well
To clarify, do you think the fix to be backported should include changes in [CL 576756](https://go.dev/cl/576756) and [CL 576895](https://go.dev/cl/576895)?dmitshur commented on go/types: issue with using const with implicit unint642w
CC @griesemer, @findleyr.dmitshur commented on golang.org/x/website: release notes for Go 1.22 mentions inexistent math/rand/v2.Uint()2w
Thanks for reporting this.
CC @rsc.dmitshur commented on cmd/compile: unnecessary runtime.growslice with provable capacity2w
CC @golang/compiler.dmitshur commented on cmd/compile: unnecessary bounds check with slice offset2w
CC @golang/compiler.dmitshur commented on go/types: Identical function doesn't work for SSA loaded type2w
CC @griesemer, @findleyr.dmitshur commented on golang.org/x/build: add LUCI linux-ppc64_power8 builder2w
Here's the certificate: [linux-ppc64-power8-1712341779.cert.txt](https://github.com/golang/go/files/14889449/linux-ppc64-power8-1712341779.cert.txt).
I'll also work on another CL needed for that h…dmitshur commented on golang.org/x/build: add LUCI linux-ppc64-power10 builder.2w
@pmur Should this issue also be closed, or is there more to do for it?dmitshur commented on golang.org/x/build: add LUCI linux-ppc64le-power10 builder2w
Thank you very much @pmur. I've mailed you [go.dev/cl/576917](https://go.dev/cl/576917) to remove its known issue.dmitshur opened an issue cmd/coordinator/internal/lucipoll: occasionally gets stuck (for upwards of 24 hrs)2w
The `pollLoop` method that runs in a loop usually takes a minute, but sometimes seems to get stuck and eventually completes in just over 24 hours without any error. This is a tracking issue to sort t…dmitshur opened an issue golang.org/x/tools/gopls/internal/test/marker: 2w
The definition/embed.txt, definition/misc.txt, and hover/sizeoffset.txt cases of `Test` are failing on linux/arm (32-bit) since they were introduced in [CL 573076](https://go.dev/cl/573076).
For e…dmitshur commented on net/http: data race in multiple tests2w
The two instances above were on release-branch.go1.22.dmitshur commented on net: ListenPacket cannot receive packets from non-localhost2w
CC @golang/openbsd, @ianlancetaylor, @neild.dmitshur commented on log/syslog: generated syslog format is not RFC-compliant2w
Thanks for reporting.
As a side note, the [package comment](https://pkg.go.dev/log/syslog#pkg-overview) states the `log/syslog` package is frozen and that some external packages provide more funct…dmitshur commented on golang.org/x/build: add LUCI linux-ppc64le-power10 builder2w
Here's the certificate for the bot hostname `linux-ppc64le-power10`:
[linux-ppc64le-power10-1712180608.cert.txt](https://github.com/golang/go/files/14858800/linux-ppc64le-power10-1712180608.cert.t…dmitshur commented on golang.org/x/build: add LUCI linux-ppc64le_power9 builder2w
Thanks. Here's the certificate: [linux-ppc64le-power9-1712180354.cert.txt](https://github.com/golang/go/files/14858793/linux-ppc64le-power9-1712180354.cert.txt).dmitshur opened an issue net/http: TestRequestLimit/h2 becomes significantly more expensive and slower after x/net@v0.23.02w
I've initially observed this on various builders, most often linux-386 ones, but it seems to reproduce on `darwin/arm64` too.
At tip without x/net@v0.23.0 (e.g., commit 61a3ee54411086d4bf996b65dd3…dmitshur commented on net/http: close connections when receiving too many headers (CVE-2023-45288)2w
@geofffranks There will be a new golang.org/x/net tag with the fix in [CL 576155](https://go.dev/cl/576155) included, soon.dmitshur closed an issue security: fix CVE-2023-45288 [1.21 backport]2w
Closed by merging commit ae5913347d15cf7d1f218916c22717e5739a9ea3 ([CL 576075](https://go.dev/cl/576075)) to `release-branch.go1.21`.dmitshur commented on os/exec: Can't use os.Command (with ExtraFiles) that uses /proc/self/fd/<exe fd> as the executable2w
CC @bradfitz, @ianlancetaylor.dmitshur commented on golang.org/x/build: add LUCI linux-ppc64le-power10 builder2w
Thanks for the ping @pmur. I have time to help move this forward this week.
I've mailed [CL 575856](https://go.dev/cl/575856) as the next step here, which should make it possible for you to start …dmitshur commented on cmd/compile: ICE with `assertion failed` when using `GODEBUG=gotypesalias=1`2w
This seems to also happen at tip (commit 94dba61276f26c01b7d3d1a4abb195bdcc596bfd) if attempting to make.bash with `GODEBUG=gotypesalias=1`.
<details>
```
src $ git pull --ff-only
Already up…dmitshur commented on golang.org/x/build/internal/installer/windowsmsi: Windows installer always adds %USERPROFILE%\go\bin to PATH even if user overrode GOPATH to point to another directory2w
The Windows installer currently always takes responsibility for setting the `GOPATH` environment variable (to `%USERPROFILE%\go`) and adding `%GOPATH%/bin` to `PATH`. If a user wishes to use a differ…dmitshur commented on golang.org/x/build/internal/installer/windowsmsi: Windows installer always adds %USERPROFILE%\go\bin to PATH even if user overrode GOPATH to point to another directory2w
CC @golang/release.dmitshur commented on net/http: HTTP Client slows down over time until stop2w
CC @neild.dmitshur closed an issue reflect/type.go: reflect.StructTag Get does not return 1st tag of dynamic structure created with reflect.StructOf2w
Thanks for reporting. https://pkg.go.dev/reflect#StructTag documentation says:
> By convention, tag strings are a concatenation of optionally space-separated key:"value" pairs. Each key is a non-e…dmitshur reopened an issue cmd/compile: merge temporaries and named variables by GC shape3w
Reopening since the fix in [CL 553055](https://go.dev/cl/553055) was rolled back in [CL 575236](https://go.dev/cl/575236).dmitshur reopened an issue cmd/compile: package-level variable initialization order looks not correct3w
Reopening since the fix in [CL 575175](https://go.dev/cl/575175) was rolled back in [CL 575316](https://go.dev/cl/575316).dmitshur closed an issue cmd/go: spurious "v1.x.y is not a tag" error when a tag's commit was previously download without the tag [1.20 backport]3w
Go 1.20 has exited its support window per https://go.dev/doc/devel/release#policy.dmitshur closed an issue net/http: don't reuse connections that are experiencing errors [1.20 backport]3w
The upstream issue isn't resolved yet, and Go 1.20 has exited its support window per https://go.dev/doc/devel/release#policy.dmitshur opened an issue os/exec: calling Cmd.Start after setting Cmd.Path manually to absolute path without ".exe" no longer implicitly adds ".exe" in Go 1.223w
https://go.dev/doc/go1.22#os/exec includes:
> On Windows, `Command` and `Cmd.Start` no longer call `LookPath` if the path to the executable is already absolute and has an executable file extension…dmitshur opened an issue golang.org/x/build: Windows builders failing with "rdb: The system cannot find the file specified."3w
We have a better understanding of the problem by now, and a mitigation is in the process of being rolled out.dmitshur closed an issue security: fix CVE-2023-452883w
dmitshur closed an issue cmd/compile: hash of unhashable type [4]int32 [1.21 backport]3w
dmitshur closed an issue cmd/compile: hash of unhashable type [4]int32 [1.22 backport]3w
dmitshur closed an issue net/http: Client.Do blocks on DNS AAAA record until timeout even after A record succeeds [1.22 backport]3w
dmitshur closed an issue golang.org/x/build: create LUCI GCE builders3w
dmitshur closed an issue golang.org/x/build: add a Linux LUCI builder with a recent Clang toolchain3w
> which would imply a builder with at least least Clang 15
There's a LUCI builder with clang 15 (e.g., [gotip-linux-amd64-clang15](https://ci.chromium.org/p/golang/builders/ci/gotip-linux-amd64-cl…dmitshur starred github.com/emersion/go-imap/v23w
dmitshur starred github.com/emersion/go-smtp3w
dmitshur commented on cmd/go: download go1.22 for darwin/arm64: toolchain not available1mo
> you have to do [...] `DIR=$(mktemp -d); cd $DIR; go version`
If you'd like to determine the bundled Go toolchain's version, it's possible to do it with `GOTOOLCHAIN=local go version`. This is do…dmitshur opened an issue golang.org/x/build/cmd/watchflakes: possibly report newly-skipped tests1mo
It's common for Go tests that require certain capability or dependency to skip themselves if the environment doesn't meet that requirement. For example, see the various `MustHave*` helpers in [`inter…dmitshur starred github.com/kanryu/mado1mo
dmitshur reviewed +2 on github.com/go-gl/glfw/scripts: Drop support for grabbing v3.2 upstream1mo
Thanks.dmitshur commented on github.com/go-gl/glfw: Consider adding release tags1mo
Let's consider starting to do that in the new-to-be v3.4/glfw module (#393). What would some of the finer details look like? I wrote the following to try to answer that and explore options.
Its fi…dmitshur commented on github.com/go-gl/glfw: Add support for GLFW v3.41mo
v3.3/glfw is its own module, separate from the top-level module that has the older versions v3.{0,1,2}/glfw. That seems to be working well, so I expect we can repeat that pattern and also have v3.4/g…dmitshur closed an issue github.com/go-gl/glfw/v3.3/glfw: GetKeyName incorrectly panics on unknown key and scancode1mo
I can confirm the same program no longer panics now that GLFW 3.3.10 is pulled in. `glfw.GetKeyName(glfw.KeyUnknown, 0x003f)` returns an empty string. I think we can close this unless there's somethi…dmitshur commented on github.com/go-gl/glfw/scripts: Grab upstream fails to apply patch for v3.21mo
I think it's fine to leave v3.2 and older as is. I don't expect there will be new GLFW 3.2.x or older patch versions to update to.dmitshur reviewed +2 on github.com/go-gl/glfw/v3.3/glfw: Update to v3.3.10 for various bug fixes1mo
Thanks.dmitshur commented on github.com/go-gl/glfw: Update README with required packages for Wayland1mo
Thanks.
As a side note, I'm starting to wonder if we should instead (or in addition) link to the upstream documentation on this at https://www.glfw.org/docs/latest/compile_guide.html#compile_deps,…dmitshur commented on github.com/go-gl/glfw: Update README with required packages for Wayland1mo
Thanks.
As a side note, I'm starting to wonder if we should instead (or in addition) link to the upstream documentation on this at https://www.glfw.org/docs/latest/compile_guide.html#compile_deps_…