Activity
Yesterday
dmitshur reviewed +2 on golang.org/x/build/cmd/relui: add govulncheck-action repo tagging workflow14h
dmitshur reviewed +2 on golang.org/x/build/cmd/relui: add govulncheck-action repo tagging workflow15h
Thanks. One more comment in Workflow.Run, otherwise I don't see anything more from my side, and I think you should feel free to submit this and/or try it out. As with any new workflow, trying it out …dmitshur reviewed +2 on all: use path for go.mod module path15h
Thanks.
```suggestion
module crypto/internal/fips140/sha3/_asm
```
Unrelated to this CL, but I wonder what is the motivation for this go.mod? Usually they're used to track tools used for code gener…dmitshur commented on golang.org/x/build: try a -racegocommand builder16h
Both the -racegocommand and -racegocommand-noopt builders have been running for some time, and so far they haven't uncovered interesting races in the go command. Issue #79667 turned out to be a probl…dmitshur reviewed +1 on cmd/go: don't run cgo compiler version probe under -toolexec17h
(1 comment)
A question related to this. As far as I see, TOOLEXEC_CDRIVER_LOG is only used to by this test in one way: to point it to a cdriver.log file and then later on check under cgo that it doe…dmitshur opened an issue os: TestRootMultiReadFile fails on netbsd/arm64 after CL 79788020h
See https://ci.chromium.org/ui/p/golang/builders/ci/gotip-netbsd-arm64/b8676812685865790769/overview for example. (A different test fails on Plan 9, see #80319.)
CC @golang/netbsd.dmitshur closed an issue golang.org/x/build/cmd/coordinator: mind combined memory usage when concurrently processing large payloads20h
We got by with increasing memory available to coordinator. By now it no longer does builds itself, only displays an old-style dashboard [build.golang.org](https://build.golang.org) pointing to [LUCI …dmitshur commented on os: TestRootConsistencyRemoveAll fails on Plan 9 after CL 79788020h
CC @golang/plan9.dmitshur commented on golang.org/x/build/relnote: ignore comment-only markdown files20h
Thanks for implementing this.
I left some review comments. In general, this looks like a good start, and when the comments are resolved we should be able to submit this.
Two suggestions here.
One,…This Week
dmitshur reviewed +2 on cmd/go: split test_vet script test for improved parallelism1d
Thanks.dmitshur reviewed +2 on cmd/go: split build_overlay script test to improve parallelism1d
Thanks.dmitshur reviewed +2 on golang.org/x/playground/sandbox: replace deprecated Konlet with systemd service in cloud-init1d
Thanks. I'm not familiar enough with the lower level details involved in this, but it makes sense to migrate off a deprecated mechanism.dmitshur closed a change golang.org/x/website/_content/doc/tutorial/generics.md: fix typo1d
This change is applied via https://go.dev/cl/782240.dmitshur reviewed +2 on golang.org/x/build/main.star: add c4d (AMD Turin) builders1d
Thanks.
Since this CL is a part of what's needed, you might want to keep the issue open for a bit until the VMs are up and everything works as you expect.
Unless I missed it, you'll still need to d…dmitshur commented on golang.org/x/build/internal/task: add support for okay-after-rc2 label1d
Thanks.
Yeah, I considered that too but stopped at just rc2 for now to match the labels that exist. For rc3 hopefully we'll really resolve all release blockers or remove the release-blocking label. …dmitshur closed a change golang.org/x/build/cmd/coordinator: lower the memory allocation1d
Replaced with CL 798540.dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: update resource allocations1d
Thanks.
I did something similar in CL 732263 earlier. It's still open because I was deciding whether to lower it a bit further before submitting. By now all legacy builds are stopped, so let's go wi…dmitshur commented on cmd/fix: pull in CL 7916601d
Thanks.dmitshur reviewed +2 on lib/time: update to 2026c/2026c1d
Thanks.dmitshur opened a change cmd/fix: pull in CL 7916601d
Generated with updatestd, though it's equivalent to manually running:
cd src/cmd
go get golang.org/x/tools@internal-branch.go1.27-vendor # v0.45.1-0.20260708165844-7044391f8d9f
go mod tidy
go mod v…dmitshur reviewed +2 on golang.org/x/build/internal/coordinator/remote: avoid a potential deadlock1d
Thanks.dmitshur fixed an issue golang.org/x/tools: tests on internal-branch.go1.27-vendor branch aren't passing with go1.27rc21d
Fixed by the aforementioned CLs.dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: remove gomote functionality from the coordinator1d
dmitshur reviewed +1 on golang.org/x/tools/go/analysis/passes/printf: reject %d of pointer or chan2d
Thanks. This looks okay to me so +1, though I expect there may be a better reviewer for go/analysis/passes packages. I understand this will be waiting on the proposal to be accepted anyway.
It took …dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.27-vendor] preserve symbols in reflecttypefor2d
Filed #80296 for this problem and mailed CLs. I'll rebase this on top, that should fix the trybots here.dmitshur commented on golang.org/x/tools/go/analysis/passes/printf: [internal-branch.go1.27-vendor] adjust printf analyzer for CL 7843812d
This change gets the [golang.org/x/tools/go/analysis/passes/printf.Test](https://ci.chromium.org/ui/p/golang/builders/try/x_tools-go1.27-linux-amd64-longtest/b8676896302437009505/test-results?q=Ex…dmitshur commented on golang.org/x/tools/go/ssa: [internal-branch.go1.27-vendor] reject generic methods from RuntimeTypes2d
This change gets the [golang.org/x/tools/go/ssa.TestStdlib](https://ci.chromium.org/ui/p/golang/builders/try/x_tools-go1.27-linux-amd64-longtest/b8676896325792242385/test-results?q=ExactID%3Agolan…dmitshur opened a change golang.org/x/tools/gopls/internal/test/marker: [internal-branch.go1.27-vendor] update hover test2d
CL 784060 updates Types.Info.Instantiations to preserve receivers
for generic methods, which breaks these tests. This change updates
a test to allow that CL to merge.
For golang/go#79657.
Fixes gola…dmitshur opened an issue golang.org/x/tools: tests on internal-branch.go1.27-vendor branch aren't passing with go1.27rc22d
The `internal-branch.go1.27-vendor` branch in x/tools was created quite early after the start of the Go 1.27 release freeze, as opposed to closer to when the Go 1.27 release freeze will be ending. So…dmitshur commented on golang.org/x/website/_content/doc: update PATH docs and restructure manage-install.html2d
Thanks.dmitshur reviewed +2 on os: properly handle trailing slashes in paths in Root2d
Thanks.dmitshur fixed an issue security: fix CVE-2026-39822 [1.25 backport]2d
Closed by merging [CL 797660](https://go.dev/cl/797660) (commit c94048f5638bbcaa22102bade5e9774e0d485315) to release-branch.go1.25.dmitshur fixed an issue os: Root escape via symlink plus trailing slash (CVE-2026-39822) [1.25 backport]2d
Closed by merging [CL 797660](https://go.dev/cl/797660) (commit c94048f5638bbcaa22102bade5e9774e0d485315) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-39822 [1.26 backport]2d
Closed by merging [CL 797661](https://go.dev/cl/797661) (commit f9ef7f55988f03afeb3b8354367d0fa8d053683d) to release-branch.go1.26.dmitshur fixed an issue os: Root escape via symlink plus trailing slash (CVE-2026-39822) [1.26 backport]2d
Closed by merging [CL 797661](https://go.dev/cl/797661) (commit f9ef7f55988f03afeb3b8354367d0fa8d053683d) to release-branch.go1.26.dmitshur commented on os: [release-branch.go1.26] properly handle trailing slashes in paths in Root2d
(1 comment)
Since this is a release-branch.go1.26 backport CL, it would've been optimal if the commit message had:
```suggestion
For #79005.
Fixes #79027.
```
Then the Go1.26.5 backport issue #790…dmitshur fixed an issue golang.org/x/build: bot openbsd-riscv64-jsing reported as broken2d
It seems to be back online and running. Thanks @4a6f656c.dmitshur fixed an issue golang.org/x/build: bot openbsd-riscv64-jsing reported as broken2d
It seems to be back online and running. Thanks @4a6f656c.dmitshur reviewed +1 on golang.org/x/website/internal/history: document Go 1.26.5 and 1.25.12 releases2d
dmitshur commented on golang.org/x/pkgsite: support generic methods and show "Migrating to v2" in encoding/json2d
> I investigated this issue and found that updating "pkgsiteCmdInternalDocVersion" to "v0.0.0-20260630164626-55ca6a10dee5" fixes the generic method rendering problem. I verified that "go doc -http" n…dmitshur reviewed +2 on cmd/go: move part of gotoolchain_net to verylongtest2d
Thanks.
I take it that it's guaranteed that calling t.TempDir() first, and t.Cleanup second will cause the cleanup to run first, TempDir deletion second, right?
Is it intentional that removeAll not…dmitshur opened an issue cmd/go: doc -http fails with "doc: no such file or directory" on first run with clean GOCACHE2d
### Go version
go version go1.27rc1 darwin/arm64
### Output of `go env` in your module/workspace:
(`go env -changed` is empty.)
### What did you do?
```
$ export GOCACHE=$(mktemp -d)
$ go…dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: remove gomote functionality from the coordinator2d
Thanks.
Optional suggestion. Since the swarming gomotes are all that's left in the golang.org/x/build/internal/gomote package, consider appending helper.go to the bottom of swarming.go, and renaming…dmitshur reviewed +2 on golang.org/x/pkgsite/internal/fetch: inherit active tool tags in build context3d
Thanks.
This test case appears to be hard to read because of how it combines the terms "other", "jsonv2", and "archive/tar" that seemingly have little in common. As a result it's unclear what it's t…dmitshur opened a change golang.org/x/build/internal/task: add support for okay-after-rc2 label3d
We've created an okay-after-rc2 label, which works like okay-after-rc1
but for RC 2 instead of RC 1. Make the 'Check blocking issues' task more
useful by having it ask only about release blockers tha…dmitshur reviewed +2 on golang.org/x/build/main.star: remove openbsd-arm64 from KNOWN_ISSUE_BUILDER_TYPES3d
Thanks again.dmitshur commented on golang.org/x/build/cmd/relui: consider target versions of security fixes in security comms3d
(1 comment)
@neal@golang.org Do you think we should keep this version syntax as is, or is it worth considering making it match the https://go.dev/doc/toolchain#name? I understand that VulnDB needs t…dmitshur commented on golang.org/x/build/main.star: remove openbsd-arm64 from KNOWN_ISSUE_BUILDER_TYPES3d
Done in patch set 4.dmitshur commented on runtime: sizespecializedmalloc experiment3d
@matloob Thanks for marking this as done.
The release note currently says "[GOEXPERIMENT=nosizespecializedmalloc] is expected to be removed in Go 1.28."; is there an issue to track doing the work of…dmitshur commented on golang.org/x/website/solutions: update urfave/cli link to v3 GitHub URL3d
> 👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏
See https://github.com/golang/website/pull/359#issuecomment-463983711…dmitshur reviewed +2 on cmd/go: move mod_insecure_issue63845 and mod_proxy_https to verylongtest3d
dmitshur reviewed +1 on test: repair codegen/simd mask instructions test3d
dmitshur closed an issue cmd/internal/testdir:0_10: Test/codegen/simd.go failures [consistent failure]3d
Last Week
dmitshur reviewed +2 on go.dev/wiki/DashboardBuilders: remove documentation for legacy builders1w
dmitshur opened a change go.dev/wiki/DashboardBuilders: remove documentation for legacy builders1w
The legacy builders have been fully stopped and don't work anymore.
The documentation for them is obsolete and misleading. Remove it.
For golang/go#67761.dmitshur commented on runtime: implement stackcheck for riscv641w
The legacy slowbot infrastructure is unsupported and doesn't work. I added their LUCI counterparts as advisory slowbots to this CL:
- [gotip-linux-riscv64](https://ci.chromium.org/ui/p/golang/builde…dmitshur commented on golang.org/x/build: gotip-openbsd-riscv64 builder is missing1w
There is a [openbsd-riscv64-jsing](https://chromium-swarm.appspot.com/bot?id=openbsd-riscv64-jsing) builder now, but it's showing up as offline as of 24 hrs ago. CC @4a6f656c.dmitshur reviewed +2 on cmd/go/internal/work: cache coverage output1w
I think I understand this at a high level and it's mostly a refactor. However, I'm not familiar with go command's action caching and coverage instrumentation, so my review isn't going to be very thor…dmitshur reviewed +2 on cmd/go: remove net script test condition from main go command suite1w
Thanks.
🎉dmitshur reviewed +2 on cmd/go: move mod_sumdb_golang network tests to verylongtest1w
Thanks.
Consider passing in the *testing.T here and call t.Fatal instead. Also below.
`l` is never closed, even after the test completes. Is the reason for that because the test executable is deeme…dmitshur reviewed +2 on cmd/go: move part of gotoolchain_net to verylongtest1w
Thanks.
This copy of scripttest is internal to the cmd module, so it makes sense to modify it to suit the needs of all of its internal users. I agree it seems calling removeAll to clean up after the…dmitshur reviewed +2 on cmd/go: move mod_insecure_issue63845 and mod_proxy_https to verylongtest1w
Thanks.
This seems like the only use of fixReadme. Should the flag be removed because it no longer has any effect, or be fixed to work?dmitshur reviewed +2 on cmd/go/testdata/script: update mod_prefer_compatible to not use net1w
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net condition from always skipped tests1w
Thanks.
I think this is saying that the test is being skipped because it has a 'skip' verb. It's fine, though a bit repetitive.
[go.dev/issue/54043](https://go.dev/issue/54043) is closed, and it's …dmitshur reviewed +2 on cmd/go/testdata/script: don't use network in mod_gonoproxy test1w
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net from mod_download_private_vcs1w
Thanks.
😄dmitshur fixed an issue golang.org/x/crypto: upgrade x/net dependency1w
As noted in the comment above, closing as fixed by [CL 788222](https://go.dev/cl/788222) which is included in x/crypto@v0.53.0. (CC @golang/security.)
> although the problem is the scan engine
It s…dmitshur reviewed +2 on cmd/go/testdata/script: don't use net in mod_pseudo_cache1w
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: don't use net in mod_sumdb_file_path test1w
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: stop using network from mod_git_export_subst1w
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net from gotoolchain_version test1w
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net check in get_iussue53955 test1w
Thanks.
(minor typo)
```suggestion
cmd/go/testdata/script: remove net check in get_issue53955 test
```dmitshur reviewed +2 on cmd/go/testdata/script: don't use network in govcs script test1w
Thanks.
I left a suggestion to consider including at least one "For #nnn." line. That suggestion is for all CLs in this stack, but I won't repeat it everywhere.
Whenever there's a large stack of CL…dmitshur reviewed +2 on cmd/go: switch toolchain if necessary in applyUpgrades1w
Thanks. Just a minor comment/question.
I don't know what's the motivation to defer base.ExitIfErrors() here given it's already being called on line 1495, and there aren't any early returns before th…dmitshur commented on cmd/compile: repair mask optimizations1w
Test/codegen/simd.go may need attention after this change, see issue #80199.dmitshur commented on cmd/internal/testdir:0_10: Test/codegen/simd.go failures [consistent failure]1w
It seems this started with [CL 794680](https://go.dev/cl/794680). Since this is a regression from go1.27rc1, it'd be good to fix for rc2.dmitshur commented on flag:race: unrecognized failures1w
That's a strange build failure that only happened once so far. It may be the same issue that was fixed by [CL 794120](https://go.dev/cl/794120) and [CL 794121](https://go.dev/cl/794121). Adjusted the…dmitshur commented on net/http/internal/http2: pre-allocate header map in server's newWriterAndRequest1w
CC @neild, @nicholashusin.dmitshur commented on golang.org/x/tools/go/analysis/passes/inline: non-deterministic facts encoding1w
CC @adonovan, @matloob, @findleyr.dmitshur commented on golang.org/x/net/webdav: support filesystem-backed dead properties1w
I think you filed issue #80232 for this, so "Fixes golang/go#80232".
This text should be acknowledged and then deleted from the PR description.
Adding a new exported API requires going through the …dmitshur commented on golang.org/x/net/webdav: support filesystem-provided dead property holders1w
CC @neild, @ianlancetaylor, @nicholashusin.dmitshur commented on golang.org/x/crypto/ssh: unable to verify SSH signatures with a hardware security key created with no-touch-required1w
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/build: bot windows-arm64-azure-qmuntal reported as broken1w
CC @qmuntal.dmitshur commented on doc: fips140 page does not specify which crypto module version is used when GODEBUG=fips140=on without GOFIPS1401w
CC @golang/security.dmitshur commented on doc: write release notes for Go 1.271w
@iandyh Thanks for reporting that. We'll resolve it as part of issue #79987.dmitshur commented on golang.org/x/pkgsite: support generic methods1w
It was reported that the package documentation for encoding/json (v1) doesn't show the "Migrating to v2" section in https://github.com/golang/go/issues/78779#issuecomment-4861881670 (thanks @iandyh).…dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.27: document syscall.Errno on Plan 91w
Thanks.dmitshur commented on golang.org/x/tools/internal/robustio: don't use syscall.Errno on Plan 91w
(1 comment)
This might be worth including in the Go 1.27 release notes (https://tip.golang.org/doc/go1.27, tracking issue #78779). CL 750680 is where the Plan 9-specific addition happened.dmitshur opened a change golang.org/x/build/cmd/relui: consider target versions of security fixes in security comms1w
So far we've only had to deal with the common case where a security fix
applies to all versions that are going as part of a monthly Go release.
At some point we'll run into a case where some security…dmitshur closed a change golang.org/x/text/go.mod: update golang.org/x dependencies1w
Replaced by a newer identical CL 795500.dmitshur closed a change golang.org/x/text/go.mod: update golang.org/x dependencies1w
Replaced by a newer identical CL 795500.dmitshur commented on net: TestLookupCNAME failures1w
@gopherbot Please consider this for backport. It's a test-only fix needed to get this test passing on release branches.
CC @nicholashusin, @golang/release.dmitshur commented on golang.org/x/build/cmd/relui: add metadata-based security comm fetching for RC releases1w
Thanks.dmitshur opened a change golang.org/x/build/cmd/relui: add metadata-based security comm fetching for RC releases1w
This has been working well for the "two minor releases" relui workflow.
Continue by making it available in "next RC" relui workflow next.
For golang/go#79037.dmitshur fixed an issue internal/sync: TestConcurrentCache failures1w
I understand this should be fixed by https://go.dev/cl/794120 and https://go.dev/cl/794121 (CC @prattmic), closing. [internal/sync.TestConcurrentCache on gotip-linux-amd64-noopt](https://ci.chromium.…dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: Warnings when building using -tags wayland1w
We'll be able to pull it in once there's a stable GLFW release that includes that change. PR glfw/glfw#2833 is added to 3.5 milestone, so I understand it will be released in in a future GLFW 3.5 rele…dmitshur reviewed +2 on runtime: [release-branch.go1.26] tolerate vendor suffixes in Linux kernel release strings1w
dmitshur reviewed +2 on golang.org/x/build/devapp/owners: remove Rob Pike from various packages1w
Thanks.
cmd/doc was deleted in CL 689835 ('go doc' continues to handle its functionality), so this entire entry can also be removed.dmitshur reviewed +2 on golang.org/x/pkgsite/deploy: update Cloud Build Go version to 1.27rc11w
Thanks.dmitshur commented on golang.org/x/sys/cpu: handle vendor suffixes in parseRelease1w
(1 comment)
Thanks.