Activity
Today
dmitshur reviewed +2 on golang.org/x/website/_content/blog: new crypto audit post19m
Thanks. Some minor suggestions.
If you haven't already, consider if it might be a net win to use a permalink pointing to a fixed commit, in case that file moves to another directory in a future comm…dmitshur closed a change golang.org/x/build/bad: Another bad commit message for testing PR rules.7h
By now CL 513397 is submitted, so this test CL is probably not needed. (Otherwise a new one can be made.)dmitshur closed a change golang.org/x/build: Rename README.md to -github.com-binance-exchange-binance-official-/ap…7h
dmitshur commented on golang.org/x/build/env: delete more unused environments7h
Thanks.dmitshur commented on golang.org/x/build/internal/migration: stop running more builders7h
Thanks.
Yeah, it is possible to track this separately, and I considered that. However, the distinction isn't used in any way. The comment still captures the information so it'll be easier to separat…Yesterday
dmitshur commented on golang.org/x/telemetry/...: clean up old go build constraints1d
Thanks.dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add paddings for Delve and update tests1d
Thanks.dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add module field to Delve entries1d
Done in CL 673235.dmitshur opened a change golang.org/x/telemetry/...: clean up old go build constraints1d
The go directive in all 3 go.mod files is 1.23.0, so build constraints
go1.20, go1.21, and go1.22 are always satisfied. No need to check them.dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add paddings for Delve and update tests1d
Copied Votes:
* Code-Review+1 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforcement` or `label…dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add module field to Delve entries1d
@rfindley@google.com I've mailed you CL 673235 in case it helps.dmitshur opened a change golang.org/x/telemetry/internal/chartconfig: add paddings for Delve and update tests1d
This adds a best-effort initial padding value for Delve. From looking
over https://github.com/go-delve/delve/tags, it seems Delve doesn't do
pre-releases, tends to do an average of 3-4 minor releases…dmitshur reviewed +2 on golang.org/x/website/_content/security: add note about release candidates1d
(1 comment)
Noticed a typo only now, sorry.
```suggestion
For issues that are present in a [major version release candidate](/s/release),
```dmitshur commented on golang.org/x/build/internal/workflow: order sub-workflow names from highest level to lowest1d
Thanks.dmitshur commented on golang.org/x/build/internal/task: bypass trybots on VERSION file CLs1d
Thanks.dmitshur commented on golang.org/x/build/internal/task: consider failing to set a review a soft failure, part 1/21d
Thanks.dmitshur commented on os: new test TestOpenFileCreateExclDanglingSymlink fails on Plan 91d
CC @golang/plan9, @neild.This Week
dmitshur closed an issue github.com/gopherjs/gopherjs: Arrays internalized as maps2d
Perhaps the "not planned" reason is more applicable here, since there was no change.dmitshur commented on golang.org/x/build/main.star: update docker builders to point at Ubuntu-22 (Jammy)2d
(Bypassed since misccompile provides no signal on luci-config branch anyway.)dmitshur reviewed +2 on golang.org/x/build/env: install unzip in Linux images2d
Thanks. Bypassed trybots since PS 1 already passed and PS 2 is just a rebase.dmitshur commented on golang.org/x/website/_content/security: add note about release candidates2d
(1 comment)
Also, that particular wiki page has a dedicated shortlink if you'd like to use it:
```suggestion
For issues that are present in a [major version release canidate](/s/release),
```dmitshur reviewed +2 on golang.org/x/website/_content/security: add note about release candidates2d
Thanks.
As I understand this applies to PUBLIC track fixes too, but the currently added text is within the PRIVATE track section. Maybe mentioning RCs here could help. Up to you.
Needs a relative l…dmitshur commented on golang.org/x/build/maintner/cmd/maintserve: update dependencies2d
Thanks.dmitshur opened a change golang.org/x/build/maintner/cmd/maintserve: update dependencies2d
This nested module hasn't been updated in a while. Update dependencies
to pull in the latest fixes that are available and make future updates
smaller.
Most notably, this pulls handling of the "draft…dmitshur pushed to
main in dmitri.shuralyov.com/service/change2ddmitshur commented on golang.org/x/build/env: cross-compile binaries for linux-arm64 images3d
(1 comment)
I take it the intent was to use its own copy here.
```suggestion
# stage0 and bootstrapswarm are built by the Makefile in env/linux-arm64-bullseye.
COPY env/linux-arm64-bullseye/stage0 …dmitshur commented on golang.org/x/build/main.star: add linux-s390x-race builder3d
Thanks.dmitshur reviewed +2 on golang.org/x/build/env: cross-compile binaries for linux-arm64 images3d
Thanks. Seems entirely reasonable. Comments on some details.
Maybe write down some rough numbers, so that if the balance changes in the future, it'll be easier to change the approach.
```suggestion…dmitshur commented on golang.org/x/crypto/sha3: add MarshalBinary, AppendBinary, and UnmarshalBinary3d
(1 comment)
Thanks for the report. This is now tracked in issue #73681.dmitshur commented on golang.org/x/crypto/x509roots/fallback: high, unskippable, init cost3d
CC @rolandshoemaker, @FiloSottile.dmitshur opened a change golang.org/x/build/internal/migration: stop running more builders3d
We've considered porting these builders but decided not to at this time.
We have a standard Debian builder in many run-mod variations, and a Sid
builder which aims to use a newer Linux kernel version…dmitshur commented on golang.org/x/build/env: delete old unused environments4d
Thanks. (Moving myself to CC since this is already reviewed, and I don't have comments.)dmitshur opened an issue golang.org/x/arch/riscv64/riscv64asm: TestObjdumpRISCV64TestDecodeGNUSyntaxdata stalls on linux/s390x4d
See https://ci.chromium.org/b/8715046913413654785 for example:
```
=== RUN TestObjdumpRISCV64TestDecodeGNUSyntaxdata
panic: test timed out after 10m0s
running tests:
TestObjdumpRISCV64TestDecod…dmitshur opened an issue golang.org/x/crypto/sha3: TestMarshalUnmarshal/SHA3-224 fails on linux/s390x4d
See https://ci.chromium.org/b/8715046724760256497 for example:
```
=== RUN TestMarshalUnmarshal
--- FAIL: TestMarshalUnmarshal (0.00s)
panic: interface conversion: *sha3.asmState is not encoding.B…dmitshur reviewed +2 on golang.org/x/build/devapp/owners: update CLI team4d
Thanks.dmitshur commented on crypto/internal/fips140/sha3: remove usages of WORD for s390x4d
Stopping this legacy trybot run since it matched 0 legacy builders.
Note that the legacy slowbot syntax needs to be in a comment, not commit message. But that shouldn't matter now that #67307 is don…dmitshur opened a change golang.org/x/build/internal/migration: stop running linux-s390x-ibm{,-race} builders4d
These builders have been migrated to LUCI.
For golang/go#67307.dmitshur opened a change golang.org/x/build/main.star: add linux-s390x-race builder4d
The previous build infrastructure had a -race builder for linux/s390x,
so port it over too.
Notably, the previous configuration enabled the -race configuration on
the main branch of the main Go repo…dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-s390x builder4d
It's working as expected in x/ repos too. There's one test failure in x/arch and x/crypto, but the same happens on the old infra builders, so it's a port problem and not a builder problem. It can be …dmitshur commented on golang.org/x/mobile/cmd/gomobile: add golistflags flag4d
(1 comment)
I agree that if it's possible to use a fixed configuration that works in both cases, it would be better. Adding a flag creates work for the users to pass in the right flag value dependin…dmitshur reviewed +2 on golang.org/x/build/devapp/owners: update CLI team4d
Thanks.
This entry doesn't exist in the gophers package yet and needs to be added, right? You can check by running `go test ./devapp/owners` locally.
It doesn't matter too much, but perhaps this sh…dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder4d
Great, thank you.
I think all that's left on our side is to adjust the builder configuration to let the builder run on applicable golang.org/x repositories (it was set to try only the main Go repo w…dmitshur opened a change golang.org/x/build/main.star: stop skipping golang.org/x repos on linux-s390x builder4d
The builder is running in the main Go repo. Remove the temporary skip
of golang.org/x repos as the next step of its onboarding.
Also move it to LOW_CAPACITY_HOSTS since by now its capacity is known
…dmitshur commented on golang.org/x/build/internal/task: use GenerateAutoSubmitChange in TagTelemetryTasks4d
Thanks.Last Week
dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder6d
Glad to hear that, and congrats on getting to this point!
The swarming bot generally takes care of using all of the CPU cores and machine capacity available to it, so the typical setup is to have on…dmitshur closed a change go/version: treat prerelease patch as valid version1w
Closing because it turns out these were left overs from testing rather than real Go release versions that need to be handled. See https://go.dev/issue/68634#issuecomment-2867535846. Thanks.dmitshur closed an issue go/version: IsValid reports false on inputs like "go1.8.5rc5", "go1.9.2rc2"1w
I've had a chance to talk with Russ about this, and he confirmed that these "go1.8.5rc5" and "go1.9.2rc2" versions aren't really proper Go releases—they're side-effects that happened to be produced…dmitshur commented on go/version: doesn't handle devel toolchain versions1w
We've taken the alternative route of making the generated development versions be compatible with the existing https://go.dev/doc/toolchain#name format (as a "non-standard toolchain") in #73372. Is t…dmitshur commented on golang.org/x/build/internal/workflow: order sub-workflow names from highest level to lowest1w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
* LUCI-TryBot-Result+1 (copy condition: "**changekind:NO_CODE_CHANGE**")
\* The label has `labelCopyEnforcement` or `lab…dmitshur opened a change golang.org/x/build/internal/task: consider failing to set a review a soft failure, part 2/21w
Apply an analogous change for GenerateAutoSubmitChange
to mirror what CL 670475 did in CreateAutoSubmitChange.
For golang/go#68276.dmitshur commented on golang.org/x/build/internal/task: consider failing to set a review a soft failure, part 1/21w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
* LUCI-TryBot-Result+1 (copy condition: "**changekind:NO_CODE_CHANGE**")
\* The label has `labelCopyEnforcement` or `lab…dmitshur commented on github.com/andygrunwald/go-gerrit/fix: handle changes/<change>/patch JSON marshalling error1w
I left some review comments from a quick look, I hope they're helpful. I haven't tried to test the changes locally so I may have missed something.
In general, the test seems to be useful, but I th…dmitshur commented on github.com/go-delve/delve/goversion: fix development version parsing1w
Thank you!dmitshur commented on golang.org/x/build/internal/task: include detailed Cloud Build log URL upon failure1w
Thanks.dmitshur commented on golang.org/x/build/internal/task: use GenerateAutoSubmitChange in TagTelemetryTasks1w
Thanks.
Yes, that's right. It has some nice properties like not requiring the caller to know the modified files (if any) in advance, and automatically not mailing a CL if nothing changed. CreateAuto…dmitshur commented on golang.org/x/build/internal/task: use GenerateAutoSubmitChange in TagTelemetryTasks1w
Copied Votes:
* Code-Review+1 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforcement` or `label…dmitshur commented on golang.org/x/build/internal/workflow: order sub-workflow names from highest level to lowest1w
Copied Votes:
* Code-Review+1 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforcement` or `label…dmitshur opened a change golang.org/x/build/internal/task: include detailed Cloud Build log URL upon failure1w
In the unexpected case that a cloud build script fails, it's generally
useful to see the log that contains the commands and their output, and
not the result GCS bucket. That bucket likely holds no re…dmitshur opened a change golang.org/x/build/internal/task: use GenerateAutoSubmitChange in TagTelemetryTasks1w
Using CloudBuild.RunScript to regenerate the config involves bookkeeping
steps to determine whether config/config.json changed or not, to avoid
creating (and then closing) a CL if it's not needed.
G…dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add module field to Delve entries1w
Does `go generate ./internal/configgen` work for you locally?
When I initially tried the same change locally earlier, it still failed:
```
2025/05/08 11:57:42 padding not defined for program "githu…dmitshur commented on golang.org/x/telemetry/internal/chartconfig: collect counters for Delve1w
Note that this change appears to break the ability to regenerate x/telemetry/config:
```
$ go generate golang.org/x/telemetry/internal/configgen
2025/05/08 10:48:26 listing versions for "github.com/…dmitshur fixed an issue runtime: timeouts on netbsd-arm64-bsiegert builder1w
This issue has stopped matching because this builder in LUCI no longer has -bsiegert in the name (it's still there in the underlying bot name, but the pattern uses builder name), but there've been so…dmitshur commented on runtime: timeouts on netbsd-arm64-bsiegert builder1w
This issue has stopped matching because this builder in LUCI no longer has -bsiegert in the name (it's still there in the underlying bot name, but the pattern uses builder name), but there've been so…dmitshur closed an issue golang.org/x/build: netbsd-amd64-8_0 builder timing out frequently1w
The netbsd-amd64-8_0 builder doesn't exist by now (LUCI has 10.0 and 10.1, old infra has 9.3), closing.dmitshur opened an issue golang.org/x/build: timeout on netbsd-arm64 builder1w
```
#!watchflakes
default <- builder ~ `netbsd-arm64` && (log ~ `SIGQUIT` || log ~ `test timed out` || `failed to start: context deadline exceeded`)
```
Filing this to hopefully catch future instanc…dmitshur fixed an issue golang.org/x/build: LUCI support for plan91w
I believe by now we have resolved the general approach to support Plan 9 testing on LUCI. The plan9 arm and 386 builders seem to be generally working okay for a while now. The amd64 builder seems to …dmitshur commented on golang.org/x/build: LUCI support for plan91w
I believe by now we have resolved the general approach to support Plan 9 testing on LUCI. The plan9 arm and 386 builders seem to be generally working okay for a while now. The amd64 builder seems to …dmitshur commented on golang.org/x/build: bot mac-330-h526 reported as broken1w
I'm not sure why this issue was opened 9 hours ago. Given #72857 is now resolved, this should happen only if the builder is dead for 24 hrs, but from looking at [its task history](https://chromium-sw…dmitshur opened a change golang.org/x/build/main.star: annotate missing riscv64 builders with tracking issues1w
It seems these missing builders need some time before they're back.
Annotate them with tracking issues so that there's less purple on
the gotip post-submit console.
For golang/go#73568.
For golang/g…dmitshur commented on golang.org/x/build/internal/task: update postTweet to Twitter API v2 when possible1w
Noting that we ran into the same error today. (CC @cherrymui.) The app once again ended up becoming "standalone" for reasons unknown to us. We re-added it to the project.dmitshur opened an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs1w
This is an enhancement to speed up the release process and slightly reduce its resource use, by adding some complexity to its implementation that lets it avoid duplicate work.
The Go build system us…dmitshur closed an issue golang.org/x/build: bot mac-331-h526 reported as broken1w
By now the bot is back and idle, having run the last 25+ builds successfully. Not sure that there's anything to do here.dmitshur starred github.com/MaxxWyndham/ToxicRagers1w
Earlier
dmitshur opened an issue golang.org/x/build: gotip-openbsd-riscv64 builder is missing2w
There are currently no bots running at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-openbsd-riscv64.
CC @4a6f656c, @golang/riscv64.dmitshur opened an issue golang.org/x/build: gotip-freebsd-riscv64 builder is missing2w
There are currently no bots running at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-freebsd-riscv64.
CC @mengzhuo, @golang/riscv64.dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder2w
From looking at the source for those functions ([here](https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/luci/appengine/swarming/swarming_bot/api/platforms/linux.py?q=%22%5B%…dmitshur commented on math/big: broken mips and mips64 builders3w
CC @golang/mips.dmitshur commented on cmd/dist: switch to a devel version format that satisfies go/version.Lang and go/version.IsValid in more cases3w
@xnox Including additional fields about the toolchain and its possible modifications in the build information (in addition to the go version string) like that is an interesting idea. It has some conn…dmitshur commented on internal/fuzz: enable fuzz testing on OpenBSD 3w
It would be good to mention this in Go 1.25 release notes (#71661), otherwise users may not know about it. See [doc/README.md](https://cs.opensource.google/go/go/+/master:doc/README.md).dmitshur fixed an issue build: build failure on x/crypto GOARCH=loong64 with Go 1.23/1.24 [consistent failure]3w
These build failures are fixed via revert CLs above. Closing.dmitshur starred github.com/apple/pkl-go-examples3w
dmitshur starred github.com/apple/eidas3w
dmitshur fixed an issue golang.org/x/build: gotip-linux-amd64-misccompile builder fails with no space left on device4w
We haven't seen this happen for a while, right?
I believe this was a combination of some short-lived builder VMs inadvertently staying around for much longer than intended, and some cache directorie…dmitshur fixed an issue golang.org/x/build: set a maintenance window for the kubernetes instance4w
dmitshur commented on golang.org/x/build: set a maintenance window for the kubernetes instance4w
It seems to be generally working well. Let's call this done; we can reopen if more is needed.dmitshur commented on cmd/compile: infinite loop in the inliner4w
We'll need to create a backport candidate issue for the Go1.24.3 milestone; moving this to Go1.25.dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder4w
@srinivas-pokala I believe the change in [crrev.com/c/6439429](https://crrev.com/c/6439429) is rolled out and you should be able to try starting up the builder again.dmitshur fixed an issue golang.org/x/build/internal/relui: TestRelease/major failures [consistent failure]4w
Fixed by [CL 664495](https://go.dev/cl/664495).dmitshur fixed an issue golang.org/x/build/env: host-linux-amd64-sid (Container Image: linux-x86-sid:latest)4w
Closed by merging [CL 665856](https://go.dev/cl/665856) (commit golang/build@48b27723f5bd8d92de3f0fff371a73debc7d8feb) to `luci-config`.dmitshur closed an issue golang.org/x/build: consider adding a linux builder with a newer kernel1mo
The new issue #73405 (CC @prattmic) is a continuation of this, folding this into that.dmitshur closed an issue golang.org/x/build/env/linux: add bleeding edge kernel builder1mo
The new issue #73405 (CC @prattmic) is a continuation of this, folding this into that.dmitshur commented on golang.org/x/build: recent Linux kernel builder1mo
We can try moving the sid builder (#61112) to cos-dev (up from cos-113-lts). If that ends up being too new and too noisy to be useful, we can move down to something less bleeding edge like cos-beta o…dmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time10mo
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.