Activity
Yesterday
dmitshur commented on build: LUCI Python update needed for openbsd ppc64 builder?9h
As far as I can tell, the swarming bot code hasn't been updated to be compatible with Python 3.14 yet, and you're among the first to notice and report this. I see that `pkgutil.get_loader` call is st…dmitshur starred github.com/filippo-claude/goapi10h
dmitshur commented on cmd/go: inferred GOAMD64 value in go env should be applied to build15h
It’s documented at https://pkg.go.dev/cmd/go#hdr-Build_constraints - search for “amd64.v3” as the exact name of the build tag, not “GOamd64.v3”; the GO prefix is a part of the environment v…dmitshur commented on cmd/go: check that insecure scheme is permitted by GOINSECURE16h
(1 comment)
I removed it to improve readability of this code. The blank line doesn’t seem helpful. Without the blank line, it’s clear that the value of security is computed to be one of web.Secu…dmitshur commented on doc: write release notes for Go 1.2719h
@stefanb It was noted in https://go.dev/doc/go1.25#json_v2, back when the encoding/json/v2 package started its experimental phase, that its design would evolve. I imagine users who have been experime…dmitshur reviewed +2 on cmd/dist: remove unused omitVariant field21h
Thanks.Last Week
dmitshur fixed an issue golang.org/x/pkgsite/internal/godoc/dochtml/internal/render: TestFormatDocHTML failures1d
Fixed by [CL 801520](https://go.dev/cl/801520).dmitshur commented on golang.org/x/pkgsite/internal/godoc/dochtml/internal/render: TestFormatDocHTML failures1d
Fixed by [CL 801520](https://go.dev/cl/801520).dmitshur reviewed +2 on golang.org/x/playground/...: run go fix ./...1d
Thanks.
I think some of the fixes by default leave code in a way that its readability can be improved when considering the context. I left some minor suggestions.
The variable name "before" is very…dmitshur reviewed +2 on golang.org/x/playground/sandbox: instrument container wait time (queue delay)1d
Thanks.
```suggestion
func getContainer(ctx context.Context) (_ *Container, err error) {
start := time.Now()
```dmitshur commented on golang.org/x/playground/...: turn down go2goplay appengine instance1d
(4 comments)
https://go.dev/doc/contribute#commit_messages suggest to "Write in complete sentences with correct punctuation, just like for your comments in Go." It's probably fine not to even mentio…dmitshur reviewed +2 on go.dev/wiki/Watchflakes: add example for matching all subtests1d
Thanks.
Because of the mandatory '/', this will exclude failures in the top-level TestServeIndexHtml test itself. Maybe it's more common to want to match the test and all its subtests too? If so, co…dmitshur reviewed +2 on Revert "cmd/compile: optimize abi.Type.TFlag loads"1d
Thanks.
I'll also add an optional x_build-gotip-linux-amd64 trybot here so we can see what it reports.
https://go.dev/wiki/CommitMessage#reverts suggests including the CL number.
```suggestion
Thi…dmitshur commented on cmd/compile: "hasUncommon: methods not computed" ICE as of CL 7012991d
It's not a problem for x/build itself, since we generally use stable Go releases there, so no worries there. It's good that it was able to uncover this.
Depending on how much other code this problem…dmitshur opened an issue cmd/compile: "hasUncommon: methods not computed" ICE as of CL 7012991d
At tip, starting with [CL 701299](https://go.dev/cl/701299), building the [golang.org/x/build/internal/relui](https://golang.org/x/build/internal/relui) package has started to fail with:
```
FAIL go…dmitshur commented on html/template: potential XSS caused by wrong JavaScript regexp context tracking after top-level `{`2d
Which release is this a blocker for? (This issue currently has no Milestone, making the release-blocker label a no-op.)dmitshur reviewed +2 on Revert "cmd/compile: on AMD64 use leave instruction for go compiled functions"2d
Thanks.dmitshur reviewed +2 on all: update vendored dependencies2d
Thanks.dmitshur commented on all: update vendored dependencies2d
(1 comment)
I'd expect this version to get maintained, but you may have not picked up the absolute latest updatestd. It's fine since it'll happen in a future run too.dmitshur commented on all: update vendored dependencies2d
The bootstrap on the builders should be go1.26.0 as of CL 801200. There's also been a small updatestd update recently, so consider rebasing and regenerating. I also left a suggestion about git-genera…dmitshur commented on golang.org/x/pkgsite/internal/godoc/dochtml/internal/render: fix tests2d
(1 comment)
```suggestion
For golang/go#76975.
Change-Id: Ibc508c39eb4785515d98b4eaf4fce299831b4924
```
So that this CL shows up in the timeline of that proposal.dmitshur commented on cmd/go/internal/telemetrystats: drop go/platform/target/{goos,goarch}:*3d
Letting this land for Go 1.28.
Thanks.dmitshur commented on reflect: [release-branch.go1.27] extract potentially embedded reflect types before use3d
Trybot failure looks like #76901, retrying it.dmitshur reopened an issue reflect: memory unsafety due to interface shadowing in reflect3d
Reopening for [CL 801220](https://go.dev/cl/801220) submission.dmitshur reopened an issue reflect: memory unsafety due to interface shadowing in reflect3d
Reopening for [CL 801220](https://go.dev/cl/801220) submission.dmitshur reopened an issue cmd/go: doc -http fails with "doc: no such file or directory" on first run with clean GOCACHE3d
The fix landed after the tree opened for Go 1.28 development, so reopening to track this being cherry picked to release-branch.go1.27.dmitshur reopened an issue cmd/go: doc -http fails with "doc: no such file or directory" on first run with clean GOCACHE3d
The fix landed after the tree opened for Go 1.28 development, so reopening to track this being cherry picked to release-branch.go1.27.dmitshur reviewed +2 on golang.org/x/website/internal/web: render markdown tables with scrollbars3d
Thanks.
This seems like a reasonable approach. I'll note that since we're dealing with HTML and Markdown and CSS and differently sized devices here, I also anticipate there's some chance of this lea…dmitshur commented on golang.org/x/build/main.star: use Go 1.26.0 as bootstrap on tip (Go 1.28 to be)3d
(1 comment)
This change is ready for review.
Tested via a shadow bucket build at https://ci.chromium.org/b/8676172686530536289. It's based on the real build https://ci.chromium.org/b/86761811769047…dmitshur commented on golang.org/x/website/cmd/golangorg: add <head> tag before </head>3d
Thanks.dmitshur opened a change golang.org/x/build/main.star: use Go 1.26.0 as bootstrap on tip (Go 1.28 to be)3d
For golang/go#77341.dmitshur reviewed +2 on cmd/go: [release-branch.go1.27] do not pass -mthreads to C compiler on Windows3d
Thanks.dmitshur commented on golang.org/x/build/cmd/updatestd: maintain cmd/go/internal/doc selection of pkgsite version3d
Thanks.
Thanks for suggesting astutil.Apply - though I knew about the existence of that package, I hadn't used it in a long while and didn't think to look there when implementing this. I did conside…dmitshur commented on internal/goversion: increment Version at start of cycle3d
This is already done for the Go 1.28 cycle via [CL 800721](https://go.dev/cl/800721) (CC @matloob). Moving to the next milestone.dmitshur closed an issue cmd/distpack: exclude the .jj directory [1.27 backport]3d
@nsrip-dd Please note https://go.dev/s/release#july--january-week-3-work-on-the-next-release-begins:
> During this period, fixes intended for the current release need to be [cherry-picked onto the r…dmitshur commented on : [release-branch.go1.27] Merge commit 'master^{/internal/goversion}~' into release-work4d
https://go.googlesource.com/go/+diff/refs/changes/60/800760/1..a5f29a67d7a26ce6d4d7c2fbae12d93a4ea8b24e matches my expectation.
Suggestion:
```
[release-branch.go1.27] all: merge master (a5f29a67) …dmitshur commented on cmd/distpack: exclude the .jj directory4d
(1 comment)
This '.git/**' entry has corresponding checks in src/cmd/distpack/test.go. Maybe it's worth adding analogous ones for similar reasons.dmitshur reviewed +1 on src/cmd/go/internal/doc: always return cached executable4d
(3 comments)
In the main Go repo, the "src" path element is normally left out, so that the path is closer to the actual import path of the relevant Go package.
```suggestion
cmd/go/internal/doc: al…dmitshur reviewed +2 on go/build/constraint: match "go1." only as a tag prefix in GoVersion4d
Thanks again.dmitshur reviewed +2 on go/build/constraint: match "go1." only as a tag prefix in GoVersion4d
(1 comment)
This parent commit is a bit old, before the fix for #80212 landed, so that particular test will fail. Rebasing would resolve that, otherwise we can bypass if that's the only failing test.dmitshur commented on cmd/vet: improve how stdversion analyzer refers to methods4d
(1 comment)
I checked locally that this works with a generic method (that @mpratt@google.com originally reported this with), and it does work as expected:
```
$ go vet -stdversion
main.go:7:19: ran…dmitshur reviewed +2 on go/build/constraint: match "go1." only as a tag prefix in GoVersion4d
Thanks.
I understand this test case, in contrast to the one above, captures the case where it's not a valid version but it does have a valid version as a substring. It seems like a good idea to add …dmitshur opened a change cmd/vet: improve how stdversion check refers to methods4d
Pull in the fix implemented in CL 800620.
Fixes #80363.
[git-generate]
updatestd -goroot=$(pwd) -branch=internal-branch.go1.27-vendordmitshur commented on github.com/go-gl/gl: Error about -mthreads option, when trying to use clang on Windows4d
Also see golang/go#80290.dmitshur commented on doc: write release notes for Go 1.274d
We removed the release-blocker label since there doesn't seem to be anything actionable left that would block the release. This issue will stay open to track any further refinement and improvement le…dmitshur opened a change golang.org/x/tools/go/analysis/passes/stdversion: [internal-branch.go1.27-vendor] correctly format symbol names4d
The existing formatting completely forgot to include the
type name T in the name of a field or method pkg.T.name.
Since this cannot be derived from a field *types.Var, we
change TooNewStdSymbols to …dmitshur commented on lib/time: update tzdata before release4d
Thanks. 2026c landed in time for Go 1.27.0. It's likely the last tzdata release to be included, so moving this to the next milestone. (If another tzdata release happens with some time before 1.27.0, …dmitshur reviewed +2 on std: address ptrtoerror analyzer diagnostics4d
Thanks.
Do you have an opinion on whether an assertion like this should go into test code (i.e., in a _test.go file) or the package implementation code? I have a slight preference for placing these …dmitshur reviewed +2 on golang.org/x/tools/go/analysis/passes/stdversion: correctly format symbol names5d
Earlier
dmitshur commented on cmd/vet: pull in CL 7994411w
(1 comment)
Fix applied.dmitshur reviewed +2 on golang.org/x/tools/go/analysis/passes/stdversion: correctly format symbol names1w
Thanks. There are some gopls tests that aren't passing yet.
Is you preference to include this in 1.27's vet output too, or do you think this might be too risky or disruptive and better to leave to G…dmitshur commented on cmd/fix: pull in CL 7994411w
(1 comment)
```suggestion
cmd/vet: pull in CL 799441
```
Will apply before submitting (not while trybots are running, to avoid interrupting).dmitshur opened a change cmd/fix: pull in CL 7994411w
Fixes #80360.
[git-generate]
updatestd -goroot=$(pwd) -branch=internal-branch.go1.27-vendordmitshur commented on golang.org/x/tools/go/analysis/passes/stdversion: stdversion check refers to "rand.(*Rand).N" method as "rand.N"1w
It looks like this isn't a regression related to generic methods, rather it's how this check displays methods in general:
<img width="568" height="293" alt="Image" src="https://github.com/user-attac…dmitshur commented on cmd/vet: stdversion check doesn't report uses of Go 1.27 APIs in pre-1.27 modules1w
@prattmic Thanks. Factored that out into #80363 since it might be more involved, and updated this to be about the more general problem of cmd/vet not being aware of all new-to-1.27 symbols.dmitshur opened an issue golang.org/x/tools/go/analysis/passes/stdversion: stdversion check refers to "rand.(*Rand).N" method as "rand.N"1w
Consider:
```shell
$ cat <(echo -- go.mod --) go.mod <(echo -- main.go --) main.go
-- go.mod --
module test
go 1.25.0
-- main.go --
package main
import ("fmt"; "math/rand/v2")
func main() {
r…dmitshur opened a change golang.org/x/tools/internal/stdlib: [internal-branch.go1.27-vendor] update stdlib index for Go 1.27 Release Candidate 21w
For golang/go#38706.
For golang/go#80360.
[git-generate]
go run golang.org/dl/go1.27rc2@latest download
go run golang.org/dl/go1.27rc2@latest generate ./internal/stdlibdmitshur opened a change golang.org/x/tools/internal/stdlib: [internal-branch.go1.27-vendor] update stdlib index for Go 1.27 Release Candidate 11w
For golang/go#38706.
For golang/go#80360.
[git-generate]
go run golang.org/dl/go1.27rc1@latest download
go run golang.org/dl/go1.27rc1@latest generate ./internal/stdlibdmitshur opened an issue cmd/vet: stdversion check doesn't report uses of Go 1.27 APIs in pre-1.27 modules1w
Consider:
```shell
$ cat <(echo -- go.mod --) go.mod <(echo -- main.go --) main.go
-- go.mod --
module test
go 1.25.0
-- main.go --
package main
import ("fmt"; "math/rand/v2")
func main() {
r…dmitshur commented on cmd/go: don't run cgo compiler version probe under -toolexec1w
(1 comment)
I'm okay with your decision on this. Thanks for considering it.dmitshur commented on golang.org/x/build/cmd/relui: consider target versions of security fixes in security comms1w
(1 comment)
Sounds good. Given we have agreement, we can move in that direction. It can happen independently of this change though, so added it as a TODO comment for now.dmitshur reviewed +2 on golang.org/x/playground/sandbox: prevent startContainer from hanging on timeout1w
Thanks.
Note that this non-nil error is also being returned to the caller to be handled. Adding a log line here will cause it to be double-logged, see line 185.
The new log line includes scanner.Te…dmitshur reviewed +2 on golang.org/x/playground/sandbox: parameterize image tags and update docker install1w
Thanks.
Does it help for this to use $TAG too?
```suggestion
docker run --name=sandbox_dev --rm --network=sandnet -ti -p 127.0.0.1:8080:80/tcp -v /var/run/docker.sock:/var/run/docker.sock golang/p…dmitshur reviewed +2 on golang.org/x/build/cmd/relui: add govulncheck-action repo tagging workflow1w
dmitshur reviewed +2 on golang.org/x/build/cmd/relui: add govulncheck-action repo tagging workflow1w
Thanks. One more comment in Workflow.Run, otherwise I don't see anything more from my side, and I think you should feel free to submit this and/or try it out. As with any new workflow, trying it out …dmitshur reviewed +2 on all: use path for go.mod module path1w
Thanks.
```suggestion
module crypto/internal/fips140/sha3/_asm
```
Unrelated to this CL, but I wonder what is the motivation for this go.mod? Usually they're used to track tools used for code gener…dmitshur commented on golang.org/x/build: try a -racegocommand builder1w
Both the -racegocommand and -racegocommand-noopt builders have been running for some time, and so far they haven't uncovered interesting races in the go command. Issue #79667 turned out to be a probl…dmitshur reviewed +1 on cmd/go: don't run cgo compiler version probe under -toolexec1w
(1 comment)
A question related to this. As far as I see, TOOLEXEC_CDRIVER_LOG is only used to by this test in one way: to point it to a cdriver.log file and then later on check under cgo that it doe…dmitshur opened an issue os: TestRootMultiReadFile fails on netbsd/arm64 after CL 7978801w
See https://ci.chromium.org/ui/p/golang/builders/ci/gotip-netbsd-arm64/b8676812685865790769/overview for example. (A different test fails on Plan 9, see #80319.)
CC @golang/netbsd.dmitshur closed an issue golang.org/x/build/cmd/coordinator: mind combined memory usage when concurrently processing large payloads1w
We got by with increasing memory available to coordinator. By now it no longer does builds itself, only displays an old-style dashboard [build.golang.org](https://build.golang.org) pointing to [LUCI …dmitshur commented on os: TestRootConsistencyRemoveAll fails on Plan 9 after CL 7978801w
CC @golang/plan9.dmitshur commented on golang.org/x/build/relnote: ignore comment-only markdown files1w
Thanks for implementing this.
I left some review comments. In general, this looks like a good start, and when the comments are resolved we should be able to submit this.
Two suggestions here.
One,…dmitshur reviewed +2 on cmd/go: split test_vet script test for improved parallelism1w
Thanks.dmitshur reviewed +2 on cmd/go: split build_overlay script test to improve parallelism1w
Thanks.dmitshur reviewed +2 on golang.org/x/playground/sandbox: replace deprecated Konlet with systemd service in cloud-init1w
Thanks. I'm not familiar enough with the lower level details involved in this, but it makes sense to migrate off a deprecated mechanism.dmitshur closed a change golang.org/x/website/_content/doc/tutorial/generics.md: fix typo1w
This change is applied via https://go.dev/cl/782240.dmitshur reviewed +2 on golang.org/x/build/main.star: add c4d (AMD Turin) builders1w
Thanks.
Since this CL is a part of what's needed, you might want to keep the issue open for a bit until the VMs are up and everything works as you expect.
Unless I missed it, you'll still need to d…dmitshur commented on golang.org/x/build/internal/task: add support for okay-after-rc2 label1w
Thanks.
Yeah, I considered that too but stopped at just rc2 for now to match the labels that exist. For rc3 hopefully we'll really resolve all release blockers or remove the release-blocking label. …dmitshur closed a change golang.org/x/build/cmd/coordinator: lower the memory allocation1w
Replaced with CL 798540.dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: update resource allocations1w
Thanks.
I did something similar in CL 732263 earlier. It's still open because I was deciding whether to lower it a bit further before submitting. By now all legacy builds are stopped, so let's go wi…dmitshur commented on cmd/fix: pull in CL 7916601w
Thanks.dmitshur reviewed +2 on lib/time: update to 2026c/2026c1w
Thanks.dmitshur opened a change cmd/fix: pull in CL 7916601w
Generated with updatestd, though it's equivalent to manually running:
cd src/cmd
go get golang.org/x/tools@internal-branch.go1.27-vendor # v0.45.1-0.20260708165844-7044391f8d9f
go mod tidy
go mod v…dmitshur reviewed +2 on golang.org/x/build/internal/coordinator/remote: avoid a potential deadlock1w
Thanks.dmitshur fixed an issue golang.org/x/tools: tests on internal-branch.go1.27-vendor branch aren't passing with go1.27rc21w
Fixed by the aforementioned CLs.dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: remove gomote functionality from the coordinator1w
dmitshur reviewed +1 on golang.org/x/tools/go/analysis/passes/printf: reject %d of pointer or chan1w
Thanks. This looks okay to me so +1, though I expect there may be a better reviewer for go/analysis/passes packages. I understand this will be waiting on the proposal to be accepted anyway.
It took …dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.27-vendor] preserve symbols in reflecttypefor1w
Filed #80296 for this problem and mailed CLs. I'll rebase this on top, that should fix the trybots here.dmitshur commented on golang.org/x/tools/go/analysis/passes/printf: [internal-branch.go1.27-vendor] adjust printf analyzer for CL 7843811w
This change gets the [golang.org/x/tools/go/analysis/passes/printf.Test](https://ci.chromium.org/ui/p/golang/builders/try/x_tools-go1.27-linux-amd64-longtest/b8676896302437009505/test-results?q=Ex…dmitshur commented on golang.org/x/tools/go/ssa: [internal-branch.go1.27-vendor] reject generic methods from RuntimeTypes1w
This change gets the [golang.org/x/tools/go/ssa.TestStdlib](https://ci.chromium.org/ui/p/golang/builders/try/x_tools-go1.27-linux-amd64-longtest/b8676896325792242385/test-results?q=ExactID%3Agolan…dmitshur opened a change golang.org/x/tools/gopls/internal/test/marker: [internal-branch.go1.27-vendor] update hover test1w
CL 784060 updates Types.Info.Instantiations to preserve receivers
for generic methods, which breaks these tests. This change updates
a test to allow that CL to merge.
For golang/go#79657.
Fixes gola…dmitshur opened an issue golang.org/x/tools: tests on internal-branch.go1.27-vendor branch aren't passing with go1.27rc21w
The `internal-branch.go1.27-vendor` branch in x/tools was created quite early after the start of the Go 1.27 release freeze, as opposed to closer to when the Go 1.27 release freeze will be ending. So…dmitshur commented on golang.org/x/website/_content/doc: update PATH docs and restructure manage-install.html1w
Thanks.dmitshur reviewed +2 on os: properly handle trailing slashes in paths in Root1w
Thanks.dmitshur fixed an issue security: fix CVE-2026-39822 [1.25 backport]1w
Closed by merging [CL 797660](https://go.dev/cl/797660) (commit c94048f5638bbcaa22102bade5e9774e0d485315) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-39822 [1.26 backport]1w
Closed by merging [CL 797661](https://go.dev/cl/797661) (commit f9ef7f55988f03afeb3b8354367d0fa8d053683d) to release-branch.go1.26.dmitshur commented on os: [release-branch.go1.26] properly handle trailing slashes in paths in Root1w
(1 comment)
Since this is a release-branch.go1.26 backport CL, it would've been optimal if the commit message had:
```suggestion
For #79005.
Fixes #79027.
```
Then the Go1.26.5 backport issue #790…dmitshur fixed an issue golang.org/x/build: bot openbsd-riscv64-jsing reported as broken1w
It seems to be back online and running. Thanks @4a6f656c.dmitshur reviewed +1 on golang.org/x/website/internal/history: document Go 1.26.5 and 1.25.12 releases1w
dmitshur commented on golang.org/x/pkgsite: support generic methods and show "Migrating to v2" in encoding/json1w
> I investigated this issue and found that updating "pkgsiteCmdInternalDocVersion" to "v0.0.0-20260630164626-55ca6a10dee5" fixes the generic method rendering problem. I verified that "go doc -http" n…