Activity
Today
dmitshur commented on golang.org/x/build/...: handle err in Walk and WalkDir more consistently52m
(1 comment)
I should add a colon here for consistency.
```suggestion
log.Fatalln("MkdirTemp:", err)
```dmitshur commented on golang.org/x/build/...: handle err in Walk and WalkDir more consistently1h
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/task: fix panic in fs.WalkDir when initial stat fails3h
Thanks. I also sent you CL 823285.dmitshur opened a change golang.org/x/build/...: handle err in Walk and WalkDir more consistently3h
buildToOutputs was outright missing an error check. Add it, and make a
few other places more consistently handle error as the very first step
so that it's easier to see.dmitshur commented on cmd/go: TestScript/gotoolchain_path broken on openbsd3h
CC @golang/openbsd.dmitshur commented on cmd/go: TestScript/cover_atomic_pkgall broken on riscv643h
CC @golang/riscv64.dmitshur commented on cmd/go: TestScript/cgo_path_space_quote is broken on ppc64/ppc64le3h
CC @golang/ppc64.dmitshur reviewed +2 on golang.org/x/build/internal/relui: patch tests to use runToFailure explicitly3h
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: patch non-security tasks assuming milestone exists3h
Thanks.
There used to be times when it wasn't as rare. 😅
Earlier on I wasn't sure if the eventual plan to represent "no security fixes" was going to be "no milestone", or "a milestone that exist…dmitshur commented on golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for release branches)4h
We've had a chance to test out this functionality over the last several releases, both in cases where there were 1+ PRIVATE-track security fix CLs to upstream and when there weren't any, and it's bee…dmitshur opened a change golang.org/x/build/internal/relui: factor upstreaming private-track CLs tasks into methods4h
It was convenient to have the functionality for automated upstreaming of
private-track security fixes on release day in addSingleReleaseWorkflow
when it was being developed. By now the development wo…dmitshur fixed an issue golang.org/x/build/cmd/relui: improve security release automation4h
There's been a lot of progress on this, and the "automate assembling the internal commits into a branch, and exporting the changes from that branch on release day" bar is certainly met. Closing in fa…dmitshur commented on golang.org/x/build/cmd/relui: improve security release automation4h
There's been a lot of progress on this, and the "automate assembling the internal commits into a branch, and exporting the changes from that branch on release day" bar is certainly met. Closing in fa…dmitshur commented on cmd/go: remove [short] skip from even more script tests6h
Note that darwin/amd64 builders with macOS 13 & 14 have started to fail with timeouts, and cmd/go.TestScript/cgo_path_space_quote has started to run on ppc64 builders and it fails as visible on the […dmitshur commented on golang.org/x/website/cmd/{adminapp,adminredirect,googlegolangorg}: update App Engine runtime6h
Thanks.dmitshur reopened an issue golang.org/x/mobile: type aliases no longer export6h
dmitshur reopened an issue golang.org/x/mobile: type aliases no longer export6h
dmitshur reviewed +2 on golang.org/x/website/_content/tour: wrap overflowing text in code-area output7h
dmitshur reviewed +2 on golang.org/x/website/internal/dl: sort multi-digit prerelease versions numerically8h
Thanks. Just two minor comments left.
Please also insert a blank line above this line, so that the "Populate ..." code block is separate.
Please insert a blank line after this line. It's meaningful…dmitshur commented on golang.org/x/build/devapp/owners: add nealpatel to go/src/crypto,math and exp/stats8h
Thanks.dmitshur commented on golang.org/x/build/...: update Go and Debian versions in Dockerfiles8h
(1 comment)
(nit: I should've left this part out since there didn't need to be Debian version changes; trixie is still the current stable. I inadvertently carried this over from the subject of CL 69…dmitshur commented on database/sql: closingMutex lost wakeup deadlocks Rows.Next against concurrent Rows.Close8h
CC @neild, @bradfitz, @kardianos.dmitshur commented on cmd/compile: [release-branch.go1.26] fix mergelocals for arm32/s390x/riscv648h
(1 comment)
Noting that Keith also sent CL 812900 for this issue earlier.Yesterday
dmitshur opened a change golang.org/x/build/...: update Go and Debian versions in Dockerfiles1d
As of CL 817742, go1.26.0 is this module's minimum toolchain version.
For golang/go#72774.
[git-generate]
find . -type f -name 'Dockerfile' -exec sed -i '' 's/golang:1.25/golang:1.27/' {} +dmitshur reviewed +2 on golang.org/x/build/internal/relui: make security release disclosure idempotent1d
dmitshur reviewed +2 on cmd/go: remove [short] skip from even more script tests1d
Thanks. gotip-linux-amd64 took 10m25s, which seems pretty good.dmitshur reviewed +2 on golang.org/x/website/_content/tour: wrap overflowing text in code-area output1d
Thanks.
Formatting nit, for consistency with other lines here:
```suggestion
.output > pre > span {
```dmitshur commented on golang.org/x/build/main.star: don't run longtest builders if cmd/go is modified1d
(1 comment)
In the future you'll want to update your lucicfg version. I don't think it matters for this CL.dmitshur reviewed +2 on golang.org/x/build/main.star: don't run longtest builders if cmd/go is modified1d
Thanks.dmitshur reviewed +2 on golang.org/x/sys/unix: run go fix1d
(1 comment)
Thanks.dmitshur reviewed +2 on cmd/go: remove [short] skip from some more script tests1d
Thanks.
Interesting that this doesn't end up being as slow as one could've expected rebuilding all of std to be.dmitshur reviewed +2 on cmd/go/testdata/script: remove redundant GO111MODULE=on1d
Thanks.dmitshur reviewed +2 on cmd: [release-branch.go1.27] vendor changes for "go fix"1d
Thanks.
This is expected because `go mod vendor` vendors package code, but it doesn't include _test.go files. Those live only in the upstream packages. See https://pkg.go.dev/cmd/go#hdr-Make_vendore…dmitshur reviewed +2 on golang.org/x/build/internal/relui: add SecurityReviewersParameter1d
Thanks.
Yep, it's a [property](https://cs.opensource.google/go/x/build/+/master:internal/gophers/gophers.go;l=42-45;drc=d955bf84b4b91d638eba901cbc7e01722e79fa98) of the interal/gophers package that …dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.27-vendor] embedlit: check index paths1d
Thanks.dmitshur starred github.com/rsc/cmd1d
dmitshur commented on golang.org/x/review/internal/gerrit: new package defining gerrit types1d
(1 comment)
Has it already been considered to reuse one of the existing ones (e.g., https://golang.org/x/build/gerrit or https://pkg.go.dev/github.com/andygrunwald/go-gerrit), and decided that the t…dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.27-vendor] embedlit - skip if no selections are embedded1d
(1 comment)
Tests seem to pass with it, and it's also there in the upstream CL 797560, so it should be fine for the backport CL to be consistent with that. (But it can probably be removed on the mai…dmitshur commented on golang.org/x/build/...: add shared infrastructure for security release integration1d
(1 comment)
DeleteBranch is a better fit for DestructiveGerritClient, isn't it?
(If you'd like to change it but it's a bit disruptive this early in the stack, note that it's also fine to defer to e…dmitshur reviewed +2 on cmd/go: remove [short] skip from some script tests1d
dmitshur commented on sort: add //go:fix inline directives for slices forwarding functions1d
Thanks for making this suggestion too. Updated [CL 783580](https://go.dev/cl/783580) to mention this issue.
https://go.dev/wiki/Deprecated is clear that deprecating an exported symbol requires a pro…dmitshur commented on sort: add go:fix inline directives to convenience wrappers1d
(2 comments)
This change is ready for review.
Hold for #80795.
Will use issue #80795. We can make it a proposal and discuss whether to also to deprecate at the same time as adding these go:fix inl…dmitshur reviewed +2 on golang.org/x/build/internal/relui: make publicize step idempotent1d
Thanks.
https://go.dev/s/style#declaring-empty-slices suggests:
> When designing interfaces, avoid making a distinction between a nil slice and a non-nil, zero-length slice, as this can lead to sub…dmitshur commented on golang.org/x/build/internal/relui: optional security milestone with confirmation gate1d
(1 comment)
Note that I would expect you'll need to add a " (optional)" suffix to the parameter name in order for relui to permit the empty string input, since it's that's the zero value of string. …dmitshur reviewed +2 on cmd/go: remove [short] skip from some script tests1d
Thanks.
In my quick testing on a moderately representative machine, `go test -count=1 -short cmd/go/...` went from around 24 seconds to around 30 seconds, which seems very reasonable.
Is it intenti…This Week
dmitshur commented on cmd/go: start a test case for an insecure scheme check2d
The only failures were in net/http due to an unrelated existing issue #78701. The rest passed. Bypassing.dmitshur commented on cmd/go: check that insecure scheme is permitted by GOINSECURE2d
The only failures were in net/http due to an unrelated existing issue #78701. The rest passed. Bypassing.dmitshur commented on net/http: re-enable HTTP/3 tests now that fake network is supported2d
(1 comment)
See longtest builders at https://ci.chromium.org/p/golang/g/go-gotip/console and recent failures in #78701.dmitshur closed an issue cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes [1.26 backport]2d
We approved this backport request fairly early on after the Go 1.26.0 release, but the issue is still not resolved at tip. Closing this backport issue for now, and once the upstream issue is resolved…dmitshur closed an issue cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes [1.26 backport]2d
We approved this backport request fairly early on after the Go 1.26.0 release, but the issue is still not resolved at tip. Closing this backport issue for now, and once the upstream issue is resolved…dmitshur reviewed +2 on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.27-vendor] embedlit invalid fix2d
dmitshur commented on net/http: TestErrorContentLength/h1 failures2d
CC @golang/ppc64.dmitshur closed a change golang.org/x/tools/gopls/internal/analysis/modernize: fix a typo in deprecation warning path2d
This change is applied in go.dev/cl/730820. Thanks.dmitshur commented on net/http: `expect: 100-continue` handling is broken in various ways2d
> is there anything else needed for this issue
There are 3 tests in net/http that are currently skipped that [point to this issue](https://cs.opensource.google/search?q=%22go.dev%2Fissue%2F67555%22&…dmitshur closed an issue net/http: TestServerReadAfterWriteHeader100Continue/h1 failures2d
dmitshur fixed an issue golang.org/x/crypto/x509roots: regeneration fails with "404 Not Found"2d
Over the last couple weeks, this hasn't happened. Closing optimistically.dmitshur commented on golang.org/x/crypto/x509roots/fallback/bundle: make subjectsEqual stricter on Go 1.27+2d
Thanks.
Done. The bundle was generated with it in CL 820300.dmitshur commented on golang.org/x/sys/unix: modernize2d
(1 comment)
Note that this command is marked as deprecated, so if running that command causes some problem there'd be no good path forward without migrating off that command. Since proposal #71859 i…dmitshur opened a change cmd/go/internal: [release-branch.go1.26] fix copy paste error2d
For #80850.
Fixes #80851.dmitshur commented on golang.org/x/website/internal/dl: sort multi-digit prerelease versions numerically3d
(2 comments)
[sort.Slice](https://pkg.go.dev/sort#Slice) documentation includes:
> Note: in many situations, the newer [slices.SortFunc](https://pkg.go.dev/slices#SortFunc) function is more ergonom…dmitshur commented on golang.org/x/tools/internal/modindex: memoize the index parsed by Read3d
Trybot failures seem to be due to an unrelated issue #81068, which is fixed now so restarting them.dmitshur fixed an issue golang.org/x/tools/gopls/internal/test/integration/misc: TestCompilerOptDetails failures on Windows [consistent failure]3d
Indeed; fixed by [CL 820440](https://go.dev/cl/820440).dmitshur fixed an issue golang.org/x/tools/gopls/internal/test/integration/misc: TestCompilerOptDetails failures on Windows [consistent failure]3d
Indeed; fixed by [CL 820440](https://go.dev/cl/820440).dmitshur reviewed +2 on golang.org/x/website/doc: retro-actively document removal of tlkskyber GODEBUG flag3d
Thanks.dmitshur reopened an issue cmd/compile: -trimpath and -json=0,file flags may lead to invalid "file://" URLs3d
Reopening since the fix [CL 806961](https://go.dev/cl/806961) is reverted in [CL 820440](https://go.dev/cl/820440).dmitshur commented on golang.org/x/tools/gopls/internal/test/integration/misc: TestCompilerOptDetails failures on Windows [consistent failure]3d
There's a revert [CL 820440](https://go.dev/cl/820440) which I understand intends to fix this. (CC @dr2chase, @pjweinb.)dmitshur commented on text/template: update range documentation3d
Thanks.dmitshur fixed an issue net: TestLookupCNAME failures3d
The solaris-amd64 failure above is a different problem; re-closing and letting it be handled in a separate issue.dmitshur fixed an issue net: TestLookupCNAME failures3d
The solaris-amd64 failure above is a different problem; re-closing and letting it be handled in a separate issue.dmitshur commented on golang.org/x/tools/internal/imports: modindex.Read is called for every file before it is known to be needed3d
Note that it's also possible to try a newer version that includes the fix by using its pseudo-version, such as `v0.49.1-0.20260813165158-3c18a2d52646`, ahead of its includion in the next release tag …dmitshur fixed an issue golang.org/x/build: bot openbsd-ppc64-n2vi reported as broken3d
Issue #80220 is resolved, and openbsd-ppc64-n2vi is back online and [green](https://ci.chromium.org/ui/p/golang/g/port-openbsd-ppc64/builders). Thanks. Closing.dmitshur fixed an issue golang.org/x/build: bot openbsd-ppc64-n2vi reported as broken3d
Issue #80220 is resolved, and openbsd-ppc64-n2vi is back online and [green](https://ci.chromium.org/ui/p/golang/g/port-openbsd-ppc64/builders). Thanks. Closing.dmitshur reviewed +2 on golang.org/x/website/doc: retro-actively document removal of tlkskyber GODEBUG flag3d
Thanks.
Yeah, I think the 1.24 release notes is a better place to add this note. After some time passes, most people looking to learn what changed in it would be looking there rathe than in 1.27 rel…dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue for plan9-amd64 builder4d
Marking as resolved (per discussion in other thread). There are still some failures on https://ci.chromium.org/ui/p/golang/builders/ci/gotip-plan9-amd64, but that can be tracked in a followup to #636…dmitshur reviewed +2 on github.com/andygrunwald/go-gerrit: Raise minimum Go version in go.mod from 1.16 to 1.264d
LGTM. Thanks.dmitshur commented on github.com/go-gl/glfw: consider adding release tags4d
Made the [second pre-release tag](https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw@v0.1.0-pre.2) to include some of the follow up fixes to v3.4/glfw. If some time passes and there aren't problems r…dmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: Wayland scaled display issue4d
Closing as resolved in v3.4.dmitshur fixed an issue github.com/go-gl/glfw: Wayland scaled display issue4d
Closing as resolved in v3.4.dmitshur closed a change github.com/go-gl/glfw/glfw/v3.3: fix build warnings4d
Thanks for preparing this. Closing since this change needs to happen upstream. Note that by now v3.4 has superseded v3.3, so it may make sense to redirect our attention towards the latest version in …dmitshur commented on github.com/go-gl/glfw/glfw/v3.3: fix build warnings4d
Thanks for preparing this. Closing since this change needs to happen upstream. Note that by now v3.4 has superseded v3.3, so it may make sense to redirect our attention towards the latest version in …dmitshur closed a change github.com/go-gl/glfw/glfw/v3.3: fix build warnings4d
dmitshur fixed an issue github.com/go-gl/glfw: Vendoring is broken in v3.44d
dmitshur pushed to
master in github.com/go-gl/glfw4ddmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: vendoring is broken4d
dmitshur merged a change github.com/go-gl/glfw: Fix preserving wayland headers in vendor4d
dmitshur reviewed +2 on github.com/go-gl/glfw: Fix preserving wayland headers in vendor4d
Thanks.dmitshur reviewed +2 on golang.org/x/website/_content/tour: clarify wording about loop init statement4d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue for plan9-amd64 builder4d
dmitshur commented on golang.org/x/build/main.star: remove known issue for plan9-amd64 builder4d
Thanks very much, and congrats on reaching this point.
Please rebase and regenerate this.dmitshur commented on github.com/andygrunwald/go-gerrit: Raise minimum Go version in go.mod from 1.16 to 1.264d
One more note. In the PR description it was mentioned that this change was done with `go mod edit -go=1.26`. In most cases it should be a better experience to manage the `go` directive with the `go g…dmitshur commented on github.com/andygrunwald/go-gerrit: Raise minimum Go version in go.mod from 1.16 to 1.264d
Thanks, this generally looks good. I left two minor comments.
I suggest picking `1.26.0` for the `go` directive here.
Prior to Go 1.21, major releases didn't have a ".0" at the end. See https://go.…Last Week
dmitshur commented on github.com/andygrunwald/go-gerrit: Support Go 1.27 and put staticcheck under Renovate management5d
Sounds good, thanks.
If someone wishes to use an older version of go-gerrit before its `go` directive increased for a while longer, even if you don't tag, they could still use the corresponding ps…dmitshur commented on github.com/andygrunwald/go-gerrit: Support Go 1.27 and put staticcheck under Renovate management5d
> Go 1.27.0 is the current upstream release, so the supported window moves to 1.27 + 1.26 per the [Go Release Policy](https://go.dev/doc/devel/release.html#policy) the README commits to. [...] The `g…