Activity
Yesterday
dmitshur commented on golang.org/x/build/main.star: use lucicfg as a tool dependency13h
Thanks, using `go tool` for this is very interesting.
I'm a bit hesitant to actually switch to this because it would mean we deviate more from the approach that's supported by the LUCI team. It woul…dmitshur commented on runtime: handle nil pointer in sysFreeOS on sbrk platforms14h
The legacy trybots aren't supported anymore, so stopping this empty run. We'll remove the gerrit vote soon to avoid confusion. Currently supported trybots are triggered via the Commit-Queue+1 vote as…dmitshur reviewed +2 on golang.org/x/arch/...: disable Git line-ending conversion15h
A few notes Gerrit-related notes: @emmanuel@orijtech.com, please note that when starting trybots via the 'Choose Tryjobs' dialog, since this CL is inside the golang.org/x/arch repository, the builder…This Week
dmitshur commented on golang.org/x/build/internal/task: remove open CL checks to prevent waiting for empty CLs1d
(1 comment)
(Any leftover generated CLs can also be found and cleaned up via a query like https://go-review.googlesource.com/q/owner:gobot@golang.org+is:open.)dmitshur closed a change golang.org/x/arch/...: upgrade go directive to at least 1.25.0 [generated]1d
Replaced by CL 744640.dmitshur closed a change golang.org/x/playground/...: upgrade go directive to at least 1.25.0 [generated]1d
dmitshur closed a change golang.org/x/text/...: upgrade go directive to at least 1.25.0 [generated]1d
dmitshur closed a change golang.org/x/mod/...: upgrade go directive to at least 1.25.0 [generated]1d
dmitshur closed a change golang.org/x/debug/...: upgrade go directive to at least 1.25.0 [generated]1d
dmitshur closed a change golang.org/x/term/...: upgrade go directive to at least 1.25.0 [generated]1d
dmitshur reviewed +2 on golang.org/x/build/internal/task: remove open CL checks to prevent waiting for empty CLs1d
Thanks.
Noting that clTitle needed to be defined as a variable in part because it needed to be used in multiple places, including for the "past open CL" check. Now that it's only being used in the o…dmitshur reviewed +2 on golang.org/x/build/cmd/gomote: remove the gomote coordinator functionality1d
Thanks.dmitshur commented on go/ast: standardize deprecated comment tags1d
CC @griesemer, @golang/tools-team, @dominikh.dmitshur closed an issue runtime: concurrent struct access in grpc-go transport crashes only on AMD1d
dmitshur commented on golang.org/x/tools/go/ssa: remove incorrect hasTypeParams check1d
(1 comment)
These two lines seem to be missing a verb in front. 'Fixes' for both?dmitshur reviewed +2 on golang.org/x/blog/...: remove 2 hidden files, leave just README1d
dmitshur reviewed +2 on golang.org/x/blog/...: remove 2 hidden files, leave just README1d
This change is ready for review.dmitshur opened a change golang.org/x/blog/...: remove 2 hidden files, leave just README1d
These were missed in CL 324270. These files aren't needed,
and can be safely removed. This way they won't become out
of date, and they won't invite maintenance.dmitshur reviewed +2 on golang.org/x/arch/...: disable Git line-ending conversion1d
(1 comment)
If I understand correctly, this is an intentionally shortened version of a similar explanatory comment used in other repos:
https://cs.opensource.google/search?q=file:.gitattributes&sq=…dmitshur fixed an issue access: join golang/riscv64 maintainer team1d
Thanks. Added @HeliC829 to https://github.com/orgs/golang/teams/riscv64/members.dmitshur commented on golang.org/x/sys/windows: reject overlong inputs in NewNTString2d
CC @golang/windows.dmitshur commented on cmd/compile: internal compiler error invalid heap allocated var without Heapaddr2d
CC @golang/compiler.dmitshur commented on cmd/compile: reduce allocations by reusing SSA scratch state2d
CC @golang/compiler.dmitshur commented on golang.org/x/arch/x86/x86avxgen: TestOutput failure2d
CC @cherrymui, @golang/windows.dmitshur commented on golang.org/x/pkgsite: improve openapi.yaml2d
CC @golang/pkgsite.dmitshur commented on golang.org/x/image/bmp: add 1, 2 and 4 bits-per-pixel palette encoding support2d
CC @nigeltao, @robpike.Last Week
dmitshur commented on net/http/internal/http2: remove "Host" header from Request.Header5d
@kidnamedcudilovedrake-dot You've been posting on many issues recently. The issue tracker is used for discussing the issue, code changes are better handled as part of CLs (which is where a [CLA](http…dmitshur commented on golang.org/x/crypto/ssh: RSA parameter moduli maximum should be increased5d
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/build/cmd/relnote: improve experience for documenting new standard library packages6d
Thanks, feel free to send a CL. See https://go.dev/doc/contribute.dmitshur opened an issue cmd/compile: cmd/compile/internal/gc fails to build (as part of running tests) under GOEXPERIMENT=newinliner6d
As of [CL 792120](https://go.dev/cl/792120), the gotip-linux-amd64-newinliner builder which tests with `GOEXPERIMENT=newinliner` fails to build cmd/compile/internal/gc:
```
FAIL cmd/compile [build f…dmitshur opened an issue github.com/actions/setup-go: Support release candidate alias ("nextstable"?) as a moving target6d
**Description:**
Currently setup-go supports "stable" and "oldstable" aliases. They are moving targets, so they make it convenient for repositories to target those versions, without needing to edit a…dmitshur commented on golang.org/x/exp/cmd/apidiff: non-deterministic output for "no longer implements"6d
CC @jba, @adonovan.dmitshur commented on github.com/go-openapi/testify/v2: didPanic relies on "panic called with nil argument" Error string equality, changes behavior in Go 1.276d
Thanks very much for resolving this!dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan6d
Thanks for confirming @noahbjohnson. That suggests govulncheck owners may consider temporarily working around by using an older x/tools while #80055 is investigated and resolved.dmitshur commented on golang.org/x/arch/loong64/loong64asm: TestObjdumpLoong64TestDecodeGoSyntaxdata failures6d
CC @golang/loong64.dmitshur commented on cmd/go: support quotes in `GOENV` file6d
CC @golang/command-line.dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan6d
If someone who's able to reproduce this wants to try building govulncheck from source, modifying it with `go get golang.org/x/tools@v0.44.0` (plus v0.45.0 is worth trying too), please see whether tha…dmitshur commented on golang.org/x/tools/go/ssa: RuntimeTypes panics on a parameterized type boxed in a generic method's closure6d
Thanks for reporting and bisecting this.
CC @golang/tools-team, @mrkfrmn, @griesemer.dmitshur commented on cmd/compile: inconsistent errors for init expr mismatches for vars and consts6d
CC @golang/compiler.dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan6d
Thanks for reporting.
CC @golang/vulndb.dmitshur opened an issue github.com/go-openapi/testify/v2: didPanic relies on "panic called with nil argument" Error string equality, changes behavior in Go 1.276d
**Describe the bug**
The `didPanic` function in `internal/assertions/panic.go` seems to try to detect instances of [`*runtime.PanicNilError`](https://pkg.go.dev/runtime#PanicNilError) error by checki…dmitshur commented on runtime: possible bug in moveSliceNoCap [1.26 backport]1w
@abtuteja Go minor releases are scheduled monthly, near the beginning of each month. So early July. See https://go.dev/wiki/MinorReleases.dmitshur commented on runtime: version parsing fails1w
Ping @bradfitz.dmitshur commented on golang.org/x/tools/go/analysis/passes: analyzer for removing canonical import comments1w
There's precedent for something along these lines in the "plusbuild" analyzer.
Do you suggest this analyzer should remove import comments only when the import math matches the actual import path of …dmitshur commented on golang.org/x/tools/go/analysis/passes: analyzer for removing canonical import comments1w
CC @adonovan, @matloob, @madelinekalil.dmitshur closed an issue build: build failure on go1.26-linux-amd64-misccompile1w
The LUCI infrastructure ran into a "i/o timeout" while invoking its own APIs. Nothing for Go to do here.dmitshur commented on golang.org/x/pkgsite: transient 500 errors on frontend during DB replica maintenance1w
CC @golang/pkgsite.dmitshur opened an issue cmd/compile: 2.29% regression in Dgeev/Circulant10-16 sec/op on linux/arm64 at 0252b4b1w
Discovered a regression in sec/op of 2.29% for benchmark Dgeev/Circulant10-16.
https://perf.golang.org/dashboard/?benchmark=Dgeev/Circulant10-16&platform=linux/arm64&repository=go&branch=master
http…dmitshur opened an issue cmd/compile: 5.10% regression in RepeatNew-88 sec/op on linux/amd64 at c59ae5c1w
Discovered a regression in sec/op of 5.10% for benchmark RepeatNew-88. Not quite clear which commit.
https://perf.golang.org/dashboard/?benchmark=RepeatNew-88&platform=linux/amd64&repository=go&bran…dmitshur commented on os/signal: TestCtrlBreak failures1w
From a triage meeting, @prattmic points out this test has a time.Sleep(1 * time.Second) so this might be a flake due to the subprocess not starting in that constant time.dmitshur commented on cmd/cgo/internal/test:external-g0: Test9400 failures1w
CC @golang/compiler.dmitshur commented on cmd/go: spurious leading blank line before `ok` when a passing test writes unterminated output1w
Thanks for the report. Would you like to send a CL? https://go.dev/doc/contributedmitshur commented on cmd/cgo/internal/test:external-g0: unrecognized failures1w
CC @golang/compiler.dmitshur commented on cmd/cgo/internal/test:auto-pie: Test9400 failures1w
CC @golang/compiler.dmitshur commented on runtime: concurrent map read and map write with sync.RWMutex on ppc64le [1.26 backport]1w
Thanks for making this backport request @Jorropo. It's approved now. Since you're the author of the fix CL, if you don't mind, please create backport CLs for this and #79878 following https://go.dev/…dmitshur fixed an issue all: switch to Go 1.27 as default inside Google1w
In a release meeting, we reviewed this blocker for the public Go 1.27 RC 1 and consider it complete. Closing.dmitshur commented on os/signal: TestCtrlBreak failures1w
CC @golang/runtime, @golang/windows.dmitshur commented on golang.org/x/build/internal/task: TestFindGoogleGroupsThread/[security]_golang.org/x/crypto_fix_pre-announcement failures1w
This test reaches out over the internet to a service (Google Groups), runs a search query and checks that the algorithm still works as expected. Every so often it seems the response doesn't include t…dmitshur reopened an issue cmd/fix: reflecttypefor replaced TypeOf(f) with TypeFor[func(...)](), losing relationship with symbol f1w
This is a cmd/fix issue in Go1.27 milestone, but so far it was closed by a CL in the x/tools repo. Reopening to make sure this change makes its way into cmd/fix in time for Go 1.27.0. This still need…dmitshur commented on golang.org/x/build: update gopls version requirements as part of the Go toolchain release workflow1w
I think the sections "Why not bump on each minor release?" at [go.dev/design/69095-x-repo-continuous-go#rationale](https://go.dev/design/69095-x-repo-continuous-go#rationale) is moderately relevant. …dmitshur commented on golang.org/x/build: automate maintenance of pinned Go toolchain/runtime versions in Dockerfile and app.yaml files1w
In addition to the 4 x/ repos already mentioned in the original issue, here are some more that also have Dockerfile and/or .yaml files that would benefit from automatic maintenance:
x/vulndb: https:…dmitshur commented on crypto/tls: only set LocalCertificate when a certificate is presented1w
@sin99xx Thanks for sending this change. As noted in https://github.com/golang/go/pull/79968#issuecomment-4684498141, it was successfully imported in Gerrit, and by now there are some review comments…dmitshur commented on golang.org/x/tools/go/packages: TestAdHocOverlays/GO111MODULE=auto failures1w
The failure above happened because package-level timeouts were reached. This was a darwin-arm64 race builder, which normally takes around 10 minutes to run on x/tools (https://ci.chromium.org/ui/p/go…dmitshur commented on crypto/mldsa: Verify accepts uninitialized PublicKey with empty signature1w
Thanks for trying out the package ahead of the release and reporting this finding. CC @golang/security.
Tentatively marking as a release blocker since this package is new to Go 1.27.dmitshur commented on crypto/tls: provide a way to access local certificate used to set up a connection [freeze exception]1w
Issue #79967 reported a problem with the new code. @rolandshoemaker Is it preferable to fix forward and proceed with it for 1.27, instead of reverting and trying again for 1.28? Given it seems like a…dmitshur commented on crypto/tls: LocalCertificate is populated on resumed TLS <=1.2 server connections1w
CC @rolandshoemaker, @golang/security.dmitshur commented on crypto/tls: TLS 1.3 post-handshake alerts not surfaced to the client1w
CC @golang/security.dmitshur commented on cmd/gofmt: comment alignment chunking behaviour different on MacOS vs Linux1w
Thanks for reporting.
It's expected that exact gofmt formatting nuances will change over time, across major Go releases, so a check like `go fmt ./...` needs to be arranged to run with a single cons…dmitshur commented on time: TestAfterQueuing/impl=func failures1w
The test contains a comment:
```Go
// This test flakes out on some systems,
// so we'll try it a few times before declaring it a failure.
const attempts = 5
```
So it seems this failure is expected…dmitshur commented on os: TestRootConsistencyStat/Lstat failures on XFS due to size of directories not being the same1w
Thanks for the report. Please note that Go 1.24 is no longer supported per https://go.dev/doc/devel/release#policy. Does this still happen with Go 1.26/1.25 or at tip?
CC @neild.Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time2y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change4ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes5y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).