Activity
Yesterday
dmitshur commented on golang.org/x/build/main.star: don't test the main branch on macOS 1210h
Thanks.dmitshur commented on doc/go1.27: document macOS requirements10h
Thanks.dmitshur commented on runtime: garbage collector panic10h
CC @golang/runtime.dmitshur closed an issue golang.org/x/pkgsite: issue titles10h
The template questions are filled in, but the content doesn't seem related to what the questions are asking.dmitshur closed an issue golang.org/x/pkgsite: issue titles10h
The template questions are filled in, but the content doesn't seem related to what the questions are asking.dmitshur commented on path/filepath: documentation for Dir (and Clean) is misleading regarding Linux and Windows behavior11h
CC @robpike, @rsc.dmitshur commented on golang.org/x/sys: no way to call ioctl BLKGETSIZE64?11h
CC @golang/runtime.dmitshur commented on crypto/tls: automatically rotated ticket keys are valid for longer than documented11h
CC @golang/security.dmitshur commented on go/printer: printing const decl containing comment not attached to a const spec messes up indentation when using SourcePos mode11h
CC @griesemer, @mvdan.dmitshur commented on cmd/go: (on s390x with gcc-15) ThreadSanitizer: CHECK failed: tsan_platform_linux.cpp:571 "((thr_beg)) >= ((tls_addr))" (0x3ffac69e140, 0x3ffac69e240)11h
CC @golang/s390x.dmitshur commented on README.vendor: document release cycle considerations11h
Thanks.dmitshur commented on README.vendor: document release cycle considerations11h
Whoops, the new reviewer & CC were intended for the next CL in the stack.
Skipping trybots a second time, PS 2 merely added a missed word.dmitshur opened a change golang.org/x/build/main.star: clean up after dropping release-branch.go1.2311h
Delete some code that's unused now that Go 1.23 is unsupported.
Generated files are unchanged.dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle12h
With [CL 738621](https://go.dev/cl/738621) (thanks @nicholashusin!) and [CL 739300](https://go.dev/cl/739300), the Go 1.27 start-of-freeze update round is done. Removing the early-in-cycle label to r…dmitshur opened a change README.vendor: document release cycle considerations13h
Write down a few more things relevant to the process of maintaining
the vendor directory for the std and cmd modules. This includes the
import path of the package containing a tree consistency check,…dmitshur commented on net/http: fix WaitGroup race in TestTransportNoReuseAfterEarlyResponse15h
(1 comment)
Yes, I addressed this in paragraph 3 of the commit message. Does that work, or do you prefer I take it out anyway?dmitshur reviewed +2 on cmd/compile: [release-branch.go1.25] during regalloc, fixedreg values are always available16h
Thanks.
I understand this part of the commit message isn't quite applicable to release-branch.go1.25, since CL 678620 was new to Go 1.26, but it's here anyway because the upstream commit had it.Last Week
dmitshur opened a change net/http: fix WaitGroup race in TestTransportNoReuseAfterEarlyResponse2d
The remaining race reported in go.dev/issue/66519 is that it's possible
for copying.Wait to start running before all copying.Add calls complete.
It happens infrequently as is, but padding both Wait a…dmitshur closed an issue golang.org/x/build: linux-mipsle/linux-mips64le builders are missing3d
Closing this in favor of the individual tracking issues that we have.
- #67306 (complete)
- #67304 (in progress as of 2026-01-23)dmitshur closed an issue golang.org/x/build: linux-mipsle/linux-mips64le builders are missing3d
Closing this in favor of the individual tracking issues that we have.
- #67306 (complete)
- #67304 (in progress)dmitshur commented on cmd/go: support for older versions of git broken again3d
Related to issue #26746 (about defining the minimum supported git version) mentioned above,
issue #26653 tracks adding a builder with that exact minimum git version.dmitshur reviewed +2 on golang.org/x/build/main.star: add runtimefreegc builder for the GOEXPERIMENT4d
Thanks.
Can you add a brief sentence with a criteria for when this should be deleted, similar to what we have for other builders intended to be tied to the rollout of an experiment? Having this cont…dmitshur commented on golang.org/x/build/gerrit: add Confirmed field to ReviewerInput4d
(1 comment)
Yes, that's right. Many golang.org/x repos provide packages meant for wide general use, but x/build is one of the exceptions to that. Also see the note in the README: https://cs.opensour…dmitshur commented on cmd/compile: fix mis-compilation for static array initialization5d
Sounds good. I'll add a wait-release and mark this thread as resolved so this can get submitted for 1.27 after the tree reopens, and we can re-title the 1.24 backport issue to be for 1.26 instead (or…dmitshur commented on github.com/dgraph-io/badger/v4/fix(aix): add aix directory synchronization support5d
> Is this still blocking the transition of the Go AIX CI instance?
Yeah, I re-checked https://github.com/golang/go/issues/67299#issuecomment-2285181258 and LUCI's cas dependency still fails to cro…dmitshur commented on cmd/compile: fix mis-compilation for static array initialization5d
@khr@golang.org Do you think this fix is safe enough, and we should proceed with at this point in the cycle? There's guidance at https://go.dev/s/release#june--december-week-2-release-candidate-1-iss…dmitshur commented on golang.org/x/build/devapp: move devapp command to x/build/cmd/devapp5d
pandora1mg@gmail.com There's no need to review changes that have already been submitted. If you'd like to contribute to Go, please see https://go.dev/doc/contribute. Thanks.dmitshur commented on golang.org/x/build/devapp: move devapp command to x/build/cmd/devapp6d
Thanks.dmitshur commented on golang.org/x/build/devapp: build Docker image via Cloud Build instead of local Docker6d
Thanks.dmitshur commented on golang.org/x/build/gerrit: add Confirmed field to ReviewerInput6d
(1 comment)
As noted here, new features are generally added to this package when something in x/build or another part of the Go project infrastructure needs it. Is this field needed for something?
…dmitshur commented on golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for release branches)6d
Thanks for offering. I suggest starting out with one of the issues already marked with a [`Suggested` or `help-wanted` label](https://github.com/golang/go/issues?q=is%3Aissue%20state%3Aopen%20(label%…dmitshur commented on github.com/ConradIrwin/font: Add support for TrueType Collection from font utility & tests1w
Yes, I would suggest removing `-u`. If someone wants that behavior and knows what they're doing, they can add it themselves, but otherwise a simple `go get import/path` is a good recommendation to …dmitshur commented on github.com/ConradIrwin/font: Add support for TrueType Collection from font utility & tests1w
Note that `-u` was needed to update the sfnt package itself in GOPATH mode, but in module mode `go get` alone will get the latest sfnt and its minimum required dependencies. See https://bsky.app/pr…dmitshur commented on golang.org/x/mobile/cmd/gomobile: -overlay build flag support1w
Ack. Marking this thread resolved, since there's nothing to do here. (CLs need all their conversation threads to get resolved in order to appear in the go.dev/s/needs-review for the Review-Enforceme…Earlier
dmitshur commented on golang.org/x/pkgsite: swap ?GOOS=darwin to arm64?1w
> A one-off non-scientific look at https://telemetry.go.dev/data/2025-03-15 has ~90% of darwin reports from darwin/arm64.
To expand on this, here are some counts of reports by GOOS/GOARCH pairs acro…dmitshur opened an issue golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for release branches)1w
By default, Go releases are built from the tip of their corresponding release branch, which gets modified only to update the content of the VERSION file during the release process. Doing this isn't v…dmitshur commented on proxy.golang.org: missing golang.org/dl/go1.25.6@latest1w
> For the official toolchain module used for GOTOOLCHAIN / go.mod toolchain upgrades, we explicitly wait for the proxy to ingest the module before announcing the release. Perhaps we could do the same…dmitshur opened an issue golang.org/x/build/cmd/relui: add a wait step for golang.org/dl command propagation to proxy.golang.org before "wait to announce" step of a release1w
Right now the release workflow has steps to publish golang.org/dl commands and wait for their submission. These are leaf steps that are done in parallel with the rest of the release process, so it is…dmitshur commented on golang.org/x/mobile: support for go/types.Aliases2w
CC @hajimehoshi as the [owner](https://dev.golang.org/owners) for x/mobile.dmitshur starred libgodc4w
dmitshur pushed to
main in dmitri.shuralyov.com/service/change8modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust5y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6y