Activity
Today
dmitshur reviewed +2 on syscall: add export linknames for socketcall on S390X31m
Thanks.dmitshur reviewed +2 on syscall: add export linknames for socketcall on S390X50m
Thanks.
It's true that these are accessed via assembly in x/sys/unix (and in x/net/internal/socket) for linux/386. However, on linux/390x, they don't seem to be accessed in x/sys/unix at all, only i…Yesterday
dmitshur opened an issue golang.org/x/build/internal/task: TagXReposTasks.findMissingBuilders should consider individual ports within -misccompile builders14h
The tagging workflow's findMissingBuilders method already has logic to block on failures within first-class ports. A -misccompile builder may fail due to any number of port(s) running into a problem,…dmitshur commented on golang.org/x/build/main.star: add known issue for x_net-gotip-linux-amd64-misccompile14h
Thanks.dmitshur opened a change golang.org/x/build/main.star: add known issue for x_net-gotip-linux-amd64-misccompile14h
For golang/go#79605.dmitshur opened an issue x/net/bpf, x/net/icmp, x/net/internal/socket, x/net/ipv{4,6}: package tests fail to build on linux/s390x at tip with "invalid reference to syscall.socketcall"15h
Based on https://ci.chromium.org/p/golang/g/x-net-gotip-by-go/console?limit=200, it seems that Go tip (1.27 to be) starting with [CL 761481](https://go.dev/cl/761481) runs into a build error in x/net…dmitshur reopened an issue runtime: `SIGSEGV` with a c-shared library and called from C#21h
Would it be worthwhile to try making the 32K → 16K change @ianlancetaylor suggested in https://github.com/golang/go/issues/78883#issuecomment-4310496625? It's hard to track this issue since it's cu…dmitshur reopened an issue runtime: `SIGSEGV` with a c-shared library and called from C#21h
Would it be worthwhile to try making the 32K → 16K change @ianlancetaylor suggested in https://github.com/golang/go/issues/78883#issuecomment-4310496625? It's hard to track this issue since it's cu…dmitshur commented on golang.org/x/build/internal/access: improve docs and tests21h
Thanks.dmitshur commented on golang.org/x/build/repos: add dot-github to mirror to golang/.github23h
Thanks. The Gerrit repo has been created, so submitting.dmitshur commented on golang.org/x/build/internal/access: add IAP context to HTTP requests1d
Thanks. Sent CL 781282 that adds tests and improved docs based on what you've done here.
Done in CL 666496.dmitshur opened a change golang.org/x/build/internal/access: improve docs and tests1d
Michael initially authored CL 461961 to allow HTTP handlers to access
the IAP user in January 2023, though that same functionality ended up
being submitted in August 2024 via CL 593915, with a follow…dmitshur commented on internal/strconv: work around escape analysis bug1d
(1 comment)
Is this meant to be [79547](https://go.dev/issue/79547)?This Week
dmitshur commented on cmd/link: enable FIPS 140-3 mode for Wasm1d
A few minor suggestions from reading over this.
It's good that this documents that these two parameters are optional. It'd be good to also say what they represent, too. Issue #79497 describes them, …dmitshur commented on archive/zip: fix reader-side Zip64 edge cases1d
Note that archive/zip tests on linux/386 (without -short flag) have started to fail as of this change. See https://ci.chromium.org/ui/test/golang/archive%2Fzip?q=V%3Abuilder%3Dgotip-linux-386-longtes…dmitshur closed a change golang.org/x/net/idna: upgrade to Unicode 15.1.01d
Thanks for working on this. The code has been updated for Unicode 17 and issue #65141 is closed, so closing this CL too.dmitshur closed a change golang.org/x/text/...: upgrade to Unicode 15.1.01d
Thanks for working on this. The code has been updated for Unicode 17 and issue #65141 is closed, so closing this CL too.dmitshur closed a change all: upgrade to Unicode 15.1.01d
Thanks for working on this. The code has been updated for Unicode 17 and issue #65141 is closed, so closing this CL too.dmitshur commented on net: use readable JSON marshaling for IPNet, IPMask, HardwareAddr1d
Unresolving this for visibility and removing Hold.dmitshur reviewed +2 on golang.org/x/tools/gopls/go.mod: update dependencies following the v0.22.0 release1d
Thanks.
Noting that the -u flag causes 'go get' to update not only the direct dependencies, but indirect dependencies of dependencies too. If you don't want that to be managing indirect dependencies…dmitshur reviewed +2 on golang.org/x/build/internal/task: re-generate license after update dependency1d
Thanks.
Not for this CL, of course, but noting that this can happen by now (issue #65917 is resolved).
```suggestion
// master branch to simulate license changes.
```dmitshur reviewed +2 on internal/testenv: make MustHaveSource detect missing source1d
Thanks.dmitshur commented on golang.org/x/build/internal/task: expand x-repo workflow to handle more than one change1d
(2 comments)
The parameter was there to make it possible to automatically add reviewers, by specifying them in the parameter.
There's a comment below:
> // We don't typically specify reviews in th…dmitshur reviewed +2 on golang.org/x/build/internal/task: add additional lint for CVE and GitHub issue references1d
dmitshur reviewed +2 on golang.org/x/build/internal/task: crystallize security-metadata derived security releasing1d
dmitshur reviewed +2 on golang.org/x/build/internal/task: use x-repo specific formatting for CLs1d
Thanks.
'For golang/go#79034.' maybe.
FWIW, Gerrit has URLs that redirect from a CL number to any project, if you leave out the '{proj}/+' part. E.g., https://go-review.googlesource.com/c/780821 (w…dmitshur fixed an issue cmd/link/internal/ld: TestAbstractOriginSanity failures1d
dmitshur fixed an issue cmd/link/internal/ld: TestAbstractOriginSanity failures1d
The original failure from Jan 8 was likely due to #77515,
and today's failures were handled by [CL 780760](https://go.dev/cl/780760)
(issue #79547 tracks the problem and removing the skip; CC @prattm…dmitshur commented on cmd/link/internal/ld: TestAbstractOriginSanity failures1d
The original failure from Jan 8 was likely due to #77515,
and today's failures were handled by [CL 780760](https://go.dev/cl/780760)
(issue #79547 tracks the problem and removing the skip; CC @prattm…dmitshur commented on os: notify testlog from (*File).Chdir1d
(1 comment)
Is the reason there isn't something like `testlog.Open(f.name) // observe likely non-existent directory` line here, similar to how it's there in os.Chdir, because that must've already ha…dmitshur commented on internal/strconv: use fast unrounded scaling for floating-point1d
Note that cmd/link/internal/ld.TestAbstractOriginSanity fails as of this change. See [here](https://ci.chromium.org/b/8681268550621413985) and #77120.dmitshur commented on cmd/go: clean should honor the -o flag as a build parameter so it can remove the final built artifacts1d
@matloob Is this intended to be a [proposal](https://go.dev/s/proposal)? It's in the Proposal milestone, but doesn't have a "proposal: " prefix in the title nor Proposal label. I fixed that assuming …dmitshur commented on cmd/dist: all.bash does not fail when run.bash fails1d
As a baseline, the `go test` command does return a non-zero exit code on Ctrl+C (SIGINT):
```shell
src $ go test all
ok archive/tar (cached)
ok archive/zip (cached)
ok bufio (cached)
^C
src $ …dmitshur opened an issue cmd/go: sending an interrupt signal (SIGINT) to a go tool invocation of a tool causes it to return with a zero exit code1d
Here's a small reproducer for `go tool` itself, found while looking into #79535:
```shell
$ cd $(mktemp -d)
$ go mod init test && go get go@1.26.0
$ mkdir -p cmd/importantwork && echo 'package main;…dmitshur commented on cmd/compile: Bug in rewrite rules for AMD64 causes SHL instruction overflow and miscompilation [1.25 backport]1d
The Critical label tracks upstream issues; it was applied there (https://github.com/golang/go/issues/79182#event-25767278742) so removing it here.dmitshur commented on cmd/compile: Bug in rewrite rules for AMD64 causes SHL instruction overflow and miscompilation [1.26 backport]1d
The Critical label tracks upstream issues; it was applied there (https://github.com/golang/go/issues/79182#event-25767278742) so removing it here.dmitshur reviewed +2 on golang.org/x/build/internal/task: expand x-repo workflow to handle more than one change2d
Thanks.
I left some inline comments. In general this looks like a good step to move #79034 forward. I understand there may be future enhancements, and it might be better to leave them out of scope h…dmitshur reviewed +2 on golang.org/x/build/internal/task: refactor closures in x-repo workflow2d
Thanks.
Nice catch that this error message was accidentally including the clNumber parameter definition rather than the value as was intended. (It could go unnoticed while this was a closure because…dmitshur reviewed +2 on golang.org/x/build/internal/task: add additional lint for CVE and GitHub issue references2d
dmitshur reviewed +2 on golang.org/x/build/internal/task: crystallize security-metadata derived security releasing2d
Thanks.
milestoneYAML was previously defined inside testSecurityReleaseCoalesceTask, the only place where it was being used.
It's still used only in that one place, inside testSecurityReleaseCoales…dmitshur reviewed +2 on doc: document new ppc64/linux features2d
Other than being rebased, nothing changed between PS 3 and PS 5, so re-adding bypass. This is a documentation-only change and the only possible failure here is bad link or Markdown or so, but [an ear…dmitshur reviewed +2 on lib/time: update to 2026b/2026b3d
Thanks.Last Week
dmitshur commented on net/http: deflake HTTP/3 tests6d
[CL 777921](https://go.dev/cl/777921) added a test skip for now, so removing release-blocker label (for Go 1.27) and moving to early-in-cycle Go 1.28.dmitshur commented on golang.org/x/text/unicode/bidi: DefaultDirection(LeftToRight) is silently ignored1w
@qsq8t65pxs It's important for backport requests to include a rationale - please see https://go.dev/wiki/MinorReleases. This issue is about a package in x/text; is there involvement of the standard l…dmitshur commented on golang.org/x/crypto: tag v1.0.01w
I agree that x/crypto behaves as if it’s already tagged v1.0.0, both when this was filed and now, it just hasn’t been tagged v1 yet, and it should. This issue hasn’t been progressing as is, and…dmitshur commented on cmd/api: run api check on all golang.org/x modules that have reached v1.0.0 or higher1w
Yes, that’s true. They should probably be tagged v1, their owners just haven’t done it yet. See issue #56325 (CC @FiloSottile) for example. We can still include them in scope of this issue.
I ti…dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
I intended to leave it pinned for some time after closing in case people whose CLs ran into this tried to look here. It’s probably fine to unpin by now. Thanks.dmitshur fixed an issue golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
It's still working; "Bots: 102" as if this posting. Closing this as resolved, and I'll follow up in other issues on what's left to do.dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
It seems to be helping so far, linux/amd64 builders are showing up:
<img width="478" height="393" alt="Image" src="https://github.com/user-attachments/assets/062662f0-cfab-4270-a045-c9f22b523b78" />…dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
A likely cause is found, trying a fix ([crrev.com/i/9297860](https://crrev.com/i/9297860)).dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
Those Debian 13 builder machines above are for the linux-amd64_debiansid builder and may be unrelated.dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
The linux/amd64 builder query at https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Alinux-amd64&f=machine_type%3An1-standard-16&f=os%3ADebian-11&f=pool%3Aluci.golang.try-workers finds 0 bot…dmitshur commented on all: the tree is highly flaky1w
@nicholashusin Thanks, that seems like a separate builder infrastructure problem. I filed #79410 for it.dmitshur opened an issue golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-141w
We're aware of an issue where many of the builders involved in the default trybot set are unavailable. For example, as visible at https://ci.chromium.org/ui/p/golang/builders/try-workers/gotip-linux-…dmitshur commented on all: the tree is highly flaky1w
TestTransportBodyReadError and other net/http flakes are likely related to the known flakes tracked in issue #78737 (CC @neild, @nicholashusin). There have been recent changes that helped, like https…dmitshur fixed an issue net/http:nethttpomithttp2: TestTransportClosesBodyOnError/h3 failures1w
dmitshur commented on net/http:nethttpomithttp2: TestTransportClosesBodyOnError/h3 failures1w
Closed by [CL 777740](https://go.dev/cl/777740) (commit c22f92a751ed649cd5face58a576d0b13e3d6db7).Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).