Activity
Today
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido12mdmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle49mdmitshur closed an issue all: Go 1.14 release status3h
dmitshur commented on all: Go 1.14 release status3h
I believe this release is done, so I'll close this.
@cagedmantis Let me know if there's anything left to do and if it should be re-opened.dmitshur merged a change doc/articles/race_detector: [release-branch.go1.14] mention memory leak potential3h
dmitshur reviewed +2 on doc/articles/race_detector: [release-branch.go1.14] mention memory leak potential5h
dmitshur reviewed +2 on doc/go1.14: [release-branch.go1.14] add link to module migration guide6h
dmitshur commented on golang.org/x/website/cmd/golangorg: use 8 letters to form index split suffix6h
This change is ready for review.dmitshur opened a change golang.org/x/website/cmd/golangorg: use 8 letters to form index split suffix6h
dmitshur commented on golang.org/x/text/unicode/norm: TestLinking consistently failing on multiple builders6h
No problem, and thank you Jeremy. I just wanted to update our list of Soon issues.dmitshur commented on golang.org/x/text/unicode/norm: TestLinking consistently failing on multiple builders7h
Friendly ping.
This issue currently has the label Soon, which is for regressions, serious bugs, and outages. This doesn't seem to qualify for that, so I'll remove the Soon label.dmitshur commented on golang.org/x/tools/internal/imports: test frequently times out on `dragonfly-amd64` builder7h
Dragonfly isn't one of the first-class ports according to the checkbox on https://build.golang.org. It seems no one is actively working on this. As a result, I don't think it's appropriate for this i…dmitshur commented on cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes7h
This is neither a regressions, serious bug, nor an outage, so removing Soon. It should be fixed, but that label is meant for things that are done in the order of days.dmitshur reviewed +2 on doc/articles/race_detector: mention memory leak potential7h
Based on git blame of race_detector.html, I consider Dmitry V. to be the owner of this article, and feedback here from him and Daniel suggests this is a good change. I don't see issues, so approving.…dmitshur reviewed +2 on golang.org/dl/dl: add go1.147h
dmitshur reviewed +2 on doc/go1.14: add link to module migration guide7h
dmitshur commented on golang.org/x/image: Go fonts not representative of OpenType state of the art8h
/cc @nigeltao @robpikedmitshur commented on time: Timer sequences newly panic with "racy use of timers"8h
This issue is blocking the Go 1.14 release, which is currently underway (but has not been cut yet, so we can still safely abort it or make changes if necessary). See https://github.com/golang/go/issu…dmitshur commented on time: Timer sequences newly panic with "racy use of timers"9h
> This program crashes very quickly
I can reproduce this with go1.14rc1, go1.14beta1, but also with go1.13.7 on darwin/amd64:
<details><br>
```
$ go run .
panic: runtime error: racy use of…dmitshur reviewed +2 on : [release-branch.go1.14] go1.149h
dmitshur reviewed +2 on golang.org/x/website/content/static/doc/devel: document Go 1.1410h
(1 comment)
s/MAKEFILE/Makefile/dmitshur merged a change doc: [release-branch.go1.14] add Go 1.14 to release history10h
dmitshur reviewed +2 on doc: add Go 1.14 to release history10h
dmitshur commented on crypto/cipher: NewGCMWithNonceSize allows zero-length nonce12h
/cc @dunhamsteve FYI.dmitshur commented on cmd/compile: use ellipses in RISCV64 rules13h
The slowbot run is stuck on waiting_for_machine state, and farmer.golang.org reports the only such builder is missing:
> host-linux-riscv64-unleashed: 0/0 (1 missing)
We need to get it back.Yesterday
dmitshur reviewed +2 on crypto/cipher: [release-branch.go1.13] require non-zero nonce size for AES-GCM23h
dmitshur created branch in github.com/shurcooL/home23h
devdmitshur commented on testing: when using a custom TestMain, m.Run does not return if one of the tests it runs panics1d
Thank you for explaining the current situation and trade-offs in https://github.com/golang/go/issues/37206#issuecomment-590441512, @ianlancetaylor.
My opinion is that we should hold off on complic…dmitshur commented on cmd/compile: Investigate regression in vs 1.131d
/cc @aclements @randall77dmitshur commented on crypto/cipher: [release-branch.go1.13] require non-zero nonce size for AES-GCM1d
It's in waiting_for_machine state, but there aren't any machines available. It shouldn't happen because it's a container-based builder. We'll investigate it after 1.14 release is done to avoid making…dmitshur opened an issue golang.org/x/build: disable darwin-amd64-10_11 builder on master branch1d
Go 1.15 will require macOS 10.12 and newer, so the macOS 10.11 builder should be disabled on the master branch now.
See https://github.com/golang/go/issues/37406#issuecomment-590549295 for additio…dmitshur merged a change doc/go1.14: [release-branch.go1.14] document that freebsd/arm64 requires FreeBSD 12.0 or later1d
dmitshur commented on cmd/compile: "internal compiler error: … unhandled expr" on darwin-amd64-10_11 builder1d
Ah, I missed the "for the main branch" bit. Yes, we should do that, since Go 1.15 won't support macOS 10.11.dmitshur reviewed +2 on doc/go1.14: [release-branch.go1.14] document that freebsd/arm64 requires FreeBSD 12.0 or later1d
LGTM. Thank you.dmitshur commented on crypto/cipher: [release-branch.go1.13] require non-zero nonce size for AES-GCM1d
I'm not sure what happened to the nacl-amd64p32 builder. We'll need to fix it, because Go 1.13 still requires it.dmitshur commented on doc/go1.14: [release-branch.go1.14] document that freebsd/arm64 requires FreeBSD 12.0 or later1d
(1 comment)
Please add a [release-branch.go1.14] prefix in front, as described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls.dmitshur commented on doc/articles/race_detector: mention memory leak potential1d
(3 comments)
Getting this onto golang.org website is easy, just need to backport this CL onto the active release branch (1.14 after tomorrow) and redeploy the website. Just need to get approval from…dmitshur commented on cmd/compile: "internal compiler error: … unhandled expr" on darwin-amd64-10_11 builder1d
@bcmills I'm not sure I understand the suggestion. Both Go 1.14 and 1.13 still support macOS 10.11, so it'll be another 12 months before we no longer support macOS 10.11 at all (when Go 1.15 becomes …dmitshur reviewed +2 on doc/go1.14: document that freebsd/arm64 requires FreeBSD 12.0 or later1d
(1 comment)
Yes, we should cherry-pick this to release-branch.go1.14 as well.
Add "document that" prefix so this begins with a verb, per https://golang.org/wiki/CommitMessage.dmitshur merged a change doc/go1.14: [release-branch.go1.14] remove draft notice1d
dmitshur merged a change crypto/cipher: [release-branch.go1.14] require non-zero nonce size for AES-GCM1d
dmitshur opened an issue doc: write Go 1.15 release notes1d
Tracking bug for writing the Go 1.15 Release Notes.
The latest state on tip can be viewed at https://tip.golang.org/doc/go1.15.
Previously #36878, #17929, #15810, #5929, etc.dmitshur opened a change crypto/cipher: [release-branch.go1.14] require non-zero nonce size for AES-GCM1d
dmitshur opened a change doc/go1.14: [release-branch.go1.14] remove draft notice1d
dmitshur merged a change doc/go1.14: remove draft notice1d
dmitshur commented on crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.12 backport]1d
Approving this backport. It's a small security hardening fix.dmitshur commented on crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.13 backport]1d
Approving this backport. It's a small security hardening fix.dmitshur commented on crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.14 backport]1d
Approving this backport. It's a small security hardening fix.dmitshur commented on crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.14 backport]1d
Ok, let's not take shortcuts. Opened #37418 for the 1.12 backport.dmitshur opened an issue crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.12 backport]1d
@networkimprov requested issue #37118 to be considered for backport to the next 1.12 minor release.
> @gopherbot please open backport, at suggestion of @FiloSottile.dmitshur reviewed +2 on golang.org/x/blog/content: add go1.14.article1d
I'm not seeing any issues. Feel free to wait for feedback/suggestions from others. We shouldn't submit this before tomorrow.dmitshur commented on golang.org/x/blog/content: add go1.14.article1d
(1 comment)
There was only one beta and one release candidate, so consider doing s/candidates/candidate/.
Can also consider adding the word "versions" afterwards.dmitshur commented on crypto/cipher: NewGCMWithNonceSize allows zero-length nonce1d
I'll repurpose the 1.12 one. It won't be getting this backport because 1.14 will be out by then, so it'll be too old.dmitshur opened a change doc/go1.14: remove draft notice1d
dmitshur merged a change golang.org/x/exp/shiny/driver/mtldriver: update to GLFW 3.3.21d
dmitshur merged a change test: clean up run.go1d
dmitshur commented on golang.org/x/exp/shiny/driver/mtldriver: update to GLFW 3.3.21d
(1 comment)
I don't like it either, but without it, it's hard to tell what "Delete this" refers to.
If this code were to stay permanently, I'd resolve the problem by adding blank lines for separati…dmitshur merged a change hash/maphash: [release-branch.go1.14] don't discard data on random seed init1d
This Week
dmitshur commented on github.com/shurcooL/githubv4: Parse 502 status code response as a GraphQL response.2d
Another use case is for detecting when a rate limit is hit. According to https://github.com/shurcooL/githubv4/issues/57#issue-569538004, GitHub returns HTTP 429 status code in those cases.dmitshur commented on github.com/shurcooL/githubv4/rate limiting: how to ?2d
> As far as I can tell, this package doesn't have any specific code path to handle the Github rate limiting.
That is true. However, note that you can always query the current rate limit by adding …dmitshur opened a change golang.org/x/exp/shiny/driver/mtldriver: update to GLFW 3.3.22d
dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: PostEmptyEvent crashes if called first on non-main thread on macOS2d
Note that the crash can be worked around by calling `glfw.PostEmptyEvent` on main thread first, before it has a chance to be called on non-main thread.
The following does not crash:
```Go
func…dmitshur opened an issue github.com/go-gl/glfw/v3.3/glfw: PostEmptyEvent crashes if called first on non-main thread on macOS2d
This is the `golang.org/go-gl/glfw/v3.3/glfw` tracking bug for upstream GLFW issue glfw/glfw#1649. It can be reproduced with the following Go program:
```Go
package main
import (
"log"
"ru…Last Week
dmitshur opened an issue github.com/glfw/glfw: Cocoa pre-window-creation event processing fix causes glfwPostEmptyEvent to crash program when called from non-main thread3d
Issue #1543 was resolved by commit 6e6805000ac7ddf39c8c5f6be3e877770cba5083.
Commit 6e6805000ac7ddf39c8c5f6be3e877770cba5083 adds the following code to `_glfwPlatformPostEmptyEvent`:
```diff
+…dmitshur commented on github.com/graphql/graphql.github.io: move machinebox/graphql from server to client section3d
Friendly ping @orta.dmitshur deleted branch in github.com/dmitshur/indieauth3d
terminology-consistencydmitshur commented on hash/maphash: don't discard data on random seed init3d
Closing because this PR has been merged via [CL 220617](https://golang.org/cl/220617) as commit 638df87fa4f927763f99ebf0c6bc9c4a5380d1f9.
`gerritbot` should've done this; we need to investigate wh…dmitshur closed a change hash/maphash: don't discard data on random seed init3d
dmitshur commented on golang.org/x/build/cmd/gerritbot: running into letsencrypt authorization rate limit3d
For now, I've just redeployed `gerritbot`. Let's see if this continues to happen.
**Edit:** It's still happening.
It may not be very important to fix, the only HTTP page gerritbot is serving se…dmitshur commented on golang.org/x/build/cmd/gerritbot: didn't close a PR that was submitted3d
This seems to be happening again with PR #37328. It has been [submitted on Gerrit](https://go-review.googlesource.com/c/go/+/220259/3#message-eacca2c63120bee7580861a608a0d804d5bfe42a) 30 minutes ago,…dmitshur opened an issue golang.org/x/build/cmd/gerritbot: running into letsencrypt authorization rate limit3d
From gerritbot logs:
```
2020/02/22 15:50:23 Updating data from log *maintner.netMutSource ...
2020/02/22 15:55:39 http: TLS handshake error from x.y.z.u:w: acme/autocert: missing certificate
2…dmitshur merged a change golang.org/x/build/devapp/owners: add khr as hash/maphash owner3d
dmitshur reviewed +2 on syscall: release a js.Func object in fsCall3d
dmitshur opened a change hash/maphash: [release-branch.go1.14] don't discard data on random seed init3d
dmitshur merged a change hash/maphash: don't discard data on random seed init3d
dmitshur commented on hash/maphash: don't discard data on random seed init3d
> It's good to go.
Great, submitting.
> Will it be in go1.14 release?
Yes. The bug it is fixing is in the Go 1.14 milestone. I'll cherry-pick this CL onto release-branch.go1.14 up next.dmitshur deleted branch in github.com/go-gl/glfw3d
fix-travisdmitshur pushed to
master in github.com/go-gl/glfw3ddmitshur created branch in github.com/go-gl/glfw3d
fix-travisdmitshur commented on github.com/go-gl/glfw/.travis.yml: use latest stable Go (1.13.8 and 1.12.17 at this time)3d
Hmm, Travis was passing in this PR, but now that it's merged to master, it's failing there.
For some reason, it's running `travis_install_go_dependencies`, which it's not supposed to be doing beca…dmitshur deleted branch in github.com/go-gl/glfw3d
update-travisdmitshur pushed to
master in github.com/go-gl/glfw3ddmitshur merged a change github.com/go-gl/glfw/.travis.yml: use latest stable Go (1.13.8 and 1.12.17 at this time)3d
dmitshur commented on github.com/go-gl/glfw/.travis.yml: use latest stable Go (1.13.8 and 1.12.17 at this time)3d
Yes, it is still testing that the package builds successfully.
We don't have any tests, hence "[no test files]". If we add some, they'll be run.dmitshur commented on github.com/shurcooL/githubv4: go get fails '...but does not contain package github.com/shurcooL/go/ctxhttp'3d
What's your `go env GOPROXY` value? Are you using a private proxy?
v0.0.0-20180223021221-8d3d310716de is an old version of module `github.com/shurcooL/graphql`. The latest version no longer import…dmitshur closed an issue golang.org/x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing3d
dmitshur commented on golang.org/x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing3d
sshing into the server timed out, but pinging it was fine.
I restarted it via Packet UI, that fixed it.
Similar to https://github.com/golang/go/issues/35708#issuecomment-555834390.
Another +…dmitshur opened an issue golang.org/x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing3d
From https://farmer.golang.org/#health:
<img src="https://user-images.githubusercontent.com/1924134/75085591-d3304500-54f8-11ea-8392-88a77b317a70.png" width="340px">
Previously:
- #35708
- …dmitshur commented on golang.org/x/mobile: build failing when using go modules4d
@axet Please do. You can refer to this issue if any of the information here is relevant. Thanks.dmitshur deleted branch in github.com/go-gl/glfw4d
update-to-3.3.2dmitshur commented on golang.org/x/build: add check to trybot to catch src/go.mod and src/vendor divergence4d
That said, the test in [CL 217218](https://golang.org/cl/217218) seems to check for this issue too, does it not?
**Edit:** It only checks for missing vendored packages, not that the vendored packa…dmitshur commented on golang.org/x/build: add check to trybot to catch src/go.mod and src/vendor divergence4d
Oh, I misread, this is about divergence between go.mod and vendor. That issue was about divergence between two different go.mods.dmitshur commented on golang.org/x/build: add check to trybot to catch src/go.mod and src/vendor divergence4d
@bcmills I think this issue is the same as issue #36907 (which was created slightly later), and can be considered resolved via [CL 217218](https://golang.org/cl/217218). Do you agree?dmitshur commented on all: refresh contributor and authors files before releases4d
I've sent [CL 220363](https://golang.org/cl/220363) with the second, and final, round of updates for Go 1.14.
Moving this issue to the Go 1.15 milestone.dmitshur commented on all: subrepos need to be green4d
This task has been completed for the Go 1.14 cycle at the time of cutting the go1.14rc1 release, see above comment for details.
Moving this issue to the Go 1.15 milestone.dmitshur commented on golang.org/x/blog: builds failing on release-branch.go1.12 due to missing dependencies5d
> How does the builder set up the workspace?
Answered in person, but for posterity, the code is in [`buildStatus.runSubrepoTests`](https://github.com/golang/build/blob/b077d0cce971fb98919ea3514515…dmitshur commented on golang.org/x/blog: builds failing on release-branch.go1.12 due to missing dependencies5d
Okay, the `golang.org/x/website/content/static` package imports `x/website/markdown`, and `x/blog` imports `golang.org/x/website/content/static`.dmitshur commented on golang.org/x/blog: builds failing on release-branch.go1.12 due to missing dependencies5d
golang.org/x repos are intentionally tested in GOPATH mode on release-branch.go1.12 branches, and in module mode (as long as a go.mod file is present) on release-branch.go1.13 branches and newer.
Bu…dmitshur commented on runtime: go1.14rc1 fatal error: invalid runtime symbol table: runtime: unexpected return pc for runtime.sigreturn called from 0x76d
Thanks for confirming @tonyghita!
I believe this issue is resolved then. It was waiting on feedback from you, the original reporter. I'll close it because there's nothing left to do. If there's an…