Activity
Today
dmitshur reviewed +2 on runtime: mark MemStats.Lookups as deprecated1h
+2 but feel free to also wait for Michael's review.
Fixing the API check needs a new line here:
```
pkg runtime, type MemStats struct, Lookups //deprecated #55915
```
Or in next/api/55915.txt if t…dmitshur commented on crypto/x509: add SetFallbackRoots and golang.org/x/crypto/x509roots/fallback package2h
@rolandshoemaker With `SetFallbackRoots` present and documented in Go 1.20, and `golang.org/x/crypto/x509roots/fallback` being recently added as part of #57792, is it time to move this issue to Go1.2…dmitshur commented on golang.org/x/crypto/x509roots: add new module5h
(1 comment)
FWIW, from https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source:
> The go generate tool also sets the build tag "generate" so that files may be examined by go generate b…dmitshur commented on golang.org/x/crypto/x509roots: add new module5h
(1 comment)
The accepted proposal said:
```
func Parse(r io.Reader) ([]*Certificate, error)
```dmitshur commented on golang.org/x/crypto/x509roots: add new module5h
(1 comment)
The accepted proposal said:
```
func Parse(r io.Reader) ([]*Certificate, error)
```Yesterday
dmitshur commented on github.com/shurcooL/githubv4: Can't decode array18h
Try making your query fields exported. `Categories` instead of `categories`, `PageData` not `pageData`, and `Title` not `title`.dmitshur commented on internal compiler error: out of range for go.shape.int64 [freeze exception]1d
@cuonglm Thanks for letting us know, but I don't see what aspect of this needs a freeze exception and why. This seems to be a recently reported bug.
Please see https://golang.org/s/release#freeze-…dmitshur opened a change golang.org/x/text/go.mod: delete repeated "indirect"1d
It got added by 'go mod tidy' in CL 471399
because the '; ' separator was missing.
For golang/go#48523.
For golang/go#58737.This Week
dmitshur commented on crypto/tls: expose SessionState extra information1d
@FiloSottile I'm unsure this needs one, and we're already tracking this since it has a release-blocker label in the Go1.21 milestone (but thanks for flagging anyway).
Fixing a new Go 1.21 API soun…dmitshur opened an issue golang.org/x/build: productionize test coverage for all Go repos2d
[`golangbuild`](https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/experimental/golangbuild/), our LUCI Executable (["luciexe"](https://go.chromium.org/luci/luciexe)) command intent…dmitshur commented on golang.org/x/tools/go/vcs: deprecate, isolate, tag, and delete package2d
Ok, expanding scope. I'll be happy to do this after proposal acceptance.dmitshur commented on lib/time: update tzdata before release2d
2023c is still the latest today. Adding okay-after-rc1.dmitshur closed an issue golang.org/x/build/internal/task: TestPreAnnounceRelease failures2d
dmitshur commented on golang.org/x/build/internal/task: TestPreAnnounceRelease failures2d
This should also be fixed by [CL 499680](https://go.dev/cl/499680).dmitshur closed an issue golang.org/x/build/internal/task: TestFindGoogleGroupsThread failures2d
This should also be fixed by [CL 499680](https://go.dev/cl/499680).dmitshur commented on golang.org/x/build/internal/task: TestFindGoogleGroupsThread failures2d
This should also be fixed by [CL 499680](https://go.dev/cl/499680).dmitshur closed an issue golang.org/x/build: trybots should always compile for all platforms on subrepos2d
@mknyszek implemented this; closing as a duplicate of #58163.dmitshur commented on golang.org/x/build: trybots should always compile for all platforms on subrepos2d
@mknyszek implemented this; closing as a duplicate of #58163.dmitshur reviewed +2 on cmd/cgo: [release-branch.go1.19] correct _cgo_flags output3d
Thanks.
This is #60118.dmitshur reviewed +2 on cmd/cgo: [release-branch.go1.20] correct _cgo_flags output3d
Thanks.dmitshur commented on cmd/dist: revisit decision for all.bash to skip testing packages without tests3d
We discussed this earlier and there was agreement the high-confidence vet coverage will almost certainly warrant doing this now, just need to sort out some of the small implementation details here.dmitshur commented on cmd/go: improper sanitization of LDFLAGS [CVE-2023-29405] [1.20 backport]3d
(This was approved earlier, the label needed to be updated.)dmitshur closed an issue net/http2: don't reuse connections that are experiencing errors [1.20 backport]3d
dmitshur commented on crypto/x509: TestPlatformVerifier fails on windows-amd64-longtest-oldcc builder on 1.19 release branch 3d
CC @dr2chase, @mknyszek.dmitshur opened a change golang.org/x/build/internal/task: parse HTML in parallel with network fetch3d
CL 499680 made findGoogleGroupsThread wait for the fetch to complete
before starting to parse HTML. This was only so that it'd be easy to
detect if reading resp.Body fails (as opposed to parsing its …dmitshur commented on golang.org/x/mod/modfile: improve directory path detection and error text consistency3d
(1 comment)
Good idea to write that down, thanks.
What you describe matches my understanding. There's no change in meaning of go.mod/go.work files, only new directory paths eventually allowed and n…dmitshur commented on golang.org/x/mod/modfile: IsDirectoryPath produces a false negative on some short clean directory paths4d
Writing down the compatibility notes for this bug fix.
There are known callers of IsDirectoryPath in x/mod itself and in cmd/go in the main repo, which is what I considered in scope below. For oth…dmitshur opened a change golang.org/x/tools/gopls: remove trailing slash from replace directory path4d
DO NOT SUBMIT: The ".." path (without a trailing slash) can't be used
today due to golang/go#60572. It can only be used after that bug is
fixed in all supported versions of Go. For example, if it's f…dmitshur commented on golang.org/x/build/cmd/gopherbot: add handleTelemetryIssues4d
(1 comment)
It occur whenever at least one label is removed from the issue. Typically the "telemetry" label itself (since that's the one gopherbot will add the quickest), but any other would also ge…dmitshur commented on golang.org/x/build/cmd/gopherbot: add handleTelemetryIssues4d
(1 comment)
Is it intentional to leave out the `|| gi.HasEvent("unlabeled")` condition for overriding this task, that other similar tasks have? (Okay if that's your intent, just confirming.)dmitshur opened an issue golang.org/x/build: add darwin builders with macOS 14 (macOS Sonoma)4d
macOS 14 (macOS Sonoma) was announced today during WWDC23 and is described to be "Coming this fall". (https://www.apple.com/macos/sonoma-preview/)
This is the tracking issue (that can be split int…dmitshur closed an issue runtime: add debugger hook for fatal signals [freeze exception]4d
[CL 495736](https://go.dev/cl/495736) is submitted, closing. Please comment if something more is needed for this freeze exception.dmitshur commented on golang.org/x/website/_content: add https://go.dev/doc/toolchain4d
(2 comments)
This link needs a '/pkg' prefix (`/pkg/os/#Getenv`) to avoid being 404.
If you'd like, this link can point directly to the release policy section on that page by adding a `#policy` fra…dmitshur reviewed +2 on golang.org/x/build/internal/datastore/fake: return ErrInvalidKey on nil key4d
Thanks.dmitshur reviewed +2 on golang.org/x/mod/sumdb: correct spelling mistakes4d
Thanks.dmitshur commented on golang.org/x/build/cmd/relui: pkgbuild produces an installer that installs to /usr/local/go/bin/go, no longer in PATH on os X mojave4d
I spotted this issue only recently, and wanted to follow up here. Also CC @golang/release. (I realize it's from 2018 so it might not be relevant to you or not something you can easily verify now.)
…dmitshur created branch in github.com/rsc/tmp4d
dmitshur/wipdmitshur pushed to
master in github.com/rsc/tmp4d
dmitshur closed a change golang.org/x/sys/unix: remove absolute path of pwd from mkall.sh5d
Closing because this PR has been merged via [CL 500656](https://go.dev/cl/500656) as commit ff98eae2a0cc3ace67e30e3e41908d279a7c13cb.
(Normally `gerritbot` does this, but sometimes it needs help d…dmitshur commented on golang.org/x/build/internal/datastore/fake: fix nil ptr dereference5d
(2 comments)
This subject accurately describes patch set 1, but now needs updating.
A real datastore.Get returns datastore.ErrInvalidKey when given a nil key, so this fake should too.
Also, it see…dmitshur reviewed +2 on golang.org/x/mod/sumdb: correct spelling mistakes5d
(1 comment)
```suggestion
// If f returns nil, the transaction attempts to commit and then return nil.
```
I think return (not returns) was right.
That is, the transaction does an atomic attempt …Last Week
dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: missing return after http.Error6d
Thanks.dmitshur commented on cmd/compile: allow ir.OMIN/ir.OMAX in mayCall6d
Thanks.
Is this the right CL number?dmitshur opened an issue cmd/compile: min/max builtins trigger mayCall ICE1w
Tested with the most recent Go tip version:
```
$ go version
go version devel go1.21-6260049fa2 Fri Jun 2 19:54:05 2023 +0000 darwin/arm64
$ cd $(mktemp -d) && go mod init example && cat <<EOF …dmitshur opened a change doc/go1.21: document macOS and Windows requirements1w
Fixes #57125.
Fixes #57003.
Fixes #57004.dmitshur commented on cmd: update vendored golang.org/x/mod1w
TRY=longtest, windows-amd64-longtestdmitshur opened a change golang.org/x/mod/modfile: improve directory path detection and error text consistency1w
An error text suggests a directory path needs to start with ./ or ../
if it's a relative path, but in reality relative paths with .\ and ..\
prefix (such as those that are used on Windows) are also a…dmitshur opened an issue golang.org/x/mod/modfile: IsDirectoryPath produces a false negative on some short clean directory paths1w
In https://github.com/golang/go/issues/51448#issuecomment-1057713459, Bryan wrote:
> The argument `.` should trigger `modfile.IsDirectoryPath` here:
https://cs.opensource.google/go/go/+/ce427cf96…dmitshur opened a change cmd/api: make check even pickier about api/next/*.txt1w
As spotted in CL 499981, 3 out of 51 of the api/next/*.txt files
ended up with a blank line at the end. It's possible it would've
been more if human reviewers didn't catch them.
Since there's no for…dmitshur reviewed +2 on api: promote next to go1.211w
Thanks.
Interesting that tooling can make different decisions when comparing '(' and 'B' for sort purposes.dmitshur commented on golang.org/x/build/main.star: drop experiments for structured tests1w
Thanks.dmitshur commented on golang.org/x/tools/go/pointer: remove replace directive1w
(1 comment)
(nit) FWIW it will continue to fail with "package golang.org/x/tools/go/pointer is not a main package". 😅 Of course removing replace directives before tagging+deleting is definitely w…dmitshur commented on golang.org/x/tools/go/pointer: remove replace directive1w
(1 comment)
While here, please delete this magic comment too. It's intended for automated tagging, and there's no automated tagging for modules holding deleted packages.dmitshur opened a change golang.org/x/build/main.star: drop experiments for structured tests1w
The experiment has graduated to default behavior in crrev.com/c/4558786
and can be removed here. (This undoes the change applied in CL 497695.)
For golang/go#59990.dmitshur opened a change golang.org/x/build/internal/task: deflake release announcement tests1w
Looking for a Google Groups thread means fetching from a remote server
over an internet connection, so impermanent failures are guaranteed to
happen some of the time. relui is already well-equipped t…dmitshur commented on golang.org/x/mobile/cmd/gomobile: upgrade minimal javac version to 1.81w
(2 comments)
Done.
Done. (#59803 seems like the right one.)dmitshur reviewed +2 on golang.org/x/mobile/cmd/gomobile: upgrade minimal javac version to 1.81w
Thanks.dmitshur reviewed +2 on golang.org/x/mobile/cmd/gomobile: upgrade minimal javac version to 1.81w
Thanks.dmitshur edited the wiki1w
dmitshur opened a change golang.org/x/build/internal/gophers: remove GitHubOfGomoteUser1w
The new gomote SSH implementation doesn't rely on knowing the user's
GitHub account and its public SSH keys, there's no more need for the
GitHubOfGomoteUser function and its maintenance.
For golang/…dmitshur reviewed +2 on doc/go1.21: fix HTML tag1w
Thanks.dmitshur closed an issue golang.org/x/build: use structured (json) test output in CI1w
This has been flipped on and running in LUCI since last week. Some examples:
- https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-amd64/b8779655559291129265/overview - a successful build …dmitshur opened a change cmd/go/internal: [release-branch.go1.19] update documentation of go test and go generate1w
For #57050.
Fixes #60457.dmitshur opened a change cmd/go/internal: [release-branch.go1.20] update documentation of go test and go generate1w
For #57050.
Fixes #60458.Earlier
dmitshur commented on golang.org/x/mod/zip: fix LICENSE file handling to match modfetch1w
(1 comment)
Stderr is set to &stderr, but stderr is never used.dmitshur starred github.com/OldUnreal/XOpenGLDrv1w
dmitshur commented on cmd/compile: var _ = f prevents f from being dead-code eliminated2w
@thediveo I think what you're pointing to is an example of a function call whose return value is being assigned to the blank identifier. That shouldn't and wouldn't change behavior. The original issu…dmitshur opened an issue cmd/dist: revisit decision for all.bash to skip testing packages without tests2w
[CL 10492](https://go.dev/cl/10492) in 2015 applied a change to have all.bash skip testing Go packages in the standard library (those matched by `go list std cmd`) that have no tests. Sadly, the comm…dmitshur closed an issue cmd/go: document GOROOT/bin/go PATH entry for `go test` and `go generate` [1.21 backport]2w
Already fixed in Go 1.21, not needed.dmitshur commented on cmd/go: document GOROOT/bin/go PATH entry for `go test` and `go generate`2w
@gopherbot Please consider this as a backport to Go 1.20 and 1.19.
This is a documentation-only fix to document a Go 1.19 feature added to `go test` and `go generate`. It'll be easier for users wh…dmitshur opened an issue golang.org/x/build/internal/workflow: TaskContext.ResetWatchdog is willing to reset expired timer2w
`watchdogTimer` is currently initialized to a timer that cancels the TaskContext's context when it times out:
```Go
func runTask(ctx context.Context, workflowID uuid.UUID, listener Listener, stat…dmitshur opened an issue golang.org/x/build/cmd/relui: advisory TryBots can handle or avoid timeouts better2w
Advisory TryBots are causing much less friction compared to previously now that #57725 has been resolved. Filing this for some followup improvements that we can apply to how they handle timeouts.
…dmitshur commented on build: wasip1 wasmtime builder is broken2w
https://build.golang.org/log/a1da7514866e849d7af09fd7ff1af7fc8d11030f looks like the first build using a builder image rebuilt with wasmtime v9.0.1 ([CL 496920](https://go.dev/cl/496920)).
It made…dmitshur reopened an issue cmd/link/internal/ld: Passing incorrect offset to `codesign.Sign`2w
Reopening to track submission of [CL 484015](https://go.dev/cl/484015) which will resolve this.dmitshur commented on cmd/link/internal/ld: Passing incorrect offset to `codesign.Sign`2w
Reopening to track submission of [CL 484015](https://go.dev/cl/484015) which will resolve this.dmitshur closed an issue cmd/go: forward compatibility work [freeze exception]2w
Thanks for filing this. It's unfortunate that #57001 only gained the release-blocker label late in the cycle and we couldn't do more to help with the timeline for a significant feature planned for Go…dmitshur closed an issue crypto/tls: advertise correct ciphers [freeze exception]2w
dmitshur closed an issue crypto/internal/bigmod: fix panic [freeze exception]2w
dmitshur closed an issue cmd/go: GOEXPERIMENT=gocacheprog [freeze exception]2w
The proposal was approved just today and this just missed the freeze by half an hour but is otherwise ready, so I can trivially approve this. Please feel free to go ahead with the CL, and thanks for …dmitshur commented on cmd/go: forward compatibility work [freeze exception]2w
CC @golang/release.dmitshur closed an issue cmd/go: GOCACHEPROG approval [freeze exception]2w
dmitshur commented on cmd/go: GOEXPERIMENT=gocacheprog [freeze exception]2w
That CL has some comments that need to be resolved. It also says "Updates #59719"—is there more that needs to happen for that proposal or is that CL fine to submit now and leave further changes for…dmitshur commented on cmd/go: GOEXPERIMENT=gocacheprog [freeze exception]2w
Also copying @bradfitz's rationale from #60420:
> I forgot to submit https://go-review.googlesource.com/c/go/+/486715 this morning after getting @bcmills's approval. I was going to spend the eveni…dmitshur closed an issue cmd/go: GOCACHEPROG approval [freeze exception]2w
I'll dedup this into #60419 and copy the rationale there. Thanks.dmitshur reopened an issue crypto/tls: QUIC 0-RTT APIs2w
This got closed but the proposal is still in progress. Reopening so it can get to a resolution (and if it doesn't make it to accepted state, to revert the CL).dmitshur commented on crypto/tls: QUIC 0-RTT APIs2w
This got closed but the proposal is still in progress. Reopening so it can get to a resolution (and if it doesn't make it to accepted state, to revert the CL).dmitshur closed a change database/sql: predictable request queue satisfaction2w
This PR is currently targeting the "release-branch.go1.17" branch. Go 1.17 is no longer supported per the [release policy](https://go.dev/doc/devel/release#policy) and so we don't use the `release-br…dmitshur commented on database/sql: predictable request queue satisfaction2w
This PR is currently targeting the "release-branch.go1.17" branch. Go 1.17 is no longer supported per the [release policy](https://go.dev/doc/devel/release#policy) and so we don't use the `release-br…dmitshur commented on golang.org/x/website: add Gerrit basic tutorial in contributing guideines2w
It's worth taking into account that Gerrit itself has fairly thorough documentation (e.g., see https://gerrit-review.googlesource.com/Documentation/index.html).
For example, https://gerrit-review.…dmitshur closed an issue build: use a zero for third digit for major release, such as 'go1.21.0'2w
Everything captured in https://github.com/golang/go/issues/57631#issuecomment-1480227646 looks good to me.
I found a few more things, but they're very minor.
In [`maintapi.parseInternalBranchVers…dmitshur opened an issue golang.org/x/pkgsite/internal/stdlib: update for "go1.21.0" onwards keeping ".0" trailing component2w
This package has a few places that might need updates for proposal #57631.dmitshur edited the wiki3w
dmitshur closed an issue cmd/cgo/internal/testcarchive: TestDeepStack failures3w
This should be fixed by [CL 496376](https://go.dev/cl/496376).dmitshur commented on crypto/rsa: 4096 bit keys are not generated with BoringCrypto [1.20 backport]3w
> not sure why gopherbot didn't close the issue.
The one time it _doesn't_ fight humans is the time it would've been helpful. [😅](https://cs.opensource.google/go/x/build/+/refs/heads/master:cmd…dmitshur commented on cmd/go: add repo info to go list -m -json3w
Is this resolved by the "Origin" JSON key added to the output of `go list -json -m` (and `go mod download -json`) in Go 1.19? (See #53644, [CL 411397](https://go.dev/cl/411397), https://pkg.go.dev/cm…dmitshur closed an issue golang.org/x/build/cmd/makemac: automatically power cycle dead MacStadium VMware hosts3w
This issue is obsolete as of #57562. Closing.dmitshur closed an issue golang.org/x/build/cmd/updatecontrib: update to work with module-aware mode3w
updatecontrib is no longer used after the change in #53961, and [CL 419075](https://go.dev/cl/419075) deleted it.
Closing this as obsolete.dmitshur starred github.com/network-quality/goresponsiveness3w
dmitshur starred github.com/network-quality/goserver3w
dmitshur closed an issue unicode: update to version 14.03w
Support for Unicode 15.0.0 (#55079) is now implemented, so there's nothing more to do in this issue. Please comment if I missed something.