Today
dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom13h
I see, thanks for clarifying. Then let's keep this as is. If we discover evidence that there are reproducible cases where it's nil and needs to be handled, we can address it then.
Yesterday
dmitshur pushed to patch-1 in github.com/dmitshur/go-graphql-client14h
5178bc9f0b583576b710cd142337af25f6cafcectransport: use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to patch-1 in github.com/dmitshur/jsgo14h
eb95c603effdd7b38331a61c8ef3c6352310e19bserver/play: Use golang.org/x/net/context/ctxhttp package
dmitshur starred github.com/dave/jsgo15h
dmitshur pushed to master in github.com/shurcooL/webdavfs15h
44bbca92c578c2cdeb441afd67c2bd3fa3341cb9webdavfs: Replace "golang.org/x/net/context" with "context".
dmitshur pushed to master in github.com/shurcooL/go15h
58262d155ee0c659f3e3963bfccbac0f6a6a1d2bctxhttp: Deprecate package in favor of upstream version.
dmitshur pushed to master in github.com/shurcooL/home15h
3ad91d15a504fea9a6eb4e8c76b0890a5018cd03http: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in dmitri.shuralyov.com/app/changes15h
5af16e21babb2483897184bb2e4c97d642af158dassets: Apply gofmt using Go 1.11.
dmitshur pushed to master in github.com/shurcooL/notificationsapp15h
0a6e54cc4198490965719c64619758a801bc4aa5assets: Apply gofmt using Go 1.11.
033c8bfe5a0ab228761a117a76d93a2c85a438d4httpclient: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in github.com/shurcooL/issuesapp16h
d91d66789394f827615d32b4326948f0ee27b8d0assets: Apply gofmt using Go 1.11.
dmitshur pushed to master in github.com/shurcooL/issuesapp16h
d97dc23dc6f58887979f66924d690f026dc60959httpclient: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in dmitri.shuralyov.com/service/change17h
7424d8ddca1d310f20d49327fd09b60e29f9d1fdhttpclient: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in github.com/shurcooL/graphql17h
16b88644589aaa174a21ae55cac72a9f60d5d837Switch back to golang.org/x/net/context/ctxhttp package.
dmitshur commented on Can shurcooL/go/ctxhttp dependency … in github.com/shurcooL/graphql17h
Issue https://github.com/golang/go/issues/21358 has been resolved today, so I can finally resolve this issue! 🎉 /cc @gmlewis
dmitshur commented on x/build/cmd/gopherbot: follow-up ba… in github.com/golang/go1d
Also happened in https://github.com/golang/go/issues/28688#issuecomment-438326787.
dmitshur commented on cmd/compile: inline multiplication … in github.com/golang/go1d
@josharian You're hitting the known issue #25574. Gopherbot already responded to a backport command earlier in this issue, so until #25574 is resolved, it never listens to follow up backport requests.
dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go1d
FWIW, explicitly setting the maximum acceptable TLS version to 1.2 in that test makes it pass: ``` diff --git a/http2/server_test.go b/http2/server_test.go index e5be1a6..3cd398f 100644 --- a/h…
dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go1d
Bisected this test failure to [CL 147638](https://golang.org/cl/147638) (crypto/tls: enable TLS 1.3 and update tests), which makes a lot of sense. /cc @FiloSottile
dmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go1d
Woohoo! CL incoming.
dmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go1d
@bradfitz, we've been removing support for Go 1.6 and replacing `golang.org/x/net/context` with `context` in many packages recently (e.g., https://github.com/golang/net/commit/04ba8c85dd55b4ee6099abb…
This Week
dmitshur commented on x/build/maintner: GitHubIssue.Close… in github.com/golang/go1d
> We have the issue events synced anyway, so the data's in the corpus. We just need to track the oldest close event per issue. That's a great idea, then no need for extra queries. The close event ha…
dmitshur commented on 71e986f52b169375e8c4310ed2c24b30996514daRefactored to use Graph… in github.com/davidoram/ght2d
You can omit the empty brackets if you want, e.g., just `graphql:"tag: node"`.
dmitshur commented on 71e986f52b169375e8c4310ed2c24b30996514daRefactored to use Graph… in github.com/davidoram/ght2d
In case it's helpful, you can probably simplify this further. Instead of using `edges` and then accessing the `node` inside, you could access the list of nodes directly via `nodes`. See the second fi…
dmitshur commented on access: request for increased Githu… in github.com/gopherjs/gopherjs2d
We've added you. Thank you Paul!
dmitshur commented on IsoGoApp: Does not find and load th… in github.com/gopherjs/gopherjs2d
/cc @EngineerKamesh
dmitshur commented on gopher build error in github.com/gopherjs/gopherjs2d
If you look at the [import graph](https://godoc.org/github.com/EngineerKamesh/igb/igweb/client?import-graph&hide=2) of that package, you'll see that it imports `go.isomorphicgo.org/go/isok`, which im…
dmitshur deleted branch in github.com/shurcooL/notifications2d
optimize-githubapi
dmitshur pushed to master in github.com/shurcooL/notifications2d
bcc2b3082a7acf2b5e8082374401a9d5e62944d2githubapi: Cache notifications in List.
926403120bbcbee30699b0ea339c947775dac05fgithubapi: Batch GraphQL queries in List.
dmitshur commented on Remove Cgo dependency on Windows in github.com/go-gl/glow2d
Add a `// TODO: Use syscall.Syscall18 when Go 1.12 is the minimum supported version.` perhaps?
dmitshur commented on remove dependency on cgo in github.com/go-gl/gl2d
I think we did reach agreement. We talked on slack and I left some comments on the proposal document. As long as you're willing to help maintain the Windows cgo-free version, we're happy to accept it.
dmitshur commented on How to encode GraphQL Aliases in github.com/shurcooL/githubv42d
@davidoram Thanks for asking. Aliases are supported, but I haven't documented them yet (see #22). I hope to fix that soon. The answer is as follows. A GraphQL query like this: ```GraphQL query…
dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom3d
Question, do you know if `e.Get("content")` always returns a non-nil value?
dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom3d
Please use a keyed field in this composite literal, for consistency with other elements. ```suggestion return &HTMLTemplateElement{BasicHTMLElement: el} ```
dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache3d
> But as long as we're working on this one, I'd rather keep hunting until we find an approach that we both like. I'm ok with the nested-diff approach (whether it uses `-u` or `-n`), but I don't _like…
dmitshur commented on Query batching and/or dynamic queri… in github.com/shurcooL/githubv43d
I've made significant progress on this issue this weekend. It turns out it has been _possible_ to perform query batching and/or dynamic queries all along, without any API changes to this package. Rea…
dmitshur created branch in github.com/shurcooL/notifications3d
optimize-githubapi
dmitshur pushed to master in github.com/shurcooL/home3d
090ea429e37509065eb1b4d6ff2bd1fa47be7fdeREADME: Update ./internal/code synopsis.
dmitshur pushed to master in github.com/shurcooL/githubv43d
5851091a7645512808078d4c786e86407b98c9abRegenerate for schema changes by 2018-11-11.
650a3fdd7fe54de16b61dd3bc5904470e9622e7aREADME: Update broken GraphQL documentation URLs.
dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache3d
> Who cares what's on disk when the failed container gets torn down? I don't mind what's on disk after the container is being shutdown. It's just that `gofmt -w` writes to disk first, and then the…
Last Week
dmitshur commented on x/build/cmd/coordinator: some CLs e… in github.com/golang/go3d
Thanks for diagnosing the issue.
dmitshur commented on x/build/cmd/coordinator: some CLs e… in github.com/golang/go4d
The "Builds Remaining" number calculation is clearly wrong. I've noticed it's sometimes wrong even elsewhere, for trybots that succeed properly. E.g., from [this](https://go-review.googlesource.com/c…
dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go4d
Deployed coordinator. Trybots will now use OpenBSD 6.4 rather than 6.2. E.g.: <img width=420px src=https://user-images.githubusercontent.com/1924134/48304759-fe05ae00-e4ec-11e8-8f67-e44da78a5254.p…
dmitshur commented on Usability thought: links can't be r… in github.com/marwan-at-work/marwanio4d
I can confirm the fix works for me. Thanks!
dmitshur commented on x/build/cmd/gerritbot: bot insists … in github.com/golang/go4d
I think this is the same issue as #24887. It's also related to https://github.com/golang/go/issues/25359#issuecomment-417217969, where I suggested: > I'll want to revisit the original design do…
dmitshur commented on x/build: make trybots post their st… in github.com/golang/go4d
> If trybots cancel themselves due to a new patchset version or the current patchset being merged Do trybots still do that? I heard from @heschik that he saw trybots continue to run and send messa…
dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go5d
Reopening for deploy (likely later tonight, when it's quieter, to avoid disruption to running builds).
dmitshur commented on README: update Travis badge to go4o… in github.com/go4org/go45d
Thanks for merging! I would suggest considering the squash merge strategy for small PRs like this, to keep the git history cleaner. It also allows you to improve the commit message before merging,…
dmitshur deleted branch in github.com/dmitshur/go45d
patch-1
dmitshur pushed to patch-1 in github.com/dmitshur/go45d
6fe5adae7d3dc4de57b02c6ba5595ee4accb1d86README: update Travis badge to go4org
dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go5d
The v2 image appears to be equally stable: <img width=100px src=https://user-images.githubusercontent.com/1924134/48279994-460acf00-e420-11e8-93ef-a488b6f1302a.png> The performance has improved…
dmitshur commented on Add several error types in github.com/shurcooL/graphql5d
Thanks for the PR. I'm going to need some time to review this and think about it. One challenge with making progress on this is that it locks in HTTP-specific types in this package, potentially ma…
dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache5d
Thanks for explaining, that makes sense. I'd like to look a way to continue to rely on `gofmt -d` to display a gofmt diff, rather than `gofmt -w` followed by `git diff`, if possible. The motivatio…
dmitshur pushed to ci-diff-n in github.com/gregjones/httpcache5d
f6876f4e36b9349575998c12e7b77f2a2a1dab26Travis: Target Go 1.11 only.
dmitshur created branch in github.com/gregjones/httpcache5d
ci-diff-n
dmitshur commented on x/build/app: build dashboard for su… in github.com/golang/go6d
@bradfitz Yes, that's the page Michael was referring to.
dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache6d
What is the motivation for changing `diff -u <(echo -n) <(gofmt -d -s .)` to `gofmt -w -s . && git diff --exit-code`?
dmitshur commented on x/build: migrate to using Go modules in github.com/golang/go6d
Well, given this is x/build and its policy (which I can't find for some reason right now), we can experiment with modules as long as they work for our needs. See https://go-review.googlesource.com/c/…
dmitshur commented on Black screen and VSync problems on … in github.com/go-gl/glfw6d
> Is this related to OpenGL deprecation? My understanding was that it would continue to be supported for some time. OpenGL is deprecated in the latest macOS, but it's still supported. This is just…
dmitshur commented on module-aware building in github.com/gopherjs/gopherjs1w
> I think leaving the project in this limbo state is unhealthy for both developers and users. Developers have no idea if they should send PRs or otherwise contribute to the project, and users are lef…
dmitshur commented on x/tools/go/packages: TestJSON may b… in github.com/golang/go1w
This seems to be re-occurring but for Go 1.10 only, see #28609.
dmitshur deleted branch in github.com/dmitshur/starlark-go1w
patch-2
dmitshur commented on x/tools/internal/lsp: TestDiagnosti… in github.com/golang/go1w
No worries, thanks for taking care of it! Now that #17626 is resolved, trybots should help catch this in advance next time.
dmitshur pushed to patch-2 in github.com/dmitshur/starlark-go1w
a195823cc40b5030f98ad309ccf14f78466f7d73README: adjust go get -u comment formatting
dmitshur pushed to patch-2 in github.com/dmitshur/starlark-go1w
560f47f61652becf1d451009b43911444047660fMerge branch 'master' into patch-2
1adc2a69b67e796f9f0447a778453fe5a4c491e5README: use go get's -u flag
da27261f3a02ec29b1a5ee9a5e34091b0adcc34dREADME: fix Issues link, 2nd try
c1036def8d2a4b50b90232f1656e3f04aa4674f7README: fix Issues link
4d4cb79ca5ff8403a6d500c120b96f7e7c864de2README: link Travis CI badge to build status page (#8)
dmitshur commented on README: simplify installation instr… in github.com/google/starlark-go1w
The change to add `-u` flag is great, and has my full support. However, I want to clarify, `go get -u` still does the `go install` step even if `-u` flag is used, so `go install` is still redundan…
dmitshur deleted branch in github.com/dmitshur/starlark-go1w
patch-1
dmitshur commented on 9c36104a24b8823669aeec409d3d05c372206facAdd documents in github.com/gopherjs/gopherwasm1w
Have you considered using a simpler URL of just https://golang.org/pkg/syscall/js/? Doesn't it give the same results?
dmitshur starred github.com/google/go-write1w
dmitshur commented on Is there a way to not pollute globa… in github.com/gopherjs/gopherjs1w
How much global namespace pollution is there? The generated JavaScript code is contained in a closure, and `this` is needed for [`js.Global`](https://godoc.org/github.com/gopherjs/gopherjs/js#Global)…
dmitshur opened a change in github.com/goxjs/glfw1w
dmitshur opened a change in github.com/goxjs/gl1w
dmitshur pushed to patch-2 in github.com/dmitshur/starlark-go1w
1fdbea21bea90db47fa7d08a083c493fa0140382README: simplify installation instructions
dmitshur pushed to patch-2 in github.com/dmitshur/starlark-go1w
438c34ea2abea9e145c0364e0e900322fc9e0459README: simplify installation instructions
dmitshur pushed to patch-2 in github.com/dmitshur/starlark-go1w
c0f9e712d469ac5c4b42ba07eeb1dcb69cbb57fdREADME: simplify installation instructions
dmitshur pushed to patch-1 in github.com/dmitshur/starlark-go1w
1ed9380551899b21237d8405c20834fdc4b67c52README: link Travis CI badge to build status page