Activity

Today
Thanks.
Yesterday
This CL was already closed in 2019, and I'm not sure why this CL was reopened in 2022. Closing again since as noted at https://go.googlesource.com/vgo#obsolete, this repository is obsolete. Thanks.
This repository doesn't have builders [defined](https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=715-747;drc=35b81aad68643121979874862a0c069da432142b), so Commit-Queue+1 won't do any…
Last Week
Thanks for reporting. Also CC @golang/netbsd. [ssh.go#L52](https://cs.opensource.google/go/x/build/+/master:cmd/buildlet/ssh.go;l=52;drc=d74f3705ac9431ccc427d35d624edb251801cbc5) calls `shell()` t…
dmitshur reviewed +2 on cmd/dist: update UnixOS comments1d
Thanks.
Thanks.
Thanks.
Thanks.
Thanks.
Thanks.
I'm not the right reviewer for changes to crypto/md5.
The top-level Properties field is deprecated¹ in favor of using TaskSlices[0].Properties, so start using the new approach, as already done in the ./internal/gomote package. The same applies to the E…
Changes in x/sys cause more allocations on Windows, as reported by failing tests. For those more familiar with x/sys and Windows - is that expected, or a problem that needs to be fixed in x/sys? Than…
Thanks for adding the builders and fixing tests at tip. The builders are currently failing on release branches 1.23 and 1.22: (CC @cagedmantis) https://ci.chromium.org/p/golang/g/go-go1.23/console…
(1 comment) I tried the same sequence of steps and I see Syscall6 → SyscallN changes in `internal/syscall/windows/zsyscall_windows.go`. See CL 623821 that's entirely generated by [git-generate](ht…
A part of the keeping Go's vendored dependencies and generated code up to date. For #36905. [git-generate] cd src go get golang.org/x/sys@v0.26.1-0.20241021134239-adbb8bbcaf61 go mod tidy go mod ve…
(1 comment) @iant@golang.org My understanding is that's the _current_ behavior (i.e., prior to this CL) - src/syscall/mksyscall_windows.go runs `golang.org/x/sys/windows/mkwinsyscall` using the vers…
(1 comment) It's currently possible to use any commit, it just requires updating the vendored x/sys version too. That is: ``` go get golang.org/x/sys@desiredcommit go mod tidy go mod vendor go gene…
(1 comment) It turned out this is the first time we ran into a workflow parameter change affecting existing scheduled workflows, and relui doesn't have good enough support for that yet (#70145). Sen…
Make it possible to see any scheduled workflows that couldn't be resumed due to their parameters changing, including their original parameter values, and the original cron schedule (if any). This al…
Relui is expected to serve 404 when a workflow that doesn't exist is requested. Its tests, ones that run only when a database is available, also expect that. Update a few places after CL 593915 accor…
When creating a workflow to be executed, relui always shows a prompt that asks: "This will create and immediately run this workflow. Ready to proceed?" The "immediately run" part is true whene…
I'll send a change that makes it possible to re-create the workflows and clean up the old ones without needing database access. It's pretty minimal, but should be fine since we don't need to do this …
Relui is designed to handle workflows that are added or modified over time. One area where it doesn't handle this well are scheduled workflows. If one of their input parameters is changed, they'll fa…
As mentioned in https://go.dev/issue/63698#issuecomment-2450448780, this might be a good starting point. Can be adjusted later as needed. For golang/go#63698.
Thanks. (Bypass since PS 2 differs from PS 1 only in comment space, and PS 1 passed.) Yeah, it's a balance of a higher-visibility hard stop when encountering new unexpected cases vs. low-visibility …
https://ci.chromium.org/b/8732718088961275521 was the first successful build - congrats on reaching this milestone! The build took over 2 hrs to complete. Given netbsd-arm64 takes around 25 min an…
There are no changes here for the Go 1.24 milestone. Moving to the next.
[CL 622015](https://go.dev/cl/622015) added an announcement to [Go 1.24 release notes](https://tip.golang.org/doc/go1.24#linux). CC @cagedmantis. Moving to the next milestone, unless there's more I m…
The input of the LUCI [build 8733044805650708721](https://ci.chromium.org/b/8733044805650708721) is `https://go.googlesource.com/tools/+/889abb17e125bb0f5d8de61bb80ef15fbe2a130d`, which is indeed a r…
Earlier
As the issue of this title says, when this issue was originally filed, the "Download" button at https://go.dev/doc/install was quite misleading. [CL 480955](https://go.dev/cl/480955) made it point to…
https://pkg.go.dev/runtime/debug#ParseBuildInfo is has no documentation. (https://go.dev/s/style#doc-comments and https://go.dev/doc/comment say that every exported identifier should have a doc comme…
Sounds great, I’m in agreement. This change will be transparent for users of the Go package, so only those who have a pre-existing git checkout for development purposes will need to migrate. FWIW, …
Thanks. An invite has been sent, it will need to be accepted by @sophie-zhao.
CC @cherrymui.
Thanks @riannucci! The aforementioned CL is submitted and released by now, so closing as fixed.
CC @golang/plan9, @FiloSottile.
Marking this as "not planned" so the issue outcome is more visible at a high level.
[CL 618635](https://go.dev/cl/618635) changes the order to be: ``` setAnchors is being scheduled generateTOC is being scheduled generateTOC is starting setAnchors is starting ``` <img widt…
[CL 601055](https://go.dev/cl/601055) added made the change to start using `node.firstChild.textContent` as the TOC item text, instead of `$(node).text()`. It looks like it was trying not to include …
dmitshur starred honnef.co/go/jello3w
dmitshur starred honnef.co/go/curve3w
Thanks for the report. GLFW v3.2 is an older version. Does this also happen with v3.3?
Thanks. CC @mknyszek.
Gaby didn't include it in https://github.com/golang/go/issues/69772#issuecomment-2392352550, but issue #67791 is also related here. If there are tests in x/ repos that would fail when switching to th…
Are the OOMs in/tools ongoing? If it was just that burst around September 20-22, I added some more detail in https://github.com/golang/go/issues/66962#issuecomment-2391753139 that's likely relevant.
Recording here that there was another instance of the builders disconnecting and needing to be restarted around September 20-23: <img width="37" alt="image" src="https://github.com/user-attachment…
All 3 CLs mentioned above are submitted, so I think this is done. Feel free to comment if we missed something.
@timothy-king You're running into friction issue #25574 – there was already a backport request in https://github.com/golang/go/issues/68658#issuecomment-2313617202. As a workaround, you can create …
Added release-blocker for now so we can track this better. (It's a documentation only issue for a secondary port, so it wouldn't block the release in practice.)
This is issue #59048. Issue #39055 is also related.
dmitshur deleted branch in github.com/dmitshur/rsc-github1mo
master
dmitshur opened a change rsc.io/github/issue: various fixes1mo
As reported by vet and staticcheck.
dmitshur created branch in github.com/dmitshur/rsc-github1mo
various-fixes
dmitshur fixed an issue runtime: unrecognized failures1mo
The most recent failures here since this was reopened are all due to a core file being left behind, and the pattern isn't narrow enough to match anything else specific. So closing this in favor of #6…
dmitshur closed an issue runtime: TestStackSwitchCallback failures1mo
Merged into #69457.
This can be reproduced locally by running the test in the x/vulndb module located in the module cache, rather than a git repository checkout. For example: ``` $ cd $(mktemp -d) $ go mod init exa…
Based on issue #69457, the watchflakes change described in https://github.com/golang/go/issues/65977#issuecomment-1969407349 above is done. It sounds like there's nothing more to do here, and we can …
Merged into #69457.
Merged into #69664.
dmitshur closed an issue make.bat: unrecognized failures1mo
Merged into #69664.
Merged into #69664.
Issue #33986 is relevant. Issue #66962 may also be relevant.
Fixed in [CL 610940](https://go.dev/cl/610940).
dmitshur commented on github.com/go-gl/glfw: GLFW v3.41mo
Build constraints are documented at https://pkg.go.dev/cmd/go#hdr-Build_constraints.
dmitshur commented on github.com/go-gl/glfw: GLFW v3.41mo
Checking in on the status. @Geo25rey, would you like to keep pushing this forward? If so, there are some unresolved review comments that need to be addressed, otherwise this seems close. I've been us…
[CL 616336](https://go.dev/cl/616336) is submitted, nothing more to do here.
The production instance isn't healthy yet: ``` $ kubectl get pods | grep watchflakes watchflakes-deployment-7dd687d899-8rf75 0/1 CrashLoopBackOff 1876 (3m53s ago) 17d ``` @dr2chase …
Another instance reported at https://ci.chromium.org/b/8735636356859002161/infra, this time on windows/amd64. So this likely applies to all platforms rather than linux/ppc64le specifically.
Fixed in [crrev.com/c/5873674](https://crrev.com/c/5873674). As a simple demonstration, [CL 615681](https://go.dev/cl/615681) contains a test that intentionally reaches across module boundary and …
One way to test it would be to run it locally; it should no longer run into the "repo mismatch" error. You'll also know it works when you [deploy watchflakes with it](https://go.googlesource.com/bui…
Watchflakes is currently in a continuous crashloop: ``` $ kubectl logs -p watchflakes-deployment-7dd687d899-8rf75 watchflakes: 2024/09/24 12:12:43 ListBuilders watchflakes: 2024/09/24 12:12:4…
Moving this issue to Go1.24 milestone. If a backport is needed, please follow the https://go.dev/wiki/MinorReleases to create backport issue(s).
In [build 8736249311634815793](https://ci.chromium.org/b/8736249311634815793) (a shard of a real linux-amd64 build on [CL 614296](https://go.dev/cl/614296), whose no_network property is true) TestCre…
It's likely related that linux-386 and linux-amd64 builders are configured to run with a no-network check: https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=527-532;drc=c29a1893e55…
### Go version go version go1.23.1 darwin/arm64 ### Output of `go env -changed` in your module/workspace <details><br> ```sh GOPROXY='http://127.0.0.1' ``` </details> ### What did…
Fixed in [crrev.com/c/5869577](https://crrev.com/c/5869577). Specifically, release branch builders (e.g. x_example-go1.22-linux-amd64) will now skip testing modules that have a go directive that's…
Fixed in [crrev.com/c/5869581](https://crrev.com/c/5869581).
Gerrit now provides an ability to rebase on behalf of the original CL author, which doesn't require Forge Author permission. See [here](https://groups.google.com/g/repo-discuss/c/NeSb-YI5mQM). Can yo…
Closing this again since the original problem with write_go_bootstrap_tar failing with 404 is resolved, the only currently connected legacy plan9 builder (plan9-arm) is working okay with a go1.22.6 b…
> I sent [CL 608155](https://go.dev/cl/608155) to [remove known issue], and [CL 607656](https://go.dev/cl/607656) to mark them as migrated [which stops coordinator from sending them work]. I haven…
I don't think anyone has plans to resume work on this, and there is a working plan9/386 LUCI builder tracked in #63599. Closing this in favor of that issue.
It is possible the builder resource limits are not sufficient for the increased demands. Increasing memory (if it's viable, given it's 32-bit) might help, but that kind of builder maintenance work is…
Indeed, I think we can consider this done. Thanks.
dmitshur commented on build: ios trybot builders failing1mo
Thanks for reporting. It looks like this builder provides its own bootstrap at /var/root/go-ios-arm64-bootstrap, and its version go1.20.6 is too low for tip. Go tip (1.24 to be) has a minimum boot…
Adding some relevant notes here. [CIPD](https://chromium.googlesource.com/infra/luci/luci-go/+/refs/heads/main/cipd/README.md) as used by LUCI builders already has an existing package providing No…
Agreed – if achieving x/playground's testing needs can be made to work without the Docker dependency, that path would be great. Recently @hyangah is exploring a similar direction for vscode-go's te…
Tracking issue #66002 is related.
@mengzhuo Thanks for requesting this backport. We already reviewed it, but a note for future: https://go.dev/wiki/MinorReleases says "The [backport] issue should include a link to the original issue …
dmitshur starred github.com/josephburnett/jd1mo
Based on https://www.freebsd.org/releases/, FreeBSD 13.0 is EOL, and its most recent releases are 13.3, 14.0, and 14.1. CC @mengzhuo Is it right that https://ci.chromium.org/ui/p/golang/builders/l…