Activity

Today
Consider the output from `go test` without `-json` flag in a situation where a test timeout happens while multiple subtests are still running (as happened in #74279): ```sh $ go version go version g…
Looking at recent build completion times for x_tools-gotip-openbsd-amd64 shows it often takes around 20 minutes, while x_tools-gotip-linux-amd64 often takes around 5 minutes. Even in the main Go repo…
Copied Votes: * Code-Review+1 (copy condition\*: "**is:ANY**") Outdated Votes: * LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE") \* The label has `labelCopyEnforcement` or `label…
Yesterday
Of course. In theory you can use a regular ./make.bash and create the .tar.gz archive of the result, but it might be easier to use ./make.bash with -distpack flag—just like the real release process…
This Week
There was another instance, but this time it was with a non-zero offset in the middle of a month: ``` 2025/06/18 14:21:34 service/activity/github: mailLoop: walkSegMail(github.fileSeg{file:"/2025-06…
This is done. Closing in favor of the newer issue #73488.
This was done a while back ([CL 532579](https://go.dev/cl/532579)).
Thanks. Sounds good, it's tracked in #74287 now.
The Go macOS installer currently runs a sequence of commands described as "Fixing permissions": ```bash GOROOT=/usr/local/go echo "Fixing permissions" cd $GOROOT find . -exec chmod ugo+r \{\} \; fin…
(Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving it a .darwin-amd64.tar.gz toolchain.)
It sounds like you were testing the change with a go1.24.4 toolchain. The change is set to apply on versions go1.25rc2 and newer only, so seeing the installation proceed as before is working as inten…
(1 comment) Oh, almost but not quite — it's still needed in `enabled` so that 'builders_to_trigger_after_toolchain_build' isn't set to non-existing dev.simd x/ repo builders.
(3 comments) Yes, config groups define presubmit. But I expect we'd need to make more changes to make it useful. As is, this arch_repo_dev-simd config group matches only "internal-branch.dev-simd-.+…
It occurs to me now that one of the effects of dropping omitVariant for test directory tests is that the corresponding test ID will now always have some shard. Previously, if fixedbugs/issue68525.go …
Thanks. directory I see, it's impossible to distinguish their timing. For example, if you do run both the go/version package tests as well as its racebench variant in JSON mode, you get both: ``` …
Both of our installers are correctly annotated for the intended host architecture. That is, the hostArchitectures option is set to x86_64 on .darwin-amd64.pkg installers, and to arm64 on .darwin-arm6…
(1 comment) Whoops, the "Fixing permissions" postinstall file existed even earlier, I'm now finding CL 11970 from 2015, and it might be present in even earlier Go macOS installers. So higher chances…
Thanks for finding this and sending the CL. It does look like a good improvement. I think it's a good time to try this for Go 1.25 since there are still opportunities to get wider signal from pre-re…
Last Week
I terminated the bot via swarming UI: <img width="892" alt="Image" src="https://github.com/user-attachments/assets/21ce9cd4-5236-479d-aedd-fd341aeba18a" /> After it came back, it had a successful …
The Scaleway linux/arm builders are no more, and there haven't been recent reports here. If this comes up on the newer linux/arm builders, watchflakes will file a report. Closing.
dmitshur starred github.com/firstrow/mcwig1w
> At this point it might help to separate out work on making relui do this automatically into a dedicated x/build/cmd/relui issue, since that can happen independently of the Go release cycle. Made #…
This is a tracking issue to create a task for updating the compiler's PGO profile, something that we currently typically do for every major Go release, so about once every 6 months (issue #60234). I…
I think we can close this now - I'm not aware of anything more left to do for this for Go 1.25. If there's anything still in the tree that exists only because of needing to support macOS 11, then th…
Thanks for the report. The corresponding release note for this is https://tip.golang.org/doc/go1.25#go-command (second paragraph, "The Go distribution will include fewer prebuilt tool binaries. …")…
Earlier
Permission change applied.
dmitshur closed an issue os: TestRootRemoveDot failing on Plan 92w
Need to grant the gobot account a permission for the TryBot-Bypass label, since it is being used by it now. Reopening for that.
The `go test` command normally runs a select subset of vet checks, and fails the test if any of them fail. In the main Go repo, to aid development, that behavior is forcibly modified to have all vet…
This issue tracks a remaining subset of the accepted proposal #61716. Specifically: > Once math/rand/v2 has shipped, we would tag and delete x/exp/rand. This would keep programs that already use x/e…
Indeed—freeze exceptions would be needed for changes that aren't in scope of the freeze (and ideally they need to be filed and approved before the freeze), but finding and resolving issues in new-t…
Great! I've also updated your email in the approvers group now, so everything should continue to work. Just as a reminder, please be familiar with the rules for voting and submitting changes as desc…
Latest instance fixed in [CL 663975](https://go.dev/cl/663975).
The darwin-arm64-longtest builder is passing at tip and on the Go 1.24 release branch, but it has one failing test on the Go 1.23 release branch. I filed #73922 for it. The darwin-arm64-race builder…
### Go version This affects Go 1.23.x only. The test passes on Go 1.24.x and at tip. ### Output of `go env` in your module/workspace: ```shell GOOS='darwin' GOARCH='arm64' ``` ### What did you do…
The problem appears to be due to a regression in the result_adapter command in [crrev.com/c/6554882](https://crrev.com/c/6554882) from May 19, 2025, which has a pending fix in [crrev.com/c/6598395](h…
@ysmolski Glad to hear that you were able to update the email in your Gerrit account! It indeed shows up as expected at https://go-review.googlesource.com/dashboard/26536. About the CLA page, in the…
dmitshur commented on access: approvers3w
CC @4a6f656c, @Rongronggg9, @milanknezevic, @mengzhuo Since you're also members of [golang/mips](https://github.com/orgs/golang/teams/mips) and [golang/riscv64](https://github.com/orgs/golang/teams/r…
The current implementation of `constructQuery` is very tailored to the needs of the rest of the graphql package. It doesn't take any options, like the ability to include spaces in formatting, and doe…
Since it's not already mentioned here, the proposal for this was #66107, and the accepted plan there was: > The proposal is to allow range over func and int the same as in Go. The current implement…
For clarity, it looks like "Methods and interfaces" was referring to the section title: ![Image](https://github.com/user-attachments/assets/9a4e2ba1-0443-4748-b26b-a3db26d837e0)
[CL 664215](https://go.dev/cl/664215) generated a preliminary list for Go 1.25. It's the same list as for Go 1.24 except the macOS minimum version became 12, and that's noted at https://tip.golang.or…
dmitshur pushed to main in dmitri.shuralyov.com/service/change1mo
6140fdcb140798fe4fda313c57be133bf235e796maintner, gerritapi: handle draft status
ce8900dcd6898d396808d962fd777dcf7be445e9gerritapi: pass context to Gerrit calls
96ed021e15235cb4abcdaa86b88cc271e47f04c1add minimal go.mod
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)
dmitshur pushed to main in dmitri.shuralyov.com/scratch1y
5eb48b5f5d31d39777719edb35d37b724f183dc8quine: add load-bearing trailing space
dmitshur created package in dmitri.shuralyov.com/scratch/quine1y
LGTM. Thanks, and congrats on your first new Go package here! Done in PS 2. Patch set 2 seems to resolve this.
Thanks! If it's ready to be submitted from your side, I can do that now.
dmitshur pushed to main in dmitri.shuralyov.com/html/belt1y
d8009a3578d1be4dafb93e9ee4894d2bbd2b5e3badd OnClick field to CommitID
63f3644d8635396fd13789affe363ee9f693e8ecadd dark mode support in Reference
They are. Although Go can make them too easy via `go:embed`. See some initial comments. I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…
Thanks! Congrats on your first change. :D See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …
dmitshur pushed to main in dmitri.shuralyov.com/go/generated2y
e1de015411532fa144166aada4201ee443800425add test case with no final newline
6904a2a3d88d6c3ad39737a7c5bf226f5ebbd482modernize test code slightly
dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl2y
85de2813cf6bd8d6d2f0240fdebf943cbffc2b8afix "supportsFamily not found" warning on macOS 10.13 and 10.14
dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl2y
b78c9fe623cca0431d866c9e206d3f83665bcf8bdeprecate FeatureSet and Device.SupportsFeatureSet
2a3c46a829b92964146abf7f6c2d649cd66cce97add GPUFamily and Device.SupportsFamily
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …
dmitshur pushed to master in dmitri.shuralyov.com/service/change3y
67e22b2f18a260a33a98c6a7d601726a58c53767maintner: update for GitCommit API change
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now. Done in PS 3. I'm following the Go style for commit messages, which chooses…
Shortened 'golang.org' to 'go.dev' here, and on line 24.
dmitshur pushed to master in dmitri.shuralyov.com/website/gido3y
f460621dc784d8a8f3a1593a068115b62baf214dadd support for multiple comma-separated import path patterns
be77a538f6a64b287e073b59d1b9f7e1314cf3a9upgrade to go-git v5
b5ce3c19e6b977800ee3c80bc722192f96ef657breplace mention of godoc.org with pkg.go.dev
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl4y
28db891af037715d8c1deec7652485a173c60e25all: add darwin/arm64 (macOS) support
dmitshur pushed to master in dmitri.shuralyov.com/website/gido4y
d2c7b7eec450806980d4eefb626ccf6df2ef99dcupdate release branches to be for Go 1.15 and 1.14
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y
a78bd3c7abc465e1864ecadce67a826711a27caeadd support for "golang.org/x/pkgsite/..." issues
dmitshur pushed to master in dmitri.shuralyov.com/html/belt5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y
b7141fef43ec3cefbd93cc444ab1f27bdc0a7725add support for "golang.org/dl/..." issues
1fdfe09b78364e4305cfc7fec4b2888fac391bb3update release branches to be for Go 1.14 and 1.13
dmitshur pushed to master in dmitri.shuralyov.com/go/prefixtitle5y
500817462677553a6769e268d66193c36b423cd6add support for "golang.org/dl/..." issues
This is a valid issue, but the root cause analysis was incorrect. > This happens because they're added using the original paths, without checking that those paths correspond to any existing director…
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y
a42bf6b4ae5ef58ce39d0a7705047c345c800b98update release branches to be for Go 1.13 and 1.12
b36d6d3cb7ee809e6244a5f67a571a2d70f46b4aadd to openChanges and closedChanges when len(paths) == 0 && root != ""
8224e12ba9aea8d30dbeb643dca121cefec05726refactor code that populates issues and changes
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated: ```Go func initExistingDirectories() error { …
dmitshur pushed to master in dmitri.shuralyov.com/app/changes5y
e22f40b3687320a8bfbc863f27da771ed17d7b05assets: regenerate after "Sign in with URL" change
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl5y
d42048ed14fdc83bd0e48f4b2a5e13c593e88cb6link to CoreGraphics framework
11308bd612348edeca0d8fddca07bc5a4dfbb35cexample/movingtriangle/internal/{ns,ca}: rename to appkit, coreanim
9364696d8c28dc804dcd7e099f0b7c6cb58ac824example/movingtriangle: remove unsafe.Unsafe conversion
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl5y
fec1b7b612ab0b81aa1d8b5c9a58c795f94fd767example/movingtriangle: update to GLFW v3.3
dmitshur pushed to master in dmitri.shuralyov.com/service/change5y
1161aef33b4aafec8f04c40d9863324a08f5c912gerritapi: display reviewer requests and removals
957083f7751c871f1d6ddba48c392eb3836786d8gerritapi: sort inline comments
813ec28aab09112bc09eecb553884b7aa962e696add LICENSE file
dmitshur pushed to master in dmitri.shuralyov.com/text/kebabcase5y
dmitshur pushed to master in dmitri.shuralyov.com/route/gerrit5y
dmitshur pushed to master in dmitri.shuralyov.com/state5y
dmitshur pushed to master in dmitri.shuralyov.com/scratch5y
dmitshur pushed to master in dmitri.shuralyov.com/app/changes5y
dmitshur pushed to master in dmitri.shuralyov.com/route/github5y
dmitshur pushed to master in dmitri.shuralyov.com/html/belt5y
dmitshur pushed to master in dmitri.shuralyov.com/route/github5y
7e79d56078638d1d7d4d6853af037d67de3f9589add IssueEventURL and PullRequestEventURL to Router
dmitshur pushed to master in dmitri.shuralyov.com/service/change5y
011d2fcff0d76baa0352ecae474a802553b46c52githubapi: omit states argument for "all" filter
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.