Activity

Today
I've spent some time thinking about this suggestion, and I understand it a lot better now. I also agree that a package-centric approach, if it is made robust, can be better and cleaner. However, I di…
I ran an experiment on the standard library and some modules that were recently published (by using the [module index](https://index.golang.org)). The results seem favorable, and there are quite a fe…
dmitshur starred in github.com/8byt/gox5h
Yesterday
(2 comments) Since we’ve confirmed this is true, maybe remove the “I believe that” prefix. Indeed. Thanks.
(2 comments) If you're referring to the flakiness workaround in robustio_flaky.go, I'm not seeing ios included there. Would you like to change that? I read this as not matching iOS since there's no…
(1 comment) Sorry I missed this CL earlier. I should be able to review it soon. There's a merge conflict, are you able to rebase and resolve it?
Also CC @eliasnaur. Any idea of this darwin kernel bug can be worked around on the side of the builder?
(1 comment) Should a similar change be made here, or is it fine as is?
The feature of graying out a builder with a known issue has been implemented in x/build/app/appengine but only for the main section. It should be grayed out in the golang.org/x repository sections as…
CC @golang/security, @toothrot, @cagedmantis.
Sound good, thanks for doing that. I've remembered that we have a test that ensures each GOOS/GOARCH term has *some* slowbot alias. But given how similar `ppc64{,le}` are, I think it's fine for us t…
> I frequently see changes being made to code related to PPC64 which only use TRY=ppc64 for testing those changes. [...] Could we change the ppc64 alias in build/dashboard/builders.go to run the linu…
dmitshur commented on golang.org/x/build: add noopt trybot1d
I'm not working on this at this time, so unassigning. CC @toothrot, @cagedmantis.
dmitshur pushed to master in github.com/shurcooL/gtdo1d
f4639f40611b1b32094f2e13fb65307e8d0b30d0frontend/selectlistview: turn off form autocompletion
This Week
This is the same change as in CL 144917, but applied to a nearby line. For #28374.
Last Week
From https://golang.org/cmd/go/: > Files whose names begin with "_" (including "_test.go") or "." are ignored. [`ScanDir`](https://github.com/golang/go/blob/fc981654c763c2c1d72df2a6e35ba3dfc78d…
On the aix-ppc64 builder: ``` --- FAIL: TestDisasmExtld (2.79s) objdump_test.go:157: Running [/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin/go build -o /ramdisk8GB/workdir-host-aix-ppc64-…
(1 comment) Thanks Joel. I'll redeploy at the nearest opportunity.
Now that x/build test failure is fixed, I've retitled to be about the buildtag check. As far as I can tell, this is working as intended and this issue should be closed. But I'll let @rsc or @matlo…
(1 comment) I'll submit as this fixes tests; we can follow up on the issue if there's more to do.
(1 comment) Filed #42019 and sent CL 263117 for the cmd/release failure.
Likely related to [CL 261958](https://golang.org/cl/261958), `gotip test golang.org/x/build/cmd/release` fails: ``` $ gotip test # golang.org/x/build/cmd/release ./releaselet.go:609:1: +buil…
Thanks for filling in the template. Please be aware that package `net/rpc` is frozen and not accepting new features. I don't believe there's an issue here. Capacity 1 is enough for when the fre…
(2 comments) The "Fixes" line got removed in patch set 3: Fixes golang/go#41856. Looks good, thanks.
> it may suffice to set `GOFLAGS=-mod=readonly` in the builder environment That has become the default in Go 1.16 (#40728), so the error message there looks like this: ``` ... in golang.org/x/…
(1 comment) The TestScript/build_overlay test is failing on the windows-amd64-longtest builder: https://build.golang.org/log/24c67afcd3eb8fefe65b729035d0fbfaf7a5a1fd. Opened #42008 for tracking.
The `TestScript/build_overlay` test is failing on the `windows-amd64-longtest` builder as of [CL 257198](https://golang.org/cl/257198): • https://build.golang.org/log/24c67afcd3eb8fefe65b729035d…
I think I see the problem. There wasn't a duplicate message sent to Gerrit. Instead, the "gobot@golang.org" Gerrit account name changed from "Gobot Gobot" to "Go Bot", which caused the Gerrit → Git…
GopherBot (along with some other services) was restarted around 12 hours ago and when it came back up, the `congratulateNewContributors` task ended up posting a repeat "congratulations" message on so…
> I do not have a way to access(programmatically) the output of the test. Have you considered the `-json` flag of `go test`? For example: ``` {"Time":"2020-10-14T20:22:16.736222-04:00","Action…
(1 comment) The ./content/static package needs to be regenerated after a change to the static content. This is caught by tests: $ go test ./... --- FAIL: TestStaticIsUpToDate (0.21s) …
Reopening because the x/website CL was reverted in [CL 261557](https://golang.org/cl/261557). x/website needs to be modified when Go 1.16 is released. I'll move this to Go 1.17 milestone with early-i…
(1 comment) Thanks. I also filed #41979 about considering an automated mechanism to prevent accidental early submission of CLs with a wait-release hashtag.
There is a convention of using a wait-* hashtag to indicate a CL is waiting on some specific item before progress can be made. This is described in issue #10658, which may need to be resolved more be…
(1 comment) If this is here because of CL 259858 only, I think it should be left out since that change was a fix for a flaky test (motivated by release testing needs). There is no change in behavior…
dmitshur reviewed +2 on : [release-branch.go1.15] go1.15.36d
(1 comment) LGTM. I've checked the build dashboard and the contents of release-branch.go1.15.
dmitshur reviewed +2 on : [release-branch.go1.14] go1.14.106d
(1 comment) LGTM. I've checked the build dashboard and the contents of release-branch.go1.14.
(1 comment) I posted a comment in https://go-review.googlesource.com/c/build/+/171238/10#message-752470128a36b70063527ced7c78712ed8650376 which would've been better to post here instead.
(1 comment) (I recall Bryan was okay with other people picking this up from an earlier discussion.) I've recently done some work locally to rebase this, resolve merge conflicts, and do some testing…
Given that we've backported a fix for this issue to Go 1.15, I believe we should not release Go 1.16 without fixing this (or re-visiting this in some way), so marking as a release-blocker.
(1 comment) I haven't had a chance to verify this yet, but if that is the reason, I think we may need to deal with this similarly to how we deal with an inconsistency of version selection between th…
(1 comment) Do you know why this change appears here? I suspect that it's because of #41375. If so, that is unfortunate and we should think about whether we want to include it. The backport reques…
dmitshur reviewed +1 on io: add a new ReadSeekCloser interface1w
(1 comment) This can probably be "Fixes" (unless you expect more will need to be done, then keeping "Updates" is fine).
From https://farmer.golang.org/: ``` host-linux-riscv64-unleashed: 0/0 (1 missing) ``` @bradfitz Are you able to get this builder up and running again? Does it just need to be restarted, or i…
(2 comments) Add: For golang/go#27532. Thank you. Sorry that it took a while to get to this.
(2 comments) Thank you. One minor comment, otherwise LGTM. I understand this builder is expected to fail initially because #40995 hasn't been resolved yet. Please set KnownIssue to 40995 here so t…
(3 comments) You're right, I forgot about that when making this suggestion. That's a good reason to leave it as is. Thanks. This just needs to be rebased and it has a +2. I think it can be submitte…
(1 comment) Thanks for the ping Joel. This CL (and 2 more) have been on my list and I plan to get to it today.
(1 comment) Thanks, I'm taking that into account. :) In this case, it was quick for me to try and get a little more signal, so I ended up choosing to do it.
(3 comments) Since this change (and the flake problem) affects both TestServerEmptyBodyRace_h{1,2}, maybe remove the _h1 suffix. Seems to work well in my brief testing. It may be helpful to add an…
From your report, the error happens when testing the `github.com/getupio-undistro/undistro/client/cluster` package, but that package doesn't appear to be available publicly. Is it possible to redu…
Thank you for making the request @mengzhuo, we will consider it.
CC @bcmills, @jayconrod, @matloob per [owners](https://dev.golang.org/owners).
If this is a question, please see https://golang.org/wiki/Questions. If this is a bug, please fill in the questions in the issue template.
CC @griesemer.
Yes, filing an issue and discussing it first is very helpful, thanks. CC @FiloSottile per [owners](https://dev.golang.org/owners).
CC @mikioh, @ianlancetaylor per [owners](https://dev.golang.org/owners).
CC @FiloSottile, @agl, @rsc per [owners](https://dev.golang.org/owners).
Please provide more information about how to reproduce the error. "go test ./..." is not enough information. What repository did you run that in?
Thanks for the report. Given it has happened just once, in an old unsupported version, and the error doesn't make much sense, we can probably close this issue for now. It can be re-opened if it ha…
CC @mikioh, @ianlancetaylor per [owners](https://dev.golang.org/owners).
CC @golang/tools-team per [owners](https://dev.golang.org/owners).
CC @rsc per [owners](https://dev.golang.org/owners).
CC @mpvl per [owners](https://dev.golang.org/owners).
This was a TODO comment added 2 years ago that was only reported 2 weeks ago. That suggests to me it's not a very serious issue, and fine to leave for 1.16.
(4 comments) s/meta-package/meta-pattern/ I think this is a good solution given the constraints today. Some minor comments. What does "pkgIsStd" short for? "Package is std"? Did you mean to say "…
> it doesn't say anything about starting from an empty environment I agree. This issue isn't expecting an empty environment plus the 6 documented variables. It's expecting the caller's environment p…
(1 comment) I think a trivial workaround could be to use a relative path instead of absolute path here.
(1 comment) This reads nice, but as far as I can tell it relies on questionable cmd/go behavior. I was surprised it worked even when the GOROOT environment variable is unset (quite common). I filed…
NeedsDecision is to decide whether to fix the implementation or the documentation.
`go generate` [documentation](https://golang.org/cmd/go/#hdr-Generate_Go_files_by_processing_source) currently says: > Go generate sets several variables when it runs the generator: > > ``` > $…
(1 comment) My second comment was sent too quickly. This loop is reading gotReqCh, not didReqCh. So I think my original comment applies.
(1 comment) Oh, I misread when the send to didReqCh happens. There will be all 25 of them. So there isn't a problem. However, the failed channel has become largely unused (there's never a value sen…
(1 comment) If a client fetch error condition happens, there will be fewer than 25 sends to gotReqCh, and 0 sends to failed channel since line 1705 is deleted. That means execution won't get past th…
Closed by merging 76a2c87a2c4e78f40f0f70bda3da93c773630179 to release-branch.go1.15.
(3 comments) This was resolved in patch set 7. Makes sense, thanks. Answered above.
Reopening for updating vendored and bundled copies in the standard library.
> A Go pointer is not passed to oto_setNotificationHandler, so this seems odd. (Is this a false positive?) I'm not sure, but here's one guess. One of the parameters to the `C.AudioQueueNewOutput` …
I've tried running the program around 10 times before and after commit 90150a1b96033538ff584be8c135c1ad99c55ca0, and this hasn't happened. Given how rare it was, it's hard to say. Given the argument…
dmitshur pushed to master in github.com/shurcooL/play1w
2f9c22b07d495d608d26dcaca1ecdd0d6ec3fc73update for oto and go-mp3 API changes
This is a panic I've observed during a call to the `oto.NewContext` function (using latest version, commit 98bd5f46accc496267494d91e926cd63d9a32822) on macOS: ``` $ go run . source sample rate: …
Thanks for answering. If I understand your reply correctly, you're suggesting there are no known reproducible situations when the response body isn't read completely by this library. That is good to …