Activity

Last Week
CC @bradfitz, @neild, @empijei.
As I understand this, the `fs.FS` interface represents an abstract hierarchical file system. It's up to the implementation to define this, and there may be multiple valid implementations that provide…
Thanks. I think with this workaround and CL 308790, we have enough rate limit budget to re-enable that task, so LGTM. I'll keep an eye on it to make sure it's working as we expect.
In https://github.com/golang/go/issues/45480#issue-854860512 a backport request was made, but gopherbot ignored it because it currently looks only inside issue comments, not the main issue body. It w…
This issue also affected a recently added "set vscode-go milestones" task. There is more information available in #45461.
Closing as duplicate of #40640.
It may be relevant here that it's possible to have a "test-only" package: one that has tests but no code. In that case, the package name can only inferred from package tests. Consider: ``` -- go.…
This proposal ended up being considered in #941 (as "Alternative 2"), but ultimately [not chosen](https://github.com/gopherjs/gopherjs/issues/941#issuecomment-583767534). The alternative solution of …
Yes, this ended up being a subset of #941 and got implemented in #966 in Feb 2020.
Will there be tests that catch this in the future?
The maintner data model doesn't expose when an issue gets transferred from one repo to another (that's golang.org/issue/37370), so GopherBot currently doesn't skip transferred issues when…
GopherBot doesn't skip issues that were transferred from one GitHub repository to another when processing them. The "set vscode-go milestones" task recently added in [CL 308350](https://golang.org/cl…
(2 comments) Add 'cmd/' in front of buildlet. It sounds like we've narrowed this down, so let's update the name and comment accordingly to provide more information, something like: …
(1 comment) The comment says Done but point 2 isn't addressed (the '/*' suffix is still there in patch set 5), is that unintentional?
Approving per discussion in a release meeting. This backport applies to both 1.16 (#45385) and 1.15 (this issue).
Approving per discussion in a release meeting. This backport applies to both 1.16 (this issue) and 1.15 (#45384).
Friendly ping after 2 weeks since it's a release blocking issue for Go 1.17.
There's a new occurrence today.
@rsc Can you please take a look since this is a release blocking issue in NeedsDecision state?
These are the only remaining comments I have, I'm happy with this. +1 because I didn't review this as thoroughly since Alex did. Thanks. Since the suggestion on line 13 was used, update this…
(6 comments) Is it intentional that 10-15 uses a dash while the 10_11 and the rest use an underscore? While here, maybe also s/osx_version/macos_version/ or so. Nit: Maybe this can be shortened to…
This looks good, minor comments. Since the milestones from different repos are separate namespaces, consider s/untriaged/vscodeUntriaged/ to make it stand out more. Maybe move this into a separate …
I noticed the comment in the `golang.org/x/sync/syncmap` package is in a `pre_go19.go` file, since after Go 1.9 it just does `type Map = sync.Map`. So it's probably not a big deal to leave it as is.
David, are you able to leave a Trust+1 and submit this when it's ready from your side?
dmitshur commented on runtime/cgo: document Handle better3d
CC @oakad, @changkun, @ianlancetaylor.
Thanks @dtchanpura and @qmuntal. The latest x/blog commit has been deployed now, so I'll close this.
CC @neelance, @cherrymui via [owners](https://dev.golang.org/owners).
(3 comments) The regexp still exists, we're just making it shorter, so: internal/dl: simplify featured macOS file regexp It's helpful to add a body that provides the motivation for mak…
Thanks, this looks good. I made suggestions to improve the test. Since this is using 1.16.3, let's include all releases available on golang.org/dl today to make this test even more useful: ``` …
(1 comment) From https://golang.org/wiki/CommitMessage#reverts: > Edit the description to add the Gerrit CL number being rolled back next to or instead of the Git revision number. Maybe it'…
April 7, 2021 edition: ![image](https://user-images.githubusercontent.com/1924134/113906566-62062c80-97a2-11eb-88c4-f188d88a2cc2.png) 1 month 13 days since last. Fixed with `kubectl delete pod …
I believe this comment was originally added in [CL 37342](https://golang.org/cl/37342), and it also exists in `golang.org/x/sync/syncmap`. CC @bcmills in case this is still familiar to you.
Just to point out, renaming a builder means previously built commits will need to be processed again, so builder renames are best done when there's a good reason. This rename makes sense to me an…
Most API additions to the `testing` package would likely need to go through the proposal process and get approved before being added. It is better to wait until the proposal is approved before sendin…
(1 comment) I suspect this needs to be a builder name, it can't be a slowbot alias.
(1 comment) s/arm64/amd64/ Here, and on line 9.
dmitshur starred in github.com/adonovan/spaghetti4d
dmitshur commented on : golang path eroor visual studio4d
If this is an issue with the VS Code Go extension, please take a look at the [troubleshooting](https://github.com/golang/vscode-go/blob/master/docs/troubleshooting.md) and [help](https://github.com/g…
dmitshur closed an issue : golang path eroor visual studio4d
I'm going to retitle this issue to be about adding a health check and metrics to improve visibility into this issue, and close it since it's done. We can file new issues for future improvements to…
dmitshur commented on : go eroor visual studio4d
Closing as the issue is empty.
dmitshur closed an issue : go eroor visual studio4d
This is fixed. Old pre-release Go versions are now considered archived rather than not being included at all, and they show up both at the bottom of https://golang.org/dl/#archive and in the API with…
dmitshur starred in github.com/peterhellberg/gfx6d
dmitshur pushed to master in github.com/shurcooL/frontend6d
a7f739b69a8fed27c3cf33212fc872add99cc97areactionsmenu: use document for detecting background clicks
6429f0c101df23638f2ec61e3bec44cc149ba7fdreactionsmenu: handle non-KeyboardEvent event gracefully
3995262113d690e70617adf21779b2fa6e07c2d6reactionsmenu/v2, tabsupport/v2: use syscall/js and dom/v2 APIs
Earlier
I can't reproduce this with Go 1.16.3. Are you sure there aren't local changes causing it? Does `git status` show a clean working directory? What about `git clean -dx --dry-run`?
(2 comments) 'x/' prefix is for issue titles, no need in CL subjects. I can't reproduce this with go mod tidy, using Go 1.16.3. When I run 'go mod tidy' on commit 85be41e4509f41…
(1 comment) Please word wrap and don't use backticks (Markdown syntax), since the commit message is meant to be readable as plain text. See https://golang.org/wiki/CommitMessage and https://gola…
(2 comments) Nit: This line is quite long and would be nice to word-wrap a bit, as described at https://golang.org/wiki/CommitMessage. This likely can be simplified to just cmd since *exec.Cmd is a…
(1 comment) This will work if the package name is the same as the last import path element, but that isn't always true. See the last paragraph of https://golang.org/issue/37689#issuecomment-5965…
Ian came up with an idea for us to add a weekly task for someone on the Go team (we have a weekly rotation we can make use of) to look for CLs that have been reviewed but just need trust to become su…
This change is already submitted via CL 276772.
Closing as this is superseded by CL 291690 and related CLs in that stack.
Thank you. Let's hold off on submitting/deploying this since it's a Friday; I will take care of it next week.
I think this change is okay to submit if there's still desire. It's waiting on outstanding code comments to be addressed (e.g., the signed-off line needs to be removed). Optionally update t…
Thanks for the change. The change to behavior isn't the right way to fix the issue: old unstable releases should be considered archived instead. I'll close this in favor of https://golang.org…
(2 comments) Maybe it's worth updating this test to check that the old unstable is a part of archived versions: _, unstable, archive := filesToReleases(fs) ... if got, want := list(…
(1 comment) I also considered that with this change the JSON payload size goes from 470 KB to 650 KB (but becomes smaller after being compressed), which should be okay for now.
Thanks. I think we can proceed with this, see comments. Let's add an updates line here pointing to an issue that lead to non-latest pre-release versions no longer appearing. (To make it visible …
dmitshur closed an issue all: Go 1.15.11 release status1w
dmitshur closed an issue all: Go 1.16.3 release status1w
dmitshur commented on all: Go 1.16.3 release status1w
This release is done.
For golang/go#45334. For golang/go#45333.
For golang/go#45334. For golang/go#45333.
dmitshur commented on all: Go 1.16.3 release status1w
## Latest build: go1\.16\.3 - src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.16.3/go1.16.3.src.tar.gz)) - linux\-386 ([tar\.gz](https://golang-release-staging.storage.goog…
dmitshur commented on all: Go 1.16.3 release status1w
## PROBLEMS WITH RELEASE - RELEASE BUILD FAILED - **Found errors during release. Stopping!** ## Latest build: go1\.16\.3 - src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/…
dmitshur commented on all: Go 1.15.11 release status1w
## Latest build: go1\.15\.11 - src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.15.11/go1.15.11.src.tar.gz)) - linux\-386 ([tar\.gz](https://golang-release-staging.storage.g…
dmitshur commented on all: Go 1.16.3 release status1w
## Log 2021/04/01 11:27:00 starting 2021/04/01 11:27:00 working in /Users/dmitshur/go-releasebot-work/go1.16.3 2021/04/01 11:27:00 $ git clone https://go.googlesource.com/go /Users/dmit…
Make the health dashboard more useful by displaying the status of the darwin/arm64 reverse builders. For golang/go#39782. For golang/go#45336.
From https://farmer.golang.org: ``` host-darwin-arm64-11_0-toothrot: 0/0 (2 missing) ``` CC @toothrot, @golang/release.
dmitshur reviewed +2 on : [release-branch.go1.15] go1.15.111w
dmitshur reviewed +2 on : [release-branch.go1.16] go1.16.31w
That is not expected, since there is a '=' character in the replace value. Please file an issue at https://golang.org/issue/new and fill in the template so we can try to reproduce it. Thanks.
dmitshur starred in github.com/mmcloughlin/mathfmt1w
dmitshur pushed to master in github.com/golang/groupcache1w
41bb18bfe9da5321badc438f91158cd790a33aa3add back Context type as alias to context.Context (#148)