Activity
Last Week
dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines2d
Take a closer look at the 'Submit Requirements' panel, it should show that the CL currently has 3 out of 4 submit requirements satisfied. As soon as the 4th one is satisfied, it'll get auto-submitted…dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines2d
misccompile failure is not persistent and unrelated; bypassing.dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines2d
(1 comment)
Is it known to you why this doesn't seem to reproduce on builders?dmitshur commented on golang.org/x/pkgsite/internal/postgres: Apply bypassLicenseCheck to IsRedistributable column.2d
(1 comment)
(nit) Please note that the Go commit message style uses a lower case letter after the colon, and no period at the end, because it's intended to complete the sentence "This change modifie…dmitshur commented on golang.org/x/build/main.star: update security release branch pattern to match RCs4d
Thanks.dmitshur opened a change golang.org/x/build/main.star: update security release branch pattern to match RCs4d
The previous pattern 'internal-release-branch.go1.24.\d+' works for
minor releases as intended, but doesn't work for release candidates.
RCs can have PRIVATE-track security fixes included too (for ex…dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too4d
Thanks.dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too4d
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too4d
(1 comment)
Thanks. Done.dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too4d
(1 comment)
@roland@golang.org This getting pretty long, so maybe worth shortening? Dropping 'and' at least?
"go1.5rc1-go1.4.2-go1.3.2-checkpoint"
I can include some change in this CL if you prefe…dmitshur opened a change golang.org/x/build/internal/task: build internal security branch for next RC too4d
In the second half of the go.dev/s/release cycle, after entering the
release freeze and before releasing the first pre-release (RC 1), a
release branch for the next major Go release is cut.
Security…dmitshur commented on cmd/cgo/internal/testsanitizers: skip asan tests when FIPS140 mode is on4d
Yes, it's generally okay to apply test fixes during the freeze, that's a large part part of what it's for. The text fix needs to be safe, and this looks safe.dmitshur commented on encoding/json/v2: add security section to doc5d
cmd/go.TestScript/list_empty_importpath is #73976.dmitshur commented on runtime: update skips for TestGdbBacktrace6d
Thanks.dmitshur closed an issue sum.golang.org: Update hash of github.com/xmppo/go-xmpp1w
In the general case, the moment a tag is published, it's not viable to modify its contents without potentially causing problems. Instead, it's possible for you to publish a newer version that correct…Earlier
dmitshur reviewed +2 on runtime: remove arbitrary 5-second timeout in TestNeedmDeadlock1w
Thanks.dmitshur commented on runtime: TestNeedmDeadlock failures1w
The only potentially relevant recent builder change I can think of is [crrev.com/c/6641842](https://crrev.com/c/6641842) (CC @mknyszek) which rebalanced test sharding strategy for #65814. Its timing …dmitshur commented on runtime: TestNeedmDeadlock failures1w
This test has started to fail very often on the gotip-linux-arm64-asan-clang15 linux specifically recently. As visible in its [history](https://ci.chromium.org/ui/test/golang/runtime.TestNeedmDeadloc…dmitshur commented on cmd/doc: fix -http on Windows1w
(1 comment)
(minor) These 2 spaces seem out of place.dmitshur fixed an issue access: approvers1w
Hi Julian,
Thank you for contributing to the Go project, and for your work of being a maintainer of the MIPS ports. We've discussed this request on the team and agreed to grant you this access. I've…dmitshur commented on : Clang 18+ does not support the '-arch' switch (Android NDK binaries)1w
CC @golang/android.dmitshur commented on cmd/link: duplicated definition of symbol github.com/ebitengine/purego.syscall15XABI0 when running with ASAN [1.24 backport]1w
We discussed this and agreed to proceed with the backport. Thanks.dmitshur commented on runtime: [release-branch.go1.24] set mspan limit field early and eagerly1w
The were a number of errors in tests hitting the Go website because during a traffic spike. Retrying.dmitshur commented on cmd/compile: devirtualized type switch causes temporary allocation to escape1w
CC @golang/compiler.dmitshur commented on reflect: TypeAssert[T] is not identical to Interface().(T)1w
CC @golang/runtime.dmitshur commented on slices: TestIssue68488 seems sensitive to minor stack perturbations1w
CC @Jorropo, @randall77.dmitshur commented on cmd/go: go tool does not accept -mod=1w
CC @golang/command-line.dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.1w
If more time is desired and the trade-offs are appropriate, also consider the path of reverting the change that caused this regression, reopening #52745, and trying again in a future cycle.dmitshur commented on runtime: skip GDB "no such process" case1w
(2 comments)
Based on the log in the issue report, and the regexp pattern, is the missing 's' here in the commit message a typo? (Otherwise the regexp won't match.)
```suggestion
"Couldn't get NT_P…dmitshur pushed to
main in rsc.io/rf1w
dmitshur merged a change rsc.io/rf/...: fix detection of unused variable1w
dmitshur reviewed +2 on rsc.io/rf/...: fix detection of unused variable1w
The check fails for reasons unrelated to the change here. The module requires Go 1.20 but the check tries to test with Go 1.16 (which is before [go.dev/doc/toolchain](https://go.dev/doc/toolchain#sel…dmitshur pushed to
main in rsc.io/rf1wdmitshur merged a change rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile1w
dmitshur reviewed +2 on rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile1w
LGTM. Thanks.dmitshur commented on cmd/compile/internal/escape: optimization wrongly affecting panics1w
CC @golang/compiler.dmitshur commented on reflect: Value.Seq|Seq2 documentation and unexported value1w
CC @golang/runtime.dmitshur commented on doc: write release notes for Go 1.251w
The Go 1.25 release notes draft is complete by now, and there doesn't seem to be any remaining known TODOs to resolve. Thanks everyone.
It's okay for this to be open to track any further refinement …dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.1w
Pinging as this is a release blocker for Go 1.25.dmitshur commented on cmd/doc: -http fails on Windows with invalid port1w
Pinging as this is a release blocker for Go 1.25.dmitshur commented on crypto/tls: TLS handshake timeout consistently on Windows VM LTSC2019 with private IP1w
Thanks for the report. So the problem happens with the same Go program in an older Windows LTSC and doesn't happen in a newer Windows LTSC. Is the crypto/tls implementation in Go doing something diff…dmitshur commented on context: fix typo in context_test.go1w
Bypass since trybots already passed on PS 3.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1w
Thanks.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1w
(3 comments)
Hmm, this is the first time I'm encountering this suggestion. I have seen many instances of short inline comments not being a complete sentence (e.g., `N int64 // bytes remaining` rathe…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1w
Yes, I gave a heads up via chat and I saw that @adonovan@google.com gave it a thumbs up, so I think that's done (Alan, please let me know if you have questions or concerns). I'll copy from https://go…dmitshur reviewed +2 on encoding/json: use zstd compressed testdata1w
Thanks. (The cmd/go.TestScript/list_empty_importpath failure looks unrelated to the changes here.)dmitshur commented on cmd/cover: wrong coverage reported when func fields in struct1w
CC @thanm, @golang/compiler.dmitshur commented on encoding/json/v2: report error on time.Duration without explicit format1w
Indeed, Auto-Submit does what it says on the tin as soon as all submit requirements are satisfied. :) Fortunately there weren't any hidden test failures so it worked out.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1w
Friendly ping.dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv21w
Thanks.
(nit) Not a big deal, but mentioning for future reference: https://www.w3.org/TR/wasm-core-2/#wasm.
Please include something to connect this CL with a tracking issue. This is [always useful…dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv21w
Thanks.
Both forms are interchangeable and okay. This is described in a bit more detail at [go.dev/wiki/CommitMessage](https://go.dev/wiki/CommitMessage#:~:text=To%20link%20a,or%20vice%20versa.).dmitshur commented on net/http: punycode labels ending with hyphen (xn--example-) should be rejected per updated UTS-461w
Thanks for filing the issue. Someone familiar with this package may have more specific comments, but in general please see https://go.dev/doc/contribute on how to send a code change. I added a mentio…dmitshur commented on golang.org/x/sys/windows: fix filetime conversions and deprecate Nanoseconds1w
CC @golang/windows.dmitshur commented on internal/goexperiment: user facing documentation for GOEXPERIMENT points to internal source for list of supported values1w
CC @golang/command-line, @golang/runtime.dmitshur commented on runtime: passing a JS pointer to Go-Wasm runtime causes memory leak1w
CC @golang/wasm.dmitshur commented on runtime: add missing unlock in sysReserveAlignedSbrk1w
(1 comment)
Is this the right issue for this?
```suggestion
unlocked at one of the return path. Add the missing unlock.
Fixes #74339.
```dmitshur commented on cmd/go: clean doesn't respect workspace vendoring1w
CC @golang/command-line.dmitshur commented on cmd/go/internal/test: "go help testflag" refers to legacy options of pprof1w
CC @golang/command-line, @cherrymui.dmitshur commented on encoding/json/jsontext: consistently use JSON terminology1w
No legacy slowbots were requested.dmitshur commented on encoding/json/v2: report error on time.Duration without explicit format1w
No legacy slowbots were requested.dmitshur commented on encoding/json/v2: test that trybots work1w
LUCI trybots by default run a rough equivalent of all.bash on various ports. If all.bash doesn't fail for you when you run it locally, LUCI trybots shouldn't fail either.
If you'd like to have all.b…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host1w
Thanks.dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host1w
Hmm, can you confirm you’ve done this part?
> (Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving …dmitshur opened an issue cmd/go: "test timed out after ... running tests: ..." attached to one of many subtests in JSON mode, can be less visible compared to non-JSON output2w
Consider the output from `go test` without `-json` flag in a situation where a test timeout happens while multiple subtests are still running (as happened in #74279):
```sh
$ go version
go version g…dmitshur commented on golang.org/x/build/main.star: increase openbsd-amd64 timeout scaling to 42w
Thanks.dmitshur opened a change golang.org/x/build/main.star: increase openbsd-amd64 timeout scaling to 42w
Looking at recent build completion times for x_tools-gotip-openbsd-amd64
shows it often takes around 20 minutes, while x_tools-gotip-linux-amd64
often takes around 5 minutes. Even in the main Go repo…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)2w
This change is ready for review.dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
Copied Votes:
* Code-Review+1 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforcement` or `label…dmitshur starred github.com/jamesshenjian/jpegsl2w
dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
Of course. In theory you can use a regular ./make.bash and create the .tar.gz archive of the result, but it might be easier to use ./make.bash with -distpack flag—just like the real release process…dmitshur commented on github.com/shurcooL/home/internal/exp/service/activity/{github,gerrit}: walkSegMail can fail with EOF2w
There was another instance, but this time it was with a non-zero offset in the middle of a month:
```
2025/06/18 14:21:34 service/activity/github: mailLoop: walkSegMail(github.fileSeg{file:"/2025-06…dmitshur closed an issue golang.org/x/build: add longtest builder for darwin/arm642w
This is done. Closing in favor of the newer issue #73488.dmitshur fixed an issue golang.org/x/build: have darwin/arm64 builders on macOS 13 (Ventura)2w
This was done a while back ([CL 532579](https://go.dev/cl/532579)).dmitshur reviewed +2 on golang.org/x/build/internal/installer/darwinpkg: speed up find command significantly2w
Thanks.
Sounds good, it's tracked in #74287 now.dmitshur opened an issue golang.org/x/build/internal/installer/darwinpkg: unclear purpose and effect of "Fixing permissions" step during postinstall2w
The Go macOS installer currently runs a sequence of commands described as "Fixing permissions":
```bash
GOROOT=/usr/local/go
echo "Fixing permissions"
cd $GOROOT
find . -exec chmod ugo+r \{\} \;
fin…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
(Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving it a .darwin-amd64.tar.gz toolchain.)dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
It sounds like you were testing the change with a go1.24.4 toolchain. The change is set to apply on versions go1.25rc2 and newer only, so seeing the installation proceed as before is working as inten…dmitshur commented on golang.org/x/build/main.star: add dev.simd branch2w
(1 comment)
Oh, almost but not quite — it's still needed in `enabled` so that 'builders_to_trigger_after_toolchain_build' isn't set to non-existing dev.simd x/ repo builders.dmitshur reviewed +2 on golang.org/x/build/main.star: add dev.simd branch2w
(3 comments)
Yes, config groups define presubmit. But I expect we'd need to make more changes to make it useful. As is, this arch_repo_dev-simd config group matches only "internal-branch.dev-simd-.+…dmitshur commented on cmd/dist: always include variant in package names2w
It occurs to me now that one of the effects of dropping omitVariant for test directory tests is that the corresponding test ID will now always have some shard. Previously, if fixedbugs/issue68525.go …dmitshur reviewed +2 on cmd/dist: always include variant in package names2w
Thanks.
directory
I see, it's impossible to distinguish their timing. For example, if you do run both the go/version package tests as well as its racebench variant in JSON mode, you get both:
```
…dmitshur opened a change golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
Both of our installers are correctly annotated for the intended host
architecture. That is, the hostArchitectures option is set to x86_64
on .darwin-amd64.pkg installers, and to arm64 on .darwin-arm6…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: speed up find command significantly2w
(1 comment)
Whoops, the "Fixing permissions" postinstall file existed even earlier, I'm now finding CL 11970 from 2015, and it might be present in even earlier Go macOS installers. So higher chances…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: speed up find command significantly2w
Thanks for finding this and sending the CL. It does look like a good improvement.
I think it's a good time to try this for Go 1.25 since there are still opportunities to get wider signal from pre-re…dmitshur fixed an issue golang.org/x/build: gotip-linux-arm builder has no disk space left3w
I terminated the bot via swarming UI:
<img width="892" alt="Image" src="https://github.com/user-attachments/assets/21ce9cd4-5236-479d-aedd-fd341aeba18a" />
After it came back, it had a successful …dmitshur fixed an issue golang.org/x/tools: frequent out-of-memory errors on linux-arm builder3w
The Scaleway linux/arm builders are no more, and there haven't been recent reports here. If this comes up on the newer linux/arm builders, watchflakes will file a report. Closing.dmitshur starred github.com/firstrow/mcwig3w
dmitshur commented on cmd/compile: update compiler's PGO profile as part of rc1 relui flow3w
> At this point it might help to separate out work on making relui do this automatically into a dedicated x/build/cmd/relui issue, since that can happen independently of the Go release cycle.
Made #…dmitshur opened an issue golang.org/x/build/cmd/relui: update compiler's PGO profile3w
This is a tracking issue to create a task for updating the compiler's PGO profile, something that we currently typically do for every major Go release, so about once every 6 months (issue #60234).
I…dmitshur fixed an issue all: end support for macOS 11 in Go 1.253w
I think we can close this now - I'm not aware of anything more left to do for this for Go 1.25.
If there's anything still in the tree that exists only because of needing to support macOS 11, then th…dmitshur commented on cmd/dist: re-expose pack command in Go 1.253w
Thanks for the report. The corresponding release note for this is https://tip.golang.org/doc/go1.25#go-command (second paragraph, "The Go distribution will include fewer prebuilt tool binaries. …")…dmitshur fixed an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs1mo
Permission change applied.dmitshur pushed to
main in dmitri.shuralyov.com/service/change1modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y