Activity
Today
dmitshur opened a change golang.org/x/build/cmd/coordinator: add link to known issue on builders page2h
The tooltip for builders with a known issue is displayed consistently
as of the last commit, but accessing a link in a tooltip is not easy.
It's reasonable to expect that known issues would be li…dmitshur commented on golang.org/x/build/cmd/coordinator: builders with non-zero KnownIssue are not grayed out in the golang.org/x repo sections2h
Now that #34744 is complete, this became much easier. Fix for this and another issue incoming.dmitshur commented on golang.org/x/build/cmd/release: evaluate releaselets used for each upcoming major Go release3h
All looks ready for Go 1.18 Beta 1, so moving this recurring issue to the next milestone.dmitshur commented on golang.org/x/vuln/...: run checks with go test4h
(1 comment)
Longtest builders (linux-386-longtest, linux-amd64-longtest, windows-amd64-longtest) are currently configured in x/build/dashboard to primarily on post-submit, and only as TryBots (pre-s…Yesterday
dmitshur commented on net/netip: add fuzz test comparing with net.ParseIP18h
Confirmed, it should be okay and helpful!
As I understand, fuzz targets don't run automatically during all.bash, so this is really low-risk for the stability of the release.dmitshur commented on golang.org/x/build/cmd/release: evaluate releaselets used for each upcoming major Go release22h
We've discussed macOS today and agreed to use macOS 12 releaselets both for amd64 and arm64 architectures starting with Go 1.18 Beta 1. Send [CL 369958](https://go.dev/cl/369958).dmitshur opened a change golang.org/x/build/cmd/release: start using macOS 12 releaselets in Go 1.18 Beta 122h
The work to add macOS 12 builders for amd64 and arm64 was completed
ahead of Go 1.18 Beta 1, so we have the opportunity to pick between
starting to use them or stay with existing macOS 11 builders lo…dmitshur reviewed +2 on Revert "build: for default bootstrap, use Go 1.17 if present, falling back to Go 1.4"22h
+2 if it is needed, since reverting a problematic change sooner is a good step. A question in inline comment.
Also add CL number being rolled back per https://go.dev/wiki/CommitMessage#reverts.
Whi…dmitshur reviewed +1 on golang.org/x/vuln/top-level: run checks with go test23h
In general it looks great. I left a few minor comments inline, the main one being to consider skipping the test in short mode (if applicable to the needs of the test).
It may be possible to make use…dmitshur commented on golang.org/x/build: add macOS 12.0 Monterey builders (arm64/amd64)1d
> not tracking health
To expand on this, the "macOS ARM64 (M1 Mac minis)" health item in https://farmer.golang.org/#health is tracking the health of `host-darwin-arm64-12_0-toothrot` (this builder),…dmitshur commented on golang.org/x/build/dashboard: remove MallocNanoZone=0 from macOS 12 builder configuration1d
Thanks Cherry. We'll wait for the 1.17 workaround to land. I think it can be removed from builder configuration when 1.18 is released and 1.16 stops being supported. So waiting on that.dmitshur commented on build: for default bootstrap, use Go 1.17 if present, falling back to Go 1.41d
(1 comment)
Nit: s/install/download/.dmitshur commented on golang.org/x/build/cmd/coordinator: transparent TryBot retries mask stalls that should be fixed1d
> This timeout-and-retry behavior
@bcmills Is the issue here that there's an unbounded number of transparent retries, or that you consider even a bounded number of retries, like 3, problematic? (O…dmitshur reviewed +2 on golang.org/x/build/repos: turn off trybots for x/vuln1d
This change looks good if you'd like to proceed with turning off builders for x/vuln at this time. (If you'd like to re-enable it in the future, you'd just need to remove noBuildAndNoDash…This Week
dmitshur merged a change misc/cgo/testplugin: remove skip in TestIssue25756pie1d
dmitshur commented on misc/cgo/testplugin: remove skip in TestIssue25756pie1d
Ok. Everything I learned about this problem earlier showed high reproducibility, so I don't expect it to be flaky, but I'll keep an eye on it just in case.dmitshur commented on misc/cgo/testplugin: remove skip in TestIssue25756pie1d
Since the test is indeed passing on tip even on macOS 11 builder, it seems there's no good reason to have the skip anymore. (In the worst case we'll learn that it doesn't pass all the tim…dmitshur commented on misc/cgo/testplugin: remove skip in TestIssue25756pie1d
I am interested in knowing that too, but I don't have the answer yet. The commit message of CL was written optimistically in case the slowbot will pass, but I don't know yet whether it will. …dmitshur commented on misc/cgo/testplugin: remove skip in TestIssue25756pie1d
TRY=darwin-arm64-11_0-toothrotdmitshur opened a change misc/cgo/testplugin: remove skip in TestIssue25756pie1d
Though this was a problem for Go 1.17,
it appears not to be a problem on tip.
This reverts change made in CL 321349.
For #46239.dmitshur reviewed +2 on misc/cgo/testplugin: [release-branch.go1.17] skip TestIssue25756pie on darwin/arm64 builder1d
There's no good issue to backport, but if there was one, it'd be approved as a test-only fix.
Other than for potential builder name changes while 1.17 is still supported.dmitshur reviewed +2 on golang.org/x/website/...: publish all commits, eliminating Website-Publish+1 vote2d
(1 comment)
The deleted block removes with it the last remaining link to the App Engine version list in x/website.
Is it being deleted in order for that page to be intentionally de-emphasized? If s…dmitshur reviewed +2 on golang.org/x/website/_content: cancel spelling2d
(1 comment)
I don't understand why this is being added. It seems like a no-op.
If it's intentional, then it's fine.dmitshur reviewed +2 on golang.org/x/website/_content: update footer menus link to go.dev/blog2d
Now that it's available, using a relative link is an improvement here. Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/locktrigger: add fix for Cloud Build race2d
(1 comment)
The original spelling of this longer word in PS 2 was okay:
> use cancellation (two ells), not cancelation.dmitshur commented on golang.org/x/website/_content: cancel cancelling, cancelled, cancellation in favor of canceling, canceled, cancelation2d
(First pass. Will re-review after.)
'cancellation' (two ells) is right according to go.dev/wiki/Spelling.
The other ones are one ell, but this one's two ells.
Same here.
'cancelat…dmitshur merged a change golang.org/x/website/...: update deploying sections in README files2d
dmitshur reviewed +2 on golang.org/x/website/...: publish all commits, eliminating Website-Publish+1 vote2d
This change looks good to me (and I've been looking forward to getting to this point).
If I understand the plan correctly, this CL will submitted after submit (or review) access in x/website is …dmitshur commented on golang.org/x/website/cmd/locktrigger: add fix for Cloud Build race2d
Actually, the 'app deploy --no-promote' step happens before live server tests are run, so the 10th version will always be available in version list, just not auto-published. (It won't be …dmitshur reviewed +2 on golang.org/x/website/cmd/locktrigger: add fix for Cloud Build race2d
If I understand correctly, if say 10 commits land in a short enough window that their builds run concurrently, then the current use of locktrigger in cloudbuild.yaml will make it so only the last wil…dmitshur commented on golang.org/x/build/cmd/release: Go 1.14 on macOS 10.11 emits "ld: warning: object file was built for newer OSX version (10.12) than being linked (10.11)"2d
We haven't been able to find a way to reproduce this, and by now, Go 1.14 is unsupported, so I'll close this issue. If this problem occurs on supported releases of Go (1.17 and 1.16 at this time), pl…Last Week
dmitshur pushed to
master in github.com/go-gl/glfw4d
dmitshur merged a change github.com/go-gl/glfw/v3.3/glfw: add netbsd support4d
dmitshur reviewed +2 on github.com/go-gl/glfw/v3.3/glfw: add netbsd support4d
Thanks, this change looks reasonable, so I'll merge it to move it forward.
I think it's fine both to leave out `wayland` tags until they're supported, but also okay to include them proactively giv…dmitshur merged a change golang.org/x/build/dashboard: remove linux-riscv64-unleashed builder4d
dmitshur commented on crypto/x509/internal/macos: link errors on ios/arm64 due to missing symbols _SecItemExport and _SecTrustEvaluateWithError4d
Closed. Thanks very much for everyone's help resolving this.dmitshur merged a change golang.org/x/build/dashboard: clear known issue for iOS builder4d
dmitshur opened a change golang.org/x/build/dashboard: clear known issue for ios builder4d
The work needed to resolve go.dev/issue/49616 looks
to be complete, and the builder is passing reliably.
Updates golang/go#49616.dmitshur commented on crypto/x509/internal/macos: link errors on ios/arm64 due to missing symbols _SecItemExport and _SecTrustEvaluateWithError4d
With the builder updates that @changkun performed, and as of CL 368054 landing, the iOS builder is passing. If I understand correctly, there's nothing more to do for this issue, right?
If so, I'll…dmitshur reviewed +1 on net: skip IPv6-to-v4 case in TestDialerLocalAddr on certain FreeBSD builders4d
Leaving to Ian to review. Just adding a +1 because the change makes sense to me.
Since the builder variable is used only on next line and fairly short, if you haven't already considered/noticed …dmitshur reviewed +2 on golang.org/x/build/env/corellium: use go install to build buildlet4d
Thanks.
Minor nit: Markdown syntax is usually not used in Go commit messages, as mentioned at https://tip.golang.org/doc/contribute#main_content.dmitshur commented on golang.org/x/website: /blog/ should show more entries4d
If the blog entries won't be inlined, it seems reasonable to display more entries. It doesn't need to show all, since that's what https://go.dev/blog/all is for. Unless /blog simply replaces the need…dmitshur commented on golang.org/dl/...: format download progress in human readable form4d
(1 comment)
Please note that we'll also need to update our tooling that makes a release announcement tweet to be in sync, so having stable output (covered by a test) is more important.dmitshur commented on golang.org/dl/...: format download progress in human readable form4d
(2 comments)
This doesn't appear to be done. Was it accidentally missed, or would you like to take a different approach?
Given how easy it is to add a test to capture the intended output, I sug…dmitshur reviewed +2 on golang.org/x/build/cmd/relui: add cloud build configuration4d
I don't know every command/flag that's listed, but all seem reasonable.dmitshur opened a change golang.org/x/build/dashboard: remove linux-riscv64-unleashed builder5d
The builder has been missing for a number of weeks and isn't showing
signs of coming back. We have test coverage for linux/riscv64 via two
other builders, and Brad said he was happy to stop runni…dmitshur merged a change golang.org/x/build/internal/task: update for golang.org → go.dev website move5d
dmitshur forked in go.seankhliao.com/testrepo-6665d
dmitshur commented on github: two items in the issue templates list say "to report a vulnerability" 5d
> Do you know what happens if SECURITY.md file isn't present?
I checked: https://github.com/seankhliao/testrepo-666 does not have a SECURITY.md, and https://github.com/seankhliao/testrepo-666/issu…dmitshur commented on github: two items in the issue templates list say "to report a vulnerability" 5d
Thanks for reporting. Indeed.
We can either:
1. Remove the custom "Security Vulnerabilities" contact link from `.github/config.yml`:
https://github.com/golang/go/blob/c4a8550421ce16f233b48a8…dmitshur commented on golang.org/x/website/internal/redirect: add special case for /issues/new for multiple templates5d
As expected, now that CL 366736 has landed, the way GitHub handles https://github.com/golang/go/issues/new doesn't seem great, and we should probably make this change to avoid some people not see…dmitshur merged a change .github: use multiple issue templates5d
dmitshur commented on .github: use multiple issue templates?5d
I've made [CL 369154](https://go.dev/cl/369154) that adds special handling of existing `go.dev/issue/new` links for if we need it.dmitshur opened a change golang.org/x/website/internal/redirect: add special case for /issues/new for multiple templates5d
For golang/go#29839.dmitshur reviewed +2 on .github: use multiple issue templates5d
Thanks everyone for getting it to this point. Let's try it out, and go from there.dmitshur opened an issue golang.org/x/build/dashboard: remove MallocNanoZone=0 from macOS 12 builder configuration5d
The macOS 12 builder environments had `MallocNanoZone=0` added to work around #49138. This is the tracking issue to remove that workaround once it is no longer needed.
@cherrymui [CL 367916](https…dmitshur closed an issue golang.org/x/website/internal/dl: include docs on how to init datastore or memcache dependencies5d
dmitshur commented on golang.org/x/website/internal/dl: include docs on how to init datastore or memcache dependencies5d
As of [CL 362496](https://go.dev/cl/362496) (CC @rsc), a copy of live server data is embedded in the `golangorg` binary, allowing the go.dev/dl/ page to be rendered and developed locally without need…dmitshur opened a change golang.org/x/build/internal/task: update for golang.org → go.dev website move5d
Start using the new shorter go.dev domain name where applicable,
such as when making announcement tweets. The previous name will
always work too, but we want to be consistent and up to date in
our ex…dmitshur commented on golang.org/x/build/cmd/gerritbot: GitHub message sync de-duplicatation mechanism fails when Gerrit account name changes5d
The account "gobot@golang.org" has again been renamed recently (from "Go Bot" to "Gopher Robot"), so fixing this bug before the next time `gerritbot` restarts should prevent this duplicate thundering…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: create datastore connection bofore using it5d
dmitshur reviewed +2 on golang.org/x/build/cmd/release: update upload URL to go.dev5d
dmitshur commented on golang.org/x/website/...: publish all commits, eliminating Website-Publish+1 vote6d
This looks great. I will review the parent CL 368365, and then come back here.
Nit: this parenthesis is unclosed.
I think this CL deserves to include "Fixes golang/go#36707", since the late…dmitshur commented on golang.org/x/website/...: update deploying sections in README files6d
(1 comment)
Actually done in PS 5.dmitshur commented on golang.org/x/website/...: update deploying sections in README files6d
(3 comments)
I wrote this with x/website/cmd/golangorg tests in mind (since this is where the README is located), but it seems better to also include other tests in the module e.g. in x/website/inte…dmitshur commented on .github: use multiple issue templates6d
There's just one more thread to resolve, then can submit.
Rob, does that sound good and can we consider this thread resolved, or would you like further changes before we submit this?
To me it l…dmitshur commented on all: update vendored golang.org/x/tools6d
TRY=longtestdmitshur reviewed +2 on all: update vendored golang.org/x/tools6d
I confirmed that e212aff is the tip of x/tools, and changes that have landed there should be only those intended for 1.18. I'll let gri look over those, but to me it looks okay.
Visually the ven…dmitshur commented on golang.org/x/build: add macOS 12.0 Monterey builders (arm64/amd64)6d
Issue #46239 is the cause of the new macOS 12 arm64 builder [consistently failing](https://github.com/golang/go/issues/49926) on the 1.17 release branch. Interestingly, that same test is not failing …dmitshur closed an issue misc/cgo/testplugin: test failing on macOS 12 (arm64) on the 1.17 release branch6d
dmitshur commented on misc/cgo/testplugin: test failing on macOS 12 (arm64) on the 1.17 release branch6d
This is indeed the same as #46239. That test has a skip that applies to the macOS 11 builder, which explains why it only fails on the macOS 12 one, due to the different name:
```Go
if os.Getenv("…dmitshur commented on misc/cgo/testplugin: test failing on macOS 12 (arm64) on the 1.17 release branch6d
Maybe this is a duplicate of #46239.dmitshur opened an issue misc/cgo/testplugin: test failing on macOS 12 (arm64) on the 1.17 release branch6d
On the 1.17 release branch (but not the 1.16 branch nor tip), the macOS 12 (arm64) builder has been failing since it was brought up.
Failures look like:
```
--- FAIL: TestIssue25756pie (1.20s)…dmitshur merged a change misc/ios: bump min version6d
dmitshur commented on golang.org/x/website/internal/history: document Go 1.17.4 and Go 1.16.116d
(1 comment)
Correction, only applies to 1.16 here; 1.17 already has that fix since beginning and didn't need that backport.dmitshur reviewed +2 on golang.org/x/website/internal/history: document Go 1.17.4 and Go 1.16.116d
(2 comments)
I see two cmd/go changes, "fix mod_get_direct" and "forward the MallocNanoZone variable to script tests". Both of those are test fixes. We usually don't mention comp…dmitshur reviewed +2 on misc/ios: bump min version6d
dmitshur commented on cmd/link: several misc/cgo/testcshared tests failing in the linker on macOS 12 on the 1.16 release branch6d
CC @golang/release in case this is a problem with the builder itself or macOS 12.dmitshur reviewed +2 on net/http: [release-branch.go1.16] update bundled golang.org/x/net/http26d
dmitshur reviewed +2 on net/http: [release-branch.go1.17] update bundled golang.org/x/net/http26d
(1 comment)
Resolved.dmitshur commented on net/http: [elease-branch.go1.17] update bundled golang.org/x/net/http26d
It looks like something went wrong during the 'go generate -run=bundle std' step, and changes to the src/net/http/h2_bundle.go file weren't correctly generated, or weren't included in…dmitshur reviewed +1 on doc/go1.18: add net/http IDNA change6d
Thanks very much for sending this CL, and thanks for the ping.
The change looks good to me, but I'll let Damien who is more familiar with proposal #46001 or Jeremy review this.
Trivial nits: it…dmitshur commented on golang.org/x/net/idna: ToASCII() mangles long strings6d
Thanks @TimothyGu, I'll close this issue then. Please comment if we missed something here, or file a new issue if there's a new problem.dmitshur closed an issue golang.org/x/net/idna: ToASCII() mangles long strings6d
dmitshur merged a change golang.org/x/net/ipv6: [internal-branch.go1.17-vendor] OpenBSD does not appear to support multicast loopback6d
dmitshur merged a change golang.org/x/net/ipv6: [internal-branch.go1.16-vendor] OpenBSD does not appear to support multicast loopback6d
dmitshur commented on golang.org/x/net/ipv6: [internal-branch.go1.16-vendor] OpenBSD does not appear to support multicast loopback6d
(1 comment)
This change isn't needed here but is also harmless, so fine to keep.dmitshur commented on golang.org/x/net/http2: TestUnreadFlowControlReturned_Server failures with stream error "NO_ERROR" since 2021-10-05 [1.17 backport]6d
@mknyszek For visibility, the backports in x/net's internal-branch.go1.x-vendor branch will also need to make their way into the main Go repository's release-branches as described in https://go.dev/w…dmitshur commented on golang.org/x/net/ipv6: TestPacketConnReadWriteMulticast{UDP,ICMP} failing with "i/o timeout" on OpenBSD 6.8 and 7.0 [1.17 backport]6d
Approved as a test-only fix. It is needed to resolve trybot failures on release branches.dmitshur merged a change golang.org/x/build/cmd/releasebot: simplify darwin-arm64 build definition6d
dmitshur merged a change golang.org/x/build/cmd/release: revert to macOS 11 builder for 1.17, 1.16 minor releases1w
dmitshur commented on syscall: ntdll.dll errors in rtlGetNtVersionNumbers via os.StartProcess [1.16 backport]1w
@zx2c4 If you believe an existing issue should be treated as security-related, please take a look at https://go.dev/security#flagging. Thanks.dmitshur opened a change golang.org/x/build/cmd/releasebot: simplify darwin-arm64 build definition1w
We don't make Go 1.15 minor releases by now, so including the
darwin-arm64 build "for Go 1.16 Beta 1 and newer" is the same
as always including it.
Also update test coverage that the lis…dmitshur commented on golang.org/x/build/cmd/release: evaluate releaselets used for each upcoming major Go release1w
By now we have darwin builders with macOS 12 both on amd64 and arm64 architectures (#49149), though that work is still evolving. We will consider whether to use them or still use macOS 11 for buildin…dmitshur opened a change golang.org/x/build/cmd/release: revert to macOS 11 builder for 1.17, 1.16 minor releases1w
CL 365736 updated the builder to macOS 12 out of necessity, since
the macOS 11 builder was not available then. Based on discussion
since, the builder is back though in limited capacity. Continue
to u…dmitshur commented on syscall: ntdll.dll errors in rtlGetNtVersionNumbers via os.StartProcess [1.16 backport]1w
Approved as a serious problem without a workaround per discussion in a release meeting. Go 1.17 and 1.16 are both getting this fix.