Yesterday
dmitshur pushed to master in github.com/shurcooL/backlog3h
dmitshur commented on Feature: turn off gzip compression in github.com/shurcooL/vfsgen3h
> There doesn't seem to be an option to turn off automatic compression of included files. This is currently true. > gzip'ed resource that has to be decompressed on the fly Decompressed by wh…
dmitshur commented on Document SanitizedAnchorName algori… in github.com/russross/blackfriday3h
Friendly ping @rtfb, do you have a chance to review this? /cc @julieqiu I think this PR may fix the issue that you ran into.
dmitshur pushed to master in dmitri.shuralyov.com/service/change4h
42f2f11cf6af70a8447796e72fcc33f90d2829a4githubapi: add support for new 🚀 and 👀 reactions on GitHub
dmitshur pushed to master in github.com/shurcooL/issues4h
0d39520a96b794d91af341f0c4d92542b315d4d5githubapi: add support for new 🚀 and 👀 reactions on GitHub
dmitshur pushed to master in github.com/shurcooL/githubv44h
d9689b59501712371c702f54e9573531888d52feregenerate for schema changes by 2019-01-18
dmitshur commented on wiki: keeping a check on wiki page … in github.com/golang/go11h
That's my understanding. I think it'll be nice if each page is grouped in a email thread. That means using the same email title. Using the page title both for "page created" and "page edited" even…
dmitshur commented on wiki: keeping a check on wiki page … in github.com/golang/go12h
I think we should take a first step of making it possible to subscribe/watch for wiki page creation/edits, before considering adding barriers to wiki page edits. We currently have a [golang-codere…
This Week
dmitshur commented on wiki: CodeReviewComments: change "n… in github.com/golang/go1d
> I really really wish there were some way to get notified on each change to the wiki. @ianlancetaylor How would you like to receive notifications? Each change to all pages, or only particular pages?
dmitshur commented on x/build/cmd/gerritbot: TestCommitMe… in github.com/golang/go1d
I believe this was fixed in [CL 157440](https://golang.org/cl/157440). Is this failure from [CL 152037](https://golang.org/cl/152037)? I think you need to rebase it on top of latest master. See https…
dmitshur commented on x/tools/go/packages: TestLoadImport… in github.com/golang/go2d
[CL 156977](https://golang.org/cl/156977) has fixed the issue for s390x as well. It must've been using a custom GOCACHE all along, before all the other environments started to as well. Thank you @…
dmitshur commented on html/template: escapeTemplate cause… in github.com/golang/go2d
> I think this issue became about fixing bug in html/template package now. I've updated the title and labels to reflect that. The specific line the issue title refers to is: https://github.c…
dmitshur commented on Is this still an active project? Wh… in github.com/shurcooL/Go-Package-Store3d
Go Package Store a web app only. It uses a browser to display the available updates using HTML.
dmitshur commented on Is this still an active project? Wh… in github.com/shurcooL/Go-Package-Store4d
Yes, I use Go Package Store weekly and actively maintain it. Adding support for Go modules is issue #92. I plan to do it. I suggest you add a :+1: reaction there and subscribe to the issue for furth…
dmitshur commented on Add support for Go modules. in github.com/shurcooL/Go-Package-Store4d
I plan to implement Go module support in Go Package Store during this year.
dmitshur commented on Update to newest "golang.org/x/mobi… in github.com/goxjs/gl4d
> Thanks for the fast answer. I'm currently working on a small engine and decided to use x/mibile/gl for now. > > But once I'm confident enough in that project to add WebGl support, I wouldn't mind s…
dmitshur commented on x/build/app: deleted security branc… in github.com/golang/go4d
There's no underlying issue in `maintner` because the build dashboard doesn't use it. The code that figures out the branches is [here](https://github.com/golang/build/blob/d960d82cca8060854d705031…
dmitshur commented on Update to newest "golang.org/x/mobi… in github.com/goxjs/gl4d
Thanks for your interest in this package. The upstream `golang.org/x/mobile/gl` has indeed made some internal changes since the fork point, the major one being the render-thread you mentioned. I do…
dmitshur pushed to master in dmitri.shuralyov.com/website/gido4d
b24489fd4afe39909a4c80487cc711ef50c496d7add support for import path patterns
2378d509cdc3e6c1b27098cbc028973cdd3c186cfactor out common components from issues/changes pages
dmitshur commented on github: delete the GoCommand label in github.com/golang/go5d
https://groups.google.com/d/msg/golang-dev/nVS0dutRTy0/32Gq9omVCwAJ may be relevant. For example, it's now possible to view all x/build issues via [goissues.org/golang.org/x/build/...](https://goi…
Last Week
dmitshur commented on go/packages: use GOROOT to determin… in github.com/golang/tools6d
Copying my message from [Gerrit](https://go-review.googlesource.com/c/tools/+/128295/6#message-a2d06060cff5225336039c5b67eca2508537544f) here, since gerritbot didn't (but it will after golang/go#2885…
dmitshur commented on all: Go 1.12beta2 release status in github.com/golang/go1w
The announcement has been made: https://groups.google.com/forum/#!msg/golang-announce/QsjKbyHTaa8/EGP_u0-_EQAJ. A tweet has been tweeted: https://twitter.com/golang/status/1083529360798302210. …
dmitshur commented on all: Go 1.12beta2 release status in github.com/golang/go1w
## Latest build: go1\.12beta2 src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.12beta2/go1.12beta2.src.tar.gz)) linux\-386 ([tar\.gz](https://golang-release-staging.storage.…
dmitshur commented on all: Go 1.12beta2 release status in github.com/golang/go1w
## Log 2019/01/10 15:21:10 starting 2019/01/10 15:21:10 working in /Users/dmitshur/go-releasebot-work/go1.12beta2 2019/01/10 15:21:10 $ git clone https://go.googlesource.com/go /Users/d…
dmitshur commented on all: subrepos need to be green in github.com/golang/go1w
Subrepos are green on [first-class ports](https://build.golang.org/#short), other than #29660 (x/tools failure on s390x) and #17538 (x/text failure on s390x). That's green enough for Go 1.12 RC 1,…
dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1w
golang.org has been redeployed with the fix. For example, https://golang.org/cl/157099 now displays a disambiguation page rather than immediately redirecting to Rietveld CL 157099, since a CL with…
dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1w
Reopening for deploy of golang.org with the fix applied.
dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1w
@gopherbot Please backport to Go 1.11.
dmitshur commented on x/build/env: run more tests in js-w… in github.com/golang/go1w
Ok. I'll try to look for when a `numTryTestHelpers` value has changed and see how it affected corresponding trybot/post-submit times. For js-wasm trybots specifically, I can't predict how the exec…
dmitshur commented on cmd/compile: confusion between vari… in github.com/golang/go1w
@aclements @ianlancetaylor This issue is currently labeled release-blocker with milestone Go 1.12. I can't tell whether it's meant to be a blocker for the final Go 1.12 release, or also for Go 1.12 R…
dmitshur commented on doc, x/tools/cmd/godoc: move golang… in github.com/golang/go1w
We already have the [`golang.org/x/tools/godoc`](https://godoc.org/golang.org/x/tools/godoc) package, which is documented as: > Package godoc is a work-in-progress (2013-07-17) package to begin spli…
dmitshur commented on x/build/env: run more tests in js-w… in github.com/golang/go1w
This sounds like a good idea, in order to catch issues like this in the future during trybot runs. @bradfitz The js-wasm builder currently has `numTryTestHelpers` set to [4](https://github.com/gol…
dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1w
We just hit this again in https://github.com/golang/go/issues/29633 for CL 157099, which exists both in Gerrit and Rietveld. There are 837 more numbers [that follow](https://go-review.googlesource.co…
dmitshur commented on runtime: js-wasm build broken in github.com/golang/go1w
> We could shard the js-wasm builder out wider and enable more tests. That sounds like a good idea, in order to catch issues like this in the future during trybot runs. The js-wasm builder curr…
dmitshur commented on crypto/x509: root_cgo_darwin and ro… in github.com/golang/go1w
Latest tip (commit 99ea99ec4c) passed on my personal Mac with macOS Mojave 10.14.2 (18C54). <details><br> ``` $ ../bin/go version go version devel +99ea99ec4c Wed Jan 9 14:49:46 2019 +0000 da…
dmitshur commented on x/build/cmd/gopherbot: gopherbot cl… in github.com/golang/go1w
> Gopherbot should only close the issue if the "Fixes #" label exists in the commit message. That makes sense. It shouldn't close when it says "Updates #nnn". Gopherbot checks only if the issue…
dmitshur commented on x/build/cmd/gopherbot: close-cherry… in github.com/golang/go1w
I've redeployed `gopherbot` with the fix.
dmitshur commented on module-aware building in github.com/gopherjs/gopherjs1w
I do plan to raise that issue. I’ve already written a draft and got Pail’s initial feedback on it. What’s left for me to do is work through the feedback and make the issue. Paul has suggested I…
Earlier
dmitshur commented on x/website: plain text file renderin… in github.com/golang/go2w
As noted by @bradfitz, this doesn't seem to affect rendered .go files. There is no leading tab character inserted in HTML on pages like https://golang.org/src/net/http/server.go: <img src="https:/…
dmitshur commented on x/build/cmd/coordinator: subrepo tr… in github.com/golang/go2w
This is worse than I originally understood, because trybots are not just testing the security release-branches in addition to normal release-branches, but rather _only_ the security release-branches.…
dmitshur commented on Fix passgo generate to generate pro… in github.com/ejcx/passgo2w
Thanks for working on this. At a high level, the new approach makes sense, and I agree that this is an improved user experience. I haven’t had a chance to review thoroughly, but from a quick rea…
dmitshur commented on generate: Sometimes generates longe… in github.com/ejcx/passgo2w
Understandable. I think rephrasing the documentation as I suggested at the bottom of https://github.com/ejcx/passgo/issues/52#issuecomment-445480407 would be helpful. Trying more than once isn'…
dmitshur commented on Doesn't build in projects that use … in github.com/shurcooL/github_flavored_markdown2w
@victorshinya There are no updates on this as far as I know. My suggested workaround would be to use [Go modules](https://golang.org/doc/go1.11#modules) that were added in Go 1.11. This package full…
dmitshur commented on Add HTMLDialogElement, HTMLPicture… in github.com/dominikh/go-js-dom2w
Thanks for working on this. I wanted to check if you had a need or use case for these, or if you were adding them just because they're missing? The general practice for this package to add support…
dmitshur commented on x/build/cmd/coordinator: subrepo tr… in github.com/golang/go2w
> Or delete the security branch altogether? We did delete them in the canonical repository (i.e., https://go.googlesource.com/go/+refs). However, it continues to show up in the GitHub mirror repos…
dmitshur commented on x/build/cmd/gitmirror: deleted bran… in github.com/golang/go2w
This is happening for deleted branches too. E.g., `release-branch.go1.11-security` was deleted from x, but it's present in the GitHub mirror, even after being manually deleted one time from the GitHu…
dmitshur pushed to master in github.com/shurcooL/home2w
abbc719fee536a7ad933889c06e2943887ebd16fabout: 2019 is the Year of the Gopher
dmitshur pushed to master in github.com/shurcooL/issuesapp2w
b8198a402c581382e6abf4459148a0df1fbe326fhttpclient: Remove unnecessary conversion from ExampleIssues_Count.
a359f164dfa502a21cdc4cc3582a5b4221308d2acomponent: Display Event.Rename.From with a line-through effect.
dmitshur pushed to master in github.com/shurcooL/graphql2w
d48a9a75455f6af30244670bc0c9d0e38e7392b5internal/jsonutil: Skip unexported fields.
dmitshur starred github.com/rwcarlsen/goexif2w
dmitshur pushed to fix_panic_with_unexported_fields in github.com/shuheiktgw/graphql2w
60e006b4497879c94c872c8dc547d6616fb6e0b5internal/jsonutil: Skip unexported fields.
dmitshur commented on Fix not to panic when struct contai… in github.com/shurcooL/graphql2w
Hi @shuheiktgw, Thanks for the PR. In order to proceed here, we need a decision on #36. I've made one in https://github.com/shurcooL/graphql/issues/36#issuecomment-450455656 and it's compatible wi…
dmitshur commented on Using unexported field in query res… in github.com/shurcooL/graphql3w
> This is a valid bug. I'll need to think how to best handle such a situation: > > 1. `encoding/json` package simply skips unexported fields, and I could do that here too. > 2. An alternative is …
dmitshur commented on Idea: image generation in github.com/russross/blackfriday3w
> could this curly bracket notation be parsed through a custom renderer? I don't see why not. > This also raises security concerns since the renderer is going to be executing arbitrary code in the …
dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3w
@SamWhited I've made a [v1.0.0](https://github.com/shurcooL/sanitized_anchor_name/releases/tag/v1.0.0) tag, so anyone using this package with Go modules should see something like this in their go.mod…
dmitshur commented on Tag a 1.0.0 release in github.com/shurcooL/sanitized_anchor_name3w
I've done so now. https://github.com/shurcooL/sanitized_anchor_name/releases/tag/v1.0.0
dmitshur created tag in github.com/shurcooL/sanitized_anchor_name3w
v1.0.0
dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3w
I understand. Thank you again!
dmitshur pushed to gomod in github.com/SamWhited/sanitized_anchor_name3w
65809d0b872c67c41327c348df3b38389e58bc8aRemove go directive from go.mod.
dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3w
The change I requested was to remove the go directive, but the latest commit changes its value from 1.9 to 1.12 instead. I'll make the change myself to save on the extra latency introduced by round-t…
dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3w
Thanks. There's not a lot of information there to give me an understanding of the implications of using that directive and its different values. There's more information about it at https://github…
dmitshur commented on Document SanitizedAnchorName algori… in github.com/russross/blackfriday3w
/cc @SamWhited FYI, you might enjoy this change. :)
dmitshur created branch in github.com/russross/blackfriday3w
v2-port-352
dmitshur pushed to fix-own-misspellings in github.com/dmitshur/misspell3w
dmitshur opened a change in github.com/client9/misspell3w
dmitshur created branch in github.com/dmitshur/misspell3w
fix-own-misspellings
dmitshur commented on Things to forward port from v1 to v2 in github.com/russross/blackfriday3w
This isn't done; those are three v1 PRs that need to be ported to v2. I'll work on #352 now.
dmitshur pushed to master in github.com/shurcooL/home3w
e3254af305572bce7798a62a20a19271f97f0e75Switch to github.com/google/uuid dependency.
2ed0895ba03c63267e82479c8cb44ed097e73345Set charset=utf-8 in POST /action/new-repo handler.
dmitshur pushed to master in github.com/shurcooL/reactions3w
dmitshur commented on x/build/maintner: reports inconsist… in github.com/golang/go3w
@andybons That sounds like a valid issue that is related, but not the same as this one. I see these two issues: 1. short windows of time where world state is inconsistent due to separate sources o…
dmitshur pushed to master in github.com/shurcooL/octicon3w
dmitshur closed an issue in github.com/shurcooL/octicon3w