Activity
Today
dmitshur commented on access: approvers1h
Hi @HeliC829, you recently sent a GitHub request to join the [golang/riscv64](https://github.com/orgs/golang/teams/riscv64) maintainer team. As suggested at https://go.dev/wiki/PortingPolicy#requirem…dmitshur reviewed +1 on github.com/fflewddur/ltbsky: Avoid logging arbitrary length byte slice2h
Thanks.dmitshur fixed an issue golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4336.yaml failures3h
Fixed in [go.dev/cl/741780](https://go.dev/cl/741780).dmitshur fixed an issue golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4336.yaml failures3h
Fixed in [go.dev/cl/741780](https://go.dev/cl/741780).dmitshur fixed an issue golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4335.yaml failures3h
dmitshur fixed an issue golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4335.yaml failures3h
Fixed in [go.dev/cl/741780](https://go.dev/cl/741780).dmitshur commented on golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4335.yaml failures3h
Fixed in [go.dev/cl/741780](https://go.dev/cl/741780).dmitshur fixed an issue golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4334.yaml failures3h
Fixed in [go.dev/cl/741780](https://go.dev/cl/741780).dmitshur commented on golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4334.yaml failures3h
Fixed in [go.dev/cl/741780](https://go.dev/cl/741780).dmitshur commented on golang.org/x/build/cmd/watchflakes: factor log.Fatal out of LUCIClient.GetBuildResult3h
Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes: update ResultDB host for January 2026 change3h
Thanks.dmitshur opened a change golang.org/x/build/cmd/watchflakes: factor log.Fatal out of LUCIClient.GetBuildResult5h
Make some progress on removing log.Fatal calls from inner functions,
in favor of returning an error to the caller and doing log.Fatal in
main. This will help eventually retry more retryable errors wi…dmitshur opened a change golang.org/x/build/internal/relui: fix BaseLink to keep RawPath in sync with Path5h
The custom functionality to prepend an optional base URL to a target URL
implemented in BaseLink involves modifying the Path field. To avoid
disrupting what the EscapedPath method returns, it's neces…dmitshur commented on golang.org/x/build/internal/task: use authentication for Gitiles in RealGerritClient5h
Thanks.dmitshur commented on golang.org/x/build/cmd/relui: automate upstreaming private-track security fixes on release day5h
Thanks.
So far we had a chance to try out the "nothing to upstream" path and that worked without uncovering anything new. We'll try the "1+ CL to upstream" path when it comes up next and adjust as n…Yesterday
dmitshur commented on golang.org/x/pkgsite-metrics/...: add codereview.cfg21h
Thanks.dmitshur commented on golang.org/x/vuln/...: add codereview.cfg21h
Thanks.dmitshur commented on golang.org/x/pkgsite/...: add codereview.cfg21h
Thanks.dmitshur commented on golang.org/x/website/_content/blog: add Go 1.26 release post22h
(2 comments)
The Go 1.25 blog post didn't link to https://go.dev/doc/go1.25#language because there weren't notable language changes, but I agree it's worth at least including a link to https://tip.g…dmitshur commented on rsc.io/rf/...: allow for custom go executable23h
Thanks for considering this.
As mentioned in https://github.com/rsc/rf/issues/16#issuecomment-812623872, I think it's generally expected that tools working on packages in GOROOT need to use the co…dmitshur commented on golang.org/x/build: add LUCI aix-ppc64 builder23h
As I understand that PR applied the fix to the v4 major version of badger, but cas currently uses v3. That means either the badger fix needs to also be backported to its v3, and cas updated to that, …dmitshur commented on rsc.io/rf/...: allow for custom go executable1d
I wanted to ask what's the motivation to add a flag for this? There have been proposals in the past in the main Go project to add alternative ways to specify the go command to use, such as golang/go#…dmitshur reviewed +1 on github.com/fflewddur/ltbsky: Extend error handling1d
Looks good, one inline comment.
"%+v" on `img` as is might create excessively verbose errors due to its [`Bytes []byte`](https://github.com/fflewddur/ltbsky/blob/9a65bc6aa513f18bb638c208c9187f8da33c…dmitshur commented on rsc.io/rf: rf fails with spurious type errors when refactoring projects with complex dependencies1d
Thanks for filing this issue and sending a fix @jitsu-net!
I tried doing a brief refactor in x/build again with the latest rf version, and can confirm it worked without errors this time. So I think …dmitshur fixed an issue rsc.io/rf: mv broken1d
dmitshur commented on golang.org/x/website/_content/blog: add Go 1.26 release post1d
(1 comment)
As far as I can tell both [crypto/mlkem/mlkemtest](https://pkg.go.dev/crypto/mlkem/mlkemtest?tab=versions) and [testing/cryptotest](https://pkg.go.dev/testing/cryptotest?tab=versions) pa…dmitshur reopened an issue golang.org/x/build/cmd/relui: simplify HTTP route handling code by using net/http's pattern matching1d
dmitshur reopened an issue golang.org/x/build/cmd/relui: simplify HTTP route handling code by using net/http's pattern matching1d
dmitshur commented on golang.org/x/build/cmd/relui: simplify HTTP route handling code by using net/http's pattern matching1d
> Also noting here that some of the route registration uses task names, which we've recently realized may contain "/" characters, and those will need some thought to handle.
This was intended to be …dmitshur commented on github: switch "what did you expect to see" and "what did you see instead"1d
CC @adonovan.This Week
dmitshur commented on time: document that Ticker.Reset can be called after Stop1d
(1 comment)
The fact the channel is reused seems more like an internal implementation detail that is secondary to the fact that calling Reset after Stop is permitted. Perhaps it'd be better not to m…dmitshur reviewed +2 on time: mention Reset in Ticker.Stop doc1d
Thanks.dmitshur commented on golang.org/x/website/_content/doc/go1.26: fix typo in slog.MultiHandler doc1d
(1 comment)
```suggestion
Its `Handle`, `WithAttrs` and `WithGroup` methods call the corresponding method
```dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.26: fix typo in slog.MultiHandler doc1d
Thanks.dmitshur reviewed +2 on log/slog: correct method name in MultiHandler docs1d
Thanks.
Let's also fix WithAttrs since it's nearby.
```suggestion
// Its Handle, WithAttrs and WithGroup methods call the corresponding method on each of the enabled handlers.
```dmitshur reviewed +2 on golang.org/x/website/internal/history: document Go 1.25.7 and 1.24.131d
Thanks.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: switch to ufs image1d
Well, it was worth a try. Thanks.dmitshur commented on golang.org/x/build/main.star: remove linux-amd64-spectre known issue2d
Just checking, is it expected this builder would not have caught the issue reported in #77420, but rather it's intended to check for easier-to-catch problems that may come up in the future?
Asking b…dmitshur reviewed +2 on golang.org/x/build/main.star: finish upgrading freebsd-amd64 to FreeBSD 14.32d
Thanks.
A single passing commit across all repos seems pretty good signal for a 14.2 -> 14.3 change, so I suspect it's fine to move ahead without much waiting.dmitshur reviewed +2 on golang.org/x/build/main.star: add freebsd-amd64_15.0 builder2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add spectre builder2d
Thanks. It'll be interesting to see the 'go env -changed' output on the builder.dmitshur reviewed +1 on internal/runtime: fix assembly for spectre retpoline instrumentation2d
(1 comment)
Thanks for catching that and improving their name. Including it in this CL seems fine.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add 15.02d
dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add 15.02d
Thanks.
Not a big deal to leave these on older version. That said, if you want, consider updating them:
```suggestion
./make.bash 15.0
After it completes, it creates a file freebsd-amd64-150.t…dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: don't restart buildlet on exit2d
Thanks.dmitshur commented on crypto/tls: revalidate whole chain on resumption on Windows and macOS2d
(1 comment)
I might've overlooked something, but to check here, can this condition be true? Since i is ranging over chain[1:], at [first glance](https://go.dev/play/p/5ZViTX7tvUY) it seems it might …dmitshur commented on golang.org/x/build: bot linux-s390x-ibm--02 reported as broken2d
Thanks for looking into this.
From looking at the list of bots connected to LUCI at https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Alinux-s390x&f=pool%3Aluci.golang.shared-workers, it d…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder2d
Thanks for requesting to add a builder to test the linux/mipsle port (CC @golang/mips). There's also issue #67304 tracking this. Is this meant to be an additional builder?
CC @golang/release, @pratt…dmitshur commented on os: File.Close hangs with concurrent I/O on Windows using go1.26rc2 [1.26 backport]2d
CC @prattmic.dmitshur reviewed +2 on golang.org/x/mobile/bind: support go/types.Alias2d
Looks good to me, though the go/types API and best practices for code that needs to handle aliases isn't something I've looked into closely. Someone more familiar (@adonovan@google.com maybe) might b…dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add 14.32d
Thanks.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add doas configuration2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add freebsd-amd64_14.3 builder2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: remove freebsd-amd64_14.1 builders2d
Thanks.
I think I tried to use the 14.1 builders to iterate a bit on that issue with the builders not cleaning up after themselves on termination requests or so. Does that work fine now?
If not, ma…dmitshur commented on golang.org/x/website/internal/web: do not treat Markdown files as templates by default3d
Missed this thread, so marking it as resolved too. Thanks again.dmitshur reviewed +2 on golang.org/x/website/internal/web: do not treat Markdown files as templates by default3d
Thanks.
Thanks. For reference, in case it comes in handy later, note that there's a bit more information about tests for x/website/cmd/golangorg in its [README](https://cs.opensource.google/go/x/web…dmitshur commented on internal/poll: readWriteUnlock should destroy fd when no remaining references3d
Minor comments on the test; otherwise leaving this to Damien to review. Thanks.
https://pkg.go.dev/testing#T.Fatal's "FailNow must be called from the goroutine running the test or benchmark function…dmitshur commented on cmd/go: add 'go test -cachelink' boolean flag3d
@bradfitz@golang.org Please note that the Run-TryBot+1 by now is meant only when looking to trigger legacy slowbots. Otherwise there aren't any trybots that run in its default set. So in most CLs lik…dmitshur commented on net: don't wait 5 seconds to re-read /etc/resolv.conf4d
There weren't any legacy slowbots requested, so Run-TryBot+1 isn't doing anything except blocking submission. Dropping it.Last Week
dmitshur commented on cmd/go: repository URL resolution behavior doesn't match documentation6d
CC @golang/command-line.dmitshur commented on golang.org/x/tools/go/analysis/passes: fix buf.WriteString(x + y) to the more efficient buf.WriteString(x); buf.WriteString(y)6d
CC @adonovan.dmitshur commented on cmd/go: `go tool` and `go get -tool` could be documented better6d
CC @golang/command-line.dmitshur commented on golang.org/x/website: code in README.md is excessively HTML escaped1w
@qrasick I should be able to review it by tomorrow. From an early look, it looked good. Thanks for preparing it.dmitshur commented on doc: write release notes for Go 1.261w
The Go 1.26 release notes draft seems ready. It's okay for this issue to stay open to track any further refinement and improvement leading up to the release, but removing the release-blocker label si…dmitshur fixed an issue cmd/go: unexpected code execution when invoking toolchain (CVE-2025-68119) [1.24 backport]1w
Closed by merging [CL 739421](https://go.dev/cl/739421) (commit 73fe85f0ea1bf2cec8e9a89bf5645de06ecaa0a6) to release-branch.go1.24.dmitshur commented on cmd/go: unexpected code execution when invoking toolchain (CVE-2025-68119) [1.24 backport]1w
Closed by merging [CL 739421](https://go.dev/cl/739421) (commit 73fe85f0ea1bf2cec8e9a89bf5645de06ecaa0a6) to release-branch.go1.24.dmitshur closed an issue cmd/go: TestScript/build_plugin_reproducible failures [consistent failure]1w
Merging into #77350.dmitshur commented on lib/time: update tzdata before release1w
2025c still remains the latest available, and with Go 1.26 RC 3 planned for next week, Go 1.26.0 soon thereafter, moving this to the next milestone. We can always revisit if applicable.dmitshur commented on plugin: unrecognized failures [consistent failure]1w
@ianlancetaylor mailed [CL 739681](https://go.dev/cl/739681) for this. (CC @cherrymui.)Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change8modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.