Activity
Today
dmitshur opened a change golang.org/x/build/internal/workflow: preserve prefix in Definition.shallowClone23m
It seems this was missed in the initial implementation of expansions,
but we never noticed until CL 541379 started using them for advisory
builders in minor release workflows.
For golang/go#63147.Yesterday
dmitshur commented on all: announce end of support for old Linux versions16h
Thanks for the suggestion above.
We've entered the release freeze for 1.22 and there aren't announcements to make for this release, moving to the next for now.dmitshur reviewed +2 on golang.org/x/build/internal/relui: add task to update test repo with go release16h
Thanks.
Same suggestion here:
```suggestion
wf.Task1(wd, "update-proxy-test", version.UpdateProxyTestRepo, published)
```
Since the `currPublished` Value is already an input to `UpdateProxyTest…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle17h
[CL 546055](https://go.dev/cl/546055) did the start-of-freeze update for the 1.22 cycle.
Moving to the Go 1.23 milestone and adding early-in-cycle.dmitshur closed an issue : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.2017h
The revert was done in [CL 545995](https://go.dev/cl/545995).
This wasn't caught via LUCI trybots because we have only setup Windows 10, not older, in it so far. See [here](https://cs.opensource.g…dmitshur closed an issue crypto/rand: Legacy RtlGenRandom use on Windows [1.20 backport]17h
This cherry-pick doesn't apply to Go 1.20 because it supports older Windows versions where ProcessPrng isn't available. The change was rolled back in [CL 545995](https://go.dev/cl/545995). Re-closing…dmitshur opened a change all: update vendored dependencies18h
The Go 1.22 code freeze has recently started. This is a time to update
all golang.org/x/... module versions that contribute packages to the
std and cmd modules in the standard library to latest maste…dmitshur reviewed +2 on Revert "[release-branch.go1.20] crypto/rand: switch RtlGenRandom for ProcessPrng"18h
TestCancelRequestWithChannelBeforeDo_Cancel failure looks like another instance of #59494. TryBot-Result+1 means it passed on Windows 7, the important bit.
I think you can rearrange this:
```
[rele…dmitshur closed an issue access: request to add myself as a member to port-maintainers/s390x team.18h
Glad this is sorted out. Thank you for your help maintaining the s390x architecture.dmitshur reviewed +2 on Revert "[release-branch.go1.20] crypto/rand: switch RtlGenRandom for ProcessPrng"18h
Thanks.
Please edit the description to add the Gerrit CL number being rolled back next to or instead of the Git revision number. (https://go.dev/wiki/CommitMessage#reverts)dmitshur commented on net/http: context deadline can cause surprising errors19h
CC @neild.dmitshur commented on : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.2019h
Go 1.20 is the last release that still supports Windows 7 and up (https://go.dev/doc/go1.20#windows), whereas Go 1.21 started to require Windows 10/Windows Server 2016 and higher (https://go.dev/doc/…dmitshur commented on : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.2019h
Two differences I'm spotting to note:
1. In old infra, go1.20.6 is being used as the bootstrap version. In LUCI, go1.17.13 is the bootstrap version, which is the minimum required for Go 1.20.
2…dmitshur opened an issue : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.2019h
From https://build.golang.org/?branch=release-branch.go1.20:
<img width="272" alt="image" src="https://github.com/golang/go/assets/1924134/c82df06a-fa07-4cca-930f-b297eb3b9f69">
Starting with […dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.21h
> Yes.. I requested the golang organization request and I am part of that now..
Can you share a screenshot of what that looks like from your end? Is "Vishwanatha-HD" the right username? I'm not se…dmitshur commented on crypto/x509: using a parsed certificate as a Template and clearing PolicyIdentifiers might not remove them21h
This is currently a blocker for the RC 1, scheduled in about two weeks. Can someone from @golang/security take a look. Thanks.dmitshur commented on internal/trace/v2: TestTraceStacks failures with `inconsistent status`21h
This is currently a blocker for the RC 1, scheduled in about two weeks. What is the latest status here?dmitshur commented on golang.org/x/crypto/x509roots/fallback: update bundle22h
Friendly ping @roland@golang.org. Unless it's intended for this CL to be waiting.dmitshur commented on golang.org/x/debug/cmd/viewcore: viewcore panic:Error while trying to run command "histo --top 10": runtime error: integer divide by zero22h
Thanks for reporting. Does this also happen with Go 1.21 or 1.20? Go 1.19 is not supported.
CC @golang/runtime.dmitshur commented on cmd/cgo/internal/test: consistently failing with `segmentation fault` on `linux-arm-aws` since CL 54527722h
CC @golang/compiler.dmitshur commented on debug/elf: slice out of bounds in DynValue22h
CC @golang/compiler.dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.22h
Hmm, I'm not entirely sure about GitHub invitation process details. Perhaps you need to accept the golang organization invite first, which will then enable you to join the team? If that doesn't work,…dmitshur closed an issue cmd/compile/internal/base: GODEBUG=zerocopy=0 tag doesn't seem to work22h
dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.22h
The GitHub team https://github.com/orgs/golang/teams/s390x is where I've sent the invite.
It currently shows "1 pending member", and your GitHub account is listed:
<img width="577" alt="image" sr…dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.23h
Thanks, I've sent a pending invitation to rejoin that you'll need to accept.This Week
dmitshur opened a change golang.org/x/build/main.star: add netbsd-arm, netbsd-arm64, openbsd-riscv64 builders1d
For golang/go#63698.
For golang/go#63614.
For golang/go#64176.dmitshur commented on golang.org/x/build: add LUCI linux-riscv64 builder1d
It looks like the builder has passed some times by now, e.g., there are recent "SUCCESS" entries at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-riscv64 and https://ci.chromium.org/ui/…dmitshur commented on debug/elf: viewcore cannot read s390x z/Linux Go coredump: decoding dwarf section info at offset 0x0: too short1d
CC @golang/s390x, @golang/compiler.dmitshur commented on golang.org/x/sys/unix: Missing Netfilter and NFTables constants1d
CC @tklauser, @golang/runtime.dmitshur commented on cmd/compile/internal/base: GODEBUG=zerocopy=0 tag doesn't seem to work1d
CC @golang/compiler.dmitshur commented on golang.org/x/build/main.star: fix console_ids for dl and protobuf repos1d
Thanks.dmitshur opened a change golang.org/x/build/main.star: fix console_ids for dl and protobuf repos1d
CL 539280 changed console names in order to improve their sort order,
but missed one more place that needed updating.dmitshur reviewed +2 on runtime: [release-branch.go1.21] call enableMetadataHugePages and its callees on the systemstack1d
dmitshur commented on sort: add available godoc link1d
Thanks.dmitshur reviewed +2 on cmd/compile: [release-branch.go1.21] fix findIndVar so it does not match disjointed loop headers1d
(1 comment)
Done in PS 2.dmitshur commented on cmd/compile: [release-branch.go1.20] fix findIndVar so it does not match disjointed loop headers1d
(1 comment)
Done in PS 3.dmitshur commented on cmd/go: TestScript/cgo_stale_precompiled fail in windows with clang 14.0.61d
CC @golang/windows, @bcmills.dmitshur reviewed +2 on cmd/compile: [release-branch.go1.20] fix findIndVar so it does not match disjointed loop headers1d
dmitshur reviewed +2 on golang.org/x/build/Revert "main.star: unpin golangbuild and clean up"2d
Thanks.dmitshur reviewed +2 on cmd/compile: fix findIndVar so it does not match disjointed loop headers2d
dmitshur reviewed +2 on cmd/compile: fix findIndVar so it does not match disjointed loop headers2d
Thanks.
Please add "[release-branch.go1.20]" prefix to the CL subject, since this is CL targets that branch.
It looks like #59494.
I'll also rebase this so that the fix for #63988 is included.dmitshur reviewed +2 on cmd/compile: fix findIndVar so it does not match disjointed loop headers2d
Thanks.
Please add "[release-branch.go1.21]" prefix to the CL subject, since this is CL targets that branch.dmitshur reopened a change path/filepath: [release-branch.go1.20] consider \\?\c: as a volume on Windows2d
dmitshur commented on path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows2d
Gerrit wouldn't let me create a new CL with the same Change-Id value, so I reopened and reused this one.dmitshur reopened a change path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows2d
dmitshur commented on path/filepath: Clean removes ending slash for volume on Windows in Go 1.21.42d
Minor releases are planned for the beginning of each month. I expect the next month's (December) minor releases to follow that pattern.dmitshur closed a change : Test HTTP Concurrency2d
Thanks for trying to prepare a cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at th…dmitshur closed a change path/filepath: [release-branch.go1.20] consider \\?\c: as a volume on Windows2d
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur closed a change path/filepath: [release-branch.go1.20] consider \\?\c: as a volume on Windows2d
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur closed a change path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows2d
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur closed a change path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows2d
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur reviewed +2 on golang.org/x/build/main.star: unpin golangbuild and clean up2d
Looks good to try again. Thanks.dmitshur commented on maps: inconsistent panic in Copy with nil dst2d
CC @eliben, @Deleplace.dmitshur commented on runtime/coverage: covcounters not written in -buildmode=c-shared2d
CC @thanm.dmitshur reviewed +2 on golang.org/x/build/Revert "main.star: unpin golangbuild and clean up"2d
dmitshur reviewed +2 on golang.org/x/build/Revert "main.star: unpin golangbuild and clean up"2d
dmitshur commented on golang.org/x/crypto/ssh: wrap errors from client handshake2d
The wycheproof test runs on a non-longtest LUCI builder (and produces a false-positive failure) because the parent commit is older than CL 510695.dmitshur commented on all: fix field names2d
Thanks.dmitshur commented on golang.org/x/crypto/ssh: add (*Client).DialContext method2d
Thanks, removed hold.
Consider linking to the Dial function in godoc:
```suggestion
// See [Dial] for additional information.
```dmitshur pushed to
main in github.com/shurcooL/githubv43d
dmitshur created branch in github.com/shurcooL/githubv43d
maindmitshur closed a change github.com/shurcooL/githubv4: Create GitHubGraphQLAPI3d
dmitshur deleted branch in github.com/shurcooL/githubv43d
masterdmitshur created branch in github.com/shurcooL/graphql3d
maindmitshur deleted branch in github.com/shurcooL/graphql3d
masterdmitshur created branch in github.com/shurcooL/markdownfmt3d
maindmitshur deleted branch in github.com/shurcooL/markdownfmt3d
masterdmitshur created branch in github.com/shurcooL/trayhost3d
maindmitshur deleted branch in github.com/shurcooL/trayhost3d
masterdmitshur created branch in github.com/shurcooL/sanitized_anchor_name3d
maindmitshur deleted branch in github.com/shurcooL/sanitized_anchor_name3d
masterdmitshur deleted branch in github.com/shurcooL/github_flavored_markdown3d
masterdmitshur created branch in github.com/shurcooL/github_flavored_markdown3d
maindmitshur created branch in github.com/shurcooL/vfsgen3d
maindmitshur deleted branch in github.com/shurcooL/vfsgen3d
masterdmitshur created branch in github.com/shurcooL/httpgzip3d
maindmitshur deleted branch in github.com/shurcooL/httpgzip3d
masterdmitshur created branch in github.com/shurcooL/httpfs3d
maindmitshur deleted branch in github.com/shurcooL/httpfs3d
masterdmitshur commented on github.com/shurcooL/httpfs/Added power support for the travis.yml file with ppc64le. and update go versions for package: httpfs3d
Closing since the .travis.yml file is deleted as of commit 617b1d4caa554e7fa8edc15c57819043384f2fc5. Thanks.dmitshur created branch in github.com/shurcooL/SLA4d
maindmitshur deleted branch in github.com/shurcooL/SLA4d
masterdmitshur created branch in github.com/shurcooL/Hover4d
maindmitshur deleted branch in github.com/shurcooL/Hover4d
masterdmitshur created branch in github.com/shurcooL/eX04d
maindmitshur deleted branch in github.com/shurcooL/eX04d
masterdmitshur created branch in github.com/shurcooL/gostatus4d
maindmitshur deleted branch in github.com/shurcooL/gostatus4d
masterdmitshur created branch in github.com/shurcooL/go4d
maindmitshur deleted branch in github.com/shurcooL/go4d
masterdmitshur created branch in github.com/shurcooL/play4d
maindmitshur deleted branch in github.com/shurcooL/play4d
masterdmitshur deleted branch in github.com/shurcooL/Go-Package-Store4d
masterdmitshur created branch in github.com/shurcooL/Go-Package-Store4d
maindmitshur created branch in github.com/shurcooL/cmd4d
maindmitshur deleted branch in github.com/shurcooL/cmd4d
masterdmitshur created branch in github.com/shurcooL/frontend4d
maindmitshur deleted branch in github.com/shurcooL/frontend4d
masterdmitshur created branch in github.com/shurcooL/highlight_diff4d
main