Activity

Yesterday
(1 comment) There should be a blank line left in cases like this, since you don’t want the copyright comment to become a package comment.
(1 comment) I'll answer anyway since I too was curious and looked into it before. :) It's a global version epoch, bumped when the process for packaging changes, so that each individual package doesn…
This Week
Thanks. I kicked off a shadow build that you can take a look at to see that everything's still passing with the new version, at least for the main Go repo: ``` $ led get-build -real-build 873451722…
Marking this as "not planned" so the issue outcome is more visible at a high level.
Thanks. What's the effect of '%' here? (minor) Now that the go.mod defines the minimum Go language version (and thus toolchain), there's less need to maintain the go version via the filename, and m…
By now, the /js/godocs.js and /js/playground.js scripts are already loaded on all go.dev pages because they're included at the bottom of the root site.tmpl template. The layout template for blog page…
(1 comment) Note that this line won't automatically close [issue 67051](https://go.dev/issue/67051) as is because it'll be interpreted as https://github.com/golang/exp/issues/67051 which is 404. Si…
(1 comment) Done in PS 2, PTAL.
(1 comment) @hyangah@gmail.com If there isn't a good reason for setAnchors to stay in site.js, this CL can just move it there, after generateTOC, instead of using window.initFuncs to achieve that. B…
[CL 618635](https://go.dev/cl/618635) changes the order to be: ``` setAnchors is being scheduled generateTOC is being scheduled generateTOC is starting setAnchors is starting ``` <img widt…
Use the existing window.initFuncs mechanism to arrange for setAnchors to run after generateTOC, instead of before. That way generateTOC can go back to using the full heading text as it did before CL …
[CL 601055](https://go.dev/cl/601055) made the change to start using `node.firstChild.textContent` as the TOC item text, instead of `$(node).text()`. It looks like it was trying not to include the '…
(1 comment) FWIW these all are in older Go toolchains, not related to code inside x/website. I don't see them under go1.23.2.
(1 comment) This approach does fix the issue, but perhaps it would be better to adjust the TOC generation code so that it's possible to continue to use code blocks in headings. That is, it seems thi…
dmitshur starred honnef.co/go/jello3d
dmitshur starred honnef.co/go/curve3d
Thanks for the report. GLFW v3.2 is an older version. Does this also happen with v3.3?
Last Week
Commit-Queue+2 permission was granted only to members of the team working on the LUCI migration when it began (CL 468955), and by now it's in an in-between state - neither removed from members of tha…
(4 comments) CloneAsSubDir is a hard-to-use-correctly API that's only needed here in one place. It's hard to use because it requires the caller to keep track of what subdirectory the Git was cloned …
Thanks. CC @mknyszek.
Gaby didn't include it in https://github.com/golang/go/issues/69772#issuecomment-2392352550, but issue #67791 is also related here. If there are tests in x/ repos that would fail when switching to th…
(1 comment) @taking@google.com Note that inserting blank lines between the [package comment](https://go.dev/doc/comment#package) and the `package` clause is problematic. For example, compare documen…
This change is ready for review.
Fetch the git tree where go.mod is being updated, walk over its content to find nested modules to tidy. This way even if new nested modules are added, they'll be handled without needing additional at…
Are the OOMs in x/tools ongoing? If it was just that burst around September 20-22, I added some more detail in https://github.com/golang/go/issues/66962#issuecomment-2391753139 that's likely relevant.
Recording here that there was another instance of the builders disconnecting and needing to be restarted around September 20-23: <img width="37" alt="image" src="https://github.com/user-attachment…
Thanks. Looks like formatting needs to be fixed. Since we’re in x/build here, this can be written in the usual way as golang/go#61095. Not a big deal of course.
Something related that's been on my mind: if we have a directory with a go.mod file with the following content: ``` module minimumbootstrap go 1.22.6 ``` Then it becomes trivial for a user with a …
(2 comments) Yeah, I understand this message is only printed when there's no "go" binary in PATH, and none of $HOME/go1.22.6, $HOME/sdk/go1.22.6, nor $HOME/go1.4 exist. So saying "if you have Go ins…
All 3 CLs mentioned above are submitted, so I think this is done. Feel free to comment if we missed something.
Thanks. Asking to understand why this is 'go1.21.0' - it is because a binary with that name is expected to be definitely Go 1.21.0 and can upgrade itself to the minimum specified in go.mod, whereas …
Let's consider proceeding here analogously to https://go-review.googlesource.com/c/wiki/+/604119/comments/27f10acb_3d4f05ce.
Some time has passed since #68024 was resolved. Since there is a note pointing to the old path for Go 1.23 and earlier, should we proceed with submitting this now so that documentation is also accura…
@timothy-king You're running into friction issue #25574 – there was already a backport request in https://github.com/golang/go/issues/68658#issuecomment-2313617202. As a workaround, you can create …
Thanks. #68024 is now resolved.
Added release-blocker for now so we can track this better. (It's a documentation only issue for a secondary port, so it wouldn't block the release in practice.)
In the failed runs, it said "LUCI CV no longer needs this Tryjob". This happened because patch set 2 was uploaded without an explicit CQ+1 vote, and the CQ+1 vote from patch set 1 was removed as out…
(1 comment) (minor) Returning `ci` here made sense, in that the change was created successfully and `ci.ChangeID` is its ID - the only thing that failed was setting a CQ+1 vote on it.
Thanks. Looks like https://go.googlesource.com/wiki/+/c775517b3fee297ad3321f53dbd5c39a92f30f1b%5E%21 updated it from GOPATH mode era to module mode era, but partially.
Thanks. I think we can say "Otherwise, the results are undefined." (In general, the go command supports working on standard library packages in its own GOROOT. Working outside of its own GOROOT mea…
This is issue #59048. Issue #39055 is also related.
Leaving a Commit-Queue+1 vote starts LUCI trybots. It's documented at https://go.dev/wiki/LUCI#trybots.
Thanks. ``` asset: do not use 'assets' directory for iOS ``` 'assets' Does this build under GOOS=ios? I expect a build error due to filepath package being unused.
dmitshur deleted branch in rsc.io/github1w
master
dmitshur opened a change rsc.io/github/issue: various fixes1w
As reported by vet and staticcheck.
dmitshur created branch in rsc.io/github1w
various-fixes
Earlier
dmitshur fixed an issue runtime: unrecognized failures1w
The most recent failures here since this was reopened are all due to a core file being left behind, and the pattern isn't narrow enough to match anything else specific. So closing this in favor of #6…
Merged into #69457.
This can be reproduced locally by running the test in the x/vulndb module located in the module cache, rather than a git repository checkout. For example: ``` $ cd $(mktemp -d) $ go mod init exa…
Based on issue #69457, the watchflakes change described in https://github.com/golang/go/issues/65977#issuecomment-1969407349 above is done. It sounds like there's nothing more to do here, and we can …
Merged into #69457.
Merged into #69664.
dmitshur closed an issue make.bat: unrecognized failures1w
Merged into #69664.
Merged into #69664.
Issue #33986 is relevant. Issue #66962 may also be relevant.
Fixed in [CL 610940](https://go.dev/cl/610940).
dmitshur commented on github.com/go-gl/glfw: GLFW v3.41w
Build constraints are documented at https://pkg.go.dev/cmd/go#hdr-Build_constraints.
dmitshur commented on github.com/go-gl/glfw: GLFW v3.41w
Checking in on the status. @Geo25rey, would you like to keep pushing this forward? If so, there are some unresolved review comments that need to be addressed, otherwise this seems close. I've been us…
(1 comment) (And just `env:` as the prefix is enough, no need to include repo name in front. Not a big deal either way.)
Thanks. (nit) Since this affects builders overall, not only gonotes: ```suggestion build/env: add rsync to builder images for gomote ``` Here and below, please add a line explaining the motivation…
[CL 616336](https://go.dev/cl/616336) is submitted, nothing more to do here.
(1 comment) If it's okay to leave the issue unassigned if no coordinators are entered, then you can reuse `reviewersParam`, right? The only difference between `reviewersParam` and `releaseCoordinato…
Thanks. has now? Is it your intention to bump the timeout only when using golangbuild, and keep 24 hr when golangbuild isn't used?
Thanks. You could add this, to avoid future instances of meaningless multiple markers. There aren't any now. ```suggestion if p.Bot { panic(fmt.Errorf("*bot marker is set multiple times for …
The production instance isn't healthy yet: ``` $ kubectl get pods | grep watchflakes watchflakes-deployment-7dd687d899-8rf75 0/1 CrashLoopBackOff 1876 (3m53s ago) 17d ``` @dr2chase …
Another instance reported at https://ci.chromium.org/b/8735636356859002161/infra, this time on windows/amd64. So this likely applies to all platforms rather than linux/ppc64le specifically.
(1 comment) Note that one of the fields of a Person is their GitHub username. See [here](https://cs.opensource.google/go/x/build/+/master:internal/gophers/gophers.go;l=18;drc=cf2ab8746449c0af3c48c37…
Fixed in [crrev.com/c/5873674](https://crrev.com/c/5873674). As a simple demonstration, [CL 615681](https://go.dev/cl/615681) contains a test that intentionally reaches across module boundary and …
As of crrev.com/c/5875121, golangbuild switched to the new default behavior of using 'proto' field naming (such as "gitiles_commit") instead of using protobuf default names (such as "gitilesCommit").…
dmitshur opened a change golang.org/x/mod/zip: add TestVoid2w
DO NOT REVIEW, DO NOT SUBMIT: This is a test.
Hopefully changes/additions of behavior-changing properties like no_network are fairly rare, but it's still good to try to make this scale better. But I think this is pragmatic now. Thanks. My read…
Moving myself to CC since this is already reviewed. Thanks.
One way to test it would be to run it locally; it should no longer run into the "repo mismatch" error. You'll also know it works when you [deploy watchflakes with it](https://go.googlesource.com/bui…
Thanks. Does 'go mod tidy' need to be run?
Thanks. Note that 'omitempty' option has effect when marshaling, no effect when unmarshaling. In general it's slightly cleaner to disregard the `tokenRespErr` value if unmarshaling into it fails, b…
Thanks. Done in PS 7.
Watchflakes is currently in a continuous crashloop: ``` $ kubectl logs -p watchflakes-deployment-7dd687d899-8rf75 watchflakes: 2024/09/24 12:12:43 ListBuilders watchflakes: 2024/09/24 12:12:4…
(1 comment) Thanks for clarifying this.
Thanks. It turns out that it might be more idiomatic to use 3-way Compare results by comparing with 0, instead of -1/1, so let's update this to be consistent with that practice: ```suggestion if v…
Thanks. Minor comments. (minor) This looks like a sign that the `Version` field in `SecurityReleaseCoalesceTask` should be a pointer, so that dereferencing here isn't needed. Probably better to use…
(2 comments) Being able to skip duplicate testing when you have assurance that it's already been done previously is great. I don't entirely understand this change. If the constant string "s" is alw…