Activity
Today
dmitshur opened a change golang.org/x/build/cmd/coordinator: unify headers visually1h
A header is displayed on 3 pages:
• farmer.golang.org - the coordinator status page
• farmer.golang.org/builders - list of builders
• build.golang.org - the build dashboa…dmitshur commented on golang.org/x/build/cmd/coordinator: unify header between build and status pages1h
I came up with a simpler next step I'm happier with. Instead of adding a new "Coordinator" button, I'll just linkify the existing "Go Build Coordinator" text to take one to cmd/coordinator's "home" p…dmitshur commented on runtime/cgo: when using msan explicitly unpoison cgoCallers2h
Trivial comments on whitespace.
Nit: The line above uses a single tab for indentation. This line uses 8 spaces.
Same comment on lines 38, 60, and 66.
Nit: The rest of the file uses tabs for indent…dmitshur reviewed +1 on sync: remove TestWaitGroupMisuse2 and TestWaitGroupMisuse33h
(3 comments)
This will also help release tests, in particular, windows/arm64 seems to hit it pretty often (I found out while investigating issue #47017).
TestWaitGroupMisuse2 and TestWaitGroupMisus…dmitshur commented on golang.org/x/build/cmd/relui/workflow: basic workflow functionality4h
(1 comment)
Nit: missing a verb before “basic”.
> the part after the colon uses the verb tense + phrase that completes the blank in, "This change modifies Go to ___________"dmitshur reviewed +2 on golang.org/x/build/cmd/relui/workflow: basic workflow functionality4h
I've not yet used the API, and I suspect may have more comments, but I see no reason not to check this in now and iterate.
I'd like to see this added as an 'internal' package and not…dmitshur reviewed +2 on golang.org/x/build/dashboard: modify linux-arm-aws enviornmental variables5h
(1 comment)
Optional: It might be possible to also fit the names of the env vars being modified in the subject:
dashboard: set GO{,HOST}ARCH, GOARM on linux-arm-aws builder
To increase the…dmitshur reviewed +2 on golang.org/x/website/blog: stop referencing mirror.gcr.io URLs7h
(2 comments)
This is okay, but maybe 'all' is good too.
Minor: Add a blank line above Change-Id, otherwise it's harder to spot that the commit message ends on line 17 rather than 15. (U…dmitshur commented on golang.org/x/website/internal/history: document Go 1.16.7 and Go 1.15.159h
Are the changes introduced to go.mod in patch set 2 intentional?dmitshur commented on rsc.io/2fa: Time remaining Feature Request9h
PR #11 is relevant.Yesterday
dmitshur merged a change golang.org/x/build/cmd/releasebot: log when a build is successful1d
dmitshur commented on golang.org/x/build/cmd/releasebot: log when a build successful1d
(1 comment)
Thanks for the suggestion.
That would result in "waiting 1m0s and trying again", which sounds too robotic/precise to be useful. My goal with this line is to make the timeline in…dmitshur opened a change golang.org/x/build/cmd/releasebot: log when a build successful1d
Releasebot runs many builds in parallel, retrying each up to 3 times.
Whenever there's an unsuccessful attempt, it prints information about
what went wrong, but it doesn't make it easy to see…dmitshur commented on net/http: deadlock in TestMissingStatusNoPanic on release-branch.go1.15 branch1d
> The root cause of the failures is port exhaustion, which hasn't been addressed, but the deadlock in `TestMissingStatusNoPanic` should be fixed.
The port exhaustion issue is now also fixed (by [C…dmitshur closed an issue net/http: deadlock in TestMissingStatusNoPanic on release-branch.go1.15 branch1d
dmitshur reviewed +2 on golang.org/x/build/cmd/gomote: handle unclean GOROOT1d
I think this looks good after inline comment is resolved. Thanks for improving gomote.dmitshur commented on golang.org/x/build/cmd/gomote: handle unclean GOROOT1d
(1 comment)
The local map documentation says its keys are like "src/make.bash", and rel previously used filepath.ToSlash.
Given the uses of the local map below, it does seem to need to be &…dmitshur commented on golang.org/x/pkgsite: surface VCS clone path from the go-import meta tag1d
I've closed #47520 as a duplicate of this issue.dmitshur commented on golang.org/x/pkgsite: for some repositories, the View Source works well for reading code but not figuring out where changes are made1d
Yep, I think it's the same, thanks.dmitshur commented on net/http: TestCancelRequestWhenSharingConnection can cause port exhaustion, leading to frequent test failures with "Only one usage of each socket address" on windows-amd64-longtest1d
Since there are dedicated backport issues, retargeted this issue to 1.17.
Closing as fixed by [CL 339594](https://golang.org/cl/339594).dmitshur closed a change net/http: [release-branch.go1.15] set socket linger time to 0 in TestCancelRequestWhenSharingConnection1d
dmitshur commented on net/http: [release-branch.go1.15] set socket linger time to 0 in TestCancelRequestWhenSharingConnection1d
We went with a better fix in CL 339594, so this backport shouldn't be needed. Closing. (Can re-open if something changes.)This Week
dmitshur commented on net/http: [release-branch.go1.15] set socket linger time to 0 in TestCancelRequestWhenSharingConnection1d
The test fix is working as expected. From windows-amd64-longtest test log so far:
ok net/http 61.339sdmitshur opened a change net/http: [release-branch.go1.15] set socket linger time to 0 in TestCancelRequestWhenSharingConnection1d
This test runs for 10 seconds, with 11 goroutines creating HTTP
requests in a tight loop for the duration of the test. These
goroutines abort in-flight requests, which can result in many new
client c…dmitshur reviewed +1 on net/http: set socket linger time to 0 in TestCancelRequestWhenSharingConnection2d
This test fix makes sense and resolves the problem in my testing on a Windows 10 machine.
Since this CL targets master branch, I think it should say "Updates" or "For", and the backp…dmitshur commented on net/http: set socket linger time to 0 in TestCancelRequestWhenSharingConnection2d
TRY=windows-amd64-longtest, linux-386-longtest, linux-amd64-longtest
This CL modifies TestCancelRequestWhenSharingConnection which is skipped in short mode, so regular TryBots won't provide a us…dmitshur opened an issue golang.org/x/pkgsite: for some repositories, the View Source works well for reading code but not figuring out where changes are made2d
### What is the URL of the page with the issue?
https://pkg.go.dev/golang.org/x/website/internal/history#Releases
### What did you do?
I shared the link https://pkg.go.dev/golang.org/x/websi…dmitshur commented on golang.org/x/build/dashboard: remove dragonfly-amd64-5_8 builder2d
Closing this PR because [golang.org/cl/332129](https://golang.org/cl/332129) has been submitted.dmitshur closed a change golang.org/x/build/dashboard: remove dragonfly-amd64-5_8 builder2d
dmitshur merged a change golang.org/x/build/dashboard: remove dragonfly-amd64-5_8 builder3d
dmitshur reviewed +2 on golang.org/x/build/dashboard: remove dragonfly-amd64-5_8 builder3d
I've updated the PR description, submitting.
Done.
Done.
Done.dmitshur commented on golang.org/x/website/cmd/golangorg: add ability to serve tip.golang.org directly from Gerrit3d
(7 comments)
Since the goal of this is to replace x/build/cmd/tip, it should also handle beta.golang.org too, by redirecting it. (See https://go.googlesource.com/build/+/12eae6d636a4f5cafe4b8f2540fc…dmitshur commented on golang.org/x/website/internal/gitfs: add git-backed FS implementation3d
(2 comments)
cmd/golangorg is currently on App Engine Standard Go 1.15 runtime¹, so either this build constraint or the runtime will need to change before cmd/golangorg can start to import this pac…dmitshur reviewed +2 on io/fs: don't use absolute path in DirEntry.Name doc3d
dmitshur commented on net/http: panic due to racy read of persistConn after handler panic [1.15 backport]3d
Approved as a fix for a security issue. This backport applies to both 1.16 (#47474) and 1.15 (this issue).dmitshur commented on net/http: panic due to racy read of persistConn after handler panic [1.16 backport]3d
Approved as a fix for a security issue. This backport applies to both 1.16 (this issue) and 1.15 (#47473).dmitshur commented on net/http/httputil: [release-branch.go1.15] close incoming ReverseProxy request body3d
(1 comment)
Should modify this 1.15 cherry-pick to use "io/ioutil".Discard.
Another one on line 1155.Last Week
dmitshur commented on github.com/mmcloughlin/avo/buildtags: support //go:build constraints4d
> *should* go/format touch .s files, if only the build header lines?
My personal preference would be to keep the scope of `cmd/gofmt` (and `go/format`, which is just an importable Go package version…dmitshur commented on github.com/mmcloughlin/avo/buildtags: support //go:build constraints4d
FWIW, in Go 1.17 the [`go/format`](https://pkg.go.dev/go/format) package (like the `gofmt` binary) takes care of this¹, so if used, the output is guaranteed to be gofmt'ed (and continue to be over t…dmitshur commented on golang.org/x/crypto/curve25519: avo doesn't generate go:build lines4d
[CL 338629](https://golang.org/cl/338629) updates this issue. CC @mmcloughlin, @josharian, @ianlancetaylor.
@mmcloughlin If updating the generator is a change that needs more time, should we fix i…dmitshur starred in github.com/mmcloughlin/avo4d
dmitshur starred in github.com/mattn/twty5d
dmitshur commented on golang.org/x/build/cmd/release: green-screen on Windows ARM64 builder with SkipTests: false6d
I tried to gather more information on this issue by making use of a physical windows/arm64 machine I have access to. I ran all.bat a number of times on it, and can confirm this issue doesn't reproduc…dmitshur opened a change golang.org/x/build/env/js-wasm: update to Node.js 146d
At this time, Node 14 is the LTS release recommended for most users,
including for production use (https://nodejs.org/en/about/releases),
so start using it.
Also check in a copy of setup_14.x into x…dmitshur commented on x/build/{cmd/coordinator,app/appengine}: combine codebases6d
The stack up to [CL 336791](https://golang.org/cl/336791) has been submitted and deployed. The new coordinator-powered dashboard is being served at https://farmer-ui-test.golang.org.
I'm not spott…dmitshur merged a change golang.org/x/build/cmd/coordinator: serve build dashboard at build.golang.org6d
dmitshur merged a change golang.org/x/build/cmd/coordinator/internal/legacydash: convert app/appengine to library6d
dmitshur commented on golang.org/x/build/cmd/coordinator/internal/legacydash: convert app/appengine to library6d
Also, the README is now regenerated.dmitshur commented on golang.org/x/build/cmd/coordinator/internal/legacydash: convert app/appengine to library6d
CL 336789 is merged into this CL in patch set 2.dmitshur closed a change golang.org/x/build/app/appengine: copy to cmd/coordinator/internal/legacydash6d
dmitshur commented on golang.org/x/build/app/appengine: copy to cmd/coordinator/internal/legacydash6d
This change is merged into CL 336790 in patch set 2, so it's no longer needed as a separate CL.dmitshur merged a change golang.org/x/build/app/appengine: delete cron.sh6d
dmitshur commented on golang.org/x/build/cmd/coordinator/internal/legacydash: convert app/appengine to library6d
(2 comments)
Acknowledged.
I agree, I felt that way too. I prototyped using a sync.Once either to make it so Handler only sets globals the first time and then returns same values, as well as to pan…dmitshur opened an issue golang.org/x/build/cmd/coordinator: unify header between build and status pages6d
The build dashboard is merging into the coordinator codebase in #34744, so maybe we should unify the header. It would help navigation between the build dashboard and the farmer status page, especiall…dmitshur reopened an issue time: Timer reset broken under heavy use since go1.16 timer optimizations added [1.16 backport]1w
dmitshur commented on time: Timer reset broken under heavy use since go1.16 timer optimizations added [1.16 backport]1w
@ianlancetaylor Should the follow up change [CL 337309](https://golang.org/cl/337309) also be cherry-picked to 1.16?
(I'll reopen this so we don't forget to make that decision before release time.)dmitshur deleted branch in github.com/go-gl/glfw1w
update-3.3.4dmitshur pushed to
master in github.com/go-gl/glfw1w
dmitshur merged a change github.com/go-gl/glfw/v3.3/glfw: update to GLFW 3.3.41w
dmitshur closed an issue github.com/go-gl/glfw/v3.3/glfw: update to GLFW v3.3.4 release1w
dmitshur opened an issue golang.org/x/build/cmd/relui: ability to make minor release announcement tweets via Twitter API1w
During the minor release process, towards the end, an announcement tweet is posted. For example, https://twitter.com/golang/status/1414721238224838666. (The tweet text and image are generated via a t…dmitshur commented on github.com/shurcooL/githubv4: QueryString with Search creating issue1w
I don't see anything wrong in the snippets you posted.
I tried putting them together into a complete program, and can't reproduce the problem with it. It seems to work fine:
<details><br>
``…dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: update to GLFW 3.3.41w
(We should also update https://github.com/go-gl/glfw/wiki/Development#updating-glfw-c-source for the new grab-upstream process.)dmitshur opened a change github.com/go-gl/glfw/v3.3/glfw: update to GLFW 3.3.41w
GLFW 3.3.4 was released on April 8, 2021.
See https://github.com/glfw/glfw/releases/tag/3.3.4.
Done with scripts/grab-upstream.sh (albeit with edits):
echo 'b3e0aae393ef6c5cda7dcad0cba06bef23…dmitshur created branch in github.com/go-gl/glfw1w
update-3.3.4dmitshur pushed to
master in github.com/shurcooL/frontend1wdmitshur deleted branch in github.com/dominikh/go-js-dom1w
rebase-pointereventdmitshur pushed to
master in github.com/dominikh/go-js-dom1wdmitshur merged a change github.com/dominikh/go-js-dom: rebase PointerEvent on top of MouseEvent1w
dmitshur pushed to
master in github.com/shurcooL/githubv41wdmitshur closed a change github.com/shurcooL/githubv4: Regenerate code and added go.mod1w
dmitshur commented on github.com/shurcooL/githubv4: Regenerate code and added go.mod1w
Thanks. The breaking changes should be fine, this package follows the GitHub API and inherits its breaking changes.
I'll deal with adding a go.mod file separately later.dmitshur commented on github.com/dominikh/go-js-dom: rebase PointerEvent on top of MouseEvent1w
This is motivated by Chrome changing "click" events to send PointerEvent rather than MouseEvent, as described at https://groups.google.com/a/chromium.org/g/blink-dev/c/bta50W_Hg24/m/YAYeAzCZAAAJ.dmitshur opened a change github.com/dominikh/go-js-dom: rebase PointerEvent on top of MouseEvent1w
According to documentation on MDN¹, the PointerEvent interface
inherits properties from MouseEvent, which in turn inherits from
UIEvent, and that inherits from Event.
Embed MouseEvent in Pointe…dmitshur created branch in github.com/dominikh/go-js-dom1w
rebase-pointereventEarlier
dmitshur closed an issue github.com/go-gl/gl: undefined reference to `__assert_func'1w
dmitshur commented on github.com/go-gl/gl: undefined reference to `__assert_func'1w
Closing as duplicate of https://github.com/go-gl/glfw/issues/319.
Also please be aware that it's possible to clear the build cache with `go clean -cache`, as documented at https://pkg.go.dev/cmd/g…dmitshur commented on github.com/go-gl/glfw/v3.2/glfw: build fails on Rasperry Pi OS1w
As a first step, try v3.3, since v3.2 is an old version of GLFW and not really supported.
If it still doesn't work, that likely means support for Raspberry Pi has not been added.dmitshur opened an issue cmd/go: 'go get -m -u all' in 1.17 may fail due to disallowed go.sum updates1w
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.17rc1 darwin/arm64
</pre>
(It also reproduces with latest master commit, 0914646ab91a3157666d845d74d8d9…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido1wdmitshur commented on golang.org/x/website/internal/dl: version sorting doesn't sort pre-release versions1w
Thanks for the report.
The `dl` package implements `fileOrder` sorting, and `versionLess` is used to compare two versions. When both are pre-release versions with same major, minor components, the…dmitshur commented on x/build/{cmd/coordinator,app/appengine}: combine codebases2w
I've been able to pick this up and make good progress this week. My focus is on getting this to a point where the build dashboard is served by cmd/coordinator, so that it's a single deploy rather tha…dmitshur opened an issue all: reopen tree for Go 1.18 development2w
### Current Tree Status: Frozen for Go 1.17 changes only 🥶 (RC 1 is out)
This is a tracking issue for the [upcoming task](https://golang.org/s/release#timeline) of reopening the tree for Go 1.1…dmitshur commented on github: add Autolink References for CLs2w
Sure, let's use it as a tracking issue then.dmitshur reopened an issue github: add Autolink References for CLs2w
dmitshur closed an issue github: add Autolink References for CLs2w
dmitshur commented on github: add Autolink References for CLs2w
Thanks for suggesting this. Unfortunately, I don't think we're on a plan that supports this feature. If that changes we should consider this.dmitshur opened an issue golang.org/x/website/go.dev/cmd/internal/site: TestGolden failing2w
As visible on the [build dashboard](https://build.golang.org/?repo=golang.org%2fx%2fwebsite), `TestGolden` is failing starting with [CL 335669](https://golang.org/cl/335669):
```
--- FAIL: TestGo…dmitshur commented on golang.org/x/tour/tour: welcome doesn't mention git is required to be able to go-get the tour for running it locally2w
By default, a modern version of Go should install the `tour` binary in module mode and use the module mirror (https://proxy.golang.org) to download the module zip, so `git` shouldn't be required.
…dmitshur commented on golang.org/x/tour: offline version of 'A Tour of Go' broken with modules2w
@jfesler Thanks for that information. Indeed, looking for content in the module cache can only work on a machine where Go is installed.
Go 1.17 will come out pretty [soon](https://groups.google.co…dmitshur commented on cmd/go: TestScript/mod_invalid_version is failing locally2w
Is this marked as a 1.18 release blocker because it's okay to fix this after 1.17 is released?
I can't reproduce with `git version 2.30.1 (Apple Git-130)` either.dmitshur commented on golang.org/x/website/tour: installing @latest gets older version2w
I understand why this is happening and can confirm both the go command and module mirror are working as expected. Specifically, https://golang.org/ref/mod#resolve-pkg-mod specifies that:
> If one or…dmitshur commented on golang.org/x/website/tour: installing @latest gets older version2w
Hmm, this doesn't seem to happen in GOPROXY=direct mode, so maybe the module mirror is playing a role. I'll check again later.dmitshur opened an issue golang.org/x/website/tour: installing @latest gets older version2w
A reasonable way to install the latest version of the `tour` binary from its latest location is by using `go install`:
```
go install golang.org/x/website/tour@latest
```
However, doing so cu…dmitshur commented on lib/time: move zoneinfo.zip to src/time/tzdata3w
Added early-in-cycle so this issue gets a reminder when the tree reopens. If we're going to do this, doing it earlier gives the greatest opportunity to find out what needs updating (outside of the Go…dmitshur commented on golang.org/x/build: dragonfly-amd64-5_8 builder is missing3w
@tuxillo Friendly ping. [CL 332129](https://golang.org/cl/332129) just had 3 minor commit message comments and can be submitted.
Are you still planning to create a tracking issue for the 6_0 build…dmitshur commented on : x/website:3w
Thanks for reporting. I suspect this might be a duplicate of #46416.dmitshur reviewed +2 on github.com/go-gl/glfw: Ignore invalidValue at PollEvents, WaitEvents, and WaitEventsTimeout3w