Today
shurcooL commented on Added listing outside collaborators… in github.com/google/go-github2 hours ago
Yes, this PR is just 1 logical commit + 3 adjustments based on review comments. I think you should rebase them, add context support and squash everything into one commit before merging into master. …
shurcooL pushed to github.com/google/go-github2 hours ago
a129861fDeclare ctx on top, reuse it for 2 calls.
shurcooL commented on Update API inside documentation. in github.com/google/go-github2 hours ago
That seems reasonable.
shurcooL commented on Playground menu link is routing to … in github.com/gopherjs/gopherjs3 hours ago
Got it, thanks for reporting the issue. We're already aware and tracking it in https://github.com/gopherjs/gopherjs.github.io/issues/63#issuecomment-278016990. The entire old website is broken and ne…
Yesterday
shurcooL commented on Playground menu link is routing to … in github.com/gopherjs/gopherjs6 hours ago
> When a user clicks the Playground menu item Where?
shurcooL created branch in github.com/google/go-github6 hours ago
context-doc-updates
shurcooL opened a pull request in github.com/google/go-github6 hours ago
shurcooL pushed to github.com/shurcooL/git-branches6 hours ago
3f60a5e4Improve consistency docs for -all flag.
b6fbb280Update .travis.yml.
shurcooL commented on Fix build for Go 1.8 in github.com/gogo/protobuf6 hours ago
The latest version of GopherJS indeed requires Go 1.8. Here's a link that says it: https://medium.com/gopherjs/gopherjs-1-8-1-is-released-b4473712ab95#.4espdfrxt See second paragraph.
shurcooL commented on Fix build for Go 1.8 in github.com/gogo/protobuf6 hours ago
See https://github.com/gogo/protobuf/pull/268#issuecomment-281537311.
shurcooL commented on Fix build for Go 1.8 in github.com/gogo/protobuf6 hours ago
> For some reason, Go 1.8 changes the generated files :( @Serabe, that reason is https://golang.org/doc/go1.8#compress_gzip: > The Writer now encodes a zero MTIME field when the Header.ModTime …
shurcooL commented on cmd/bug: does nothing if there is n… in github.com/golang/go8 hours ago
I've seen at least one reported case where where "xdg-open" seemed to block and not return until browser was closed. To help the issue, I had to run it in a background goroutine. See https://github.c…
shurcooL commented on 1d1a6b7cBorrow a lot more logic… in github.com/gopherjs/gopherjs9 hours ago
Relevant: https://github.com/gopherjs/gopherjs/pull/590/commits/ca4a8d8cc7cd068a70c2e00ef090244607ca5266.
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs9 hours ago
@flimzy I've pushed some fixes to this PR, I hope that's okay with you. See last 4 commits and their commit messages for details.
shurcooL pushed to github.com/flimzy/gopherjs9 hours ago
8334ec3ccompiler/natives/src/testing: Fix build errors.
426ccd56compiler/natives/src: Fix package name; gofmt.
ca4a8d8ccompiler/natives/src: Print expected output for disabled examples.
0aaca850compiler/natives: Regenerate.
shurcooL commented on Add support for Preview Review Requ… in github.com/google/go-github9 hours ago
It looks like #557 is related. @varadarajana, @sevki, you should coordinate to avoid duplicate work.
shurcooL commented on Add requestreviewers in github.com/google/go-github9 hours ago
@sevki, is this meant to resolve (partially or in full) #516?
shurcooL starred github.com/upspin/upspin10 hours ago
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs10 hours ago
Depends on if you want a byte slice, then: ``` b := make([]byte, 0, capacity) ``` Or if you want a `bytes.Buffer`, then: ``` buf := bytes.NewBuffer(make([]byte, 0, capacity)) ``` See …
shurcooL closed an issue in github.com/google/go-github10 hours ago
shurcooL commented on Flag for dumping HTTPS traffic? in github.com/google/go-github10 hours ago
Is there anything left here, or can we close this?
shurcooL commented on Large file sizes in github.com/gopherjs/gopherjs10 hours ago
In https://github.com/gopherjs/gopherjs/issues/561#issuecomment-280864761, @tj said: > The size is pretty reasonable if you stay out of stdlib territory. My conclusion so far is you pretty much ju…
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs10 hours ago
gofmt?
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs10 hours ago
I think this needs to be `package cookiejar_test`. The example is in an external test package. See https://github.com/golang/go/blob/go1.8/src/net/http/cookiejar/example_test.go#L5.
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs10 hours ago
Same here, `package reflect_test`. See https://github.com/golang/go/blob/go1.8/src/reflect/example_test.go#L5.
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs11 hours ago
Same here. ```Go func ExampleStructOf() { // Blocked on https://github.com/gopherjs/gopherjs/issues/499. } ```
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs11 hours ago
It's very helpful (for later) to put a comment inside that explains why a test/example is disabled: ```Go func ExampleNew() { // Example relies on httptest.NewServer, which GopherJS does not…
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs11 hours ago
If there's any error during reading the example stdout file, `_ = os.Remove(w.Name())` line will never run. Would the following be better? ```Go out, readFileError := ioutil.ReadFile(w.Name())…
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs11 hours ago
This isn't the approach I meant. Is it possible to override and skip examples similar to how we skip failing/unsupported tests? Look at https://github.com/gopherjs/gopherjs/commit/3303ee8edfe1a368…
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs11 hours ago
Well, it would allow you to simplify circle.yml back to the original version. I think it's worth doing, if it's indeed possible. Thanks!
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs11 hours ago
Just trying to understand this better. Do you know why the original Go code did this here in a goroutine, instead of simply doing it at the end (original line 51, `out := <-outC`)? Is it so that w…
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs12 hours ago
Why not check errors from `io.Copy`? How about this: ```Go func readFile(filename string) (string, error) { f, err := os.Open(filename) if err != nil { return "", err } defer f.Clos…
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs12 hours ago
It [looks like](https://circleci.com/gh/gopherjs/gopherjs/1062) only two examples are failing: - `ExampleNew`, because it tries to perform network operations that GopherJS doesn't support (i.e., i…
shurcooL commented on Make runnable Examples work in github.com/gopherjs/gopherjs12 hours ago
@flimzy, those 2 commits where you changed code to avoid extra imports, was that because a test was failing when you did that? Just want to check.
shurcooL commented on Generate accessors for structs with… in github.com/google/go-github13 hours ago
Although, this is code that runs during `go generate`, only by developers of this package, not users. So in theory we could require/expect developers to be running 1.8. But, this is absolutely not wo…
shurcooL commented on Generate accessors for structs with… in github.com/google/go-github13 hours ago
Ah, yes, my mistake. I was off by one. :)
shurcooL commented on WIP: Use cmd/go with GopherJS suppo… in github.com/gopherjs/gopherjs13 hours ago
@neelance I will also delete the https://github.com/gopherjs/go WIP repository. It was created to support this PR, and is no longer needed.
shurcooL commented on WIP: Install and use source-map-sup… in github.com/gopherjs/gopherjs13 hours ago
The status continues to be the same as in [Jun 26, 2016](https://github.com/gopherjs/gopherjs/pull/449#issuecomment-228637693). Except now it's higher priority than #388. :) I still need to think …
shurcooL commented on proposal: Replace in-house implemen… in github.com/gopherjs/gopherjs13 hours ago
I'm no longer actively working on this proposal, see https://github.com/gopherjs/gopherjs/pull/485#issuecomment-281441761 for full details.
shurcooL deleted branch in github.com/gopherjs/gopherjs13 hours ago
cmd-go
shurcooL closed a pull request in github.com/gopherjs/gopherjs13 hours ago
shurcooL commented on WIP: Use cmd/go with GopherJS suppo… in github.com/gopherjs/gopherjs13 hours ago
Yep, I've been meaning to post an update here. I will be closing this PR and abandoning this effort. I may choose to revisit the effort later, but until further notice, I won't be actively working…
shurcooL commented on Generate accessors for structs with… in github.com/google/go-github14 hours ago
FWIW, you could use `sort.Slice` now to make this a little shorter (i.e., `byName` type and its 3 methods can go away), if you wanted to, since #554 is merged. (Completely optional, just mentionin…
shurcooL commented on tests/integration: Get rid of integ… in github.com/google/go-github15 hours ago
Yep, completely agreed. That's why I noted: > (perhaps rename them to be more specific to go-github integration tests, rather than more generic, to avoid false matches) Checking for `GITHUB_AUT…
shurcooL commented on Issue530: Resolves fully Issue 530:… in github.com/google/go-github15 hours ago
Look at the description of `EditChange`: ```Go // EditChange represents the changes when an issue, pull request, or comment has // been edited. type EditChange struct { ``` I'm not sure if …
shurcooL commented on Issue530: Resolves fully Issue 530:… in github.com/google/go-github15 hours ago
Do you mind re-arranging these in the same consistent order as in `activity_events.go` and `messages.go`? `ProjectEvent`, then `ProjectCardEvent`, then `ProjectColumnEvent`.
shurcooL commented on Issue530: Resolves fully Issue 530:… in github.com/google/go-github15 hours ago
This should be `json:"name,omitempty"`, not `json:"title,omitempty"`, shouldn't it?
shurcooL commented on Issue530: Resolves fully Issue 530:… in github.com/google/go-github15 hours ago
This should be `json:"note,omitempty"`, not `json:"title,omitempty"`, shouldn't it?
This week
shurcooL commented on build: breaking change in go-github in github.com/golang/go1 day ago
What's the version support policy for x/build? According to #17626: > > What's the general policy for how many versions back we maintain support on a given subrepo? > > In general, the two most …
shurcooL deleted branch in github.com/shurcooL/Go-Package-Store1 day ago
github-context
shurcooL pushed to github.com/shurcooL/Go-Package-Store1 day ago
7557da93Update for go-github API change.
shurcooL deleted branch in github.com/shurcooL/home1 day ago
github-context
shurcooL pushed to github.com/shurcooL/home1 day ago
497b76caUpdate for go-github API change. (#8)
shurcooL merged a pull request in github.com/shurcooL/home1 day ago
shurcooL deleted branch in github.com/shurcooL/issues1 day ago
github-context
shurcooL pushed to github.com/shurcooL/issues1 day ago
37dad549githubapi: Update for go-github API change.
shurcooL deleted branch in github.com/shurcooL/notifications1 day ago
github-context
shurcooL pushed to github.com/shurcooL/notifications1 day ago
6d5343edgithubapi: Update for go-github API change. (#1)
shurcooL pushed to github.com/shurcooL/home1 day ago
8b38ed21Update for new signature of go-github.Client.Do.
shurcooL deleted branch in github.com/shurcooL/users1 day ago
github-context
shurcooL pushed to github.com/shurcooL/users1 day ago
e6485effgithubapi: Update for go-github API change.
shurcooL pushed to github.com/shurcooL/notifications1 day ago
2482595egithubapi: Update for new signature of go-github.Client.Do.
shurcooL deleted branch in github.com/google/go-github1 day ago
context
shurcooL pushed to github.com/google/go-github1 day ago
23d6cb9cAdd support for context package to all endpoints. (#529)
shurcooL merged a pull request in github.com/google/go-github1 day ago
shurcooL closed an issue in github.com/google/go-github1 day ago
shurcooL commented on Add support for context package. in github.com/google/go-github1 day ago
Everything still looks good, I'm proceeding with the plan to merge this PR now.
shurcooL commented on gosimple: simplify comma-ok type as… in github.com/dominikh/go-tools1 day ago
Thank you @dominikh!
shurcooL commented on UnauthenticatedRateLimitedTransport… in github.com/google/go-github2 days ago
@karanjthakkar Sounds great, thanks for considering looking into this! Actually, figuring out the best approach to go with is a part of resolving this issue. The one you said is one valid approach…
shurcooL pushed to github.com/google/go-github2 days ago
052be224Fix GetArchiveLink, DownloadReleaseAsset methods not propagating ctx.
shurcooL commented on Add support for context package. in github.com/google/go-github2 days ago
@gmlewis, I have pushed 2 additional commits to this PR, PTAL. As usual, see the commit messages for rationale. It's also outlined in full detail in https://github.com/google/go-github/issues/526#…
shurcooL pushed to github.com/google/go-github2 days ago
74bd2e5dRevert "Revert Do to take 2 parameters."
4a879a1bImprove documentation and context-specific error handling in Do.
shurcooL commented on support the context package in github.com/google/go-github2 days ago
As promised in https://github.com/google/go-github/pull/529#issuecomment-280947212, here's an update on the status. /cc @gmlewis Something we should keep in mind when thinking this over is that ou…
shurcooL commented on Update Go version aliases in github.com/travis-ci/travis-build2 days ago
As I understand, by "real Go version" it means whatever `go version` prints. Which is "1.8" for current version. The regexp example is definitely misleading.
shurcooL pushed to github.com/shurcooL/trayhost2 days ago
a78e9bf0Revert "Travis: Force Go 1.8 for now."
shurcooL commented on Update Go version aliases in github.com/travis-ci/travis-build2 days ago
Thank you for fixing this!
shurcooL commented on Update for go-github API change. in github.com/shurcooL/Go-Package-Store2 days ago
Thanks for your comment @slimsag! `context.TODO()` exists so you can write code like this: ```Go fetchLog(nil /* TODO: Figure out what context I want to use here. */, client, "") ``` See […
shurcooL starred github.com/karanjthakkar/showmyprs.com2 days ago
shurcooL created branch in github.com/shurcooL/Go-Package-Store2 days ago
github-context
shurcooL opened a pull request in github.com/shurcooL/home2 days ago
shurcooL created branch in github.com/shurcooL/home2 days ago
github-context
shurcooL pushed to github.com/shurcooL/home2 days ago
6d7a7d6eRemove commented out code.
shurcooL created branch in github.com/shurcooL/issues2 days ago
github-context
shurcooL created branch in github.com/shurcooL/notifications2 days ago
github-context
shurcooL created branch in github.com/shurcooL/users2 days ago
github-context
shurcooL commented on Add support for context package. in github.com/google/go-github2 days ago
An update here, the status of this PR continues to be **DO NOT MERGE.** We're going to delay merging because I have some updates. /cc @gmlewis I've done some more "prototyping" by using this branc…
Last week
shurcooL starred github.com/SirCmpwn/evilpass3 days ago
shurcooL commented on support the context package in github.com/google/go-github3 days ago
I don't believe that's not true (for point versions), it only respects the `go1` tag or branch. And as far as I know no one actually uses that feature, and there was proposal https://github.com/golan…
shurcooL commented on support the context package in github.com/google/go-github3 days ago
> We'd document that if you need support for <1.7, then use X previous version. @willnorris Where do you think such documentation would be a good fit? 796decd247300437ba695568862bcfab779ec98b i…
shurcooL commented on support the context package in github.com/google/go-github3 days ago
For anyone watching this issue, the PR #529 that will resolve it is now completely finished and reviewed with approval. I will be merging it tomorrow (Sunday) morning. /cc @kevinburke