Today
shurcooL pushed to master in github.com/shurcooL/issues6h
9e9db335c690d8afe0c750d0d432434bba09bc74fs: Update HTML URL scheme for issue tracker.
shurcooL commented on 2603995d57ba4dc772fcd6c80e5856f9c2d52093Added additional testda… in github.com/ConradIrwin/font18h
These files add 24 + 16 + 7 MB to repo size. Not necessarily a showstopper, but it does give me some pause. I don't have any further comments for now, just wanted to point out (we can discuss w…
shurcooL pushed to master in github.com/shurcooL/home19h
bb59db6a9ba1bfc6ba0fdeaf4645b92d13c5414epackages: Remove gopathutil.
shurcooL pushed to master in github.com/shurcooL/go19h
364c5ae8518b51f5fda954762864d6f4d5c30c89gopathutil: Remove empty and unused package.
shurcooL pushed to master in dmitri.shuralyov.com/service/change19h
93ac3b3359e4139f30719afe7ad13d35cafbf78afs: Add third commit, merge change in mock data.
Yesterday
shurcooL deleted branch in github.com/ConradIrwin/font23h
add-travisci
shurcooL commented on Add .travis.yml; add badges to READ… in github.com/ConradIrwin/font1d
If you want to support older versions of Go and test them in CI, we can add them here.
shurcooL created branch in github.com/ConradIrwin/font1d
add-travisci
shurcooL commented on Add continuous integration (CI). in github.com/ConradIrwin/font1d
I don't have strong opinions on dependency management in this repo. I'll defer that decision to you. I'm okay with things as they are (i.e., always fetching latest with `go get -u`), as well as `d…
shurcooL commented on Add continuous integration (CI). in github.com/ConradIrwin/font1d
Thanks. It looks like I do. I'll let you know there's anything else.
shurcooL deleted branch in github.com/ConradIrwin/font1d
woff2
shurcooL commented on Add support for parsing WOFF2 fonts. in github.com/ConradIrwin/font1d
I've rebased and resolved conflicts. PTAL.
shurcooL pushed to woff2 in github.com/ConradIrwin/font1d
e1d7235e5916c9416e9ea444016d5912118ce507Add support for parsing WOFF2 fonts.
d797009a8098ca7f6c36a29d0c132a3d39bc4212Merge pull request #15 from ConradIrwin/evenmore
7aef32decca10995ef3b458e2f58af6f32f323a5Minor whitespace fixes + updated the benchmark results.
0e7ebd753de92b8438d4b6f4f45768db81453f71Added a new ReadTag and NewTag function, to centralised the handling of tag creation.
a2f1d92330e8308977f29b01d86d71e9b98ee5e9Redefined the meaning of length and zlength. This makes the definition of length the same for compressed and uncompressed tables.
b6e7f19debbd32f5a933c0bd6b0a037f6287ea94Changed the Table interface so it knows its own name, and changed the parsers to accept []byte instead of io.Reader.
1014c6b35c1c21122c4e17c316c25f6592fe950fNoticed that binary.Read(...) is REALLY slow, got a 3-4x speed up by not using it.
ca60f9b6d23694a72d8009218911578c6461a166Change the font.Table map to be to tableSection pointers. This avoids a bunch of copying.
shurcooL commented on Add support for parsing WOFF2 fonts. in github.com/ConradIrwin/font1d
I've merged https://dmitri.shuralyov.com/font/woff2/...$changes/1. Going to resolve conflicts now.
shurcooL pushed to master in dmitri.shuralyov.com/font/woff21d
957792cbbdabb084d484a7dcfd1e5b1a739a0cedAdd initial parser implementation.
shurcooL commented on talks.godoc.org still links to go-t… in github.com/golang/gddo1d
Reopening for tracking when the fix has been deployed.
shurcooL commented on Add ability to set operation names … in github.com/shurcooL/graphql1d
I've reviewed this but come up with a question about which API to go with. See #12. We need to come to a decision there in order to proceed with merging this.
shurcooL commented on Support specifying operation names. in github.com/shurcooL/graphql1d
@seanpile has already created PR #8 that resolves this issue. In it, he mentioned: > This is a backward compatible change, although you could argue that operation name should be a first class citi…
shurcooL commented on Add support for parsing WOFF2 fonts. in github.com/ConradIrwin/font1d
@ConradIrwin It is ready from my side. I've responded to all review comments so far, and I was just waiting in case there would be any further review comments. I'll go ahead and merge that change …
This Week
shurcooL pushed to master in dmitri.shuralyov.com/service/change2d
767600363629289bbc9da5b0ebe76ee1389a8d6bmaintner: Support GetDiffOptions; populate Change.Replies.
shurcooL commented on OpenGL 4.6 support. in github.com/go-gl/glow2d
@errcw Did you see #91 before making #92?
shurcooL pushed to master in dmitri.shuralyov.com/service/change2d
345df30e663312345caa0f4588bc6b2093a4d960maintner: Implement basic functionality with available data.
shurcooL commented on staticcheck: type assertion shadowi… in github.com/dominikh/go-tools2d
Related issues also include: #168, #110.
shurcooL commented on incompatibility with Golang v1.9 in github.com/cespare/xxhash3d
Go 1.9 added the `math/bits` package. See https://golang.org/doc/go1.9#math-bits. Is your Go installation broken somehow?
Last Week
shurcooL commented on Blackfriday v2 version in github.com/shurcooL/markdownfmt4d
I'll be able to look at this more later, but I'm very interested in this! I've wanted to update `markdownfmt` to blackfriday v2; the only reason I haven't is because I've had higher priorities that p…
shurcooL pushed to master in dmitri.shuralyov.com/service/change4d
c74edf3a9b92e02fd7da1abcd5a3a7632fa3f353githubapi: Use larger page size for ListCommits call.
shurcooL commented on Add support for parsing WOFF2 fonts. in github.com/ConradIrwin/font4d
Friendly ping. Let me know if there's anything I can do to help make progress on this. If there are any concerns about the approach, just let me know.
shurcooL commented on x/tools/go/buildutil: TestContainin… in github.com/golang/go4d
I've sent [CL 94900](https://golang.org/cl/94900) that'll resolve this issue.
shurcooL commented on cmd/go: arbitrary command execution… in github.com/golang/go4d
I've sent [CL 94899](https://golang.org/cl/94899) for golang.org/x.
shurcooL pushed to master in github.com/shurcooL/home4d
fd36f401ae56dd669f30814137a169bb493ac07cinternal/code: Update kebabcase import path.
shurcooL pushed to master in dmitri.shuralyov.com/text/kebabcase4d
40e40b42552a9cb37d6e98f4ad31f63ae53ea43aUpdate import path in test package.
shurcooL commented on go/doc: link detection in ToHTML is… in github.com/golang/go4d
An update on what I said earlier. `]` is not one of the safe characters that can be included in a URL without encoding (according to https://www.ietf.org/rfc/rfc1738.txt). RFC 1738 says it must to be…
shurcooL commented on cmd/go: arbitrary command execution… in github.com/golang/go4d
> My inclination right now is to go with my CL (94603) for patch releases, including 1.10.1, but go with @Invizory 's CL (94656) for 1.11. That should give us plenty of time to find out whether full …
shurcooL commented on changes to allow the output of the … in github.com/kisielk/errcheck4d
Minor style nit. There should be a space after `//`. See https://dmitri.shuralyov.com/idiomatic-go#comments-for-humans-always-have-a-single-space-after-the-slashes.
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs5d
CI is now green! ✅ I've created PR #755 that will resolve this issue. I invite everyone to test and/or review it. Thanks!
shurcooL commented on path/filepath: go test fails when G… in github.com/golang/go5d
For what it's worth, I think it's fine if such an issue comes up occasionally because of no "read-only builder". If it comes up, it can be reported, and then fixed. If no one notices for some time, t…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs5d
490aeb592b56fd50c5d4766ea4133d53a332b3a4compiler/natives: Regenerate.
28e102cafab52fc8b6ccac116e06766a82f3026ecompiler/natives/src/reflect: Override Value.assignTo method, drop v.Kind() == Interface && v.IsNil().
5e5d2d2a995bbb99a0843ca37c6db7bbc102101dRevert "compiler/natives/src/reflect: Return true in IsNil for implicitly converted nil interface."
7729020c1f3122ecdd49acc30b26e603ec3d3d6eTarget Go 1.10 final.
0bd5ec1a0c9ec164dd2ad59b47d31e1794034cf3compiler/natives/src/encoding/gob: Skip TestTypeRace.
12f65e290eece74bee294bbe70eaca80c764a7eecompiler/natives/src/io: Skip TestMultiWriterSingleChainFlatten.
446447afae62be20519fa168eac7cfd97868ddf3compiler/natives/src/strings: Skip optional pointer manipulation.
4bff1ed141973ca59a263e04e376ef365ffb13c6doc: Document partially supported packages in more detail.
8fc1f3cabe719f570ed9a95ca3574aca26408855build: Exclude linux-specific crypto/rand tests.
7c7c56991f8dadbf12b1793d95c035390c4ac3f1tests: Triage test failures new to Go 1.10.
397649b8666f6ed0b7caa94d17d7beb69c49c872Target Go 1.10 RC 2.
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs5d
I'm actively investigating the `html/template` failure now. I think I've finally cracked it. This wasn't trivial to track down. I started with the following simplified test case from `html/templat…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs5d
shurcooL commented on Replaces sync import with nosync be… in github.com/gopherjs/gopherjs5d
Perfect, that's very helpful, thanks!
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs5d
2252e22ab1f55d18c6ea8fc05c0bcd1fa8c9cbd9compiler/natives: Regenerate.
aff7ec6c50475ce318f8f26293e70d7658db3ec4compiler/natives/src/encoding/gob: Skip TestTypeRace.
shurcooL commented on Replaces sync import with nosync be… in github.com/gopherjs/gopherjs5d
Thanks for reporting this and sending a PR. Do you have any suggestions for how I can verify that this is a problem, and that the PR fixes it? I want to confirm your findings. If I understand c…
shurcooL commented on Don't use 'nosync' for the standard… in github.com/gopherjs/gopherjs5d
I ran into this during work on Go 1.10 support as well, in package `encoding/gob`. It currently uses `nosync`, and a new test in 1.10 is failing. If it's made to use real `sync` package, then the tes…
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs5d
Working on the `encoding/gob` failure now. I've figured out why it's happening, just need to decide on a resolution now. Only 1 more thing left to investigate go after this.
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs5d
Fixing `io` turned out easy, `TestMultiWriterSingleChainFlatten` just needed to be skipped because it uses unsupported runtime features. Done in commit e11ce777d8cabfb640c9fd1ac44cc56a9bb12480.
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs5d
7268865099fe45cddf1828bbadb707e1f7a1b96dcompiler/natives: Regenerate.
e11ce777d8cabfb640c9fd1ac44cc56a9bb12480compiler/natives/src/io: Skip TestMultiWriterSingleChainFlatten.
e91feeac4ca0ac5c5a4a4308d673bdcd4160c069compiler/natives/src/strings: Skip optional pointer manipulation.
3ec97f3cacecf92b33c60da819d71d6d2c0bfadddoc: Document partially supported packages in more detail.
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs5d
072e78d62beb52a1fee84a947d677578a16b8558Revert "compiler/natives/src/reflect: Don't skip string internalization for types."
9d5176b3c1a295fefefe9538d8b4cab1cb83a367compiler/natives/src/reflect: Implement throw.
8b2ca4bdee5d89b5c3a669b2f0b2ab4a9130e9bacompiler/natives/src/strings: Simple Builder implementation for js architecture.
3e6aba56150158c65e956009038fd8e5a5acd72bcompiler/natives/src/testing: Override frameSkip to avoid runtime.Callers.
1fb1aaaca99f647eaf7ca2ce6b3bc1f8aab27ef8compiler/natives/src/reflect: Return true in IsNil for implicitly converted nil interface.
a85517404324586ae512aa3ad40041323d8246f6compiler/natives/src/reflect: Skip TestCallReturnsEmpty.
5fab10db8c5416011eefa4eb6b404bcf9285d28acompiler/natives/src/reflect: Don't skip string internalization for types.
c4db7b2ec4f61a91265715577fcbab8164f676f2WIP: Hacky fix for wrong method set order with unicode.
87f956b642b426f988b227c341aeb88d8b58764dcompiler/natives/src/reflect: Update method indexing for non-ASCII exported methods.
66c17b11e4b071348e97a636fa3d9d115651b41ccompiler/natives/src/reflect: Update mutability of non-exported embedded fields.
9c9c7cd9608a8df35937eb75dc2969d3850277d2compiler/natives/src/reflect: Allow Copy from string to []byte.
9d71b8d703a4bdc663dfbcad970958c4847781bacompiler/natives/src/internal/poll: Implement semaphores.
605cc217f5da6a359139fad18041c66764c2e32fcompiler/natives/src/syscall: Provide implementation of Exit.
d796bf55a339fd9ff3a939dbf354e9e097292649compiler/natives/src/reflect: Change makechan size parameter type from uint64 to int.
2556b29edd4c43456a30e7388821f823eceb7821compiler/natives/src/reflect: Remove pkgPath parameter from newName.
232d13255c33ee96cb41da28f480c888b4a47543compiler/natives/src/time: Update for internal code reorganization.
a57c0828a67c8575f53236bdb3f1b984c839b9b2compiler/natives/src/math: Remove Dim implementation.
622f536f57135bff38a582c85afe55f6cd0baec4compiler/natives/src/runtime: Add stubs for getcallerpc, findfunc, funcname.
fa8fb1b0e439b027e84c5af269725890b8cebadcTarget Go 1.10 Beta 1, update version to GopherJS 1.10-wip.
3926a9f66452f7a8c8d9c0e4e3074383f9aff5cdinternal/sysutil: Fix build error on FreeBSD due to Rlimit.Cur type mismatch. (#752)
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs5d
I've figured out the `strings` `TestBuilder` failure. It's because of some `unsafe.Pointer` manipulation added in rc2 (see golang/go@484586c81a0196e42ac52f651bc56017ca454280). Just need to remove it.…
shurcooL commented on Skp in github.com/shurcooL/Hover5d
I believe SketchUp itself can export as dae. That’s what I did, at least in the version of SketchUp I used, which was some time ago.
shurcooL commented on x/tools/imports: Feature Request: A… in github.com/golang/go5d
I suspect the best way to resolve this issue might be to decide that "forking `imports` is the best way to customize its behavior", because it seems very very hard to come up with a better way.
shurcooL commented on x/tools/imports: consider exporting… in github.com/golang/go5d
This issue seems related to #12696. Although I don't know how exporting only `FixImports` helps. The PR doesn't seem to help facilitate the decision, because it doesn't communicate why `FixImports…
shurcooL pushed to master in github.com/shurcooL/home5d
e3419152b2c71854ae6a88dbbc4abba02aed6a5dSet session on context in git server.
b74f19d96502cc0452e09fdd71141f74748c53a5issues, changes: Use "/..." suffix in title for github repos too.
shurcooL pushed to master in github.com/shurcooL/events5d
08857041db7c52b374e58991c0482fe187f8b29afs: Add authorization check to Log.
shurcooL pushed to master in github.com/shurcooL/home5d
86a9cb4617bbad7385ac5ce6235f730574a0c8d5issues: Don't consider /idiomatic-go as a Go repo.
shurcooL commented on Potential false negative, didn't re… in github.com/mvdan/unparam6d
Thanks again; this is great!
shurcooL pushed to master in github.com/shurcooL/home6d
ca7cb7b09f6984a6ac947547452823a217bf55f2Link GitHub issues/PRs to local apps for shurcooL user.
shurcooL pushed to master in github.com/shurcooL/events6d
687fb6b1a26ab3ace9b4b3dfd9c66d6b4c294e56githubapi: Use github.Router for issue and change HTML URLs.
shurcooL commented on Comments for humans always have a s… in dmitri.shuralyov.com/idiomatic-go6d
Yes, `// +build` is an exception that comes from pre-1.0 times. It doesn't invalidate the point made here. The main reason for this entry is *consistency* with existing code. There was a proposal to…
shurcooL pushed to master in github.com/shurcooL/notifications6d
2acc6a83825b8261f1586ab2e11d01de56e70aebgithubapi: Factor out Router into standalone package.
shurcooL created repository dmitri.shuralyov.com/route/github6d
Package github defines a router for targeting GitHub subjects.
shurcooL pushed to master in dmitri.shuralyov.com/service/change6d
8371dbf1bbdfedfb1249989c3e0b277143ede61agithubapi: Avoid using embedded pointer to unexported struct.
shurcooL pushed to master in github.com/gopherjs/gopherjs1w
3926a9f66452f7a8c8d9c0e4e3074383f9aff5cdinternal/sysutil: Fix build error on FreeBSD due to Rlimit.Cur type mismatch. (#752)
shurcooL pushed to rlimit_freebsd in github.com/juergenhoetzel/gopherjs1w
2cd41d7d91d7e7f4b9d46a2d42c6fb921b18b988internal/sysutil: Document why type conversion is necessary.
shurcooL commented on go/vcs: add package comment in github.com/golang/tools1w
### Before ![image](https://user-images.githubusercontent.com/1924134/36227239-6f100776-119e-11e8-9b97-b4e2972d5529.png) ### After ![image](https://user-images.githubusercontent.com/1924134/…
shurcooL deleted branch in github.com/shurcooL/tools1w
vcs-doc
shurcooL pushed to master in github.com/shurcooL/Hover1w
shurcooL pushed to master in github.com/shurcooL/notifications1w
6ddfc4f3a7333c8050c6e30ddda0cd74d7cf4ebbgithubapi: Sync with issues/githubapi, change/githubapi.
shurcooL pushed to master in github.com/shurcooL/issues1w
3db36ea3fa8a58c6a40b124166c46e4dd769f49dgithubapi: Change ghV3User to accept value, not pointer.
47ac47af2acf5dd1e86a83227704e37f350aa210Document expectation to include domain in issues.RepoSpec.
shurcooL pushed to master in dmitri.shuralyov.com/service/change1w
2fb0e89b2ed38899ef391fdf285fad155e9bc230githubapi: Sync various improvements from issues/githubapi.
shurcooL pushed to master in github.com/shurcooL/tictactoe1w
ecb4d472d527ddb97e427be037b8214a6ef2682dcmd/tictactoe: Use document.ReadyState to not miss DOMContentLoaded event.
shurcooL commented on Potential false negative, didn't re… in github.com/mvdan/unparam1w
Looking to clarify. This issue was marked as resolved in commit ed0d5d54fb556ea0c2330b5c5d4d32cc80086f96 with the following message: ``` check: "result X is always nil" with one return Before,…
shurcooL commented on Roadmap. in github.com/shurcooL/githubql1w
Good news, I've just checked off the following box: > - [x] Directives (haven't tested yet, but expect it to be supported). I've tested [GraphQL directives](http://graphql.org/learn/queries/#di…
shurcooL pushed to master in github.com/shurcooL/home1w
10d947de8e2758bf2441cf414662c59c45aec527Implement issues.TimelineLister in shurcoolSeesGitHubIssues.
shurcooL pushed to master in github.com/shurcooL/issuesapp1w
a882069ebb79b8d8a92f91fa9df3b6db810e286dMake use of optional issues.TimelineLister interface.
shurcooL pushed to master in github.com/shurcooL/issuesapp1w
e5fc7b08fde5b9ad1cd8fffa4d1dd72092913877Make use of optional issues.TimelineLister interface.
shurcooL pushed to master in github.com/shurcooL/issues1w
4081aa59e957752abbfc6b6fdab72c3bbc1c1decAdd optional ListTimeline method; implement it in githubapi.
36fff28db4d1f8abcc8bce30659f0ad759331307githubapi: Combine two GraphQL queries in ListComments.
8e4d78e17470533663c73d0467710f43de1f8d16githubapi: Support bot actors.
shurcooL commented on Broken build on master in github.com/shurcooL/Go-Package-Store1w
Thanks for reporting. The package that fails it build is only used on frontend, and in normal build, it uses a pre-compiled version from `assets` package. That’s why `cmd/Go-Package-Store` works. …
shurcooL commented on Experiment: compiling go packages -… in github.com/gopherjs/gopherjs1w
Thanks for letting us know. There are multiple issues open that discuss the similar topic of "having GopherJS produce rather than a single javascript file, multiple files - one for each Go package…
shurcooL commented on proposal: reconsider allowing emacs… in github.com/golang/go1w
One benefit of the current policy is that it makes it easy to reject CLs (and discourage them from being created) that try to add "SomeObscureAndQestionableFile" to `.gitignore`. If this proposal …
shurcooL commented on Add the packaging metadata to build… in github.com/rsc/2fa1w
Isn’t the canonical import path `rsc.io/2fa`? That’s what it says in the README.
shurcooL pushed to master in dmitri.shuralyov.com/service/change1w
ede004665f39daffb01fdd6c41652a2ff7ac6901fs: Add second commit to mock data.