Activity
Today
dmitshur reviewed +2 on golang.org/x/mobile/internal/binres: use %v to format pool string data4h
Thanks.
I don't mind seeing a note like this in a code review comment, but I'm not sure about including it in the commit message itself. Perhaps this is still a topic being discussed and I may chang…dmitshur commented on golang.org/x/mobile/...: update the go directive to 1.26.05h
(4 comments)
Consider making this commit message much shorter, focusing on the problem being surfaced by the Go 1.26 vet check (#72850). For example, compare with similar CLs for x/sys and x/exp: CL…Yesterday
dmitshur commented on golang.org/x/exp/errors/fmt: use %d formatting verb for int6h
Thanks.dmitshur opened a change go.dev/wiki/DashboardBuilders: add notes on Python 3 version6h
As suggested at https://go.dev/issue/80220#issuecomment-5350598333,
it can be helpful to say a few more words about the exact Python 3
version that should be used. Also, an optional reference, point …dmitshur commented on golang.org/x/build: LUCI swarming bot works with Python 3.13 but not Python 3.14 due to reliance on removed pkgutil.get_loader6h
It's not very visible on the issue, but as of today it does have a pending code change (https://crrev.com/c/8265616).dmitshur commented on golang.org/dl/internal/version: add explanatory comments to runGo6h
Thanks.dmitshur commented on golang.org/dl/internal/version: add explanatory comments to runGo6h
CL 763260 moved some of this code; rebased in PS 2.dmitshur opened a change golang.org/x/exp/errors/fmt: use %d formatting verb for int9h
It's caught by Go 1.26's vet check that the format %q here is
given a wrong type int. The formatting verb %d is appropriate.dmitshur commented on golang.org/x/sys/windows: pass rune to %q formatting verb9h
Unfortunate timing of my reply with Commit-Queue... Bypassing trybots since they did pass on patchset 1.dmitshur commented on golang.org/x/sys/windows: pass rune to %q formatting verb9h
(1 comment)dmitshur opened a change golang.org/x/sys/windows: pass rune to %q formatting verb9h
It's caught by Go 1.26's vet check that the format %q here
is given a wrong type uint16. Convert it to a rune instead.dmitshur commented on golang.org/x/mobile/...: upgrade go directive to at least 1.26.0 [generated]10h
Thank you!
Yes, proposal #69095 was about having a policy and automation to maintain the minimum value of the `go` directive in golang.org/x modules, and this CL is a part of that, but it's possible…dmitshur fixed an issue cmd/internal/testdir:1_10: Test/codegen/arithmetic.go failures [consistent failure]10h
Closed by merging [CL 815220](https://go.dev/cl/815220) (commit 983064c1b5bd8e0ad581607aa140167c698cd4eb) to release-branch.go1.25.dmitshur closed an issue cmd/compile: ppc64 `MADDLD` lowering rules depend on the values schedule [1.25 backport]11h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed an issue os: TestRootMultiMkdirAllShallow failures on openbsd [consistent failure] [1.25 backport]11h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed an issue runtime: async preemption corrupts AVX (YMM) state on netbsd/amd64 [1.25 backport]11h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed a change internal/cpu: [release-branch.go1.25] disable AVX+ on netbsd/amd6411h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed a change os: [release-branch.go1.25] don't symlink on Root.Mkdir("symlink/") on openbsd11h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed a change crypto/x509: avoid false wildcard matches for 2-label exclusions11h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed a change cmd/compile: [release-branch.go1.25] fix up backport of CL 80324011h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed a change cmd/go: [release-branch.go1.25] test barrier actions11h
With the release of [Go 1.27.0](https://go.dev/doc/go1.27), the two supported major Go releases are 1.27 and 1.26 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.…dmitshur closed an issue golang.org/x/mobile: type aliases no longer export12h
Tentatively closing this as a duplicate, but please comment here or in issue #70698 if there's still an issue.dmitshur commented on golang.org/x/mobile: type aliases no longer export12h
@xcolwell I believe support for type aliases in x/mobile was already added as of [CL 740861](https://go.dev/cl/740861), so the temporary workaround of setting GODEBUG manually in the environment shou…dmitshur commented on golang.org/x/build: go1.26-linux-s390x & go1.27-linux-s390x trybots fail during bootstrap12h
I found [go.dev/cl/804720](https://go.dev/cl/804720) that matches this description, is that what you're referring to? If so, the issue in that CL is that it's on the main branch, so it needs to use "…dmitshur commented on golang.org/x/build: go1.26-linux-s390x & go1.27-linux-s390x trybots fail during bootstrap13h
@srinivas-pokala Thanks for reporting this. Can you please include links to where you ran into this?
One possibility is that the builder names and repository branch names are out of alignment. In th…dmitshur commented on golang.org/x/build/main.star: apply a known issue to missing power8 builders13h
Thanks.dmitshur opened a change golang.org/x/build/main.star: apply a known issue to missing power8 builders13h
As visible on the build dashboard¹² and reported in go.dev/issue/80703,
the power8 builders are gone. Annotate them with a known issue to hide
some purple boxes from the build dashboard, making it …dmitshur commented on golang.org/x/build/main.star: clean up after dropping release-branch.go1.2513h
Thanks.dmitshur commented on golang.org/x/build/main.star: update supported Go versions and drop release-branch.go1.2513h
Thanks.dmitshur commented on golang.org/x/website/_content/doc: add go1.28.md placeholder13h
Thanks.dmitshur opened a change golang.org/x/build/main.star: clean up after dropping release-branch.go1.2514h
Delete code that became dead as of CL 818140. Generated files unchanged.dmitshur commented on golang.org/x/website/_content/doc: add go1.28.md placeholder14h
This change is ready for review.dmitshur opened a change golang.org/x/website/_content/doc: add go1.28.md placeholder14h
Add this file now that it's possible to preview the release notes draft
at https://tip.golang.org/doc/go1.28.
For golang/go#80959.dmitshur opened an issue doc: write release notes for Go 1.2814h
This is the tracking issue for writing the Go 1.28 Release Notes. The version at tip can be viewed at https://tip.golang.org/doc/next.
When we have a fairly complete release notes draft, enough for …dmitshur reviewed +2 on golang.org/x/website/_content/tour: add missing code tag to var keyword14h
Thanks.dmitshur opened a change golang.org/x/build/main.star: update supported Go versions and drop release-branch.go1.2515h
The Go 1.27.0 release is out, so 1.26 is the oldest supported release.¹
The previous infrastructure (cmd/coordinator) does this automatically,
whereas here I authored this CL manually. We'll explore…dmitshur reviewed +2 on golang.org/x/telemetry/godev: update telemetry docker versions to 1.2615h
Thanks.
Since by now a stable version of Go 1.27 is also available and should work as well as Go 1.26 and better, you could go to it directly. Its other advantage is that it'll be supported for 6 mo…dmitshur commented on golang.org/x/build/...: apply 'go fix ./...' after go 1.26.0 is minimum16h
Thanks.dmitshur commented on golang.org/x/build/...: apply 'go fix ./...'16h
Thanks.dmitshur commented on golang.org/x/build/...: apply 'go fix ./...'16h
This change is ready for review.dmitshur reviewed +2 on golang.org/x/website/internal/history: remove draft notice, update deployment, add Go 1.2717h
Thanks. One optional comment.
Hmm, I noticed that in [Go 1.24 release notes](https://go.dev/doc/go1.24) and older this was linked. I'm not sure why 1.25 onwards stopped doing it, and I wonder if may…dmitshur closed an issue golang.org/x/tools/godoc/vfs/zipfs: `New` can't be called with a `*zip.Reader`18h
This package has been deprecated, tagged, and deleted as part of #59056.dmitshur closed an issue golang.org/x/tools/godoc: remove replaceLinePrefixCommentsWithBlankLine in favor of better fix18h
This package has been deprecated, tagged, and deleted as part of #59056.dmitshur closed an issue golang.org/x/tools/godoc/vfs: path separator character(s) in FileSystem, Opener interfaces is not specified18h
dmitshur commented on github.com/gophers-latam/go-tour-es/fix: point feedback button to gophers-latam/go-tour-es issue tracker18h
Thanks! This will fix #26.dmitshur opened an issue github.com/gophers-latam/go-tour-es: 'Send feedback about this page' doesn't point to this issue tracker19h
Hello,
I see that the README at https://github.com/gophers-latam/go-tour-es#%EF%B8%8F-reportar-issues already points to this issue tracker for issues with the Spanish translation of the Go tour. How…dmitshur reviewed +2 on golang.org/x/website/internal/history: document Go 1.26.7 and Go 1.25.1419h
Thanks.This Week
dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]1d
dmitshur commented on cmd/compile: always do rewriteCondSelectIntoMath for powers of two1d
(1 comment)
I see - apologies about the false positive 😅 and thanks for already taking this into account.dmitshur commented on cmd/compile: always do rewriteCondSelectIntoMath for powers of two1d
(1 comment)
In future commit messages, please consider this commit message suggestion from https://go.dev/wiki/CommitMessage:
> when referencing CLs, prefer saying “CL nnn” or using a go.dev/cl…dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]1d
dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]1d
dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]1d
dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]1d
dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]_07_09_20251d
dmitshur commented on golang.org/x/website/tour: add a Spanish translation1d
@thiagomowszet@gmail.com Is there an issue tracker that can be used to report issues related to the Spanish translation of the tour at https://go-tour-lat.appspot.com/ ? The 'submit feedback' button …dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]1d
Other than a URL, this is an empty issue without any of the needed details.dmitshur closed an issue golang.org/x/tour/tour: [REPLACE WITH SHORT DESCRIPTION]1d
Other than a URL, this is an empty issue without any of the needed details.dmitshur commented on cmd/compile: ppc64 `MADDLD` lowering rules depend on the values schedule [1.25 backport]1d
That other option is what [CL 815220](https://go.dev/cl/815220) does if I understand correctly.dmitshur commented on golang.org/x/vulndb/go.mod: update github.com/go-git/go-git1d
(1 comment)
Is it expected that `go mod tidy` seemingly undoes this change (because the newly added requirements are only indirectly used)? This repo seems to use go-git/v5.dmitshur commented on net/http: [release-branch.go1.25] clear ReadHeaderTimeout after accepting an unencrypted h2 conn1d
Patchset 3 passed all trybots, except go1.25-wasip1-wasm_wasmtime failed in time package due a timeout. It doesn't seem related, and it passed on second try, so adding bypass.dmitshur commented on crypto/tls: client handshake tests hardcode TLSv1.0 [1.27 backport]1d
Moved this back to Go1.27.1 milestone to reflect today's discussion in a release meeting.dmitshur commented on cmd/compile/internal/test: TestMergeLocalsIntegration fails on s390x in go1.26.61d
This looks related to issue #80484. It already has backport CLs in progress at [CL 812920](https://go.dev/cl/812920) and [CL 812920](https://go.dev/cl/812920), can you please check if those are enoug…dmitshur commented on cmd/internal/obj/x86: don't use LEAVE on plan9/amd641d
I'm not sure if retrying trybots will help. This passed on all trybots other than gotip-plan9-amd64 itself, but gotip-plan9-amd64 has a still-open known issue #63600 and it hasn't been green at https…dmitshur commented on cmd/asm: riscv64 VRORVI rejects valid immediate values from 32 to 631d
CC @golang/riscv64.dmitshur commented on cmd/compile: internal compiler error with >1000 package-level vars and multi-return function call1d
@Jorropo Are you referring to the fix in [CL 737880](https://go.dev/cl/737880) that was reverted (in [CL 794180](https://go.dev/cl/794180))? If so, that fix originally fixed issue #77153, and that is…dmitshur commented on crypto/tls: client handshake tests hardcode TLSv1.01d
CC @golang/security, @golang/release.dmitshur reviewed +2 on golang.org/x/mobile/cmd/gomobile: invoke the NDK Clang directly1d
Thanks.dmitshur reviewed +2 on golang.org/x/benchmarks/cmd/bent: lower default go.mod version to 1.251d
Thanks.
We'll stop very soon, after Go 1.27.0 is released. But that indeed hasn't happened quite yet.dmitshur fixed an issue access: add new members to port-maintainers/s390x team1d
I see both invitations have been accepted, so this should be done. Please comment if something got missed. Thanks.dmitshur fixed an issue access: add new members to port-maintainers/s390x team1d
dmitshur commented on access: add new members to port-maintainers/s390x team1d
I see both invitations have been accepted, so this should be done. Please comment if something got missed. Thanks.dmitshur reviewed +2 on golang.org/x/build/dashboard: update owners for host-linux-s390x1d
Thanks.
Please consider adding a reference to issue #80843 here. That way it may be easier to find if someone needs to.
```
For golang/go#80843.
```dmitshur commented on golang.org/x/website/_content/doc/go1.24: fix typo2d
This passed on most builders; the few failure are due to unrelated 500s from Gerrit rather than the change content.dmitshur reviewed +2 on golang.org/x/build/main.star: add goamd64v3 perf builders2d
Thanks.
Do you know if having GOAMD64=v3 set in the environment will be enough and propagate to the rest of the perf tooling, without being cleared away for a consistent performance benchmarking sta…dmitshur commented on access: add new members to port-maintainers/s390x team2d
Thanks for your work on maintaining the GOARCH=s390x port. @kmvijay-IBM and @prophet6250 should now have invitations to join the @golang/s390x team.dmitshur commented on access: add new members to port-maintainers/s390x team2d
CC @golang/release, @golang/s390x.dmitshur fixed an issue access: may-start-trybots for sunny@golang.org2d
Your golang.org account should work now.dmitshur reviewed +2 on golang.org/x/build/devapp/owners: remove commandlineTeam and replace with matloob2d
Thanks.
Something to consider: a "release" team doesn't exist either, but we kept the GitHub team behind and repurposed it to be, as it's currently described:
> Members of this team are notified vi…dmitshur commented on golang.org/x/build/internal/perf: add "|" to InfluxDB allowed-in-string chars2d
(1 comment)
Something like this, perhaps:
```suggestion
var validateRe = regexp.MustCompile(`^[a-zA-Z0-9(),=/_:;.-|]+$`)
```dmitshur commented on golang.org/x/build/internal/perf: add "|" to InfluxDB allowed-in-string chars2d
(1 comment)
Oh, is the newly permitted '|' meant to go before the '$' (end of string)?dmitshur reviewed +2 on golang.org/x/build/internal/perf: add "|" to InfluxDB allowed-in-string chars2d
Thanks.dmitshur commented on github.com/mdempsky/unconvert/...: update go and dependency versions3d
Thanks.dmitshur deleted branch in github.com/mdempsky/unconvert3d
go-126-125dmitshur merged a change github.com/mdempsky/unconvert/...: update go and dependency versions3d
dmitshur commented on golang.org/x/website/internal/dl: sort multi-digit prerelease versions numerically3d
(1 comment)
```suggestion
Fixes golang/go#80907
```dmitshur commented on golang.org/x/website/internal/dl: sort multi-digit prerelease versions numerically3d
(2 comments)
This works, but given version.Compare exists, we could replace the entire versionLess helper with it.
So, please delete versionLess entirely, and in the places that currently use versi…dmitshur reviewed +2 on golang.org/x/review/...: remove double space in copyright headers3d
Thanks.
From a [quick search](https://cs.opensource.google/search?q=%22The%20Go%20Authors.%20%20All%20rights%20reserved.%22&sq=&ss=go), there may be a few more repos like x/arch, x/debug, x/perf tha…dmitshur opened a change github.com/mdempsky/unconvert/...: update go and dependency versions3d
Using too old of an x/tools version causes newer toolchains such as go1.27rc3 to run into errors like 'internal error: package "strings" without types was imported'. Updating to a newer x/tools versi…Last Week
dmitshur opened a change os: [release-branch.go1.25] don't symlink on Root.Mkdir("symlink/") on openbsd5d
POSIX says you follow the symlink, but some platforms don't.
Add OpenBSD to the list of ones that don't.
For #80386.
Fixes #80888.dmitshur opened a change os: [release-branch.go1.26] don't symlink on Root.Mkdir("symlink/") on openbsd5d
POSIX says you follow the symlink, but some platforms don't.
Add OpenBSD to the list of ones that don't.
For #80386.
Fixes #80889.dmitshur opened a change os: [release-branch.go1.27] don't symlink on Root.Mkdir("symlink/") on openbsd5d
POSIX says you follow the symlink, but some platforms don't.
Add OpenBSD to the list of ones that don't.
Fixes #80386.dmitshur commented on os: TestRootMultiMkdirAllShallow failures on openbsd [consistent failure]5d
This is already fixed for Go 1.28 by [CL 800700](https://go.dev/cl/800700), but it still happens on release branches.
@gopherbot Please consider this for backport. It's a small OpenBSD-only change t…dmitshur commented on golang.org/x/oauth2/google: change the snake case endpoint to kebab-case5d
Done in patchset 4.
Fix applied.dmitshur reviewed +2 on golang.org/x/build/buildlet: ensure bytes are drained before network connection5d
Thanks.
I find this description a little unclear since it doesn't say which bytes.
My current understanding is that the /connect-ssh HTTP handler first writes an HTTP response to the POST request, …dmitshur commented on golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for the main branch)5d
@rhysh made a suggestion to consider sending an email to golang-dev to notify Go developers at tip when the PRIVATE-track security fixes have finished landing. Adding a note here since this would be …dmitshur commented on golang.org/x/net/idna: New(VerifyDNSLength(true)).ToASCII rejects hosts that contain a trailing period5d
This issue is currently in the Unreleased milestone, meaning it's only associated with the golang.org/x/net module and not the main Go release cycle. Is it expected that the fix will be inside the x/…dmitshur commented on cmd/compile: [release-branch.go1.27] do not home mul/div results in HI/LO5d
Done. We decided this is okay for go1.27.0.dmitshur commented on cmd/compile: [release-branch.go1.25] fix up backport of CL 8032405d
Minor release is done, dropping hold.
This backport CL is ready, but CL 812920 still needs a review.dmitshur commented on cmd/compile: [release-branch.go1.26] fix up backport of CL 8032405d
Minor release is done, dropping hold.