Activity
Today
dmitshur opened a change cmd/cgo/internal/test: [release-branch.go1.25] use (syntactic) constant for C array bound2h
A test in C has an array bound defined as a "const int", which is
technically a variable. The new version of C compiler in Xcode 26
beta emits a warning "variable length array folded to constant
arra…dmitshur fixed an issue cmd/cgo/internal/test: build error on macOS 26 in Go 1.252h
dmitshur fixed an issue cmd/cgo/internal/test: build error on macOS 26 in Go 1.252h
Closing as fixed in Go 1.26 by [CL 692877](https://go.dev/cl/692877).dmitshur commented on cmd/cgo/internal/test: build error on macOS 26 in Go 1.252h
Closing as fixed in Go 1.26 by [CL 692877](https://go.dev/cl/692877).dmitshur commented on cmd/cgo/internal/test: build error on macOS 26 in Go 1.252h
Thanks. Since this is a test-only fix, and should be safe, we can probably backport it. (Another option would be to skip the test, but that doesn't seem to be needed.)
@gopherbot Please consider thi…dmitshur opened an issue cmd/cgo/internal/test: build error on macOS 26 in Go 1.252h
The recently added darwin/arm64 builder with macOS 26 (issue #76798) uncovers a failing test on [release-branch.go1.25](https://ci.chromium.org/ui/p/golang/builders/ci/go1.25-darwin-arm64_26):
I can…dmitshur commented on golang.org/x/build/main.star: add darwin-amd64_15 builder3h
Thanks.dmitshur commented on golang.org/x/build/main.star: unskip linux/mipsle builders for golang.org/x repos3h
Thanks.dmitshur opened a change golang.org/x/build/main.star: add darwin-amd64_15 builder3h
For golang/go#77997.dmitshur opened an issue golang.org/x/build: add darwin/amd64 builders with macOS 15 (macOS Sequoia)3h
This is a tracking issue for adding darwin/amd64 builders with macOS 15 (macOS Sequoia).
We already have darwin/arm64 builders ones with it as of #73397.
CC @golang/release, @golang/darwin.dmitshur opened an issue golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for the main branch)4h
One of the things left out of initial scope of #77214 was:
> upstreaming to main branch - this has a lot in common to release branches, but we don't have an existing ref for this and there are more …dmitshur commented on io: add an `Err` field to `LimitedReader`5h
The CL still needs to complete the [code review process](https://go.dev/doc/contribute#reviews). It already has reviewers added to it, but perhaps they haven't found the time to get to it. Since it's…dmitshur opened a change golang.org/x/build/{influx,perf}: build Docker images via Cloud Build instead of local Docker5h
For golang/go#70913.dmitshur commented on golang.org/x/build/cmd/relui: request 8 GiB of ephemeral storage5h
Thanks.dmitshur commented on net: TestListenIPv6WildcardAddr failures [consistent failure]6h
Oh, I missed the earlier https://github.com/golang/go/issues/77945#issuecomment-3999348983 where it was mentioned. That looks like an improvement as far as I can tell, so if you don't mind please do …dmitshur opened a change golang.org/x/build/cmd/relui: request 16 GiB of ephemeral-storage7h
Relui may need more scratch space to work with when running tasks
that involve cloning large repositories, such as when upstreaming
private-track security CLs on the release day.
The previous value …Yesterday
dmitshur reviewed +2 on golang.org/x/website/internal/history: document Go 1.26.1 and 1.25.8 releases1d
Thanks.
If this intends to refer to today's date, then:
```suggestion
Date: Date{2026, 3, 5}, Version: Version{1, 26, 1},
```
(Same below.)dmitshur reviewed +2 on net: skip TestListenIPv6WildcardAddr on DragonFly BSD and OpenBSD1d
Thanks.dmitshur commented on net: TestListenIPv6WildcardAddr failures [consistent failure]1d
The TestListenIPv6WildcardAddr test was recently added in [CL 743080](https://go.dev/cl/743080) (CC @ravisastryk, @nicholashusin), and it's consistently failing on openbsd/amd64 and openbsd/ppc64 por…dmitshur closed an issue cmd/link: unknown relocation type 7 when linking resource.syso on windows/amd64 with Go 1.26.01d
dmitshur closed an issue cmd/link: unknown relocation type 7 when linking resource.syso on windows/amd64 with Go 1.26.01d
dmitshur commented on access: may-start-trybots for George Adams1d
CC @golang/release, @cherrymui.dmitshur opened a change golang.org/x/build/main.star: unskip linux/mipsle builders for golang.org/x repos1d
The builder has been added and it's passing all.bash in the main repo.
Move it from TBD_CAPACITY_HOSTS to LOW_CAPACITY_HOSTS and drop its
skip_x_repos option to get closer to fully removing its known…dmitshur reviewed +2 on image/jpeg: make decoder.receiveExtend branchless1d
Thanks.This Week
dmitshur commented on cmd/go: subcommands to add and remove modules from the module cache2d
@bysiber Please avoid posting many repetitive comments in rapid succession in the Go issue tracker. Thanks.dmitshur commented on cmd/go: update "GOPATH environment variable" section to be module-mode first2d
[CL 664235](https://go.dev/cl/664235) updated this section. @matloob Was this issue perhaps intended to be closed by it? (Its commit message said "Fixes #57355" which seems to be 404, and this issue …dmitshur commented on golang.org/x/website/_content/blog/allocation-optimizations: fix typo2d
(1 comment)
Indeed. There's no merge conflict because both CLs made an identical change here, so once rebased, only the fix on line 279 will be applied. Rebasing would be required if there was a mer…dmitshur reviewed +2 on golang.org/x/website/_content/blog/allocation-optimizations: fix typo2d
This was resolved in patch set 2.
Thanks.dmitshur commented on crypto/tls: use %w rather than %s in fmt.Errorf2d
I suggest starting with a brief issue describing this change, and include `CC @golang/security` to let the [owners](https://dev.golang.org/owners) of these packages know. They'll have a better idea w…dmitshur commented on crypto/tls: use %w rather than %s in fmt.Errorf3d
Should a change like this also have tests, updated documentation, and a reference to an issue (or a proposal if this is considered notable enough)? Possibly also a release note for Go 1.27?
Without …dmitshur reviewed +2 on golang.org/x/build/main.star: add darwin-arm64_26 builder3d
Thanks.
👍dmitshur reviewed +2 on golang.org/x/build/cmd/makemac: add darwin-arm64-26 bots3d
Thanks!dmitshur commented on golang.org/x/build/cmd/maintnerd: build Docker images via Cloud Build4d
Thanks.dmitshur commented on golang.org/x/build/maintner/maintnerd: move maintnerd command to x/build/cmd/maintnerd4d
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/makemac: update darwin-amd64-13/144d
Thanks.dmitshur opened a change golang.org/x/build/maintner/maintnerd: move maintnerd command to x/build/cmd/maintnerd4d
Make it easier to maintain (and unify) deployment files for x/build
services by having the commands uniformly live in the cmd directory.
For golang/go#70913.dmitshur opened a change golang.org/x/build/cmd/maintnerd: build Docker images via Cloud Build4d
The intention of CL 707295 was to do this for all x/build services,
but maintnerd was missed.
For golang/go#70913.dmitshur reviewed +2 on golang.org/x/build/cmd/makemac: update darwin-amd64-124d
Thanks.dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.26-vendor] fix rangeint rewriting4d
(1 comment)
> Didn't know gopherbot will close issues for CLs landed on internal-vendor branch.
Ah, I was mistaken when I anticipated that happening, sorry for a misleading comment. It indeed won't…dmitshur commented on cmd/fix: rangeint uses target platform's type in the range expression, breaking other platforms4d
@dagood The change in x/tools repo in [CL 747560](https://go.dev/cl/747560) hasn't been vendored into the main Go repo yet. That will certainly happen in time for Go 1.27 (this issue's milestone), tr…dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.26-vendor] fix rangeint rewriting4d
(1 comment)
Note that this CL alone won't fix #77899; the CL that pulls this change into the [main Go repo's release branch](https://cs.opensource.google/go/go/+/release-branch.go1.26:src/cmd/go.mod…dmitshur commented on robpike.io/ivy/...: read version from Go metadata5d
As an alternative to running 'go build', 'go clean', then 'go install', would it work to skip the first two steps and run 'go install' right away? If there's a build error, 'go install' would report …Last Week
dmitshur starred github.com/bobg/mingo6d
dmitshur commented on cmd/go: change `go mod init` default go directive back to 1.N [1.26 backport]1w
Added a release-blocker label to indicate the release shouldn't happen while this issue is still open.dmitshur commented on cmd/compile: internal compiler error: panic during rewrite tern with GOEXPERIMENT=simd [1.26 backport]1w
@dr2chase This backport issue is still open but without CherryPickApproved nor CherryPickCandidate label. Should this go back to approved but with [CL 749241](https://go.dev/cl/749241) as the new CL …dmitshur commented on cmd/fix: stringscut rewrite changes behavior [1.26 backport]1w
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77737#event-23078589596 to this issue. (CC @dr2chase.)dmitshur commented on cmd/fix: stringscut rewrite changes behavior1w
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77737#event-23012415692).dmitshur commented on cmd/fix: stringscut rewrite changes behavior1w
This issue was marked as fixed by [CL 747900](https://go.dev/cl/747900), but that CL is in the main branch of x/tools. That's sufficient to fix the problem in time for Go 1.27, but this issue is curr…dmitshur closed an issue cmd/compile: internal compiler error: 'main.func1': not lowered: v15, Load STRUCT PTR SSA [1.25 backport]1w
dmitshur commented on cmd/fix: stringsbuilder ignores variables if they are used multiple times [1.26 backport]1w
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77659#event-23078585370 to this issue.dmitshur commented on cmd/fix: stringsbuilder ignores variables if they are used multiple times1w
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77659#event-23004957221).dmitshur commented on cmd/fix: waitgroup leads to a compilation error1w
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77754#event-23010399320).dmitshur commented on cmd/fix: minmax breaks select statements1w
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77671#event-23007156867).dmitshur commented on cmd/fix: reflect.TypeOf(nil) transformed into reflect.TypeFor[untyped nil]()1w
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77636#event-23009845781).dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes [1.26 backport]1w
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77482#event-23078592981 to this issue.dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes1w
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77482#event-23054151261).dmitshur commented on cmd/fix: change -diff to exit 1 if diffs exist1w
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77583#event-22768894147).dmitshur fixed an issue golang.org/x/build: bot linux-s390x-ibm--02 reported as broken1w
dmitshur commented on cmd/fix: rangeint uses target platform's type in the range expression, breaking other platforms1w
This is the main issue, so the CherryPickCandidate label doesn't apply here. There was already #77766 opened to track the Go 1.26.x backport.Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change9modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).