Today
dmitshur commented on cmd/doc: go doc rsc.io/quote/v3 in module mode shows wrong import path1h
Thanks for confirming @mseshachalam. The change was [CL 183991](https://golang.org/cl/183991), you can read its commit message for details. It fixed issue #28992, which was that in some conditions, …
Yesterday
dmitshur commented on doc/go1.13: document removal of NaCl targets in Go 1.1416h
Yes, it needs to be a new CL. You can mention in its commit message that it's a followup to golang.org/cl/185537. Thank you.
dmitshur commented on golang.org/x/build/x/build/cmd/gopherbot: do not consider nested backport requests16h
(1 comment) > Can it be said that any issue with label CherryPickCandidate or CherryPickApproved is a backport? The vast majority do and should, but there are a handful of exceptions (for various r…
dmitshur commented on doc/go1.13: document removal of NaCl targets in Go 1.1417h
(1 comment) I see, you're right, not having an <h3> title if the only entry will be that a port is being removed is consistent. Thanks. On a different note, it might still be helpful to add a id="n…
dmitshur commented on golang.org/x/build/x/build/cmd/gopherbot: do not consider nested backport requests19h
(1 comment) Thanks for working on this. Additional ideas: - Check that gi.Title has the suffix " backport]" instead of just containing backport. This will reduce chance for false positives. - Chec…
dmitshur commented on cmd/gofmt: rewrite 'a->a' breaks declaration inside function literal21h
Thanks for reporting this as well.
dmitshur commented on cmd/gofmt: rewrite 'a->a' adds parentheses around function return type21h
Thanks for reporting this.
dmitshur commented on cmd/gofmt: rewrite 'a -> a' transforms 'default:' into 'case :'21h
Thanks for the report. I checked, this affects Go 1.12.7 as well as Go 1.10.5, so it's not a new regression in Go 1.13 beta 1. Given this and the other 2 issues you reported (#33104, #33105), i…
dmitshur commented on golang.org/x/net/icmp: Hogs CPU on Windows, doesn't capture packets21h
/cc @mikioh @ianlancetaylor per [owners](https://dev.golang.org/owners).
dmitshur commented on : the tool to prioritization the test cases order by coverage rate22h
Hi @gxs929. This seem to be a question rather than an issue. I suggest posting it another medium that is better suited for questions, see https://golang.org/wiki/Questions. Compare to the issue tr…
dmitshur commented on doc/go1.13: document removal of NaCl targets in Go 1.1422h
(1 comment) All the other entries in this Ports section have a <h3> title above them (see https://tip.golang.org/doc/go1.13#ports). Perhaps we should add one for NaCl too?
dmitshur commented on golang.org/x/crypto: NaCl compatibility not clear22h
Also relevant here is that NaCl is close to being removed (1.13 will be the last release to support it), see #30439 and https://tip.golang.org/doc/go1.13#ports.
dmitshur commented on gccgo: go/internal/work forces -fsplit-stack into cgoCFLAGS22h
/cc @ianlancetaylor @thanm @cherrymui per [owners](https://dev.golang.org/owners).
dmitshur commented on golang.org/x/mobile: build failing when using goMobile in Cayley22h
@zhuguocheng29 Thanks for the report. If you are using module mode, let's close this issue in favor of #27234, since it's already tracking the task of resolving that.
dmitshur commented on load plugin crash fatal error: runtime: no plugin module data22h
Thanks for the report. You answered "Does this issue reproduce with the latest release?" with "Yes", I just want to confirm, did you test it with Go 1.12.7 or a different version?
dmitshur commented on golang.org/x/website: inconsistent headers22h
/cc @andybons
dmitshur commented on cmd/go: -failfast flag does not apply across packages22h
/cc @jayconrod @bcmills
dmitshur commented on net: *OpError.Error() should check its Err field22h
The `if e == nil {` check was added by @adg in [CL 1848049](https://github.com/golang/go/commit/fc4ba1546c787a99fbcd037649575c29728655b4), so I'll /cc him in case he has opinions on this issue.
dmitshur commented on net: *OpError.Error() should check its Err field22h
Thanks for the report. I see that the case of `*net.OpError` being nil is currently supported: ```Go func (e *OpError) Error() string { if e == nil { return "<nil>" } [...] } ``` …
dmitshur commented on runtime: memclrNoHeapPointers: unexpected fault address22h
Thanks for the report. Does it happen reproducibly, or is it hard to reproduce? Please let us know if it happens with Go 1.12.7 and/or 1.13 beta 1.
dmitshur commented on cmd/doc: go doc rsc.io/quote/v3 in module mode shows wrong import path1d
Go 1.12.7 does not include it, it's currently only available on the latest `master` branch. You can use [`golang.org/dl/gotip`](https://godoc.org/golang.org/dl/gotip) to try it.
dmitshur commented on golang.org/x/build/cmd/coordinator: add health item for tip.golang.org1d
(1 comment) I spent some time trying to come up with a good new package to contain the ForeachLine* helpers, and found it hard to do so in a way that felt right. It was useful to look at their histo…
dmitshur commented on github.com/shurcooL/graphql: Expecting type ISODateTime1d
Is that a custom scalar type that the GraphQL server you're connecting to defines in its schema? If so, you'll need to define your own Go type accordingly. See [here](https://github.com/shurcoo…
This Week
dmitshur pushed to master in dmitri.shuralyov.com/website/gido1d
5275a64acd14885a8d67315e2b66570347b757afdetermine directories by walking Go repositories
Last Week
dmitshur pushed to master in github.com/shurcooL/events2d
de7d109ebe4c7eb08603fe3535fbd2ee84be2fbagithubapi: handle not found errors from fetchModulePath
dmitshur pushed to master in github.com/shurcooL/events2d
fe45bbe529ac7937f3f46c314924f8d7725449cfgithubapi: handle not found errors from fetchModulePath
dmitshur commented on cmd/doc: go doc rsc.io/quote/v3 in module mode shows wrong import path2d
@mseshachalam Did you have a copy of `rsc.io/quote` repository in your GOPATH/src? Can you check if commit 3b040b7e8088ad2c02e413a4abf7effcd62373d0 fixes it?
dmitshur commented on golang.org/x/mobile/bind: Reflection to get ApplicationContext is disallowed on Android P (API Level 28) and causes a crash on Android Q3d
This was resolved via [CL 175103](https://golang.org/cl/175103), closing. (The reason it wasn't closed automatically is because the "Fixes #31364" line in the commit message was missing the "golan…
dmitshur commented on golang.org/x/build/cmd/coordinator: add health item for tip.golang.org3d
(1 comment) The functionality certainly is very similar. However, it differs in a few ways: - signatures are not the same (bufio.Scanner takes an io.Reader as input) - no 64 KB line limit that bufi…
dmitshur commented on doc/go1.13: document removal of NaCl targets in Go 1.145d
(1 comment) It doesn't seem to be done (in the latest patch set 3). Did you include the change and push it?
dmitshur commented on doc/go1.13: document removal of NaCl targets in Go 1.145d
(2 comments) Please wrap to a more comfortable width of 76~ characters, per golang.org/wiki/CommitMessage. This change doesn't seem to be intentional, please undo.
dmitshur commented on golang.org/x/build: all packet builders missing5d
Restarting the machine fixed the issue (yet again; see details in the linked issue above and previous ones linked from there).
dmitshur commented on golang.org/x/build: all packet builders missing5d
SSHing into the machine works okay. I'm going to try rebooting it, a safe operation, as the first step.
dmitshur opened an issue golang.org/x/build: all packet builders missing5d
From https://farmer.golang.org/#health: ``` # "packet" status: Packet linux/arm64 machines # Notes: https://github.com/golang/build/tree/master/env/linux-arm64/packet Warn: packet01 missing, no…
dmitshur commented on golang.org/x/playground/playground: simplify latest go version logic5d
(4 comments) Yeah, using go run here seems nice. It's short and does exactly what's needed (since we're module mode per line 6). golang.org/x/playground is just a command, no one is importing it. S…
dmitshur commented on golang.org/x/playground/playground: fix typo in deploy.json5d
(1 comment) > The goal is to ensure that we're not doing anything to pollute the /workspace. It might be more clear to set "dir": "/go" in the step configuration for this step, or set a GO111MODULE=…
dmitshur pushed to master in github.com/shurcooL/resume6d
837571dbbc383c6a44771681b22b619460ad6dc9.travis.yml: use go vet instead of go tool vet
dmitshur reviewed +2 on golang.org/x/playground/playground: fix typo in deploy.json6d
(1 comment) What is the cd step needed for? Is it to ensure there's no go.mod file in current or any of parent directories, or something else?
dmitshur reviewed +2 on golang.org/x/playground/playground: trigger playground deploys from master6d
(5 comments) Nit: This sentence is short and doesn't seem worthy of being first and having a dedicated paragraph. You could append this sentence to one of the following paragraphs, or move it to the…
dmitshur commented on golang.org/x/playground/playground: push image in trigger before deploying6d
(1 comment) Oh, perhaps this is where it was causing it to push the resulting image. The parameter name wasn't very intuitive, but I read its docs. So it was a part of this CL. Makes sense now.
dmitshur reviewed +2 on golang.org/x/playground/playground: push image in trigger before deploying6d
(1 comment) It's not visible in this CL, but as I understand the trigger was previously configured to push images (albeit "too late" since the app engine deploy step happened earlier), and that is b…
dmitshur commented on go/parser: non-contiguous comments grouped together6d
Thank you everyone for helping resolve this issue. I considered sending a CL to add a test so this `ast.CommentGroup` behavior doesn't regress without us noticing, but then I realized it would have t…
dmitshur commented on github.com/rakyll/statik/fs: handle Readdir(0) same as Readdir(< 0)1w
Thanks for reviewing!
dmitshur commented on github.com/shurcooL/httpfs: Fixed vfsutil compatibility issue with statik/fs1w
Resolved via https://github.com/rakyll/statik/pull/69.
dmitshur commented on github.com/shurcooL/httpfs/vfsutil: ReadDir compatibility issue with statik/fs1w
Fixed via https://github.com/rakyll/statik/pull/69.
dmitshur commented on github.com/rakyll/statik: Readdir should treat zero for count value as it was negative to be fully compatible with the interface1w
No problem @shakahl, that's very relatable. Thanks for reporting this issue.
dmitshur reviewed +2 on golang.org/x/build/cmd/rmplaysnippet: account for local datastore host env var1w
(3 comments) This is a very small and targeted utility so it matter much less, but have you considered an approach where if DATASTORE_EMULATOR_HOST is set, it prints a warning but doesn't try to cha…
dmitshur commented on golang.org/x/build/cmd/tip: clear error when process starts successfully1w
Thanks for reviewing Emmanuel. I've tested this change (together with the other one in the chain) on https://tip-staging.golang.org and didn't spot any issues. Merging.
dmitshur closed an issue all: Go 1.11.12 release status1w
dmitshur commented on all: Go 1.11.12 release status1w
This is done, closing.
dmitshur closed an issue all: Go 1.12.7 release status1w
dmitshur commented on all: Go 1.12.7 release status1w
This is done, closing.
dmitshur reviewed +2 on : [release-branch.go1.12] go1.12.71w
dmitshur reviewed +2 on : [release-branch.go1.12] go1.12.71w
dmitshur reviewed +2 on : [release-branch.go1.11] go1.11.121w
dmitshur commented on crypto/tls: TestVerifyHostnameResumed consistently failing in longtest builder1w
I can reproduce this on macOS with Go 1.12.6. ``` ~ $ go version go version go1.12.6 darwin/amd64 ~ $ go test -count=1 crypto/tls --- FAIL: TestVerifyHostnameResumed (1.62s) --- FAIL: Tes…
dmitshur reviewed +2 on doc: document Go 1.12.71w
dmitshur reviewed +2 on doc: document Go 1.11.121w
dmitshur commented on math/big: arm64 assembly code for shlVU is incorrect1w
Ok, thanks @erifan. I've repurposed #32940 as the 1.12 backport issue. I'll discuss whether it meets the backporting criteria with the team tomorrow. If it gets approved for a cherry-pick, we'll n…
dmitshur commented on math/big: arm64 assembly code for shlVU is incorrect [1.13 backport]1w
Targeting 1.12 and reopening for consideration per https://github.com/golang/go/issues/31084#issuecomment-509062438.
dmitshur commented on math/big: arm64 assembly code for shlVU is incorrect1w
@erifan According to the original issue, this breakage started with commit e4ba400. That commit isn't a part of 1.12. So does this problem exist in 1.12?
dmitshur commented on math/big: arm64 assembly code for shlVU is incorrect1w
There will be a Go 1.12.7 release soon (we aim to make minor releases monthly). We can consider cherry-picking this fix to 1.12 if it meets the backporting criteria (described [here](https://golang.o…
dmitshur pushed to fix-Readdir-0 in github.com/rakyll/statik1w
4de39f1ee5a34c2d375590bd1199e287dbc8519dfs: handle Readdir(0) same as Readdir(< 0)
dmitshur opened a change github.com/rakyll/statik/fs: treat Readdir(0) same as Readdir(< 0)1w
Implementations of the File.Readdir method are expected to treat all n <= 0 values the same, returning all the `os.FileInfo` structures from the directory in a single slice. This is documented at …
dmitshur created branch in github.com/rakyll/statik1w
fix-Readdir-0
dmitshur commented on github.com/rakyll/statik: Readdir should treat zero for count value as it was negative to be fully compatible with the interface1w
I'll send a PR since I'm already looking at this, it's a very small change.
dmitshur commented on github.com/rakyll/statik: Readdir should treat zero for count value as it was negative to be fully compatible with the interface1w
@shakahl Are you still planning to send a PR? If not, I can do it.
dmitshur pushed to master in github.com/shurcooL/httpfs1w
8d4bc4ba774931155e6cd5ef6098cb038dd45135text/vfstemplate: create package for text/template
dmitshur commented on github.com/shurcooL/httpfs: Add text/vfstemplate1w
Sure, I consider that in scope. Thanks for the PR, I’ll review and merge later tonight.
Earlier
dmitshur commented on github.com/shurcooL/highlight_go: unexpected = in type declaration1w
Thanks for reporting. What version of Go are you using? I suspect it might be version Go 1.8 or older. If so, you'll need to update to Go 1.9 or newer, since that's when [type aliases](https://gol…
dmitshur commented on github.com/shurcooL/githubv4: Add support for Schema Previews1w
> I'm still new to Go and GraphQL so creating a transpiler for SDL -> Go lang is definitely a challenge that I'd like to take on, but will take me a long time. No worries. You also don't have to w…
dmitshur deleted branch in github.com/gopherjs/snippet-store1w
modernize
dmitshur pushed to master in github.com/gopherjs/snippet-store1w
eb3ae24c517a8af4f4b6bc048848930bc26afc39add 3 minute timeout to load and serve snippets
7d16d0355c5f10565b900d06c4141f0da44ce0ccrequire storage directory to exist, instead of creating
5476705083ef8bc4ce3a33ae14dd3fe051979022add go.mod and go.sum files
537165a38cf1200cb25592ec46dc787755e8d269refactor top-level code organization
dmitshur commented on all: remove nacl port1w
> My prototype is doing something I don’t think any of the comments here had in mind: Running the compiler in the browser. I mentioned that possibility in the details of https://github.com/golan…
dmitshur commented on golang.org/x/build/cmd/tip: _tipstatus endpoint error is not cleared on successful process start1w
The problem was that the error was never cleared, so it indeed always showed the "last error", not "current error". I've sent 2 CLs, one to improve precondition checking, the other to fix this issue.
dmitshur pushed to patch-1 in github.com/dmitshur/isFileGenerated1w
e810c488b9e89cb1a5e632df012990b96c2a0a07update to new go/generated import path
dmitshur opened a change github.com/gopherci/isFileGenerated: update to new go/generated import path1w
The package has moved. Start using its new import path. Fixes #3.