Today
dmitshur commented on use of internal package not allowed in github.com/ejcx/passgo1h
The [README instructions](https://github.com/ejcx/passgo#getting-started-with-passgo) only mention the `go get -u github.com/ejcx/passgo` step. Should the extra `dep ensure` step be documented then? …
dmitshur commented on support Go modules in github.com/golang/gddo3h
@Sean-Der The current godoc.org website supports Go packages that are functional in GOPATH mode. As you pointed out, if a package is available only in module mode but not in GOPATH mode, it won't sho…
dmitshur commented on runtime: builders failing on macOS … in github.com/golang/go5h
In this case, I don't think rolling back will put is in a better state. The CL has fixed another macOS issue (#31264) that was causing macOS 10.14 and nocgo builders to fail very often: <img width…
dmitshur commented on x/playground: TryBot fails for play… in github.com/golang/go8h
I'm not sure that it's a duplicate. As I understand, that issue is more about adding playground post-submit builders (i.e., on https://build.golang.org) and testing building the playground image is s…
Yesterday
dmitshur starred github.com/griesemer/tryhard1d
dmitshur commented on runtime: use dispatch semaphores on… in go.googlesource.com/go1d
> Unfortunately, Darwin 10.11 seems to not work with this change: > > https://build.golang.org/log/0d04b71ee64cb1e982b28fcee9ab6035ac382a33 Ian is away this week, so there may be a delay. I filed i…
dmitshur commented on html/template: print nil Error poin… in go.googlesource.com/go1d
This CL has been superseded by CL 181579, so I'll close it. We can always re-open if needed.
dmitshur reviewed +2 on html/template: handle nil errors in… in go.googlesource.com/go1d
(1 comment) LGTM, thank you. Would you like me to submit this for you, or are you planning to do that yourself? Consider doing s/errors/*Error/ to make the title more specific.
dmitshur reviewed +2 on html/template, text/template: docum… in go.googlesource.com/go1d
(1 comment) Thanks for sending this change, it looks great. Sorry about the delay. s/Fix/Fixes/ per https://golang.org/wiki/CommitMessage.
dmitshur commented on Null terminate strings automaticall… in github.com/go-gl/gl1d
@docuys I suggest looking at the examples in https://github.com/go-gl/example. `gl41core-cube` in particular uses both `gl.CreateShader` and `gl.Strs`, see [here](https://github.com/go-gl/example/blo…
This Week
dmitshur commented on Help: Can you dynamically construct… in github.com/shurcooL/graphql2d
The experience of performing dynamic GraphQL queries is still a work in progress. There's an open issue about it at https://github.com/shurcooL/githubv4/issues/17. A comment https://github.com/shurco…
dmitshur commented on Arrays internalized as maps in github.com/gopherjs/gopherjs2d
> When a simple non-typed JavaScript array is passed to a Go function parameter of type `interface{}`, it is internalized as a map rather than a slice (`[]interface{}`) Can you share a snippet tha…
dmitshur pushed to master in github.com/shurcooL/home2d
d4d33fdf1de308e296be8d7d680c399b106ae39dadd simple metrics to count ?go-get=1 requests
b24e4b455902a5d506a3a3eaebbe74804d69c4bccancel other components if HTTP server fails
559bf04d3b06d6d62052f7bb15d9585c50b346feall: improve httptest usage
dmitshur pushed to master in github.com/shurcooL/home2d
dmitshur commented on diff: latest release version still … in github.com/sourcegraph/go-diff2d
> the workarounds proposed here would need to be applied by every downstream dependency. That's correct. The act of changing an import path (issue #27) means every active downstream dependency nee…
dmitshur pushed to master in github.com/russross/blackfriday2d
a925a152c144ea7de0f451eaf2f7db9e52fa005aREADME: update URL of LaTeX renderer (#465)
dmitshur commented on Heads-up: markdownfmt is now packag… in github.com/shurcooL/markdownfmt2d
Thanks for letting me know. I'm glad it's useful to people, however, I'm also sad because this project is nowhere near the high quality I wished it could reach, and I've stopped actively trying to im…
dmitshur commented on possibly bug, definite weirdness in github.com/shurcooL/github_flavored_markdown2d
This package requires v1 of `github.com/russross/blackfriday` package. Unfortunately, there's a bad v2.0.0 tag in the blackfriday which results in a v2.0.0+incompatible version of v1 blackfriday API.…
dmitshur deleted branch in github.com/gregjones/httpcache2d
ci-diff-n
dmitshur pushed to master in github.com/shurcooL/cmd2d
e8b5cc9577219573d0123cdbaac9cf68111c156bgorepogen: use RCS format for gofmt diff
dmitshur deleted branch in github.com/gregjones/httpcache2d
gregjones-patch-1
dmitshur commented on 8d99bbad4d48262aeae568b68f33274c748f3699Follow the new syscall/… in github.com/hajimehoshi/oto2d
Why is `runtime.KeepAlive` needed?
Last Week
dmitshur commented on devapp: make it easier to see only … in go.googlesource.com/build4d
> Filed https://golang.org/issue/32626. The fix is already in, need to rebase this CL.
dmitshur commented on x/build/cmd/coordinator: fails 'go … in github.com/golang/go4d
This is already resolved via [CL 182017](https://golang.org/cl/182017). (Existing CLs may need to be rebased to pick up the change.) > (Why don't we have a builder for x/build?) I thought we had an…
dmitshur commented on x/build: "website" not on dashboard in github.com/golang/go4d
As mentioned in #32626, we should also add x/build subrepo to post-submit builders. /cc @bcmills Only need limited builders (e.g., linux/amd64 on latest stable release) since it's our internal inf…
dmitshur commented on x/build: Scaleway builders offline in github.com/golang/go4d
This outage has been resolved (2 years ago), closing.
dmitshur commented on playground: parameterize GO_VERSION… in go.googlesource.com/playground4d
> In this case, I suspect the trybots shouldn't be running against Go 1.11 and Go 1.12, or the GO111MODULE=yes environment should be set if they are. Find/file that bug instead. The higher-level rea…
dmitshur reviewed +2 on playground: parameterize GO_VERSION… in go.googlesource.com/playground4d
(1 comment) I see, thanks for answering.
dmitshur commented on syscall/js: performance considerati… in github.com/golang/go4d
@hajimehoshi Sure. I've updated the source code in the original post.
dmitshur commented on x/playground: if Imports is checked… in github.com/golang/go4d
Also /cc @toothrot.
dmitshur commented on syscall/js: performance considerati… in github.com/golang/go4d
I've tried the benchmark again with recent development versions of 3 browsers: ``` Chrome Canary Version 77.0.3824.0 (Official Build) canary (64-bit) 114.154496 s/op - WebAssembly via sys…
dmitshur deleted branch in github.com/shurcooL/home4d
tempmodquery
dmitshur commented on x/tools/cmd/godoc: ?m=all not showi… in github.com/golang/go4d
The `?m=all` parameter is only supported by `x/tools/cmd/godoc` right now. The original issue linked to godoc.org, which is another website that does not support the `?m=all` query parameter.
dmitshur commented on [dev.boringcrypto] misc/boring: add… in go.googlesource.com/go5d
(2 comments) > It'll make the process less risk-prone and save time on code reviews, knowing they're generated rather than hand-crafted. To clarify, _having the scripts_ checked in is what helps he…
dmitshur reviewed +2 on [dev.boringcrypto] misc/boring: add… in go.googlesource.com/go5d
(6 comments) This is awesome! Thanks for doing this. It'll make the process less risk-prone and save time on code reviews, knowing they're generated rather than hand-crafted. I suggest writing the …
dmitshur reviewed +2 on [dev.boringcrypto] misc/boring: add… in go.googlesource.com/go5d
(1 comment) s/latest/go1.12.6b4 and go1.11.11b4/ That'll make git log view (where only commit subjects are visible) more readable. "latest" is a moving target.
dmitshur reviewed +2 on cmd/makemac, cmd/coordinator: expor… in go.googlesource.com/build5d
(1 comment) I'd suggest adding a check here that len(f) isn't < 4 to be sure the next line won't panic and take down the entire server, or otherwise leave a comment explaining why it's safe not to c…
dmitshur commented on cmd/coordinator: fix build error in go.googlesource.com/build5d
(2 comments) Some minor comments/questions since I looked at this. There was no build error, the code compiled successfully. Did you mean vet or test failure? I agree it caused go test to fail, bu…
dmitshur commented on playground: parameterize GO_VERSION… in go.googlesource.com/playground5d
(4 comments) What's the reason this was moved here? The commit message doesn't say anything about it. Is it just for consistency/better practice to do this step earlier, or is there another specific…
dmitshur commented on proxy.golang.org: missing package in github.com/golang/go5d
Thanks! I plan to remove the temporary workaround from my site tonight, and will test that it continues to work afterwards.
dmitshur commented on x/build/cmd/coordinator: test packa… in github.com/golang/go5d
Here's how I expect this can be implemented. [`runSubrepoTests`](https://github.com/golang/build/blob/2f0768f8d89d96de7e497ec5afa86c921659bc5c/cmd/coordinator/coordinator.go#L2346-L2460) would nee…
dmitshur commented on proposal: cmd/go: build argument to… in github.com/golang/go5d
@rorth Thanks for reporting. I agree that having to manually intervene several times a day to keep a builder running is too much overhead and not sustainable. We should fix that. I suspect we can fi…
dmitshur commented on syscall/js: performance considerati… in github.com/golang/go5d
> It would be also good to benchmark with Firefox and see the results. Agreed. I'll do this later and share results. > IIUC, you are just benchmarking DOM manipulation. And since DOM manipulati…
dmitshur commented on gopls: adding static check to the n… in go.googlesource.com/tools5d
(1 comment) > This is related to issue #17312, which was implemented in module mode (by using proxy.golang.org) but not in GOPATH mode. A better issue to point to is #14594.
dmitshur commented on x/build: go builders and trybots fo… in github.com/golang/go5d
This issue was a duplicate of #14594. This is implemented now, however only when building in module mode.
dmitshur commented on gopls: adding static check to the n… in go.googlesource.com/tools5d
(2 comments) s/adding/add/ From https://golang.org/wiki/CommitMessage: > the part after the colon uses the verb tense + phrase that completes the blank in, "This change modifies Go to ___________"…
dmitshur commented on cmd/coordinator: add missing Sprint… in go.googlesource.com/build5d
Thanks for reviewing Emmanuel!
dmitshur reviewed +2 on cmd/coordinator: add health item fo… in go.googlesource.com/build5d
(1 comment) This fmt.Sprintf call has two %s verbs but no matching arguments. I've sent CL 182017 to fix it (so you don't have to).
dmitshur commented on doc: mention os.UserConfigDir in re… in go.googlesource.com/go5d
(2 comments) That makes sense. When writing this, I found it hard to come up with a good rationale for this CL and I was tempted to leave the commit body blank. However, I try to make it a habit to…
dmitshur reviewed +2 on doc: release notes for text/scanner… in go.googlesource.com/go6d
(1 comment) s/<tab>/<space>/
dmitshur reviewed +2 on cmd/go: add '--' before repository … in go.googlesource.com/go6d
The git command changes look good to me. I'm less familiar with VCS types other than git, but the changes there look reasonable.
dmitshur reviewed +1 on doc: release notes for syscall and … in go.googlesource.com/go6d
(4 comments) If "App" is capitalized, "Store" should probably be too. It's a part of the "App Store" brand name. It sounds like a word is missing here. The new X and Y _what_? Consider inserting t…
dmitshur commented on proxy.golang.org: missing package in github.com/golang/go6d
I've temporarily modified the module server on my website to respond to a limited subset of module queries in commit https://github.com/shurcooL/home/commit/c1141c0e0197df42c3dbad3e8c5200dbd83ca9f9. …
dmitshur created branch in github.com/shurcooL/home6d
tempmodquery
dmitshur commented on all: Go 1.12.6 release status in github.com/golang/go1w
The release is done; see https://groups.google.com/forum/#!msg/golang-announce/dNU0sAdX65I/3psx7_OqAQAJ.
dmitshur commented on all: Go 1.11.11 release status in github.com/golang/go1w
The release is done; see https://groups.google.com/forum/#!msg/golang-announce/dNU0sAdX65I/3psx7_OqAQAJ.
dmitshur commented on all: Go 1.11.11 release status in github.com/golang/go1w
## Latest build: go1\.11\.11 src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.11.11/go1.11.11.src.tar.gz)) linux\-386 ([tar\.gz](https://golang-release-staging.storage.googl…
dmitshur commented on all: Go 1.12.6 release status in github.com/golang/go1w
## Latest build: go1\.12\.6 src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.12.6/go1.12.6.src.tar.gz)) linux\-386 ([tar\.gz](https://golang-release-staging.storage.googleap…
dmitshur commented on proxy.golang.org: builds failing wh… in github.com/golang/go1w
Hi @icco, thanks for the report. I suspect this issue is the same as https://github.com/golang/go/issues/32542#issuecomment-500648906. /cc @heschik
dmitshur commented on all: Go 1.12.6 release status in github.com/golang/go1w
## Log 2019/06/11 10:18:07 starting 2019/06/11 10:18:07 working in /Users/dmitshur/go-releasebot-work/go1.12.6 2019/06/11 10:18:07 $ git clone https://go.googlesource.com/go /Users/dmit…
dmitshur commented on all: Go 1.11.11 release status in github.com/golang/go1w
## Log 2019/06/11 10:01:30 starting 2019/06/11 10:01:30 working in /Users/dmitshur/go-releasebot-work/go1.11.11 2019/06/11 10:01:30 $ git fetch origin master 2019/06/11 10:01:31 $ g…
dmitshur commented on cmd/go: MacOS binaries invalid for … in github.com/golang/go1w
@pieterclaerhout The release should be available tomorrow, June 11th.
dmitshur commented on x/build/env/linux-arm64/packet: all… in github.com/golang/go1w
I've restarted the server and that fixed the issue (just like in #31112). It took a few minutes for it to fully restart, but then it became responsive to pings, ssh, and all the packet builders ar…
dmitshur commented on proxy.golang.org: missing package in github.com/golang/go1w
> It looks like the module proxy referenced by https://dmitri.shuralyov.com/service/change?go-get=1, https://dmitri.shuralyov.com/api/module, doesn't support looking up versions by hash This is tr…
dmitshur commented on x/build/env/linux-arm64/packet: all… in github.com/golang/go1w
`ssh`ing into the server times out: ``` $ ssh -v -i ~/.ssh/id_ed25519_golang1 root@147.75.74.194 [...] ssh: connect to host 147.75.74.194 port 22: Operation timed out ``` Pinging it times o…
dmitshur commented on x/net/http: Re-connect with upgrade… in github.com/golang/go1w
/cc @bradfitz @FiloSottile
dmitshur commented on cmd/test2json: 'exec format error' … in github.com/golang/go1w
I've never used `test2json` before so I'm not familiar with its details, but its documentation notes that: > Note that test2json is only intended for converting a single test binary's output. To c…