Activity
Yesterday
dmitshur commented on golang.org/x/build/internal/task: add mail-dl-cl task to releasebot CLI9h
(3 comments)
It's not the end of the world to mail 2 individual CLs instead of one, but we have generally been combining them with the current process (e.g., see CL 348869), and it results in le…dmitshur merged a change golang.org/x/build/cmd/releasebot: improve "about to tag this commit, ok?" prompt UX9h
dmitshur commented on golang.org/x/build/gerrit: add support for creating and editing CLs10h
(3 comments)
Done.
Removed the return statement to make it less confusing.
The documentation says 409 is only used in this one case. I don't want to hardcode what looks like an error message t…dmitshur commented on golang.org/x/build/gerrit: add support for creating and editing CLs12h
(3 comments)
Ok, I'll change it to describe doArg rather than enumerate things that implement it.
The if statement is currently a no-op that exists only to hold a TODO comment inside. Removing …dmitshur opened a change golang.org/x/build/cmd/releasebot: improve "about to tag this commit, ok?" prompt UX13h
Accept "Y" in addition to "y", and don't print a verbose stack trace.
This change is based on past experience described in golang/go#36948.
Fixes golang/go#36948.This Week
dmitshur merged a change golang.org/x/build/dashboard: add linux-loong64-3a5000 builder1d
dmitshur reviewed +2 on golang.org/x/build/dashboard: add linux-loong64-3a5000 builder1d
I've resolved the remaining threads, they're all okay to follow up in future changes as needed.
Submitting. You should be able to start connecting the builders after the next coordinator dep…dmitshur commented on golang.org/x/tools/cmd/godoc: deprecate and point to cmd/pkgsite2d
I think it is reasonable to deprecate godoc in favor of a newer in command x/pkgsite that is actively maintained and provides better support for modern features like versions, generics.
We should al…dmitshur opened an issue golang.org/x/pkgsite/cmd/pkgsite: templates aren't embedded, causing an error if run from another directory2d
This issue is likely a subset of #40371.
<details><summary>Environment Details</summary>
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.17.1 darwin/…dmitshur reviewed +2 on golang.org/x/build/...: move services to new Kubernetes cluster2d
PS 3 looks good, see 3 comments.
s/us-central/us-central1/ IIUC.
Add a doc comment that specifies what this method does.
> Deleted.
It's not deleted in the Patch Set 3, the latest pushed P…dmitshur reviewed +2 on golang.org/x/build/...: remove node selector2d
dmitshur reviewed +2 on golang.org/x/net/http/h2demo: remove node selector2d
Woohoo, it's nice when fewer things need to explicitly configured in each deployment.dmitshur reviewed +2 on golang.org/x/build/cmd/gcpinit: delete2d
(1 comment)
The purpose of the command is to help initialize a cluster in a reproducible way. It does fewer things now than it used to in the past (e.g., it no longer initializes metrics as of CL 30…dmitshur commented on golang.org/x/build/cmd/xb: move to new Kubernetes cluster2d
(1 comment)
Since the new name of this cluster is "services", we may find this comment easier to understand if it's updated to refer to it as the services cluster.
(The field name can b…dmitshur reviewed +2 on golang.org/x/build/cmd/xb: move to new Kubernetes cluster2d
(2 comments)
What's the motivation of changing the control zone? (I didn't find an answer in the commit message.)
I don't know what value comment is providing, but if keeping it, this p…dmitshur commented on github: consider using GitHub Discussions3d
By now, GitHub Discussions are being tried out in the Go project to a limited degree. See https://github.com/golang/go/discussions/47139.dmitshur reviewed +1 on golang.org/x/website/...: fix video can't display3d
(2 comments)
The path prefix can be more specific than "all":
go.dev/_content/blog: fix embedded videos in two posts
The PR subject will need to be updated as described at https://…dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: move to Workload Identity3d
dmitshur closed a change golang.org/x/blog: The link of ⌘ is not available4d
dmitshur commented on golang.org/x/blog: The link of ⌘ is not available4d
Closing because the URL is working by now. (Also, blog content moved to x/website/blog.)dmitshur closed a change golang.org/x/blog/x/blog: fix images so that they actually render4d
dmitshur commented on golang.org/x/blog/x/blog: fix images so that they actually render4d
Closing since golang/go#38532 is closed, and blog content moved to x/website/blog.dmitshur commented on golang.org/x/build/maintner/maintnerd: move to Workload Identity4d
(1 comment)
(And here.)dmitshur commented on golang.org/x/build/maintner/maintnerd: move to Workload Identity4d
(1 comment)
Maybe fix the label while here. It should use '=' not space between key and value. (Spotted by Alex recently.)dmitshur reviewed +2 on golang.org/x/build/maintner/maintnerd: move to Workload Identity4d
dmitshur reviewed +2 on golang.org/x/build/dashboard: update linux-mipsle-mengzhuo info4d
Thanks for the ping. This looks good, though having those env vars explicitly listed is not a problem. But if you prefer to remove them, since they're also set to the same value on the reverse bu…dmitshur reviewed +2 on golang.org/x/website/_content/doc: update local tour installation instructions4d
Thanks, feel free to submit when ready from your side.dmitshur reviewed +2 on golang.org/x/build/devapp/owners: update owners for pkgsite4d
dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: set pkgsite milestones4d
dmitshur commented on golang.org/x/build/cmd/gopherbot: set pkgsite milestones4d
(3 comments)
I don't know what effect it has, but the name of milestone 168 on GitHub and here are slightly different:
"pkgsite/license"
"pkgsite/licenses"
Maybe one of…dmitshur reviewed +2 on golang.org/x/website/_content/doc: update local tour installation instructions4d
Thanks.
Let’s also update this to keep wording consistent with the change made in CL 326330:
<a href="/cmd/go/#hdr-GOPATH_and_Modules">GOPATH</a>'sLast Week
dmitshur starred in github.com/mystor/git-revise6d
dmitshur commented on golang.org/x/build/cmd/coordinator: update Dockerfile to Go 1.171w
(1 comment)
Maybe this comment is worth keeping? It makes it easier for future maintainers of this Dockerfile to see this line is an optimization, rather than a necessary part of the build process. …dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: update Dockerfile to Go 1.171w
(2 comments)
Makes sense to me, thanks.
If it's still an applicable TODO, keeping it is fine with me. Thanks.dmitshur commented on golang.org/x/build/cmd/coordinator: update Dockerfile to Go 1.171w
(2 comments)
Maybe adding motivation here will make it easier to tell that it's an intentional change despite its effect on iterative docker building speed:
"... because it's easier …dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: update Dockerfile to Go 1.171w
(2 comments)
I rarely "iterate" when building docker images (I usually iterate without involving Docker) so I'm not familiar with what optimizations work well or not.
If I understand co…dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: fix gomote ssh connection closing1w
dmitshur merged a change golang.org/x/build/cmd/gopherbot: move to Workload Identity1w
dmitshur merged a change golang.org/x/build/cmd/releasebot: set trust when mailing VERSION file CL1w
dmitshur opened a change golang.org/x/build/cmd/gopherbot: move to Workload Identity1w
Create a new service account, and move the deployment over to the prod
namespace. Also update the build image to Go 1.17.
For golang/go#48263.dmitshur commented on golang.org/x/website/_context/doc/modules: add GOPRIVATE to managing-dependencies1w
(1 comment)
Nit: No need to insert a colon here, just 'Fixes golang/go#44240' will be consistent with style described in https://golang.org/doc/contribute#ref_issues.dmitshur reviewed +2 on golang.org/x/build/dashboard: enable snapshot for linux-riscv64-unmatched1w
dmitshur commented on golang.org/x/build/cmd/release: darwin/arm64 installer prompts for installing Rosetta 21w
@ifamakes I've checked the `Distribution` file in go1.17.darwin-arm64.pkg, and it still has `hostArchitectures="arm64"` set, so that hasn't regressed on our side.
Since this issue has been closed fo…dmitshur commented on golang.org/x/pkgsite: add support for type parameters1w
I understand the scope of this issue is x/pkgsite, and I don't mean to change that.
I'll point out that a similar issue may apply to x/website, though golang.org serves documentation under a signi…dmitshur commented on golang.org/x/build/cmd/gerritbot: running into letsencrypt authorization rate limit1w
The problem turned out to be a misconfigured use of `autocert` (not enabling `acme.ALPNProto`, and not using `HTTPHandler`), which prevented gerritbot's HTML "hello" page from being served. [CL 34843…dmitshur commented on github.com/shurcooL/githubv4: Do not include unhelpful scalar types.1w
@davidkarlsen Something like this should work:
```Go
variables := map[string]interface{}{
"somekey": (*githubv4.String)(nil), // or another concrete type instead of String
// ...
}
```dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle1w
With the 5 CLs above, we're in good shape for early in cycle. Removing that label to revisit this closer to the code freeze.dmitshur starred in github.com/ianlancetaylor/demangle1w
dmitshur pushed to
master in github.com/shurcooL/httperror1w
dmitshur pushed to
master in github.com/shurcooL/httperror1wEarlier
dmitshur opened an issue golang.org/x/build/internal/workflow: TestParallelism is flaky2w
This seems to happen occasionally, suggesting the test is flaky:
```
--- FAIL: TestParallelism (0.15s)
workflow_test.go:122: task sleep #1 : started
workflow_test.go:122: task sleep #2…dmitshur commented on cmd/vet: panic during processing of hash/crc32 package2w
@timothy-king Correct. Go 1.17 and 1.16 do not have this problem.dmitshur commented on golang.org/x/crypto/curve25519: consider removing dependency on "fmt" if worthwhile2w
Sounds good. Please include a small test in x/crypto that this package doesn't import `fmt`, so this property doesn't accidentally regress without the benefit of go/build's test.dmitshur opened an issue golang.org/x/crypto/curve25519: consider removing dependency on "fmt" if worthwhile2w
The `curve25519` package imports `fmt` and uses it 3 times:
```Go
return nil, fmt.Errorf("bad scalar length: %d, expected %d", l, 32)
return nil, fmt.Errorf("bad point length: %d, expected %d", …dmitshur commented on cmd/vet: panic during processing of hash/crc32 package2w
Bisection shows this problem is introduced in [CL 338529](https://golang.org/cl/338529):
```
$ (cd cmd; go get -d golang.org/x/tools@3fce476f0a782aeb5034d592c189e63be4ba6c9e && go mod tidy && go …dmitshur opened an issue cmd/vet: panic during processing of hash/crc32 package2w
There is a problem on tip when the vendored x/tools module is updated to its latest master pseudo-version (as part of #36905).
### What did you do?
```
$ git clone https://go.googlesource.com/…dmitshur commented on go/types: incorrect type reported for comma-err C functions (manifests itself in IDEs)2w
The fix that closed this issue landed into master branch, which is where Go 1.18 development is happening, so moving this issue to the Go1.18 milestone. (The 1.17 backport issue #47854 is in 1.17.1 m…dmitshur commented on cmd/compile: reduced microbenchmark execution speed in 1.172w
This issue was closed in NeedsInvestigation state without a fix, but if a fix were to be made, it would need to target Go 1.18 first. Since this isn't a [backport issue](https://golang.org/wiki/Minor…dmitshur commented on all: decide and document iOS supported versions2w
Also CC @changkun, @hajimehoshi.dmitshur commented on golang.org/x/build: adding linux-riscv64-unmatched builder2w
cmd/coordinator has been redeployed, so the reverse builder should be able to connect. It’s visible at https://farmer.golang.org now:
> host-linux-riscv64-unmatched: 0/0 (1 missing)dmitshur closed an issue golang.org/x/mobile: failed to pull the signing certificate to determine your team ID2w
dmitshur commented on golang.org/x/mobile: failed to pull the signing certificate to determine your team ID2w
Thanks for fixing this @changkun. Closing.dmitshur starred in github.com/gonutz/d3d92w
dmitshur commented on golang.org/x/mobile: use GOOS=ios and remove the build tag ios usages2w
Now that Go 1.17 is released (and thus 1.15 has become unsupported), there shouldn't be a reason not to do this. Also see discussion in #47952.dmitshur closed an issue golang.org/x/build/cmd/tip: version information and /_tipstatus page are not easily discoverable2w
dmitshur commented on golang.org/x/build/cmd/tip: version information and /_tipstatus page are not easily discoverable2w
This issue was not really resolved, but `golang.org/x/build/cmd/tip` was deleted in [CL 343449](https://golang.org/cl/343449), so closing.dmitshur opened an issue golang.org/dl: switch to go install path@latest syntax in documentation2w
Now that Go 1.17 is released and Go 1.15 in unsupported per [release policy](https://golang.org/doc/devel/release#policy), we should update documentation of [`golang.org/dl/go1.N` commands](https://p…dmitshur closed an issue syscall: SysProcAttr{ NoInheritHandles: true } broken in 1.17 on Windows [1.16 backport]2w
dmitshur commented on syscall: SysProcAttr{ NoInheritHandles: true } broken in 1.17 on Windows [1.16 backport]2w
Go 1.16 isn't affected, so this backport issue isn't needed.dmitshur commented on golang.org/x/website: broken link on go get deprecation2w
CC @jayconrod.dmitshur pushed to
master in github.com/shurcooL/home2wdmitshur closed an issue github.com/shurcooL/home/indieauth: update implementation for 2020 spec changes2w
dmitshur commented on doc: make it more explicit where print and println can be used2w
I understand the Go language specification is vague for the reasons Rob suggested, allowing different implementations of the Go language to implement them as most appropriate.
The behavior of Go…dmitshur commented on golang.org/x/website/go.dev: playground snippets in blog posts fail to run3w
I think this issue can be fixed by changing go.dev's playground.js script as follows:
```diff
-$.ajax('/compile', {
+$.ajax('https://play.golang.org/compile', {
```
_(Source: [go.dev/_conten…dmitshur commented on golang.org/x/website/go.dev: /learn page does not suggest installing the latest version and also suitable for my operating system3w
It's likely Go 1.15 was shown because a frontend fetch failed, or JavaScript execution is disabled. The relevant code is:
```JS
async function getLatestVersion() {
let version = 'go1.15'; //…dmitshur closed an issue golang.org/x/build/app/appengine: clean up after dashboard unification3w
dmitshur commented on golang.org/x/build: adding linux-riscv64-unmatched builder3w
@mengzhuo A key's been provided via email. Patch set 2 of [CL 329489](https://golang.org/cl/329489) looks good, please submit it when you're ready, and after the following cmd/coordinator deploy the …dmitshur commented on golang.org/x/build: adding linux-riscv64-unmatched builder3w
@mengzhuo Excellent, let's proceed then, thank you again. CL 329489 is reviewed, can you address the remaining comment on it, and submit it? After that, I'll redeploy coordinator, which will allow th…dmitshur commented on golang.org/x/build/cmd/release: green-screen on Windows ARM64 builder with SkipTests: false3w
I've repeated this exercise using the `windows-arm64-10` builder, and the green-screens no longer happen reproducibly. I've still observed at least 1 instance out of 5 runs, filed #47965 for that.
…dmitshur opened an issue golang.org/x/build: windows-arm64-10 builder occasionally crashes during sequential all.bash test execution3w
Breaking this out from #47017 as a narrower issue for tracking any investigation purposes.
There still seems to be some instances where running all.bash sequentially (i.e., without any sharding) o…dmitshur commented on golang.org/x/build/cmd/updatestd: verify that target GOROOT's bin/go is in PATH3w
During the 1.18 dev cycle, using the `go` binary not from the tip checkout can cause `go mod tidy` step to fail:
```
> go mod tidy
command failed: exit status 1
go mod tidy: go.mod file indicat…dmitshur opened an issue golang.org/x/build/cmd/updatestd: ability to split large updates into a sequence of smaller update CLs, for better bisection3w
At this time the `updatestd` command updates all golang.org/x versions to latest available when it is run. If run fairly infrequently (e.g., twice per cycle, so every 3 months), there can be many cha…dmitshur closed an issue golang.org/x/website: go-import meta tags not served for golang.org/x subrepos in china3w
dmitshur commented on golang.org/x/website: go-import meta tags not served for golang.org/x subrepos in china3w
Thanks for verifying. Closing as fixed (see related issue #47808 which has more details).
(Thanks for fixing @rsc!)dmitshur commented on golang.org/x/website: go-import meta tags not served for golang.org/x subrepos in china3w
CL 344289 will fix the problem due to redirection.dmitshur commented on golang.org/x/build/cmd/coordinator: health check for tip.golang.org reports a false positive of "404 not found"4w
tip.golang.org is served by x/website/cmd/golangorg as of [CL 335049](https://golang.org/cl/335049), and we need to update this health check. It still points to a /_tipstatus URL, which isn't served …dmitshur commented on golang.org/x/build: plan to remove windows-[386|amd64]-2008 builders4w
These builders are used by Go releases right now. Go 1.17 and 1.16 are documented to require Windows 7 or newer. Before we can remove the builders, we need to start using a newer builder for releases…dmitshur commented on golang.org/x/website: No Atom feed linked in new blog header1mo
CC @jamalc, @rsc.dmitshur commented on golang.org/x/build/cmd/tip: shut down and delete1mo
Sent [CL 343449](https://golang.org/cl/343449) that deletes the code. I plan to submit it after stopping the service.dmitshur opened an issue golang.org/x/build/cmd/releasebot: pushing issues and closing milestone didn't work for major release1mo
There seems to be a problem in `pushIssues` for major releases. It's documented to move issues for major releases:
```Go
// pushIssues moves open issues to the milestone of the next release of th…dmitshur commented on golang.org/x/website: test page returns 5001mo
Thanks for reporting and bisecting @fgm.
CC @rsc as the author of [CL 339403](https://golang.org/cl/339403).dmitshur commented on golang.org/x/website: error accessing "Writing Web Applications" section in docs1mo
This is likely introduced by recent x/website changes. @rsc Can you take a look?dmitshur commented on golang.org/x/website: /dl broken on golang.google.cn1mo
This issue is similar to https://github.com/golang/go/issues/47751#issuecomment-900451045. The problem is also present as of CL 339403, not present in the one before.
It's temporarily mitigated be…dmitshur commented on golang.org/x/website: /ref/mod template execution error1mo
Thanks for reporting.
The last good version was golang/website@f8f1822, rolled back golang.org to that.
The problem is introduced with the following commit, golang/website@ef7fed48ece033b41e88e…dmitshur commented on golang.org/x/website: /dl broken on golang.google.cn1mo
Thanks for reporting. CC @rsc.dmitshur opened an issue golang.org/x/build/cmd/tip: shut down and delete1mo
The x/website/cmd/golangorg server became able to serve the tip.golang.org website as of CL 335049, and it is actively doing so now that the corresponding DNS change has propagated.
(Proof: https:…dmitshur commented on gerrit: support "mergeable" queries1mo
From looking at other Gerrit instances like https://gerrit-review.googlesource.com/q/is:mergeable, https://chromium-review.googlesource.com/q/is:mergeable, it appears that this option is not generall…dmitshur closed an issue html/template: data race with concurrent ExecuteTemplate calls [1.15 backport]1mo
dmitshur commented on html/template: data race with concurrent ExecuteTemplate calls [1.15 backport]1mo
Go 1.17 has been released, and so Go 1.15 is no longer supported per the [release policy](https://golang.org/doc/devel/release#policy). Closing.dmitshur commented on sync/atomic: CompareAndSwapPointer should be CompareAndSwap [1.17 backport]1mo
Approved as a documentation fix for a new-to-Go-1.17 API. Only 1.17 needs this backport.