2020/06/01 13:16:41 starting
2020/06/01 13:16:41 working in /Users/dmitshur/go-releasebot-work/go1.14.4
2020/06/01 13:16:41 $ git clone https://go.googlesource.com/go /Users/dmit…
2020/06/01 13:15:40 starting
2020/06/01 13:15:40 working in /Users/dmitshur/go-releasebot-work/go1.13.12
2020/06/01 13:15:40 $ git fetch origin master
2020/06/01 13:15:41 $ g… Issue tracking the go1.14.4 release by releasebot. Issue tracking the go1.13.12 release by releasebot. (1 comment)
Replace this with golang.org/cl/113177, it's shorter and more future proof.
Reference: https://golang.org/wiki/CommitMessage. (1 comment)
Fixed via CL 235937. w.Milestone will be set for all release types. We can add a check to have releasebot report an error and refuse to proceed with a beta1 release, there is an issue deemed to be a release blocker for the given milestone, and is not deemed to be oka…
Thanks for the ping.
I'm not seeing issues. Left minor comments.
This TODO can be resolved right now by changing it to context.Background().
I found that https://golang.org/ref/mod#v… There are 3 exported identifiers with the word "Run" in package [`golang.org/x/tools/internal/gocommand`](https://pkg.go.dev/golang.org/x/tools/internal/gocommand). None of them say what the identifi…
Please also include the CL number. See https://golang.org/wiki/CommitMessage#reverts and https://golang.org/issue/30530 for context. (1 comment)
This won't quite work as-is because w.Milestone is not set for beta releases.
I'll fix that. We now have a way of telling which release blocker issues apply to
a beta1 release, so start checking for such issues, and prevent
the release from proceeding if any of them are open. I think this issue is best split into two. One for beta releases (where master branch is used), and another for all other releases (where release-branches are used).
For beta releases, there is a … Currently, the release process involves running `releasebot` first in prepare mode, then again in release mode.
For release types other than beta, a CL that updates the VERSION file is created in … (1 comment)
Done. +2 modulo previous comments and trybots passing. (4 comments)
Nit, we generally use "doc/go1.15:" prefix for changes touching this file.
All is not a real package. Both these CLs were about removing darwin/386 port, which is already documented in… The version of the golang.org/x/tools module is specified in the src/cmd/go.mod files on the release branches for Go 1.14 and 1.13:
- https://github.com/golang/go/blob/release-branch.go1.14/src/cm… Have you considered the [`rsc.io/goversion/version`](https://pkg.go.dev/rsc.io/goversion/version) package? > I'm running GHE 2.20.7
You should use the Versions dropdown to select documentation for that version:
![image](https://user-images.githubusercontent.com/1924134/83212718-39e38100-a12e-11ea-94df-1… MAINTAINERS: update Dmitri's email and username The race in `go/types` API was fixed in #36689. /cc @matloob
I believe this issue should be resolved now. We can watch it for 2 weeks and close if nothing new happens. We've looked over this issue in a release meeting. Based on the discussion above, though it was a close call in either direction, the decision we're making is to proceed with a rollback, which is imp… I've closed #37050 as a duplicate of this issue. See that issue for more investigation and discussion.
I've also edited the original issue to make all the links say "linux-amd64-longtest" rather t… I've looked into how the `linux-386-longtest` builder is passing on tip, and found a similar (or duplicate) issue #37404. It's passing on tip because [CL 227587](https://golang.org/cl/227587) has add… (Factoring out this specific problem from #37050.)
The TestNexting/dlv-dbg-hist test is failing on `linux-386-longtest` builder on release-branch.go1.14 and release-branch.go1.13:
- https://bui… (1 comment)
I checked at https://github.com/golang/go/commits/master/doc/go_spec.html and there haven't been changes since Jan 15, 2020. But you're right that the specification itself might still se… There are no language changes in Go 1.15, so document that.
For #37419. (2 comments)
Maybe add a sentence motivating the change¹. Like, setting innerHTML is a more heavyweight operation that supports HTML. What's being done here doesn't use HTML, so it's viable to use … I'm not sure if you're already aware of it or not, so I want to point out there exists another general purpose Gerrit API client at https://pkg.go.dev/github.com/andygrunwald/go-gerrit. Its scope is … Upon further testing, it seems the problem was not the version of dlv, but the fact that the installed `dlv` binary was built with GOOS=linux GOARCH=amd64, and the same binary is being used for GOHOS… I just remembered @bcmills's https://github.com/golang/go/issues/37050#issuecomment-582914424 from earlier, that seems like another good option to consider, as it would make the test depend on the en… The version of `dlv` installed on the `linux-386-longtest` builder is:
root@buildlet-linux-stretch-morecpu-rn5eea3af:~# dlv version
Build: $Id: 068e2451004e95… It is also happening on the release-branch.go1.13 branch. See the post-submit failure [here](https://build.golang.org/log/95c7870d8f07053a3a68e2d4e3967f46f5e38304), and the SlowBot run [here](https:/… TRY=linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-race
The linux-386-longtest failure is in TestNexting/dlv-dbg-hist, which is … TRY=linux-386-longtest, linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-race As @bcmills noted in https://github.com/golang/go/issues/37001#issuecomment-581691898, there's a chance this is the same issue as #37001, which has been resolved on Feb 6, 2020. /cc @toothrot
The … TRY=linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-race
The linux-386-longtest failure is in TestNexting/dlv-dbg-hist, which is … This seems to be happening on `linux-386-longtest` builder specifically more often. It has happened on the post-submit builder on release-branch.go1.14 [here](https://build.golang.org/log/db8f1224d3e… An ultimate solution would be a mechanism that makes it possible to redeploy coordinator without losing gomote sessions, or at least makes it possible to re-connect to them without their state gettin… There are times when people need to investigate issues that require configuration or environment that is hard to reproduce locally, and they use [gomote](https://golang.org/wiki/Gomote) instances for… TRY=linux-386-longtest, linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-race The purpose of the -race builder is to check for bugs on the Go side,
so use the newer available Windows version with the expectation that
there should be fewer unfixed bugs left in it.
Take this ea… (2 comments)
This change isn't quite right, the freeze does apply to some golang.org/x repos partially. Specifically, it applies to packages that are vendored in the main Go repository, and their tr… There's agreement from release team, and this is needed for #29252.
I'll start with adding just the longtest builders first. Sent [CL 234531](https://golang.org/cl/234531) for that. This test data will be modified to match a change in behavior
in the next commit. Update it to a supported Go version first.
For golang/go#37827. (1 comment)
It is used by builders (all.bat calls run.bat), but it's called with --no-rebuild flag, so the affected section is skipped. Issue #32441 was unfortunate in that it both had a "x/" prefix, yet it didn't match a real package "x/net/http2" that exists and is vendored.
One way to make that task of adding "Unreleased" miles… (1 comment)
Also, if abandonCL fails (e.g., due to a network issue), this line won't be executed. Since it can never fail, it should be better to swap their order so this happens first, and abandonC… (2 comments)
I've tested this in dry-run (after CL 234889) and live, it's working well. The time between each checkPullRequests loop is a minute or two, so it's very unlikely a CL would be abandoned… Reopening for testing purposes. (2 comments)
Also see https://github.com/golang/build/blob/4872bffdeec51d5c4128a3c0c189cec944515603/dashboard/builders.go#L2573-L2599 for the naming strategy of similar helpers in x/build. They migh… (2 comments)
Needs documentation please.
Go version naming deviates from semver in that Go 1.14.1 is a minor release, and Go 1.14 is a major release.
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464). ### What did you do?
I read the documentation of package `go/printer` in order to understand how to use `printer.CommentedNode`.
### What did you expect to see?
Documentation that would allo… Thanks for reporting.
This is due to a limitation of the algorithm used to trim excessively large string literals and slices (see relevant code [here](https://github.com/golang/gddo/blob/a4ebd2f7e57… I don't know exactly without first looking more, but it should be somewhere in the repository's Gerrit configuration. E.g., see https://gerrit-review.googlesource.com/Documentation/config-gerrit.html… This already works for most repositories. For example, [CL 234658](https://golang.org/cl/234658) was imported from https://github.com/golang/go/pull/39176, and Gerrit correctly linkifies the PR menti… (1 comment)
I don't know why I keep thinking it's called this; it should be secret manager¹.
¹ https://cloud.google.com/secret-manager Restore the ability to test gerritbot locally in dry-run mode.
Update some references to compute metadata with secret keeper,
since that is what's used now.
Also add a safety check at the top of po… [CL 234531](https://golang.org/cl/234531) adds automatic long tests to the release process. Once submitted, `releasebot -mode=prepare` will run tests on the linux-amd64-longtest and windows-amd64-lon… Thanks for reviewing.
To clarify, a backport CL doesn't necessarily need to be reviewed by the original author, it just needs to be reviewed by someone who is qualified to review the change. Usually… Friendly ping. This CL needs a code review. It is fixing a backport issue that has been approved. Friendly ping. This CL needs a code review. It is fixing a backport issue that has been approved. The `windows-amd64-race` builder is already using `n1-highcpu-16` machine type (16 vCPUs, 14.4 GB mem), same as the `windows-amd64-longtest` builder. So, there isn't an easy opportunity to increase t… The longtest builders are passing, so this is confirmed to be resolved. dmitshur edited the wiki1w SlowBots are intended to allow custom and slow testing, so I believe this is in scope. It's a matter of figuring out a syntax for it and implementing the feature.
As a starting point, I'll suggest… As @stamblerre mentioned above (I was too slow to comment), we should consider how this would affect the support window for builders, if at all. At this time, we're able to stop supporting a builder … This issue is resolved now. Removing Soon label. I'll keep it open to confirm the next longtest builder run is successful. There has been a firewall misconfiguration affecting the vcs-test.golang.org service. It is causing longtest builders to fail on tests that need to access vcs-test.golang.org.
http… (1 comment)
This check should stay in the ghr.ForeachIssue function as before, where there's enough context to see that abandonCL is only called on Gerrit CLs that are still open.
This helper shoul… (3 comments)
In general, this looks good. I left some comments. I think we should test it to confirm it's working as expected and not causing issues before submitting the CL.
One other scenario to … (3 comments)
Thanks for reviewing.
It can be. I thought it was a reasonable opportunity to save on vertical space, since the GOOS/GOARCH pair is often considered one piece of information.
I'll lea… The URL format has changed slightly, update it so that the Flexible
environment filter continues to be active.
Also, avoid printing directions at the end of the publish step in the
Makefile. Doing s… Allow golang.org/x repos to opt-in to use pkg.go.dev for documentation.
The golang.org/x/pkgsite repository is the first one to use it.
Update to current golang.org/x/build version and regenerate:
… The golang.org/x/pkgsite is the first repository that needs it now.