Activity
Today
dmitshur opened a change golang.org/x/build/cmd/gorebuild: log at start of GerritTarGz42m
GerritTarGz prints about problems it encounters and how it handles them,
but those messages are hard to make sense of without some context about
what work was being done. Add a brief log line to help…dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian131h
Thanks.dmitshur commented on : [release-branch.go1.26] fix incorrect loop trip counts2h
go1.26-linux-arm64_debian13 trybot failure is #78406, fixed only after this CL was prepared and unrelated to the change here, so bypassing since everything else passed.dmitshur commented on all: [release-branch.go1.26] update x/net to 705de46f2h
The change to src/net/http/h2_bundle.go seems missing (as caught by `go test cmd/internal/moddeps`). Otherwise this looks good.dmitshur opened a change golang.org/x/build/main.star: remove known issue for linux-arm64_debian132h
go.dev/issue/78405 and go.dev/issue/78406 were resolved,
and the builder has started working on release branches:
https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/go1.26-linux-arm64_debia…dmitshur commented on cmd/link: stop requiring gold on arm64 when GNU ld is fixed [1.26 backport]3h
> fixed by CL 740480 with a potential followup in CL 747660
@cherrymui and I discussed whether to wait for the potential followup. Since the original fix is enough for the debian13 builders, we'll s…dmitshur commented on cmd/link: use bfd ld 2.41+ on linux/arm64 instead of gold4h
(1 comment)
@dimitri.ledkov@surgut.co.uk Can you apply this change? Or perhaps I can edit it for you, though then I can't review this CL as I'll become the uploader.dmitshur commented on golang.org/x/build/main.star: move known_issue computation from define_builder to enabled4h
(1 comment)
Actually done this time...dmitshur commented on golang.org/x/build/main.star: move known_issue computation from define_builder to enabled4h
Thanks.
Oh, this is one more place where the earlier computation should be reused. No effect on generated files now, but it might make a different in the future. Done in PS 2.dmitshur commented on golang.org/x/build/internal/relui: update TestRelease to use supported Go versions5h
(3 comments)
Hmm, unfortunately I think having a test for 1.27 rc intersects poorly with the task to generate a x/tools CL, because that ends up trying to use the real `golang.org/dl/go1.27rc1` comm…dmitshur commented on cmd/compile: [release-branch.go1.25] handle min integer step in loop5h
The linux-arm64_debian13 builder doesn't work on release branches yet, and it currently has a known issue associated with it:
https://ci.chromium.org/p/golang/g/go-go1.25-known_issue/console
It sho…dmitshur opened a change golang.org/x/build/main.star: move known_issue computation from define_builder to enabled5h
In general, we always first call enabled on a given builder type to tell
whether a builder exists at all, and only then do we call define_builder
for that builder type.
Computing the known issue in …Yesterday
dmitshur fixed an issue golang.org/x/build/cmd/gorebuild: may fail to produce a useful report due to running into '429 Too Many Requests' unauthenticated rate limiting21h
https://go.dev/rebuild has a successful report with the new version ([CL 767880](https://go.dev/cl/767880)).
<img width="547" height="405" alt="Image" src="https://github.com/user-attachments/assets…dmitshur commented on golang.org/x/build/cmd/gorebuild: may fail to produce a useful report due to running into '429 Too Many Requests' unauthenticated rate limiting21h
https://go.dev/rebuild has a successful report with the new version ([CL 767880](https://go.dev/cl/767880)).
<img width="547" height="405" alt="Image" src="https://github.com/user-attachments/assets…dmitshur commented on golang.org/x/build: add LUCI aix-ppc64 builder22h
That message does seem unexpected. I also see it in a recent task like https://chromium-swarm.appspot.com/task?id=77aef1f18b21ad10 and it's blocking further progress on the task.
If you look at http…dmitshur opened a change go.dev/wiki/PortingPolicy: make port-maintainers links more direct22h
Link directly to the 'Teams' tab instead of the default 'Members' tab.
It's more useful, since the top-level golang/port-maintainers team is
not really used; it just holds the port-specific sub-teams…dmitshur commented on cmd/go/internal/modfetch: update zip hashes for new flate compression23h
Thanks.
Noting that a number of watchflakes-opened issues can be closed when this CL lands: https://go.dev/issues?q=is%3Aissue%20state%3Aopen%20author%3Agopherbot%20%22(but%20content%20has%20correct…dmitshur reviewed +2 on cmd/go/internal/modcmd: omit null fields23h
Thanks.dmitshur reviewed +2 on cmd/go/internal/workcmd: include toolchain and godebug in -json23h
Thanks.
TestCodeRepo failures should be fixed CL 767543.dmitshur reviewed +2 on cmd/go/internal/workcmd: include toolchain and godebug in -json23h
I cc'ed you on another CL 724260 that was sent for the same issue earlier, but this seems like a superset of that.
Also noting that the `Directive` definition at https://go.dev/ref/mod#go-work-file-…dmitshur commented on internal/workcmd: add toolchain to json output23h
(1 comment)
Oh, I noticed on the [issue](https://github.com/golang/go/issues/75941#issuecomment-4237842457) that @sean@liao.dev recently sent CL 766480, which already has this comment addressed, and…dmitshur reviewed +2 on internal/workcmd: add toolchain to json output1d
I can review this CL. Thanks for preparing it.
I'll note that in that issue description it's apparent that the 'godebug' is also missing, so this could be changed to 'For #75941' to keep the issue o…dmitshur commented on golang.org/x/build/internal/releasetargets: update list for Go 1.271d
(1 comment)
Oh, I also realized dropping 1.24 release targets will make these tests fail, since they still target that version (as in https://ci.chromium.org/b/8684329214885421377). You could leave …dmitshur opened a change golang.org/x/build/internal/task: fix 'gcloud storage' migration in publishPackageExtension1d
The 'storage' argument here was missed in CL 749081.dmitshur commented on golang.org/x/website/_content/rebuild: mention git dependency1d
Thanks.dmitshur commented on golang.org/x/build/cmd/gorebuild: add a git clone-based fallback to Gerrit's +archive URL1d
Thanks.dmitshur opened a change golang.org/x/website/_content/rebuild: mention git dependency1d
Having git is needed to enable the fallback when fetching directly over
HTTPS runs into insufficient quota and rate limiting.
For golang/go#78804.dmitshur commented on golang.org/x/build/cmd/gorebuild: add a git clone-based fallback to Gerrit's +archive URL1d
(1 comment)
Hmm, it seems this flag is a bit too new e.g. to be included in latest stable Ubuntu, so I'll defer using it. Done in PS 3.dmitshur opened a change golang.org/x/build/cmd/gorebuild: add a git clone-based fallback to Gerrit's +archive URL1d
If the +archive endpoint responds with 429, wait a bit and try again
by using git clone instead. For the purposes of gorebuild it is okay
to wait and make requests slowly: we generally want to run go…dmitshur opened an issue golang.org/x/build/cmd/gorebuild: may fail to produce a useful report due to running into '429 Too Many Requests' unauthenticated rate limiting1d
Gorebuild fetches Go source code from its canonical source, the https://go.googlesource.com/go git repository, and proceeds to check that it can be used to reproduce the associated files posted to ht…This Week
dmitshur opened a change golang.org/x/website/_content/doc: add go1.27.md placeholder2d
Add this file now that it's possible to preview the release notes draft
at https://tip.golang.org/doc/go1.27.
For golang/go#78779.dmitshur opened an issue doc: write release notes for Go 1.272d
This is the tracking issue for writing the Go 1.27 Release Notes. The version at tip can be viewed at https://tip.golang.org/doc/next.
When we have a fairly complete release notes draft, enough for …dmitshur reviewed +2 on golang.org/x/build/internal/releasetargets: update list for Go 1.272d
Thanks. Everything looks good, we'll just need to incorporate the update for #75836 here. I also reopened that issue and wrote down a list of the tasks, so this will be easier to remember next time a…dmitshur reopened an issue all: end support for macOS 12 in Go 1.272d
There's just a few more tasks not quite done yet, edited the original description to write them down and reopened for that.dmitshur reopened an issue all: end support for macOS 12 in Go 1.272d
There's just a few more tasks not quite done yet, edited the original description to write them down and reopened for that.dmitshur closed an issue cmd/compile/internal/types2: unrecognized failures2d
dmitshur closed an issue cmd/compile/internal/types2: unrecognized failures2d
dmitshur commented on cmd/go: frequent SEGV without stderr text [darwin, go1.26+tip]2d
From issue triage, this might be explainable by general darwin corruption (issue #77515), it may just be to affecting cmd/go behavior in this instance. @adonovan Have you looked into whether this aff…dmitshur commented on cmd/go: go.work.sum after `go work sync` is missing entries needed by `go list`2d
@matloob There was another `go work sync` fix that landed in Go 1.27 recently, do you know how different this issue is?dmitshur commented on runtime: sigtramp on linux/arm64 crashes when .syso code clobbers R28 (g register)2d
From issue triage, it seems like this is not intended to be a supported use case, so we can close this issue. Is there anything more to do here?dmitshur closed an issue cmd/compile/internal/types2: unrecognized failures2d
dmitshur commented on golang.org/x/vuln/cmd/govulncheck: TestCommand/common fails with "no package patterns provided"2d
@earthboundkid That sounds like issue #78743. This one is about the TestCommand test failure.dmitshur starred github.com/stapelberg/expanderr3d
dmitshur reviewed +2 on golang.org/x/website/ref/mod: fix markdown syntax inside embedded HTML3d
Thanks.
Markdown has some support for tables; I wonder if it might be viable to use it. Getting it to use the same CSS might be the tricky part. In any case, that'd be a bigger change and this CL is…dmitshur reviewed +2 on cmd/go: loosen go work sync version requirements4d
Thanks.
(nit)
```suggestion
bumps the versions up.
```
Is this comment still up to date? It seems like it might not be, because EnterModule is no longer called on moduleLoader in the loop (it's ca…dmitshur commented on cmd/go: add go1.24 requirement when running go get with tools4d
(1 comment)
This is probably too minor to make a difference in practice, but if someone copies and pastes the suggested command here, they'll end up with `go 1.24.13` (that's what the `go list -m go…dmitshur commented on golang.org/x/tools/gopls: remove trailing slash from replace directory path4d
These test results from 2023 are for Go 1.21 and older, and they're obsolete now. The error back then was expected as the fix landed in Go 1.22.
Thanks.dmitshur opened an issue golang.org/x/vuln/cmd/govulncheck: TestCommand/common fails with "no package patterns provided"4d
There's a test failure that seems to have started with [CL 736180](https://go.dev/cl/736180):
```
vuln $ go test ./...
ok golang.org/x/vuln 0.777s
--- FAIL: TestCommand (14.83s)
--- FAI…dmitshur fixed an issue golang.org/x/vuln/cmd/govulncheck: unrecognized failures4d
Closing in favor of watchflakes opening more targeted new issue(s).dmitshur fixed an issue golang.org/x/vuln/internal/vulncheck: TestCommand failures4d
dmitshur fixed an issue golang.org/x/vuln/internal/vulncheck: TestCommand failures4d
The most recent failures all seem to be on Go 1.24 and older versions. Maybe the remaining problem was fixed starting with Go 1.25+? Closing and letting watchflakes reopen if there are new failures. …dmitshur commented on golang.org/x/vuln/internal/vulncheck: TestCommand failures4d
The most recent failures all seem to be on Go 1.24 and older versions. Maybe the remaining problem was fixed starting with Go 1.25+? Closing and letting watchflakes reopen if there are new failures. …dmitshur fixed an issue golang.org/x/vuln/cmd/govulncheck: fails to build at tip due to use of gotypesalias setting4d
x/vuln is fixed by [CL 739740](https://go.dev/cl/739740), which is now included in [govulncheck v1.2.0](https://pkg.go.dev/golang.org/x/vuln@v1.2.0/cmd/govulncheck).
x/pkgsite-metrics was also fixed …dmitshur commented on golang.org/x/vuln/cmd/govulncheck: fails to build at tip due to use of gotypesalias setting4d
x/vuln is fixed by [CL 739740](https://go.dev/cl/739740), which is now included in [govulncheck v1.2.0](https://pkg.go.dev/golang.org/x/vuln@v1.2.0/cmd/govulncheck).
x/pkgsite-metrics was also fixed …dmitshur reviewed +2 on golang.org/x/build/internal/task: allow auto-tagging of golang.org/x/vuln4d
Glad to see this! This'll also fix the fact that despite issue #77335 is fixed at HEAD of x/vuln, doing `go install golang.org/x/vuln/cmd/govulncheck@latest` using tip (Go 1.27 to be) was still runni…dmitshur commented on : Tarball for Go 1.26.2 contains 1.25.2 binary?4d
`GODEBUG=toolchaintrace=1` is another useful tool for visibility into Go toolchain selection. See the last two paragraphs of the [Go toolchain selection](https://go.dev/doc/toolchain#select) section.dmitshur commented on golang.org/x/sys/cpu: add runtime import in cpu_darwin_arm64_other.go4d
@alex.brainman@gmail.com Sorry it wasn't clear. The way I found this missed import in cpu/cpu_darwin_arm64_other.go was when I was testing out the suggestion posted in https://go-review.googlesource.…Last Week
dmitshur commented on golang.org/x/build/internal/migration: stop running any remaining legacy builders6d
Thanks.dmitshur reviewed +2 on cmd/go: remove bzr support1w
Thanks.dmitshur commented on golang.org/x/tools/gopls: remove trailing slash from replace directory path1w
This change is ready for review.dmitshur commented on golang.org/x/build/main.star: clean up after dropping release-branch.go1.211w
For posterity, this was reopened as CL 765503. I'm glad we were able to land this!dmitshur commented on golang.org/x/build/main.star: drop release-branch.go1.23 from TOOLS_GO_BRANCHES1w
Thanks.dmitshur commented on golang.org/x/build/main.star: clean up after dropping TOOLS_GO_BRANCHES1w
Thanks. Woohoo!
This strange author date is because this change is pulled out of CL 605296 from 2024. I'm glad we're able to land this now! 🎉dmitshur opened a change golang.org/x/build/main.star: clean up after dropping TOOLS_GO_BRANCHES1w
Delete code that became dead after CL 765501. Generated files unchanged.
For golang/go#69321.dmitshur opened a change golang.org/x/build/main.star: drop release-branch.go1.23 from TOOLS_GO_BRANCHES1w
CL 605000 kept only the 1.21 branch as a special case for gopls v0.17.0
needs and CL 702235 replaced it with a 1.23 branch. As of gopls v0.18.0,
older release branches (beyond the usual ones covering…dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 in x/arch1w
Thanks.dmitshur commented on golang.org/x/build: add LUCI windows/arm64 builder1w
Noting that the "--" sequence in the hostname has a special meaning, the best docs that I could find for it so far are [here](https://source.chromium.org/chromium/infra/infra_superproject/+/main:infr…dmitshur commented on golang.org/x/build: add LUCI windows/arm64 builder1w
CC @golang/release, @golang/windows.dmitshur commented on golang.org/x/build/main.star: add known issue for linux-arm64_debian13 in x/arch1w
It seems the x/arch issue was just recently fixed. I appended another CL 765300 to drop the known issue; submitting this as is since it adds improved syntax support, something we'll want to be able t…dmitshur opened a change golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 in x/arch1w
Issue golang/go#66005 was fixed by CL 759280.
For golang/go#74985.
For golang/go#66005.dmitshur commented on golang.org/x/arch: TestObjdumpARM64TestDecodeGNUSyntaxdata and TestObjdumpARM64TestDecodeGoSyntaxdata fail with binutils 2.421w
Fixed by [CL 759280](https://go.dev/cl/759280) (commit golang/arch@e36c9fb6d51bbba090562e5df53be05a4ab3b74f). Thanks @JunyangShao!dmitshur commented on golang.org/x/tools/gopls/completion: prepend space when completing right after "//" before a declaration1w
Generally, it's not possible to use trybots (aka "pre-submit builders") on a CL after it's submitted. However, you can look at the post-submit dashboard to see post-submit builder results, and they s…dmitshur opened a change golang.org/x/build/main.star: add known issue for linux-arm64_debian13 in x/arch1w
The builder isn't working in x/arch yet, but it is working in
all other golang.org/x repositories. Annotate it accordingly.
For golang/go#74985.
For golang/go#66005.dmitshur commented on golang.org/x/tools/gopls/doc: update go command version support description1w
Thanks.dmitshur commented on golang.org/x/tools/gopls/doc: simplify 'supported Go versions' section1w
Thanks.dmitshur commented on golang.org/x/tools/gopls/doc: simplify 'supported Go versions' section1w
(1 comment)
Sounds good. Then we can probably also drop the "keep this in sync" note in goversion.Supported.
Done in PS 2.dmitshur commented on golang.org/x/tools/gopls/doc: update go command version support description1w
(1 comment)
Sure. Thanks for suggesting a better re-write of this section.
Since it's a bit of a bigger change, done in a followup CL 765040 so we can keep this a smaller correction of what's out o…dmitshur opened a change golang.org/x/tools/gopls/doc: simplify 'supported Go versions' section1w
Based on suggested text by Alan in CL 764860.
For golang/go#69321.dmitshur opened a change golang.org/x/build/internal/migration: stop running any remaining legacy builders1w
We're long past the deadline for migrating builders from the legacy
build infrastructure (cmd/coordinator) to LUCI (go.dev/wiki/LUCI).
We planned to give more time to builders whose migration were un…dmitshur commented on golang.org/x/tools/gopls/doc: update go command version support description1w
(2 comments)
Thanks, done.
Updated accordingly.dmitshur commented on golang.org/x/tools/gopls/doc: narrow go command version support policy to 21w
(2 comments)
I started doing that, and... see my other inline comment.
Wow, I completely missed this. So it seems this is already done as of v0.18.0, then? Was it just that we forgot to update the …dmitshur commented on golang.org/x/tools/gopls/doc: narrow go command version support policy to 21w
This change is ready for review.dmitshur reviewed +2 on golang.org/dl/gotip: explicitly set GOTOOLCHAIN=auto1w
Thanks.
I see.
> Should we leave this open so we can fix for other go1.X?
>
> I am thinking maybe the same solution works for other go versions.
I'm not sure that there's an issue for other go1.X …dmitshur reviewed +2 on cmd/go: use fsys.ReadDir for IsStandardPackage1w
(2 comments)
Thanks.
Thanks.dmitshur reviewed +2 on cmd/go: use fsys.ReadDir for IsStandardPackage1w
Thanks.
A question about the kind of paths being involved here.
`dir` is clearly a filesystem path (not '/'-separated path), and filepath.ToSlash isn't being used here. Is that because https://pkg.…dmitshur reviewed +2 on cmd/go: build pkgsite doc command in same go command invocation1w
Thanks. In general this makes sense and I didn't see issues, though take into account I'm not as familiar with cmd/go's internal APIs, so you can wait for another review as you see fit.
Makes sense.…dmitshur commented on cmd/internal/testdir:6_10: Test/rangegen.go failures1w
> Does the CI client restart after each test run? If so, that should result in restarting the container, and a fresh tmpfs.
No, in general the swarming bot client runs a number of builds in sequence…dmitshur opened an issue cmd/internal/testdir: Test/fixedbugs/bug513.go fails on FreeBSD 15.01w
Now that issue #77411 is resolved at tip, the [gotip-freebsd-amd64_15.0 builder](https://ci.chromium.org/ui/p/golang/builders/ci/gotip-freebsd-amd64_15.0) now has only one failing test:
```
=== RUN …dmitshur commented on golang.org/dl/internal/version: set GOTOOLCHAIN=local+auto for gotip1w
Thanks. This generally seems fine to me, and Michael's already reviewed it. I left a few comments that were on my mind, but they're minor and I think you should feel free to proceed.
Since this chan…dmitshur commented on golang.org/x/website/cmd/golangorg: use _goroot.zip during deploy tests too1w
Thanks.
I tested locally and it seems like it should do what's intended. I'll keep an eye on the next few deploys, too.dmitshur fixed an issue security: fix CVE-2026-27140 [1.26 backport]1w
Closed by merging [CL 763549](https://go.dev/cl/763549) (commit 096f21b1c50fe62bc54c1fb1ede60fca63239123) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-27140 [1.25 backport]1w
Closed by merging [CL 763556](https://go.dev/cl/763556) (commit abaa0cbb259e059ee60c33a7507eddc1fe7d20fa) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-32283 [1.25 backport]1w
Closed by merging [CL 763555](https://go.dev/cl/763555) (commit 02f574a8303560a4a79a42834f3092ce7c9a57cc) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-32283 [1.26 backport]1w
Closed by merging [CL 763548](https://go.dev/cl/763548) (commit 7cafb4140d5616f1a0316a194a977b0794cd7d7c) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-27143 [1.26 backport]1w
Closed by merging [CL 763546](https://go.dev/cl/763546) (commit c4b4bd7b3aefeb67a541912df0733bde68333bfc) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-27143 [1.25 backport]1w
Closed by merging [CL 763553](https://go.dev/cl/763553) (commit 7d2dd3488cdfbddda14c18c455d3263df75a46fc) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-27144 [1.25 backport]1w
Closed by merging [CL 763552](https://go.dev/cl/763552) (commit 72cc33629a3b26e68f6e6e5564618a1d763896f3) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-27144 [1.26 backport]1w
Closed by merging [CL 763545](https://go.dev/cl/763545) (commit 3a4577a2687ad46d2a00305ddb68733283ea0720) to release-branch.go1.26.