Activity
Yesterday
dmitshur commented on github.com/gopherjs/gopherjs/natives: duplicate aliasing.go in x/crypto10h
Neither location is absolutely ideal. It's a patch that makes use of:
- internal GopherJS APIs (which may become different depending on GopherJS version)
- internal x/crypto APIs (which may become …Last Week
dmitshur starred in brainbaking.com/go-jamming1d
dmitshur commented on golang.org/x/build/maintner: client Corpus is unhelpfully verbose by default1d
@Hrtkk Thanks for offering. As you noticed, there are already 2 CLs out that will fix this issue. You're welcome to help with [reviewing](https://golang.org/doc/contribute#reviews) them. Thanks!dmitshur commented on golang.org/x/build/cmd/coordinator: consolidate TryBot branch logic2d
(1 comment)
Sure. It's easy to do since tryWorkItem has an error return value now, but then it worked out better just to factor it out to the caller who is in a better position to determine deve…dmitshur opened a change golang.org/x/build/maintner: log about loading unknown JSON only in verbose mode2d
We already log about storing unknown JSON (on the server) and can look
up occurrences there. Most clients don't care, so only log if they are
in verbose mode.
Fixes golang/go#46180.dmitshur opened a change golang.org/x/build/maintner: discard lock_reason in GitHub issue events2d
"lock_reason" is a field that was added to GitHub API v3 after maintner
was created. It's present in GitHub issue "locked" events and indicates
the reason the issue was locked, su…dmitshur opened an issue golang.org/x/build/maintner: client Corpus is unhelpfully verbose by default2d
### What did you do?
Use a client `*maintner.Corpus` via the [`godata`](https://pkg.go.dev/golang.org/x/build/maintner/godata) package.
See [example code](https://pkg.go.dev/golang.org/x/build/…dmitshur opened an issue golang.org/x/build/devapp/owners: remove stale and unhelpful entries2d
The list of owners at https://dev.golang.org/owners is updated periodically via people sending CLs that add/remove entries. Given a good amount of time has passed and people's priorities and time ava…dmitshur commented on cmd/dist: display first class port status in json output2d
First pass review with just minor comments.
Please add a period at the end of the sentence (per https://golang.org/s/style#comment-sentences). Also add "See golang.org/issue/38874." after it…dmitshur edited the wiki2d
dmitshur reviewed +2 on golang.org/x/website/all: remove ?m=src2d
So long, this niche mode!.
This line isn't a part of "collect examples" (it was previously separated by being in a separate block), so maybe add a blank line above it, or better yet move…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: fixup -tags prod for internal/web2d
dmitshur commented on golang.org/x/website/all: remove toFS usage2d
(2 comments)
It looks like this unintentionally reverts a code simplification that was intentionally made in CL 311089. Since the name variable isn't used anywhere below, I don't see a reaso…dmitshur commented on golang.org/x/website/all: remove Path metadata-based redirects2d
I really like the direction of this change.
I have some questions to confirm/better understand the intended changes to the URLs. See inline comment on line 203 of godoc_test.go. Once I know the answ…dmitshur commented on golang.org/x/website/cmd/golangorg: remove special cases for /project/, /doc/devel/release2d
I think the direction of this change is great, but I wanted to ask one question about the data structure change to history.Release, to understand it better. Please see the inline comment on line 15 o…dmitshur commented on golang.org/x/build/cmd/coordinator: consolidate TryBot branch logic3d
(1 comment)
Fixed in PS 2.dmitshur commented on golang.org/x/build/cmd/release: evaluate releaselets used for each upcoming major Go release3d
We agreed to use `darwin-amd64-11_0` for 1.17 onwards, filed #46161 for that, and moving this to 1.18 milestone.dmitshur opened an issue golang.org/x/build/cmd/release: use darwin-amd64-11_0 releaselet starting with Go 1.17 Beta 13d
This is consistent with our approach of using latest major macOS version builder for creating macOS releases. Also see https://github.com/golang/go/issues/40561#issuecomment-840725710.
CC @golang/…dmitshur commented on golang.org/x/build/cmd/release: evaluate releaselets used for each upcoming major Go release3d
There haven't been noteworthy builder changes in the last 2 weeks since https://github.com/golang/go/issues/40561#issuecomment-830424055. I've looked over our current selection of releaselets for 1.1…dmitshur opened an issue golang.org/x/build/maintner/maintnerd/maintapi: test x/tools CLs on gopls-release-branch.* branches also with past 2 releases3d
In golang.org/x repo, TryBots testing CLs on branches other than the default "master" branch are only tested with Go tip, not with the past 2 releases (e.g., 1.16 and 1.15).
The `gopls-release-bra…dmitshur commented on golang.org/x/build: use new name for release branches in golang.org/x repos starting with Go 1.163d
There's one more place that needs updating, opened #46154 to track it.dmitshur opened an issue golang.org/x/build/cmd/coordinator: TryBots should test golang.org/x internal branches like they do release branches3d
Issue #28891 was about having coordinator test golang.org/x repos on release branches like "release-branch.go1.n" with Go 1.n exactly, rather than Go tip. This is because those branches are specifica…dmitshur commented on cmd/compile: failures with "wait: no child processes" on solaris-amd64-oraclerel since 2021-04-024d
I'm not aware of builder changes on our side, but `solaris-amd64-oraclerel` is a [reverse builder](https://farmer.golang.org/builders) whose owner is @rorth, and perhaps they may be aware of some cha…dmitshur commented on golang.org/x/build/cmd/releasebot: add an upper limit to the total log posted to GitHub4d
I think it's hard to determine what an optimal value for this is, given how infrequently it may happen. I wanted to suggest 2 MB to match our current limit in x/build logs, but imagining releasebot p…dmitshur commented on golang.org/x/build/cmd/release: macOS installer should add GOBIN to PATH5d
I spent some time investigating this and found some additional constraints and challenges. It seems we can't make a simple change here without potentially needing larger UI and behavior changes, and …dmitshur commented on golang.org/x/build/cmd/coordinator: failed to add requested SlowBot5d
Actually, I think there are at least 2 underlying problems. Let's keep #42084 about it ignoring re-requests on same patch set with a different TRY= message, which might be a simple logic fix.
One …dmitshur commented on golang.org/x/build/cmd/coordinator: SlowBot requests are sometimes not recognized (seemingly when re-requested on same patch set)5d
The `<=` in this segment is looks suspicious:
https://github.com/golang/build/blob/58cc22bdeadbabfebe33fa4dda4b08e14b036336/maintner/maintnerd/maintapi/api.go#L142-L144
Shouldn't it be `<`, els…dmitshur commented on golang.org/x/build/cmd/coordinator: failed to add requested SlowBot5d
This looks likely to be the same as #42084. At least the investigation there could explain this instance too. Should we close this in favor of that issue or keep it open?dmitshur commented on cmd/dist: delete branchtag and its misleading use in findgoversion6d
I think we can delete this as a next step, which shouldn't change behavior in meaningful ways, but make the current code easier to maintain and change in the future.
Better to do it not during the…dmitshur commented on golang.org/x/build: remove Scaleway builders6d
This is currently in 1.17 milestone, but Go 1.15 will be supported throughout this milestone. Moving to 1.18 and adding early-in-cycle instead.dmitshur commented on run.bash: document GOTESTONLY, GO_TEST_SHORT and GO_TEST_TIMEOUT_SCALE6d
Also CC @golang/release.
`GO_TEST_SHORT` is currently an internal implementation detail of the build system and not intended for users (see [here](https://github.com/golang/go/blob/d9e068d2894ff2f…dmitshur closed an issue golang.org/x/build/cmd/gopherbot: don't mark issues as fixed if the “fix” verb is part of a larger sentence6d
dmitshur commented on golang.org/x/build/cmd/gopherbot: don't mark issues as fixed if the “fix” verb is part of a larger sentence6d
Closing but let me know if I missed something.dmitshur commented on golang.org/x/build/cmd/gopherbot: don't mark issues as fixed if the “fix” verb is part of a larger sentence6d
This behavior is implemented by GitHub and not GopherBot per se. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-iss…dmitshur commented on github.com/shurcooL/tictactoe: Ensure move is valid1w
Ah, it was `playerTurn`, not `playerMove`, sorry for misdirecting.Earlier
dmitshur commented on golang.org/x/lint: freeze and deprecate1w
`gitmirror` is redeployed with [CL 318190](https://golang.org/cl/318190), and its errors are now fixed (they [could be seen](https://user-images.githubusercontent.com/1924134/117556647-14970c80-b039-…dmitshur deleted branch in github.com/shurcooL/home1w
devdmitshur commented on golang.org/x/lint: freeze and deprecate1w
@mvdan Sure, done.dmitshur commented on github.com/shurcooL/tictactoe: Ensure move is valid1w
Ok. Let's try it. This PR will need further changes to be complete:
1. The documentation of Apply should be updated to reflect the new behavior:
```Go
// Apply a move to this board. Mark is …dmitshur pushed to
master in github.com/shurcooL/tictactoe1w
dmitshur merged a change github.com/shurcooL/tictactoe: Better formatting of print1w
dmitshur reviewed +2 on github.com/shurcooL/tictactoe: Better formatting of print1w
I tried it out, and agree it's an improvement. Thanks.dmitshur commented on github.com/shurcooL/tictactoe: Ensure move is valid1w
The `Apply` method documentation says:
```
// Apply a valid move to this board. Mark is either X or O. [...]
```
It's a precondition for `Apply` that the move must be valid. As long as it's a…dmitshur pushed to
master in github.com/shurcooL/tictactoe1w
dmitshur closed an issue github.com/shurcooL/tictactoe: Add a License1w
dmitshur commented on golang.org/x/lint: freeze and deprecate1w
Thank you @mvdan, I agree it would be helpful.
I added one more step to Andy's comment, to add `archivedOnGitHub` option to x/build/repos (similar to [CL 289699](https://golang.org/cl/289699)), wh…dmitshur opened an issue golang.org/x/tools/internal/jsonrpc2_v2: TestIdleTimeout failed with "goroutine leak detected" on openbsd-amd64-68 once1w
Observed the following test failure on a `openbsd-amd64-68` TryBot in https://go-review.googlesource.com/c/tools/+/313097/7#message-05b2ee7a7f430f763806057296bde561b9777f07:
```
--- FAIL: TestIdl…dmitshur commented on doc/go1.17: document changes to the language for Go 1.171w
@griesemer In addition to "spec: allow conversion from slice to array ptr" ([CL 216424](https://golang.org/cl/216424)), are there more change to the language for Go 1.17? I see the go_spec.html file …dmitshur commented on doc/go1.17: document spec changes for Go 1.171w
"spec" isn't a Go package. This TODO should be moved to the https://tip.golang.org/doc/go1.17#language section. I can help with that.dmitshur commented on go/types: TestStdlib is accidentally skipped1w
Nicely spotted. Also CC @bcmills.dmitshur closed an issue net/http: ReadRequest can stack overflow due to recursion with very large headers1w
dmitshur commented on net/http: ReadRequest can stack overflow due to recursion with very large headers1w
The x/net fix has been pulled into the main repo for Go 1.17 as part of [CL 316251](https://golang.org/cl/316251). Closing as fixed.dmitshur closed an issue golang.org/x/build: windows-arm-zx2c4 builder missing1w
dmitshur commented on golang.org/x/build: windows-arm-zx2c4 builder missing1w
Thank you.dmitshur commented on runtime: "unexpected return pc for runtime.sigpanic" in x/perf/storage/app on darwin-amd641w
> I still find the dashboard for subrepos a bit hard to understand. Apparently the "Go commits" are not in order?
Sorry about that. This is #28643, and improvements to that should follow after #3474…dmitshur commented on build: announce end of support for old macOS releases1w
Mailed [CL 316889](https://golang.org/cl/316889) for 1.17. Will move this to the next milestone when it's submitted.dmitshur commented on golang.org/x/website: https://golang.org/dl/?mode=json&include=all to https://golang.org/dl/releases.json1w
The proposed scheme has some convenience improvements in specific cases, but I think the bar for introducing and perpetually maintaining a mirror of an API needs to be higher than minor convenience i…dmitshur commented on golang.org/x/build: gopls-CI Kokoro presubmit failing on CL 315570 due to `rsync` failure1w
> The failure log also links to a document that no longer exists (https://go.googlesource.com/tools/+/refs/heads/master/gopls/doc/user.md#supported-go-versions),
It looks like the new link should be…dmitshur opened an issue golang.org/x/build/cmd/release: in -upload mode, difficult to recover/resume if third step fails2w
When `release` runs in upload mode (that is, with `-upload` flag), it goes through 3 high level stages:
1. [uploads files to GCS](https://github.com/golang/build/blob/249a248223ffdaccaf87d0ee76bca…dmitshur commented on golang.org/x/website/internal/dl: expose whether a release is a security release or not in API2w
The https://golang.org/design/draft-vulndb design draft may also be a relevant factor to consider here.
CC @golang/security, @golang/release.dmitshur closed an issue golang.org/x/website: improve /doc/tutorial/call-module-code to adapt to the Go 1.162w
dmitshur commented on golang.org/x/website: improve /doc/tutorial/call-module-code to adapt to the Go 1.162w
I agree it looks like this has been fixed, so closing. Please let us know if we missed something.dmitshur commented on cmd/dist: show which GOOS/GOARCH combinations are first class ports2w
As another data point, this might be useful for issue #14892, if we'd like to arrange that all first-class ports (but not necessarily all ports) are automatically specified as contexts for the purpos…dmitshur commented on api: API check test should disallow API additions after an api/go1.N.txt is created (currently it does this only after a VERSION file is added)2w
@FiloSottile After taking some time to think about it carefully, I'm in agreement with the suggestion you made. I, too, now believe there is a good chance that removing our use of next.txt and requir…dmitshur commented on runtime: remove VZEROUPPER patch once Darwin <10.15.6 is not supported2w
I understand this isn't so critical that we need to re-evaluate and bump every 6 months, so I'll put this in a future Go 1.23 milestone. If something changes before then, we can revisit this.dmitshur commented on golang.org/x/build: limit number of trybot reattempts2w
CC @golang/release.dmitshur closed an issue golang.org/x/build: dragonfly builders acting up2w
dmitshur commented on golang.org/x/build: dragonfly builders acting up2w
It has come down by this time:
```
host-dragonfly-amd64-5_8: 518 waiting (oldest 24h38m57s, newest 2h30m48s, progress 2s)
host-dragonfly-amd64-master: 552 waiting (oldest 24h38m57s, newest 2h30m…dmitshur commented on cmd/go: frequent test timeouts on dragonfly-amd64 builder2w
Based on that information about the builder, it sounds like it's expected it to need more time to complete tests successfully, so increasing the test timeout (#45216) has a good chance of resolving t…dmitshur commented on golang.org/x/build: dragonfly-amd64 builders may need a longer TEST_TIMEOUT_SCALE2w
@tuxillo Sure, let's try going with 2x and see how it goes. We can always follow up if needed.
Please feel free to send a CL and make me a reviewer. You can look at [CL 300870](https://golang.org/…dmitshur closed an issue golang.org/x/build: dragonfly-amd64 builder missing2w
dmitshur commented on golang.org/x/build: dragonfly-amd64 builder missing2w
I see that both of these builders are online and doing work, so closing this.
```
host-dragonfly-amd64-5_8: 1/1
host-dragonfly-amd64-master: 1/1
```
Thank you @tuxillo.dmitshur commented on golang.org/x/build: auto-add slowbots based on branch / CL contents2w
I'll retitle this to about adding the ability to opt-in to builders based on files modified in a CL. We need to do some work for it, but it would enable us to improve pre-submit test coverage in a mo…dmitshur commented on net/http: ReadRequest can stack overflow [1.15 backport]2w
Fixred by merging 5aed4ce3c854bdbbb6dd5c1ccfa15c23d4b6c989 to release-branch.go1.15.dmitshur closed an issue net/http: ReadRequest can stack overflow [1.15 backport]2w
dmitshur closed an issue test: fuse.go consistently failing on noopt builder2w
dmitshur commented on test: fuse.go consistently failing on noopt builder2w
Fixed by [CL 314632](https://golang.org/cl/314632). Thanks @bcmills for reporting and @cherrymui for fixing.dmitshur reopened an issue net/http: ReadRequest can stack overflow [1.15 backport]2w
dmitshur reopened an issue net/http: ReadRequest can stack overflow [1.15 backport]2w
dmitshur commented on net/http: ReadRequest can stack overflow [1.15 backport]2w
Reopening for update to the vendored copy in the Go tree.dmitshur edited the wiki2w
dmitshur edited the wiki2w
dmitshur reopened an issue net/http: ReadRequest can stack overflow due to recursion with very large headers2w
dmitshur commented on net/http: ReadRequest can stack overflow due to recursion with very large headers2w
The x/net fix still needs to be pulled into the main Go repo as done in [CL 314596](https://golang.org/cl/314596), reopening for that (and adding release-blocker so it's not missed).dmitshur commented on http: ReadRequest can stack overflow [1.15 backport]2w
Approved as this is a security fix. This backport applies to both 1.16 (#45712) and 1.15 (this issue).dmitshur commented on http: ReadRequest can stack overflow [1.16 backport]2w
Approved as this is a security fix. This backport applies to both 1.16 (this issue) and 1.15 (#45711).dmitshur commented on cmd/dist: show which GOOS/GOARCH combinations are first class ports2w
@ianlancetaylor I think your understanding of how this could be implemented is accurate. I agree referring to `cmd/dist` is more precise; I was mentioning `cmd/go` only because I expected it's more l…dmitshur opened an issue golang.org/x/build: windows-arm-zx2c4 builder missing2w
The `windows-arm-zx2c4` builder is currently missing. From https://farmer.golang.org/#pools:
```
host-windows-arm64-zx2c4: 0/0 (1 missing)
```
@zx2c4 Are you able to take a look? Thank you.
…dmitshur commented on golang.org/x/build/cmd/coordinator: failing to complete TryBot run for change with duplicate Change-Id line2w
Another instance in [CL 313132](https://golang.org/cl/313132).
We're making progress on fixing #45213, but if this keeps happening even after that, it might be worth reopening.dmitshur commented on net: BenchmarkTCP{4,6}ConcurrentReadWrite failures on freebsd-amd64-race with "read: connection reset by peer"2w
The new builder will be used in future testing (existing commit with test results are not automatically re-tested at this time), so its results will show up when new commits are pushed, or by explici…dmitshur commented on github.com/gopherjs/gopherjs.github.io: Update playground for GopherJS 1.16.1+go1.16.33w
Fixed the access issue for you both.dmitshur commented on golang.org/x/build: misc-compile TryBots are too slow3w
With the work done to migrate x/build to OpenCensus in [CL 303669](https://golang.org/cl/303669), we're closer to starting to measure and track TryBot completion time, which has been a blocker for ma…dmitshur commented on golang.org/x/build/cmd/release: update to FreeBSD-[amd64|386]-11_4 builder for 1.17 Beta3w
Using the latest "patch" release of the oldest "major" release of FreeBSD that we support for issuing Go 1.17 releases seems consistent with what we've done before, and SGTM.dmitshur commented on golang.org/x/tools/cmd/getgo: uses incorrect "latest" url3w
That sounds good, thank you!dmitshur commented on golang.org/x/tools/cmd/getgo: uses incorrect "latest" url3w
@fmpwizard [CL 270878](https://golang.org/cl/270878) has some outstanding review comments, once addressed it should be good to submit. Are you able to take a look?dmitshur closed an issue golang.org/x/vulndb: new repository3w
dmitshur commented on golang.org/x/vulndb: new repository3w
[golang.org/x/vulndb](https://golang.org/x/vulndb) is now live. Please comment or reopen if there's anything more.
I'll mention that since this x repo has its own issue tracker, you may or may not…dmitshur commented on github.com/shurcooL/gtdo: Show LICENSE information when available3w
I agree this information would be helpful to expose, especially when viewing specific commits other than the latest one on the main branch (something that gtdo lets users do).
However, this informat…dmitshur edited the wiki3w
dmitshur reviewed +2 on github.com/gopherjs/gopherjs/compiler/natives/src/syscall: fix broken build3w
Thanks. Not finding issues in this change.