Today
dmitshur commented on x/tools/cmd/go-contrib-init: requir… in github.com/golang/go5h
> to be set up as x/tools/scratch
Did you mean "as x/scratch" in the title?
I think there's still value in pretending scratch would live at `golang.org/x/scratch`, if it were a real subrepo, becaus…
> to be set up as x/tools/scratch
Did you mean "as x/scratch" in the title?
I think there's still value in pretending scratch would live at `golang.org/x/scratch`, if it were a real subrepo, becaus…dmitshur commented on apostrophes get turned into HTML en… in github.com/microcosm-cc/bluemonday15h> that data will be saved in a database eventually and redisplayed later.
How are you planning to display it later?
It sounds like what you’re looking for is an HTML to text renderer. Then yo…
> that data will be saved in a database eventually and redisplayed later.
How are you planning to display it later?
It sounds like what you’re looking for is an HTML to text renderer. Then yo…dmitshur commented on Rendering a Triangle with Apple's M… in dmitri.shuralyov.com/blog17h
An update: there is now code to open a window with a Metal layer, and render the triangle that follows your mouse at 60+ FPS.
[.
I'm okay with quoting the C type; I just wanted it to be a more complete sentence (with a period at the end).dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow18hSource: https://golang.org/s/style#declaring-empty-slices.
Source: https://golang.org/s/style#declaring-empty-slices.Yesterday
dmitshur created package dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/ns18h
Package ns provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur created package dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/ca18h
Package ca provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package dmitri.shuralyov.com/gpu/mtl/example/movingtriangle18h
movingtriangle is an example Metal program that displays a moving triangle in a window.
dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow20hI know `gl` is a large generated package, but I still think it'd be nice to follow http://golang.org/s/style#comment-sentences more closely.
Perhaps generate sentences like this:
```
// Parame…
I know `gl` is a large generated package, but I still think it'd be nice to follow http://golang.org/s/style#comment-sentences more closely.
Perhaps generate sentences like this:
```
// Parame…dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow20hMore idiomatic to just do `var lines []string`.
More idiomatic to just do `var lines []string`.dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow20hYou're checking if the `fn.Doc` string is not empty here, right? I recommend this style:
```Go
if fn.Doc != "" {
```
For reasons style described in https://dmitri.shuralyov.com/idiomatic-go#e…
You're checking if the `fn.Doc` string is not empty here, right? I recommend this style:
```Go
if fn.Doc != "" {
```
For reasons style described in https://dmitri.shuralyov.com/idiomatic-go#e…dmitshur commented on access: may-start-trybots in github.com/golang/go1dHi Carlos,
Thank you for your contributions and for requesting Trybots access! I've added you to the `may-start-trybots` group, so you should be able to do so now.
As you've likely read at http…
Hi Carlos,
Thank you for your contributions and for requesting Trybots access! I've added you to the `may-start-trybots` group, so you should be able to do so now.
As you've likely read at http…dmitshur commented on encoding/gob: tooBig is too small in github.com/golang/go1dIndeed. I kept an eye on gopherbot logs (among other things) during the GitHub semi-outage, and didn't spot it doing anything visibly bad. (See #28320 for what I did find, but it's unrelated to this.…
Indeed. I kept an eye on gopherbot logs (among other things) during the GitHub semi-outage, and didn't spot it doing anything visibly bad. (See #28320 for what I did find, but it's unrelated to this.…dmitshur commented on x/build/maintner: reports incorrect… in github.com/golang/go1dThis would be a good issue for anyone who wants to help out and do some investigation. It'd be very helpful for us to find out what's causing this issue.
This would be a good issue for anyone who wants to help out and do some investigation. It'd be very helpful for us to find out what's causing this issue.dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl1dSounds good; I'm in agreement.
Following the same logic, I think we should change (or consider changing; perhaps for 3.3) `GetCocoaWindow` and similar methods in `glfw` to return `unsafe.Pointer` …
Sounds good; I'm in agreement.
Following the same logic, I think we should change (or consider changing; perhaps for 3.3) `GetCocoaWindow` and similar methods in `glfw` to return `unsafe.Pointer` …
This Week
dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl1d> I think `uintptr` makes the most sense, just because that is what is proper in general / it is the least bad solution.
One issue I'm currently facing with pointers to C types returned as `uintpt…
> I think `uintptr` makes the most sense, just because that is what is proper in general / it is the least bad solution.
One issue I'm currently facing with pointers to C types returned as `uintpt…dmitshur commented on No longer go gettable with go 1.11 … in github.com/davecgh/go-spew2dI don't think you can use `GO111MODULE=on` inside a GOPATH workspace, can you? I think
`GO111MODULE=on` is allowed only outside of GOPATH, and ``GO111MODULE=off` or ``GO111MODULE=auto` are allowed …
I don't think you can use `GO111MODULE=on` inside a GOPATH workspace, can you? I think
`GO111MODULE=on` is allowed only outside of GOPATH, and ``GO111MODULE=off` or ``GO111MODULE=auto` are allowed …dmitshur commented on 
Initial Metal example in github.com/glfw/glfw2dI see, thanks. Reading the rest of the documentation I linked above has some very relevant sections:
> In addition to creating a layer-backed view, you can create a layer-hosting view by assigning…
Initial Metal example in github.com/glfw/glfw2dI see, thanks. Reading the rest of the documentation I linked above has some very relevant sections:
> In addition to creating a layer-backed view, you can create a layer-hosting view by assigning…dmitshur commented on Initial Metal example in github.com/glfw/glfw2dThe default value here is `NO` so setting it to `YES` has an effect. However, I haven't been able to spot any differences in behavior regardless if `wantsLayer` is set to `YES` or left at `NO`.
Ac…
Initial Metal example in github.com/glfw/glfw2dThe default value here is `NO` so setting it to `YES` has an effect. However, I haven't been able to spot any differences in behavior regardless if `wantsLayer` is set to `YES` or left at `NO`.
Ac…dmitshur commented on Initial Metal example in github.com/glfw/glfw2dFWIW, according to https://developer.apple.com/documentation/quartzcore/cametallayer/1478155-pixelformat:
> The default value is `MTLPixelFormatBGRA8Unorm`.
So this line is a no-op.
Initial Metal example in github.com/glfw/glfw2dFWIW, according to https://developer.apple.com/documentation/quartzcore/cametallayer/1478155-pixelformat:
> The default value is `MTLPixelFormatBGRA8Unorm`.
So this line is a no-op.dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl2d> my understanding is that `unsafe.Pointer` forces to import `unsafe` package to the package users
I'm not sure if that's quite right. My understanding is that if a package returns `unsafe.Pointer…
> my understanding is that `unsafe.Pointer` forces to import `unsafe` package to the package users
I'm not sure if that's quite right. My understanding is that if a package returns `unsafe.Pointer…dmitshur commented on githubapi: Possible nil pointer der… in github.com/shurcooL/events2dI have never seen this occur again.
My guess is that this happened because of some temporary problems on GitHub side that shouldn't happen again.
Closing, but can be re-opened and re-considered…
I have never seen this occur again.
My guess is that this happened because of some temporary problems on GitHub side that shouldn't happen again.
Closing, but can be re-opened and re-considered…dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl2dIn general, removing C types from the `gl` public API SGTM. I suspect it was an oversight rather than intentional decision that they ended up there (please correct me if wrong).
> replace such C t…
In general, removing C types from the `gl` public API SGTM. I suspect it was an oversight rather than intentional decision that they ended up there (please correct me if wrong).
> replace such C t…dmitshur commented on gl.FenceSync returns invalid unsafe… in github.com/go-gl/gl2dFriendly ping @dominikh. You said [on February 15](https://github.com/go-gl/gl/issues/71#issuecomment-366133553):
> I've finally gotten around to testing the change. It compiles, doesn't cause run…
Friendly ping @dominikh. You said [on February 15](https://github.com/go-gl/gl/issues/71#issuecomment-366133553):
> I've finally gotten around to testing the change. It compiles, doesn't cause run…dmitshur commented on remove dependency on cgo in github.com/go-gl/gl2dIndeed. However, there's only 8 of them (compared to hundreds or thousands of Go types), and I don't think they should've been exposed in the first place. I don't know whether they're functional eith…
Indeed. However, there's only 8 of them (compared to hundreds or thousands of Go types), and I don't think they should've been exposed in the first place. I don't know whether they're functional eith…Last Week
dmitshur commented on platform/darwin: Make NSStatusItem … in github.com/shurcooL/trayhost3d@pavben said over chat:
> if it works with dark mode now and you don’t have any strong reservations about the method used, I’m happy with it
@pavben said over chat:
> if it works with dark mode now and you don’t have any strong reservations about the method used, I’m happy with itdmitshur commented on all: Regenerate after DO NOT EDIT c… in github.com/go-gl/gl3dNope, this PR already included https://github.com/go-gl/glow/pull/99 in it.
Nope, this PR already included https://github.com/go-gl/glow/pull/99 in it.dmitshur commented on client: Icon renders poorly in Dark… in github.com/pavben/InstantShare3dI've found good information on how to support dark mode in this Stack Overflow answer:
https://stackoverflow.com/questions/24623559/nsstatusitem-change-image-for-dark-tint/24644754#24644754
Luc…
I've found good information on how to support dark mode in this Stack Overflow answer:
https://stackoverflow.com/questions/24623559/nsstatusitem-change-image-for-dark-tint/24644754#24644754
Luc…dmitshur commented on Remove importing C from conversions… in github.com/go-gl/glow3dAlso, any non-trivial changes to glow make sense to land after we've gained confidence in the generated code works well and we want to keep it.
Also, any non-trivial changes to glow make sense to land after we've gained confidence in the generated code works well and we want to keep it.dmitshur commented on Remove importing C from conversions… in github.com/go-gl/glow3dIt's hard for me to know what effect making this change would have, and I'm hesitant to make a change here before knowing the full picture.
Have you already prototyped the entire "drop Cgo" change…
It's hard for me to know what effect making this change would have, and I'm hesitant to make a change here before knowing the full picture.
Have you already prototyped the entire "drop Cgo" change…
dmitshur commented on Use the standard do-not-edit commen… in github.com/go-gl/glow3d```suggestion
// Code generated by glow (https://github.com/go-gl/glow). DO NOT EDIT.
```
```suggestion
// Code generated by glow (https://github.com/go-gl/glow). DO NOT EDIT.
```dmitshur commented on Use the standard do-not-edit commen… in github.com/go-gl/glow3dPlease update the URL scheme to https. Here, and below.
```suggestion
// Code generated by glow (https://github.com/go-gl/glow). DO NOT EDIT.
```
Please update the URL scheme to https. Here, and below.
```suggestion
// Code generated by glow (https://github.com/go-gl/glow). DO NOT EDIT.
```dmitshur commented on x/tools/present: Docs say 'h' key i… in github.com/golang/go3d> So something doesn't look right here. I don't know if the documentation is wrong, or if the implementation has a bug.
I did some code archeology to find out. The earlier commit I found where the…
> So something doesn't look right here. I don't know if the documentation is wrong, or if the implementation has a bug.
I did some code archeology to find out. The earlier commit I found where the…
dmitshur commented on Support Go modules. in github.com/shurcooL/vfsgen3d`vfsgen` itself supports modules.
`./cmd/vfsgendev`, a convenience tool for using `vfsgen` in a specific way, currently doesn't support modules because it looks for import paths only within GOPATH…
`vfsgen` itself supports modules.
`./cmd/vfsgendev`, a convenience tool for using `vfsgen` in a specific way, currently doesn't support modules because it looks for import paths only within GOPATH…dmitshur commented on cmd/gopherbot: race condition in au… in github.com/golang/go3dI think I've already seen code somewhere that uses Gerrit API in addition to `maintner` to confirm the "latest" state before taking some action. @bradfitz will probably remember where that was.
I …
I think I've already seen code somewhere that uses Gerrit API in addition to `maintner` to confirm the "latest" state before taking some action. @bradfitz will probably remember where that was.
I …dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go3d> Will redeploy `cmd/coordinator` later tonight (when it's quieter).
Version golang/build@24469dd429f05bdb34b644430843761abf7e1367 of `cmd/coordinator` is deployed now.
> Will redeploy `cmd/coordinator` later tonight (when it's quieter).
Version golang/build@24469dd429f05bdb34b644430843761abf7e1367 of `cmd/coordinator` is deployed now.dmitshur commented on set exit code according to found wa… in github.com/mvdan/unparam3dI'm a little surprised this PR was merged to `master` as 3 individual commits rather than squashing into one. Was that intentional?
I'm a little surprised this PR was merged to `master` as 3 individual commits rather than squashing into one. Was that intentional?dmitshur commented on basic changes for vgo support in github.com/go-audio/wav3d> I had to put all tests into the wav package to make vgo happy.
What was the error you're getting? Which version of Go were you using? I don't think that should be the case.
> I had to put all tests into the wav package to make vgo happy.
What was the error you're getting? Which version of Go were you using? I don't think that should be the case.dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go4dI've updated the images and sent [CL 143458](https://golang.org/cl/143458).
Will redeploy `cmd/coordinator` later tonight (when it's quieter).
After a few days of no issues, the next step will …
I've updated the images and sent [CL 143458](https://golang.org/cl/143458).
Will redeploy `cmd/coordinator` later tonight (when it's quieter).
After a few days of no issues, the next step will …dmitshur commented on Remove the "always receives X" chec… in github.com/mvdan/unparam4d> Does anyone find it useful?
I don't remember the last time I've seen it. I might've fixed all instances and not introduced new ones.
As a result, it's hard for me to say, but it sounds useful…
> Does anyone find it useful?
I don't remember the last time I've seen it. I might've fixed all instances and not introduced new ones.
As a result, it's hard for me to say, but it sounds useful…dmitshur commented on Vsync doesn't work on macOS 10.14 (… in github.com/glfw/glfw4dI can also confirm this, it's a regression in macOS 10.14 and wasn't a problem in 10.13.
This issue may be related to #1334 in some way. What I'm observing is that vsync works until you move or re…
I can also confirm this, it's a regression in macOS 10.14 and wasn't a problem in 10.13.
This issue may be related to #1334 in some way. What I'm observing is that vsync works until you move or re…dmitshur commented on OSX 10.14 (Mojave) Window does not … in github.com/glfw/glfw4dThanks for the report. This is a duplicate of #1334.
Thanks for the report. This is a duplicate of #1334.dmitshur commented on proposal: x/tools/go/generated: par… in github.com/golang/go5dI agree with your comment @rsc that this would be a small package, and it's better to avoid that in x/tools.
I've been thinking about where this functionality could fit into existing packages, and…
I agree with your comment @rsc that this would be a small package, and it's better to avoid that in x/tools.
I've been thinking about where this functionality could fit into existing packages, and…dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go5dI'll work on updating the images to 6.4 final.
The current 6.4 snapshots have been quite stable on https://build.golang.org/:
<img width=101 src="https://user-images.githubusercontent.com/19241…
I'll work on updating the images to 6.4 final.
The current 6.4 snapshots have been quite stable on https://build.golang.org/:
<img width=101 src="https://user-images.githubusercontent.com/19241…dmitshur commented on x/build: create mips32 soft-float b… in github.com/golang/go1w@bradfitz From [`x/build/dashboard/builders.go`](https://github.com/golang/build/blob/c27f283fefcd9cd436e591d4b932a1d94d469a27/dashboard/builders.go#L425-L474), it looks like all our current `mips` b…
@bradfitz From [`x/build/dashboard/builders.go`](https://github.com/golang/build/blob/c27f283fefcd9cd436e591d4b932a1d94d469a27/dashboard/builders.go#L425-L474), it looks like all our current `mips` b…dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go1wStarting to have second thoughts about the proposed workaround. In the [CL 142362](https://golang.org/cl/142362) commit message, I wrote:
> The goal of this change is to reduce occurrences of goph…
Starting to have second thoughts about the proposed workaround. In the [CL 142362](https://golang.org/cl/142362) commit message, I wrote:
> The goal of this change is to reduce occurrences of goph…dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go1wI tested the approach (locally) and it worked in solving the problem. Going to send a CL.
I tested the approach (locally) and it worked in solving the problem. Going to send a CL.dmitshur commented on x/build/cmd/gopherbot: testing figh… in github.com/golang/go1wTesting successful (done locally, so not visible here). Closing.
Testing successful (done locally, so not visible here). Closing.