Today
dmitshur merged a change doc/go1.13: add missing slashes1h
dmitshur opened a change github.com/andygrunwald/go-gerrit: add ReviewerUpdates field to ChangeInfo2h
Also add ReviewerUpdateInfo struct. References: - https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-info - https://gerrit-review.googlesource.com/Documentation/…
dmitshur created branch in github.com/andygrunwald/go-gerrit2h
add-ReviewerUpdates
dmitshur reviewed +2 on doc/go1.13: add missing slashes3h
(1 comment) Thank you Toshihiro! Can you please add a short sentence to the commit message body justifying this change? For example: This saves a redirect and makes the document more consisten…
dmitshur pushed to master in github.com/shurcooL/home4h
3b3cbfcc2ad2edc64abe7de14dd7207c63e9aba0_data/resume: add style for location class
dmitshur pushed to master in github.com/shurcooL/resume4h
dc47c8f77a8061791fe407ec399a6ff5b54c7cd6add company and university locations
dmitshur commented on doc/go1.13: add missing slashes12h
The changes in this CL got implemented as part of CL 191797. You can either close this, or rebase and implement the 10 suggestions from my previous review.
dmitshur commented on doc/go1.13: fix bad URLs in strconv identifiers13h
(1 comment) s/in/to/ It was URLs _to_ strconv identifiers that were bad, at least that's what I had in mind.
dmitshur reviewed +2 on doc/go1.13: fix bad URLs13h
(2 comments) Thanks for the quick fix. It'll help to have a more specific subject when it comes to cherry picking and looking at git log, etc. doc/go1.13: fix bad URLs to strconv identifiers …
dmitshur commented on doc/go1.13: document _ between digits for math/big, strconv13h
(1 comment) No problem, thanks for following up.
Yesterday
dmitshur commented on doc/go1.13: document _ between digits for math/big, strconv14h
(1 comment) s|/pkg/math/big/#strconv.|/pkg/strconv/|g (3 places in total)
dmitshur reviewed +2 on doc/go1.13: add missing slashes14h
(10 comments) The URLs without slash will redirect, but it doesn't hurt to have more consistency and save a redirect. There are 10 more places where a slash is missing if you'd like to fix them too…
dmitshur merged a change golang.org/x/tools/godoc: apply gofmt14h
dmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)18h
Commit [5275a64a](https://dmitri.shuralyov.com/website/gido$commit/5275a64acd14885a8d67315e2b66570347b757af) has made this better. Directories are now determined by walking Go repositories at process…
dmitshur commented on cmd/go: add GOCMD environment variable20h
> Then I have another question: can we get a warning or an error when we violate this rule? I don't think it's possible to implement such a warning or error without false positives, at least not i…
dmitshur opened an issue github.com/bradfitz/go-smtpd/smtpd: ability to stop the server21h
This is a feature request. I want to find out if it's in scope for this package. It'd be nice to be able to stop the `smtpd.Server`, similar to [`http.Server.Close`](https://godoc.org/net/http#Ser…
dmitshur opened an issue github.com/sourcegraph/go-vcs/vcs/git: build failure due to import path change in a dependency22h
The latest version of the [`sourcegraph.com/sourcegraph/go-vcs/vcs/git`](https://godoc.org/sourcegraph.com/sourcegraph/go-vcs/vcs/git) package fails to build: ``` $ go version go version go1.12.…
dmitshur commented on github.com/shurcooL/vfsgen: Seeking doesn't work reliably with compressed files.22h
Thanks for reporting this. That sounds like a bug, seeking should be fully supported. I'd really like to fix it. Would it be possible for you to share some code that can reproduce the issue?
dmitshur commented on cmd/go: add GOCMD environment variable1d
@hajimehoshi When using a wrapper command around `go` that has a different name, it's that wrapper command's responsibility to update `PATH` variable before invoking the real `go` command such that p…
Last Week
dmitshur commented on cmd/pprof: index out of bounds crash1d
@gopherbot, please backport to 1.13.
dmitshur commented on cmd/vendor: update vendored x/arch repo to 8a70ba74b3a11d
(1 comment) > the change to add rsc.io/pdf to go.sum in this CL? What's up with that? It seems expected to me. The newer version of golang.org/x/module has had a go.mod file added (in CL 167137). …
dmitshur commented on cmd/go: document <module>/@latest endpoint in 'go help goproxy'1d
(3 comments) Thank you for the explanation. This change was a part of CL 190839. Rebasing this CL on top of latest master should fix this. The current parent is older. Same here; rebasing and rege…
dmitshur commented on cmd/pprof: index out of bounds crash1d
As a reminder, if we want this fix to become a part of the final Go 1.13 release, we'll also need to backport it from `master to `release-branch.go1.13` branch.
dmitshur reviewed +1 on cmd/vendor: update vendored x/arch repo to 8a70ba74b3a11d
(1 comment) I think using -d is reasonable, but I'll let Bryan or Jay confirm. (For reference, the removal of -m is documented at https://tip.golang.org/doc/go1.13#go-get.) If it looks good to one …
dmitshur commented on golang.org/x/website: website godoc to golangorg help text fix2d
(3 comments) The commit message of this CL needs to be formatted per rules described at https://golang.org/wiki/CommitMessage. Namely, it should begin with "cmd/golangorg: " since it affects that p…
dmitshur commented on access: deklerk@ approvers + may-start-trybots2d
Hi Jean, Thank you for contributing to the Go project and helping out so much in the world of modules! I've discussed this request with the team (/cc @golang/osp-team), and we agreed to grant you ac…
dmitshur commented on cmd/go: document <module>/@latest endpoint in 'go help goproxy'2d
(1 comment) I've seen that in the proxyRepo implementation of the modfetch.Repo interface, the Latest method does GET /@latest first, and if it gets a not exist error, it then tries to get latest ve…
dmitshur commented on github.com/GoogleCloudPlatform/golang-samples/getting-started/bookshelf: initial rewrite2d
The parameter `ctx` is unused, so it'd be slightly better to leave it out, as you have already done in the `firestoreDB.Close` method.
dmitshur commented on github.com/GoogleCloudPlatform/golang-samples/getting-started/bookshelf: initial rewrite2d
This is completely okay as is, but consider moving it to a _test.go file since it's not a piece of code that is needed for functionality of the app. Doing so causes a failure for `*firestoreDB` to…
dmitshur commented on github.com/GoogleCloudPlatform/golang-samples/getting-started/bookshelf: initial rewrite2d
Perhaps consider switching to another version that isn't incompatible. For example, `github.com/gofrs/uuid/v3 v3.1.2` or `github.com/google/uuid v1.1.1`.
dmitshur commented on cmd/go: document <module>/@latest endpoint in 'go help goproxy'2d
(2 comments) s/go1.12/Go 1.12/ For three reasons: - this is prose for humans, and we tend to prefer "Go 1.12" in such contexts, instead of using the tag name - the phrase "go1.12" may give a stron…
dmitshur commented on golang.org/x/build/cmd/releasebot: use releasebot work dir for staging releases3d
(2 comments) I considered it but didn't think it was worth it. However, I've made a change to avoid reusing staging directories across multiple releasebot invocations (because it's dangerous, we do…
dmitshur commented on golang.org/x/mobile: Try bots experiments3d
(1 comment) For reference, we support two phrases that have special meaning: DO NOT SUBMIT and DO NOT REVIEW. They're documented at https://groups.google.com/d/msg/golang-dev/YU56eKYiXJg/K1CkXo7Iy0g…
dmitshur commented on golang.org/x/exp/shiny/driver/mtldriver: add start of a Metal API-based driver3d
> I'll get to this at some point, but I'm pretty busy with other work right now. Thanks for your understanding... Understood, no problem, thank you!
dmitshur closed an issue all: Go 1.13rc1 release status3d
dmitshur commented on all: Go 1.13rc1 release status3d
The announcement is [here](https://groups.google.com/d/msg/golang-announce/WJwdF-j-UJI/_bARSsExAAAJ) and the tweet is [here](https://twitter.com/golang/status/1164276194524762113). This release is…
dmitshur commented on encoding/json: slice out of bounds decoder crash found via fuzzing4d
I'll copy @FiloSottile's comment from https://go-review.googlesource.com/c/go/+/190909/1#message-40010dc222e17a86edce656aa3c589f8c5adb95a here: > I don't have a strong opinion on whether to rollba…
dmitshur starred in github.com/google/trillian4d
dmitshur commented on github.com/shurcooL/githubv4: Query batching and/or dynamic queries.5d
@cheshire137 Yes, that should work if you use the suggestion @paultyng posted above. Please feel free to let me know if there's more to it.
dmitshur commented on golang.org/x/build/cmd/gitmirror: deleted branches/tags are being mirrored to GitHub5d
I've investigated this further, it seems the theory above was accurate. [CL 190879](https://golang.org/cl/190879) is deployed and makes it so that refs deleted from origin repositories are no long…
dmitshur deleted branch in github.com/golang/scratch5d
dmitshur-test2
dmitshur deleted branch in github.com/golang/scratch5d
dmitshur-test1
dmitshur commented on golang.org/x/build/cmd/gitmirror: deleted branches/tags are being mirrored to GitHub5d
While it may have looked like something changed causing this issue to not be a problem anymore, that is not the case. I've recently created and later deleted a branch named `dmitshur-test1` in the…
dmitshur deleted branch in github.com/golang/scratch5d
dmitshur-test1
dmitshur commented on c85582a6916c1f75a6e0707a5a469e6f86783999honnef.co/go/tools/cmd/go-module-query: prototype utility for analysing Go modules6d
FYI, you're escaping the module path but not the module version. The module version also needs to be escaped (although it makes a difference much less frequently). See [`module.EscapeVersion`](https:…
dmitshur commented on github.com/dbmedialab/go-graphql-client/transport: use golang.org/x/net/context/ctxhttp package.6d
It seems this project isn't active and so this PR isn't helpful. I'll close it after another month or so.
dmitshur commented on github.com/client9/misspell: Fix own misspellings6d
Friendly heartbeat; this PR is still active from my side and I'm ready and willing to make any changes based on code review. Thank you!
dmitshur commented on github.com/ejcx/passgo: start building in module mode6d
Friendly ping. 🙂
Earlier
dmitshur pushed to master in github.com/shurcooL/home1w
0fc55ef272168267b2d98801645e24f834925733internal/page/blog: shorten blog posts on front page
dmitshur opened an issue github.com/shurcooL/home/internal/page/blog: shorten very long posts1w
Right now, the blog at https://dmitri.shuralyov.com/blog shows all blog posts one after another on one page. Some posts are small, some are very long. It makes it hard to skim the blog and tell where…
dmitshur commented on github.com/gopherjs/vecty: RenderBody became blocking (it never returns) after PR #2321w
Thank you very much for such a thoughtful and detailed answer @slimsag! I don't mind making changes in my codebase to update to a new/different API, but I couldn't do that without first understandin…
dmitshur commented on cloud.google.com/go: set up gopherbot1w
I don't have a lot of context for this issue so I might not be understanding it correctly. I'll provide some background first. "gopherbot" consists of these things: - the @gopherbot GitHub account…
dmitshur starred in github.com/docker-library/golang1w
dmitshur commented on cmd/go/internal/modfetch: re-evaluate the undocumented proxy behavior in proxyRepo.latest()1w
> 2. whether to include pseudo-versions or not in /@v/list Just as an observation, the last paragraph at https://golang.org/cmd/go/#hdr-Module_proxy_protocol says: > Even when downloading direc…
dmitshur commented on os.RemoveAll: openFdAt function without O_CLOEXEC and cause fd escape to child process [1.12 backport]1w
For security releases, we can't include the details of the security fixes in the pre-announcement until the security release is available. For all other releases, you can look at the upcoming milesto…
dmitshur closed an issue all: Go 1.12.9 release status1w
dmitshur commented on all: Go 1.12.9 release status1w
Announcement: https://groups.google.com/d/msg/golang-announce/oeMaeUnkvVE/a49yvTLqAAAJ Tweet: https://twitter.com/golang/status/1162112434355748864 This release is done, closing. 🎉
dmitshur commented on all: Go 1.12.9 release status1w
## Latest build: go1\.12\.9 src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.12.9/go1.12.9.src.tar.gz)) linux\-386 ([tar\.gz](https://golang-release-staging.storage.googleap…
dmitshur commented on all: Go 1.12.9 release status1w
## Log 2019/08/15 14:09:32 starting 2019/08/15 14:09:32 working in /Users/dmitshur/go-releasebot-work/go1.12.9 2019/08/15 14:09:32 $ git clone https://go.googlesource.com/go /Users/dmit…
dmitshur opened an issue all: Go 1.12.9 release status1w
Issue tracking the go1.12.9 release by releasebot.
dmitshur commented on os.RemoveAll: openFdAt function without O_CLOEXEC and cause fd escape to child process [1.12 backport]1w
The Go 1.12.9 point release is coming out very soon after the security release. It's planned to be released today.
dmitshur commented on os.RemoveAll: openFdAt function without O_CLOEXEC and cause fd escape to child process [1.12 backport]1w
@oiooj It's because Go 1.12.8 was a security release, so its contents are just Go 1.12.7 with the security fixes applied. The next point release, Go 1.12.9, will include both the security fixes from …
dmitshur commented on math/big: arm64 assembly code for shlVU is incorrect [1.12 backport]1w
This backport has been approved and merged to the release branch; updating label to CherryPickApproved to reflect that. The rationale was that this was a serious problem affecting arm64 with no worka…
dmitshur commented on os.RemoveAll: openFdAt function without O_CLOEXEC and cause fd escape to child process [1.12 backport]1w
This backport has been approved and merged to the release branch; updating label to CherryPickApproved to reflect that. The rationale was that this was a serious problem with no workaround.
dmitshur commented on cmd/link: missing section for relocation target [1.12 backport]1w
This backport has been approved and merged to the release branch; updating label to CherryPickApproved to reflect that. The rationale was that this was a serious problem with no workaround.
dmitshur commented on testing: test with child process sometimes hangs on 1.10; -timeout not respected [1.11 backport]1w
This backport was approved, but there was no fix available, so it wasn't actually submitted. Since it's closed now, I'll move the state back to CherryPickCandidate to reflect that better.
dmitshur commented on cmd/link: stack depth check too shallow [1.11 backport]1w
This backport has been accepted and merged to the release branch, so I'll update the label from CherryPickCandidate to CherryPickApproved to reflect that. It was a serious problem and the fix was …
dmitshur commented on cmd/link: stack depth check too shallow [1.12 backport]1w
Not a problem and thank you!
dmitshur commented on github.com/golang/gddo: Don't truncate package docs1w
The current document size limit is 800'000 bytes: https://github.com/golang/gddo/blob/af0f2af80721261f4d211b2c9563f7b46b2aab06/database/database.go#L263-L264 The `compute/v0.beta` package docum…
dmitshur commented on github.com/golang/gddo: https://godoc.org/golang.org/x/sys/unix/aliases.go returns 500 Internal server error.1w
The problem is here: https://github.com/golang/gddo/blob/af0f2af80721261f4d211b2c9563f7b46b2aab06/gosrc/vcs.go#L294-L304 We're opening a directory and trying to read its contents, but not handl…
dmitshur commented on github.com/golang/gddo: New Design for godocs1w
This is happening as part of https://github.com/golang/go/issues/33654. /cc @julieqiu
dmitshur commented on cmd/link: stack depth check too shallow [1.12 backport]1w
This backport has been accepted and merged to the release branch, so I'll update the label from CherryPickCandidate to CherryPickAccepted to reflect that. The rationale was that this was a serious pr…
dmitshur commented on math/big: arm64 assembly code for shlVU is incorrect [1.12 backport]1w
@erifan This is expected. Go 1.12.8 was a security release, so its contents are just Go 1.12.7 with the security fixes applied. The next point release, Go 1.12.9, will include both the security fixes…
dmitshur commented on github.com/gopherjs/vecty: RenderBody became blocking (it never returns) after PR #2321w
I understand it's likely related to WebAssembly, but it doesn't tell me if this was intentional or not. The user program can arrange for the `main` function not to return, vecty doesn't necessarily h…
dmitshur opened an issue golang.org/x/tools/cmd/godoc: add module support1w
This is the tracking issue specifically for the [`golang.org/x/tools/cmd/godoc`](https://godoc.org/golang.org/x/tools/cmd/godoc) command to have support for displaying package documentation in module…
dmitshur commented on net/url: URL.Parse Multiple Parsing Issues [1.12 backport]1w
Fixed by 3226f2d492963d361af9dfc6714ef141ba606713.
dmitshur commented on net/url: URL.Parse Multiple Parsing Issues [1.11 backport]1w
Fixed by c1d9ca70995dc232a2145e3214f94e03409f6fcc.
dmitshur commented on net/url: URL.Parse Multiple Parsing Issues1w
@gopherbot Please backport this to 1.12 and 1.11. This was a security problem.
dmitshur commented on net/http: Denial of Service vulnerabilities in the HTTP/2 implementation [1.11 backport]1w
Fixed by e152b01a468a1c18a290bf9aec52ccea7693c7f2.
dmitshur commented on net/http: Denial of Service vulnerabilities in the HTTP/2 implementation [1.12 backport]1w
Fixed by 7139b45d1410ded14e1e131151fd8dfc435ede6c.
dmitshur commented on net/http: Denial of Service vulnerabilities in the HTTP/2 implementation1w
@gopherbot Please backport this to 1.12 and 1.11. This was a security problem.
dmitshur commented on os: os.OpenFile() ignores FileMode when truncating a existing file1w
Thank you for confirming this is not a recent regression, that's very helpful. This issue is under the 1.14 milestone, so we can investigate it during the upcoming development cycle.