Activity
Yesterday
dmitshur starred github.com/bobg/mingo21h
Last Week
dmitshur commented on cmd/compile: forward small Load through Move to avoid redundant copies1d
@khr@golang.org Did you mean to start current trybots (i.e., Commit-Queue+1)? There weren't any specific legacy slowbots requested, and so the trybot set is empty. Stopped it.dmitshur commented on cmd/go: change `go mod init` default go directive back to 1.N [1.26 backport]1d
Added a release-blocker label to indicate the release shouldn't happen while this issue is still open.dmitshur commented on golang.org/x/build/...: migrate to 'gcloud storage' from gsutil1d
Agreed. Since this is a refactor and can probably wait a bit, putting it on hold until a better time to land it and follow up as needed. Thanks.dmitshur commented on golang.org/x/build/cmd/genbotcert: add detail to hostname mismatch error1d
Thanks.
It wasn't about alphabetical order; my intent was to leave the parameters in what seemed like a descending order, placing the core parameter towards the front, secondary parameter later. Tha…dmitshur reviewed +2 on golang.org/x/build/cmd/gitmirror: remove reference to obsolete "apt-key"2d
Thanks.dmitshur reviewed +2 on cmd/go: revert update default go directive in mod or work init2d
Thanks.
https://go.dev/wiki/CommitMessage#reverts suggests including the Gerrit CL number being rolled back in the commit message, so maybe add a mention of CL 720480 here.dmitshur commented on cmd/compile: internal compiler error: panic during rewrite tern with GOEXPERIMENT=simd [1.26 backport]2d
@dr2chase This backport issue is still open but without CherryPickApproved nor CherryPickCandidate label. Should this go back to approved but with [CL 749241](https://go.dev/cl/749241) as the new CL …dmitshur commented on cmd/fix: stringscut rewrite changes behavior [1.26 backport]2d
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77737#event-23078589596 to this issue. (CC @dr2chase.)dmitshur commented on cmd/fix: stringscut rewrite changes behavior2d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77737#event-23012415692).dmitshur commented on cmd/fix: stringscut rewrite changes behavior2d
This issue was marked as fixed by [CL 747900](https://go.dev/cl/747900), but that CL is in the main branch of x/tools. That's sufficient to fix the problem in time for Go 1.27, but this issue is curr…dmitshur reviewed +2 on go.dev/wiki/MinimumRequirements: drop requirements for unsupported Go versions2d
Thanks.
Maybe related that macOS 10.14 came out in Sept 2018, in between Go 1.11 (Aug 2018) and Go 1.12 (Feb 2019) releases. So they both probably worked, perhaps even older Go versions too given ma…dmitshur reviewed +2 on golang.org/x/build/cmd/gitmirror: remove reference to obsolete "apt-key"2d
Thanks. Some minor (optional) suggestions.
Splitting this long line to one-line-per-command for readability seems good, but maybe it's worth keeping the one-command-pipe-into-another together? I don…dmitshur reviewed +2 on golang.org/x/build/doc/deployment.md: include auth step in deployment process2d
In the past we may have previously relied on the CheckUserCredentials check to suggest this step if it wasn't already done (see [here](https://cs.opensource.google/go/x/build/+/master:buildenv/envs.g…dmitshur closed an issue cmd/compile: internal compiler error: 'main.func1': not lowered: v15, Load STRUCT PTR SSA [1.25 backport]3d
dmitshur commented on cmd/fix: stringsbuilder ignores variables if they are used multiple times [1.26 backport]3d
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77659#event-23078585370 to this issue.dmitshur commented on cmd/fix: stringsbuilder ignores variables if they are used multiple times3d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77659#event-23004957221).dmitshur commented on cmd/fix: waitgroup leads to a compilation error3d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77754#event-23010399320).dmitshur commented on cmd/fix: minmax breaks select statements3d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77671#event-23007156867).dmitshur commented on cmd/fix: reflect.TypeOf(nil) transformed into reflect.TypeFor[untyped nil]()3d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77636#event-23009845781).dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes [1.26 backport]3d
We reviewed and approved this during a release meeting, moved CherryPickApproved from https://github.com/golang/go/issues/77482#event-23078592981 to this issue.dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes3d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77482#event-23054151261).dmitshur commented on cmd/fix: change -diff to exit 1 if diffs exist3d
@gopherbot Please create a backport issue for Go 1.26 (original request was in https://github.com/golang/go/issues/77583#event-22768894147).dmitshur fixed an issue golang.org/x/build: bot linux-s390x-ibm--02 reported as broken4d
dmitshur commented on cmd/fix: rangeint uses target platform's type in the range expression, breaking other platforms4d
This is the main issue, so the CherryPickCandidate label doesn't apply here. There was already #77766 opened to track the Go 1.26.x backport.dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder5d
Thanks. Here's the new corresponding certificate: [linux-mipsle-hooc-ag-1771954236.cert.txt](https://github.com/user-attachments/files/25526903/linux-mipsle-hooc-ag-1771954236.cert.txt).Earlier
dmitshur commented on runtime: regression segfault on linux 3.4 on mipsle1w
CC @golang/mips.dmitshur commented on gerrit: approver no longer grant AutoSubmit privileges1w
Submitting CLs on release-branches is limited to release managers. See https://go.dev/wiki/MinorReleases:
> The code review process is otherwise the same as regular CLs. Permission to submit to the …dmitshur commented on cmd/go: stdversion check should be on by default for `go test`1w
> I also wonder why this check wasn't added to go test once it was introduced; it seems like a simple (and presumably fast) check that should have zero false negatives.
I noticed that the accepted p…dmitshur closed an issue golang.org/x/build/cmd/gopherbot: don't mark issues as fixed if the “fix” verb is part of a larger sentence1w
dmitshur opened an issue golang.org/x/build/maintner: improve issue reference detection to report preceding verb (e.g., "Fixes", "For")1w
(Factored out a maintner improvement opportunity from the gopherbot-specific issue #29599.)
It'd be good if maintner's detection and reporting of issue references was improved. There is an existing …dmitshur commented on os: Go 1.25.x regression on RemoveAll for windows [1.25 backport]1w
Added release-blocker here since the go1.26.1 backport is done, so this isn't accidentally missed from go1.25.8.dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder1w
> To avoid any inconsistencies, I will generate a new private key and CSR for linux-mipsle-hooc-ag and request a fresh certificate.
Sounds good. I've revoked the previous certificate and can generat…dmitshur pushed to
main in dmitri.shuralyov.com/service/change9modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur opened an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y
dmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Commit [5275a64a](https://dmitri.shuralyov.com/website/gido$commit/5275a64acd14885a8d67315e2b66570347b757af) has made this better. Directories are now determined by walking Go repositories at process…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6y