Activity
Today
dmitshur commented on encoding/json: [release-branch.go1.27] fix Indent with a non-space prefix or indent21m
linux-386-longtest failure is unrelated and being fixed by CL 856161. Bypassing.dmitshur commented on encoding/json: [release-branch.go1.27] fix UnsupportedValueError.Value for cycles22m
linux-386-longtest failure is unrelated and being fixed by CL 856161. Bypassing.dmitshur reviewed +2 on golang.org/x/build/cmd/makemac: switch darwin-arm64-14 to 8-core VMs40m
Thanks. Seems good to try.
Please associate this change with some tracking issue, either an existing one or a new one.
If V1_MEDIUM_VM is the the default, what was the motivation to explicitly set …dmitshur reviewed +2 on golang.org/x/build/main.star: add js-wasm-stackswitch builder1h
Thanks.dmitshur fixed an issue cmd/compile: staticcheck still crashes with generic methods on Go 1.27.22h
It doesn't seem like there's anything left to do for Go 1.28 (this issue's milestone), so closing.
Issue #82106 tracked backporting the fix to Go 1.27.4, which was [released](https://go.dev/doc/deve…dmitshur commented on cmd/internal/fuzztest: [release-branch.go1.26] limit GOMAXPROCS for 386 subtests2h
testcarchive.TestPreemption failures are unrelated and preexisting. Bypassing.dmitshur reviewed +2 on golang.org/x/website/_content/blog/goroutine-leak-profiles: fix example; update SVG bg2h
Thanks.dmitshur commented on golang.org/x/build/repos: disable protobuf mirroring to GitHub3h
Sounds good, I'll get this change submitted and deployed today.
Thanks.
@shaod@google.com Just checking, have you thought about what to do with the protobuf repo on Gerrit? Do you plan to mark it a…dmitshur commented on cmd/go: validate split -Wl, next-arg flags and linker script targets3h
gotip-linux-arm64-boringcrypto failures look to be due hitting 1 minute timeouts, doesn't seem related to this change, and the same builder passed on another try in https://ci.chromium.org/b/86654932…dmitshur commented on spec: type inferred composite literals4h
This still needs a release note, right? Not seeing it at https://tip.golang.org/doc/go1.28. Filed a separate release-blocking issue #82973 for that.dmitshur opened an issue doc: add a release note for "type inferred composite literals"4h
This is notable enough to need a release note. Factored out of #12854 for tracking, since this needs to block RC 1.
CC @griesemer, @mrkfrmn.Yesterday
dmitshur opened a change golang.org/x/website/cmd/adminapp: remove obsolete build constraint23h
Back when this constraint was added, the go directive in go.mod was
on 1.24.0, so '//go:build go1.25' was effectively raising the version
(and avoiding a build error that would happen with Go 1.24).
…dmitshur commented on golang.org/x/website/cmd/googlegolangorg: point google.golang.org/protobuf at GitHub1d
This change is live now. Before:
```
$ curl -s 'https://google.golang.org/protobuf?go-get=1' | grep go-import
<meta name="go-import" content="google.golang.org/protobuf git https://go.googlesourc…dmitshur commented on golang.org/x/crypto/ssh/agent: use a short socket path for ssh-agent in tests1d
Thanks for looking into those failures.
That error sounds like a problem on Gerrit's end, I would suggest to keep trying with some backoff and see if it gets better.dmitshur reviewed +2 on golang.org/x/crypto/ssh/agent: use a short socket path for ssh-agent in tests1d
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/googlegolangorg: point google.golang.org/protobuf at GitHub1d
Thanks.dmitshur commented on golang.org/x/pkgsite-metrics/cmd: update to go1.27.31d
The issue being referenced is likely #72774.
Just noting that 'golang:1.27' already referred to Go 1.27.3, based on https://hub.docker.com/_/golang#shared-tags and comparing image digests [here](htt…dmitshur reviewed +2 on golang.org/x/build/main.star: increase number of concurrent perf builders to 101d
Thanks.dmitshur commented on golang.org/x/crypto/ssh/agent: TestAgentExtensions, TestSetupForwardAgent, TestLockOpenSSHAgent failures with "too long for Unix domain socket" [consistent failure]1d
CC @drakkan, @golang/darwin.
Also added Soon label since this consistent failure is on a first-class port, and so it blocks monthly golang.org/x tagging. (CC @prattmic.)dmitshur closed an issue golang.org/x/crypto/ssh/agent: TestLockOpenSSHAgent failures [consistent failure]1d
Merged into #82712.dmitshur commented on golang.org/x/crypto/ssh/agent: TestLockOpenSSHAgent failures [consistent failure]1d
Merged into #82712.dmitshur closed an issue golang.org/x/crypto/ssh/agent: TestSetupForwardAgent failures [consistent failure]1d
Merged into #82712.dmitshur commented on golang.org/x/crypto/ssh/agent: TestSetupForwardAgent failures [consistent failure]1d
Merged into #82712.dmitshur commented on crypto/x509: reject trailing data after SEC 1 EC private keys1d
(1 comment)
I'm used to most Go code checking the error return value before other fields, so I'd expect checking len(rest) before err would be done if there was a good reason to (ideally with a comm…dmitshur reviewed +2 on golang.org/x/build/main.star: remove docker builders1d
Thanks.
Maybe update the mentions here too:
```suggestion
PKGSITE_SCREENTEST_NOTIFIER = luci.notifier(
name = "pkgsite-screentest-ci",
on_new_status = ["FAILURE"],
notify_emails = PKGSI…Last Week
dmitshur starred github.com/jarmitage99/OpenDE4d
Earlier
dmitshur fixed an issue net/http: backport fix to protect against middleware changing server response body [1.26 backport]1w
Closed by merging [CL 843365](https://go.dev/cl/843365) (commit bdd49b5785c73bec7341905e101e7ff92dd4752c) and [CL 843566](https://go.dev/cl/843566) (commit 1216ba432cef4ef3c0e11e65c6ecb95c158f70ed) t…dmitshur commented on cmd/compile: ICE on 386 when inlining nested bit rotations (Int64Lo not lowered) [1.26 backport]1w
The 1.27 counterpart (issue #81706) is in, any reason not to include this in the same month's 1.26 release as well? See https://github.com/golang/go/issues/34536#issuecomment-572188389.dmitshur commented on golang.org/x/build: recent Linux kernel builder2w
https://crrev.com/i/8198148 landed some time ago, and as far as I can tell it seemed to work okay? At least I didn't see too many false positive signals from it, but not sure how many true positives …dmitshur commented on cmd/compile: staticcheck still crashes with generic methods on Go 1.27.2 [1.27 backport]2w
Tentatively added release-blocker given the discussion in #82105 about wanting this fix to be made available sooner, and this seems close ([CL 847627](https://go.dev/cl/847627) was submitted on Oct 1…dmitshur commented on golang.org/x/net/html: quadratic complexity when coalescing text nodes2w
> I will re-assign this to the Go1.28 milestone.
@thatnealpatel This package isn't vendored in the main Go repo, and there doesn't seem to be anything tied to the Go 1.28 release here. Okay to move …dmitshur closed an issue encoding/json/v2: possibly clarify retention prohibitions in documentation [1.26 backport]2w
dmitshur opened an issue golang.org/x/build: try out CL submission via queue in golang.org/x/build Gerrit repo2w
We're building a prototype of CL submission via queue, initially limited in scope to cover the golang.org/x/build repository, and this is a tracking issue for that. See issue #12482 for motivation an…dmitshur commented on golang.org/x/build: upgrade freebsd builders to 14.5 and 15.12w
CC @golang/freebsd, @golang/release.dmitshur commented on golang.org/x/build: add OpenBSD 8.0 builder2w
CC @golang/openbsd, @golang/release.dmitshur fixed an issue golang.org/x/build/internal/installer/darwinpkg: unclear purpose and effect of "Fixing permissions" step during postinstall3w
The "Fixing permissions" step removal in Go 1.27 didn't seem to uncover anything unexpected, so closing this as done.
<details><summary>Confirmation of removal details</summary>
```shell
$ pkgutil …dmitshur commented on golang.org/x/build: add GOAMD64=v3 perf builders3w
There were GOAMD64=v3 perf builders added above, and they're running. It's also added to the perf dashboard.
@matloob Should this be closed as done or was there something specific still left to do h…dmitshur pushed to
master in github.com/mdempsky/unconvert3wdmitshur reviewed +2 on github.com/mdempsky/unconvert: 3w
Thanks.
Note that in the general case, it's not necessary to include the -u flag in the "go get" invocation in order to update dependencies. The -u flag means to update indirect dependencies (depend…dmitshur fixed an issue golang.org/x/build: linux-amd64-race is taking about 5 minutes too long for pre-submit purposes3w
dmitshur commented on golang.org/x/build: linux-amd64-race is taking about 5 minutes too long for pre-submit purposes3w
linux-amd64-race trybots are now consistently averaging 5-6 minute completion time (with around 7 minutes in the worst case) after @matloob's work in #82017. That's well within 15 minutes. Calling th…dmitshur commented on cmd/compile: ICE "Int64Val(uint64(9223372036854775808))" when ranging over an unsigned constant ≥ 2^63 in a clear loop (`for i := range uint64(1<<63) { s[i] = 0 }`)3w
CC @golang/compiler.dmitshur commented on dmitri.shuralyov.com/website/gido: Support proposals1mo
Proposals are already supported, in the sense they're listed as issues at https://goissues.org/ with a "Proposal" label.
See [prefixtitle.ParseIssue](https://pkg.go.dev/dmitri.shuralyov.com/go/prefi…dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time2y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability4y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change4ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes5y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim7y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit7y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl7ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl7ydmitshur pushed to
master in dmitri.shuralyov.com/service/change7ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase7ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit7ydmitshur pushed to
master in dmitri.shuralyov.com/state7ydmitshur pushed to
master in dmitri.shuralyov.com/scratch7ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes7ydmitshur pushed to
master in dmitri.shuralyov.com/route/github7ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt7ydmitshur pushed to
master in dmitri.shuralyov.com/route/github7ydmitshur pushed to
master in dmitri.shuralyov.com/service/change7ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority7y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority7y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…