Yesterday
dmitshur commented on x/build: stop testing dev.boringcry… in github.com/golang/go1d
Sounds like the decision is to use `windows/386`. I'll proceed with that for now, but happy to change it if there's further feedback.
Sounds like the decision is to use `windows/386`. I'll proceed with that for now, but happy to change it if there's further feedback.dmitshur commented on x/build: stop testing dev.boringcry… in github.com/golang/go1dTesting on at least one other builder in addition to `linux/amd64` itself sounds reasonable. Which one (or ones)?
Some possibilities:
- Just `windows/amd64`?
- All first class ports: `linux/{3…
Testing on at least one other builder in addition to `linux/amd64` itself sounds reasonable. Which one (or ones)?
Some possibilities:
- Just `windows/amd64`?
- All first class ports: `linux/{3…dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom1dI see, thanks for clarifying. Then let's keep this as is. If we discover evidence that there are reproducible cases where it's nil and needs to be handled, we can address it then.
I see, thanks for clarifying. Then let's keep this as is. If we discover evidence that there are reproducible cases where it's nil and needs to be handled, we can address it then.
This Week
dmitshur commented on Can shurcooL/go/ctxhttp dependency … in github.com/shurcooL/graphql1dIssue https://github.com/golang/go/issues/21358 has been resolved today, so I can finally resolve this issue! 🎉 /cc @gmlewis
Issue https://github.com/golang/go/issues/21358 has been resolved today, so I can finally resolve this issue! 🎉 /cc @gmlewisdmitshur commented on x/build/cmd/gopherbot: follow-up ba… in github.com/golang/go2dAlso happened in https://github.com/golang/go/issues/28688#issuecomment-438326787.
Also happened in https://github.com/golang/go/issues/28688#issuecomment-438326787.dmitshur commented on cmd/compile: inline multiplication … in github.com/golang/go2d@josharian You're hitting the known issue #25574. Gopherbot already responded to a backport command earlier in this issue, so until #25574 is resolved, it never listens to follow up backport requests.
@josharian You're hitting the known issue #25574. Gopherbot already responded to a backport command earlier in this issue, so until #25574 is resolved, it never listens to follow up backport requests.dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go2dFWIW, explicitly setting the maximum acceptable TLS version to 1.2 in that test makes it pass:
```
diff --git a/http2/server_test.go b/http2/server_test.go
index e5be1a6..3cd398f 100644
--- a/h…
FWIW, explicitly setting the maximum acceptable TLS version to 1.2 in that test makes it pass:
```
diff --git a/http2/server_test.go b/http2/server_test.go
index e5be1a6..3cd398f 100644
--- a/h…dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go2dBisected this test failure to [CL 147638](https://golang.org/cl/147638) (crypto/tls: enable TLS 1.3 and update tests), which makes a lot of sense. /cc @FiloSottile
Bisected this test failure to [CL 147638](https://golang.org/cl/147638) (crypto/tls: enable TLS 1.3 and update tests), which makes a lot of sense. /cc @FiloSottiledmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go2dWoohoo! CL incoming.
Woohoo! CL incoming.dmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go2d@bradfitz, we've been removing support for Go 1.6 and replacing `golang.org/x/net/context` with `context` in many packages recently (e.g., https://github.com/golang/net/commit/04ba8c85dd55b4ee6099abb…
@bradfitz, we've been removing support for Go 1.6 and replacing `golang.org/x/net/context` with `context` in many packages recently (e.g., https://github.com/golang/net/commit/04ba8c85dd55b4ee6099abb…dmitshur commented on x/build/maintner: GitHubIssue.Close… in github.com/golang/go3d> We have the issue events synced anyway, so the data's in the corpus. We just need to track the oldest close event per issue.
That's a great idea, then no need for extra queries. The close event ha…
> We have the issue events synced anyway, so the data's in the corpus. We just need to track the oldest close event per issue.
That's a great idea, then no need for extra queries. The close event ha…dmitshur commented on 
Refactored to use Graph… in github.com/davidoram/ght3dYou can omit the empty brackets if you want, e.g., just `graphql:"tag: node"`.
Refactored to use Graph… in github.com/davidoram/ght3dYou can omit the empty brackets if you want, e.g., just `graphql:"tag: node"`.dmitshur commented on Refactored to use Graph… in github.com/davidoram/ght3dIn case it's helpful, you can probably simplify this further. Instead of using `edges` and then accessing the `node` inside, you could access the list of nodes directly via `nodes`. See the second fi…
Refactored to use Graph… in github.com/davidoram/ght3dIn case it's helpful, you can probably simplify this further. Instead of using `edges` and then accessing the `node` inside, you could access the list of nodes directly via `nodes`. See the second fi…dmitshur commented on access: request for increased Githu… in github.com/gopherjs/gopherjs3dWe've added you. Thank you Paul!
We've added you. Thank you Paul!dmitshur commented on IsoGoApp: Does not find and load th… in github.com/gopherjs/gopherjs3d/cc @EngineerKamesh
/cc @EngineerKameshdmitshur commented on gopher build error in github.com/gopherjs/gopherjs3dIf you look at the [import graph](https://godoc.org/github.com/EngineerKamesh/igb/igweb/client?import-graph&hide=2) of that package, you'll see that it imports `go.isomorphicgo.org/go/isok`, which im…
If you look at the [import graph](https://godoc.org/github.com/EngineerKamesh/igb/igweb/client?import-graph&hide=2) of that package, you'll see that it imports `go.isomorphicgo.org/go/isok`, which im…dmitshur commented on Remove Cgo dependency on Windows in github.com/go-gl/glow3dAdd a `// TODO: Use syscall.Syscall18 when Go 1.12 is the minimum supported version.` perhaps?
Add a `// TODO: Use syscall.Syscall18 when Go 1.12 is the minimum supported version.` perhaps?dmitshur commented on remove dependency on cgo in github.com/go-gl/gl3dI think we did reach agreement. We talked on slack and I left some comments on the proposal document. As long as you're willing to help maintain the Windows cgo-free version, we're happy to accept it.
I think we did reach agreement. We talked on slack and I left some comments on the proposal document. As long as you're willing to help maintain the Windows cgo-free version, we're happy to accept it.dmitshur commented on How to encode GraphQL Aliases in github.com/shurcooL/githubv44d@davidoram Thanks for asking. Aliases are supported, but I haven't documented them yet (see #22). I hope to fix that soon.
The answer is as follows. A GraphQL query like this:
```GraphQL
query…
@davidoram Thanks for asking. Aliases are supported, but I haven't documented them yet (see #22). I hope to fix that soon.
The answer is as follows. A GraphQL query like this:
```GraphQL
query…dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom4dQuestion, do you know if `e.Get("content")` always returns a non-nil value?
Question, do you know if `e.Get("content")` always returns a non-nil value?dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom4dPlease use a keyed field in this composite literal, for consistency with other elements.
```suggestion
return &HTMLTemplateElement{BasicHTMLElement: el}
```
Please use a keyed field in this composite literal, for consistency with other elements.
```suggestion
return &HTMLTemplateElement{BasicHTMLElement: el}
```dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache4d> But as long as we're working on this one, I'd rather keep hunting until we find an approach that we both like. I'm ok with the nested-diff approach (whether it uses `-u` or `-n`), but I don't _like…
> But as long as we're working on this one, I'd rather keep hunting until we find an approach that we both like. I'm ok with the nested-diff approach (whether it uses `-u` or `-n`), but I don't _like…dmitshur commented on Query batching and/or dynamic queri… in github.com/shurcooL/githubv44dI've made significant progress on this issue this weekend. It turns out it has been _possible_ to perform query batching and/or dynamic queries all along, without any API changes to this package. Rea…
I've made significant progress on this issue this weekend. It turns out it has been _possible_ to perform query batching and/or dynamic queries all along, without any API changes to this package. Rea…dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache4d> Who cares what's on disk when the failed container gets torn down?
I don't mind what's on disk after the container is being shutdown. It's just that `gofmt -w` writes to disk first, and then the…
> Who cares what's on disk when the failed container gets torn down?
I don't mind what's on disk after the container is being shutdown. It's just that `gofmt -w` writes to disk first, and then the…Last Week
dmitshur commented on x/build/cmd/coordinator: some CLs e… in github.com/golang/go4dThanks for diagnosing the issue.
Thanks for diagnosing the issue.dmitshur commented on x/build/cmd/coordinator: some CLs e… in github.com/golang/go5dThe "Builds Remaining" number calculation is clearly wrong. I've noticed it's sometimes wrong even elsewhere, for trybots that succeed properly. E.g., from [this](https://go-review.googlesource.com/c…
The "Builds Remaining" number calculation is clearly wrong. I've noticed it's sometimes wrong even elsewhere, for trybots that succeed properly. E.g., from [this](https://go-review.googlesource.com/c…dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go5dDeployed coordinator. Trybots will now use OpenBSD 6.4 rather than 6.2. E.g.:
<img width=420px src=https://user-images.githubusercontent.com/1924134/48304759-fe05ae00-e4ec-11e8-8f67-e44da78a5254.p…
Deployed coordinator. Trybots will now use OpenBSD 6.4 rather than 6.2. E.g.:
<img width=420px src=https://user-images.githubusercontent.com/1924134/48304759-fe05ae00-e4ec-11e8-8f67-e44da78a5254.p…dmitshur commented on Usability thought: links can't be r… in github.com/marwan-at-work/marwanio5dI can confirm the fix works for me. Thanks!
I can confirm the fix works for me. Thanks!dmitshur commented on x/build/cmd/gerritbot: bot insists … in github.com/golang/go5dI think this is the same issue as #24887.
It's also related to https://github.com/golang/go/issues/25359#issuecomment-417217969, where I suggested:
> I'll want to revisit the original design do…
I think this is the same issue as #24887.
It's also related to https://github.com/golang/go/issues/25359#issuecomment-417217969, where I suggested:
> I'll want to revisit the original design do…dmitshur commented on x/build: make trybots post their st… in github.com/golang/go6d> If trybots cancel themselves due to a new patchset version or the current patchset being merged
Do trybots still do that? I heard from @heschik that he saw trybots continue to run and send messa…
> If trybots cancel themselves due to a new patchset version or the current patchset being merged
Do trybots still do that? I heard from @heschik that he saw trybots continue to run and send messa…dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go6dReopening for deploy (likely later tonight, when it's quieter, to avoid disruption to running builds).
Reopening for deploy (likely later tonight, when it's quieter, to avoid disruption to running builds).dmitshur commented on README: update Travis badge to go4o… in github.com/go4org/go46dThanks for merging!
I would suggest considering the squash merge strategy for small PRs like this, to keep the git history cleaner. It also allows you to improve the commit message before merging,…
Thanks for merging!
I would suggest considering the squash merge strategy for small PRs like this, to keep the git history cleaner. It also allows you to improve the commit message before merging,…dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go6dThe v2 image appears to be equally stable:
<img width=100px src=https://user-images.githubusercontent.com/1924134/48279994-460acf00-e420-11e8-93ef-a488b6f1302a.png>
The performance has improved…
The v2 image appears to be equally stable:
<img width=100px src=https://user-images.githubusercontent.com/1924134/48279994-460acf00-e420-11e8-93ef-a488b6f1302a.png>
The performance has improved…dmitshur commented on Add several error types in github.com/shurcooL/graphql6dThanks for the PR. I'm going to need some time to review this and think about it.
One challenge with making progress on this is that it locks in HTTP-specific types in this package, potentially ma…
Thanks for the PR. I'm going to need some time to review this and think about it.
One challenge with making progress on this is that it locks in HTTP-specific types in this package, potentially ma…dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache6dThanks for explaining, that makes sense.
I'd like to look a way to continue to rely on `gofmt -d` to display a gofmt diff, rather than `gofmt -w` followed by `git diff`, if possible. The motivatio…
Thanks for explaining, that makes sense.
I'd like to look a way to continue to rely on `gofmt -d` to display a gofmt diff, rather than `gofmt -w` followed by `git diff`, if possible. The motivatio…dmitshur commented on x/build/app: build dashboard for su… in github.com/golang/go1w@bradfitz Yes, that's the page Michael was referring to.
@bradfitz Yes, that's the page Michael was referring to.dmitshur commented on .travis.yml: Bump to Go 1.11, retur… in github.com/gregjones/httpcache1wWhat is the motivation for changing `diff -u <(echo -n) <(gofmt -d -s .)` to `gofmt -w -s . && git diff --exit-code`?
What is the motivation for changing `diff -u <(echo -n) <(gofmt -d -s .)` to `gofmt -w -s . && git diff --exit-code`?dmitshur commented on x/build: migrate to using Go modules in github.com/golang/go1wWell, given this is x/build and its policy (which I can't find for some reason right now), we can experiment with modules as long as they work for our needs. See https://go-review.googlesource.com/c/…
Well, given this is x/build and its policy (which I can't find for some reason right now), we can experiment with modules as long as they work for our needs. See https://go-review.googlesource.com/c/…dmitshur commented on Black screen and VSync problems on … in github.com/go-gl/glfw1w> Is this related to OpenGL deprecation? My understanding was that it would continue to be supported for some time.
OpenGL is deprecated in the latest macOS, but it's still supported. This is just…
> Is this related to OpenGL deprecation? My understanding was that it would continue to be supported for some time.
OpenGL is deprecated in the latest macOS, but it's still supported. This is just…dmitshur commented on module-aware building in github.com/gopherjs/gopherjs1w> I think leaving the project in this limbo state is unhealthy for both developers and users. Developers have no idea if they should send PRs or otherwise contribute to the project, and users are lef…
> I think leaving the project in this limbo state is unhealthy for both developers and users. Developers have no idea if they should send PRs or otherwise contribute to the project, and users are lef…dmitshur commented on x/tools/go/packages: TestJSON may b… in github.com/golang/go1wThis seems to be re-occurring but for Go 1.10 only, see #28609.
This seems to be re-occurring but for Go 1.10 only, see #28609.dmitshur commented on x/tools/internal/lsp: TestDiagnosti… in github.com/golang/go1wNo worries, thanks for taking care of it!
Now that #17626 is resolved, trybots should help catch this in advance next time.
No worries, thanks for taking care of it!
Now that #17626 is resolved, trybots should help catch this in advance next time.dmitshur pushed to 
README: adjust go get -u comment formatting
patch-2 in github.com/dmitshur/starlark-go1wREADME: adjust go get -u comment formattingdmitshur pushed to Merge branch 'master' into patch-2
README: use go get's -u flagREADME: fix Issues link, 2nd tryREADME: fix Issues linkREADME: link Travis CI badge to build status page (#8)
patch-2 in github.com/dmitshur/starlark-go1wMerge branch 'master' into patch-2README: use go get's -u flagREADME: fix Issues link, 2nd tryREADME: fix Issues linkREADME: link Travis CI badge to build status page (#8)dmitshur commented on README: simplify installation instr… in github.com/google/starlark-go1wThe change to add `-u` flag is great, and has my full support.
However, I want to clarify, `go get -u` still does the `go install` step even if `-u` flag is used, so `go install` is still redundan…
The change to add `-u` flag is great, and has my full support.
However, I want to clarify, `go get -u` still does the `go install` step even if `-u` flag is used, so `go install` is still redundan…dmitshur commented on 
Add documents in github.com/gopherjs/gopherwasm1wHave you considered using a simpler URL of just https://golang.org/pkg/syscall/js/? Doesn't it give the same results?
Add documents in github.com/gopherjs/gopherwasm1wHave you considered using a simpler URL of just https://golang.org/pkg/syscall/js/? Doesn't it give the same results?dmitshur commented on Is there a way to not pollute globa… in github.com/gopherjs/gopherjs1wHow much global namespace pollution is there? The generated JavaScript code is contained in a closure, and `this` is needed for [`js.Global`](https://godoc.org/github.com/gopherjs/gopherjs/js#Global)…
How much global namespace pollution is there? The generated JavaScript code is contained in a closure, and `this` is needed for [`js.Global`](https://godoc.org/github.com/gopherjs/gopherjs/js#Global)…dmitshur pushed to README: simplify installation instructions
patch-2 in github.com/dmitshur/starlark-go1wREADME: simplify installation instructionsdmitshur pushed to README: simplify installation instructions
patch-2 in github.com/dmitshur/starlark-go1wREADME: simplify installation instructionsdmitshur pushed to README: simplify installation instructions
patch-2 in github.com/dmitshur/starlark-go1wREADME: simplify installation instructionsdmitshur pushed to README: link Travis CI badge to build status page
patch-1 in github.com/dmitshur/starlark-go1wREADME: link Travis CI badge to build status page