Today
shurcooL pushed to master in dmitri.shuralyov.com/service/change27m
c74edf3a9b92e02fd7da1abcd5a3a7632fa3f353githubapi: Use larger page size for ListCommits call.
shurcooL commented on Add support for parsing WOFF2 fonts. in github.com/ConradIrwin/font12h
Friendly ping. Let me know if there's anything I can do to help make progress on this. If there are any concerns about the approach, just let me know.
shurcooL commented on x/tools/go/buildutil: TestContainin… in github.com/golang/go12h
I've sent [CL 94900](https://golang.org/cl/94900) that'll resolve this issue.
shurcooL commented on cmd/go: arbitrary command execution… in github.com/golang/go12h
I've sent [CL 94899](https://golang.org/cl/94899) for golang.org/x.
shurcooL pushed to master in github.com/shurcooL/home13h
fd36f401ae56dd669f30814137a169bb493ac07cinternal/code: Update kebabcase import path.
shurcooL pushed to master in dmitri.shuralyov.com/text/kebabcase13h
40e40b42552a9cb37d6e98f4ad31f63ae53ea43aUpdate import path in test package.
Yesterday
shurcooL commented on go/doc: link detection in ToHTML is… in github.com/golang/go14h
An update on what I said earlier. `]` is not one of the safe characters that can be included in a URL without encoding (according to https://www.ietf.org/rfc/rfc1738.txt). RFC 1738 says it must to be…
shurcooL commented on cmd/go: arbitrary command execution… in github.com/golang/go15h
> My inclination right now is to go with my CL (94603) for patch releases, including 1.10.1, but go with @Invizory 's CL (94656) for 1.11. That should give us plenty of time to find out whether full …
shurcooL commented on changes to allow the output of the … in github.com/kisielk/errcheck17h
Minor style nit. There should be a space after `//`. See https://dmitri.shuralyov.com/idiomatic-go#comments-for-humans-always-have-a-single-space-after-the-slashes.
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs18h
CI is now green! ✅ I've created PR #755 that will resolve this issue. I invite everyone to test and/or review it. Thanks!
shurcooL commented on path/filepath: go test fails when G… in github.com/golang/go18h
For what it's worth, I think it's fine if such an issue comes up occasionally because of no "read-only builder". If it comes up, it can be reported, and then fixed. If no one notices for some time, t…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs19h
490aeb592b56fd50c5d4766ea4133d53a332b3a4compiler/natives: Regenerate.
28e102cafab52fc8b6ccac116e06766a82f3026ecompiler/natives/src/reflect: Override Value.assignTo method, drop v.Kind() == Interface && v.IsNil().
5e5d2d2a995bbb99a0843ca37c6db7bbc102101dRevert "compiler/natives/src/reflect: Return true in IsNil for implicitly converted nil interface."
7729020c1f3122ecdd49acc30b26e603ec3d3d6eTarget Go 1.10 final.
0bd5ec1a0c9ec164dd2ad59b47d31e1794034cf3compiler/natives/src/encoding/gob: Skip TestTypeRace.
12f65e290eece74bee294bbe70eaca80c764a7eecompiler/natives/src/io: Skip TestMultiWriterSingleChainFlatten.
446447afae62be20519fa168eac7cfd97868ddf3compiler/natives/src/strings: Skip optional pointer manipulation.
4bff1ed141973ca59a263e04e376ef365ffb13c6doc: Document partially supported packages in more detail.
8fc1f3cabe719f570ed9a95ca3574aca26408855build: Exclude linux-specific crypto/rand tests.
7c7c56991f8dadbf12b1793d95c035390c4ac3f1tests: Triage test failures new to Go 1.10.
397649b8666f6ed0b7caa94d17d7beb69c49c872Target Go 1.10 RC 2.
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs20h
I'm actively investigating the `html/template` failure now. I think I've finally cracked it. This wasn't trivial to track down. I started with the following simplified test case from `html/templat…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs23h
shurcooL commented on Replaces sync import with nosync be… in github.com/gopherjs/gopherjs23h
Perfect, that's very helpful, thanks!
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs23h
2252e22ab1f55d18c6ea8fc05c0bcd1fa8c9cbd9compiler/natives: Regenerate.
aff7ec6c50475ce318f8f26293e70d7658db3ec4compiler/natives/src/encoding/gob: Skip TestTypeRace.
shurcooL commented on Replaces sync import with nosync be… in github.com/gopherjs/gopherjs1d
Thanks for reporting this and sending a PR. Do you have any suggestions for how I can verify that this is a problem, and that the PR fixes it? I want to confirm your findings. If I understand c…
shurcooL commented on Don't use 'nosync' for the standard… in github.com/gopherjs/gopherjs1d
I ran into this during work on Go 1.10 support as well, in package `encoding/gob`. It currently uses `nosync`, and a new test in 1.10 is failing. If it's made to use real `sync` package, then the tes…
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs1d
Working on the `encoding/gob` failure now. I've figured out why it's happening, just need to decide on a resolution now. Only 1 more thing left to investigate go after this.
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs1d
Fixing `io` turned out easy, `TestMultiWriterSingleChainFlatten` just needed to be skipped because it uses unsupported runtime features. Done in commit e11ce777d8cabfb640c9fd1ac44cc56a9bb12480.
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs1d
7268865099fe45cddf1828bbadb707e1f7a1b96dcompiler/natives: Regenerate.
e11ce777d8cabfb640c9fd1ac44cc56a9bb12480compiler/natives/src/io: Skip TestMultiWriterSingleChainFlatten.
e91feeac4ca0ac5c5a4a4308d673bdcd4160c069compiler/natives/src/strings: Skip optional pointer manipulation.
3ec97f3cacecf92b33c60da819d71d6d2c0bfadddoc: Document partially supported packages in more detail.
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs1d
072e78d62beb52a1fee84a947d677578a16b8558Revert "compiler/natives/src/reflect: Don't skip string internalization for types."
9d5176b3c1a295fefefe9538d8b4cab1cb83a367compiler/natives/src/reflect: Implement throw.
8b2ca4bdee5d89b5c3a669b2f0b2ab4a9130e9bacompiler/natives/src/strings: Simple Builder implementation for js architecture.
3e6aba56150158c65e956009038fd8e5a5acd72bcompiler/natives/src/testing: Override frameSkip to avoid runtime.Callers.
1fb1aaaca99f647eaf7ca2ce6b3bc1f8aab27ef8compiler/natives/src/reflect: Return true in IsNil for implicitly converted nil interface.
a85517404324586ae512aa3ad40041323d8246f6compiler/natives/src/reflect: Skip TestCallReturnsEmpty.
5fab10db8c5416011eefa4eb6b404bcf9285d28acompiler/natives/src/reflect: Don't skip string internalization for types.
c4db7b2ec4f61a91265715577fcbab8164f676f2WIP: Hacky fix for wrong method set order with unicode.
87f956b642b426f988b227c341aeb88d8b58764dcompiler/natives/src/reflect: Update method indexing for non-ASCII exported methods.
66c17b11e4b071348e97a636fa3d9d115651b41ccompiler/natives/src/reflect: Update mutability of non-exported embedded fields.
9c9c7cd9608a8df35937eb75dc2969d3850277d2compiler/natives/src/reflect: Allow Copy from string to []byte.
9d71b8d703a4bdc663dfbcad970958c4847781bacompiler/natives/src/internal/poll: Implement semaphores.
605cc217f5da6a359139fad18041c66764c2e32fcompiler/natives/src/syscall: Provide implementation of Exit.
d796bf55a339fd9ff3a939dbf354e9e097292649compiler/natives/src/reflect: Change makechan size parameter type from uint64 to int.
2556b29edd4c43456a30e7388821f823eceb7821compiler/natives/src/reflect: Remove pkgPath parameter from newName.
232d13255c33ee96cb41da28f480c888b4a47543compiler/natives/src/time: Update for internal code reorganization.
a57c0828a67c8575f53236bdb3f1b984c839b9b2compiler/natives/src/math: Remove Dim implementation.
622f536f57135bff38a582c85afe55f6cd0baec4compiler/natives/src/runtime: Add stubs for getcallerpc, findfunc, funcname.
fa8fb1b0e439b027e84c5af269725890b8cebadcTarget Go 1.10 Beta 1, update version to GopherJS 1.10-wip.
3926a9f66452f7a8c8d9c0e4e3074383f9aff5cdinternal/sysutil: Fix build error on FreeBSD due to Rlimit.Cur type mismatch. (#752)
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs1d
I've figured out the `strings` `TestBuilder` failure. It's because of some `unsafe.Pointer` manipulation added in rc2 (see golang/go@484586c81a0196e42ac52f651bc56017ca454280). Just need to remove it.…
shurcooL commented on Skp in github.com/shurcooL/Hover1d
I believe SketchUp itself can export as dae. That’s what I did, at least in the version of SketchUp I used, which was some time ago.
This Week
shurcooL commented on x/tools/imports: Feature Request: A… in github.com/golang/go1d
I suspect the best way to resolve this issue might be to decide that "forking `imports` is the best way to customize its behavior", because it seems very very hard to come up with a better way.
shurcooL commented on x/tools/imports: consider exporting… in github.com/golang/go1d
This issue seems related to #12696. Although I don't know how exporting only `FixImports` helps. The PR doesn't seem to help facilitate the decision, because it doesn't communicate why `FixImports…
shurcooL pushed to master in github.com/shurcooL/home1d
e3419152b2c71854ae6a88dbbc4abba02aed6a5dSet session on context in git server.
b74f19d96502cc0452e09fdd71141f74748c53a5issues, changes: Use "/..." suffix in title for github repos too.
shurcooL pushed to master in github.com/shurcooL/events1d
08857041db7c52b374e58991c0482fe187f8b29afs: Add authorization check to Log.
shurcooL pushed to master in github.com/shurcooL/home1d
86a9cb4617bbad7385ac5ce6235f730574a0c8d5issues: Don't consider /idiomatic-go as a Go repo.
shurcooL commented on Potential false negative, didn't re… in github.com/mvdan/unparam1d
Thanks again; this is great!
shurcooL pushed to master in github.com/shurcooL/home1d
ca7cb7b09f6984a6ac947547452823a217bf55f2Link GitHub issues/PRs to local apps for shurcooL user.
shurcooL pushed to master in github.com/shurcooL/events1d
687fb6b1a26ab3ace9b4b3dfd9c66d6b4c294e56githubapi: Use github.Router for issue and change HTML URLs.
shurcooL commented on Comments for humans always have a s… in dmitri.shuralyov.com/idiomatic-go1d
Yes, `// +build` is an exception that comes from pre-1.0 times. It doesn't invalidate the point made here. The main reason for this entry is *consistency* with existing code. There was a proposal to…
shurcooL pushed to master in github.com/shurcooL/notifications1d
2acc6a83825b8261f1586ab2e11d01de56e70aebgithubapi: Factor out Router into standalone package.
shurcooL created repository dmitri.shuralyov.com/route/github2d
Package github defines a router for targeting GitHub subjects.
shurcooL pushed to master in dmitri.shuralyov.com/service/change2d
8371dbf1bbdfedfb1249989c3e0b277143ede61agithubapi: Avoid using embedded pointer to unexported struct.
shurcooL pushed to master in github.com/gopherjs/gopherjs2d
3926a9f66452f7a8c8d9c0e4e3074383f9aff5cdinternal/sysutil: Fix build error on FreeBSD due to Rlimit.Cur type mismatch. (#752)
shurcooL pushed to rlimit_freebsd in github.com/juergenhoetzel/gopherjs2d
2cd41d7d91d7e7f4b9d46a2d42c6fb921b18b988internal/sysutil: Document why type conversion is necessary.
shurcooL commented on go/vcs: add package comment in github.com/golang/tools2d
### Before ![image](https://user-images.githubusercontent.com/1924134/36227239-6f100776-119e-11e8-9b97-b4e2972d5529.png) ### After ![image](https://user-images.githubusercontent.com/1924134/…
shurcooL deleted branch in github.com/shurcooL/tools2d
vcs-doc
shurcooL pushed to master in github.com/shurcooL/Hover3d
shurcooL pushed to master in github.com/shurcooL/notifications3d
6ddfc4f3a7333c8050c6e30ddda0cd74d7cf4ebbgithubapi: Sync with issues/githubapi, change/githubapi.
shurcooL pushed to master in github.com/shurcooL/issues3d
3db36ea3fa8a58c6a40b124166c46e4dd769f49dgithubapi: Change ghV3User to accept value, not pointer.
47ac47af2acf5dd1e86a83227704e37f350aa210Document expectation to include domain in issues.RepoSpec.
shurcooL pushed to master in dmitri.shuralyov.com/service/change3d
2fb0e89b2ed38899ef391fdf285fad155e9bc230githubapi: Sync various improvements from issues/githubapi.
shurcooL pushed to master in github.com/shurcooL/tictactoe3d
ecb4d472d527ddb97e427be037b8214a6ef2682dcmd/tictactoe: Use document.ReadyState to not miss DOMContentLoaded event.
shurcooL commented on Potential false negative, didn't re… in github.com/mvdan/unparam3d
Looking to clarify. This issue was marked as resolved in commit ed0d5d54fb556ea0c2330b5c5d4d32cc80086f96 with the following message: ``` check: "result X is always nil" with one return Before,…
shurcooL commented on Roadmap. in github.com/shurcooL/githubql3d
Good news, I've just checked off the following box: > - [x] Directives (haven't tested yet, but expect it to be supported). I've tested [GraphQL directives](http://graphql.org/learn/queries/#di…
shurcooL pushed to master in github.com/shurcooL/home3d
10d947de8e2758bf2441cf414662c59c45aec527Implement issues.TimelineLister in shurcoolSeesGitHubIssues.
shurcooL pushed to master in github.com/shurcooL/issuesapp3d
a882069ebb79b8d8a92f91fa9df3b6db810e286dMake use of optional issues.TimelineLister interface.
shurcooL pushed to master in github.com/shurcooL/issuesapp3d
e5fc7b08fde5b9ad1cd8fffa4d1dd72092913877Make use of optional issues.TimelineLister interface.
shurcooL pushed to master in github.com/shurcooL/issues3d
4081aa59e957752abbfc6b6fdab72c3bbc1c1decAdd optional ListTimeline method; implement it in githubapi.
36fff28db4d1f8abcc8bce30659f0ad759331307githubapi: Combine two GraphQL queries in ListComments.
8e4d78e17470533663c73d0467710f43de1f8d16githubapi: Support bot actors.
shurcooL commented on Broken build on master in github.com/shurcooL/Go-Package-Store4d
Thanks for reporting. The package that fails it build is only used on frontend, and in normal build, it uses a pre-compiled version from `assets` package. That’s why `cmd/Go-Package-Store` works. …
shurcooL commented on Experiment: compiling go packages -… in github.com/gopherjs/gopherjs4d
Thanks for letting us know. There are multiple issues open that discuss the similar topic of "having GopherJS produce rather than a single javascript file, multiple files - one for each Go package…
shurcooL commented on proposal: reconsider allowing emacs… in github.com/golang/go4d
One benefit of the current policy is that it makes it easy to reject CLs (and discourage them from being created) that try to add "SomeObscureAndQestionableFile" to `.gitignore`. If this proposal …
shurcooL commented on Add the packaging metadata to build… in github.com/rsc/2fa4d
Isn’t the canonical import path `rsc.io/2fa`? That’s what it says in the README.
shurcooL pushed to master in dmitri.shuralyov.com/service/change4d
ede004665f39daffb01fdd6c41652a2ff7ac6901fs: Add second commit to mock data.
shurcooL pushed to master in dmitri.shuralyov.com/app/changes4d
606c5de432d831a3d9cce62bb35a482dec42e7e2Progress on "requested changes" review state in templates.
shurcooL pushed to master in github.com/shurcooL/home4d
40500e07e975a3e4181c7e24c8a921cb65492b2b_data/commit: Use "display: block;" for ".highlight .input-block".
shurcooL pushed to master in github.com/shurcooL/home5d
65e8feb150998ce2b6af506a2705480518843028internal/code: Offer full package doc (not just synopsis).
shurcooL pushed to master in dmitri.shuralyov.com/service/change5d
e5d81b90c30ef8b47bf582517aeaf4271c684c2efs: Update mock data for first woff2 change.
shurcooL pushed to master in github.com/shurcooL/issuesapp5d
8ad0f08b3bd1632fe8cc131e529c09b896920db8component: When user login is missing, show name.
shurcooL pushed to master in dmitri.shuralyov.com/app/changes5d
07ddaaabd263e43af99a7f8085644b81ed900daacomponent: When user login is missing, show name.
shurcooL pushed to master in dmitri.shuralyov.com/service/change5d
0493202ef5f73b299291d6aa0ad2f5338c197e46githubapi: Fall back to git user when github user is missing.
shurcooL pushed to master in github.com/shurcooL/notifications5d
c27d09b6148c3751459a88d57f548e9f8812f6e0Spell out zero in documentation.
9d253906b5bc7b6a2c258a072037ad66cafd1859githubapi: Try again without cache in MarkRead if notification not found.
shurcooL pushed to master in github.com/shurcooL/home5d
acc8859d8d1cd25bc14029265909b4df4689deffMake Changes tab visible on commit page.
shurcooL pushed to master in dmitri.shuralyov.com/app/changes5d
459f87ddd82ac73a94bd82d93d5ec180f43e25a4Render inline comments as markdown.
shurcooL commented on Fix build error on FreeBSD due to R… in github.com/gopherjs/gopherjs5d
As a heads up, this wouldn't be right. Both commas and spaces are significant, so you shouldn't use both. See https://godoc.org/go/build#hdr-Build_Constraints: > A build constraint is evaluated as…
shurcooL commented on Monocticons: Octicons mono reposito… in github.com/primer/octicons5d
> At this time, new icons will only be added when they are needed for GitHub products. Is this statement still accurate or not anymore? It was removed here, and I can't find it re-added anywhere e…
shurcooL commented on golang.org\x\crypto\ssh\terminal in github.com/golang/gddo5d
I see. This issue tracker is for tracking bugs related to the `github.com/golang/gddo` project, but your problem is with installing the `golang.org/x/crypto/ssh/terminal` package via `go get`. I'll c…
shurcooL commented on Potential false negative, didn't re… in github.com/mvdan/unparam5d
Thank you for your work and making the tool better; glad my report was helpful!
shurcooL commented on golang.org\x\crypto\ssh\terminal in github.com/golang/gddo5d
Is this a bug report for godoc.org? What is the problem?
shurcooL starred github.com/vektah/gqlgen5d
shurcooL commented on Add support for parsing WOFF2 fonts. in github.com/ConradIrwin/font5d
> I've added a few comments via redpen. I have to admit, I don't find that the easiest, because it makes things like searching hard, and I'm used to reviewing APIs in code. But I've given it a go :) …
shurcooL deleted branch in github.com/shurcooL/home5d
changes
shurcooL pushed to master in github.com/shurcooL/home5d
61cf5468bec416f763e9761fa696cf5b6f8b99a9activity: Rename event.PullRequest* to event.Change*.
14ccd71942d03de5e5fbf7993c036f492efaaaa7Use changes app for displaying changes in local repos.
81fcb0e65ad72e321f872c854ca2b974ad439becUse changes app for displaying PRs on GitHub.
shurcooL pushed to changes in github.com/shurcooL/home5d
61cf5468bec416f763e9761fa696cf5b6f8b99a9activity: Rename event.PullRequest* to event.Change*.
shurcooL pushed to master in github.com/shurcooL/events5d
cbb6dd2641d7c3c0ad6f876fb393abef011d59caRename PullRequest{,Comment} to Change{,Comment}.
shurcooL created branch in github.com/shurcooL/home5d
changes
shurcooL commented on Fixed the Markdown formatting in th… in github.com/intel-go/cpuid5d
You should probably indent the entire fenced code block, so that it appears with the same alignment as "Usage example:" text on top. Compare, the current README: ![image](https://user-images.gi…
shurcooL commented on Fixed the Markdown formatting in th… in github.com/intel-go/cpuid5d
Were these 2 spaces added intentionally?
shurcooL created repository dmitri.shuralyov.com/font/woff25d
Package woff2 implements a WOFF2 font decoder.
shurcooL pushed to master in github.com/shurcooL/home5d
a2635afb8c1f37c8c158191abd2da4c6faa76c92internal/code: Discover empty repositories.
9de7e91fe3132cbeaf9de0d6e5abe087c525a904Make it clear that listCommits error is being handled.
shurcooL deleted branch in github.com/shurcooL/home5d
discover-empty-repo
shurcooL created branch in github.com/shurcooL/home5d
discover-empty-repo
shurcooL pushed to master in dmitri.shuralyov.com/app/changes6d
04f366dcc540bf583cb10b1108c90fbd43700f58Add repo parameter to ThreadType.