Activity
Yesterday
dmitshur commented on github.com/hajimehoshi/oto: Crash on newDriver on macOS4h
(@hajimehoshi If you want to CC me, my GitHub username is @dmitshur [as of July 2018](https://twitter.com/dmitshur/status/1021266582834634752).)dmitshur commented on github.com/dghubble/sling: Add Content-Length checking before decoding4h
In case it's helpful to you, please note there's a typo in "Content-Lenght". It should be "Content-Length".dmitshur closed an issue github.com/russross/blackfriday/v2: decide on import path and make a new release5h
dmitshur commented on github.com/russross/blackfriday/v2: decide on import path and make a new release5h
There haven't been any reports of serious issues with the `v1.6.0-pre.1` pre-release version (neither in this thread, nor in other issues), so I'm going to proceed with promoting it to `v1.6.0`.
V…dmitshur created tag in github.com/russross/blackfriday5h
v1.6.0dmitshur commented on github.com/russross/blackfriday: Fix 404 error for v25h
The `github.com/russross/blackfriday/v2` import path is intentional. See https://github.com/russross/blackfriday/issues/587#issuecomment-703393820.
Where are you getting a 404?dmitshur commented on windows/arm: fatal error: minpc or maxpc invalid10h
> Perhaps @dmitshur can fill us in on what needs to happen to get access to this machine? I checked `gomote create` and it was listing `windows-arm-zx2c4` as a valid gomote, but `gomote ssh` failed.
…dmitshur commented on golang.org/x/website: Fix timestamp format in pseudo-versions10h
(2 comments)
Add a prefix to the subject, and use lower-case "fix" instead of "Fix":
content/static/doc: fix timestamp format in pseudo-versions
To make this change, edit the Pull Request subj…This Week
dmitshur merged a change doc/go1.16: consolidate stdlib changes in "Minor changes" section1d
dmitshur merged a change doc/go1.16: consolidate stdlib changes in "Minor changes" section1d
dmitshur commented on doc/go1.16: consolidate stdlib changes in "Minor changes" section1d
(1 comment)
I think both approaches are okay and it comes down to preference: I interpret this line as a very short sentence, and prefer to end it with a period. See CL 273126 for a recent example o…dmitshur opened a change doc/go1.16: consolidate stdlib changes in "Minor changes" section1d
Many of the standard library changes that were added before CL 272871
ended up in the "Core library" section. That section is meant for
major changes like new packages, and most of these aren't.
Con…dmitshur reviewed +2 on doc/go1.16: add time/tzdata release note for CL 2618771d
(4 comments)
Thanks! I left very minor comments.
https://tip.golang.org/pkg/time/tzdata/ uses "timezone" without space, maybe that's better for consistency.
Nit: Would it be better to write databa…dmitshur commented on golang.org/x/build/cmd/relnote: RELNOTE in Gerrit comments are missed after Gerrit UI change in July 20202d
Sent [CL 272907](https://golang.org/cl/272907).
I went with the following approach:
> - Another option is to modify `relnote` to use the Gerrit API. It should be possible to write a search quer…dmitshur merged a change doc/go1.16: fill in Go 1.16 release note TODOs using relnote2d
dmitshur opened a change doc/go1.16: fill in Go 1.16 release note TODOs using relnote2d
The additions were generated using golang.org/x/build/cmd/relnote.
For #40700.dmitshur opened a change golang.org/x/build/cmd/relnote: use GerritCL.Subject method instead of clSubject function2d
Apply a trivial code simplification. Tested by re-running relnote, and
its output did not change.
For golang/go#41849.dmitshur commented on golang.org/x/website: SHA256 Checksum incorrect in Ubuntu3d
Thanks for reporting, we'll take a look.
CC @golang/release.dmitshur commented on golang.org/x/net/http/httpproxy: http_proxy is being used for https requests3d
Closing as fixed. (We still need to document this change in Go 1.16 release notes, but that's tracked separately.)
The code change has happened in x/net in [CL 249440](https://golang.org/cl/249440…dmitshur closed an issue golang.org/x/net/http/httpproxy: http_proxy is being used for https requests3d
dmitshur commented on golang.org/x/net/http/httpproxy: match http scheme when selecting http_proxy3d
(1 comment)
It's quite hard to tell that the issue is open for release notes. Its title is x/net. Let's use RELNOTE=yes here, and close the issue, since the code change has already been done.dmitshur commented on cmd/link: unexpected bindingNone in '_go.buildid'3d
From https://github.com/golang/go/issues/42082#issuecomment-728301951, I see this issue is already resolved on tip via changes in `dev.link` that were merged into `master`. So I understand this issue…dmitshur commented on cmd/link: unexpected bindingNone in '_go.buildid'3d
@cherrymui Should this issue target Go1.16 milestone, and once fixed, a backport of it requested via the process described at https://golang.org/wiki/MinorReleases? Or is there a reason not to follow…dmitshur merged a change cmd/compile: [release-branch.go1.15] do not emit an extra debug_line entry for the end of seq addr3d
dmitshur commented on cmd/compile: [release-branch.go1.15] do not emit an extra debug_line entry for the end of seq addr3d
(1 comment)
There are extra rules for release branches, they are documented at https://golang.org/wiki/MinorReleases. A backport issue must first get to CherryPickApproved state before any CLs for i…dmitshur commented on cmd/link: debug_line can contain multiple entries for the same PC address in Go 1.15.4 [1.15 backport]3d
Approved as this is a serious issue without a viable workaround. Only 1.15 needs this backport.dmitshur commented on golang.org/x/build/env/linux-x86-buster: add netbase package to the host3d
(1 comment)
Trivial nit: All lines above have a colon after the package name, separating it from the description.dmitshur reviewed +2 on golang.org/x/build/env/linux-x86-buster: add netbase package to the host3d
(2 comments)
Interesting that it's not included by default.
Add a comment above this line explaining the motivation for netbase. Something like:
# netbase: for net package tests, issue 42750
…dmitshur commented on runtime: crash on allocation of extremely large block (darwin/arm64)3d
I tried the consul@v1.8.5 repro and I'm able to reproduce on a M1 Mac with 8 GB RAM at:
```
$ go version
go version devel +7716a2fbb7 Sun Nov 22 11:44:49 2020 -0500 darwin/arm64 # CL 272258 PS …dmitshur commented on path/filepath: TestEvalSymlinksAboveRoot failures on darwin-amd64 builders4d
I've run into this failure on darwin/arm64 as well, so it's not just darwin/amd64.
It seems to be quite easy to reproduce when the system is under load with:
```
$ go version
go version devel…dmitshur commented on runtime: sporadic but frequent "signal: illegal instruction" during all.bash on darwin/arm64 at CL 272258 PS 14d
I'm able to reproduce @rolandshoemaker's finding above with `go test io -run='^$' -bench=BenchmarkCopy -count=10`, 5 out of 5 times. It triggers within 5-30 seconds.
---
Trying out `GODEBUG=asy…dmitshur commented on runtime: sporadic but frequent "signal: illegal instruction" during all.bash on darwin/arm64 at CL 272258 PS 14d
> Does `TestExec` in syscall package pass reliably?
I believe it does:
<details><br>
```
$ go version
go version devel +7716a2fbb7 Sun Nov 22 11:44:49 2020 -0500 darwin/arm64
$ go test -…dmitshur commented on runtime: sporadic but frequent "signal: illegal instruction" during all.bash on darwin/arm64 at CL 272258 PS 14d
I think that issue is about running Go darwin/amd64 port under Rosetta 2. This is about running the darwin/arm64 port natively.
I can try it anyway to see what effect it has.dmitshur commented on cmd/go: macOS on arm64 requires codesigning4d
> Does CL https://go-review.googlesource.com/c/go/+/272258 help? Thanks!
As others confirmed above, that CL indeed makes it possible to do `go run hello.go` and have it work as usual.
That CL e…dmitshur opened an issue runtime: sporadic but frequent "signal: illegal instruction" during all.bash on darwin/arm64 at CL 272258 PS 14d
[CL 272258](https://golang.org/cl/272258) has made it easy to run `all.bash`, so I ran it a few times. It has passed at least once, but most of the some test will fail due to "signal: illegal instruc…dmitshur starred in filippo.io/yubikey-agent4d
dmitshur closed a change github.com/dbmedialab/go-graphql-client/transport: use golang.org/x/net/context/ctxhttp package4d
Last Week
dmitshur commented on cmd/go: macOS on arm64 requires codesigning5d
@jpap Yes, rebooting has an effect. I tried building+signing+execing a novel binary to a non-temporary location, it was killed. After rebooting (and doing nothing else), the same binary started to ru…dmitshur commented on cmd/go: macOS on arm64 requires codesigning6d
Ok. I tried PS 4 with a modified program:
<details><br>
```
# modify p.go to be a new program, one I've definitely never built before
$ GOOS=darwin GOARCH=arm64 go build -o ps4 p.go
$ /tmp…dmitshur commented on cmd/go: macOS on arm64 requires codesigning6d
> If you build a fresh binary, don't try to execute it, sign it, then execute, does it work?
In my previous tests, I’ve always done `go build`, then sign, then execute. I may not have cleaned bu…dmitshur commented on cmd/go: macOS on arm64 requires codesigning6d
I tried Cherry’s `codesign` again at Patch Sets 1 through 3. If I didn’t make a mistake, it seems they all work if I compress the binary and uncompress it, but not before that. The binaries were …dmitshur commented on cmd/go: macOS on arm64 requires codesigning6d
Thanks for double checking my result @jpap. I will try again in a bit.dmitshur commented on cmd/go: macOS on arm64 requires codesigning6d
> @dmitshur what about PS3? I just updated the CL again.
@cherrymui Same outcome with PS3.dmitshur commented on cmd/go: macOS on arm64 requires codesigning6d
> Just to be sure, could someone confirm that the updated version of codesign.go on https://go-review.googlesource.com/c/scratch/+/271866 works on M1? Thanks.
@cherrymui I tried again with Patch Set…dmitshur opened an issue golang.org/x/build/cmd/releasebot: provide binary release for darwin/arm64 for 1.166d
Based on discussion in a release meeting, I understand our current plan is to aim to provide binaries (and installer) for darwin/arm64 in time for the Go 1.16 release.
I'm making this as the track…dmitshur commented on golang.org/x/build/cmd/release: evaluate builders used for upcoming major Go release6d
The @golang/release team has considered the current builders, and we are proposing the following builder changes for the Go 1.16 release:
go1.16*.linux-amd64.tar.gz
--------------------------
…dmitshur reviewed +2 on golang.org/x/build/dashboard: add new Windows ARM builder6d
(5 comments)
Thanks, this looks good. See inline comments for minor changes.
I checked and this misc-compile TryBot should be passing:
```
$ ./buildall.bash windows-arm
Building Go cmd/dist using …dmitshur commented on syscall: add DLLError.Unwrap() method6d
@alexbrainman Thanks for making this freeze exception request and providing a rationale.
I am approving this for Go 1.16. The change is trivial and should not add significant delay or increase ris…dmitshur closed a change net/http: skip TestNoSniffExpectRequestBody_h26d
dmitshur commented on net/http: skip TestNoSniffExpectRequestBody_h26d
This CL has served its intended purpose and is no longer needed.dmitshur closed a change all: update vendored dependencies for Go 1.16 release (alt)6d
dmitshur commented on all: update vendored dependencies for Go 1.16 release (alt)6d
This CL has served its intended purpose and is no longer needed.dmitshur reopened an issue net/http: race in http2Transport6d
dmitshur commented on net/http: race in http2Transport6d
Reopening as the `net/http` issue isn't fixed in Go 1.16 yet.
This issue got closed because [CL 253259](https://golang.org/cl/253259) was submitted with the verb "Fixes". However that CL was in x/…dmitshur commented on cmd/compile: ICE due to bad ORL constant [1.14 backport]6d
Approving as it is a serious issue without a good workaround. This backport applies to both 1.15 (#42753) and 1.14 (this issue).dmitshur commented on cmd/compile: ICE due to bad ORL constant [1.15]6d
Ah, indeed, go1.5.4 was too old and fails even on simple Go programs for unrelated reasons (not to mention its compiler doesn't support ssa/check/on). Thanks for accurately determining that this regr…dmitshur commented on cmd/compile: ICE due to bad ORL constant [1.15]6d
It seems this isn't a recent regression, it happens even with Go 1.5.4:
```
$ go1.5.4 build p.go
# command-line-arguments
fatal error: still in list
[...]
main.main()
/usr/local/go/src/cmd/…dmitshur merged a change internal/poll: [release-branch.go1.15] use copy_file_range only on Linux kernel >= 5.36d
dmitshur reviewed +2 on internal/poll: [release-branch.go1.15] use copy_file_range only on Linux kernel >= 5.36d
dmitshur closed an issue golang.org/x/website: golang.org/subtests is showing an error6d
dmitshur commented on golang.org/x/website: golang.org/subtests is showing an error6d
Thanks for clarifying.
blog-test.golang.org is not a valid subdomain at this time, and all unknown subdomains get redirected to golang.org. This is working as intended.
I'll close this since th…dmitshur closed an issue golang.org/x/website: needs redeploy after Go 1.15.5 release6d
dmitshur commented on golang.org/x/website: needs redeploy after Go 1.15.5 release6d
Given that https://golang.org/doc/devel/release.html#go1.15 was updated to include full description of Go 1.15.5, I agree this can be closed as a duplicate of #42744.
Thanks @AlexRouSg.dmitshur commented on cmd/go: update tests not to rely on external domains that only an individual maintainer has access to6d
As an update, this issue has been resolved for the `insecure.go-get-issue-15410.appspot.com` host by granting access to it to the @golang/release team.dmitshur commented on internal/cpu: support darwin/arm64 CPU feature detection [freeze exception]6d
@FiloSottile Thanks for letting us know. We've discussed this on the release team, and based on the rationale you provided and the external constraints that could not be worked around in advance, we …dmitshur commented on golang.org/x/website: needs redeploy after Go 1.15.5 release6d
Thanks for reporting. The website needs to be redeployed after the Go 1.15.5 release.
CC @katiehockman.dmitshur commented on runtime: crash on allocation of extremely large block (darwin/arm64)1w
CC @cherrymui.dmitshur commented on cmd/go: macOS on arm64 requires codesigning1w
@cherrymui I got the same result as @rolandshoemaker. In case it helps, some details:
<details><br>
```
$ export PATH="$PATH:$HOME/go116arm64/bin"
$ GOOS=darwin GOARCH=arm64 go build -o h0 he…dmitshur reviewed +2 on net: reset value before adding in minor kernel version1w
(1 comment)
Thanks for fixing.dmitshur commented on io: Copy leaves file zero bytes in Azure AKS with CIFS — Go1.15 regression [1.15 backport]1w
Approving per discussion in a release meeting. Only Go 1.15 needs this backport.
I left a comment on the CL that should be addressed as part of code review.dmitshur commented on internal/poll: [release-branch.go1.15] use copy_file_range only on Linux kernel >= 5.31w
(1 comment)
I left a comment on the upstream CL (https://go-review.googlesource.com/c/go/+/268338/3#message-84a3c0cbf4b123110d8dc4184c023d2f2e5a0ef3), I think it may apply here.dmitshur commented on internal/poll: use copy_file_range only on Linux kernel >= 5.31w
(2 comments)
I think this is missing a line to reset value to zero:
value = 0
Without it, the minor component value will be miscalculated when the major version isn't 0.
I understand kernelVe…dmitshur opened an issue net: kernelVersion helper miscalculates minor version component1w
In `kernelVersion`, after reaching the end of the major version component, the accumulated `value` is used. But it isn't reset to zero after, so the minor version component computation is polluted.
…dmitshur commented on cmd/link/internal/ld/pe: Fix segfault adding resource section1w
(1 comment)
To update the commit message text, you need to edit the GitHub Pull Request description. Please see https://golang.org/wiki/CommitMessage#github-pull-requests.dmitshur commented on runtime: infinite loop in lockextra on linux/amd64 [1.14 backport]1w
Approving per discussion in a release meeting. This backport applies to both 1.15 (#42636) and 1.14 (this issue).dmitshur commented on runtime: infinite loop in lockextra on linux/amd64 [1.15 backport]1w
Approving per discussion in a release meeting. This backport applies to both 1.15 (this issue) and 1.14 (#42635).dmitshur closed an issue golang.org/x/build: dragonfly-amd64-master builder is offline1w
dmitshur commented on golang.org/x/build: add automated notifications for missing builders to its owner and/or golang-dev1w
CC @golang/release.dmitshur commented on golang.org/x/build: dragonfly-amd64-master builder is offline1w
Thanks for bringing the builder back online.
At this time, we don't have a notification mechanism beyond someone spotting that a builder is missing by looking at [build.golang.org](https://build.g…dmitshur commented on golang.org/x/build: add builder for macOS on Apple silicon1w
@tzeejay Thanks. We do use MacStadium, as you can see at https://github.com/golang/build/tree/master/env/darwin/macstadium. @cagedmantis reached out to them on November 10, and we are now waiting for…dmitshur merged a change golang.org/x/website/content/static: fix collapsed spacing in preformatted blocks1w
dmitshur commented on cmd/go: macOS on arm64 requires codesigning1w
@marcopeereboom Please be mindful of [Gopher values](https://golang.org/conduct#values) when communicating in the Go issue tracker. Criticism is welcome when it adds new information to the discussion…dmitshur reviewed +2 on golang.org/x/website/content/static: fix collapsed spacing in preformatted blocks1w
(2 comments)
Thanks!
Let's add a comment, similar to line 97 above, to help explain this somewhat unusual workaround. Something like:
/* Maintain spacing inside preformatted blocks rendered fr…dmitshur reviewed +1 on crypto/hmac: [dev.boringcrypto] merge up to 2a206c7 and skip test1w
dmitshur merged a change all: [dev.boringcrypto] merge master into dev.boringcrypto1w
dmitshur opened a change all: [dev.boringcrypto] merge master into dev.boringcrypto1w
dmitshur commented on : go get isn't using GOPROXY1w
In Go 1.15, the default value for `GO111MODULE` is auto, which selects GOPATH mode if there isn't a go.mod file in any parent directory. You may need to set `GO111MODULE=on` explicitly.
This doesn…dmitshur closed an issue : go get isn't using GOPROXY1w
dmitshur commented on golang.org/x/blog/content: add additional links to pkgsite-redesign.article1w
(1 comment)
Thanks!
FWIW, I found that https://html.spec.whatwg.org/multipage/grouping-content.html#the-figcaption-element suggests:
> Contexts in which this element can be used:
> As the first or…dmitshur commented on golang.org/x/blog/content: add additional links to pkgsite-redesign.article1w
(1 comment)
Is it okay that the newly added <figcaption> element doesn't have a <figure> element as a parent?dmitshur reviewed +2 on golang.org/x/blog/content: add additional links to pkgsite-redesign.article1w
dmitshur reviewed +2 on golang.org/x/blog/content: fix images on mobile for pkgsite-redesign.article1w
dmitshur commented on dev.regabi: create dev branch for register ABI implementation1w
Done. `dev.regabi` is created and currently points to commit 0968d2d599189229145b1000cec55d9df47fbc98.
As a friendly observation, the code freeze is intended to shift focus on completing the Go 1.…dmitshur closed an issue dev.regabi: create dev branch for register ABI implementation1w
dmitshur opened an issue golang.org/x/build: consider opting-in to longtest builders by default for cmd/go changes, if/when they're under 15 min1w
(I have a feeling @bcmills may have already filed an issue for this, but I couldn't find it. Maybe it was a comment instead.)
With the progress made on https://github.com/golang/go/issues/37439#is…dmitshur commented on cmd/go: revert "in 'go get', only load retractions for resolved versions"1w
(1 comment)
Thank you Jay.dmitshur commented on cmd/go: revert "in 'go get', only load retractions for resolved versions"1w
(1 comment)
TRY=linux-386-longtest, linux-amd64-longtestdmitshur opened a change cmd/go: revert "in 'go get', only load retractions for resolved versions"1w
This reverts CL 269019.
Reason for revert: The TestScript/mod_gonoproxy test is failing
on linux-386-longtest and linux-amd64-longtest builders.dmitshur commented on golang.org/x/website: HTTP 500 error for concurrency slides1w
Thanks for reporting.
This is another instance of #42572, so I'll merge this issue into that one.dmitshur closed an issue golang.org/x/website: HTTP 500 error for concurrency slides1w