Yesterday
shurcooL pushed to master in github.com/shurcooL/eX023h
shurcooL commented on Attrib.Value is int for webgl and u… in github.com/goxjs/gl1d
> I've moved to passing around the gl.Attrib values directly, which works, but I'd love to be able to pass around the indices by themselves, to avoid exposing gl.* types in my own API. I see. >…
shurcooL commented on tests aren't checked in github.com/mdempsky/unconvert1d
If support for tests is added, it would be nice to make it a boolean flag that's default true, similar to other tools, e.g.: https://github.com/dominikh/go-tools/blob/b0e79018b59e45680f7b4eee178fa…
shurcooL commented on Navigator.Online() is not implement… in github.com/dominikh/go-js-dom1d
Implementing it may be tricky (e.g., see challenges in #35), but anyone who's interested in working on it can give it a shot, and send a PR.
shurcooL commented on reflect Type.Size() bug in github.com/gopherjs/gopherjs1d
Here's a simpler case: https://gopherjs.github.io/playground/#/hOibckA1tX It looks like size of structs isn't supported.
shurcooL commented on reflect Type.Size() bug in github.com/gopherjs/gopherjs1d
Thanks for reporting. That looks like a legitimate issue.
This Week
shurcooL pushed to gradient-pattern in github.com/dominikh/go-js-dom1d
32d3f8a95da38b68672e1f93c3d336edfefd69d2Add result parameters to gradient, pattern creation methods
shurcooL created branch in github.com/dominikh/go-js-dom1d
gradient-pattern
shurcooL commented on Attrib.Value is int for webgl and u… in github.com/goxjs/gl2d
Thanks, that's helpful. It sounds like you still need the ability to create ad-hoc `gl.Attrib` values and use them as indices. The code you posted should work in a cross-platform compatible way. C…
shurcooL commented on Attrib.Value is int for webgl and u… in github.com/goxjs/gl2d
Hi, thanks for reporting this. > This makes it a little hard to manipulate these in a portable way. `gl.Attrib` should be an opaque type. You're likely to get one via [`gl.GetAttribLocation`](h…
shurcooL starred github.com/kolide/updater2d
shurcooL pushed to master in github.com/shurcooL/eX02d
6e5cca970d7263929ea0215825c1276538edc358Use SO_REUSEADDR.
a9c323305713955d605f2e33ff49d83c913dd1b0Add support for Weapon{Command,Action} packages.
244efa1943d27c72a0658c5653fd133e61272167Improve UDP Packet docs consistency.
2f59d25118a4a836f7df230647fa5538d7f2b660Add support for {Send,Broadcast}TextMessage packages.
shurcooL commented on Switch from MDN-doc-scraper to cust… in github.com/gopherjs/vecty2d
Relevant good news: https://blogs.windows.com/msedgedev/2017/10/18/documenting-web-together-mdn-web-docs/.
shurcooL pushed to master in github.com/shurcooL/eX02d
b9f75adfec1b605a20e704e7b97c94678ca4628fRemove .gitignore.
7207137a3e35dfdd915618d1f45a08e1f7f7eb08Force IPv4-only for UDP connections.
shurcooL commented on Implementation of the missing Canva… in github.com/dominikh/go-js-dom2d
Sure thing, happy to collaborate! Merged. Thank you again @luckcolors!
shurcooL pushed to master in github.com/dominikh/go-js-dom2d
790c7894c96d07ad1d2081aca7091a894de79a46Implement missing CanvasRenderingContext2D methods (#44)
shurcooL commented on Typo in README s/fs/assets in github.com/shurcooL/vfsgen2d
No problem. The best/easiest way to use `vfsgen` is via `vfsgendev`, see https://github.com/shurcooL/vfsgen#vfsgendev-usage. I should probably move that section to the top, and move the current…
shurcooL commented on add optional User parameter when fo… in github.com/google/go-github3d
I don't see this parameter documented at https://developer.github.com/v3/repos/forks/#create-a-fork. Is it documented somewhere else? As far as I can tell, the `organization` parameter is optional…
shurcooL commented on Fatal error from a tool results in … in github.com/bradleyfalzon/gopherci3d
> non zero exit codes are normal for static analysis tools Do you mean it's normal for static analysis tools to give non-zero exit code and report no problems?
shurcooL commented on Ply still imports "howett.net/plist" in github.com/DHowett/go-plist3d
@DHowett This is a small issue, but it would probably help to update https://github.com/DHowett/go-plist/blob/master/cmd/ply/README.md#installation to say `howett.net/plist/cmd/ply` instead of `githu…
shurcooL commented on Add unconvert tool. in github.com/bradleyfalzon/gopherci3d
Sorry for the delay. An update here; I now wish to withdraw from taking this and will happily let you take it. When I was considering working on this, I didn't think about the fact there'd be more…
shurcooL deleted branch in github.com/shurcooL/Conception-go3d
try-ci
shurcooL pushed to master in github.com/shurcooL/Conception-go3d
715e0dc2f2aa14651aa6dffa9831a96810e9f554CI: Remove libgles2-mesa-dev package; add .gopherci.yml.
shurcooL pushed to master in github.com/shurcooL/Hover3d
40c52b54c079ff2c6845473525cd49fc30d6341bCI: Switch to libgl1-mesa-dev and xorg-dev packages.
shurcooL deleted branch in github.com/shurcooL/Hover3d
try-ci
shurcooL created branch in github.com/shurcooL/Conception-go3d
try-ci
shurcooL created branch in github.com/shurcooL/Hover3d
try-ci
shurcooL deleted branch in github.com/shurcooL/eX03d
try-ci
shurcooL pushed to master in github.com/shurcooL/eX03d
d346eff6a78d7416d68f2d160d9dfa1e29107501CI: Switch to libgl1-mesa-dev and xorg-dev; add .gopherci.yml.
shurcooL pushed to try-ci in github.com/shurcooL/eX03d
6ae8691fa4842d0ee91aaee956ce8d77afcd183bCI: Switch to libgl1-mesa-dev and xorg-dev; add .gopherci.yml.
shurcooL deleted branch in github.com/shurcooL/eX03d
add-gopherci-yml
shurcooL deleted branch in github.com/shurcooL/eX03d
try-xorg-dev
shurcooL created branch in github.com/shurcooL/eX03d
try-ci
shurcooL created branch in github.com/shurcooL/eX03d
try-xorg-dev
shurcooL pushed to master in github.com/shurcooL/eX03d
4d1812613f53dcd6ccf7f7b42c25c49fe2b527cfAdd zoom feature to FreeCamera.
63737eee551a2f6f8f85aeac10e3b2f419b987b8Fix possible panic due to race condition.
e44d90b7c902600716ff9c741c7cf3c3d2cff648Simplify declaration, remove unneeded code.
shurcooL commented on Panic possible in server.processUDP… in github.com/shurcooL/eX03d
I think it happened again: ``` ... CommandRate: (uint8)(20), UpdateRate: (uint8)(20), }) (packet.EnteredGameNotification)(packet.EnteredGameNotification{ TCPHeader: (packet.TCPHeader)(pa…
shurcooL commented on Add NewEnterpriseClient for GitHub … in github.com/shurcooL/githubql3d
Thanks for reviewing @gmlewis!
shurcooL deleted branch in github.com/shurcooL/githubql3d
github-enterprise
shurcooL pushed to master in github.com/shurcooL/githubql3d
62fe469bc6b12ef11f61fc67722f7f63bce3a2ffAdd NewEnterpriseClient for GitHub Enterprise. (#24)
shurcooL commented on fix tar dest in src in github.com/mholt/archiver3d
Function name `testSame` doesn't match the name `symmetricTest` used in documentation here.
shurcooL pushed to master in github.com/luckcolors/go-js-dom3d
5da0cd85d71854fc48ccc19ae6b51236dad761ebCall correct method in ResetTransform.
e43f1d185ce180f740b95f9a19be10afe8d4b4daUse anticlockwise parameter in Ellipse.
da1872ffdc8b76570cf70d33169b88c94a359d09Rename introtation parameter to rotation.
d2d8617f391b63378fd7f5af9604aadd03aa2e05Document FillText, StrokeText methods.
shurcooL pushed to master in github.com/luckcolors/go-js-dom3d
324901fbea9ad757991224afbc8670ee81f803c4Use int parameters in pixel manipulation methods.
shurcooL commented on Implementation of the missing Canva… in github.com/dominikh/go-js-dom3d
`putImageData` is similar to `drawImage`, in that it accepts fractional values for the position X/Y of where in the canvas to render image data. However, the dirty parameters can only be integers, si…
shurcooL commented on Implementation of the missing Canva… in github.com/dominikh/go-js-dom3d
I testes the X/Y positions, and can confirm they're truncated as well as width/height: ```Go var canvas = document.GetElementByID("canvas").(*dom.HTMLCanvasElement) var ctx = canvas.GetContext2d…
shurcooL commented on Implementation of the missing Canva… in github.com/dominikh/go-js-dom3d
I've done some reading of https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/getImageData and testing `GetImageData`: ```Go println(ctx.GetImageData(50, 50, 1, 1).Object) …
shurcooL commented on Implementation of the missing Canva… in github.com/dominikh/go-js-dom3d
I've pushed a fix for `GetLineDash` build error in df6ab95b9c4396bfdd1c300bca4992016d1ce894, please review @luckcolors.
shurcooL pushed to master in github.com/luckcolors/go-js-dom3d
df6ab95b9c4396bfdd1c300bca4992016d1ce894Fix build error in GetLineDash implementation.
shurcooL commented on Implementation of the missing Canva… in github.com/dominikh/go-js-dom3d
> So i think this is now done, unless you have some other doubts or issues you would like to address. I think this is almost ready to be merged. There just 2 known issues we need to resolve: 1.…
shurcooL commented on Implementation of the missing Canva… in github.com/dominikh/go-js-dom3d
Did you test these changes? It doesn't build: ``` $ gopherjs build dom.go:2036:9: cannot use ctx.Call("getLineDash") (value of type *github.com/gopherjs/gopherjs/js.Object) as []float64 value in…
shurcooL deleted branch in github.com/shurcooL/godecl3d
try-anchor-style
shurcooL commented on 553a104c38ec5076c6f0f817bc933b2e549b7f1bREADME: Try style attri… in github.com/shurcooL/godecl3d
No luck, style attribute isn't allowed either: ![image](https://user-images.githubusercontent.com/1924134/31687972-c9e189b2-b358-11e7-8e1e-401a55864571.png) It still looks like a normal link ra…
shurcooL created branch in github.com/shurcooL/godecl3d
try-anchor-style
shurcooL pushed to master in github.com/shurcooL/godecl3d
af455b9817e79d58bc1660e21f9a0408f58ec6c8README: Add website URL to project description.
7109fca38a4cb6e41595658b28ea31848ec50eadAdd support for address operator.
shurcooL commented on #720 Initial commit for listing Pla… in github.com/google/go-github3d
Yes, it is. Although if you want to be precise about terms, it's a "type conversion". See https://golang.org/ref/spec#Conversions: > Conversions are expressions of the form T(x) where T is a type …
shurcooL commented on Minor readabilty improvements in github.com/gopherjs/gopherjs3d
Thanks for the PR. I agree these changes are an improvement. However, I remember seeing an exact same (or very similar) PR in the past (can't easily find it now), and @neelance rejected it then, b…
shurcooL commented on Minor readabilty improvements in github.com/gopherjs/gopherjs3d
That would work too, but personally, I don't mind (in fact, I slightly prefer) it as written. It has to do with where I perceive the emphasis to be when reading the code. When I see: ```Go err…
shurcooL pushed to github-enterprise in github.com/shurcooL/githubql3d
897d508fa82ea8671574bc666bf538c1f7993b41Add NewEnterpriseClient for GitHub Enterprise.
shurcooL created branch in github.com/shurcooL/githubql3d
github-enterprise
shurcooL commented on GitHub Enterprise support. in github.com/shurcooL/githubql3d
The root GraphQL endpoint for GitHub Enterprise is custom: > the GraphQL API v4 has a single endpoint: > > ``` > http(s)://[hostname]/api/graphql > ``` > > The endpoint remains constant no m…
shurcooL pushed to master in github.com/shurcooL/githubql3d
0be80261f9a4f247c4b0bfef2249685db64724e9README: Move roadmap into issue #22.
shurcooL opened an issue in github.com/shurcooL/githubql3d
shurcooL commented on Ply still imports "howett.net/plist" in github.com/DHowett/go-plist4d
> So if you want to make debian packaging easier for all projects that build-depends on plist, pls consider using the github URL. To play devil's advocate, what if `dh-make-golang` didn’t have g…
shurcooL commented on #720 Initial commit for listing Pla… in github.com/google/go-github4d
@lackerman It works for other services because they're defined as `service`, e.g.: ```Go type ActivityService service ``` So `*service` is convertible to `*ActivityService`. E.g., see [here](…
shurcooL pushed to master in github.com/shurcooL/home4d
adf19fa38b233f0798a3fcd58fcd2d66c1a18963commits: Define own fields for Commit type.
ea20387db1cbaa5b5e0dc5908804dc73ff6a8807commits: Remove headings.
shurcooL commented on runtime: GOROOT() docs are confusing in github.com/golang/go4d
If the current behavior is deemed correct, here's a take at fixing the documentation: > GOROOT returns the root of the Go tree. It uses the GOROOT environment variable, if set at process start, or…
shurcooL commented on tests are broken in github.com/golang/gddo4d
This looks like a duplicate of #480. One of the two issues should be closed as dup.
shurcooL pushed to master in github.com/gopherjs/gopherjs4d
a0a7cfed7b2a54080888fd2b3d4a3ec14562c86cREADME: Use inline code syntax for gopherjs serve command. (#712)
shurcooL merged a pull request in github.com/gopherjs/gopherjs4d
shurcooL commented on wiki: Projects page is 404 but has … in github.com/golang/go4d
@ianlancetaylor Yes, the change is a commit complete with a git author. That git author has a GitHub account associated with it.
shurcooL commented on #720 Initial commit for listing Pla… in github.com/google/go-github4d
@lackerman You wouldn't be able to reuse `&c.common` struct anymore, because `*MarketplaceService` will have an extra field. You'll have to create a new `*MarketplaceService` struct, like so: ```d…
shurcooL commented on How to track API usage statistics in github.com/google/go-github4d
Adding a mechanism for achieving this into `go-github` has the following costs: - Development time cost – the initial work of adding code to every method that exists. - Maintenance time cost …
shurcooL commented on wiki: Projects page is 404 but has … in github.com/golang/go4d
> Is that intentional? Ok, so it looks like this was a case of vandalism, unfortunately. The Projects page has been restored. I'll close this since the issue is resolved.
shurcooL commented on proposal: specify and enforce packa… in github.com/golang/go4d
> Because the current specifications do not limit or prevent people to name their packages in any way This statement is untrue, there are multiple restrictions on the import paths: > Implementa…
shurcooL commented on proposal: specify and enforce packa… in github.com/golang/go4d
> My bad - I keep forgetting that interpreting package names as paths is not an explicit part of the spec. Ignore the first sentence of my comment above. Both "package name" and "import path" are …
shurcooL commented on proposal: specify and enforce packa… in github.com/golang/go4d
From what I understand, only a very small number of Go packages in the wild have problems with import path case inconsistency, is that right? What do you think of taking the approach of directly fixi…
shurcooL commented on godoc: Link rendering is misbehaving in github.com/golang/go5d
> #### What did you expect to see? > > Valid link to `https://www.instagram.com/reneefrench` named `Renée French`. I would not expect to see that. It's a \<pre\> block containing the following …
shurcooL commented on wiki: Projects page is 404 but has … in github.com/golang/go5d
According to https://github.com/golang/go/wiki/_history, the Projects page was removed yesterday, in commit [`d94bd06`](https://github.com/golang/go/wiki/_compare/e33c905b26a850ed59f62877f5a5ace600ed…
shurcooL pushed to NestedTeamsPreview in github.com/google/go-github5d
6f59276df76bdf8958380fcd1fb0144e9ea1cd9dBump libraryVersion
366fb1b76e630d12d7487e261e25eed7fdddde5cChange ParentTeamID field to int (from string). (#748)
5c20fe5b69c72f5c728af3dba67a6524d13d1dceAdd NestedTeamsPreview header to remaining endpoints
beb277c4ff64b327482f8f72cf001058bd9c89c6Add NewTeam struct. (#724)
d25a6cefb1b39177150aba9d80d0c71569de34deAdd support for fetching parent team (for nested teams). (#723)
a021c14a5f1960591b0e1773a4a2ef8257ec93b8Adds RequireCodeOwnerReviews to PullRequestReviewsEnforcement (#744)
99750d1edbfc12d104a3f9d4ff6960e444d37058Add AppsService.{Add,Remove}Repository methods. (#749)
bf5bc4e6583b9891d25811ceb2100cf0e491b1d6Remove ListOptions from RepositoryListAllOptions. (#751)
7de811820d2b3b6ef66f466bdae21e494a52b633Use non-empty Client.BaseURL path in tests.
10a2b148cba999c248d9f7cea42308b24f390519Use relative URLs in all tests.
0f6d3ce15ec23c92c74d014303a167a9a374dd7eAdd ProjectOptions.State field. (#746)
shurcooL commented on Merge NestedTeamsPreview branch to … in github.com/google/go-github5d
We'll need to resolve the conflict with `libraryVersion` bump (it should become 14 now). I'll do that by rebasing this branch on latest `master`. Maybe it's best to bump it just before merging the PR…
shurcooL starred github.com/influx6/shogun5d
shurcooL commented on syscall: fallback to process.exit w… in github.com/gopherjs/gopherjs5d
We should take this documented behavior into account: > In the browser, calling `os.Exit` (e.g. indirectly by `log.Fatal`) also does not terminate the execution of the program. For convenience, it…
shurcooL commented on proposal: doc: Consider GopherJS as… in github.com/golang/go5d
> I believe that the effort behind it should be highlighted in the specifications as such. Why? The goal of The Go Programming Language Specification is to specify the Go programming language, not…
shurcooL commented on proposal: doc: Consider GopherJS as… in github.com/golang/go5d
> can it compile `go/types`? It's go code. Yes, it can. ``` $ gopherjs build go/types $ echo $? 0 ``` > If they can compile all valid go code, why is a library like `go/types` (which is …
Last Week
shurcooL commented on Adds RequireCodeOwnerReviews to Pul… in github.com/google/go-github1w
(That is a hard requirement for top level identifiers, but for struct fields, I think both ways are acceptable. This is currently consistent with the documentation for fields above.)
shurcooL commented on Change JSON encoder to escape HTML in github.com/google/go-github1w
We can amend the commit message when merging this, so that's not a problem. Just waiting on a second review here.
shurcooL pushed to master in github.com/google/go-github1w
99750d1edbfc12d104a3f9d4ff6960e444d37058Add AppsService.{Add,Remove}Repository methods. (#749)
shurcooL pushed to master in github.com/google/go-github1w
bf5bc4e6583b9891d25811ceb2100cf0e491b1d6Remove ListOptions from RepositoryListAllOptions. (#751)