Activity

Today
dmitshur closed an issue golang.org/x/vuln: TestGoModTidy failures37m
I've tried to de-duplicate this into #58766 by updating its pattern to also match this failure.
This is the same failure mode as in #58766. It's a problem only in the old build infrastructure.
(1 comment) (nit) image/jpeg instead of std/jpeg.
From what I can tell, SWARMING_NEVER_REBOOT has effect for most frequent reasons that would otherwise cause the reboot to happen, but it doesn't catch all. The swarming bot seems to occasionally trig…
They are. Although Go can make them too easy via `go:embed`. See some initial comments. I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…
Thanks! Congrats on your first change. :D See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …
Yesterday
Thanks. The "c2s16" suffix seems to fall fairly neatly into the CPU selection category (it has to do with performance consistency).
[CL 568197](https://go.dev/cl/568197) added previous Go release coverage for 3 more first-class ports: linux/386, darwin/amd64, and windows/amd64.
Last Week
dmitshur starred github.com/emer/gosl/v23d
Also CC @golang/mips (for completeness; almost everyone in it was already CC'ed).
Tested this out now; no issues with the fine-grained token permissions so far. I'll keep an eye on it for some time. Submitting.
[CL 563856](https://go.dev/cl/563856) added a note to Go 1.23 release notes, moving to the next.
Thanks. Yeah, I gave it fairly minimal resources to start. It mostly makes API calls in a loop, so it might not need much, and we can bump it later as needed. So far it's taking around 7-8 min per i…
Thanks.
Earlier
[CL 550215](https://go.dev/cl/550215) added a new package. One of its tests, `TestPQCrystalsAccumulated`, is failing on the linux/s390x port: ``` --- FAIL: TestPQCrystalsAccumulated (0.07s) …
@panjf2000 The Auto-Submit+1 vote is documented at https://go.dev/wiki/GerritAccess#auto-submit. I meant you can ask the person who left the +2 vote to either submit or leave Auto-Submit+1 vote—but…
dmitshur starred fyshos.com/fynedesk1w
dmitshur closed an issue access: may-start-trybots and approvers1w
Hi @panjf2000, thanks for contributing to the Go project and asking for approvers access again. We considered this request. As documented at https://go.dev/wiki/GerritAccess, Gerrit "approvers" ac…
This is fixed via [CL 568339](https://go.dev/cl/568339), which removed the duplication.
dmitshur closed an issue access: go-assignees and go-editors1w
Hi @qiulaidongfeng, thanks for your interest and contributions to Go. We considered this request. Similarly to https://github.com/golang/go/issues/66611#issuecomment-2052070282, when considering g…
dmitshur closed an issue access: +2 approval in CLs1w
Hi @mauri870, thanks for contributing to the Go project and asking for this access. We considered this request and felt your contribution history demonstrates enough signals for us to be close to …
dmitshur closed an issue access: approvers1w
Hi @qiulaidongfeng, thanks for your interest and contributions to Go. We considered this request (previously considered in #64255). As documented at https://go.dev/wiki/GerritAccess, Gerrit "appro…
Hi @raghvenders, thanks for your contributions to Go so far. We discussed this request. We generally look for contributors to have a more established track record of contributions before consideri…
This is resolved as of [CL 569875](https://go.dev/cl/569875). (It didn't get closed automatically because the Fixes line didn't specify the `golang/go` repo quite right.)
dmitshur starred github.com/aclements/go-obj1w
@jub0bs Yes, your understanding is right and generally it's good to allow some time for discussion on the issue first, though it's still okay to send a change sooner. There are some more details abou…
Thanks. Confirming a few details. `GOARCH` should be `wasm32` instead of `wasm`, is that right? Related to the above—will `GOROOT/misc/wasm` be used for both `wasm` and `wasm32` exec helpers? Tha…
dmitshur closed an issue access: may-start-trybots2w
Hi abner chenc, Thanks for your contributions and helping maintain the linux/loong64 port. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybot…
> should backport the fix as well To clarify, do you think the fix to be backported should include changes in [CL 576756](https://go.dev/cl/576756) and [CL 576895](https://go.dev/cl/576895)?
CC @griesemer, @findleyr.
Thanks for reporting this. CC @rsc.
CC @golang/compiler.
CC @golang/compiler.
CC @griesemer, @findleyr.
Here's the certificate: [linux-ppc64-power8-1712341779.cert.txt](https://github.com/golang/go/files/14889449/linux-ppc64-power8-1712341779.cert.txt). I'll also work on another CL needed for that h…
@pmur Should this issue also be closed, or is there more to do for it?
Thank you very much @pmur. I've mailed you [go.dev/cl/576917](https://go.dev/cl/576917) to remove its known issue.
The `pollLoop` method that runs in a loop usually takes a minute, but sometimes seems to get stuck and eventually completes in just over 24 hours without any error. This is a tracking issue to sort t…
The definition/embed.txt, definition/misc.txt, and hover/sizeoffset.txt cases of `Test` are failing on linux/arm (32-bit) since they were introduced in [CL 573076](https://go.dev/cl/573076). For e…
The two instances above were on release-branch.go1.22.
CC @golang/openbsd, @ianlancetaylor, @neild.
Thanks for reporting. As a side note, the [package comment](https://pkg.go.dev/log/syslog#pkg-overview) states the `log/syslog` package is frozen and that some external packages provide more funct…
Here's the certificate for the bot hostname `linux-ppc64le-power10`: [linux-ppc64le-power10-1712180608.cert.txt](https://github.com/golang/go/files/14858800/linux-ppc64le-power10-1712180608.cert.t…
Thanks. Here's the certificate: [linux-ppc64le-power9-1712180354.cert.txt](https://github.com/golang/go/files/14858793/linux-ppc64le-power9-1712180354.cert.txt).
I've initially observed this on various builders, most often linux-386 ones, but it seems to reproduce on `darwin/arm64` too. At tip without x/net@v0.23.0 (e.g., commit 61a3ee54411086d4bf996b65dd3…
@geofffranks There will be a new golang.org/x/net tag with the fix in [CL 576155](https://go.dev/cl/576155) included, soon.
Closed by merging commit ae5913347d15cf7d1f218916c22717e5739a9ea3 ([CL 576075](https://go.dev/cl/576075)) to `release-branch.go1.21`.
Thanks for the ping @pmur. I have time to help move this forward this week. I've mailed [CL 575856](https://go.dev/cl/575856) as the next step here, which should make it possible for you to start …
This seems to also happen at tip (commit 94dba61276f26c01b7d3d1a4abb195bdcc596bfd) if attempting to make.bash with `GODEBUG=gotypesalias=1`. <details> ``` src $ git pull --ff-only Already up…
The Windows installer currently always takes responsibility for setting the `GOPATH` environment variable (to `%USERPROFILE%\go`) and adding `%GOPATH%/bin` to `PATH`. If a user wishes to use a differ…
Thanks for reporting. https://pkg.go.dev/reflect#StructTag documentation says: > By convention, tag strings are a concatenation of optionally space-separated key:"value" pairs. Each key is a non-e…
Reopening since the fix in [CL 553055](https://go.dev/cl/553055) was rolled back in [CL 575236](https://go.dev/cl/575236).
Reopening since the fix in [CL 575175](https://go.dev/cl/575175) was rolled back in [CL 575316](https://go.dev/cl/575316).
Go 1.20 has exited its support window per https://go.dev/doc/devel/release#policy.
The upstream issue isn't resolved yet, and Go 1.20 has exited its support window per https://go.dev/doc/devel/release#policy.
https://go.dev/doc/go1.22#os/exec includes: > On Windows, `Command` and `Cmd.Start` no longer call `LookPath` if the path to the executable is already absolute and has an executable file extension…
We have a better understanding of the problem by now, and a mitigation is in the process of being rolled out.
dmitshur closed an issue security: fix CVE-2023-452883w
> which would imply a builder with at least least Clang 15 There's a LUCI builder with clang 15 (e.g., [gotip-linux-amd64-clang15](https://ci.chromium.org/p/golang/builders/ci/gotip-linux-amd64-cl…
dmitshur starred github.com/emersion/go-imap/v21mo
dmitshur starred github.com/emersion/go-smtp1mo
> you have to do [...] `DIR=$(mktemp -d); cd $DIR; go version` If you'd like to determine the bundled Go toolchain's version, it's possible to do it with `GOTOOLCHAIN=local go version`. This is do…
It's common for Go tests that require certain capability or dependency to skip themselves if the environment doesn't meet that requirement. For example, see the various `MustHave*` helpers in [`inter…
dmitshur starred github.com/kanryu/mado1mo
Let's consider starting to do that in the new-to-be v3.4/glfw module (#393). What would some of the finer details look like? I wrote the following to try to answer that and explore options. Its fi…
v3.3/glfw is its own module, separate from the top-level module that has the older versions v3.{0,1,2}/glfw. That seems to be working well, so I expect we can repeat that pattern and also have v3.4/g…
I can confirm the same program no longer panics now that GLFW 3.3.10 is pulled in. `glfw.GetKeyName(glfw.KeyUnknown, 0x003f)` returns an empty string. I think we can close this unless there's somethi…
I think it's fine to leave v3.2 and older as is. I don't expect there will be new GLFW 3.2.x or older patch versions to update to.
Thanks. As a side note, I'm starting to wonder if we should instead (or in addition) link to the upstream documentation on this at https://www.glfw.org/docs/latest/compile_guide.html#compile_deps,…
Thanks. As a side note, I'm starting to wonder if we should instead (or in addition) link to the upstream documentation on this at https://www.glfw.org/docs/latest/compile_guide.html#compile_deps_…
Thanks. As a side note, I'm starting to wonder if we should instead (or in addition) link to the upstream documentation on this at https://www.glfw.org/docs/latest/compile_guide.html#compile_deps_…
It seems a bit unclear if this means "you _only_ need" or "you _also_ need". Since "mesa-libGL-devel" is repeated, I'm guessing it's not the latter? It might be more clear to reuse the phrasing fr…
This is done, and announced at https://groups.google.com/g/golang-dev/c/CqVVuxngzDU/m/MD4qrteuAQAJ. There may be more to do in this general, but bulk of the work is done, so I'll close this. We ca…
We're aware of some issues on the LUCI post-submit dashboard (https://ci.chromium.org/p/golang/g/go-gotip/console). This is an umbrella tracking issue to collect most critical ones that affect the Go…
dmitshur pushed to main in dmitri.shuralyov.com/go/generated1y
e1de015411532fa144166aada4201ee443800425add test case with no final newline
6904a2a3d88d6c3ad39737a7c5bf226f5ebbd482modernize test code slightly
dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl1y
85de2813cf6bd8d6d2f0240fdebf943cbffc2b8afix "supportsFamily not found" warning on macOS 10.13 and 10.14
dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl1y
b78c9fe623cca0431d866c9e206d3f83665bcf8bdeprecate FeatureSet and Device.SupportsFeatureSet
2a3c46a829b92964146abf7f6c2d649cd66cce97add GPUFamily and Device.SupportsFamily
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …
dmitshur pushed to master in dmitri.shuralyov.com/service/change1y
67e22b2f18a260a33a98c6a7d601726a58c53767maintner: update for GitCommit API change
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now. Done in PS 3. I'm following the Go style for commit messages, which chooses…
Shortened 'golang.org' to 'go.dev' here, and on line 24.
dmitshur pushed to master in dmitri.shuralyov.com/website/gido2y
f460621dc784d8a8f3a1593a068115b62baf214dadd support for multiple comma-separated import path patterns
be77a538f6a64b287e073b59d1b9f7e1314cf3a9upgrade to go-git v5
b5ce3c19e6b977800ee3c80bc722192f96ef657breplace mention of godoc.org with pkg.go.dev