Activity

Yesterday
In certain cases the HTTP/2 stack needs to resend a request. It obtains a fresh body to send by calling req.GetBody. This call was missing from the path where the HTTP/2 round tripper returns ErrSkip…
@rsc This backport has been approved for 1.14 and 1.13. It applies cleanly to 1.14, but not 1.13. Since you authored the original CL, would you like to resolve the conflict and send a [cherry-pick CL…
(3 comments) Daniel, how does patch set 2 look to you? s/supports/support/ s/types/type/
(2 comments) Thanks for working on this! > Oddly git-codereview complained about gofmt for some runtime files and the only way to get this change up was to submit to its complaint and then make thi…
/cc @FiloSottile @x1ddos per [owners](https://dev.golang.org/owners).
/cc @alexbrainman @bradfitz per [owners](https://dev.golang.org/owners).
@jayconrod `x/tools/cmd/godoc` has support for module mode (see https://groups.google.com/g/golang-dev/c/uxtj_w7wpnY/m/jR3ui47eBQAJ), what's the reason to want to use `pkgsite` instead of continuing …
/cc @julieqiu per [owners](https://dev.golang.org/owners).
/cc @julieqiu per [owners](https://dev.golang.org/owners).
/cc @julieqiu per [owners](https://dev.golang.org/owners).
/cc @matloob per [owners](https://dev.golang.org/owners).
Aside from visual noise and extra bytes, does the added `=""` cause any issues when the HTML is parsed? /cc @mikioh @bradfitz @ianlancetaylor per [owners](https://dev.golang.org/owners).
Thanks for reporting. I agree the example, as displayed at https://golang.org/pkg/net/http/#example_ServeMux_Handle, can feel like it's missing some code to start the server. However, the example …
/cc @alandonovan (per [owners](https://dev.golang.org/owners)) @ianlancetaylor @matloob.
Backport approved for Go 1.14 (#39920) and 1.13 (this issue) as this is a serious issue with no workaround.
Backport approved for Go 1.14 (this issue) and 1.13 (#39925) as this is a serious issue with no workaround.
(1 comment) TRY=solaris-amd64-oraclerel
This fixes an issue raised at https://github.com/golang/go/issues/38458#issuecomment-635617670 in which --- PASS and --- FAIL lines would not trigger --- CONT lines of other tests. Updates #38458. F…
Backport approved for Go 1.14 (#39849) and 1.13 (this issue) because it's a small fix to a serious problem without a workaround.
Backport approved for Go 1.14 (this issue) and 1.13 (#39848) because it's a small fix to a serious problem without a workaround.
(1 comment) TRY=linux-ppc64,linux-ppc64le
(1 comment) I'll rebase and submit after trybots pass.
/cc @jayconrod @bcmills @matloob
/cc @nigeltao @robpike per [owners](https://dev.golang.org/owners).
Can you please provide a more complete reproduce case? Where did you add `if err := Config.validate(p); err != nil { ... }`? What does `Config` refer to?
(1 comment) Since this change was sent as a GitHub PR, https://golang.org/wiki/CommitMessage#github-pull-requests is relevant.
(3 comments) The subject should be something like: internal/gophers: add new email for Roberto Clapis Notably, package path prefix, colon, space, lower case letter, verb that completes "This c…
(1 comment) Cherry, I have a question about this 1.14 backport CL. Its parent is currently "[release-branch.go1.14] cmd/link: fix GC data reading from shared library (attempt 2)", which means trybot…
@cherrymui Yes, 1.13 will become unsupported once 1.15 is released, which should happen next month. However, both 1.14 and 1.13 are supported equally until then (see #34536 for more details), so if t…
@mundaym This backport doesn't apply cleanly. Would you like to work on creating the backport CL as described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls and see if the merge conf…
These conversion instructions set the condition code and so should be marked as clobbering flags. Updates #39651. Fixes #39690.
Approved for 1.14 (#39690) and 1.13 (this issue) as it's a serious problem without a workaround.
Approved for 1.14 (this issue) and 1.13 (#39689) as it's a serious issue without a workaround.
The relevant code for this error message in Gerrit source code is at https://gerrit.googlesource.com/gerrit/+/refs/tags/v3.2.2/java/com/google/gerrit/server/notedb/OpenRepo.java#181.
Issue #25020 (/cc @ALTree) might be relevant here. If GerritBot indeed doesn't support branches other than `master`, then the fix for this issue will be very simple: it should not consider a Gerrit C…
Consider a Gerrit CL that was imported from a GitHub PR, and merged (or closed without merging). For example, see PR #39821. It's possible that a cherry-pick of that imported Gerrit CL will be mad…
From `gopherbot` logs: ``` 2020/07/10 13:33:30 close stale WaitingForInfo: POST https://api.github.com/repos/golang/go/issues/39453/comments: 422 Validation Failed [{Resource:IssueComment Field:d…
@cherrymui You've sent a 1.14 backport CL for #39955. Are you able to send one for 1.13 (this issue) as well?
Backport approved for Go 1.14 (#39955) and 1.13 (this issue) based on the rationale in https://github.com/golang/go/issues/39955#issuecomment-652647856.
Backport approved for Go 1.14 and 1.13 based on that rationale.
@mkumatag There will be a security release on Tuesday, July 14, as recently [pre-announced](https://groups.google.com/d/msg/golang-announce/f2c5bqrGH_g/GnH6k56AAAAJ). It will include only the securit…
Approving as it is a serious problem without a workaround. It is a 1.14-only regression, so a fix for 1.13 isn't needed.
From `gopherbot` logs, there are a number of CLs where a reviewer fails to be added due to the error "Change nnn may not exceed 5000 updates. It may still be abandoned or submitted. To continue worki…
Thanks for sending a change. Per https://golang.org/doc/contribute.html#design, please open an issue and fill in the template, then add a "Fixes golang/go#nnn." line here. I'd like to understan…
This Week
(1 comment) Thanks for following up!
(1 comment) > For now, let's just bundle all crypto together in the branch, because that's effectively what crypto/internal/boring does. Done, PTAL. The final result diff turned out smaller and mo…
Approved as this 1.14-only regression is a serious issue without a workaround.
I've run into this too when investigating iOS support recently, and temporarily changed to "Apple Development" locally. I haven't followed up on that yet, but just wanted to add a data point.
(1 comment) > Removing encoding/asn1 is easy, removing math/big is not. Got it. Removing encoding/asn1 but keeping math/big would still be an improvement (albeit a smaller one), as it would allow t…
As discussed in [golang.org/cl/241442](https://go-review.googlesource.com/c/go/+/241442/1#message-bb399544c64ab073e5adf50eef6a961dc798ab5e), this is a tracking issue to look into breaking `crypto/int…
(4 comments) Maybe also add the related issues: Updates #38458. Updates #24929. Thanks! (This note.) This is an .html file and Markdown isn't supported here, so please convert this to HT…
There's a CL out to fix this (that just needs review), I think we don't want to release Go 1.15 without this, so marking release-blocker so this isn't missed by accident.
> Running the mentioned go playground program prints "application/wasm", so there it is working correctly. What about if you run the same program on your computer, what does it print then?
(1 comment) Yes, if encoding/asn1 and math/big dependencies are removed from crypto/internal/boring, it would make fitting it in much easier! All other packages it imports are much lower level. Tho…
(1 comment) > I don't think the distinction between which crypto packages import cgo and which ones don't is meaningful in dev.boringcrypto. Thanks for this information. However, even if we drop t…
(2 comments) An optional comment about a small detail. Compared to how many other env vars are currently described here, this sentence seems a bit out of place and may be prone to being misinterpre…
Removed the fixed pitfall from the SlowBots wiki page in commit [`2b70f5ce`](https://github.com/golang/go/wiki/SlowBots/_compare/c6e42666f7905fcaef067d5495004c47d1426ae7...2b70f5ce3d2354f29339716db0c…
dmitshur edited the wiki3d
(1 comment) This has been tested and it's working as expected so far; I'm not spotting any issues. After leaving https://go-review.googlesource.com/c/go/+/241274/3#message-b8608a9934c725916edcf6dfe…
(2 comments) Yep, thanks. Done.
(1 comment) TRY=macos, ios
(3 comments) Added a comment. Done. Done.
> are there any known issues with that builder? I can't think of anything relevant off the top of my head, and the "notes" field at https://farmer.golang.org/builders is empty. In general, the darwi…
(3 comments) I agree. If there's ever a better way, I'd be happy to switch to it. That said, I can say I've been associating inline comments with the top-level message just by the equating the time …
Fixes golang/go#40106. Fixes golang/go#38747.
I've looked into this and know what needs to be done to restore service: - update maintapi to extract TRY= comments from inline comments (where they now end up) - [likely] add [List Change Comm…
(2 comments) TRY=linux-amd64-longtest (Unresolved comment.) Reply.
(1 comment) TRY=linux-amd64-longtest (Resolved comment.)
(1 comment) Tests in build_test.go are primarily testing that the go/build package itself is working correctly. I suggest moving this to the bottom of deps_test.go, that seems like a better place t…
(1 comment) I realize that this was likely copied directly from TestDependencies, but consider reusing testenv.HasSrc() (see https://pkg.go.dev/internal/testenv#HasSrc) to achieve the same effect an…
The problem with "unable to add local env to initialize request" doesn't look related to the race in #39865, but maybe I'm misunderstanding it. If you think all of the recent failures on `freebsd-am…
The test added in [CL 238917](https://golang.org/cl/238917) are not passing on darwin builders: ![image](https://user-images.githubusercontent.com/1924134/86809786-3ce56180-c04a-11ea-8411-e103074f…
(1 comment) The RELNOTES comment in CL 207877 includes a partial note, maybe it's worth copying it here: > The linker defaults to internal linking mode for PIE on linux/amd64 and linux/arm64, which…
The fix for #38574 was included in go1.15beta1. @albrow, can you please see if the issue is fixed in that version?
Thanks for reporting. /cc @neelance @cherrymui
/cc @matloob @bcmills @jayconrod
/cc @rsc per [owners](https://dev.golang.org/owners).
I believe this has been fixed by the builder change in [CL 227859](https://golang.org/cl/227859). There have not been timeout errors in the `x/tools/go/packages` package lately. Closing. This is a…
The `freebsd-amd64-race` builder was largely passing on x/tools before June 25, and started to often since then: | Before | After | |--------|------| ![image](https://user-images.githubuserconte…
Go 1.15 adds the `GOMODCACHE` environment variable (#34527). It's mentioned in the release notes ([CL 230537](https://golang.org/cl/230537)). Should it also be included in the list at https://tip.gol…
I've looked at the last 2 weeks of results (this is after the builder change in [CL 235419](https://golang.org/cl/235419)), and I'm not spotting OOM-related failures. There are frequent failures on `…
I was able to reproduce locally on darwin/amd64 at golang/tools@95bc2bdf7e31d255ef5ac04e85be0e11883c7cf2 with: ``` $ go version go version go1.14.4 darwin/amd64 $ go test -count=10 -race golang…
Spotted via `linux-amd64-race` and `windows-amd64-race` builders at https://build.golang.org/?repo=golang.org%2fx%2ftools: ``` --- FAIL: TestSource (99.21s) --- FAIL: TestSource/GOPATH (56.5…