Thanks.
This .* will successfully match even if the FailedBuild field is included, right? Maybe change it to `"Elapsed":0}` if elapsed is always zero on build error, or add a `! stdout` check, or so…
(1 comment)
Is it intended that FailedBuild field is populated even under gotestjsonbuildtext=1, which is intended to make Go 1.24 behave more like Go 1.23?
One the one hand a new field should be f…
We've now set a maintenance window to be during early weekday mornings, skipping Friday. We can wait a bit to see how it goes, adjusting further if needed.
Thanks. Optional comment.
If desired, you can also set `Check` to some function that'll check for definitely-incorrect input values. E.g., if this changed to be a number, it can be something like ch…
Thanks.
Given your reply [here](https://go-review.googlesource.com/c/website/+/635615/comment/330baf43_4740666f/), you'll likely want to update it here too.
Thanks.
(minor) It it intended to use a git author email that's different from your Gerrit account's primary email in this repo, or possibly unintentional?
The comment at https://github.com/GoogleCloudPlatform/gsutil/issues/1776#issuecomment-2538018415 says that gsutil version 5.32 and above supports Python 3.12.
Cuong, please see https://go.dev/issue/24850#issuecomment-383723439, that’s where the email policy is written down. go.dev and golang.org are effectively aliases.
@danp@danp.net The Run-TryBot+1 vote still exists for rare cases when you wish to trigger a specific [legacy slowbot](https://go.dev/wiki/SlowBots#pre-luci-slowbots). In the general case, just Commit…
Thanks. FWIW, CL 635095 landed minutes ago in case you want to include it. (It's fine not to worry about it since there may always be CLs landing to the main branch.)
Checking in on the status here. Did the comment above resolve the need to make further changes, or would you still like to pursue that?
The builder appears to be missing now (https://ci.chromium.o…
(1 comment)
Thanks for clarifying. We may still want to recover panics and turn them into internal task errors for relui. The main difference here, I think, is that FakeGerrit is only for tests. If …
Thanks.
It's a bit unfortunate this increases chances of non-canonical links to dynamic content proliferating, but I suppose if it matters enough, code review and/or tests can catch that.
There was…
Thanks. Just minor commit message style suggestions.
Please change this line to match [Go commit message style](https://go.dev/wiki/CommitMessage):
```
cmd/googlegolangorg: mdd google.golang.org/ge…
(2 comments)
Thanks, done.
Thanks. Thinking more, this function can't be entirely sure what the caller will do, so I rephrased this to avoid committing to terminal/fatal, rather say this is where i…
Gorebuild involves going over the Internet to fetch bytes. Some errors
that it might encounter might be temporary, such that if the caller
were to try again after waiting a bit, it might just succeed…
As the comment at the top of the loop says, and git protocol docs¹²
confirm, the sideband byte will be 1, 2, or 3. If something else is
encountered, don't print it to stdout without any context and…
At Go tip, js/wasm programs inside a browser run into a panic during init of syscall package:
```
panic: syscall/js: call of Value.Int on undefined
goroutine 1 [running]:
syscall/js.Value.flo…
CL 606658 added a constants.Get("O_DIRECTORY").Int() call at init time,
which panics in browsers because O_DIRECTORY is undefined. It needs to
be a JavaScript number to avoid that.
Fixes #70723.
There are LUCI builders for netbsd/arm and netbsd/arm64 ports (#63698 and #63614). They're remote, so this change is something their builder owner can consider applying (CC @bsiegert).
I don't believe there are active plans to pursue a non-reverse netbsd/arm64 builder now, and a newer reverse builder for LUCI was added: https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/go…
(1 comment)
I tend to prefer to defer unlock when there's a bit more than 1-2 lines of code in between (more like [this](https://cs.opensource.google/go/x/build/+/master:devapp/server.go;l=93-94;drc…
As https://ci.chromium.org/b/8729261949578211409 showed, MailDLCL and
CreateAutoSubmitVersionCL can call CreateAutoSubmitChange at the same
time. Guard map access with a mutex.
For golang/go#70655.
…
We'll drop it from tip and the new release-branch.go1.24 branch as soon
as result_adapter is ready to handle events that contain ImportPath but
not Package fields, but that's not the case this week.
…
By now we consistently start a pre-build a week ahead of the planned
release, so we don't get to benefit from having the 'Check blocking
issues' task on the day of the release. Add a second one, that…
[CL 634041](https://go.dev/cl/634041), [CL 631336](https://go.dev/cl/631336), and [CL 626995](https://go.dev/cl/626995) took care of the start-of-freeze updates for the Go 1.24 cycle. There may still…
[CL 612555](https://go.dev/cl/612555) regenerated the list for Go 1.24. It's the same list as for Go 1.23 but without windows/arm (32-bit), and that's noted at https://go.dev/doc/go1.24#windows.
I…
(1 comment)
A quick clarification note for posterity: the policy decision is [Go issue 32102](https://go.dev/issue/32102) and applies to the golang.org/x/sys/unix package specifically, not golang.or…
Anything other "pick latest versions of all x/ repos" does need some manual intervention. You could still use updatestd, just followed by a `go get golang.org/x/net@{pseudo-version before CL 632816}`…
Thanks for improving this!
It'd probably also be fine to combine with skip_x_repos, something like 'skip_x_repos_and_hide_from_presubmit', or 'builder_not_added_yet' with a comment that explains the…
Thanks.
It'd be a proposal. It's probably fine as is for now, and we can continue to keep it as a trybot while a secondary port since it works well. The same can apply to other secondary ports when …
Also reproduces on an M1 Pro machine.
> Looking through the code some codepaths sanitize the nanoseconds before calling predictN, others don't. I'll send a fix.
I did that locally (in B.stopOrScale…
### Go version
go version devel go1.24-3ae00f5d29 Fri Dec 6 02:16:12 2024 +0000 darwin/arm64
### Output of `go env` in your module/workspace:
```shell
$ go env -changed
GOFLAGS='-ldflags=-…
Now that #61095 is nearly done, at least for the freebsd-amd64 builder, I think this should be a matter of adding the right package to [this line](https://cs.opensource.google/go/x/build/+/master:env…
The cmd/relnote test requires that all new APIs have a corresponding entry in doc/next/\*-stdlib/\*-minor. This works as intended for most APIs, but some new APIs are entirely new packages. Those are…
The Go porting policy has a section on broken ports, https://go.dev/wiki/PortingPolicy#broken-ports. The GOOS=windows GOARCH=arm (not arm64) port was marked broken in August 2024 ([CL 601777](https:/…
The TestCheckAPIFragments test in cmd/relnote looks at api/next content
and requires doc/next to have corresponding entries. So, make sure that
test is happy by starting to remove doc/next no sooner …
The generation sequence looks right. It's uncovering CL 632816 is causing golang.org/x/sys/unix to get vendored into the main Go repo, which doesn't align with a past policy decision (#32102).
(2 comments)
Oh, I noticed the builder is not yet passing on release branches for 1.23 and 1.22:
- https://ci.chromium.org/b/8729548849265746753
- https://ci.chromium.org/b/8729550591543558097
Tha…
Thanks.
Thanks for calling this out. In earlier discussion with @cherryyz@google.com (and Eli) we agreed that we generally do not need to default to making secondary port builders included in the de…
This looks good to me. Thanks.
If Michael or Sam have additional suggestions, please feel free to refine the draft further after it's moved to x/website/_content.
Thanks.
I'm not sure, but maybe using a fixed commit rather than the moving branch will work better as time passes.
```suggestion
[reactor/library](https://github.com/WebAssembly/WASI/blob/63a46f61…
If there are in-flight CLs for doc/next, it might make sense to finish
them before moving the release notes into x/website. This is something
the release coordinator may do manually, so add an automa…
We considered this freeze exception in a release meeting today. This seems to be a new API that would be safe to land in the next upcoming major Go release, Go 1.25, so that if there are unexpected i…
Thanks for the quick fix! The monthly golang.org/x tagging workflow ran into this, and the fix enabled it to keep going (https://go.googlesource.com/crypto/+/refs/tags/v0.30.0).
At Go tip, TestMultiSign fails when run without -short flag, including on first class ports like linux/amd64:
```
=== RUN TestMultiSign
clearsign_test.go:155: cannot create key: rsa: gener…
Added okay-after-rc1 since RC 1 is scheduled for [next week](https://go.dev/s/release#june--december-week-2-release-candidate-1-issued) and 2024b is still the latest available version. (CC @mknyszek.…