Dmitri Shuralyov

dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue for plan9-amd64 builder41s

Marking as resolved (per discussion in other thread). There are still some failures on https://ci.chromium.org/ui/p/golang/builders/ci/gotip-plan9-amd64, but that can be tracked in a followup to #636…

dmitshur reviewed +2 on github.com/andygrunwald/go-gerrit: Raise minimum Go version in go.mod from 1.16 to 1.263h

LGTM. Thanks.

dmitshur commented on github.com/go-gl/glfw: consider adding release tags4h

Made the [second pre-release tag](https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw@v0.1.0-pre.2) to include some of the follow up fixes to v3.4/glfw. If some time passes and there aren't problems r…

dmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: Wayland scaled display issue4h

Closing as resolved in v3.4.

dmitshur fixed an issue github.com/go-gl/glfw: Wayland scaled display issue4h

Closing as resolved in v3.4.

dmitshur closed a change github.com/go-gl/glfw/glfw/v3.3: fix build warnings4h

Thanks for preparing this. Closing since this change needs to happen upstream. Note that by now v3.4 has superseded v3.3, so it may make sense to redirect our attention towards the latest version in …

dmitshur commented on github.com/go-gl/glfw/glfw/v3.3: fix build warnings4h

Thanks for preparing this. Closing since this change needs to happen upstream. Note that by now v3.4 has superseded v3.3, so it may make sense to redirect our attention towards the latest version in …

dmitshur closed a change github.com/go-gl/glfw/glfw/v3.3: fix build warnings5h

dmitshur fixed an issue github.com/go-gl/glfw: Vendoring is broken in v3.45h

dmitshur pushed to master in github.com/go-gl/glfw5h

8fa725040a18feef1098d802d2108effa73ea652 → d41da22a9587f777098f96d37014f6cdd35d1afb

dmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: vendoring is broken5h

dmitshur merged a change github.com/go-gl/glfw: Fix preserving wayland headers in vendor5h

dmitshur reviewed +2 on github.com/go-gl/glfw: Fix preserving wayland headers in vendor5h

Thanks.

dmitshur reviewed +2 on golang.org/x/website/_content/tour: clarify wording about loop init statement6h

Thanks.

dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue for plan9-amd64 builder6h

dmitshur commented on golang.org/x/build/main.star: remove known issue for plan9-amd64 builder6h

Thanks very much, and congrats on reaching this point. Please rebase and regenerate this.

dmitshur commented on github.com/andygrunwald/go-gerrit: Raise minimum Go version in go.mod from 1.16 to 1.266h

One more note. In the PR description it was mentioned that this change was done with `go mod edit -go=1.26`. In most cases it should be a better experience to manage the `go` directive with the `go g…

dmitshur commented on github.com/andygrunwald/go-gerrit: Raise minimum Go version in go.mod from 1.16 to 1.266h

Thanks, this generally looks good. I left two minor comments. I suggest picking `1.26.0` for the `go` directive here. Prior to Go 1.21, major releases didn't have a ".0" at the end. See https://go.…

dmitshur commented on github.com/andygrunwald/go-gerrit: Support Go 1.27 and put staticcheck under Renovate management1d

Sounds good, thanks. If someone wishes to use an older version of go-gerrit before its `go` directive increased for a while longer, even if you don't tag, they could still use the corresponding ps…

dmitshur commented on github.com/andygrunwald/go-gerrit: Support Go 1.27 and put staticcheck under Renovate management1d

> Go 1.27.0 is the current upstream release, so the supported window moves to 1.27 + 1.26 per the [Go Release Policy](https://go.dev/doc/devel/release.html#policy) the README commits to. [...] The `g…

dmitshur commented on golang.org/x/website/_content/tour: clarify wording about loop init statement1d

(2 comments) This isn't quite right. According to the spec, the optional [init statement](https://go.dev/ref/spec#InitStmt) is a [simple statement](https://go.dev/ref/spec#SimpleStmt), which in addi…

dmitshur commented on cmd/go: report an implicit go directive as upgraded from 1.162d

(1 comment) This parent commit is quite old and explains why some unrelated (since fixed) tests are failing. Rebasing should help with that.

dmitshur commented on encoding/json: use embedded terminology2d

(1 comment) At least in Go 1 package documentation it was a documented bug that gave the heads up that the behavior may change in a future version: https://pkg.go.dev/encoding/json@go1#pkg-note-BUG

dmitshur closed an issue cmd/fix: embedlit: drops first field incorrectly2d

dmitshur reviewed +2 on golang.org/x/vscode-go/extension/test/gopls: fix test after go1.27 upgrade2d

dmitshur closed an issue golang.org/x/tools/internal/invoke/gocommand: tests are timing out2d

dmitshur closed an issue golang.org/x/tools/cmd/goimports: recent commit using 700% of CPU2d

dmitshur closed an issue time: optimize weekday calculation2d

dmitshur fixed an issue golang.org/x/build: LUCI swarming bot works with Python 3.13 but not Python 3.14 due to reliance on removed pkgutil.get_loader2d

Closing this since https://issues.chromium.org/issues/536346612 is resolved now. Please feel free to try it again with Python 3.14.

dmitshur fixed an issue golang.org/x/build: LUCI swarming bot works with Python 3.13 but not Python 3.14 due to reliance on removed pkgutil.get_loader2d

Closing this since https://issues.chromium.org/issues/536346612 is resolved now. Please feel free to try it again with Python 3.14.

dmitshur reviewed +2 on golang.org/x/vscode-go/extension/test/gopls: fix test after go1.27 upgrade3d

Thanks. Consider including a mention of the go command issue, since it's related: ``` Updates golang/go#37300. ```

dmitshur reviewed +2 on golang.org/x/build/main.star: add c2s16 GOAMD64=v3 perf builder3d

How does this compare with CL 812781? This looks good too, just please coordinate with Michael. Thanks. For #80818? Or is there another tracking issue for these perf builders? See https://go-revie…

dmitshur commented on golang.org/x/website/cmd/golangorg: update App Engine runtime to Go 1.273d

Thanks.

dmitshur closed an issue golang.org/x/net/http2/hpack: "id (106) <= evictCount (117)" panic in headerFieldTable.idToIndex3d

dmitshur reviewed +2 on go.dev/wiki/DashboardBuilders: add notes on Python 3 version3d

Thanks. Yes, this topic is also touched on in https://go.dev/wiki/DashboardBuilders#security-notes.

dmitshur reviewed +2 on golang.org/x/website/_content/tour: describe any3d

Thanks.

dmitshur reviewed +2 on golang.org/x/mobile/internal/binres: use %v to format pool string data3d

Thanks. I don't mind seeing a note like this in a code review comment, but I'm not sure about including it in the commit message itself. Perhaps this is still a topic being discussed and I may chang…

dmitshur commented on golang.org/x/mobile/...: update the go directive to 1.26.03d

(4 comments) Consider making this commit message much shorter, focusing on the problem being surfaced by the Go 1.26 vet check (#72850). For example, compare with similar CLs for x/sys and x/exp: CL…

dmitshur commented on golang.org/x/exp/errors/fmt: use %d formatting verb for int3d

Thanks.

dmitshur opened a change go.dev/wiki/DashboardBuilders: add notes on Python 3 version3d

As suggested at https://go.dev/issue/80220#issuecomment-5350598333, it can be helpful to say a few more words about the exact Python 3 version that should be used. Also, an optional reference, point …

dmitshur commented on golang.org/x/build: LUCI swarming bot works with Python 3.13 but not Python 3.14 due to reliance on removed pkgutil.get_loader3d

It's not very visible on the issue, but as of today it does have a pending code change (https://crrev.com/c/8265616).

dmitshur commented on golang.org/dl/internal/version: add explanatory comments to runGo3d

Thanks.

dmitshur commented on golang.org/dl/internal/version: add explanatory comments to runGo3d

CL 763260 moved some of this code; rebased in PS 2.

dmitshur opened a change golang.org/x/exp/errors/fmt: use %d formatting verb for int3d

It's caught by Go 1.26's vet check that the format %q here is given a wrong type int. The formatting verb %d is appropriate.

dmitshur commented on golang.org/x/sys/windows: pass rune to %q formatting verb3d

Unfortunate timing of my reply with Commit-Queue... Bypassing trybots since they did pass on patchset 1.

dmitshur commented on golang.org/x/sys/windows: pass rune to %q formatting verb3d

(1 comment)

dmitshur opened a change golang.org/x/sys/windows: pass rune to %q formatting verb3d

It's caught by Go 1.26's vet check that the format %q here is given a wrong type uint16. Convert it to a rune instead.

dmitshur commented on golang.org/x/mobile/...: upgrade go directive to at least 1.26.0 [generated]3d

Thank you! Yes, proposal #69095 was about having a policy and automation to maintain the minimum value of the `go` directive in golang.org/x modules, and this CL is a part of that, but it's possible…

dmitshur fixed an issue cmd/internal/testdir:1_10: Test/codegen/arithmetic.go failures [consistent failure]3d

Closed by merging [CL 815220](https://go.dev/cl/815220) (commit 983064c1b5bd8e0ad581607aa140167c698cd4eb) to release-branch.go1.25.

dmitshur closed an issue cmd/compile: ppc64 `MADDLD` lowering rules depend on the values schedule [1.25 backport]3d