Activity
Yesterday
dmitshur commented on golang.org/x/build/internal/task: add Buffer Poster client5h
Thanks. This seems very reasonable. I left some high level comments, but they're all optional.
The implementation of NewBufferClient and its Post/PostTweet methods seems reasonable. It'll be helpful…dmitshur reviewed +2 on golang.org/x/build/internal/secret: add BufferCredentials for Buffer API5h
Thanks.
I think both approaches work well in this particular instance, so either way is okay. Keeping it separate makes it a bit easier to focus on only credential change.
Noting that it could also…dmitshur commented on golang.org/x/net/http2: TestAPITransportClientConnPending fails at tip after "fix/simplify tracking of pending requests"5h
Added Soon since this failure blocks progress on monthly golang.org/x repository tagging.dmitshur fixed an issue cmd/compile/internal/test: TestMergeLocalsIntegration failures [consistent failure]5h
This was already fixed at tip, but it got reopened due to failures on release-branch.go1.26. That's been fixed via #81152, and there are no more failures since August 27. Closing again.dmitshur commented on golang.org/x/build/main.star: remove protobuf repository6h
Thanks.dmitshur commented on golang.org/x/build/cmd/gitmirror: update google-cloud-cli package name6h
Friendly ping. Thanks.dmitshur commented on golang.org/x/build/repos: disable protobuf mirroring to GitHub6h
(1 comment)
Also, it should be safe to stop the LUCI builders that operate on the protobuf Gerrit repo (i.e., https://ci.chromium.org/p/golang/g/z-protobuf-gotip/console) now that there's not going …dmitshur opened a change golang.org/x/build/main.star: remove protobuf repository6h
The protobuf repo is no longer being developed and tested in Gerrit
(also see CL 862081 and CL 854910), so remove the LUCI builders and
extra configuration for that Gerrit repository.
For b/57011971…dmitshur commented on cmd/api: windows/arm64 check is missing1d
Also see #53205.This Week
dmitshur reviewed +2 on .github: ask how issues are discovered1d
Thanks.
Pick one of the two similar verbs?dmitshur reviewed +2 on golang.org/x/net/idna: update form x/text, avoid excesive work in Punycode encoding1d
Thanks. +2 since this is generated from existing code and I can reproduce, but feel free to wait for Neal to also look if needed. (Although I'm seeing Go 1.28's restriction on converting integer type…dmitshur commented on golang.org/x/net/idna: Punycode encoding happens after length checks, enabling excessive HTTP client CPU usage1d
The next step here to make forward progress is to create backport issues, right?
@gopherbot Please create backport issues for this PUBLIC-track security fix.dmitshur reopened an issue golang.org/x/net/http2: TestAPITransportClientConnPending fails at tip after "fix/simplify tracking of pending requests"1d
Reopening because the test still fails with the same output at tip after [CL 860083](https://go.dev/cl/860083).
(That CL's last trybot run happened on Nov 6, which is 3 days before [CL 858641](https…dmitshur commented on golang.org/x/net/http2: TestAPITransportClientConnPending fails at tip after "fix/simplify tracking of pending requests"1d
Reopening because the test still fails with the same output at tip after [CL 860083](https://go.dev/cl/860083).
(That CL's last trybot run happened on Nov 6, which is 3 days before [CL 858641](https…dmitshur commented on golang.org/x/build/cmd/relui: define a govulncheck-action tagging workflow1d
By now CL 750120 added a workflow, CL 799320 fixed permissions, and an instance of the workflow successfully created a [v1.1.0 tag](https://go.googlesource.com/govulncheck-action/+/refs/tags/v1.1.0).…dmitshur reviewed +2 on golang.org/x/build/internal/task: remove AutoSubmit+12d
(1 comment)
Checking, now that the rest of the change has been tested, do we still need to drop Auto-Submit+1 for public Gerrit CL submission? As far as I can tell, it should work as normal, but let…dmitshur commented on golang.org/x/build/internal/task: use Topics-based submission2d
Thanks.
I read this over more and this generally looks good. We got some good signal from trying it out.
I left some more comments, but I expect this can be submitted after they're resolved.
Now t…dmitshur commented on golang.org/x/net/go.mod: update golang.org/x dependencies2d
Pre-existing failure, filed #83005 for it.dmitshur commented on net/http/internal/http2: fix/simplify tracking of pending requests2d
This change seems to cause x/net/http2.TestAPITransportClientConnPending test to fail with:
```
=== RUN TestAPITransportClientConnPending
transport_api_test.go:1220: ClientConnState.StreamsAct…dmitshur opened an issue golang.org/x/net/http2: TestAPITransportClientConnPending fails at tip after "fix/simplify tracking of pending requests"2d
At tip, starting with [CL 858641](https://go.dev/cl/858641):
```
=== RUN TestAPITransportClientConnPending
transport_api_test.go:1220: ClientConnState.StreamsActive = 2, want 1
transport_a…dmitshur commented on golang.org/x/crypto/ssh/test: connect to sshd over a loopback TCP connection2d
Also thanks for fixing darwin longtest builders!dmitshur commented on encoding/json: [release-branch.go1.27] fix UnsupportedValueError.Value for cycles2d
Yes, that's because this CL is on a release branch, as covered at https://go.dev/wiki/MinorReleases#making-cherry-pick-cls:
> [...] The code review process is otherwise the same as regular CLs. Perm…dmitshur commented on honnef.co/go/tools/SA4023 panic: index out of range — objectpath method indices desync when a type has a generic method3d
Go 1.27.4 came out today with that fix, golang/go#82106. (It ended up not being Go 1.27.3 exactly because that version was taken up by last month's out-of-cycle release with an urgent track security …dmitshur commented on golang.org/x/build/cmd/makemac: switch darwin-arm64-14 to 8-core VMs3d
(1 comment)
Not seeing done as of PS 3.dmitshur commented on golang.org/x/build/cmd/makemac: switch darwin-arm64-14 to 8-core VMs3d
(1 comment)
Thanks, no need to make a change (unless you see a reason to), I was mostly interested in learning your reason for their inclusion.dmitshur commented on encoding/json: [release-branch.go1.27] fix Indent with a non-space prefix or indent3d
linux-386-longtest failure is unrelated and being fixed by CL 856161. Bypassing.dmitshur commented on encoding/json: [release-branch.go1.27] fix UnsupportedValueError.Value for cycles3d
linux-386-longtest failure is unrelated and being fixed by CL 856161. Bypassing.dmitshur reviewed +2 on golang.org/x/build/cmd/makemac: switch darwin-arm64-14 to 8-core VMs3d
Thanks. Seems good to try.
Please associate this change with some tracking issue, either an existing one or a new one.
If V1_MEDIUM_VM is the the default, what was the motivation to explicitly set …dmitshur reviewed +2 on golang.org/x/build/main.star: add js-wasm-stackswitch builder3d
Thanks.dmitshur fixed an issue cmd/compile: staticcheck still crashes with generic methods on Go 1.27.23d
It doesn't seem like there's anything left to do for Go 1.28 (this issue's milestone), so closing.
Issue #82106 tracked backporting the fix to Go 1.27.4, which was [released](https://go.dev/doc/deve…dmitshur commented on cmd/internal/fuzztest: [release-branch.go1.26] limit GOMAXPROCS for 386 subtests3d
testcarchive.TestPreemption failures are unrelated and preexisting. Bypassing.dmitshur reviewed +2 on golang.org/x/website/_content/blog/goroutine-leak-profiles: fix example; update SVG bg3d
Thanks.dmitshur commented on golang.org/x/build/repos: disable protobuf mirroring to GitHub3d
Sounds good, I'll get this change submitted and deployed today.
Thanks.
@shaod@google.com Just checking, have you thought about what to do with the protobuf repo on Gerrit? Do you plan to mark it a…dmitshur commented on cmd/go: validate split -Wl, next-arg flags and linker script targets3d
gotip-linux-arm64-boringcrypto failures look to be due hitting 1 minute timeouts, doesn't seem related to this change, and the same builder passed on another try in https://ci.chromium.org/b/86654932…dmitshur commented on spec: type inferred composite literals3d
This still needs a release note, right? Not seeing it at https://tip.golang.org/doc/go1.28. Filed a separate release-blocking issue #82973 for that.dmitshur opened an issue doc: add a release note for "type inferred composite literals"3d
This is notable enough to need a release note. Factored out of #12854 for tracking, since this needs to block RC 1.
CC @griesemer, @mrkfrmn.dmitshur opened a change golang.org/x/website/cmd/adminapp: remove obsolete build constraint4d
Back when this constraint was added, the go directive in go.mod was
on 1.24.0, so '//go:build go1.25' was effectively raising the version
(and avoiding a build error that would happen with Go 1.24).
…dmitshur commented on golang.org/x/website/cmd/googlegolangorg: point google.golang.org/protobuf at GitHub4d
This change is live now. Before:
```
$ curl -s 'https://google.golang.org/protobuf?go-get=1' | grep go-import
<meta name="go-import" content="google.golang.org/protobuf git https://go.googlesourc…dmitshur commented on golang.org/x/crypto/ssh/agent: use a short socket path for ssh-agent in tests4d
Thanks for looking into those failures.
That error sounds like a problem on Gerrit's end, I would suggest to keep trying with some backoff and see if it gets better.dmitshur reviewed +2 on golang.org/x/crypto/ssh/agent: use a short socket path for ssh-agent in tests4d
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/googlegolangorg: point google.golang.org/protobuf at GitHub4d
Thanks.dmitshur commented on golang.org/x/pkgsite-metrics/cmd: update to go1.27.34d
The issue being referenced is likely #72774.
Just noting that 'golang:1.27' already referred to Go 1.27.3, based on https://hub.docker.com/_/golang#shared-tags and comparing image digests [here](htt…dmitshur reviewed +2 on golang.org/x/build/main.star: increase number of concurrent perf builders to 104d
Thanks.dmitshur commented on golang.org/x/crypto/ssh/agent: TestAgentExtensions, TestSetupForwardAgent, TestLockOpenSSHAgent failures with "too long for Unix domain socket" [consistent failure]4d
CC @drakkan, @golang/darwin.
Also added Soon label since this consistent failure is on a first-class port, and so it blocks monthly golang.org/x tagging. (CC @prattmic.)dmitshur closed an issue golang.org/x/crypto/ssh/agent: TestLockOpenSSHAgent failures [consistent failure]4d
Merged into #82712.dmitshur commented on golang.org/x/crypto/ssh/agent: TestLockOpenSSHAgent failures [consistent failure]4d
Merged into #82712.dmitshur closed an issue golang.org/x/crypto/ssh/agent: TestSetupForwardAgent failures [consistent failure]4d
Merged into #82712.dmitshur commented on golang.org/x/crypto/ssh/agent: TestSetupForwardAgent failures [consistent failure]4d
Merged into #82712.dmitshur commented on crypto/x509: reject trailing data after SEC 1 EC private keys4d
(1 comment)
I'm used to most Go code checking the error return value before other fields, so I'd expect checking len(rest) before err would be done if there was a good reason to (ideally with a comm…dmitshur reviewed +2 on golang.org/x/build/main.star: remove docker builders4d
Thanks.
Maybe update the mentions here too:
```suggestion
PKGSITE_SCREENTEST_NOTIFIER = luci.notifier(
name = "pkgsite-screentest-ci",
on_new_status = ["FAILURE"],
notify_emails = PKGSI…Last Week
dmitshur starred github.com/jarmitage99/OpenDE1w
Earlier
dmitshur fixed an issue net/http: backport fix to protect against middleware changing server response body [1.26 backport]2w
Closed by merging [CL 843365](https://go.dev/cl/843365) (commit bdd49b5785c73bec7341905e101e7ff92dd4752c) and [CL 843566](https://go.dev/cl/843566) (commit 1216ba432cef4ef3c0e11e65c6ecb95c158f70ed) t…dmitshur commented on cmd/compile: ICE on 386 when inlining nested bit rotations (Int64Lo not lowered) [1.26 backport]2w
The 1.27 counterpart (issue #81706) is in, any reason not to include this in the same month's 1.26 release as well? See https://github.com/golang/go/issues/34536#issuecomment-572188389.dmitshur commented on golang.org/x/build: recent Linux kernel builder2w
https://crrev.com/i/8198148 landed some time ago, and as far as I can tell it seemed to work okay? At least I didn't see too many false positive signals from it, but not sure how many true positives …dmitshur commented on cmd/compile: staticcheck still crashes with generic methods on Go 1.27.2 [1.27 backport]2w
Tentatively added release-blocker given the discussion in #82105 about wanting this fix to be made available sooner, and this seems close ([CL 847627](https://go.dev/cl/847627) was submitted on Oct 1…dmitshur commented on golang.org/x/net/html: quadratic complexity when coalescing text nodes2w
> I will re-assign this to the Go1.28 milestone.
@thatnealpatel This package isn't vendored in the main Go repo, and there doesn't seem to be anything tied to the Go 1.28 release here. Okay to move …dmitshur closed an issue encoding/json/v2: possibly clarify retention prohibitions in documentation [1.26 backport]2w
dmitshur opened an issue golang.org/x/build: try out CL submission via queue in golang.org/x/build Gerrit repo2w
We're building a prototype of CL submission via queue, initially limited in scope to cover the golang.org/x/build repository, and this is a tracking issue for that. See issue #12482 for motivation an…dmitshur commented on golang.org/x/build: upgrade freebsd builders to 14.5 and 15.13w
CC @golang/freebsd, @golang/release.dmitshur commented on golang.org/x/build: add OpenBSD 8.0 builder3w
CC @golang/openbsd, @golang/release.dmitshur fixed an issue golang.org/x/build/internal/installer/darwinpkg: unclear purpose and effect of "Fixing permissions" step during postinstall3w
The "Fixing permissions" step removal in Go 1.27 didn't seem to uncover anything unexpected, so closing this as done.
<details><summary>Confirmation of removal details</summary>
```shell
$ pkgutil …dmitshur commented on golang.org/x/build: add GOAMD64=v3 perf builders3w
There were GOAMD64=v3 perf builders added above, and they're running. It's also added to the perf dashboard.
@matloob Should this be closed as done or was there something specific still left to do h…dmitshur commented on dmitri.shuralyov.com/website/gido: Support proposals2mo
Proposals are already supported, in the sense they're listed as issues at https://goissues.org/ with a "Proposal" label.
See [prefixtitle.ParseIssue](https://pkg.go.dev/dmitri.shuralyov.com/go/prefi…dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time2y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability4y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change4ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes5y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y