Activity

Today
> The logic around `misc-compile` builders is unfortunately kind of hairy. There's every indication that it should be already running for x/ repo trybots (albeit failing by trying to run `buildall.ba…
Makes sense and seems reasonable to me. Thanks.
I'm fairly confident this will work to resolve the immediate issue. (And if not, we'll learn why not by trying.) Thanks. As I understand, this Printf ends up being fairly load-bearing: it indirectl…
CC @golang/js, @golang/security.
Thanks.
Yesterday
Thanks for working on this, this generally makes sense and looks right to me. I left 2 optional thoughts/comments, will give other reviewers a chance to look too. As an optional idea, you could comb…
Looks good to me; leaving to Matt.
dmitshur reviewed +2 on cmd/dist: keep flag list sorted1d
Thanks. (I didn't notice the flags were sorted when adding -force in CL 458515; will check for that in the future.)
CC @golang/release.
It also increases consistency with make.bash, etc. Thanks.
Thanks.
Looks good to me, just giving Matt a chance to also look. Thanks.
Adding Hold on this one until the "all.bash is passing with Node.js 18" part is done.
Thanks.
dmitshur reviewed +2 on net/http: disable fetch on NodeJS1d
Thanks.
Thanks for investigating this and figuring out the problem. > Would love **@​neelance**'s thoughts on a NodeJS based socket syscall interface, I assume the reason we didn't introduce one origina…
dmitshur reviewed +2 on misc/wasm: use NodeJS crypto library1d
Thanks. Johan, please take a look at CL 463915. Once it's reviewed, I can redeploy coordinator is redeployed and it'll become possible to get passing trybots here. (We can't really rely on TryBot-By…
(1 comment) I understand you're aware the current plan is to require at least Windows 10 per latest status of #57004 (so it's indeed true that it'll be greater than Windows 7 for purposes of this CL…
@qmuntal Do you know the frequency of [windowsZones.xml](https://github.com/unicode-org/cldr/blob/main/common/supplemental/) (the source for zoneinfo_abbrs_windows.go) changes? If it's tied to the s…
This Week
Last Week
dmitshur commented on time: update windows zoneinfo_abbrs3d
(1 comment) Perhaps change this to "Fixes" since that issue is in Go 1.21 milestone, and it seems there's nothing more to do for it. Also fine to close the issue manually too.
Here's the event log from the [aforementioned](https://github.com/golang/go/issues/54679#issuecomment-1407113776) 20-minute TryBot run, for reference: <details><br> ``` builder: linux-arm-aw…
The js/wasm port maintainers are getting ready to start landing changes for Go 1.21 that replace Node.js 14 support with Node.js 18 support. Disable the js-wasm TryBot on tip so that work can start t…
Thanks. Mentioning the issue in a comment on this line could be helpful, but it’s also fine as is since context can be found via git blame.
Similar to #58028, for Go 1.21 we should update the macOS minimum version requirement from [10.13](https://github.com/golang/build/blob/39ddd66f41da17065d8f700e8e64e006dccf6032/internal/task/buildrel…
(3 comments) (nit) Delete the '//' characters here. This can be a blank line instead. As mentioned at https://go.dev/doc/comment, every exported identifier should have a doc comment. (nit) Here to…
Thanks. LGTM with an inline comment suggesting to handle errors closer to call site for you to consider. (trivial) Both `attempt++` and `attempt += 1` have the same behavior here. I'm curious why th…
Thanks, this generally looks good and makes sense. See some minor comments. (nit) Maybe just "Wait for advisory TryBots", since approving failures is only needed when failures happen, which hopefull…
(1 comment) I believe this already has the default retries, since it doesn't opt-out via ctx. DisableRetries, so it doesn't need a second layer of retries. Is this comment left behind by accident or…
(That's my current understanding too. Replied on the issue.)
In CL 463579, @heschi commented: > For my understanding, is there some particular difficulty setting up a windows-386-2016 builder? This one was just a GOARCH setting on top of the amd64 OS, right…
That builder just needs to be updated not to test tip (where 1.21 development is currently happening) per accepted proposal #57003. I've sent CL 463578 for that.
The staging section was commented out because that environment is not supported. It's still visible when viewing the .md file in its raw form and has proven to cause confusion. Since we can easily ge…
I agree we should do that. Filed #58008 for tracking it.
Go 1.20 will be the last Go release with support for some OS versions, as documented at https://tip.golang.org/doc/go1.20#ports. The corresponding builders should be updated not to to test commits at…
The latest builder for the windows/386 port at this time is windows-386-2012 (Windows 8/8.1). That builder will be going away as part of #57004. As long as windows/386 is one of the first class por…
(1 comment) Is it relevant that one of the lines has -"ORN", the other has -ORN" (missing double quote)? This seems to be the only instance in this file.
(1 comment) AUTHORS files aren't included in golang.org/x repos as of mid-2022 (see https://go-review.git.corp.google.com/q/topic:%22noac%22).
dmitshur created repository in github.com/golang/pkgsite-metrics6d
Code to serve pkg.go.dev/metrics [mirror]
(1 comment) (nit) In almost all .go files in golang.org/x repos, the copyright header comment is separated from build constraints with a blank line. x/sys/unix/endian_{big,little}.go are the few rar…
Thanks. Consider also adding "Fixes golang/go#52150." since it seems x/tools tests are fixed for GOEXPERIMENT=unified and there's nothing more to do for it.
Makes sense, thanks.
@mdempsky Just confirming: is it not useful on release-branch.go1.19 because it doesn't support GOEXPERIMENT=nounified, only 1.20 does?
dmitshur opened a change test: break helloworld.go test case1w
DO NOT SUBMIT: This is a test to see how different platforms report a failing test case.
Also CC @Pryz, @evanphx who've recently joined as Wasm maintainers in #57968. (Thanks!) Investigating and resolving this issue will help unblock progress on #57614.
DO NOT SUBMIT: This is currently a WIP prototype. For #37486. Fixes #56844.
Thanks. > the images are downloaded twice That's a good point. Maybe combining all desired aspects (3-way theme selector support, repetition-free syntax, deferred image variant downloading) will be…
dmitshur starred github.com/zserge/fenster1w
Thanks. Consider adding ^ and $ to start/end of the regexp, since it needs to match an entire line. (style nit) Since this is checking the error from the immediate WalkDir call above (line 41), the…
dmitshur commented on all: implement wasmimport directive1w
The tree is open for Go 1.21 development as of Thursday (see #57736 and https://groups.google.com/g/golang-dev/c/09IwUs7cxXA/m/c2jyIhECBQAJ).
Earlier
I've started working on this more actively recently and made enough progress to post an update. I think I have a good idea for the general implementation plan here: as expected, it'll be to migrate t…
(1 comment) (trivial nit) Two blank lines here, as opposed to one like between other sections.
With the changes above, I believe this is complete. Closing. Please comment if I missed something. (For now, only the incomplete linux/sparc64 port was marked as broken. If some approvers believe …
dmitshur closed an issue cmd/dist: add support for broken ports1w
Thanks. Please shorten the text in the PR description to "Fixes golang/go#57585", rather than the URL, to be consistent with the convention documented at https://go.dev/doc/contribute#ref_issues.
The Windows ARM64 builders on Azure have replaced the Windows ARM64 builders on AWS by now. Remove unused environment configuration; we can bring it back or look it up in history if needed. Updates …
(CL 454118 fixed that test failure, but isn't currently included on the internal-branch.go1.20-vendor branch.) Since this CL isn't on the main branch, should it have a "[internal-branch.go1.20-vendo…
Thanks. (nit) Perhaps update to {src,lib} to be more precise in this log message. Also, maybe either remove the blank lines on lines 46 and 51 since the entire block is being timed, or move the ove…
(1 comment) One other idea: you could consider setting this field to {1, 20} for this builder. Its effect will be limited, but may be better than nothing.
Is there more context you can share? Did this happen on some CLs to motivate this? This change doesn't achieve the effect stated in the commit message, and I'm not sure if there's a supported way to…
dmitshur starred github.com/OpenSAGE/OpenSAGE2w
dmitshur starred github.com/baldurk/renderdoc2w
Test done, this CL is no longer needed.
We're turning up Macs in a network environment that clashes with this test. I don't think it's critical to get it working, so skip it. For #49149. DO NOT SUBMIT: This is a test.
This part can land during the freeze because it's in x/build. Doing that to reduce chance of conflicts arising.
Thanks Joel. To me, disabling (or removing, really) 7.1 builders seems fine, and that would resolve #57585. I'll let OpenBSD port owners follow up as you prefer. Please file a new issue for anything …
This was reverted in #57689 and therefore isn't included in Go 1.18.10. Removing CherryPickApproved so it doesn't show up in the list of issues linked at https://go.dev/doc/devel/release#go1.18.10.
This was reverted in #57690 and therefore isn't included in Go 1.19.5. Removing CherryPickApproved so it doesn't show up in the list of issues linked at https://go.dev/doc/devel/release#go1.19.5.
dmitshur edited the wiki3w
Closing until I see evidence this would be at all useful. Can be trivially reopened if so.
Sounds good, closing since I haven't seen reports of this in a long while, can reopen or file another issue if this comes up again. From looking at the initial report, there's also a chance that t…
go-gl/glfw generally follows the GLFW C API quite closely, but it's a Go package with an API that's meant to be more Go-like and friendly. As such, GLFW function calls that can fail return multiple v…
> unless we're planning to refresh the `x` dependencies one more time before the final release. (@golang/release can confirm whether that is the case?) We create internal vendor branches for x repos…
(1 comment) Sounds good, thanks. Done in PS 3. (I tried to avoid phrasing that could discourage people from just running `go generate ..` in this directory; happy to tweak it further if desired.)
Before: ``` ##### Test execution environment. # GOARCH: wasm # CPU: # GOOS: js # OS Version: UNKNOWN: error determining OS version: unimplemented ``` After: ``` ##### Test execution environment. …
TRY=js-wasm
TRY=js-wasm, js-wasm-node18
Seeing the Node.js version that was used during a particular test run should be helpful during the upcoming migration from Node.js 14 to 18. Add minimal support for that. For golang/go#57614.
TestFailure in golang.org/x/exp/constraints will need to be updated in some way after this change; filed #57615 for it.
[CL 460396](https://go.dev/cl/460396) improved error messages for constraint errors. It seems TestFailure in x/exp/constraints currently depends on the old text containing the old "implements" word, …
One minor comment, otherwise this looks good for after the tree reopens and TryBots are made to pass (one way or another). There is one thing related to TryBots that's probably worth considering. I …
As I understand, the fix suggested in https://github.com/golang/go/issues/56860#issuecomment-1321274898 (and currently implemented in [CL 455415](https://go.dev/cl/455415)) intentionally drops compat…
The js/wasm port is compatible with Node.js 14 but not Node.js 18, and we're in the middle of a freeze so it's too late to make changes now. Target the new builder for Go 1.21 and newer, and replace …
The builder seems to be working okay, but we can't switch fully to it yet. Filed an umbrella tracking port for updating js/wasm to support Node.js 18, and will close this issue since the builder pa…