Activity
Today
dmitshur opened a change cmd/internal/moddeps: [release-branch.go1.26] restore tests13m
By now PRIVATE-track security fixes involving a vendored/bundled package
have been released, and these tests can be made to run again as before.
[git-generate]
updatestd -goroot=$(pwd) -branch=inter…dmitshur commented on encoding/json: UnsupportedValueError.Value is invalid for cycles in Go 1.2731m
CC @dsnet, @bradfitz, @mvdan.dmitshur opened an issue all: end support for macOS 13 in Go 1.2940m
### Proposal Details
Apple continues a yearly major macOS release cadence, and the last accepted proposal to drop the very oldest macOS version was #75836, a year ago. Since neither the macOS nor Go…dmitshur reviewed +2 on golang.org/x/build/...: improve documentation for security releasing1h
(1 comment)
Thanks for clarifying this.dmitshur commented on golang.org/x/build/internal/task: make 'Publish changes' more fault tolerant1h
Thanks. See inline comment.
I think this change was a good way to unblock today's release from proceeding, but maybe we don't need it longer term? After fixing the submit type, presumably there shou…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lint trusted DeploymentMap CLs against their manifest2h
Thanks.dmitshur commented on golang.org/x/build/internal/relui: lint manually deployed CL descriptions2h
(1 comment)
I just noticed this TODO - perhaps the code below addresses it.dmitshur reviewed +2 on golang.org/x/build/internal/task: ignore PUBLIC track issues during preflight checks2h
Thanks.dmitshur commented on net/http/internal/http2: avoid excessive work on initial window changes2h
The failing gotip-linux-amd64-boringcrypto trybot failed in the runtime package with "fatal error: gp.xRegState.p != nil on async preempt". This CL is only touching net/http, so it doesn't seem relat…dmitshur opened a change net/http: limit the size of range headers parsed in ServeContent3h
Set a limit on the number of ranges in a Range header,
avoiding excessive allocations/CPU when parsing a header
containing a large number of small ranges.
The limit is controlled by GODEBUG=httpserv…dmitshur reviewed +2 on golang.org/x/build/internal/relui: use time.Tick directly4h
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: improve documentation for security releasing4h
Thanks.
Asking a few questions to improve my understanding of what this refers to.
What is an example of confusion? Is an example of that when a security fix cannot be automatically cherry-picked f…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lint manually deployed CL descriptions4h
Thanks.dmitshur reviewed +2 on golang.org/x/website/internal/gitfs: require caller to pass http.Client4h
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: make HTTPClient required4h
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: add documentation, better nil semantics4h
Thanks.
This part of the method documentation is being made obsolete by the implementation change below.dmitshur commented on golang.org/x/website/internal/history: document Go 1.27.2 and Go 1.26.95h
Thanks.dmitshur opened a change golang.org/x/website/internal/history: document Go 1.27.2 and Go 1.26.96h
dmitshur commented on cmd/go: go get go can write a language version as the toolchain line7h
CC @matloob.Yesterday
dmitshur commented on net/http: concurrent response body Read and Close can deadlock with automatic draining in Go 1.27 [1.27 backport]1d
Moved Critical label to the upstream issue.dmitshur commented on net/http: readLoop reads Response.ContentLength after Body.Close returns [1.27 backport]1d
Moved Critical label to the upstream issue.dmitshur commented on net/http: Response.Body.Close returns the earlier Read error after a non-EOF Read failure [1.27 backport]1d
Moved Critical label to the upstream issue.dmitshur commented on net/http: Response.Trailer race due to response body draining [1.27 backport]1d
Moved Critical label to the upstream issue.dmitshur reviewed +2 on golang.org/x/build/main.star: switch gotip-linux-amd64_n4dh32 to Debian 11, in worker pool1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder1d
Thanks.
Note for next time, since this isn't the main repo, this generally needs to include the 'golang/go' prefix.
```suggestion
For golang/go#82017
```
It's not a big deal this time, and the lin…This Week
dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder1d
Thanks.
You'd probably want to set a known issue for this experimental builder type to start out with, right?
The commit message says the intent is to add a postsubmit builder, but it's currently b…dmitshur commented on cmd/compile: regalloc reloads a value from a narrower phi's stack slot, losing its upper bits2d
From triage meeting, this is likely not a regalloc bug but elsewhere. @cherrymui said that @randall77 had a suggested approach for this might work for this.dmitshur commented on cmd/dist: `{CC,CXX}_FOR_TARGET` is incorrectly embedded into output when cross-compiling2d
CC @golang/compiler.dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.27 backport]2d
We discussed this in a release meeting. Approved the already-created backport CL.dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.26 backport]2d
We discussed this in a release meeting. Approved the already-created backport CL.dmitshur commented on cmd/compile: generic shift-by-constant canonicalization gives Const64 the wrong type [1.26 backport]2d
Approving the backport to Go 1.26 for CL 795240 and CL 837245.dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.27 backport]2d
The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.26 backport]2d
The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.dmitshur commented on cmd/compile: loong64 spills a byte-sized inlined result with an 8-byte MOVD, clobbering adjacent stack slots [1.26 backport]2d
@abner-chenc Can you please include a backport rationale for this request. Also, is this a problem for Go 1.26 only, or is 1.27 also affected?dmitshur commented on crypto/tls: IPv4 public names are allowed in ECH2d
CC @golang/security, @cpu.dmitshur commented on mime: avoid panicking when reading globs2 files2d
CC @neild.dmitshur commented on net: maxListenerBacklog panics on empty somaxconn input2d
CC @ianlancetaylor, @neild, @nicholashusin.dmitshur commented on cmd/compile: hoist slice allocations out of a loop2d
CC @golang/compiler.dmitshur closed an issue : x/pkgsite:2d
Empty issue.dmitshur commented on : x/pkgsite:2d
Empty issue.dmitshur commented on cmd/compile: regalloc reloads a value from a narrower phi's stack slot, losing its upper bits2d
CC @golang/compile.dmitshur commented on cmd/compile: specialize instantiations of "certain" generic functions2d
CC @golang/compile.dmitshur commented on cmd/compile: linker panic "R_USEIFACE ... references type:.eqfunc... which is not a type or itab" with reflect.TypeFor[T]().Comparable()2d
CC @golang/compile.dmitshur commented on cmd/compile: CSE of OpLocalAddr across calls lets GC free objects still reachable from a local array2d
CC @golang/compile.dmitshur commented on runtime: g is allocated from the 480-byte size class on amd64, arm64 and loong642d
CC @golang/runtime.dmitshur commented on runtime: bound overtakes of lock2 sleepers2d
CC @golang/runtime.dmitshur commented on runtime: allocation profile is stale when collected multiple times before GC happens2d
CC @golang/runtime.dmitshur commented on runtime: random memory allocation errors on AIX2d
CC @golang/aix, @golang/runtime.dmitshur commented on net/http: HTTP/2 server re-arms a connection's idle timer after its serve loop ends, retaining the connection for IdleTimeout (and the client read loop never stops its health-check timer)2d
CC @neild, @nicholashusin.dmitshur commented on math: Exp returns +Inf for finite results on amd64 (709.436 <= x < 709.783)2d
CC @griesemer, @rsc, @thatnealpatel.dmitshur commented on hash/maphash: WriteComparable loses input on a zero-value Hash2d
CC @randall77.dmitshur commented on runtime: windows: a fault while printing an exception hangs the process instead of exiting2d
CC @golang/windows, @golang/runtime.dmitshur commented on runtime: windows/386: suspending a thread inside NtContinue crashes recovery from a fault2d
CC @golang/windows, @golang/runtime.dmitshur commented on golang.org/x/sys/windows: MemoryBasicInformation has the wrong layout on windows/3862d
CC @golang/windows.dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: stditerators produces non-compiling code when the loop does not use the element2d
CC @madelinekalil, @adonovan.dmitshur commented on golang.org/x/crypto/ssh: OpenChannel can block forever when the connection dies concurrently2d
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/MichaelWittgreffe2d
CC @golang/pkgsite.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/arsham6ix/Xray-core2d
CC @golang/pkgsite.dmitshur commented on golang.org/x/text/language: Parse accepts a tag that repeats an extension singleton2d
CC @mpvl.dmitshur commented on golang.org/x/website/tour: add four community translations and update four URLs2d
CC @golang/tools-team, @ALTree.dmitshur commented on golang.org/x/vuln: govulncheck -format=sarif generates invalid SARIF with duplicate stacks, violating SARIF v2.1.02d
CC @golang/vulndb.dmitshur commented on image/draw: finding the closest palette color is slow for large palettes2d
CC @nigeltao.dmitshur commented on golang.org/x/build/cmd/relui: unexplained instance of a workflow stall2d
During this month's release workflow, we saw relui get restarted due to OOM. It's quite possible that enabling the race detector contributed to more memory usage, enough to exceed its current 8 GB al…dmitshur commented on runtime: native SEH unwinding faults in mcall on windows/amd64 since Go 1.253d
CC @golang/runtime, @golang/windows.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/sebastienrousseau/scout, scout-mcp, scout-reporting, scout-action3d
CC @golang/pkgsite.dmitshur commented on encoding/xml: Marshal and EncodeToken emit ill-formed element/attribute names with nil error3d
CC @rsc.dmitshur commented on go/types: types.Error.go116end end position derived from placeholder Ident.Name is garbage3d
CC @griesemer, @mrkfrmn.dmitshur commented on go/types: Interface.Method and ExplicitMethod are not ordered by Id, contra docs3d
CC @griesemer, @mrkfrmn.dmitshur commented on net/http: FileServer issues incorrect redirect to regular file given multiple trailing slashes3d
CC @neild, @nicholashusin.dmitshur closed an issue : Add minia2a — x402 marketplace for agent monetization via API3d
dmitshur commented on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder3d
(2 comments)
> If we can use 12 for the default builders I think that would be better.
We're already using 12 for linux/arm64 (CL 622318), but still 11 for linux/amd64. Changing the version comes w…dmitshur commented on golang.org/x/build: evaluate switching default builders to a newer architecture3d
CC @golang/release.dmitshur reviewed +2 on golang.org/x/build/internal/relui: make poll-wait for submit less spammy3d
Thanks.
(nit) Given a not very self-descriptive type like `chan string`, 'ch' is not a very descriptive variable name for it. Since it's being used to log notable state changes, consider naming it s…dmitshur commented on security: fix CVE-2026-568613d
Removing release-blocker for clarity. Since this issue was moved to the Unreleased milestone, that label has no effect. It can be re-added if this needs to block a specific release.dmitshur commented on net/http: Transport reuses cached unencrypted HTTP/2 connection for https:// request3d
Removing release-blocker for clarity. Since this issue was moved to the Unreleased milestone, that label has no effect. It can be re-added if this needs to block a specific release.dmitshur commented on cmd/go: go vet -fix does not apply fixes in std packages, and -tags turns unsafeptr back on3d
CC @adonovan, @matloob.dmitshur reviewed +2 on golang.org/x/build/internal/relui: transition WIP CLs to Ready3d
Thanks.
https://go.dev/doc/comment suggests "Every exported (capitalized) name should have a doc comment."
I wonder if it could work out slightly better to do the mark ready step as soon as the con…dmitshur reviewed +2 on golang.org/x/build/gerrit: fix incorrect return schema for SetCommitMessage3d
Thanks.
It's kinda surprising to see that given it's [not documented](https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-message) in the Gerrit API REST docs, and [this](…dmitshur reviewed +2 on golang.org/x/crypto/acme: prefer test log helpers in test contexts3d
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: don't require credentials when debugging one build or script3d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: do not fail on cherry-pick merge conflicts3d
Thanks.
What is the effect and motivation of having a sleep here and on line 961 (above)? They're in the same goroutine, so as far as I can tell they have no effect inside synctest.Test. If they hav…dmitshur reviewed +2 on golang.org/x/build/internal/task: add observability to MoveAndRebase3d
Thanks.
By this line, ci has been assigned to movedCI. Will its Branch field be the new branch by then? If so, perhaps something like:
```suggestion
prevBranch := ci.Branch
ci = &movedCI
ctx.…Last Week
dmitshur commented on golang.org/x/build/relmeta: add Symbols to SecurityPatch6d
Another tool to consider is cmp.Diff, since its output on failure can be easier to read.dmitshur reviewed +2 on golang.org/x/build/relmeta: add Symbols to SecurityPatch6d
Thanks.
I'll note that it seems a bit unexpected that DeploymentMap would have this effect on Symbols, where an empty map causes p.Symbols to be used as is, whereas a non-empty map causes some filte…dmitshur reviewed +2 on golang.org/x/build/relmeta: add escape hatch for manual deployment6d
dmitshur commented on image/draw: speed up finding the closest palette color6d
The net/http.TestTransportMaxConnsPerHostDialCancellation/h1 failure is an unrelated flaky test (tracked in issue #69182), and everything else passed.dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.27.md: add two late release notes6d
Thanks.dmitshur fixed an issue golang.org/x/build: migrate low-capacity (reverse) builders to LUCI1w
This migration is done, closing out this umbrella issue. Any other builder-specific work can be tracked in individual issues.dmitshur opened an issue golang.org/x/build: add darwin/arm64 builders with macOS 27 Golden Gate1w
This is a tracking issue for adding darwin/arm64 builders with macOS 27 Golden Gate. (There's no need for amd64 ones since macOS 27 drops support for amd64.) Issue #76798 was for previous year's vers…dmitshur commented on golang.org/x/vgo/Automated: Migrate go/vgo from gsutil to gcloud storage1w
Thanks for preparing this change. As noted in the [README](https://go.googlesource.com/vgo#obsolete), this repository is an archive, preserved for historical interest only. It's not actively used nor…dmitshur reviewed +2 on golang.org/x/build/relmeta: add escape hatch for manual deployment1w
Thanks.
I see a lot of uses of DeploymentMap in this CL, but I'm having a hard time finding any one place that gives it a clear description. Given it's a map of A to B, what do A and B represent? I …dmitshur reviewed +2 on golang.org/x/build/internal/relui: factor upstreaming private-track CLs tasks into methods1w
Thanks.
Noting that this whole "Confirm PRIVATE-track security CLs" step was meant to be temporarily guard against human release coordinators accidentally pasting in the wrong ref until the metadata…dmitshur reviewed +2 on golang.org/x/build/internal/relui: split off privXMilestoneParameter1w
Yep, relui parameter definitions are basically free so it's good to specialize them to be more precise when applicable (such as here). Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: return milestones by pointer1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: remove indirections where possible1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift CL conversion in ReleaseMilestone1w
Thanks.
This is a general comment. I see a pattern across various CLs to convert some method-based tasks into function-based tasks and provide dependencies to them as parameters (wf.Const since they…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift checkpoint branch creation1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift await for disclosed security patches1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift public branch head guards1w
I wished (for purposes of readability of the CL stack) this was a part of CL 826666 rather than happening later, but maybe these couldn't be moved earlier until some of the refactors in between.
Tha…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift submission of security patches1w
Thanks.