Activity

Today
If there are in-flight CLs for doc/next, it might make sense to finish them before moving the release notes into x/website. This is something the release coordinator may do manually, so add an automa…
Yesterday
Thanks. This comment refers to the deleted initHandler below. I suppose it’s fine to delete it by now since moving projects will force us to deal with the missing root key one way or another. Thi…
Duplicate of #70682.
(1 comment) Yeah, it looks like it's newly needed by x/tools/go/packages tests as of x/tools v0.28.0: ``` mobile $ go mod why -m github.com/google/go-cmp # github.com/google/go-cmp (main module doe…
Thanks. Since CL 618598 and issue 68678 are now handled, you could remove this line from the 'Needs to be documented and tracked via a release-blocking issue.' section. It's fine not to worry about…
We considered this freeze exception in a release meeting today. This seems to be a new API that would be safe to land in the next upcoming major Go release, Go 1.25, so that if there are unexpected i…
(1 comment) (CL 633835 improved the test error message.)
The test already requires "https://go.dev/page" links to be written as relative "/page" ones; it looks like an oversight not to do that right away in these two cases.
https://go.dev/issue/new already redirects to GitHub's issue tracker with the "/choose" suffix, and https://go.dev/issue/new/choose is 404. Improve the test to handle this case and suggest the right …
(1 comment) Since https://go.dev/issue/new redirects to https://github.com/golang/go/issues/new/choose and https://go.dev/issue/new/choose is 404, I think what you're looking for is: ```suggestion…
Thanks for the quick fix! The monthly golang.org/x tagging workflow ran into this, and the fix enabled it to keep going (https://go.googlesource.com/crypto/+/refs/tags/v0.30.0).
The expected happy path is that the "between freeze start and RC 1" workflow is run once to completion and not again. Still, it might happen that we run it more than once, intentionally or accidental…
dmitshur created repository in github.com/golang/open2opaque19h
I'm not familiar with conventions for gopls-release-branch.* branches in x/tools, so feel free to ask Tim to also look, but LGTM since this matches the original CL 632356. In other places I've seen …
@mknyszek@google.com suggested waiting a bit and redoing this after a few in flight CLs land, so adding a Hold+1 for that. (We can also close the CL.)
(1 comment) Indeed, that's a good idea and it would've been better to include it. (I generally [do that](https://go-review.googlesource.com/c/build/+/527016/2//COMMIT_MSG#23), but forgot this time.)
(3 comments) This change is ready for review. Ok, PS 2 should be ready from my side. I tried a brief dry run (i.e., without real Gerrit/GitHub clients) locally and there weren't clear problems visi…
dmitshur reviewed +2 on go.dev/wiki/Modules: add go1.24 tools22h
Thanks. I'm not seeing any issues, though Michael would be more familiar with this change than I am.
At Go tip, TestMultiSign fails when run without -short flag, including on first class ports like linux/amd64: ``` === RUN TestMultiSign clearsign_test.go:155: cannot create key: rsa: gener…
Added okay-after-rc1 since RC 1 is scheduled for [next week](https://go.dev/s/release#june--december-week-2-release-candidate-1-issued) and 2024b is still the latest available version. (CC @mknyszek.…
This workflow automates the following sequence that we need to do for every major Go release cycle sometime between freeze start and RC 1: • Update the API check. • cat api/next/*.txt | sort >…
The new "apply wait" task is analogous to the existing "unwait" one, and was tested out during the Go 1.24 freeze two weeks ago. Move both of them into a new release cycle-focused struct where more …
No need to repeat the path when it's implicitly specified via file path in x/website/_content. Also move the title key to be higher up. This is to make the generator match what we've been doing in x/…
Many instances already use the shorter "owner, repo string" form. Fix a few that didn't. This will get that diff out of future CLs. For golang/go#70655. [git-generate] find . -type f -name '*.go' -…
dmitshur deleted branch in github.com/shurcooL/git-branches1d
8weeks
dmitshur pushed to main in github.com/shurcooL/git-branches1d
351e1dad1259efe6b24d22971543bfa6a67d4b30add support for git worktrees
1e66ec400680172499da7202cd412646fdec93cause "main" as the default branch name
173b1b1c1f347034a832c725aa9e6e355f6a91d3change definition of "stale" to 8 weeks (up from 2 weeks)
This Week
Thanks. I understand it considered that a single regexp can be made to match both, and a list of regexp was chosen anyway because it's deemed more readable.
@seankhliao I don't see a [frozen notice](https://go.dev/wiki/Frozen) convention applied to golang.org/x/tools/godoc nor golang.org/x/tools/godoc/vfs. It doesn't seem to be frozen? Does that still ne…
In addition to workflows for all of Go release types, relui holds a few workflows for miscellaneous recurring tasks that come up in the release cycle (go.dev/s/release) such as [pinging early-in-cycl…
This issue is still valid and relevant to the package, but the package itself is probably less relevant now that io/fs exists. It should probably be deprecated in favor of that as part of #59056.
By now we have answers to that question from 6 years ago about how to do this: removing a golang.org/x package involves deprecating it, isolating it to its own nested module, tagging that, and then d…
The v1.1.20 -> v1.1.23 diff in code is quite small, and reasonable. Thanks. (Note there's also a v1.1.24 out by now.)
Thanks. (nit) This outer `func()` was unavoidable previously, because there were two function calls in the goroutine. Now that it's down to one, it's viable to skip it if desired. ```suggestion go…
At tip (commit c5adb8216968be46bd11f7b7360a7c8bde1258d9), TestBenchmarkBLoopIterationCorrect succeeds under most conditions. <details><br> ``` $ go test -run=^TestBenchmarkBLoopIterationCorrec…
Last Week
(minor) Oddly, this go-cmp go.mod checksum entry, as well as the xerrors go.mod entry on line 6, do not show up for me after a `go mod tidy` with go1.23.3. But extra lines in go.sum are harmless.
We solved this during the migration to LUCI, golang.org/x/xerrors has post-submit builders visible on its dashboard (e.g., https://ci.chromium.org/p/golang/g/x-xerrors-gotip/console). It's still not …
The fix is backported and this shouldn't happen on release branches either, now. Closing again.
@mvdan This issue can indeed be marked as closed since it's resolved in Go 1.24, but the Go1.24 milestone is right. There are child backport issues that need to refer to this one. We need a parent is…
dmitshur commented on os: TestGetwdDeepWithPWDSet failures1w
This is a continuation of https://github.com/golang/go/issues/69234#issuecomment-2501169320. So far, These particular failures seem to only happen on the darwin/amd64 builders with macOS 11.
dmitshur pushed to master in github.com/mdempsky/unconvert1w
db6ad295e1ced00ee0372d285662f6ad3a2d261cunconvert: replace deprecated io/ioutil with os
A [comment on CL 618601](https://go-review.git.corp.google.com/c/go/+/618601/comments/3d652992_21d045d6) indicated that the change (which fixed #63934 and #68652) should likely be mentioned in [Go 1.…
A [comment on the CL](https://go-review.googlesource.com/c/go/+/618598/comments/6a1b5da8_513f46c7) suggested that this change should be mentioned in [Go 1.24 release notes](https://github.com/golang/…
@neild This change (a package available only when an experiment is set) should be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), otherwise users might not know it ex…
This looks like a change that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Reopening as a release blocker to track that.
It looks like [CL 630775](https://go.dev/cl/630775) implemented most of this proposal if not all, though it didn't close it. What's left for Go 1.24? Is it just SecP256r1MLKEM768, which according to …
This cmd/go change might be noteworthy enough¹ to be covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), so reopening with a release blocker to track that. ¹ In additi…
@rolandshoemaker There's no API change here, but this still seems like a change that should be covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Mentioning…
@cherrymui Do you think that wasm change (in CL 626615) is something to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)?
@FiloSottile Does this change need to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)? Thanks.
@griesemer Do you think there's anything to be said in [Go 1.24 release notes](https://github.com/golang/go/issues/68545) about this? Or is it fine not to mention it there since this a clarification …
This vet change seems like something that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), and it's not mentioned there yet. Reopening as a release blocker…
dmitshur reopened an issue cmd/compile: add go:wasmexport directive1w
This looks like a change that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545); that doesn't seem to be done yet. Reopening as a release blocker to track th…
@FiloSottile Does this change need to covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)?
A new check added to vet seems like something that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), and it's not mentioned there yet. Reopening as a releas…
This vet change is new to Go 1.24 and still needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), right? Reopening with a release blocker label to track that.
This change (enabling these directives in Go 1.24) is documented in cmd/cgo [package docs](https://pkg.go.dev/cmd/cgo@master#hdr-Optimizing_calls_of_C_code), but it seems a note in [Go 1.24 release n…
@ianlancetaylor Do you think this needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)? Or should this be considered a minor bug fix on Windows (despite going t…
@samthanawalla This new capability seems noteworthy enough that it should be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Reopening as a release blo…
Adding a release blocker to track mentioning this new cmd/go feature in the [Go 1.24 release notes](https://github.com/golang/go/issues/68545).
This Go 1.24 language change isn't currently covered in the [Go 1.24 release notes](https://github.com/golang/go/issues/68545) draft, is it? Reopening as a release blocker to track that.
@adonovan Ack. That'll happen before RC 1 via another round in #36905, or it can be an individual CL sooner.
The persistent failures were indeed fixed, but now the test seems to flake with "file name too long" only on darwin/amd64 builders with macOS 11. Since that looks like a different failure mode, I'll …
The latest batch is resolved by restarting these. This is likely to happen again in about a month while the root issue (#66962) is unresolved.
Thanks. Reopening this with a release blocker so it's tracked.
dmitshur commented on testing: benchmark unit properties1w
@aclements Is there anything here that should be included in the Go 1.24 release notes? I also commented on the unsubmitted [CL 357590](https://go.dev/cl/357590).
@rolandshoemaker This is documented in godebug.md, but not in the Go 1.24 release notes. Do you think this should be documented there?
> It's useful to expose it in x/crypto for external implementations of the interface to use it. It will be vendored back. If I understand right, it's currently added to the main Go repo as the int…
Adding release-blocker to track updating release notes.
Earlier
This hasn't happened in a while, and it's just being bumped from release to release. Moving to Backlog. (If someone starts working on this, feel free to move to the corresponding release milestone.)
From your description, it sounds like there's something going wrong when you're building Go from source. I'm not sure if you're running into some problem that only affects the combination of Windo…
These "Error enabling Transport HTTP/2 support: protocol https already registered" errors may be fairly new, and if so maybe related to recent net/http changes. Also seeing them in #70299. CC @neild.
dmitshur opened an issue all: reopen tree for Go 1.25 development1w
### Current Tree Status: Release freeze for Go 1.24 (see [golang-dev announcement](https://groups.google.com/g/golang-dev/c/JkRenbsSBv4/m/dhcurHI5CwAJ)) Now that we've entered the freeze for Go 1.…
Thanks. It looks like both of those CLs made it in before the freeze started, so a freeze exception isn't needed.
Happened again in trybots for CL 629635 today (see [build 8730612819953883601](https://ci.chromium.org/b/8730612819953883601)).
Both Go 1.23.3 and Go tip (commit c4e6ab9750e9d673a29203a9f41a517bcdc7a64c) have same behavior as in the original report. @seankhliao It doesn't seem that this is complete.
Thanks for letting us know ahead of the freeze. We discussed this and will approve the freeze exception bit here. Please be ready to update your plan if there turn out to be more complications than o…
Merged into #70496.
Merged into #70496.
dmitshur commented on : AIX build broken with SIGSEGV2w
CC @golang/aix.
@gopherbot Please consider this issue for backport. It appears to be a case of stack corruption during fault handling, and we're now seeing this failure on both 1.23 and 1.22 release branches (e.g., …
dmitshur closed an issue sync/atomic: TestNilDeref failures2w
It's happening on the Go 1.23 release branch now. Closing in favor of #70288 again. I relaxed the pattern there and removed this issue from Test Flakes project, so watchflakes sends its reports th…
CC @golang/openbsd.
Thanks for the report. Note that the net/http/cgi package comment includes "This package is intended primarily for compatibility with existing systems." but it sounds like this issue might affect exi…
Closed by merging [CL 630215](https://go.dev/cl/630215) (commit 6f05fa7a4f632fee7fadada8d31cf8755c709610) to release-branch.go1.22.
Closed by merging [CL 630196](https://go.dev/cl/630196) (commit 847cb6f9ca43da48cb10e98808a74a40b41242fa) to release-branch.go1.23.
The TestToStruct test in `google.golang.org/protobuf/types/known/structpb` package has started to fail at Go tip, as of [go.dev/cl/627716](https://go.dev/cl/627716) (CC @randall77): ``` === RUN …
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)
dmitshur pushed to main in dmitri.shuralyov.com/scratch7mo
5eb48b5f5d31d39777719edb35d37b724f183dc8quine: add load-bearing trailing space