Today
shurcooL commented on Added typed error in github.com/sony/gobreaker1h
Style-wise, since this is a type, it should be named `CircuitBreakerError`. `ErrFoo` is for error variables, not types. Reference: https://talks.golang.org/2014/names.slide#15. You could also c…
shurcooL commented on proposal: increase contributions by… in github.com/golang/go1h
@bradleyfalzon made a nice [6-minute video](https://www.youtube.com/watch?v=fjPJDC-0hXA) showing the end-to-end process of thinking through a problem in an open source project and the possible soluti…
Yesterday
shurcooL deleted branch in github.com/google/go-github15h
foo/test
shurcooL pushed to master in github.com/shurcooL/githubql16h
2eeedea5example/githubqldev: Move warning in package comment.
shurcooL pushed to NestedTeamsPreview in github.com/google/go-github16h
ad2ff3f8Add support for fetching parent team (for nested teams). (#723)
shurcooL starred github.com/esimov/triangle16h
shurcooL deleted branch in github.com/shurcooL/go-goon19h
try2
shurcooL deleted branch in github.com/shurcooL/go-goon19h
try
shurcooL pushed to master in github.com/shurcooL/go-goon19h
37c2f522Improve robustness of dumping time.Time timezone.
shurcooL created branch in github.com/shurcooL/go-goon19h
try2
shurcooL created branch in github.com/shurcooL/go-goon19h
try
shurcooL pushed to master in github.com/shurcooL/go-goon20h
4658ef80Simplify code, remove unused code.
24f6278aConvert map test to example with unordered output.
373bbb6dImprove dumping of time.Time values.
1dbe114fREADME, Travis: Regenerate.
shurcooL pushed to master in github.com/shurcooL/gtdo20h
71fa3f15Rearrange declarations.
decfdb38Replace http.CloseNotifier.CloseNotify() with req.Context().Done().
9bd847a6assets: Regenerate.
597f0b4cfrontend: Don't add extraneous '#' when clearing hash.
shurcooL commented on Added typed error in github.com/sony/gobreaker21h
(You should consult with someone more familiar with the project, and the needs of #9. I'm just a passerby that left a quick comment about a potential typo I spotted.) Both approaches are valid and…
shurcooL commented on Project! in github.com/WebAssembly/design1d
FWIW, iOS 11 came out 3 days ago, which shipped WebAssembly support in mobile Safari.
shurcooL pushed to master in github.com/shurcooL/notificationsapp1d
98af235eDon't panic in errorHandler if users service is nil.
shurcooL pushed to master in github.com/shurcooL/issuesapp1d
6077763bDon't panic in errorHandler if users service is nil.
shurcooL commented on Request parent team when endpoints … in github.com/google/go-github1d
@e-beach, this PR is currently targeting `master` branch. Was that a mistake? Can you update it to target `NestedTeamsPreview` instead?
shurcooL commented on Request parent team from endpoints … in github.com/google/go-github1d
Oh, my bad, I forgot that it's possible now. All right.
This Week
shurcooL starred github.com/nokka/d2client1d
shurcooL starred github.com/nokka/d2s1d
shurcooL commented on Added typed error in github.com/sony/gobreaker1d
Did you mean to name this `ErrTooManyRequests` or `ErrTooManyRequest`?
shurcooL commented on add built-in GraphiQL in github.com/neelance/graphql-go1d
As far as I know, the default encoding for JSON is UTF-8, so it shouldn't be necessary to specify the charset in the header.
shurcooL commented on go/build: ImportDir/Import no longe… in github.com/golang/go1d
@mattfarina Your latest comment goes counter to what I said in the 2nd half of [this comment](https://github.com/golang/go/issues/21923#issuecomment-330955263). It's not clear to me, is it because yo…
shurcooL commented on Question: Would a single pagination… in github.com/shurcooL/githubql1d
No problem. Please let me know when you do post it, I am interested in following it for updates.
shurcooL commented on Question: Would a single pagination… in github.com/shurcooL/githubql1d
@gmlewis Have you already posted in that forum? If so, what's the URL of the post?
shurcooL commented on Supported OpenGL version in github.com/goxjs/gl1d
> Basically I was looking to port Three.js to Go (which I had done before in C#) and it looked like this was a great base for windowing/context cross platform part. Don't have specific things that ar…
shurcooL commented on Request parent team from endpoints … in github.com/google/go-github1d
Okay. I've created a [`NestedTeamsPreview`](https://github.com/google/go-github/tree/NestedTeamsPreview) branch. I'll close this PR, @e-beach please re-send it against that brach rather than `mast…
shurcooL created branch in github.com/google/go-github1d
NestedTeamsPreview
shurcooL commented on Code blocks not rendered correctly … in github.com/russross/blackfriday2d
Issue #239 is also possibly related.
shurcooL pushed to master in github.com/shurcooL/issuesapp2d
d08a77e2cmd: Add test programs with {GitHub,Asana} API-backed services.
6e5ad488frontend: Don't add extraneous '#' when clearing hash.
shurcooL commented on Transparent hint check in github.com/glfw/glfw2d
Style-wise, is it okay this places `{` on same line as `if`, while the rest of the code places it next line?
shurcooL commented on Consider replacing staticcheck, gos… in github.com/bradleyfalzon/gopherci2d
> It might make sense to have higher level categories though. Like, it might not matter so much whether a check came from `vet` or `staticcheck`, since they're both related to correctness with no fal…
shurcooL commented on Ignore errors whose return value is… in github.com/kisielk/errcheck2d
Here's an example of it being used (in good taste, IMO) in the standard library: https://github.com/golang/go/blob/eca45997dfd6cd14a59fbdea2385f6648a0dc786/src/mime/multipart/multipart.go#L120-L12…
shurcooL commented on Ignore errors whose return value is… in github.com/kisielk/errcheck2d
> If someone writes code that uses `_` as the name of any return that matters, then that should fail any code review, regardless of whether a check like this makes it into errcheck or similar tools. …
shurcooL commented on staticcheck: consider detecting no-… in github.com/dominikh/go-tools2d
I was referring to the potential practice of restoring a variable "just in case", even if's never modified. Although, I realize now that even if static analysis could perfectly tell you that such cod…
shurcooL commented on include HTTP request object in Auth… in github.com/AaronO/go-git-http2d
It would be more readable and clear to write `0777` here instead of `os.ModePerm`.
shurcooL commented on staticcheck: consider detecting noo… in github.com/dominikh/go-tools2d
> The test may have been written defensively, restoring the variable "just in case" As static checks become more powerful and capable, I hope that'll reduce the need to write "defensive" code, i.e…
shurcooL commented on Ignore errors whose return value is… in github.com/kisielk/errcheck2d
> but there is no means to specify in code that f never returns an error. There are two ways: 1. Don't include the `error` return value. If it's always nil, it's not needed. (Presumably, this i…
shurcooL commented on Ignore errors whose return value is… in github.com/kisielk/errcheck2d
I'm not sure this is viable. Some Go code ends up giving the error return value blank identifier name for completely unrelated reasons. E.g., imagine you start with: ```Go type Bar struct { ... }…
shurcooL deleted branch in github.com/google/go-github2d
use-timestamp-unix-const
shurcooL pushed to master in github.com/google/go-github2d
61bf8a6aUse referenceUnixTimeStr const in tests. (#721)
shurcooL commented on staticcheck: consider detecting noo… in github.com/dominikh/go-tools2d
Thanks for the thorough and thoughtful analysis. I suspected there may be many obstacles preventing a check that detects this from being viable, and it looks like that's the case, unfortunately.
shurcooL pushed to master in github.com/shurcooL/home2d
7cd7b947Add new Go packages to /packages list.
shurcooL pushed to master in github.com/shurcooL/go2d
c661e953generated: Use unicode ellipsis in package comment.
shurcooL starred github.com/Lngramos/three2d
shurcooL commented on Fix #664. Docs for empty DismissalR… in github.com/google/go-github2d
Thanks for the update @beiriannydd. I understand your position. It's completely okay to withdraw from working on a PR if it's no longer a priority and you're unable to take it further. This is a hard…
shurcooL commented on Request parent team from endpoints … in github.com/google/go-github2d
Minor, unneeded blank line here.
shurcooL created branch in github.com/google/go-github2d
use-timestamp-unix-const
shurcooL pushed to master in github.com/google/go-github2d
ea6e70fdAdd test for anomalous timestamp format from Projects API. (#716)
shurcooL commented on (#715) Add test for anomalous times… in github.com/google/go-github2d
GitHub announcement says: > Starting on Monday October 2nd, 2017 So, wouldn't it be more accurate to say this? ```diff -before October 1, 2017. +before October 2, 2017. ``` At least I …
shurcooL commented on Supported OpenGL version in github.com/goxjs/gl2d
Hi @delaneyj, Thanks for asking. That's a good observation. See #9 for the PR that did it. I don't have a good reason for it. I think it's because OpenGL 2.1 (with extensions) happened to be…
shurcooL commented on Add support for MarketplacePurchase… in github.com/google/go-github2d
Sorry for the delay. It looks like we have no support for the Marketplace preview API at all yet. Since the goal of this library is to implement all GitHub endpoints, it should be added. It doesn't h…
shurcooL commented on gl.FenceSync returns invalid unsafe… in github.com/go-gl/gl2d
Friendly ping @dominikh.
shurcooL commented on go/build: ImportDir/Import no longe… in github.com/golang/go2d
That said, there may be room for improvement of how `build.Import` reports different types of errors, but that's an enhancement that's distinct from the Go 1.8 -> 1.9 change regarding `os.IsNotExist`…
shurcooL commented on go/build: ImportDir/Import no longe… in github.com/golang/go2d
I agree with @ianlancetaylor here. I think you should update your code and treat a non-`nil` error to mean "package not found". That's what I do in my code, and I haven't run into any false positi…
shurcooL commented on Use method as cache key prefix for … in github.com/gregjones/httpcache2d
Thank you @hx again for this valuable fix, and for your patience with us getting to this PR.
shurcooL pushed to master in github.com/gregjones/httpcache2d
316c5e0fUse method as cache key prefix for non-GET requests. (#75)
shurcooL pushed to master in github.com/shurcooL/issuesapp2d
f6007195frontend: Don't add extraneous '#' when clearing hash.
shurcooL commented on Consider replacing staticcheck, gos… in github.com/bradleyfalzon/gopherci2d
I will say you should _consider_ what it would be like to de-emphasize which tool a warning came from in your UI. If you decide that it's a good idea, this issue changes dramatically. (But this is a …
shurcooL commented on Consider replacing staticcheck, gos… in github.com/bradleyfalzon/gopherci2d
> Do you agree or disagree with this? Do you think there's value in keeping the existing behaviour, or do you think it should be swapped, considering the fact the original tool raising the issue woul…
shurcooL commented on making a box for a directory above … in github.com/gobuffalo/packr2d
If you want an `http.FileServer`-like construct with without special handling of `index.html` files, it's quite easy to make your own. You can see an example of one I've created at https://godoc.org/…
shurcooL starred github.com/jakecoffman/cp3d
shurcooL commented on Regression in rendering, found in G… in github.com/gopherjs/vecty3d
If you don't mind, I'm certainly open to considering improvement suggestions, thank you. I'll spend some time reading and learning more about #130, thanks for providing the information. Also, I th…
shurcooL pushed to master in github.com/shurcooL/home3d
e04149e7Remove global anchor style for blog.
shurcooL commented on Use method as cache key prefix for … in github.com/gregjones/httpcache3d
I'll give @gregjones a day or two to see if he has any other comments. After that, I can merge.
shurcooL pushed to master in github.com/shurcooL/gostatus3d
c21d3a3dUpdate for vcsstate API change.
shurcooL pushed to master in github.com/shurcooL/Go-Package-Store3d
dd3728eeworkspace: Update for vcsstate API change.
shurcooL deleted branch in github.com/shurcooL/vcsstate3d
add-cmd-timeout
shurcooL deleted branch in github.com/shurcooL/vcsstate3d
RemoteContains-take-default-branch
shurcooL pushed to master in github.com/shurcooL/vcsstate3d
ff45d549Add default branch parameter to RemoteContains.
shurcooL pushed to master in github.com/shurcooL/Go-Package-Store3d
15b4c1d7Document GO_PACKAGE_STORE_GITHUB_TOKEN env var.
shurcooL commented on Use method as cache key prefix for … in github.com/gregjones/httpcache3d
> I also didn't know GitHub allowed the addition of commits to someone else's PR; TIL. It's a new feature from last year, see https://github.com/blog/2247-improving-collaboration-with-forks. Maint…
shurcooL commented on Regression in rendering, found in G… in github.com/gopherjs/vecty3d
This is unexpected to me because I thought #130 and the `prop` tag only mattered if I were using `Restorer` interface, which I wasn't. I'll have to spend some time to understand #130 better, and wher…
shurcooL commented on Regression in rendering, found in G… in github.com/gopherjs/vecty3d
Yeah, that seems to have worked. I've made this one line change: ```diff // RepoPresentation is a component for presenting a repository update. // // TODO: Dedup with workspace.RepoPresentation…
shurcooL commented on Regression in rendering, found in G… in github.com/gopherjs/vecty3d
Just reload in the browser. When you use the dev build tag, it always builds from source. I'll give that a try, thanks!
shurcooL commented on Regression in rendering, found in G… in github.com/gopherjs/vecty3d
Sorry, unfortunately, I haven't yet added support for sourcemaps to `gopherjs_http` package. You could use the `gopherjs build` to get them there, but that's gonna take some manual work. Also, …
shurcooL commented on Regression in rendering, found in G… in github.com/gopherjs/vecty3d
Absolutely. ``` go get -u github.com/gopherjs/gopherjs go get -u -d github.com/shurcooL/Go-Package-Store/cmd/Go-Package-Store GOARCH=js go get -u -d github.com/shurcooL/Go-Package-Store/fronten…
shurcooL pushed to master in github.com/shurcooL/Go-Package-Store3d
e7b1bc56Update for Vecty API change. (#84)
shurcooL commented on Port to new Vecty API in github.com/shurcooL/Go-Package-Store3d
@slimsag I've pushed a 4th commit to this PR. It kinda reverts the code layout changes you've applied, but updates to use the new API. Basically, my goal with this PR is to make minimal change to …
shurcooL pushed to master in github.com/slimsag/Go-Package-Store3d
82742d41Return to previous code layout.
shurcooL commented on Port to new Vecty API in github.com/shurcooL/Go-Package-Store3d
Thanks a lot for explaining that, it's very helpful for me to understand the change. After thinking about this, I still prefer to keep the method `presentationChangesAndError` returning just the c…
shurcooL commented on Lifecycle design changes (persisten… in github.com/gopherjs/vecty3d
The changelog says: > Properties should be denoted via ``` `vecty:"prop"` ``` struct field tags. What are properties and what are non-properties? How do I know if a field should be marked with …
shurcooL commented on Port to new Vecty API in github.com/shurcooL/Go-Package-Store3d
Ok, it is a regression, but not with the new API. It happened before. I did some archeology. I merged the Vecty branch and regenerated on April 13. I was using the latest Vecty commit at the time,…