Activity

Today
(1 comment) While reviewing this CL, I (re)discovered there is an API to get the directory where tools are installed: https://golang.org/pkg/go/build/#ToolDir. However, to use it with os.Stat, you'…
(1 comment) We forgot the fully qualified issue reference in CL 242643, so the issue didn't get closed yet. If you'd like, change this to Fixes as there's nothing more to do there after this is sub…
Thanks! This is how the test fails when `oldlink` binary isn't present: ``` $ go test -v -run=TestOldLink -count=1 cmd/link === RUN TestOldLink link_test.go:558: [/tmp/tmp.AG3oE0Ne/go/…
> A test may fail if the old linker is not present. We could change the test to skip if the binary does not exist. @cherrymui Which test were you referring to? I can try to find anything by tak…
(2 comments) The comment is optional. It'll be possible to figure out when it's safe to delete this even without it. (Taking into account that we support two past versions of Go, of course.) It do…
(1 comment) I expect https://pkg.go.dev/cmd/oldlink will be removed in some future Go release. Do you know if there's already an issue tracking that? If not, maybe make a new one. Then we can add a…
Right now, it's possible to use `releasebot -dry-run -mode=prepare` to run a release locally that doesn't produce any public artifacts or changes state, but only for the beta release type (e.g., `go1…
I've confirmed the package `net` does not import `fmt` nor `unicode`, not even indirectly. It was resolved via [CL 241257](https://golang.org/cl/241257), and [CL 241078](https://golang.org/cl/241078)…
@mknyszek Can you please add a short rationale about why the backport might be needed? (Per [MinorReleases](https://golang.org/wiki/MinorReleases).) Thanks.
@ianlancetaylor Issue #37097 was about a problem on the Go-Release-Cycle page. I spotted a problematic statement in the MinorReleases page; filed #40206 about it.
The https://golang.org/wiki/MinorReleases page currently still says: > "Use a more recent stable version" is a valid workaround, so very few fixes will be backported to both previous issues. Th…
Based on https://github.com/golang/go/issues/34775#issuecomment-628115836: > this issue has existed since Go1.12 and unfortunately because it wasn't a regression but rather a long standing bug …
@dmitshur requested issue #34775 to be considered for backport to the next 1.13 minor release. The original issue exists in 1.13 too, so per backport policy, it must be considered for backporting …
Yesterday
Thanks for clarifying, that's very helpful. In the original issue report, I didn't realize you were using an IDE and could not understand where the error was coming from. > I wish I was already a …
dmitshur commented on all: modify VERSION file1d
This was a test for #30037. It's no longer needed.
dmitshur closed a change all: modify VERSION file1d
The current behavior is that GopherBot will import PRs into Gerrit (see https://github.com/golang/go/pull/40190 and https://go-review.googlesource.com/c/go/+/242279 for a recent example). However, it…
dmitshur opened a change all: modify VERSION file1d
DO NOT REVIEW DO NOT SUBMIT This is a test.
dmitshur created branch in github.com/dmitshur/go1d
modified-rb112
dmitshur forked1d
They have been pre-announced¹. ¹ https://groups.google.com/d/msg/golang-announce/f2c5bqrGH_g/GnH6k56AAAAJ
@georettica Does the email you signed the CLA with match the one used as the git author email (can be seen in second line [here](https://github.com/georgettica/tour/commit/18cb8b1c03a4085fd45f71d3ec7…
One lead to investigate is that the exported `DB` type is defined as: ``` type DB struct { *baseDB ctx context.Context } ``` Notably, `baseDB` is an embedded field. The `DB` type gets many of its…
Thanks for reporting. I tested this package at commit https://github.com/go-pg/pg/commit/6fe164e2d690b7e22a4787f5d40d5dd93fc2e5e3 with pkg.go.dev, godoc.org, and x/tools/cmd/godoc, and can confirm…
Last Week
dmitshur pushed to master in dmitri.shuralyov.com/website/gido2d
a78bd3c7abc465e1864ecadce67a826711a27caeadd support for "golang.org/x/pkgsite/..." issues
I would help if you provided a higher level overview of the problem, not the exact specifics. Can you please answer these these questions: 1. Is there a snippet we can run to reproduce the problem…
dmitshur pushed to master in github.com/shurcooL/events3d
e83751ac5ad857636323b1fde113c50b5d745913fs: document possible types of eventDisk.Payload field
dmitshur pushed to master in github.com/shurcooL/git-branches3d
8e7ff6fb0c4eb6c9eb6245e64aa71bd28aebda3f.travis.yml: use go vet instead of go tool vet
(1 comment) Thanks Emmanuel. Only release managers can submit CLs to the release branches¹, so there's no expectation the CL owner to submit this. Now that both this and and the 1.13 CL are reviewe…
(4 comments) This statement seems out of date. This list includes 6 CLs, the subject and list below includes only 5. It’s hard to see that this note applies to the entire back port CL and is not…
In certain cases the HTTP/2 stack needs to resend a request. It obtains a fresh body to send by calling req.GetBody. This call was missing from the path where the HTTP/2 round tripper returns ErrSkip…
@rsc This backport has been approved for 1.14 and 1.13. It applies cleanly to 1.14, but not 1.13. Since you authored the original CL, would you like to resolve the conflict and send a [cherry-pick CL…
(3 comments) Daniel, how does patch set 2 look to you? s/supports/support/ s/types/type/
(2 comments) Thanks for working on this! > Oddly git-codereview complained about gofmt for some runtime files and the only way to get this change up was to submit to its complaint and then make thi…
/cc @FiloSottile @x1ddos per [owners](https://dev.golang.org/owners).
/cc @alexbrainman @bradfitz per [owners](https://dev.golang.org/owners).
@jayconrod `x/tools/cmd/godoc` has support for module mode (see https://groups.google.com/g/golang-dev/c/uxtj_w7wpnY/m/jR3ui47eBQAJ), what's the reason to want to use `pkgsite` instead of continuing …
/cc @julieqiu per [owners](https://dev.golang.org/owners).
/cc @julieqiu per [owners](https://dev.golang.org/owners).
/cc @julieqiu per [owners](https://dev.golang.org/owners).
/cc @matloob per [owners](https://dev.golang.org/owners).
Aside from visual noise and extra bytes, does the added `=""` cause any issues when the HTML is parsed? /cc @mikioh @bradfitz @ianlancetaylor per [owners](https://dev.golang.org/owners).
Thanks for reporting. I agree the example, as displayed at https://golang.org/pkg/net/http/#example_ServeMux_Handle, can feel like it's missing some code to start the server. However, the example …
/cc @alandonovan (per [owners](https://dev.golang.org/owners)) @ianlancetaylor @matloob.
Backport approved for Go 1.14 (#39920) and 1.13 (this issue) as this is a serious issue with no workaround.
Backport approved for Go 1.14 (this issue) and 1.13 (#39925) as this is a serious issue with no workaround.
(1 comment) TRY=solaris-amd64-oraclerel
This fixes an issue raised at https://github.com/golang/go/issues/38458#issuecomment-635617670 in which --- PASS and --- FAIL lines would not trigger --- CONT lines of other tests. Updates #38458. F…
Backport approved for Go 1.14 (#39849) and 1.13 (this issue) because it's a small fix to a serious problem without a workaround.
Backport approved for Go 1.14 (this issue) and 1.13 (#39848) because it's a small fix to a serious problem without a workaround.
(1 comment) TRY=linux-ppc64,linux-ppc64le
(1 comment) I'll rebase and submit after trybots pass.
/cc @jayconrod @bcmills @matloob
/cc @nigeltao @robpike per [owners](https://dev.golang.org/owners).
Can you please provide a more complete reproduce case? Where did you add `if err := Config.validate(p); err != nil { ... }`? What does `Config` refer to?
(1 comment) Since this change was sent as a GitHub PR, https://golang.org/wiki/CommitMessage#github-pull-requests is relevant.
(3 comments) The subject should be something like: internal/gophers: add new email for Roberto Clapis Notably, package path prefix, colon, space, lower case letter, verb that completes "This c…
(1 comment) Cherry, I have a question about this 1.14 backport CL. Its parent is currently "[release-branch.go1.14] cmd/link: fix GC data reading from shared library (attempt 2)", which means trybot…
@cherrymui Yes, 1.13 will become unsupported once 1.15 is released, which should happen next month. However, both 1.14 and 1.13 are supported equally until then (see #34536 for more details), so if t…
@mundaym This backport doesn't apply cleanly. Would you like to work on creating the backport CL as described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls and see if the merge conf…
These conversion instructions set the condition code and so should be marked as clobbering flags. Updates #39651. Fixes #39690.
Approved for 1.14 (#39690) and 1.13 (this issue) as it's a serious problem without a workaround.
Approved for 1.14 (this issue) and 1.13 (#39689) as it's a serious issue without a workaround.
The relevant code for this error message in Gerrit source code is at https://gerrit.googlesource.com/gerrit/+/refs/tags/v3.2.2/java/com/google/gerrit/server/notedb/OpenRepo.java#181.
Issue #25020 (/cc @ALTree) might be relevant here. If GerritBot indeed doesn't support branches other than `master`, then the fix for this issue will be very simple: it should not consider a Gerrit C…
Consider a Gerrit CL that was imported from a GitHub PR, and merged (or closed without merging). For example, see PR #39821. It's possible that a cherry-pick of that imported Gerrit CL will be mad…
From `gopherbot` logs: ``` 2020/07/10 13:33:30 close stale WaitingForInfo: POST https://api.github.com/repos/golang/go/issues/39453/comments: 422 Validation Failed [{Resource:IssueComment Field:d…
@cherrymui You've sent a 1.14 backport CL for #39955. Are you able to send one for 1.13 (this issue) as well?
Backport approved for Go 1.14 (#39955) and 1.13 (this issue) based on the rationale in https://github.com/golang/go/issues/39955#issuecomment-652647856.
Backport approved for Go 1.14 and 1.13 based on that rationale.
@mkumatag There will be a security release on Tuesday, July 14, as recently [pre-announced](https://groups.google.com/d/msg/golang-announce/f2c5bqrGH_g/GnH6k56AAAAJ). It will include only the securit…
Approving as it is a serious problem without a workaround. It is a 1.14-only regression, so a fix for 1.13 isn't needed.
From `gopherbot` logs, there are a number of CLs where a reviewer fails to be added due to the error "Change nnn may not exceed 5000 updates. It may still be abandoned or submitted. To continue worki…
Thanks for sending a change. Per https://golang.org/doc/contribute.html#design, please open an issue and fill in the template, then add a "Fixes golang/go#nnn." line here. I'd like to understan…
(1 comment) Thanks for following up!
(1 comment) > For now, let's just bundle all crypto together in the branch, because that's effectively what crypto/internal/boring does. Done, PTAL. The final result diff turned out smaller and mo…
Approved as this 1.14-only regression is a serious issue without a workaround.
I've run into this too when investigating iOS support recently, and temporarily changed to "Apple Development" locally. I haven't followed up on that yet, but just wanted to add a data point.
(1 comment) > Removing encoding/asn1 is easy, removing math/big is not. Got it. Removing encoding/asn1 but keeping math/big would still be an improvement (albeit a smaller one), as it would allow t…
As discussed in [golang.org/cl/241442](https://go-review.googlesource.com/c/go/+/241442/1#message-bb399544c64ab073e5adf50eef6a961dc798ab5e), this is a tracking issue to look into breaking `crypto/int…