Activity

Yesterday
The 'wait-release' hashtag has meaning for humans and release tooling. The 'wait-release' topic can be easy to accidentally apply instead of the hashtag. Add a task to correct such mistakes automatic…
@prattmic We will update it soon, now that we've entered the release freeze, as part of #36905. It's also fine to update it separately for this as needed.
dmitshur closed an issue crypto/tls: make 3DES opt-in10h
[CL 587295](https://go.dev/cl/587295) implemented this, documented the GODEBUG setting and added a release note.
This change is ready for review.
dmitshur commented on net/http: support partitioned cookies13h
See https://go.dev/wiki/MinorReleases. We try to backport as little as possible during minor releases, only critical problems, security fixes and important documentation fixes. This is a new API that…
Thanks. Like for bug fix CLs, test-only CLs will also need to exercise judgement. E.g., there shouldn't be large and possibly risky test-only CL landing later on, e.g., when we're very close to issu…
In addition to the watchflakes reports, the [test history view](https://ci.chromium.org/ui/test/golang/cmd%2Fcompile%2Finternal%2Ftypes2.TestStdlib?q=V%3Abuilder%3Dgotip-linux-arm64-longtest-test_onl…
If I understand correctly, the accepted proposal is to add four new fields to http2.Transport as described in https://github.com/golang/go/issues/57893#issuecomment-1406834509. I updated the title ac…
dmitshur commented on runtime: deprecate func GOROOT14h
A fix CL is available but hasn't been reviewed before Go 1.23 freeze. Moving to the next milestone.
Reopening since [CL 529816](https://go.dev/cl/529816) was rolled back in [CL 571695](https://go.dev/cl/571695), and a roll forward hasn't been submitted.
Thanks. Note: A strategy I've seen used sometimes is to always name executable binaries with a ".exe" suffix, even on non-Windows OSes. It has no effect there. End result is slightly fewer special c…
Thanks.
(1 comment) Added. Also reworded slightly to say "the command", similarly to how it's done in the previous paragraph.
Merged as [CL 587717](https://go.dev/cl/587717) (commit fd1363240ac22583125d43d8e15f130f02a7659b).
This Week
dmitshur reviewed +1 on crypto/tls: add ech client support1d
(1 comment) (nit) Is it useful to keep the no-op `true && `?
(1 comment) I considered including that but it seemed like a detail that someone interested in using the flag could look up from the cmd/go documentation. This release note was intended to call atte…
dmitshur commented on cmd/go: add go mod tidy -diff1d
A new flag likely needs a release note. Sent CL 587695.
Add a release note for the flag that CL 585401 added. For #27005. For #65614.
Thanks.
dmitshur commented on crypto/tls: disable 3-DES by default1d
(1 comment) @filippo@golang.org FYI this needs a trivial rebase to resolve conflict with CL 584117. (Sorry!)
dmitshur commented on crypto/tls: disable 3-DES by default1d
Sounds good. Thanks.
By now the supported and tested Go versions are Go 1.22 and 1.21. Update the website deployment to start using the Go 1.22 runtime. See https://cloud.google.com/appengine/docs/standard/lifecycle/supp…
Whoops, I triggered trybots a bit too quick, before CL 587415 finished being auto-submitted. Restarting.
Thanks.
pprof test failure looks like #67563. Not this CL.
Pull in latest changes to x/build/relnote. Its functionality will be used for the go.dev/doc/next page. For golang/go#64169.
Go release notes always start out as a draft with a clear notice. That notice is removed when the final release (go1.N.0) is made. For example, the last time was in CL 562255. Add this to the Go 1.2…
Thanks. Please undo the change on this line. To work as a link, it would need to be written as `structs.HostLayout`, but in this context just `HostLayout` is a better fit.
Thanks.
(1 comment) I'm still not sure what a `*BannerError` with a nil `Err` field would represent and whether it makes sense to try to support it. But it seems reasonable for the `Error` method not to pan…
(1 comment) Would it be better if the Err field had a comment stating it's expected to have a non-nil value? ```suggestion Err error // non-nil ``` As is, the documentation doesn't really say…
This is #67502, unrelated to changes in this CL. Bypassing since everything else passed.
(1 comment) Thanks. I would still suggest including the 'Cq-Include-Trybots' footer in the commit message since it eliminates the possibility of the CL being submitted without a positive signal from…
dmitshur commented on crypto/tls: add ech client support2d
(1 comment) Git considers only the lines in the last paragraph as trailers, so this blank line causes the Cq-Include-Trybots: line to appear in the second-last paragraph and therefore be a no-op. Se…
@Jacalz and I discussed https://github.com/go-gl/glfw/issues/188#issuecomment-1982945940 offline; I believe we agreed it's not something we can pursue in a way that works with the [Go module](https:/…
dmitshur commented on github.com/go-gl/glfw: GLFW v3.43d
Thanks for getting it this far. I've been using this locally on macOS and haven't spotted any more issues on this platform and in my usage. --- > Forgot to mention, @dmitshur can you test with …
dmitshur reviewed +2 on doc: simplify links for release notes3d
Thanks.
Thanks. I'll David look since he's more familiar with this, but to me it seems fine to submit since this change is only affecting a port that you maintain and https://storage.googleapis.com/go-build-…
Noting here that the maintner service's [`ListGoReleases`](https://pkg.go.dev/golang.org/x/build/maintner/maintnerd/apipb#MaintnerServiceClient.ListGoReleases) API call might be useful for this. <…
Yes, for that please file a new issue as described at https://go.dev/wiki/GerritAccess#requesting-access. Thanks.
secret.InitFlagSupport doesn't always succeed. Handle things when it returns a non-nil error. Also apply gofmt.
This issue tracks turning this on in the coordinator codebase (see [here](https://cs.opensource.google/go/x/build/+/master:dashboard/builders.go;l=1484-1486;drc=4ee487b137da815f5e68acb20a18dc0e6f9693…
dmitshur reviewed +2 on doc: simplify links for release notes3d
Thanks. Thanks for checking this.
The plan/386 port doesn't bootstrap at this time. Remove it from the current misc-compile trybot set to get them passing while the Plan 9 issue is being investigated and fixed. For golang/go#67502.
(1 comment) (nit) The lines in this list are sorted; if you don't mind please apply that to the new lines too. It's not a big deal and can happen in a future CL instead.
(2 comments) Thanks. Done. It doesn't seem to add much to the error message, so removed everywhere. Done.
Last Week
dmitshur starred github.com/skx/cpmulator5d
This is a tracking issue to port the behavior implemented in coordinator for #61925 to the LUCI side in [golangbuild](https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/experimental…
dmitshur closed an issue security: fix CVE-2023-393245d
As reported by the plan9-386-0intro builder and legacy misc-compile-plan9-386 trybot, the plan9/386 port fails to bootstrap: ``` gotip $ git rev-parse HEAD e7bf9959fd9ea649e1513cef16f91f81b13604…
Thanks. Note that Run-TryBot+1 triggers legacy trybots only. It's necessary to use Commit-Queue+1 to satisfy the 'TryBots-Pass' submit requirement.
Our migration to [LUCI](https://go.dev/wiki/LUCI) should make a meaningful improvement for golang.org/x repo result views. Using a recent issue #67439 as an example, where CL 546676 introduced a n…
Adding a few investigative notes. As visible by comparing [here](https://ci.chromium.org/ui/test/golang/net%2Fhttp.TestServerReadAfterWriteHeader100Continue%2Fh1) and [here](https://ci.chromium.or…
(1 comment) Would it be better to apply the same change here as in sum32a.Sum? ```suggestion return byteorder.BeAppendUint32(in, v) ```
CC @golang/windows, @ianlancetaylor.
dmitshur closed an issue access: may-start-trybots6d
Thanks for your contributions and helping maintain the ppc64 and ppc64le ports. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybots](https://go.…
One additional CL would also need to be reverted to fix the build. The fix forward in CL 586516 was prepared quickly and is submitted now. Closing.
Thanks. I'll prepare the rollback in CL 586515.
This reverts CL 544455. Reason for revert: Breaks linux/arm and 9 more ports. For #61395.
linux/arm and a number of secondary ports are failing to make.bash as of this CL. Please comment if you think the fix is small and can be done soon, otherwise let's revert.
Issue #67439 is fixed by CL 586315, so this change is no longer needed. I think the original implementation is marginally better, and it relies on intended net/http behavior that shouldn't regress.
This doesn't reproduce each time for me, but I saw it happen again today after running these commands in my development GOROOT directory today: ``` src $ git-branches | Branch | …
Note that Go 1.22.2 is not the current latest version. That version is Go 1.22.3, released 10 days: https://groups.google.com/g/golang-announce/c/wkkO4P9stm0. Go 1.22.3 includes fixes for CVE-2024-24…
From looking at https://ci.chromium.org/ui/p/golang/g/port-freebsd-riscv64/builders, the builder seems to be producing good testing signal. @mengzhuo Would you like to remove its [known issue](https:…
Thanks for reporting. CC @golang/release, @mknyszek. Are you able to narrow down more specifics of where the additional bandwidth utilization comes from? Is it uplink or downlink? The testing s…
Thanks for reporting this. The git configuration surface is quite large, and this appears to be a case where one of the configuration values conflicts with the expectations of git-codereview, caus…
Thanks for reporting. Some notes from when I briefly looked in case they're helpful. cmd/dist sets GOPATH env var (which in turn sets the module cache location) to $GOROOT/pkg/obj/gopath during the …
Let's use Commit-Queue+1 to trigger trybots in this CL. See https://go.dev/wiki/LUCI#trybots.
Thanks. @imcusg@gmail.com Please see https://go.dev/wiki/LUCI#trybots for current information on how to trigger trybots. In most cases you should use Commit-Queue+1 vote, not the legacy Run-TryBot+1…
Thanks for reporting. CC @golang/release. First, can you try and see if you're able to start slowbots by including a `Cq-Include-Trybots: luci.golang.try:gotip-linux-loong64` git footer in the com…
dmitshur commented on access: merge my Gerrit accounts6d
Sorry for the trouble, I didn't realize it wouldn't have effect on your newer CLs. Since it's only two of them and both haven't begun code review yet (and one of them needs a merge conflict resolu…
Thanks for getting to this point. The bot is visible at https://chromium-swarm.appspot.com/bot?id=illumos-amd64-jclulow. As you noted, it's identifying itself as having a cipd_platform value of "s…
Thank you for working on this and your patience. I'd like to try to help move this forward. Apologies for not commenting here sooner. We don't quite have an ideal existing builder that we can poin…
This particular issue tracks the Android emulator-based builder. I've had a chance to prototype it earlier, and will update it as further progress is made. @changkun, at this time this issue doesn…
(1 comment) Consider adding a `Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest` footer (detailed instructions [here](https://go.dev/wiki/SlowBots#using-slowbots)) so trybot signal wo…
(1 comment) I retitled the issue to be about net/http.
Looks good to me, but I'll leave it to Jonathan to look, so +1. Left a few minor comments that I spotted. Thanks. (nit) https://go.dev/wiki/Spelling suggests using a different spelling for this part…
Hold because CL 586315 will restore the net/http behavior, and this shouldn't be needed.
CC @golang/runtime, @alexbrainman.
CC @golang/darwin, @ianlancetaylor.
CC @golang/tools-team.
(1 comment) This is dead code now; removed.
We can call this done. At least no use in tracking this via an open issue anymore.
I sent [CL 586077](https://go.dev/cl/586077) which fixes the immediate problem on the x/build side. It'd be good for Damien to check if this is working as expected.