Activity
Today
dmitshur commented on golang.org/x/build/cmd/relnote: added markdown summary info from issue and CLs for each TODO1m
(1 comment)
Hmm, I should've put that code in a block that so the Markdown string doesn't render in the Gerrit comment view. π
```
fmt.Sprintf("TODO: accepted [proposal %d](/issue/%[1]d)", num)
β¦dmitshur commented on golang.org/x/build/cmd/relnote: added markdown summary info from issue and CLs for each TODO3m
Thanks for doing this. A couple suggestions I was thinking about, since you're already planning to improve this to handle link generation better. I'll review after that.
I'm not sure I understand thβ¦dmitshur reviewed +2 on golang.org/x/website/_content/doc: make TODO cl and issue links in go1.27.md work8m
Thanks. I was going to leave this suggestion on relnote tool CL too.dmitshur commented on cmd/go: [release-branch.go1.26] use fsys.ReadDir for IsStandardPackage35m
(1 comment)
Not (yet) applied here.dmitshur commented on cmd/go: [release-branch.go1.25] use fsys.ReadDir for IsStandardPackage42m
Trybot failures need attention.dmitshur commented on cmd/go: [release-branch.go1.26] use fsys.ReadDir for IsStandardPackage42m
The trybot failures seem related to the backport. Please add this back to my attention set once that's resolved.
```suggestion
Fixes #79721
```dmitshur reviewed +2 on reflect: linkify the docs for Value.Seq and Value.Seq250m
Thanks.
FWIW, I tried looking a bit into how doc comment linking can be used when brackets are involved, and found it may be viable to do some linking.
That is, it is possible, though it does mean β¦dmitshur reviewed +2 on golang.org/x/build/main.star: enable x repos on openbsd-arm64 builder54m
Thanks!dmitshur commented on api: promote next to go1.271h
Filed #79733 for the problem in cmd/api.dmitshur commented on api: audit for Go 1.271h
Thanks for catching that. Filed #79737 for cmd/api.dmitshur opened an issue cmd/api: misses encoding/json/v2 API changes1h
@prattmic noticed and reported in https://github.com/golang/go/issues/79733#issuecomment-4575506443 that the cmd/api tool missed encoding/json/v2 API changes. It may be related to the API being gatedβ¦dmitshur commented on cmd/go: document new `go mod tidy` behavior2h
Thanks for preparing this release note.
The doc/next files in this repo were deleted in CL 784700. The process of filing the API audit issue (#79733) and merging the release note fragments into x/weβ¦Yesterday
dmitshur commented on golang.org/x/build/internal/relui: only run TestRelease/major on 1.26 and newer15h
Thanks.dmitshur commented on golang.org/x/build/internal/relui: unskip TestRelease/rc test15h
Thanks.dmitshur reviewed +2 on doc: format net package release note15h
Thanks.dmitshur reviewed +2 on doc: inserted TODOs into 9-todo.md15h
Thanks.dmitshur reviewed +2 on doc: inserted TODOs into 9-todo.md19h
Thanks. I think this is good to merge as soon as the trybot failure is fixed. The improved format will make it easier to many people to follow up in parallel on addressing the TODOs, so no need for tβ¦dmitshur commented on golang.org/x/exp/typeparams: update termlist, typeterm source files19h
> One caveat, seems like go mod tidy doesn't delete the empty go.sum file...
Ah, yeah. Maybe that's solvable with a 4th line like:
```
//go:generate rm go.sum # workaround for go.dev/issue/36236
`β¦dmitshur commented on sort: add go:fix inline directives to convenience wrappers22h
(1 comment)
This note was intentionally added as regular text for readers, rather than deprecating the symbol, to avoid creating churn.
Now that go:fix inline can reduce the toil in migrating from β¦dmitshur commented on golang.org/x/build/cmd/relui: add govulncheck-action repo tagging workflow1d
Thanks for working on this, and sorry about the review latency. In general, this looks good and makes sense. Thanks for implementing all the steps involved in tagging and following up.
I left a numbβ¦dmitshur commented on golang.org/x/build/cmd/relui: define a govulncheck-action tagging workflow1d
It's good that you're taking into account that there is a general-purpose tagging workflow in relui (I was going to mention it in CL review too). That said, that workflow is intended to work on all oβ¦dmitshur reviewed +2 on golang.org/x/build/cmd/gomoteserver: add Kubernetes health checks1d
Thanks.
This makes sense to me. My one minor comment is about possibly simplifying the probe configuration a bit, but I have no objections to any of it if it helps.
From briefly re-reading about hoβ¦dmitshur closed a change golang.org/x/build: Expose more ReviewInfo fields in the Go Gerrit client1d
This PR is being closed because [go.dev/cl/234660](https://go.dev/cl/234660) was closed.
The x/build/gerrit [package comment](https://pkg.go.dev/golang.org/x/build/gerrit#pkg-overview) is now moreβ¦dmitshur commented on golang.org/x/build: Expose more ReviewInfo fields in the Go Gerrit client1d
This PR is being closed because [go.dev/cl/234660](https://go.dev/cl/234660) was closed.
The x/build/gerrit [package comment](https://pkg.go.dev/golang.org/x/build/gerrit#pkg-overview) is now moreβ¦dmitshur closed a change golang.org/x/build: Expose more ReviewInfo fields in the Go Gerrit client1d
dmitshur commented on os: notify testlog from (*File).Chdir1d
This should be covered at https://go.dev/wiki/MinorReleases. In particular, see this paragraph:
> When the child issue is labeled CherryPickApproved, the original author of the change fixing that isβ¦dmitshur opened a change golang.org/x/website/go.mod: pull in "relnote: include file name for stdlib minor changes"1d
Pull in x/build CL 783780 so that its effect on the /doc/go1.27 page
applies sooner.This Week
dmitshur opened a change golang.org/x/build/internal/relui: unskip TestRelease/rc test1d
It's preferable to be able to run the TestRelease/rc test ahead of the
upcoming RC 1 release, and see that it passes. Make that possible with
a fairly small scope reduction in the FakeCloudBuild implβ¦dmitshur opened a change golang.org/x/build/internal/relui: only run TestRelease/major on 1.26 and newer1d
A fixup for CL 768223 to unbreak x/build tests with Go 1.25.dmitshur reviewed +2 on golang.org/x/exp/typeparams: deprecate and inline aliased functions1d
> as far as I know that is not considered an "API change" and so no proposal needed
I prepared CL 783580 but became less sure about that. After all, a similar argument may apply - adding a go:fix inβ¦dmitshur commented on golang.org/x/exp/typeparams: update termlist, typeterm source files1d
I suspect it may work to make GO111MODULE=on work by taking advantage of go:generate directives being defined to execute in a predictable order, and doing something like:
```
//go:generate go get goβ¦dmitshur commented on testing: allow examples to return an error1d
(Someone may extend that argument to say that it's odd to accept an error return from example and test functions, but not from net/http [handlers](https://pkg.go.dev/net/http#Handler).)dmitshur commented on cmd/go: check that insecure scheme is permitted by GOINSECURE1d
This change is ready for review.dmitshur commented on cmd/go: start a test case for an insecure scheme check1d
(1 comment)
This change is ready for review.
(nit) This should maintain a trailing newline. A self-reminder to remember to push a patch set with a fix.dmitshur opened a change cmd/go: start a test case for an insecure scheme check1d
This is before the fix. The test case passes, but it's exhibiting the
buggy behavior. The next CL implements a fix and updates the test case
to require intended behavior.
The test case defines a vcsβ¦dmitshur commented on cmd/go: concurrent map writes in `go/build.(*Context).Import`1d
@prattmic Do you happen to have a link to the build handy? I tried looking over the last few https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-linux-amd64-noopt and didn't spot this fβ¦dmitshur reviewed +1 on os/signal: [release-branch.go1.26] make NotifyContext Cause match context.Canceled1d
dmitshur reviewed +2 on go/types: add simd/.../sgutil to the TestStdlib ignores1d
Thanks.
I left a comment at https://go.dev/issue/79676#issuecomment-4557824015 on a similar issue. It seems to apply to issue #79677. The test is passing at the tip commit of the main branch. But maβ¦dmitshur commented on golang.org/x/build: add LUCI openbsd-arm64 builder1d
@4a6f656c Should we take the next steps towards removing the known issue for this builder, so that it starts to shows up at https://ci.chromium.org/p/golang/g/go-gotip/console instead of only appeariβ¦dmitshur opened a change cmd/fix: [release-branch.go1.26] pull in CL 7839601d
Generated with updatestd, though it's equivalent to manually running:
cd src/cmd
go get golang.org/x/tools@internal-branch.go1.26-vendor # v0.39.1-0.20260527181557-0f52e3809b35
go mod tidy
go mod vβ¦dmitshur fixed an issue cmd/compile/internal/types2: TestStdlib failures1d
dmitshur fixed an issue cmd/compile/internal/types2: TestStdlib failures1d
The failures seem to be commits on the dev.simd branch, prior to it being merged into the main branch. The merge conflict that was resolved at https://go-review.googlesource.com/c/go/+/782083/4/src/gβ¦dmitshur commented on cmd/compile/internal/types2: TestStdlib failures1d
The failures seem to be commits on the dev.simd branch, prior to it being merged into the main branch. The merge conflict that was resolved at https://go-review.googlesource.com/c/go/+/782083/4/src/gβ¦dmitshur commented on cmd/compile/internal/types2: TestStdlib failures1d
The build log is large, but "could not import _gen/sgutil (cannot find package "_gen/sgutil" in any of: ..." seems to be the problem inside.dmitshur closed an issue runtime: `SIGSEGV` with a c-shared library and called from C#1d
dmitshur opened a change golang.org/x/tools/go/analysis/passes/modernize: [internal-branch.go1.26-vendor] slicescontains: check for side effects1d
We should avoid suggesting a fix if the needle or predicate may
have side effects. Otherwise, the program behavior may change.
For example, in converting from a loop to slices.ContainsFunc,
the needlβ¦dmitshur commented on os: make tests pass even without Administrator account1d
(2 comments)
Are there still tests that fail when running 'go test os' on Windows without an administrator account after this change? If not, this can become Fixes, otherwise Updates is fine.
The nβ¦dmitshur reviewed +2 on golang.org/x/build/relnote: include file name for stdlib minor changes2d
Copied votes on follow-up patch sets have been updated:
* Code-Review+2 has been copied to patch set 2 (copy condition: "is:ANY").
(3 comments)
For golang/go#64169.
Though I guess by now that issuβ¦dmitshur opened a change sort: add go:fix inline directives to convenience wrappers2d
These will make it easier for callers to migrate to the newer
counterpart, consolidating a redundant older API with a newer one.
For #61180.dmitshur commented on golang.org/x/exp/typeparams: deprecate and inline aliased functions2d
I think it's a good idea to add //go:fix inline directive, and as far as I know that is not considered an "API change" and so no proposal needed. But deprecating symbols does need a proposal. Up to yβ¦dmitshur commented on golang.org/x/exp/typeparams: simplify now that minimum required Go is 1.25.02d
Thanks.dmitshur commented on golang.org/x/exp/typeparams: consider String methods optional2d
Thanks.
This was a minimal change to get the test working at tip. It was only afterwards that I realized the entire 1.17 codepath and the test are made obsolete by the go.mod file's go 1.25.0 directβ¦dmitshur reviewed +2 on doc: document removal of asynctimerchan GODEBUG setting (update release notes)2d
Thanks.dmitshur commented on doc: document removal of gotypesalias GODEBUG setting (update release notes)2d
runtime.TestGoroutineLeakProfile/Istio18454 failure is not caused by this documentation-only change.dmitshur commented on golang.org/x/exp/typeparams: deprecate and eventually delete aliased names2d
I initially left a π reaction, but have since removed it. I mistakenly thought this package's scope was only to cover the transition period, but it turns out there's more. The commit message of [β¦dmitshur opened a change golang.org/x/exp/typeparams: simplify now that minimum required Go is 1.25.02d
This module has a go directive set to 1.25.0. Some of the files have
build constraints that will therefore never be satisfied, such as the
'//go:build !go1.18' constraint in the typeparams_go117.go fβ¦dmitshur commented on go/types: add String methods2d
Sent CL 783322.dmitshur opened a change golang.org/x/exp/typeparams: consider String methods optional2d
TestAPIConsistency correctly reports at Go tip that String methods
on the TypeList, TypeParamList, and Instance types are inconsistent.
They were added in Go 1.27 as part of proposal go.dev/issue/792β¦dmitshur reviewed +1 on doc: document generic methods (update release notes)2d
dmitshur reviewed +1 on doc: document generalized function type inference (update release notes)2d
(1 comment)
This link is missing a leading '/', causing it to break.
```suggestion
contexts where a generic function is [assigned](/ref/spec#Assignability) to a
```dmitshur reviewed +2 on cmd/go/internal/work: add signpost to x/tools vet std test2d
Thanks.dmitshur reviewed +2 on golang.org/x/tools/go/analysis/unitchecker: disable unreachable in vet_std_test.go2d
Thanks.dmitshur fixed an issue golang.org/x/telemetry/config: counters for target GOOS/GOARCH2d
Thanks.
[CL 775981](https://go.dev/cl/775981) added a local counter for the target port GOOS/GOARCH, and [CL 776000](https://go.dev/cl/776000) enabled its uploading for Go 1.27+. We should start seβ¦dmitshur commented on golang.org/x/telemetry/config: counters for target GOOS/GOARCH2d
Thanks.
[CL 775981](https://go.dev/cl/775981) added a local counter for the target port GOOS/GOARCH, and [CL 776000](https://go.dev/cl/776000) enabled its uploading for Go 1.27+. We should start seβ¦dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add go/platform/target/port:*-* counter2d
Thanks.
I take it you mean across multiple lines? Sure, done in PS 3.dmitshur opened a change golang.org/x/telemetry/internal/chartconfig: consolidate indentation in config.txt2d
Some of the lines were indented by 2 spaces, some by 4. Make them all
indented by a single tab, and the viewers can use their preferred tab
width in their text editor. This is based on gofmt using a β¦dmitshur opened a change golang.org/x/build/main.star: include longtest builders in pre-submit in x/vuln2d
The longtest builders in this repository are fast (3 min), and this
should help catch problems that tests miss when -short flag is used.dmitshur commented on cmd/compile: update compiler's PGO profile2d
This should be safe to do before or after Go 1.27 RC 1, probably better no later than RC 2. Added that label for visibility.dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle2d
The two CLs above did the "at the end of dev cycle" update for Go 1.27. Moving to the next.dmitshur fixed an issue runtime/coverage: TestCoverageApis failures2d
Closing since this hasn't happened in a while. [CL 588235](https://go.dev/cl/588235) may have helped (or will help for next time it flakes.) Watchflakes will reopen or file a new issue as needed.dmitshur commented on runtime/coverage: TestCoverageApis failures2d
Closing since this hasn't happened in a while. [CL 588235](https://go.dev/cl/588235) may have helped (or will help for next time it flakes.) Watchflakes will reopen or file a new issue as needed.dmitshur commented on cmd/pprof: update vendored github.com/google/pprof2d
internal/coverage/cfile.TestCoverageApis is a flaky test tracked in issue #74632. It also passed in the parent CL. Bypassing.dmitshur commented on all: update vendored dependencies2d
It also passed in the next CL. Bypassing.dmitshur closed an issue internal/coverage/cfile: TestCoverageApis/emitToFailingWriter failures2d
dmitshur closed an issue internal/coverage/cfile: TestCoverageApis/emitToNonexistentDir failures2d
dmitshur closed an issue internal/coverage/cfile: TestCoverageApis/emitToNilWriter failures2d
dmitshur closed an issue internal/coverage/cfile: TestCoverageApis/emitToDir failures2d
dmitshur closed an issue internal/coverage/cfile: TestCoverageApis/emitWithCounterClear failures2d
dmitshur commented on all: update vendored dependencies2d
TestFileAssociatedWithExternalIOCP looks like a pre-existing flaky test, tracked in issue #73726.dmitshur commented on runtime: remove asynctimerchan GODEBUG setting2d
@gri@golang.org Since you are the author of this change, and self-review in this repository is not allowed, it would be better to leave a +1 vote with your @google.com account rather than +2. This alβ¦dmitshur opened a change all: update vendored dependencies2d
The Go 1.27 code freeze has recently started. This is a time to update
all golang.org/x/... module versions that contribute packages to the
std and cmd modules in the standard library to latest masteβ¦dmitshur opened a change cmd/pprof: update vendored github.com/google/pprof2d
Pull in the latest published version of github.com/google/pprof
as part of the continuous process of keeping Go's dependencies
up to date.
For #36905.
[git-generate]
cd src/cmd
go get github.com/goβ¦dmitshur commented on golang.org/x/build/internal/releasetargets: update for each upcoming major Go release3d
[CL 767441](https://go.dev/cl/767441) generated a preliminary list for Go 1.27. It's the same list as for Go 1.26 except the macOS minimum version became 13, and that's noted at https://tip.golang.orβ¦dmitshur commented on all: announce end of support for old Linux versions3d
There haven't been any accepted proposals related to old versions of Linux during the Go 1.27 development cycle, so moving to the next milestone.dmitshur commented on all: announce end of support for old Windows releases3d
There haven't been any accepted proposals related to old versions of Windows during the Go 1.27 development cycle, so moving to the next milestone.dmitshur commented on all: announce end of support for old macOS releases3d
[CL 739380](https://go.dev/cl/739380) added an entry to the Go 1.27 release notes. Moving to the next milestone.dmitshur commented on os: `go test os` (with and without -short flag) fails because tests involving creating symlinks fail (and aren't skipped) when not running tests as an administrator4d
@alexbrainman Your understanding above about longtest builders is right. Only builders with the "longtest" runtime modifier run `go test` without `-short` flag. All other builders run `go test -shortβ¦dmitshur closed a change golang.org/x/mobile: Create SECURITY.md4d
Last Week
dmitshur closed a change golang.org/x/mobile: Create SECURITY.md5d
dmitshur starred github.com/AlekSi/xfail5d
dmitshur commented on golang.org/x/build/cmd/gopherbot: track Gerrit "Fixes" CLs by applying the "FixPending" label6d
This sounds like a useful automatic behavior. It would help make existing CLs (or lack thereof) easier to see, and it would reduce some of the toil involved in [issue gardening](https://go.dev/wiki/Gβ¦dmitshur commented on golang.org/x/build/cmd/watchflakes: label open issues6d
I agree that -author:gopherbot is probably a reasonable way to filter out such issues. Still, since the Automation label exists and its description matches, watchflakes might as well use it.
Note thβ¦dmitshur commented on golang.org/x/build: extend main Go repo's "every vet check is forcibly made high-confidence" behavior to golang.org/x modules6d
Yes, we can also implement it that way.Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.