Activity

Today
The tooltip for builders with a known issue is displayed consistently as of the last commit, but accessing a link in a tooltip is not easy. It's reasonable to expect that known issues would be li…
Now that #34744 is complete, this became much easier. Fix for this and another issue incoming.
All looks ready for Go 1.18 Beta 1, so moving this recurring issue to the next milestone.
(1 comment) Longtest builders (linux-386-longtest, linux-amd64-longtest, windows-amd64-longtest) are currently configured in x/build/dashboard to primarily on post-submit, and only as TryBots (pre-s…
Yesterday
Confirmed, it should be okay and helpful! As I understand, fuzz targets don't run automatically during all.bash, so this is really low-risk for the stability of the release.
We've discussed macOS today and agreed to use macOS 12 releaselets both for amd64 and arm64 architectures starting with Go 1.18 Beta 1. Send [CL 369958](https://go.dev/cl/369958).
The work to add macOS 12 builders for amd64 and arm64 was completed ahead of Go 1.18 Beta 1, so we have the opportunity to pick between starting to use them or stay with existing macOS 11 builders lo…
+2 if it is needed, since reverting a problematic change sooner is a good step. A question in inline comment. Also add CL number being rolled back per https://go.dev/wiki/CommitMessage#reverts. Whi…
In general it looks great. I left a few minor comments inline, the main one being to consider skipping the test in short mode (if applicable to the needs of the test). It may be possible to make use…
> not tracking health To expand on this, the "macOS ARM64 (M1 Mac minis)" health item in https://farmer.golang.org/#health is tracking the health of `host-darwin-arm64-12_0-toothrot` (this builder),…
Thanks Cherry. We'll wait for the 1.17 workaround to land. I think it can be removed from builder configuration when 1.18 is released and 1.16 stops being supported. So waiting on that.
(1 comment) Nit: s/install/download/.
> This timeout-and-retry behavior @bcmills Is the issue here that there's an unbounded number of transparent retries, or that you consider even a bounded number of retries, like 3, problematic? (O…
This change looks good if you'd like to proceed with turning off builders for x/vuln at this time. (If you'd like to re-enable it in the future, you'd just need to remove noBuildAndNoDash…
This Week
Ok. Everything I learned about this problem earlier showed high reproducibility, so I don't expect it to be flaky, but I'll keep an eye on it just in case.
Since the test is indeed passing on tip even on macOS 11 builder, it seems there's no good reason to have the skip anymore. (In the worst case we'll learn that it doesn't pass all the tim…
I am interested in knowing that too, but I don't have the answer yet. The commit message of CL was written optimistically in case the slowbot will pass, but I don't know yet whether it will. …
TRY=darwin-arm64-11_0-toothrot
Though this was a problem for Go 1.17, it appears not to be a problem on tip. This reverts change made in CL 321349. For #46239.
There's no good issue to backport, but if there was one, it'd be approved as a test-only fix. Other than for potential builder name changes while 1.17 is still supported.
(1 comment) The deleted block removes with it the last remaining link to the App Engine version list in x/website. Is it being deleted in order for that page to be intentionally de-emphasized? If s…
(1 comment) I don't understand why this is being added. It seems like a no-op. If it's intentional, then it's fine.
Now that it's available, using a relative link is an improvement here. Thanks.
(1 comment) The original spelling of this longer word in PS 2 was okay: > use cancellation (two ells), not cancelation.
(First pass. Will re-review after.) 'cancellation' (two ells) is right according to go.dev/wiki/Spelling. The other ones are one ell, but this one's two ells. Same here. 'cancelat…
This change looks good to me (and I've been looking forward to getting to this point). If I understand the plan correctly, this CL will submitted after submit (or review) access in x/website is …
Actually, the 'app deploy --no-promote' step happens before live server tests are run, so the 10th version will always be available in version list, just not auto-published. (It won't be …
If I understand correctly, if say 10 commits land in a short enough window that their builds run concurrently, then the current use of locktrigger in cloudbuild.yaml will make it so only the last wil…
We haven't been able to find a way to reproduce this, and by now, Go 1.14 is unsupported, so I'll close this issue. If this problem occurs on supported releases of Go (1.17 and 1.16 at this time), pl…
Last Week
dmitshur pushed to master in github.com/go-gl/glfw4d
caad923f49f49da6834c183daae7b59e7fc2e4fcv3.3/glfw: add netbsd support
Thanks, this change looks reasonable, so I'll merge it to move it forward. I think it's fine both to leave out `wayland` tags until they're supported, but also okay to include them proactively giv…
Closed. Thanks very much for everyone's help resolving this.
The work needed to resolve go.dev/issue/49616 looks to be complete, and the builder is passing reliably. Updates golang/go#49616.
With the builder updates that @changkun performed, and as of CL 368054 landing, the iOS builder is passing. If I understand correctly, there's nothing more to do for this issue, right? If so, I'll…
Leaving to Ian to review. Just adding a +1 because the change makes sense to me. Since the builder variable is used only on next line and fairly short, if you haven't already considered/noticed …
Thanks. Minor nit: Markdown syntax is usually not used in Go commit messages, as mentioned at https://tip.golang.org/doc/contribute#main_content.
If the blog entries won't be inlined, it seems reasonable to display more entries. It doesn't need to show all, since that's what https://go.dev/blog/all is for. Unless /blog simply replaces the need…
(1 comment) Please note that we'll also need to update our tooling that makes a release announcement tweet to be in sync, so having stable output (covered by a test) is more important.
(2 comments) This doesn't appear to be done. Was it accidentally missed, or would you like to take a different approach? Given how easy it is to add a test to capture the intended output, I sug…
I don't know every command/flag that's listed, but all seem reasonable.
The builder has been missing for a number of weeks and isn't showing signs of coming back. We have test coverage for linux/riscv64 via two other builders, and Brad said he was happy to stop runni…
> Do you know what happens if SECURITY.md file isn't present? I checked: https://github.com/seankhliao/testrepo-666 does not have a SECURITY.md, and https://github.com/seankhliao/testrepo-666/issu…
Thanks for reporting. Indeed. We can either: 1. Remove the custom "Security Vulnerabilities" contact link from `.github/config.yml`: https://github.com/golang/go/blob/c4a8550421ce16f233b48a8…
As expected, now that CL 366736 has landed, the way GitHub handles https://github.com/golang/go/issues/new doesn't seem great, and we should probably make this change to avoid some people not see…
dmitshur merged a change .github: use multiple issue templates5d
I've made [CL 369154](https://go.dev/cl/369154) that adds special handling of existing `go.dev/issue/new` links for if we need it.
dmitshur reviewed +2 on .github: use multiple issue templates5d
Thanks everyone for getting it to this point. Let's try it out, and go from there.
The macOS 12 builder environments had `MallocNanoZone=0` added to work around #49138. This is the tracking issue to remove that workaround once it is no longer needed. @cherrymui [CL 367916](https…
As of [CL 362496](https://go.dev/cl/362496) (CC @rsc), a copy of live server data is embedded in the `golangorg` binary, allowing the go.dev/dl/ page to be rendered and developed locally without need…
Start using the new shorter go.dev domain name where applicable, such as when making announcement tweets. The previous name will always work too, but we want to be consistent and up to date in our ex…
The account "gobot@golang.org" has again been renamed recently (from "Go Bot" to "Gopher Robot"), so fixing this bug before the next time `gerritbot` restarts should prevent this duplicate thundering…
This looks great. I will review the parent CL 368365, and then come back here. Nit: this parenthesis is unclosed. I think this CL deserves to include "Fixes golang/go#36707", since the late…
(1 comment) Actually done in PS 5.
(3 comments) I wrote this with x/website/cmd/golangorg tests in mind (since this is where the README is located), but it seems better to also include other tests in the module e.g. in x/website/inte…
There's just one more thread to resolve, then can submit. Rob, does that sound good and can we consider this thread resolved, or would you like further changes before we submit this? To me it l…
TRY=longtest
dmitshur reviewed +2 on all: update vendored golang.org/x/tools6d
I confirmed that e212aff is the tip of x/tools, and changes that have landed there should be only those intended for 1.18. I'll let gri look over those, but to me it looks okay. Visually the ven…
Issue #46239 is the cause of the new macOS 12 arm64 builder [consistently failing](https://github.com/golang/go/issues/49926) on the 1.17 release branch. Interestingly, that same test is not failing …
This is indeed the same as #46239. That test has a skip that applies to the macOS 11 builder, which explains why it only fails on the macOS 12 one, due to the different name: ```Go if os.Getenv("…
Maybe this is a duplicate of #46239.
On the 1.17 release branch (but not the 1.16 branch nor tip), the macOS 12 (arm64) builder has been failing since it was brought up. Failures look like: ``` --- FAIL: TestIssue25756pie (1.20s)…
dmitshur merged a change misc/ios: bump min version6d
(1 comment) Correction, only applies to 1.16 here; 1.17 already has that fix since beginning and didn't need that backport.
(2 comments) I see two cmd/go changes, "fix mod_get_direct" and "forward the MallocNanoZone variable to script tests". Both of those are test fixes. We usually don't mention comp…
dmitshur reviewed +2 on misc/ios: bump min version6d
CC @golang/release in case this is a problem with the builder itself or macOS 12.
It looks like something went wrong during the 'go generate -run=bundle std' step, and changes to the src/net/http/h2_bundle.go file weren't correctly generated, or weren't included in…
dmitshur reviewed +1 on doc/go1.18: add net/http IDNA change6d
Thanks very much for sending this CL, and thanks for the ping. The change looks good to me, but I'll let Damien who is more familiar with proposal #46001 or Jeremy review this. Trivial nits: it…
Thanks @TimothyGu, I'll close this issue then. Please comment if we missed something here, or file a new issue if there's a new problem.
(1 comment) This change isn't needed here but is also harmless, so fine to keep.
@mknyszek For visibility, the backports in x/net's internal-branch.go1.x-vendor branch will also need to make their way into the main Go repository's release-branches as described in https://go.dev/w…
Approved as a test-only fix. It is needed to resolve trybot failures on release branches.
@zx2c4 If you believe an existing issue should be treated as security-related, please take a look at https://go.dev/security#flagging. Thanks.
We don't make Go 1.15 minor releases by now, so including the darwin-arm64 build "for Go 1.16 Beta 1 and newer" is the same as always including it. Also update test coverage that the lis…
By now we have darwin builders with macOS 12 both on amd64 and arm64 architectures (#49149), though that work is still evolving. We will consider whether to use them or still use macOS 11 for buildin…
CL 365736 updated the builder to macOS 12 out of necessity, since the macOS 11 builder was not available then. Based on discussion since, the builder is back though in limited capacity. Continue to u…
Approved as a serious problem without a workaround per discussion in a release meeting. Go 1.17 and 1.16 are both getting this fix.