Activity
Today
dmitshur reviewed +2 on golang.org/x/build/...: add builder for release branch3h
Makes sense and seems reasonable to me. Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: pass advisory trybot when context canceled3h
I'm fairly confident this will work to resolve the immediate issue. (And if not, we'll learn why not by trying.)
Thanks.
As I understand, this Printf ends up being fairly load-bearing: it indirectl…dmitshur commented on crypto/rand: TestRead: panic on js/wasm 5h
CC @golang/js, @golang/security.dmitshur reviewed +2 on golang.org/x/build/...: fix some comments6h
Thanks.Yesterday
dmitshur reviewed +1 on crypto/rand: batch large random reads on js15h
Thanks for working on this, this generally makes sense and looks right to me. I left 2 optional thoughts/comments, will give other reviewers a chance to look too.
As an optional idea, you could comb…dmitshur reviewed +1 on golang.org/x/website/internal/history: add Go 1.20, remove release notes draft notice22h
Looks good to me; leaving to Matt.dmitshur reviewed +1 on golang.org/x/build/...: add release-branch.go1.20 view and poller23h
dmitshur reviewed +2 on cmd/dist: keep flag list sorted1d
Thanks. (I didn't notice the flags were sorted when adding -force in CL 458515; will check for that in the future.)dmitshur commented on cmd/compile: A GOOS=wasi GOARCH=wasm compilation target1d
CC @golang/release.dmitshur reviewed +2 on misc/wasm: extend executable compatibility1d
It also increases consistency with make.bash, etc.
Thanks.dmitshur reviewed +1 on doc: move Go 1.20 release notes to x/website1d
Thanks.dmitshur reviewed +1 on golang.org/x/website/_content/doc: add Go 1.20 release notes1d
Looks good to me, just giving Matt a chance to also look. Thanks.dmitshur commented on golang.org/x/build/dashboard: re-enable js/wasm TryBot (with Node 18)1d
Adding Hold on this one until the "all.bash is passing with Node.js 18" part is done.dmitshur reviewed +2 on misc/wasm: use NodeJS performance library1d
Thanks.dmitshur reviewed +2 on net/http: disable fetch on NodeJS1d
Thanks.dmitshur commented on net: HTTP GET on local HTTP server fails with "fetch failed" on js/wasm with Node.js 181d
Thanks for investigating this and figuring out the problem.
> Would love **@neelance**'s thoughts on a NodeJS based socket syscall interface, I assume the reason we didn't introduce one origina…dmitshur reviewed +2 on misc/wasm: use NodeJS crypto library1d
Thanks.
Johan, please take a look at CL 463915. Once it's reviewed, I can redeploy coordinator is redeployed and it'll become possible to get passing trybots here. (We can't really rely on TryBot-By…dmitshur commented on runtime: always use LoadLibraryEx to load system libraries1d
(1 comment)
I understand you're aware the current plan is to require at least Windows 10 per latest status of #57004 (so it's indeed true that it'll be greater than Windows 7 for purposes of this CL…dmitshur commented on lib/time: update tzdata before release1d
@qmuntal Do you know the frequency of [windowsZones.xml](https://github.com/unicode-org/cldr/blob/main/common/supplemental/) (the source for zoneinfo_abbrs_windows.go) changes?
If it's tied to the s…This Week
dmitshur reviewed +2 on internal/syscall/windows: regenerate zsyscall_windows.go1d
Thanks.Last Week
dmitshur commented on time: update windows zoneinfo_abbrs3d
(1 comment)
Perhaps change this to "Fixes" since that issue is in Go 1.21 milestone, and it seems there's nothing more to do for it. Also fine to close the issue manually too.dmitshur commented on golang.org/x/build: `linux-arm.*-aws` TryBots are often stragglers3d
Here's the event log from the [aforementioned](https://github.com/golang/go/issues/54679#issuecomment-1407113776) 20-minute TryBot run, for reference:
<details><br>
```
builder: linux-arm-aw…dmitshur reviewed +2 on golang.org/x/build/internal/relui: modify advisory trybots4d
dmitshur opened a change golang.org/x/build/dashboard: disable js-wasm TryBot (with Node 14) on Go 1.21 tree4d
The js/wasm port maintainers are getting ready to start landing changes
for Go 1.21 that replace Node.js 14 support with Node.js 18 support.
Disable the js-wasm TryBot on tip so that work can start t…dmitshur reviewed +2 on golang.org/x/build/dashboard: remove openbsd-mips64 from misc-compile-openbsd4d
Thanks.
Mentioning the issue in a comment on this line could be helpful, but it’s also fine as is since context can be found via git blame.dmitshur opened an issue golang.org/x/build/internal/task: update the minimum macOS version in the Go 1.21 installer4d
Similar to #58028, for Go 1.21 we should update the macOS minimum version requirement from [10.13](https://github.com/golang/build/blob/39ddd66f41da17065d8f700e8e64e006dccf6032/internal/task/buildrel…dmitshur reviewed +2 on golang.org/x/build/dashboard: remove -d=dclstack compiler flag for ssacheck builder4d
Thanks.dmitshur commented on encoding/binary: add var NativeEndian5d
(3 comments)
(nit) Delete the '//' characters here. This can be a blank line instead.
As mentioned at https://go.dev/doc/comment, every exported identifier should have a doc comment.
(nit) Here to…dmitshur reviewed +2 on golang.org/x/build/internal/relui: modify advisory trybots5d
Thanks. LGTM with an inline comment suggesting to handle errors closer to call site for you to consider.
(trivial) Both `attempt++` and `attempt += 1` have the same behavior here. I'm curious why th…dmitshur commented on golang.org/x/build/internal/relui: modify advisory trybots5d
Thanks, this generally looks good and makes sense. See some minor comments.
(nit) Maybe just "Wait for advisory TryBots", since approving failures is only needed when failures happen, which hopefull…dmitshur commented on golang.org/x/build/internal/relui: modify advisory trybots5d
(1 comment)
I believe this already has the default retries, since it doesn't opt-out via ctx. DisableRetries, so it doesn't need a second layer of retries. Is this comment left behind by accident or…dmitshur commented on golang.org/x/build/dashboard: limit windows-{386,amd64}-2012 to build at most Go 1.205d
(That's my current understanding too. Replied on the issue.)dmitshur commented on golang.org/x/build: add a windows/386 builder with Windows 10 or newer5d
In CL 463579, @heschi commented:
> For my understanding, is there some particular difficulty setting up a windows-386-2016 builder? This one was just a GOARCH setting on top of the amd64 OS, right…dmitshur commented on runtime: use explicit NOFRAME on windows/amd645d
That builder just needs to be updated not to test tip (where 1.21 development is currently happening) per accepted proposal #57003. I've sent CL 463578 for that.dmitshur opened a change golang.org/x/build/doc: delete commented out staging section5d
The staging section was commented out because that environment is not
supported. It's still visible when viewing the .md file in its raw form
and has proven to cause confusion. Since we can easily ge…dmitshur commented on testing: exit status 0xc0000139 with -race + external linking on windows-amd64-20085d
I agree we should do that. Filed #58008 for tracking it.dmitshur opened an issue golang.org/x/build/dashboard: update windows*{2008,2012}* and darwin-amd64-10_14 builders with atMostGo1(20)5d
Go 1.20 will be the last Go release with support for some OS versions, as documented at https://tip.golang.org/doc/go1.20#ports. The corresponding builders should be updated not to to test commits at…dmitshur opened an issue golang.org/x/build: add a windows/386 builder with Windows 10 or newer5d
The latest builder for the windows/386 port at this time is windows-386-2012 (Windows 8/8.1).
That builder will be going away as part of #57004.
As long as windows/386 is one of the first class por…dmitshur commented on test/codegen: merge identical ppc64 and ppc64le tests5d
(1 comment)
Is it relevant that one of the lines has -"ORN", the other has -ORN" (missing double quote)?
This seems to be the only instance in this file.dmitshur commented on golang.org/x/pkgsite-metrics: initial commit6d
(1 comment)
AUTHORS files aren't included in golang.org/x repos as of mid-2022 (see https://go-review.git.corp.google.com/q/topic:%22noac%22).dmitshur created repository in github.com/golang/pkgsite-metrics6d
Code to serve pkg.go.dev/metrics [mirror]
dmitshur reviewed +2 on github.com/mdempsky/unconvert: update deps and bump go.mod to 1.186d
dmitshur commented on golang.org/x/sys/cpu: add IsBigEndian6d
(1 comment)
(nit) In almost all .go files in golang.org/x repos, the copyright header comment is separated from build constraints with a blank line. x/sys/unix/endian_{big,little}.go are the few rar…dmitshur reviewed +2 on golang.org/x/build/dashboard: only test nounified on release-branch.go1.206d
Thanks.
Consider also adding "Fixes golang/go#52150." since it seems x/tools tests are fixed for GOEXPERIMENT=unified and there's nothing more to do for it.dmitshur commented on golang.org/x/build: shut down -unified and -nounified builders6d
Makes sense, thanks.dmitshur commented on golang.org/x/build: shut down -unified and -nounified builders6d
@mdempsky Just confirming: is it not useful on release-branch.go1.19 because it doesn't support GOEXPERIMENT=nounified, only 1.20 does?dmitshur opened a change test: break helloworld.go test case1w
DO NOT SUBMIT: This is a test to see how different platforms report
a failing test case.dmitshur commented on net: HTTP GET on local HTTP server fails with "fetch failed" on js/wasm with Node.js 181w
Also CC @Pryz, @evanphx who've recently joined as Wasm maintainers in #57968. (Thanks!)
Investigating and resolving this issue will help unblock progress on #57614.dmitshur opened a change cmd/dist: convert test/run.go runner to a cmd/go test1w
DO NOT SUBMIT: This is currently a WIP prototype.
For #37486.
Fixes #56844.dmitshur reviewed +2 on golang.org/x/website/_content/security/fuzz: fix transparent image for dark theme1w
Thanks.
> the images are downloaded twice
That's a good point. Maybe combining all desired aspects (3-way theme selector support, repetition-free syntax, deferred image variant downloading) will be…dmitshur starred github.com/zserge/fenster1w
dmitshur reviewed +2 on golang.org/x/build/cmd/gomote: add missing entry in isGoToolDistGenerated1w
Thanks.
Consider adding ^ and $ to start/end of the regexp, since it needs to match an entire line.
(style nit) Since this is checking the error from the immediate WalkDir call above (line 41), the…dmitshur commented on all: implement wasmimport directive1w
The tree is open for Go 1.21 development as of Thursday (see #57736 and https://groups.google.com/g/golang-dev/c/09IwUs7cxXA/m/c2jyIhECBQAJ).Earlier
dmitshur commented on test: add JSON output support to the run.go program1w
I've started working on this more actively recently and made enough progress to post an update. I think I have a good idea for the general implementation plan here: as expected, it'll be to migrate t…dmitshur reviewed +1 on golang.org/x/build: Add first CI builder1w
(1 comment)
(trivial nit) Two blank lines here, as opposed to one like between other sections.dmitshur commented on cmd/dist: add support for broken ports1w
With the changes above, I believe this is complete. Closing. Please comment if I missed something.
(For now, only the incomplete linux/sparc64 port was marked as broken. If some approvers believe …dmitshur closed an issue cmd/dist: add support for broken ports1w
dmitshur commented on cmd/dist: mark linux/sparc64 as a broken port, remove incomplete map1w
TRY=longtestdmitshur commented on cmd/compile/internal/ssa: generate code via a //go:generate directive1w
TRY=longtestdmitshur reviewed +2 on golang.org/x/build/dashboard: remove openbsd-{386,amd64}-711w
dmitshur reviewed +2 on golang.org/x/build/dashboard: remove openbsd-{386,amd64}-711w
Thanks.
Please shorten the text in the PR description to "Fixes golang/go#57585", rather than the URL, to be consistent with the convention documented at https://go.dev/doc/contribute#ref_issues.dmitshur commented on golang.org/x/build/env/windows-arm64/aws: delete1w
Thanks.dmitshur opened a change golang.org/x/build/env/windows-arm64/aws: delete1w
The Windows ARM64 builders on Azure have replaced the Windows ARM64
builders on AWS by now. Remove unused environment configuration; we
can bring it back or look it up in history if needed.
Updates …dmitshur commented on golang.org/x/tools/go/analysis/passes/loopclosure: [internal-branch.go1.20-vendor] avoid panic in new parallel subtest check when t.Run has single argument1w
(1 comment)
Thanks.dmitshur commented on golang.org/x/tools/go/analysis/passes/loopclosure: avoid panic in new parallel subtest check when t.Run has single argument1w
(CL 454118 fixed that test failure, but isn't currently included on the internal-branch.go1.20-vendor branch.)
Since this CL isn't on the main branch, should it have a "[internal-branch.go1.20-vendo…dmitshur reviewed +2 on misc/reboot: overlay $GOROOT/lib in temporary goroot1w
Thanks.
(nit) Perhaps update to {src,lib} to be more precise in this log message.
Also, maybe either remove the blank lines on lines 46 and 51 since the entire block is being timed, or move the ove…dmitshur commented on golang.org/x/build/dashboard: restrict power10 trybot usage to go1.20 and newer2w
(1 comment)
One other idea: you could consider setting this field to {1, 20} for this builder. Its effect will be limited, but may be better than nothing.dmitshur commented on golang.org/x/build/dashboard: restrict power10 trybot usage to go1.20 and newer2w
Is there more context you can share? Did this happen on some CLs to motivate this?
This change doesn't achieve the effect stated in the commit message, and I'm not sure if there's a supported way to…dmitshur starred github.com/OpenSAGE/OpenSAGE2w
dmitshur starred github.com/baldurk/renderdoc2w
dmitshur closed a change net: [release-branch.go1.16] skip TestDialCancel on darwin-arm642w
Test done, this CL is no longer needed.dmitshur opened a change net: [release-branch.go1.16] skip TestDialCancel on darwin-arm642w
We're turning up Macs in a network environment that clashes with this
test. I don't think it's critical to get it working, so skip it.
For #49149.
DO NOT SUBMIT: This is a test.dmitshur reviewed +1 on golang.org/x/build/env/darwin/aws: reduce guest CPU count to 42w
Thanks.dmitshur commented on golang.org/x/build/dashboard: add makeScriptArgs for fine control over make script args2w
This part can land during the freeze because it's in x/build. Doing that to reduce chance of conflicts arising.dmitshur commented on golang.org/x/build/dashboard: add OpenBSD 7.1 and 7.2 builders (for 386, amd64)3w
Thanks Joel. To me, disabling (or removing, really) 7.1 builders seems fine, and that would resolve #57585. I'll let OpenBSD port owners follow up as you prefer. Please file a new issue for anything …dmitshur closed an issue os/exec: tests hang on macOS due to Apple libc fork bugs [1.18 backport]3w
dmitshur commented on os/exec: tests hang on macOS due to Apple libc fork bugs [1.18 backport]3w
This was reverted in #57689 and therefore isn't included in Go 1.18.10. Removing CherryPickApproved so it doesn't show up in the list of issues linked at https://go.dev/doc/devel/release#go1.18.10.dmitshur commented on os/exec: tests hang on macOS due to Apple libc fork bugs [1.19 backport]3w
This was reverted in #57690 and therefore isn't included in Go 1.19.5. Removing CherryPickApproved so it doesn't show up in the list of issues linked at https://go.dev/doc/devel/release#go1.19.5.dmitshur closed an issue os/exec: tests hang on macOS due to Apple libc fork bugs [1.19 backport]3w
dmitshur edited the wiki3w
dmitshur closed a change golang.org/x/build/cmd/genbootstrap: add -force flag3w
Closing until I see evidence this would be at all useful. Can be trivially reopened if so.dmitshur reviewed +2 on golang.org/x/build/internal/releasetargts: add windows-arm64-11 as a release target3w
Thanks.
(nit) Missing 'e'.dmitshur closed an issue golang.org/x/build: frequent timeouts running js-wasm TryBots3w
dmitshur commented on golang.org/x/build: frequent timeouts running js-wasm TryBots3w
Sounds good, closing since I haven't seen reports of this in a long while, can reopen or file another issue if this comes up again.
From looking at the initial report, there's also a chance that t…dmitshur commented on github.com/go-gl/glfw: No error handling in v3.33w
go-gl/glfw generally follows the GLFW C API quite closely, but it's a Go package with an API that's meant to be more Go-like and friendly. As such, GLFW function calls that can fail return multiple v…dmitshur commented on golang.org/x/net/http2: TestTransportReturnsUnusedFlowControlMultipleWrites failures3w
> unless we're planning to refresh the `x` dependencies one more time before the final release. (@golang/release can confirm whether that is the case?)
We create internal vendor branches for x repos…dmitshur starred github.com/davideberly/GeometricTools3w
dmitshur reviewed +1 on golang.org/x/build/cmd/gomote: push local VERSION file if it exists3w
dmitshur commented on cmd/compile/internal/ssa: generate code via a //go:generate directive3w
(1 comment)
Sounds good, thanks. Done in PS 3. (I tried to avoid phrasing that could discourage people from just running `go generate ..` in this directory; happy to tweak it further if desired.)dmitshur commented on cmd/internal/osinfo: report Node.js version3w
Before:
```
##### Test execution environment.
# GOARCH: wasm
# CPU:
# GOOS: js
# OS Version: UNKNOWN: error determining OS version: unimplemented
```
After:
```
##### Test execution environment.
…dmitshur commented on cmd/internal/osinfo: report Node.js version3w
TRY=js-wasmdmitshur commented on cmd/internal/osinfo: report Node.js version3w
TRY=js-wasm, js-wasm-node18dmitshur opened a change cmd/internal/osinfo: report Node.js version3w
Seeing the Node.js version that was used during a particular test run
should be helpful during the upcoming migration from Node.js 14 to 18.
Add minimal support for that.
For golang/go#57614.dmitshur commented on cmd/compile: use "satisfies" (not "implements") for constraint errors3w
TestFailure in golang.org/x/exp/constraints will need to be updated in some way after this change; filed #57615 for it.dmitshur opened an issue golang.org/x/exp/constraints: TestFailure fails on Go tip after compiler improved error messages3w
[CL 460396](https://go.dev/cl/460396) improved error messages for constraint errors. It seems TestFailure in x/exp/constraints currently depends on the old text containing the old "implements" word, …dmitshur reviewed +2 on misc/wasm: migrate support to Node 18 LTS3w
One minor comment, otherwise this looks good for after the tree reopens and TryBots are made to pass (one way or another).
There is one thing related to TryBots that's probably worth considering. I …dmitshur commented on misc/wasm: Go's WASM shim breaks in Node v193w
As I understand, the fix suggested in https://github.com/golang/go/issues/56860#issuecomment-1321274898 (and currently implemented in [CL 455415](https://go.dev/cl/455415)) intentionally drops compat…dmitshur opened a change golang.org/x/build/dashboard: update js-wasm-node18 known issue and limit it to Go 1.21+3w
The js/wasm port is compatible with Node.js 14 but not Node.js 18, and
we're in the middle of a freeze so it's too late to make changes now.
Target the new builder for Go 1.21 and newer, and replace …dmitshur commented on golang.org/x/build/dashboard: add js-wasm-node18 builder with Node.js 18 LTS3w
The builder seems to be working okay, but we can't switch fully to it yet.
Filed an umbrella tracking port for updating js/wasm to support Node.js 18,
and will close this issue since the builder pa…dmitshur opened an issue all: update js/wasm port for Node.js 1.183w
The recently-added js/wasm builder with Node.js 1.18 reports that all.bash doesn't pass out of the box.
This is the umbrella issue to track everything needed to migrate the js/wasm port from Node.js…