Activity
Today
dmitshur reviewed +2 on go.dev/wiki/DashboardBuilders: remove documentation for legacy builders39m
dmitshur opened a change go.dev/wiki/DashboardBuilders: remove documentation for legacy builders40m
The legacy builders have been fully stopped and don't work anymore.
The documentation for them is obsolete and misleading. Remove it.
For golang/go#67761.dmitshur commented on runtime: implement stackcheck for riscv6450m
The legacy slowbot infrastructure is unsupported and doesn't work. I added their LUCI counterparts as advisory slowbots to this CL:
- [gotip-linux-riscv64](https://ci.chromium.org/ui/p/golang/builde…dmitshur commented on golang.org/x/build: gotip-openbsd-riscv64 builder is missing1h
There is a [openbsd-riscv64-jsing](https://chromium-swarm.appspot.com/bot?id=openbsd-riscv64-jsing) builder now, but it's showing up as offline as of 24 hrs ago. CC @4a6f656c.dmitshur reviewed +2 on cmd/go/internal/work: cache coverage output1h
I think I understand this at a high level and it's mostly a refactor. However, I'm not familiar with go command's action caching and coverage instrumentation, so my review isn't going to be very thor…dmitshur reviewed +2 on cmd/go: remove net script test condition from main go command suite2h
Thanks.
🎉dmitshur reviewed +2 on cmd/go: move mod_sumdb_golang network tests to verylongtest2h
Thanks.
Consider passing in the *testing.T here and call t.Fatal instead. Also below.
`l` is never closed, even after the test completes. Is the reason for that because the test executable is deeme…dmitshur reviewed +2 on cmd/go: move part of gotoolchain_net to verylongtest2h
Thanks.
This copy of scripttest is internal to the cmd module, so it makes sense to modify it to suit the needs of all of its internal users. I agree it seems calling removeAll to clean up after the…dmitshur reviewed +2 on cmd/go: move mod_insecure_issue63845 and mod_proxy_https to verylongtest2h
Thanks.
This seems like the only use of fixReadme. Should the flag be removed because it no longer has any effect, or be fixed to work?dmitshur reviewed +2 on cmd/go/testdata/script: update mod_prefer_compatible to not use net2h
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net condition from always skipped tests2h
Thanks.
I think this is saying that the test is being skipped because it has a 'skip' verb. It's fine, though a bit repetitive.
[go.dev/issue/54043](https://go.dev/issue/54043) is closed, and it's …dmitshur reviewed +2 on cmd/go/testdata/script: don't use network in mod_gonoproxy test2h
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net from mod_download_private_vcs2h
Thanks.
😄dmitshur fixed an issue golang.org/x/crypto: upgrade x/net dependency2h
As noted in the comment above, closing as fixed by [CL 788222](https://go.dev/cl/788222) which is included in x/crypto@v0.53.0. (CC @golang/security.)
> although the problem is the scan engine
It s…dmitshur reviewed +2 on cmd/go/testdata/script: don't use net in mod_pseudo_cache4h
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: don't use net in mod_sumdb_file_path test4h
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: stop using network from mod_git_export_subst4h
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net from gotoolchain_version test4h
Thanks.dmitshur reviewed +2 on cmd/go/testdata/script: remove net check in get_iussue53955 test4h
Thanks.
(minor typo)
```suggestion
cmd/go/testdata/script: remove net check in get_issue53955 test
```dmitshur reviewed +2 on cmd/go/testdata/script: don't use network in govcs script test4h
Thanks.
I left a suggestion to consider including at least one "For #nnn." line. That suggestion is for all CLs in this stack, but I won't repeat it everywhere.
Whenever there's a large stack of CL…dmitshur reviewed +2 on cmd/go: switch toolchain if necessary in applyUpgrades5h
Thanks. Just a minor comment/question.
I don't know what's the motivation to defer base.ExitIfErrors() here given it's already being called on line 1495, and there aren't any early returns before th…dmitshur commented on cmd/compile: repair mask optimizations5h
Test/codegen/simd.go may need attention after this change, see issue #80199.dmitshur commented on cmd/internal/testdir:0_10: Test/codegen/simd.go failures [consistent failure]5h
It seems this started with [CL 794680](https://go.dev/cl/794680). Since this is a regression from go1.27rc1, it'd be good to fix for rc2.dmitshur commented on flag:race: unrecognized failures6h
That's a strange build failure that only happened once so far. It may be the same issue that was fixed by [CL 794120](https://go.dev/cl/794120) and [CL 794121](https://go.dev/cl/794121). Adjusted the…dmitshur commented on net/http/internal/http2: pre-allocate header map in server's newWriterAndRequest6h
CC @neild, @nicholashusin.dmitshur commented on golang.org/x/tools/go/analysis/passes/inline: non-deterministic facts encoding6h
CC @adonovan, @matloob, @findleyr.dmitshur commented on golang.org/x/net/webdav: support filesystem-backed dead properties6h
I think you filed issue #80232 for this, so "Fixes golang/go#80232".
This text should be acknowledged and then deleted from the PR description.
Adding a new exported API requires going through the …dmitshur commented on golang.org/x/net/webdav: support filesystem-provided dead property holders6h
CC @neild, @ianlancetaylor, @nicholashusin.dmitshur commented on golang.org/x/crypto/ssh: unable to verify SSH signatures with a hardware security key created with no-touch-required6h
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/build: bot windows-arm64-azure-qmuntal reported as broken6h
CC @qmuntal.dmitshur commented on doc: fips140 page does not specify which crypto module version is used when GODEBUG=fips140=on without GOFIPS1407h
CC @golang/security.dmitshur commented on doc: write release notes for Go 1.277h
@iandyh Thanks for reporting that. We'll resolve it as part of issue #79987.dmitshur commented on golang.org/x/pkgsite: support generic methods7h
It was reported that the package documentation for encoding/json (v1) doesn't show the "Migrating to v2" section in https://github.com/golang/go/issues/78779#issuecomment-4861881670 (thanks @iandyh).…Yesterday
dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.27: document syscall.Errno on Plan 923h
Thanks.dmitshur commented on golang.org/x/tools/internal/robustio: don't use syscall.Errno on Plan 91d
(1 comment)
This might be worth including in the Go 1.27 release notes (https://tip.golang.org/doc/go1.27, tracking issue #78779). CL 750680 is where the Plan 9-specific addition happened.This Week
dmitshur opened a change golang.org/x/build/cmd/relui: consider target versions of security fixes in security comms1d
So far we've only had to deal with the common case where a security fix
applies to all versions that are going as part of a monthly Go release.
At some point we'll run into a case where some security…dmitshur closed a change golang.org/x/text/go.mod: update golang.org/x dependencies1d
Replaced by a newer identical CL 795500.dmitshur closed a change golang.org/x/text/go.mod: update golang.org/x dependencies1d
Replaced by a newer identical CL 795500.dmitshur commented on net: TestLookupCNAME failures2d
@gopherbot Please consider this for backport. It's a test-only fix needed to get this test passing on release branches.
CC @nicholashusin, @golang/release.dmitshur commented on golang.org/x/build/cmd/relui: add metadata-based security comm fetching for RC releases2d
Thanks.dmitshur opened a change golang.org/x/build/cmd/relui: add metadata-based security comm fetching for RC releases2d
This has been working well for the "two minor releases" relui workflow.
Continue by making it available in "next RC" relui workflow next.
For golang/go#79037.dmitshur fixed an issue internal/sync: TestConcurrentCache failures2d
dmitshur fixed an issue internal/sync: TestConcurrentCache failures2d
I understand this should be fixed by https://go.dev/cl/794120 and https://go.dev/cl/794121 (CC @prattmic), closing. [internal/sync.TestConcurrentCache on gotip-linux-amd64-noopt](https://ci.chromium.…dmitshur commented on internal/sync: TestConcurrentCache failures2d
I understand this should be fixed by https://go.dev/cl/794120 and https://go.dev/cl/794121 (CC @prattmic), closing. [internal/sync.TestConcurrentCache on gotip-linux-amd64-noopt](https://ci.chromium.…dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: Warnings when building using -tags wayland2d
We'll be able to pull it in once there's a stable GLFW release that includes that change. PR glfw/glfw#2833 is added to 3.5 milestone, so I understand it will be released in in a future GLFW 3.5 rele…dmitshur reviewed +2 on runtime: [release-branch.go1.26] tolerate vendor suffixes in Linux kernel release strings2d
dmitshur reviewed +2 on golang.org/x/build/devapp/owners: remove Rob Pike from various packages2d
Thanks.
cmd/doc was deleted in CL 689835 ('go doc' continues to handle its functionality), so this entire entry can also be removed.dmitshur reviewed +2 on golang.org/x/pkgsite/deploy: update Cloud Build Go version to 1.27rc13d
Thanks.dmitshur commented on golang.org/x/sys/cpu: handle vendor suffixes in parseRelease3d
(1 comment)
Thanks.dmitshur commented on golang.org/x/sys/cpu: handle vendor suffixes in parseRelease3d
(1 comment)
Is it applied in patch set 4? The change doesn't seem to be uploaded yet.dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.27: fix typo4d
Thanks.dmitshur merged a change github.com/go-gl/glfw/v3.4/glfw: gofmt not_wayland.go4d
Last Week
dmitshur opened a change github.com/go-gl/glfw/v3.4/glfw: gofmt not_wayland.go5d
For #419.
(CC @oliverbestmann.)dmitshur created branch in github.com/go-gl/glfw5d
gofmt-after-pr-420dmitshur fixed an issue github.com/go-gl/glfw: Linux, no buildtags on 3.4 does not expose `GetWaylandDisplay`.5d
I understand PR #420 fixed this, so closing.dmitshur commented on runtime: [release-branch.go1.26] tolerate vendor suffixes in Linux kernel release strings5d
(1 comment)
Yes, the other Gerrit footers are usually kept - this is covered at https://go.dev/wiki/MinorReleases#making-cherry-pick-cls:
> In the popup enter the branch name (like release-branch.g…dmitshur starred github.com/x448/float165d
dmitshur commented on cmd/gofmt: don't rewrite into smart quotes6d
A concern is that proposal conflicts (significantly overlaps) with an already-accepted but not yet implemented one at #54312. That proposal went through an analysis of the ecosystem as part of arrivi…dmitshur commented on golang.org/x/tools/go/types/internal/play: show Cursor path6d
(1 comment)
Noting here that it should also be possible to take advantage of this fmt printing behavior:
> 2. If an operand implements the [Formatter](https://pkg.go.dev/fmt#Formatter) interface, i…dmitshur commented on proposal: blanket approval for String and GoString methods6d
In the example provided, the phrasing "a fuller description of a Thing than [Thing.String]" seems more distinct than I'd expect from the description for the `GoString() string` method given at https:…dmitshur closed an issue net/http: add GODEBUG=httpmaxheadervalues=N [freeze exception]1w
dmitshur commented on golang.org/x/build/main.star: use lucicfg as a tool dependency1w
Thanks, using `go tool` for this is very interesting.
I'm a bit hesitant to actually switch to this because it would mean we deviate more from the approach that's supported by the LUCI team. It woul…dmitshur commented on runtime: handle nil pointer in sysFreeOS on sbrk platforms1w
The legacy trybots aren't supported anymore, so stopping this empty run. We'll remove the gerrit vote soon to avoid confusion. Currently supported trybots are triggered via the Commit-Queue+1 vote as…dmitshur reviewed +2 on golang.org/x/arch/...: disable Git line-ending conversion1w
A few notes Gerrit-related notes: @emmanuel@orijtech.com, please note that when starting trybots via the 'Choose Tryjobs' dialog, since this CL is inside the golang.org/x/arch repository, the builder…dmitshur commented on golang.org/x/build/internal/task: remove open CL checks to prevent waiting for empty CLs1w
(1 comment)
(Any leftover generated CLs can also be found and cleaned up via a query like https://go-review.googlesource.com/q/owner:gobot@golang.org+is:open.)dmitshur closed a change golang.org/x/arch/...: upgrade go directive to at least 1.25.0 [generated]1w
Replaced by CL 744640.dmitshur closed a change golang.org/x/playground/...: upgrade go directive to at least 1.25.0 [generated]1w
dmitshur closed a change golang.org/x/text/...: upgrade go directive to at least 1.25.0 [generated]1w
dmitshur closed a change golang.org/x/mod/...: upgrade go directive to at least 1.25.0 [generated]1w
dmitshur closed a change golang.org/x/debug/...: upgrade go directive to at least 1.25.0 [generated]1w
dmitshur closed a change golang.org/x/term/...: upgrade go directive to at least 1.25.0 [generated]1w
dmitshur reviewed +2 on golang.org/x/build/internal/task: remove open CL checks to prevent waiting for empty CLs1w
Thanks.
Noting that clTitle needed to be defined as a variable in part because it needed to be used in multiple places, including for the "past open CL" check. Now that it's only being used in the o…dmitshur reviewed +2 on golang.org/x/build/cmd/gomote: remove the gomote coordinator functionality1w
Thanks.dmitshur commented on go/ast: standardize deprecated comment tags1w
CC @griesemer, @golang/tools-team, @dominikh.dmitshur closed an issue runtime: concurrent struct access in grpc-go transport crashes only on AMD1w
dmitshur commented on golang.org/x/tools/go/ssa: remove incorrect hasTypeParams check1w
(1 comment)
These two lines seem to be missing a verb in front. 'Fixes' for both?dmitshur reviewed +2 on golang.org/x/blog/...: remove 2 hidden files, leave just README1w
dmitshur reviewed +2 on golang.org/x/blog/...: remove 2 hidden files, leave just README1w
This change is ready for review.dmitshur opened a change golang.org/x/blog/...: remove 2 hidden files, leave just README1w
These were missed in CL 324270. These files aren't needed,
and can be safely removed. This way they won't become out
of date, and they won't invite maintenance.dmitshur reviewed +2 on golang.org/x/arch/...: disable Git line-ending conversion1w
(1 comment)
If I understand correctly, this is an intentionally shortened version of a similar explanatory comment used in other repos:
https://cs.opensource.google/search?q=file:.gitattributes&sq=…dmitshur fixed an issue access: join golang/riscv64 maintainer team1w
Thanks. Added @HeliC829 to https://github.com/orgs/golang/teams/riscv64/members.dmitshur commented on golang.org/x/sys/windows: reject overlong inputs in NewNTString1w
CC @golang/windows.dmitshur commented on cmd/compile: internal compiler error invalid heap allocated var without Heapaddr1w
CC @golang/compiler.dmitshur commented on cmd/compile: reduce allocations by reusing SSA scratch state1w
CC @golang/compiler.dmitshur commented on golang.org/x/arch/x86/x86avxgen: TestOutput failure1w
CC @cherrymui, @golang/windows.dmitshur commented on golang.org/x/pkgsite: improve openapi.yaml1w
CC @golang/pkgsite.dmitshur commented on golang.org/x/image/bmp: add 1, 2 and 4 bits-per-pixel palette encoding support1w
CC @nigeltao, @robpike.Earlier
dmitshur commented on net/http/internal/http2: remove "Host" header from Request.Header1w
@kidnamedcudilovedrake-dot You've been posting on many issues recently. The issue tracker is used for discussing the issue, code changes are better handled as part of CLs (which is where a [CLA](http…dmitshur commented on golang.org/x/crypto/ssh: RSA parameter moduli maximum should be increased1w
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/build/cmd/relnote: improve experience for documenting new standard library packages2w
Thanks, feel free to send a CL. See https://go.dev/doc/contribute.dmitshur opened an issue cmd/compile: cmd/compile/internal/gc fails to build (as part of running tests) under GOEXPERIMENT=newinliner2w
As of [CL 792120](https://go.dev/cl/792120), the gotip-linux-amd64-newinliner builder which tests with `GOEXPERIMENT=newinliner` fails to build cmd/compile/internal/gc:
```
FAIL cmd/compile [build f…dmitshur opened an issue github.com/actions/setup-go: Support release candidate alias ("nextstable"?) as a moving target2w
**Description:**
Currently setup-go supports "stable" and "oldstable" aliases. They are moving targets, so they make it convenient for repositories to target those versions, without needing to edit a…dmitshur commented on golang.org/x/exp/cmd/apidiff: non-deterministic output for "no longer implements"2w
CC @jba, @adonovan.dmitshur commented on github.com/go-openapi/testify/v2: didPanic relies on "panic called with nil argument" Error string equality, changes behavior in Go 1.272w
Thanks very much for resolving this!dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan2w
Thanks for confirming @noahbjohnson. That suggests govulncheck owners may consider temporarily working around by using an older x/tools while #80055 is investigated and resolved.dmitshur commented on golang.org/x/arch/loong64/loong64asm: TestObjdumpLoong64TestDecodeGoSyntaxdata failures2w
CC @golang/loong64.dmitshur commented on cmd/go: support quotes in `GOENV` file2w
CC @golang/command-line.dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan2w
If someone who's able to reproduce this wants to try building govulncheck from source, modifying it with `go get golang.org/x/tools@v0.44.0` (plus v0.45.0 is worth trying too), please see whether tha…dmitshur commented on golang.org/x/tools/go/ssa: RuntimeTypes panics on a parameterized type boxed in a generic method's closure2w
Thanks for reporting and bisecting this.
CC @golang/tools-team, @mrkfrmn, @griesemer.dmitshur commented on cmd/compile: inconsistent errors for init expr mismatches for vars and consts2w
CC @golang/compiler.