Activity
Today
dmitshur commented on golang.org/x/website/_content/doc/go1.26: fix typo in slog.MultiHandler doc38m
(1 comment)
```suggestion
Its `Handle`, `WithAttrs` and `WithGroup` methods call the corresponding method
```dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.26: fix typo in slog.MultiHandler doc38m
Thanks.dmitshur reviewed +2 on log/slog: correct method name in MultiHandler docs40m
Thanks.
Let's also fix WithAttrs since it's nearby.
```suggestion
// Its Handle, WithAttrs and WithGroup methods call the corresponding method on each of the enabled handlers.
```dmitshur reviewed +2 on golang.org/x/website/internal/history: document Go 1.25.7 and 1.24.1349m
Thanks.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: switch to ufs image1h
Well, it was worth a try. Thanks.dmitshur commented on golang.org/x/build/main.star: remove linux-amd64-spectre known issue2h
Just checking, is it expected this builder would not have caught the issue reported in #77420, but rather it's intended to check for easier-to-catch problems that may come up in the future?
Asking b…dmitshur reviewed +2 on golang.org/x/build/main.star: finish upgrading freebsd-amd64 to FreeBSD 14.33h
Thanks.
A single passing commit across all repos seems pretty good signal for a 14.2 -> 14.3 change, so I suspect it's fine to move ahead without much waiting.dmitshur reviewed +2 on golang.org/x/build/main.star: add freebsd-amd64_15.0 builder3h
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add spectre builder3h
Thanks. It'll be interesting to see the 'go env -changed' output on the builder.dmitshur reviewed +1 on internal/runtime: fix assembly for spectre retpoline instrumentation4h
(1 comment)
Thanks for catching that and improving their name. Including it in this CL seems fine.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add 15.04h
dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add 15.04h
Thanks.
Not a big deal to leave these on older version. That said, if you want, consider updating them:
```suggestion
./make.bash 15.0
After it completes, it creates a file freebsd-amd64-150.t…dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: don't restart buildlet on exit5h
Thanks.dmitshur commented on crypto/tls: revalidate whole chain on resumption on Windows and macOS6h
(1 comment)
I might've overlooked something, but to check here, can this condition be true? Since i is ranging over chain[1:], at [first glance](https://go.dev/play/p/5ZViTX7tvUY) it seems it might …dmitshur commented on golang.org/x/build: bot linux-s390x-ibm--02 reported as broken7h
Thanks for looking into this.
From looking at the list of bots connected to LUCI at https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Alinux-s390x&f=pool%3Aluci.golang.shared-workers, it d…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder8h
Thanks for requesting to add a builder to test the linux/mipsle port (CC @golang/mips). There's also issue #67304 tracking this. Is this meant to be an additional builder?
CC @golang/release, @pratt…dmitshur commented on os: File.Close hangs with concurrent I/O on Windows using go1.26rc2 [1.26 backport]8h
CC @prattmic.Yesterday
dmitshur reviewed +2 on golang.org/x/mobile/bind: support go/types.Alias23h
Looks good to me, though the go/types API and best practices for code that needs to handle aliases isn't something I've looked into closely. Someone more familiar (@adonovan@google.com maybe) might b…dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add 14.31d
Thanks.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add doas configuration1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add freebsd-amd64_14.3 builder1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: remove freebsd-amd64_14.1 builders1d
Thanks.
I think I tried to use the 14.1 builders to iterate a bit on that issue with the builders not cleaning up after themselves on termination requests or so. Does that work fine now?
If not, ma…dmitshur commented on golang.org/x/website/internal/web: do not treat Markdown files as templates by default1d
Missed this thread, so marking it as resolved too. Thanks again.dmitshur reviewed +2 on golang.org/x/website/internal/web: do not treat Markdown files as templates by default1d
Thanks.
Thanks. For reference, in case it comes in handy later, note that there's a bit more information about tests for x/website/cmd/golangorg in its [README](https://cs.opensource.google/go/x/web…dmitshur commented on internal/poll: readWriteUnlock should destroy fd when no remaining references1d
Minor comments on the test; otherwise leaving this to Damien to review. Thanks.
https://pkg.go.dev/testing#T.Fatal's "FailNow must be called from the goroutine running the test or benchmark function…dmitshur commented on cmd/go: add 'go test -cachelink' boolean flag1d
@bradfitz@golang.org Please note that the Run-TryBot+1 by now is meant only when looking to trigger legacy slowbots. Otherwise there aren't any trybots that run in its default set. So in most CLs lik…This Week
dmitshur commented on net: don't wait 5 seconds to re-read /etc/resolv.conf2d
There weren't any legacy slowbots requested, so Run-TryBot+1 isn't doing anything except blocking submission. Dropping it.Last Week
dmitshur commented on cmd/go: repository URL resolution behavior doesn't match documentation5d
CC @golang/command-line.dmitshur commented on golang.org/x/tools/go/analysis/passes: fix buf.WriteString(x + y) to the more efficient buf.WriteString(x); buf.WriteString(y)5d
CC @adonovan.dmitshur commented on cmd/go: `go tool` and `go get -tool` could be documented better5d
CC @golang/command-line.dmitshur commented on golang.org/x/website: code in README.md is excessively HTML escaped5d
@qrasick I should be able to review it by tomorrow. From an early look, it looked good. Thanks for preparing it.dmitshur commented on doc: write release notes for Go 1.266d
The Go 1.26 release notes draft seems ready. It's okay for this issue to stay open to track any further refinement and improvement leading up to the release, but removing the release-blocker label si…dmitshur fixed an issue cmd/go: unexpected code execution when invoking toolchain (CVE-2025-68119) [1.24 backport]6d
Closed by merging [CL 739421](https://go.dev/cl/739421) (commit 73fe85f0ea1bf2cec8e9a89bf5645de06ecaa0a6) to release-branch.go1.24.dmitshur commented on cmd/go: unexpected code execution when invoking toolchain (CVE-2025-68119) [1.24 backport]6d
Closed by merging [CL 739421](https://go.dev/cl/739421) (commit 73fe85f0ea1bf2cec8e9a89bf5645de06ecaa0a6) to release-branch.go1.24.dmitshur closed an issue cmd/go: TestScript/build_plugin_reproducible failures [consistent failure]6d
Merging into #77350.dmitshur commented on lib/time: update tzdata before release6d
2025c still remains the latest available, and with Go 1.26 RC 3 planned for next week, Go 1.26.0 soon thereafter, moving this to the next milestone. We can always revisit if applicable.dmitshur commented on plugin: unrecognized failures [consistent failure]6d
@ianlancetaylor mailed [CL 739681](https://go.dev/cl/739681) for this. (CC @cherrymui.)dmitshur commented on cmd/go: builds appear slower on openbsd/amd64 with Go 1.26rc2 (vs 1.25.6)1w
CC @golang/runtime.dmitshur commented on cmd/internal/obj/riscv: add Zvkned extension support1w
CC @golang/riscv64.dmitshur commented on golang.org/x/pkgsite: does not recognize the standard and recommended COPYING.LESSER filename for LGPL1w
CC @golang/pkgsite.dmitshur fixed an issue build: adopt Go 1.24 as bootstrap toolchain for Go 1.261w
dmitshur commented on build: adopt Go 1.24 as bootstrap toolchain for Go 1.261w
We plan to take the reported friction and discussion here into account when doing this the next time, for Go 1.28. Filed #77341 for that.
At this point there's nothing more to do for Go 1.26, so clo…Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change8modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y