Activity

Today
A header is displayed on 3 pages: • farmer.golang.org - the coordinator status page • farmer.golang.org/builders - list of builders • build.golang.org - the build dashboa…
I came up with a simpler next step I'm happier with. Instead of adding a new "Coordinator" button, I'll just linkify the existing "Go Build Coordinator" text to take one to cmd/coordinator's "home" p…
Trivial comments on whitespace. Nit: The line above uses a single tab for indentation. This line uses 8 spaces. Same comment on lines 38, 60, and 66. Nit: The rest of the file uses tabs for indent…
(3 comments) This will also help release tests, in particular, windows/arm64 seems to hit it pretty often (I found out while investigating issue #47017). TestWaitGroupMisuse2 and TestWaitGroupMisus…
(1 comment) Nit: missing a verb before “basic”. > the part after the colon uses the verb tense + phrase that completes the blank in, "This change modifies Go to ___________"
I've not yet used the API, and I suspect may have more comments, but I see no reason not to check this in now and iterate. I'd like to see this added as an 'internal' package and not…
(1 comment) Optional: It might be possible to also fit the names of the env vars being modified in the subject: dashboard: set GO{,HOST}ARCH, GOARM on linux-arm-aws builder To increase the…
(2 comments) This is okay, but maybe 'all' is good too. Minor: Add a blank line above Change-Id, otherwise it's harder to spot that the commit message ends on line 17 rather than 15. (U…
Are the changes introduced to go.mod in patch set 2 intentional?
PR #11 is relevant.
Yesterday
(1 comment) Thanks for the suggestion. That would result in "waiting 1m0s and trying again", which sounds too robotic/precise to be useful. My goal with this line is to make the timeline in…
Releasebot runs many builds in parallel, retrying each up to 3 times. Whenever there's an unsuccessful attempt, it prints information about what went wrong, but it doesn't make it easy to see…
> The root cause of the failures is port exhaustion, which hasn't been addressed, but the deadlock in `TestMissingStatusNoPanic` should be fixed. The port exhaustion issue is now also fixed (by [C…
I think this looks good after inline comment is resolved. Thanks for improving gomote.
(1 comment) The local map documentation says its keys are like "src/make.bash", and rel previously used filepath.ToSlash. Given the uses of the local map below, it does seem to need to be &…
I've closed #47520 as a duplicate of this issue.
Since there are dedicated backport issues, retargeted this issue to 1.17. Closing as fixed by [CL 339594](https://golang.org/cl/339594).
We went with a better fix in CL 339594, so this backport shouldn't be needed. Closing. (Can re-open if something changes.)
This Week
The test fix is working as expected. From windows-amd64-longtest test log so far: ok net/http 61.339s
This test runs for 10 seconds, with 11 goroutines creating HTTP requests in a tight loop for the duration of the test. These goroutines abort in-flight requests, which can result in many new client c…
This test fix makes sense and resolves the problem in my testing on a Windows 10 machine. Since this CL targets master branch, I think it should say "Updates" or "For", and the backp…
TRY=windows-amd64-longtest, linux-386-longtest, linux-amd64-longtest This CL modifies TestCancelRequestWhenSharingConnection which is skipped in short mode, so regular TryBots won't provide a us…
### What is the URL of the page with the issue? https://pkg.go.dev/golang.org/x/website/internal/history#Releases ### What did you do? I shared the link https://pkg.go.dev/golang.org/x/websi…
Closing this PR because [golang.org/cl/332129](https://golang.org/cl/332129) has been submitted.
I've updated the PR description, submitting. Done. Done. Done.
(7 comments) Since the goal of this is to replace x/build/cmd/tip, it should also handle beta.golang.org too, by redirecting it. (See https://go.googlesource.com/build/+/12eae6d636a4f5cafe4b8f2540fc…
(2 comments) cmd/golangorg is currently on App Engine Standard Go 1.15 runtime¹, so either this build constraint or the runtime will need to change before cmd/golangorg can start to import this pac…
Approved as a fix for a security issue. This backport applies to both 1.16 (#47474) and 1.15 (this issue).
Approved as a fix for a security issue. This backport applies to both 1.16 (this issue) and 1.15 (#47473).
(1 comment) Should modify this 1.15 cherry-pick to use "io/ioutil".Discard. Another one on line 1155.
Last Week
> *should* go/format touch .s files, if only the build header lines? My personal preference would be to keep the scope of `cmd/gofmt` (and `go/format`, which is just an importable Go package version…
FWIW, in Go 1.17 the [`go/format`](https://pkg.go.dev/go/format) package (like the `gofmt` binary) takes care of this¹, so if used, the output is guaranteed to be gofmt'ed (and continue to be over t…
[CL 338629](https://golang.org/cl/338629) updates this issue. CC @mmcloughlin, @josharian, @ianlancetaylor. @mmcloughlin If updating the generator is a change that needs more time, should we fix i…
dmitshur starred in github.com/mmcloughlin/avo4d
dmitshur starred in github.com/mattn/twty5d
I tried to gather more information on this issue by making use of a physical windows/arm64 machine I have access to. I ran all.bat a number of times on it, and can confirm this issue doesn't reproduc…
At this time, Node 14 is the LTS release recommended for most users, including for production use (https://nodejs.org/en/about/releases), so start using it. Also check in a copy of setup_14.x into x…
The stack up to [CL 336791](https://golang.org/cl/336791) has been submitted and deployed. The new coordinator-powered dashboard is being served at https://farmer-ui-test.golang.org. I'm not spott…
Also, the README is now regenerated.
CL 336789 is merged into this CL in patch set 2.
This change is merged into CL 336790 in patch set 2, so it's no longer needed as a separate CL.
(2 comments) Acknowledged. I agree, I felt that way too. I prototyped using a sync.Once either to make it so Handler only sets globals the first time and then returns same values, as well as to pan…
The build dashboard is merging into the coordinator codebase in #34744, so maybe we should unify the header. It would help navigation between the build dashboard and the farmer status page, especiall…
@ianlancetaylor Should the follow up change [CL 337309](https://golang.org/cl/337309) also be cherry-picked to 1.16? (I'll reopen this so we don't forget to make that decision before release time.)
dmitshur deleted branch in github.com/go-gl/glfw1w
update-3.3.4
dmitshur pushed to master in github.com/go-gl/glfw1w
0db043d8d5be8de18ce39aa7407778d752544b7cv3.3/glfw: update to GLFW 3.3.4
During the minor release process, towards the end, an announcement tweet is posted. For example, https://twitter.com/golang/status/1414721238224838666. (The tweet text and image are generated via a t…
I don't see anything wrong in the snippets you posted. I tried putting them together into a complete program, and can't reproduce the problem with it. It seems to work fine: <details><br> ``…
(We should also update https://github.com/go-gl/glfw/wiki/Development#updating-glfw-c-source for the new grab-upstream process.)
GLFW 3.3.4 was released on April 8, 2021. See https://github.com/glfw/glfw/releases/tag/3.3.4. Done with scripts/grab-upstream.sh (albeit with edits): echo 'b3e0aae393ef6c5cda7dcad0cba06bef23…
dmitshur created branch in github.com/go-gl/glfw1w
update-3.3.4
dmitshur pushed to master in github.com/shurcooL/frontend1w
4ab50a35b5e50c53bc35d4f06e1d2992d04f4c06reactionsmenu: handle PointerEvent type in "click" handler
dmitshur deleted branch in github.com/dominikh/go-js-dom1w
rebase-pointerevent
dmitshur pushed to master in github.com/dominikh/go-js-dom1w
f030747120f2bf279a88308f7e808d790b4fcfb5rebase PointerEvent on top of MouseEvent
dmitshur pushed to master in github.com/shurcooL/githubv41w
83ba7b4c9228d93b438cd13cb01655d5b239934aregenerate for schema changes by 2021-07-25
Thanks. The breaking changes should be fine, this package follows the GitHub API and inherits its breaking changes. I'll deal with adding a go.mod file separately later.
This is motivated by Chrome changing "click" events to send PointerEvent rather than MouseEvent, as described at https://groups.google.com/a/chromium.org/g/blink-dev/c/bta50W_Hg24/m/YAYeAzCZAAAJ.
According to documentation on MDN¹, the PointerEvent interface inherits properties from MouseEvent, which in turn inherits from UIEvent, and that inherits from Event. Embed MouseEvent in Pointe…
dmitshur created branch in github.com/dominikh/go-js-dom1w
rebase-pointerevent
Earlier
Closing as duplicate of https://github.com/go-gl/glfw/issues/319. Also please be aware that it's possible to clear the build cache with `go clean -cache`, as documented at https://pkg.go.dev/cmd/g…
As a first step, try v3.3, since v3.2 is an old version of GLFW and not really supported. If it still doesn't work, that likely means support for Raspberry Pi has not been added.
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.17rc1 darwin/arm64 </pre> (It also reproduces with latest master commit, 0914646ab91a3157666d845d74d8d9…
dmitshur pushed to master in dmitri.shuralyov.com/website/gido1w
f460621dc784d8a8f3a1593a068115b62baf214dadd support for multiple comma-separated import path patterns
be77a538f6a64b287e073b59d1b9f7e1314cf3a9upgrade to go-git v5
b5ce3c19e6b977800ee3c80bc722192f96ef657breplace mention of godoc.org with pkg.go.dev
Thanks for the report. The `dl` package implements `fileOrder` sorting, and `versionLess` is used to compare two versions. When both are pre-release versions with same major, minor components, the…
I've been able to pick this up and make good progress this week. My focus is on getting this to a point where the build dashboard is served by cmd/coordinator, so that it's a single deploy rather tha…
dmitshur opened an issue all: reopen tree for Go 1.18 development2w
### Current Tree Status: Frozen for Go 1.17 changes only 🥶 (RC 1 is out) This is a tracking issue for the [upcoming task](https://golang.org/s/release#timeline) of reopening the tree for Go 1.1…
Sure, let's use it as a tracking issue then.
dmitshur reopened an issue github: add Autolink References for CLs2w
dmitshur closed an issue github: add Autolink References for CLs2w
Thanks for suggesting this. Unfortunately, I don't think we're on a plan that supports this feature. If that changes we should consider this.
As visible on the [build dashboard](https://build.golang.org/?repo=golang.org%2fx%2fwebsite), `TestGolden` is failing starting with [CL 335669](https://golang.org/cl/335669): ``` --- FAIL: TestGo…
By default, a modern version of Go should install the `tour` binary in module mode and use the module mirror (https://proxy.golang.org) to download the module zip, so `git` shouldn't be required. …
@jfesler Thanks for that information. Indeed, looking for content in the module cache can only work on a machine where Go is installed. Go 1.17 will come out pretty [soon](https://groups.google.co…
Is this marked as a 1.18 release blocker because it's okay to fix this after 1.17 is released? I can't reproduce with `git version 2.30.1 (Apple Git-130)` either.
I understand why this is happening and can confirm both the go command and module mirror are working as expected. Specifically, https://golang.org/ref/mod#resolve-pkg-mod specifies that: > If one or…
Hmm, this doesn't seem to happen in GOPROXY=direct mode, so maybe the module mirror is playing a role. I'll check again later.
A reasonable way to install the latest version of the `tour` binary from its latest location is by using `go install`: ``` go install golang.org/x/website/tour@latest ``` However, doing so cu…
Added early-in-cycle so this issue gets a reminder when the tree reopens. If we're going to do this, doing it earlier gives the greatest opportunity to find out what needs updating (outside of the Go…
@tuxillo Friendly ping. [CL 332129](https://golang.org/cl/332129) just had 3 minor commit message comments and can be submitted. Are you still planning to create a tracking issue for the 6_0 build…
dmitshur commented on : x/website:3w
Thanks for reporting. I suspect this might be a duplicate of #46416.