Activity

Yesterday
dmitshur starred in brainbaking.com/go-jamming10h
@Hrtkk Thanks for offering. As you noticed, there are already 2 CLs out that will fix this issue. You're welcome to help with [reviewing](https://golang.org/doc/contribute#reviews) them. Thanks!
Last Week
(1 comment) Sure. It's easy to do since tryWorkItem has an error return value now, but then it worked out better just to factor it out to the caller who is in a better position to determine deve…
"lock_reason" is a field that was added to GitHub API v3 after maintner was created. It's present in GitHub issue "locked" events and indicates the reason the issue was locked, su…
We already log about storing unknown JSON (on the server) and can look up occurrences there. Most clients don't care, so only log if they are in verbose mode. Fixes golang/go#46180.
### What did you do? Use a client `*maintner.Corpus` via the [`godata`](https://pkg.go.dev/golang.org/x/build/maintner/godata) package. See [example code](https://pkg.go.dev/golang.org/x/build/…
The list of owners at https://dev.golang.org/owners is updated periodically via people sending CLs that add/remove entries. Given a good amount of time has passed and people's priorities and time ava…
First pass review with just minor comments. Please add a period at the end of the sentence (per https://golang.org/s/style#comment-sentences). Also add "See golang.org/issue/38874." after it…
dmitshur edited the wiki1d
dmitshur reviewed +2 on golang.org/x/website/all: remove ?m=src1d
So long, this niche mode!. This line isn't a part of "collect examples" (it was previously separated by being in a separate block), so maybe add a blank line above it, or better yet move…
(2 comments) It looks like this unintentionally reverts a code simplification that was intentionally made in CL 311089. Since the name variable isn't used anywhere below, I don't see a reaso…
I really like the direction of this change. I have some questions to confirm/better understand the intended changes to the URLs. See inline comment on line 203 of godoc_test.go. Once I know the answ…
I think the direction of this change is great, but I wanted to ask one question about the data structure change to history.Release, to understand it better. Please see the inline comment on line 15 o…
(1 comment) Fixed in PS 2.
We agreed to use `darwin-amd64-11_0` for 1.17 onwards, filed #46161 for that, and moving this to 1.18 milestone.
This is consistent with our approach of using latest major macOS version builder for creating macOS releases. Also see https://github.com/golang/go/issues/40561#issuecomment-840725710. CC @golang/…
There haven't been noteworthy builder changes in the last 2 weeks since https://github.com/golang/go/issues/40561#issuecomment-830424055. I've looked over our current selection of releaselets for 1.1…
Thanks for fixing these links.
(1 comment) Note to self: delete, this is repetitive.
Previously, we were using the branch of golang.org/x repo as the GoBranch, which is inaccurate. It made little difference because few builder policies filter by GoBranch at this time. Fixes golang/g…
Fixes golang/go#46154. Updates golang/go#36882.
This change reverts the coordinator side to be much simpler, as it was before CL 167382, and consolidates all the version selection in maintapi. This direction is chosen because at this time¹ mainta…
In golang.org/x repo, TryBots testing CLs on branches other than the default "master" branch are only tested with Go tip, not with the past 2 releases (e.g., 1.16 and 1.15). The `gopls-release-bra…
There's one more place that needs updating, opened #46154 to track it.
Issue #28891 was about having coordinator test golang.org/x repos on release branches like "release-branch.go1.n" with Go 1.n exactly, rather than Go tip. This is because those branches are specifica…
I'm not aware of builder changes on our side, but `solaris-amd64-oraclerel` is a [reverse builder](https://farmer.golang.org/builders) whose owner is @rorth, and perhaps they may be aware of some cha…
I think it's hard to determine what an optimal value for this is, given how infrequently it may happen. I wanted to suggest 2 MB to match our current limit in x/build logs, but imagining releasebot p…
I spent some time investigating this and found some additional constraints and challenges. It seems we can't make a simple change here without potentially needing larger UI and behavior changes, and …
Actually, I think there are at least 2 underlying problems. Let's keep #42084 about it ignoring re-requests on same patch set with a different TRY= message, which might be a simple logic fix. One …
The `<=` in this segment is looks suspicious: https://github.com/golang/build/blob/58cc22bdeadbabfebe33fa4dda4b08e14b036336/maintner/maintnerd/maintapi/api.go#L142-L144 Shouldn't it be `<`, els…
This looks likely to be the same as #42084. At least the investigation there could explain this instance too. Should we close this in favor of that issue or keep it open?
I think we can delete this as a next step, which shouldn't change behavior in meaningful ways, but make the current code easier to maintain and change in the future. Better to do it not during the…
This is currently in 1.17 milestone, but Go 1.15 will be supported throughout this milestone. Moving to 1.18 and adding early-in-cycle instead.
Also CC @golang/release. `GO_TEST_SHORT` is currently an internal implementation detail of the build system and not intended for users (see [here](https://github.com/golang/go/blob/d9e068d2894ff2f…
Closing but let me know if I missed something or if this needs more discussion.
This behavior is implemented by GitHub and not GopherBot per se. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-iss…
Ah, it was `playerTurn`, not `playerMove`, sorry for misdirecting.
Earlier
`gitmirror` is redeployed with [CL 318190](https://golang.org/cl/318190), and its errors are now fixed (they [could be seen](https://user-images.githubusercontent.com/1924134/117556647-14970c80-b039-…
dmitshur deleted branch in github.com/shurcooL/home1w
dev
@mvdan Sure, done.
Ok. Let's try it. This PR will need further changes to be complete: 1. The documentation of Apply should be updated to reflect the new behavior: ```Go // Apply a move to this board. Mark is …
dmitshur pushed to master in github.com/shurcooL/tictactoe1w
e4032f53f8be09b4a18f3268f03b6c5f8b8e09ebimprove formatting in Board.String
I tried it out, and agree it's an improvement. Thanks.
The `Apply` method documentation says: ``` // Apply a valid move to this board. Mark is either X or O. [...] ``` It's a precondition for `Apply` that the move must be valid. As long as it's a…
dmitshur pushed to master in github.com/shurcooL/tictactoe1w
Thank you @mvdan, I agree it would be helpful. I added one more step to Andy's comment, to add `archivedOnGitHub` option to x/build/repos (similar to [CL 289699](https://golang.org/cl/289699)), wh…
Observed the following test failure on a `openbsd-amd64-68` TryBot in https://go-review.googlesource.com/c/tools/+/313097/7#message-05b2ee7a7f430f763806057296bde561b9777f07: ``` --- FAIL: TestIdl…
@griesemer In addition to "spec: allow conversion from slice to array ptr" ([CL 216424](https://golang.org/cl/216424)), are there more change to the language for Go 1.17? I see the go_spec.html file …
"spec" isn't a Go package. This TODO should be moved to the https://tip.golang.org/doc/go1.17#language section. I can help with that.
Nicely spotted. Also CC @bcmills.
The x/net fix has been pulled into the main repo for Go 1.17 as part of [CL 316251](https://golang.org/cl/316251). Closing as fixed.
> I still find the dashboard for subrepos a bit hard to understand. Apparently the "Go commits" are not in order? Sorry about that. This is #28643, and improvements to that should follow after #3474…
Mailed [CL 316889](https://golang.org/cl/316889) for 1.17. Will move this to the next milestone when it's submitted.
The proposed scheme has some convenience improvements in specific cases, but I think the bar for introducing and perpetually maintaining a mirror of an API needs to be higher than minor convenience i…
> The failure log also links to a document that no longer exists (https://go.googlesource.com/tools/+/refs/heads/master/gopls/doc/user.md#supported-go-versions), It looks like the new link should be…
When `release` runs in upload mode (that is, with `-upload` flag), it goes through 3 high level stages: 1. [uploads files to GCS](https://github.com/golang/build/blob/249a248223ffdaccaf87d0ee76bca…
The https://golang.org/design/draft-vulndb design draft may also be a relevant factor to consider here. CC @golang/security, @golang/release.
I agree it looks like this has been fixed, so closing. Please let us know if we missed something.
As another data point, this might be useful for issue #14892, if we'd like to arrange that all first-class ports (but not necessarily all ports) are automatically specified as contexts for the purpos…
@FiloSottile After taking some time to think about it carefully, I'm in agreement with the suggestion you made. I, too, now believe there is a good chance that removing our use of next.txt and requir…
I understand this isn't so critical that we need to re-evaluate and bump every 6 months, so I'll put this in a future Go 1.23 milestone. If something changes before then, we can revisit this.
CC @golang/release.
It has come down by this time: ``` host-dragonfly-amd64-5_8: 518 waiting (oldest 24h38m57s, newest 2h30m48s, progress 2s) host-dragonfly-amd64-master: 552 waiting (oldest 24h38m57s, newest 2h30m…
Based on that information about the builder, it sounds like it's expected it to need more time to complete tests successfully, so increasing the test timeout (#45216) has a good chance of resolving t…
@tuxillo Sure, let's try going with 2x and see how it goes. We can always follow up if needed. Please feel free to send a CL and make me a reviewer. You can look at [CL 300870](https://golang.org/…
I see that both of these builders are online and doing work, so closing this. ``` host-dragonfly-amd64-5_8: 1/1 host-dragonfly-amd64-master: 1/1 ``` Thank you @tuxillo.
I'll retitle this to about adding the ability to opt-in to builders based on files modified in a CL. We need to do some work for it, but it would enable us to improve pre-submit test coverage in a mo…
Fixred by merging 5aed4ce3c854bdbbb6dd5c1ccfa15c23d4b6c989 to release-branch.go1.15.
Fixed by [CL 314632](https://golang.org/cl/314632). Thanks @bcmills for reporting and @cherrymui for fixing.
Reopening for update to the vendored copy in the Go tree.
dmitshur edited the wiki2w
dmitshur edited the wiki2w
The x/net fix still needs to be pulled into the main Go repo as done in [CL 314596](https://golang.org/cl/314596), reopening for that (and adding release-blocker so it's not missed).
Approved as this is a security fix. This backport applies to both 1.16 (#45712) and 1.15 (this issue).
Approved as this is a security fix. This backport applies to both 1.16 (this issue) and 1.15 (#45711).
@ianlancetaylor I think your understanding of how this could be implemented is accurate. I agree referring to `cmd/dist` is more precise; I was mentioning `cmd/go` only because I expected it's more l…
The `windows-arm-zx2c4` builder is currently missing. From https://farmer.golang.org/#pools: ``` host-windows-arm64-zx2c4: 0/0 (1 missing) ``` @zx2c4 Are you able to take a look? Thank you. …
Another instance in [CL 313132](https://golang.org/cl/313132). We're making progress on fixing #45213, but if this keeps happening even after that, it might be worth reopening.
The new builder will be used in future testing (existing commit with test results are not automatically re-tested at this time), so its results will show up when new commits are pushed, or by explici…
Fixed the access issue for you both.
With the work done to migrate x/build to OpenCensus in [CL 303669](https://golang.org/cl/303669), we're closer to starting to measure and track TryBot completion time, which has been a blocker for ma…
Using the latest "patch" release of the oldest "major" release of FreeBSD that we support for issuing Go 1.17 releases seems consistent with what we've done before, and SGTM.
That sounds good, thank you!