Yesterday
dmitshur commented on U1000 false positive on nested anon… in github.com/dominikh/go-tools5h
Related issues: #262, #203.
Related issues: #262, #203.Last Week
dmitshur commented on x/build/cmd/gerritbot: Gerrit asks … in github.com/golang/go1dI thought we had a similar issue. It was #27533 and it's closed now. Is this the same problem, or subtly different?
I thought we had a similar issue. It was #27533 and it's closed now. Is this the same problem, or subtly different?
dmitshur commented on stylecheck: consider requiring line… in github.com/dominikh/go-tools2dI have a style suggestion entry for this [here](https://dmitri.shuralyov.com/idiomatic-go#comments-for-humans-always-have-a-single-space-after-the-slashes). One relevant part from there is that:
>…
I have a style suggestion entry for this [here](https://dmitri.shuralyov.com/idiomatic-go#comments-for-humans-always-have-a-single-space-after-the-slashes). One relevant part from there is that:
>…dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github2dAnother step that needs to be done is to re-generate one of the files in this Go package by running the `go generate github.com/google/go-github/github` command. This is mentioned in step 5 of [CONTR…
Another step that needs to be done is to re-generate one of the files in this Go package by running the `go generate github.com/google/go-github/github` command. This is mentioned in step 5 of [CONTR…dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github2dAs mentioned earlier, this is out of place, let's get rid of it.
As mentioned earlier, this is out of place, let's get rid of it.dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github2dBased on what I see at https://developer.github.com/v3/pulls/, it seems that the field is named exactly `draft`, not `is_draft`. Do you have another source suggesting it should be `is_draft` instead?…
Based on what I see at https://developer.github.com/v3/pulls/, it seems that the field is named exactly `draft`, not `is_draft`. Do you have another source suggesting it should be `is_draft` instead?…dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github2dThanks, this is a great start!
It looks like this PR currently includes commit 31ef9b1 that shouldn't be here. It's removing some code and isn't related to issue #1120.
You should also update t…
Thanks, this is a great start!
It looks like this PR currently includes commit 31ef9b1 that shouldn't be here. It's removing some code and isn't related to issue #1120.
You should also update t…dmitshur commented on Support Draft Pull Requests API Pub… in github.com/google/go-github2d> I am really new to Go and this repo but I tried to take a shot on this. I am sorry if there's anything wrong.
@joshuabezaleel Thank you for doing that! You don't have to worry, we have code revi…
> I am really new to Go and this repo but I tried to take a shot on this. I am sorry if there's anything wrong.
@joshuabezaleel Thank you for doing that! You don't have to worry, we have code revi…dmitshur commented on x/build/cmd/gopherbot: sometimes do… in github.com/golang/2dThe fix is deployed now, and it's working as intended. See [here](https://go-review.googlesource.com/c/crypto/+/111335/7#message-17b9a455d2a4c994b44e36a167e9d631f514e0d2).
The fix is deployed now, and it's working as intended. See [here](https://go-review.googlesource.com/c/crypto/+/111335/7#message-17b9a455d2a4c994b44e36a167e9d631f514e0d2).dmitshur commented on x/build/cmd/gopherbot: sometimes do… in github.com/golang/2dThe fix is deployed now, and it's working as intended. See [here](https://go-review.googlesource.com/c/crypto/+/111335/7#message-17b9a455d2a4c994b44e36a167e9d631f514e0d2).
The fix is deployed now, and it's working as intended. See [here](https://go-review.googlesource.com/c/crypto/+/111335/7#message-17b9a455d2a4c994b44e36a167e9d631f514e0d2).dmitshur commented on x/website: tracking bug for tip.gol… in github.com/golang/go2d@cnoellekb Are you planning on working on this? If so, I'm happy to be a reviewer for the CLs. Otherwise I can take this and you can be a reviewer.
@cnoellekb Are you planning on working on this? If so, I'm happy to be a reviewer for the CLs. Otherwise I can take this and you can be a reviewer.dmitshur commented on x/build/cmd/coordinator: some subre… in github.com/golang/go2dI see two ways this can be implemented:
- a more lightweight way (i.e., without having to run all tests twice) by adding a new GOPATH mode builder for just one GOOS/GOARCH, similar to how we do th…
I see two ways this can be implemented:
- a more lightweight way (i.e., without having to run all tests twice) by adding a new GOPATH mode builder for just one GOOS/GOARCH, similar to how we do th…dmitshur commented on x/website: tracking bug for tip.gol… in github.com/golang/go2dAs part of the changes of moving website into x/website, we have to make a decision about the future scope of tip.golang.org.
Previously, tip.golang.org served two purposes: it served the latest c…
As part of the changes of moving website into x/website, we have to make a decision about the future scope of tip.golang.org.
Previously, tip.golang.org served two purposes: it served the latest c…dmitshur commented on Add include/exclude example to docs in github.com/shurcooL/vfsgen3dHi, thanks for the suggestion.
> not sure if this is the best way of doing this.
That's a reasonable way of doing it.
I've also done this using the `github.com/shurcooL/httpfs/filter` packag…
Hi, thanks for the suggestion.
> not sure if this is the best way of doing this.
That's a reasonable way of doing it.
I've also done this using the `github.com/shurcooL/httpfs/filter` packag…dmitshur commented on Feature request: allow manually set… in github.com/shurcooL/vfsgen3dThanks.
The relevant part in the snippet is here:
```Go
vfsgen.Generate(http.Dir(*dir)
```
That means you're currently using `http.Dir` as the `http.FileSystem` interface implementation th…
Thanks.
The relevant part in the snippet is here:
```Go
vfsgen.Generate(http.Dir(*dir)
```
That means you're currently using `http.Dir` as the `http.FileSystem` interface implementation th…dmitshur commented on x/build/cmd/release: go1.12rc1 sour… in github.com/golang/go4d@bradfitz You're absolutely right, that's what happened. I didn't know about that behavior of Archive Utility.app on macOS.
I also confirmed the "go" directory is indeed top-level in `go1.12rc1.sr…
@bradfitz You're absolutely right, that's what happened. I didn't know about that behavior of Archive Utility.app on macOS.
I also confirmed the "go" directory is indeed top-level in `go1.12rc1.sr…dmitshur commented on Feature request: allow manually set… in github.com/shurcooL/vfsgen5dCan you share how you're using `vfsgen` right now? If so, it'll be easier for me to show you what I mean. If not, I can try to explain anyway by coming up with an example.
Can you share how you're using `vfsgen` right now? If so, it'll be easier for me to show you what I mean. If not, I can try to explain anyway by coming up with an example.dmitshur commented on x/build/cmd/gopherbot: keeps repeat… in github.com/golang/go5dThere's a new addition, as of #30182:
```
2019/02/12 01:45:58 got corpus update after 24.897577657s
freeze
https://golang.org/issue/23772 x/build/cmd/gerritbot: <fill this in>
2019/02/12 01:…
There's a new addition, as of #30182:
```
2019/02/12 01:45:58 got corpus update after 24.897577657s
freeze
https://golang.org/issue/23772 x/build/cmd/gerritbot: <fill this in>
2019/02/12 01:…dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go5dThe current fix adds to the plate of "actions gopherbot keeps taking without any effect" (issue #28320):
```
freeze
https://golang.org/issue/23772 x/build/cmd/gerritbot: <fill this in>
```
…
The current fix adds to the plate of "actions gopherbot keeps taking without any effect" (issue #28320):
```
freeze
https://golang.org/issue/23772 x/build/cmd/gerritbot: <fill this in>
```
…dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go5dI've deployed the fix in the aforementioned CL, which is why gopherbot woke up. The CL still needs to be reviewed before it can be merged.
I've deployed the fix in the aforementioned CL, which is why gopherbot woke up. The CL still needs to be reviewed before it can be merged.dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go5dSince this isn't resolved yet, I have to manually say that I've sent a fix for the "soon" part of this issue as [CL 161906](https://golang.org/cl/161906).
Since this isn't resolved yet, I have to manually say that I've sent a fix for the "soon" part of this issue as [CL 161906](https://golang.org/cl/161906).dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go5dIssue #23772 was an empty/spam issue that was closed a year ago. It's showing up as 404 now, which gopherbot can't handle.
There are two things we need to fix here:
1. This specific problem in …
Issue #23772 was an empty/spam issue that was closed a year ago. It's showing up as 404 now, which gopherbot can't handle.
There are two things we need to fix here:
1. This specific problem in …dmitshur commented on x/build/cmd/gopherbot: sometimes do… in github.com/golang/go5dIt's a logic problem in `gopherbot` code related to how it does author comparisons, and how Gerrit sometimes represents authors as "Firstname Lastname <1234@...>", but other times as "Gerrit User 123…
It's a logic problem in `gopherbot` code related to how it does author comparisons, and how Gerrit sometimes represents authors as "Firstname Lastname <1234@...>", but other times as "Gerrit User 123…dmitshur commented on unsupported GOOS/GOARCH pair darwin… in github.com/goxjs/gl5dI'm glad I was helpful with this. :)
If you don't mind, I'll reopen this issue and use it to update the README with the new instructions.
I'm glad I was helpful with this. :)
If you don't mind, I'll reopen this issue and use it to update the README with the new instructions.dmitshur commented on unsupported GOOS/GOARCH pair darwin… in github.com/goxjs/gl5dIt is related to your project using modules. Unfortunately, the version of GopherJS on the `master` branch does not yet have support for modules. This is issue https://github.com/gopherjs/gopherjs/is…
It is related to your project using modules. Unfortunately, the version of GopherJS on the `master` branch does not yet have support for modules. This is issue https://github.com/gopherjs/gopherjs/is…dmitshur commented on unsupported GOOS/GOARCH pair darwin… in github.com/goxjs/gl5dThe intention behind that command was to fetch the GopherJS dependencies of `gl`.
I think the `go` command has gotten stricter about rejecting unsupported GOOS/GOARCH combinations. In the past, it…
The intention behind that command was to fetch the GopherJS dependencies of `gl`.
I think the `go` command has gotten stricter about rejecting unsupported GOOS/GOARCH combinations. In the past, it…
dmitshur commented on Feature request: allow manually set… in github.com/shurcooL/vfsgen6dHi @veqryn,
Thanks for the feature request. Fortunately, this is already possible to achieve without changes to `vfsgen`. `vfsgen` was designed to enable this kind of customization (and more) thro…
Hi @veqryn,
Thanks for the feature request. Fortunately, this is already possible to achieve without changes to `vfsgen`. `vfsgen` was designed to enable this kind of customization (and more) thro…Earlier
dmitshur commented on x/build: trybots should rebase when… in github.com/golang/go1wThis would've helped catch a problem in [CL 161497](https://golang.org/cl/161497), where the tests passed with an older commit as a parent, but started to fail after being rebased on latest master.
…
This would've helped catch a problem in [CL 161497](https://golang.org/cl/161497), where the tests passed with an older commit as a parent, but started to fail after being rebased on latest master.
…dmitshur commented on xerrors: adds IsOneOf in github.com/golang/xerrors1w> First, Go development is done with Gerrit (see https://go-review.googlesource.com). We don't accept GitHub PRs.
To clarify, we do accept GitHub PRs (they get imported into Gerrit via [GerritBot]…
> First, Go development is done with Gerrit (see https://go-review.googlesource.com). We don't accept GitHub PRs.
To clarify, we do accept GitHub PRs (they get imported into Gerrit via [GerritBot]…dmitshur commented on x/build/maintner: GitHub issue even… in github.com/golang/go1w> Without logs that I could investigate on what's happening this is an insanely hard task with my code base knowledge.
>
> Sorry, I couldn't help out.
Understandable, and no problem.
On the c…
> Without logs that I could investigate on what's happening this is an insanely hard task with my code base knowledge.
>
> Sorry, I couldn't help out.
Understandable, and no problem.
On the c…dmitshur commented on ST1017: possible false positive in … in github.com/dominikh/go-tools1wI see. I thought it would be `<const> <binop> <non-const>`.
I see. I thought it would be `<const> <binop> <non-const>`.dmitshur commented on x/build/devapp: doesn't make it cle… in github.com/golang/go1wThis is deployed to https://dev.golang.org/release by now.
This is deployed to https://dev.golang.org/release by now.dmitshur commented on x/build/cmd/gopherbot: don’t comm… in github.com/golang/go1wThanks for clarifying.
Thanks for clarifying.dmitshur commented on httputil/header: ParseValueAndParam… in github.com/golang/gddo1wI am not familiar with the semantics of ParseValueAndParams to have opinions. If it's within spec and doesn't break gddo, it should be fine.
That said, I would like to see this package move in the d…
I am not familiar with the semantics of ParseValueAndParams to have opinions. If it's within spec and doesn't break gddo, it should be fine.
That said, I would like to see this package move in the d…dmitshur commented on x/build/cmd/gopherbot: don’t comm… in github.com/golang/go1wThere's not enough information here for me to understand this issue. Could you please clarify.
Per https://golang.org/wiki/CodeReview (and [Interim Code Review and Issue Tracker Conventions](https…
There's not enough information here for me to understand this issue. Could you please clarify.
Per https://golang.org/wiki/CodeReview (and [Interim Code Review and Issue Tracker Conventions](https…dmitshur commented on x/build/maintner: GerritCL.Subject … in github.com/golang/go1w> According to git behavior, [...]
I could've been more convincing and brief by referencing git documentation, rather than trying to demonstrate behavior. It's documented at https://git-scm.com/do…
> According to git behavior, [...]
I could've been more convincing and brief by referencing git documentation, rather than trying to demonstrate behavior. It's documented at https://git-scm.com/do…dmitshur commented on Fix golint import path in github.com/klauspost/asmfmt1wFor posterity, this change has already been merged as part of commit 9ff68f32955e896453b502001b8266c9aeb20399.
For posterity, this change has already been merged as part of commit 9ff68f32955e896453b502001b8266c9aeb20399.dmitshur commented on x/build/maintner: isTempError impro… in github.com/golang/go1w> if `Sync` is called, and any repository sync operation fails, the entire error group will exit
> ...
> a single temporary error in the `Sync` call will always abort all other routines in the grou…
> if `Sync` is called, and any repository sync operation fails, the entire error group will exit
> ...
> a single temporary error in the `Sync` call will always abort all other routines in the grou…dmitshur commented on x/build/devapp: doesn't make it cle… in github.com/golang/go1wI've sent [CL 161219](https://golang.org/cl/161219) with the fix. It can be previewed on a staging instance at https://dev-staging.golang.org/release#Pending%20CLs.
I've sent [CL 161219](https://golang.org/cl/161219) with the fix. It can be previewed on a staging instance at https://dev-staging.golang.org/release#Pending%20CLs.dmitshur commented on x/build/cmd/builder: delete in github.com/golang/go1wI followed up by [removing the old-style builder section](https://github.com/golang/go/wiki/DashboardBuilders/_compare/5134752ac102b78d09b5a3cd2d00dd7531421a08...fc308971ff06504290f34bc6d58bae59fe613…
I followed up by [removing the old-style builder section](https://github.com/golang/go/wiki/DashboardBuilders/_compare/5134752ac102b78d09b5a3cd2d00dd7531421a08...fc308971ff06504290f34bc6d58bae59fe613…dmitshur commented on ST1017: possible false positive in … in github.com/dominikh/go-tools1wI didn't expect it to have an effect on ST1017, but using such constants makes `staticcheck` no longer emit ST1017 on those lines.
I agree using consts for paths is better, and that was the long ter…
I didn't expect it to have an effect on ST1017, but using such constants makes `staticcheck` no longer emit ST1017 on those lines.
I agree using consts for paths is better, and that was the long ter…
dmitshur commented on x/build/cmd/gopherbot: reply to com… in github.com/golang/go1w> (Almost sure there was an issue for this, but couldn't find it. Please close as dup if anyone does.)
@FiloSottile That issue is #25450. It was a proposal to tackle this problem, and it was appro…
> (Almost sure there was an issue for this, but couldn't find it. Please close as dup if anyone does.)
@FiloSottile That issue is #25450. It was a proposal to tackle this problem, and it was appro…