Activity

Last Week
(1 comment) Thanks. I've considered it, and didn't find a way to make this change that I thought worked well. Making it a constant requires coming up with a good name and rearranging comment…
I've mailed [CL 407615](https://go.dev/cl/407615) that makes android-amd64-emu a post-submit builder only (in the main repo) while investigation of this issue is underway. If submitted, this issue ca…
This builder is known to run into errors while running runtime tests, as tracked in go.dev/issue/51001. This causes more disruption because the builder is a default TryBot. Since GOOS=android is not…
Thanks for letting us know about this. I believe we're in agreement that this is okay. Approved.
Thanks. I see that only 2 builders are currently connected, but ExpectNum here says 5. The builder owners can either spin up 3 more builders or update ExpectNum to say 2 instead, depending on what&#…
(1 comment) I had the same thought when reading the code and the error in https://go.dev/issue/42699#issuecomment-1072858349, and this reaffirms that it was unfortunately unintentionally missed. Sen…
The coordinator relies on Exec reporting that the given timeout was exceeded in order to mark a build as failed instead of retrying it. A refactor resulted in Exec no longer doing that, despite what …
dmitshur pushed to master in github.com/shurcooL/githubv42d
0b4e3294ff0076145153b32bdd09d1794ca0f387regenerate for schema changes by 2022-05-19
dmitshur pushed to master in github.com/shurcooL/graphql2d
bdb1221e171e552b0c7228c0837e6a2a2038b0f1ident: add GitLab, DevOps, IssueHunt, LFX brands
dmitshur commented on runtime: TestGcSys is still flaky2d
@mknyszek The test `TestGcSys` is still [checked in](https://cs.opensource.google/go/go/+/master:src/runtime/gc_test.go;l=23-33;drc=f01c20bf2ba889e5c9e3565175cc4276f9c11516) on tip, but with a skip t…
(3 comments) Optionally also mention "go repo" before branches, to clarify it's not the x repo ones. Perhaps add something like: (empty list means main branch only) I figured it o…
Thanks, I think this is a good change. See inline comments that point out of a few specifics, I don't expect there's more after that. Add: Fixes golang/go#50474. Since this removes the…
Thanks Ian. For the record, my upcoming coordinator change was going to include a 5 minute timeout on the x/build side via [`DistTestsExecTimeout`](https://pkg.go.dev/golang.org/x/build/dashboard#…
(Moving myself to CC since this has active reviewers.)
I suspect [CL 207908](https://go.dev/cl/207908) and [CL 208157](https://golang.org/cl/208157) made a lot of progress on this, and we're in a state where most buildlet methods that should have a conte…
I ran into this most recently while sending a trivial fix in https://go.dev/cl/406897, where a linux-amd64-longtest SlowBot request took almost 2 hrs instead of the usual 10-15 min, and while waiting…
I've observed a few more instances of this with `testsanitizers`. I think the root cause here is the same as issue #42699: some test is stalling, and eventually gets retried and succeeds. I've fil…
(This is mostly a continuation of #33249, with some new information.) There's evidence of a problem where this test can sometimes hang indefinitely, though in some environments there is an externa…
We generally have a global timeout for VM/pod-based builders (see #52929), though not sure about if reverse builders have something equivalent or not. I'll close this in favor of #35364, a more recen…
(1 comment) This was indeed fixed in PS 2—thanks. Marking this thread as resolved so GopherBot sees that and can auto-submit this CL.
(1 comment) I'll mark this resolved so the CL gets auto-submitted, we can take care of this in future release note editing passes.
Not sure why this thread didn't get marked as resolved. I've done that now.
I don't know what this test is doing, but it very frequently flakes for me while testing mundane compiler CLs. According to the issue log, it's been flaky for ~3 years. Updates #37331. Fixes…
Running the test 100'000 times on a darwin/amd64 machine did not reproduce the problem. Running the same on a darwin/arm64 machine seems to reproduce after a while: ``` $ go test -count=100000…
dmitshur commented on all: tidy std module4d
(This'll be submitted soon; also using this CL as an opportunity to debug a coordinator issue.)
(1 comment) Mailed CL 406897 to remove these now-unused entries.
dmitshur commented on all: tidy std module4d
TRY=longtest
dmitshur opened a change all: tidy std module4d
Run go mod tidy to remove go.sum lines that are unused as of CL 406914. (This was spotted by the cmd/internal/moddeps.TestAllDependencies test.)
`git-codereview` implements a fake Gerrit server (type `gerritServer`) and a git helper (type `gitTest`) for its tests, which might be relevant here (spotted via #50576).
Since it's not already mentioned, I'll add that one of the few ways to test `gopherbot` changes now is via its `-dry-run` mode. This helps, but it's not a complete nor ideal solution. If we mock i…
My understanding of the state of this issue is that it can in Backlog milestone without a release-blocker label. That is, the known-failing test is skipped (via [CL 402181](https://go.dev/cl/402181))…
dmitshur merged a change golang.org/x/build/cmd/cl: delete4d
[CL 406355](https://go.dev/cl/406355) and [CL 406356](https://go.dev/cl/406356) updated golang.org/x dependencies. [CL 406359](https://go.dev/cl/406359) updated github.com/google/pprof. (Other indi…
Note: This also pulls in the latest demangle which includes a doc comment change Russ meant for 1.19 in https://github.com/ianlancetaylor/demangle/pull/15; this was upstreamed to pprof first via http…
Pull in the latest published version of github.com/google/pprof as part of go.dev/issue/36905. Done with: go get github.com/google/pprof@upgrade go mod tidy go mod vendor For #36905.
dmitshur deleted branch in github.com/google/pprof5d
update-dep
dmitshur pushed to update-dep in github.com/google/pprof5d
(1 comment) Let's mention the issue so this CL shows up in its timeline: For golang/go#48021.
There are newer versions of dependencies available. Start using them. I reviewed the change locally by comparing the diff of `go mod vendor` before and after. There were expected changes in x/sys/…
dmitshur pushed to update-dep in github.com/google/pprof5d
dmitshur created branch in github.com/google/pprof5d
update-dep
dmitshur deleted branch in github.com/google/pprof5d
update-dep
dmitshur pushed to update-dep in github.com/google/pprof5d
7d74b6bf53bff97dc3079980459a2c44318c1352all: update dependencies There are newer versions of dependencies available. Start using them.
dmitshur created branch in github.com/google/pprof5d
update-dep
Thanks for preparing this CL. It was not reviewed, and by now a newer pprof has been pulled in via CL 393370, so I'll close this.
It looks like this was sent to the main branch via CL 279425, and in turn got superseded by CL 301889. Closing since this is probably not needed, please reopen otherwise.
TRY=longtest, linux-386-longtest, windows-amd64-longtest, darwin-arm64
TRY=longtest, linux-386-longtest, windows-amd64-longtest, darwin-arm64
The Go 1.19 code freeze has recently started. This is a time to update all golang.org/x/... module versions that contribute packages to the std and cmd modules in the standard library to latest maste…
(1 comment) Note that exec.Command uses LookPath internally when given a binary name rather than a complete path, so it's viable to skip the explicit LookPath call and just do exec.Command("…
(2 comments) (Also, at least when it was execve'ing 'ssh', it wasn't viable to defer anything since the ssh process was replacing the gomote process as described in Heschi's repl…
(3 comments) Nit: Also s/renew/Renew/ here since that's the new name of the method. Typo, s/Incomming/Incoming/g. Is it intended for KeepAlive's context to get canceled when IncomingSSHPos…
(3 comments) The ID 'remote' is already used above. Minor: This can return template.HTML, which'll eliminate the conversion at the call site. Can be simplified slightly to time.Until(s…
(3 comments) Nit: https://go.dev/s/style#error-strings applies here, s/Unable/unable/ (it's already done in other instances). If the execve system call is used here, gomote program execution wi…
(1 comment) (That might change in CL 405257 where it gets more fields.)
(1 comment) Done. (It's https://go.dev/issue/52929).
[CL 406216](https://go.dev/cl/406216) increased the timeout to 2 hours, and longtest builds are completing on first try or so. Compare [before](https://user-images.githubusercontent.com/1924134/16840…
(1 comment) Still need to make it.
The comment of [`CleanUpOldVMs`](https://cs.opensource.google/go/x/build/+/master:internal/coordinator/pool/gce.go;l=648-661;drc=3ab5e7e87a80893ee88aba0e9de7e86cde9f5a0a) (and `CleanUpOldPodsLoop`) i…
dmitshur pushed to master in github.com/go-gl/glfw6d
eb3e265c76614051c36c141350d9740d439c068dall: fix typos in documentation
LGTM. Thanks.
dmitshur pushed to master in github.com/go-gl/glfw6d
8da84822faab099fbb16874b628a80a2b2a7ee9fv3.3/glfw: apply minor code cleanup
If you'd like, lines 174, 229, and 231 can also benefit from a similar fix.
Earlier
dmitshur reviewed +1 on cmd/compile: regenerate ssa1w
I get an identical diff when regenerating ssa locally. Leaving +2 to someone more familiar with this package. Please include the CL number "CL 367039" instead of (or next to) the commit hash.
Yep, looks like it hasn't been added. Please feel free to send a PR if you have a need for it.
dmitshur pushed to master in github.com/go-gl/glfw1w
I think this is okay to add. Thanks.
Yeah, if we stop defining _GNU_SOURCE and that causes a warning in GLFW C codebase due to _GNU_SOURCE not being defined, that might be something that is better suited to be addressed upstream. Are…
dmitshur pushed to master in github.com/go-gl/glfw1w
597ae79a86c6cf2997fc178267cff9a519f851c9v3.3/glfw: update to GLFW 3.3.7
(1 comment) I see, that matches my understanding, thanks!
I had a memory of that code missing some case, but I couldn't recall what it was exactly and left for later. Now I remember! Sent CL 406414 to fix the panic, leaving just the wrong parameter name…
Sometimes the number of parameters matches, but their names don't. Report that with a descriptive error rather than a nil pointer dereference panic.