Thanks. Just adding a couple style suggestions.
(nit) The "Update latestgo to " prefix here doesn't need to be included because Go commit subjects implicitly complete the sentence "This change modif…
(1 comment)
(minor) Since this isn't the main Go repository, issues in the main Go issue tracker need to be fully qualified by adding the 'golang/go' prefix before '#'. (See https://go.dev/wiki/Comm…
Thanks.
If I understand correctly, this is saying that it is in fact possible to change the cmd/go command in a way that would permit normal Go tests to emit ^V characters without breaking go test -…
Thanks.
Thanks.
Part of my point was that by now I'm not sure that setting CGO_CFLAGS is needed at all on either architecture, given the lack of a known repro case of what breaks if its unset and h…
(1 comment)
This looks to be equivalent to '-dGoMajorVersion=1' until Go 2 is out, which I don't think is your intention here. (https://go.dev/play/p/koczj41XviY)
Thanks.
(nit) The trailing '/' is not included in the canonical URL on go.dev anymore and can be left out.
(minor) Maybe add 'Go' prefix here to improve readability, since there are various things …
(3 comments)
Is there evidence that setting this field has a positive effect, or any observable effect?
(It was previously intentionally left out on the new macOS architecture until such evidence e…
Thanks for working on this. A few comments from an initial look.
Now that the ".0" is there, is VersionNoPatch still needed or is it just the same as "Version"?
https://go.dev/issue/57631#issuecomm…
I used CL 478155 to get a not-fully-complete but fairly representative all.bash run with `go test -json` output, and converted it to some basic HTML to visualize the data. I intentionally added 2 fai…
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel go1.21-ac881545ce Tue Mar 21 12:44:04 2023 -0400 darwin/arm64
</pre>
### Does this issue reproduce wi…
Thanks.
Thanks for updating the docs here.
I'll just point out that it seems there's also a copy (or two, though I hope x/tools owners will tag+delete the godoc copy soon) in x/tools, but 'system' …
Thanks for suggesting and implementing this, and sorry I didn't get a chance to comment sooner. I've had the idea of doing something like this for some time and I've seen it successfully used in http…
We can do all golang.org/x GitHub mirrors too (and the special case without x, golang.org/dl). At least I can't think of a downside to treating them the same as the main Go repo mirror for the purpos…
It does seem likely that there was some incompatibility in your local build environment setup. If the problem doesn't reproduce with a functional latest version of Xcode, I don't think there's anythi…
Looking at https://build.golang.org/?repo=golang.org%2fx%2ftools, the linux-amd64-perf builder column has some "ok" rows but most are empty.
At https://farmer.golang.org/#completed right now there…
Another case affected PR #58779. It was submitted on Gerrit 5 days ago and the PR wasn't marked as closed.
It once again got stuck on `Changes for PR golang/go#58779 have yet to be mirrored in the…
Closing because this PR has been merged via [CL 471915](https://go.dev/cl/471915) as commit dfe4591fc4d2d66da7740de18b32761e7a20691c.
(Normally `gerritbot` does this, but sometimes it needs help d…
Starting with [CL 462035](https://go.dev/cl/462035) (CC @randall77), the aix-ppc64 builder is failing during bootstrap:
```
Building Go cmd/dist using /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go…
Pinging issues with "early-in-cycle" is a task that we do once every 6 months, after the development of a new major Go version starts. Right now it's implemented as a task in `gopherbot` that needs t…
Hello,
Thanks for your contributions and making this access request. The "approvers" access permits reviewing and submitting CLs across the entire Go project as documented https://go.dev/wiki/Gerr…
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
[CL 467297](https://go.dev/cl/467297) and a few others took care of this for early in cycle.
Removing that label to revisit this at the start of freeze.
Thanks watchflakes, but commit 600d37 is before the fix in commit [21e451e](https://go.googlesource.com/go/+/21e451ec446724c9f3f124139e07d88ff812a1bc).
At some point between filing this proposal and now, I've realized that the "v" part in a string like "v1.2.3" is not a part of SemVer 2.0.0. See https://semver.org/spec/v2.0.0.html#is-v123-a-semantic…
This test is not failing on Windows builders on release-branch.go1.19. Either there's no problem (i.e., TestSystemVerify was modified in a way that needed the fix only in Go 1.20) or perhaps it's bec…
@mdempsky Please add a short backport rationale to this backport issue (see https://go.dev/wiki/MinorReleases; "The issue should include a link to the original issue and a short rationale about why t…
This was observed again on 2023-02-28 19:38:
```
GitHub Activity Service: ok
Gerrit Activity Service: walkSegMail(gerrit.fileSeg{file:"/2023-03.reclog", skip:0, size:4096}): truncated record at …
Thanks for reporting.
We're using Xcode tooling to create a fairly standard macOS installer (see [here](https://cs.opensource.google/go/x/build/+/master:internal/task/buildrelease.go;l=298;drc=f03…
Currently at https://farmer.golang.org/#pools:
```
host-darwin-amd64-10_15-aws: 0/0 (2 missing)
```
And there are no builds on the last 30 commits in the main Go repo. Although the most recen…
The problem seems to be that `testGo` is only set when `testenv.HasGoBuild()` reports positively, but when GOOS=android it returns false. The test currently doesn't check `testenv.HasGoBuild()` nor `…
[CL 468636](https://go.dev/cl/468636) (CC @bcmils) recently improved TestDocsUpToDate to invoke `go help documentation` directly, without the mkalldocs.sh script, but it's not able to run at least in…
These are two different modules.
Module `github.com/go-gl/glfw/v3.3/glfw` contains v3.3.
Module `github.com/go-gl/glfw` contains older versions: v3.0, v3.1, and v3.2.
At least some code that parses Go versions and/or tags may have code that explicitly handles ".0" as a special case, and that would to change (for example, see [here](https://cs.opensource.google/go/…
Closing as fixed by [CL 362414](https://go.dev/cl/362414).
(Not sure why it didn't get closed automatically via the "Fixes" line in https://github.com/golang/tools/commit/8111118043894a9c0eab886fc…
Thanks for reporting this.
The Go installer on macOS adds the installed `go` and `gofmt` binaries to `PATH` by placing a file containing the "/usr/local/go/bin" path to the /etc/paths.d directory.…
The /dl/upload endpoint has some logic to clear the cache at the end ([here](https://cs.opensource.google/go/x/website/+/master:internal/dl/server.go;l=195;drc=71c2d285b86a517fbac3e662cbf461d326846b4…
Xcode completes its installation on its first launch, showing a prompt that looks like this (in a recent version):
<img width="612" alt="image" src="https://user-images.githubusercontent.com/19241…
A few more things for me not to forget to update:
- in main repo: test/codegen directory README has instructions for running all codegen tests beyond that what all.bash runs on linux-amd64 builder…
x/build is exempt from Go 1 compat and even the release policy as documented at the top of README; if the failing platform isn't something we want to go out our way to support (e.g. we only support c…
> older hardware, such as my 2015 mac book pro
Is there a typo in that example? 2015 MacBook Pro models can run up to macOS 12 Monterey (released in 2021), see https://support.apple.com/en-us/HT21…
For context, this [comment thread](https://go-review.git.corp.google.com/c/go/+/448802/4..7/src/cmd/dist/test.go#b359) captures some of the reasons why `-run=^$` was chosen over test -c at the time, …
[CL 464342](https://go.dev/cl/464342) and [CL 464875](https://go.dev/cl/464875) regenerated the index after the Go 1.20 release.
Moving to the next milestone since this won't need attention until Go…
Doing `go generate golang.org/x/tools/internal/imports` is fine with Go 1.19 and older, but fails when using Go 1.20:
```
$ go version
go version go1.20 darwin/arm64
$ go generate
2023/02/02…