Activity

Today
(1 comment) Minor and optional comment: this link works, but it might be better to link directly to https://go.dev/blog/survey2020-results to skip a redirect.
Minor suggestion. Maybe it's better to reverse the order so the latest version (1.17) is tested and listed first, and the oldest version 1.12 is at the bottom (since it's least important and soones…
Last Week
With this change, the computation of the scale factor becomes identical across the freetype and truetype packages, removing deviations in the font metrics that are derived from scale. The roundi…
dmitshur created branch in github.com/golang/freetype1d
scale-nearest
I noticed there's sometimes a tiny discrepancy in font metrics as computed by `freetype.Context` and `truetype.NewFace`. As a reproducible example, using the Go Mono font of size 86.4 exactly, at …
Thanks—this is a duplicate of #60.
Looks reasonable to me. One minor comment/question. Is "/usr/X11R6/include" considered a standard include directory on OpenBSD?
Updated the milestone to Go 1.18 since that's the version this proposal was implemented. This change is significant enough to warrant being mentioned in the [1.18 release notes](https://tip.golang…
dmitshur commented on syscall/js: remove Wrapper interface4d
RELNOTE=yes
This is a 32-bit architecture, so increasing machine RAM size beyond 4 GB is unlikely to help. Going with CL 357370 instead.
This is a 32-bit architecture, so increasing RAM of the machine to 16 GB probably won't help (thanks @cagedmantis for catching this). I think the right next step here is #49090.
OpenBSD 6.4 is not supported by now. Fixes golang/go#49090. Fixes golang/go#36563. Fixes golang/go#38413. Fixes golang/go#46080.
Indeed, OpenBSD 6.2 is not supported, closing.
At this time, OpenBSD 7.0 (released 6 days ago) and 6.9 are the supported releases of OpenBSD per their support policy of maintaining the last 2 releases. OpenBSD 6.4 stopped being supported on Octob…
Thank you for letting us know. We have discussed this on the team and agreed that this exception is okay to make for 1.18, especially since this is a part of overall generics work that is in scope of…
@bcmills Based on a recent test failure (e.g., https://build.golang.org/log/3d50d2e41477382548e0b84905d5dff6ea05f2f2) and the test code, to me it looks like the problem may be that the test code trie…
(1 comment) In case there are 2 or more PATH variables in env, only one of them (previously the first, now the last) will be removed. If the goal of this fix is to allow setPathEnv to operate corre…
RELNOTE=yes
This line looks off: ``` } `graphql:"node(id: $repoId")` ``` Perhaps it should be: ``` } `graphql:"node(id: $repoId)"` ```
Earlier
dmitshur starred in github.com/gotify/server/v21w
Both command line arguments and environment variables are currently passed to WebAssembly by writing them to linear memory, and [CL 354571](https://golang.org/cl/354571) added a fixed limit of 4096 b…
(4 comments) Nit: NestedVirt or 'nested virtualization'. This HostConfig doesn't set MinCPUPlatform, so maybe mention NestedVirt instead (or in addition to). Same as above. Maybe this…
I'll give it some time before submitting CL 355669, since the builder machine type changed slightly in CL 354757, so we have more data. (Otherwise we won't know what it was that fixed it.) > > Thi…
Stay with 4 vCPU, but increase RAM from 4 to 16 GB. This is to help this builder run x/tools tests without running into problems caused by having insufficient memory. For golang/go#36563. Updates go…
Now that [CL 354757](https://golang.org/cl/354757) is submitted, I'll send a CL for this.
(1 comment) Some relevant resources for reference: • https://cloud.google.com/compute/docs/machine-types#machine_types • https://cloud.google.com/blog/products/compute/google-compute-engine-get…
From the original comment: > I suspect this may be similar to #36444. This builder is currently on n1-highcpu-4, which has only 3.6 GB memory, and that is likely not enough for x/tools tests to pa…
The pattern that seems to establish itself here is that builders that run x/tools tests need approximately 16~ GB RAM. Going with as little as 4 or 8 GB RAM has proven to be insufficient in a number …
(2 comments) FWIW, GitHub API v4 added support for filtering milestones with a query on the title. But v3 doesn’t have that, and the error indeed doesn't report the ID of the conflicting miles…
This target updates the buildlet binary used by builders that test the darwin/arm64 port (i.e., darwin-arm64-11_0-toothrot). Updates golang/go#39782.
(1 comment) Since #34352 isn't resolved yet and the checked out x repo is also being used for running tests in the code below, let's include that in the comment so that it's a more compl…
dmitshur reviewed +2 on all: update vendored golang.org/x/tools2w
TRY=longtest (for more thorough coverage by cmd/internal/moddeps.TestAllDependencies test)
(5 comments) s/run go env GOMOD/find go.mod files/ Running tests in module mode can be done without checking out said files to disk, instead relying on module mirror to fetch the code to be tested.…
TRY=longtest (for more thorough coverage by cmd/internal/moddeps.TestAllDependencies test)
It turned out we had sufficient coverage so none of the subrepos needed this, and we got by without ever implementing it. So the decision here is "won't fix". Closing in favor of #48875.
Yes, I think by now it's safe to drop that path. Issue #30233 was open for a long time to test some x repos in both modes, but we got by without ever implementing it. Given the status of GOPATH mode…
The current release process relies on humans to create GitHub milestones for future Go releases. releasebot includes automated checks that detect when that step is forgotten. CL 294249 included one o…
Thanks very much @jclulow! The issue affecting `cmd/cgo` and causing a visible failure was fixed via [CL 354695](https://golang.org/cl/354695), which is why this issue is closed now, but updating th…
Do you have a sense of how much extra time this adds? Would it be worth blocking landing this on having metrics for average builder completion time, or not worth? Given each tester.runPending invoca…
(1 comment) Please apply the suggested action for revert CL commit messages (https://golang.org/wiki/CommitMessage#reverts): > Edit the description to add the Gerrit CL number being rolled back …
Since the builder appears to be providing its own functional GOROOT_BOOTSTRAP value, I understand it's also possible to fix the issue by removing its incorrect override in dashboard.go.
The buildlet binary for darwin-amd64 has been updated (the rest to follow). @bcmills Can you check whether it's working as expected in CL 223755?
(2 comments) Another mention of Docker Hub. Another. (Maybe fine to update later.)
For quick reference, the outstanding CLs for this issue that I'm aware of and their status as of this posting: - [CL 240611](https://golang.org/cl/240611) - includes "For #​41184", has +2, outst…
@jclulow is the owner of the `illumos-amd64` builder listed at https://farmer.golang.org/builders, and I understand the only one able to resolve this issue. Please let us know if someone else can he…
Nice work, Go Bot! 😎
Thanks. Leaving a +2 but probably better not to submit before the current release is complete (#48843). > the convenience of using envutil didn't seem worth the maintenance headache of dealin…
> I mailed out a CL to fix this, but I think it will require some deployment work to determine whether it fixes the problem. I think the change in [CL 353549](https://golang.org/cl/353549) most re…
A [comment on Apr 23](https://github.com/golang/go/issues/32632#issuecomment-825932443) mentions a revised target time: > Our updated target time for TryBot completion time is 10 minutes (see subj…
Closing since I understand this is all resolved, thanks again!
dmitshur starred in github.com/Khan/genqlient3w
The old golang.org/pkg/ documentation server indeed used anchors for examples that don't exactly match those on pkg.go.dev. When pkg.go.dev was in its early development stages in 2019, since it was a…
godoc is essentially in maintenance mode by now, and may be headed towards being replaced with a newer tool based on a more actively maintained documentation rendering library (e.g., see issue #48264…
dmitshur pushed to master in github.com/shurcooL/githubv41mo
6831e00d857f83854b9207d58a3b5616447b3385regenerate schema for changes by 2021-09-20
Thanks, changes look good. I think it's okay to go with `string` as the underlying type for the new Base64String scalar for now. It's simpler, and gives the caller explicit control over the base64…
dmitshur pushed to bkeyes/update-schema in github.com/bluekeyes/githubv41mo
dmitshur starred in github.com/bluekeyes/patch2pr1mo
dmitshur starred in github.com/bluekeyes/go-gitdiff1mo
Heya! 😀 Sorry that it's via an issue report! 😅 > this is definitely unintentional. Thanks for confirming. > what may be happening is our usage of gofumpt From what I can tell, this particul…
Consider the following (minified) example program that tries to print a value of type [`font.Metrics`](https://pkg.go.dev/golang.org/x/image/font#Metrics): ```Go package main import ( "fmt" …
dmitshur starred in github.com/magcius/noclip.website1mo
This issue is likely a subset of #40371. <details><summary>Environment Details</summary> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.17.1 darwin/…
By now, GitHub Discussions are being tried out in the Go project to a limited degree. See https://github.com/golang/go/discussions/47139.
dmitshur starred in github.com/mystor/git-revise1mo
@ifamakes I've checked the `Distribution` file in go1.17.darwin-arm64.pkg, and it still has `hostArchitectures="arm64"` set, so that hasn't regressed on our side. Since this issue has been closed fo…
I understand the scope of this issue is x/pkgsite, and I don't mean to change that. I'll point out that a similar issue may apply to x/website, though golang.org serves documentation under a signi…
The problem turned out to be a misconfigured use of `autocert` (not enabling `acme.ALPNProto`, and not using `HTTPHandler`), which prevented gerritbot's HTML "hello" page from being served. [CL 34843…
@davidkarlsen Something like this should work: ```Go variables := map[string]interface{}{ "somekey": (*githubv4.String)(nil), // or another concrete type instead of String // ... } ```
With the 5 CLs above, we're in good shape for early in cycle. Removing that label to revisit this closer to the code freeze.
dmitshur starred in github.com/ianlancetaylor/demangle1mo
dmitshur pushed to master in github.com/shurcooL/httperror1mo
9bb3cabb3d153353a5ca771ba6c403dd0b481764use errors.As instead of type assertion in IsError functions
dmitshur pushed to master in github.com/shurcooL/httperror1mo
This seems to happen occasionally, suggesting the test is flaky: ``` --- FAIL: TestParallelism (0.15s) workflow_test.go:122: task sleep #1 : started workflow_test.go:122: task sleep #2…
@timothy-king Correct. Go 1.17 and 1.16 do not have this problem.
Sounds good. Please include a small test in x/crypto that this package doesn't import `fmt`, so this property doesn't accidentally regress without the benefit of go/build's test.
The `curve25519` package imports `fmt` and uses it 3 times: ```Go return nil, fmt.Errorf("bad scalar length: %d, expected %d", l, 32) return nil, fmt.Errorf("bad point length: %d, expected %d", …
Bisection shows this problem is introduced in [CL 338529](https://golang.org/cl/338529): ``` $ (cd cmd; go get -d golang.org/x/tools@3fce476f0a782aeb5034d592c189e63be4ba6c9e && go mod tidy && go …
There is a problem on tip when the vendored x/tools module is updated to its latest master pseudo-version (as part of #36905). ### What did you do? ``` $ git clone https://go.googlesource.com/…
The fix that closed this issue landed into master branch, which is where Go 1.18 development is happening, so moving this issue to the Go1.18 milestone. (The 1.17 backport issue #47854 is in 1.17.1 m…
This issue was closed in NeedsInvestigation state without a fix, but if a fix were to be made, it would need to target Go 1.18 first. Since this isn't a [backport issue](https://golang.org/wiki/Minor…
Also CC @changkun, @hajimehoshi.
cmd/coordinator has been redeployed, so the reverse builder should be able to connect. It’s visible at https://farmer.golang.org now: > host-linux-riscv64-unmatched: 0/0 (1 missing)