Activity
Yesterday
dmitshur commented on github.com/shurcooL/githubv4: More of a question; need clarification3h
I suspect what's happening is that the type of Enterprise.Members a list of EnterpriseMember, which is a GraphQL union:
https://docs.github.com/en/graphql/reference/unions#enterprisemember
So i…dmitshur commented on golang.org/x/build: update Go bootstrap on Corellium builders4h
It looks like these builders are now using a Go 1.18.3 bootstrap (up from Go 1.15.3), and passing:
- [android-arm-corellium at 2f6783c098696790223eae6986700868e9da0472](https://build.golang.org/lo…dmitshur reviewed +2 on golang.org/x/tools/gopls/doc/workspace: correct grammar8h
dmitshur pushed to
patch-1 in golang.org/x/tools8h
dmitshur reviewed +2 on golang.org/x/tools/gopls/doc/workspace: correct grammar8h
(2 comments)
Done in PS 2.
Done.dmitshur commented on cmd/pprof: graphviz node names are funny with generics10h
> Do we have a standard process for backporting one-off fixes to vendored packages, rather than wholesale updates?
We have a standard process that applies to golang.org/x dependencies. It uses "inte…dmitshur commented on cmd/pprof: graphviz node names are funny with generics10h
@prattmic The backporting approach described in https://github.com/golang/go/issues/34536#issuecomment-572188389 suggests we'll need to also backport the fix to 1.18, since the problem also exists in…dmitshur commented on build: update comments about Go 1.4 in make.bash, make.bat, make.rc11h
(1 comment)
Can add "Fixes #54301."dmitshur reviewed +2 on build: update comments about Go 1.4 in make.bash, make.bat, make.rc11h
Also see CL 421834. However this one also addresses some redundancy that we don't want to touch each time the bootstrap will change again.dmitshur reviewed +2 on golang.org/x/build/vcs-test: clean up dead code11h
dmitshur reviewed +2 on cmd: [release-branch.go1.19] vendor github.com/google/pprof to fix mangled type parameter symbol names11h
(1 comment)
You can try to create this change from scratch by running the usual 3 commands in the cmd module:
```
go get github.com/google/pprof@v0.0.0-20220729232143-a41b82acbcb1
go mod tidy
go mo…dmitshur reviewed +2 on golang.org/x/build/vcs-test: clean up dead code12h
Thanks.
It seems to be used now:
```
$ curl -v https://vcs-test.golang.org/ 2>&1 | grep "Let's"
* issuer: C=US; O=Let's Encrypt; CN=R3
```
I take you'll make sure it also works over the vcs-test-…dmitshur reviewed +2 on golang.org/x/build/...: re-disable container native routing12h
dmitshur reviewed +2 on golang.org/x/build/...: re-disable container native routing12h
dmitshur reviewed +2 on golang.org/x/net: TEST13h
Test review.dmitshur reviewed +2 on golang.org/x/net: TEST13h
Test vote.dmitshur reviewed +2 on test: remove unused code in run.go14h
Thanks.dmitshur reviewed +2 on golang.org/x/net/nettest: fix Unix socket test on macOS14h
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: update early in cycle email link for 1.2015h
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/relui: fix two silly mistakes15h
(1 comment)
Wow, this one hid for almost a year. Thanks for catching.dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: remove Kubernetes buildlet support15h
Nice cleanup, thanks.
Which part are you referring to?
Nit: s/VMS/VMs/
I thought we could also get rid of this entire feature since it's not at all used and it depended on the kube pool, but updat…This Week
dmitshur reviewed +1 on golang.org/x/build/dashboard: fix vet warning1d
dmitshur reviewed +2 on build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.171d
Thanks.
We'll likely want to reduce how many things need updating here if we'll be bumping the bootstrap requirement more often (#54265), but this is fine for now.dmitshur reviewed +2 on golang.org/x/build/internal/relui: fix layout for large parameters1d
Thanks very much.
If you want, you can add 'Updates golang/go#53382.' since this extends that work.
Question: Is this attribute used or going to be used? Similarly for 'data-slice' on line 244.dmitshur commented on build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.171d
See inline comments that point out a few more places that are in need of a similar update.
This can be updated.
Here.
Here, and also on line 80 below.dmitshur commented on build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.171d
(2 comments)
I don't think we want to delete the use of go1.4 directory as a last fallback yet. Some users or setups may have a newer, compatible bootstrap at that location, and maybe there's not si…dmitshur opened an issue golang.org/x/vuln/vulncheck: TestCommand, TestBinary, TestExtractPackagesAndSymbols, TestLineFromAline failing after compiler generated symbol change2d
https://build.golang.org/?repo=golang.org%2fx%2fvuln shows test failures on Go tip as of [CL 317917](https://go.dev/cl/317917) ("all: use ":" for compiler generated symbols").
CC @golang/vulndb, @…dmitshur reviewed +2 on golang.org/x/build/env/linux-x86-alpine: update to Alpine 3.162d
dmitshur commented on golang.org/x/build/cmd/relui: workflow parameters of slice types aren't visibly shown2d
Sure, thanks for helping!dmitshur opened a change golang.org/x/website/cmd/golangorg: make release.txt less brittle2d
CL 421426 extended release.txt coverage to include history entries for
the latest releases, including the currently supported Go 1.19 and 1.18.
Make the test less strict so it doesn't start to fail w…dmitshur reviewed +2 on golang.org/x/build/internal/task: always log through the TaskContext2d
Thanks.dmitshur reviewed +1 on golang.org/x/build/internal/task/releaselet: speed up MSI builds2d
Nice speed up, thanks.
Does the generated installer size change much/at at all? We'd probably want to prefer spending a few more minutes when generating if that helps all the users downloading. (Of …dmitshur commented on golang.org/x/build: add to trybot set based on port-specific files2d
Issue #42661 is related, it's about automatically opting-in to longtest builders when a change is deemed to modify the cmd/go command or its tests.
CC @golang/release.dmitshur commented on cmd/go: improve error message for replace with '@' in path2d
(The new x/mod version will need to be brought into the main repo, and that'll happen at the very least via #36905.)dmitshur commented on golang.org/x/mod/modfile: improve error message for replace with '@' in path2d
Thanks.dmitshur commented on net/http/cgi: remove port from the CGI environment of variable SERVER_NAME2d
Thanks.dmitshur opened a change golang.org/x/build/internal/relui: display parameters, even if their type isn't string3d
Some parameters have a type other than string, so unmarshaling them into
a map with string value type would fail. Prefer to make such problems
visible by returning any non-nil errors from workflowPar…dmitshur commented on golang.org/x/build/cmd/relui: workflow parameters of slice types aren't visibly shown3d
Looked at this briefly. As expected, it was only a problem for non-string parameters, and it's because the current parameter display code assumes all parameters are strings, which isn't always the ca…dmitshur reviewed +2 on golang.org/x/build/cmd/relui: use new sqlc configuration format3d
(1 comment)
Maybe more identical as of PS 2. :)dmitshur commented on golang.org/x/build/cmd/relui: use new sqlc configuration format3d
(1 comment)
This method too likely needs to move to next CL in stack, where it's being added.dmitshur reviewed +2 on golang.org/x/build/internal/relui: add workflow details page and new list3d
Thanks. I left some inline comments, including some resolved ones because they're optional and very minor.
See comment on previous CL in stack; this diff will likely not stay present in this CL as a…dmitshur commented on golang.org/x/build/internal/relui: buildrelease_test fails with flake on uuid length3d
There were 7 occurrences (out of 127) attributed to this issue in [last week](https://github.com/golang/go/issues/52653#issuecomment-1205909358)'s flaky test triage:
- [2022-08-02T02:32:00-4b12e2b…dmitshur closed an issue golang.org/x/build/cmd/gomote: notify gomote users of upcoming change to authentication3d
dmitshur reviewed +2 on golang.org/x/website/_content/doc/devel: call out "security" in relevant release notes3d
Thanks for improving the accuracy of these historical release entries. They predate the recent practice of distinguishing security from bug fixes, but it's nice to backfill that information.
See min…dmitshur reviewed +2 on test: skip -buildmode=pie tests on alpine3d
(1 comment)
Note that this can also be written as 'go.dev' which is slightly shorter. Both work.dmitshur reviewed +2 on golang.org/x/build/internal/relui/protos: add protos to relui4d
Thanks. I think this is a great starting point. I left some thoughts as inline comment, and don't really have suggestions other than to proceed and adjust further once we're implementing the server a…dmitshur reviewed +2 on golang.org/x/build/env/linux-x86-alpine: update to Alpine 3.164d
Thanks.
And if you're changing this file anyway, you can also fix the LABEL syntax here with s/ /=/.
If you'd like, these can be deleted now that Go 1.19 is used.dmitshur reviewed +2 on runtime/cgo: add -fno-stack-protector to CFLAGS4d
dmitshur commented on strings: avoid utf.RuneError mangling in Split4d
(1 comment)
SGTM. Thanks for considering this.dmitshur commented on syscall: rename close to closeFD4d
(1 comment)
I see, thanks.dmitshur reviewed +2 on cmd: vendor github.com/google/pprof to fix mangled type parameter symbol names4d
(1 comment)
Thanks.dmitshur commented on security: fix CVE-2022-27664 [1.18 backport]4d
Since this is in Go1.18.6 milestone, added a "[1.18 backport]" suffix to the title and CherryPickCandidate label so this doesn't get missed during backport review, but I expect it to get approved as …dmitshur commented on cmd/pprof: graphviz node names are funny with generics4d
I'll move this issue to Go 1.20 milestone since the fix will need to land on master branch first. To address this issue for minor releases, we'd need to use the https://go.dev/wiki/MinorReleases proc…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle4d
CLs 421334 and 421461 took care of all the golang.org/x dependencies, and [CL 420234](https://go.dev/cl/420234) will update pprof.
Once that's done, we can remove the early-in-cycle label and revisi…dmitshur commented on cmd/compile/internal/test: TestAppendOfMake fails on linux-amd64-unified4d
Removing Soon label since [CL 422037](https://go.dev/cl/422037) added a " && !goexperiment.unified" build constraint, so the builder doesn't fail now. Thanks.dmitshur commented on cmd: vendor github.com/google/pprof to fix mangled type parameter symbol names4d
TRY=longtest
Filed #54337 for it, as it doesn't seem related to this change.
I'll restart TryBots to run a longtest SlowBot.dmitshur opened an issue cmd/compile/internal/test: TestAppendOfMake fails on linux-amd64-unified4d
Observed in trybots of CL 420234:
```
--- FAIL: TestAppendOfMake (0.00s)
issue53888_test.go:29: got 1.000000 allocs, want 0
issue53888_test.go:41: got 1.000000 allocs, want 0
FAIL
FAI…dmitshur reviewed +2 on cmd: vendor github.com/google/pprof to fix mangled type parameter symbol names4d
Thanks, see one inline comment about the vendor/modules.txt content, otherwise LGTM.
When I run:
go get github.com/google/pprof@upgrade
go mod tidy
go mod vendor
using the go command a…dmitshur reviewed +1 on golang.org/x/build/env/linux-ppc64le/osuosl: increase cpu/container4d
Thanks, looks okay from my side, leaving +2 to Lynn.
(If this change to the ratio of cores to available memory leads to problems, we can undo it, but it seems fine to try.)dmitshur commented on all: add freebsd/riscv64 port4d
CC @golang/release.dmitshur commented on crypto/tls: delete unnecessary line of return4d
Thanks.dmitshur closed an issue all: reopen tree for Go 1.20 development4d
dmitshur commented on all: reopen tree for Go 1.20 development4d
We're ready to complete the tree reopening. Updated the tree status heading to "Open for Go 1.20 development". Happy development!Last Week
dmitshur pushed to
master in github.com/go-gl/glfw6d
dmitshur closed an issue github.com/go-gl/glfw/v3.3/glfw: warning: 'GLAPIENTRY' macro redefined6d
dmitshur merged a change github.com/go-gl/glfw/v3.3: Update glfw to v3.3.86d
dmitshur reviewed +2 on github.com/go-gl/glfw/v3.3: Update glfw to v3.3.86d
Thanks.dmitshur reviewed +2 on fmt: add a function to recover the original format string given a State1w
dmitshur closed an issue golang.org/x/build: various timeouts on dragonfly-amd64 builder1w
dmitshur commented on golang.org/x/build: various timeouts on dragonfly-amd64 builder1w
I think this is fixed by [CL 419084](https://go.dev/cl/419084); this builder was recently replaced with another.dmitshur commented on golang.org/x/tools/internal/lsp: TestLSP/GOPATH failure with "race detected during execution of test"1w
Thanks and sorry I missed it. I changed the prefix in the title of [#54214](https://github.com/golang/go/issues/54214#event-7136329449) to follow the usual [convention](https://github.com/golang/tool…dmitshur commented on debug/pe: add IMAGE_FILE_MACHINE_RISCV641w
(1 comment)
This file was for new-to-Go1.19 APIs and is now frozen. Since this CL is for 1.20, its API additions should go in api/next. See api/README for information.dmitshur commented on debug/pe: add IMAGE_FILE_MACHINE_RISCV641w
(1 comment)
Compare with CL 421394.dmitshur commented on all: update vendored golang.org/x/{net,tools} for Go 1.20 development1w
TRY=longtest, linux-386-longtest, windows-amd64-longtestdmitshur commented on golang.org/x/net/lif: as long as std imports these packages, they can't import golang.org/x/sys/unix because of standard library policy1w
Thanks Ian for finding a resolution to this issue that's better than reverting those earlier x/net CLs. I'm glad I left x/net out of CL 421334 to create an opportunity to take time to think about thi…dmitshur opened a change all: update vendored golang.org/x/{net,tools} for Go 1.20 development1w
CL 421334 updated most of golang.org/x dependencies at the start of
the Go 1.20 development cycle. This CL updates x/net and x/tools as
well, now that go.dev/issue/54259 is resolved.
For #36905.
Upd…dmitshur reviewed +2 on golang.org/x/net/route: import syscall rather than golang.org/x/sys/unix1w
That is quite fortunate as there's no need to fully revert those simplification CLs now!
Thanks.dmitshur opened a change cmd/compile: [release-branch.go1.18] fix boolean comparison on RISCV641w
Following CL 421457, for RISCV64.
May fix RISCV64 builds.
Updates #52788.
Updates #53397.dmitshur opened a change cmd/compile: [release-branch.go1.18] fix If lowering on ARM641w
On ARM64, an If block is lowered to (NZ cond yes no). This is
incorrect because cond is a boolean value and therefore only the
last byte is meaningful (same as AMD64, see ARM64Ops.go). But here
we ar…dmitshur commented on golang.org/x/tools/go/ssa: panic: T1w
CC @timothy-king, @findleyr.dmitshur commented on : build dashboard triage log1w
`greplogs --triage --since=2022-07-27`
- #54276
- [x] [2022-08-02T18:52:36-0d04f65-4345620/freebsd-amd64-race](https://build.golang.org/log/927c2103551010f213d6fbd0e8afa80897bca0bb)
- #53037
…dmitshur opened an issue golang.org/x/build: instances of all internet-facing tests failing1w
What happened here? All the internet-facing tests failed with errors.
```
[...]
2022/07/28 00:33:59 syncing segment 136 did not succeed on attempt 3, will try again in 9s: https://maintner.golan…dmitshur opened an issue cmd/go: TestScript timeout on dragonfly-amd641w
```
--- FAIL: TestScript (0.02s)
--- FAIL: TestScript/mod_all (8.94s)
[...]
rflags 0x202
cs 0x2b
fs 0x23
gs 0x23
[c…dmitshur closed an issue syscall: TestSetuidEtc failure1w
dmitshur commented on syscall: TestSetuidEtc failure1w
Duplicate of #19938.dmitshur commented on golang.org/x/tools/cmd/fiximports: frequent TestDryRun and TestFixImportrs timeouts on plan9-arm since 2021-11-121w
Also an occurrence on dragonfly/amd64:
[2022-08-02T14:13:40-310ea71-f2a9f3e/dragonfly-amd64](https://build.golang.org/log/c9ccaf3eae394f16eb3e6dec27d90f169db0f332)dmitshur opened an issue golang.org/x/tools/gopls/internal/regtest/misc: TestSimultaneousEdits failure with "error(s) cleaning sandbox", unlinkat directory not empty1w
```
[...]
1 @ 0x1068299 0x107d1a8 0x107a24b 0x10ab2b7 0x1160c8b 0x1160c7d 0x12a47e6 0x106be41
# 0x1068298 syscall.syscall6+0x98 /Users/gopher/workdir/go/src/runtime/sys_darwin.go:44
# 0x10…dmitshur opened an issue golang.org/x/tools/internal/lsp: TestLSP/GOPATH failure with "race detected during execution of test"1w
```
2022/08/02 19:20:54 New session
create_session=1
2022/08/02 19:20:56 go/packages.Load #1
[...]
==================
WARNING: DATA RACE
Read at 0x00c0086205a0 by goroutine 34461:
golang.o…dmitshur opened an issue golang.org/x/build: linux-amd64-wsl builder runs into "unexpected EOF" errors downloading dependencies1w
From https://build.golang.org/log/1d606b9af9022065aa9b7b4dd76799415ae5fd0b:
```
[...]
go: downloading github.com/gobwas/pool v0.2.1
go: downloading golang.org/x/text v0.3.6
go: downloading git…dmitshur opened an issue syscall: TestSetuidEtc failure1w
```
--- FAIL: TestSetuidEtc (0.01s)
syscall_linux_test.go:565: [6] "Setgroups([]int{0,1,2,3})" comparison: "/proc/85360/status" got:"Groups:\t0 1 2 3 4 6 10 11 20 26 27" want:"Groups:\t0 1 2 3"…dmitshur opened an issue golang.org/x/net/nettest: TestTestConn/UnixPipe failures on darwin/amd641w
```
--- FAIL: TestTestConn (0.53s)
--- FAIL: TestTestConn/UnixPipe (0.13s)
--- FAIL: TestTestConn/UnixPipe/BasicIO (0.00s)
conntest.go:32: unable to make pipe: listen unix…dmitshur opened an issue golang.org/x/tools/gopls/internal/regtest/misc: TestFailingDiagnosticClearingOnEdit failures with "context deadline exceeded"1w
There are instances of the `TestFailingDiagnosticClearingOnEdit` test failing with "context deadline exceeded":
```
--- FAIL: TestFailingDiagnosticClearingOnEdit (560.80s)
--- FAIL: TestFai…dmitshur commented on cmd/go: go.work: `go build` requires versioned replace directive when replacing a used module with a local path1w
CC @bcmills, @matloob.dmitshur opened a change golang.org/x/build/dashboard: set HostArch for host-solaris-oracle-amd64-oraclerel1w
Without an explicit HostArch set, this host name leads to "oracle"
being inferred as the GOARCH value, while in reality it is "amd64".
For golang/go#44505.dmitshur reviewed +2 on golang.org/x/net/lif: import syscall rather than golang.org/x/sys/unix1w
Thanks.dmitshur opened an issue cmd/api: API check failing with "go tool api: signal: killed", "exit status 1" on linux-ppc64le-buildlet, linux-ppc64le-power9osu1w
As of [CL 420902](https://go.dev/cl/420902) ("cmd/dist: require Go 1.17 for building Go" for #44505), API check fails on these two builders with:
```
##### API check
Error running API checker: e…dmitshur commented on all: reopen tree for Go 1.20 development1w
Everything that was planned is in, I've updated the tree status heading to say that bug fixes and stability improvement CLs are okay to land, and the tree can be fully opened on Monday.dmitshur commented on cmd/go: `go list -json -m` does not provide `Replace.Path` relative to current directory when using workspaces1w
CC @bcmills, @matloob.dmitshur commented on cmd/compile: self-contradictory error message when separating the definition and implementation of an interface with anonymous structs in a method signature1w
CC @golang/compiler.