Activity
Yesterday
dmitshur opened a change golang.org/x/build/...: use 'an error satisfying errors.Is/As(err, target)' phrasing17h
Based on https://pkg.go.dev/os/exec#LookPath.
This way it should be more precise and clear.Last Week
dmitshur commented on golang.org/x/vulndb/go.mod: make go1.26.2 toolchain requirement explicit1d
Thanks.
In contrast to issue #74739, godebug directives can only be maintained by the low-level go mod edit commands, not something higher level like go get, and we don't want the low-level go mod e…dmitshur opened an issue cmd/go: go mod tidy can automatically maintain toolchain directive when godebug default requires a higher toolchain1d
This is a minor friction report and a suggested feature request to address it, similar to #74739, except it's about the `godebug` directive and its default key.
Consider a module with a `go 1.25.0` …dmitshur reviewed +2 on std: go fix -slicesbackward=false ./...1d
Ok, I got through everything and left inline comments.
A few high level observations are that perhaps `go fix` shouldn't try to work on packages that are marked as deprecated, or within symbols that…dmitshur closed an issue build: build failure on gotip-linux-loong641d
dmitshur commented on golang.org/x/build/cmd/gomote: failure when creating gotip-windows-amd64 gomote1d
This issue seems to be affecting windows/386 and windows/amd64 builders, not only gomote. It's pretty visible on the post-submit dashboard and started recently:
<img width="104" height="1147" alt="I…dmitshur opened a change golang.org/x/review/git-codereview: add -ready flag1d
Sometimes a WIP CL becomes ready for review, and it's convenient to be
able to use git-codereview to mark it as ready for review while also
possibly starting trybots and adding reviewers, without nee…dmitshur commented on std: go fix -slicesbackward=false ./...1d
(1 comment)
To clarify, I think the follow up simplifications are fine to defer. I only mentioned them because I think splitting into multiple CLs would make it easier to pursue them in follow up CL…dmitshur commented on std: go fix -slicesbackward=false ./...1d
(1 comment)
Oh, I saw from failing patch set 1 tests that it was causing some test to fail. Still, might help to note it down for future code readers.dmitshur commented on std: go fix -slicesbackward=false ./...1d
Thanks for doing this.
I'm still reviewing it, leaving some early comments.
I was able to reproduce this diff with `go fix -slicesbackward=false`, other than the `var a3 [3]int` line in encoding/go…dmitshur opened an issue cmd/api: api check's false positive when "Deprecated:" text comes up in the middle of a paragraph instead of at the beginning1d
api check implements its own [logic](https://cs.opensource.google/go/go/+/master:src/cmd/api/main_test.go;l=1155-1163;drc=87fe5fafbacac634646e8177c9df07a6805cf2d0) to detect whether an exported API s…dmitshur commented on go/importer: ForCompiler is mistakenly deprecated1d
@prattmic pointed out a deviation in deprecation comment detection between cmd/api check and pkgsite. As is, api check considers the go/importer.ForCompiler function as deprecated, but pkgsite [does …dmitshur commented on golang.org/x/build/cmd/relui: compute security content summary from security-metadata1d
Thanks.dmitshur commented on golang.org/x/mod/zip: include 'but content has correct sum' note in TestVCS1d
Thanks.dmitshur commented on golang.org/x/mod/zip: update zip hashes for new flate compression1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: correct typos in comments and identifiers1d
Thanks.dmitshur closed a change golang.org/x/mod/modfile: fix AddNewRequire block ordering2d
Issue #69050 is closed as working as intended, so it seems this CL isn't needed. Closing. Thanks.dmitshur closed an issue build: build failure on gotip-linux-amd64-sizespecializedmalloc2d
dmitshur closed an issue build: build failure on gotip-linux-386-softfloat2d
dmitshur closed an issue build: build failure on gotip-linux-loong642d
dmitshur closed an issue build: build failure on gotip-linux-amd64-longtest-git2.24.02d
dmitshur closed an issue build: build failure on gotip-darwin-arm64_152d
dmitshur closed an issue build: build failure on gotip-darwin-arm64_262d
dmitshur closed an issue build: build failure on go1.26-darwin-arm64_152d
dmitshur closed an issue build: build failure on go1.25-linux-loong642d
dmitshur opened a change golang.org/x/mod/zip: update zip hashes for new flate compression2d
This is like CL 767543, but for a similar test in x/mod/zip.
It's a bit more involved because golang.org/x/mod/zip needs to support
Go 1.26 and 1.25, too. Use the //go:build-constraint syntax to enc…dmitshur reviewed +2 on cmd/go/internal/vcs: stop making network connections in test2d
Thanks.
It seems this comment ends abruptly.
I understand `ts.Listener.Addr().String()` is used here because `ts.URL` doesn't quite apply here; you want to leave out its "http://" prefix and only i…dmitshur opened a change golang.org/x/vulndb/go.mod: make go1.26.2 toolchain requirement explicit2d
The inclusion of 'godebug default=go1.26.2' in go.mod lets this module
keep using GODEBUG default settings from Go 1.26.2, as it did prior to
CL 771620 being submitted. It also means that while insid…dmitshur opened a change golang.org/x/build/cmd/relui: compute security content summary from security-metadata2d
Use a fairly simple template, similar to the one we used during last
month's Go release. (If we want more creative control over these, it
could be a new field added to security metadata.)
Being shor…dmitshur commented on golang.org/x/review/git-codereview: add -private flag to mail command2d
The Go project doesn't use private CLs. (When something like that is needed, e.g., for developing private-track security fixes, we use a separate Gerrit host that's configured to be private at the ho…dmitshur commented on golang.org/x/review/git-codereview: isolate tests from user's global git config2d
Thanks.
Since they're environment variables rather than flags, older git versions will ignore them meaning the older git versions won't benefit from the improved test isolation, but that's fine. Go …dmitshur opened a change golang.org/x/build/devapp/owners: add primary owners for x/review2d
dmitshur commented on golang.org/x/build/cmd/relui: add metadata-based security comm fetching for minor releases3d
Thanks.dmitshur commented on golang.org/x/build/cmd/relui: add metadata-based security comm fetching for minor releases3d
(1 comment)
No, unfortunately the term "milestone" ends up being ambiguous.
Maybe a reasonable way to describe this (without going too much into internals) is to say this is the "security-metadata …dmitshur opened a change golang.org/x/build/cmd/relui: add metadata-based security comm fetching for minor releases3d
Start with the "two minor releases" relui workflow, the most common one.
For now, the secuity comms are fetched at the start of the workflow,
which is very similar to what happened when these were m…dmitshur opened an issue golang.org/x/build/cmd/relui: automate security comms inputs using security metadata3d
The security metadata (issue #76157) includes prepared security comms. This issue tracks using that instead of manually entering them at the start of the relui workflow (one release note entry per se…dmitshur reviewed +2 on cmd/compile: disable constant string size check3d
Thanks.
Since issue #78346 will be reopened, maybe include `TODO(go.dev/issue/78346)` here so it's a bit easier to get to the tracking issue. (It can probably be found via git blame -> commit messag…dmitshur commented on runtime:gccheckmark: TestNotInGoMetric/CgoCallAndCallback failures3d
This was closed in favor of the still-open #78877.dmitshur commented on crypto/fips140: add package docs3d
The only two failed tests are tracked in issues #68440 and #68777, not related to this change. Everything else passed, so adding bypass.dmitshur reviewed +2 on golang.org/x/build/internal/task: use relmeta definitions3d
dmitshur reviewed +2 on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions3d
(1 comment)
Given it can be kept opaque, that seems like a good direction to go with. I see you've updated testdata for the new `ID` field name in CL 771601.dmitshur reviewed +2 on golang.org/x/build/internal/task: use relmeta definitions4d
Thanks.
Since there's now a named constant, consider using it here:
```suggestion
if patch.Track == relmeta.Public {
```dmitshur reviewed +2 on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions4d
Thanks. Two questions about fields that stood out to me, but I expect you're more familiar with what they're intended to be.
Is `ID` right here? I expect it might've intended to be BuganizerID / `bu…dmitshur commented on golang.org/x/build/go.mod: update various dependencies4d
Thanks.dmitshur commented on golang.org/x/vulndb/...: lower go directive to 1.25.04d
Thanks for checking.dmitshur commented on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions4d
(2 comments)
Filed issue #79001 for it.
These updates are reasonable but a slight preference to break them out into a separate CL, since it's pretty unrelated. Sent you CL 771740.dmitshur opened a change golang.org/x/build/go.mod: update various dependencies4d
golang.org/x/vulndb happens to use newer versions of some of the same
dependencies that golang.org/x/build has. Update to the same versions.
[git-generate]
go get golang.org/x/vulndb
go get go@1.25.…dmitshur commented on golang.org/x/vulndb/...: lower go directive to 1.25.04d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/task: make workflow explicitly pick up non-PUBLIC changes4d
Thanks.
This is a part of some work tracked in one of the already open issues, right? Please add a `For golang/go#nnn.` line here.dmitshur commented on golang.org/x/build/main.star: remove Go 1.25 builders for x/vulndb4d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/gophers: update Rob's Gerrit email4d
Thanks.dmitshur opened a change golang.org/x/build/main.star: remove Go 1.25 builders for x/vulndb4d
The Go 1.25 builders that test with GOTOOLCHAIN=local produce no useful
signal since the x/vulndb module had 1.26.0 become its minimum required
language version in CL 747200. Stop these builders for …dmitshur commented on golang.org/x/vulndb/...: lower go directive to 1.25.04d
Thanks. If that govulncheck test is the main reason this module ended up requiring as high of a language version as 1.26.2, it seems worthwhile to factor that out. Opened a tracking issue #79001 for …dmitshur opened an issue golang.org/x/vulndb: lower go directive to 1.25.0, update govulncheck test4d
The golang.org/x/vulndb module has some packages that we want to import from other golang.org/x modules, but that would propagate its current go directive 1.26.2, which is quite high. It'd be good to…dmitshur commented on golang.org/x/vulndb/...: update go version and dependencies4d
(1 comment)
Sent CL 771620 to make sure tests still pass with 1.26.2+/tip.dmitshur opened a change golang.org/x/vulndb/...: lower go directive to 1.25.04d
There's nothing in this module that requires 1.26.2 language semantics.
Lower its requirement to go 1.25.0 to make it possible for other modules
to depend on this module without in turn raising their…dmitshur commented on golang.org/x/vulndb/...: update go version and dependencies4d
(1 comment)
It seems this CL updates the Go toolchain version used during the build and deploy (in cmd/worker/Dockerfile and deploy/build.yaml), but also raises the minimum go language version for t…dmitshur commented on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions4d
(1 comment)
It's because a requirement on the golang.org/x/vulndb module is added, and that module requires 1.26.2:
https://cs.opensource.google/go/x/vulndb/+/master:go.mod;l=3;drc=5571712294b453fa…dmitshur commented on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions4d
(1 comment)
Is raising the x/build module minimum requirement from 1.25.0 to 1.26.2 intentional?dmitshur commented on all: fix a lot of spelling mistakes4d
(1 comment)
It seems both of these are considered valid alternative spellings of the same word, and we generally want to avoid changing spelling if it's not a fix or a clear improvement. But in this…dmitshur reviewed +2 on cmd/go: set a http user agent5d
Thanks. This seems okay and safe to me, but it would be good if you give some time before submitting so @matloob@golang.org has a chance to look and comment if there are concerns.
The rest of the te…dmitshur fixed an issue all: end support for macOS 12 in Go 1.275d
Those tasks are done now, closing again.dmitshur commented on all: end support for macOS 12 in Go 1.275d
Those tasks are done now, closing again.dmitshur commented on go.dev/wiki/MinimumRequirements: document that Go 1.27 requires macOS 135d
Thanks.Earlier
dmitshur starred honnef.co/go/stuff1w
dmitshur commented on cmd/go: set a unique user agent1w
That is a reasonable extension to consider. After all, the same reasoning can be applied to any VCS the go command invokes (git, hg, svn, and so on): having a go command-specific user agent helps wit…dmitshur commented on golang.org/x/build/cmd/gitmirror: stop serving-only instances1w
Thanks.dmitshur opened a change golang.org/x/build/cmd/gitmirror: stop serving-only instances1w
We continue to use gitmirror for its primary mirroring functionality,
but its secondary serving functionality has not been used in a while.
With LUCI builders, we're relying on having them fetch dire…dmitshur closed an issue golang.org/x/build/cmd/gopherbot: reply to commit comments saying we do not monitor them1w
dmitshur closed an issue golang.org/x/build/cmd/gopherbot: reply to commit comments saying we do not monitor them1w
dmitshur commented on golang.org/x/build/cmd/gopherbot: reply to commit comments saying we do not monitor them1w
Merging this into proposal #25450.dmitshur closed a change golang.org/x/build/commitcommentshook: politely respond to commit comments on golang/go1w
Thanks for working on this. Closing since issue #25450 is resolved.dmitshur fixed an issue github: lock conversations on GitHub commits1w
In 2026, GitHub added support to disable comments on individual commits via the UI:
https://github.blog/changelog/2026-03-25-disable-comments-on-individual-commits/
So we're able to accomplish this…dmitshur commented on github: lock conversations on GitHub commits1w
In 2026, GitHub added support to disable comments on individual commits via the UI:
https://github.blog/changelog/2026-03-25-disable-comments-on-individual-commits/
So we're able to accomplish this…dmitshur commented on cmd/go: set a http user agent1w
The vcweb/vctest package sets up an HTTP+HTTPS server for go command testing needs (e.g., [here](https://cs.opensource.google/go/go/+/go1.26.2:src/cmd/go/internal/vcweb/vcstest/vcstest.go;l=64) and […dmitshur commented on cmd/go: set a http user agent1w
This probably needs a test, right? Otherwise this change might accidentally regress during a refactor without any test catching it.
```suggestion
go.dev/issue/35699 was a declined proposal to add th…dmitshur commented on cmd/go: set a unique user agent1w
The default user agent in the net/http package also deliberately doesn't include the toolchain version. E.g., see comment [here](https://cs.opensource.google/go/go/+/master:src/net/http/request.go;l=…dmitshur closed an issue runtime:gccheckmark: TestNotInGoMetric/CgoCallAndCallback failures1w
dmitshur commented on runtime:gccheckmark: TestNotInGoMetric/CgoCallAndCallback failures1w
The :gccheckmark test variant may not be relevant to this failure, so merging into the top-level tracking issue for this test, issue #78877.dmitshur commented on net/http: new HTTP client package1w
CC @neild.dmitshur commented on runtime: setevent failed; errno=6, fatal error: runtime.semawakeup1w
Can you also try this at tip (1.27 to be) with its new GOEXPERIMENT= goleakprofile feature (see issue #75280)? Thanks.dmitshur commented on runtime: setevent failed; errno=6, fatal error: runtime.semawakeup1w
CC @golang/windows, @golang/runtime.dmitshur commented on runtime: make mutexActiveSpinSize configurable1w
CC @golang/runtime.dmitshur commented on runtime: `SIGSEGV` with a c-shared library and called from C#1w
CC @golang/runtime.dmitshur commented on cmd/go: when running 'go doc', GOPATH/src/<stdpkg> shadows stdlib when runtime.GOROOT() is empty1w
Thanks for the report. Would you like to send a CL? https://go.dev/doc/contributedmitshur commented on cmd/cgo/internal/testsanitizers: TestASAN/asan5_fail failures1w
CC @golang/compiler.dmitshur commented on cmd/cgo/internal/testsanitizers: TestASAN/asan5_fail failures1w
From issue triage, let's wait a bit to see if this happens more.dmitshur commented on runtime: map with 8 elements unnecessarily grows on existing key update1w
Thanks for filing an issue for this. If you have a fix in mind, would you like to send a CL? https://go.dev/doc/contribute.
CC @golang/runtime.dmitshur commented on cmd/go: go-import meta tag can redirect to insecure location1w
CC @golang/command-line.dmitshur commented on go.dev/wiki/PortingPolicy: make port-maintainers links more direct1w
Thanks.dmitshur reviewed +2 on go.dev/wiki: Add f4 editor with Go syntax highlighting support1w
Thanks.dmitshur reviewed +2 on go.dev/wiki/Range: wrap reference table to prevent Safari overflow1w
Thanks.dmitshur opened a change go.dev/wiki/MinimumRequirements: document that Go 1.27 requires macOS 131w
For golang/go#75836.dmitshur commented on crypto/tls: generate test certificates1w
(1 comment)
As written, this'll be willing to run any test whose name happens to contain the substring TestGenerateCertificates, but I think the intention is to run a single specific test (below). C…dmitshur commented on runtime: on 32bits arches timespec (64) definition is wrong1w
@Jorropo Can you please clarify why you requested this backport to Go 1.26 and not 1.25? Is this a regression from 1.25 or is there another reason? Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: update TestRelease to use supported Go versions1w
Thanks.
It matches what I found too, thanks.dmitshur commented on golang.org/x/build: add LUCI windows/arm64 builder1w
I see it connected at https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Awindows-arm64&f=pool%3Aluci.golang.shared-workers and it's started its first build at https://ci.chromium.org/b/8683…dmitshur commented on golang.org/x/build: add LUCI windows/arm64 builder1w
Here's the certificate for it: [windows-arm64-azure-qmuntal-1776787311.cert.txt](https://github.com/user-attachments/files/26939453/windows-arm64-azure-qmuntal-1776787311.cert.txt).dmitshur commented on golang.org/x/build: add LUCI windows/arm64 builder1w
Okay, thanks for checking. I've updated our internal config ([crrev.com/i/9223085](https://crrev.com/i/9223085)) to drop the "--01" suffix from the bot matching, can you try again now?
Either it sho…dmitshur commented on math/big: correct panic message caused by copy-paste1w
The absent commit message body and issue reference are okay in this case. Done.