Activity

Yesterday
Sounds good. I expect it'll be easiest for us to update release docs to have the release coordinator take care of it during the transition, but we'll know to explore other options if desired. Thanks.
Thanks. (style nit) s/dvlist/dvList/ perhaps per https://go.dev/s/style#mixed-caps. (Assuming 'dv' is an acronym for Download Version.) (minor) PS 2 added a skip to should for ".src." filenames. So…
Thanks. Something that I've found to work well when implementing the module proxy protocol is to avoid the temptation of making its URL appealing to humans, and rather make it more like an API URL. …
This Week
dmitshur starred honnef.co/go/gotraceui1d
(1 comment) I'm not sure whether it matters by now, but at least some time ago we sorta tried to intentionally migrate away using the term "subrepos", because it was a Mercurial-specific term and ma…
Thanks. Typo, d↔i. What do you think about using its shortlink, https://go.dev/s/release (I know it means an extra redirect)? Similarly here, https://go.dev/wiki. Just a minor side idea: if loo…
This should be fixed by CL 480655. Restarting. (nit) Note that this "c/go/+/" part can be deleted to make the URL shorter while still having it point to the same CL.
This change is certainly safe and okay to do. Thanks. Usually when a port is being added, it doesn't need to be added to broken port list because it's only added to 'cgoEnabled' (and in turn shows u…
This was implemented earlier, and exercised for the first time today! 🎉 https://groups.google.com/g/golang-announce/c/71Wg3N0IZk0 @rolandshoemaker Okay to close this issue or was there somet…
See also [`internal/diff`](https://pkg.go.dev/internal/diff), an internal "anchored diff" implementation in the main repo. (Adding a mention here for completeness.) Edit: I see this is already men…
(1 comment) I think the only effect of the 'export GOROOT' line is to make the value of GOROOT set by the previous line ('eval $(../bin/go tool dist env)') visible to child processes, rather than ju…
Thanks. See previous comment, otherwise not spotting problems, and anyway that might be easier after we see this on the dashboard.
(1 comment) This isn't a subrepo, is the change here intentional too?
Thanks. (Good catch in PS 3.)
(1 comment) I'll probably want to confirm even harder, but off the top of my head, I think it would be unsetting it if there was a '=' after the env var name. Without the '=', it's exporting the cur…
TRY=longtest, windows
The comment justifies exporting GOROOT by saying the api test needs it, which was relevant back when it was added in CL 99870043, but isn't true by now. As of Go 1.8, GOPATH can be unset (https://go…
PS 2 also looks good, thanks. See note about x/build version. Since PS 2 starts to use version.ParseTag, you'll want to update x/build to include CL 479556 when it lands (unfortunately not yet, but …
Thanks. s/man/maj/
Thanks for reporting. It might be because [CL 467955](https://go.dev/cl/467955) (CC @petergeorgas) removed the `-prev` flag, which is still used, and https://goprevplay.golang.org/version ends up …
(1 comment) I considered that field. An example I found looked like this: ``` test_presentation = resultdb.test_presentation( column_keys = ["v.gpu"], grouping_keys = ["status", "v.test_sui…
We want to enable the "Test Results" tab our build pages and display test results in a structured manner there.
Last Week
dmitshur closed a change golang.org/x/oauth2/...: fix typo1w
dmitshur commented on golang.org/x/oauth2/...: fix typo1w
Submitted via [CL 459695](https://go.dev/cl/459695) (commit 86850e07236e6a4f59e810fb16229fdebb07a119).
dmitshur commented on cmd/dist: add json output support1w
I used CL 478155 to get a representative (not fully complete) all.bash run with `go test -json` output, and converted it to HTML to more easily visualize the data. I intentionally added 2 failing tes…
### What version of Go are you using (`go version`)? <pre> $ go version go version devel go1.21-ac881545ce Tue Mar 21 12:44:04 2023 -0400 darwin/arm64 </pre> ### Does this issue reproduce wi…
Thanks for suggesting and implementing this, and sorry I didn't get a chance to comment sooner. I've had the idea of doing something like this for some time and I've seen it successfully used in http…
dmitshur commented on github: branch protections1w
We can do all golang.org/x GitHub mirrors too (and the special case without x, golang.org/dl). At least I can't think of a downside to treating them the same as the main Go repo mirror for the purpos…
dmitshur starred github.com/daafu/sokoban1w
Earlier
Fixed by [CL 469975](https://go.dev/cl/469975). (CC @jamalc.)
It does seem likely that there was some incompatibility in your local build environment setup. If the problem doesn't reproduce with a functional latest version of Xcode, I don't think there's anythi…
Issue #115 is related.
dmitshur pushed to master in github.com/shurcooL/githubv43w
efb623903184656cfeaaf308f6cdc3f74aaa49eeregenerate for schema changes by 2023-03-05
Looking at https://build.golang.org/?repo=golang.org%2fx%2ftools, the linux-amd64-perf builder column has some "ok" rows but most are empty. At https://farmer.golang.org/#completed right now there…
Another case affected PR #58779. It was submitted on Gerrit 5 days ago and the PR wasn't marked as closed. It once again got stuck on `Changes for PR golang/go#58779 have yet to be mirrored in the…
Closing because this PR has been merged via [CL 471915](https://go.dev/cl/471915) as commit dfe4591fc4d2d66da7740de18b32761e7a20691c. (Normally `gerritbot` does this, but sometimes it needs help d…
Starting with [CL 462035](https://go.dev/cl/462035) (CC @randall77), the aix-ppc64 builder is failing during bootstrap: ``` Building Go cmd/dist using /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go…
Pinging issues with "early-in-cycle" is a task that we do once every 6 months, after the development of a new major Go version starts. Right now it's implemented as a task in `gopherbot` that needs t…
dmitshur closed an issue access: gerrit approvers4w
dmitshur commented on access: gerrit approvers4w
Hello, Thanks for your contributions and making this access request. The "approvers" access permits reviewing and submitting CLs across the entire Go project as documented https://go.dev/wiki/Gerr…
dmitshur closed a change golang.org/x/tour: Update basics.article4w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
dmitshur closed a change golang.org/x/tour: Clarify founding date4w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…
[CL 467297](https://go.dev/cl/467297) and a few others took care of this for early in cycle. Removing that label to revisit this at the start of freeze.
CC @bcmills, @matloob.
CC @mpvl, @golang/runtime.
CC @golang/security.
Thanks watchflakes, but commit 600d37 is before the fix in commit [21e451e](https://go.googlesource.com/go/+/21e451ec446724c9f3f124139e07d88ff812a1bc).
CC @ianlancetaylor, @eliben.
CC @golang/compiler.
At some point between filing this proposal and now, I've realized that the "v" part in a string like "v1.2.3" is not a part of SemVer 2.0.0. See https://semver.org/spec/v2.0.0.html#is-v123-a-semantic…
Confirmed that the problem reproduces on an updated Windows 11 device, and the patch fixes it.
This test is not failing on Windows builders on release-branch.go1.19. Either there's no problem (i.e., TestSystemVerify was modified in a way that needed the fix only in Go 1.20) or perhaps it's bec…
As of [CL 472295](https://go.dev/cl/472295) (which fixed #58791), `TestSystemVerify` is failing on darwin-amd64-10_15 (only) with: ``` --- FAIL: TestIssue51759 (0.32s) --- FAIL: TestIssue517…
@mdempsky Please add a short backport rationale to this backport issue (see https://go.dev/wiki/MinorReleases; "The issue should include a link to the original issue and a short rationale about why t…
@gopherbot Please backport at minimum the Windows text fix aspect of this issue. This is needed to fix failing tests on release branches.
No backport needed for Go 1.19 because this issue isn't present in that version.
This was observed again on 2023-02-28 19:38: ``` GitHub Activity Service: ok Gerrit Activity Service: walkSegMail(gerrit.fileSeg{file:"/2023-03.reclog", skip:0, size:4096}): truncated record at …
CC @golang/security.
Thanks for reporting. We're using Xcode tooling to create a fairly standard macOS installer (see [here](https://cs.opensource.google/go/x/build/+/master:internal/task/buildrelease.go;l=298;drc=f03…
CC @golang/security.
CC @dsnet, @bradfitz, @mvdan.
dmitshur commented on hash/crc32: data leaks to heap1mo
CC @golang/security.
CC @neild, @ianlancetaylor.
Currently at https://farmer.golang.org/#pools: ``` host-darwin-amd64-10_15-aws: 0/0 (2 missing) ``` And there are no builds on the last 30 commits in the main Go repo. Although the most recen…
Thanks for catching and reporting this. CC @golang/security.
The problem seems to be that `testGo` is only set when `testenv.HasGoBuild()` reports positively, but when GOOS=android it returns false. The test currently doesn't check `testenv.HasGoBuild()` nor `…
CC @ianlancetaylor, @cherrymui.
CC @golang/compiler, @ianlancetaylor.
CC @golang/compiler, @ianlancetaylor.
CC @matloob, @golang/tools-team.
[CL 468636](https://go.dev/cl/468636) (CC @bcmils) recently improved TestDocsUpToDate to invoke `go help documentation` directly, without the mkalldocs.sh script, but it's not able to run at least in…
These are two different modules. Module `github.com/go-gl/glfw/v3.3/glfw` contains v3.3. Module `github.com/go-gl/glfw` contains older versions: v3.0, v3.1, and v3.2.
2fa documentation states: > The keychain is stored unencrypted in the text file `$HOME/.2fa`.
At least some code that parses Go versions and/or tags may have code that explicitly handles ".0" as a special case, and that would to change (for example, see [here](https://cs.opensource.google/go/…
dmitshur deleted branch in github.com/gopherjs/snippet-store1mo
master