Activity

Yesterday
dmitshur starred github.com/roblillack/spot16h
@kolyshkin You can find documentation for our backporting process at https://go.dev/wiki/MinorReleases. If you believe this issue meets the criteria to be considered for backporting, you should ask @…
Prior to CL 561115, calling a function without any return values would print "function called with 0 args; should be 1 or 2". Afterwards, the error message became "too many return values". Keep the …
@cherrymui With [CL 587195](https://go.dev/cl/587195) submitted now, do you expect we might want to do another update before RC 1? When we're confident there's nothing more to do for Go 1.23 mileston…
(1 comment) CL 588195 does that the topic → hashtag move. Let's consider this done?
The release freeze for Go 1.23 has started, so now is a good time to regenerate this list. Done with 'go generate'. The list is the same as for Go 1.22 with the addition of the new openbsd/riscv64 p…
Note that #36905 tracks re-vendoring all dependencies in the main Go repo, which will happen soon now that we're in the freeze. This issue can be kept open after that happens if there are more x/tele…
Thanks for documenting this. Note that I separated this out because I understand that proposal #58894 is separate from what's being documented here. Feel free to correct that if needed.
SGTM, thanks.
(1 comment) Turns out out this breaks if run outside of x/website directory because it tries to find _content even if doesn't exist. Setting the -content flag to empty string explicitly gets it to u…
Smaller edits are usually fine to do without previewing, since Markdown can be intuitive. But for larger changes including re-ordering sections and such, it can be helpful to quickly see the end resu…
Add this file now so we can use the https://tip.golang.org/doc/go1.23 both before and after the release note fragments are merged, meaning we won't need to tell people to abruptly stop looking at /do…
The implementation CL is also waiting on the proposal to be accepted, and it has a Hold+1 vote. The wait-issue tag helps make it easier to see what the CL is waiting for, so we can add it to that CL …
Issue #65286 is a proposal that hasn't been accepted yet. I understand this CL is currently waiting on that proposal to be accepted.
This Week
The 'wait-release' hashtag has meaning for humans and release tooling. The 'wait-release' topic can be easy to accidentally apply instead of the hashtag. Add a task to correct such mistakes automatic…
@prattmic We will update it soon, now that we've entered the release freeze, as part of #36905. It's also fine to update it separately for this as needed.
dmitshur closed an issue crypto/tls: make 3DES opt-in1d
[CL 587295](https://go.dev/cl/587295) implemented this, documented the GODEBUG setting and added a release note.
This change is ready for review.
See https://go.dev/wiki/MinorReleases. We try to backport as little as possible during minor releases, only critical problems, security fixes and important documentation fixes. This is a new API that…
Thanks. Like for bug fix CLs, test-only CLs will also need to exercise judgement. E.g., there shouldn't be large and possibly risky test-only CL landing later on, e.g., when we're very close to issu…
In addition to the watchflakes reports, the [test history view](https://ci.chromium.org/ui/test/golang/cmd%2Fcompile%2Finternal%2Ftypes2.TestStdlib?q=V%3Abuilder%3Dgotip-linux-arm64-longtest-test_onl…
If I understand correctly, the accepted proposal is to add four new fields to http2.Transport as described in https://github.com/golang/go/issues/57893#issuecomment-1406834509. I updated the title ac…
dmitshur commented on runtime: deprecate func GOROOT2d
A fix CL is available but hasn't been reviewed before Go 1.23 freeze. Moving to the next milestone.
Reopening since [CL 529816](https://go.dev/cl/529816) was rolled back in [CL 571695](https://go.dev/cl/571695), and a roll forward hasn't been submitted.
Thanks. Note: A strategy I've seen used sometimes is to always name executable binaries with a ".exe" suffix, even on non-Windows OSes. It has no effect there. End result is slightly fewer special c…
Thanks.
(1 comment) Added. Also reworded slightly to say "the command", similarly to how it's done in the previous paragraph.
Merged as [CL 587717](https://go.dev/cl/587717) (commit fd1363240ac22583125d43d8e15f130f02a7659b).
dmitshur reviewed +1 on crypto/tls: add ech client support2d
(1 comment) (nit) Is it useful to keep the no-op `true && `?
(1 comment) I considered including that but it seemed like a detail that someone interested in using the flag could look up from the cmd/go documentation. This release note was intended to call atte…
dmitshur commented on cmd/go: add go mod tidy -diff2d
A new flag likely needs a release note. Sent CL 587695.
Add a release note for the flag that CL 585401 added. For #27005. For #65614.
Thanks.
dmitshur commented on crypto/tls: disable 3-DES by default2d
(1 comment) @filippo@golang.org FYI this needs a trivial rebase to resolve conflict with CL 584117. (Sorry!)
dmitshur commented on crypto/tls: disable 3-DES by default2d
Sounds good. Thanks.
By now the supported and tested Go versions are Go 1.22 and 1.21. Update the website deployment to start using the Go 1.22 runtime. See https://cloud.google.com/appengine/docs/standard/lifecycle/supp…
Whoops, I triggered trybots a bit too quick, before CL 587415 finished being auto-submitted. Restarting.
Thanks.
pprof test failure looks like #67563. Not this CL.
Pull in latest changes to x/build/relnote. Its functionality will be used for the go.dev/doc/next page. For golang/go#64169.
Go release notes always start out as a draft with a clear notice. That notice is removed when the final release (go1.N.0) is made. For example, the last time was in CL 562255. Add this to the Go 1.2…
Thanks. Please undo the change on this line. To work as a link, it would need to be written as `structs.HostLayout`, but in this context just `HostLayout` is a better fit.
Thanks.
(1 comment) I'm still not sure what a `*BannerError` with a nil `Err` field would represent and whether it makes sense to try to support it. But it seems reasonable for the `Error` method not to pan…
(1 comment) Would it be better if the Err field had a comment stating it's expected to have a non-nil value? ```suggestion Err error // non-nil ``` As is, the documentation doesn't really say…
This is #67502, unrelated to changes in this CL. Bypassing since everything else passed.
(1 comment) Thanks. I would still suggest including the 'Cq-Include-Trybots' footer in the commit message since it eliminates the possibility of the CL being submitted without a positive signal from…
dmitshur commented on crypto/tls: add ech client support4d
(1 comment) Git considers only the lines in the last paragraph as trailers, so this blank line causes the Cq-Include-Trybots: line to appear in the second-last paragraph and therefore be a no-op. Se…
@Jacalz and I discussed https://github.com/go-gl/glfw/issues/188#issuecomment-1982945940 offline; I believe we agreed it's not something we can pursue in a way that works with the [Go module](https:/…
dmitshur commented on github.com/go-gl/glfw: GLFW v3.44d
Thanks for getting it this far. I've been using this locally on macOS and haven't spotted any more issues on this platform and in my usage. --- > Forgot to mention, @dmitshur can you test with …
dmitshur reviewed +2 on doc: simplify links for release notes4d
Thanks.
Thanks. I'll David look since he's more familiar with this, but to me it seems fine to submit since this change is only affecting a port that you maintain and https://storage.googleapis.com/go-build-…
Noting here that the maintner service's [`ListGoReleases`](https://pkg.go.dev/golang.org/x/build/maintner/maintnerd/apipb#MaintnerServiceClient.ListGoReleases) API call might be useful for this. <…
Yes, for that please file a new issue as described at https://go.dev/wiki/GerritAccess#requesting-access. Thanks.
secret.InitFlagSupport doesn't always succeed. Handle things when it returns a non-nil error. Also apply gofmt.
This issue tracks turning this on in the coordinator codebase (see [here](https://cs.opensource.google/go/x/build/+/master:dashboard/builders.go;l=1484-1486;drc=4ee487b137da815f5e68acb20a18dc0e6f9693…
dmitshur reviewed +2 on doc: simplify links for release notes5d
Thanks. Thanks for checking this.
The plan/386 port doesn't bootstrap at this time. Remove it from the current misc-compile trybot set to get them passing while the Plan 9 issue is being investigated and fixed. For golang/go#67502.
(1 comment) (nit) The lines in this list are sorted; if you don't mind please apply that to the new lines too. It's not a big deal and can happen in a future CL instead.
(2 comments) Thanks. Done. It doesn't seem to add much to the error message, so removed everywhere. Done.
Last Week
dmitshur starred github.com/skx/cpmulator6d
This is a tracking issue to port the behavior implemented in coordinator for #61925 to the LUCI side in [golangbuild](https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/experimental…
dmitshur closed an issue security: fix CVE-2023-393246d
As reported by the plan9-386-0intro builder and legacy misc-compile-plan9-386 trybot, the plan9/386 port fails to bootstrap: ``` gotip $ git rev-parse HEAD e7bf9959fd9ea649e1513cef16f91f81b13604…
Thanks. Note that Run-TryBot+1 triggers legacy trybots only. It's necessary to use Commit-Queue+1 to satisfy the 'TryBots-Pass' submit requirement.
Our migration to [LUCI](https://go.dev/wiki/LUCI) should make a meaningful improvement for golang.org/x repo result views. Using a recent issue #67439 as an example, where CL 546676 introduced a n…
Adding a few investigative notes. As visible by comparing [here](https://ci.chromium.org/ui/test/golang/net%2Fhttp.TestServerReadAfterWriteHeader100Continue%2Fh1) and [here](https://ci.chromium.or…
(1 comment) Would it be better to apply the same change here as in sum32a.Sum? ```suggestion return byteorder.BeAppendUint32(in, v) ```
CC @golang/windows, @ianlancetaylor.
dmitshur closed an issue access: may-start-trybots1w
Thanks for your contributions and helping maintain the ppc64 and ppc64le ports. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybots](https://go.…
One additional CL would also need to be reverted to fix the build. The fix forward in CL 586516 was prepared quickly and is submitted now. Closing.
Thanks. I'll prepare the rollback in CL 586515.
This reverts CL 544455. Reason for revert: Breaks linux/arm and 9 more ports. For #61395.
linux/arm and a number of secondary ports are failing to make.bash as of this CL. Please comment if you think the fix is small and can be done soon, otherwise let's revert.
Issue #67439 is fixed by CL 586315, so this change is no longer needed. I think the original implementation is marginally better, and it relies on intended net/http behavior that shouldn't regress.
This doesn't reproduce each time for me, but I saw it happen again today after running these commands in my development GOROOT directory today: ``` src $ git-branches | Branch | …
Note that Go 1.22.2 is not the current latest version. That version is Go 1.22.3, released 10 days: https://groups.google.com/g/golang-announce/c/wkkO4P9stm0. Go 1.22.3 includes fixes for CVE-2024-24…
From looking at https://ci.chromium.org/ui/p/golang/g/port-freebsd-riscv64/builders, the builder seems to be producing good testing signal. @mengzhuo Would you like to remove its [known issue](https:…
Thanks for reporting. CC @golang/release, @mknyszek. Are you able to narrow down more specifics of where the additional bandwidth utilization comes from? Is it uplink or downlink? The testing s…
Thanks for reporting this. The git configuration surface is quite large, and this appears to be a case where one of the configuration values conflicts with the expectations of git-codereview, caus…