Last Week
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs1d
Package `strings` tests are passing as of 2272dd2. What's left now is: ``` $ gopherjs test io --- FAIL: TestMultiWriterSingleChainFlatten (0.00s) multi_test.go:174: multiWriter did not flatten chai…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs1d
2272dd23ee85b25660a5a6ffdc16d26c107b76c6compiler/natives/src/strings: Simple Builder implementation for js architecture.
99b79b1456efdb3b7ea234fcb0a83c4ae124d29bcompiler/natives/src/testing: Override frameSkip to avoid runtime.Callers.
shurcooL commented on bytes: make Buffer.String avoid cop… in github.com/golang/go1d
Are there benchmarks available for `strings.Builder` anywhere? I'm not finding any as part of [CL 74931](https://golang.org/cl/74931). I figured there's a good chance there are some existing bench…
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs1d
Addressed some of the remaining TODOs (but not all) in the `reflect` package changes, and cleaned up the commit messages. They're now pushed. Moving onto the remaining packages with failing tests on…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs1d
3d3a7237b82ee75dbd4cc9caf5527c0de518082dcompiler/natives: Regenerate.
413beaaa7486b47585f34811a1af84c324491d66compiler/natives/src/reflect: Return true in IsNil for implicitly converted nil interface.
bfaa210d6eed9dfef49f473ba66ab7f14897000dcompiler/natives/src/reflect: Skip TestCallReturnsEmpty.
9e9dc6719038e6be18bda9edaf7cf19bcbac2f1ccompiler/natives/src/reflect: Don't skip string internalization for types.
e6b5c867d11d43aa9f18a9fa821feda9fddb4855compiler/natives/src/reflect: Update method indexing for non-ASCII exported methods.
53975a8215db60687ec68ab1e5ab4b9b98f6b224compiler/natives/src/reflect: Update mutability of non-exported embedded fields.
e6d0a1f64cc141094a6e3d28ac9fb998e95c82cbcompiler/natives/src/reflect: Allow Copy from string to []byte.
dd057ec6636fcdeb1035439abbd3b8fe30e5113dcompiler/natives/src/internal/poll: Implement semaphores.
5edd803808ee69c9256fd6b5f6676ca44ac789f1compiler/natives/src/syscall: Provide implementation of Exit.
de62d20afc56aad97a1788e9a858808b0d5b4ecdcompiler/natives/src/reflect: Change makechan size parameter type from uint64 to int.
9987fe1cc42e27f531a18555f8d922178a49bacfcompiler/natives/src/reflect: Remove pkgPath parameter from newName.
shurcooL commented on CanvasRenderingContext2D.DrawImage … in github.com/dominikh/go-js-dom1d
@luckcolors No problem. It can be more efficient to quickly spot issues when actually using the code to do something, rather than spending too much time trying to catch all issues during code review.…
shurcooL commented on Add result parameters to gradient, … in github.com/dominikh/go-js-dom1d
Thank you very much @slimsag. @dominikh I believe I've addressed the remaining task with ff5f7d3 and this PR should be ready to be merged now. PTAL.
shurcooL pushed to gradient-pattern in github.com/dominikh/go-js-dom1d
ff5f7d3eeb055b196191cd9f4c038c63535b3214Provide attribution for documentation
shurcooL commented on Expose $packages for dev tooling in… in github.com/gopherjs/gopherjs1d
@marwan-at-work I have a question related to this. Have you thought about or considered making HMR exposed via the [`plugin`](https://godoc.org/plugin) package interface? If so, what were your tho…
shurcooL commented on Added examples to the README in github.com/google/go-github1d
> Adding information regarding the need to import context package and defining ctx variable in the snippets preceding this example code. I think this can be resolved by having a comment in the pro…
shurcooL commented on Added examples to the README in github.com/google/go-github1d
We should add a mention for it there, but for a contributor, you should prefer to always push separate, new commits to PRs, rather than squashing and force pushing existing ones. The reason to do …
shurcooL commented on Support preview Additional endpoints in github.com/google/go-github1d
A status update here. We had a PR that implemented this issue (at least partially), but deferred merging it because of rationale posted in https://github.com/google/go-github/pull/736#pullrequestrevi…
shurcooL commented on Adding a simple working program und… in github.com/google/go-github1d
> Since all the issues tagged "good first issue" are currently under development Is that really the case? I'd suggest double checking if you haven't already. If an issue was started but there's been…
shurcooL commented on int64 IDs in github.com/google/go-github1d
@kshitij10496 Are you using `go-github` on a 32-bit environment? The problem is only relevant there. > Also, shouldn't uint64 be the desired final type instead of int64 based on the recommendation? …
shurcooL created branch in github.com/dominikh/go-js-dom1d
element-non-ptr
shurcooL commented on Who to DrawImage in github.com/dominikh/go-js-dom1d
Thanks for pointing that out. That looks like an oversight during #44. We should resolve it by changing the signature to accept `Element` interface, I think the breaking API change is warranted.
shurcooL commented on RoundTrip: avoid modifying the orig… in github.com/google/go-github2d
Also get rid of "shallow copy of the struct" and "deep copy of the Header" here.
shurcooL commented on RoundTrip: avoid modifying the orig… in github.com/google/go-github2d
The "shallow copy of request" and "deep copy of request URL" phrases seem out of place here, since there's a sentence explaining it on top. Let's get rid of them.
shurcooL commented on tests/fields: False positive for fi… in github.com/google/go-github2d
> I'm very new to Go (and OS contributing) so I might not succeed. No problem, that's completely acceptable. Even if you don't succeed, you'll have tried, perhaps learned something, and maybe will…
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs2d
It's not ready for testing yet. When it is, I will announce that.
shurcooL commented on tests/fields: False positive for fi… in github.com/google/go-github2d
You're certainly welcome to, thanks! This is a hard issue. If you think you have ideas for how to tackle it, I suggest you discuss them here before sending code for review. That way, we can make sma…
shurcooL commented on Upgrade RepoStatus.ID from int to i… in github.com/google/go-github2d
For posterity (no need to resolve this now), the generator is not doing the right thing for `int64` type. It should be generating the following signature: ```Go func (r *RepoStatus) GetID() int64…
shurcooL commented on int64 IDs in github.com/google/go-github2d
We've had a report of this issue causing real errors in production on a 32-bit architecture in #806. /cc @maruel It had to do with `RepoStatus.ID` ID specifically, but the value "4396447431" provi…
shurcooL commented on Added examples to the README in github.com/google/go-github2d
The directory is named `example`, not `examples`, you should refer to it accordingly. ([This](https://dmitri.shuralyov.com/idiomatic-go#use-singular-form-for-collection-repo-folder-name) explains why…
shurcooL commented on Added examples to the README in github.com/google/go-github2d
This program, contrary to what the objective of #809 was, is not actually complete. It's missing a `package main` clause, and it's missing `func main() { ... }`. I think we should fix that and make i…
shurcooL commented on Adding a simple working program und… in github.com/google/go-github2d
Hi there, thank you for feedback and suggestions, they are appreciated. I agree this is important, especially because `go-github` is a good first package to play with for people who just installed G…
shurcooL commented on unused: mark an entire file as unus… in github.com/dominikh/go-tools2d
Isn't that going to be very rare, and hard to justify having/maintaining additional code for detecting this? If the entire file is unused, meaning all identifiers in it are unused, after removing sa…
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs3d
Got all `reflect` tests to pass. There were some complications and remaining TODOs. I'm not completely confident in some of the fixes, they'll need to be reviewed and evaluated more closely in the en…
shurcooL commented on net/http: Implement cancellation vi… in github.com/gopherjs/gopherjs3d
Not that I want you to change anything, just looking to learn. How did you decide between doing `return nil, <-errCh` and something like `return nil, ctx.Err()`? Did you consider the tradeoffs?
shurcooL commented on Who to DrawImage in github.com/dominikh/go-js-dom3d
`drawImage` is documented at https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/drawImage. It describes the `image` parameter like so: > An element to draw into the context.…
shurcooL commented on net/http: Implement cancellation vi… in github.com/gopherjs/gopherjs3d
(It would probably be better to have this discussion outside of this PR, since it's not related to XHR...) > Cancellation support for fetch would be nice too, but doesn't seem to be widely support…
shurcooL commented on Getting an array value in github.com/gopherjs/gopherjs3d
Reopening this one is fine. You should provide JS code too.
shurcooL commented on cmd/go: running dsymutil failed: si… in github.com/golang/go4d
This is happening to me too with `go1.10beta1 darwin/amd64` on latest macOS High Sierra (10.13.2). Easy to reproduce, happens even after clearing $GOPATH/pkg. Seemingly on (all?) commands that import…
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs4d
Made good progress so far. Go 1.10 seems to have relatively few breaking changes to deal with (so far). As of commit e092078, on macOS where I'm doing development, `gopherjs test` is passing for a…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs4d
b58fec1926b871ba9cbf2bc3eef5797340100dabcompiler/natives: Regenerate.
e0920789b97d8e99bda96d9b35a4b8ac64e64640compiler/natives/src/internal/poll: Implement semaphores.
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs4d
0679f7b5686388e8e561ee6a9862a01fdd9d6644compiler/natives: Regenerate.
f2be7aeaf67d3da764467d0ecd2014e8017ab0b2compiler/natives/src/syscall: Provide implementation of Exit.
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs4d
f6e791b8c05605409b4ae7e658d74497434f8167ompiler/natives: Regenerate.
af8e2707e23f5bdb166c101c39c0833cdfe35736compiler/natives/src/reflect: Change makechan size parameter type from uint64 to int.
c3f96acb70df8307bf5e079892b5485b6f02c5d7compiler/natives/src/reflect: Remove pkgPath parameter from newName.
724ecdb6a8849eb9f8da092b4d10805e12d5c215compiler/natives/src/time: Update for internal code reorganization.
f9c2a14a3bc5d8ad3ce22e78da1562ae94ba8a81compiler/natives/src/math: Remove Dim implementation.
2fd19ac748b0310ebd53aa55b841e83e6fa2cafdcompiler/natives/src/runtime: Add stubs for getcallerpc, findfunc, funcname.
shurcooL commented on Advent 2017 - gRPC Go : Beyond the … in github.com/gopheracademy/gopheracademy-web4d
"Fo" looks like a typo, should be "For".
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs4d
I've started looking into this on [`go1.10`](https://github.com/gopherjs/gopherjs/commits/go1.10) branch. The current status is that `runtime` package doesn't compile because of missing identifier…
shurcooL created branch in github.com/gopherjs/gopherjs4d
go1.10
shurcooL commented on Getting an array value in github.com/gopherjs/gopherjs4d
To clarify for posterity, I believe it should be: ```Go js.Global.Get("temporaryVariable").Interface().(uint32) ```
shurcooL commented on Redirect issue with CreateRelease()… in github.com/google/go-github5d
I don't think it'd be hard to do. It can probably be centralized in the `Do` method. However, I agree with @willnorris and feel unconvinced that the potential benefits justify the cost of having thi…
shurcooL commented on staticcheck: detect dubious err che… in github.com/dominikh/go-tools5d
> someone previously suggested flagging `return <var>` where `<var>` is known to be nil That might've been me in https://github.com/mvdan/unparam/issues/21. To clarify, instead of "known to be nil",…
shurcooL commented on bugfix: pr comment field should be … in github.com/google/go-github5d
> Ah, I didn't realize that this struct was used for both input and output. Unfortunately, a handful of structs are, including `IssueComment`, `PullRequest`, and some others. These decisions were …
shurcooL commented on Are you aware of another Go GraphQL… in github.com/machinebox/graphql5d
> This means that every query (probably) is going to be unique. I agree. > as long as it doesn’t add loads of structs or other types to your code (it could always do this inside function bodi…
shurcooL commented on Are you aware of another Go GraphQL… in github.com/machinebox/graphql5d
> Yes, I did see it. Good to hear! > except for the complication around using structs for requests. When I tried to use that I failed I see, thanks for feedback. By any chance, do you remember wha…
shurcooL deleted branch in github.com/shurcooL/gopheracademy-web6d
patch-1
shurcooL commented on RepoStatus.id needs to be int64 in github.com/google/go-github6d
Thanks for reporting. This is definitely related to #597.
Earlier
shurcooL commented on Failure configuring node-gyp for Go… in github.com/gopherjs/gopherjs1w
Not sure if you spotted it by now or not, but it’s a warning, not an error. That’s why it’d happen in success case too. ``` ../syscall.cc:28:51: warning: ... ``` (Also, this is a good example…
shurcooL starred github.com/adinfinit/texpack1w
shurcooL pushed to master in github.com/shurcooL/home1w
080875be3b23bef30ca0606e19cc19a62476826eRemove deleted analysis package.
shurcooL pushed to master in github.com/shurcooL/home1w
314d2939507b914427055b5829391c82ae21e8b2Add heading, tabnav to {issues,notifications}app issue trackers.
shurcooL commented on Support for "expression:" on "objec… in github.com/shurcooL/githubql1w
> I tried the following (without success) The GraphQL query has `object(expression: "master:LICENSE")`. You should include the whole thing in the `graphql` tag: ``` } `graphql:"object(expression: \…
shurcooL commented on Support AllowUnexported on gopherjs in github.com/google/go-cmp1w
The `master` version of GopherJS requires Go 1.9. Aside from that, it should work with just `go get -u github.com/gopherjs/gopherjs` as per https://github.com/gopherjs/gopherjs#installation-and-usage…
shurcooL commented on Advent 2017 - gRPC Go : Beyond the … in github.com/gopheracademy/gopheracademy-web1w
I don't know whether it affects parsing or not, but you should remove this blank line (unless you have a good reason for including it). Other posts don't have it. See https://raw.githubusercontent.co…
shurcooL pushed to patch-1 in github.com/shurcooL/gopheracademy-web1w
74c9888ca3c0af620b1c0dffa45a26b5538828f3Custom JSON Unmarshaler: Apply long tail tweaks.
shurcooL commented on $global improperly defined in webex… in github.com/gopherjs/gopherjs1w
This unfortunately sounds messy. I wonder if there's a reasonable and safe way we can detect this, without compromising the behavior on other platforms. Perhaps by checking if `typeof window.String…
shurcooL deleted branch in github.com/shurcooL/gopheracademy-web1w
patch-1
shurcooL pushed to patch-1 in github.com/shurcooL/gopheracademy-web1w
25b3ea15eda9df71b5449fdec82adb6413e532aaFit query parameters for the results.
shurcooL pushed to patch-1 in github.com/shurcooL/gopheracademy-web1w
9a1dc64f285d267eeb65b08766eb8e0733a6414dCustom JSON Unmarshaler: Improve formatting, presentation.
shurcooL deleted branch in github.com/shurcooL/gopheracademy-web1w
advent-2017-dec-8-post
shurcooL pushed to advent-2017-dec-8-post in github.com/shurcooL/gopheracademy-web1w
6ea8e311ce47d200ff79ead8f4549f7a875c770dApply changes based on @kevinburke suggestions.
shurcooL commented on Advent 2017: Custom JSON unmarshale… in github.com/gopheracademy/gopheracademy-web1w
Point taken. But, I'm not sure there was much surprising stuff (aside from the dual slices of values maybe), it was a pretty straightforward problem (perhaps in hindsight?). I like that the curren…
shurcooL opened an issue in github.com/gopherjs/gopherjs1w
shurcooL pushed to advent-2017-dec-8-post in github.com/shurcooL/gopheracademy-web1w
7decb8cd0949c8cae993e0e4604520f91740cd3bRemove pushState, popState, state helpers.
shurcooL closed an issue in github.com/shurcooL/issuesapp1w
shurcooL commented on TEstin in github.com/shurcooL/issuesapp1w
Thanks for testing the issue tracker, but I recommend using a scratch repository for testing: https://dmitri.shuralyov.com/scratch/issues I'll close this because this is a not a real issue.
shurcooL pushed to advent-2017-dec-8-post in github.com/shurcooL/gopheracademy-web1w
2967d8e69c023fd751e2eef5eeb13dbaf08ba5f6Fix minor grammar/spelling issues.
shurcooL commented on Advent 2017: Custom JSON unmarshale… in github.com/gopheracademy/gopheracademy-web1w
Thanks for reviewing and making suggestions @kevinburke. I'll make appropriate changes soon.
shurcooL deleted branch in github.com/shurcooL/gopheracademy-web1w
patch-1
shurcooL created branch in github.com/shurcooL/gopheracademy-web1w
advent-2017-dec-8-post
shurcooL pushed to patch-1 in github.com/shurcooL/gopheracademy-web1w
2b46c8a5a52a12d38de40db7d5f2139389dfe38fAdvent 2017: Custom JSON unmarshaler for a GraphQL client (Dec 8)
shurcooL commented on RoundTrip: avoid modifying the orig… in github.com/google/go-github1w
> I am struggling with tests for this change. I don't think this change needs a test. We'll just review it carefully to ensure that the `URL` field of original request is not being modified, and t…
shurcooL commented on Fix typo on index.html in github.com/bluzi/travis-buddy1w
Nice contirubtion! 😝
shurcooL commented on Add support for affiliation and vis… in github.com/google/go-github1w
It might be because your oauth token doesn't have private repos scope. You should check whether or not the issue is in the `go-github` library, or on the GitHub API side by making the same request ma…
shurcooL commented on linter complains on code in generat… in github.com/gogo/protobuf1w
I see, thanks. I agree that this `return this == nil` change was a good simplification to make. But in the general case, I don't think that all linter advice is always appropriate for generated file…
shurcooL commented on c3c5e211b99fc66a5d94052fb35a159ae459da28gitignore: add .DS_Store in github.com/gopherjs/vecty1w
> I guess this should actually be `**/.DS_Store` probably. No, just`.DS_Store` would be sufficient to ignore all files with that name in all subdirectories. My original comment was pointing out th…
shurcooL commented on Redirect issue with CreateRelease()… in github.com/google/go-github1w
Oh, good point. There are definitely (wanted) redirects involved when hitting a repository that was moved/renamed, etc. What if we check the scheme before and after in the redirect. If the original …
shurcooL commented on linter complains on code in generat… in github.com/gogo/protobuf1w
@temoto I'm just wondering, did you explicitly ask `gosimple` to include generated files in its scan (because the default is [false](https://github.com/dominikh/go-tools/blob/376b3b58b9e4def403181ee2…
shurcooL commented on c3c5e211b99fc66a5d94052fb35a159ae459da28gitignore: add .DS_Store in github.com/gopherjs/vecty1w
Commit message says ".DS_Store", but the actual diff contains ".DS_store". Also, in case it's helpful, it's very common to ignore ".DS_Store" globally rather than on a per-repository basis, by add…
shurcooL commented on Redirect issue with CreateRelease()… in github.com/google/go-github1w
> if I remember correctly, there are a number of API calls that should follow redirects (for example, fetching release assets, which are typically stored on Amazon S3 so GitHub sends a redirect to th…
shurcooL commented on Redirect issue with CreateRelease()… in github.com/google/go-github1w
Hmm, supporting redirects transparent like that sounds like a double-edged sword. On the up side, it allows things to work, but on the (much more significant IMO) down side, it makes it harder to rea…
shurcooL commented on Potential false negative, didn't re… in github.com/mvdan/unparam1w
I see, that makes sense. I think I missed this in the README: > In the last two cases, a minimum number of calls is required to ensure that the warnings are useful. However, is that sentence missin…
shurcooL commented on Consider changing (*HTML).Node retu… in github.com/gopherjs/vecty1w
This sounds like a change that you should defer doing until the very moment you actually need this. Doing it sooner has no benefits IMO, but has downsides in that you might end up changing your mind …
shurcooL commented on How can I access template files in … in github.com/shurcooL/vfsgen1w
@cryptix's suggestion is right on. Package [`github.com/shurcooL/httpfs/html/vfstemplate`](https://godoc.org/github.com/shurcooL/httpfs/html/vfstemplate) is a convenient existing solution for what yo…
shurcooL commented on CSS styling in github.com/gopherjs/vecty1w
I’ve used such a technique to make one of my HTML [components](https://github.com/shurcooL/home/blob/bd99d2ad1d60f7a1c7292257c1d8701e87bcf999/component/header.go#L51-L89) (that needed a style sheet…
shurcooL commented on Set accept header for function Apps… in github.com/google/go-github1w
Sorry, I don’t understand. If you think there’s a worthwhile opportunity to improve tests, feel free to open a new issue and describe it in more detail. I am satisfied with the current tests as t…
shurcooL commented on Comments on commits that can't be s… in github.com/bradleyfalzon/gopherci1w
Worth noting, the output from `apicompat` states line 49, not 0. It seems it wasn't parsed correctly: ``` $ apicompat -before 3500fa32fc1c1bce424c831ce06357dd3b2ddab5~1 ./... 245ms HEAD:users.go…