Activity

Yesterday
dmitshur commented on math: add Tau in constants5h
> Are there are any other languages that provide `Tau` in their standard library? From https://github.com/golang/go/issues/24759#issuecomment-379993741, I see that it's provided in the standard li…
The [CONTRIBUTORS](https://tip.golang.org/CONTRIBUTORS) file was updated for the Go 1.15 release in [CL 247767](https://golang.org/cl/247767). Moving this recurring issue to the next major release.
dmitshur reviewed +2 on golang.org/dl/dl: add go1.156h
dmitshur commented on all: Go 1.15 release status6h
It should be okay because it's a safe documentation-only change and you had a CL ready. We'd want to include it in the release. (If we don't think it should block the release, we can update the issue…
(1 comment) Optionally, you could opt to keep this HTML comment and modify it to say "CL 191783 was reverted". This can help anyone looking at the source trying to understand why a relnote=yes-worth…
(1 comment) Thanks!
dmitshur commented on all: Go 1.15 release status6h
@mvdan I'll note that a more reliable way to ensure a CL is merged before the final release is add a "Fixes #nnn." line pointing to a new issue in Go 1.15 milestone with the release-blocker label. Re…
(1 comment) Please add an "Updates #37419." line (or equivalent).
dmitshur opened a change CONTRIBUTORS: update for Go 1.15 release8h
This update was created using the updatecontrib command: go get golang.org/x/build/cmd/updatecontrib cd gotip updatecontrib With manual changes based on publicly available information to canonic…
These repositories use the Go license and have a minimal CONTRIBUTORS file that points to the one in the main Go repository, so contributors to those repositories should be considered by the updateco…
Last Week
The testdata directory exists [on disk](https://github.com/golang/go/tree/master/src/io/ioutil/testdata). However, the example doesn’t have an // Output comment, so it’s only meant to be compiled…
Unrelated to documentation, please be sure to discuss changes to the /dl page in an issue first.
goexec seems to be correctly executing the code and printing the output. The call to `http.ListenAndServe` is returning an `net.OpError` with the underlying error being that “bind” syscall fai…
(1 comment) This comment is no longer applicable given the change on the line below. The blank line above wasn’t there before CL 247195 and should probably be removed too.
Issue #40147 may be related to this. /cc @andybons @toothrot @cagedmantis
Thanks for the PR. I'll try to get to reviewing it, but it may not happen right away. I hope you don't mind using your fork in the meantime, and please let me know if you learn anything more about…
(2 comments) My earlier +2 still applies, just one minor comment. s/devDataDir/dir/
(1 comment) Thanks. Doing that makes sense (and it seems clear in hindsight).
This will get resolved as part of #34744, which is something I'm working on now and it should happen over the next few weeks. If someone wants to solve it independently of #34744 sooner, feel free…
This is a great catch. Thanks for spotting this opportunity and sending a PR.
(2 comments) Not seeing issues. Thank you to new and past owners. Trivial optional nitpick: consider either replacing "not found" with "does not exist in the internal/gophers package" so it's still…
These builders are still used for making minor Go 1.14 and 1.13 releases at this time (see golang.org/issue/40563). Re-enable them on relevant release branches so that we are better informed for futu…
(1 comment) When writing this code originally, I started out with Version, Query, VersionQuery, but didn't like them because they were either too short/misleading or too verbose/distracting when loo…
Add the ability to have builds apply only to select Go versions according to a module-query-like but fictional syntax. We don't need to support all arbitrary queries right away, so start with a small…
The `cmd/release` command is currently configured to use the `freebsd-{amd64,386}-11_1` builders for the `freebsd` release targets. However, we've documented that Go 1.13 onwards requires at least…
The `freebsd-amd64-race` builder currently uses `host-freebsd-11_1-big`. Go 1.13 and newer require FreeBSD 11.2 or newer. We should update this builder accordingly. If our assumption is that newer…
At the start of each code freeze, we should evaluate the builders used to make the upcoming major Go release, and confirm they are the most appropriate choice out of what is available. The start o…
The current Go tag parser supports only final releases, not betas and not RCs. It would become more useful if it supported all release types. There are some places in x/build where we've wanted to us…
(1 comment) Maybe we can improve this panic text to make it easier to understand what should be done to fix the problem? Feel free to edit it if you think so.
(1 comment) An entry needs to be added to the internal/gophers package.
(3 comments) Please wrap this line to a more comfortable width, per https://golang.org/wiki/CommitMessage ("the text should be wrapped ..."). This is in scope of issue #18548 (also see #18917). We …
dmitshur pushed to master in github.com/shurcooL/home1w
91c5682bc2aa970ba2311282230a37f1b27e4c1csupport HEAD method in ?go-get=1 requests
DO NOT REVIEW / DO NOT SUBMIT: This is a draft CL that goes with https://golang.org/issue/40477#issuecomment-667809154.
> 1. Write a CL. Examples: https://golang.org/cl/245379, https://golang.org/cl/245380. If the site requires more than just adding a pattern, describe your changes here first. I tried to create a C…
dmitshur pushed to master in github.com/shurcooL/githubv41w
f27d2ca7f6d535f7e35dd817493104814423eb48regenerate for schema changes by 2020-07-31
Earlier
Thanks, we’ll try to take a look at this request next week. For programs where it’s critical to receive stop / shutdown event, do you know if there is a workaround that can be used until this is…
Does this issue affect Go 1.13 in addition to 1.14, or was it introduced in 1.14? We need to know this because the minor release policy requires an issue is fixed in all affected supported releases (…
(8 comments) Is there a call to flag.Parse() missing? Consider using UserConfigDir instead. Consider filepath.Join-ing it with "relui" or so. There are some calls to newFileStore with the empty s…
From https://farmer.golang.org#pools: - host-android-arm64-corellium-android: 0/0 (3 missing) - host-darwin-arm64-corellium-ios: 0/0 (3 missing) Their results have stopped showing up on https:…
dmitshur closed a change doc/go1.15: add dd's closing tag1w
dmitshur commented on doc/go1.15: add dd's closing tag1w
This change was bundled into CL 245977, in patch set 2.
dmitshur closed a change doc/go1.15: add "now"1w
dmitshur commented on doc/go1.15: add "now"1w
This change was bundled into CL 245977, in patch set 2.
(2 comments) LGTM, thanks! While many phrases use "now", there are plenty that omit it, so I think this would be fine without it. There's no need to make them all include it. But, this is okay too.
Sounds good. Factored it out into a standalone issue #40519.
(Factoring out comment https://github.com/golang/go/issues/28856#issuecomment-665252612 into a separate issue, since it's slightly different than #28856 and out of scope for that issue.) Some of `…
(1 comment) The change looks reasonable to me, but I'm not closely familiar with the logic so I'll give +1 for now. Is it worth adding a test for this, or okay as is? Will the new tests in CL 24089…
Thanks for reporting. This looks like a bug that needs to be fixed. Where did you get to the URL https://golang.org/doc/articles/wiki/final.go from?
Either rename the `StarGazers` field to `Stargazers`, or add an explicit name override via field tag: ```Go StarGazers struct { TotalCount githubv4.Int } `graphql:"stargazers"` ``` There's…
In a Go release meeting, we noticed issue #40368 likely affects Go 1.13 as well. This needs to be confirmed, and if so, this is the tracking issue for #40368 to be considered for backport to the next…
I think there is a benefit to using this approach as a next step to support linking to module source code. Iterating on this approach in an internal package can help inform the design of an HTTP m…
The https://golang.org/project/ page has a "Version history" section that lists major Go releases that have been released. Prior to [CL 229483](https://golang.org/cl/229483), it needed to be manually…
dmitshur starred in rsc.io/swtch1w
rsc.io is working again now (see https://github.com/rsc/quote/issues/4#issuecomment-665300101). Making cmd/go tests not depend on external services is tracked in issue #28856. I don't think there's a…
The immediate issue has been resolved: ``` $ GOPROXY=direct GO111MODULE=on go get rsc.io/quote/v3 go: downloading rsc.io/quote/v3 v3.1.0 go: downloading rsc.io/quote v1.5.2 go: rsc.io/quote/v3…
@menghanl Fixing rsc.io/quote is being tracked in issue https://github.com/rsc/quote/issues/4.
@hencrice The `GOPRIVATE` environment variable in `go env` output is set to `*`, which tells the go command to consider all modules as private and not to use the module proxy and checksum database fo…
@hencrice Please post the full output of running `go version`, then `go env`, then the exact command you ran that's still giving an error, so we have full information. It should work okay if GOPRO…
There were some additional cmd/go tests failing on the longtest builder because `rsc.io`, `swtch.com`, and `insecure.go-get-issue-15410.appspot.com` domains were not serving Go packages (see #40452).…
@hencrice I can't reproduce this with Go 1.14 with a default configuration: ``` $ go version go version go1.14.6 darwin/amd64 $ cd $(mktemp -d) $ go mod init example.com/m go: creating new go…
dmitshur commented on doc: write Go 1.15 release notes2w
The draft notice is correct. We generally remove it as part of making the final release, not earlier.
Following up on https://github.com/golang/go/issues/38485#issuecomment-647584660. Since then, I found that Gio (/cc @eliasnaur) also sets the `ios` build tag unconditionally (see [here](https://gi…
By now (after some number of days have passed), it says "The current version is go1.14.6." on the About page.
> strange thing is we do receive those collaborators regardless in our response. Maybe the results are incomplete? If you think it's a bug on GitHub's side, it would be helpful to report it to them.…
This false positive issue is very similar to #316. Consider test code like this: ```Go func TestFooAllocs(t *testing.T) { allocs := testing.AllocsPerRun(1000, func() { Foo("bar") }) if a…
Overall, I like the plan and the future versions. As discussed over chat, I think you should avoid retroactively giving existing older releases (all but the latest current release, 2020.1.4) a seman…
> I can also confirm I'm getting the data back as expected. So it seems to be something in the lib that is doing some check or magic somewhere after getting the response causing that error regarding …
Thanks for investigating and confirming this is fixed, Hajime.
> However when ran from graphql playground using the same authentication token it works. That is unexpected. > Is there a way I can inspect the generated graphql? Yeah, it's a good idea to confirm…
dmitshur commented on go4.org: Installing go4 error2w
No problem. @melardev Out of curiosity, did you find the previous invalid "github.com/go4org/go4/strutil" import path written down or suggested somewhere? I'm asking because if there was some resour…
dmitshur commented on go4.org: Installing go4 error2w
The fix is to use a matching module path, which is `go4.org`. You can see it declared at the top of the [`go.mod` file](https://github.com/go4org/go4/blob/f5505b9728ddf920bb673137648788c5ac99de1b/go.…
I believe this particular misalignment has been resolved by now. I'm not able to spot it by now. Note that #28643 tracks general readability improvements to the golang.org/x repo view.
Thanks for reporting the problem with `ignore` build tag, that indeed needs to be fixed. Can you please open a separate issue about the problem with `importPathToDir`? It does need to be run inside …
> a bug in the dashboard UI I've looked into it, it's not a trivial mistake, the problem happens due to insufficient data and a more complete fix would need changes to multiple components (the bui…
It turns out it's a bug in the dashboard UI rather than intentional configuration. The `linux-amd64-androidemu` builder is configured to run both on pre- and post-submit builders. There's even a [tes…
Oh, I was misreading the build dashboard. The linux-amd64-androidemu builder is configured run pre-submit trybots, but not post-submit builds. Skipping it with this issue open seems reasonable to …
Do you know since when it became flaky? How often have you seen it? I'm not seeing many (or any) previous failures on the post-submit runs (https://build.golang.org/?repo=golang.org%2fx%2fmobile).…
My intention was to suggest we use #39813 for tracking improvements to the heuristic of when to consider a function as a "factory function". However, this issue seems slightly different, as it's abou…
Closing in favor of aforementioned issue. See https://github.com/golang/go/issues/36642#issuecomment-577908050 for more details about what happened, including the root cause.
The current latest Go release is Go 1.14.6. Clicking the About button at https://play.golang.org now says: > The playground uses the latest stable release of Go. > The current version is [go1.…
It seems the memcached instance has become unhealthy again. I'll look into restarting it for now.
Fixed via [CL 243477](https://golang.org/cl/243477) and [CL 241717](https://golang.org/cl/241717).
dmitshur pushed to master in github.com/shurcooL/home3w
e9ff8b15dd53491dc9974c689c910f34742bdd97indieauth: reject redirects to insecure HTTP protocol
> It is not committed If a very large file or directory is not committed, it would not be a real problem, so `gorelease` reporting that is a false positive as far as I understand. Is there already a…
> it does not reproduce on other modules or with an older version of gorelease, [CL 197299/4](https://go-review.googlesource.com/c/exp/+/197299/4). In the diff between [patch set 4 of CL 197299 and …