Activity
Today
dmitshur reviewed +2 on golang.org/x/build/main.star: add go-private image mirror1h
Thanks.dmitshur commented on runtime/race: [release-branch.go1.26] apply LLVM zero-initialization fix1h
Hold for CL 758160 readiness. (To make tracking easier.)dmitshur opened a change golang.org/x/build/main.star: remove known issue for linux-amd64-longtest-git2.24.01h
The builder has been added and it's working.
For golang/go#26746.
For golang/go#77284.
Fixes golang/go#26653.dmitshur commented on crypto/internal/fips140/drbg: unnecessary linear memory increase on Wasm with Go 1.262h
CC @golang/wasm.dmitshur commented on internal/trace: preallocate pcs array to correct size2h
Thanks.dmitshur commented on net/url: url.Parse in 1.26 breaks mongodb connection string parsing with multiple hosts [1.26 backport]3h
@neild On the main branch, CL 751360 added the mongo-specific implementation and a test, and CL 758900 generalized it for non-http/https and kept the test. The Go 1.26 backport CL 758901 adds the new…dmitshur commented on golang.org/x/build: add a builder with oldest git supported by cmd/go to catch regressions3h
Now that #78323 is resolved, the builder is passing [at tip](https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-amd64-longtest-git2.24.0).
It's also passing on [release-branch.go1.26](https…dmitshur commented on cmd/go: [release-branch.go1.25] tests: rename git-min-vers->git-sha2563h
This change is ready for review.dmitshur commented on cmd/go: [release-branch.go1.25] skip git sha256 tests if git < 2.293h
This change is ready for review.dmitshur commented on cmd/go/internal/vcweb/vcstest: TestScripts/git/gitrepo-sha256.txt failures [consistent failure]3h
@gopherbot Please consider this for backport to Go 1.25. (Go 1.26 already has these fixes, so nothing to backport there.) These are test-only fixes needed to make tests pass with the oldest suppor…Yesterday
dmitshur opened a change cmd/go: [release-branch.go1.25] tests: rename git-min-vers->git-sha25621h
Follow-up cleanup on go.dev/cl/698835. Clarify the tests by replacing
git-min-vers with a more-purposeful git-sha256 verb in the cmd tests.dmitshur opened a change cmd/go: [release-branch.go1.25] skip git sha256 tests if git < 2.2921h
Fix test building on older Ubuntu LTS releases (that are still
supported). Git SHA256 support was only included in 2.29, which came out
in 2021. Check the output of `git version` and skip these tests…dmitshur reviewed +2 on cmd/dist: try to use jj commit info for devel version21h
This addition seems reasonable since this code path affects Go developers only. Note that it's untested by builders, so it'll be up to whoever uses it locally to maintain. Thanks.
Fixes #nnn? This s…dmitshur commented on golang.org/x/build/main.star: add x/website presubmit builder for all of GOROOT/doc23h
Thanks.dmitshur opened an issue cmd/compile: multiple "internal compiler error" issues23h
There have been a number of "internal compiler error" issues reported recently, each covering specific edge cases that were uncovered. This is an umbrella issue to make it easier to track them.
CC @…dmitshur commented on cmd/go: do not forward GOAUTH-derived credential headers across cross-host redirects23h
From triage, it sounds like the redirect happens by an initially trusted source, and not forwarding GOAUTH may cause it to not work for the target. So there may not be any behavior change to do here.dmitshur commented on cmd/compile: internal compiler error: map elem too big 214748364823h
CC @golang/compiler.dmitshur commented on cmd/link: TestMachOBuildVersion failures23h
From triage, maybe this test doesn't need to run on GOARCH=ppc64le as well.
CC @golang/ppc64.dmitshur commented on cmd/link: peCreateExportFile generates invalid .def file when output name has trailing dot (c-shared on Windows)1d
CC @golang/windows.dmitshur commented on syscall: wrong constant used in `WaitStatus.Stopped()` & `WaitStatus.Continued()` comparisons1d
CC @golang/freebsd, @golang/openbsd.dmitshur commented on crypto/tls: Seg Fault In TLS Handshake in RKE1d
Are you able to reproduce this when using either Go 1.26 or 1.25? In the go env output, it looked like the Go toolchain version was 1.22.dmitshur commented on golang.org/x/website/cmd/golangorg: support absolute paths in testTree1d
Thanks.dmitshur commented on golang.org/x/website/cmd/golangorg: include GOROOT/doc files in TestAll checks1d
Thanks.dmitshur commented on golang.org/x/website/cmd/golangorg: catch instances of bad escaping due to template use1d
Thanks.
The 1.26/1.25 (only) builders failing was [expected](https://go-review.googlesource.com/c/website/+/746741/comments/ae57427c_0909aa7c). The backport CLs have just landed, so everything shoul…dmitshur opened a change cmd/compile: [release-branch.go1.26] skip race detector test failure for unsupported VMA1d
For #77799.
For #78219.dmitshur commented on cmd/compile: panic on invalid generic append with type parameter spread [1.26 backport]1d
Need to confirm whether 1.25 backport is also needed, or if this is 1.26-only per https://github.com/golang/go/issues/34536#issuecomment-572188389.dmitshur commented on cmd/compile: panic on invalid generic append with type parameter spread1d
Does the problem also affect Go 1.25? In that case we should also backport to 1.25 per our policy.dmitshur commented on golang.org/x/build/main.star: remove linux-amd64-spectre known issue1d
It passed at tip (https://ci.chromium.org/b/8686347220472067905) and correctly detected a problem intentionally re-introduced in CL 759121, so everything seems working as intended to me.
Thanks.dmitshur commented on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test1d
Thanks.dmitshur reviewed +1 on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test1d
dmitshur opened a change golang.org/x/sys/cpu: add runtime import in cpu_darwin_arm64_other.go1d
It was missed in CL 737260.
For golang/go#43046.dmitshur commented on golang.org/x/sys/cpu: use IsProcessorFeaturePresent to calculate ARM64 on windows1d
(1 comment)
I agree it would be good to update mkwinsyscall to support this use case, and that it can happen later. In the meantime, what do you think about temporarily replacing the need for manual…dmitshur reviewed +1 on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test1d
dmitshur commented on runtime: memory corruption leading to panic on linux/riscv641d
Thanks for the report. Does this happen only on the linux/riscv64 port specifically, or are you able to reproduce it on other ports too?
CC @golang/riscv64.dmitshur commented on security: fix CVE-2026-338101d
CC @golang/security, @golang/release.dmitshur commented on golang.org/x/build/main.star: set {gc,asm}flags via GO_{GC,TEST_ASM}FLAGS in spectre runmod1d
Thanks.This Week
dmitshur commented on cmd/go: add information about GODEBUGs to go help gopath1d
(1 comment)
The issue and this part of the commit message say 'GO111MODULE=auto', but the text being added says 'GO111MODULE=off'. As I understand, standard library tests work with the default moder…dmitshur reviewed +2 on cmd/go: add information about GODEBUGs to go help gopath1d
Thanks.
One too many closing double quotes here.dmitshur commented on golang.org/x/build/cmd/watchflakes: stop applying NeedsInvestigation label1d
(2 comments)
This part of the postNew's documentation seems out of date. Same on line 415.
No need to change it now; just noting that since this ends up being the only place where the constant is n…dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: stop applying NeedsInvestigation label1d
Thanks.
I suggest filing some tracking issue for this change, and adding a 'Fixes golang/go#nnn.' line here.
This change will add to the incoming volume of issues that end up in the https://go.dev/…dmitshur reviewed +2 on golang.org/x/build/main.star: remove linux-amd64-spectre known issue1d
Thanks. Note that I rebased and regenerated this change in PS 2.dmitshur commented on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test1d
(1 comment)
gogcflags has "all=" implicitly prepended; removed here in PS 4.dmitshur commented on golang.org/x/build/main.star: remove linux-amd64-spectre known issue1d
Done in CL 758840.dmitshur commented on golang.org/x/build/main.star: set {gc,asm}flags via GO_{GC,TEST_ASM}FLAGS in spectre runmod1d
(1 comment)
I missed that GO_GCFLAGS differs from setting -gcflags directly in that its value gets an implicit "all=" prefix [already prepended](https://cs.opensource.google/go/go/+/master:src/cmd/d…dmitshur reviewed +2 on cmd/go/testdata/vcstest: explicitly set invalid-version's branch to main1d
Glad to see the fix ended up this small. Thanks.
It's probably fine to backport then, if this is all it takes to to unblock the builder on 1.26+1.25 release branches too. I'll check if that's the ca…dmitshur commented on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test1d
(1 comment)
Probably cleaner to add a field to tester instead of a global. It was already not being given any value if cmdtest wasn't run, but seems nicer to make it a clear build error if accidenta…dmitshur commented on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test1d
(1 comment)
This struct field and associated code is very easy to add anew when/if we have a need to handle it differently per test, but that's not the case so far, so I'll avoid adding it and makin…dmitshur opened a change golang.org/x/build/main.star: make linux-amd64-longtest-git2.24.0 available in presubmit1d
Being able to optionally request it in presubmit should be helpful when
developing fixes for go.dev/issue/78323.
For golang/go#26653.dmitshur opened a change golang.org/x/build/main.star: set {gc,asm}flags via GO_{GC,TEST_ASM}FLAGS in spectre runmod1d
cmd/dist unsets any GOFLAGS value that might be set in the environment
to make the build and test environment more predictable. It is however
possible to provide gcflags to make.bash via the GO_GCFLA…dmitshur commented on cmd/go: support for older versions of git broken again1d
The new [*-git2.24.0](https://ci.chromium.org/ui/p/golang/g/port-linux-amd64/builders?q=-git2.24.0) builder isn't passing all tests yet, but it's very close to it. Filed a followup issue #78323 for i…dmitshur commented on golang.org/x/build: add a builder with oldest git supported by cmd/go to catch regressions1d
[crrev.com/c/7694655](https://crrev.com/c/7694655) and [go.dev/cl/758381](https://go.dev/cl/758381) added a builder that tests with git 2.24.0, the latest git minimum version based on https://github.…dmitshur opened an issue cmd/go: TestScript/mod_invalid_version and ./internal/vcweb/vcstest.TestScripts/git/invalid-version.txt fail with git 2.24.01d
The builder with the minimum supported git version is being added in issue #26653, and so far it seems all but these two tests are passing with it:
- [cmd/go.TestScript/mod_invalid_version](https://…dmitshur reviewed +2 on golang.org/x/build/main.star: add mapsplitgroup builder2d
Thanks.dmitshur opened a change cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test2d
If we run into a need for finer control over when -asmflags gets set,
there can be an asmflags field added to goTest, analogously to the
existing gcflags and ldflags fields. Start with a minimal chan…dmitshur commented on test/fixedbugs: [release-branch.go1.26] remove issue46234 test timeout2d
net/http.TestOptions/h1 is a pre-existing flaky test tracked in issue #69002. Not related to this change, and everything else passed, so applying TryBot-Bypass.dmitshur commented on golang.org/x/benchmarks/sweet/common: invoke go env with -json flag2d
Thanks.dmitshur opened a change golang.org/x/benchmarks/sweet/common: invoke go env with -json flag2d
The go command supports the -json flag to make it convenient to parse
its output programmatically. Since human-readable output isn't needed
here, switch to using the -json flag.dmitshur opened a change test/fixedbugs: [release-branch.go1.25] remove issue46234 test timeout2d
issue46234 is flaky on slow machines due to the possibility of running
into the constant timeout. Delete it in favor of timeouts applied at a
higher level.
Note that that test timeout already got in…dmitshur opened a change test/fixedbugs: [release-branch.go1.26] remove issue46234 test timeout2d
issue46234 is flaky on slow machines due to the possibility of running
into the constant timeout. Delete it in favor of timeouts applied at a
higher level.
Note that that test timeout already got in…dmitshur commented on test: issue46234.go failures with "command exceeded time limit"2d
@gopherbot Please consider this for backport. This is a test-only fix that removes a constant timeout for one subtest (in favor of timeouts applied at a higher level), and is needed to get the darwin…dmitshur commented on golang.org/x/build/main.star: add linux-amd64-longtest-git2.24.0 builder2d
Thanks.
I was too (in [this thread](https://go-review.googlesource.com/c/build/+/758381/comment/fbb41a80_6bf219c7/)). :) It seems something like "min" might be a good fit for builders where the mini…dmitshur commented on internal/cpu: support windows/arm642d
As for where the GOROOT/src/go/build/deps_test.go dependency policy should be discussed: this issue is fine. You can find reasonable examples of where it last changed via git history (e.g., [here](ht…dmitshur commented on golang.org/x/build/main.star: add linux-amd64-longtest-git2.24.0 builder2d
(1 comment)
Done. We already use dots in some builder name versions, like "freebsd-amd64_15.0", so done the same here since git2.24.0 is easier to read than git2240.dmitshur commented on golang.org/x/build/main.star: add linux-amd64-longtest-git2.24.0 builder2d
(1 comment)
Hmm, maybe it'll be simpler in the long run to give this a specific version. That way when this eventually becomes a newer version, it can be added as a separate runmod with a separate k…dmitshur opened a change golang.org/x/build/main.star: add linux-amd64-longtest-git2.24.0 builder2d
For golang/go#26653.dmitshur commented on golang.org/x/image/tiff: cap buffer growth to prevent OOM from malicious IFD offset2d
Thanks.
No, since this is ready from your side and all submit requirements are met, it just needs someone with submit access to either press the 'Submit' button directly or to add an Auto-Submit+1 v…dmitshur commented on golang.org/x/benchmarks/cmd/bench: compute distribution size2d
(1 comment)
There's no date in `go env -json GOVERSION`; see related [comment](https://go-review.googlesource.com/c/benchmarks/+/758120/comment/aa9f0f2d_c7bb460d/).dmitshur reviewed +2 on golang.org/x/benchmarks/cmd/bench: compute distribution size2d
Thanks.
This seems like it might run into an off-by-one-character problem, unless I missed something. go/version doesn't tolerate extraneous characters (e.g., https://go.dev/play/p/eGgX4tlSAXs), so …dmitshur commented on builtin: [release-branch.go1.26] incorporate all feedback into doc string for new2d
(1 comment)
Fix applied.dmitshur commented on testing: within a B.Loop loop, assigning function result to _ allows body to be optimized away (1.26 regression) [1.26 backport]2d
@JunyangShao This backport issue is approved, and it needs a backport CL to be created as the next step here. Since you authored the original CL, mind doing that? Note that there is a merge conflict …dmitshur commented on golang.org/x/tools/go/analysis/passes/inline: [internal-branch.go1.26-vendor] fix panic in inlineAlias with instantiated generic alias3d
CL 758300 vendors this change on main Go repo's release-branch.go1.26 branch.dmitshur opened a change cmd/fix: [release-branch.go1.26] pull in CL 7559803d
Fixes #78191.
[git-generate]
cd src/cmd
go get golang.org/x/tools@internal-branch.go1.26-vendor # v0.39.1-0.20260323181443-4f499ecaa91d
go mod tidy
go mod vendordmitshur commented on crypto/x509: quadratic work in policy validation with large PolicyMappings3d
CC @rolandshoemaker.dmitshur commented on crypto/x509: excessive chain-building work in Verify with many candidate parents3d
CC @rolandshoemaker.dmitshur commented on builtin: [release-branch.go1.26] incorporate all feedback into doc string for new3d
(1 comment)
```suggestion
Fixes #77586.
```
Will apply after trybots finish running to avoid interrupting them.dmitshur opened a change builtin: [release-branch.go1.26] incorporate all feedback into doc string for new3d
The previously submitted CL didn't include some of the feedback
that was provided on the CL. Specifically, it didn't mention the
behavior of `new` for untyped constant arguments.
For #77584.
Fixes #…dmitshur opened a change builtin: [release-branch.go1.26] update new function comment3d
The function comment for new does not reflect the recent change in behaviour since Go 1.26.
For #77584.
For #77586.dmitshur commented on golang.org/x/build: add LUCI linux-riscv64-rva22u64 builder3d
@mengzhuo Thanks, here's the corresponding certificate: [linux-riscv64-rva22u64-mengzhuo-1774283578.cert.txt](https://github.com/user-attachments/files/26188379/linux-riscv64-rva22u64-mengzhuo-177428…dmitshur reviewed +2 on golang.org/x/benchmarks/cmd/bench: compute distribution size3d
Thanks.
It made sense to use sweet's packages when this was a benchmark in sweet, but now that it's not, provided it works out well to use https://pkg.go.dev/os#CopyFS and runtime.GOOS/GOARCH direct…Last Week
dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies failures during migration to pkgbits.V35d
dmitshur reopened an issue internal/cpu: support windows/arm645d
Reopening this issue because [CL 740880](https://go.dev/cl/740880) was rolled back ([CL 757482](https://go.dev/cl/757482)).
Adding an import of golang.org/x/sys/windows inside the golang.org/x/sys/c…dmitshur commented on go/build: latest version of x/sys/cpu is incompatible with dependency policy in the standard library5d
CC @golang/runtime, @golang/windows.dmitshur opened an issue go/build: latest version of x/sys/cpu is incompatible with dependency policy in the standard library5d
Currently at tip, the only package from x/sys vendored into the std module of the main Go repo is [x/sys/cpu](https://cs.opensource.google/go/go/+/master:src/vendor/modules.txt;l=19-20;drc=ca5ffe0092…dmitshur commented on cmd/internal/moddeps: TestAllDependencies failures during migration to pkgbits.V35d
[CL 757520](https://go.dev/cl/757520) will fix this.dmitshur fixed an issue golang.org/x/playground: error communicating with remote server on 2026-03-206d
That particular version of the 1.26 playground backend got into an unhealthy state for reasons that aren't yet understood. Since this is the first occurrence of this specific failure mode for the pla…dmitshur commented on doc: go.dev/doc/godebug page contains "{{raw" due to misconfigured template use6d
The fix is visible at https://tip.golang.org/doc/godebug now, but not yet at https://go.dev/doc/godebug. We still need to backport it, since go.dev serves content from a stable release branch. This i…dmitshur commented on golang.org/x/playground: error communicating with remote server on 2026-03-206d
The immediate problem should be resolved. Thanks @dolmen for confirming.
I'll keep this issue open for some time since we're still looking more into what happened and what we can do to reduce chance…dmitshur commented on golang.org/x/playground: error communicating with remote server on 2026-03-206d
Thanks for reporting this. We're working on resolving this, and will update this issue once this is fixed.
As the original issue noted, "Go 1.25 and gotip backends are working at the moment.", so as…Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change10modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2y