Today
Yesterday
dmitshur commented on Refactor testcases in github.com/shurcooL/markdownfmt12h
Thanks for the PR! I apologize, but it'll take me some time before I get a chance to review it.
I'm not sure if we should be resolving #44 by updating the test data. I think it's a higher priority…
Thanks for the PR! I apologize, but it'll take me some time before I get a chance to review it.
I'm not sure if we should be resolving #44 by updating the test data. I think it's a higher priority…dmitshur commented on .github: use multiple issue templat… in github.com/golang/go15h> However, it does add an extra step when you are at the GitHub issue page and then click "New issue". To experience it yourself, go e.g. to https://github.com/tensorflow/tensorflow/issues and click …
> However, it does add an extra step when you are at the GitHub issue page and then click "New issue". To experience it yourself, go e.g. to https://github.com/tensorflow/tensorflow/issues and click …dmitshur commented on cmd/go: provide an easy way to fetc… in github.com/golang/go15h> Users can figure it out using the default branch name as the suffix (e.g. go get -m golang.org/x/text@master) but the default branch name varies depending on repos so it requires a bit of digging a…
> Users can figure it out using the default branch name as the suffix (e.g. go get -m golang.org/x/text@master) but the default branch name varies depending on repos so it requires a bit of digging a…dmitshur commented on Fix own misspellings in github.com/client9/misspell16hFriendly ping @client9. Let me know if I can help in any way with getting this PR reviewed.
Friendly ping @client9. Let me know if I can help in any way with getting this PR reviewed.dmitshur commented on .github: use multiple issue templat… in github.com/golang/go16h> We could use this e.g. to have different templates for proposals vs regular issues.
Adding a `.github/ISSUE_TEMPLATE/proposal.md` sounds reasonable to me.
> On the other hand, it adds another…
> We could use this e.g. to have different templates for proposals vs regular issues.
Adding a `.github/ISSUE_TEMPLATE/proposal.md` sounds reasonable to me.
> On the other hand, it adds another…dmitshur commented on x/build: trybot-result-changers Ger… in github.com/golang/go18hI think @andybons has resolved the issue of some of us not being able to remove TryBot-Result votes recently, see https://github.com/golang/go/issues/29285#issuecomment-454962865.
Do we still need…
I think @andybons has resolved the issue of some of us not being able to remove TryBot-Result votes recently, see https://github.com/golang/go/issues/29285#issuecomment-454962865.
Do we still need…This Week
dmitshur commented on Make today/tomorrow/yesterday at th… in github.com/olebedev/when1dIssue #13 is related.
Issue #13 is related.dmitshur commented on Today shouldn't equal now in github.com/olebedev/when1dIt looks like PR #14 is related to this issue.
It looks like PR #14 is related to this issue.dmitshur commented on Document SanitizedAnchorName algori… in github.com/russross/blackfriday1d@rtfb Since this change drops a dependency, and many people like that, perhaps we should make a new v2 release. Perhaps v2.1.0? What do you think @rtfb?
@rtfb Since this change drops a dependency, and many people like that, perhaps we should make a new v2 release. Perhaps v2.1.0? What do you think @rtfb?dmitshur commented on Document SanitizedAnchorName algori… in github.com/russross/blackfriday1dNo problem! Thanks, I'll merge it now.
No problem! Thanks, I'll merge it now.dmitshur commented on module-aware building in github.com/gopherjs/gopherjs1d> The only point I'm making is that, depending on when you think you'll be in a position to raise that issue, it might make sense to try and get those PRs kicked off now, rather than waiting any long…
> The only point I'm making is that, depending on when you think you'll be in a position to raise that issue, it might make sense to try and get those PRs kicked off now, rather than waiting any long…dmitshur commented on module-aware building in github.com/gopherjs/gopherjs1d@dmitshur - any update on this?
I have an update. I'm working on getting it done during this long weekend.
> When we last spoke you said you wanted to get the issue about the future of GopherJS…
@dmitshur - any update on this?
I have an update. I'm working on getting it done during this long weekend.
> When we last spoke you said you wanted to get the issue about the future of GopherJS…Last Week
dmitshur commented on 3rd-side packages in github.com/gopherjs/gopherjs.github.io2dDo you mean in a local copy of the playground? Yes, they're just compiled archive .a files being copied there. See `update.sh` file to see how the pkg directory is populated.
If you mean for https…
Do you mean in a local copy of the playground? Yes, they're just compiled archive .a files being copied there. See `update.sh` file to see how the pkg directory is populated.
If you mean for https…dmitshur commented on Feature: turn off gzip compression in github.com/shurcooL/vfsgen3d> There doesn't seem to be an option to turn off automatic compression of included files.
This is currently true.
> gzip'ed resource that has to be decompressed on the fly
Decompressed by wh…
> There doesn't seem to be an option to turn off automatic compression of included files.
This is currently true.
> gzip'ed resource that has to be decompressed on the fly
Decompressed by wh…dmitshur commented on Document SanitizedAnchorName algori… in github.com/russross/blackfriday3dFriendly ping @rtfb, do you have a chance to review this?
/cc @julieqiu I think this PR may fix the issue that you ran into.
Friendly ping @rtfb, do you have a chance to review this?
/cc @julieqiu I think this PR may fix the issue that you ran into.
dmitshur commented on wiki: keeping a check on wiki page … in github.com/golang/go3dThat's my understanding.
I think it'll be nice if each page is grouped in a email thread. That means using the same email title. Using the page title both for "page created" and "page edited" even…
That's my understanding.
I think it'll be nice if each page is grouped in a email thread. That means using the same email title. Using the page title both for "page created" and "page edited" even…dmitshur commented on wiki: keeping a check on wiki page … in github.com/golang/go3dI think we should take a first step of making it possible to subscribe/watch for wiki page creation/edits, before considering adding barriers to wiki page edits.
We currently have a [golang-codere…
I think we should take a first step of making it possible to subscribe/watch for wiki page creation/edits, before considering adding barriers to wiki page edits.
We currently have a [golang-codere…dmitshur commented on wiki: CodeReviewComments: change "n… in github.com/golang/go4d> I really really wish there were some way to get notified on each change to the wiki.
@ianlancetaylor How would you like to receive notifications? Each change to all pages, or only particular pages?
> I really really wish there were some way to get notified on each change to the wiki.
@ianlancetaylor How would you like to receive notifications? Each change to all pages, or only particular pages?dmitshur commented on x/build/cmd/gerritbot: TestCommitMe… in github.com/golang/go4dI believe this was fixed in [CL 157440](https://golang.org/cl/157440). Is this failure from [CL 152037](https://golang.org/cl/152037)? I think you need to rebase it on top of latest master. See https…
I believe this was fixed in [CL 157440](https://golang.org/cl/157440). Is this failure from [CL 152037](https://golang.org/cl/152037)? I think you need to rebase it on top of latest master. See https…dmitshur commented on x/tools/go/packages: TestLoadImport… in github.com/golang/go5d[CL 156977](https://golang.org/cl/156977) has fixed the issue for s390x as well. It must've been using a custom GOCACHE all along, before all the other environments started to as well.
Thank you @…
[CL 156977](https://golang.org/cl/156977) has fixed the issue for s390x as well. It must've been using a custom GOCACHE all along, before all the other environments started to as well.
Thank you @…dmitshur commented on html/template: escapeTemplate cause… in github.com/golang/go5d> I think this issue became about fixing bug in html/template package now.
I've updated the title and labels to reflect that.
The specific line the issue title refers to is:
https://github.c…
> I think this issue became about fixing bug in html/template package now.
I've updated the title and labels to reflect that.
The specific line the issue title refers to is:
https://github.c…dmitshur commented on Is this still an active project? Wh… in github.com/shurcooL/Go-Package-Store6dGo Package Store a web app only. It uses a browser to display the available updates using HTML.
Go Package Store a web app only. It uses a browser to display the available updates using HTML.dmitshur commented on Is this still an active project? Wh… in github.com/shurcooL/Go-Package-Store1wYes, I use Go Package Store weekly and actively maintain it.
Adding support for Go modules is issue #92. I plan to do it. I suggest you add a :+1: reaction there and subscribe to the issue for furth…
Yes, I use Go Package Store weekly and actively maintain it.
Adding support for Go modules is issue #92. I plan to do it. I suggest you add a :+1: reaction there and subscribe to the issue for furth…dmitshur commented on Add support for Go modules. in github.com/shurcooL/Go-Package-Store1wI plan to implement Go module support in Go Package Store during this year.
I plan to implement Go module support in Go Package Store during this year.dmitshur commented on Update to newest "golang.org/x/mobi… in github.com/goxjs/gl1w> Thanks for the fast answer. I'm currently working on a small engine and decided to use x/mibile/gl for now.
>
> But once I'm confident enough in that project to add WebGl support, I wouldn't mind s…
> Thanks for the fast answer. I'm currently working on a small engine and decided to use x/mibile/gl for now.
>
> But once I'm confident enough in that project to add WebGl support, I wouldn't mind s…dmitshur commented on x/build/app: deleted security branc… in github.com/golang/go1wThere's no underlying issue in `maintner` because the build dashboard doesn't use it.
The code that figures out the branches is [here](https://github.com/golang/build/blob/d960d82cca8060854d705031…
There's no underlying issue in `maintner` because the build dashboard doesn't use it.
The code that figures out the branches is [here](https://github.com/golang/build/blob/d960d82cca8060854d705031…dmitshur commented on Update to newest "golang.org/x/mobi… in github.com/goxjs/gl1wThanks for your interest in this package.
The upstream `golang.org/x/mobile/gl` has indeed made some internal changes since the fork point, the major one being the render-thread you mentioned.
I do…
Thanks for your interest in this package.
The upstream `golang.org/x/mobile/gl` has indeed made some internal changes since the fork point, the major one being the render-thread you mentioned.
I do…dmitshur commented on github: delete the GoCommand label in github.com/golang/go1whttps://groups.google.com/d/msg/golang-dev/nVS0dutRTy0/32Gq9omVCwAJ may be relevant.
For example, it's now possible to view all x/build issues via [goissues.org/golang.org/x/build/...](https://goi…
https://groups.google.com/d/msg/golang-dev/nVS0dutRTy0/32Gq9omVCwAJ may be relevant.
For example, it's now possible to view all x/build issues via [goissues.org/golang.org/x/build/...](https://goi…Earlier
dmitshur commented on go/packages: use GOROOT to determin… in github.com/golang/tools1wCopying my message from [Gerrit](https://go-review.googlesource.com/c/tools/+/128295/6#message-a2d06060cff5225336039c5b67eca2508537544f) here, since gerritbot didn't (but it will after golang/go#2885…
Copying my message from [Gerrit](https://go-review.googlesource.com/c/tools/+/128295/6#message-a2d06060cff5225336039c5b67eca2508537544f) here, since gerritbot didn't (but it will after golang/go#2885…dmitshur commented on all: Go 1.12beta2 release status in github.com/golang/go1wThe announcement has been made: https://groups.google.com/forum/#!msg/golang-announce/QsjKbyHTaa8/EGP_u0-_EQAJ.
A tweet has been tweeted: https://twitter.com/golang/status/1083529360798302210.
…
The announcement has been made: https://groups.google.com/forum/#!msg/golang-announce/QsjKbyHTaa8/EGP_u0-_EQAJ.
A tweet has been tweeted: https://twitter.com/golang/status/1083529360798302210.
…dmitshur commented on all: Go 1.12beta2 release status in github.com/golang/go1w
## Latest build: go1\.12beta2
src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.12beta2/go1.12beta2.src.tar.gz))
linux\-386 ([tar\.gz](https://golang-release-staging.storage.…
## Latest build: go1\.12beta2
src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.12beta2/go1.12beta2.src.tar.gz))
linux\-386 ([tar\.gz](https://golang-release-staging.storage.…dmitshur commented on all: Go 1.12beta2 release status in github.com/golang/go1w
## Log
2019/01/10 15:21:10 starting
2019/01/10 15:21:10 working in /Users/dmitshur/go-releasebot-work/go1.12beta2
2019/01/10 15:21:10 $ git clone https://go.googlesource.com/go /Users/d…
## Log
2019/01/10 15:21:10 starting
2019/01/10 15:21:10 working in /Users/dmitshur/go-releasebot-work/go1.12beta2
2019/01/10 15:21:10 $ git clone https://go.googlesource.com/go /Users/d…dmitshur commented on all: subrepos need to be green in github.com/golang/go1wSubrepos are green on [first-class ports](https://build.golang.org/#short), other than #29660 (x/tools failure on s390x) and #17538 (x/text failure on s390x).
That's green enough for Go 1.12 RC 1,…
Subrepos are green on [first-class ports](https://build.golang.org/#short), other than #29660 (x/tools failure on s390x) and #17538 (x/text failure on s390x).
That's green enough for Go 1.12 RC 1,…dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1wgolang.org has been redeployed with the fix.
For example, https://golang.org/cl/157099 now displays a disambiguation page rather than immediately redirecting to Rietveld CL 157099, since a CL with…
golang.org has been redeployed with the fix.
For example, https://golang.org/cl/157099 now displays a disambiguation page rather than immediately redirecting to Rietveld CL 157099, since a CL with…dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1wReopening for deploy of golang.org with the fix applied.
Reopening for deploy of golang.org with the fix applied.dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1w@gopherbot Please backport to Go 1.11.
@gopherbot Please backport to Go 1.11.dmitshur commented on x/build/env: run more tests in js-w… in github.com/golang/go1wOk. I'll try to look for when a `numTryTestHelpers` value has changed and see how it affected corresponding trybot/post-submit times.
For js-wasm trybots specifically, I can't predict how the exec…
Ok. I'll try to look for when a `numTryTestHelpers` value has changed and see how it affected corresponding trybot/post-submit times.
For js-wasm trybots specifically, I can't predict how the exec…dmitshur commented on cmd/compile: confusion between vari… in github.com/golang/go1w@aclements @ianlancetaylor This issue is currently labeled release-blocker with milestone Go 1.12. I can't tell whether it's meant to be a blocker for the final Go 1.12 release, or also for Go 1.12 R…
@aclements @ianlancetaylor This issue is currently labeled release-blocker with milestone Go 1.12. I can't tell whether it's meant to be a blocker for the final Go 1.12 release, or also for Go 1.12 R…dmitshur commented on doc, x/tools/cmd/godoc: move golang… in github.com/golang/go1wWe already have the [`golang.org/x/tools/godoc`](https://godoc.org/golang.org/x/tools/godoc) package, which is documented as:
> Package godoc is a work-in-progress (2013-07-17) package to begin spli…
We already have the [`golang.org/x/tools/godoc`](https://godoc.org/golang.org/x/tools/godoc) package, which is documented as:
> Package godoc is a work-in-progress (2013-07-17) package to begin spli…dmitshur commented on x/build/env: run more tests in js-w… in github.com/golang/go1wThis sounds like a good idea, in order to catch issues like this in the future during trybot runs.
@bradfitz The js-wasm builder currently has `numTryTestHelpers` set to [4](https://github.com/gol…
This sounds like a good idea, in order to catch issues like this in the future during trybot runs.
@bradfitz The js-wasm builder currently has `numTryTestHelpers` set to [4](https://github.com/gol…dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1wWe just hit this again in https://github.com/golang/go/issues/29633 for CL 157099, which exists both in Gerrit and Rietveld. There are 837 more numbers [that follow](https://go-review.googlesource.co…
We just hit this again in https://github.com/golang/go/issues/29633 for CL 157099, which exists both in Gerrit and Rietveld. There are 837 more numbers [that follow](https://go-review.googlesource.co…dmitshur commented on runtime: js-wasm build broken in github.com/golang/go1w> We could shard the js-wasm builder out wider and enable more tests.
That sounds like a good idea, in order to catch issues like this in the future during trybot runs.
The js-wasm builder curr…
> We could shard the js-wasm builder out wider and enable more tests.
That sounds like a good idea, in order to catch issues like this in the future during trybot runs.
The js-wasm builder curr…dmitshur commented on crypto/x509: root_cgo_darwin and ro… in github.com/golang/go1wLatest tip (commit 99ea99ec4c) passed on my personal Mac with macOS Mojave 10.14.2 (18C54).
<details><br>
```
$ ../bin/go version
go version devel +99ea99ec4c Wed Jan 9 14:49:46 2019 +0000 da…
Latest tip (commit 99ea99ec4c) passed on my personal Mac with macOS Mojave 10.14.2 (18C54).
<details><br>
```
$ ../bin/go version
go version devel +99ea99ec4c Wed Jan 9 14:49:46 2019 +0000 da…dmitshur commented on x/build/cmd/gopherbot: gopherbot cl… in github.com/golang/go2w> Gopherbot should only close the issue if the "Fixes #" label exists in the commit message.
That makes sense. It shouldn't close when it says "Updates #nnn".
Gopherbot checks only if the issue…
> Gopherbot should only close the issue if the "Fixes #" label exists in the commit message.
That makes sense. It shouldn't close when it says "Updates #nnn".
Gopherbot checks only if the issue…dmitshur commented on x/build/cmd/gopherbot: close-cherry… in github.com/golang/go2wI've redeployed `gopherbot` with the fix.
I've redeployed `gopherbot` with the fix.dmitshur commented on module-aware building in github.com/gopherjs/gopherjs2wI do plan to raise that issue. I’ve already written a draft and got Pail’s initial feedback on it. What’s left for me to do is work through the feedback and make the issue. Paul has suggested I…
I do plan to raise that issue. I’ve already written a draft and got Pail’s initial feedback on it. What’s left for me to do is work through the feedback and make the issue. Paul has suggested I…dmitshur commented on x/website: plain text file renderin… in github.com/golang/go2wAs noted by @bradfitz, this doesn't seem to affect rendered .go files. There is no leading tab character inserted in HTML on pages like https://golang.org/src/net/http/server.go:
<img src="https:/…
As noted by @bradfitz, this doesn't seem to affect rendered .go files. There is no leading tab character inserted in HTML on pages like https://golang.org/src/net/http/server.go:
<img src="https:/…dmitshur commented on x/build/cmd/coordinator: subrepo tr… in github.com/golang/go2wThis is worse than I originally understood, because trybots are not just testing the security release-branches in addition to normal release-branches, but rather _only_ the security release-branches.…
This is worse than I originally understood, because trybots are not just testing the security release-branches in addition to normal release-branches, but rather _only_ the security release-branches.…dmitshur commented on Fix passgo generate to generate pro… in github.com/ejcx/passgo2wThanks for working on this. At a high level, the new approach makes sense, and I agree that this is an improved user experience.
I haven’t had a chance to review thoroughly, but from a quick rea…
Thanks for working on this. At a high level, the new approach makes sense, and I agree that this is an improved user experience.
I haven’t had a chance to review thoroughly, but from a quick rea…dmitshur commented on generate: Sometimes generates longe… in github.com/ejcx/passgo2wUnderstandable.
I think rephrasing the documentation as I suggested at the bottom of https://github.com/ejcx/passgo/issues/52#issuecomment-445480407 would be helpful.
Trying more than once isn'…
Understandable.
I think rephrasing the documentation as I suggested at the bottom of https://github.com/ejcx/passgo/issues/52#issuecomment-445480407 would be helpful.
Trying more than once isn'…dmitshur commented on Doesn't build in projects that use … in github.com/shurcooL/github_flavored_markdown2w@victorshinya There are no updates on this as far as I know.
My suggested workaround would be to use [Go modules](https://golang.org/doc/go1.11#modules) that were added in Go 1.11. This package full…
@victorshinya There are no updates on this as far as I know.
My suggested workaround would be to use [Go modules](https://golang.org/doc/go1.11#modules) that were added in Go 1.11. This package full…dmitshur commented on Add HTMLDialogElement, HTMLPicture… in github.com/dominikh/go-js-dom2wThanks for working on this.
I wanted to check if you had a need or use case for these, or if you were adding them just because they're missing? The general practice for this package to add support…
Thanks for working on this.
I wanted to check if you had a need or use case for these, or if you were adding them just because they're missing? The general practice for this package to add support…dmitshur commented on x/build/cmd/coordinator: subrepo tr… in github.com/golang/go2w> Or delete the security branch altogether?
We did delete them in the canonical repository (i.e., https://go.googlesource.com/go/+refs). However, it continues to show up in the GitHub mirror repos…
> Or delete the security branch altogether?
We did delete them in the canonical repository (i.e., https://go.googlesource.com/go/+refs). However, it continues to show up in the GitHub mirror repos…dmitshur commented on x/build/cmd/gitmirror: deleted bran… in github.com/golang/go2wThis is happening for deleted branches too. E.g., `release-branch.go1.11-security` was deleted from x, but it's present in the GitHub mirror, even after being manually deleted one time from the GitHu…
This is happening for deleted branches too. E.g., `release-branch.go1.11-security` was deleted from x, but it's present in the GitHub mirror, even after being manually deleted one time from the GitHu…