Today
Yesterday
dmitshur commented on crypto/x509: macOS -framework Secur… in github.com/golang/go1d
As another data point, I am not seeing any ld warnings on the following configuration:
OS: macOS 10.13.6
Go version: current tip-1 (c6118af55864916c2c3b1bca8e216e627f232bf3)
Xcode: not installed…
As another data point, I am not seeing any ld warnings on the following configuration:
OS: macOS 10.13.6
Go version: current tip-1 (c6118af55864916c2c3b1bca8e216e627f232bf3)
Xcode: not installed…dmitshur commented on cmd/go: error when enable cgo and s… in github.com/golang/go1d> But your suggestion is good, it may be the go-ethereum's problem.
> I will report an issue to their project.
Sounds good. Feel free to link it to this issue so we can keep track of progress.
…
> But your suggestion is good, it may be the go-ethereum's problem.
> I will report an issue to their project.
Sounds good. Feel free to link it to this issue so we can keep track of progress.
…dmitshur commented on x/mobile/cmd/gomobile: c++ with SWIG in github.com/golang/go1dThis issue was resolved by [CL 134975](https://golang.org/cl/134975), but didn't get closed automatically because the commit message wasn't using the pattern described at https://golang.org/wiki/Comm…
This issue was resolved by [CL 134975](https://golang.org/cl/134975), but didn't get closed automatically because the commit message wasn't using the pattern described at https://golang.org/wiki/Comm…This Week
dmitshur commented on Make the mod time optional in github.com/shurcooL/vfsgen1dHi @jribe, thanks for the PR!
However, it is already possible to make the modify times zero, and it can be done without making direct changes to vfsgen. The way it can be done is with a wrapper `h…
Hi @jribe, thanks for the PR!
However, it is already possible to make the modify times zero, and it can be done without making direct changes to vfsgen. The way it can be done is with a wrapper `h…dmitshur commented on x/net/html: html.Parse() panic caus… in github.com/golang/go1dGreat! We can close this issue then, if there's nothing more to do here.
Great! We can close this issue then, if there's nothing more to do here.dmitshur commented on Include response body in 'unexpecte… in github.com/shurcooL/graphql2dThanks for the issue report @cjwagner, and for providing the details.
This issue is already on my radar, as PR #24 was sent to address a similar need. See discussion there for some background and …
Thanks for the issue report @cjwagner, and for providing the details.
This issue is already on my radar, as PR #24 was sent to address a similar need. See discussion there for some background and …dmitshur commented on v2: Add go.mod in github.com/russross/blackfriday2dI'm not sure that the `/v2` suffix belongs here. I think it's expected to come from the tag version (e.g., tag [v2.0.0](https://github.com/russross/blackfriday/releases/tag/v2.0.0) would have the mod…
I'm not sure that the `/v2` suffix belongs here. I think it's expected to come from the tag version (e.g., tag [v2.0.0](https://github.com/russross/blackfriday/releases/tag/v2.0.0) would have the mod…dmitshur commented on v2: Add go.mod in github.com/russross/blackfriday2dIt seems that we need to ensure that the installation instructions work for GOPATH workspaces and in module-aware mode, but they don't necessarily have to be the same. For instance, for GOPATH, it ca…
It seems that we need to ensure that the installation instructions work for GOPATH workspaces and in module-aware mode, but they don't necessarily have to be the same. For instance, for GOPATH, it ca…dmitshur commented on vfsgendev: look up source in the cu… in github.com/shurcooL/vfsgen2dThanks for the PR.
When running inside a Go module, would you expect `vfsgendev` to look for packages only within said module?
As far as I know, the usual approach to adding support for modules…
Thanks for the PR.
When running inside a Go module, would you expect `vfsgendev` to look for packages only within said module?
As far as I know, the usual approach to adding support for modules…dmitshur commented on runtime: cgo Unix C code can't modi… in github.com/golang/go2dThis issue has a high similarity to #22302 in nature, which was resolved with [CL 75751](https://golang.org/cl/75751). Perhaps that is a good example to follow?
It stands out that unlike `runtime.…
This issue has a high similarity to #22302 in nature, which was resolved with [CL 75751](https://golang.org/cl/75751). Perhaps that is a good example to follow?
It stands out that unlike `runtime.…dmitshur commented on x/build/cmd/gerritbot: deployed ver… in github.com/golang/go2dI see a bug in maintner code. It's likely the bug causing this crash, but I don't have full information to say that conclusively.
I'll start by fixing it and see if anything more needs to be done.…
I see a bug in maintner code. It's likely the bug causing this crash, but I don't have full information to say that conclusively.
I'll start by fixing it and see if anything more needs to be done.…dmitshur commented on x/build/cmd/gerritbot: deployed ver… in github.com/golang/go2dSeeing a few more instances of the same crash. This time it should be easier to debug because the deployed version is known/latest:
```
2018/09/15 16:16:52 Reloaded data from log *maintner.netMut…
Seeing a few more instances of the same crash. This time it should be easier to debug because the deployed version is known/latest:
```
2018/09/15 16:16:52 Reloaded data from log *maintner.netMut…dmitshur commented on x/tools/godoc/vfs: path separator c… in github.com/golang/go2dActually, in the [`vfs.OS`](https://godoc.org/golang.org/x/tools/godoc/vfs#OS) documentation, it says:
> ... because the slash-separated path passed to Open ...
Which implies that the paths are…
Actually, in the [`vfs.OS`](https://godoc.org/golang.org/x/tools/godoc/vfs#OS) documentation, it says:
> ... because the slash-separated path passed to Open ...
Which implies that the paths are…dmitshur commented on proposal: x/tools/cmd/godoc: add "j… in github.com/golang/go2dHere's a 24-second video to demonstrate the workflow and navigation speed possible with the "jump to identifier" dialog. In the video, I open the docs for `net/http` package and visit, in order, the …
Here's a 24-second video to demonstrate the workflow and navigation speed possible with the "jump to identifier" dialog. In the video, I open the docs for `net/http` package and visit, in order, the …dmitshur commented on x/tools/cmd/godoc: add hamburger bu… in github.com/golang/go2d> Currently, when going through larger sets of documentation, it can be a little annoying to scroll down to a method, only to have to scroll back to the top and repeat. For libs/projects that don't h…
> Currently, when going through larger sets of documentation, it can be a little annoying to scroll down to a method, only to have to scroll back to the top and repeat. For libs/projects that don't h…dmitshur commented on x/tools/cmd/goimports: Allow "-loca… in github.com/golang/go2dRelated issue is #20818.
Related issue is #20818.dmitshur commented on cmd/go: error when enable cgo and s… in github.com/golang/go2dYou're saying that `go build --ldflags "-linkmode external -extldflags -static" -a -o main -v -mod=vendor secp256k1.test.go` produces an error above, but there's no error if you take out `-mod=vendor…
You're saying that `go build --ldflags "-linkmode external -extldflags -static" -a -o main -v -mod=vendor secp256k1.test.go` produces an error above, but there's no error if you take out `-mod=vendor…dmitshur commented on x/net/html: html.Parse() panic caus… in github.com/golang/go2dI can't reproduce this with the current `golang.org/x/net/html`. Is this still an open issue? Perhaps it got resolved during changes for #23071, likely [CL 123776](https://golang.org/cl/123776).
I can't reproduce this with the current `golang.org/x/net/html`. Is this still an open issue? Perhaps it got resolved during changes for #23071, likely [CL 123776](https://golang.org/cl/123776).dmitshur commented on Inferred package links not always c… in github.com/golang/gddo2d/cc @dsnet FYI. This issue is something to be aware of when trying to linkify identifiers within the docs.
/cc @dsnet FYI. This issue is something to be aware of when trying to linkify identifiers within the docs.dmitshur commented on cmd/vet: check for http.ResponseWri… in github.com/golang/go2d/cc @alandonovan @josharian @mvdan per [owners](https://dev.golang.org/owners/).
/cc @alandonovan @josharian @mvdan per [owners](https://dev.golang.org/owners/).dmitshur commented on x/mobile: The generated jni functio… in github.com/golang/go2d> ### Does this issue reproduce with the latest release?
>
> The gomobile version is the latest
That question is referring to the version of Go you have installed. The latest release is Go 1.11.…
> ### Does this issue reproduce with the latest release?
>
> The gomobile version is the latest
That question is referring to the version of Go you have installed. The latest release is Go 1.11.…dmitshur commented on x/mobile/cmd/gobind: non-pointer st… in github.com/golang/go2d/cc @eliasnaur @hyangah per [owners](https://dev.golang.org/owners/).
/cc @eliasnaur @hyangah per [owners](https://dev.golang.org/owners/).
dmitshur commented on Port to WASM in github.com/gopherjs/websocket3dThis was resolved in bc9bf10c75f863bd82ad9e5bc2a2c832293383c6.
This was resolved in bc9bf10c75f863bd82ad9e5bc2a2c832293383c6.dmitshur commented on Port to WASM in github.com/gopherjs/websocket3dThe `dataArray := js.TypedArrayOf(data)` line below needs to be updated, doesn't it?
The `dataArray := js.TypedArrayOf(data)` line below needs to be updated, doesn't it?dmitshur commented on 
modules: use stable tag… in github.com/google/go-github3dWhen I do `go mod tidy`, it actually removes those lines, and makes some other changes. How did you update these files @willnorris?
modules: use stable tag… in github.com/google/go-github3dWhen I do `go mod tidy`, it actually removes those lines, and makes some other changes. How did you update these files @willnorris?dmitshur commented on x/mobile: Replace hardcoded -miphon… in github.com/golang/go3dFixed by [CL 135415](https://golang.org/cl/135415), closing. (It didn't get the "Fixes" format quite right, hence didn't get closed automatically.)
Fixed by [CL 135415](https://golang.org/cl/135415), closing. (It didn't get the "Fixes" format quite right, hence didn't get closed automatically.)dmitshur commented on Add StartWithSize to allow resizing… in github.com/kr/pty3dNitpick, this sentence is missing a period at the end.
Nitpick, this sentence is missing a period at the end.dmitshur commented on modules: use stable tag… in github.com/google/go-github3dIs it expected for `github.com/google/go-querystring v0.0.0-...` lines to not go away? Any idea why not?
modules: use stable tag… in github.com/google/go-github3dIs it expected for `github.com/google/go-querystring v0.0.0-...` lines to not go away? Any idea why not?dmitshur commented on v2: Add go.mod in github.com/russross/blackfriday3dThe canonical import path of blackfriday v2 is `gopkg.in/russross/blackfriday.v2`, per https://github.com/russross/blackfriday#installation. How does this intersect with that?
The canonical import path of blackfriday v2 is `gopkg.in/russross/blackfriday.v2`, per https://github.com/russross/blackfriday#installation. How does this intersect with that?dmitshur commented on doc: FAQ entry explaining Go is spe… in github.com/golang/go3dFor anyone who needs to link to this in advance of next Go release, it shows up at tip.golang.org already:
https://tip.golang.org/doc/faq#go_or_golang
For anyone who needs to link to this in advance of next Go release, it shows up at tip.golang.org already:
https://tip.golang.org/doc/faq#go_or_golangdmitshur commented on Port to WASM in github.com/gopherjs/websocket3dThis is great, thank you for working on this @nightexcessive! I tested this quickly with [one of my projects](https://github.com/shurcooL/eX0/tree/master/eX0-go#readme) that uses WebSockets substanti…
This is great, thank you for working on this @nightexcessive! I tested this quickly with [one of my projects](https://github.com/shurcooL/eX0/tree/master/eX0-go#readme) that uses WebSockets substanti…Last Week
dmitshur commented on GOPROXY using file:// protocol not … in github.com/golang/go4d/cc @rsc @bcmills
/cc @rsc @bcmillsdmitshur commented on Minor documentation fix for beginne… in github.com/shurcooL/vfsgen4d@tariq1890 I tried to elaborate and clarify the Usage section in PR #53. Can you let me know if you think it's helpful?
@tariq1890 I tried to elaborate and clarify the Usage section in PR #53. Can you let me know if you think it's helpful?dmitshur commented on Adding gitignore to vfsgen in github.com/shurcooL/vfsgen4dAlso, I'm happy you're learning how to use vfsgen! If you have any further questions about it, feel free to ask.
Also, I'm happy you're learning how to use vfsgen! If you have any further questions about it, feel free to ask.dmitshur commented on Adding gitignore to vfsgen in github.com/shurcooL/vfsgen4dThanks for answering.
In general, I prefer to have as few files in repos as possible: only the ones that are needed and provide clear value (e.g., .go code files, README, etc.). Having unused file…
Thanks for answering.
In general, I prefer to have as few files in repos as possible: only the ones that are needed and provide clear value (e.g., .go code files, README, etc.). Having unused file…dmitshur commented on Update install.md in github.com/derekparker/delve4dIsn’t this path missing the `/src/` path component?
Isn’t this path missing the `/src/` path component?dmitshur commented on Adding gitignore to vfsgen in github.com/shurcooL/vfsgen4dHi, thanks for the PR. Can you please elaborate on how you think this change is useful?
Hi, thanks for the PR. Can you please elaborate on how you think this change is useful?dmitshur commented on Make TravisCI build green again in github.com/andygrunwald/go-gerrit5dA trivial thing I just spotted: `body[:]` could be simplified to `body`. It's already a slice, no need to slice it again.
A trivial thing I just spotted: `body[:]` could be simplified to `body`. It's already a slice, no need to slice it again.dmitshur commented on WebAssembly port in github.com/robpike/ivy5d> if I'm not mistaken, the code for [iOS, Android apps] lives in this repository.
I was mistaken, it looks like what lives here is a small part of the mobile ports. The actual iOS/Android app proj…
> if I'm not mistaken, the code for [iOS, Android apps] lives in this repository.
I was mistaken, it looks like what lives here is a small part of the mobile ports. The actual iOS/Android app proj…dmitshur commented on x/build: dashboard “first-class p… in github.com/golang/go5dI can fix the discrepancy, but I'll need the decision of which are to be considered first-class vs not.
Here's the current first-class port list from build.golang.org in text form:
darwin/386:
…
I can fix the discrepancy, but I'll need the decision of which are to be considered first-class vs not.
Here's the current first-class port list from build.golang.org in text form:
darwin/386:
…dmitshur commented on cmd/go/internal/modfetch: TestCodeR… in github.com/golang/go5dIt's not urgent to fix this, I just filed the issue so we don't forget.
The test was added 3 months ago in [CL 118095](https://golang.org/cl/118095) by @rsc. I'd wait for his comments on how to be…
It's not urgent to fix this, I just filed the issue so we don't forget.
The test was added 3 months ago in [CL 118095](https://golang.org/cl/118095) by @rsc. I'd wait for his comments on how to be…dmitshur commented on cmd/go/internal/modfetch: TestCodeR… in github.com/golang/go5dFrom a glance, it looks like the test expects the tag not to be there.
From a glance, it looks like the test expects the tag not to be there.dmitshur commented on x/tools/cmd/goimports: Allow "-loca… in github.com/golang/go5dI think it's highly beneficial to avoid adding flags if possible. gofmt is already pretty opinionated, and people accept that. It has no flags (more or less), which means all projects are formatted t…
I think it's highly beneficial to avoid adding flags if possible. gofmt is already pretty opinionated, and people accept that. It has no flags (more or less), which means all projects are formatted t…dmitshur commented on x/build: limit the number of auto-a… in github.com/golang/go5dI'll wait to hear @andybons thoughts on this, but I'd say if we're going to treat "would ping more than 5 people" specially, it should just avoid doing anything.
I don't think it's viable to pick …
I'll wait to hear @andybons thoughts on this, but I'd say if we're going to treat "would ping more than 5 people" specially, it should just avoid doing anything.
I don't think it's viable to pick …dmitshur commented on x/build/cmd/gerritbot: deployed ver… in github.com/golang/go6dHaven't seen any crashes since then. I'll consider this resolved until there's evidence otherwise (we can re-open this).
Haven't seen any crashes since then. I'll consider this resolved until there's evidence otherwise (we can re-open this).dmitshur commented on How I use GOPATH with multiple work… in dmitri.shuralyov.com/blog6d
@hemenkapadia It might be worth asking that question on a [dep forum](https://gophers.slack.com/messages/dep-users). I am not familiar with it, so I can't say. I would expect that it should not fail …
@hemenkapadia It might be worth asking that question on a [dep forum](https://gophers.slack.com/messages/dep-users). I am not familiar with it, so I can't say. I would expect that it should not fail …dmitshur commented on Make TravisCI build green again in github.com/andygrunwald/go-gerrit1wNot at a problem at all, this isn't blocking me in any way.
If you don't want this opportunity to improve code to be forgotten, I'd suggest opening an issue to track it.
Not at a problem at all, this isn't blocking me in any way.
If you don't want this opportunity to improve code to be forgotten, I'd suggest opening an issue to track it.dmitshur commented on syscall/js: unclear what the zero j… in github.com/golang/go1w> Open to debate.
I have a relevant mini-experience-report to share.
In the [WebGL 1 spec](https://www.khronos.org/registry/webgl/specs/latest/1.0/), two of the functions are defined as follows…
> Open to debate.
I have a relevant mini-experience-report to share.
In the [WebGL 1 spec](https://www.khronos.org/registry/webgl/specs/latest/1.0/), two of the functions are defined as follows…dmitshur commented on Add WebAssembly support (GOARCH=was… in github.com/gopherjs/websocket1wThanks for opening the issue, and for sending a draft PR!
I tested it with one of my projects that uses WebSockets just now, and I can see that it compiles and functions partially, but after some …
Thanks for opening the issue, and for sending a draft PR!
I tested it with one of my projects that uses WebSockets just now, and I can see that it compiles and functions partially, but after some …dmitshur commented on x/build/internal/gophers: first ema… in github.com/golang/go1wI understand the issue fully now. I have a fix in mind that I think will be good, and will send a CL (with a commit message that explains everything) soon.
I also want to follow up by improving th…
I understand the issue fully now. I have a fix in mind that I think will be good, and will send a CL (with a commit message that explains everything) soon.
I also want to follow up by improving th…dmitshur commented on access: may-start-trybots in github.com/golang/go1wHi Alessandro,
Thank you for your contributions, and for requesting trybot access! I've added you to the `may-start-trybots` group, so you should be able to do so now.
As you've probably seen a…
Hi Alessandro,
Thank you for your contributions, and for requesting trybot access! I've added you to the `may-start-trybots` group, so you should be able to do so now.
As you've probably seen a…dmitshur commented on x/build/internal/gophers: first ema… in github.com/golang/go1w> You cannot add a person to a review using their Gerrit ID email, for instance.
@andybons Could you please provide more information about that. I'd like to get a better understanding of the compl…
> You cannot add a person to a review using their Gerrit ID email, for instance.
@andybons Could you please provide more information about that. I'd like to get a better understanding of the compl…dmitshur commented on Request: use *js.Value instead of j… in github.com/gopherjs/gopherwasm1w> as the behavior uninitialized `js.Value` isn't clearly (if at all) defined to me.
For posterity, that is being tracked in issue golang/go#27592.
> as the behavior uninitialized `js.Value` isn't clearly (if at all) defined to me.
For posterity, that is being tracked in issue golang/go#27592.dmitshur commented on Minor documentation fix for beginne… in github.com/shurcooL/vfsgen1wThanks for the PR!
I'm a bit worried that the very next paragraph talks about `assets`, but it's a different one. It's the `assets` variable in the generated .go file, not the input filesystem `fs…
Thanks for the PR!
I'm a bit worried that the very next paragraph talks about `assets`, but it's a different one. It's the `assets` variable in the generated .go file, not the input filesystem `fs…dmitshur commented on Reports zero candidates for syscall… in github.com/mdempsky/gocode1wThis looks related to #56.
This looks related to #56.dmitshur commented on x/tools/go/packages: TestJSON may b… in github.com/golang/go1wIt happened again on `darwin-amd64-10_11` builder on go1.10 branch:
https://build.golang.org/log/c5f6c6b6e6863169c92564c528adbb0cbc163b23
So it's not just FreeBSD that's affected. Just providin…
It happened again on `darwin-amd64-10_11` builder on go1.10 branch:
https://build.golang.org/log/c5f6c6b6e6863169c92564c528adbb0cbc163b23
So it's not just FreeBSD that's affected. Just providin…dmitshur commented on x/build: mirror the "dl" repo to Gi… in github.com/golang/go1wIt seems that getting TryBots to be functional on the new repo would require additional steps that haven't been done yet. When I tried to run them in [CL 134435](https://golang.org/cl/134435), they f…
It seems that getting TryBots to be functional on the new repo would require additional steps that haven't been done yet. When I tried to run them in [CL 134435](https://golang.org/cl/134435), they f…dmitshur commented on vanity import paths backed by GitHu… in github.com/golang/gddo1wThe fix is merged and deployed, resolving this issue. Thanks again for the report @myitcv! Please let us know if something else comes up.
The fix is merged and deployed, resolving this issue. Thanks again for the report @myitcv! Please let us know if something else comes up.dmitshur commented on x/build: mirror the "dl" repo to Gi… in github.com/golang/go1w> The last thing to confirm after this is that googlebot will apply the "cla: yes"/"cla: no" labels on future PRs.
Verified that it works well in https://github.com/golang/dl/pull/2:
![image](h…
> The last thing to confirm after this is that googlebot will apply the "cla: yes"/"cla: no" labels on future PRs.
Verified that it works well in https://github.com/golang/dl/pull/2:
dmitshur commented on x/build/cmd/gerritbot: comments occ… in github.com/golang/go1wNow that https://github.com/golang/go/issues/27561#issuecomment-420072789 is resolved, at least a part of this issue should be resolved too. Perhaps all of it.
If there are further occurrences of …
Now that https://github.com/golang/go/issues/27561#issuecomment-420072789 is resolved, at least a part of this issue should be resolved too. Perhaps all of it.
If there are further occurrences of …dmitshur commented on x/build/cmd/gerritbot: first "PR ha… in github.com/golang/go1wThis is deployed.
I've confirmed it's working. I created a new PR just now, and the "This PR has been imported to Gerrit for code review" comment was posted:
https://github.com/golang/dl/pull/2…
This is deployed.
I've confirmed it's working. I created a new PR just now, and the "This PR has been imported to Gerrit for code review" comment was posted:
https://github.com/golang/dl/pull/2…dmitshur commented on tour: Dead link at that page in github.com/golang/tour1wThis issue should be resolved or at least improved when https://github.com/golang/go/issues/27205 is resolved.
This issue should be resolved or at least improved when https://github.com/golang/go/issues/27205 is resolved.dmitshur commented on vanity import paths backed by GitHu… in github.com/golang/gddo1wThat CL can be tested (temporarily) at https://20180910t145226-dot-godoc-org.appspot.com/.
E.g., these work as expected:
- https://20180910t145226-dot-godoc-org.appspot.com/go4.org/sort (doesn'…
That CL can be tested (temporarily) at https://20180910t145226-dot-godoc-org.appspot.com/.
E.g., these work as expected:
- https://20180910t145226-dot-godoc-org.appspot.com/go4.org/sort (doesn'…dmitshur commented on vanity import paths backed by GitHu… in github.com/golang/gddo1w> Does it make sense to revert the commit that broke this in the first place, for now?
In this (rare) case, I've opted not to, because the problem and the path to resolution are well understood. T…
> Does it make sense to revert the commit that broke this in the first place, for now?
In this (rare) case, I've opted not to, because the problem and the path to resolution are well understood. T…dmitshur commented on Using unexported field in query res… in github.com/shurcooL/githubv41wIf you don’t mind, I’ll reopen this issue and use it to track the fix to the panic when unexported fields are involved. Once resolved, future users won’t run into this panic either.
If you don’t mind, I’ll reopen this issue and use it to track the fix to the panic when unexported fields are involved. Once resolved, future users won’t run into this panic either.