Activity

Yesterday
Thanks.
dmitshur commented on os: add Root.Chown11h
Thanks, this is fixed in CL 649636 now. @dneil@google.com A solaris/amd64 builder is available in LUCI infra, see https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-solaris-amd64 for …
dmitshur fixed an issue access: approvers11h
Hi @cpu, Thank your for contributing to the Go project and all of your work on packages related to Go's security and cryptography. We've discussed this request on the team and agreed to grant you th…
In case it's helpful, I'll point out that you can get some signal from compile-only testing via cross-compilation. For example, `GOOS=aix GOARCH=ppc64 go test -c -o=/dev/null` can be run on any platf…
Thanks. Indeed, from [x/exp's by Go commit](https://ci.chromium.org/p/golang/g/x-exp-gotip-by-go/console) view it looks like it's introduced by CL 629256. (FYI @khr@golang.org.) This'll be bumped …
(1 comment) FWIW the spaces here are different; not sure it matters much.
(2 comments) I've reviewed the CL and everything here looks right to me. The gopls module is left as is, it's already on a higher vrsion. The top-level x/tools module is updated to language version …
(1 comment) This is nearly a no-op, but it have some beneficial effect that e.g. someone accidentally still using go1.23rc1 (instead of the final stable 1.23 release) would get upgraded.
(1 comment) I looked into this brifly too, and found that moving this module to language 1.21 is enough for the new lines to get added. I don't see a specific reason for it in https://go.dev/doc/go1…
The go directive is at go1.23.0 and this build constraint was previously working to set a minimum supported version, but now it lowers it.
(2 comments) Hmm, this build constraint is no longer needed, the go directive in go.mod is enough now that all supported Go versions treat it as a minimum rather than advisory. (That is, Go 1.20 doe…
(1 comment) These old-style // +build lines aren't needed as of Go 1.18 and they're being removed automatically, as mentioned at https://go.dev/doc/go1.18#go-build-lines: > Since the release of Go …
Originally, the ShowOnDashboard property controlled whether a given repo was displayed in the list of golang.org/x repositories at the bottom of the build.golang.org dashboard. Because that page was …
(1 comment) It's not a big deal, but if you'd like to change it, I can suggest something like this: ```suggestion cmd/go/internal: use pathpkg name more The package "path" is already imported unde…
(1 comment) Note that a package can either be imported (one time) or not (zero times). It's not possible for a Go package to import another package more than once. It is possible to refer to an impo…
This Week
h2_bundle.go has been updated.
With CL 648735, CL 648916, and CL 649296, everything's updated for the early-in-cycle round. Removing that label to revisit this when the release freeze starts.
dmitshur reviewed +2 on net/http: add httpcommon package1d
Thanks. Indeed, that's right.
dmitshur reviewed +2 on net/http: add httpcommon package1d
Thanks for arranging this, everything looks good, one optional comment. I wish bundle wasn't trying to take on the responsibility of including the //go:generate directive in the generated output fil…
(1 comment) This is an exported identifier. See https://go.dev/doc/comment: > Every exported (capitalized) name should have a doc comment.
CC @ianlancetaylor, @neild.
CC @golang/security.
Thanks. If it becomes desired to document, add example values, or a quick validation check for these inputsin the future, keep in mind you can do that via [Doc, Example, Check fields](https://pkg.go…
Pull in the latest published version of github.com/google/pprof as part of the continuous process of keeping Go's dependencies up to date. For #36905. [git-generate] cd src/cmd go get github.com/go…
Oh, so the $HOME/.cache isn't being cleaned by anything? Yeah, using a cache directory in a per-build work directory that is cleaned sounds good. Did you mean XDG_CACHE_HOME (s/_DIR/_HOME)? Setting …
Thanks for filing an issue to track this. Oddly, as Michael K. pointed out, it seems this isn't happening in post-submit so far, yet fairly often in pre-submit recently. Compare with: https://ci.ch…
Cherry pick looks good. One of the misccompile shards failed due to running out of disk space (issue #57902), bypassing it.
CC @golang/tools-team.
Thanks.
@qmuntal If I understand right, when you applied the release-blocker label in Nov 2024 it was meant to be to track reverting CL 618496 in time for Go 1.24, is that right? Note that when using that la…
(1 comment) Now that the typeutil vet issue is resolved, all that's left is for someone more familiar with vet to review this file. @adonovan@google.com Is this vet test change expected and okay?
Copied Votes: * Code-Review+2 (copy condition\*: "**is:ANY**") Outdated Votes: * LUCI-TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE") \* The label has `labelCopyEnforcement` or `label…
Copied Votes: * Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**") * LUCI-TryBot-Result+1 (copy condition: "**changekind:NO_CODE_CHANGE**") \* The label has `labelCopyEnforcement` or `lab…
Outdated Votes: * Code-Review+1 (forced copy restriction\*: "**changeis:review-enforced_gerrit** AND NOT changekind:TRIVIAL_REBASE_WITH_MESSAGE_UPDATE AND NOT (**uploaderin:trusted-users_gerrit** AND…
(1 comment) > I wonder why nothing in our CI process causes the go test set of vet checks to run on this package on a 32-bit OS, because presumably it would continue to fail even after this change, …
Reported the problem on [the upstream CL](https://go-review.googlesource.com/c/tools/+/612496/comment/97413f32_a97e66d3/), sent CL 648895 as a potential fix. (FYI @adonovan@google.com.)
(The context for this change is [here](https://go-review.googlesource.com/c/tools/+/612496/comment/97413f32_a97e66d3/).)
(1 comment) linux/386 is a first-class port where uintptr is 32-bit, causing vet to report the finding: ``` $ GOOS=linux GOARCH=386 go vet golang.org/x/tools/go/types/typeutil # golang.org/x/tools/…
This resolves a TODO, and also coincidentally dodges vet's check for shifts that equal or exceed the width of the integer from triggering on the hash >> 32 shift on 32-bit architectures. For example,…
TryBots uncovered a problem on linux/386, I'll look.
The Go 1.25 development tree has opened. This is a good time to update all golang.org/x/... module versions that contribute packages to the std and cmd modules in the standard library to latest maste…
Thanks. Thanks for the suggestion. If it's a comment like '# NEXTUP_GO should be added here after release-branch.go1.25 is created.', it's a bit easy to miss it in the INTERNAL_GO_BRANCHES section b…
Based on the issue, these builders weren't intended to stick around beyond Go 1.24. Update 'exists' to take into account that Go tip is at 1.25, and x/tools will soon be upgraded to language version …
Copied Votes: * Code-Review+1 (copy condition\*: "**is:ANY**") Outdated Votes: * LUCI-TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE") \* The label has `labelCopyEnforcement` or `label…
Delete code that became dead as of CL 648675. Generated files unchanged.
They're both fixed. For golang/go#71612. For golang/go#71613.
@mcandre go tool dist list already leaves out broken ports by default. Broken ports can be listed too by passing in the `-broken` flag. <details><br> ``` $ go version go version go1.24.0 darwin/arm…
Thanks for updating it earlier in CL 636835 for 1.24 pre-releases as well! If you think it's helpful, feel free expand this relui task to run for RCs in addition the .0 final by changing [this line](…
(1 comment) https://go.dev/dl/#go1.24.0 is now published; removing hold. The Go 1.24.0 release is now announced at https://groups.google.com/g/golang-announce/c/_G2hEiKx8SE, so please feel free to …
Thanks! I'm reminded of CL 589936 now, which is likely where this broke. (Good to remember about the -v flag printing the content source.)
dmitshur commented on : [release-branch.go1.24] go1.24.03d
Issue #57902 that is.
dmitshur commented on : [release-branch.go1.24] go1.24.03d
One of the misccompile shards failed due to running out of disk space for some reason (issue #648555). The same builder already passed during release tests, as well as on the parent commit in https:/…
dmitshur reviewed +2 on : [release-branch.go1.24] go1.24.03d
dmitshur reviewed +2 on golang.org/dl/...: add go1.24.03d
Add this file now that it's possible to preview the release notes draft at https://tip.golang.org/doc/go1.25. For golang/go#71661.
dmitshur opened an issue doc: write release notes for Go 1.253d
This is the tracking issue for writing the Go 1.25 Release Notes. When the Go 1.25 Release Notes are complete, including resolving all known items and those caught by `relnote todo`, the release-blo…
(1 comment) The release downloads aren't posted yet; adding a hold for that (to prevent accidental early submission).
Thanks. Submitting this now alongside CL 648498.
Start using the GOROOT content from release-branch.go1.24, and add an entry for the Go 1.24.0 release to the release history. Removing the draft notice from the release notes is done in CL 647797. F…
Thanks for the report. I agree it looks like the code is missing a matching RUnlock call on configForClient.mutex in that case. This code doesn't seem to have changed recently, but it only comes up w…
The builder issue (#71563) is resolved.
Fixed by [crrev.com/c/6250541](https://crrev.com/c/6250541).
Fixed by [crrev.com/c/6250541](https://crrev.com/c/6250541).
Thanks. I've re-added it, thanks.
(1 comment) (minor) `ExampleLines` and `ExampleToValidUTF8` aren't really related, not any more than other examples, so it seems this is missing a blank line to separate them like done elsewhere. `…
Closed by merging [CL 648135](https://go.dev/cl/648135) (commit 6d399e9da6090af289aba1f9c4bcc8488387ff9a) to release-branch.go1.24.
Thanks. (The 4 linux-arm64 builders will run into #71504; if it's only that and nothing else, bypassing is fine.)
Since this release-blocker is in the Go 1.24 milestone, re-opening to track cherry-picking to release-branch.go1.24.
The linux-arm64 builder failures are #71504. It's probably not worth rebasing the entire stack over just that known issue, so bypassing.
Readding the CR+2/AS+1 that PS 9 had. Thanks for confirming.
(1 comment) Asking because it stands out as a bit of an outlier in this context: is it intented that these two map entries have same value despite having a different key? (Same question for SHAKE-25…
(1 comment) @roland@golang.org This CL came up via https://go.dev/s/needs-review but probably needs someone more familiar with details of these flags to take a look too. Can you look, or add someone…
Last Week
> I understand the image needs to be built and tested to work. I expect this is still the case, right? I'll try to find time next week for this. Thanks again. This still has go14 while the amd64 o…
Thanks. Have you had a chance to test or otherwise try it out? If there isn't an open issue for this, let's at least use the previous one. ```suggestion for minor releases. For golang/go#65756. `…
Thanks for preparing in advance.
(1 comment) We can probably remove the release-blocker label from that issue now, right? With this, and CL 646336 submitted, there's nothing that blocks the release left. Removing the draft notice i…
As far as I can tell everything's working as expected. I filed #71613 and #71612 for the current findings. Is there anything more to do here @mknyszek or ready to call this done?
Thanks. I figured something like that would inevitably need to be done as soon as there's a desire apply it more finely than per-project. I gave it a quick try just now in CL 647778. apply_mod itse…
This no-op refactor is intended to make it easier to set known issues within run mods, as will be done in the following CL.
[CL 643918](https://go.dev/cl/643918) added ASAN and MSAN builders for linux-arm64, related to issue #70054. The gotip-linux-arm64-asan-clang15 builder is passing, but the gotip-linux-arm64-msan-cla…
When x/tools' go.mod is updated to Go language 1.24 or newer (which will happen this August based on https://go.dev/s/release#timeline and https://go.dev/design/69095-x-repo-continuous-go#why-1_n_1_0…
Go 1.24 makes a change to crypto/rsa.GenerateKey that makes it return an error if a key of less than 1024 bits is requested, also adding a GODEBUG rsa1024min for it. See https://go.dev/doc/go1.24#cry…