Activity
Yesterday
dmitshur commented on all: audit x/ repos for gotypesalias settings7h
Gaby didn't include it in https://github.com/golang/go/issues/69772#issuecomment-2392352550, but issue #67791 is also related here. If there are tests in x/ repos that would fail when switching to th…dmitshur commented on golang.org/x/tools/...: set gotypesalias=0 explicitly7h
(1 comment)
@taking@google.com Note that inserting blank lines between the [package comment](https://go.dev/doc/comment#package) and the `package` clause is problematic. For example, compare documen…dmitshur commented on golang.org/x/build/internal/task: dynamically find nested modules to tidy during tagging9h
This change is ready for review.dmitshur commented on golang.org/x/build/internal/gitfs: add a generated copy of x/website/internal/gitfs9h
This change is ready for review.dmitshur commented on golang.org/x/build/internal/task: update tagging for x/oscar/internal/devtools nested module9h
This change is ready for review.dmitshur opened a change golang.org/x/build/internal/task: dynamically find nested modules to tidy during tagging10h
Fetch the git tree where go.mod is being updated, walk over its content
to find nested modules to tidy. This way even if new nested modules are
added, they'll be handled without needing additional at…dmitshur commented on golang.org/x/build: OOM on windows-arm64 builder14h
Are the OOMs in x/tools ongoing? If it was just that burst around September 20-22, I added some more detail in https://github.com/golang/go/issues/66962#issuecomment-2391753139 that's likely relevant.dmitshur commented on golang.org/x/build: gotip-windows-arm64 builders stops working14h
Recording here that there was another instance of the builders disconnecting and needing to be restarted around September 20-23:
<img width="37" alt="image" src="https://github.com/user-attachment…dmitshur reviewed +2 on golang.org/x/build/main.star: add linux-arm64-clang15 builder type14h
Thanks.This Week
dmitshur reviewed +2 on golang.org/x/build/main.star: make freebsd-amd64 high capacity and enable subrepo builders1d
Thanks.
Looks like formatting needs to be fixed.
Since we’re in x/build here, this can be written in the usual way as golang/go#61095. Not a big deal of course.dmitshur reviewed +2 on golang.org/x/build/maintner: use more recent protobuf module1d
Thanks.dmitshur commented on make.bash: hint how to install the bootstrap Go1d
Something related that's been on my mind: if we have a directory with a go.mod file with the following content:
```
module minimumbootstrap
go 1.22.6
```
Then it becomes trivial for a user with a …dmitshur commented on make.bash: hint how to install the bootstrap Go1d
(2 comments)
Yeah, I understand this message is only printed when there's no "go" binary in PATH, and none of $HOME/go1.22.6, $HOME/sdk/go1.22.6, nor $HOME/go1.4 exist. So saying "if you have Go ins…dmitshur fixed an issue golang.org/x/website: update mentions of GOARCH=wasm files in misc/wasm to lib/wasm where needed1d
All 3 CLs mentioned above are submitted, so I think this is done. Feel free to comment if we missed something.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: port to LUCI and upgrade to 14.11d
Thanks.
Asking to understand why this is 'go1.21.0' - it is because a binary with that name is expected to be definitely Go 1.21.0 and can upgrade itself to the minimum specified in go.mod, whereas …dmitshur commented on golang.org/x/website/wasi: update wasm runtime file location1d
Thanks.dmitshur commented on golang.org/x/website/wasi: update wasm runtime file location1d
Let's consider proceeding here analogously to https://go-review.googlesource.com/c/wiki/+/604119/comments/27f10acb_3d4f05ce.dmitshur commented on go.dev/wiki/WebAssembly: update support file location1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: add support for lib/wasm folder1d
dmitshur commented on go.dev/wiki/WebAssembly: update support file location1d
Some time has passed since #68024 was resolved. Since there is a note pointing to the old path for Go 1.23 and earlier, should we proceed with submitting this now so that documentation is also accura…dmitshur commented on cmd/go: breaking change in 1.23rc2 with version constraints in GOPATH mode1d
@timothy-king You're running into friction issue #25574 – there was already a backport request in https://github.com/golang/go/issues/68658#issuecomment-2313617202. As a workaround, you can create …dmitshur commented on golang.org/x/build/...: add support for lib/wasm folder1d
Thanks.
#68024 is now resolved.dmitshur commented on golang.org/x/website: update mentions of GOARCH=wasm files in misc/wasm to lib/wasm where needed1d
Added release-blocker for now so we can track this better. (It's a documentation only issue for a secondary port, so it wouldn't block the release in practice.)dmitshur commented on golang.org/x/website/internal/history: document Go 1.23.2 and 1.22.8 releases2d
In the failed runs, it said "LUCI CV no longer needs this Tryjob".
This happened because patch set 2 was uploaded without an explicit CQ+1 vote, and the CQ+1 vote from patch set 1 was removed as out…dmitshur reviewed +2 on golang.org/x/build/internal/task: add workflow to build internal security release branches2d
(1 comment)
(minor) Returning `ci` here made sense, in that the change was created successfully and `ci.ChangeID` is its ID - the only thing that failed was setting a CQ+1 vote on it.dmitshur reviewed +2 on golang.org/x/build/internal/gomote: specify workdir to buildlet as an absolute path3d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/gomote: specify workdir to buildlet as an absolute path3d
Thanks.dmitshur reviewed +2 on go.dev/wiki/WebAssembly: fix reference to `go install`3d
Thanks.
Looks like https://go.googlesource.com/wiki/+/c775517b3fee297ad3321f53dbd5c39a92f30f1b%5E%21 updated it from GOPATH mode era to module mode era, but partially.dmitshur reviewed +2 on README.vendor: add note about GOROOT, recommend fresh go3d
dmitshur reviewed +2 on README.vendor: add note about GOROOT, recommend fresh go3d
Thanks.
I think we can say "Otherwise, the results are undefined."
(In general, the go command supports working on standard library packages in its own GOROOT. Working outside of its own GOROOT mea…dmitshur closed an issue github: block merge button on github x/ repos3d
dmitshur commented on github: block merge button on github x/ repos3d
This is issue #59048. Issue #39055 is also related.dmitshur reviewed +2 on golang.org/x/mobile/asset: do not use 'assets' directory for iOS3d
Leaving a Commit-Queue+1 vote starts LUCI trybots.
It's documented at https://go.dev/wiki/LUCI#trybots.dmitshur reviewed +2 on golang.org/x/mobile/asset: do not use 'asset' directory for iOS3d
Thanks.
```
asset: do not use 'assets' directory for iOS
```
'assets'
Does this build under GOOS=ios? I expect a build error due to filepath package being unused.dmitshur deleted branch in rsc.io/github4d
masterdmitshur opened a change rsc.io/github/issue: various fixes4d
As reported by vet and staticcheck.dmitshur created branch in rsc.io/github4d
various-fixesdmitshur forked in rsc.io/github4d
Last Week
dmitshur fixed an issue runtime: unrecognized failures5d
The most recent failures here since this was reopened are all due to a core file being left behind, and the pattern isn't narrow enough to match anything else specific. So closing this in favor of #6…dmitshur closed an issue runtime: TestStackSwitchCallback failures5d
Merged into #69457.dmitshur commented on golang.org/x/vulndb/internal/symbols: TestPatchedSymbols failures5d
This can be reproduced locally by running the test in the x/vulndb module located in the module cache, rather than a git repository checkout. For example:
```
$ cd $(mktemp -d)
$ go mod init exa…dmitshur fixed an issue build: build failure on gotip-linux-amd64-newinliner5d
Based on issue #69457, the watchflakes change described in https://github.com/golang/go/issues/65977#issuecomment-1969407349 above is done. It sounds like there's nothing more to do here, and we can …dmitshur closed an issue runtime:mayMoreStackMove: unrecognized failures5d
Merged into #69457.dmitshur closed an issue build: build failure on x_tools-go1.23-windows-arm645d
Merged into #69664.dmitshur closed an issue make.bat: unrecognized failures5d
Merged into #69664.dmitshur closed an issue cmd/internal/testdir: Test/fixedbugs/issue20749.go failures5d
Merged into #69664.dmitshur commented on golang.org/x/build: OOM on windows-arm64 builder5d
Issue #33986 is relevant.
Issue #66962 may also be relevant.
dmitshur fixed an issue build: build failure on x_sys-gotip-linux-amd64-misccompile5d
Fixed in [CL 610940](https://go.dev/cl/610940).dmitshur commented on github.com/go-gl/glfw: GLFW v3.45d
Build constraints are documented at https://pkg.go.dev/cmd/go#hdr-Build_constraints.dmitshur commented on github.com/go-gl/glfw: GLFW v3.45d
Checking in on the status. @Geo25rey, would you like to keep pushing this forward? If so, there are some unresolved review comments that need to be addressed, otherwise this seems close. I've been us…dmitshur commented on golang.org/x/build/build/env: add rsync to some gomote images6d
(1 comment)
(And just `env:` as the prefix is enough, no need to include repo name in front. Not a big deal either way.)dmitshur reviewed +2 on golang.org/x/build/build/env: add rsync to some gomote images6d
Thanks.
(nit) Since this affects builders overall, not only gonotes:
```suggestion
build/env: add rsync to builder images for gomote
```
Here and below, please add a line explaining the motivation…dmitshur reviewed +2 on golang.org/x/build/internal/gomote: align golangbuild's and buildlet's work directory6d
Thanks.dmitshur fixed an issue cmd/go: TestScript/list_pkgconfig_error failures [consistent failure]6d
[CL 616336](https://go.dev/cl/616336) is submitted, nothing more to do here.dmitshur commented on golang.org/x/build/internal/task: replace reviewers parameter with release coordinators6d
(1 comment)
If it's okay to leave the issue unassigned if no coordinators are entered, then you can reuse `reviewersParam`, right? The only difference between `reviewersParam` and `releaseCoordinato…dmitshur reviewed +2 on golang.org/x/build/internal/gomote: extend gomote max timeout6d
Thanks.
has now?
Is it your intention to bump the timeout only when using golangbuild, and keep 24 hr when golangbuild isn't used?dmitshur commented on golang.org/x/build/cmd/coordinator/internal/lucipoll: update for new JSONPB field naming6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/gophers: change github user name6d
Thanks.
You could add this, to avoid future instances of meaningless multiple markers. There aren't any now.
```suggestion
if p.Bot {
panic(fmt.Errorf("*bot marker is set multiple times for …dmitshur commented on golang.org/x/build/cmd/watchflakes: fails to run after a build output property field gitilesCommit → gitiles_commit rename6d
The production instance isn't healthy yet:
```
$ kubectl get pods | grep watchflakes
watchflakes-deployment-7dd687d899-8rf75 0/1 CrashLoopBackOff 1876 (3m53s ago) 17d
```
@dr2chase …dmitshur commented on golang.org/x/build/cmd/golangbuild: potential send on closed channel during cleanup6d
Another instance reported at https://ci.chromium.org/b/8735636356859002161/infra, this time on windows/amd64. So this likely applies to all platforms rather than linux/ppc64le specifically.dmitshur commented on golang.org/x/build/internal/task: add release coordinator parameter1w
(1 comment)
Note that one of the fields of a Person is their GitHub username. See [here](https://cs.opensource.google/go/x/build/+/master:internal/gophers/gophers.go;l=18;drc=cf2ab8746449c0af3c48c37…dmitshur fixed an issue golang.org/x/build/cmd/golangbuild: also move or delete untested nested modules for run-tests-outside-repository check1w
Fixed in [crrev.com/c/5873674](https://crrev.com/c/5873674).
As a simple demonstration, [CL 615681](https://go.dev/cl/615681) contains a test that intentionally reaches across module boundary and …dmitshur opened a change golang.org/x/build/cmd/coordinator/internal/lucipoll: update for new JSONPB field naming1w
As of crrev.com/c/5875121, golangbuild switched to the new default
behavior of using 'proto' field naming (such as "gitiles_commit")
instead of using protobuf default names (such as "gitilesCommit").…dmitshur opened a change golang.org/x/mod/zip: add TestVoid1w
DO NOT REVIEW, DO NOT SUBMIT: This is a test.dmitshur reviewed +1 on golang.org/x/build/internal/task: create release tag and github release in vscode release1w
dmitshur reviewed +2 on golang.org/x/build/cmd/gomote: account for no-network builders1w
Hopefully changes/additions of behavior-changing properties like no_network are fairly rare, but it's still good to try to make this scale better. But I think this is pragmatic now.
Thanks.
My read…dmitshur commented on golang.org/x/build/cmd/watchflakes: look for both gitilesCommit and gitiles_commit1w
Moving myself to CC since this is already reviewed. Thanks.dmitshur commented on golang.org/x/build/cmd/watchflakes: fails to run after a build output property field gitilesCommit → gitiles_commit rename1w
One way to test it would be to run it locally; it should no longer run into the "repo mismatch" error.
You'll also know it works when you [deploy watchflakes with it](https://go.googlesource.com/bui…dmitshur reviewed +2 on golang.org/x/build/go.mod: update github.com/jackc/pgx/v4 to fix GHSA-mrww-27vc-gghv1w
Thanks.
Does 'go mod tidy' need to be run?dmitshur reviewed +2 on golang.org/x/build/internal/iapclient: handle authentication failures1w
Thanks.
Note that 'omitempty' option has effect when marshaling, no effect when unmarshaling.
In general it's slightly cleaner to disregard the `tokenRespErr` value if unmarshaling into it fails, b…dmitshur commented on golang.org/x/build/cmd/gomote: don't duplicate logic present in golangbuild in the repro subcommand1w
CC @golang/release.dmitshur reviewed +2 on cmd/dist: enforce the lowest bootstrap version1w
Thanks.
Done in PS 7.dmitshur opened an issue golang.org/x/build/cmd/watchflakes: fails to run after a build output property field gitilesCommit → gitiles_commit rename1w
Watchflakes is currently in a continuous crashloop:
```
$ kubectl logs -p watchflakes-deployment-7dd687d899-8rf75
watchflakes: 2024/09/24 12:12:43 ListBuilders
watchflakes: 2024/09/24 12:12:4…dmitshur reviewed +1 on golang.org/x/build/internal/task: add steps to build and publish package extension1w
(1 comment)
Thanks for clarifying this.dmitshur reviewed +2 on cmd/dist: enforce the lowest bootstrap version1w
Thanks.
It turns out that it might be more idiomatic to use 3-way Compare results by comparing with 0, instead of -1/1, so let's update this to be consistent with that practice:
```suggestion
if v…dmitshur reviewed +2 on golang.org/x/build/internal/task: add workflow to build internal security release branches1w
Thanks. Minor comments.
(minor) This looks like a sign that the `Version` field in `SecurityReleaseCoalesceTask` should be a pointer, so that dereferencing here isn't needed.
Probably better to use…dmitshur commented on golang.org/x/build/internal/task: add steps to build and publish package extension1w
(2 comments)
Being able to skip duplicate testing when you have assurance that it's already been done previously is great.
I don't entirely understand this change. If the constant string "s" is alw…dmitshur reviewed +1 on golang.org/x/build/internal/task: add release definition for vscode-go stable release1w
dmitshur commented on runtime: panic not generating a correct backtrace stack while crashing in cgo on ARM64 platform1w
Moving this issue to Go1.24 milestone to track investigating and fixing it at tip. If a backport is needed, please follow the https://go.dev/wiki/MinorReleases process to create backport issue(s).dmitshur reviewed +2 on cmd/go: skip TestScript on Plan 9 in short mode1w
Thanks.Earlier
dmitshur commented on os: file write permission ignored on linux trybots1w
In [build 8736249311634815793](https://ci.chromium.org/b/8736249311634815793) (a shard of a real linux-amd64 build on [CL 614296](https://go.dev/cl/614296), whose no_network property is true) TestCre…dmitshur commented on os: file write permission ignored on linux trybots1w
It's likely related that linux-386 and linux-amd64 builders are configured to run with a no-network check:
https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=527-532;drc=c29a1893e55…dmitshur opened an issue cmd/go/internal/modcmd: download with -json flag doesn't print JSON objects to stdout for some module download errors2w
### Go version
go version go1.23.1 darwin/arm64
### Output of `go env -changed` in your module/workspace
<details><br>
```sh
GOPROXY='http://127.0.0.1'
```
</details>
### What did…dmitshur fixed an issue golang.org/x/example/ragserver/ragserver: requires go1.23.0, so go1.22 builders are redundant with go1.23 builders2w
Fixed in [crrev.com/c/5869577](https://crrev.com/c/5869577).
Specifically, release branch builders (e.g. x_example-go1.22-linux-amd64) will now skip testing modules that have a go directive that's…dmitshur fixed an issue golang.org/x/build/cmd/golangbuild: propagate "infra failure" status from lower-level steps upwards2w
Fixed in [crrev.com/c/5869581](https://crrev.com/c/5869581).dmitshur starred github.com/immersive-web/WebXR-WebGPU-Binding3w
dmitshur closed an issue golang.org/x/build/cmd/gopherbot: add command to rebase CLs3w
Gerrit now provides an ability to rebase on behalf of the original CL author, which doesn't require Forge Author permission. See [here](https://groups.google.com/g/repo-discuss/c/NeSb-YI5mQM). Can yo…dmitshur fixed an issue golang.org/x/build/cmd/coordinator: write_go_bootstrap_tar failing with 404 on some arm builders3w
Closing this again since the original problem with write_go_bootstrap_tar failing with 404 is resolved, the only currently connected legacy plan9 builder (plan9-arm) is working okay with a go1.22.6 b…dmitshur commented on golang.org/x/build/cmd/coordinator: write_go_bootstrap_tar failing with 404 on some arm builders3w
> I sent [CL 608155](https://go.dev/cl/608155) to [remove known issue], and [CL 607656](https://go.dev/cl/607656) to mark them as migrated [which stops coordinator from sending them work].
I haven…dmitshur closed an issue golang.org/x/build/env: host-plan9-386-gce (VM Image: plan9-386-v7)3w
I don't think anyone has plans to resume work on this, and there is a working plan9/386 LUCI builder tracked in #63599. Closing this in favor of that issue.dmitshur commented on golang.org/x/build/env: host-dragonfly-amd64-622 (VM Image: dragonfly-amd64-622)3w
CC @golang/dragonfly.dmitshur commented on internal/trace: TestTraceStress failing on openbsd-386-72 builders3w
It is possible the builder resource limits are not sufficient for the increased demands. Increasing memory (if it's viable, given it's 32-bit) might help, but that kind of builder maintenance work is…dmitshur fixed an issue golang.org/x/*: define module boundaries for all the repos under golang.org/x/3w
Indeed, I think we can consider this done. Thanks.dmitshur commented on build: ios trybot builders failing3w
Thanks for reporting.
It looks like this builder provides its own bootstrap at /var/root/go-ios-arm64-bootstrap, and its version go1.20.6 is too low for tip. Go tip (1.24 to be) has a minimum boot…dmitshur commented on github.com/golang/vscode-go/process: migrate CI from Kokoro to LUCI3w
Adding some relevant notes here.
[CIPD](https://chromium.googlesource.com/infra/luci/luci-go/+/refs/heads/main/cipd/README.md) as used by LUCI builders already has an existing package providing No…dmitshur commented on golang.org/x/build: support x/playground tests that need additional dependencies3w
Agreed – if achieving x/playground's testing needs can be made to work without the Docker dependency, that path would be great. Recently @hyangah is exploring a similar direction for vscode-go's te…dmitshur commented on golang.org/x/playground: simplify development and testing3w
Tracking issue #66002 is related.dmitshur commented on syscall: TestAmbientCapsUserns fails on Ubuntu 24.04/Linux 6.8.03w
@mengzhuo Thanks for requesting this backport. We already reviewed it, but a note for future: https://go.dev/wiki/MinorReleases says "The [backport] issue should include a link to the original issue …dmitshur closed an issue cmd/go: support `git/subcommand` invocations for git9 on plan93w
dmitshur starred github.com/josephburnett/jd3w