Activity

Yesterday
(3 comments) It's not the end of the world to mail 2 individual CLs instead of one, but we have generally been combining them with the current process (e.g., see CL 348869), and it results in le…
(3 comments) Done. Removed the return statement to make it less confusing. The documentation says 409 is only used in this one case. I don't want to hardcode what looks like an error message t…
(3 comments) Ok, I'll change it to describe doArg rather than enumerate things that implement it. The if statement is currently a no-op that exists only to hold a TODO comment inside. Removing …
Accept "Y" in addition to "y", and don't print a verbose stack trace. This change is based on past experience described in golang/go#36948. Fixes golang/go#36948.
This Week
I've resolved the remaining threads, they're all okay to follow up in future changes as needed. Submitting. You should be able to start connecting the builders after the next coordinator dep…
I think it is reasonable to deprecate godoc in favor of a newer in command x/pkgsite that is actively maintained and provides better support for modern features like versions, generics. We should al…
This issue is likely a subset of #40371. <details><summary>Environment Details</summary> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.17.1 darwin/…
PS 3 looks good, see 3 comments. s/us-central/us-central1/ IIUC. Add a doc comment that specifies what this method does. &gt; Deleted. It&#39;s not deleted in the Patch Set 3, the latest pushed P…
Woohoo, it&#39;s nice when fewer things need to explicitly configured in each deployment.
dmitshur reviewed +2 on golang.org/x/build/cmd/gcpinit: delete2d
(1 comment) The purpose of the command is to help initialize a cluster in a reproducible way. It does fewer things now than it used to in the past (e.g., it no longer initializes metrics as of CL 30…
(1 comment) Since the new name of this cluster is &#34;services&#34;, we may find this comment easier to understand if it&#39;s updated to refer to it as the services cluster. (The field name can b…
(2 comments) What&#39;s the motivation of changing the control zone? (I didn&#39;t find an answer in the commit message.) I don&#39;t know what value comment is providing, but if keeping it, this p…
By now, GitHub Discussions are being tried out in the Go project to a limited degree. See https://github.com/golang/go/discussions/47139.
(2 comments) The path prefix can be more specific than &#34;all&#34;: go.dev/_content/blog: fix embedded videos in two posts The PR subject will need to be updated as described at https://…
Closing because the URL is working by now. (Also, blog content moved to x/website/blog.)
Closing since golang/go#38532 is closed, and blog content moved to x/website/blog.
(1 comment) (And here.)
(1 comment) Maybe fix the label while here. It should use &#39;=&#39; not space between key and value. (Spotted by Alex recently.)
Thanks for the ping. This looks good, though having those env vars explicitly listed is not a problem. But if you prefer to remove them, since they&#39;re also set to the same value on the reverse bu…
Thanks, feel free to submit when ready from your side.
(3 comments) I don&#39;t know what effect it has, but the name of milestone 168 on GitHub and here are slightly different: &#34;pkgsite/license&#34; &#34;pkgsite/licenses&#34; Maybe one of…
Thanks. Let’s also update this to keep wording consistent with the change made in CL 326330: &lt;a href=&#34;/cmd/go/#hdr-GOPATH_and_Modules&#34;&gt;GOPATH&lt;/a&gt;&#39;s
Last Week
dmitshur starred in github.com/mystor/git-revise6d
(1 comment) Maybe this comment is worth keeping? It makes it easier for future maintainers of this Dockerfile to see this line is an optimization, rather than a necessary part of the build process. …
(2 comments) Makes sense to me, thanks. If it&#39;s still an applicable TODO, keeping it is fine with me. Thanks.
(2 comments) Maybe adding motivation here will make it easier to tell that it&#39;s an intentional change despite its effect on iterative docker building speed: &#34;... because it&#39;s easier …
(2 comments) I rarely &#34;iterate&#34; when building docker images (I usually iterate without involving Docker) so I&#39;m not familiar with what optimizations work well or not. If I understand co…
Create a new service account, and move the deployment over to the prod namespace. Also update the build image to Go 1.17. For golang/go#48263.
(1 comment) Nit: No need to insert a colon here, just &#39;Fixes golang/go#44240&#39; will be consistent with style described in https://golang.org/doc/contribute#ref_issues.
@ifamakes I've checked the `Distribution` file in go1.17.darwin-arm64.pkg, and it still has `hostArchitectures="arm64"` set, so that hasn't regressed on our side. Since this issue has been closed fo…
I understand the scope of this issue is x/pkgsite, and I don't mean to change that. I'll point out that a similar issue may apply to x/website, though golang.org serves documentation under a signi…
The problem turned out to be a misconfigured use of `autocert` (not enabling `acme.ALPNProto`, and not using `HTTPHandler`), which prevented gerritbot's HTML "hello" page from being served. [CL 34843…
@davidkarlsen Something like this should work: ```Go variables := map[string]interface{}{ "somekey": (*githubv4.String)(nil), // or another concrete type instead of String // ... } ```
With the 5 CLs above, we're in good shape for early in cycle. Removing that label to revisit this closer to the code freeze.
dmitshur pushed to master in github.com/shurcooL/httperror1w
9bb3cabb3d153353a5ca771ba6c403dd0b481764use errors.As instead of type assertion in IsError functions
dmitshur pushed to master in github.com/shurcooL/httperror1w
Earlier
This seems to happen occasionally, suggesting the test is flaky: ``` --- FAIL: TestParallelism (0.15s) workflow_test.go:122: task sleep #1 : started workflow_test.go:122: task sleep #2…
@timothy-king Correct. Go 1.17 and 1.16 do not have this problem.
Sounds good. Please include a small test in x/crypto that this package doesn't import `fmt`, so this property doesn't accidentally regress without the benefit of go/build's test.
The `curve25519` package imports `fmt` and uses it 3 times: ```Go return nil, fmt.Errorf("bad scalar length: %d, expected %d", l, 32) return nil, fmt.Errorf("bad point length: %d, expected %d", …
Bisection shows this problem is introduced in [CL 338529](https://golang.org/cl/338529): ``` $ (cd cmd; go get -d golang.org/x/tools@3fce476f0a782aeb5034d592c189e63be4ba6c9e && go mod tidy && go …
There is a problem on tip when the vendored x/tools module is updated to its latest master pseudo-version (as part of #36905). ### What did you do? ``` $ git clone https://go.googlesource.com/…
The fix that closed this issue landed into master branch, which is where Go 1.18 development is happening, so moving this issue to the Go1.18 milestone. (The 1.17 backport issue #47854 is in 1.17.1 m…
This issue was closed in NeedsInvestigation state without a fix, but if a fix were to be made, it would need to target Go 1.18 first. Since this isn't a [backport issue](https://golang.org/wiki/Minor…
Also CC @changkun, @hajimehoshi.
cmd/coordinator has been redeployed, so the reverse builder should be able to connect. It’s visible at https://farmer.golang.org now: > host-linux-riscv64-unmatched: 0/0 (1 missing)
Thanks for fixing this @changkun. Closing.
dmitshur starred in github.com/gonutz/d3d92w
Now that Go 1.17 is released (and thus 1.15 has become unsupported), there shouldn't be a reason not to do this. Also see discussion in #47952.
This issue was not really resolved, but `golang.org/x/build/cmd/tip` was deleted in [CL 343449](https://golang.org/cl/343449), so closing.
Now that Go 1.17 is released and Go 1.15 in unsupported per [release policy](https://golang.org/doc/devel/release#policy), we should update documentation of [`golang.org/dl/go1.N` commands](https://p…
Go 1.16 isn't affected, so this backport issue isn't needed.
CC @jayconrod.
dmitshur pushed to master in github.com/shurcooL/home2w
e98364ec944d232c9592f89e7852d36498986f9cindieauth: update for specification changes in 2020
7d2d26741fa3ac8e689c88abdcdb3d649096f368remove repoInfoContextKey
I understand the Go language specification is vague for the reasons Rob suggested, allowing different implementations of the Go language to implement them as most appropriate. The behavior of Go…
I think this issue can be fixed by changing go.dev's playground.js script as follows: ```diff -$.ajax('/compile', { +$.ajax('https://play.golang.org/compile', { ``` _(Source: [go.dev/_conten…
It's likely Go 1.15 was shown because a frontend fetch failed, or JavaScript execution is disabled. The relevant code is: ```JS async function getLatestVersion() { let version = 'go1.15'; //…
@mengzhuo A key's been provided via email. Patch set 2 of [CL 329489](https://golang.org/cl/329489) looks good, please submit it when you're ready, and after the following cmd/coordinator deploy the …
@mengzhuo Excellent, let's proceed then, thank you again. CL 329489 is reviewed, can you address the remaining comment on it, and submit it? After that, I'll redeploy coordinator, which will allow th…
I've repeated this exercise using the `windows-arm64-10` builder, and the green-screens no longer happen reproducibly. I've still observed at least 1 instance out of 5 runs, filed #47965 for that. …
Breaking this out from #47017 as a narrower issue for tracking any investigation purposes. There still seems to be some instances where running all.bash sequentially (i.e., without any sharding) o…
During the 1.18 dev cycle, using the `go` binary not from the tip checkout can cause `go mod tidy` step to fail: ``` > go mod tidy command failed: exit status 1 go mod tidy: go.mod file indicat…
At this time the `updatestd` command updates all golang.org/x versions to latest available when it is run. If run fairly infrequently (e.g., twice per cycle, so every 3 months), there can be many cha…
Thanks for verifying. Closing as fixed (see related issue #47808 which has more details). (Thanks for fixing @rsc!)
CL 344289 will fix the problem due to redirection.
tip.golang.org is served by x/website/cmd/golangorg as of [CL 335049](https://golang.org/cl/335049), and we need to update this health check. It still points to a /_tipstatus URL, which isn't served …
These builders are used by Go releases right now. Go 1.17 and 1.16 are documented to require Windows 7 or newer. Before we can remove the builders, we need to start using a newer builder for releases…
CC @jamalc, @rsc.
Sent [CL 343449](https://golang.org/cl/343449) that deletes the code. I plan to submit it after stopping the service.
There seems to be a problem in `pushIssues` for major releases. It's documented to move issues for major releases: ```Go // pushIssues moves open issues to the milestone of the next release of th…
Thanks for reporting and bisecting @fgm. CC @rsc as the author of [CL 339403](https://golang.org/cl/339403).
This is likely introduced by recent x/website changes. @rsc Can you take a look?
This issue is similar to https://github.com/golang/go/issues/47751#issuecomment-900451045. The problem is also present as of CL 339403, not present in the one before. It's temporarily mitigated be…
Thanks for reporting. The last good version was golang/website@f8f1822, rolled back golang.org to that. The problem is introduced with the following commit, golang/website@ef7fed48ece033b41e88e…
Thanks for reporting. CC @rsc.
The x/website/cmd/golangorg server became able to serve the tip.golang.org website as of CL 335049, and it is actively doing so now that the corresponding DNS change has propagated. (Proof: https:…
dmitshur commented on gerrit: support "mergeable" queries1mo
From looking at other Gerrit instances like https://gerrit-review.googlesource.com/q/is:mergeable, https://chromium-review.googlesource.com/q/is:mergeable, it appears that this option is not generall…
Go 1.17 has been released, and so Go 1.15 is no longer supported per the [release policy](https://golang.org/doc/devel/release#policy). Closing.
Approved as a documentation fix for a new-to-Go-1.17 API. Only 1.17 needs this backport.