Activity
Yesterday
dmitshur commented on cmd/compile: allow parameterized type aliases to omit redundant type parameters4h
CC @golang/compiler.dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: coalesce a package-level failure to a test failure in the same package6h
Thanks.
This seems like an improvement to me. Sounds good to update the few existing issues, thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: add -build flag for analyze a single build6h
Thanks. Just minor comments.
Maybe while you're here:
```suggestion
if b.GetBuilder().GetBuilder() != bName { // coherence check
```
(I realize the code is just moving, so this is optional.)
If …dmitshur commented on golang.org/x/tools/x/tools: update go.mod to 1.22 and gopls to go1.237h
That configuration lives on the `luci-config` branch of x/build, in `GO_BRANCHES` and `EXTRA_GO_BRANCHES`:
https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=536-565;drc=5953629ed4eeb…dmitshur opened a change doc/next: introduce a problem (to see if it can be caught)9h
DO NOT REVIEW
DO NOT SUBMIT
Testing out an idea for checking links for problems (such as using
an absolute link instead of relative, non-canonical URLs, bad HTML,
and so on).dmitshur commented on crypto/tls: expose extensions presented by client to GetCertificate10h
(1 comment)
Please move this file to a directory called 'next' and rename to 32936.txt.
See https://cs.opensource.google/go/go/+/master:api/README;l=17-23;drc=600225f83f7846b1129af94253f5172a359c308…dmitshur reopened an issue golang.org/x/build: gotip-freebsd-riscv64 builder is in quarantined state10h
The bot is currently missing, last seen 11h 54m ago. CC @mengzhuo.dmitshur commented on golang.org/x/perf/cmd/benchstat: generate partial comparisons if some of the tests timeout on a particular Go version 10h
CC @golang/runtime.dmitshur commented on golang.org/x/build/dashboard: stop running remaining ported builders12h
Thanks.dmitshur opened a change golang.org/x/build/dashboard: stop running remaining ported builders12h
The gradual shutdown has gone smoothly and can be applied
to a couple more remaining builders that have been ported.
Fixes golang/go#67761.dmitshur reviewed +2 on runtime: remove darwin-amd64-10_14 builder check13h
Thanks.dmitshur opened a change net: unskip TestUDPZeroBytePayload on Darwin13h
From information we have available in the issue, this test was flaky
on OS X 10.10 but not newer. By now macOS 11 is the minimum required
version, and 1000 local runs of the test passed, so try to un…dmitshur commented on golang.org/x/build/internal/task: add definition for releasing go pls14h
Thanks, this is a great start! Left some inline comments, I think this should be ready once they're addressed.
This CL is a part of a larger work, and it helps to have an issue associated with it fo…dmitshur commented on golang.org/x/crypto/ssh: add support for unpadded RSA signatures14h
(Marking thread unresolved for visibility.)dmitshur commented on net/http: match os.File.Readdir behavior in DotFileHiding14h
This looks ready. Submit?dmitshur commented on golang.org/x/build/main.star: mark darwin-amd64 host as slower14h
(1 comment)
Thanks for clarifying. Added a brief note here too.dmitshur commented on golang.org/x/build/main.star: mark darwin-amd64 host as slower15h
(1 comment)
The fact that timeout scaling is multiplicative is mentioned as part of make_run_mod ("Compose timeout scaling factors by multiplying them", around line 700). Did you already see that bu…dmitshur closed an issue cmd/compile: panics with generic type alias and based-on constraint [1.23 backport]15h
@cuonglm Please note the second paragraph of https://groups.google.com/g/golang-dev/c/or4BmCu3LIE/m/a1Hv1yoxBAAJ, copied here:
> Any CLs that land after [CL 600176](https://go.dev/cl/600176) ("int…dmitshur commented on mime: incorrect mime-type for .mjs files on windows (text/plain instead of application/javascript)15h
CC @neild.dmitshur opened a change golang.org/x/build/main.star: mark darwin-amd64 host as slower15h
We're aware of an issue where the current darwin-amd64 hosts are slower
than we expect, primarily in the context of the darwin-amd64-longtest
builders. Various cmd/go tests often end up failing with …dmitshur commented on golang.org/x/build/cmd/coordinator: stop using internal module proxy16h
Thanks.dmitshur commented on golang.org/x/build/cmd/gopherbot: fix repository reference in "close luci-config issues"16h
Thanks.dmitshur commented on golang.org/x/build/main.star: re-enable misccompile builders everywhere but x/oscar16h
Thanks.This Week
dmitshur commented on golang.org/x/build/main.star: remove linux-amd64-typesalias for Go 1.23 onwards1d
Thanks.dmitshur opened a change golang.org/x/build/main.star: remove linux-amd64-typesalias for Go 1.23 onwards1d
Setting gotypesalias=1 is a no-op in Go 1.23 onwards, so constrain
the builder to exist only for 1.22 and older.dmitshur commented on golang.org/x/build/main.star: re-enable misccompile builders everywhere but x/oscar1d
(1 comment)
This change is ready for review.
To help a bit with review, PS 1 of this change was a pure revert, so you might want to look at the diff of PS 1 and PS 2 to see only x/oscar misccompile…dmitshur opened a change golang.org/x/build/main.star: re-enable misccompile builders everywhere but x/oscar1d
CL 597335 intended to disable the misccompile builder for x/oscar repo.
It did so successfully, stopping the misccompile builder from running
both in pre-submit (by default) and in post-submit in tha…dmitshur reviewed +2 on cmd/compile/internal/types: fix typo in comment1d
dmitshur reviewed +2 on cmd/compile/internal/types: fix typo in comment1d
Thanks.
Done in PS 3.
Done in PS 4.dmitshur commented on cmd/compile: emit tail call wrappers when possible1d
@khr@golang.org You +2ed this but this was previously waiting for the tree to reopen. Submit now?dmitshur opened a change golang.org/x/build/cmd/coordinator: stop using internal module proxy1d
We want to migrate from Global DNS for VMs to Zonal DNS, which is more
resilient. The only known use of Global DNS in the x/build GCP project
is the internal module proxy.
This was previously needed…dmitshur closed an issue golang.org/x/build/cmd/watchflakes: shouldn't reopen frozen issues1d
I agree, the auto-archival of closed issues without recent activity likely removes the main source of this happening. Let's not do anything for now unless we find out this is still a problem somehow.…dmitshur merged a change golang.org/x/build/cloudfns/{sendwikidiff,wikiwebhook}: delete1d
dmitshur commented on golang.org/x/build/cloudfns/{sendwikidiff,wikiwebhook}: delete1d
Thanks.dmitshur commented on golang.org/x/build/cloudfns/wikiwebhook: wiki updates reporter does not report deleted pages1d
Fortunately Gerrit supports setting up [notifications](https://go-review.googlesource.com/settings/#Notifications) for the wiki repo for all changes, including those that involve deleting pages:
!…dmitshur commented on x/build/cloudfns/{sendwikidiff,wikiwebhook}: remove1d
For posterity and in case we need to restore this or setup something similar in the future:
- deleted a [webhook](https://github.com/golang/go/settings/hooks) sending "Wiki" events only to `https:…dmitshur opened a change golang.org/x/build/cloudfns/{sendwikidiff,wikiwebhook}: delete1d
The need for this setup has been made obsolete via wiki move to Gerrit,
proposal golang/go#61940.
Fixes golang/go#64730.
Fixes golang/go#55263.
Fixes golang/go#33187 (obsolete).dmitshur reviewed +2 on golang.org/x/website/_content: add anchor links to article headers1d
Thanks.
It would be nice to finish CL 342610, but perhaps it's a bit unrealistic to forbid HTML from being used at all.
FWIW, since Markdown does get rendered to HTML in [golang.org/x/website/inter…dmitshur commented on runtime/cgocall: severe performance drop for cgo calls in go1.22.51d
CC @golang/runtime.dmitshur opened a change golang.org/x/build/cmd/gopherbot: fix repository reference in "close luci-config issues"1d
I anticipated that the commit link would need to be absolute, since
commits to the luci-config branch get mirrored to a different GitHub
repo than where the issue is being closed, but accidentally po…dmitshur commented on golang.org/x/build/main.star: unpin golangbuild version1d
Thanks.dmitshur commented on golang.org/x/build/main.star: mark aix-ppc64 as fixed capacity2d
Thanks.dmitshur commented on golang.org/x/crypto/ssh: add support for unpadded RSA signatures2d
@filippo@golang.org or @roland@golang.org Does this change look okay to you too? Thanks.dmitshur commented on cmd/go: in 1.23rc2, TestScript fails on Windows when GOEXPERIMENT is set: "go was invoked but no counters were incremented"2d
CC @matloob, @findleyr.dmitshur commented on net/http: get-request with wrong content-length header breaks context2d
CC @neild.dmitshur commented on golang.org/x/tools/internal/refactor/inline: offer an option to inline all calls in a file2d
CC @adonovan.dmitshur commented on cmd/go: print file name when showing an import cycle2d
@matloob https://go.dev/wiki/HandlingIssues suggests issues should have one of the Needs{Investigation,Decision,Fix} labels after they're triaged. Removing NeedsInvestigation without adding something…dmitshur commented on : build failure >= 1.18 on windows arm322d
Thanks for reporting. It's possible this port might have broken, as we don't have a builder to test it (issue #67308).
Are you able to test whether this issue reproduces at tip if you use a newer …dmitshur commented on golang.org/x/build: add LUCI windows-arm builder2d
CC @zx2c4, @golang/windows.dmitshur commented on golang.org/x/build/main.star: unpin golangbuild version2d
(1 comment)
I fell back to this after not finding a way to do it with 'led edit', but maybe I missed something.dmitshur opened a change golang.org/x/build/main.star: unpin golangbuild version2d
This reverts the temporary change applied in CL 596815.
By now golangbuild has a workaround added to it in crrev.com/c/5730108.
Tested with:
$ led get-build -real-build 8741505627666329441 \
| sed …dmitshur commented on golang.org/x/build: add LUCI aix-ppc64 builder2d
Thanks. Here's the certificate: [aix-ppc64-power8-1721862086.cert.txt](https://github.com/user-attachments/files/16368164/aix-ppc64-power8-1721862086.cert.txt).dmitshur commented on golang.org/x/build: add LUCI aix-ppc64 builder2d
@pmur I see you've edited that post, replacing `-` with `_`. You were likely thinking of builder names, where underscores are indeed used to separate the OS version and/or runmods. But for hostnames …dmitshur opened a change golang.org/x/build/main.star: mark aix-ppc64 as fixed capacity2d
For golang/go#67299.dmitshur reviewed +2 on golang.org/x/build/retrybuilds: rewrite tool to support LUCI2d
Thanks! The general approach makes sense and looks good. Just minor comments.
```suggestion
cmd/retrybuilds: rewrite tool to support LUCI
```
Needs updating/re-generating. (You can use x/build/upda…dmitshur reviewed +2 on golang.org/x/build/internal/gopher: add hxjiang to gophers2d
(2 comments)
Rebasing past CL 600735 should fix the trybot failures.
(optional nit while you're here)
```suggestion
internal/gophers: add hxjiang to gophers
```
To match the directory name.dmitshur reviewed +2 on go.dev/wiki/DashboardBuilders: put < and > in code span2d
This change is ready for review.dmitshur opened a change go.dev/wiki/DashboardBuilders: put < and > in code span2d
Otherwise it's interpreted as HTML and doesn't get rendered.dmitshur reviewed +2 on golang.org/x/build/internal/gopher: add hxjiang to gophers2d
Thanks.
Since your @golang.org is your primary Gerrit email, you'll want to list it first (before the @google.com one).dmitshur commented on doc/next: use relative link to Go issue2d
Thanks.dmitshur opened a change doc/next: use relative link to Go issue2d
The Go release notes are served on multiple domains (go.dev,
golang.google.cn, tip.golang.org, localhost:8080 and so on), so links
pointing to the Go website itself need to be relative to work in all…dmitshur reviewed +2 on golang.org/x/build/cmd/gomote: handle internal/runtime/sys move2d
(2 comments)
This part was just handled by CL 600735, but the devapp change here still looks good. Thanks.
Consider also adding:
For golang/go#65355.dmitshur commented on golang.org/x/build/cmd/gomote: update isGoToolDistGenerated for internal/runtime/sys move2d
Thanks for making that in advance; I missed that it already existed, sorry.
Please go ahead, though since this had Auto-Submit+1 it's already submitted too. Thanks.dmitshur opened a change golang.org/x/build/cmd/gomote: update isGoToolDistGenerated for internal/runtime/sys move2d
The internal runtime package sys moved in CL 600436. Update the list of
dist-generated files accordingly.
runtime/internal/sys/zversion.go is left behind for the same reason as
written in the commit…dmitshur closed an issue cmd/trace/v2: pprof profiles always empty2d
Closing in favor of #66782, since this is already fixed in Go1.23.
([CL 600275](https://go.dev/cl/600275) included "Fixes #68542" but cherry-pick CLs only close cherry-pick issues automatically, n…dmitshur commented on cmd/trace/v2: pprof profiles always empty [1.22 backport]2d
We reviewed in a meeting and agreed to backport this. Thanks.dmitshur commented on all: user-facing golang.org/x repos need to stay green2d
Right now x/build and x/website are red:
- #68574
- #68575
Neither of those are blocking Go 1.23 (the current milestone of this recurring issue).
We reviewed this in this week's release wee…dmitshur opened an issue golang.org/x/website/cmd/golangorg: TestAll failing as of CL 5889772d
```
=== RUN TestAll
server_test.go:215: GET https://go.dev/doc/go1.24: found link to https://go.dev/issue/67699, should be /issue/67699
server_test.go:215: GET https://go.dev/doc/next: f…dmitshur opened an issue golang.org/x/build/cmd/gomote: TestIsGoToolDistGenerated failing as of CL 6004362d
```
=== RUN TestIsGoToolDistGenerated
push_test.go:70: Checking generated files in /home/swarming/.swarming/w/ir/x/w/goroot/src/.
push_test.go:111: src/cmd/cgo/zdefaultcc.go: "// Code ge…dmitshur commented on golang.org/x/sys/unix: update to Linux kernel 6.102d
Thanks.dmitshur commented on cmd/go: fix TestNewReleaseRebuildsStalePackagesInGOPATH for runtime move3d
Thanks.dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle3d
[CL 600535](https://go.dev/cl/600535) did the early-in-cycle update for Go 1.24.
(Also sent [CL 600596](https://go.dev/cl/600596) to update a pprof dependency.)
Removing that label to revisit this …dmitshur commented on runtime: move runtime/internal/sys to internal/runtime/sys3d
Sent CL 600595.dmitshur opened a change cmd/go: fix TestNewReleaseRebuildsStalePackagesInGOPATH for runtime move3d
CL 600436 moved runtime/internal/sys to internal/runtime/sys and updated
TestNewReleaseRebuildsStalePackagesInGOPATH in part accordingly. This is
the other part that's needed for it to pass.
For #65…dmitshur commented on all: update vendored dependencies3d
Left a comment on [CL 600436](https://go-review.googlesource.com/c/go/+/600436#message-8) about the TestNewReleaseRebuildsStalePackagesInGOPATH failure.dmitshur commented on runtime: move runtime/internal/sys to internal/runtime/sys3d
The cmd/go.TestNewReleaseRebuildsStalePackagesInGOPATH test is failing (e.g., https://ci.chromium.org/b/8741595849470417761). Is it a matter of updating the test case or is there more to do? Please f…dmitshur opened a change all: update vendored dependencies3d
The Go 1.24 development tree has opened. This is a time to update
all golang.org/x/... module versions that contribute packages to the
std and cmd modules in the standard library to latest master ver…dmitshur reviewed +2 on golang.org/x/build/main.star: sort longtest project+path list3d
No worries, it was really minor, and thanks.dmitshur commented on golang.org/x/build/main.star: enable longtest builders on x/benchmarks for sweet3d
(1 comment)
(Also, while you're here, could keep these sorted.)dmitshur reviewed +2 on golang.org/x/build/main.star: enable longtest builders on x/benchmarks for sweet3d
Thanks.
Optionally:
```suggestion
"sweet/.+[.]go",
```dmitshur commented on golang.org/x/build: add LUCI aix-ppc64 builder3d
CC @golang/aix.dmitshur commented on all: reopen tree for Go 1.24 development3d
@thanm That generally happens as part of issue #36905 which is early-in-cycle and we'll get to soon. It's fine to do it separately even sooner if needed.dmitshur commented on golang.org/x/build: AIX builders fail with "unknown directive "Disconnected" "3d
Thanks for finding that. Note that x/oscar is defined PT.TOOL, a repository intended to only be tested on a few first-class platforms like Linux/Windows/macOS, in the LUCI build configuration (see [h…dmitshur closed an issue all: reopen tree for Go 1.24 development3d
The tree is now open. See [announcement](https://groups.google.com/g/golang-dev/c/or4BmCu3LIE/m/a1Hv1yoxBAAJ) on golang-dev. Thanks.dmitshur commented on runtime: remove VZEROUPPER in asyncPreempt on darwin/amd643d
Thanks.dmitshur commented on golang.org/x/build: perf builders are failing to build cockroachdb for baseline at tip3d
@mknyszek I looked only very briefly, but isn't the problem that the baseline toolchain is something like 1.22 so the constraints in runtime_go1.20_21_22.go match, but because sweet now sets the `unt…dmitshur opened an issue golang.org/x/build: perf builders are failing to build cockroachdb for baseline at tip3d
The gotip-linux-amd64_{c2s16,c3h88}-perf_vs_release builders are failing at tip due sweet running into an error building cockroachdb for baseline:
```
[sweet] error: build cockroachdb for baselin…dmitshur commented on golang.org/x/build/cmd/golangbuild: wrapped command invocation is broken on Windows4d
Sent [crrev.com/c/5730108](https://crrev.com/c/5730108) to work around the problem, to unblock golangbuild development while is go1.22.6 isn't released yet.dmitshur commented on all: reopen tree for Go 1.24 development4d
There were about 7 CLs that were already approved and marked AutoSubmit+1, but blocked on wait-release. They're now in. I'll wait to see the results on the post-submit dashboard and follow up before …dmitshur commented on golang.org/x/build/cmd/relui: initialize Mastodon, Swarming, Buildbucket clients on demand4d
(1 comment)
This is due to a constraint of the Go language syntax. Without the parentheses, the '{' for the composite literal and the '{' for the if statement overlap. Putting the composite literal …dmitshur commented on golang.org/x/build/cmd/relui: initialize Mastodon, Swarming, Buildbucket clients on demand4d
Thanks.dmitshur closed a change golang.org/x/tools/nillness: updated wrong internal code comment4d
The same change was applied in CL 595895, so rebasing this made this CL empty. Nothing more to do here, closing.dmitshur closed an issue golang.org/x/tools/go/analysis/passes/nilness: wrong internal code comment // "x is nil, y is unknown"4d
Thanks for pointing that out.
Fixed by [CL 595895](https://go.dev/cl/595895).dmitshur opened a change golang.org/x/website/_content/doc: add go1.24.md placeholder4d
Add this file now so that it's possible to preview the latest release
notes draft at https://tip.golang.org/doc/go1.24, and to include that
link in the tracking issue. Based on CL 588057 that did thi…dmitshur commented on cmd/trace/v2: pprof profiles always empty [1.22 backport]4d
This problem doesn't affect Go 1.21, only 1.22, because it's related to https://go.dev/doc/go1.22#trace changes, is that right?dmitshur commented on all: [release-branch.go1.23] merge master (5e8a731) into release-branch.go1.234d
(1 comment)
In PS 2, updated to pull in 2 more CLs that landed before the "goversion bump" CL.dmitshur commented on internal/goversion: increment Version at start of cycle4d
[CL 600176](https://go.dev/cl/600176) did this for Go 1.24; moving to the next milestone.dmitshur reopened an issue flag/flag.go panic: runtime error: index out of range [0] with length 04d
dmitshur commented on cmd/trace/v2: pprof profiles always empty4d
CC @golang/runtime via [owners](https://dev.golang.org/owners).dmitshur commented on all: [release-branch.go1.23] merge master (f0de94f) into release-branch.go1.234d
(1 comment)
This change is ready for review.
I read over the list of changes to confirm they're all intended for 1.23 and okay per freeze policy, didn't spot any problems.