This Week
dmitshur commented on Link to demo movie is broken. in github.com/audreylim/go-presenter1d
The domain (and port) has changed. The following updated link should work: http://instantshare.win/1vs4fiwjm924q.mov
dmitshur commented on Handle 1.x as a pattern correctly in github.com/travis-ci/gimme2d
Friendly ping; my Travis build is still failing because of #152, so I'd really like to help fix it if there's anything I can do.
Last Week
dmitshur commented on Transfer request has incorrect json… in github.com/google/go-github1w
Thanks for following up on this @juliaferraioli! As an aside, I got a chance to use the Repository Transfer API recently (I changed my GitHub username and wanted to move all my repos under old nam…
dmitshur pushed to master in github.com/google/go-github1w
e96f1f1b07a5be7cba161bc7c1fd636044bfd75cUse "team_ids" JSON name for TransferRequest.TeamID field (#947)
dmitshur commented on Add support for the repository tran… in github.com/google/go-github1w
I just noticed now, I think `json:"team_id,omitempty"` should've been `json:"team_ids,omitempty"`, isn't that right? From https://developer.github.com/v3/repos/#transfer-a-repository: ![image](…
dmitshur commented on Issue when using a null parameter in github.com/shurcooL/graphql1w
Thanks for reporting this. `graphql` shouldn't panic, and I will fix that. But I suspect I see what the issue is. You're not specifying the exact pointer type for the nil variable. You should do t…
dmitshur commented on Handle 1.x as a pattern correctly in github.com/travis-ci/gimme1w
Issue is #152 is affecting me too, so I'm looking forward to a resolution. What is needed to make progress on this PR? /cc @meatballhat I'm happy to help if there's anything I can do. Thanks!
dmitshur pushed to master in github.com/shurcooL/vfsgen1w
62bca832be04bd2bcaabd3b68a6b19a7ec044411cmd/vfsgendev: Clean up computeDoc implementation.
dmitshur pushed to master in github.com/shurcooL/cmd1w
f4d6041a8168fe0eb6558ed6d413e96a71ef94c5gorepogen: Clean up computeDoc implementation.
dmitshur pushed to master in github.com/shurcooL/home1w
05b5de335638250d907d9bf2decb5dfc219dd76einternal/code: Compute full package documentation automatically.
0c473b6149ddaed0f3937e84aec8635255b1e3dfinternal/code: Add darwin/amd64 fallback env for package loading.
0457bc74a32e2bd03cab9688436c118d10a9765chttputil: Don't gzip for status codes that can't have body.
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
Thank you for working on this PR @yml. It has helped us better understand what it looks like to add Wasm support to this package and how viable it was to reuse the existing `dom` API. We found out th…
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1w
The import path was concenived with `vgo` in mind, but for now, I pictured it as just a normal directory named `v2` containing a `dom` package in the same repository. If I understand correctly, it s…
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1w
Agreed. @dominikh How do you feel about a `dom` v2 API at the import path `honnef.co/go/js/dom/v2` (package name `dom`)? The API would be the same as v1, except current `js` fields would be rep…
dmitshur starred github.com/browsh-org/browsh1w
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
Sorry, I missed that part of your comment.
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1w
I think I've found a potentially show-stopping problem with implementing this issue. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many obj…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
However, I think I've found a potentially show-stopping problem. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many objects. E.g.: https…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
> I did all the changes mentioned above. Perfect, thanks! > I am wondering if the very exact build target `+build js,!wasm` and `+build js,wasm` is not going to cause issue to code completion a…
Earlier
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
Let's remove the import comment here as well, so it's only in `doc.go` file.
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
The package comment must be immediately preceding the package clause. There can't be a blank line separating them, otherwise it's not parsed as a package comment by `godoc`. So please remove the blan…
dmitshur commented on Error variable naming in dmitri.shuralyov.com/idiomatic-go1w
That's an interesting approach. I haven't seen that before. Thanks for sharing. I know there are tools such as [`errcheck`](https://github.com/kisielk/errcheck) and [`staticcheck`](https://github.co…
dmitshur commented on Error variable naming in dmitri.shuralyov.com/idiomatic-go1w
@storozhukBM I guess both are fair style choices. I wanted to pick one, so that all my code would be consistent. `specificError` seemed more natural to me: if the first word is long and written in fu…
dmitshur commented on Net/http package in github.com/gopherjs/gopherjs1w
`http.Client` in GopherJS has 2 implementations: one based on Fetch API, another based on XMLHttpRequest API. It picks whichever is available in that order. Both of those tend to be available in brow…
dmitshur commented on rpc.Dial not supported in gopherjs? in github.com/gopherjs/gopherjs1w
Browsers don't provide access to raw TCP sockets, which `net/rpc` uses, so it can't work. This is why the [compatibility table](https://github.com/gopherjs/gopherjs/blob/master/doc/packages.md) says …
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1w
@dominikh, in PR #59, you said: > Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it. (I wanted to move the discussion here…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
> Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it. I would like to avoid it too, but out of all alternatives, it seems the …
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
For now, I'd prefer we avoid duplicating the package comment, since we can avoid it. Let's delete it here and in `dom.go`, and move it to a new file `doc.go` that just has the package comment and pac…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1w
We do not want to modify the signature. First, it causes the API to differ between GopherJS and Wasm. Second, it causes `*htmlDocument` to no longer satisfy the `Document` interface: ``` panic: i…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom2w
> I think this package needs to shift towards being code generated from the HTML spec Such a drastic change would need to be considered for v2 or another package. It’s not in scope of this PR/is…
dmitshur commented on all: WebAssembly ("wasm") support in github.com/golang/go2w
@omac777 For GopherJS, many people use high-level bindings for various browser APIs rather than the low-level `js` package directly. I suspect a similar approach will be most popular with Wasm too. I…
dmitshur commented on Warnings in MacOS when go-getting a… in github.com/go-gl/gl2w
I can't reproduce this on my system: ``` ~ $ export GOPATH=/tmp/empty ~ $ go get -u github.com/go-gl/gl/v3.3-core/gl ~ $ ``` What version of Go are you using? I'm on a Mid-2015 15" MBP, macOS 10.…
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom2w
@yml Thanks for looking at this and sharing your work. I think that's a great step forward. The approach I'd like us to use for `dom` is going to be slightly different than the one you've used, bu…
dmitshur starred github.com/bradfitz/latlong2w
dmitshur commented on Report more details about errors in… in github.com/shurcooL/graphql2w
Hi, thanks for the PR. I'd like to understand it better, so we can implement a better solution. Can you tell me under what conditions a non-200 response code is expected from a GraphQL server? How…
dmitshur commented on "go get -u honnef.co/go/js/dom" fai… in github.com/dominikh/go-js-dom2w
Thanks for reporting @h8liu! I suspect we’ll have this fixed within 12 hours. /cc @dominikh In the meantime, if someone doesn’t have this package and needs to clone it, a workaround is possibl…
dmitshur commented on Add Reviewers field to ChangeInfo in github.com/andygrunwald/go-gerrit2w
> Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned. For anyone who doesn't already know, it'…
dmitshur commented on Go 1.11 support. in github.com/gopherjs/gopherjs2w
I've started working on this on [`go1.11`](https://github.com/gopherjs/gopherjs/compare/go1.11) branch. I've made good progress so far. The current status is that most of the fundamental functiona…
dmitshur pushed to go1.11 in github.com/gopherjs/gopherjs2w
f67f648ee1b996cf9733eb10d43927540083411fRegenerate.
5f7b3de89300f63cd6477ee5e58b37e7d588b177natives/math: Use Go implementation for extreme Ldexp inputs.
3446fac2d84343b9326d87447f2edf740ba0849enatives/strings: Skip TestBuilderGrow.
486731921c14d88d81b96f2eb929cc4f29da68bbnatives/reflect: Sort exported methods first; add xcount to uncommonType.
a6e22d021c8af6dbd8af8523a4d9cff78a160811natives/reflect: Use 'embedded' rather than 'anonymous'.
004a367dd87a5eec06ebc7c92d122cf90944ac29natives/testing: Update frameSkip signature and implementation.
1a7431c97d8158c6d2e9825b05feb38c16830378natives/unicode: Update signature of to.
1075a948fbd3bfbabc0748011e61069254be0211natives/sync: Update sync.WaitGroup fields.
93d634afcf105a5e575b2674537a1cd6a0e99591natives/syscall: Implement rawSyscallNoError, unsetenv_c.
e3c1680de599ef575855a44f24c0fe773edf020fnatives/internal/syscall/unix: Define randomTrap; override IsNonblock.
dmitshur pushed to go1.11 in github.com/gopherjs/gopherjs2w
c17f6fac74dbf28dd7b8265d310c294c24f4e22bRegenerate.
b04c4ce7ffdd5c35fba0845612df95107554a65bnatives/math: Use Go implementation for extreme Ldexp inputs.
d562e02fcd6df9f6d12284beed36439fccfe2865natives/strings: Skip TestBuilderGrow.
2556912b52f4e937d06121f1ac7ab4ddaa1dc9f6natives/reflect: Sort exported methods first; add xcount to uncommonType.
35485b4b332ac37678487e54ce14c1aceda0953anatives/reflect: Use 'embedded' rather than 'anonymous'.
ea31e0a1e41f4e0a94f918af4a1780489982614dnatives/testing: Update frameSkip signature and implementation.
8832169874389875dbbd61b2d8d3810befefc270natives/internal/syscall/unix: Define randomTrap; override IsNonblock.
dmitshur pushed to go1.11 in github.com/gopherjs/gopherjs2w
39a106f02f8cb8a890d0b07a6e542f511aeb25e5Regenerate.
41e000463a25e8c65ce403f9b5085d95d3c4c917natives/math: Use Go implementation for extreme Ldexp inputs.
95881a7c5afbfb5d1ef57781ee191a1ceb3fe5eanatives/strings: Skip TestBuilderGrow.
5d6fd672723dce443b43d4db56232edf2745bd8anatives/reflect: Sort exported methods first; add xcount to uncommonType.
adec09c5c4a20338c67c13a14943ed5435f87139natives/reflect: Use 'embedded' rather than 'anonymous'.
faba8efeaf9f6d40a055dac6f70fe0bafdb47d30natives/testing: Update frameSkip signature and implementation.
f636772a5ba2e96fc31b1e829fa2271296cb1308natives/internal/syscall/unix: Override IsNonblock.
63ec37fb0330aa54fb7bec67ad4f5723851e6d7bnatives/unicode: Update signature of to.
0097dbf1366ee21b7c449ffb2ad9388055171602natives/sync: Update sync.WaitGroup fields.
269bd7a75ddc3cb1910a1c9b28d95e06bfab5f3fnatives/internal/cpu: Define CacheLineSize constant for GOARCH=js.
cf66b337be936652a4bd5831cbb212f75d3e9f84Target Go 1.11 Beta 1, update version to GopherJS 1.11-wip.
0892b62f0d9fb5857760c3cfca837207185117eedoc: Document Node.js version 10.0.0 requirement.
5232e517d8951ce05c3b08f5bdefb1924f3f7979node-syscall: Use Get instead of deprecated CloneElementAt. (#810)
dmitshur created branch in github.com/shurcooL/vfsgen2w
go1.11
dmitshur pushed to master in github.com/gopherjs/gopherjs3w
0892b62f0d9fb5857760c3cfca837207185117eedoc: Document Node.js version 10.0.0 requirement.
dmitshur pushed to master in github.com/gopherjs/gopherjs3w
5232e517d8951ce05c3b08f5bdefb1924f3f7979node-syscall: Use Get instead of deprecated CloneElementAt. (#810)
dmitshur commented on syscalls: move away from deprecated… in github.com/gopherjs/gopherjs3w
Ended up going back to Node.js 10.0.0 which doesn't cause `package-lock.json` to get modified, it's the simplest solution for now. We'll deal with newer Node.js versions after first migrating off the…
dmitshur deleted branch in github.com/gopherjs/gopherjs3w
try-node-10.0.0
dmitshur pushed to fix_node_10 in github.com/myitcv/gopherjs-compiler3w
84e890a347a75e5a3a869fd36b38e9ba63bf83a5CI: Revert back to Node.js 10.0.0.
dmitshur created branch in github.com/gopherjs/gopherjs3w
try-node-10.0.0
dmitshur pushed to fix_node_10 in github.com/myitcv/gopherjs-compiler3w
1d1026e4e661f7a4fac1b85f81643a4a0c22cfe9CI: Change directory into project directory.
dmitshur pushed to fix_node_10 in github.com/myitcv/gopherjs-compiler3w
0988e64a283e4c6bed3924ef9f63e0d30e2f0d86CI: Add missing inference commands.
dmitshur pushed to fix_node_10 in github.com/myitcv/gopherjs-compiler3w
e1ea8f130dd7cfc213d97f5f92c1a9f849acd756CI: Override dependency commands.
dmitshur commented on syscalls: move away from deprecated… in github.com/gopherjs/gopherjs3w
Well, that didn't work, because Circle CI runs a second `npm install` without the `--no-save` option as part of its "inference commands": ![image](https://user-images.githubusercontent.com/1924134…
dmitshur pushed to fix_node_10 in github.com/myitcv/gopherjs-compiler3w
ceaf48189b0c4ec152b0b919158094d4559b1aa2CI: Use --no-save option for npm install of dev dependencies.
dmitshur commented on syscalls: move away from deprecated… in github.com/gopherjs/gopherjs3w
I guess I'll go with `npm install --no-save` as a solution. We don't want `npm install` to be modifying dependencies in `package-lock.json` in CI.
dmitshur commented on syscalls: move away from deprecated… in github.com/gopherjs/gopherjs3w
The diff I get locally after running `npm install` is: ```diff diff --git a/package-lock.json b/package-lock.json index ed79b7a..6118aad 100644 --- a/package-lock.json +++ b/package-lock.json …
dmitshur pushed to fix_node_10 in github.com/myitcv/gopherjs-compiler3w
7117a8117795289a70e9409fec3cf627ee361678CI: Update to latest Node.js version.
dmitshur created branch in github.com/gopherjs/gopherjs3w
go1.11
dmitshur opened an issue in github.com/gopherjs/gopherjs3w
dmitshur commented on markdownfmt makes annoying and comp… in github.com/shurcooL/markdownfmt3w
The way `markdownfmt` is implemented is that it parses a Markdown document (currently, using blackfriday v1) and then prints back a pretty-printed version of said markdown document. There are mult…
dmitshur pushed to master in github.com/shurcooL/markdownfmt3w
5ba28a0bf0048ea9b00cecd23688dcf6cfb23fe5markdown: Omit repeated []byte types in method signatures. (#43)
dmitshur commented on markdown: combine []byte params to … in github.com/shurcooL/markdownfmt3w
I don't think this makes a big difference, it's unclear if one way if completely superior to the other. But, the shortened version seems a little cleaner, so I'll take it. Thanks! LGTM.
dmitshur pushed to master in dmitri.shuralyov.com/service/change3w
761d04bf40c2c9ef3f63f776a7e525c6290464a3githubapi: Add timeline pagination to ListTimeline.
dmitshur deleted branch in dmitri.shuralyov.com/gpu/mtl3w
render
dmitshur commented on js: Consider adding Wasm support. in github.com/gopherjs/gopherjs3w
I have nothing against that. The two packages perform different non-overlapping tasks: - gopherwasm helps future Go programs that target WebAssembly and its `syscall/js` API to *also* compile with G…
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl4w
9453c974ce537a33764337d12411404dbb07f718Add support for rendering very basic geometry.
dmitshur starred github.com/pions/webrtc4w
dmitshur commented on x/build/version: promote to /v in github.com/golang/go4w
Some reasons why we might want to include a /v/ (or another name) path element: 1. The alternative precludes placing all the individual `go...` commands in a single git repository. Each command wo…
dmitshur commented on x/build/version: promote to /v in github.com/golang/go4w
Worth thinking through: what will https://golang.org/go1.11beta1 serve? A 404? A redirect to the godoc.org page? I expect the latter, since https://golang.org/x/build/version/go1.10beta1 redirects…
dmitshur commented on Packages which normalize casing in … in github.com/golang/gddo4w
I have an idea for how to deal with the catch-22. If my memory of how gddo works is right, I recall there's github.com-specific logic that first checks if the `user/repo` casing is canonical, and …
dmitshur commented on x/tools/cmd/tip: migrate beta.golan… in github.com/golang/go4w
I have some comments/questions to understand this better. I'm not against this, you're in a better position to know if the work maintaining beta isn't justified. If I understand this issue, once r…
dmitshur commented on Check for fields in externalize, in… in github.com/gopherjs/gopherjs4w
Sorry about the delay. The code in `jsmapping.go` looks good. There have been changes to how prelude is stored by now, so we'll need to rebase and regenerate it (as was mentioned in comments ab…
dmitshur commented on Ability to print query string befor… in github.com/shurcooL/githubv41mo
> you can **copy** the constructQuery() code from graphql library The keyword is *copy*. It's unexported because it's low-level internal functionality and not a part of the public `graphql` API. You…
dmitshur commented on net/http.Cookie is being rendered i… in github.com/golang/gddo1mo
What browser are you using? I see something different in Chrome 67.0.3396.87 on macOS: ![image](https://user-images.githubusercontent.com/1924134/41617043-8119b89a-73cd-11e8-89e9-22d81bce9efc.png)…
dmitshur created branch in dmitri.shuralyov.com/gpu/mtl1mo
render
dmitshur commented on syscall/js: comparing two number ob… in github.com/golang/go1mo
I’m not completely sure if two distinct `js.Value` values should report positively for equality, even if their underlying values are equal. A similar situation I can think of is `reflect.Value`,…
dmitshur created branch in dmitri.shuralyov.com/gpu/mtl1mo
master
dmitshur created repository dmitri.shuralyov.com/gpu/mtl1mo
Package mtl provides access to Apple's Metal API (https://developer.apple.com/documentation/metal).
dmitshur starred github.com/crawshaw/littleboss1mo
dmitshur commented on all: Go 1.10.3 release status in github.com/golang/go1mo
@publicarray This issue is about version 1.10.3, but the URL you posted has 1.10.4 in it.
dmitshur starred github.com/james4k/go-bgfx1mo
dmitshur commented on build error under OSX 10.12.6 in github.com/vulkan-go/vulkan1mo
Have you tried following the instructions at https://github.com/vulkan-go/demos#how-to-run-on-desktops? It has some special instructions for building on macOS.
dmitshur commented on self-hosting git clone support in github.com/shazow/ssh-chat1mo
In case it's helpful as a reference, [here](https://godoc.org/github.com/shurcooL/play/231)'s a proof of concept SSH git server.
dmitshur starred github.com/esimov/pigo1mo
dmitshur commented on presentation mode query parameters … in github.com/golang/gddo1mo
That query parameter applies to `godoc`, the command you can run locally. godoc.org doesn’t have it.
dmitshur commented on unsafe.Pointer workaround in github.com/gopherjs/gopherjs1mo
That happens because GopherJS represents `int64` internally using two JavaScript numbers: the low and high components of the `int64`. An `int` is represented by a single JavaScript number that direct…
dmitshur commented on unsafe.Pointer workaround in github.com/gopherjs/gopherjs1mo
> states that unsafe package isn’t available To clarify, that document states the `unsafe` package isn't _fully supported_. Parts of it may work, but there are no guarantees. Also, `js.InternalO…
dmitshur pushed to master in github.com/shurcooL-legacy/octicons1mo
10c8018fdc76d80a11b1cf745398ce1046ce6369Update for octicon package rename.
dmitshur pushed to master in github.com/shurcooL/home1mo
44cbddab16bf4432a205185b822589e1d548d1b8Update for octicon package rename.