Activity
Yesterday
dmitshur commented on golang.org/x/build/internal/gitfs: regenerate17h
Thanks.dmitshur opened a change golang.org/x/build/internal/gitfs: regenerate17h
This pulls in the change applied in CL 634456.dmitshur commented on golang.org/x/build/internal/relui: re-check blocking issues after release coordinator approval18h
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: update gliderlabs/ssh package version18h
Thanks. The code diff looks okay.dmitshur reviewed +2 on cmd/go: drop FailedBuild field if gotestjsonbuildtext=118h
Thanks.
This .* will successfully match even if the FailedBuild field is included, right? Maybe change it to `"Elapsed":0}` if elapsed is always zero on build error, or add a `! stdout` check, or so…dmitshur commented on golang.org/x/website/_content/doc/go1.24: use en dash for number range18h
Thanks.dmitshur commented on cmd/go: re-enable build JSON from go test -json, now with GODEBUG20h
(1 comment)
Is it intended that FailedBuild field is populated even under gotestjsonbuildtext=1, which is intended to make Go 1.24 behave more like Go 1.23?
One the one hand a new field should be f…This Week
dmitshur commented on golang.org/x/build: set a maintenance window for the kubernetes instance1d
We've now set a maintenance window to be during early weekday mornings, skipping Friday. We can wait a bit to see how it goes, adjusting further if needed.dmitshur reviewed +2 on golang.org/x/build/internal/task: fix private patch github issue example1d
Thanks. Optional comment.
If desired, you can also set `Check` to some function that'll check for definitely-incorrect input values. E.g., if this changed to be a number, it can be something like ch…dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.24: normalize how GODEBUG settings are referred to1d
Thanks.dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.24: minor nits1d
Thanks.
Given your reply [here](https://go-review.googlesource.com/c/website/+/635615/comment/330baf43_4740666f/), you'll likely want to update it here too.dmitshur reviewed +2 on golang.org/x/website/npm: quote argument expansions1d
Thanks.
(minor) It it intended to use a git author email that's different from your Gerrit account's primary email in this repo, or possibly unintentional?dmitshur commented on cmd/go: add fips140 module selection mechanism2d
Given #69536 and #70123 are in Go1.24 milestone, it seems this should be too, right?dmitshur commented on github.com/GoogleCloudPlatform/gsutil: gsutil 5.31 doesn't work with Python 3.12.7 in alpine 2d
The comment at https://github.com/GoogleCloudPlatform/gsutil/issues/1776#issuecomment-2538018415 says that gsutil version 5.32 and above supports Python 3.12.dmitshur fixed an issue build: build failure on darwin builders since CL 536399 [consistent failure]2d
Failures above were on release-branch.go1.24 prior to [CL 634237](https://go.dev/cl/634237).dmitshur commented on golang.org/x/build/cmd/gopherbot: add matthew@go.dev2d
Cuong, please see https://go.dev/issue/24850#issuecomment-383723439, that’s where the email policy is written down. go.dev and golang.org are effectively aliases.dmitshur commented on golang.org/x/website/_content/doc/go1.24: use backticks for GOAUTH2d
@danp@danp.net The Run-TryBot+1 vote still exists for rare cases when you wish to trigger a specific [legacy slowbot](https://go.dev/wiki/SlowBots#pre-luci-slowbots). In the general case, just Commit…dmitshur reviewed +2 on all: [release-branch.go1.24] merge master (0ca521f) into release-branch.go1.242d
Thanks. FWIW, CL 635095 landed minutes ago in case you want to include it. (It's fine not to worry about it since there may always be CLs landing to the main branch.)dmitshur reviewed +2 on all: [release-branch.go1.24] merge master (c93477b) into release-branch.go1.242d
Thanks. These CLs look in scope of the Go 1.24 freeze.dmitshur commented on golang.org/x/website/_content/doc/go1.24: remove release-blocking issues that are resolved2d
Thanks.dmitshur opened a change golang.org/x/website/_content/doc/go1.24: remove release-blocking issues that are resolved2d
Also incorporate output of 'relnote todo' on fragments that were moved
in CL 634056 and CL 634057.
For golang/go#68545.dmitshur commented on golang.org/x/website/_content/doc/go1.24: add testing/synctest to release notes3d
Thanks.
This line can be deleted now, since it's resolved.dmitshur commented on golang.org/x/build: add LUCI openbsd-riscv64 builder3d
Checking in on the status here. Did the comment above resolve the need to make further changes, or would you still like to pursue that?
The builder appears to be missing now (https://ci.chromium.o…dmitshur commented on golang.org/x/build/internal/task: synchronize FakeGerrit.changes access in test helper3d
(1 comment)
Thanks for clarifying. We may still want to recover panics and turn them into internal task errors for relui. The main difference here, I think, is that FakeGerrit is only for tests. If …dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.24: minor updates3d
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: redirect various dynamic content on tip.golang.org3d
Thanks.
It's a bit unfortunate this increases chances of non-canonical links to dynamic content proliferating, but I suppose if it matters enough, code review and/or tests can catch that.
There was…dmitshur commented on crypto/internal/fips140test:exe_external: unrecognized failures3d
It does look consistent to me, at least the last few pages of gotip-linux-riscv64 results ignoring the unrelated failure in build 8728977600951940513.dmitshur commented on crypto/internal/fips140test:exe_external: unrecognized failures3d
CC @mengzhuo.dmitshur reviewed +2 on golang.org/x/website: [genai-infra][go] Add google.golang.org/genai to the list of modules under google.golang.org.4d
Thanks. Just minor commit message style suggestions.
Please change this line to match [Go commit message style](https://go.dev/wiki/CommitMessage):
```
cmd/googlegolangorg: mdd google.golang.org/ge…dmitshur commented on golang.org/x/build/cmd/gorebuild: add basic retries to Get4d
Thanks.dmitshur commented on golang.org/x/build/cmd/gorebuild: add basic retries to Get4d
(2 comments)
Thanks, done.
Thanks. Thinking more, this function can't be entirely sure what the caller will do, so I rephrased this to avoid committing to terminal/fatal, rather say this is where i…dmitshur opened a change golang.org/x/build/cmd/gorebuild: add basic retries to Get4d
Gorebuild involves going over the Internet to fetch bytes. Some errors
that it might encounter might be temporary, such that if the caller
were to try again after waiting a bit, it might just succeed…dmitshur commented on robpike.io/ivy/...: add @ operator modifier5d
Interestingly, that's different from https://go.dev/s/style#declaring-empty-slices which suggests the var style for empty slices.dmitshur commented on lib/wasm: provide fs.constants.O_DIRECTORY definition6d
Thanks.dmitshur commented on golang.org/x/website/internal/gitfs: remove apparent debugging dreg6d
Thanks. I'll submit this during the work week.Last Week
dmitshur opened a change golang.org/x/website/internal/gitfs: remove apparent debugging dreg6d
As the comment at the top of the loop says, and git protocol docs¹²
confirm, the sideband byte will be 1, 2, or 3. If something else is
encountered, don't print it to stdout without any context and…dmitshur commented on lib/wasm: provide fs.constants.O_DIRECTORY definition6d
The windows/386 timeout is either #64482 or something similar. Not caused by this change.dmitshur commented on syscall: add O_DIRECTORY for js6d
(1 comment)
O_DIRECTORY needs to be defined here to avoid a panic in browsers. Sent CL 634455.dmitshur opened an issue syscall: fs_js.go accesses a fs.O_DIRECTORY constant that's not defined in browsers6d
At Go tip, js/wasm programs inside a browser run into a panic during init of syscall package:
```
panic: syscall/js: call of Value.Int on undefined
goroutine 1 [running]:
syscall/js.Value.flo…dmitshur opened a change lib/wasm: provide fs.constants.O_DIRECTORY definition6d
CL 606658 added a constants.Get("O_DIRECTORY").Int() call at init time,
which panics in browsers because O_DIRECTORY is undefined. It needs to
be a JavaScript number to avoid that.
Fixes #70723.dmitshur commented on golang.org/x/build: add doas package on NetBSD systems1w
There are LUCI builders for netbsd/arm and netbsd/arm64 ports (#63698 and #63614). They're remote, so this change is something their builder owner can consider applying (CC @bsiegert).dmitshur closed an issue golang.org/x/build: add builder for netbsd/arm641w
I don't believe there are active plans to pursue a non-reverse netbsd/arm64 builder now, and a newer reverse builder for LUCI was added: https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/go…dmitshur fixed an issue golang.org/x/build: add LUCI netbsd-arm builder1w
I think we can close this now – the builder is added and its known issue is removed. Thanks!dmitshur reviewed +2 on golang.org/x/build/main.star: don't even define PRESUBMIT.DISABLED builders1w
Thanks.dmitshur commented on golang.org/x/build/internal/task: synchronize FakeGerrit.changes access1w
(1 comment)
I tend to prefer to defer unlock when there's a bit more than 1-2 lines of code in between (more like [this](https://cs.opensource.google/go/x/build/+/master:devapp/server.go;l=93-94;drc…dmitshur commented on golang.org/x/build/internal/relui: re-check blocking issues after release coordinator approval1w
The data race is #70694, fix in Ib22d647458af18669a35acf5f45d6f0a1959eb81.dmitshur opened a change golang.org/x/build/internal/task: synchronize FakeGerrit.changes access1w
As https://ci.chromium.org/b/8729261949578211409 showed, MailDLCL and
CreateAutoSubmitVersionCL can call CreateAutoSubmitChange at the same
time. Guard map access with a mutex.
For golang/go#70655.
…dmitshur opened a change golang.org/x/build/main.star: extend gotestjsonbuildtext=1 to NEXT_GO1w
We'll drop it from tip and the new release-branch.go1.24 branch as soon
as result_adapter is ready to handle events that contain ImportPath but
not Package fields, but that's not the case this week.
…dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: install doas1w
Looks so simple. :) Thanks!dmitshur opened a change golang.org/x/build/internal/relui: re-check blocking issues after release coordinator approval1w
By now we consistently start a pre-build a week ahead of the planned
release, so we don't get to benefit from having the 'Check blocking
issues' task on the day of the release. Add a second one, that…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle1w
[CL 634041](https://go.dev/cl/634041), [CL 631336](https://go.dev/cl/631336), and [CL 626995](https://go.dev/cl/626995) took care of the start-of-freeze updates for the Go 1.24 cycle. There may still…dmitshur reviewed +2 on : [release-branch.go1.24] update codereview.cfg for release-branch.go1.241w
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add NEXT_GO branch for Go 1.24 release candidate1w
Thanks.dmitshur commented on golang.org/x/build/internal/releasetargets: evaluate for each upcoming major Go release1w
[CL 612555](https://go.dev/cl/612555) regenerated the list for Go 1.24. It's the same list as for Go 1.23 but without windows/arm (32-bit), and that's noted at https://go.dev/doc/go1.24#windows.
I…dmitshur reviewed +2 on all: update vendored dependencies [generated]1w
Thanks.dmitshur commented on golang.org/x/net/Revert "route: change from syscall to x/sys/unix"1w
(1 comment)
A quick clarification note for posterity: the policy decision is [Go issue 32102](https://go.dev/issue/32102) and applies to the golang.org/x/sys/unix package specifically, not golang.or…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle1w
Anything other "pick latest versions of all x/ repos" does need some manual intervention. You could still use updatestd, just followed by a `go get golang.org/x/net@{pseudo-version before CL 632816}`…dmitshur reviewed +2 on golang.org/x/build/main.star: hide totally broken builders from presubmit1w
Thanks for improving this!
It'd probably also be fine to combine with skip_x_repos, something like 'skip_x_repos_and_hide_from_presubmit', or 'builder_not_added_yet' with a comment that explains the…dmitshur commented on golang.org/x/build/main.star: explicitly exclude secondary ports from presubmit1w
(1 comment)
As am I in that comment. :) Thanks again.dmitshur reviewed +2 on golang.org/x/build/main.star: disable FreeBSD 14.1 on old release branches1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: explicitly exclude secondary ports from presubmit1w
Thanks.
It'd be a proposal. It's probably fine as is for now, and we can continue to keep it as a trybot while a secondary port since it works well. The same can apply to other secondary ports when …dmitshur commented on testing: fix divide by zero when benchmark is faster than OS's clock resolution1w
(1 comment)
Too late for this CL and not a big deal at all, but please take this into account in the future. Thanks.dmitshur commented on testing: fix divide by zero when benchmark is faster than OS's clock resolution1w
(1 comment)
The other nit here is that commit messages do not use Markdown, so please leave out the backticks.dmitshur commented on testing: integer divide by zero in predictN1w
Also reproduces on an M1 Pro machine.
> Looking through the code some codepaths sanitize the nanoseconds before calling predictN, others don't. I'll send a fix.
I did that locally (in B.stopOrScale…dmitshur commented on testing: integer divide by zero in predictN1w
`go test -count=1000 -run=^TestBLoopHasResults$ testing` reliably reproduces this on this machine, a MacBook Pro with M4 Pro, macOS 15.1.1 (24B2091).dmitshur opened an issue testing: integer divide by zero in predictN1w
### Go version
go version devel go1.24-3ae00f5d29 Fri Dec 6 02:16:12 2024 +0000 darwin/arm64
### Output of `go env` in your module/workspace:
```shell
$ go env -changed
GOFLAGS='-ldflags=-…dmitshur commented on golang.org/x/build: add doas package on NetBSD systems1w
Now that #61095 is nearly done, at least for the freebsd-amd64 builder, I think this should be a matter of adding the right package to [this line](https://cs.opensource.google/go/x/build/+/master:env…dmitshur commented on golang.org/x/website/_content/doc: fix typo in testing.B.Loop section.1w
PS 1 already has a passing trybot run, so this can be directly submitted with Auto-Submit+1.dmitshur commented on golang.org/x/website/cmd/golangorg: suggest relative links for /issue/ and /wiki/ cases1w
Thanks.dmitshur commented on golang.org/x/website/_content/doc/go1.24: document broken windows/arm port1w
Thanks.dmitshur commented on golang.org/x/website/_content/doc/go1.24: remove empty headings for new packages1w
(1 comment)
Sure, done. Thanks.dmitshur commented on golang.org/x/build/internal/task: order doc/next removal after api/next promotion1w
Thanks.dmitshur commented on golang.org/x/website/_content/doc/go1.24: remove empty headings for new packages1w
(1 comment)
There's room to improve relnote and reduce friction here. Filed #70706 to track that.dmitshur opened an issue golang.org/x/build/cmd/relnote: improve experience for documenting new standard library packages1w
The cmd/relnote test requires that all new APIs have a corresponding entry in doc/next/\*-stdlib/\*-minor. This works as intended for most APIs, but some new APIs are entirely new packages. Those are…dmitshur opened a change golang.org/x/website/_content/doc/go1.24: document broken windows/arm port1w
For golang/go#70705.
For golang/go#68545.dmitshur opened a change golang.org/x/website/_content/doc/go1.24: remove empty headings for new packages1w
Plus various edits to make the formatting more consistent.
Also remove release-blocking issues that are resolved now.
For golang/go#68545.dmitshur opened an issue build: windows/arm (32-bit ARM) port is broken1w
The Go porting policy has a section on broken ports, https://go.dev/wiki/PortingPolicy#broken-ports. The GOOS=windows GOARCH=arm (not arm64) port was marked broken in August 2024 ([CL 601777](https:/…dmitshur reviewed +2 on doc/next: delete1w
Good finding. Done in CL 634044.dmitshur opened a change golang.org/x/build/internal/task: order doc/next removal after api/next promotion1w
The TestCheckAPIFragments test in cmd/relnote looks at api/next content
and requires doc/next to have corresponding entries. So, make sure that
test is happy by starting to remove doc/next no sooner …dmitshur commented on all: update vendored dependencies [generated]1w
The generation sequence looks right. It's uncovering CL 632816 is causing golang.org/x/sys/unix to get vendored into the main Go repo, which doesn't align with a past policy decision (#32102).dmitshur reviewed +2 on doc/next: delete1w
Looks right. For reference, CL 594036 was the previous similar CL during the Go 1.23 cycle.dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue from freebsd-amd641w
(2 comments)
Oh, I noticed the builder is not yet passing on release branches for 1.23 and 1.22:
- https://ci.chromium.org/b/8729548849265746753
- https://ci.chromium.org/b/8729550591543558097
Tha…dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue from freebsd-amd641w
Thanks.
Thanks for calling this out. In earlier discussion with @cherryyz@google.com (and Eli) we agreed that we generally do not need to default to making secondary port builders included in the de…dmitshur reviewed +2 on golang.org/x/build/main.star: adjust LUCI load at openbsd-ppc64 builder1w
Thanks.
Glad to hear it had an effect.dmitshur reviewed +2 on doc/next: introduce module tools1w
This looks good to me. Thanks.
If Michael or Sam have additional suggestions, please feel free to refine the draft further after it's moved to x/website/_content.dmitshur commented on cmd/go: drop -v from go help get1w
This seems ready to be submitted.dmitshur reviewed +2 on golang.org/x/website/...: remove unreachable code1w
dmitshur commented on golang.org/x/build/internal/task: check for open documentation-only CLs before moving them1w
Thanks.dmitshur closed a change golang.org/x/website/_content/doc: add merged go1.24.md1w
Closing this generated CL; we'll be running the workflow again slightly later.dmitshur closed a change api: promote next to go1.241w
Closing this generated CL; we'll be running the workflow again slightly later.dmitshur reviewed +2 on doc/next: add release notes for Wasm changes1w
Thanks.
I'm not sure, but maybe using a fixed commit rather than the moving branch will work better as time passes.
```suggestion
[reactor/library](https://github.com/WebAssembly/WASI/blob/63a46f61…dmitshur opened a change golang.org/x/build/internal/task: check for open documentation-only CLs before moving them1w
If there are in-flight CLs for doc/next, it might make sense to finish
them before moving the release notes into x/website. This is something
the release coordinator may do manually, so add an automa…dmitshur closed an issue golang.org/x/crypto/openpgp/clearsign: TestMultiSign failures1w
Duplicate of #70682.dmitshur commented on io/fs: add ReadLinkFS interface1w
We considered this freeze exception in a release meeting today. This seems to be a new API that would be safe to land in the next upcoming major Go release, Go 1.25, so that if there are unexpected i…dmitshur commented on golang.org/x/crypto/openpgp/clearsign: TestMultiSign fails with "random source is broken" at Go tip1w
Thanks for the quick fix! The monthly golang.org/x tagging workflow ran into this, and the fix enabled it to keep going (https://go.googlesource.com/crypto/+/refs/tags/v0.30.0).dmitshur created repository in github.com/golang/open2opaque1w
dmitshur opened an issue golang.org/x/crypto/openpgp/clearsign: TestMultiSign fails with "random source is broken" at Go tip1w
At Go tip, TestMultiSign fails when run without -short flag, including on first class ports like linux/amd64:
```
=== RUN TestMultiSign
clearsign_test.go:155: cannot create key: rsa: gener…dmitshur commented on lib/time: update tzdata before release1w
Added okay-after-rc1 since RC 1 is scheduled for [next week](https://go.dev/s/release#june--december-week-2-release-candidate-1-issued) and 2024b is still the latest available version. (CC @mknyszek.…dmitshur deleted branch in github.com/shurcooL/git-branches1w
8weeksdmitshur pushed to
main in github.com/shurcooL/git-branches1w