Today
dmitshur commented on x/tools/present: Docs say 'h' key i… in github.com/golang/go6h
> So something doesn't look right here. I don't know if the documentation is wrong, or if the implementation has a bug.
I did some code archeology to find out. The earlier commit I found where the…
> So something doesn't look right here. I don't know if the documentation is wrong, or if the implementation has a bug.
I did some code archeology to find out. The earlier commit I found where the…
dmitshur commented on Support Go modules. in github.com/shurcooL/vfsgen7h`vfsgen` itself supports modules.
`./cmd/vfsgendev`, a convenience tool for using `vfsgen` in a specific way, currently doesn't support modules because it looks for import paths only within GOPATH…
`vfsgen` itself supports modules.
`./cmd/vfsgendev`, a convenience tool for using `vfsgen` in a specific way, currently doesn't support modules because it looks for import paths only within GOPATH…Yesterday
dmitshur commented on cmd/gopherbot: race condition in au… in github.com/golang/go9hI think I've already seen code somewhere that uses Gerrit API in addition to `maintner` to confirm the "latest" state before taking some action. @bradfitz will probably remember where that was.
I …
I think I've already seen code somewhere that uses Gerrit API in addition to `maintner` to confirm the "latest" state before taking some action. @bradfitz will probably remember where that was.
I …dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go10h> Will redeploy `cmd/coordinator` later tonight (when it's quieter).
Version golang/build@24469dd429f05bdb34b644430843761abf7e1367 of `cmd/coordinator` is deployed now.
> Will redeploy `cmd/coordinator` later tonight (when it's quieter).
Version golang/build@24469dd429f05bdb34b644430843761abf7e1367 of `cmd/coordinator` is deployed now.dmitshur commented on set exit code according to found wa… in github.com/mvdan/unparam11hI'm a little surprised this PR was merged to `master` as 3 individual commits rather than squashing into one. Was that intentional?
I'm a little surprised this PR was merged to `master` as 3 individual commits rather than squashing into one. Was that intentional?dmitshur commented on basic changes for vgo support in github.com/go-audio/wav11h> I had to put all tests into the wav package to make vgo happy.
What was the error you're getting? Which version of Go were you using? I don't think that should be the case.
> I had to put all tests into the wav package to make vgo happy.
What was the error you're getting? Which version of Go were you using? I don't think that should be the case.dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go15hI've updated the images and sent [CL 143458](https://golang.org/cl/143458).
Will redeploy `cmd/coordinator` later tonight (when it's quieter).
After a few days of no issues, the next step will …
I've updated the images and sent [CL 143458](https://golang.org/cl/143458).
Will redeploy `cmd/coordinator` later tonight (when it's quieter).
After a few days of no issues, the next step will …This Week
dmitshur commented on Remove the "always receives X" chec… in github.com/mvdan/unparam1d> Does anyone find it useful?
I don't remember the last time I've seen it. I might've fixed all instances and not introduced new ones.
As a result, it's hard for me to say, but it sounds useful…
> Does anyone find it useful?
I don't remember the last time I've seen it. I might've fixed all instances and not introduced new ones.
As a result, it's hard for me to say, but it sounds useful…dmitshur commented on Vsync doesn't work on macOS 10.14 (… in github.com/glfw/glfw1dI can also confirm this, it's a regression in macOS 10.14 and wasn't a problem in 10.13.
This issue may be related to #1334 in some way. What I'm observing is that vsync works until you move or re…
I can also confirm this, it's a regression in macOS 10.14 and wasn't a problem in 10.13.
This issue may be related to #1334 in some way. What I'm observing is that vsync works until you move or re…dmitshur commented on OSX 10.14 (Mojave) Window does not … in github.com/glfw/glfw1dThanks for the report. This is a duplicate of #1334.
Thanks for the report. This is a duplicate of #1334.dmitshur commented on proposal: x/tools/go/generated: par… in github.com/golang/go1dI agree with your comment @rsc that this would be a small package, and it's better to avoid that in x/tools.
I've been thinking about where this functionality could fit into existing packages, and…
I agree with your comment @rsc that this would be a small package, and it's better to avoid that in x/tools.
I've been thinking about where this functionality could fit into existing packages, and…dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go1dI'll work on updating the images to 6.4 final.
The current 6.4 snapshots have been quite stable on https://build.golang.org/:
<img width=101 src="https://user-images.githubusercontent.com/19241…
I'll work on updating the images to 6.4 final.
The current 6.4 snapshots have been quite stable on https://build.golang.org/:
<img width=101 src="https://user-images.githubusercontent.com/19241…
dmitshur commented on x/build: create mips32 soft-float b… in github.com/golang/go3d@bradfitz From [`x/build/dashboard/builders.go`](https://github.com/golang/build/blob/c27f283fefcd9cd436e591d4b932a1d94d469a27/dashboard/builders.go#L425-L474), it looks like all our current `mips` b…
@bradfitz From [`x/build/dashboard/builders.go`](https://github.com/golang/build/blob/c27f283fefcd9cd436e591d4b932a1d94d469a27/dashboard/builders.go#L425-L474), it looks like all our current `mips` b…dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go4dStarting to have second thoughts about the proposed workaround. In the [CL 142362](https://golang.org/cl/142362) commit message, I wrote:
> The goal of this change is to reduce occurrences of goph…
Starting to have second thoughts about the proposed workaround. In the [CL 142362](https://golang.org/cl/142362) commit message, I wrote:
> The goal of this change is to reduce occurrences of goph…dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go4dI tested the approach (locally) and it worked in solving the problem. Going to send a CL.
I tested the approach (locally) and it worked in solving the problem. Going to send a CL.dmitshur commented on x/build/cmd/gopherbot: testing figh… in github.com/golang/go4dTesting successful (done locally, so not visible here). Closing.
Testing successful (done locally, so not visible here). Closing.dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go4dAnother: #28103. I was expecting it to happen, so I fired up a local copy of `gopherbot` running in dry-mode and watched it fight me (one time), as well as looked at `gopherbot` and `maintnerd` logs …
Another: #28103. I was expecting it to happen, so I fired up a local copy of `gopherbot` running in dry-mode and watched it fight me (one time), as well as looked at `gopherbot` and `maintnerd` logs …dmitshur commented on x/build/cmd/gopherbot: reply when a… in github.com/golang/go4dWhat's the criteria for @gopherbot to consider a comment to be a request?
Should it be a comment that mentions @gopherbot and also contains "please"? Or just the mention on its own?
What's the criteria for @gopherbot to consider a comment to be a request?
Should it be a comment that mentions @gopherbot and also contains "please"? Or just the mention on its own?dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go4dI'm going to fold this issue into #21312, since it's the same thing. I'll take its title since it's easer to find and more accurate.
I'm going to fold this issue into #21312, since it's the same thing. I'll take its title since it's easer to find and more accurate.dmitshur commented on .github: hide text for issue author… in github.com/golang/go4dSounds good. I'll apply the change just before my next triaging rotation, and make sure it has a positive effect on the new issue reports.
Sounds good. I'll apply the change just before my next triaging rotation, and make sure it has a positive effect on the new issue reports.dmitshur commented on Newly created packages should be di… in github.com/shurcooL/home5dMade some progress on automatic package discovery on push:
It needs more work, test…
Made some progress on automatic package discovery on push:
It needs more work, test…dmitshur commented on Website down in github.com/vulkan-go/vulkan5d@xlab Since the website does not exist at this time, maybe it would make sense to remove its URL? When/if you do create it, you can re-add the URL.
I think people get confused because the URL exis…
@xlab Since the website does not exist at this time, maybe it would make sense to remove its URL? When/if you do create it, you can re-add the URL.
I think people get confused because the URL exis…dmitshur commented on vulkango.com is down in github.com/vulkan-go/vulkan5dI think this is a duplicate of #16.
I think this is a duplicate of #16.dmitshur commented on Where did golint go? in github.com/golang/lint6d@mvpmvh The issue is closed because it has been resolved. You can install `golint` via `go get -u golang.org/x/lint/golint`, as described in the [README](https://github.com/golang/lint/blob/master/RE…
@mvpmvh The issue is closed because it has been resolved. You can install `golint` via `go get -u golang.org/x/lint/golint`, as described in the [README](https://github.com/golang/lint/blob/master/RE…Last Week
dmitshur commented on API comparison to previous DOM pack… in github.com/dennwc/dom1wI see, thanks for the answer!
> `net`-like implementation of WebSockets for both `js`
Just checking, are you familiar with https://github.com/gopherjs/websocket? You can use it if you don't wis…
I see, thanks for the answer!
> `net`-like implementation of WebSockets for both `js`
Just checking, are you familiar with https://github.com/gopherjs/websocket? You can use it if you don't wis…dmitshur commented on gosrc: svg files in presentations n… in github.com/golang/gddo1w> Aside, why is gobot not enabled for this repo, to automatically link issues with CLs?
Right now, only CLs that mention issues in the main Go issue tracker are enabled. See [here](https://github.…
> Aside, why is gobot not enabled for this repo, to automatically link issues with CLs?
Right now, only CLs that mention issues in the main Go issue tracker are enabled. See [here](https://github.…dmitshur commented on ci: Enable windows on travis in github.com/sourcegraph/go-langserver1w@keegancsmith What's interesting about the missing `gcc` issue is that it only seems to affect Go 1.11.1 (`1.x`) builds, but not Go 1.9.7 (`1.9.x`) ones. See the 2nd and 3rd bullet points of https://…
@keegancsmith What's interesting about the missing `gcc` issue is that it only seems to affect Go 1.11.1 (`1.x`) builds, but not Go 1.9.7 (`1.9.x`) ones. See the 2nd and 3rd bullet points of https://…dmitshur commented on Travis: Run tests on Windows. in github.com/sourcegraph/go-vcs1wLooks like @keegancsmith is seeing very similar issues in https://github.com/sourcegraph/go-langserver/pull/329, and has filed an issue about them at https://travis-ci.community/t/go-cant-find-gcc-wi…
Looks like @keegancsmith is seeing very similar issues in https://github.com/sourcegraph/go-langserver/pull/329, and has filed an issue about them at https://travis-ci.community/t/go-cant-find-gcc-wi…dmitshur commented on Travis: Run tests on Windows. in github.com/sourcegraph/go-vcs1wLooks like it'll take some work to get tests to pass on Windows. I see the following issues so far:
- `gofmt` reports every file as not formatted; this is likely because the [line endings](http://…
Looks like it'll take some work to get tests to pass on Windows. I see the following issues so far:
- `gofmt` reports every file as not formatted; this is likely because the [line endings](http://…
dmitshur commented on cmd/go: add 'go release' in github.com/golang/go1w/cc @bradleyfalzon who created [`apicompat`](https://github.com/bradleyfalzon/apicompat), a tool to check for the introduction of backwards incompatible changes, which is relevant here.
/cc @bradleyfalzon who created [`apicompat`](https://github.com/bradleyfalzon/apicompat), a tool to check for the introduction of backwards incompatible changes, which is relevant here.dmitshur commented on x/build: add OpenBSD 6.4 builder (b… in github.com/golang/go1w[CL 139857](https://golang.org/cl/139857) has been merged and `cmd/coordinator` redeployed. There are `openbsd-amd64-64` and `openbsd-386-64` builders running now.
It's not the final OpenBSD 6.4 r…
[CL 139857](https://golang.org/cl/139857) has been merged and `cmd/coordinator` redeployed. There are `openbsd-amd64-64` and `openbsd-386-64` builders running now.
It's not the final OpenBSD 6.4 r…dmitshur commented on proposal: cmd/go: stop special-casi… in github.com/golang/go1wThis special case is documented at https://golang.org/cmd/go/#hdr-Package_lists_and_patterns, in the third paragraph from the end:
> Packages in a program need not have unique package names, but t…
This special case is documented at https://golang.org/cmd/go/#hdr-Package_lists_and_patterns, in the third paragraph from the end:
> Packages in a program need not have unique package names, but t…dmitshur commented on go/scanner: Scanner.Scan sometimes … in github.com/golang/go1w> There's no Go code containing two dots ".." that is valid,
In case you're curious how I discovered this, I ran into this in issue #28082. You left a [comment](https://github.com/golang/go/issues…
> There's no Go code containing two dots ".." that is valid,
In case you're curious how I discovered this, I ran into this in issue #28082. You left a [comment](https://github.com/golang/go/issues…dmitshur commented on Shows information about removed sub… in github.com/golang/gddo1wDid you visit and refresh the actual packages that no longer exist? E.g.:
- https://godoc.org/github.com/andersfylling/disgord/rest
- https://godoc.org/github.com/andersfylling/disgord/state
- etc.
…
Did you visit and refresh the actual packages that no longer exist? E.g.:
- https://godoc.org/github.com/andersfylling/disgord/rest
- https://godoc.org/github.com/andersfylling/disgord/state
- etc.
…dmitshur commented on proposal: x/tools/go/generated: par… in github.com/golang/go1w> Is the only concern about the regular expression its speed?
No. I wanted to avoid the `regexp` dependency because it was easy to implement the matching behavior myself.
The `regexp` package c…
> Is the only concern about the regular expression its speed?
No. I wanted to avoid the `regexp` dependency because it was easy to implement the matching behavior myself.
The `regexp` package c…dmitshur commented on time: Timer.Reset documentation not… in github.com/golang/go1w> We should probably say something about `AfterFunc` in the `Timer.Reset` docs.
Agreed.
My parsing of the `Reset` documentation was that the `f` parameter to `AfterFunc` being executed is equivalen…
> We should probably say something about `AfterFunc` in the `Timer.Reset` docs.
Agreed.
My parsing of the `Reset` documentation was that the `f` parameter to `AfterFunc` being executed is equivalen…dmitshur commented on cmd/go: go test -h output doesn't w… in github.com/golang/go1wThanks for the correction @mvdan, `-h` is indeed a valid flag.
Thanks for the correction @mvdan, `-h` is indeed a valid flag.dmitshur commented on godoc search not work locally in github.com/golang/go1wFrom `godoc -help` output:
```
-index
enable search index
```
By default, the search index isn't enabled. You'll need to explicitly enable it if you want it to be available:
```
g…
From `godoc -help` output:
```
-index
enable search index
```
By default, the search index isn't enabled. You'll need to explicitly enable it if you want it to be available:
```
g…dmitshur commented on runtime/race: ERROR: ThreadSanitize… in github.com/golang/go1w> I want to compile go1.11.1 with go1.4.
You should check out the `go1.11.1` tag in the `go` repository checkout, cd into its `src` directory, and run:
```
GOROOT_BOOTSTRAP=/home/hello/go1.4 .…
> I want to compile go1.11.1 with go1.4.
You should check out the `go1.11.1` tag in the `go` repository checkout, cd into its `src` directory, and run:
```
GOROOT_BOOTSTRAP=/home/hello/go1.4 .…dmitshur commented on cmd/gofmt: inconsistent formatting … in github.com/golang/go1wAn interesting behavior.
For anyone confused why it formats instead of printing an error like `main.go:3:12: expected type, found 'EOF'`, scroll to the right. The `) {}` characters are just off-sc…
An interesting behavior.
For anyone confused why it formats instead of printing an error like `main.go:3:12: expected type, found 'EOF'`, scroll to the right. The `) {}` characters are just off-sc…dmitshur commented on cmd/go: go test -h output doesn't w… in github.com/golang/go1w`-h` is not a valid flag for `go help`, so `go test -h` writes usage to stderr, not stdout, and exits with a non-zero exit code. The pipe only sends stdout to less.
The correct command to view hel…
`-h` is not a valid flag for `go help`, so `go test -h` writes usage to stderr, not stdout, and exits with a non-zero exit code. The pipe only sends stdout to less.
The correct command to view hel…dmitshur commented on runtime/race: ERROR: ThreadSanitize… in github.com/golang/go1wIt looks like one of the race detector tests has failed.
Is this issue reproducible for you? What happens if you try `./all.bash` a second time?
It looks like one of the race detector tests has failed.
Is this issue reproducible for you? What happens if you try `./all.bash` a second time?dmitshur commented on x/talks: cannot deploy to GAE using… in github.com/golang/go1w> merge App Engine and "local" logic into one binary without build tags
🎉 👍
> merge App Engine and "local" logic into one binary without build tags
🎉 👍dmitshur commented on x/playground: deploy may take over … in github.com/golang/go1wA data point from today's deploy (for #25462): the cloud build step took 10 min 58 sec. (It was within my 15 minute timeout.)
A data point from today's deploy (for #25462): the cloud build step took 10 min 58 sec. (It was within my 15 minute timeout.)dmitshur commented on x/playground: in About text, docume… in github.com/golang/go1wI've deployed the new version. Thanks @ysmolsky!
I've deployed the new version. Thanks @ysmolsky!dmitshur commented on Infinite Page Loading for Nigeria I… in github.com/golang/gddo1w> I am unable to access any Godoc page
Are you talking about https://godoc.org pages? Or something else like https://talks.godoc.org?
It's an App Engine app, so this probably would be related t…
> I am unable to access any Godoc page
Are you talking about https://godoc.org pages? Or something else like https://talks.godoc.org?
It's an App Engine app, so this probably would be related t…dmitshur commented on Talks doesn't support .background in github.com/golang/gddo1wThe new version is deployed now, so `.background` should be working. Thank you for the contribution!
The new version is deployed now, so `.background` should be working. Thank you for the contribution!dmitshur commented on Block parsing for fenced code block… in github.com/russross/blackfriday1wI have a lead. Modifying the code as follows seems to fix the issue, at least for that one instance of the problematic input:
```diff
-_, marker := isFenceLine(chunk, nil, codeBlockMarker, false)…
I have a lead. Modifying the code as follows seems to fix the issue, at least for that one instance of the problematic input:
```diff
-_, marker := isFenceLine(chunk, nil, codeBlockMarker, false)…dmitshur commented on Fix block parsing for fenced code b… in github.com/russross/blackfriday1wI've just discovered this PR is causing #495.
I've just discovered this PR is causing #495.dmitshur commented on New rule for generated Go files in github.com/github/linguist1wWas this issue closed intentionally? It seems it's not resolved yet, and it'd useful to have an open issue to track this open task.
Was this issue closed intentionally? It seems it's not resolved yet, and it'd useful to have an open issue to track this open task.dmitshur commented on Update Go (golang) handling in github.com/github/linguist1wI'd like to see linguist updated to use the https://golang.org/s/generatedcode specification, and it seems this PR is working in that direction.
From the discussion, it seems that to make progress…
I'd like to see linguist updated to use the https://golang.org/s/generatedcode specification, and it seems this PR is working in that direction.
From the discussion, it seems that to make progress…dmitshur commented on Port to WASM in github.com/gopherjs/websocket1w> Obviously, the former seems more desirable.
Ok, it sounds like you're feeling pretty strongly about avoiding having two implementations of the high-level `websocket` package (one using `syscall/…
> Obviously, the former seems more desirable.
Ok, it sounds like you're feeling pretty strongly about avoiding having two implementations of the high-level `websocket` package (one using `syscall/…