Today
shurcooL commented on Support Preview hovercard API (#87… in github.com/google/go-github23m
It would be good to place `Hovercard` on top of `UserContext`. The general pattern is higher level identifiers should come first. They are easier to understand, and they set context for the lower lev…
Yesterday
shurcooL commented on cannot convert math.MaxInt64 in github.com/gopherjs/gopherjs1d
> `int(math.MaxInt64)` will never work, anywhere Not sure what you mean, but it would work on a 64-bit environment where `int` is 64 bits.
shurcooL commented on cannot convert math.MaxInt64 in github.com/gopherjs/gopherjs1d
GopherJS emulates a 32-bit environment. `int` is 32 bits, so the `math.MaxInt64` constant is too large for it. It will fit into a `int64` variable though. See https://github.com/gopherjs/gopherjs#ge…
shurcooL commented on Cannot go get install in github.com/gopherjs/gopherjs1d
It looks like your `golang.org/x/tools` history has diverged from upstream for some reason. Either you made some local changes to it, or the upstream has force-pushed an incompatible commit (less lik…
This Week
Last Week
shurcooL commented on Proposal: Official GopherJS Docker … in github.com/gopherjs/gopherjs3d
I personally don't need this myself at this time. But if you want to do it (for yourself and for others), I don't see why you shouldn't. It might be a good idea to start this in a place where it's e…
shurcooL commented on js.ValueOf(0).Length() returns -429… in github.com/neelance/go3d
For precedent, https://godoc.org/reflect#Value.Len says: > Len returns v's length. It panics if v's Kind is not Array, Chan, Map, Slice, or String. Panicking (and documenting the panic) seems most …
shurcooL commented on Avoid unused method receiver names in dmitri.shuralyov.com/idiomatic-go4d
@ilius, not to my knowledge. It can be implemented at the AST-level, type information isn't needed. It might be a good fit into either [`unused`](https://github.com/dominikh/go-tools/tree/master/cmd…
shurcooL commented on unused exported function not report… in github.com/dominikh/go-tools4d
To be more precise, it’s a method. Its existence makes the `Abc` type implement the following interface: ```Go type Func1er interface { Func1() } ``` If this were a library rather than command, …
shurcooL starred github.com/felixangell/phi4d
shurcooL commented on exclude vendor dir from matching `.… in github.com/kisielk/errcheck4d
That's right. As of https://github.com/kisielk/gotool/issues/16 being resolved, `gotool` will not include `vendor` when expanding `...` on Go 1.9 and later.
shurcooL pushed to master in github.com/shurcooL/events4d
37636e399bf5ca43c6bd4d7fdb9828a2111a87ecevent: Implement json.Marshaler, json.Unmarshaler for Event.
shurcooL pushed to master in github.com/shurcooL/events4d
bdc4b9e84dfee39f9bb532201eec3080351fa03fevent: Implement json.Marshaler, json.Unmarshaler for Event.
shurcooL pushed to master in github.com/shurcooL/home6d
shurcooL commented on Utilizing Same API Client Pattern i… in github.com/google/go-github6d
As Glenn said, Will is indeed the person who can give you a good answer. I personally hope you do apply the best practices of making a high quality Go package to your API client library. I've contr…
shurcooL pushed to master in dmitri.shuralyov.com/website/gido6d
58d6128437a163a2dd5351a1b77fbe5b892e6398Apply gzip compression to dynamic pages.
shurcooL pushed to master in dmitri.shuralyov.com/website/gido6d
a1ea132dfd8617047a44f45e0e6fc9c848f24e98Apply gzip compression to dynamic pages.
08f99819a87ffdf2fdaccc331a2780115e520f48Rename responseWriter{header,bytes} to {header,bytes}ResponseWriter.
shurcooL pushed to master in github.com/shurcooL/home1w
7a53f4bfbc1071415fadfd055df29686bcdfa307internal/page/{idiomaticgo,resume}: Update testdata.
shurcooL pushed to master in github.com/shurcooL/resume1w
shurcooL pushed to master in dmitri.shuralyov.com/service/change1w
edf95a0d92762102d986315f7a564b09d12e5637gerritapi: Handle comments with multiple labels.
shurcooL deleted branch in github.com/shurcooL/graphql1w
handle-no-data
shurcooL pushed to master in github.com/shurcooL/graphql1w
62c9ce094e75302d560f7adcdf16c06d05aaa958Unmarshal data field only if present. (#23)
shurcooL commented on Unmarshal data field only if presen… in github.com/shurcooL/graphql1w
Thanks for checking, @mwilli31.
Earlier
shurcooL commented on Panic when calling "getReader" on a… in github.com/neelance/go1w
Yeah, just checked latest Firefox Nightly, and Streams API is simply not supported (with default settings). Compare Firefox Nightly (62.0a1): ![image](https://user-images.githubusercontent.com/192…
shurcooL commented on Panic when calling "getReader" on a… in github.com/neelance/go1w
Did you check if the same functionality in JavaScript works? Does that version of Firefox support streams API by now? https://caniuse.com/#search=ReadableStream Last time I checked (some time ago), …
shurcooL pushed to master in github.com/shurcooL/octiconssvg1w
f4482000187f70884083d861259564f0822a2fb0Update to Octicons v7.3.0, regenerate.
shurcooL commented on Unexpected panic when using callback in github.com/neelance/go1w
It might be worthwhile to keep this open until @neelance gets a chance to see this. I suspect there are API change opportunities to consider here, ones that could make the user experience better. F…
shurcooL commented on Unexpected panic when using callback in github.com/neelance/go1w
Also, have you tried this? ```diff promise.Call("then", callback.New(func(args []js.Value) { fmt.Println(args) -})) +}).Value) ``` Since `callback` package isn't documented yet, it's no…
shurcooL commented on Unexpected panic when using callback in github.com/neelance/go1w
@johanbrandhorst This may or may not be related, bu the http://google.com URL doesn't permit CORS, so the code you tried to execute is expected to fail in browser: ![image](https://user-images.git…
shurcooL commented on Test failure in TestDependencies (s… in github.com/neelance/go1w
If you don't mind a question related to this, why is `callback` a separate package from `syscall/js`? Does it need to be, or was it done for code organization reasons? From what I've seen, its API s…
shurcooL starred github.com/iafan/goplayspace1w
shurcooL pushed to master in dmitri.shuralyov.com/website/gido1w
d228a7ef38c36d1df5e7102927d1e4e031b42b21Regenerate list of packages.
shurcooL commented on Need an option to keep no newline m… in github.com/sourcegraph/go-diff1w
Can you check if the [`Hunk.OrigNoNewlineAt`](https://godoc.org/sourcegraph.com/sourcegraph/go-diff/diff#Hunk.OrigNoNewlineAt) field tracks the information you need? https://github.com/sourcegraph…
shurcooL commented on not call Flush can also print log r… in github.com/golang/gddo1w
Hi there, This is an issue tracker for the gddo project, used to track bugs in it. People who may know the answer to your question are unlikely to see it here. For asking questions about Go, se…
shurcooL commented on GraphQL Errors not be returned due … in github.com/shurcooL/graphql1w
@mwilli31 I've sent PR #23 which should fix this issue. Could you give it a try and confirm it fixes it for you?
shurcooL pushed to handle-no-data in github.com/shurcooL/graphql1w
9c4e46973c6a6ed48f8e8798d819382ac9c7b733Unmarshal data field only if present.
shurcooL created branch in github.com/shurcooL/graphql1w
handle-no-data
shurcooL commented on Add checks api in github.com/google/go-github1w
> Any recommended pattern to follow when a required field is dependent on another field. Yes, we have no choice but to make them a pointer with `,omitempty`, and just rely on documentation. See…
shurcooL commented on GraphQL Errors not be returned due … in github.com/shurcooL/graphql1w
@mwilli31 Can you share the GraphQL query and/or the Go code to execute that query that you used? I can't reproduce the problem yet.
shurcooL commented on cmd/go: documentation unclear that … in github.com/golang/go1w
I think [CL 109341](https://golang.org/cl/109341) (for issue #22726) has helped this issue somewhat (at least, it implemented a part of what I described in https://github.com/golang/go/issues/21529#i…
shurcooL commented on cmd/go: do nothing with explicitly … in github.com/golang/go1w
This is related to #21529.
shurcooL commented on GraphQL Errors not be returned due … in github.com/shurcooL/graphql1w
Thanks a lot for the information, it's very helpful. I will work on a fix. I suspect the right solution is that `UnmarshalGraphQL` should not return an error on that input. It should return nil err…
shurcooL commented on Add checks api in github.com/google/go-github1w
And this struct should be modified so the required parameters are values, not pointers. They also don't need `,omitempty` option. So: ```Go // CreateCheckRunOptions sets up parameters need to cre…
shurcooL commented on Add checks api in github.com/google/go-github1w
s/the the/the
shurcooL commented on Add checks api in github.com/google/go-github1w
Was this line removed intentionally? It doesn't look like an improvement, so unless you have a reason, I'd suggest reverting it.
shurcooL commented on GraphQL Errors not be returned due … in github.com/shurcooL/graphql1w
Hi, thanks for reporting. > Minor bug where the response from the server is not compliant with the Query Struct and provides valid graphql Errors I'd like to better understand when this can hap…
shurcooL commented on Robust Header Check in github.com/bradleyfalzon/ghinstallation1w
It would be nice to document what the function does. Perhaps something like this: ```Go // addAcceptHeader adds acceptHeader to headers, but only // if the current "Accept" header is not set, or…
shurcooL commented on Robust Header Check in github.com/bradleyfalzon/ghinstallation1w
What about the first part? I still see some comments that don't have a space after `//`.
shurcooL commented on CHANGELOG.md: Fix typos in removed … in github.com/primer/octicons1w
No problem. I noticed that v7.3.0 was missing those 2 icons when upgrading from v6.0.1, so I wanted to check the CHANGELOG to confirm it was intentional. That’s when I spotted the typos.
shurcooL deleted branch in github.com/shurcooL/octicons-11w
patch-1
shurcooL pushed to patch-1 in github.com/shurcooL/octicons-11w
bb52a4c58b119786a626f20fda567a8868b02f2cCHANGELOG.md: Fix typos in removed icon names.
shurcooL commented on specify http username & password, a… in github.com/shurcooL/gtdo1w
`https://go.googlesource.com/go` is known not to need authentication, so this shouldn't be done here.
shurcooL commented on Reduce memory use in github.com/gregjones/httpcache1w
The first commit (using `*{bytes,strings}.Reader` instead of `*bytes.Buffer`) looks good to me. It simplifies code and performs better. Second and third commits have an inconsistency. Inside `Cach…
shurcooL commented on suggestion: Unify Foo and FooEXT fu… in github.com/go-gl/gl1w
> I can use `GenFramebufersEXT` as a fallback of `GenFrambuffers` (or vise versa?), but should callers care of this? Can we have unified function, `GenFramebuffers` in this case, and always use them?…
shurcooL commented on Propagate context on token refresh … in github.com/bradleyfalzon/ghinstallation1w
> Yeah I added the new method to avoid making a breaking API change. Should I just add the context argument to the Token() method? Here's what I wrote in #8 about this: > Given the breaking cha…
shurcooL commented on carddav: Remove duplicate package c… in github.com/emersion/go-webdav1w
Thank you for the quick review. :)
shurcooL deleted branch in github.com/shurcooL/go-webdav1w
patch-1
shurcooL commented on Question: Should we change the lern… in github.com/primer/octicons1w
Given #208 and #220 have been merged, should this issue be closed now? Or is there more to be done here?
shurcooL pushed to patch-1 in github.com/shurcooL/go-webdav1w
0ad8fa5233df2baaf424895cc6dcb6bdd8d14351carddav: Remove duplicate package comment
shurcooL pushed to master in github.com/shurcooL/home1w
4ed7cfc947ebdc15b146b624497ad645c78a2eafAdd support for shurcool to see Gerrit changes.
shurcooL pushed to master in dmitri.shuralyov.com/service/change1w
9fd50fad53a60a8f07cc81abed8d3a3dc4aa770bgerritapi: Update for go-gerrit API changes.
shurcooL deleted branch in github.com/andygrunwald/go-gerrit1w
expose-baseURL
shurcooL pushed to master in github.com/andygrunwald/go-gerrit1w
5632c7fad122548dfabeb3011e98d3b0a08a89d7Expose the client's BaseURL.
90fea2ddaa1296d860b670a12a06fb7040eb82c8Improve consistency of baseURL trailing slash handling.
027139b1be4290457df202b74c84d82d5188b10dImprove documentation consistency.
shurcooL commented on Expose the client's BaseURL. in github.com/andygrunwald/go-gerrit1w
There are no outstanding review comments, and this is ready from my side. Merging (preserving individual commits, since they're logical, independent, with descriptive commit messages).
shurcooL deleted branch in github.com/google/go-github1w
README-githubv4-link
shurcooL starred github.com/tfriedel6/canvas1w
shurcooL commented on Expose the client's BaseURL. in github.com/andygrunwald/go-gerrit1w
> I forgot the fact that baseURL of the client struct is not exported and only accessible through the getter function. As of this PR. It wasn't accessible before, which is what I wanted to fix. :)
shurcooL created branch in github.com/google/go-github1w
README-githubv4-link
shurcooL pushed to master in github.com/shurcooL/home1w
e3d7309cc59bf25a8326ecc4aba1c5a118dbf4a9Update for githubql package rename.
shurcooL pushed to master in dmitri.shuralyov.com/app/changes1w
10f5d9731d4e9f493558e249aae39706e397e026cmd/changesdev: Update for githubql package rename.
shurcooL pushed to master in github.com/shurcooL/notifications1w
dff011de811913011425fb3f9caf38df1570050dgithubapi: Update for githubql package rename.
shurcooL pushed to master in github.com/shurcooL/events1w
d9c94830a4e26ae963da672baa2d17640cabbddagithubapi: Update for githubql package rename.
ffd6705898ad9fda846e5bf47b5c403893442e59Remove commented out Store interface.
shurcooL pushed to master in dmitri.shuralyov.com/service/change1w
c380a3d196cbdd6ee199615434e6eb4ec25c0430githubapi: Update for githubql package rename.
7b7788c77483cdab4134f879966f36cfad8e48c6gerritapi: Fetch messages in Get; simplify project helper.
shurcooL pushed to master in github.com/shurcooL/issuesapp1w
dd604f920142cbaf6c200fe58d9e5ab535d4599acmd/githubissues: Update for githubql package rename.
shurcooL pushed to master in github.com/shurcooL/issues1w
c5ffda8383060586c180b557ba5de0274285853cgithubapi: Update for githubql package rename.
shurcooL pushed to master in github.com/shurcooL/resume1w
d835ca1ec3cc45c1df6287be3bf15488e5ced493Update for githubql package rename.
shurcooL pushed to master in github.com/shurcooL/graphql1w
2feaaa7394a54a63e6d46b6400cc204abf30deb6Update for githubql package rename.
shurcooL pushed to master in github.com/shurcooL/githubv41w
19298c78142b5fe80c2cdaa2091bc51cbc3a94fcRename package from githubql to githubv4.
shurcooL commented on Proposal: Rename package to githubv… in github.com/shurcooL/githubql1w
I wrote the instructions for updating code in the commit message, but I'll copy it here: > This is a breaking API change. Updating code is easy. > It can be done with an automated tool or by hand…
shurcooL commented on Propagate context on token refresh … in github.com/bradleyfalzon/ghinstallation1w
When context support was added to some places in standard library, they used just a `Context` suffix (rather than `WithContext`). E.g: - https://godoc.org/os/exec#CommandContext - https://godoc.o…
shurcooL commented on Expose the client's BaseURL. in github.com/andygrunwald/go-gerrit1w
Do you mean the one above the `baseURL` field of `Client` struct? ```Go // baseURL is the base URL of the Gerrit instance for API requests. // It must have a trailing slash. baseURL *url.URL `…
shurcooL commented on ID type intersects poorly with map[… in github.com/shurcooL/githubql1w
@mwilli31 You need to explicitly specify the GraphQL type for variables, like so: ```Go variables := map[string]interface{}{ "type": githubql.String("TestType"), "description": githubq…
shurcooL pushed to master in github.com/shurcooL/githubql1w
shurcooL pushed to master in github.com/shurcooL/githubql1w
c954749b8eacdb439f89d385fd6b019d51dd8631Regenerate for schema changes by 2018-05-04.
shurcooL commented on missing node "golang.org/x/net/lex/… in github.com/shurcooL/httpgzip2w
@h8liu I've merged the fix into `master` by now, but I see that current builds on smallrepo.com (as recent as 4 minutes ago) are still using the smlrepo fork: https://smallrepo.com/builds/20180508…
shurcooL commented on Warning in a procedure in github.com/go-gl/glfw2w
The warnings are coming from the GLFW C code, so there's nothing we need to do on our end. They're likely going to be fixed in the next release of GLFW.
shurcooL deleted branch in github.com/shurcooL/webgl2w
patch-1
shurcooL pushed to master in github.com/gopherjs/webgl2w
39bd6d41eeb587730fcaa65adf71978fb10675bcREADME: Specify WebGL 1.0 as the version. (#17)