After the inline comment is resolved, this change LGTM. (1 comment)
This may need to be updated too, if the /search endpoint is removed. (1 comment)
Fixes golang/go#44613. https://farmer.golang.org/#health reports a problem with the tip.golang.org website.
[CL 293412](https://golang.org) removed the -index flag. `cmd/tip` needs to be updated accordingly. Otherwise i… (1 comment)
This does not get a version of x/tools that includes CL 293449. (1 comment)
Please rename the PR title to:
content/context-and-structs.article: fix duplicate arguments
Thanks for sending the change.
I considered it before the release, but found that even after this change there's one more instance still using nil without being wrapped in <code>. When … (1 comment)
Can you update this to require a version of x/tools that includes CL 293449?
(Same comment for the equivalent blog and talks CLs.) (4 comments)
This change LGTM.
Given that the functionality this package provides is so trivial, but the overhead caused by having an indirect abstraction is relatively constant, I think things wou… Resolved in [CL 293771](https://golang.org/cl/293771). We've updated our release process to start creating branches that follow the new internal naming scheme, and it has been used with the Go 1.16 release.
We've also updated permissions in [CL 283262…
As of this CL, this image now contains both a normal and faketime Go installation, and what they have in common is they're both built at GO_VERSION version.
Optio… (1 comment)
Done. (2 comments)
Oh, indeed. I see how I got confused:
I initially tested it on the Go 1.16 blog post like https://golang.org/blog/go1.16, which didn’t work, but that looks like a bug due to it havin… I too have observed this:
<img src="https://user-images.githubusercontent.com/1924134/108784909-5f2ae180-753e-11eb-88e6-f93311e9c182.png" width=303px>
When these trybots take the longest, they … Copied from Go commit 094048b93845c08e0f2db8639764f9564e64835b,
deleted there in CL 295209. The "Current Tree Status" was updated from "Open for bug fixes only" to "Open for Go 1.17 development". I've sent an announcement to [golang-dev](https://groups.google.com/g/golang-dev/c/VNJFUxHWLHo/… This template is based on CL 248198 and previous ones like it.
Continue to eagerly include often-used sections, and clarify that
the TODO is about completing the section, or removing if it turns
out … Tracking bug for writing the Go 1.17 Release Notes.
The latest state on tip can be viewed at https://tip.golang.org/doc/go1.17 (the page doesn't exist yet, so it's currently 404; that'll be fixed … Can this be fixed by changing `t.Errorf("cannot check consistency for filesystem-local replacement in module ...` into `t.Fatalf`? It seems the rest of the test doesn't produce a helpful output if th… (1 comment)
Phew, done reviewing this stack (first pass). Please me know when you're ready for me to take another look at what's still left. (9 comments)
I think these are all gone except "text", which isn't included here.
No longer does. Also s/godoc/golangorg/ if you choose to include this file in this CL.
These are gone.… (3 comments)
Need to add a "golang/go" prefix since this isn't the main repo:
These lines can be updated to match the new behavior.
The current redirect code handles im… (2 comments)
This is needed in prod mode, but less sure whether it's needed in local mode. I guess having it in both modes is fine for now.
Consider making it more clear that it's okay for this to … (1 comment)
🎉 (3 comments)
The commit message doesn't say, but I understand we consider gatefs no longer needed (and will follow up if it turns out otherwise).
Please document bindFS and its behavior.
It should… (1 comment)
Deleting RootType SGTM. I'm not sure if I understand whether the replacement is sound, but I know all this code is being deleted in a future CL in this stack, so I skipped reviewing that… (3 comments)
Note: we can delete the internal/godoc/golangorgenv package even without landing CL 293418 and CL 293419. Everything in x/website can use internal/env.
But I'll wait to see your replie… (2 comments)
As an aside: it's unfortunate in that we could have—it would've been fast to have it enabled since golang.org used to serve only the standard library packages (analysis mode would get… (2 comments)
These changes aren't correct, looks like a bad "replace all", please undo.
This change may actually be okay, but that package is being deleted in the next CL in the stack, and this REA… (1 comment)
I worry a 6 character hash may stop being uniquely identifying within Go's lifetime with a high probability. Can you please replace it a full length one also add the CL number:
This i… (3 comments)
See my comment on CL 293449. There are some concerns here and I think we can skip this for now, revisit it after.
This function is unused. I understand it was meant to be assigned to p… (1 comment)
See my comment on CL 293449. There are some concerns here and I think we can skip this for now, revisit it after. (2 comments)
IIUC the motivation for this CL is to simplify things given the x/website stack ending at CL 293495. However this package is used in more places than just x/website, so I'd suggest let'… (3 comments)
Question. We haven't supported URLs like https://golang.org/blog/go116-module-changes in the past, only https://golang.org/blog. Is it intentional they're added? What's the benefit comp… (1 comment)
This period can be removed since it's preceded by an ellipsis. (5 comments)
Remove " && !prod"; this file is meant to be shared between local and prod modes.
(This will fix build errors like "undefined: httpAddr".)
Were these constraints moved on top of the c… (3 comments)
Since this change also removes the -zip flag (item 3 in that list).
(FYI I've reviewed up to CL 293489 in this stack so far; will resume after a meeting… (2 comments)
I see, thanks for the explanation.
Thanks for the explanation (I see no manual editing is ever required: I can use gotip fmt instead).
> If you are using Go built from master (I hope … Indeed, this isn't relevant by now, closing. Fixed by [CL 292590](https://golang.org/cl/292590), closing. (It didn't get closed automatically because the "golang/go" prefix wasn't included.)
@magical The commit message suggests that the migr…
If this isn't needed for #44222 (since no package from x/build is vendored into the main repo), I'd prefer we submit this after Go 1.17 is out, to avoid adding manual maintenance overhea… (1 comment)
If we need to change the build constraints before Go 1.17 is released, will we need to update the //go:build line by hand? As far as I understand, gofmt won't do it for another 6~ months. (1 comment)
The previous value seems correct to me.
It's there to match very old macOS release files, like "go1.4.darwin-386-osx10.8.pkg", that had a "-osx10.8" suffix. See https://golang.org/dl/#g… When github.Client.Do returns a non-nil error, the *github.Response
may be nil if a request wasn't even made. Check for that to avoid a
Fixes golang/go#44438. Observed this panic from 43 days ago:
2021/02/04 06:15:49 Retrieving PR golang/blog#34 from GitHub using Etag "W/\"8a7ebf3c8163c89f842d22ec8a135ec89f9af0061f034bbd6a13ad716abff05b\"" ...
pan… (1 comment)
Is it okay there's no tracking issue being opened for this? Based on https://github.com/golang/crypto/pull/143#issuecomment-782377386, this issue might be affecting more services than just GopherBot. (2 comments)
The prefix should be "acme/autocert:".
Lower case 'include' after.
Please wrap these lines, and move the fixes line separately:
More compliant ...
with Pebble ...
Fixes … It should work now. But, from GerritBot logs:
2021/02/19 21:40:32 GitHub: 0/5000 calls remaining; Reset in 7m52.975721092s
It likely shares rate limit with GopherBot, so issue #44406 … @FiloSottile [GerritBot](http://golang.org/wiki/GerritBot) waits for @googlebot to add a "cla: yes" label before starting work. For some reason that hasn't happened here yet. Fixes golang/go#44426. (1 comment)
Please remove the "x/blog/" prefix, leaving just "content:".
That prefix is needed in Go issues, because all repositories share the same issue tracker. It's not needed in commit subject… CC @golang/release. (2 comments)
Minor: Consider mj >= 11 so that this number visually matches the "As of macOS *11*.0 (Big Sur), ..." comment on top.
If you prefer leaving it as is, that's good too.
Checking my unde… Thanks for reporting.
CC @golang/release. For now I'll resolve this specific issue by updating freebsd-amd64-race to use the available FreeBSD version, 12.0.
Please file a separate issue about adding new builders that target newer version… The `freebsd-amd64-10_3` builder is long gone (removed in [CL 246639](https://golang.org/cl/246639)), so this specific issue can be closed. (The general tracking issue for TryBot speed is #17104.) The Go 1.17 tree has started adding the windows/arm64 port. The release process now documents the step of creating the first minor
release milestone when issuing a major Go release. That happens before
the 'releasebot -mode=prepare' step.
Add an automated ch… Thanks, we'll deploy today. @toothrot is already on it, please close this issue when done. Yes, I'm doing a deploy now (also for #44414). Thank you for the feedback. I've filed #44426 about improving the Linux installation instructions. Given how important the step of removing the previous /usr/local/go directory before extracting, I think we must include it in the numbered steps.
The current instructions link to https://golang.o… Experience and feedback in #44320 (thank you @jpmieville, @davecheney, @agnivade) suggests that the current Linux installation instructions are prone to a user mistake: missing the step of removing t… @thanm Yes, as Russ said that CL is a follow up to the dev.regabi merge and is okay. Thanks. (1 comment)
Thanks for reviewing. I'll submit this if/when #44402 is approved for backport. While investigating x, I noticed in GopherBot's logs that it was failing to take some actions due to exceeding GitHub API rate limit quota:
$ kubectl logs -f gopherbot-deployment-6c6d86d5b9-s… This may have been resolved by placing the Go Bot account (and Gerrit Bot) in a "Service Users" group for Gerrit's Attention Set feature (documented [here](https://gerrit-review.googlesource.com/Docu… I noticed that GopherBot hadn't closed #44346 even though [CL 293411](https://golang.org/cl/293411) was submitted. I figured out the problem by looking at its logs and seeing:
2021/02/19 00:2… Fixes breakage accidentally introduced by https://golang.org/cl/291711.
Updates #44295. @gopherbot Please backport this to Go 1.16. It is a safe documentation fix needed to restore the gopher image at https://pkg.go.dev/std#section-readme (and any other place that displays the README of… CC @golang/release. @heschik Yep, that makes sense. The reason I've used this early-in-cycle path for now is the same reason I closed https://github.com/golang/go/issues/27155#issuecomment-779940755: we currently don't … As a first step, let's make this a recurring early-in-cycle release-blocking issue, similar to #40705 and #36905, so that this task isn't missed.
I'll place it in Go 1.17 milestone now, and when […