Today
dmitshur commented on Setting go version to "1.10.x" inst… in github.com/travis-ci/travis-ci1h
I believe this issue is resolved as of https://github.com/travis-ci/travis-build/pull/1442#issuecomment-413131247. @cezarsa Please restart your builds and confirm, then feel free to close this issue …
I believe this issue is resolved as of https://github.com/travis-ci/travis-build/pull/1442#issuecomment-413131247. @cezarsa Please restart your builds and confirm, then feel free to close this issue …dmitshur commented on gimme 1.x is selecting a beta relea… in github.com/travis-ci/gimme1h@FiloSottile This issue should be resolved as of https://github.com/travis-ci/travis-build/pull/1442#issuecomment-413131247. Try restarting your failed builds. If it's resolved for you too, this issu…
@FiloSottile This issue should be resolved as of https://github.com/travis-ci/travis-build/pull/1442#issuecomment-413131247. Try restarting your failed builds. If it's resolved for you too, this issu…dmitshur commented on Update gimme to support `.x` Go ver… in github.com/travis-ci/travis-build2hConfirmed! I’ve restarted [the same build](https://travis-ci.org/shurcooL/home/jobs/416164962) again, and this time I see:
```
Updating gimme
…
$ gimme version
v1.5.1
$ go version
go ver…
Confirmed! I’ve restarted [the same build](https://travis-ci.org/shurcooL/home/jobs/416164962) again, and this time I see:
```
Updating gimme
…
$ gimme version
v1.5.1
$ go version
go ver…Yesterday
dmitshur commented on Update gimme to support `.x` Go ver… in github.com/travis-ci/travis-build16h@cotsog Thanks for following up.
I created a new branch in one of my repos, which triggered a new build. Its output is here:
https://travis-ci.org/shurcooL/home/jobs/416164962
You can see th…
@cotsog Thanks for following up.
I created a new branch in one of my repos, which triggered a new build. Its output is here:
https://travis-ci.org/shurcooL/home/jobs/416164962
You can see th…dmitshur commented on x/build: fix gomote ssh to COS-base… in github.com/golang/go17h[CL 129356](https://golang.org/cl/129356) and deploying the new version of `cmd/buildlet` were sufficient to resolve the issue. We just needed to move the SSH server being started to a non-22 port to…
[CL 129356](https://golang.org/cl/129356) and deploying the new version of `cmd/buildlet` were sufficient to resolve the issue. We just needed to move the SSH server being started to a non-22 port to…This Week
dmitshur commented on godoc/dl: go-import meta tag isn't … in github.com/golang/1dYes, this is a very minor issue. Anyone just doing `go get golang.org/dl/gox.y.z` isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).
Yes, this is a very minor issue. Anyone just doing `go get golang.org/dl/gox.y.z` isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).dmitshur commented on godoc/dl: go-import meta tag isn't … in github.com/golang/1dYes, this is a very minor issue. Anyone just doing `go get golang.org/dl/gox.y.z` isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).
Yes, this is a very minor issue. Anyone just doing `go get golang.org/dl/gox.y.z` isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).dmitshur commented on all: subrepos need to be green in github.com/golang/go1dThe x/tools subrepo tests are currently passing on tip but failing on 1.10 and 1.9 according to https://build.golang.org/. The failures are related to the new `x/tools/go/packages` package have start…
The x/tools subrepo tests are currently passing on tip but failing on 1.10 and 1.9 according to https://build.golang.org/. The failures are related to the new `x/tools/go/packages` package have start…dmitshur commented on gimme 1.x is selecting a beta relea… in github.com/travis-ci/gimme2dIn addition to what @AlekSi mentioned above, there is also issue https://github.com/travis-ci/travis-ci/issues/9652 tracking this.
It seems the only remaining step to resolve this is for Travis CI…
In addition to what @AlekSi mentioned above, there is also issue https://github.com/travis-ci/travis-ci/issues/9652 tracking this.
It seems the only remaining step to resolve this is for Travis CI…dmitshur commented on Update gimme to support `.x` Go ver… in github.com/travis-ci/travis-build2d> We'll try to get [a gimme v1.5.1 release](https://github.com/travis-ci/gimme/pull/156) and it should be incorporated in a build automatically.
Following up on this. The gimme [v1.5.1 release](ht…
> We'll try to get [a gimme v1.5.1 release](https://github.com/travis-ci/gimme/pull/156) and it should be incorporated in a build automatically.
Following up on this. The gimme [v1.5.1 release](ht…
dmitshur commented on Mr Dimitri in github.com/shurcooL/github_flavored_markdown2dHi there. Thanks for the compliment.
If you're interested in the topic of LCD monitors, I'd suggest you check out https://www.testufo.com/ and https://www.blurbusters.com/ websites, as well as fol…
Hi there. Thanks for the compliment.
If you're interested in the topic of LCD monitors, I'd suggest you check out https://www.testufo.com/ and https://www.blurbusters.com/ websites, as well as fol…
Last Week
dmitshur commented on x/build/cmd/gopherbot: lock commit … in github.com/golang/go4dI've looked into this a bit.
I think a better place to implement this might be in `x/build/cmd/gitmirror`, the command responsible for mirroring the canonical git repositories from go.googlesource…
I've looked into this a bit.
I think a better place to implement this might be in `x/build/cmd/gitmirror`, the command responsible for mirroring the canonical git repositories from go.googlesource…dmitshur commented on natives/runtime: add pkgpath method… in github.com/gopherjs/gopherjs6dThanks for PR @egonelbre! This looks like the right fix. I’ll try to get to fully reviewing and merging it within the next few days.
Thanks for PR @egonelbre! This looks like the right fix. I’ll try to get to fully reviewing and merging it within the next few days.dmitshur commented on Go 1.11 support. in github.com/gopherjs/gopherjs6d@paralin You’ll need the patch from PR https://github.com/gopherjs/gopherjs/pull/846 to fix that. I haven’t had a chance to merge it yet, but the change looks right from a quick look.
@paralin You’ll need the patch from PR https://github.com/gopherjs/gopherjs/pull/846 to fix that. I haven’t had a chance to merge it yet, but the change looks right from a quick look.dmitshur commented on Panic: reflect.Value.Interface: can… in github.com/shurcooL/githubv41wI've investigated this, and it's not the same issue as what I thought it might be.
Your struct `m` where the results of the mutation get populated contains an unexported field:
```Go
var m str…
I've investigated this, and it's not the same issue as what I thought it might be.
Your struct `m` where the results of the mutation get populated contains an unexported field:
```Go
var m str…dmitshur commented on Panic: reflect.Value.Interface: can… in github.com/shurcooL/githubv41wThanks a lot for reporting. I suspect this issue is https://github.com/shurcooL/graphql/issues/11. I've already started a fix for it locally, I just need to finish it and push it. I'll confirm whethe…
Thanks a lot for reporting. I suspect this issue is https://github.com/shurcooL/graphql/issues/11. I've already started a fix for it locally, I just need to finish it and push it. I'll confirm whethe…dmitshur commented on x/build/devapp: duplicate CL lines … in github.com/golang/go1wI've deployed the new version and confirmed that the bug is fixed in production.
### Before
 because the GitHub GraphQL API v4 doesn't make use of the…
Yes, it is a long term goal. However, I don't plan to work on this soon. It's not needed for [githubv4](https://github.com/shurcooL/githubv4) because the GitHub GraphQL API v4 doesn't make use of the…dmitshur commented on use gopkg.in to make buildable with… in github.com/shurcooL/github_flavored_markdown1wThanks for reporting this and sending the PR. I'd like to investigate and understand the issue better.
Can you post the commands for building this with modules in Go 1.11 and the output you get? I…
Thanks for reporting this and sending the PR. I'd like to investigate and understand the issue better.
Can you post the commands for building this with modules in Go 1.11 and the output you get? I…dmitshur commented on x/build/devapp: duplicate CL lines … in github.com/golang/go1w[`maintner.GerritCL`](https://godoc.org/golang.org/x/build/maintner#GerritCL) has a field `GitHubIssueRefs` of type `[]GitHubIssueRef`. Currently, if the CL description mentions the same issue more t…
[`maintner.GerritCL`](https://godoc.org/golang.org/x/build/maintner#GerritCL) has a field `GitHubIssueRefs` of type `[]GitHubIssueRef`. Currently, if the CL description mentions the same issue more t…dmitshur commented on x/build/devapp: duplicate CL lines … in github.com/golang/go1wThis seems to happen when the CL description mentions the same issue more than once. For example, here's a current occurrence of this bug:
 is not included in gimme v1.5.0, a ne…
This is strange, but I’ve seen gimme v1.5.0 already used in my previous builds.
Additionally, the recent fix (
https://github.com/travis-ci/gimme/pull/153) is not included in gimme v1.5.0, a ne…Earlier
dmitshur commented on x/build/devapp: show GitHub usernam… in github.com/golang/go1wWe also have issue #23964, which is the root problem. When/if that is resolved, this issue will be obsolete.
If that issue is lot of work and takes a long while, while this one is quick and easy, …
We also have issue #23964, which is the root problem. When/if that is resolved, this issue will be obsolete.
If that issue is lot of work and takes a long while, while this one is quick and easy, …dmitshur commented on generator: use go/format to format … in github.com/shurcooL/vfsgen1wThanks for the PR. (Please ignore the CI failure, it happens due to a current issue on Travis CI (see https://github.com/travis-ci/travis-ci/issues/9652#issuecomment-409789014).) Let's discuss the de…
Thanks for the PR. (Please ignore the CI failure, it happens due to a current issue on Travis CI (see https://github.com/travis-ci/travis-ci/issues/9652#issuecomment-409789014).) Let's discuss the de…dmitshur commented on 1.x selects 1.11beta1 in github.com/travis-ci/gimme1wThanks for the heads up @philpennock. I reported it to their support email, and afterwards found https://github.com/travis-ci/travis-ci/issues/9652, which looks like a decent issue for the purpose of…
Thanks for the heads up @philpennock. I reported it to their support email, and afterwards found https://github.com/travis-ci/travis-ci/issues/9652, which looks like a decent issue for the purpose of…dmitshur commented on Setting go version to "1.10.x" inst… in github.com/travis-ci/travis-ci1w> `1.x` picking up `go1.11beta1`
This was issue https://github.com/travis-ci/gimme/issues/152 in `gimme`. It has recently been resolved. However, as I understand, what's remaining is for Travis CI…
> `1.x` picking up `go1.11beta1`
This was issue https://github.com/travis-ci/gimme/issues/152 in `gimme`. It has recently been resolved. However, as I understand, what's remaining is for Travis CI…dmitshur commented on go get honnef.co/go/js/dom in github.com/dominikh/go-js-dom1wThanks for reporting. This issue has been resolved by now, so closing.
See https://github.com/dominikh/go-tools/issues/269#issuecomment-409646894 for some additional context on this.
Thanks for reporting. This issue has been resolved by now, so closing.
See https://github.com/dominikh/go-tools/issues/269#issuecomment-409646894 for some additional context on this.dmitshur commented on How to serve gzipped bytes? in github.com/shurcooL/vfsgen2wYes, there is. What you’re looking for is [`httpgzip.FileServer(assets, ...)`](https://godoc.org/github.com/shurcooL/httpgzip#FileServer)\.
[`httpgzip`](https://godoc.org/github.com/shurcooL/httpg…
Yes, there is. What you’re looking for is [`httpgzip.FileServer(assets, ...)`](https://godoc.org/github.com/shurcooL/httpgzip#FileServer)\.
[`httpgzip`](https://godoc.org/github.com/shurcooL/httpg…dmitshur commented on 1.x selects 1.11beta1 in github.com/travis-ci/gimme2wThanks for resolving this issue in `gimme`!
Is there an existing issue tracking the task of updating the version of `gimme` that travis-ci.org uses?
I tried restarting [my build](
https://trav…
Thanks for resolving this issue in `gimme`!
Is there an existing issue tracking the task of updating the version of `gimme` that travis-ci.org uses?
I tried restarting [my build](
https://trav…dmitshur commented on fix go vet error with go1.11 in github.com/google/go-github3wI don't think it's appropriate to add this much code in between `got, err := ...` and the `if err != nil ...` statements while keeping the variable name just `err` (see [here](https://dmitri.shuralyo…
I don't think it's appropriate to add this much code in between `got, err := ...` and the `if err != nil ...` statements while keeping the variable name just `err` (see [here](https://dmitri.shuralyo…dmitshur commented on simple: skip "empty branch" check i… in github.com/dominikh/go-tools3w> I can't see a simpler/better way to do it,
As a data point, the way I got rid of it was by commenting out the entire empty branch, see the diff of `issues.go` in https://github.com/shurcooL/issu…
> I can't see a simpler/better way to do it,
As a data point, the way I got rid of it was by commenting out the entire empty branch, see the diff of `issues.go` in https://github.com/shurcooL/issu…dmitshur commented on fix go vet error with go1.11 in github.com/google/go-github3wWe'll need to think about a better long term way to deal with gofmt changes.
I think the best future proof solution is to have the `diff -u <(echo -n) <(gofmt -d -s .)` check run only for one of t…
We'll need to think about a better long term way to deal with gofmt changes.
I think the best future proof solution is to have the `diff -u <(echo -n) <(gofmt -d -s .)` check run only for one of t…dmitshur commented on lint/mutexHat: add a comment for sy… in github.com/go-critic/go-critic3wTo clarify, in that entry, the idea was that the comment was implicit and therefore not required.
> So, *without needing to write the comment*, the above is implicitly understood to be equivalent
I…
To clarify, in that entry, the idea was that the comment was implicit and therefore not required.
> So, *without needing to write the comment*, the above is implicitly understood to be equivalent
I…dmitshur commented on Switch to 1.11beta2 in github.com/gopherjs/gopherjs3wAccording to the CI failure, the current `go1.11` code is no longer compatible with beta 2. It will need to be updated.
According to the CI failure, the current `go1.11` code is no longer compatible with beta 2. It will need to be updated.dmitshur commented on Link to demo movie is broken. in github.com/audreylim/go-presenter3wThe domain (and port) has changed. The following updated link should work:
http://instantshare.win/1vs4fiwjm924q.mov
The domain (and port) has changed. The following updated link should work:
http://instantshare.win/1vs4fiwjm924q.movdmitshur commented on Handle 1.x as a pattern correctly in github.com/travis-ci/gimme4wFriendly ping; my Travis build is still failing because of #152, so I'd really like to help fix it if there's anything I can do.
Friendly ping; my Travis build is still failing because of #152, so I'd really like to help fix it if there's anything I can do.dmitshur commented on Transfer request has incorrect json… in github.com/google/go-github1moThanks for following up on this @juliaferraioli!
As an aside, I got a chance to use the Repository Transfer API recently (I changed my GitHub username and wanted to move all my repos under old nam…
Thanks for following up on this @juliaferraioli!
As an aside, I got a chance to use the Repository Transfer API recently (I changed my GitHub username and wanted to move all my repos under old nam…
dmitshur commented on Add support for the repository tran… in github.com/google/go-github1moI just noticed now, I think `json:"team_id,omitempty"` should've been `json:"team_ids,omitempty"`, isn't that right?
From https://developer.github.com/v3/repos/#transfer-a-repository:
![image](…
I just noticed now, I think `json:"team_id,omitempty"` should've been `json:"team_ids,omitempty"`, isn't that right?
From https://developer.github.com/v3/repos/#transfer-a-repository:
?
The API would be the same as v1, except current `js` fields would be rep…
Agreed.
@dominikh How do you feel about a `dom` v2 API at the import path `honnef.co/go/js/dom/v2` (package name `dom`)?
The API would be the same as v1, except current `js` fields would be rep…dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1moSorry, I missed that part of your comment.
Sorry, I missed that part of your comment.dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1moI think I've found a potentially show-stopping problem with implementing this issue. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many obj…
I think I've found a potentially show-stopping problem with implementing this issue. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many obj…dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1moHowever, I think I've found a potentially show-stopping problem. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many objects. E.g.:
https…
However, I think I've found a potentially show-stopping problem. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many objects. E.g.:
https…dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo> I did all the changes mentioned above.
Perfect, thanks!
> I am wondering if the very exact build target `+build js,!wasm` and `+build js,wasm` is not going to cause issue to code completion a…
> I did all the changes mentioned above.
Perfect, thanks!
> I am wondering if the very exact build target `+build js,!wasm` and `+build js,wasm` is not going to cause issue to code completion a…dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1moLet's remove the import comment here as well, so it's only in `doc.go` file.
Let's remove the import comment here as well, so it's only in `doc.go` file.dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1moThe package comment must be immediately preceding the package clause. There can't be a blank line separating them, otherwise it's not parsed as a package comment by `godoc`. So please remove the blan…
The package comment must be immediately preceding the package clause. There can't be a blank line separating them, otherwise it's not parsed as a package comment by `godoc`. So please remove the blan…dmitshur commented on Error variable naming in dmitri.shuralyov.com/idiomatic-go1mo
That's an interesting approach. I haven't seen that before. Thanks for sharing.
I know there are tools such as [`errcheck`](https://github.com/kisielk/errcheck) and [`staticcheck`](https://github.co…
That's an interesting approach. I haven't seen that before. Thanks for sharing.
I know there are tools such as [`errcheck`](https://github.com/kisielk/errcheck) and [`staticcheck`](https://github.co…dmitshur commented on Error variable naming in dmitri.shuralyov.com/idiomatic-go1mo@storozhukBM I guess both are fair style choices. I wanted to pick one, so that all my code would be consistent. `specificError` seemed more natural to me: if the first word is long and written in fu…
@storozhukBM I guess both are fair style choices. I wanted to pick one, so that all my code would be consistent. `specificError` seemed more natural to me: if the first word is long and written in fu…dmitshur commented on Net/http package in github.com/gopherjs/gopherjs1mo`http.Client` in GopherJS has 2 implementations: one based on Fetch API, another based on XMLHttpRequest API. It picks whichever is available in that order. Both of those tend to be available in brow…
`http.Client` in GopherJS has 2 implementations: one based on Fetch API, another based on XMLHttpRequest API. It picks whichever is available in that order. Both of those tend to be available in brow…dmitshur commented on rpc.Dial not supported in gopherjs? in github.com/gopherjs/gopherjs1moBrowsers don't provide access to raw TCP sockets, which `net/rpc` uses, so it can't work. This is why the [compatibility table](https://github.com/gopherjs/gopherjs/blob/master/doc/packages.md) says …
Browsers don't provide access to raw TCP sockets, which `net/rpc` uses, so it can't work. This is why the [compatibility table](https://github.com/gopherjs/gopherjs/blob/master/doc/packages.md) says …dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1mo@dominikh, in PR #59, you said:
> Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it.
(I wanted to move the discussion here…
@dominikh, in PR #59, you said:
> Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it.
(I wanted to move the discussion here…dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo> Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it.
I would like to avoid it too, but out of all alternatives, it seems the …
> Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it.
I would like to avoid it too, but out of all alternatives, it seems the …dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1moFor now, I'd prefer we avoid duplicating the package comment, since we can avoid it. Let's delete it here and in `dom.go`, and move it to a new file `doc.go` that just has the package comment and pac…
For now, I'd prefer we avoid duplicating the package comment, since we can avoid it. Let's delete it here and in `dom.go`, and move it to a new file `doc.go` that just has the package comment and pac…dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1moWe do not want to modify the signature. First, it causes the API to differ between GopherJS and Wasm. Second, it causes `*htmlDocument` to no longer satisfy the `Document` interface:
```
panic: i…
We do not want to modify the signature. First, it causes the API to differ between GopherJS and Wasm. Second, it causes `*htmlDocument` to no longer satisfy the `Document` interface:
```
panic: i…dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo> I think this package needs to shift towards being code generated from the HTML spec
Such a drastic change would need to be considered for v2 or another package. It’s not in scope of this PR/is…
> I think this package needs to shift towards being code generated from the HTML spec
Such a drastic change would need to be considered for v2 or another package. It’s not in scope of this PR/is…dmitshur commented on all: WebAssembly ("wasm") support in github.com/golang/go1mo@omac777 For GopherJS, many people use high-level bindings for various browser APIs rather than the low-level `js` package directly. I suspect a similar approach will be most popular with Wasm too. I…
@omac777 For GopherJS, many people use high-level bindings for various browser APIs rather than the low-level `js` package directly. I suspect a similar approach will be most popular with Wasm too. I…dmitshur commented on Warnings in MacOS when go-getting a… in github.com/go-gl/gl1moI can't reproduce this on my system:
```
~ $ export GOPATH=/tmp/empty
~ $ go get -u github.com/go-gl/gl/v3.3-core/gl
~ $
```
What version of Go are you using?
I'm on a Mid-2015 15" MBP, macOS 10.…
I can't reproduce this on my system:
```
~ $ export GOPATH=/tmp/empty
~ $ go get -u github.com/go-gl/gl/v3.3-core/gl
~ $
```
What version of Go are you using?
I'm on a Mid-2015 15" MBP, macOS 10.…dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1mo@yml Thanks for looking at this and sharing your work. I think that's a great step forward.
The approach I'd like us to use for `dom` is going to be slightly different than the one you've used, bu…
@yml Thanks for looking at this and sharing your work. I think that's a great step forward.
The approach I'd like us to use for `dom` is going to be slightly different than the one you've used, bu…dmitshur commented on Report more details about errors in… in github.com/shurcooL/graphql1moHi, thanks for the PR. I'd like to understand it better, so we can implement a better solution.
Can you tell me under what conditions a non-200 response code is expected from a GraphQL server? How…
Hi, thanks for the PR. I'd like to understand it better, so we can implement a better solution.
Can you tell me under what conditions a non-200 response code is expected from a GraphQL server? How…dmitshur commented on "go get -u honnef.co/go/js/dom" fai… in github.com/dominikh/go-js-dom1moThanks for reporting @h8liu! I suspect we’ll have this fixed within 12 hours. /cc @dominikh
In the meantime, if someone doesn’t have this package and needs to clone it, a workaround is possibl…
Thanks for reporting @h8liu! I suspect we’ll have this fixed within 12 hours. /cc @dominikh
In the meantime, if someone doesn’t have this package and needs to clone it, a workaround is possibl…dmitshur commented on Add Reviewers field to ChangeInfo in github.com/andygrunwald/go-gerrit1mo> Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned.
For anyone who doesn't already know, it'…
> Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned.
For anyone who doesn't already know, it'…dmitshur commented on Go 1.11 support. in github.com/gopherjs/gopherjs1moI've started working on this on [`go1.11`](https://github.com/gopherjs/gopherjs/compare/go1.11) branch. I've made good progress so far.
The current status is that most of the fundamental functiona…
I've started working on this on [`go1.11`](https://github.com/gopherjs/gopherjs/compare/go1.11) branch. I've made good progress so far.
The current status is that most of the fundamental functiona…