Activity
Today
dmitshur commented on golang.org/x/build/env/darwin/macstadium: update image documentation5h
(1 comment)
I'm not seeing a change here. Is that intentional?dmitshur reviewed +2 on golang.org/x/build/env/darwin/macstadium: update image documentation8h
(4 comments)
Thanks a lot for improving the documentation for this process, this is very clear and helpful.
I left very minor comments inline.
Nit, a runaway capital letter.
Add "or newer" unless…dmitshur reviewed +2 on doc: [release-branch.go1.14] update the minimum supported macOS version to 10.118h
dmitshur merged a change golang.org/x/build/cmd/coordinator: report errors on all gitmirror instances22h
dmitshur commented on golang.org/x/build/cmd/coordinator: gitmirror health check is flaky because it reports status of a single gitmirror instance, as determined by load balancer22h
Tested the CL above, it worked as expected:
No more flakiness, refreshing the page …dmitshur commented on golang.org/x/build/cmd/coordinator: report errors on all gitmirror instances22h
This is deployed, and it worked as intended to resolve the health check flakiness problem. I'll submit this now. We can follow this up with more changes/issues based on answers to my previous comment.Yesterday
dmitshur merged a change cmd/go: [release-branch.go1.13] fix and skip known Windows test failures1d
dmitshur merged a change cmd/doc: [release-branch.go1.13] skip failing TestDotSlashLookup on Windows1d
dmitshur merged a change cmd/compile/internal/syntax: [release-branch.go1.13] don't hardwire path separator in test1d
dmitshur merged a change os: [release-branch.go1.13] use an actual RemoveAll failure in TestRemoveAllWithMoreErrorThanReqSize1d
dmitshur merged a change net/http: [release-branch.go1.13] deflake TestCancelRequestWithChannelBeforeDo_Cancel1d
dmitshur commented on golang.org/x/build/cmd/coordinator: report errors on all gitmirror instances1d
(1 comment)
Thanks for reviewing!
> I would prefer we did something a little bigger as a more complete fix for the bug, or as a follow up
All 3 of those suggestions sound like improvements to me.
…dmitshur commented on golang.org/x/build/cmd/coordinator: gitmirror health check is flaky because it reports status of a single gitmirror instance, as determined by load balancer1d
> to improve the health check so that it checks all the pods
I've sent [CL 226678](https://golang.org/cl/226678) that implements this.dmitshur opened a change golang.org/x/build/cmd/coordinator: report errors on all gitmirror instances1d
There are 2 gitmirror instances running since 2017 (CL 36801).
The gitmirror health check has been relying on fetching the HTML
status page from the gitmirror service via its load balancer.
If one o…dmitshur commented on golang.org/x/build: linux-riscv64-unleashed builder missing1d
@bradfitz Thanks for the update, that is understandable.
Also thank you for the offer, but maintaining a builder for the riscv64 architecture is not something I have the bandwidth or interest to d…dmitshur commented on golang.org/x/build: linux-riscv64-unleashed builder missing1d
@bradfitz Friendly ping, do you know if you'll be able to look into this, or is there a better person to talk to about the `host-linux-riscv64-unleashed` builder?This Week
dmitshur commented on golang.org/x/build/cmd/gitmirror: reporting "Go repo mirroring hung for 4+ hours" then "ok" then again2d
This issue is happening again now. Refreshing farmer.golang.org sometimes shows that Git mirroring is okay, other times it's showing "repo go: hung? no activity since last success 8h41m49.610989692s …dmitshur commented on go.dev: <input class="DetailsHeader-pathInput"> element is floating strangely2d
Do you know if making its opacity 0 a viable alternative?dmitshur opened an issue go.dev: <input class="DetailsHeader-pathInput"> element is floating strangely2d
### What is the URL of the page with the issue?
https://pkg.go.dev/cmd/link?tab=doc
### What is your user agent?
`Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, l…dmitshur reviewed +2 on golang.org/x/build/dashboard: use race-enabled linker in racecompile builder2d
(3 comments)
Thanks for sending this change. I'm not spotting any issues, some minor comments.
s/becomed/became/
If you don't mind fixing an outdated name while you're here, s/runMake/RunMake/. (r…dmitshur commented on net/http: release callbacks after fetch promise completes3d
(1 comment)
See previous discussion at https://go-review.googlesource.com/c/go/+/226204/2/src/net/http/roundtrip_js.go#113.dmitshur commented on net/http: release callbacks after fetch promise completes3d
(1 comment)
Great. I wasn't sure if it was safe to release while the function is in the middle of running.
The documentation currently says:
> Func.Release must be called to free up resources when…dmitshur opened an issue syscall/js: document more clearly how early js.Func can be released3d
The documentation for [`js.Func`](https://pkg.go.dev/syscall/js#Func) currently says:
> Func.Release must be called to free up resources when the function will not be used any more.
> Release f…dmitshur merged a change net/http: use DOMException.message property in error text3d
dmitshur commented on net/http: release callbacks after fetch promise completes3d
(1 comment)
Patch set 2 is ready for review again.
TRY=wasm-js
This idea seems to have worked out. Implemented it in patch set 2.Last Week
dmitshur commented on net/http: release callbacks after fetch promise completes3d
(1 comment)
Hmm, AbortController is supported on almost all modern browsers by now (https://caniuse.com/#search=AbortController), but if we're supporting browsers where it's not, then this approach …dmitshur commented on net/http: release callbacks after fetch promise completes3d
TRY=wasmdmitshur commented on net/http: use DOMException.message property in error text3d
TRY=wasmdmitshur opened a change net/http: use DOMException.message property in error text3d
Previously, details about the underlying fetch error
were not visible in the net/http error text:
net/http: fetch() failed: <object>
When using the message property, they are:
net/http: fetch() …dmitshur opened a change net/http: release callbacks after fetch promise completes3d
When the request context was canceled, the Transport.RoundTrip method
could return before the fetch promise resolved. This would cause the
success and failure callback functions to get called after t…dmitshur commented on golang.org/x/talks: 2 sets of deploy instructions5d
I investigated whether the deploy instructions in x/build/cmd/tip (which have the auto-deploy feature) can still be used today, but they have atrophied and cannot be used without making changes to ge…dmitshur opened an issue golang.org/x/build/cmd/tip: deploy instructions for talks.golang.org are non-functional5d
(Factoring this out from #36825 to describe this problem in more detail, without derailing the higher level decision in that issue.)
The deploy instructions for talks.golang.org that are in the x/…dmitshur commented on golang.org/x/blog: auto-deploy latest master version5d
An update on this issue. I brought it up and discussed it while talking with @rsc today.
We were in agreement that doing this should be reasonable, given some pre-conditions:
- we should create…dmitshur closed an issue go.dev: include '¶' permalinks in all package doc subheadings5d
dmitshur commented on go.dev: include '¶' permalinks in all package doc subheadings5d
This fix has been deployed and it's working as expected. For example, see:
- https://pkg.go.dev/testing#hdr-Benchmarks
- https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source
- ht…dmitshur commented on golang.org/x/build/dashboard: macOS builders should specify filesystem case sensitivity in Notes field1w
When writing up this issue, I also initially hesitated about suggesting using the `Notes` field, because I noticed all the linux builders don't specify it either.
However, the main point of this i…dmitshur opened an issue golang.org/x/build/dashboard: macOS builders should specify filesystem case sensitivity in Notes field1w
It should be easy to find out whether the filesystem is case sensitive or insensitive (macOS offers both options).
We can put this information in the [`Notes`](https://github.com/golang/build/blob…dmitshur opened an issue golang.org/x/build/cmd/releasebot: create version CL via Gerrit API instead of filesystem+git+codereview1w
During most release types (all other than beta), `releasebot` needs to create a Gerrit CL that update the content of the [`VERSION`](https://github.com/golang/go/blob/release-branch.go1.14/VERSION) f…dmitshur commented on go.dev: display table of contents (TOC) in command documentation1w
I meant to compare with golang.org (powered by x/tools/godoc). godoc.org (powered by github.com/golang/gddo) doesn't implement this feature.
Some implementation notes.
golang.org renders (via […dmitshur opened an issue go.dev: display table of contents (TOC) in command documentation1w
### What is the URL of the page with the issue?
https://pkg.go.dev/cmd/go
### Screenshot
This should be done.
In order to be able to publish new v2 versions, a blocking task is to resolve the current lack of clarity about what import path should be suggested and continued to be used f…dmitshur commented on github.com/shurcooL/sanitized_anchor_name: lowercase package name1w
Hi @kolyshkin, thanks for reporting this issue.
There seem to be a few different things here.
> Apparently (golang/go#26456) golang doesn't like Uppercased letters in package names.
This isn…dmitshur commented on : Gccgo producing wrong objectfiles on AIX 7.1 1w
/cc @ianlancetaylor @thanm @cherrymui @trex58 per [owners](https://dev.golang.org/owners).dmitshur commented on cmd/go: go get should reject import paths with trailing slashes1w
/cc @matloob @bcmills @jayconroddmitshur commented on go.dev: add ability to link to package doc subheadings1w
I've sent a CL that should fix this issue once it is deployed. We can keep this issue open to confirm everything is working as expected.dmitshur commented on golang.org/x/crypto/ssh: TestValidTerminalMode fails with some shells1w
/cc @hanwen @FiloSottile per [owners](https://dev.golang.org/owners).dmitshur edited the wiki1w
dmitshur commented on doc: BuildNameToCertificate deprecated in go 1.14 not mentioned in the release notes [1.14 backport]1w
Approving, as this is a documentation fix.dmitshur commented on doc: BuildNameToCertificate deprecated in go 1.14 not mentioned in the release notes1w
@FiloSottile Yes, to release-branch.go1.14, since the modified file is in the main Go repository.dmitshur commented on golang.org/x/build: linux-amd64-staticlockranking consistently failing1w
@andybons The failure is expected. See #37937 for context.
I enabled the builder a few days in advance of it being needed so that it would be available for SlowBots at the time the CL is ready, and …dmitshur edited the wiki1w
dmitshur commented on : build tag for detecting go modules usage1w
> For my package, in order to support Go Modules and non-modules users, I need to use a build tag so that I can use `github.com/cenkalti/backoff/v4` for go modules users and `gopkg.in/cenkalti/backof…dmitshur closed an issue net/http: support request cancellation on js/wasm1w
dmitshur commented on net/http: support request cancellation on js/wasm1w
This is already implemented! 🎉
It was implemented 2 years ago in the original [CL 114515](https://golang.org/cl/114515). See [here](https://github.com/golang/go/blob/9a2db7c41ba5b1f9498d5354e6c…dmitshur opened an issue net/http: support request cancellation on js/wasm1w
We should implement HTTP request cancellation via request context cancellation on `js/wasm` now that `AbortSignal` has become part of the [DOM living standard](https://dom.spec.whatwg.org/#abortsigna…Earlier
dmitshur reopened an issue golang.org/x/build/dashboard: missing trybot for linux-riscv641w
dmitshur commented on golang.org/x/build/dashboard: missing trybot for linux-riscv641w
[CL 216765](https://golang.org/cl/216765) was reverted via [CL 217723](https://golang.org/cl/217723), so re-opening.dmitshur commented on golang.org/x/build: linux-riscv64-unleashed builder missing1w
https://farmer.golang.org says:
```
host-linux-riscv64-unleashed: 0/0 (1 missing)
```
/cc @bradfitz as builder owner per https://farmer.golang.org/builders. Are you able to look into this?dmitshur commented on golang.org/x/build: create builder that runs with GOEXPERIMENT set to 'staticlockranking' (once lock ranking change is in)1w
[CL 224078](https://golang.org/cl/224078) is deployed now, and the linux-amd64-staticlockranking builder has started running. It is currently failing, as expected, because the experiment hasn't lande…dmitshur commented on golang.org/x/net/http2/h2demo: http2.golang.org is down1w
The URL of image https://blog.golang.org/go-programming-language-turns-two_gophers.jpg has changed to https://blog.golang.org/2years/2years-gophers.jpg in [CL 223599](https://golang.org/cl/223599).
…dmitshur commented on golang.org/x/net/http2/h2demo: http2.golang.org is down1w
Relevant code:
https://github.com/golang/net/blob/a8b05e9114ab0cb08faec337c959aed24b68bf50/http2/h2demo/h2demo.go#L326-L329
`log.Fatal` explains this.dmitshur opened an issue golang.org/x/net/http2/h2demo: http2.golang.org is down1w
Its pod was restarted 3 hours ago, and is currently in CrashLoopBackOff state.
The log just has:
```
2020/03/20 21:40:03 Error fetching https://blog.golang.org/go-programming-language-turns-tw…dmitshur opened an issue golang.org/x/build/dashboard: atLeastGo1/atMostGo1 helpers handle non-release branches incorrectly1w
As a follow-up to #37953, we can improve the `atLeastGo1` and `atMostGo1` helpers so that they operate closer to what the name suggests, and report only whether the Go version meets a certain number.…dmitshur commented on golang.org/x/build: better dashboard/builder support for dev.* branches1w
Thanks for providing more information and having the discussion.
It has helped me understand the current situation better, and I think [CL 223381](https://golang.org/cl/223381) is a safe change to…dmitshur commented on runtime: "fatal error: unexpected signal" 0xC0000005 on Windows for a small program with a large allocation1w
No problem Austin, it'll make its way into the next minor release. Thank you!dmitshur commented on runtime: "fatal error: unexpected signal" 0xC0000005 on Windows for a small program with a large allocation1w
@ulikunitz Yes, the review needs to be completed. The CL will then get submitted, backported, and be a part of the next minor release.
I've left a ping for @aclements on the CL in case the notificat…dmitshur commented on runtime: crash when trying go run or go build1w
@Shurikken Please open a new issue, with information how to reproduce this problem with Go 1.14.1, so we can investigate. Thank you.dmitshur pushed to
master in github.com/shurcooL/home1w
dmitshur commented on golang.org/x/build: mac builders are missing1w
I'll remove Soon label and unpin because https://farmer.golang.org/#health reports healthy status by now.dmitshur starred in github.com/luruke/browser-20201w
dmitshur commented on golang.org/x/build: better dashboard/builder support for dev.* branches1w
Looking at our current builder configuration more, I see that we already build most dev.* branches on most builders. For example, the dev.link branch specifically has many post-submit builders:
ht…dmitshur commented on golang.org/x/build: better dashboard/builder support for dev.* branches1w
Thanks for filing the issue.
> Cherry created a preliminary [CL 223381](https://golang.org/cl/223381) to do this, but there were concerns that this might not be a way to go.
To clarify, the con…dmitshur commented on golang.org/x/build: create builder that runs with GOEXPERIMENT set to 'staticlockranking' (once lock ranking change is in)1w
Sounds good.
Thinking about it more, it should be useful to get the builder up and running starting with the latest existing commit on master, and ensure it's passing. Then, when you're ready to l…dmitshur commented on golang.org/x/build: create builder that runs with GOEXPERIMENT set to 'staticlockranking' (once lock ranking change is in)1w
I see. For those CLs, it'll be possible to run the new builder via [SlowBots](https://golang.org/wiki/SlowBots) by asking for that builder specifically with something like `TRY=linux-amd64-staticlock…dmitshur commented on golang.org/x/build: create builder that runs with GOEXPERIMENT set to 'staticlockranking' (once lock ranking change is in)2w
@danscales Do you think just a post-submit builder (not a part of the default trybot set) is sufficient, or do you think including this builder in trybots would be helpful too?dmitshur commented on cmd/internal/moddeps: test TestAllDependenciesVendored/golang.org/x/tools fails2w
Manually removing the `pkg` subdirectory with `sudo rm -rf ./pkg` resolved the problem for me.
[CL 223924](https://golang.org/cl/223924) looks like a good change. Thanks!dmitshur commented on cmd/internal/moddeps: test TestAllDependenciesVendored/golang.org/x/tools fails2w
It doesn't reproduce with a fresh checkout:
```
ok cmd/internal/moddeps 8.331s
```
`$HOME/gotip` is my normal checkout of the main Go repo for development. I constantly switch branches and …dmitshur commented on cmd/internal/moddeps: test TestAllDependenciesVendored/golang.org/x/tools fails2w
I'll try making a new temporary directory, clone https://go.googlesource.com/go, and see if it reproduces there.dmitshur commented on cmd/internal/moddeps: test TestAllDependenciesVendored/golang.org/x/tools fails2w
```
$ sudo ls -al /Users/dmitshur/gotip/pkg/obj/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20190325161752-5a8dccf5b48a/go.mod
-r--r--r-- 1 dmitshur primarygroup 87 Mar 25 2019 /Users/dmitshur/gotip…dmitshur commented on go/doc: rework go/doc to be more flexible2w
Also see [CL 72890](https://golang.org/cl/72890) for related work. It is an attempt to split documentation rendering into smaller and more flexible building blocks. An updated copy of that package is…dmitshur commented on go/doc: rework go/doc to be more flexible2w
Thanks for sending that change, @JAicewizard. It will be helpful to have that prototype when discussing and considering this change.
The `go/doc` package is low level and in the standard library. …dmitshur opened an issue cmd/internal/moddeps: test TestAllDependenciesVendored/golang.org/x/tools fails2w
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel +6412750f32 Wed Mar 18 01:03:36 2020 +0000 darwin/amd64
</pre>
### Does this …dmitshur commented on golang.org/x/build: host-plan9-386-0intro builder is stuck2w
The SlowBot run is stuck in waiting_on_machine state, meaning it's waiting for a builder to become available and get scheduled to run that build.
There's only one plan9-386-0intro reverse builder,…dmitshur closed an issue golang.org/x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing (mid-March 2020)2w
dmitshur commented on golang.org/x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing (mid-March 2020)2w
Restarted the server via [Packet UI](https://github.com/golang/build/blob/1e42a94bc4f581883a689d2d139f5b79839c2b49/env/linux-arm64/packet/README#L3) to fix it.dmitshur opened an issue golang.org/x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing (mid-March 2020)2w
From https://farmer.golang.org/:
Previously:
- #37371 (last occurrence, 25 days …dmitshur commented on cmd/compile/internal/syntax: TestStdLib verbosely broken on Windows2w
@gopherbot, please consider this issue for backport to Go 1.13. This is a test fix. It is needed to resolve a test failure in the `cmd/compile/internal/syntax` package on windows-amd64-longtest build…dmitshur commented on os: TestRemoveAllWithMoreErrorThanReqSize is failing on Plan 9 and Windows2w
@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a test failure in the `os` package on windows-amd64-longtest builder, which could be masking other problems (du…dmitshur commented on golang.org/x/build: report failures fast but still make all test results available2w
/cc @findleyrdmitshur commented on net/http: TestCancelRequestWithChannelBeforeDo_Cancel failure on Windows long test2w
@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a failure in the `net/http` package on windows-amd64-longtest builder, which could be masking other problems an…dmitshur commented on cmd/go: improve documentation of remote import paths for developers (implementing the go-get protocol)2w
> A direct server (not a proxy) probably don't know the package-to-repository mapping.
I don't understand this point. Given the server needs to serve responses to `?go-get=1` requests, wouldn't it h…dmitshur commented on cloud.google.com/go/all: audit transitive dependencies2w
As @tbpg said, they are not in the build, but they are in the module graph and so they still need to be written down.
Also see the `cmd/go` proposal https://github.com/golang/go/issues/36460. It is …dmitshur commented on golang.org/x/build/cmd/coordinator: write proper scheduler2w
[CL 223381](https://golang.org/cl/223381) is related. It's a request to start running post-submit builders on new commits on `dev.*` branches.dmitshur pushed to
dev in github.com/shurcooL/home2wdmitshur commented on go.dev: tag like v17.03.1 is not recognized as a version2w
pkg.go.dev interprets versions in the same way as the `go` command in module mode. The problem here seems to be that repository doesn't publish versions that are compatible to be used with the `go` c…dmitshur commented on cmd/go: improve documentation of remote import paths for developers (implementing the go-get protocol)2w
I suspect the behavior differs depending whether module mode or GOPATH mode is used. The documentation you're quoting there was written for GOPATH mode.
/cc @jayconrod @bcmills @matloob per [owner…dmitshur pushed to
master in github.com/shurcooL/home2wdmitshur closed an issue os/exec: environForSysProcAttr is never called as sysattr.Env is never nil2w
dmitshur commented on os/exec: environForSysProcAttr is never called as sysattr.Env is never nil2w
> Gopherbot opened for 1.12 and 1.13, reopening this issue for 1.14.
@toothrot has opened a new backport issue for 1.14 (#37471), and this issue is already fixed on master via [CL 220587](https://…dmitshur commented on go/types: data race in representableConst in Go 1.13 and earlier [1.13 backport]2w
We've discussed this cherry pick candidate in a release meeting.
To recap the latest status of this candidate, we know this is a serious problem and we have been investigating to see if there is a…