Today
shurcooL pushed to github.com/shurcooL/events48m
bdc28fd3githubapi: Remove unneeded prefix from event.Page HTML URLs.
shurcooL edited the wiki in github.com/golang/go1h
shurcooL edited the wiki in github.com/golang/go1h
shurcooL edited the wiki in github.com/golang/go1h
shurcooL commented on x/tools/godoc: Anchors for variable… in github.com/golang/go3h
> Cherry-pick doesn't apply cleanly. 3bcb6efb399c5289003b99a1c165bd9797ff406c (the commit that closed this issue) is a minor patch/bug fix for e1bdc76d0461f7041136c70e0a1356ea0f5e01d0, where this …
shurcooL starred github.com/chaosbot/chaos7h
shurcooL commented on idea: show number of notifications … in github.com/shurcooL/notificationsapp16h
Resolved in https://github.com/shurcooL/home/commit/45e3e48ee25e1a001a138816575dc04d43f1fe4f.
shurcooL pushed to github.com/shurcooL/home16h
45e3e48ecomponent: Show number of unread notifications in tooltip.
shurcooL commented on idea: show number of notifications … in github.com/shurcooL/notificationsapp16h
I think a solution I'll go with is to show the number of unread notifications in a tooltip, when user hovers (indicating they might care about additional details). That way the presentation is still…
Yesterday
shurcooL commented on GopherCI fails with an Internal err… in github.com/bradleyfalzon/gopherci1d
> Does that answer the issue? Yes, that answers the issue about poor error handling. I forgot #88 exists and is still open, thanks for pointing me at it. However, I'm confused why [this](https:…
shurcooL commented on using both cancelled and canceled i… in github.com/grpc/grpc-go1d
> Both spelling are correct, but we should pick one and be consistent. Related: https://dmitri.shuralyov.com/idiomatic-go#use-consistent-spelling-of-certain-words. The Go project chose to go wi…
shurcooL commented on cmd/gosimple/README.md: Improperly … in github.com/dominikh/go-tools1d
For posterity, it was fixed in e94d1c1a34c6b61d8d06c7793b8f22cd0dfcdd90.
shurcooL commented on GopherCI fails with an Internal err… in github.com/bradleyfalzon/gopherci1d
@bradleyfalzon I've made a similar change in https://github.com/shurcooL/Hover/commit/6f3928f0f5fa09ccb54a3aec5985e5cfcdcc857c, but GopherCI fails with the same error message as before: https://gc…
shurcooL created branch in github.com/shurcooL/eX01d
add-gopherci-yml
shurcooL commented on Add .gopherci.yml support and use i… in github.com/bradleyfalzon/gopherci1d
@bradleyfalzon I've made a similar change in https://github.com/shurcooL/Hover/commit/6f3928f0f5fa09ccb54a3aec5985e5cfcdcc857c, but GopherCI fails with the same error message as before: https://gc…
shurcooL pushed to github.com/shurcooL/Hover1d
6f3928f0Add .gopherci.yml.
shurcooL commented on Missing document.execCommand()? in github.com/dominikh/go-js-dom1d
From looking at the API of this library, it appears it does not currently have support for `execCommand`. If your question is "how would the equivalent of document.execCommand() be achieved in gen…
shurcooL commented on proposal: Replace in-house implemen… in github.com/gopherjs/gopherjs1d
I'm going to remove Proposal-Accepted label from this to reflect current reality. The implementation effort I started was cancelled (see previous comment). The proposal plan was pretty specific to…
shurcooL commented on Add support to gopherjs tool for sp… in github.com/gopherjs/gopherjs1d
I plan to test that the GopherJS Playground continues to work successfully with this change. I will also continue to test this change locally for some more time, to gain confidence, before merging. …
shurcooL commented on Add support to gopherjs tool for sp… in github.com/gopherjs/gopherjs1d
Great, thanks! One other benefit I didn't explicitly mention is that this PR removes more code than it adds. The code it removes contained partially incorrect and hard to understand logic. It also…
shurcooL commented on Add support to gopherjs tool for sp… in github.com/gopherjs/gopherjs1d
> What's the advantage of having this intermediate state? There are many. It keeps the scope of this PR smaller. To resolve #302, that's it. Having a smaller PR/smaller scope has many benefi…
shurcooL commented on 8e37ae57check: detect params th… in github.com/mvdan/unparam1d
Hey, minor typo in "thnask", should be "thanks". 😛
shurcooL commented on Add support to gopherjs tool for sp… in github.com/gopherjs/gopherjs1d
@neelance That's exactly what I want to do next, this was just a working intermediate solution. Just checking, but did you consider the commit message of f79744a233766fd8897d5f2dc8f05b6ee0e72d8c befo…
This Week
shurcooL pushed to github.com/gopherjs/websocket1d
87ee4760websocketjs: Use Normal Closure (1000) close code in WebSocket.Close. (#22)
shurcooL commented on Update impl with more AST goodness in github.com/josharian/impl2d
Minor, there should be a space after the two slashes. Reference: https://dmitri.shuralyov.com/idiomatic-go#comments-for-humans-always-have-a-single-space-after-the-slashes.
shurcooL commented on Update impl with more AST goodness in github.com/josharian/impl2d
"A" is repeated twice. Perhaps you meant "An A is ...", or just "A is...".
shurcooL commented on Detect unexported func parameters t… in github.com/mvdan/unparam2d
Can you clarify/be more precise about what you mean by "same value"? Identical value per execution? At all times? Constant? Etc.
shurcooL commented on 769824ffssa: don't crash in con… in github.com/dominikh/go-tools2d
@dominikh This is minor, but `identical_17.go` could be called `identical17.go`, the underscore is unusual. See `const.go` and `const15.go` in same directory.
shurcooL commented on arm-linux-gnueabi/bin/ld: cannot fi… in github.com/go-gl/glfw2d
Based on your comment in https://github.com/go-gl/gl/issues/76#issuecomment-302916913, where you said you're targeting Raspberry Pi 3, that platform is not supported by `go-gl/glfw` at this time. No …
shurcooL commented on # github.com/go-gl/gl/v3.2-core/gl … in github.com/go-gl/gl2d
I know `goxjs/gl` does not support Raspberry Pi, see issue https://github.com/goxjs/gl/issues/13 that's tracking it. I don't know what the support status for `x/mobile/gl` is, but it seems more likel…
Last Week
shurcooL pushed to github.com/shurcooL/events3d
790e8060githubapi: Remove debug print.
shurcooL commented on # github.com/go-gl/gl/v3.2-core/gl … in github.com/go-gl/gl3d
> My development machine is Ubuntu 16.04 amd64 and target is arm. Target is arm? Can you elaborate? I don't think targeting arm architecture is supported by go-gl/gl packages. You may want t…
shurcooL pushed to github.com/gopherjs/gopherjs3d
6997325ccompiler/natives/src/net/http: Include reason in error when fetch() fails. (#647)
shurcooL commented on arm-linux-gnueabi/bin/ld: cannot fi… in github.com/go-gl/glfw3d
See the "Installation" section in the README for instructions on how to install GLFW dependencies. https://github.com/go-gl/glfw#installation
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
Ah, well, I just remembered one GopherJS-specific thing. It's actually safe to call the `js.Object` methods on a nil value of `*js.Object`. It's a way of converting it to that type. E.g., this is …
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
I found that it's indeed possible to pass `null` as a rejection reason with JavaScript promises: ```JavaScript var p1 = new Promise( (resolve, reject) => { //resolve('Success!'); // or r…
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
Why is one message "net/http: fetch" but the other "net/http: fetch()"? It'd be better to make them consistent.
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
Style-wise, just name this `err`. I don't see why it should be `jsErr`.
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
It'd be nice if could find out. That way, the code could be simpler.
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
I guess it should never be `nil` for the same reason `result` is never nil in the success case. I looked at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise…
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
Can you be sure that `reason` will never be nil? Otherwise it'd be a nil pointer dereference panic, right?
shurcooL commented on Include more information in error m… in github.com/gopherjs/gopherjs3d
No, there wasn't an intention to keep the message short, so this is a welcome improvement, thanks.
shurcooL commented on Setting for target=_blank for exter… in github.com/russross/blackfriday3d
`bluemonday` already supports this, as part of its sanitization process. Look into its `AddTargetBlankToFullyQualifiedLinks` option, described at https://github.com/microcosm-cc/bluemonday#links.
shurcooL created branch in github.com/gopherjs/gopherjs3d
natives-gopherjsdev
shurcooL pushed to github.com/shurcooL/vfsgen3d
a68da2d1cmd/vfsgendev: Add -tag flag to override default "dev"/"!dev" build tags.
adf640b1cmd/vfsgendev: Simplify lookupSource to lookupNameAndComment.
304fc191cmd/vfsgendev: Improve flag parsing error handling.
shurcooL created branch in github.com/shurcooL/vfsgen3d
vfsgendev-add-tag-flag
shurcooL pushed to github.com/shurcooL/home3d
3a47e5c2Add /about/setup page.
shurcooL commented on Add support to gopherjs tool for sp… in github.com/gopherjs/gopherjs3d
> and otherwise fail? That's what'll happen anyway. If a relative import path is specified, and `wd` is left blank, the next function will return an error like "cannot resolve relative import path…
shurcooL commented on Templates don't seem to be found in github.com/flexd/slackinviter3d
You can use something like this to find the directory corresponding to an import path inside GOPATH, and `os.Chdir` into it during command initialization: https://github.com/go-gl/example/blob/ee0…
shurcooL commented on Comments: Replacing Disqus with Git… in github.com/dwilliamson/donw.io3d
@dwilliamson, I'm curious if you've seen https://dmitri.shuralyov.com/blog/23#comment-0 and what you think about it. It's inspired by your post, and demonstrates something similar I've done on my blo…
shurcooL deleted branch in github.com/gopherjs/gopherjs3d
build-document-ignored
shurcooL pushed to github.com/gopherjs/gopherjs3d
2f8d2fd5build: Document what packages are being ignored. (#636)
shurcooL deleted branch in github.com/gopherjs/gopherjs3d
add-test-count-flag
shurcooL pushed to github.com/gopherjs/gopherjs3d
43db6ffbAdd support for gopherjs test --count flag.
shurcooL commented on Proposal: tightening up $internaliz… in github.com/gopherjs/gopherjs3d
@myitcv I know there's still some discussion/planning in the other proposals about structs with `*js.Object`, but from what I can tell, we're pretty much agreed on this one being a good idea. I'm …
shurcooL created branch in github.com/gopherjs/gopherjs3d
tool-relative-ip
shurcooL commented on `gopherjs test ./with/relative/path… in github.com/gopherjs/gopherjs4d
I'm going to reopen and resolve this issue. /cc @slimsag Sure, there's always the workaround of doing: ``` $ gopherjs test $(go list ./...) ``` But that's not nice and not friendly to new …
shurcooL commented on 40463118README: use alternative… in github.com/gopherjs/vecty4d
What does "simple description" in the commit message title mean?
shurcooL starred github.com/minio/c2goasm4d
shurcooL commented on staticcheck: warn on type assertion… in github.com/dominikh/go-tools4d
> And I don't see how a nil deref is any better than a panic from a type assertion. I agree. If I know something is safe to type covert, I explicitly use the short form to assert my confidence …
shurcooL commented on Add Pull Request MergeCommitSHA in github.com/google/go-github4d
I think you meant "merge_commit_sha", not "merge~~d~~_commit_sha": ![image](https://cloud.githubusercontent.com/assets/1924134/26229422/a67bf52c-3c0f-11e7-9c64-b99cb3ffc92e.png)
shurcooL pushed to github.com/shurcooL/cmd4d
475974a9Add .gopherci.yml. (#6)
shurcooL commented on GopherCI fails with an Internal err… in github.com/bradleyfalzon/gopherci5d
Those docs look good to me.
shurcooL commented on Add xorg-dev and libgl1-mesa-dev pa… in github.com/shurcooL/cmd5d
What about the 2 space indent?
shurcooL commented on Add xorg-dev and libgl1-mesa-dev pa… in github.com/shurcooL/cmd5d
Can you swap the order to have them consistent with .travis.yml file, and also use 2 spaces for indent, again for consistency with .travis.yml.
shurcooL commented on Add xorg-dev and libgl1-mesa-dev pa… in github.com/shurcooL/cmd5d
Get rid of the comment, I don't think it's necessary. I prefer to find this information via git blame and the commit message.
shurcooL commented on Add .gopherci.yml support and use i… in github.com/bradleyfalzon/gopherci5d
Is .gopherci.yml syntax documented somewhere?
shurcooL commented on cmd/all: add profiling flags in github.com/dominikh/go-tools5d
Under `-debug.<key>` namespace and with "can come and go" disclaimer SGTM.
shurcooL starred github.com/bradfitz/go-smtpd5d
shurcooL pushed to github.com/avelino/awesome-go5d
3f23d6ebUpdate description of github.com/mattes/migrate. (#1422)
shurcooL commented on delete custom media type 'applicati… in github.com/google/go-github5d
Friendly ping @ahmedhagii. If you prefer not to continue working on this, we can take this PR (which is 90% there), apply the suggested change above, and merge it. That's completely okay.
shurcooL deleted branch in github.com/google/go-github5d
CommitsComparison-url-fields
shurcooL pushed to github.com/google/go-github5d
e1a8581dAdd missing URL fields to CommitsComparison struct. (#644)
shurcooL commented on cmd/all: add profiling flags in github.com/dominikh/go-tools5d
> Would definitely be interesting That was added by Brad when he was optimizing `goimports` performance. What use would these flags have for users? It would pollute existing set of flags. "Interes…
shurcooL pushed to github.com/google/go-github5d
a492e8b7Use right repo name in test values.
shurcooL pushed to github.com/google/go-github5d
93b2d574Move URL, the only API URL to the bottom (better fit with our style).
shurcooL created branch in github.com/google/go-github5d
CommitsComparison-url-fields
shurcooL commented on CommitsComparison should have metho… in github.com/google/go-github5d
You're right, `CommitsComparison` struct is missing the `HTMLURL` field, and therefore also missing the `GetHTMLURL` method (which gets generated from the field). The fix is to add the `HTMLURL` f…