Activity

Today
Thanks. Left an assortment of improvement suggestions, but you're welcome to pick and choose what's worth doing now, since this is an internal package and it's easy to change it later or when there's…
Yesterday
> `GOFLAGS='-ldflags=-linkmode=internal'` That looks relevant! Please try without forcing internal link mode (which isn't supported with cgo, see golang/go#38918).
That's quite odd. I'm finding similar errors in issues like https://github.com/mattn/go-sqlite3/issues/112, https://github.com/mattn/go-sqlite3/issues/404. They suggest this might be caused by someth…
Thanks. I'll get this deployed before the 'Wait to Announce' step and let @drchase@google.com know when it's done.
Move the timeout scale closer to what's used by openbsd-riscv64 now. This was suggested by Eric who looked at their relative performance. For golang/go#63480.
Thanks for trying. That's unexpected. I have a similar setup but I can't reproduce the problem so far. A few more ideas to try: 1. What's your Xcode version (`xcodebuild -version`)? 2. To confirm, s…
This Week
v0.0.0-20210410170116-ea3d685f79fb is a pretty old version of glfw/v3.3. Can you try the latest and see if that fixes it? ```sh go get github.com/go-gl/glfw/v3.3/glfw go run . ``` If so, we …
@0intro Sorry it took a while before I had a chance to get back to this, but I'm glad you were able to make progress. There is open source documentation for the Swarming Bot at https://chromium.googl…
(1 comment) No problem, thanks.
Thanks. In a separate future change, we should probably migrate these comments and the code that recognizes them from old style "// +build" directive style to current "//go:build" one. But that shou…
Duplicate of #54279
Duplicate of #54279
At least partially a duplicate of #54279. I'll let watchflakes file a new issue when it's a different problem.
The likely explanation here is that the k8s cluster was undergoing an upgrade, resulting in brief windows of service unavailability. Let's reuse this issue to catch future instances, so that watch…
This issue from 2019 was resolved and frozen due to age. For new work, maybe it'd be better to file a new issue and refer to this one.
dmitshur commented on doc: write release notes for Go 1.232d
The Go 1.23 Release Notes draft is complete, and all known TODOs have been resolved. Running <code>[relnote](https://golang.org/x/build/cmd/relnote) todo</code> right now doesn't find anything remain…
(1 comment) Please change this line to: ``` For #65991. Fixes #65994. ``` (See https://go.dev/wiki/MinorReleases#making-cherry-pick-cls.)
TryBots passed on Patch Set 1; I accidentally caused them to start and immediately stop a second time.
Thanks.
dmitshur opened a change all: update vendored golang.org/x/tools2d
Pull in CL 593297: f2d2ebe4 go/analysis/passes/buildtag: retire Go 1.15 support Along with other changes that have landed into x/tools. This fixes a vet failure reported on longtest builders. For…
Go 1.17 is long since out. Furthermore, CL 516575 added a use of parser.SkipObjectResolution to a file with a go1.16 build constraint. This used to be fine, but not now that vet checks for this (see…
This backport is approved and it's waiting on a cherry-pick CL to be created. See https://go.dev/wiki/MinorReleases#making-cherry-pick-cls. Once that's created and all of its submit requirements are …
Thanks. Is having a leading '/' in the path based on some source? I don't see it in the [doc examples](https://chromium.googlesource.com/infra/luci/luci-go/+/HEAD/lucicfg/doc/README.md#cq.location-f…
(1 comment) Please add this comment above this line: ``` &lt;!-- go.dev/issue/58894, go.dev/issue/67111 --> ``` Both so that humans can find the associated proposals easier, and so that `relnote t…
Thanks.
The "/issue/nnn" pattern is what we want to use long term. It will work fine once the release notes are moved to x/website's _content/doc directory. It would be good to make it work on tip.golang.org…
dmitshur edited the wiki3d
Use Markdown's list syntax with indentation. It makes it easier to see in the rendered version where each item begins and ends.
This was the only non-.md wiki page, causing it not to render at go.dev/wiki. It was previously converted from Markdown to AsciiDoc to get a generated table of content, but that happens for Markdown …
It looks like an intentional decision in [CL 470676](https://go.dev/cl/470676) that the module toolchain isn't complete to run all tests, as it doesn't keep the "test" directory either: https://cs…
(2 comments) Indeed, no reason to treat them differently, and not indenting is consistent with the intent behind this `markdownToTextRenderer`. It looks like the CodeBlock case was incomplete and no…
The Markdown parser used here emits separate AST nodes for regular and fenced code blocks. Despite that partial support for the former was started in the initial CL 411575, it appears incomplete. Cod…
The "label proposals" task adds the "Proposal" label and sets the "Proposal" milestone, whichever is missing, to proposal issues. It got stuck processing a no-longer-existing proposal issue 67913: m…
Last Week
dmitshur closed an issue github.com/go-gl/gl: Not able to import5d
There's no package with the import path `github.com/go-gl/gl/v3.3/gl`, so an error is expected. There are packages with the following import paths: - [`github.com/go-gl/gl/v3.3-core/gl`](https:…
The macOS race builder is reporting data races in found by briefly running benchmarks. For example: ``` ================== WARNING: DATA RACE Write at 0x00c000152a49 by goroutine 40: tes…
dmitshur commented on doc: write release notes for Go 1.231w
Rerunning `relnote todo` today doesn't find more TODOs beyond the 4 already added to the source (view-source:https\://tip.golang.org/doc/go1.23). <details><summary><code>relnote todo</code> output…
> Or are there cases where one module's tests will be run against another module's `go.mod`? To answer this question specifically: yes, it is possible to test packages contained in modules other t…
Earlier
dmitshur commented on api: audit for Go 1.231w
I also looked a bit at the proposed and implemented APIs. Everything seems to align. The `WSAENOPROTOOPT` constant wasn't mentioned in proposal #62254, but it seems fine.
This issue is about the "dl" repo that holds commands like [golang.org/dl/go1.22.4](https://cs.opensource.google/go/dl/+/master:go1.22.4/main.go;drc=9bf7d9b5654bbbf3a03546ecf70a20c5488663ec), not the…
Congrats on the progress! On the corresponding build page (https://ci.chromium.org/b/8745946740583765537), oddly, there are 31 failing test result entries (and 2901 passing) despite the overall buil…
We reviewed this in a meeting, and agreed to approve its "freeze exception" bit. Thanks for letting us know.
We reviewed this in a meeting, and agreed to approve its "freeze exception" bit. Thanks for letting us know.
We reviewed this in a meeting, and agreed to approve its "freeze exception" bit. Thanks for letting us know.
Note that if the linker in older Xcode 14 doesn't support the same flag to disable the warning, such that passing it causes an error (as mentioned in [2]), then that needs to be taken into account. …
The pattern in #49338 required the builder name to be exactly "plan9-arm", which was true in coordinator, but LUCI builder names include more context (repo, release branch). Updated its pattern s/==/…
FYI [CL 589935](https://go.dev/cl/589935) updated x/telemetry to v0.0.0-20240603224550-f2b69109f79b. Feel free to close this if that's enough for the needs of RC 1, or keep it open if you'd like to c…
### Go version go version go1.22.3 darwin/arm64 ### Output of `go env` in your module/workspace: ```shell GO111MODULE='' GOARCH='arm64' GOBIN='' GOCACHE='/Users/gopher/Library/Caches/go-build' …
> Also, how can we make sure that test failures in x/ repos triggered by the go.mod version are caught in CI? Filed #67791 for that.
Issue #67783 is an example of a test failure that happened only at tip (future Go 1.23 to be) and when the go directive in x/net is increased to Go language version 1.23. Bumping x/net go directive …
It’s true that GOROOT_FINAL is removed in Go 1.23, so it’s no longer relevant. As https://github.com/golang/go/issues/39819#issuecomment-648880776 points out, there are more env vars that might n…
The bootstrap failure is now resolved via [CL 586835](https://go.dev/cl/586835), which is what the original issue was about. Perhaps it would work well to close this issue and open a separate one to …
This is a tracking issue to trim down coordinator, stopping more of the builders that have been ported to LUCI. This builds on top of the previous dashboard work in #65913. CC @golang/release.
The timing of api files being merged isn't exactly the same as in past releases because they're also involved in the test for improved release notes (#64169). The task that updates x/tools/interna…
That mechanism isn't currently available for LUCI builders. Without snapshots, and with make.bash taking 45 minutes, it makes testing golang.org/x repos slower and use more resources, but I understa…
Thanks. I'm convinced you should be able try this, given you're already taking the support needs into account to a great degree. This is something we can choose to undo if you learn it's not working …
> Given that the gopls build must already download external dependencies, I don't see why GOTOOLCHAIN=local is necessary. The [Go release policy](https://go.dev/doc/devel/release#policy) says the …
dmitshur closed an issue net: TestSplice failures3w
dmitshur closed an issue os/exec: TestPipeLookPathLeak failures3w
dmitshur closed an issue os/exec: TestPipeLookPathLeak failures3w
That looks like a different failure mode. I'll re-close this frozen issue and take it out of Test Flakes so that watchflakes can create a new issue.
The loading error happens because the main Go repository contains a development version of Go 1.23, which isn't released yet. In general, setting up gopls to work on the main Go repository is conside…
Closing as a duplicate of #27992 again, and taking it out of Test Flakes project so it doesn't get reopened.
This was done for x/tools in [CL 562838](https://go.dev/cl/562838). This issue is in Go1.22 milestone, so closing again. (It was fixed by [CL 559796](https://go.dev/cl/559796).)
dmitshur closed an issue build: make.bat failures3w
Duplicate of #67720
[CL 589015](https://go.dev/cl/589015) added a pre-announcement to Go 1.23 release notes. Moving to the next milestone.
We haven't updated `retrybuilds` for LUCI, but may do so in the future. So far it hasn't been a high priority because it's generally okay to wait for future commits to come in and be built. In LUCI U…
@gopherbot Please consider this for backport, in particular [CL 589295](https://go.dev/cl/589295) and [CL 589296](https://go.dev/cl/589296). They apply test-only fixes that are needed to fix builder …
The error message above includes "quota exceeded". It seems to have been temporary. Looking at https://ci.chromium.org/ui/p/golang/g/port-openbsd-ppc64/builders, the builder seems to be stable and pa…
Looking at the most [recent builds](https://chromium-swarm.appspot.com/bot?id=openbsd-riscv64-jsing), make.bash is now successfully completing but taking 1.1-1.2 hrs to do so. That seems quite long f…
In [b8746572283039962513](https://ci.chromium.org/b/8746572283039962513), the 'upload prebuilt go' step took 54 seconds. A pre-built toolchain is around 150 MB compressed, so that seems to line up wi…
Support for GO386=387 was dropped in Go 1.16 (https://go.dev/doc/go1.16#386). There's a [linux-386-softfloat](https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=412;drc=e09c5e8d198089…
Sharing a filesystem seems good if it works well. Embedding is just an alternative path. It would make the test binaries larger and may require them to write out the embedded data to a temporary dire…
dmitshur closed an issue build: make.bash failures3w
Duplicate of #67621
@0intro https://chromium-swarm.appspot.com/task?id=69d9f835adb76f10 was a recent build after the aforementioned CL: ``` 15819 2024-05-28 21:41:44.550 E: Failed to run run_isolated Traceback (mos…
That's great to hear, thanks! One idea I wanted to briefly mention about testdata: I wonder if could work well to rely on `//go:embed testdata` directives in _test.go files to make embed testdata …
Closing as fixed by [CL 587796](https://go.dev/cl/587796) and [CL 588236](https://go.dev/cl/588236). (If it's not, watchflakes will comment or reopen.)
dmitshur starred github.com/rtr7/router73w
Thanks for setting it up! I see it at https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-openbsd-riscv64?limit=200 and https://chromium-swarm.appspot.com/bot?id=openbsd-riscv64-jsing. …
dmitshur starred github.com/roblillack/spot3w
@kolyshkin You can find documentation for our backporting process at https://go.dev/wiki/MinorReleases. If you believe this issue meets the criteria to be considered for backporting, you should ask @…