Activity

Today
A few test queries with the /debug304 endpoint (from [CL 415254](https://go.dev/cl/415254)) show that waiting under 30 seconds results in 304 being returned, but 30 or more seconds results in 502 aft…
(1 comment) This came from initial code here, but since both of us prefer using the named consts, improved (in Patch Set 3 of parent CL). Thanks.
Thanks for reviewing. I'll test it out before submission, so adding Hold for now.
dmitshur closed an issue api: audit for Go 1.194h
dmitshur commented on api: audit for Go 1.194h
[CL 414635](https://go.dev/cl/414635) is in. Thank you, closing as done. (I've also checked off the last 3 boxes so it's clear we didn't accidentally miss them. They corresponded to the 3 more fie…
The rationale to backport and safety of fix here seems very similar to #53590, so it can possibly be handled in a similar way.
Practice shows 55 seconds isn't working well by now. See if adjusting the timeout slightly is all that's needed to make the problem go away. For golang/go#53569.
Thanks for fixing it quickly.
It does appear the failure isn't consistent, for some reason, but it happened again on the latest commit on the release branch (see [here](https://build.golang.org/log/5527be461db9e9c7576175b95366340…
CL 383554 disables testing cgo internal linking on all ARM64 but Windows, because it doesn't work with newer GCC. But - darwin-arm64 works, and it does not use GCC - we don't support cgo internal lin…
The previous workaround for issue #39466 only disabled this test for Linux. However, the issue manifests for all arm64 systems with gcc 9.4 and above. The new netbsd-arm64 builder uses NetBSD-current…
Thanks, nice catch. Since ssToDirEntries isn't doing anything other than converting every entry from string to buildlet.DirEntry, if you'd like, you have the option to simplify it by inlining the co…
Yesterday
(1 comment) Minor: I think this refers to ~/.gitconfig, but it's clear from the context of line 26.
This seems reasonable, @bcmills want to send a CL for this? We can try it and adjust based on experience.
Thanks. Please see inline comments. (Sorry about the long delay. I was finally able to work through my recent attention set backlog and am able to get to reviewing this CL now, if it's still helpful…
This Week
(1 comment) Maybe out of scope of this CL, but pointing out in case it's helpful: this test can benefit from a similar improvement by using t.Skipf.
Thanks for reviewing. The reason a minor release kind isn't listed in this switch is because it's inside createSingle, which is only used for final, RC and betas (see lines 608-616 below). The mino…
Re 1, I think we don't have a direct fallback because, if `GO_DISABLE_OUTBOUND_NETWORK` is working (it might not be, see #51444), then any fallback direct connections would be refused by the firewall…
(2 comments) Done in PS 2. Done in PS 2.
The downloading code was just missing the case for where the client had more bytes than server (due to server restarting with some uncommitted transactions).
The 502 Bad Gateway from /logs is another (non-serious) issue, filed #53569 for it. I was going to send a small change to add a log line, to learn what range value causes the server to respond wit…
If the maintnerd server restarts with some uncommitted transactions, clients may end up having more downloaded bytes than the server, after the server restarts. We're invariably heading towards an Er…
The /logs endpoint supports long polling via `waitsizenot` parameter. To avoid being flagged as a timeout, it tries to serve a 304 in just under a minute (55 seconds specifically): ```Go // Retur…
dmitshur pushed to master in dmitri.shuralyov.com/service/change3d
67e22b2f18a260a33a98c6a7d601726a58c53767maintner: update for GitCommit API change
dmitshur starred github.com/josharian/tstruct3d
Last Week
(1 comment) Thanks, I'll mark this thread as resolved.
I initially wanted to update this issue with the latest status, and then saw that it'd be quick to send a trivial CL to close it. All that was needed was a trivial change to the following flaky-test-…
On the internet, servers generally don't go out of their way to ensure graceful stream shutdowns, preferring to instead rely on the clients to receive a network error and decide to repeat the same re…
TRY=longtest It doesn’t make a difference in this case, but note in general we don’t need to include the -u flag when using go get in module mode. Using the selected dependency versions of the m…
Issue #35299 is the same, I'll close one of them as a duplicate.
(1 comment) Thanks. It needs to be added to the PR description to show up here, please see https://go.dev/wiki/CommitMessage#github-pull-requests for details.
I think both the x/exp specifics and coordinator testing strategy (#51455) are in an okay shape by now, and not in scope of the problem described in the initial report here. Since it has the Thinking…
TRY=longtest, linux-amd64-race Consider adding "For #53190." and possibly also mentioning this is a followup to CL 410034, since that information can be useful to future readers.
Based on progress of investigation in #51323, the conclusion is that other than the error message not making it easy to see that the error is coming from a remote server for a possibly unavoidable re…
(1 comment) Indeed. I think a better way to handle that would be to define a single top-level layout header with the top-level HTML and common header, and have individual pages provide "content" via…
I forgot there was another copy of the template in status.go. Move at least coordinator's 2 copies of the header into one common place; we can do more later. Also update the perf header to be consis…
(1 comment) Minor: If the 's' wasn't included intentionally, given the method is called runBenchmarkTests, you can remove it.
(1 comment) That sounds like an intentional change then, thanks.
This is generally ready (other than a small TODO), making it available for reading sooner while I make progress on #51150.
Simplify API usage when the caller has multiple values they wish to make a slice from, allowing: Slice([]workflow.Value{v1, v2}) To be written as: Slice(v1, v2) For cases where the caller has a…
The next step after joining the announcement mail and tweet tasks is to append them to the end of the main existing release workflows. This removes the need for the human release coordinator to manu…
This enables communication parameters to be entered at the start of workflow, and no more need to manually specify versions (those are computed during the release workflows, and available for reuse):…
Now that both announcement mail and tweet tasks are ready (and, as of #47406, joined together), the next step is to append them to the end of the main release workflows that build and publish artifac…
I'm not a great reviewer for these packages (also note they're marked as "Deprecated: this package is unmaintained except for security fixes"). I left one general suggestion in an inline comment. Th…
Thanks. (Two trivial nits, I marked them as resolved because I think it's fine not to do anything about them.) Nit: There's a trailing '/' after 'c' in the final URL. Nit: No newline at end of rig…
I agree this looks like a duplicate of #2076, and should be discussed in go-gl/glfw#351. We've just pushed a fix that should resolve that issue, @alexballas please feel free to try again with the …
dmitshur pushed to master in github.com/go-gl/glfw1w
a6c407ee30a0307a64f5195bd06840c97ad89a0av3.3/glfw: fix _GNU_SOURCE redefined warning
@cornelk I think what I wrote in https://github.com/go-gl/glfw/issues/351#issuecomment-1126811178 applies. If the problem can be reproduced with the GLFW C source code (independently of the Go bindin…
> [...] it’s useful to have it automatically update, but the author should also be able to update the contents outside the block. That was implemented in [CL 300229](https://go.dev/cl/300229); I…
dmitshur closed an issue golang.org/x/build: flesh out READMEs1w
Since as https://go.dev/s/release says, "During the freeze, only bug fixes and doc updates are accepted.", this seems okay, and I don't think a freeze exception is needed. This particular document…
Thanks for reporting. [CL 413235](https://go.dev/cl/413235) will fix this.
This may also help with #51057 as I understand.
Earlier
@heschi I plan to take this next now that work on #47405 is almost done, which I think is okay with you.
Resolved by now via the module mode and the [module mirror](https://proxy.golang.org/), that dependency should be available even when gopkg.in is down.
@mdempsky This issue might be okay as a duplicate to close given we now have #48803 and #49207. What do you think? (CC @prattmic)
Thanks for offering help here, but this ended up being intertwined with #47405 and will be resolved as part of that.
> Is it going to be similar to how iOS living today? (i.e. unless `try=ios`, the builder will only be tested after a CL is submitted?) Yes, this is correct. "Removing the builder from the TryBot s…
I think in the current state it makes sense for the `android-amd64-emu` builder to be post-submit only. If I understand correctly, @cherrymui may support that too, based on [this comment](https://…
As a small correction, only the `android-amd64-emu` builder is configured as a TryBot. The `android-386-emu` one is a post-submit only builder for all repos.
Also see #26. Its "Implementation" section discussed two approaches, though more relevant to the GOPATH mode. The Go module mode was added 3 years later and creates new possibilities to fetch depe…
I think we can probably close this in favor of #40279, since the scope of that issue covers everything mentioned here, and it'll be in `cmd/relui` rather than `cmd/releasebot`.
Since this issue is closed as a duplicate of #52026, and that issue is also closed, it's going to be harder to investigate here. If you're seeing a problem that looks related, please file a new issue…
dmitshur pushed to master in github.com/shurcooL/go-vcs2w
d784c9520ccdd19883f59efd0a2ae4441f576582cmd/go-vcs, vcs/hgcmd: update .../sourcegraph/go-diff/diff import path (#112)
2705c8e6e51cc57752376bfe59358e2b99dac4a8Merge pull request #111 from shurcooL/follow-no-glob
236487bb6e4de281ce154ab15746f8e5bd0f1815vcs/gitcmd: not use --follow for glob pathspecs
dmitshur commented on : build dashboard triage log2w
Notes: From a quick random sampling of a few links and seeing the same x/exp test failure, I am guessing a large portion of the failures are all coming from one bad commit in x/exp. Even though th…
dmitshur commented on : build dashboard triage log2w
Giving it a shot to at least collect new findings for this week. <details><summary>Initial setup</summary> ``` $ go install golang.org/x/build/cmd/fetchlogs@latest $ go install golang.org/x/b…
With #53290 resolved, should this be closed too, or is there more to do?
The tweet task currently uses Twitter API v1.1. We can't fully update to Twitter API v2 because the media endpoints aren't available there yet. This is the tracking issue for updating when it's possi…
`https://go.dev/ref` (no trailing slash) redirects to https://go.dev/doc/#references. I suspect this issue can be resolved by making `https://go.dev/ref/` do the same.
I expect [CL 410394](https://go.dev/cl/410394) (CC @rsc) will resolve this issue.
dmitshur pushed to master in github.com/shurcooL/graphql3w
3cf50f8a0a295163db1d360b4de28fb3cb874913internal/jsonutil: support directives directly after name
dmitshur pushed to master in github.com/david-bain/graphql3w
41059dec68f051aa8cd11a5cc48420cf5198d595internal/jsonutil: combine field name separators, add test for '@'
Thanks, this change makes sense. I'll refactor it slightly and add a test before merging.
dmitshur deleted tag in github.com/shurcooL/go-goon3w
experiment-with-bypass_alt
dmitshur deleted branch in github.com/shurcooL-deprecated/goon3w
master
dmitshur created branch in github.com/shurcooL-deprecated/goon3w
main
dmitshur deleted branch in github.com/shurcooL/go-goon3w
master
dmitshur created branch in github.com/shurcooL/go-goon3w
main
dmitshur pushed to master in github.com/shurcooL/go-goon3w