Activity

This Week
dmitshur pushed to master in github.com/shurcooL/markdownfmt2d
75134924a9fd3335f76a9709314c5f5cef4d6ddcall: update github.com/russross/blackfriday to v1.6.0
2100e71982853277d98b2caf5a63b112551073d9add LICENSE file
dmitshur pushed to master in github.com/shurcooL/markdownfmt2d
b99a94c9abe1e4bdf7cdfbc3496076638da828b7all: update github.com/russross/blackfriday to v1.6.0
49fd5a5f24ae02f4347baafaf0f49085f74d5e70add LICENSE file
Thanks for reporting. I’ll fix this soon.
Last Week
The mirroring is done by [`gitmirror`](https://pkg.go.dev/golang.org/x/build/cmd/gitmirror). Unfortunately, we are still waiting on GitHub to expose the ability to lock conversations on commits via a…
dmitshur starred in github.com/beevik/ntp2d
dmitshur commented on a3704cafc7d523c8ea371199636cab38e3d37ba4rsc.io/2fa/2fa: add go.mod3d
Please note while go.mod declares v0.1.2 as the minimum required version of `clipboard`, the [vendored copy](https://github.com/rsc/2fa/tree/a3704cafc7d523c8ea371199636cab38e3d37ba4/vendor) is an old…
Commit a3704cafc7d523c8ea371199636cab38e3d37ba4 has been merged, so maybe this PR can be closed (or, alternatively, rebased to include only the vendor directory removal).
(1 comment) Is this word included unintentionally?
(2 comments) Done. (I didn't apply this to the advice we print because it makes the command too verbose, humans should be able to interpret and use the simple command.) It seems viable to symlink …
(3 comments) > makes it much more likely that someone editing the test will incur at least one extra test/edit cycle if they forget to run it in short mode To clarify, are you aware of a scenario w…
dmitshur commented on github.com/golang/gddo: SERCURITY.md3d
There isn't a need to add a MySECURITY.md file to this repository. Information about security can be found at https://golang.org/security.
dmitshur closed a change github.com/golang/gddo: SERCURITY.md3d
Thanks for sending this change. A similar change was made via https://golang.org/cl/215678, so closing.
(1 comment) Thanks.
Please keep https://golang.org/conduct in mind when taking the time to report an issue. The godoc.org website does not make a decision to hide the scrollbar. This appears to be a configuration opt…
Please see https://github.com/golang/go/issues/41094#issuecomment-682574230.
> OK, so how do we "fix" that? There's nothing you need to do, this was fixed by making a module-aware package documentation available at pkg.go.dev, where as you said this works. Considering http…
(1 comment) Thanks! Done.
(1 comment) TRY=darwin-amd64-10_15 (Fingers crossed I don't run into #42084, but I won't be surprised...)
Tests should avoid writing to GOROOT when possible. Such writes would fail if GOROOT is non-writeable, and it can interfere with other tests that don't expect GOROOT to change during test execution. …
(1 comment) Done.
(8 comments) Thanks for the comments. I've considered them and left inline replies, please let me know what you think. For now, I'll push the next patch set that moves this CL in the direction that…
(1 comment) > This would be better if we had tests for the tree being "go generate"-clean, but AFAIK we don't. There's one being added in CL 283643 now. It primarily targets checking that the tree …
(2 comments) windows-386-2008 failure is #42637. The issue mentioned a preference of an index text file over directory listing due to the latter being more out of date. Has the directory listing be…
We can add a test that catches and reports when the a module in GOROOT is not tidy. Having an automated test for this will prevent it from happening without anyone noticing, and it makes it easier…
Issue #43430 is related. CC @jayconrod. Based on the discussion there, I suspect we prefer suggesting `go get` over `go mod tidy` for the specific task of adding new dependencies. (`go mod tidy` i…
@mvdan Do you think the suggested combined phrasing in https://github.com/golang/go/issues/37097#issuecomment-583182330 would work well?
Done. (A late) Welcome to the team, Tim! CC @golang/release.
dmitshur commented on access: Github("go-approvers")1w
Hi Sean, Thank you so much for your contributions on the issue tracker and elsewhere, they've been very helpful! We've discussed this request on the team and agreed to grant you access. I've sent …
dmitshur closed an issue access: Github("go-approvers")1w
We needed to rewrite the history of x/tools master branch so that the `gopls/v0.6.1` tag would no longer be an ancestor (this is what was causing the pseudo-versions to start with `v0.6.2-0.`). …
dmitshur starred in github.com/hexops/autogold1w
dmitshur pushed to master in github.com/shurcooL/go-goon1w
7585751d9a1713e6e2a31d5860b6793e6683dbcbREADME: add Alternatives section
17bfb51d7f1adcb84175e04983edf72d7bee6f58add LICENSE file
f2cf30a124b79d14764105b7f34f2b95938b0482.travis.yml: use go vet instead of go tool vet
dmitshur commented on 410806f8a482d6c2b70e8cacafe3f1aee179cdefgithub.com/shurcooL/graphql/.travis.yml: use go vet instead of go tool vet1w
@Uzume That commit predated https://github.com/shurcooL/cmd/commit/e8b5cc9577219573d0123cdbaac9cf68111c156b.
Closing due to no answer from PR author. We can re-open if there's new information.
dmitshur starred in github.com/blizzy78/ebitenui1w
Earlier
dmitshur deleted branch in github.com/dmitshur/indielogin.com1w
patch-1
Friendly post-holiday ping, in case you missed this @aaronpk.
Yes, let's do that. Thank you.
Sometimes the "\x00" isn't added automatically out of consideration to avoid allocations, since they can be easily avoided if the caller provides a null-terminated string. That said, [`Strs`](https:…
### What version of Go are you using (`go version`)? Tested with latest tip as of 30 minutes ago. <pre> $ gotip version go version devel +d2131704a Wed Jan 6 15:02:50 2021 +0000 darwin/amd64 …
Thanks for reporting. To confirm, are those warnings reproducible for you, meaning they are emitted for each separate build operation? As I said in https://github.com/golang/go/issues/36025#issuec…
> I think we can forgo a fix for this... I am a few of the last on 10.11.6 ... El Captain. @einthusan Go 1.14 is supposed to require macOS 10.11 as the oldest version, not 10.12. (See [here](https:/…
@einthusan It'll be better to file a new issue, fill in the relevant information, and also mention this issue number. Thanks.
dmitshur starred in rsc.io/rf2w
We skip or fix tests in old branches when the test failure is understood and it interferes with the release process, but it's not a goal to always fix all old tests. If this isn't causing much troubl…
dmitshur pushed to master in github.com/goxjs/gl2w
e3fafc6f8f2a43929cc152a64e4319b747b09f38test: support darwin/arm64 and silence OpenGL deprecation warning
718adbf826b9eee8c7a7d8fc465b4b707142920buse OpenGL ES only on iOS and Android
This issue tracker is for the Go bindings to GLFW. Does the problem also occur upstream, in [GLFW itself](https://www.glfw.org/)?
dmitshur pushed to master in github.com/shurcooL/home2w
164885982757a609c5a32d75bdb13288534023a32021 is the Year of the Gopher
bd7e3538a80227086a2a3ca5bae036a2e36daa4aupdate setup for end of 2020
a843450ede39c23718bf24d4d08a2805c865a069internal/exp/spa: match pages more precisely
d111021689adb16d989289873ce3a2485a96c79cinternal/exp/app/notifsapp: make mark-read button keyboard accessible
194d1342e12832984878e51833c953f43e11395dadd dark mode to login page
7d656fde432a2fba084f6230240b130404e8db39switch to SVG website icon
d14a4919de24f4a35f3d72946c0977da422eb0dbadd /... suffix to repository home URL
@Zegnat I'm not familiar with the history of this codebase to say, but perhaps custom code is being used in order to provide more customization over error messages and diagnostics on indielogin.com, …
Thanks for confirming. Closing as duplicate/resolved in v3.3.
Does the issue also affect v3.3/glfw?
One comment, otherwise LGTM. Thanks!
One comment, otherwise LGTM. Thanks!
Replace “current + two previous” with “current + previous”. Go supports two major releases at a time, not three.
dmitshur starred in github.com/hexops/valast2w
The Go standard library uses vendored copies of some external packages. These packages are updated as needed to fix bugs or bring in new features, and in bulk as part of release cycle maintenance (is…
Yep, the time difference is expected because [`ioutil.ReadDir`](https://github.com/golang/go/blob/go1.15.6/src/io/ioutil/ioutil.go#L91-L105) calls `f.Readdir` which performs lstat for each file to ge…
I'll close this as there's no bug here, and we use the Go issue tracker for bugs and proposals only. For questions and discussion about using Go, please see https://golang.org/wiki/Questions for a…
Directory order means the same order that the operating system returns. This depends on the OS type, version, and importantly the filesystem used at the path that was read. To get a predictable or…
> (Does gomobile set C flags (e.g. `-arch arm64`) explicitly?) I believe it does, see https://github.com/golang/mobile/blob/e6ae53a27f4fd7cfa2943f2ae47b96cba8eb01c9/cmd/gomobile/env.go#L170-L172. …
Thanks for the request and rationale. @thanm Is Go 1.14 okay, or does it need a fix for this problem too? Our backport policy is to either fix the bug in all supported Go versions, or none (if it'…
We have not backported CL 253259 yet. Do you mean that we may do that as part of backport requests #42539 and #42586? If so, please close this and add a comment there. It should be easier to track th…
Could it be that you're running into #42563 and `/Users/furkan/go/src/goroot/bin` isn't in your $PATH?
I see you mentioned #32724, but how is this issue different from that one? I see the title is different, but the steps in "What did you do?" seem to be the same. Also, what does `which go` print?
It seems to me that `embed.FS` and `os.DirFS` are working as intended, you will need to arrange your code to either handle different roots, or have the same root by running your program with `./root …
Thanks. We should fix this in time for the next pre-release of Go 1.16. If you'd like, you can wait until then, but you certainly don't have to. This issue affects only the installer, the actual Go …
> Unfortunately, one of the packages is windows-only. `go test ./...` dies immediately If that package is windows-only, it wouldn't be picked up by the `./...` pattern. Maybe it's missing `// +bui…
Is this problem reproducible even with a small iOS project? If so, can you please share a complete sequence of steps to trigger the problem, and include the full output? (If it's large, you can paste…
This behavior doesn't reproduce for me, see https://play.golang.org/p/Ih5e7bjhbNp. Did you provide the `*token.FileSet` parameter to `astutil.DeleteImport`? If this problem still happens for yo…
The problem may be that we're not including a `hostArchitectures` property in the installer Distribution options: ``` $ pkgutil --expand go1.16beta1.darwin-arm64.pkg out $ cat out/Distribution |…
Thanks for reporting. Perhaps there's some configuration in the installer causing macOS to think Rosetta will be needed, when that shouldn't be the case. We'll take a look. After installing, does …
In the latest 20201126 IndieAuth specification version, it has been clarified that grant_type is a mandatory parameter that must be set to authorization_code¹ when redeeming the authorization code…
dmitshur pushed to patch-1 in github.com/dmitshur/indielogin.com3w
d233e371851e88ec66072c4c5d5fc2c2983e1b85set grant_type=authorization_code in authz code request
@Zegnat Perhaps that code isn't being used. I think the relevant code path is here: https://github.com/aaronpk/indielogin.com/blob/8183508453e2bdc1dd8395f4aa01f9a88bee29cb/app/Provider/IndieAuth.p…
dmitshur opened an issue api: audit for Go 1.16 go1.16.txt3w
next.txt was copied to go1.16.txt in [CL 276454](https://golang.org/cl/276454) (with a followup in [CL 278992](https://golang.org/cl/278992)). This is a tracking issue for doing an audit of API ad…
@eliasnaur Thanks. I've edited my comment above to clarify it's specifically about gomobile's `build` subcommand.