Activity
Yesterday
dmitshur reviewed +2 on golang.org/x/website/_content/doc/install/source: mention GOARCH=loong641d
(1 comment)
Done.dmitshur commented on make.bat: handle spaces in path when determining bootstrap version1d
Alex, sorry for causing confusion. The initial +2 vote I left was not done from a Google machine and only counted for Code-Review, not for Review-Enforcement. When I left a +1 from my @google.com acc…dmitshur commented on build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.171d
Removing +2 here in favor of CL 423354, since it makes the same changes as here but also removes some redundancy to make it easier to update the bootstrap versions in the future. Thanks.dmitshur commented on make.bat: fix GOROOT_BOOTSTRAP default location1d
Thanks, but it seems that this change shouldn't be made as is. Please see inline comment.
All current locations are being documented in a very recent CL 423354:
> GOROOT_BOOTSTRAP: A working Go tre…dmitshur reviewed +2 on make.bat: handle spaces in path when determining bootstrap version1d
Thanks. I came up with the same fix locally, and found this CL before mailing an identical one.dmitshur reviewed +2 on golang.org/x/website/_content/doc/install/source: mention GOARCH=loong641d
Thanks.
There's a recent issue that this will resolve, so please add:
Fixes golang/go#54350.dmitshur reviewed +2 on golang.org/x/website/_content/doc/install/source: reorder the table of GOOS/GOARCH combinations1d
Thanks.dmitshur commented on golang.org/x/website: Installing Go from source page does not mention loong instruction set1d
https://go.dev/cl/421575 fixes this.dmitshur commented on golang.org/x/website/x/website: add loong instruction set desc1d
Please see CL 421575.dmitshur commented on golang.org/x/build: add automated notifications for missing builders to its owner and/or golang-dev1d
In https://github.com/golang/go/issues/50299#issuecomment-1214140833, @changkun also suggested this:
> Perhaps it would be better to have an email notification to the builder maintainer from farme…Last Week
dmitshur commented on github.com/shurcooL/githubv4: More of a question; need clarification2d
I suspect what's happening is that the type of Enterprise.Members a list of EnterpriseMember, which is a GraphQL union:
https://docs.github.com/en/graphql/reference/unions#enterprisemember
So i…dmitshur commented on golang.org/x/build: update Go bootstrap on Corellium builders2d
It looks like these builders are now using a Go 1.18.3 bootstrap (up from Go 1.15.3), and passing:
- [android-arm-corellium at 2f6783c098696790223eae6986700868e9da0472](https://build.golang.org/lo…dmitshur reviewed +2 on golang.org/x/tools/gopls/doc/workspace: correct grammar2d
dmitshur pushed to
patch-1 in golang.org/x/tools2d
dmitshur reviewed +2 on golang.org/x/tools/gopls/doc/workspace: correct grammar2d
(2 comments)
Done in PS 2.
Done.dmitshur commented on cmd/pprof: graphviz node names are funny with generics2d
> Do we have a standard process for backporting one-off fixes to vendored packages, rather than wholesale updates?
We have a standard process that applies to golang.org/x dependencies. It uses "inte…dmitshur commented on cmd/pprof: graphviz node names are funny with generics2d
@prattmic The backporting approach described in https://github.com/golang/go/issues/34536#issuecomment-572188389 suggests we'll need to also backport the fix to 1.18, since the problem also exists in…dmitshur commented on build: update comments about Go 1.4 in make.bash, make.bat, make.rc2d
(1 comment)
Can add "Fixes #54301."dmitshur reviewed +2 on build: update comments about Go 1.4 in make.bash, make.bat, make.rc2d
Also see CL 421834. However this one also addresses some redundancy that we don't want to touch each time the bootstrap will change again.dmitshur reviewed +2 on golang.org/x/build/vcs-test: clean up dead code2d
dmitshur reviewed +2 on cmd: [release-branch.go1.19] vendor github.com/google/pprof to fix mangled type parameter symbol names2d
(1 comment)
You can try to create this change from scratch by running the usual 3 commands in the cmd module:
```
go get github.com/google/pprof@v0.0.0-20220729232143-a41b82acbcb1
go mod tidy
go mo…dmitshur reviewed +2 on golang.org/x/build/vcs-test: clean up dead code2d
Thanks.
It seems to be used now:
```
$ curl -v https://vcs-test.golang.org/ 2>&1 | grep "Let's"
* issuer: C=US; O=Let's Encrypt; CN=R3
```
I take you'll make sure it also works over the vcs-test-…dmitshur reviewed +2 on golang.org/x/build/...: re-disable container native routing2d
dmitshur reviewed +2 on golang.org/x/net: TEST2d
Test review.dmitshur reviewed +2 on golang.org/x/net: TEST2d
Test vote.dmitshur reviewed +2 on test: remove unused code in run.go2d
Thanks.dmitshur reviewed +2 on golang.org/x/net/nettest: fix Unix socket test on macOS2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: update early in cycle email link for 1.202d
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/relui: fix two silly mistakes2d
(1 comment)
Wow, this one hid for almost a year. Thanks for catching.dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: remove Kubernetes buildlet support2d
Nice cleanup, thanks.
Which part are you referring to?
Nit: s/VMS/VMs/
I thought we could also get rid of this entire feature since it's not at all used and it depended on the kube pool, but updat…dmitshur reviewed +1 on golang.org/x/build/dashboard: fix vet warning3d
dmitshur reviewed +2 on build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.173d
Thanks.
We'll likely want to reduce how many things need updating here if we'll be bumping the bootstrap requirement more often (#54265), but this is fine for now.dmitshur reviewed +2 on golang.org/x/build/internal/relui: fix layout for large parameters3d
Thanks very much.
If you want, you can add 'Updates golang/go#53382.' since this extends that work.
Question: Is this attribute used or going to be used? Similarly for 'data-slice' on line 244.dmitshur commented on build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.173d
See inline comments that point out a few more places that are in need of a similar update.
This can be updated.
Here.
Here, and also on line 80 below.dmitshur commented on build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.173d
(2 comments)
I don't think we want to delete the use of go1.4 directory as a last fallback yet. Some users or setups may have a newer, compatible bootstrap at that location, and maybe there's not si…dmitshur opened an issue golang.org/x/vuln/vulncheck: TestCommand, TestBinary, TestExtractPackagesAndSymbols, TestLineFromAline failing after compiler generated symbol change4d
https://build.golang.org/?repo=golang.org%2fx%2fvuln shows test failures on Go tip as of [CL 317917](https://go.dev/cl/317917) ("all: use ":" for compiler generated symbols").
CC @golang/vulndb, @…dmitshur reviewed +2 on golang.org/x/build/env/linux-x86-alpine: update to Alpine 3.164d
dmitshur commented on golang.org/x/build/cmd/relui: workflow parameters of slice types aren't visibly shown4d
Sure, thanks for helping!dmitshur opened a change golang.org/x/website/cmd/golangorg: make release.txt less brittle4d
CL 421426 extended release.txt coverage to include history entries for
the latest releases, including the currently supported Go 1.19 and 1.18.
Make the test less strict so it doesn't start to fail w…dmitshur reviewed +2 on golang.org/x/build/internal/task: always log through the TaskContext4d
Thanks.dmitshur commented on golang.org/x/build: add to trybot set based on port-specific files4d
Issue #42661 is related, it's about automatically opting-in to longtest builders when a change is deemed to modify the cmd/go command or its tests.
CC @golang/release.dmitshur commented on cmd/go: improve error message for replace with '@' in path4d
(The new x/mod version will need to be brought into the main repo, and that'll happen during the Go 1.20 cycle at the very least via #36905.)dmitshur commented on golang.org/x/build/cmd/relui: workflow parameters of slice types aren't visibly shown5d
Looked at this briefly. As expected, it was only a problem for non-string parameters, and it's because the current parameter display code assumes all parameters are strings, which isn't always the ca…dmitshur commented on golang.org/x/build/internal/relui: buildrelease_test fails with flake on uuid length5d
There were 7 occurrences (out of 127) attributed to this issue in [last week](https://github.com/golang/go/issues/52653#issuecomment-1205909358)'s flaky test triage:
- [2022-08-02T02:32:00-4b12e2b…dmitshur closed an issue golang.org/x/build/cmd/gomote: notify gomote users of upcoming change to authentication5d
dmitshur commented on security: fix CVE-2022-27664 [1.18 backport]6d
Since this is in Go1.18.6 milestone, added a "[1.18 backport]" suffix and a CherryPickCandidate label so this doesn't get missed during backport review, but I expect it to get approved as a security …dmitshur commented on cmd/pprof: graphviz node names are funny with generics6d
I'll move this issue to Go 1.20 milestone since the fix will need to land on master branch first. To address this issue for minor releases, we'd need to use the https://go.dev/wiki/MinorReleases proc…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle6d
CLs 421334 and 421461 took care of all the golang.org/x dependencies, and [CL 420234](https://go.dev/cl/420234) will update pprof.
Once that's done, we can remove the early-in-cycle label and revisi…dmitshur commented on cmd/compile/internal/test: TestAppendOfMake fails with GOEXPERIMENT=unified6d
Removing Soon label since [CL 422037](https://go.dev/cl/422037) added a " && !goexperiment.unified" build constraint, so the builder doesn't fail now. Thanks.dmitshur opened an issue cmd/compile/internal/test: TestAppendOfMake fails with GOEXPERIMENT=unified6d
Observed in trybots of CL 420234:
```
--- FAIL: TestAppendOfMake (0.00s)
issue53888_test.go:29: got 1.000000 allocs, want 0
issue53888_test.go:41: got 1.000000 allocs, want 0
FAIL
FAI…dmitshur commented on all: add freebsd/riscv64 port6d
CC @golang/release.dmitshur closed an issue all: reopen tree for Go 1.20 development6d
dmitshur commented on all: reopen tree for Go 1.20 development6d
We're ready to complete the tree reopening. Updated the tree status heading to "Open for Go 1.20 development". Happy development!Earlier
dmitshur pushed to
master in github.com/go-gl/glfw1w
dmitshur closed an issue github.com/go-gl/glfw/v3.3/glfw: warning: 'GLAPIENTRY' macro redefined1w
dmitshur merged a change github.com/go-gl/glfw/v3.3: Update glfw to v3.3.81w
dmitshur reviewed +2 on github.com/go-gl/glfw/v3.3: Update glfw to v3.3.81w
Thanks.dmitshur commented on golang.org/x/build: various timeouts on dragonfly-amd64 builder1w
I think this is fixed by [CL 419084](https://go.dev/cl/419084); this builder was recently replaced with another.dmitshur closed an issue golang.org/x/build: various timeouts on dragonfly-amd64 builder1w
dmitshur commented on golang.org/x/tools/internal/lsp: TestLSP/GOPATH failure with "race detected during execution of test"1w
Thanks and sorry I missed it. I changed the prefix in the title of [#54214](https://github.com/golang/go/issues/54214#event-7136329449) to follow the usual [convention](https://github.com/golang/tool…dmitshur commented on golang.org/x/net/lif: as long as std imports these packages, they can't import golang.org/x/sys/unix because of standard library policy1w
Thanks Ian for finding a resolution to this issue that's better than reverting those earlier x/net CLs. I'm glad I left x/net out of CL 421334 to create an opportunity to take time to think about thi…dmitshur commented on golang.org/x/tools/go/ssa: panic: T1w
CC @timothy-king, @findleyr.dmitshur commented on : build dashboard triage log1w
`greplogs --triage --since=2022-07-27`
- #54276
- [x] [2022-08-02T18:52:36-0d04f65-4345620/freebsd-amd64-race](https://build.golang.org/log/927c2103551010f213d6fbd0e8afa80897bca0bb)
- #53037
…dmitshur opened an issue golang.org/x/build: instances of all internet-facing tests failing1w
What happened here? All the internet-facing tests failed with errors.
```
[...]
2022/07/28 00:33:59 syncing segment 136 did not succeed on attempt 3, will try again in 9s: https://maintner.golan…dmitshur opened an issue cmd/go: TestScript timeout on dragonfly-amd641w
```
--- FAIL: TestScript (0.02s)
--- FAIL: TestScript/mod_all (8.94s)
[...]
rflags 0x202
cs 0x2b
fs 0x23
gs 0x23
[c…dmitshur closed an issue syscall: TestSetuidEtc failure1w
dmitshur commented on syscall: TestSetuidEtc failure1w
Duplicate of #19938.dmitshur commented on golang.org/x/tools/cmd/fiximports: frequent TestDryRun and TestFixImportrs timeouts on plan9-arm since 2021-11-121w
Also an occurrence on dragonfly/amd64:
[2022-08-02T14:13:40-310ea71-f2a9f3e/dragonfly-amd64](https://build.golang.org/log/c9ccaf3eae394f16eb3e6dec27d90f169db0f332)dmitshur opened an issue golang.org/x/tools/gopls/internal/regtest/misc: TestSimultaneousEdits failure with "error(s) cleaning sandbox", unlinkat directory not empty1w
```
[...]
1 @ 0x1068299 0x107d1a8 0x107a24b 0x10ab2b7 0x1160c8b 0x1160c7d 0x12a47e6 0x106be41
# 0x1068298 syscall.syscall6+0x98 /Users/gopher/workdir/go/src/runtime/sys_darwin.go:44
# 0x10…dmitshur opened an issue golang.org/x/tools/internal/lsp: TestLSP/GOPATH failure with "race detected during execution of test"1w
```
2022/08/02 19:20:54 New session
create_session=1
2022/08/02 19:20:56 go/packages.Load #1
[...]
==================
WARNING: DATA RACE
Read at 0x00c0086205a0 by goroutine 34461:
golang.o…dmitshur opened an issue golang.org/x/build: linux-amd64-wsl builder runs into "unexpected EOF" errors downloading dependencies1w
From https://build.golang.org/log/1d606b9af9022065aa9b7b4dd76799415ae5fd0b:
```
[...]
go: downloading github.com/gobwas/pool v0.2.1
go: downloading golang.org/x/text v0.3.6
go: downloading git…dmitshur opened an issue syscall: TestSetuidEtc failure1w
```
--- FAIL: TestSetuidEtc (0.01s)
syscall_linux_test.go:565: [6] "Setgroups([]int{0,1,2,3})" comparison: "/proc/85360/status" got:"Groups:\t0 1 2 3 4 6 10 11 20 26 27" want:"Groups:\t0 1 2 3"…dmitshur opened an issue golang.org/x/net/nettest: TestTestConn/UnixPipe failures on darwin/amd641w
```
--- FAIL: TestTestConn (0.53s)
--- FAIL: TestTestConn/UnixPipe (0.13s)
--- FAIL: TestTestConn/UnixPipe/BasicIO (0.00s)
conntest.go:32: unable to make pipe: listen unix…dmitshur opened an issue golang.org/x/tools/gopls/internal/regtest/misc: TestFailingDiagnosticClearingOnEdit failures with "context deadline exceeded"1w
There are instances of the `TestFailingDiagnosticClearingOnEdit` test failing with "context deadline exceeded":
```
--- FAIL: TestFailingDiagnosticClearingOnEdit (560.80s)
--- FAIL: TestFai…dmitshur commented on cmd/go: go.work: `go build` requires versioned replace directive when replacing a used module with a local path1w
CC @bcmills, @matloob.dmitshur opened an issue cmd/api: API check failing with "go tool api: signal: killed", "exit status 1" on linux-ppc64le-buildlet, linux-ppc64le-power9osu1w
As of [CL 420902](https://go.dev/cl/420902) ("cmd/dist: require Go 1.17 for building Go" for #44505), API check fails on these two builders with:
```
##### API check
Error running API checker: e…dmitshur commented on all: reopen tree for Go 1.20 development1w
Everything that was planned is in, I've updated the tree status heading to say that bug fixes and stability improvement CLs are okay to land, and the tree can be fully opened on Monday.dmitshur commented on cmd/go: `go list -json -m` does not provide `Replace.Path` relative to current directory when using workspaces1w
CC @bcmills, @matloob.dmitshur commented on cmd/compile: self-contradictory error message when separating the definition and implementation of an interface with anonymous structs in a method signature1w
CC @golang/compiler.dmitshur commented on golang.org/x/sys/unix: panic when using solaris Event Ports1w
CC @golang/runtime.dmitshur commented on debug/pe: RiscV64 is not supported1w
CC @alexbrainman, @golang/riscv64.dmitshur commented on debug/pe: check for PE or PE32+ executable is not fully correct1w
CC @alexbrainman.dmitshur commented on runtime: panic marked free object in span[1.17]1w
CC @golang/runtime.dmitshur commented on golang.org/x/build: update Go bootstrap on Corellium builders1w
CC @golang/release.dmitshur commented on golang.org/x/net/lif: as long as net imports this package, it can't import golang.org/x/sys/unix because of standard library policy1w
Next up:
```
$ go mod why 'golang.org/x/sys/unix'
# golang.org/x/sys/unix
net
golang.org/x/net/route
golang.org/x/sys/unix
```dmitshur commented on golang.org/x/net: drop unused variables and consts that x/sys/unix has1w
For x/net packages that are vendored into std, this appears to be incompatible with the policy set in #32102 that std shouldn't vendor golang.org/x/sys/unix. See #54259.dmitshur opened an issue golang.org/x/sys/lif: as long as net imports this package, it can't import golang.org/x/sys/unix because of standard library policy1w
Updating to latest golang.org/x dependencies causes golang.org/x/sys/unix to be vendored into std, which goes against the policy set in go.dev/issue/32102:
```
--- FAIL: TestScript (0.02s)
-…dmitshur commented on go/doc/comment: Inconsistent documentation about comment.Parser.LookupPackage == nil1w
CC @rsc.dmitshur commented on golang.org/x/tools/cmd/gorename: Renaming Interface Functions Does Not Affect Implementations1w
Is this about [cmd/gorename](https://golang.org/x/tools/cmd/gorename) specifically, or more broadly one of the packages that gopls uses?
CC @golang/tools-team.dmitshur commented on golang.org/x/net/http2: stream reset on invalid content-length header drops conn flow control1w
CC @neild, @tombergan.dmitshur closed an issue golang.org/x/build/cmd/releasebot: consider a third -mode=wrapup mode for wrapping up a release1w
dmitshur commented on golang.org/x/build/cmd/releasebot: consider a third -mode=wrapup mode for wrapping up a release1w
This is a key part of what relui does for us, and by now it has superseded releasebot. Closing.dmitshur commented on golang.org/x/build/cmd/releasebot: improve -dry-run -mode=prepare to support advance testing for more release types1w
releasebot has been superseded by relui and this issue doesn't apply directly. relui has a "dry-run (test and build only): ..." workflows for testing, and #47407 is for more. Closing.dmitshur closed an issue golang.org/x/build/cmd/releasebot: add an upper limit to the total log posted to GitHub1w
dmitshur commented on golang.org/x/build/cmd/releasebot: add an upper limit to the total log posted to GitHub1w
releasebot has been superseded by relui, and relui doesn't post to GitHub issues, so this issue no longer applies. Closing.dmitshur closed an issue golang.org/x/build/cmd/releasebot: canceled release can create truncated tarballs1w
dmitshur commented on golang.org/x/build/cmd/releasebot: canceled release can create truncated tarballs1w
releasebot has been superseded by relui and this issue no longer applies, closing.dmitshur commented on runtime: occasional "exit status 0xc0000005" on windows-386-2012 builder1w
It's the only one I've seen so far; we can try greplogs or similar tools to look if there've been more.