See inline comments for tests, otherwise I think this is okay to submit. Thanks.
This `TestHooksOverwriteOldCommitMsg` test is supposed to be testing that the old commit-msg hook is still being rewr…
Apply lucicfg fmt.
Doesn't matter much, but macOS 11 was released in Nov 2020 (along
with the first Apple silicon Macs). In June it was only announced.
Thanks.
(optional) Right now the 'dialServer' path is being taken in swarming bot mode by modifying the if statement on line 249.
Since it seems the swarming bot mode is more like reverse than non-…
Thanks.
I see, thanks for explaining the context. I agree the copy is justified given it avoids that complexity now.
Using runBuildStep looks like a good improvement, thanks.
```suggestion
func (b…
The release-blocker here is inherited from the upstream issue (https://github.com/golang/go/issues/63260#event-10501492244 + https://github.com/golang/go/issues/63260#event-10501491205). (CC @findley…
Moving this to the Go 1.22 milestone to track the fix at tip, and copying @rfindley's release-blocker label to the backport issue (which now tracks the fix for Go 1.21.3). Please feel free to remove …
(5 comments)
Yep. FWIW, moving signed results next to unsigned ones is indeed how it used to work during the releasebot era. It was only with relui that we wanted to avoid different tasks/services w…
As observed in https://go.dev/issue/61666#issuecomment-1739476954,
if a -run flag value matches no tests, dist test output doesn't do much
to help users notice that was what happened. It is valid and…
CL 233437 added a redactedURL field to proxyRepo, a struct that already
had a field named 'url'. Neither fields were documented, so the similar
names suggest the most natural interpretation that prox…
CL 406675 added more detail to bare errors from net/http in two places.
CL 461682 improved one of the two places to stop folding "//" into "/".
This CL applies the same change to the other place.
Fo…
Basic cut functionality is available in the standard library as of
Go 1.18, so today's supported Go versions (1.21 & 1.20) can use it.
Also simplify some slice and map code while here.
Basic cut functionality is available in the standard library as of
Go 1.18, so today's supported Go versions (1.21 & 1.20) can use it.
Also delete cutAny since it was unused.
The page you linked to is a part of the GitHub REST API. If that's what you're looking for, see https://pkg.go.dev/github.com/google/go-github/v55/github#SecurityAdvisoriesService. This repository ha…
Sorry you ran into this, and thanks for adding the comment. It’s sometimes possible to catch these types of issues via the dry-run mode, but even that can only so far.
(1 comment)
We already use the 'os:Linux' dimension for coordinator builders (where, like here, any Linux is fine). It seems I can resolve this TODO by changing the expected_dimensions["os"] in crre…
Thanks.
If you haven't already, you could consider %q over %v, which might help if there are filenames with spaces in the future.
(minor)
The ServiceAccount field [docs](https://pkg.go.dev/cloud.g…
If LUCI_MACHINE_TOKEN is set in the environment (intended for the
swarming bot; added in crrev.com/i/6478812), also recognize it here
and use it as the default token file path flag value.
> `2023/09/22 11:24:17 unable to read file "/var/lib/luci_machine_tokend/token.json": open /var/lib/luci_machine_tokend/token.json: no such file or directory`
@rorth Sorry, that may have been a ty…
As visible at https://go.dev/rebuild, `gorebuild` has uncovered the possibility of non-reproducibility on go1.21.1.linux-armv6l.tar.gz (and its module zip version, v0.0.1-go1.21.1.linux-arm.zip) in t…
The decision to not ship race detector syso files for other platforms was made in 2018 in cmd/release ([CL 144281](https://go.dev/cl/144281)), to reduce archive binary size. It was ported to cmd/relu…
So far the data points suggest the flake rate is at an acceptable (to me) rate. At least it's not unreasonably high.
Closing since doesn't need active work and watchflakes will still post results.
@BerndCzech Thanks for looking to contribute to Go. There is indeed an existing CL here, and a next step before it can be submitted is for it to be [reviewed](https://go.dev/doc/contribute#review). I…
This was waiting on #62076. Now that the off-cycle Go 1.19.13 release is published, I think this is unblocked.
This isn't urgent and probably a good task for someone who's on interrupts and has ti…
The current relui logic is as follows:
```Go
publishingHead := wf.Task4(wd, "Check branch state matches source archive", build.checkSourceMatch, distpackVal, branchVal, versionFile, source, wf.Af…
Yes, that appears to be what's happening.
As far as I can see, the root problem is that as of https://github.com/gofiber/fiber/pull/2588, the go.mod of the module github.com/gofiber/fiber/v2 state…
Sorry it's a bit confusing. There's a good description at https://go.dev/ref/mod#graph-pruning. Given this is only relevant to older Go versions that aren't supported by now, I don't think there's an…
The go directive in x/mobile is set to 1.17. Given by now only Go 1.21 and 1.20 release, let's fix this by bumping to a newer Go language for the module: one of 18, 19 or 20.
To clarify, is this proposal to replace OpenGL ES 2 on Android with OpenGL ES 3? That is, to drop 2 and add 3 in its place?
Given Android 5 was released in 2014 and is unsupported since 2016, I ca…
Oh, it does seem to match the documented behavior. [CheckFilePath](https://pkg.go.dev/golang.org/x/mod/module#CheckFilePath) docs say:
> The definition of a valid file path is the same as the defi…
Here's a smaller reproducer:
```
$ cd $(mktemp -d)
$ go mod init test
$ GOPATH=$(mktemp -d) GOPROXY=direct GOSUMDB=off go get github.com/chinmayb/notepad@v0.0.1
go: downloading github.com/chin…
Thanks for reporting this. CC @bcmills, @matloob.
I wanted to clarify a part of the "What did you do?" section. Specifically, when you start out with a go.mod file with support for Go 1.17 through…
@griesemer Sorry, I just noticed this issue in the Go1.21.1 milestone now. It was missed earlier because it didn't have the usual CherryPickCandidate label and "[1.21 backport]" suffix (see https://g…
@gaby Thanks for reporting, but this is a closed issue and it's not appropriate to investigate here. Both `go mod tidy` and `govulncheck` should be working successfully even with the default auto. Gi…
Also moving back to Go1.21 milestone, since that's when this was completed.
(Gopherbot automatically moved it to the next milestone because it was still open.)
@bcmills The release branches are planned to be frozen today. Given the upstream issue isn't resolved yet, and you said it might be better to let it slip to Go 1.21.2 instead of holding back the Go 1…
The track1.dat is an internal format of the game whose source code is located in this repository. You can refer to the Go reimplementation [track/track.go](https://github.com/shurcooL/Hover/blob/HEAD…
Thanks for the detailed proposal.
I noticed currently there's no discussion of exit codes here. It's a small detail, but still fairly important in that each future consumer of the JSON will need t…
Also see #56530, which I think this is either a subset or a duplicate of. It was waiting for the next friction fixit week, but we've discussed and agreed to up its priority, so I'm resuming work on i…
One more data point: x/pkgsite is untagged so its x/mod dependency wasn't automatically updated. If this issue were resolved, #62031 might've been resolved sooner or avoided.
Revision 1081f8c0 has completed by now: https://build.golang.org/log/b6794b36aae821c21ac4dd69b38f795c412fabe0.
The other two are still running, but spent most of the 20 hours waiting for a builder…
This issue still needs to be investigated. It it's determined that the current behavior is buggy, the fix will need to be developed for Go 1.22 first before it can be considered for backport.
To m…
<!--
Please answer these questions before submitting your issue. Thanks!
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
</pre>
### Does this issue reproduc…
It's good that the workaround of disabling cgo works.
I'm not sure what's causing the problem when cgo is left enabled. It might be something about the environment you're running this on. Has inst…
Indeed, thanks for reporting.
It was set to GOARM=6 in 1.20 and older because the release target used the [linux-arm-aws builder](https://cs.opensource.google/go/x/build/+/master:internal/releaset…
Can you elaborate on what you mean by "vim-go deosn't work with gopls."? In what way does it not work? If there's an error printed, what is its text? Or is there no error, just no functionality?
C…
What is your Xcode version? I think `xcodebuild -version` should print it. If it's Xcode 15 (beta), there are some known issues that are being worked on, e.g., see #61229, although this failure mode …
> android was special-cased to return / in https://go.dev/cl/139717.
> The commit message and code-review comments do not explain why, as far as I can tell, and no code comment was added explaining …
What does the Go language specification say about this?
I expect this is working as intended, and the https://go.dev/doc/faq#convert_slice_with_same_underlying_type entry covers this situation.
…
I might be able to help a bit sooner too. :)
Sent [CL 520900](https://go.dev/cl/520900).
FWIW, if you think it has a chance to help more, it's also fine to use go1.21.0 as the bootstrap for thi…