Activity

Today
dmitshur commented on all: update vendored dependencies1h
Left a comment on [CL 600436](https://go-review.googlesource.com/c/go/+/600436#message-8) about the TestNewReleaseRebuildsStalePackagesInGOPATH failure.
The cmd/go.TestNewReleaseRebuildsStalePackagesInGOPATH test is failing (e.g., https://ci.chromium.org/b/8741595849470417761). Is it a matter of updating the test case or is there more to do? Please f…
dmitshur opened a change all: update vendored dependencies1h
The Go 1.24 development tree has opened. This is a time to update all golang.org/x/... module versions that contribute packages to the std and cmd modules in the standard library to latest master ver…
No worries, it was really minor, and thanks.
(1 comment) (Also, while you're here, could keep these sorted.)
Thanks. Optionally: ```suggestion "sweet/.+[.]go", ```
CC @golang/aix.
@thanm That generally happens as part of issue #36905 which is early-in-cycle and we'll get to soon. It's fine to do it separately even sooner if needed.
Thanks for finding that. Note that x/oscar is defined PT.TOOL, a repository intended to only be tested on a few first-class platforms like Linux/Windows/macOS, in the LUCI build configuration (see [h…
dmitshur closed an issue all: reopen tree for Go 1.24 development4h
The tree is now open. See [announcement](https://groups.google.com/g/golang-dev/c/or4BmCu3LIE/m/a1Hv1yoxBAAJ) on golang-dev. Thanks.
@mknyszek I looked only very briefly, but isn't the problem that the baseline toolchain is something like 1.22 so the constraints in runtime_go1.20_21_22.go match, but because sweet now sets the `unt…
The gotip-linux-amd64_{c2s16,c3h88}-perf_vs_release builders are failing at tip due sweet running into an error building cockroachdb for baseline: ``` [sweet] error: build cockroachdb for baselin…
Yesterday
Sent [crrev.com/c/5730108](https://crrev.com/c/5730108) to work around the problem, to unblock golangbuild development while is go1.22.6 isn't released yet.
There were about 7 CLs that were already approved and marked AutoSubmit+1, but blocked on wait-release. They're now in. I'll wait to see the results on the post-submit dashboard and follow up before …
(1 comment) This is due to a constraint of the Go language syntax. Without the parentheses, the '{' for the composite literal and the '{' for the if statement overlap. Putting the composite literal …
The same change was applied in CL 595895, so rebasing this made this CL empty. Nothing more to do here, closing.
Thanks for pointing that out. Fixed by [CL 595895](https://go.dev/cl/595895).
Add this file now so that it's possible to preview the latest release notes draft at https://tip.golang.org/doc/go1.24, and to include that link in the tracking issue. Based on CL 588057 that did thi…
This problem doesn't affect Go 1.21, only 1.22, because it's related to https://go.dev/doc/go1.22#trace changes, is that right?
(1 comment) In PS 2, updated to pull in 2 more CLs that landed before the "goversion bump" CL.
[CL 600176](https://go.dev/cl/600176) did this for Go 1.24; moving to the next milestone.
CC @golang/runtime via [owners](https://dev.golang.org/owners).
(1 comment) This change is ready for review. I read over the list of changes to confirm they're all intended for 1.23 and okay per freeze policy, didn't spot any problems.
Go 1.24 is in the process of being opened for development (to be eventually released). This change marks the very beginning of its development cycle, updating the Version value accordingly. For #407…
dmitshur opened an issue doc: write release notes for Go 1.241d
This is the tracking issue for writing the Go 1.24 Release Notes. The previous issue was #65614.
@cuonglm We'll soon merge everything on the main branch, up to but not including the upcoming "internal/goversion: update Version to 1.24" CL, to release-branch.go1.23. Since [CL 599675](https://go.d…
We've reached the time to reopen. I'll be starting on this soon. So far it seems there aren't any large changes that need special treatment; please comment if we missed something that should land ear…
Last Week
It's not needed as of Go 1.20, the generator is seeded randomly at program started anyway.
In the last successful build from 20 hours ago, the "7. upload benchmark results" step took 6.9 seconds. In the failing builds since then, it's failing after 7-9 minutes and the "results" log appears…
dmitshur closed an issue : JSON_Parser_BUG6d
[CL 598532](https://go.dev/cl/598532) deleted this test case. Thanks.
The 'module with one vuln' screentest failure is due to a pre-existing problem (filed #68467), not caused by this change, and everything else passed. Bypassing.
The screentest "module-with-one-vuln" is currently failing at tip, as seen in the most recent trybot occurrence in [CL 598524](https://go.dev/cl/598524). This test case was very recently fixed in …
Closing, an equivalent change was applied in CL 590796 and issue #64216 is closed, so there's nothing left to do here. Thanks.
By now Go 1.19 isn't supported, so there's no need to work around go.dev/issue/52287 in this module anymore. For golang/go#57792. For golang/go#52287.
This is [fixed](https://github.com/user-attachments/assets/2e119a47-25f1-4614-b330-22122b485219) now, so closing. Thanks.
Thanks. Please add the repo prefix since this isn't the main Go repo: ```suggestion Update golang/go#67105 ``` (It looks like we missed `issuerepo: golang/go` in codereview.cfg on this branch; wit…
Earlier
dmitshur starred github.com/gowebapi/webapi1w
Thanks. Should be v0.22.0 to keep both modules in sync. Edit: Done in PS 2.
> And there does not appear to be anything for `openbsd-arm` (or possibly `openbsd-armv7`) here: Yeah, the *bsd-armv7l CIPD binaries haven't been added yet. @bsiegert Do you have plans to work on …
Thanks. The general approach here looks good, and we discussed some of the remaining open questions recently, so moving this CL to your attention set. Yep. Certainly seems fine to leave to a separat…
Filed #68402 to track the current problem with the builder.
https://ci.chromium.org/ui/p/golang/builders/ci/gotip-freebsd-riscv64 In the Machine Pool section, it's visible that the [freebsd-riscv64-mengzhuo](https://chromium-swarm.appspot.com/bot?id=freebs…
Thanks. Returning no error is equivalent to the previous behavior, but it's probably a slight improvement to make this task fail visibly rather than become a quiet no-op in the unlikely case the scr…
Discussed this with Ian. We concluded this machinery is indeed fine to remove, and then archive the golang-wikichanges mailing list. Moving to NeedsFix.
dmitshur reviewed +2 on make.bash: drop GNU/kFreeBSD handling1w
Thanks.
Yes, LUCI builders with a known issue aren’t shown on the build.golang.org dashboard, so removing its known issue will make it visible. Thanks. You can also add an entry to a [BuildersPortedToLUCI]…
Congrats on reaching this point! > Do we want to cut over the build dashboard? Are you referring to removing the known issue for the builder at https://cs.opensource.google/go/x/build/+/luci-config…
@gopherbot Please backport to Go 1.22. Only Go 1.22 needs the fix, as this isn't an issue in Go 1.2​1. This is a regression that can cause wrong binaries to be executed on Windows, with no worka…
@zigo101 When fixes are made, they're included in the next major release. That is the default. Only in rare cases when it is deemed necessary they are also backported to currently supported major rel…
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)
Reported #68314 for the root cause. I'll wait a bit to see how it goes there before coming back to this.
I sent [CL 596875](https://go.dev/cl/596875) with a proposed fix. Its approach is based on an earlier prototype ([CL 575275](https://go.dev/cl/575275)).
That CL pulled in 7 changes from x/telemetry: https://go.googlesource.com/telemetry/+log/51e8b5d718eb..7d78a974cc44. Skipping ones that were test-only or modifying services (and not vendored to the m…
As a mitigation to unbreak Windows builders, [CL 596815](https://go.dev/cl/596815) pins the previous golangbuild version.
dmitshur created repository in golang.org/x/oscar2w
[mirror] Open source contributor agent architecture repo.
Right now the `CreateAutoSubmitChange` method is willing to create a CL, fail to add a reviewer, and report the failure to the caller. This leaves CLs behind and is generally not the optimal behavior…
What was the exact command you ran, and what was its output?
This is a duplicate of #32897 and more (see related issues above). To get the behavior you'd like, it requires changing the helper defined in your code: ```diff -func performHttpRequest(method…
It's unexpected that the error includes a different email than your primary Gerrit email, the one visible at https://go-review.googlesource.com/dashboard/54019. I'll look into why this might be happe…
dmitshur starred github.com/mjl-/mox3w
dmitshur starred github.com/mjl-/gopherwatch3w
> Sure, but deadline exceeded to download what? If I knew what the URL was or a command to reproduce the download, it would have been much easier to troubleshoot further. Note that the exact "cas …
Our default policy decision is to support all supported versions of Go equally. See [proposal 34536](https://github.com/golang/go/issues/34536#issuecomment-572188389). Since this problem affects both…
In case you haven't already seen it, there is open source documentation for the Swarming Bot at https://chromium.googlesource.com/infra/luci/luci-py.git/+/main/appengine/swarming/doc/Bot.md. The "…
This is a consequence of the simplification of the build policy during the migration to LUCI. With coordinator, there were many custom policies applied to builders individually, including what you me…
Closed by merging [CL 593876](https://go.dev/cl/593876) (commit ceaf26ecce663e75c4f4b476dc3c64fa58a2f0dd) to `release-branch.go1.22`.
@ncruces See https://go.dev/wiki/SlowBots. In particular, you should be able to include a footer like this: ``` Cq-Include-Trybots: luci.golang.try:x_sys-gotip-netbsd-arm64 ``` That'll cause …
This functionality and test was recently added in [CL 592415](https://go.dev/cl/592415). It fails on GOOS=openbsd specifically: ``` === RUN TestMmapPtr mmap_unix_test.go:72: Munmap: invali…
This functionality and test was recently added in [CL 592415](https://go.dev/cl/592415). It fails on GOOS=netbsd specifically: ``` === RUN TestMremapPtr mremap_test.go:67: MremapPtr: canno…
These tests probably shouldn't run on GOARCH=wasm. They fail due to "not implemented" errors, e.g.: ``` === RUN TestFreeRefs/file2.go freesymbols_test.go:107: file2.go:1:19: could not impo…
The legacy builders freebsd-amd64-13_0 and freebsd-amd64-12_3 are frequently failing with "connection reset by peer": ``` --- FAIL: TestTLS13OnlyClientHelloCipherSuite (0.00s) --- FAIL: Test…
> Questions for @golang/release: is there a policy on how to bump go.mod versions of x/ repos? There isn't something written down beyond the [Go release policy](https://go.dev/doc/devel/release#po…
Thanks, please feel free to work on it and send a CL. See https://go.dev/doc/contribute.
The Google Docker build task is currently made of two tasks: one to start a Cloud Build invocation, and another to await its result. This has a flaw in that if the Cloud Build invocation happens to f…
> `GOFLAGS='-ldflags=-linkmode=internal'` That looks relevant! Please without forcing internal link mode (which isn't supported with cgo, see golang/go#38918).
That's quite odd. I'm finding similar errors in issues like https://github.com/mattn/go-sqlite3/issues/112, https://github.com/mattn/go-sqlite3/issues/404. They suggest this might be caused by someth…
Thanks for trying. That's unexpected. I have a similar setup but I can't reproduce the problem so far. A few more ideas to try: 1. What's your Xcode version (`xcodebuild -version`)? 2. To confirm, s…
v0.0.0-20210410170116-ea3d685f79fb is a pretty old version of glfw/v3.3. Can you try the latest and see if that fixes it? ``` go get github.com/go-gl/glfw/v3.3/glfw@latest go run . ``` If so, we sh…
@0intro Sorry it took a while before I had a chance to get back to this, but I'm glad you were able to make progress. There is open source documentation for the Swarming Bot at https://chromium.googl…
Duplicate of #54279
Duplicate of #54279
At least partially a duplicate of #54279. I'll let watchflakes file a new issue when it's a different problem.