Today
dmitshur commented on x/tools/cmd/go-contrib-init: requir… in github.com/golang/go5h
> to be set up as x/tools/scratch Did you mean "as x/scratch" in the title? I think there's still value in pretending scratch would live at `golang.org/x/scratch`, if it were a real subrepo, becaus…
dmitshur starred github.com/aykevl/tinygo9h
dmitshur commented on apostrophes get turned into HTML en… in github.com/microcosm-cc/bluemonday15h
> that data will be saved in a database eventually and redisplayed later. How are you planning to display it later? It sounds like what you’re looking for is an HTML to text renderer. Then yo…
dmitshur commented on Rendering a Triangle with Apple's M… in dmitri.shuralyov.com/blog17h
An update: there is now code to open a window with a Metal layer, and render the triangle that follows your mouse at 60+ FPS. [![Image](/usercontent/1924134@github.com/8c1b2d6a-f367-4170-aa2c-016b0e…
dmitshur pushed to master in dmitri.shuralyov.com/service/change17h
a85b471d5412b6580fdd6bdbaedc2365efe16812fs: Finish and merge the mtl change.
e712a6949fbe7fe04b2f49fc22810f827b17f3f8maintner: Display hashtags as labels.
dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow18h
I'm okay with quoting the C type; I just wanted it to be a more complete sentence (with a period at the end).
dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow18h
Source: https://golang.org/s/style#declaring-empty-slices.
dmitshur deleted branch in dmitri.shuralyov.com/gpu/mtl18h
window-60fps
Yesterday
dmitshur created package dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/ns18h
Package ns provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur created package dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/ca18h
Package ca provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package dmitri.shuralyov.com/gpu/mtl/example/movingtriangle18h
movingtriangle is an example Metal program that displays a moving triangle in a window.
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl18h
c4eb07ba2d711bc78bcd2606dd587d9267a61aa5Add minimal API to support interactive rendering in a window.
7a718d85c5434c53dac1cf3027b30739f15d7948Add PixelFormatBGRA8UNormSRGB, SetVertexBytes.
dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow20h
I know `gl` is a large generated package, but I still think it'd be nice to follow http://golang.org/s/style#comment-sentences more closely. Perhaps generate sentences like this: ``` // Parame…
dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow20h
More idiomatic to just do `var lines []string`.
dmitshur commented on Replace exported C types with unsaf… in github.com/go-gl/glow20h
You're checking if the `fn.Doc` string is not empty here, right? I recommend this style: ```Go if fn.Doc != "" { ``` For reasons style described in https://dmitri.shuralyov.com/idiomatic-go#e…
dmitshur closed an issue in github.com/golang/go1d
dmitshur commented on access: may-start-trybots in github.com/golang/go1d
Hi Carlos, Thank you for your contributions and for requesting Trybots access! I've added you to the `may-start-trybots` group, so you should be able to do so now. As you've likely read at http…
dmitshur commented on encoding/gob: tooBig is too small in github.com/golang/go1d
Indeed. I kept an eye on gopherbot logs (among other things) during the GitHub semi-outage, and didn't spot it doing anything visibly bad. (See #28320 for what I did find, but it's unrelated to this.…
dmitshur commented on x/build/maintner: reports incorrect… in github.com/golang/go1d
This would be a good issue for anyone who wants to help out and do some investigation. It'd be very helpful for us to find out what's causing this issue.
dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl1d
Sounds good; I'm in agreement. Following the same logic, I think we should change (or consider changing; perhaps for 3.3) `GetCocoaWindow` and similar methods in `glfw` to return `unsafe.Pointer` …
dmitshur pushed to master in github.com/shurcooL/goexec1d
67b40f7358c4d2374e5372905ba1f9a4af90607fRename local variable cwd to wd.
This Week
dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl1d
> I think `uintptr` makes the most sense, just because that is what is proper in general / it is the least bad solution. One issue I'm currently facing with pointers to C types returned as `uintpt…
dmitshur commented on No longer go gettable with go 1.11 … in github.com/davecgh/go-spew2d
I don't think you can use `GO111MODULE=on` inside a GOPATH workspace, can you? I think `GO111MODULE=on` is allowed only outside of GOPATH, and ``GO111MODULE=off` or ``GO111MODULE=auto` are allowed …
dmitshur commented on 97b652c58466a1dd57beeb94ce8410b0ed39b79aInitial Metal example in github.com/glfw/glfw2d
I see, thanks. Reading the rest of the documentation I linked above has some very relevant sections: > In addition to creating a layer-backed view, you can create a layer-hosting view by assigning…
dmitshur commented on 97b652c58466a1dd57beeb94ce8410b0ed39b79aInitial Metal example in github.com/glfw/glfw2d
The default value here is `NO` so setting it to `YES` has an effect. However, I haven't been able to spot any differences in behavior regardless if `wantsLayer` is set to `YES` or left at `NO`. Ac…
dmitshur commented on 97b652c58466a1dd57beeb94ce8410b0ed39b79aInitial Metal example in github.com/glfw/glfw2d
FWIW, according to https://developer.apple.com/documentation/quartzcore/cametallayer/1478155-pixelformat: > The default value is `MTLPixelFormatBGRA8Unorm`. So this line is a no-op.
dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl2d
> my understanding is that `unsafe.Pointer` forces to import `unsafe` package to the package users I'm not sure if that's quite right. My understanding is that if a package returns `unsafe.Pointer…
dmitshur commented on githubapi: Possible nil pointer der… in github.com/shurcooL/events2d
I have never seen this occur again. My guess is that this happened because of some temporary problems on GitHub side that shouldn't happen again. Closing, but can be re-opened and re-considered…
dmitshur pushed to master in github.com/shurcooL/events2d
410e4ca65f48ffdd749002a20a0b182c174e7020fs: Create eventsDir if it doesn't exist.
dmitshur commented on proposal: Remove 'C' types from the… in github.com/go-gl/gl2d
In general, removing C types from the `gl` public API SGTM. I suspect it was an oversight rather than intentional decision that they ended up there (please correct me if wrong). > replace such C t…
dmitshur commented on gl.FenceSync returns invalid unsafe… in github.com/go-gl/gl2d
Friendly ping @dominikh. You said [on February 15](https://github.com/go-gl/gl/issues/71#issuecomment-366133553): > I've finally gotten around to testing the change. It compiles, doesn't cause run…
dmitshur commented on remove dependency on cgo in github.com/go-gl/gl2d
Indeed. However, there's only 8 of them (compared to hundreds or thousands of Go types), and I don't think they should've been exposed in the first place. I don't know whether they're functional eith…
Last Week
dmitshur deleted branch in github.com/shurcooL/trayhost3d
use-image-template
dmitshur pushed to master in github.com/shurcooL/trayhost3d
114974ef9e1627fd6c8fc39b5c9d68b0e785948cplatform/darwin: Make NSStatusItem image a template.
dmitshur commented on platform/darwin: Make NSStatusItem … in github.com/shurcooL/trayhost3d
@pavben said over chat: > if it works with dark mode now and you don’t have any strong reservations about the method used, I’m happy with it
dmitshur deleted branch in github.com/go-gl/gl3d
regen-after-DNE-comment
dmitshur pushed to master in github.com/go-gl/gl3d
629e6eb0370bc1987d806c0786368395657324a0all: Regenerate after DO NOT EDIT comment change.
dmitshur commented on all: Regenerate after DO NOT EDIT c… in github.com/go-gl/gl3d
Nope, this PR already included https://github.com/go-gl/glow/pull/99 in it.
dmitshur deleted branch in github.com/go-gl/glow3d
DNE-whitespace-fixup
dmitshur pushed to master in github.com/go-gl/glow3d
37a41ef3b08a43ee077b9f0e724238830eae7d80Keep space in procaddr.tmpl comments.
dmitshur created branch in github.com/shurcooL/trayhost3d
use-image-template
dmitshur pushed to master in github.com/shurcooL/trayhost3d
4e3d7a996fa62f6556793a66e09d0fbde6290f49Update shurcooL username to dmitshur.
dmitshur commented on client: Icon renders poorly in Dark… in github.com/pavben/InstantShare3d
I've found good information on how to support dark mode in this Stack Overflow answer: https://stackoverflow.com/questions/24623559/nsstatusitem-change-image-for-dark-tint/24644754#24644754 Luc…
dmitshur pushed to regen-after-DNE-comment in github.com/go-gl/gl3d
629e6eb0370bc1987d806c0786368395657324a0all: Regenerate after DO NOT EDIT comment change.
dmitshur created branch in github.com/go-gl/gl3d
regen-after-DNE-comment
dmitshur created branch in github.com/go-gl/glow3d
DNE-whitespace-fixup
dmitshur commented on Remove importing C from conversions… in github.com/go-gl/glow3d
Also, any non-trivial changes to glow make sense to land after we've gained confidence in the generated code works well and we want to keep it.
dmitshur commented on Remove importing C from conversions… in github.com/go-gl/glow3d
It's hard for me to know what effect making this change would have, and I'm hesitant to make a change here before knowing the full picture. Have you already prototyped the entire "drop Cgo" change…
dmitshur pushed to master in github.com/go-gl/glow3d
e361f3a9a993a4b104349aa52e4d467d34c98c35Use standard code generated comment format. (#98)
dmitshur pushed to donotedit in github.com/hajimehoshi/glow3d
c43a772ac3957494678f776542aad4cadf598a17Use https in glow URL in package comment.
dmitshur starred github.com/dave/dst3d
dmitshur commented on Use the standard do-not-edit commen… in github.com/go-gl/glow3d
```suggestion // Code generated by glow (https://github.com/go-gl/glow). DO NOT EDIT. ```
dmitshur commented on Use the standard do-not-edit commen… in github.com/go-gl/glow3d
Please update the URL scheme to https. Here, and below. ```suggestion // Code generated by glow (https://github.com/go-gl/glow). DO NOT EDIT. ```
dmitshur pushed to master in github.com/shurcooL/home3d
dmitshur commented on x/tools/present: Docs say 'h' key i… in github.com/golang/go3d
> So something doesn't look right here. I don't know if the documentation is wrong, or if the implementation has a bug. I did some code archeology to find out. The earlier commit I found where the…
dmitshur pushed to master in github.com/shurcooL/vfsgen3d
a97a25d856cadfe6481325baeb35a70d6723ca0ccmd/vfsgendev: Find packages in the current Go module. (#50)
dmitshur closed an issue in github.com/shurcooL/vfsgen3d
dmitshur commented on Support Go modules. in github.com/shurcooL/vfsgen3d
`vfsgen` itself supports modules. `./cmd/vfsgendev`, a convenience tool for using `vfsgen` in a specific way, currently doesn't support modules because it looks for import paths only within GOPATH…
dmitshur pushed to modules in github.com/antong/vfsgen3d
f70f7b99817abba9c1503688ed139dcf92a51114cmd/vfsgendev: Document new parseSourceFlag behavior.
dmitshur pushed to modules in github.com/antong/vfsgen3d
5971689f9e17d66dc735d0ce4adcc56e7cf3328ecmd/vfsgendev: Simplify code to get current working directory.
a0177350122c8c4c7f230f2eb011e4132200a580cmd/vfsgendev: Factor out relative import path check.
dmitshur commented on cmd/gopherbot: race condition in au… in github.com/golang/go3d
I think I've already seen code somewhere that uses Gerrit API in addition to `maintner` to confirm the "latest" state before taking some action. @bradfitz will probably remember where that was. I …
dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go3d
> Will redeploy `cmd/coordinator` later tonight (when it's quieter). Version golang/build@24469dd429f05bdb34b644430843761abf7e1367 of `cmd/coordinator` is deployed now.
dmitshur commented on set exit code according to found wa… in github.com/mvdan/unparam3d
I'm a little surprised this PR was merged to `master` as 3 individual commits rather than squashing into one. Was that intentional?
dmitshur commented on basic changes for vgo support in github.com/go-audio/wav3d
> I had to put all tests into the wav package to make vgo happy. What was the error you're getting? Which version of Go were you using? I don't think that should be the case.
dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go4d
I've updated the images and sent [CL 143458](https://golang.org/cl/143458). Will redeploy `cmd/coordinator` later tonight (when it's quieter). After a few days of no issues, the next step will …
dmitshur created branch in github.com/shurcooL/talks4d
add-go1.11-talk
dmitshur commented on Remove the "always receives X" chec… in github.com/mvdan/unparam4d
> Does anyone find it useful? I don't remember the last time I've seen it. I might've fixed all instances and not introduced new ones. As a result, it's hard for me to say, but it sounds useful…
dmitshur commented on Vsync doesn't work on macOS 10.14 (… in github.com/glfw/glfw4d
I can also confirm this, it's a regression in macOS 10.14 and wasn't a problem in 10.13. This issue may be related to #1334 in some way. What I'm observing is that vsync works until you move or re…
dmitshur commented on OSX 10.14 (Mojave) Window does not … in github.com/glfw/glfw4d
Thanks for the report. This is a duplicate of #1334.
dmitshur commented on proposal: x/tools/go/generated: par… in github.com/golang/go5d
I agree with your comment @rsc that this would be a small package, and it's better to avoid that in x/tools. I've been thinking about where this functionality could fit into existing packages, and…
dmitshur commented on x/build: add OpenBSD 6.4 builder in github.com/golang/go5d
I'll work on updating the images to 6.4 final. The current 6.4 snapshots have been quite stable on https://build.golang.org/: <img width=101 src="https://user-images.githubusercontent.com/19241…
dmitshur created branch in github.com/shurcooL/home5d
optimize-Rediscover
dmitshur pushed to master in dmitri.shuralyov.com/service/change5d
dmitshur pushed to master in github.com/shurcooL/home6d
e90afb26fdf9d49c711e70ac9773f62498e886b4internal/code: Rediscover packages on git pushes.
1771d6e32fa43c7c723a46284046fa3d95283ec9internal/code: Extend test to cover pushing new commit.
fecc632705f4c41dfbaa7775cacb466403dcc729Move gitHandler into internal/code package.
f8f95065d74350fa2d8c0908ccda77b050fd96cbFactor out authentication from gitHandler.
dmitshur created branch in dmitri.shuralyov.com/gpu/mtl6d
window-60fps
dmitshur pushed to master in dmitri.shuralyov.com/service/change6d
f0c4aee46f480a95d2b38fca1cde98f16466e592fs: Add an open change for mtl package.
dmitshur commented on x/build: create mips32 soft-float b… in github.com/golang/go1w
@bradfitz From [`x/build/dashboard/builders.go`](https://github.com/golang/build/blob/c27f283fefcd9cd436e591d4b932a1d94d469a27/dashboard/builders.go#L425-L474), it looks like all our current `mips` b…
dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go1w
Starting to have second thoughts about the proposed workaround. In the [CL 142362](https://golang.org/cl/142362) commit message, I wrote: > The goal of this change is to reduce occurrences of goph…
dmitshur commented on x/build/cmd/gopherbot: don't fight … in github.com/golang/go1w
I tested the approach (locally) and it worked in solving the problem. Going to send a CL.
dmitshur commented on x/build/cmd/gopherbot: testing figh… in github.com/golang/go1w
Testing successful (done locally, so not visible here). Closing.