Dmitri Shuralyov

Thanks for sending this fix, however this command has been deprecated (see CL 349051), so I don't think we should try to continue to maintain it, other than to fix the deprecation notice (it has …

dmitshur commented on runtime: support preemption on windows/arm and windows/arm642d

@zx2c4 We've discussed this on the release team, and in general we are okay with this happening for Go 1.18, especially if it can help fix other bugs. It seems the CLs are reviewed and ready to go, s…

dmitshur reviewed +1 on .github: use multiple issue templates2d

Thanks for addressing the review comments this has received so far Sean. With Thanksgiving Day in the US coming up tomorrow and many people being away, I think we should avoid submitting this for now…

dmitshur reviewed +2 on golang.org/x/build/env/corellium: bump minimum ios version2d

It should be okay, you can submit this independently since it uses cherry-pick strategy and there aren't conflicts between the two CLs.

dmitshur reviewed +2 on golang.org/x/build/env/corellium: bump minimum ios version2d

(1 comment) Add 'golang/go' before #, since this is an x/ repo.

dmitshur merged a change doc/go1.18: add Clone doc2d

dmitshur merged a change doc/go1.18: document that iOS 12 or newer is required2d

dmitshur closed an issue github: Go Organization website points to golang.org2d

dmitshur commented on github: Go Organization website points to golang.org2d

Thanks for reporting. Updated. Unfortunately that means no more "Verified" badge for now, but we'll get that back after some time. Though go.dev is the new shorter URL where the Go websites have bee…

dmitshur commented on crypto/x509/internal/macos: link errors on ios/arm64 due to missing symbols _SecItemExport and _SecTrustEvaluateWithError2d

@changkun Yes, I think we'll go with iOS 12 for Go 1.18. I've mailed [CL 366914](https://golang.org/cl/366914) to document it in the release notes. Thank you for your help with with updating the buil…

dmitshur opened a change doc/go1.18: document that iOS 12 or newer is required2d

For #47694. Updates #49616. Updates #48076.

dmitshur commented on golang.org/x/build/cmd/release: update the releaselets for go1.183d

FreeBSD and macOS updates look good. Based on today's discussion, I expect Windows builder for 1.18 may be changing, is that right? (I'm not working on the implementation beyond what's a…

dmitshur reviewed +1 on .github: use multiple issue templates3d

Thanks. I primarily reviewed the 00-bug.md template, other than a few minor comments, it looks good. I looked over the rest, and didn't spot problems. Adding a few more people to give them a cha…

dmitshur reviewed +2 on vendor: update golang.org/x/net to tip3d

Thanks. Yes, we ended up with the go.mod files controlling both vendor and bundle versions, rather than managing them separately (issues #41375 and #41409 have more context).

dmitshur reviewed -2 on vendor: update golang.org/x/net to tip3d

When modifying versions selected in go.mod files, it is useful to run tests in the cmd/internal/moddeps package (or request a longtest builder that will also do that), as they help accidental version…

dmitshur merged a change golang.org/x/website/_content/blog: restore previous talks URL in tidy web post3d

dmitshur commented on .github: use multiple issue templates3d

Thanks for sending this CL. I left some initial comments/questions. I've also asked pkgsite and gopls owners to take a look at those sections. These 2 blank lines were intentional: they allow …

dmitshur merged a change golang.org/x/build/repos: don't test x/talks on build dashboard3d

dmitshur commented on golang.org/x/build: frequent "communication error to buildlet" failures on all plan9 builders3d

This looks relevant to: ```Go // If a build fails multiple times due to communication // problems with the buildlet, assume something's wrong with // the buildlet or machine and fail the build,…

dmitshur commented on golang.org/x/website: anchor links don't seem to work properly anymore3d

Thanks for the report. I can reproduce this too. CC @jamalc, @rsc.

dmitshur commented on golang.org/x/tools/playground: improve error message on playground UI when server returns 413 while sharing snippet3d

Thanks, but to fix this issue, the playground.js file in x/website will need to be modified, not this old copy in x/tools. Please see my comment at https://go.dev/issue/49527#issuecomment-976799250.

dmitshur commented on golang.org/x/website: on go.dev/play, "server error, try again" displayed when server responds with 413 Payload Too Large3d

The playground has recently moved to go.dev/play, and so the fix needs to happen in x/website. > it seems like the same fix is needed in `playground.js` in `tools/godoc/static` Oh, that was actuall…

dmitshur commented on golang.org/x/talks/...: remove content and app.yaml3d

(1 comment) That should've been: ``` ... to [golang.org/x/website/_content/talks/](https://golang.org/x/website/_content/talks). ``` (It seems there's a bug in Gerrit comment rendering, wh…

dmitshur reviewed +2 on golang.org/x/talks/...: remove content and app.yaml3d

See inline comments. I suggest leaving only README.md file as we've done in x/blog. Otherwise LGTM. Please also include the information that it was CL 365135 and commit e219555f where it was add…

dmitshur opened a change golang.org/x/build/repos: don't test x/talks on build dashboard3d

The x/talks repository followed suit after x/blog and x/tour and has been merged into x/website. CL 366177 removes all of its moved content, leaving just a README. Stop displaying it on the build da…

dmitshur commented on golang.org/x/website/_content/blog: restore previous talks URL in tidy web post3d

This change is ready for review.

dmitshur commented on golang.org/x/website/_content: replace talks.golang.org links with go.dev/talks3d

(1 comment) This doesn't appear to be an intentional change. Sent CL 366554 to revert it.

dmitshur opened a change golang.org/x/website/_content/blog: restore previous talks URL in tidy web post3d

This change was made inadvertently as part of CL 365495.

dmitshur reviewed +2 on golang.org/x/net/ipv6: OpenBSD does not appear to support multicast loopback4d

dmitshur reviewed +2 on golang.org/x/website/_content/doc: fix download buttons for go.dev/dl/4d

dmitshur commented on golang.org/x/net/ipv6: OpenBSD does not appear to support multicast loopback4d

(1 comment) Shall this switch be removed?

dmitshur reviewed +1 on golang.org/x/website/_content: link to atom feed4d

Thanks, leaving to Russ or Jamal to review and submit.

dmitshur reviewed +2 on golang.org/x/build/deploy: add GRPC servers to build.golang.org4d

Changes in PS 3 also look reasonable to me. Thanks for answering!

dmitshur edited the wiki4d

bc19cd79032a8e033ebc2fe1069ffb5596891b39Edit page Gardening.

dmitshur commented on golang.org/x/playground: "server error, try again" displayed when server responds with 413 Payload Too Large4d

@uppalabharath Thanks for offering to help (be sure to look over https://go.dev/doc/contribute if you haven't already)! I think the message just needs to communicate the reason for the problem. Perh…

dmitshur commented on golang.org/x/website: install windows broken4d

Also, the link is to "golang.org/dl/" but should likely be updated to "go.dev/dl/". CC @rsc.

dmitshur reviewed +1 on golang.org/x/build/dashboard: set MallocNanoZone on ARM64 too4d

dmitshur merged a change golang.org/x/build/internal/sourcecache: increase x/website size limit to 200 MB4d

dmitshur commented on golang.org/x/build/internal/sourcecache: increase x/website size limit to 200 MB4d

(2 comments) Me too. In situations where fields from the error type are used, I typically use: if e := (sourcecache.TooBigError{}); errors.As(err, &e) { // use e.Foo } But I o…

dmitshur merged a change golang.org/x/build/cmd/coordinator: don't retry when tree too big4d

dmitshur commented on golang.org/x/build/cmd/coordinator: don't retry when tree too big4d

(1 comment) I tried making it an unexported method on buildStatus. It was much better than inside a distant buildgo package, but it still felt worse than just inlining the 2 calls directly into runS…

dmitshur commented on golang.org/x/website/go.dev: link to atom and json feeds4d

Oh, I missed that it wasn't https://www.jsonfeed.org/, thanks for catching. Nit: no longer 'json'.

dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: fix testdata/live.txt for golang.org → go.dev redirect4d

dmitshur commented on golang.org/x/website/_content/talks: add talks.golang.org content4d

(1 comment) CL 366135 increases the x/website limit too 200 MB, and will resolve this.

dmitshur commented on golang.org/x/build/internal/sourcecache: increase download size limit to accommodate larger repositories in 20214d

Update on 2021-11-22: x/talks content (74 MB compressed) is being moved into x/website in CL 365135, pushing it over 100 MB. [CL 366135](https://golang.org/cl/366135) updates the limit for x/websi…

dmitshur opened a change golang.org/x/build/internal/sourcecache: increase x/website size limit to 200 MB4d

The x/website repository is unusually large due to having content from x/blog, and as of CL 365135 also from x/talks. Increase its limit to 200 MB, but leave other repositories as they were. Updates…

dmitshur reviewed +2 on golang.org/x/build/dashboard: remove macOS 12.0 KI4d

dmitshur commented on golang.org/x/build/cmd/coordinator: limit number of TryBot reattempts5d

Fixing this involves starting to track the number of retries (for a high-level trybot request on a given repo/commit) due to communication errors, and modifying [`repeatedCommunicationError`](https:/…

dmitshur opened a change golang.org/x/build/cmd/coordinator: don't retry when tree too big5d

The build system enforces a limit on the compressed tree tarball size that it's willing to fetch and propagate throughout the rest of the system. If that limit is exceeded, consider it a terminal…

dmitshur commented on golang.org/x/website/_content/talks: add talks.golang.org content5d

(Also filed golang.org/issue/49707 to make coordinator stop after one such failure rather.)

dmitshur opened an issue golang.org/x/build/cmd/coordinator: exceeding Gerrit tree fetch limit should be a fatal error5d

If a CL pushes the (compressed) size of the tree over a limit, trybots fail with something like: ``` Error: runTests: reading website/b4aa6ae539a1f644d48c473ca6e0e31a95ab4b26 from gerrit: rejecte…

dmitshur commented on golang.org/x/website/_content/talks: add talks.golang.org content5d

Removing trybot vote for now since they can't complete without some change; see inline comment. TryBots are currently unable to run because this CL pushes the size of a compressed tarball of the…

dmitshur reviewed +2 on golang.org/x/website/internal/blog: fix atom feed self link5d

dmitshur reviewed +2 on golang.org/x/website/go.dev: link to atom and json feeds5d

(1 comment) Ah. Thanks!

Last Week

dmitshur reviewed +2 on golang.org/x/website/internal/blog: fix atom feed self link6d

(1 comment) Yep, it's right. The parent commit in this CL is 7c9fc1ca, which is a commit from CL 364276. 👍

dmitshur reviewed +2 on golang.org/x/website/go.dev: link to atom and json feeds6d

(1 comment) Any reason not to include the Content-Type header check?

dmitshur commented on golang.org/x/website/...: merge golang.org → go.dev6d

(1 comment) CL 364276 fixes this parameter to have the correct value, "go.dev". It'll require the merge conflict to be resolved here, since this RegisterFeeds call is moved (and its firs…

dmitshur reviewed +2 on golang.org/x/website/internal/blog: fix atom feed self link6d

Thanks. If you wanted and if this is rebased on top of CL 364276, you can add something like this under the 'GET https://go.dev/blog/feed.atom' block: body contains <link rel="se…

dmitshur reviewed +2 on golang.org/x/website/go.dev: link to atom and json feeds6d

Thanks for the fix, it looks right to me. Let's be sure to add a test case so we can be confident the feed(s) won't break in the future, see inline comment. Russ, please let us know if you h…

dmitshur commented on golang.org/x/website: feed.atom self link is incorrect6d

Thanks everyone for reporting this, it is indeed a new problem. It should be fixed within a couple of days, along with a test to avoid future regressions. Thanks for your patience.

dmitshur closed an issue github.com/go-gl/glfw/v3.3/glfw: 'Carbon/Carbon.h' file not found6d

dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: 'Carbon/Carbon.h' file not found6d

@runeimp Thanks for context. It the header was indeed removed in some versions of Xcode and then brought back, that could explain how some people (and not everyone) ran into this. I'll close this …

dmitshur merged a change golang.org/x/website/go.dev/_content/blog: fix links6d

dmitshur reviewed +1 on golang.org/x/website/go.dev/_content/blog: fix links6d

(1 comment) CL 365095 modifies this adjacent line, so this may unfortunately generate a trivial merge conflict.

dmitshur commented on lib/time: update tzdata before release1w

@tklauser Do you think it's safe to expect that 2021e will still be latest by the time 1.18 final is released (est. Feb 2022)? If there's a chance of a newer timezone release before then, we should m…

dmitshur commented on github.com/go-gl/glfw: 'Carbon/Carbon.h' file not found1w

That's odd. The aforementioned program builds successfully (and prints "Hello Carbon." if executed) for me both on: - macOS Monterey (12.0.1), M1 CPU - macOS Big Sur (11.6.1), Intel CPU I expect th…

dmitshur reviewed +2 on golang.org/x/build/deploy: add GRPC servers to build.golang.org1w

(1 comment) A question about this change. There's already a '/*' path that also maps to coordinator-internal backend on port 444. Are the new rules being added in this CL because that ru…

dmitshur commented on golang.org/x/website/go.dev/_content: link to atom and json feeds1w

(1 comment) Both https://go.dev/blog/feed.atom and https://go.dev/blog/.json serve 404 right now. Sean, maybe there's been a change or regression since this CL was sent, perhaps in CL 362955?

dmitshur commented on doc: go1.18 release notes for CLs 323318/3327711w

If you'd like to proceed with this CL, it'll need to be rebased to resolve a conflict with CL 365318.

dmitshur commented on doc: [go] document speedups to Trim[|Left|Right]1w

(1 comment) This should be /pkg/strings/#Trim since this entry is about the strings package. There is also an existing open CL 363840 that set out to document these changes, so if that CL is rebase…

dmitshur reviewed +1 on doc: [go] add short-circuit evaluation for text/template1w

A few minor comments on the commit message style, since you may be sending more CLs here, I hope they'll be helpful (new contributors often look only at the most recent CL and repeat its style). …

dmitshur reviewed +2 on doc/go1.18: add Clone doc1w

Thanks. Adding Jeremy who can review for trust and submit. This is resolved. Resolved. Resolved.

dmitshur opened an issue golang.org/x/build/cmd/gerritbot: update CLA check mechanism1w

`gerritbot` currently checks whether each PR has a "cla: yes" label (using the maintner corpus, so it doesn't contribute to GitHub API rate limit use) to determine that CLA checks have passed before …

dmitshur commented on golang.org/x/build/buildlet: tweaks to Darwin, OpenBSD, and Linux builders1w

(1 comment) I agree.

dmitshur reviewed +1 on golang.org/x/build/buildlet: tweaks to Darwin, OpenBSD, and Linux builders1w

Minor comments, otherwise leaving to Alex to review. Maybe a good opportunity to update the slowbot aliases too. In this package, it's common to use the atLeastGo1(goBranch, 16) helper for perf…

dmitshur reviewed +2 on golang.org/x/build/dashboard: add n1 hosts for OpenBSD and NetBSD1w

(4 comments) Can include CL number to make it easier to navigate to it: ... in CL 354757 ... If I understand correctly, the issue happens much more often on GOARCH=386 than GOARCH=amd64 for Ope…

dmitshur merged a change golang.org/x/build/dashboard: update ExpectNum for host-linux-riscv64-unleashed to 01w

dmitshur opened a change golang.org/x/build/dashboard: update ExpectNum for host-linux-riscv64-unleashed to 01w

Take a small step to bring the dashboard towards the current state of the builder. For golang/go#49325.

dmitshur reviewed +2 on golang.org/x/build/dashboard: add darwin-arm64-12_0 builder1w

(1 comment) This can be simplified to: buildsRepo: defaultPlusExpBuild, Without changing behavior, since by now 1.16+ are the only supported/tested branches, 1.15 and older are not.

dmitshur commented on golang.org/x/build/cmd/release: update the releaselets for go1.181w

Just leaving a minor first pass comment for now; I plan to read the rest of the change carefully in a second pass. This is the first time we're adding a "==" query and I'm not sure w…

dmitshur reviewed +2 on golang.org/x/build/dashboard: update freebsd-amd64-race builder host1w

Changes look good. +2 is for after inline comments are resolved. Is the new 13.0 image known to work as expected via some form of testing, or is the plan to deploy coordinator with CL 365314 to lear…

dmitshur reviewed +2 on doc: go1.18 release notes for CLs 323318/3327711w

Thanks. Please use the existing format to mention a second CL here:  This is so that existing tooling recognizes that these CLs have already been mention…

dmitshur commented on doc/go1.18: add Clone doc1w

(1 comment) Also, the link should be "/pkg/strings/#Clone" (it's currently missing an 's').

dmitshur reviewed +2 on doc/go1.18: add Clone doc1w

Thank you for sending this change. It's possible we can find ways to make the description easier for readers to understand in future editing passes (or maybe another reviewer will suggest so), b…

dmitshur reviewed +2 on golang.org/x/build/dashboard: add freebsd-[amd64|386]-13_0 builders1w

I think this is a good idea, though it might be preferable to do in a follow up change rather than all at once. However, it's also fine to just do it here. Leaving to Carlos to decide.

dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: increase the disk size for image1w

dmitshur reviewed +1 on golang.org/x/debug/dwtest: add new pseudo-package with DWARF location tests1w

Leaving this to other reviewers more familiar with the context, but I'm not spotting any issues. It passes with today's gotip on darwin/amd64 for me (it didn't pass with a gotip from a we…

dmitshur commented on golang.org/x/build/cmd/gopherbot: add auto-submit functionality1w

(CCing Michael just as FYI.)