Activity

Yesterday
dmitshur starred github.com/gowebapi/webapi19h
Last Week
Thanks. Should be v0.22.0 to keep both modules in sync. Edit: Done in PS 2.
> And there does not appear to be anything for `openbsd-arm` (or possibly `openbsd-armv7`) here: Yeah, the *bsd-armv7l CIPD binaries haven't been added yet. @bsiegert Do you have plans to work on …
Thanks. The general approach here looks good, and we discussed some of the remaining open questions recently, so moving this CL to your attention set. Yep. Certainly seems fine to leave to a separat…
Filed #68402 to track the current problem with the builder.
https://ci.chromium.org/ui/p/golang/builders/ci/gotip-freebsd-riscv64 In the Machine Pool section, it's visible that the [freebsd-riscv64-mengzhuo](https://chromium-swarm.appspot.com/bot?id=freebs…
Thanks. Returning no error is equivalent to the previous behavior, but it's probably a slight improvement to make this task fail visibly rather than become a quiet no-op in the unlikely case the scr…
Discussed this with Ian. We concluded this machinery is indeed fine to remove, and then archive the golang-wikichanges mailing list. Moving to NeedsFix.
dmitshur reviewed +2 on make.bash: drop GNU/kFreeBSD handling2d
Thanks.
Thanks.
Yes, LUCI builders with a known issue aren’t shown on the build.golang.org dashboard, so removing its known issue will make it visible. Thanks. You can also add an entry to a [BuildersPortedToLUCI]…
I suspect the adverse effect is either negligible or non-existent, but I haven’t tried to confirm. I happened to spot it while reading over the code on my own accord, and sent this change to make i…
The "close luci-config issues" task is based on the "close cherry pick issues" task and exists for the same reason. For example, the Go issue go.dev/issue/63482 should've been closed when https://go.…
Congrats on reaching this point! > Do we want to cut over the build dashboard? Are you referring to removing the known issue for the builder at https://cs.opensource.google/go/x/build/+/luci-config…
@gopherbot Please backport to Go 1.22. Only Go 1.22 needs the fix, as this isn't an issue in Go 1.2​1. This is a regression that can cause wrong binaries to be executed on Windows, with no worka…
Earlier
@zigo101 When fixes are made, they're included in the next major release. That is the default. Only in rare cases when it is deemed necessary they are also backported to currently supported major rel…
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)
Reported #68314 for the root cause. I'll wait a bit to see how it goes there before coming back to this.
I sent [CL 596875](https://go.dev/cl/596875) with a proposed fix. Its approach is based on an earlier prototype ([CL 575275](https://go.dev/cl/575275)).
That CL pulled in 7 changes from x/telemetry: https://go.googlesource.com/telemetry/+log/51e8b5d718eb..7d78a974cc44. Skipping ones that were test-only or modifying services (and not vendored to the m…
As a mitigation to unbreak Windows builders, [CL 596815](https://go.dev/cl/596815) pins the previous golangbuild version.
dmitshur created repository in golang.org/x/oscar1w
[mirror] Open source contributor agent architecture repo.
Right now the `CreateAutoSubmitChange` method is willing to create a CL, fail to add a reviewer, and report the failure to the caller. This leaves CLs behind and is generally not the optimal behavior…
What was the exact command you ran, and what was its output?
This is a duplicate of #32897 and more (see related issues above). To get the behavior you'd like, it requires changing the helper defined in your code: ```diff -func performHttpRequest(method…
It's unexpected that the error includes a different email than your primary Gerrit email, the one visible at https://go-review.googlesource.com/dashboard/54019. I'll look into why this might be happe…
dmitshur starred github.com/mjl-/mox2w
dmitshur starred github.com/mjl-/gopherwatch2w
> Sure, but deadline exceeded to download what? If I knew what the URL was or a command to reproduce the download, it would have been much easier to troubleshoot further. Note that the exact "cas …
Our default policy decision is to support all supported versions of Go equally. See [proposal 34536](https://github.com/golang/go/issues/34536#issuecomment-572188389). Since this problem affects both…
In case you haven't already seen it, there is open source documentation for the Swarming Bot at https://chromium.googlesource.com/infra/luci/luci-py.git/+/main/appengine/swarming/doc/Bot.md. The "…
This is a consequence of the simplification of the build policy during the migration to LUCI. With coordinator, there were many custom policies applied to builders individually, including what you me…
Closed by merging [CL 593876](https://go.dev/cl/593876) (commit ceaf26ecce663e75c4f4b476dc3c64fa58a2f0dd) to `release-branch.go1.22`.
@ncruces See https://go.dev/wiki/SlowBots. In particular, you should be able to include a footer like this: ``` Cq-Include-Trybots: luci.golang.try:x_sys-gotip-netbsd-arm64 ``` That'll cause …
This functionality and test was recently added in [CL 592415](https://go.dev/cl/592415). It fails on GOOS=openbsd specifically: ``` === RUN TestMmapPtr mmap_unix_test.go:72: Munmap: invali…
This functionality and test was recently added in [CL 592415](https://go.dev/cl/592415). It fails on GOOS=netbsd specifically: ``` === RUN TestMremapPtr mremap_test.go:67: MremapPtr: canno…
These tests probably shouldn't run on GOARCH=wasm. They fail due to "not implemented" errors, e.g.: ``` === RUN TestFreeRefs/file2.go freesymbols_test.go:107: file2.go:1:19: could not impo…
The legacy builders freebsd-amd64-13_0 and freebsd-amd64-12_3 are frequently failing with "connection reset by peer": ``` --- FAIL: TestTLS13OnlyClientHelloCipherSuite (0.00s) --- FAIL: Test…
> Questions for @golang/release: is there a policy on how to bump go.mod versions of x/ repos? There isn't something written down beyond the [Go release policy](https://go.dev/doc/devel/release#po…
Thanks, please feel free to work on it and send a CL. See https://go.dev/doc/contribute.
The Google Docker build task is currently made of two tasks: one to start a Cloud Build invocation, and another to await its result. This has a flaw in that if the Cloud Build invocation happens to f…
> `GOFLAGS='-ldflags=-linkmode=internal'` That looks relevant! Please without forcing internal link mode (which isn't supported with cgo, see golang/go#38918).
That's quite odd. I'm finding similar errors in issues like https://github.com/mattn/go-sqlite3/issues/112, https://github.com/mattn/go-sqlite3/issues/404. They suggest this might be caused by someth…
Thanks for trying. That's unexpected. I have a similar setup but I can't reproduce the problem so far. A few more ideas to try: 1. What's your Xcode version (`xcodebuild -version`)? 2. To confirm, s…
v0.0.0-20210410170116-ea3d685f79fb is a pretty old version of glfw/v3.3. Can you try the latest and see if that fixes it? ``` go get github.com/go-gl/glfw/v3.3/glfw@latest go run . ``` If so, we sh…
@0intro Sorry it took a while before I had a chance to get back to this, but I'm glad you were able to make progress. There is open source documentation for the Swarming Bot at https://chromium.googl…
Duplicate of #54279
Duplicate of #54279
At least partially a duplicate of #54279. I'll let watchflakes file a new issue when it's a different problem.
The likely explanation here is that the k8s cluster was undergoing an upgrade, resulting in brief windows of service unavailability. Let's reuse this issue to catch future instances, so that watch…
This issue from 2019 was resolved and frozen due to age. For new work, maybe it'd be better to file a new issue and refer to this one.
dmitshur commented on doc: write release notes for Go 1.233w
The Go 1.23 Release Notes draft is complete, and all known TODOs have been resolved. Running `relnote todo` right now doesn't find anything remaining beyond proposal #61940, which doesn't need to be …
This backport is approved and it's waiting on a cherry-pick CL to be created. See https://go.dev/wiki/MinorReleases#making-cherry-pick-cls. Once that's created and all of its submit requirements are …
dmitshur edited the wiki3w
It looks like an intentional decision in [CL 470676](https://go.dev/cl/470676) that the module toolchain isn't complete to run all tests. The module toolchain distribution doesn't keep the "test" dir…
dmitshur closed an issue github.com/go-gl/gl: Not able to import4w
There's no package with the import path `github.com/go-gl/gl/v3.3/gl`, so an error is expected. There are packages with the following import paths: - `github.com/go-gl/gl/v3.3-core/gl` - `gith…
The macOS race builder is reporting data races in found by briefly running benchmarks. For example: ``` ================== WARNING: DATA RACE Write at 0x00c000152a49 by goroutine 40: tes…
dmitshur commented on doc: write release notes for Go 1.231mo
Rerunning `relnote todo` today doesn't find more TODOs beyond the 4 already added to the source (view-source:https\://tip.golang.org/doc/go1.23). <details><summary><code>relnote todo</code> output…
> Or are there cases where one module's tests will be run against another module's `go.mod`? To answer this question specifically: yes, it is possible to test packages contained in modules other t…
dmitshur commented on api: audit for Go 1.231mo
I also looked a bit at the proposed and implemented APIs. Everything seems to align. The `WSAENOPROTOOPT` constant wasn't mentioned in proposal #62254, but it seems fine.
This issue is about the "dl" repo that holds commands like [golang.org/dl/go1.22.4](https://cs.opensource.google/go/dl/+/master:go1.22.4/main.go;drc=9bf7d9b5654bbbf3a03546ecf70a20c5488663ec), not the…
Congrats on the progress! On the corresponding build page (https://ci.chromium.org/b/8745946740583765537), oddly, there are 31 failing test result entries (and 2901 passing) despite the overall buil…
We reviewed this in a meeting, and agreed to approve its "freeze exception" bit. Thanks for letting us know.
We reviewed this in a meeting, and agreed to approve its "freeze exception" bit. Thanks for letting us know.
We reviewed this in a meeting, and agreed to approve its "freeze exception" bit. Thanks for letting us know.
Note that if the linker in older Xcode 14 doesn't support the same flag to disable the warning, such that passing it causes an error (as mentioned in [2]), then that needs to be taken into account. …
The pattern in #49338 required the builder name to be exactly "plan9-arm", which was true in coordinator, but LUCI builder names include more context (repo, release branch). Updated its pattern s/==/…
FYI [CL 589935](https://go.dev/cl/589935) updated x/telemetry to v0.0.0-20240603224550-f2b69109f79b. Feel free to close this if that's enough for the needs of RC 1, or keep it open if you'd like to c…
### Go version go version go1.22.3 darwin/arm64 ### Output of `go env` in your module/workspace: ```shell GO111MODULE='' GOARCH='arm64' GOBIN='' GOCACHE='/Users/gopher/Library/Caches/go-build' …
> Also, how can we make sure that test failures in x/ repos triggered by the go.mod version are caught in CI? Filed #67791 for that.
Issue #67783 is an example of a test failure that happened only at tip (future Go 1.23 to be) and when the go directive in x/net is increased to Go language version 1.23. Bumping x/net go directive …
It’s true that GOROOT_FINAL is removed in Go 1.23, so it’s no longer relevant. As https://github.com/golang/go/issues/39819#issuecomment-648880776 points out, there are more env vars that might n…
dmitshur starred github.com/praydog/REFramework1mo
The bootstrap failure is now resolved via [CL 586835](https://go.dev/cl/586835), which is what the original issue was about. Perhaps it would work well to close this issue and open a separate one to …
This is a tracking issue to trim down coordinator, stopping more of the builders that have been ported to LUCI. This builds on top of the previous dashboard work in #65913. CC @golang/release.
The timing of api files being merged isn't exactly the same as in past releases because they're also involved in the test for improved release notes (#64169). The task that updates x/tools/interna…
That mechanism isn't currently available for LUCI builders. Without snapshots, and with make.bash taking 45 minutes, it makes testing golang.org/x repos slower and use more resources, but I understa…
Thanks. I'm convinced you should be able try this, given you're already taking the support needs into account to a great degree. This is something we can choose to undo if you learn it's not working …
> Given that the gopls build must already download external dependencies, I don't see why GOTOOLCHAIN=local is necessary. The [Go release policy](https://go.dev/doc/devel/release#policy) says the …
dmitshur closed an issue net: TestSplice failures1mo
dmitshur closed an issue os/exec: TestPipeLookPathLeak failures1mo
dmitshur closed an issue os/exec: TestPipeLookPathLeak failures1mo
That looks like a different failure mode. I'll re-close this frozen issue and take it out of Test Flakes so that watchflakes can create a new issue.
The loading error happens because the main Go repository contains a development version of Go 1.23, which isn't released yet. In general, setting up gopls to work on the main Go repository is conside…
Closing as a duplicate of #27992 again, and taking it out of Test Flakes project so it doesn't get reopened.
This was done for x/tools in [CL 562838](https://go.dev/cl/562838). This issue is in Go1.22 milestone, so closing again. (It was fixed by [CL 559796](https://go.dev/cl/559796).)
dmitshur pushed to main in dmitri.shuralyov.com/scratch2mo
5eb48b5f5d31d39777719edb35d37b724f183dc8quine: add load-bearing trailing space
dmitshur created package in dmitri.shuralyov.com/scratch/quine2mo
LGTM. Thanks, and congrats on your first new Go package here! Done in PS 2. Patch set 2 seems to resolve this.