Activity
Today
dmitshur reviewed +2 on golang.org/dl/internal/version: set GOROOT_FINAL and PWD in environments3h
Unfortunate to be adding more complexity here, but I think this change is the best path forward given the alternatives available in #50183. It's possible we can eventually remove the complexity.dmitshur commented on cmd/go: varying GOROOT_FINAL invalidates precompiled C dependencies of "net"3h
Based on analysis in https://github.com/golang/go/issues/50183#issuecomment-1018921215 and following discussion, it sounds like it's determined that `cmd/go` itself is working as intended for 1.18, a…dmitshur commented on cmd/go: varying GOROOT_FINAL invalidates precompiled C dependencies of "net"3h
If I understand correctly, once the accepted proposal #47257 is implemented, this issue (and others like it) will stop being relevant. So that is the long-term fix for this problem, and we just need …dmitshur reviewed +2 on golang.org/x/build/internal/relui: add state icons and error text4h
Thanks.
Pointing out that the CSS name is still 'itemStatus'. It seems fine even if they're not exactly 1:1 (similar to how TaskList-itemCreated has title "Started") so marking t…Yesterday
dmitshur closed a change golang.org/dl/internal/version: update download link to dl.google.com21h
dmitshur commented on golang.org/dl/internal/version: update download link to dl.google.com21h
Thanks. This change has been applied in CL 311375.dmitshur commented on golang.org/x/build/cmd/release: Go installer on macOS 12.2 beta (21D5039d) fails22h
We've applied the aforementioned change to our release pipeline, so macOS installers that are published alongside upcoming Go releases should not be affected by this problem. We can keep this issue o…dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: expose native wayland methods1d
Now that the new file has `openbsd,wayland` added, it seems `native_linbsd_x11.go` should also be updated so its build constraint is `openbsd,!wayland`.This Week
dmitshur closed an issue github.com/go-gl/glfw: glfw.Init() changes os.Getwd() to `./resources/` directory when one exists.2d
dmitshur commented on github.com/go-gl/glfw: glfw.Init() changes os.Getwd() to `./resources/` directory when one exists.2d
As suggested above, this is GLFW working as intended rather than a bug to be fixed. See https://www.glfw.org/docs/latest/intro_guide.html#GLFW_COCOA_CHDIR_RESOURCES_hint.
This behavior can be cont…Last Week
dmitshur commented on golang.org/x/build/cmd/release: Go installer on macOS 12.2 beta (21D5039d) fails3d
Bisection shows the duplicate bg.png file was introduced in the change we made to fix issue #44239, in Feb 2021. The .pkg installer for go1.15.8 (released just before that change) has one bg.png, but…dmitshur commented on golang.org/x/build/cmd/release: Go installer on macOS 12.2 beta (21D5039d) fails4d
As it was helpfully pointed out, this may be related to our .pkg having a duplicate file in its table of content:
```
$ xar -t -f ./go1.17.6.darwin-arm64.pkg
[...]
Resources/bg.png
Resources/b…dmitshur commented on golang.org/x/build/cmd/relui: create production and staging environments4d
> TBD?
In addition to production and staging, I suggest having a third semi-environment, "dry-run mode". It would be intended for local execution and wouldn't need to be deployed anywhere. It woul…dmitshur opened an issue golang.org/x/build/cmd/gopherbot: assignReviewersToCLs fails to assign reviewers on x/tools CLs (e.g. CL 374434)5d
From `gopherbot` logs:
```
2022/01/20 19:15:16 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/374434
2022/01/20 19:15:16 Setting review on https://go-review.googlesource.com/c/…dmitshur commented on golang.org/x/build/cmd/release: Go installer on macOS 12.2 beta (21D5039d) fails5d
I found that [grr](https://github.com/google/grr) has a .pkg installer for macOS at https://grr-doc.readthedocs.io/en/latest/deploying-grr-clients/overview.html#downloading-clients, although it seems…dmitshur commented on golang.org/x/build/cmd/release: Go installer on macOS 12.2 beta (21D5039d) fails6d
Thanks for testing and confirming this Cherry. Can you try some other macOS installers (e.g., Chrome) and see if they're also affected, or it it only happening to the Go installer?
Given how generic…dmitshur pushed to
master in github.com/goxjs/websocket6d
dmitshur pushed to
master in github.com/goxjs/glfw6ddmitshur commented on golang.org/x/build/cmd/release: Go installer on macOS 12.2 beta (21D5039d) fails1w
I tried on macOS 12.1 (21C52) and on macOS 11.6.2 (20G314), and this issue doesn't reproduce. The installer shows up as correctly signed with a Google certificate, and opens okay.
So this may be e…dmitshur closed an issue golang.org/x/website/internal/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv}1w
dmitshur commented on golang.org/x/website/internal/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv}1w
Yeah, as far as I can tell, because of how package → module resolution works (documented at https://go.dev/ref/mod#resolve-pkg-mod), in module mode it appears to be sufficient as long as ?go-get=1 …dmitshur commented on golang.org/x/website/internal/talks: go.dev/talks doesn't parse legacy present formatting syntax1w
It seems the relevant parsing/conversion happens in [`present.Style`](https://pkg.go.dev/golang.org/x/tools/present#Style):
```Go
// Style returns s with HTML entities escaped and font indicators…dmitshur opened an issue golang.org/x/website/internal/talks: go.dev/talks doesn't parse legacy present formatting syntax1w
https://go.dev/talks hosts some Go talks, many of which use the [legacy present syntax](https://pkg.go.dev/golang.org/x/tools/present#hdr-Legacy_Present_Syntax) (rather than the newer [Markdown synta…dmitshur starred github.com/tdewolff/canvas1w
Earlier
dmitshur pushed to
master in github.com/shurcooL/githubv41wdmitshur starred bintris1w
dmitshur closed an issue github.com/shurcooL/githubv4: Type mismatch between variable and argument for optional String / ID1w
dmitshur commented on github.com/shurcooL/githubv4: Type mismatch between variable and argument for optional String / ID1w
> Would you welcome a PR including a section providing an example of this to avoid confusion from other users?
I believe this should be covered by https://github.com/shurcooL/githubv4#pagination; ca…dmitshur commented on github.com/shurcooL/githubv4: Type mismatch between variable and argument for optional String / ID1w
Ah, that snippet assumed that `endCursor` was of type `string`, but in your code its type is `*string`. In that case, you can just [convert](https://go.dev/ref/spec#Conversions) it to a `*graphql.Str…dmitshur commented on github.com/shurcooL/githubv4: Type mismatch between variable and argument for optional String / ID1w
From what you've shared, I'm fairly confident the problem is with the `variables` map you're providing to the `Query` call, specifically this code:
```Go
query := new(reposQuery)
variables := map[st…dmitshur starred github.com/PostgresApp/PostgresApp1w
dmitshur commented on github.com/shurcooL/githubv4: Type mismatch between variable and argument for optional String / ID1w
Yes, if it's an optional GraphQL type, using a Go pointer makes sense. That is also what's done in the code example I linked above. The [`NewString`](https://pkg.go.dev/github.com/shurcooL/githubv4#N…dmitshur commented on github.com/shurcooL/githubv4: Type mismatch between variable and argument for optional String / ID1w
If you look at GitHub's [`RepositoryOwner`](https://docs.github.com/en/graphql/reference/interfaces#repositoryowner) interface, the `after` argument of the `repositories` field has type [`String`](ht…dmitshur commented on 
github.com/terraform-providers/terraform-provider-github: Adding BypassPullRequestActorIDs to branch protection2w
github.com/terraform-providers/terraform-provider-github: Adding BypassPullRequestActorIDs to branch protection2w@jtyr The `BranchProtectionRule` struct looks to be used for querying the [BranchProtectionRule](https://docs.github.com/en/graphql/reference/objects#branchprotectionrule) GitHub GraphQL object. That…dmitshur commented on github.com/shurcooL/githubv4: Field 'bypassPullRequestActorIds' doesn't exist on type 'BranchProtectionRule'2w
The generated code includes enums in enum.go, and convenience input structs in input.go. The field `bypassForcePushActorIds` was added to `CreateBranchProtectionRuleInput` and `UpdateBranchProtection…dmitshur commented on golang.org/x/build/devapp: https://dev.golang.org/reviews page was unavailable on Aug 13, 2021 due to unexpected Gerrit behavior2w
I've looked into the panic in `golang.org/x/build/maintner`, and it seems the panic cannot happen under normal situations, only if Gerrit is misbehaving somehow. Since it only happened that one time …dmitshur opened an issue golang.org/x/build/maintner: GerritMeta.LabelVotes may panic if one of the commits it loops over is not present in corpus2w
Inside the `GerritMeta.LabelVotes` method, there's code like:
```Go
oldCommit := m.CL.Project.GitCommit(lastCommit)
newCommit := m.CL.Project.GitCommit(commit)
if !oldCommit.SameDiffStat(newCom…dmitshur starred filippo.io/intermediates2w
dmitshur pushed to
master in github.com/shurcooL/githubv42wdmitshur closed an issue github.com/shurcooL/githubv4: Code regeneration2w
dmitshur commented on github.com/shurcooL/githubv4: Code regeneration2w
Sure, I'll regenerate today. I'm not ready to start making tags here yet, that will happen later.dmitshur commented on golang.org/x/crypto/cryptobyte: cannot read all boolean true values3w
@FiloSottile Sounds good. Please feel free to update the `x/crypto` entry (and/or nested ones) in https://dev.golang.org/owners accordingly, so other people doing CCing will know as well.dmitshur closed an issue os/exec: TestLookPath fails on Windows3w
dmitshur commented on os/exec: TestLookPath fails on Windows3w
Thanks @iwdgo, closing.
Please comment if we missed something, or file a new issue if there's a new problem.dmitshur commented on github.com/peterhellberg/link: Update to account if applications use single quotes instead of double quotes3w
Not panicking seems like a good change.
Do you know if RFC 5988 permits the relation-type to be quoted with a single quote in addition to double quote?dmitshur opened an issue github.com/peterhellberg/link: Parse panics on input without double quotes3w
(Reporting in case it is helpful.)
The following input causes `Parse` to panic:
```Go
link.Parse(`</example.png>;rel=preload;as=image`)
```
(Playground link: https://go.dev/play/p/yZcgx_-7…dmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4w
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4w
dmitshur starred github.com/electronicarts/CnC_Remastered_Collection4w
dmitshur commented on golang.org/x/build: android and iOS corellium builders are missing1mo
Thank you @changkun. Not having 1 of 3 iOS builders is an okay state, since builds can complete with the 2 builders even if at a slightly reduced rate. For example, it helped make progress in [CL 369…dmitshur closed an issue cmd/compile: internal compiler error: unexpected stmt: nil1mo
dmitshur commented on cmd/compile: internal compiler error: unexpected stmt: nil1mo
Since this issue is resolved on tip, I'll move it to that milestone and close it as fixed. It can still be considered for [backport](https://go.dev/wiki/MinorReleases) to 1.17 and 1.16 (if 1.16 is af…dmitshur commented on cmd/go: go install with -trimpath and muslc (alpine linux) gcc is needed1mo
I see, thanks for more context.
It seems like we can close this issue as a duplicate of #37158, do you agree?
Note that proposal #47257 has been accepted by now, so that will affect this situat…dmitshur commented on golang.org/x/crypto/cryptobyte: cannot read all boolean true values1mo
Thanks for the report.
CC @FiloSottile, @katiehockman, @rolandshoemaker.dmitshur commented on cmd/install: with -trimpath and muslc (alpine linux) gcc is needed1mo
cgo needs a C compiler is needed to build C code, this is working as expected.
If you prefer to disable cgo, you can configure that with the `CGO_ENABLED` environment option.
If your C compiler…dmitshur commented on go tool compile: fork/exec /usr/local/go/pkg/tool/linux_amd64/compile: resource temporarily unavailable1mo
Does the same problem happen if using `go` from the command line? If not, it looks like the problem is with in `nvim` and how it uses Go, and so this report would need to be made in its issue tracker…dmitshur commented on golang.org/x/vulndb: labels not applied when issue is created1mo
Is it because the label in x/vulndb doesn't have a space ([NeedsTriage](https://github.com/golang/vulndb/labels?q=NeedsTriage)),
but in [worker.go](https://github.com/golang/vulndb/blob/552ce2251f…dmitshur commented on golang.org/x/website/internal/dl: provide json listing in version order1mo
Thanks. In general it looks good, I left minor comments.
As I mentioned on the CL, I expect this change to not to be disruptive, and one that we can make, but it's hard to know for sure in advance…dmitshur commented on reflect: segmentation violation while using html/template1mo
@randall77 Is the reason the backport request was made for 1.17 only because 1.16 doesn't have this problem?dmitshur opened an issue golang.org/x/build: android and iOS corellium builders are missing1mo
It looks like these builders have gone missing recently. As visible at https://farmer.golang.org/#pools:
```
host-android-arm64-corellium-android: 0/0 (3 missing)
host-ios-arm64-corellium-ios: 0…dmitshur commented on net/http: first HTTP request is consistently slower1mo
Thanks for clarifying.
I'm still not seeing the same difference you're describing on my machine, at least not with Go 1.18 Beta 1:
```
$ go run . | grep "handshake end"
184.652292ms handshake…dmitshur commented on cmd/compile: "cannot use concurrent backend compilation with provided flags" reported after building go1.18beta1 from source1mo
This problem doesn't reproduce when I build Go from source at that commit:
<details>
```
gotip $ git status
HEAD detached at becaeea119
nothing to commit, working tree clean
gotip $ cd src …dmitshur commented on net/http: first HTTP request is consistently slower1mo
> consistently 100-200ms slower
Can you clarify how you're getting to that number? From your log, it looked like all 3 requests got first byte within 20 ms, not 100-200 ms.dmitshur commented on net/http: first HTTP request is consistently slower1mo
In the test performed, `client := &http.Client{}` looks suspicious. From https://pkg.go.dev/net/http#Client.Transport:
```Go
// Transport specifies the mechanism by which individual
// HTTP requ…
Nit: Line 35 needs one more dash for alignment. :)dmitshur commented on github: two items in the issue templates list say "to report a vulnerability" 1mo
> If it's hard to find the optimal choice, we can default to the simpler option of removing the custom contact link.
Okay, let's do this for now to resolve this issue.dmitshur commented on golang.org/x/website/internal/dl: provide json listing in version order1mo
Since the suggestion here is to make &include=all give versions in sorted order, I think that means #47367 needs to be fixed first. Otherwise when there's more than 1 pre-release version, it won't be…dmitshur commented on golang.org/x/build/cmd/releasebot: add an upper limit to the total log posted to GitHub1mo
Issue #47148 is a data point involving fairly verbose output, spanning 20 comments. Perhaps it can help make a decision here.
As a straw proposal, how about if `len(bodyParts) <= 4`, post them all…dmitshur opened an issue golang.org/x/build/cmd/releasebot: may select wrong current milestone if there are duplicates1mo
Releasebot looks for the release milestone for the current release, and uses it for various things during the release process.
GitHub allows for multiple milestones to have the same title that dif…dmitshur commented on runtime/race: building for iOS, but linking in object file built for macOS [1.16 backport]1mo
Approved as a test-only fix. Only 1.16 needs this backport, since the fix is already present in Go 1.17.dmitshur commented on golang.org/x/website: tip.golang.org should redirect to pkgsite with tip link1mo
This was done in other cases, for example https://tip.golang.org/pkg redirects to https://pkg.go.dev/std@master. Looks like this is an edge case that was missed, and just needs to be fixed. Thanks fo…dmitshur opened an issue github.com/google/go-github/v42: add AppID field to ListCheckRunsOptions1mo
Both https://docs.github.com/en/rest/reference/checks#list-check-runs-for-a-git-reference and https://docs.github.com/en/rest/reference/checks#list-check-suites-for-a-git-reference endpoints documen…dmitshur starred golang.org/x/website1mo
dmitshur commented on golang.org/x/vuln: Test failing on multiple builders due to undeclared dependencies fetched from the network1mo
```
Get "https://sum.golang.org/lookup/...": ...: no route to host
```
Failures resolving the checksum database means the checked in go.sum is missing entries for dependencies that are being dow…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes1mo
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on github.com/libsdl-org/SDL: macOS 12 Monterey - odd/broken OpenGL VSync behavior1mo
In case it's helpful here, reports in https://github.com/glfw/glfw/issues/1990 suggest this issue may be fixed in macOS 12.1 (21C52), released today.dmitshur commented on github.com/glfw/glfw: Vsync doesn't work on macOS 12.0 (Monterey)1mo
I can confirm @GameParrot's finding.
I've retested an OpenGL application mentioned in https://github.com/glfw/glfw/issues/1990#issuecomment-968177486 right before, while on macOS 12.0.1 (21A559), …dmitshur closed a change golang.org/x/build/update-readmes.go: add comment1mo
dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: update to GLFW 3.3.41mo
> (We should also update https://github.com/go-gl/glfw/wiki/Development#updating-glfw-c-source for the new grab-upstream process.)
Done in [wiki commit `f28edba4`](https://github.com/go-gl/glfw/wi…dmitshur edited the wiki in github.com/go-gl/glfw1mo
dmitshur pushed to
master in github.com/go-gl/glfw1mo
dmitshur merged a change github.com/go-gl/glfw: Upgrade glfw to 3.3.6, fixes #3391mo
dmitshur closed an issue github.com/go-gl/glfw/v3.3/glfw: update to latest GLFW release1mo
dmitshur reviewed +2 on github.com/go-gl/glfw: Upgrade glfw to 3.3.6, fixes #3391mo
Looks good, thank you.dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes1mo
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur commented on net/netip: AddrPort MarshalText and String methods produce different values1mo
CC @bradfitz.dmitshur commented on github.com/go-gl/gl: Make the workflow a bit more reliable1mo
Thanks!
It's true there aren't dedicated tests, but it still helps to at least run `go test ./...` since it confirms there aren't build errors, and runs some high-confidence vet checks. (Plus if a…dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: update to latest GLFW release1mo
Indeed. @Jacalz, if you'd like and are able to, please feel free to send a PR. The last update was in PR #329, and its commit message should have helpful information. Improvements to make the grab-up…dmitshur edited the wiki1mo
dmitshur commented on golang.org/x/website: "Get Started" on /learn links to the current page1mo
CC @Lyoness, @pearring via [owners](https://dev.golang.org/owners).dmitshur commented on golang.org/x/website: Linkable sections "Learning Resources" and "Meetups"1mo
CC @Lyoness, @pearring via [owners](https://dev.golang.org/owners).dmitshur closed an issue golang.org/x/website: cannot Google search for Release History page1mo
dmitshur commented on golang.org/x/website: cannot Google search for Release History page1mo
Thanks, indeed, it shows up now. Closing.dmitshur commented on golang.org/x/build/cmd/coordinator: builders with non-zero KnownIssue are not grayed out in the golang.org/x repo sections1mo
Now that #34744 is complete, this became much easier. Fix for this and another issue incoming.dmitshur commented on golang.org/x/build/cmd/release: evaluate releaselets used for each upcoming major Go release1mo
All looks ready for Go 1.18 Beta 1, so moving this recurring issue to the next milestone.dmitshur commented on net/netip: add fuzz test comparing with net.ParseIP1mo
Confirmed, it should be okay and helpful!
As I understand, fuzz targets don't run automatically during all.bash, so this is really low-risk for the stability of the release.dmitshur commented on golang.org/x/build/cmd/release: evaluate releaselets used for each upcoming major Go release1mo
We've discussed macOS today and agreed to use macOS 12 releaselets both for amd64 and arm64 architectures starting with Go 1.18 Beta 1. Send [CL 369958](https://go.dev/cl/369958).dmitshur commented on golang.org/x/build: add macOS 12.0 Monterey builders (arm64/amd64)1mo
> not tracking health
To expand on this, the "macOS ARM64 (M1 Mac minis)" health item in https://farmer.golang.org/#health is tracking the health of `host-darwin-arm64-12_0-toothrot` (this builder),…dmitshur commented on golang.org/x/build/dashboard: remove MallocNanoZone=0 from macOS 12 builder configuration1mo
Thanks Cherry. We'll wait for the 1.17 workaround to land. I think it can be removed from builder configuration when 1.18 is released and 1.16 stops being supported. So waiting on that.