Dmitri Shuralyov

Activity

Today

dmitshur commented on golang.org/x/build/internal/relui: leave out GOROOT_FINAL when building distpacks6m

Thanks.

dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count28m

> that means the intent of getting this fixed in go1.21.1 is recorded only in my head It's okay to create the backport issue as soon as you think it should be considered for backport, before the iss…

dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count1h

@adonovan Note that manually placing an issue in a Go minor release milestone can lead to it being missed in weekly backport review and in [minor release note](https://go.dev/doc/devel/release#go1.25…

dmitshur reviewed +2 on golang.org/x/pkgsite-metrics/terraform/environment: reduce minScale to 03h

Thanks, though please take into account I'm not very familiar with this.

dmitshur commented on golang.org/x/net/...: remove go1.25 and older build constraints4h

Thanks.

dmitshur commented on golang.org/x/build/internal/https: delete copy of http.CrossOriginProtection4h

Thanks.

dmitshur commented on golang.org/x/net/...: remove go1.25 and older build constraints6h

This change is ready for review.

Yesterday

dmitshur opened a change golang.org/x/net/...: remove go1.25 and older build constraints16h

Now that the x/net module requires Go 1.25.0, the go1.25 build constraint is always satisfied. Simplify the code accordingly.

dmitshur opened a change golang.org/x/build/internal/https: delete copy of http.CrossOriginProtection16h

Now that the x/build module requires Go 1.25.0, it's viable to always use CrossOriginProtection from the standard library instead of a copy of it. For golang/go#75899.

dmitshur commented on cmd/compile: set alignment of type descriptors23h

This change seems to cause testplugin test failures on GOOS=darwin (except on the nocgo builder): https://ci.chromium.org/p/golang/g/go-gotip.

dmitshur reviewed +2 on golang.org/x/pkgsite-metrics/devtools: introduce revision tagging1d

Thanks. Since this line is a continuation of the previous one, consider indenting it to make that more visible. See line 109 for example. Is the indentation change here intended?

dmitshur closed a change golang.org/x/build/internal/relui: add a one-off "maintain go directive (only) for Go 1.26" workflow1d

Thanks. This was intended for a one-off workflow run for the Go 1.26 release cycle. That's done now and it successfully created go-directive-only [x/ repo CLs](https://go-review.googlesource.com/q/ow…

dmitshur commented on golang.org/x/build/internal/task: leave toolchain directive to the go command1d

Thanks.

dmitshur commented on golang.org/x/build/internal/relui: don't include go fix in go directive maintenance CLs1d

Thanks.

dmitshur commented on golang.org/x/build/internal/relui: don't include go fix in go directive maintenance CLs1d

(1 comment) Added a scheme so it gets linkified in Gerrit (and elsewhere), like above.

dmitshur opened a change golang.org/x/build/internal/relui: add a one-off "maintain go directive (only) for Go 1.26" workflow1d

This is intended to make it possible to re-generate the "all: upgrade go directive to at least 1.25.0 [generated]" CLs for the Go 1.26 cycle with 'go fix ./...' not included.

dmitshur commented on golang.org/x/build/internal/relui: don't include go fix in go directive maintenance CLs1d

This change is ready for review.

dmitshur opened a change golang.org/x/build/internal/relui: don't include go fix in go directive maintenance CLs1d

The 'go fix ./...' invocation was included in the initial implementation of the go directive maintenance workflow with the following rationale, copied from https://go.dev/design/69095-x-repo-continuo…

dmitshur closed a change DO NOT SUBMIT: [release-branch.go1.24] runtime: add traceback nil m context1d

Closing because this is on release-branch.go1.24 and probably not needed now that Go 1.26.0 is out. Feel free to reopen if it's still useful for something.

dmitshur closed a change cmd/go: [release-branch.go1.24] test barrier actions1d

With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…

dmitshur closed a change cmd/compile: [release-branch.go1.24] fix loopvar version detection with line directives1d

dmitshur closed a change runtime: don't negate eventfd errno1d

With the release of Go 1.26.0, the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.24 backport CL.

dmitshur commented on cmd/compile: go1.22+ cmd with go.mod 1.21 generates per-loop variable when using line directive [1.26 backport]1d

dmitshur closed an issue runtime: netpollinit() incorrectly prints the error from `linux.Eventfd` [1.24 backport]1d

dmitshur closed an issue cmd/go: CGO compilation fails after upgrading from Go 1.25.5 to 1.25.6 due to --define-variable flag in pkg-config [1.24 backport]1d

This Week

dmitshur commented on cmd/go: inconsistent reporting of default Go version1d

One of #63507 or #70090 can probably be closed as a duplicate of the other. Note that https://github.com/golang/go/issues/63507#issuecomment-1759734314 includes motivation for the current behavior: …

dmitshur opened a change golang.org/x/build/internal/task: leave toolchain directive to the go command1d

As of Go 1.25, the go command does not introduce the toolchain directive on 'go get go@...' invocations if there wasn't already a toolchain directive present. Relui didn't want to add those directive…

dmitshur opened a change golang.org/x/build/internal/coordinator/pool: remove extra goroutine1d

The EC2BuildetPool code isn't used now, but fix it anyway since it was spotted in CL 744160. Also shorten TestWaitForInstaceRevdialError code.

dmitshur commented on golang.org/x/build/cmd/makemac: drop macOS 11 builders1d

Thanks. It's so nice that makemac vacates excess instances automatically too now (CL 652235).

dmitshur commented on golang.org/x/build/main.star: clean up after dropping release-branch.go1.241d

Thanks.

dmitshur commented on golang.org/x/build/main.star: update supported Go versions and drop release-branch.go1.241d

Thanks.

dmitshur opened a change golang.org/x/build/internal/installer/darwinpkg: remove "Fixing permissions" step1d

For golang/go#74287.

dmitshur opened a change golang.org/x/build/cmd/makemac: drop macOS 11 builders1d

Reallocate the new capacity to the remaining ones. For golang/go#69839.

dmitshur commented on golang.org/x/build/main.star: clean up after dropping release-branch.go1.241d

That's right, this CL depends on the changes of CL 744141 and shouldn't be submitted before that one is. It's already stacked accordingly.

dmitshur opened a change golang.org/x/build/main.star: clean up after dropping release-branch.go1.241d

Delete code that became dead as of CL 744141. Generated files unchanged.

dmitshur opened a change golang.org/x/build/main.star: update supported Go versions and drop release-branch.go1.241d

The Go 1.26.0 release is out, so 1.25 is the oldest supported release.¹ The previous infrastructure (cmd/coordinator) does this automatically, whereas here I authored this CL manually. We'll explore…

dmitshur reviewed +2 on golang.org/x/build/...: upgrade go directive to at least 1.25.0 [generated]2d

This matches my expectations (as noted [here](https://go-review.googlesource.com/c/build/+/743495/3//COMMIT_MSG)). Thanks.

dmitshur commented on golang.org/x/build/cmd/devapp: update source code link after move2d

Thanks.

dmitshur commented on golang.org/x/website/internal/history: remove draft notice, update deployment, add Go 1.262d

(1 comment) If you want, this can be "Fixes" since it removes the draft notice, and doing that is the reason that issue [was left open](https://github.com/golang/go/issues/75005#issuecomment-3814390…

dmitshur opened a change golang.org/x/build/cmd/devapp: update source code link after move2d

Add the "cmd" path component was missed in CL 737061. Point to the source code viewer at https://go.dev/cs.

dmitshur reviewed +2 on go.dev/wiki/GerritAccess: overhaul approvers section2d

Still LGTM. Thanks again. The newer links you've added are already using the works-in-more-contexts relative form, so consider applying that to this old link too. ```suggestion Note that all user-v…

dmitshur closed a change golang.org/x/build: -- dividing line after reaching go fix zero diff --2d

This "dividing line" CL has served its purpose.

dmitshur commented on golang.org/x/build/...: simplify after slicescontains and stringsbuilder fixes2d

Thanks.

dmitshur commented on github.com/go-gl/gl: Jerky refresh with high update rate2d

Does the same behavior reproduce if you try the example programs at [go-gl/example](https://github.com/go-gl/example)? If not, you can try bisecting between the two programs to narrow in on the cause…

dmitshur reviewed +2 on cmd/go/internal/bug: sync go bug headings with GitHub form2d

Thanks.

dmitshur commented on golang.org/x/build/...: apply omitzero fix2d

(1 comment) It's actually a minimal client for the k8s API, added back in 2015 (CL 14390). At some point I think it was used more heavily for k8s-based builders. By now I think our only remaining us…

dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes3d

In case it helps, noting here that I found breaking out a single analyzer run to happen first in the dashboard package is a viable workaround: ```sh go fix -stringsseq ./dashboard # workaround for …

dmitshur commented on golang.org/x/build/...: replace slices.Contains-likes with slices.Contains3d

This change is ready for review.

dmitshur opened a change golang.org/x/build: -- dividing line after reaching go fix zero diff --3d

At this point, 'go fix ./...' produces zero diff and exit code 0. The following CLs are follow ups to some of the earlier changes that were generated. Their scope was intentionally to run a fix as i…

dmitshur opened a change golang.org/x/build/...: apply fmtappendf fix3d

For golang/go#77519. [git-generate] go fix -fmtappendf ./...

dmitshur opened an issue golang.org/x/build: modernize for Go 1.24+ (via `go fix`)3d

The x/build repo has a good number of opportunities to modernize Go code, some older and some newer. In Go 1.26, [`go fix`](https://go.dev/doc/go1.26#go-command) is improved to make it much easier to…

dmitshur opened a change golang.org/dl/internal/version: add explanatory comments to runGo3d

Explain some of the subtle reasons for why runGo behaves as it does. Do this to reduce chances of something accidentally breaking in the future. Based on suggestions Russ made in https://go-review.g…

dmitshur opened a change golang.org/x/build/internal/relui: leave out GOROOT_FINAL when building distpacks3d

As of Go 1.23, the GOROOT_FINAL environment variable is no more¹, and so it's no longer necessary to set it here. Start gradually removing it. Also, delete some code that became dead as of Go 1.24.…

dmitshur opened a change golang.org/x/build/cmd/watchflakes: include all failures in "log" field3d

The "log" field is documented as "the entire failed build log" at https://go.dev/wiki/Watchflakes#records. In practice it was only the top-level log text, and not the additional failures. Their logs …

dmitshur commented on cmd/go: use AppendPath(OrigEnv) as env for tool executable3d

Filed issue #77509 to document this behavior.

dmitshur commented on cmd/go: place GOROOT/bin at the beginning of PATH in 'go run'3d

Filed issue #77509 to document this behavior.

dmitshur opened an issue cmd/go: document GOROOT/bin/go PATH entry for `go run` and `go tool`3d

This is a continuation of issue #57050, to add missing documentation for a cmd/go behavior that's already implemented for a few more of its commands. ([CL 461683](https://go.dev/cl/461683) previously…

dmitshur commented on github.com/shurcooL/githubv4: Maintenance status and future plans3d

Thanks for offering to help. I wouldn't describe its maintenance levels as very active, but I do still use it myself and ocassionally update it to include latest GitHub GraphQL schema changes. That'…

dmitshur pushed to main in github.com/shurcooL/graphql3d

ed46e5a4646634fc16cb07c3b8db389542cc8847 → 7ee5256398cf02fc37809e1d97599dcbe308c2f8

dmitshur closed a change github.com/shurcooL/githubv4: regenerate for schema changes by 2022-10-243d

Thanks. These schema changes are already merged via PR https://github.com/shurcooL/githubv4/pull/110.

dmitshur commented on github.com/shurcooL/githubv4: regenerate for schema changes by 2022-10-243d

Thanks. These schema changes are already merged via PR https://github.com/shurcooL/githubv4/pull/110.

dmitshur commented on github.com/shurcooL/githubv4: Regenerate for schema changes by 2025-11-213d

Thanks for the PR. I prefer to update go.mod and go.sum files separately. I pushed commit 2402fdf4a9edcf51ed3f2eab4dc57c6867b10eea that includes schema changes by 2026-02-08. It doesn't yet includ…

dmitshur pushed to main in github.com/shurcooL/githubv43d

48295856cce734663ddbd790ff54800f784f3193 → 2402fdf4a9edcf51ed3f2eab4dc57c6867b10eea

dmitshur commented on golang.org/x/example/gotypes: update for go/types.Alias 3d

[CL 620075](https://go.dev/cl/620075) updated the gotypes tutorial.

dmitshur closed an issue runtime: TestRuntimeLockMetricsAndProfile/runtime.lock/sample-1 failures4d

dmitshur closed an issue cmd/go/internal/bug: sync issue body format with GitHub template4d

Last Week

dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder5d

Adding a note here that the exec format error on cipd_cache/bin/cipd is likely the same problem that was encountered in https://github.com/golang/go/issues/67306#issuecomment-3633590314. If so, you m…

dmitshur commented on net/http: fix WaitGroup race in TestTransportNoReuseAfterEarlyResponse5d

Thanks.

dmitshur opened a change golang.org/x/build/cmd/gopherbot: close reopened cherry-pick issues5d

Maintain the property that gopherbot doesn't enter a non-stop fighting match with a human trying to reopen a cherry-pick issue, but still let the submission of newer backport CLs re-close said issues…

dmitshur opened an issue cmd/go/internal/bug: sync issue body format with GitHub template (as of February 2026)5d

[CL 553155](https://go.dev/cl/553155) reordered headings in the GitHub issue templates to be "got, want" (for issue #64890), but the issue template used by `go bug` still has the old inverse "want, g…

dmitshur commented on cmd/go: add `go env -bug-report`5d

I agree that `go env -changed` cannot fully replace `go env`, but it can be a useful addition in many cases. Go's CI system prints all 3 of `go env`, `go env -changed`, and even `cmd/internal/metadat…

dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.26: minor adjustments6d

Thanks.

dmitshur reviewed +2 on golang.org/x/build/go.mod: upgrade github.com/fflewddur/ltbsky6d

Thanks. Needs a go mod tidy, I suspect. I really can't tell which is less expensive: leaving this unresolved comment that gets in the way of this auto-submitting, or leaving it for a future CL at t…

dmitshur commented on crypto/tls: [release-branch.go1.26] avoid data race when canceling a QUICConn's Context6d

Adding TryBot-Bypas since only go1.26-linux-amd64-longtest had a seemingly unrelated TestTraceGCSTW failure, and after being restarted it passed.

dmitshur reviewed +2 on go.dev/wiki/GerritAccess: clarify encouragement to vote Auto-Submit+16d

Thanks very much. Optional: maybe "new exported API" is better than "new API"; it doesn't add much verbosity but I think may help solidify that this isn't talking about internal API changes too. > …

dmitshur commented on golang.org/x/build/internal/relui: fix BaseLink to keep RawPath in sync with Path6d

Thanks. I can redeploy relui with this now.

dmitshur opened a change log/slog: [release-branch.go1.26] correct method names in MultiHandler docs6d

For #77428. Fixes #77429.

dmitshur opened an issue cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes6d

### Go version go version go1.26rc3 darwin/arm64 ### Output of `go env` in your module/workspace: ```shell AR='ar' CC='clang' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_ENABLED=…

dmitshur commented on access: approvers1w

Hi @HeliC829, you recently sent a GitHub request to join the [golang/riscv64](https://github.com/orgs/golang/teams/riscv64) maintainer team. As suggested at https://go.dev/wiki/PortingPolicy#requirem…

dmitshur reviewed +1 on github.com/fflewddur/ltbsky: Avoid logging arbitrary length byte slice1w

Thanks.

dmitshur fixed an issue golang.org/x/vulndb: TestLintReports/data/reports/GO-2026-4336.yaml failures1w