Activity
This Week
dmitshur pushed to
master in github.com/shurcooL/markdownfmt2d
dmitshur pushed to
master in github.com/shurcooL/markdownfmt2ddmitshur closed an issue github.com/shurcooL/markdownfmt: please add copyright :)2d
dmitshur commented on github.com/shurcooL/markdownfmt: please add copyright :)2d
Thanks for reporting. I’ll fix this soon.Last Week
dmitshur commented on GitHub mirror: lock conversations on GitHub commits2d
The mirroring is done by [`gitmirror`](https://pkg.go.dev/golang.org/x/build/cmd/gitmirror). Unfortunately, we are still waiting on GitHub to expose the ability to lock conversations on commits via a…dmitshur closed an issue GitHub mirror: lock conversations on GitHub commits2d
dmitshur starred in github.com/beevik/ntp2d
Please note while go.mod declares v0.1.2 as the minimum required version of `clipboard`, the [vendored copy](https://github.com/rsc/2fa/tree/a3704cafc7d523c8ea371199636cab38e3d37ba4/vendor) is an old…dmitshur commented on rsc.io/2fa/2fa: migrate to Go Modules3d
Commit a3704cafc7d523c8ea371199636cab38e3d37ba4 has been merged, so maybe this PR can be closed (or, alternatively, rebased to include only the vendor directory removal).dmitshur commented on syscall: comment on fields omitted from the win32finddata1 struct3d
(1 comment)
Is this word included unintentionally?dmitshur commented on cmd/internal/moddeps: check content of all modules in GOROOT3d
(2 comments)
Done.
(I didn't apply this to the advice we print because it makes the command too verbose, humans should be able to interpret and use the simple command.)
It seems viable to symlink …dmitshur commented on cmd/internal/moddeps: check content of all modules in GOROOT3d
(3 comments)
> makes it much more likely that someone editing the test will incur at least one extra test/edit cycle if they forget to run it in short mode
To clarify, are you aware of a scenario w…dmitshur merged a change github.com/golang/gddo/README.markdown: add archive note3d
dmitshur commented on github.com/golang/gddo: SERCURITY.md3d
There isn't a need to add a MySECURITY.md file to this repository. Information about security can be found at https://golang.org/security.dmitshur closed a change github.com/golang/gddo: SERCURITY.md3d
dmitshur closed a change github.com/golang/gddo: Move to Go modules3d
dmitshur commented on github.com/golang/gddo: Move to Go modules3d
Thanks for sending this change. A similar change was made via https://golang.org/cl/215678, so closing.dmitshur reviewed +2 on github.com/golang/gddo/README.markdown: add archive note3d
(1 comment)
Thanks.dmitshur closed an issue github.com/golang/gddo: I can't figure out why you're hiding the scrollbar from the site, you idiot3d
dmitshur commented on github.com/golang/gddo: I can't figure out why you're hiding the scrollbar from the site, you idiot3d
Please keep https://golang.org/conduct in mind when taking the time to report an issue.
The godoc.org website does not make a decision to hide the scrollbar. This appears to be a configuration opt…dmitshur closed an issue github.com/golang/gddo: Marxist propaganda on the website3d
dmitshur commented on github.com/golang/gddo: Marxist propaganda on the website3d
Please see https://github.com/golang/go/issues/41094#issuecomment-682574230.dmitshur commented on github.com/golang/gddo: GoDoc.org shows out of date package github:temporalio/temporal-go-sdk3d
> OK, so how do we "fix" that?
There's nothing you need to do, this was fixed by making a module-aware package documentation available at pkg.go.dev, where as you said this works. Considering http…dmitshur closed an issue github.com/golang/gddo: GoDoc.org shows out of date package github:temporalio/temporal-go-sdk3d
dmitshur closed an issue github.com/golang/gddo: Typo on page 'package bsontype'3d
dmitshur merged a change cmd/link: remove GOROOT write in TestBuildForTvOS3d
dmitshur commented on cmd/link: remove GOROOT write in TestBuildForTvOS3d
(1 comment)
Thanks! Done.dmitshur commented on cmd/link: remove GOROOT write in TestBuildForTvOS3d
(1 comment)
TRY=darwin-amd64-10_15
(Fingers crossed I don't run into #42084, but I won't be surprised...)dmitshur opened a change cmd/link: remove GOROOT write in TestBuildForTvOS3d
Tests should avoid writing to GOROOT when possible. Such writes
would fail if GOROOT is non-writeable, and it can interfere with
other tests that don't expect GOROOT to change during test execution.
…dmitshur commented on cmd/internal/moddeps: check content of all modules in GOROOT3d
(1 comment)
Done.dmitshur commented on cmd/internal/moddeps: check content of all modules in GOROOT4d
(8 comments)
Thanks for the comments. I've considered them and left inline replies, please let me know what you think.
For now, I'll push the next patch set that moves this CL in the direction that…dmitshur commented on crypto/x509: update bundled iOS roots and rewrite generator4d
(1 comment)
> This would be better if we had tests for the tree being "go generate"-clean, but AFAIK we don't.
There's one being added in CL 283643 now. It primarily targets checking that the tree …dmitshur reviewed +2 on crypto/x509: update iOS bundled roots to version 55188.40.94d
(2 comments)
windows-386-2008 failure is #42637.
The issue mentioned a preference of an index text file over directory listing due to the latter being more out of date. Has the directory listing be…dmitshur opened an issue std: add test to ensure that all modules in GOROOT are tidy5d
We can add a test that catches and reports when the a module in GOROOT is not tidy.
Having an automated test for this will prevent it from happening without anyone noticing, and it makes it easier…dmitshur commented on golang.org/x/website: Getting Started tutorial doesn't work with Go 1.166d
Issue #43430 is related. CC @jayconrod.
Based on the discussion there, I suspect we prefer suggesting `go get` over `go mod tidy` for the specific task of adding new dependencies. (`go mod tidy` i…dmitshur commented on wiki: Go-Release-Cycle has an out of date statement on backporting policy6d
@mvdan Do you think the suggested combined phrasing in https://github.com/golang/go/issues/37097#issuecomment-583182330 would work well?dmitshur closed an issue access: add timothy-king to go-assignees and go-approvers6d
dmitshur commented on access: add timothy-king to go-assignees and go-approvers6d
Done. (A late) Welcome to the team, Tim!
CC @golang/release.dmitshur commented on access: Github("go-approvers")1w
Hi Sean,
Thank you so much for your contributions on the issue tracker and elsewhere, they've been very helpful! We've discussed this request on the team and agreed to grant you access. I've sent …dmitshur closed an issue access: Github("go-approvers")1w
dmitshur closed an issue golang.org/x/tools: rewrite git history to remove accidental merge commit1w
dmitshur commented on golang.org/x/tools: rewrite git history to remove accidental merge commit1w
We needed to rewrite the history of x/tools master branch so that the `gopls/v0.6.1` tag would no longer be an ancestor (this is what was causing the pseudo-versions to start with `v0.6.2-0.`).
…dmitshur starred in github.com/hexops/autogold1w
dmitshur pushed to
master in github.com/shurcooL/go-goon1wdmitshur closed a change github.com/shurcooL/go-goon: License issue of pkg.go.dev fix #141w
dmitshur closed an issue github.com/shurcooL/go-goon: https://pkg.go.dev/ can't detect license1w
@Uzume That commit predated https://github.com/shurcooL/cmd/commit/e8b5cc9577219573d0123cdbaac9cf68111c156b.dmitshur closed a change github.com/russross/blackfriday: Fix 404 error for v21w
dmitshur commented on github.com/russross/blackfriday: Fix 404 error for v21w
Closing due to no answer from PR author. We can re-open if there's new information.dmitshur starred in github.com/blizzy78/ebitenui1w
Earlier
dmitshur deleted branch in github.com/dmitshur/indielogin.com1w
patch-1dmitshur commented on github.com/aaronpk/indielogin.com: set grant_type=authorization_code in authz code request1w
Friendly post-holiday ping, in case you missed this @aaronpk.dmitshur closed an issue windows/arm: fatal error: minpc or maxpc invalid [1.15 backport]1w
dmitshur commented on windows/arm: fatal error: minpc or maxpc invalid [1.15 backport]1w
Yes, let's do that. Thank you.dmitshur commented on github.com/go-gl/gl: Strs returned free not actually working properly1w
Sometimes the "\x00" isn't added automatically out of consideration to avoid allocations, since they can be easily avoided if the caller provides a null-terminated string.
That said, [`Strs`](https:…dmitshur opened an issue cmd/compile: internal compiler error after OpArg expansion delay on PPC641w
### What version of Go are you using (`go version`)?
Tested with latest tip as of 30 minutes ago.
<pre>
$ gotip version
go version devel +d2131704a Wed Jan 6 15:02:50 2021 +0000 darwin/amd64
…dmitshur commented on ld: warning: object file was built for newer OSX version (10.12) than being linked (10.11)1w
Thanks for reporting. To confirm, are those warnings reproducible for you, meaning they are emitted for each separate build operation?
As I said in https://github.com/golang/go/issues/36025#issuec…dmitshur commented on cmd/link: system linker warnings on macOS 10.14 when using cgo1w
> I think we can forgo a fix for this... I am a few of the last on 10.11.6 ... El Captain.
@einthusan Go 1.14 is supposed to require macOS 10.11 as the oldest version, not 10.12. (See [here](https:/…dmitshur commented on cmd/link: system linker warnings on macOS 10.14 when using cgo1w
@einthusan It'll be better to file a new issue, fill in the relevant information, and also mention this issue number. Thanks.dmitshur starred in rsc.io/rf2w
dmitshur commented on crypto/x509: Update test case in verify_test2w
We skip or fix tests in old branches when the test failure is understood and it interferes with the release process, but it's not a goal to always fix all old tests. If this isn't causing much troubl…dmitshur pushed to
master in github.com/goxjs/gl2wdmitshur commented on github.com/go-gl/glfw: Enter Chinese in full screen2w
This issue tracker is for the Go bindings to GLFW. Does the problem also occur upstream, in [GLFW itself](https://www.glfw.org/)?dmitshur pushed to
master in github.com/shurcooL/home2wdmitshur commented on github.com/aaronpk/indielogin.com: Add grant_type2w
@Zegnat I'm not familiar with the history of this codebase to say, but perhaps custom code is being used in order to provide more customization over error messages and diagnostics on indielogin.com, …dmitshur commented on net/http: net/http's TestNoSniffExpectRequestBody_h2 stops passing after x/net/http2 change in CL 253259 [1.14 backport]2w
Closing for the same reason as in #43139.dmitshur closed an issue github.com/go-gl/glfw/v3.2/glfw: warnings during build2w
dmitshur commented on github.com/go-gl/glfw/v3.2/glfw: warnings during build2w
Thanks for confirming.
Closing as duplicate/resolved in v3.3.dmitshur commented on github.com/go-gl/glfw: Is this an error?2w
Does the issue also affect v3.3/glfw?dmitshur commented on github.com/andygrunwald/go-gerrit/README: Follow the Go Release Policy2w
One comment, otherwise LGTM. Thanks!dmitshur commented on github.com/andygrunwald/go-gerrit/README: Follow the Go Release Policy2w
One comment, otherwise LGTM. Thanks!dmitshur commented on github.com/andygrunwald/go-gerrit/README: Follow the Go Release Policy2w
Replace “current + two previous” with “current + previous”. Go supports two major releases at a time, not three.dmitshur starred in github.com/hexops/valast2w
dmitshur opened an issue all: audit which generate directives depend on version of vendored packages2w
The Go standard library uses vendored copies of some external packages. These packages are updated as needed to fix bugs or bring in new features, and in bulk as part of release cycle maintenance (is…dmitshur commented on os: File.Readdirnames order is different than of "ls -l"2w
Yep, the time difference is expected because [`ioutil.ReadDir`](https://github.com/golang/go/blob/go1.15.6/src/io/ioutil/ioutil.go#L91-L105) calls `f.Readdir` which performs lstat for each file to ge…dmitshur commented on os: File.Readdirnames order is different than of "ls -l"2w
I'll close this as there's no bug here, and we use the Go issue tracker for bugs and proposals only.
For questions and discussion about using Go, please see https://golang.org/wiki/Questions for a…dmitshur closed an issue os: File.Readdirnames order is different than of "ls -l"2w
dmitshur commented on : os.File.Readdirnames order is different than of "ls -l"2w
Directory order means the same order that the operating system returns. This depends on the OS type, version, and importantly the filesystem used at the path that was read.
To get a predictable or…dmitshur commented on golang.org/x/mobile/cmd/gomobile: brackets expression not supported on this target2w
> (Does gomobile set C flags (e.g. `-arch arm64`) explicitly?)
I believe it does, see https://github.com/golang/mobile/blob/e6ae53a27f4fd7cfa2943f2ae47b96cba8eb01c9/cmd/gomobile/env.go#L170-L172.
…dmitshur commented on cmd/link: panic: runtime error: slice bounds out of range [::1751306] with length 1048576 [1.15 backport]2w
Thanks for the request and rationale.
@thanm Is Go 1.14 okay, or does it need a fix for this problem too? Our backport policy is to either fix the bug in all supported Go versions, or none (if it'…dmitshur commented on net/http: net/http's TestNoSniffExpectRequestBody_h2 stops passing after x/net/http2 change in CL 253259 [1.15 backport]2w
We have not backported CL 253259 yet. Do you mean that we may do that as part of backport requests #42539 and #42586? If so, please close this and add a comment there. It should be easier to track th…dmitshur commented on golang.org/x/mobile/cmd/gomobile: gomobile build on simple program returns "ld: error: duplicate symbol: x_cgo_inittls" [1.15 backport]2w
The rationale sounds good. Approving (for 1.15 and 1.14 both).dmitshur commented on cmd/go: running `go generate` with go tool with _same_ GOROOT fails2w
Could it be that you're running into #42563 and `/Users/furkan/go/src/goroot/bin` isn't in your $PATH?dmitshur commented on cmd/go: running `go generate` with go tool with _same_ GOROOT fails2w
I see you mentioned #32724, but how is this issue different from that one? I see the title is different, but the steps in "What did you do?" seem to be the same.
Also, what does `which go` print?dmitshur commented on embed: FS root directory is always the package directory, while os.DirFS may have another root2w
It seems to me that `embed.FS` and `os.DirFS` are working as intended, you will need to arrange your code to either handle different roots, or have the same root by running your program with `./root …dmitshur commented on golang.org/x/build/cmd/release: darwin/arm64 installer prompts for installing Rosetta 22w
Thanks.
We should fix this in time for the next pre-release of Go 1.16. If you'd like, you can wait until then, but you certainly don't have to. This issue affects only the installer, the actual Go …dmitshur commented on cmd/go: don't make "build constraints exclude all Go files" a fatal error for go test2w
> Unfortunately, one of the packages is windows-only. `go test ./...` dies immediately
If that package is windows-only, it wouldn't be picked up by the `./...` pattern. Maybe it's missing `// +bui…dmitshur commented on golang.org/x/mobile/cmd/gomobile: brackets expression not supported on this target2w
Is this problem reproducible even with a small iOS project? If so, can you please share a complete sequence of steps to trigger the problem, and include the full output? (If it's large, you can paste…dmitshur commented on golang.org/x/tools/go/ast/astutil: DeleteImport leaves behind inline comments2w
This behavior doesn't reproduce for me, see https://play.golang.org/p/Ih5e7bjhbNp.
Did you provide the `*token.FileSet` parameter to `astutil.DeleteImport`?
If this problem still happens for yo…dmitshur commented on golang.org/x/build/cmd/release: darwin/arm64 installer prompts for installing Rosetta 22w
The problem may be that we're not including a `hostArchitectures` property in the installer Distribution options:
```
$ pkgutil --expand go1.16beta1.darwin-arm64.pkg out
$ cat out/Distribution |…dmitshur commented on : Installation asks for installing Rosetta 22w
Thanks for reporting. Perhaps there's some configuration in the installer causing macOS to think Rosetta will be needed, when that shouldn't be the case. We'll take a look.
After installing, does …dmitshur opened a change github.com/aaronpk/indielogin.com: set grant_type=authorization_code in authz code request3w
In the latest 20201126 IndieAuth specification version, it has been
clarified that grant_type is a mandatory parameter that must be set
to authorization_code¹ when redeeming the authorization code…dmitshur pushed to
patch-1 in github.com/dmitshur/indielogin.com3wset grant_type=authorization_code in authz code requestdmitshur forked in github.com/aaronpk/indielogin.com3w
dmitshur commented on github.com/aaronpk/indielogin.com: Add grant_type3w
@Zegnat Perhaps that code isn't being used. I think the relevant code path is here:
https://github.com/aaronpk/indielogin.com/blob/8183508453e2bdc1dd8395f4aa01f9a88bee29cb/app/Provider/IndieAuth.p…dmitshur opened an issue api: audit for Go 1.16 go1.16.txt3w
next.txt was copied to go1.16.txt in [CL 276454](https://golang.org/cl/276454) (with a followup in [CL 278992](https://golang.org/cl/278992)).
This is a tracking issue for doing an audit of API ad…dmitshur commented on ios/arm64 executable: must specify a minimum supported OS version.3w
@eliasnaur Thanks. I've edited my comment above to clarify it's specifically about gomobile's `build` subcommand.