Activity
Yesterday
dmitshur reviewed +2 on golang.org/x/build/main.star: grant tricium permissions18h
Thanks.dmitshur commented on golang.org/x/build/cmd/dl2mod: add command to convert go.dev/dl archives to modules20h
Sounds good. I expect it'll be easiest for us to update release docs to have the release coordinator take care of it during the transition, but we'll know to explore other options if desired. Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/dl2mod: add command to convert go.dev/dl archives to modules20h
Thanks.
(style nit) s/dvlist/dvList/ perhaps per https://go.dev/s/style#mixed-caps. (Assuming 'dv' is an acronym for Download Version.)
(minor) PS 2 added a skip to should for ".src." filenames. So…dmitshur commented on golang.org/x/build/cmd/releaseschedule: basic doc and README.md22h
Thanks.dmitshur commented on golang.org/x/build/go.mod: update x/net and x/image23h
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: add support for module form of Go distributions1d
Thanks.
Something that I've found to work well when implementing the module proxy protocol is to avoid the temptation of making its URL appealing to humans, and rather make it more like an API URL. …This Week
dmitshur starred honnef.co/go/gotraceui1d
dmitshur commented on golang.org/x/build/main.star: add header to Go project consoles and adjust console names1d
(1 comment)
I'm not sure whether it matters by now, but at least some time ago we sorta tried to intentionally migrate away using the term "subrepos", because it was a Mercurial-specific term and ma…dmitshur reviewed +2 on golang.org/x/build/main.star: add header to Go project consoles and adjust console names1d
Thanks.
Typo, d↔i.
What do you think about using its shortlink, https://go.dev/s/release (I know it means an extra redirect)?
Similarly here, https://go.dev/wiki.
Just a minor side idea: if loo…dmitshur reviewed +2 on golang.org/x/build/main.star: allow task accounts to spawn buildbucket builds1d
Thanks.dmitshur commented on golang.org/x/build/env/corellium/ios: special case "--print-prog-name=ar" in clang wrapper1d
This should be fixed by CL 480655. Restarting.
(nit) Note that this "c/go/+/" part can be deleted to make the URL shorter while still having it point to the same CL.dmitshur reviewed +2 on cmd/dist: mark wasip1/wasm port as broken1d
This change is certainly safe and okay to do. Thanks.
Usually when a port is being added, it doesn't need to be added to broken port list because it's only added to 'cgoEnabled' (and in turn shows u…dmitshur commented on security: include CVE IDs in pre-announcements1d
This was implemented earlier, and exercised for the first time today! 🎉
https://groups.google.com/g/golang-announce/c/71Wg3N0IZk0
@rolandshoemaker Okay to close this issue or was there somet…dmitshur reviewed +2 on golang.org/x/build/main.star: add consoles for subrepos ordered by main repo commits1d
dmitshur reviewed +2 on golang.org/x/build/recipes/recipes: fix tricium checkout url1d
Thanks.dmitshur commented on golang.org/x/tools/diff: a package for computing text differences2d
See also [`internal/diff`](https://pkg.go.dev/internal/diff), an internal "anchored diff" implementation in the main repo. (Adding a mention here for completeness.)
Edit: I see this is already men…dmitshur commented on run.bash: drop 'export GOROOT' and its obsolete comment2d
Thanks.dmitshur commented on run.bash: drop 'export GOROOT' and its obsolete comment2d
(1 comment)
I think the only effect of the 'export GOROOT' line is to make the value of GOROOT set by the previous line ('eval $(../bin/go tool dist env)') visible to child processes, rather than ju…dmitshur reviewed +2 on golang.org/x/build/main.star: add consoles for subrepos ordered by main repo commits2d
Thanks. See previous comment, otherwise not spotting problems, and anyway that might be easier after we see this on the dashboard.dmitshur commented on golang.org/x/build/main.star: add consoles for subrepos ordered by main repo commits2d
(1 comment)
This isn't a subrepo, is the change here intentional too?dmitshur reviewed +2 on golang.org/x/build/main.star: trigger subrepo builders from main repo builder2d
Thanks. (Good catch in PS 3.)dmitshur commented on run.bash: drop 'export GOROOT' and its obsolete comment2d
(1 comment)
I'll probably want to confirm even harder, but off the top of my head, I think it would be unsetting it if there was a '=' after the env var name. Without the '=', it's exporting the cur…dmitshur commented on run.bash: drop 'export GOROOT' and its obsolete comment2d
TRY=longtest, windowsdmitshur opened a change run.bash: drop 'export GOROOT' and its obsolete comment2d
The comment justifies exporting GOROOT by saying the api test needs it,
which was relevant back when it was added in CL 99870043, but isn't true
by now.
As of Go 1.8, GOPATH can be unset (https://go…dmitshur reviewed +2 on golang.org/x/playground/deploy: fail the goprev deployment if latestgo fails2d
Thanks.dmitshur reviewed +2 on golang.org/x/playground/cmd/latestgo: restore the -prev flag2d
PS 2 also looks good, thanks. See note about x/build version.
Since PS 2 starts to use version.ParseTag, you'll want to update x/build to include CL 479556 when it lands (unfortunately not yet, but …dmitshur reviewed +2 on golang.org/x/playground/cmd/latestgo: restore the -prev flag2d
Thanks.
s/man/maj/dmitshur commented on golang.org/x/playground: 1.19 is missing2d
Thanks for reporting.
It might be because [CL 467955](https://go.dev/cl/467955) (CC @petergeorgas) removed the `-prev` flag, which is still used, and https://goprevplay.golang.org/version ends up …dmitshur commented on golang.org/x/build/main.star: enable Buildbucket:ResultDB integration3d
(1 comment)
I considered that field. An example I found looked like this:
```
test_presentation = resultdb.test_presentation(
column_keys = ["v.gpu"],
grouping_keys = ["status", "v.test_sui…dmitshur opened a change golang.org/x/build/main.star: enable Buildbucket:ResultDB integration3d
We want to enable the "Test Results" tab our build pages
and display test results in a structured manner there.dmitshur starred github.com/Microsoft/go-winio5d
Last Week
dmitshur closed a change golang.org/x/oauth2/...: fix typo1w
dmitshur commented on golang.org/x/oauth2/...: fix typo1w
Submitted via [CL 459695](https://go.dev/cl/459695) (commit 86850e07236e6a4f59e810fb16229fdebb07a119).dmitshur commented on cmd/dist: add json output support1w
I used CL 478155 to get a representative (not fully complete) all.bash run with `go test -json` output, and converted it to HTML to more easily visualize the data. I intentionally added 2 failing tes…dmitshur opened an issue cmd/go: duplicate "pass" action from TestFlag test of testing package1w
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel go1.21-ac881545ce Tue Mar 21 12:44:04 2023 -0400 darwin/arm64
</pre>
### Does this issue reproduce wi…dmitshur commented on github.com/shurcooL/githubv4/feat: create automation for schema updates1w
Thanks for suggesting and implementing this, and sorry I didn't get a chance to comment sooner. I've had the idea of doing something like this for some time and I've seen it successfully used in http…dmitshur closed an issue golang.org/x/build/cmd/gerritbot: Gerrit comment content should be posted to GitHub PRs1w
dmitshur commented on golang.org/x/build/cmd/gerritbot: Gerrit comment content should be posted to GitHub PRs1w
This is #38689.dmitshur commented on github: branch protections1w
We can do all golang.org/x GitHub mirrors too (and the special case without x, golang.org/dl). At least I can't think of a downside to treating them the same as the main Go repo mirror for the purpos…dmitshur starred github.com/daafu/sokoban1w
Earlier
dmitshur closed an issue golang.org/x/website: broken link to system requirements2w
Fixed by [CL 469975](https://go.dev/cl/469975). (CC @jamalc.)dmitshur commented on github.com/go-gl/glfw: Build fail on macOS ventura 13.2.12w
It does seem likely that there was some incompatibility in your local build environment setup. If the problem doesn't reproduce with a functional latest version of Xcode, I don't think there's anythi…dmitshur reviewed +2 on github.com/sourcegraph/go-diff: remove unnecessary dependencies2w
Thanks.dmitshur commented on robpike.io/ivy: Ivy iOS App Broken as of iOS 16 +2w
Issue #115 is related.dmitshur pushed to
master in github.com/shurcooL/githubv43w
dmitshur opened an issue golang.org/x/build: linux-amd64-perf continuously failing on x/tools with "error committing perfdata file: upload failed: 500 Internal Server Error no valid benchmark lines found"3w
Looking at https://build.golang.org/?repo=golang.org%2fx%2ftools, the linux-amd64-perf builder column has some "ok" rows but most are empty.
At https://farmer.golang.org/#completed right now there…dmitshur commented on golang.org/x/build/cmd/gerritbot: didn't close a PR that was submitted3w
Another case affected PR #58779. It was submitted on Gerrit 5 days ago and the PR wasn't marked as closed.
It once again got stuck on `Changes for PR golang/go#58779 have yet to be mirrored in the…dmitshur closed a change io/ioutil: add doc links for deprecated function3w
dmitshur commented on io/ioutil: add doc links for deprecated function3w
Closing because this PR has been merged via [CL 471915](https://go.dev/cl/471915) as commit dfe4591fc4d2d66da7740de18b32761e7a20691c.
(Normally `gerritbot` does this, but sometimes it needs help d…dmitshur opened an issue cmd/dist: "unexpected fault address 0x200732d00" during bootstrap4w
Starting with [CL 462035](https://go.dev/cl/462035) (CC @randall77), the aix-ppc64 builder is failing during bootstrap:
```
Building Go cmd/dist using /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go…dmitshur opened an issue cmd/gopherbot: move "ping-early-issues" task to relui4w
Pinging issues with "early-in-cycle" is a task that we do once every 6 months, after the development of a new major Go version starts. Right now it's implemented as a task in `gopherbot` that needs t…dmitshur closed an issue access: gerrit approvers4w
dmitshur commented on access: gerrit approvers4w
Hello,
Thanks for your contributions and making this access request. The "approvers" access permits reviewing and submitting CLs across the entire Go project as documented https://go.dev/wiki/Gerr…dmitshur closed an issue cmd/compile: incorrect type set intersection computation [1.18 backport]4w
dmitshur closed a change golang.org/x/tour: Update basics.article4w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur closed a change golang.org/x/tour/...: fix wrong arguments order for image.Rect4w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur commented on golang.org/x/tour/Resolves golang/tour#1062: Add explanation of semicolons to if-else slide4w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur closed a change golang.org/x/tour: Clarify founding date4w
dmitshur commented on golang.org/x/tour: Clarify founding date4w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle4w
[CL 467297](https://go.dev/cl/467297) and a few others took care of this for early in cycle.
Removing that label to revisit this at the start of freeze.dmitshur commented on cmd/go: replace use of "main module" in help docs & error messages 4w
CC @bcmills, @matloob.dmitshur commented on golang.org/x/text: building as a plugin failure on darwin/arm641mo
CC @mpvl, @golang/runtime.dmitshur commented on internal/fuzz: go test -fuzz= outputs failing input which contains wrong datatypes1mo
CC @golang/fuzzing.dmitshur commented on golang.org/x/crypto: error parsing even large ASN.1 identifiers1mo
CC @golang/security.dmitshur closed an issue crypto/x509: TestSystemVerify consistently failing1mo
dmitshur commented on crypto/x509: TestSystemVerify consistently failing1mo
Thanks watchflakes, but commit 600d37 is before the fix in commit [21e451e](https://go.googlesource.com/go/+/21e451ec446724c9f3f124139e07d88ff812a1bc).dmitshur commented on slices: Delete is an attractive nuisance1mo
CC @ianlancetaylor, @eliben.dmitshur commented on cmd/compile: bad DWARF location for variable1mo
CC @golang/compiler.dmitshur commented on golang.org/x/tools/go/pointer: internal error in pointer analysis: node has no enclosing object1mo
CC @timothy-king, @alandonovan.dmitshur commented on plugin: /usr/bin/ld: failed to set dynamic section sizes: bad value1mo
CC @golang/runtime.dmitshur commented on Go 2: start using semantic versions for Go releases1mo
At some point between filing this proposal and now, I've realized that the "v" part in a string like "v1.2.3" is not a part of SemVer 2.0.0. See https://semver.org/spec/v2.0.0.html#is-v123-a-semantic…dmitshur commented on crypto/x509: TestSystemVerify consistently failing [1.19 backport]1mo
Confirmed that the problem reproduces on an updated Windows 11 device, and the patch fixes it.dmitshur commented on crypto/x509: TestSystemVerify consistently failing [1.19 backport]1mo
This test is not failing on Windows builders on release-branch.go1.19. Either there's no problem (i.e., TestSystemVerify was modified in a way that needed the fix only in Go 1.20) or perhaps it's bec…dmitshur opened an issue crypto/x509: TestSystemVerify has started to fail on darwin-amd64-10_151mo
As of [CL 472295](https://go.dev/cl/472295) (which fixed #58791), `TestSystemVerify` is failing on darwin-amd64-10_15 (only) with:
```
--- FAIL: TestIssue51759 (0.32s)
--- FAIL: TestIssue517…dmitshur commented on cmd/compile: ICE on method value involving imported anonymous interface [1.20 backport]1mo
@mdempsky Please add a short backport rationale to this backport issue (see https://go.dev/wiki/MinorReleases; "The issue should include a link to the original issue and a short rationale about why t…dmitshur commented on crypto/x509: TestSystemVerify consistently failing1mo
@gopherbot Please backport at minimum the Windows text fix aspect of this issue.
This is needed to fix failing tests on release branches.dmitshur commented on crypto/x509: Incorrect documentation for `ParsePKCS8PrivateKey` [1.20 backport]1mo
No backport needed for Go 1.19 because this issue isn't present in that version.dmitshur commented on github.com/shurcooL/home/internal/exp/service/activity/github: walkSegMail can fail with EOF1mo
This was observed again on 2023-02-28 19:38:
```
GitHub Activity Service: ok
Gerrit Activity Service: walkSegMail(gerrit.fileSeg{file:"/2023-03.reclog", skip:0, size:4096}): truncated record at …dmitshur commented on crypto/x509: Certificate.Verify rejects self-signed leaf1mo
CC @golang/security.dmitshur commented on golang.org/x/build: macOS PKG installer shows misleading error when installing for the wrong architecture 1mo
Thanks for reporting.
We're using Xcode tooling to create a fairly standard macOS installer (see [here](https://cs.opensource.google/go/x/build/+/master:internal/task/buildrelease.go;l=298;drc=f03…dmitshur commented on golang.org/x/build/cmd/runqemubuildlet: qemu failed to find an available port: address already in use1mo
CC @golang/release.dmitshur reopened an issue cmd/link: linker fails on linux/amd64 when gcc's lto options are used1mo
dmitshur reopened an issue cmd/link: linker fails on linux/amd64 when gcc's annobin plugin is used1mo
dmitshur commented on crypto/x509: Incorrect documentation for `ParsePKCS8PrivateKey`1mo
CC @golang/security.dmitshur commented on encoding/json: json.Decoder Token method is two times slow than Decode 1mo
CC @dsnet, @bradfitz, @mvdan.dmitshur commented on hash/crc32: data leaks to heap1mo
CC @golang/security.dmitshur commented on golang.org/x/net/idna: VerifyDNSLength is not rejecting empty labels1mo
CC @neild, @ianlancetaylor.dmitshur opened an issue golang.org/x/build: darwin-amd64-10_15 builder missing, no builds for some time1mo
Currently at https://farmer.golang.org/#pools:
```
host-darwin-amd64-10_15-aws: 0/0 (2 missing)
```
And there are no builds on the last 30 commits in the main Go repo. Although the most recen…dmitshur commented on crypto/x509: Certificate.Verify does not consistently return UnknownAuthorityError1mo
Thanks for catching and reporting this.
CC @golang/security.dmitshur commented on cmd/go: TestDocsUpToDate is incompatible with android emu builder environment1mo
The problem seems to be that `testGo` is only set when `testenv.HasGoBuild()` reports positively, but when GOOS=android it returns false. The test currently doesn't check `testenv.HasGoBuild()` nor `…dmitshur commented on misc/cgo/test: link failure with atomics on arm641mo
CC @ianlancetaylor, @cherrymui.dmitshur commented on debug/macho: over allocation in NewFile1mo
CC @golang/compiler, @ianlancetaylor.dmitshur commented on debug/buildinfo: over allocation in Read through xcoff.NewFile1mo
CC @golang/compiler, @ianlancetaylor.dmitshur commented on runtime: malloc instancing generic function seems to deadlock(ish) during benchmark1mo
CC @golang/runtime.dmitshur commented on golang.org/x/tools/go/packages: "files=" queries don't seem to work1mo
CC @matloob, @golang/tools-team.dmitshur opened an issue cmd/go: TestDocsUpToDate is incompatible with android emu builder environment1mo
[CL 468636](https://go.dev/cl/468636) (CC @bcmils) recently improved TestDocsUpToDate to invoke `go help documentation` directly, without the mkalldocs.sh script, but it's not able to run at least in…dmitshur commented on github.com/go-gl/glfw: Old module name in README installation instructions1mo
These are two different modules.
Module `github.com/go-gl/glfw/v3.3/glfw` contains v3.3.
Module `github.com/go-gl/glfw` contains older versions: v3.0, v3.1, and v3.2.dmitshur commented on rsc.io/2fa: How to generate codes after moving disk to the new computer?1mo
2fa documentation states:
> The keychain is stored unencrypted in the text file `$HOME/.2fa`.dmitshur commented on : use a zero for third digit for major release, such as 'go1.23.0'1mo
At least some code that parses Go versions and/or tags may have code that explicitly handles ".0" as a special case, and that would to change (for example, see [here](https://cs.opensource.google/go/…dmitshur deleted branch in github.com/gopherjs/snippet-store1mo
master