Activity
Today
dmitshur commented on golang.org/x/build/cmd/golangbuild: update code search link56m
This change is ready for review.dmitshur opened a change golang.org/x/build/cmd/golangbuild: update code search link58m
The previous link is shorter, but it's no longer indexed. Point to the
new view to golangbuild source code where search indexing is available.dmitshur closed an issue build: build failure on x_vulndb-gotip-linux-amd64-race1h
dmitshur closed an issue build: build failure on x_net-gotip-linux-arm64_debian131h
Yesterday
dmitshur reviewed +2 on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions22h
Thanks.
I'll note that it's somewhat unclear how exactly values would be represented in some of the fields because they're not documented: for example, `Changelists []string` might be a slice of URL…dmitshur commented on go/types: [release-branch.go1.26] handle unconstrained type parameters correctly in a few places1d
The release branch is currently frozen until the [Go 1.26.2 release](https://groups.google.com/g/golang-announce/c/2UyQAnUQKwc) is complete, added a temporary Hold+1.dmitshur closed an issue build: build failure on x_net-gotip-linux-arm64_debian131d
dmitshur reviewed +2 on golang.org/x/website/_content: in managing dependencies doc '-u' flag and mention '-modfile'1d
Thanks.dmitshur commented on golang.org/x/build/cmd/relui: update to ltbsky v0.4.21d
Thanks.dmitshur commented on github.com/go-gl/glow: Add support for OpenGLES 3.21d
This generally looks reasonable, thanks for working on it.
Have you had a chance to try generating the gles bindings afterwards, and does the generated output seem okay? I think it'd be a matter o…dmitshur reviewed +2 on golang.org/x/website/ref/mod: add more documentation for 'go tool' features.1d
Thanks. Minor comments.
Nit, https://go.dev/doc/contribute#first_line suggests leaving out the period; the period is a part of the "This change modifies Go to _____." sentence being completed.
```s…This Week
dmitshur reviewed +2 on image/jpeg: reject RGB and non-standard chroma subsampling1d
Thanks.
```suggestion
add support for non-standard chroma subsampling ratios" (CL 738280).
```
So that it's easier to get to if desired. Gerrit linkifies such CL mentions, and it's also possible to…Last Week
dmitshur starred znkr.io/diff3d
dmitshur commented on test/codegen: fix ppc64x rldicl bit test3d
It was another test failing, rangegen.go. It might've just been unlucky, it happens fairly often based on its history: https://ci.chromium.org/ui/test/golang/cmd%2Finternal%2Ftestdir%3A6_10.Test%2Fra…dmitshur opened a change golang.org/x/build/cmd/relui: update to ltbsky v0.4.23d
Pull in https://github.com/fflewddur/ltbsky/pull/5.dmitshur commented on simd/archsimd: Load*SlicePart panics with "checkptr: converted pointer straddles multiple allocations"3d
CC @golang/compiler.dmitshur commented on cmd/fix: `go fix` inline producing conflicting var names3d
Thanks for the report.
CC @golang/tools-team.dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip3d
(1 comment)
This isn't right: the known issue should keep this an optional security trybot. Done in PS 2.dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip3d
Thanks.dmitshur commented on cmd/internal/testdir:1_10: Test/codegen/bits.go failures [consistent failure]3d
This consistent failure on ppc64 and loong64 is due to https://go-review.googlesource.com/c/go/+/750200/comments/58cbcdce_f20cfeba.
CC @Jorropo, @golang/ppc64, @golang/loong64.dmitshur commented on crypto: disallow RegisterHash with hash value 03d
(1 comment)
FWIW since its value is actually 20, I understand this means "just use its value by picking a value that's higher than maxHash by some reasonable margin so that it'll be some time before…dmitshur reviewed +2 on cmd/go: specify full path to go command when running go tool covdata3d
Thanks.
Thanks for the clarification.dmitshur commented on crypto: disallow RegisterHash with hash value 03d
(1 comment)
Did something go wrong with your "gofmt-on-save"?dmitshur commented on cmd/go: specify full path to go command when running go tool covdata4d
(1 comment)
Or, maybe the problem being fixed is that once someone with an old toolchain upgrades _to_ 1.25.x or 1.26.x (via go.dev/doc/toolchain), this change (once backported to 1.25.x and 1.26.x)…dmitshur commented on cmd/go: specify full path to go command when running go tool covdata4d
(1 comment)
A question about this; I'm not sure I understood this sequence properly. In the issue comment you described the problem as affecting Go 1.24 and older toolchains upgrading to Go 1.25+. B…dmitshur opened a change golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip4d
Do keep a known issue for Go 1.26 and 1.25 release branches since
it doesn't work there yet (but may work soon).
For golang/go#74985.dmitshur reviewed +2 on golang.org/x/build/main.star: don't run newinliner builder by default in presubmit4d
Thanks.dmitshur reviewed +2 on debug/buildinfo: remove macho/elf DataStart fallback code4d
Thanks.
I think this is right. You can give some more time for another review since Cherry is more familiar with this code, up to you.dmitshur commented on cmd/link: use bfd ld 2.41+ on linux/arm64 instead of gold4d
net/smtp failures are likely #77504, so rebasing should resolve them.dmitshur commented on cmd/link: stop requiring gold on arm64 when GNU ld is fixed4d
@gopherbot Please consider backporting this issue (fixed by [CL 740480](https://go.dev/cl/740480) with a potential followup in [CL 747660](https://go.dev/cl/747660)). The linux/arm64 builder with Deb…dmitshur reviewed +2 on golang.org/x/build/main.star: remove known issue of simd builders4d
Thanks.
Sounds good. (It's possible to follow up in the unlikely case it does need attention.) Thanks for taking release branch into consideration when removing the known issue.dmitshur opened a change cmd/link: [release-branch.go1.25] use bfd ld 2.36+ on linux/arm64 instead of gold4d
The bfd linker has been fixed for a while. In the mean time gold got
deprecated and has stopped receiving new features. Add runtime version
checking and only use gold, if bfd ld 2.35 and lower is det…dmitshur commented on golang.org/x/build: add Debian Trixie builders4d
That problem was tracked in #22040, and [CL 740480](https://go.dev/cl/740480) resolved it. The [linux-arm64_debian13](https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-arm64_debian13) is no…dmitshur commented on runtime/race: TestOutput failures4d
A race reported during this test's execution. The test has otherwise been passing without reported races.
CC @golang/runtime.dmitshur commented on internal/godebugs: TestAll failures4d
It looks like the internal/godebugs package tests often come quite close to the 6 minute timeout, e.g., past runs have taken 325.885s and similar. And in this case it went over the time limit, causin…dmitshur commented on cmd/go: test failure due to unexpected telemetry files left behind in temporary directory4d
This looks similar to #55260, but in this case it is some telemetry files being left behind. So far only happened once on a linux-ppc64le builder.
CC @golang/command-line.dmitshur fixed an issue cmd/go: test failure due to unexpected vcstest files left behind in temporary directory4d
There haven't been any matches since 2023, so perhaps this is fixed by various cmd/go test refactoring. There is a new instance in #78397 but it's related to telemetry files rather than vcstest files…dmitshur commented on cmd/go: test failure due to unexpected vcstest files left behind in temporary directory4d
There haven't been any matches since 2023, so perhaps this is fixed by various cmd/go test refactoring. There is a new instance in #78397 but it's related to telemetry files rather than vcstest files…dmitshur commented on golang.org/x/sys/windows: GetNamedSecurityInfo crashes when GetNamedSecurityInfoW succeeds with NULL SECURITY_DESCRIPTOR4d
CC @golang/windows.dmitshur commented on cmd/compile: register allocation differs based on tail loop presence, affects performance4d
CC @golang/compiler.dmitshur commented on syscall: TestPidFD failures4d
This test timed out running for 323 seconds.
From looking at this [test history](https://ci.chromium.org/ui/test/golang/syscall.TestPidFD), it's almost always passing and usually takes something lik…dmitshur commented on cmd/compile: fallthrough prevents the elimination of some bounds checks4d
CC @golang/compiler.dmitshur commented on net/http: how to utilize sendfile() when send request via NewRequestWithContext4d
If this is a question, please see http://go.dev/wiki/Questions for places that are better suited for asking questions. The Go issue tracker is used for bugs, feature requests, optimization issues.
D…dmitshur commented on cmd/compile: channel operations require but do not use a type dictionary4d
CC @golang/compiler.dmitshur commented on cmd/compile: loop induction with `*` and `<<` induction operators4d
CC @golang/compiler.dmitshur commented on cmd/compile: closures in generic functions capture type dictionaries unconditionally4d
CC @golang/compiler.dmitshur commented on archive/zip: provide way to limit number of entries in an archive4d
CC @dsnet, @bradfitz.dmitshur commented on gccgo: internal compiler error in flatten_append on undefined variable in slice of append argument4d
CC @ianlancetaylor, @thanm, @cherrymui.dmitshur commented on gccgo: Compiler Segfault on non-integer argument to make of channel4d
CC @ianlancetaylor, @thanm, @cherrymui.dmitshur commented on cmd/compile: constant-string doubling plus []rune conversion can exhaust memory4d
CC @golang/compiler.dmitshur reviewed +2 on golang.org/x/build/main.star: add linux-amd64 SIMD builders4d
Thanks.dmitshur commented on govulncheck-action: Release current master to have tagged version utilizing the full commit SHAs of transitive actions4d
CC @golang/vulndb, @catzkorn, @lufia.dmitshur commented on os: running "go test os -short" command fails4d
CC @golang/windows, @ianlancetaylor.dmitshur commented on os/user: GroupIds fails when a member of more than 256 groups on macOS4d
CC @golang/darwin, @bradfitz, @kevinburke.dmitshur commented on golang.org/x/build/cmd/watchflakes: stop applying NeedsInvestigation label4d
This change is deployed now.dmitshur commented on build: build failure on x_vulndb-gotip-linux-amd64-race4d
Something went wrong with the builder infrastructure in this instance. The x/vulndb tests passed, but the task log failed at the end with:
```
RPC failed permanently: rpc error: code = DeadlineExcee…dmitshur closed a change math/big: [release-branch.go1.26] Improve performance of modular exponentiation, particularly for medium-sized inputs.4d
Release branches are used for backport CLs (https://go.dev/wiki/MinorReleases). Closing in favor of CL 751120, which is the same change that targets the main development branch.dmitshur closed a change net/url: [release-branch.go1.26] permit colons in the host subcomponent of non-http/https URLs4d
Replaced with CL 759662.dmitshur commented on net/url: [release-branch.go1.26] permit colons in the host subcomponent of non-http/https URLs4d
This change is ready for review.dmitshur commented on runtime/race: [release-branch.go1.26] apply LLVM zero-initialization fix4d
It seems ready now, so dropping hold.dmitshur commented on golang.org/x/build/main.star: remove known issue for darwin-amd64_154d
Thanks.dmitshur opened a change golang.org/x/build/main.star: remove known issue for darwin-amd64_154d
A builder is added and it's working. More instances may get added later.
Fixes golang/go#77997.dmitshur fixed an issue golang.org/x/build: add darwin/arm64 builders with macOS 26 (macOS Tahoe)4d
The work needed to add darwin/amd64 builders with macOS 26 is somewhat different, so factored that out into its own tracking issue #78388. Retitled this to be about darwin/arm64 only, which is done. …dmitshur opened an issue golang.org/x/build: darwin/amd64 builders with macOS 26 (macOS Tahoe)4d
This is a tracking issue for darwin/amd64 builders with macOS 26 (macOS Tahoe). (We already have darwin/arm64 builders with this macOS version as of issue #76798.)
This is the very last macOS versio…dmitshur reviewed +2 on golang.org/x/build/main.star: add go-private image mirror5d
Thanks.dmitshur commented on runtime/race: [release-branch.go1.26] apply LLVM zero-initialization fix5d
Hold for CL 758160 readiness. (To make tracking easier.)dmitshur opened a change golang.org/x/build/main.star: remove known issue for linux-amd64-longtest-git2.24.05d
The builder has been added and it's working.
For golang/go#26746.
For golang/go#77284.
Fixes golang/go#26653.dmitshur commented on crypto/internal/fips140/drbg: unnecessary linear memory increase on Wasm with Go 1.265d
CC @golang/wasm.dmitshur commented on internal/trace: preallocate pcs array to correct size5d
Thanks.dmitshur commented on net/url: url.Parse in 1.26 breaks mongodb connection string parsing with multiple hosts [1.26 backport]5d
@neild On the main branch, CL 751360 added the mongo-specific implementation and a test, and CL 758900 generalized it for non-http/https and kept the test. The Go 1.26 backport CL 758901 adds the new…dmitshur commented on golang.org/x/build: add a builder with oldest git supported by cmd/go to catch regressions5d
Now that #78323 is resolved, the builder is passing [at tip](https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-amd64-longtest-git2.24.0).
It's also passing on [release-branch.go1.26](https…dmitshur commented on cmd/go: [release-branch.go1.25] tests: rename git-min-vers->git-sha2565d
This change is ready for review.dmitshur commented on cmd/go: [release-branch.go1.25] skip git sha256 tests if git < 2.295d
This change is ready for review.dmitshur commented on cmd/go/internal/vcweb/vcstest: TestScripts/git/gitrepo-sha256.txt failures [consistent failure]5d
@gopherbot Please consider this for backport to Go 1.25. (Go 1.26 already has these fixes, so nothing to backport there.) These are test-only fixes needed to make tests pass with the oldest suppor…dmitshur opened a change cmd/go: [release-branch.go1.25] tests: rename git-min-vers->git-sha2565d
Follow-up cleanup on go.dev/cl/698835. Clarify the tests by replacing
git-min-vers with a more-purposeful git-sha256 verb in the cmd tests.dmitshur opened a change cmd/go: [release-branch.go1.25] skip git sha256 tests if git < 2.295d
Fix test building on older Ubuntu LTS releases (that are still
supported). Git SHA256 support was only included in 2.29, which came out
in 2021. Check the output of `git version` and skip these tests…dmitshur reviewed +2 on cmd/dist: try to use jj commit info for devel version5d
This addition seems reasonable since this code path affects Go developers only. Note that it's untested by builders, so it'll be up to whoever uses it locally to maintain. Thanks.
Fixes #nnn? This s…dmitshur commented on golang.org/x/build/main.star: add x/website presubmit builder for all of GOROOT/doc5d
Thanks.dmitshur opened an issue cmd/compile: multiple "internal compiler error" issues5d
There have been a number of "internal compiler error" issues reported recently, each covering specific edge cases that were uncovered. This is an umbrella issue to make it easier to track them.
CC @…dmitshur commented on cmd/go: do not forward GOAUTH-derived credential headers across cross-host redirects5d
From triage, it sounds like the redirect happens by an initially trusted source, and not forwarding GOAUTH may cause it to not work for the target. So there may not be any behavior change to do here.dmitshur commented on cmd/compile: internal compiler error: map elem too big 21474836485d
CC @golang/compiler.dmitshur commented on cmd/link: TestMachOBuildVersion failures5d
From triage, maybe this test doesn't need to run on GOARCH=ppc64le as well.
CC @golang/ppc64.dmitshur commented on cmd/link: peCreateExportFile generates invalid .def file when output name has trailing dot (c-shared on Windows)6d
CC @golang/windows.dmitshur commented on syscall: wrong constant used in `WaitStatus.Stopped()` & `WaitStatus.Continued()` comparisons6d
CC @golang/freebsd, @golang/openbsd.dmitshur commented on crypto/tls: Seg Fault In TLS Handshake in RKE6d
Are you able to reproduce this when using either Go 1.26 or 1.25? In the go env output, it looked like the Go toolchain version was 1.22.dmitshur commented on golang.org/x/website/cmd/golangorg: support absolute paths in testTree6d
Thanks.dmitshur commented on golang.org/x/website/cmd/golangorg: include GOROOT/doc files in TestAll checks6d
Thanks.dmitshur commented on golang.org/x/website/cmd/golangorg: catch instances of bad escaping due to template use6d
Thanks.
The 1.26/1.25 (only) builders failing was [expected](https://go-review.googlesource.com/c/website/+/746741/comments/ae57427c_0909aa7c). The backport CLs have just landed, so everything shoul…dmitshur opened a change cmd/compile: [release-branch.go1.26] skip race detector test failure for unsupported VMA6d
For #77799.
For #78219.dmitshur commented on cmd/compile: panic on invalid generic append with type parameter spread [1.26 backport]6d
Need to confirm whether 1.25 backport is also needed, or if this is 1.26-only per https://github.com/golang/go/issues/34536#issuecomment-572188389.dmitshur commented on cmd/compile: panic on invalid generic append with type parameter spread6d
Does the problem also affect Go 1.25? In that case we should also backport to 1.25 per our policy.dmitshur commented on golang.org/x/build/main.star: remove linux-amd64-spectre known issue6d
It passed at tip (https://ci.chromium.org/b/8686347220472067905) and correctly detected a problem intentionally re-introduced in CL 759121, so everything seems working as intended to me.
Thanks.dmitshur commented on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test6d
Thanks.dmitshur reviewed +1 on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test6d
dmitshur opened a change golang.org/x/sys/cpu: add runtime import in cpu_darwin_arm64_other.go6d
It was missed in CL 737260.
For golang/go#43046.dmitshur commented on golang.org/x/sys/cpu: use IsProcessorFeaturePresent to calculate ARM64 on windows6d
(1 comment)
I agree it would be good to update mkwinsyscall to support this use case, and that it can happen later. In the meantime, what do you think about temporarily replacing the need for manual…dmitshur reviewed +1 on cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test6d
dmitshur commented on runtime: memory corruption leading to panic on linux/riscv646d
Thanks for the report. Does this happen only on the linux/riscv64 port specifically, or are you able to reproduce it on other ports too?
CC @golang/riscv64.dmitshur commented on security: fix CVE-2026-338106d
CC @golang/security, @golang/release.dmitshur commented on golang.org/x/build/main.star: set {gc,asm}flags via GO_{GC,TEST_ASM}FLAGS in spectre runmod6d
Thanks.