Today
dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3h
Thank you for the PR and for elaborating on the motivation for wanting this, and how it affects you. It's reasonable to mark the current `sanitized_anchor_name` as v1.0.0. It's very stable and has…
dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3h
Where is this "go" directive documented? What are the consequences of using it? I'd rather avoid adding it until I understand the implications.
dmitshur commented on Move "Recently Installed Updates" s… in github.com/shurcooL/Go-Package-Store3h
> I can extract the useful implementation cleanups from this change Done in 00930cb77276442831a58fe4da42af6a1cb6db2e.
dmitshur pushed to master in github.com/shurcooL/Go-Package-Store3h
21925defcb4ef32b62c34e310f72971b93fc449fassets: Regenerate.
00930cb77276442831a58fe4da42af6a1cb6db2eClean up frontend code, apply minor UI tweaks.
dmitshur deleted branch in github.com/shurcooL/Go-Package-Store4h
recently-updated-on-top
dmitshur commented on Move "Recently Installed Updates" s… in github.com/shurcooL/Go-Package-Store4h
I've evaluated this approach extensively in my local testing over the last few weeks, and did not find it to be an overall improvement. I didn't get used to it, and it kept feeling awkward and strang…
Yesterday
dmitshur commented on generate: Sometimes generates longe… in github.com/ejcx/passgo1d
After reading the [`pc.GeneratePassword`](https://github.com/ejcx/passgo/blob/833999f9aa7e85c20c99a1c3615f0a7f7d5c3429/pc/pc.go#L193-L229) code, I suspect I understand what's happening. It keeps a…
Last Week
dmitshur commented on cmd/go: module-mode import path che… in github.com/golang/go3d
> As of #18660, `go get` in `GOPATH` mode allows any Unicode letter To be more precise, #18660 was about allowing Unicode letters within the "subdir" part of github.com import paths like "github.c…
dmitshur commented on Add ForceAllTypes to Options in github.com/shurcooL/vfsgen1w
Hi @kenshaw, Thank you for the PR and for the detailed rationale for why you want this. Added a thinking label because I'd like to take some time before making a decision here, but let me tell …
dmitshur commented on Read doesn't write to slice. in github.com/shurcooL/vfsgen1w
Hi @kinghunter58, It looks like there might be a bug in your code to read from `f`. The [`io.Reader`](https://godoc.org/io#Reader) interface documentation notes: > Read reads up to len(p) by…
dmitshur pushed to master in github.com/dominikh/go-js-dom1w
dmitshur closed a change in github.com/shurcooL/vfsgen1w
dmitshur pushed to master in github.com/shurcooL/vfsgen1w
dmitshur commented on Add MIT License in github.com/shurcooL/vfsgen1w
Hi @andrewmostello. > I'd like to use vfsgen in our projects Great! > was hoping you could add a license. I've added the MIT license here `vfsgen` is already licensed using the MIT licens…
dmitshur commented on Add include/exclude options in github.com/shurcooL/vfsgen1w
Also, in case you haven't seen it, you should consider https://godoc.org/github.com/shurcooL/httpfs/filter which is a package that offers similar functionality.
dmitshur commented on Add include/exclude options in github.com/shurcooL/vfsgen1w
Hi @rasa, Thank you for the PR, and sorry it took me a while to get back to you. I think users should absolutely have access to this kind of functionality. However, it can be done without needi…
dmitshur commented on x/build: clean download fails in github.com/golang/go1w
@bradfitz I think this is closer to https://github.com/go4org/go4/issues/30, which has been resolved a year ago.
Earlier
dmitshur pushed to master in github.com/shurcooL/go1w
914043390fc61e853638b3b18e1fdc33f01832ecctxhttp: Delete deprecated package.
dmitshur pushed to master in github.com/shurcooL/go1w
63d82a2ec3bb5f06acbf7fd0b63775f184585f2ectxhttp: Delete deprecated package.
dmitshur commented on 2182bb097dc5cacf556f89e4e7d2cfdd96882237.github: don't render a… in github.com/golang/go1w
For consistency with lines 16 and 19.
dmitshur commented on go/doc: example for syscall/js.NewC… in github.com/golang/go1w
I noticed something in [`os/exec`](https://godoc.org/os/exec) package documentation related to this issue. Namely, it includes the following paragraph in the package documentation: > Note that the…
dmitshur commented on cmd/go/internal/modfetch: TestCodeR… in github.com/golang/go1w
Related issue #27692. It's another instance of the cmd/go tests relying on an external live repository.
dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1w
I believe this issue is now fully resolved by [CL 150057](https://golang.org/cl/150057), redeploying golang.org, and @andybons taking measures to prevent future Gerrit CL numbers from overlapping wit…
dmitshur commented on x/build/cmd/coordinator: use cmd/go… in github.com/golang/go1w
Isn't the build cache tied to a specific compiler version? As soon as the compiler changes just a bit, every package would need to be rebuilt. Can you elaborate on how the build cache could be use…
dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go1w
Thanks Brad. It looks like it has made good progress, the [build dashboard](https://build.golang.org/) is mostly filled in by now. Closing as fixed.
dmitshur commented on Remove sourcegraph.com vanity impor… in github.com/sourcegraph/go-diff2w
> My thinking was that the long term goal here would be: > > 1. Remove vanity imports for all github.com/sourcegraph packages > 2. Eventually remove support for vanity import paths in Sourcegraph its…
dmitshur commented on GOARCH=arm support. in github.com/go-gl/gl2w
Most of the work would be figuring out why it doesn't work, and what needs to be done to make it work. It's hard to estimate it other by starting to do it and seeing how it goes. I think most ARM-ba…
dmitshur deleted branch in github.com/shurcooL/home2w
optimize-Rediscover
dmitshur commented on [Windows] A tutorial to install gcc… in github.com/go-gl/glfw2w
Given how often this comes up, and how difficult it is to figure out on one's own, I agree it would be helpful to say something. We shouldn't maintain such tutorials ourselves, but linking to some r…
dmitshur commented on transport: use golang.org/x/net/con… in github.com/dbmedialab/go-graphql-client2w
@warpfork Friendly ping. Feel free to let me know if this PR isn't helpful.
dmitshur starred github.com/tv42/becky2w
dmitshur commented on Remove sourcegraph.com vanity impor… in github.com/sourcegraph/go-diff2w
Changing an import path of a package has some cost, which should be taken into account when making a decision like this. Note that the `diff` package imports `sourcegraph.com/sqs/pbtypes`, which is …
dmitshur commented on 7cbfbdb64626fed7dc5db52b55781bf9df0e75a8[WIP] Add Metal impleme… in github.com/hajimehoshi/ebiten2w
I don't think it works with Metal. [`glfwSwapInterval` documentation](http://www.glfw.org/docs/latest/group__context.html#ga6d4e0cdf151b5e579bd67f13202994ed) says: > This function sets the swap in…
dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2w
@tklauser Thanks for reporting. @bradfitz mentioned remembering that at least one service needs to be restarted after a force push. https://build.golang.org/ not showing the latest commits is definit…
dmitshur commented on x/tools/cmd/godoc: add support for … in github.com/golang/go2w
@dsnet has created a prototype for this, and this proposal is accepted, so it will be integrated into `x/tools/cmd/godoc` code. It hasn't happened yet, but updates will be posted here when there's pr…
dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go2w
golang.org has been redeployed with the [CL 150057](https://golang.org/cl/150057) change applied, so short links like https://golang.org/cl/150057 are correctly pointing to Gerrit CLs now.
dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2w
golang-dev announcement: https://groups.google.com/d/msg/golang-dev/8JmYrD3DWY0/oNVcA29FBgAJ. Closing since this is done.
dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2w
Or `--force-with-lease`.
dmitshur commented on x/tools/godoc: backport Flex change… in github.com/golang/go2w
This is done now. [Twelve CLs](https://github.com/golang/tools/compare/927e5423272fee7c3fdca1c32a2a700d8bc6c7e2%5E...f1c3f9758cfa55baca3eeb5caf8b723ca47643b4) have been backported.
dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2w
I'm in favor of rewriting the history to drop the binary for the following reasons: - This is the main `go` repo, not a subrepo, so only Go developers have a copy. Had it been a subrepo, it would …
dmitshur starred github.com/wselwood/resparse2w
dmitshur created branch in github.com/dmitshur/gddo3w
talksapp-go19
dmitshur commented on x/build: stop testing dev.boringcry… in github.com/golang/go3w
Sounds like the decision is to use `windows/386`. I'll proceed with that for now, but happy to change it if there's further feedback.
dmitshur commented on x/build: stop testing dev.boringcry… in github.com/golang/go3w
Testing on at least one other builder in addition to `linux/amd64` itself sounds reasonable. Which one (or ones)? Some possibilities: - Just `windows/amd64`? - All first class ports: `linux/{3…
dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom3w
I see, thanks for clarifying. Then let's keep this as is. If we discover evidence that there are reproducible cases where it's nil and needs to be handled, we can address it then.
dmitshur pushed to patch-1 in github.com/dmitshur/go-graphql-client3w
5178bc9f0b583576b710cd142337af25f6cafcectransport: use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to patch-1 in github.com/dmitshur/jsgo3w
eb95c603effdd7b38331a61c8ef3c6352310e19bserver/play: Use golang.org/x/net/context/ctxhttp package
dmitshur starred github.com/dave/jsgo3w
dmitshur pushed to master in github.com/shurcooL/webdavfs3w
44bbca92c578c2cdeb441afd67c2bd3fa3341cb9webdavfs: Replace "golang.org/x/net/context" with "context".
dmitshur pushed to master in github.com/shurcooL/go3w
58262d155ee0c659f3e3963bfccbac0f6a6a1d2bctxhttp: Deprecate package in favor of upstream version.
dmitshur pushed to master in github.com/shurcooL/home3w
3ad91d15a504fea9a6eb4e8c76b0890a5018cd03http: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in dmitri.shuralyov.com/app/changes3w
5af16e21babb2483897184bb2e4c97d642af158dassets: Apply gofmt using Go 1.11.
dmitshur pushed to master in github.com/shurcooL/notificationsapp3w
0a6e54cc4198490965719c64619758a801bc4aa5assets: Apply gofmt using Go 1.11.
033c8bfe5a0ab228761a117a76d93a2c85a438d4httpclient: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in github.com/shurcooL/issuesapp3w
d91d66789394f827615d32b4326948f0ee27b8d0assets: Apply gofmt using Go 1.11.
dmitshur pushed to master in github.com/shurcooL/issuesapp3w
d97dc23dc6f58887979f66924d690f026dc60959httpclient: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in dmitri.shuralyov.com/service/change3w
7424d8ddca1d310f20d49327fd09b60e29f9d1fdhttpclient: Use golang.org/x/net/context/ctxhttp package.
dmitshur pushed to master in github.com/shurcooL/graphql3w
16b88644589aaa174a21ae55cac72a9f60d5d837Switch back to golang.org/x/net/context/ctxhttp package.
dmitshur commented on Can shurcooL/go/ctxhttp dependency … in github.com/shurcooL/graphql3w
Issue https://github.com/golang/go/issues/21358 has been resolved today, so I can finally resolve this issue! 🎉 /cc @gmlewis
dmitshur commented on x/build/cmd/gopherbot: follow-up ba… in github.com/golang/go3w
Also happened in https://github.com/golang/go/issues/28688#issuecomment-438326787.
dmitshur commented on cmd/compile: inline multiplication … in github.com/golang/go3w
@josharian You're hitting the known issue #25574. Gopherbot already responded to a backport command earlier in this issue, so until #25574 is resolved, it never listens to follow up backport requests.
dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go3w
FWIW, explicitly setting the maximum acceptable TLS version to 1.2 in that test makes it pass: ``` diff --git a/http2/server_test.go b/http2/server_test.go index e5be1a6..3cd398f 100644 --- a/h…
dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go3w
Bisected this test failure to [CL 147638](https://golang.org/cl/147638) (crypto/tls: enable TLS 1.3 and update tests), which makes a lot of sense. /cc @FiloSottile
dmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go3w
Woohoo! CL incoming.
dmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go3w
@bradfitz, we've been removing support for Go 1.6 and replacing `golang.org/x/net/context` with `context` in many packages recently (e.g., https://github.com/golang/net/commit/04ba8c85dd55b4ee6099abb…
dmitshur commented on x/build/maintner: GitHubIssue.Close… in github.com/golang/go3w
> We have the issue events synced anyway, so the data's in the corpus. We just need to track the oldest close event per issue. That's a great idea, then no need for extra queries. The close event ha…
dmitshur commented on 71e986f52b169375e8c4310ed2c24b30996514daRefactored to use Graph… in github.com/davidoram/ght3w
You can omit the empty brackets if you want, e.g., just `graphql:"tag: node"`.
dmitshur commented on 71e986f52b169375e8c4310ed2c24b30996514daRefactored to use Graph… in github.com/davidoram/ght3w
In case it's helpful, you can probably simplify this further. Instead of using `edges` and then accessing the `node` inside, you could access the list of nodes directly via `nodes`. See the second fi…
dmitshur commented on access: request for increased Githu… in github.com/gopherjs/gopherjs3w
We've added you. Thank you Paul!
dmitshur commented on IsoGoApp: Does not find and load th… in github.com/gopherjs/gopherjs3w
/cc @EngineerKamesh
dmitshur commented on gopher build error in github.com/gopherjs/gopherjs3w
If you look at the [import graph](https://godoc.org/github.com/EngineerKamesh/igb/igweb/client?import-graph&hide=2) of that package, you'll see that it imports `go.isomorphicgo.org/go/isok`, which im…
dmitshur deleted branch in github.com/shurcooL/notifications3w
optimize-githubapi
dmitshur pushed to master in github.com/shurcooL/notifications3w
bcc2b3082a7acf2b5e8082374401a9d5e62944d2githubapi: Cache notifications in List.
926403120bbcbee30699b0ea339c947775dac05fgithubapi: Batch GraphQL queries in List.
dmitshur commented on Remove Cgo dependency on Windows in github.com/go-gl/glow3w
Add a `// TODO: Use syscall.Syscall18 when Go 1.12 is the minimum supported version.` perhaps?
dmitshur commented on remove dependency on cgo in github.com/go-gl/gl4w
I think we did reach agreement. We talked on slack and I left some comments on the proposal document. As long as you're willing to help maintain the Windows cgo-free version, we're happy to accept it.
dmitshur commented on How to encode GraphQL Aliases in github.com/shurcooL/githubv44w
@davidoram Thanks for asking. Aliases are supported, but I haven't documented them yet (see #22). I hope to fix that soon. The answer is as follows. A GraphQL query like this: ```GraphQL query…
dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom4w
Question, do you know if `e.Get("content")` always returns a non-nil value?
dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom4w
Please use a keyed field in this composite literal, for consistency with other elements. ```suggestion return &HTMLTemplateElement{BasicHTMLElement: el} ```