Activity
Today
dmitshur opened a change golang.org/x/website/cmd/golangorg: catch instances of bad escaping due to template use41m
The {{raw `…`}} sequence is commonly used in Markdown templates to
include a block as is. If such a sequence is used in a Markdown file
while its 'template' field in metadata is accidentally set to…dmitshur commented on cmd/fix: stringsbuilder breaks code when combining two `strings.Builder`s [1.26 backport]2h
@mrkfrmn Thanks. Note that I left a comment on [CL 746360](https://go.dev/cl/746360), I believe it already handles the vendoring for this backport issue as is, only its commit message does not curren…dmitshur reviewed +2 on go.dev/wiki/MinimumRequirements: simplify tinyconfig requirements2h
Thanks.dmitshur reviewed +2 on go.dev/wiki/Linux: update requirements to kernel 3.2 or later2h
I left a suggestion but overall this looks good. Thanks.dmitshur commented on go.dev/wiki/Linux: update requirements to kernel 3.2 or later2h
(1 comment)
Since 'drop requirements for unsupported Go versions' is a WIP CL that comes after this one, and I understand this table tries to capture the information when a given Kernel became requi…dmitshur commented on cmd/compile: internal compiler error on : "tried to free an already free register" with generic function and type >= 192 bytes [1.26 backport]3h
Moving the Critical label from here to #77604 (the upstream Go 1.27 tracking issue).Yesterday
dmitshur closed an issue cmd/fix: OOB panic in stringscut modernizer21h
dmitshur closed an issue cmd/fix: OOB panic in stringscut modernizer21h
dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: leave out space in stringsbuilder edit1d
Thanks.
I suspect this makes at most a tiny dent in the grand scheme of work to resolve issue #76476, but hopefully it helps more than not.dmitshur commented on golang.org/x/tools/gopls: fix typos1d
(1 comment)
Great. Thanks again.dmitshur commented on golang.org/x/build/cmd/gorebuild: leave out "you need to" suggestion1d
Thanks.dmitshur reviewed +2 on golang.org/x/website/_content/blog: minor edits to gofix.md1d
Thanks.
Was https://go-review.googlesource.com/c/website/+/745380/comment/fdba0ae1_5a22a858/ missed? It was about s/Repeat/Attempts/ rather than gofmt, since `type RequestJSON` definition above had …dmitshur reviewed +2 on golang.org/x/mobile/cmd/gomobile: update comments to explain why x86_64 is used for Arm641d
Thanks.Last Week
dmitshur commented on builtin: update new documentation for Go 1.26 expression syntax [1.26 backport]4d
Please see https://go.dev/wiki/MinorReleases for more information on the backport process. This cherry pick candidate is waiting to be reviewed first. We'll ask for your help with creating the backpo…dmitshur closed an issue : "go fix" produces invalid StringBuilder combination4d
I opened #77624 to backport the fix for this to Go 1.26.1.dmitshur commented on cmd/fix: stringsbuilder breaks code when combining two `strings.Builder`s [1.26 backport]4d
[CL 733180](https://go.dev/cl/733180) is already submitted on internal-branch.go1.26-vendor branch of x/tools, so what's left is to [vendor it](https://cs.opensource.google/go/go/+/release-branch.go…dmitshur commented on cmd/fix: stringsbuilder breaks code when combining two `strings.Builder`s4d
@gopherbot Please consider this for backport to Go 1.26. It's needed to prevent overlapping stringsbuilder fixes (#77620, #76983) from causing `go fix` to generate invalid code.dmitshur opened a change golang.org/x/tools/go/analysis/passes/modernize: leave out space in stringsbuilder edit4d
Applying the stringsbuilder suggestion in an editor previously ended up
inserting (or rather leaving behind) an extraneous space:
-s += "abc"
+s .WriteString("abc")
Adjust the edit to leave the s…dmitshur commented on : "go fix" produces invalid StringBuilder combination4d
Thanks for the report. This might be another instance of the known problem described in issue #76476 (and issue #76983).dmitshur commented on cmd/covdata: TestCovTool/{Textfmt,Subtract,MergeSimple} failures [consistent failure]4d
These test failures started with [CL 726800](https://go.dev/cl/726800). (CC @rudy-regazzoni-sonarsource.)dmitshur closed an issue cmd/covdata: TestCovTool/MergeSimple failures [consistent failure]4d
Joined into #77608.dmitshur closed an issue cmd/covdata: TestCovTool/Subtract failures [consistent failure]4d
Joined into #77608.dmitshur commented on github.com/OldUnreal/UT2004Patches: MacREADME.txt includes incorrect directory name in instructions (MacOS 3374 release)5d
> Thankfully the instructions on the website are correct.
It looks like they were fixed very recently, in commit de21bcf257f796c33ec3aa9ec7e20c55c0717993.dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count6d
> that means the intent of getting this fixed in go1.21.1 is recorded only in my head
It's okay to create the backport issue as soon as you think it should be considered for backport, before the iss…dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count6d
@adonovan Note that manually placing an issue in a Go minor release milestone can lead to it being missed in weekly backport review and in [minor release note](https://go.dev/doc/devel/release#go1.25…dmitshur commented on cmd/compile: go1.22+ cmd with go.mod 1.21 generates per-loop variable when using line directive [1.26 backport]1w
With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…dmitshur closed an issue runtime: netpollinit() incorrectly prints the error from `linux.Eventfd` [1.24 backport]1w
With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…dmitshur closed an issue runtime: netpollinit() incorrectly prints the error from `linux.Eventfd` [1.24 backport]1w
With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…dmitshur closed an issue cmd/go: CGO compilation fails after upgrading from Go 1.25.5 to 1.25.6 due to --define-variable flag in pkg-config [1.24 backport]1w
With the release of [Go 1.26.0](https://go.dev/doc/go1.26#introduction), the two latest supported major Go releases are 1.26 and 1.25 per the [Go release policy](https://go.dev/doc/devel/release#poli…dmitshur commented on cmd/go: inconsistent reporting of default Go version1w
One of #63507 or #70090 can probably be closed as a duplicate of the other.
Note that https://github.com/golang/go/issues/63507#issuecomment-1759734314 agrees the message can be improved but include…dmitshur commented on github.com/go-gl/gl: Jerky refresh with high update rate1w
Does the same behavior reproduce if you try the example programs at [go-gl/example](https://github.com/go-gl/example)? If not, you can try bisecting between the two programs to narrow in on the cause…dmitshur commented on cmd/fix: fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes1w
In case it helps, noting here that I found breaking out a single analyzer run to happen first in the dashboard package is a viable workaround:
```sh
go fix -stringsseq ./dashboard # workaround for …dmitshur opened an issue golang.org/x/build: modernize for Go 1.24+ (via `go fix`)1w
The x/build repo has a good number of opportunities to modernize Go code, some older and some newer. In Go 1.26, [`go fix`](https://go.dev/doc/go1.26#go-command) is improved to make it much easier to…dmitshur opened an issue cmd/go: document GOROOT/bin/go PATH entry for `go run` and `go tool`1w
This is a continuation of issue #57050, to add missing documentation for a cmd/go behavior that's already implemented for a few more of its commands. ([CL 461683](https://go.dev/cl/461683) previously…dmitshur commented on github.com/shurcooL/githubv4: Maintenance status and future plans1w
Thanks for offering to help.
I wouldn't describe its maintenance levels as very active, but I do still use it myself and ocassionally update it to include latest GitHub GraphQL schema changes. That'…dmitshur pushed to
main in github.com/shurcooL/graphql1wdmitshur commented on github.com/shurcooL/githubv4: regenerate for schema changes by 2022-10-241w
Thanks. These schema changes are already merged via PR https://github.com/shurcooL/githubv4/pull/110.dmitshur commented on github.com/shurcooL/githubv4: Regenerate for schema changes by 2025-11-211w
Thanks for the PR. I prefer to update go.mod and go.sum files separately.
I pushed commit 2402fdf4a9edcf51ed3f2eab4dc57c6867b10eea that includes schema changes by 2026-02-08. It doesn't yet includ…dmitshur pushed to
main in github.com/shurcooL/githubv41wdmitshur commented on golang.org/x/example/gotypes: update for go/types.Alias 1w
[CL 620075](https://go.dev/cl/620075) updated the gotypes tutorial.dmitshur closed an issue runtime: TestRuntimeLockMetricsAndProfile/runtime.lock/sample-1 failures1w
Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change9modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur closed a change github.com/shurcooL/githubv4: regenerate for schema changes by 2022-10-242y
dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y