Today
dmitshur commented on reflect: TestStructOfGC is flaky an… in github.com/golang/go11m
I used the bash for loop above instead of `go test -count=100` because of #31043.
dmitshur commented on reflect: running go test with -coun… in github.com/golang/go12m
This is a regression. It doesn't happen in Go 1.12.1: ``` $ go version go version go1.12.1 darwin/amd64 $ go test -count=2 reflect ok reflect 0.915s ```
dmitshur commented on x/crypto: extract non-crypto parts … in github.com/golang/go16m
We've created [golang.org/x/term](https://github.com/golang/term) exactly for this purpose. But the move hasn't been done yet. This is related to issue #13104. /cc @matloob @bradfitz
dmitshur commented on reflect: TestStructOfGC is flaky an… in github.com/golang/go27m
I can reproduce this locally on latest master commit (270de1c110221c309c832b526012f3e21b35f581) on macOS: ``` $ ../bin/go version go version devel +270de1c110 Mon Mar 25 22:41:37 2019 +0000 darw…
dmitshur commented on reflect: TestStructOfGC fails somet… in github.com/golang/go45m
And in https://go-review.googlesource.com/c/go/+/169239/1#message-e40aeddcdbf30a884ada5e3011f6bd45b86d8734, it happened as part of normal `reflect` tests, not under -buildmode=pie: > 2 of 19 TryBo…
dmitshur commented on reflect: TestStructOfGC fails somet… in github.com/golang/go55m
It happened again in https://go-review.googlesource.com/c/go/+/169237/2#message-23a89ac54f4e6a1f71cfb768ab0e5bf762ded0bc: > Failed on linux-amd64: https://storage.googleapis.com/go-build-log/d44bc…
dmitshur commented on cmd/vet/all: get golang.org/x/tools… in github.com/golang/go58m
> and see what happens FWIW, the x/tools version currently specified in the `cmd` module go.mod file predates both CL 168404 (which caused #30971) and CL 168803 (which fixed it), so it should pass…
dmitshur commented on cmd/vet/all: get golang.org/x/tools… in github.com/golang/go1h
`cmd/vet/all` is inside the `cmd` module, and its go.mod file specifies a version of the golang.org/x/tools module. Is it not being used? https://github.com/golang/go/blob/e6df1799791fac7262effe44…
dmitshur commented on cmd/dist: move GOPATH setting from … in go.googlesource.com/go2h
> Verified that #30960 is still fixed. Thanks for doing that. > Failed on linux-amd64: https://storage.googleapis.com/go-build-log/2d0c62df/linux-amd64_b03ce43a.log Seems unrelated to this change,…
dmitshur commented on cmd/coordinator: remove special cas… in go.googlesource.com/build2h
(1 comment) > We can make cmd/vet/all force module mode. We won't be removing the opt-in mode, considering Go 1.11 and Go 1.12 had it. Yeah, I meant we should do that. SGTM.
dmitshur commented on cmd/coordinator: remove special cas… in go.googlesource.com/build2h
My main concern with this CL is that we should not put ourselves in a corner if we need to change the GO111MODULE default back to auto before 1.13 final. I think it's fine if we can commit to using …
dmitshur commented on all: deploy with Go 1.12 in github.com/golang/gddo3h
This is done now. https://godoc.org/cmd/go/internal/renameio displays the docs for that new package, and searching for `fmt`, `http` finds the packages from standard library because they're instal…
dmitshur commented on [release-branch.go1.12] cmd/go: fix… in go.googlesource.com/go5h
> Patch Set 3: TryBot-Result-1 > > 1 of 20 TryBots failed: > Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/fc81bbbc/misc-vet-vetall_3773e1bd.log > > Consult https://build.g…
dmitshur commented on cmd/vet/all: build failures affecti… in github.com/golang/go5h
I can't reproduce this locally so far; `GO_BUILDER_NAME=*-vetall ../bin/go tool dist test -run arm64` and `GO_BUILDER_NAME=*-vetall ../bin/go tool dist test -run js/wasm` succeed locally for me both …
dmitshur commented on cmd/dist: set GOPATH to internal di… in go.googlesource.com/go5h
The misc-vet-vetall builder is failing after this CL, as seen at https://build.golang.org/. I've re-opened https://github.com/golang/go/issues/30971#issuecomment-476318351 to investigate this.
dmitshur commented on cmd/vet/all: build failures affecti… in github.com/golang/go6h
I'm seeing this failure, or a failure similar to this one, on latest tip commit on https://build.golang.org/ from [CL 168697](https://golang.org/cl/168697) that was submitted 15 minutes ago: https…
Yesterday
dmitshur pushed to master in github.com/shurcooL/home21h
aec053160f3587887ec9118ff7e2b6597003565bupdate .../go-diff/diff import path
634c9fc61fa60ce57abf0ddc7bb158c0b349f005update for .../service/change/githubapi.NewService API change
8a7e434f60e17374a4f98b90f59950f95d9b754freplace internal uses of shurcool with dmitshur
dmitshur pushed to master in dmitri.shuralyov.com/app/changes21h
4ceb812fd96abecf5b93471d42c411f5511141cfupdate .../go-diff/diff import path
2d5cbe16520770145f8d6e7e3fa8d17a81c896a5mark changes as read
dmitshur pushed to master in dmitri.shuralyov.com/service/change21h
c30c625107fb4624ceab7b0e90d22159c9d8e372maintner: update .../go-diff/diff import path
09fc1cdc80ff92256db38ada7ae5bdecad9db138githubapi: remove NewService parameter notifications.ExternalService
6c693117c87e0e85291cca3e8a4fc1df794a033egerritapi: implement ThreadType interface
17086f11787b0ad3d36fd609387e7709d6195c46fs, githubapi: rename threadType constant
8d1e12dfd0b5f2d6448ccdef35e63401bfb5f6d2gerritapi: include commit message in change description
dmitshur starred github.com/fyne-io/fyne22h
dmitshur commented on Remove sourcegraph.com vanity impor… in github.com/sourcegraph/go-diff1d
I think this issue has been resolved via PR #30 and can be closed. /cc @sqs @slimsag
dmitshur commented on use github.com/sourcegraph/go-diff … in github.com/sourcegraph/go-diff1d
README still says `go get -u sourcegraph.com/sourcegraph/go-diff/diff` and uses the previous import path in the godoc.org badge. Is that unintentional?
dmitshur pushed to master in github.com/shurcooL/markdownfmt1d
dmitshur commented on markdown: fails to build in module … in github.com/shurcooL/markdownfmt1d
I'll use the latest pseudo-version of v1 API for now, and open an issue for blackfriday to make a newer v1 release version. Opened https://github.com/russross/blackfriday/issues/533.
dmitshur commented on markdown: fails to build in module … in github.com/shurcooL/markdownfmt1d
It turns out I can't use v1.5.2 because it's too old and doesn't include the fix for https://github.com/russross/blackfriday/issues/495.
dmitshur commented on errors with undefined blackfriday v… in github.com/shurcooL/markdownfmt1d
Thanks for reporting. The problem is that the package [`github.com/shurcooL/markdownfmt/markdown`](https://godoc.org/github.com/shurcooL/markdownfmt/markdown?imports) imports [`github.com/russross…
Last Week
dmitshur commented on Version 2 compatibility with versio… in github.com/ejcx/passgo1d
> I don't think it there should be any compatibility issues. Great! Thanks for answering. > - Regular sites are stored as files now by default. As opposed to what? How were they stored before?
dmitshur commented on go/token: add IsIdentifier, IsKeywo… in go.googlesource.com/go2d
> I don't think we should add an identical function to another package without deprecating one of them. It makes the API confusing for new users: they can't reasonably make a decision about which of …
dmitshur commented on go/token: add IsIdentifier, IsKeywo… in go.googlesource.com/go2d
(1 comment) I don't think we should add an identical function to another package without deprecating one of them. It makes the API confusing for new users: they can't reasonably make a decision abou…
dmitshur commented on go get fails on your new home repo in github.com/shurcooL/home2d
I'll close this since the issue is resolved, but please feel free to re-open if it occurs again.
dmitshur commented on [release-branch.go1.12] cmd/go: fix… in go.googlesource.com/go3d
This change is ready for review.
dmitshur commented on cmd/go: executables are sometimes n… in github.com/golang/go3d
Approving this because it's a regression from GOPATH mode. There was an attempt to get it into 1.12.1 that didn't work out, so we're trying again for 1.12.2.
dmitshur commented on cmd/go: executables are sometimes n… in github.com/golang/go3d
Reopening because the original [CL 140863](https://golang.org/cl/140863) was reverted on `master` branch via [CL 168402](https://golang.org/cl/168402).
dmitshur commented on Support for Go 1.12 in github.com/gopherjs/gopherjs3d
Yes, I plan to allocate time on reviewing the PR this weekend, and I think it’s close to being mergeable.
dmitshur commented on cmd/go: using relative paths with n… in github.com/golang/go3d
https://golang.org/cmd/go/#hdr-The_main_module_and_the_build_list says: > The "main module" is the module containing the directory where the go command is run. The go command finds the module root b…
dmitshur commented on go/packages: give a better error if… in go.googlesource.com/tools3d
(1 comment) > I'm surprised that there's no way to get this info from the error itself. There is. See https://godoc.org/os/exec#ErrNotFound. Sent CL 168897.
dmitshur commented on runtime: dll injection vulnerabilit… in github.com/golang/go4d
@zx2c4, since you're the author of the original [CL 165798](https://golang.org/cl/165798), would you like to send a backport CL? The process for doing so is described at https://golang.org/wiki/Mi…
dmitshur commented on runtime: dll injection vulnerabilit… in github.com/golang/go4d
Approving this because it's a security issue, which is in line with our [backport policy](https://github.com/golang/go/wiki/MinorReleases).
dmitshur commented on go get fails on your new home repo in github.com/shurcooL/home4d
I was going to suggest trying with an empty module cache directory. Glad to hear that fixes it. You wouldn't have by any chance made a backup of that directory? If so, if you don't mind sharing a co…
dmitshur commented on go get fails on your new home repo in github.com/shurcooL/home4d
What was the command you ran?
dmitshur commented on cmd/go: duplicate symbols when incl… in github.com/golang/4d
Cherry pick approved because this is a followup to a fix for a significant regression from GOPATH mode.
dmitshur commented on cmd/go: duplicate symbols when incl… in github.com/golang/4d
Cherry pick approved because this is a followup to a fix for a significant regression from GOPATH mode.
dmitshur commented on cmd/go: duplicate symbols when incl… in github.com/golang/go4d
For posterity, the second backport issue was created manually: #30937 (for 1.12).
dmitshur commented on x/build/cmd/gopherbot: follow-up ba… in github.com/golang/go4d
Happened again in https://github.com/golang/go/issues/30374#issuecomment-474556262, @jayconrod had to create the backport issue manually.
dmitshur commented on cmd/go: duplicate symbols when incl… in github.com/golang/go4d
> (I know gopherbot usually opens these issues; I asked politely, but it didn't do it). For reference, this is tracked in issue #25574. Until that is resolved, gopherbot listens for backport reque…
dmitshur commented on go get fails on your new home repo in github.com/shurcooL/home4d
Hi. I haven't moved anything recently. Is there a command I can run to reproduce the problem? From the error message, it looks like it might've been a transient network error. Have you tried restar…
dmitshur commented on x/build: update dependencies in go.… in github.com/golang/go4d
@thepudds Did you close this issue unintentionally? It's not yet fully resolved; doing `go get -u -m` on the x/build module still produces an error. @jadekler Thanks for the update! I don't think …
dmitshur commented on Vsync doesn't work on macOS 10.14 (… in github.com/glfw/glfw5d
> someone on Twitter told me that the broken vsync support is *fixed* in the 10.14.2 beta releases, against expectations I'm on 10.14.3 (18D109), the latest public release, and the vsync issue is no…
dmitshur commented on cmd/doc: go doc rsc.io/quote/v3 in … in github.com/golang/go5d
Actually, I can't reproduce this with Go 1.12.1 nor Go tip (at commit fd270d8b579cc9dd4ced34fa7605a444794a787d): ``` $ cd $(mktemp -d) $ go mod init m go: creating new go.mod: module m $ go ge…
dmitshur commented on cmd/doc: go doc rsc.io/quote/v3 in … in github.com/golang/go5d
I'll be able to look into this issue.
dmitshur pushed to master in dmitri.shuralyov.com/service/change5d
9a7a6e8aef50bf7dceb93c681ed6446f3fdfa0b0remove ApprovedEvent, ChangesRequestedEvent
dmitshur pushed to master in dmitri.shuralyov.com/app/changes5d
3c6a68559ec8cd18b4cee7840b40ddddeb42e7e5component: delete support for change.{Approved,ChangesRequested}Event
dmitshur commented on x/tools/cmd/godoc: remove CLI suppo… in github.com/golang/go6d
@trivigy The `godoc` command does not have support for module mode yet, but work on resolving that is underway. The umbrella issue #26827 is tracking that task, and you can subscribe to it for furthe…
dmitshur commented on keyify: support build tags in github.com/dominikh/go-tools6d
Friendly ping @dominikh. What do you think of this change?
dmitshur commented on go get https://github.com/user/repo… in github.com/golang/go6d
Thanks for providing additional information and context. It's helpful to finding out if there's something we can do to make an improvement.
dmitshur commented on gerrit: CL submission hangs in github.com/golang/go6d
Does the problem persist even now, if you try again?
dmitshur commented on go get https://github.com/user/repo… in github.com/golang/go6d
Is there something in the `go get` documentation that made you think there should be an `https://` prefix in front of the import path?
dmitshur commented on cmd/go: test failing to initialize … in github.com/golang/go6d
Another possible cause is [CL 167087](https://golang.org/cl/167087), the CL that changed the default value of GO111MODULE to 'on'. It was 3 commits earlier, and there are no test results for it for t…
dmitshur commented on x/build/cmd/coordinator: http://far… in github.com/golang/go1w
Sure. This part still applies: > I'd also like to learn how to do this (so I can apply the knowledge in similar situations in the future).
dmitshur pushed to master in dmitri.shuralyov.com/state1w
dmitshur commented on Gerrit: don't wipe Trybot-Result wh… in github.com/golang/go1w
In what sense is it lost? I see a "TryBots are happy." message with a "TryBot-Result +1" vote at https://go-review.googlesource.com/c/go/+/167978#message-c36076efcbed3a38e87c5f6d4de374821854b7f5. …
dmitshur pushed to master in github.com/shurcooL/home1w
caa2a870e30633633565b582bf636bf394ccd54arefactor SIGINT handling code, rename shurcoolGerritChange
dmitshur pushed to master in github.com/shurcooL/home1w
9cc2805626c3555e580e9d114e10069e31a9cb23.travis.yml: use go vet instead of go tool vet
21134fcd45d122b5d6f48d7d326fe6f27ca29b76internal/code: check that repo spec has canonical form
2ffc368263f353652c88e28dfeafa58d0460abc6replace generic -production flag with specific flags
ce682e8d1b0aa766e76a62ecc01eeb46e6dd4cc1add test packages
dmitshur pushed to master in github.com/shurcooL/cmd1w
789e0acba4a07c4f939e046046e01fdcee2e738cgorepogen: use go vet instead of go tool vet in .travis.yml
dmitshur opened an issue in github.com/shurcooL/home1w
Earlier
dmitshur commented on x/build: speed up large container s… in github.com/golang/go1w
@bradfitz I've read the original issue and the linked design doc in full, which helped me understand this better, but I still have an unanswered question about this part: > The gist of it is that …
dmitshur commented on Add go.mod in github.com/dominikh/go-tools1w
> I want to be able to more easily compute the vanity import path from the git remote URL And the reason I want that is so that I can show this on my website: ![image](https://user-images.githu…
dmitshur commented on How to insert an object using mutat… in github.com/shurcooL/graphql1w
What GraphQL server are you using? Can we reproduce this error somehow? It looks like the GraphQL server is returning an error "variables can only be defined on input types". Googling that error …
dmitshur commented on Add go.mod in github.com/dominikh/go-tools1w
> Plus, strictly speaking, we cannot abide by the modules requirements. This project very much doesn't use semantic versioning, and I'm not planning on changing that; every release of staticcheck is …
dmitshur commented on d0100b6bd8b389f0385611eb39152c4d7c3a7905all: re-introduce go.mo… in github.com/golang/lint1w
@giautm That general issue is being tracked in https://github.com/golang/go/issues/30831.
dmitshur commented on What's the motivation for ST1015? in github.com/dominikh/go-tools1w
Thank you for answering.
dmitshur commented on Error when updating the library wit… in github.com/googleapis/google-cloud-go1w
> I know there are multiple tracking issues at this point for the related set of changes, but is there a next step here on this issue? I agree that it'd be worth it to re-open this one for trackin…
dmitshur commented on go.mod: update dependencies in github.com/googleapis/google-api-go-client1w
> Do we know for sure all the packages we need to touch, @dmitshur? I tried the following locally. Made an new module with a go.mod like this: ``` module m require ( go.opencensus.io v0.1…
dmitshur commented on go.mod: update dependencies in github.com/googleapis/google-api-go-client1w
> I like @bcmills idea slightly more, then. Which one are you referring to? > Do we know for sure all the packages we need to touch, @dmitshur? I tried to look through everything that was re…
dmitshur commented on go.mod: update dependencies in github.com/googleapis/google-api-go-client1w
> Does that produce a bad version? What is Go modules behavior here? It does not. When a module is needed but not specified in a given go.mod file, the go command figures one out on demand, using …
dmitshur commented on Latest tagged version still require… in github.com/openzipkin/zipkin-go1w
There's been progress made. Right now, I think one of the next blocking pieces to resolve is https://github.com/googleapis/google-api-go-client/issues/342 and https://github.com/census-instrumentatio…
dmitshur commented on Remove dependency from ourself, thi… in github.com/census-instrumentation/opencensus-go1w
I'm not sure that this will actually work, for the following reason. Replace directives of a go.mod file only apply when that module is the main module. When this module is required elsewhere, its…
dmitshur commented on go.mod: update dependencies in github.com/googleapis/google-api-go-client1w
> I'm not sure if there's another way out of this situation, but let me know if you see one. I do see another way. It would require one of the projects to temporarily omit the other in its go.mod …
dmitshur commented on go.mod: update dependencies in github.com/googleapis/google-api-go-client1w
A possible way to proceed, requiring coordination on both sides. If @bogdandrutu plans to make a new tag of `go.opencensus.io` at `v0.19.2`, and the project owners here are willing to make a new r…