Yesterday
dmitshur commented on net/http/httptest: update docs, rem… in go.googlesource.com/go13h
(2 comments)
LGTM, just see the inline comment in commit message.
With the change to ResponseRecorder.Header documentation done in PS2, you should also add:
Fixes #32136
I consider that issue…
(2 comments)
LGTM, just see the inline comment in commit message.
With the change to ResponseRecorder.Header documentation done in PS2, you should also add:
Fixes #32136
I consider that issue…dmitshur commented on v2: add dom package in github.com/dominikh/go-js-dom14h
@dominikh The last two comments should address all your points, PTAL.
@dominikh The last two comments should address all your points, PTAL.
dmitshur commented on sourcegraph.com/sourcegraph/go-diff… in github.com/sourcegraph/go-diff15h@ian-howell It's not showing up in your go.mod file because you're requiring it indirectly, not directly.
Specifically, you're requiring the module `github.com/golangci/golangci-lint` at version v…
@ian-howell It's not showing up in your go.mod file because you're requiring it indirectly, not directly.
Specifically, you're requiring the module `github.com/golangci/golangci-lint` at version v…dmitshur commented on Change import path to github.com/ug… in github.com/ugorji/go16h@ugorji That https://golang.org/wiki/Modules wiki page has lots of documentation about multi-module repositories. There's also a specific FAQ section at https://golang.org/wiki/Modules#faqs--multi-mo…
@ugorji That https://golang.org/wiki/Modules wiki page has lots of documentation about multi-module repositories. There's also a specific FAQ section at https://golang.org/wiki/Modules#faqs--multi-mo…dmitshur commented on net/http/httptest: update docs, rem… in go.googlesource.com/go17h(1 comment)
Would "use" instead of "see" be better?
(1 comment)
Would "use" instead of "see" be better?dmitshur reviewed +2 on net/http/httptest: update docs, rem… in go.googlesource.com/go17h(2 comments)
You've updated many the other two http.ResponseHeader methods to say "MethodName implements http.ResponseWriter.", but not this one. Are you intentionally leaving it and #32136 out of s…
(2 comments)
You've updated many the other two http.ResponseHeader methods to say "MethodName implements http.ResponseWriter.", but not this one. Are you intentionally leaving it and #32136 out of s…Last Week
dmitshur commented on net/http/httptest: deprecate Respon… in github.com/golang/go1dI just realized that the `Header` method exists so that `*httptest.ResponseRecorder` implements the [`http.ResponseWriter`](https://godoc.org/net/http#ResponseWriter) interface, so it can't be outrig…
I just realized that the `Header` method exists so that `*httptest.ResponseRecorder` implements the [`http.ResponseWriter`](https://godoc.org/net/http#ResponseWriter) interface, so it can't be outrig…dmitshur commented on Extract js package to another repo in github.com/gopherjs/gopherjs1dThis is a reasonable feature request to consider. It should be possible to accomplish this, but it would take a fair bit of implementation work (which is hard due to #894). It also has the downside o…
This is a reasonable feature request to consider. It should be possible to accomplish this, but it would take a fair bit of implementation work (which is hard due to #894). It also has the downside o…dmitshur commented on cmd/go: returns confusing error for… in github.com/golang/go1dI've made a change to the module proxy URL used to serve modules beginning with the path `dmitri.shuralyov.com` in commit shurcooL/home@17791dca3219d26ab08ab73c7b0f0a9d81d925ae. The URL now contains …
I've made a change to the module proxy URL used to serve modules beginning with the path `dmitri.shuralyov.com` in commit shurcooL/home@17791dca3219d26ab08ab73c7b0f0a9d81d925ae. The URL now contains …dmitshur commented on v2: add dom package in github.com/dominikh/go-js-dom1d@myitcv You made this suggestion in https://github.com/dominikh/go-js-dom/pull/59#issuecomment-402835350 and it was discussed briefly there. It's a very big change in direction and I think it should …
@myitcv You made this suggestion in https://github.com/dominikh/go-js-dom/pull/59#issuecomment-402835350 and it was discussed briefly there. It's a very big change in direction and I think it should …dmitshur commented on js: Consider adding Wasm support. in github.com/gopherjs/gopherjs2dI think by now it has become more clear that it's unlikely someone will want to spend the time on implementing this.
GopherJS now supports `syscall/js` API (PR #908), which means Go libraries can …
I think by now it has become more clear that it's unlikely someone will want to spend the time on implementing this.
GopherJS now supports `syscall/js` API (PR #908), which means Go libraries can …dmitshur commented on v2: add dom package in github.com/dominikh/go-js-dom2d> All of the attribute setters are missing.
Thanks for catching that huge and embarrassing blunder. :) We do need to add methods for setting attributes too.
> Can we document that v2 is an alph…
> All of the attribute setters are missing.
Thanks for catching that huge and embarrassing blunder. :) We do need to add methods for setting attributes too.
> Can we document that v2 is an alph…dmitshur commented on v2: Create with support for both Go… in github.com/dominikh/go-js-dom2dI have an update on this.
@hajimehoshi has added support for the `syscall/js` API to GopherJS 1.12-2 in PR https://github.com/gopherjs/gopherjs/pull/908. That change makes it possible for a `sysca…
I have an update on this.
@hajimehoshi has added support for the `syscall/js` API to GopherJS 1.12-2 in PR https://github.com/gopherjs/gopherjs/pull/908. That change makes it possible for a `sysca…dmitshur commented on env/darwin/macstadium: add docs in go.googlesource.com/build2d(1 comment)
It's a weird thing to suddenly remember, but I felt like sharing.
I just remembered that I saw this typo AND that I forgot to point it out. Glad you caught it anyway!
(1 comment)
It's a weird thing to suddenly remember, but I felt like sharing.
I just remembered that I saw this typo AND that I forgot to point it out. Glad you caught it anyway!dmitshur commented on Error: https fetch: Get https://dmi… in github.com/shurcooL/home2dMy server provider confirmed there was a network problem with their upstream. It has been resolved by now.
Here's a graph of ?go-get=1 requests my server was responding to successfully to provide …
My server provider confirmed there was a network problem with their upstream. It has been resolved by now.
Here's a graph of ?go-get=1 requests my server was responding to successfully to provide …dmitshur commented on all: add linux-mips64le qemu builde… in go.googlesource.com/build2d(4 comments)
Question about the buildletURLTmpl field value, the rest looks good.
Nit: extra blank line at the end.
Do we want to continue to use http here (instead of https)?
Why isn't this buil…
(4 comments)
Question about the buildletURLTmpl field value, the rest looks good.
Nit: extra blank line at the end.
Do we want to continue to use http here (instead of https)?
Why isn't this buil…dmitshur reviewed +2 on dashboard, coordinator, debugnewvm:… in go.googlesource.com/build2d(3 comments)
buildlet instead of coordinator?
cmd/debugnewvm.
Right now the documentation for this method is:
1. talking about return value
2. saying it's applicable only when c.IsContainer() is …
(3 comments)
buildlet instead of coordinator?
cmd/debugnewvm.
Right now the documentation for this method is:
1. talking about return value
2. saying it's applicable only when c.IsContainer() is …dmitshur reviewed +1 on env/openbsd: add OpenBSD 6.5 releas… in go.googlesource.com/build2dI'll downgrade my CR vote to prevent accidental early submission.
I'll downgrade my CR vote to prevent accidental early submission.dmitshur commented on Error: https fetch: Get https://dmi… in github.com/shurcooL/home2dHi, thanks for reporting.
It seems my server provider was having some networking issues that prevented the server from being reachable.
The issue appears to be resolved as of about 15 minutes ago. …
Hi, thanks for reporting.
It seems my server provider was having some networking issues that prevented the server from being reachable.
The issue appears to be resolved as of about 15 minutes ago. …dmitshur reviewed +2 on env/openbsd: add OpenBSD 6.5 releas… in go.googlesource.com/build2dThanks; sorry I missed the notification for this.
Thanks; sorry I missed the notification for this.dmitshur commented on net/http/httputil: remove os.Stderr… in go.googlesource.com/go2d(1 comment)
Does the +2 mean you're okay with the current version as is, or do you still think doing the above would be an improvement?
(1 comment)
Does the +2 mean you're okay with the current version as is, or do you still think doing the above would be an improvement?dmitshur commented on net/http/httputil: remove os.Stderr… in go.googlesource.com/go2dAlso, if I make this change, I should take out this sentence from the commit message:
> Saying that the standard logger is used should be sufficient to explain the behavior, and users can infer that…
Also, if I make this change, I should take out this sentence from the commit message:
> Saying that the standard logger is used should be sufficient to explain the behavior, and users can infer that…dmitshur commented on net/http/httputil: remove os.Stderr… in go.googlesource.com/go2d(1 comment)
I sent this CL because the current documentation made me think that httputil does something special that bypasses the default log package behavior and forces it to write to os.Stderr eve…
(1 comment)
I sent this CL because the current documentation made me think that httputil does something special that bypasses the default log package behavior and forces it to write to os.Stderr eve…dmitshur commented on godoc: declare small victory over t… in go.googlesource.com/tools2dFriendly ping.
Friendly ping.dmitshur commented on godoc: re-add test for ignoring //l… in go.googlesource.com/tools2dTest failure seems unrelated, PTAL.
Test failure seems unrelated, PTAL.dmitshur reviewed +2 on env/darwin/macstadium: add docs in go.googlesource.com/build3d(5 comments)
Thanks for writing this up, very helpful!
Extra '('.
s/serve/serves/
s/Wireguard/WireGuard/
Missing period?
Missing period?
(5 comments)
Thanks for writing this up, very helpful!
Extra '('.
s/serve/serves/
s/Wireguard/WireGuard/
Missing period?
Missing period?dmitshur commented on errors: performance regression in N… in github.com/golang/go3dThis was fixed via [CL 176997](https://golang.org/cl/176997), which reverted the change that was causing this issue. /cc @andybons
This was fixed via [CL 176997](https://golang.org/cl/176997), which reverted the change that was causing this issue. /cc @andybonsdmitshur commented on cmd/buildlet: make handleRemoveAll … in go.googlesource.com/build4d(1 comment)
Nit: If this is referring to the workDir variable, it should be "workDir".
(1 comment)
Nit: If this is referring to the workDir variable, it should be "workDir".dmitshur reviewed +2 on cmd/buildlet: make handleRemoveAll … in go.googlesource.com/build4d(2 comments)
It'd be helpful to document the rationale for why we don't try this on those two OSes, either in a comment or the commit message. That way, making/reviewing changes to this function in …
(2 comments)
It'd be helpful to document the rationale for why we don't try this on those two OSes, either in a comment or the commit message. That way, making/reviewing changes to this function in …dmitshur reviewed +2 on Makefile: adjust the test rule to b… in go.googlesource.com/playground4d(1 comment)
Didn't we want to forcibly do GO111MODULE=on here, or is there a reason to leave it out?
(1 comment)
Didn't we want to forcibly do GO111MODULE=on here, or is there a reason to leave it out?dmitshur commented on playground: format go.mod files; fi… in go.googlesource.com/playground4dLeaving out the Makefile changes to a separate CL.
Leaving out the Makefile changes to a separate CL.dmitshur commented on playground: format go.mod files; fi… in go.googlesource.com/playground4dI see now the go test invocation was not inside Docker, it's just a part of the Makefile test target:
https://github.com/golang/playground/blob/a7b4d4c4bb72efd2ec20c9f30d5c1e6f09cee3d2/Makefile#L7
…
I see now the go test invocation was not inside Docker, it's just a part of the Makefile test target:
https://github.com/golang/playground/blob/a7b4d4c4bb72efd2ec20c9f30d5c1e6f09cee3d2/Makefile#L7
…dmitshur commented on playground: format go.mod files; fi… in go.googlesource.com/playground4d> Did you also run "make docker" to run the other half of the tests?
>
> (go test is one one half; the other half need to run inside the nacl-modified Go runtime)
I did now. On first try, it failed…
> Did you also run "make docker" to run the other half of the tests?
>
> (go test is one one half; the other half need to run inside the nacl-modified Go runtime)
I did now. On first try, it failed…dmitshur commented on playground: format go.mod files; fi… in go.googlesource.com/playground4d(1 comment)
Done.
(1 comment)
Done.dmitshur commented on x/playground: error line highlighti… in github.com/golang/go4dPreviously, there was only one file and so the line number was the only thing that mattered. Now, we'll need to have logic that maps a file:line pair to a single line number of the combined txtar fil…
Previously, there was only one file and so the line number was the only thing that mattered. Now, we'll need to have logic that maps a file:line pair to a single line number of the combined txtar fil…dmitshur commented on cmd/go: go list has too many (more … in github.com/golang/go4d> where `go list` and `go mod tidy` seem to disagree
That is issue #31248.
> where `go list` and `go mod tidy` seem to disagree
That is issue #31248.dmitshur commented on Dep ensure fails in dmitri.shuralyov.com/text/kebabcase4dIt sounds like caching was indeed the cause. Sorry for the trouble.
Glad to hear it's resolved now. :) I'll close this.
It sounds like caching was indeed the cause. Sorry for the trouble.
Glad to hear it's resolved now. :) I'll close this.dmitshur commented on Please add the text of the license … in github.com/shurcooL/httpgzip4dWill do this evening, thanks.
Will do this evening, thanks.dmitshur commented on x/tools/cmd/bundle: use caller's mo… in github.com/golang/go5d`bundle` [currently uses](https://github.com/golang/tools/blob/7d7faa4812bd548dafb3ef3238a968e0aa9b70d4/cmd/bundle/main.go#L193-L194) `golang.org/x/tools/go/loader` to load packages. At first glance,…
`bundle` [currently uses](https://github.com/golang/tools/blob/7d7faa4812bd548dafb3ef3238a968e0aa9b70d4/cmd/bundle/main.go#L193-L194) `golang.org/x/tools/go/loader` to load packages. At first glance,…dmitshur commented on Dep ensure fails in dmitri.shuralyov.com/text/kebabcase5dI'm not an expert on Docker so I could be mistaken about some of this, but my understanding is that it does cache pretty aggressively. I suspect there's a good chance that's what's happening here.
A…
I'm not an expert on Docker so I could be mistaken about some of this, but my understanding is that it does cache pretty aggressively. I suspect there's a good chance that's what's happening here.
A…dmitshur commented on proposal: Go 2: add mechanism to re… in github.com/golang/go5dThe `go:lang` examples above use exported fields/types. I think it'd be helpful to include their documentation to get a better sense of how the `go:lang` directive would fit in. Does it go on top or …
The `go:lang` examples above use exported fields/types. I think it'd be helpful to include their documentation to get a better sense of how the `go:lang` directive would fit in. Does it go on top or …dmitshur commented on x/playground: support txtar input f… in github.com/golang/go5dI missed the test case because it wasn't in between the two other test cases where I expected to see it. I left a comment about that too. 😛
I missed the test case because it wasn't in between the two other test cases where I expected to see it. I left a comment about that too. 😛dmitshur commented on x/playground: support txtar input f… in github.com/golang/go5dOh, I see now that the code already does that. I missed that there's no return in the `if v := bytes.TrimSpace(a.Comment); len(v) > 0 {` block.
Oh, I see now that the code already does that. I missed that there's no return in the `if v := bytes.TrimSpace(a.Comment); len(v) > 0 {` block.dmitshur commented on x/playground: support txtar input f… in github.com/golang/go5d@bradfitz The current implementation of `splitFiles` in [CL 177043](https://golang.org/cl/177043) is described as:
> If src isn't in txtar format, it returns a file named "prog.go".
Have you co…
@bradfitz The current implementation of `splitFiles` in [CL 177043](https://golang.org/cl/177043) is described as:
> If src isn't in txtar format, it returns a file named "prog.go".
Have you co…dmitshur commented on x/playground: support third-party i… in github.com/golang/go5d`txtar` is not in scope of #31761, so copying it (if that's the design we're implementing) sounds reasonable. If you're going to copy it, I suggest copying via [`bundle`](https://godoc.org/golang.org…
`txtar` is not in scope of #31761, so copying it (if that's the design we're implementing) sounds reasonable. If you're going to copy it, I suggest copying via [`bundle`](https://godoc.org/golang.org…dmitshur commented on Dep ensure fails in dmitri.shuralyov.com/text/kebabcase5dIt must be something else then. I’ll reopen this.
How can I reproduce it? What was the command you ran?
It must be something else then. I’ll reopen this.
How can I reproduce it? What was the command you ran?dmitshur commented on Dep ensure fails in dmitri.shuralyov.com/text/kebabcase6d@ribice There's a new `dep` release tag [v0.5.3](https://github.com/golang/dep/releases/tag/v0.5.3) published now. Can you please try again and let me know if the issue is resolved now?
@ribice There's a new `dep` release tag [v0.5.3](https://github.com/golang/dep/releases/tag/v0.5.3) published now. Can you please try again and let me know if the issue is resolved now?dmitshur commented on x/website: unify playground.js loca… in github.com/golang/go6dThis task is a part of the larger "fully stripping down the godoc binary so that it only displays local code documentation" task in https://github.com/golang/go/issues/29206#issuecomment-468807289.
This task is a part of the larger "fully stripping down the godoc binary so that it only displays local code documentation" task in https://github.com/golang/go/issues/29206#issuecomment-468807289.dmitshur commented on cmd/go: extra slash added to url ca… in github.com/golang/go6dI've edited the original issue to make it more visible that this affects Go tip only. Go 1.12 and Go 1.11 are not affected.
I think there are two problems, one in `cmd/go` and the other in the way…
I've edited the original issue to make it more visible that this affects Go tip only. Go 1.12 and Go 1.11 are not affected.
I think there are two problems, one in `cmd/go` and the other in the way…Earlier
dmitshur commented on U1000 is not reported when identifi… in github.com/dominikh/go-tools1w> I can only suggest running staticcheck with tests disabled.
I didn't realize that would help (I thought it would just not report problems in tests). Thanks, that sounds good.
> I can only suggest running staticcheck with tests disabled.
I didn't realize that would help (I thought it would just not report problems in tests). Thanks, that sounds good.dmitshur commented on Dep ensure fails in dmitri.shuralyov.com/text/kebabcase1w@ribice Oh, I just noticed the latest `dep` release tag is missing the "v" prefix! See https://github.com/golang/dep/releases. That means doing `go get -u` in module mode will actually install v0.5.1…
@ribice Oh, I just noticed the latest `dep` release tag is missing the "v" prefix! See https://github.com/golang/dep/releases. That means doing `go get -u` in module mode will actually install v0.5.1…dmitshur commented on Dep ensure fails in dmitri.shuralyov.com/text/kebabcase1w@ribice I've looked in the GoBuffalo project, and I see it calls out to `dep` in a few places, but I don't see an old version specified anywhere. Maybe it's a layer caching issue (i.e., perhaps that …
@ribice I've looked in the GoBuffalo project, and I see it calls out to `dep` in a few places, but I don't see an old version specified anywhere. Maybe it's a layer caching issue (i.e., perhaps that …dmitshur commented on cmd/go: operations requiring a go.m… in github.com/golang/go1w> At the very least there needs to be a command that'll (re)generate the go.sum.
Isn't `go mod tidy` that command, or are you looking for something else?
> At the very least there needs to be a command that'll (re)generate the go.sum.
Isn't `go mod tidy` that command, or are you looking for something else?dmitshur commented on go/doc: Synopsis can return a sente… in github.com/golang/go1wSounds good. To make progress on this issue, we should run that experiment and confirm the results are favorable. We should be able to include a corpus with a number of third-party packages in the ex…
Sounds good. To make progress on this issue, we should run that experiment and confirm the results are favorable. We should be able to include a corpus with a number of third-party packages in the ex…dmitshur commented on x/playground: support third-party i… in github.com/golang/go1wAgreed this would be nice, and is easier now than before.
There are no additional security concerns with this feature request. It's always been possible to accomplish this in a round-about way: by…
Agreed this would be nice, and is easier now than before.
There are no additional security concerns with this feature request. It's always been possible to accomplish this in a round-about way: by…dmitshur commented on Latest tagged version still require… in github.com/openzipkin/zipkin-go1wAll of the reasons this issue had been triggering have been resolved by now, and so this issue is fixed. It's possible to use `go get -u` with the latest version of this module successfully now. Than…
All of the reasons this issue had been triggering have been resolved by now, and so this issue is fixed. It's possible to use `go get -u` with the latest version of this module successfully now. Than…dmitshur commented on GO111MODULE=on support in github.com/DisposaBoy/GoSublime1w@kortschak The answer to your question is at the bottom of https://golang.org/cmd/go/#hdr-Import_path_checking:
> Import path checking is also disabled when using modules. Import path comments are…
@kortschak The answer to your question is at the bottom of https://golang.org/cmd/go/#hdr-Import_path_checking:
> Import path checking is also disabled when using modules. Import path comments are…dmitshur commented on x/build: GitHub rate limit exceeded… in github.com/golang/go1wWe've recovered all services from this outage by now.
We've recovered all services from this outage by now.dmitshur commented on GO111MODULE=on support in github.com/DisposaBoy/GoSublime1wThe latest update on the `GO111MODULE` plan is [here](https://github.com/golang/go/issues/31857#issue-440694837).
The latest update on the `GO111MODULE` plan is [here](https://github.com/golang/go/issues/31857#issue-440694837).dmitshur commented on x/build: GitHub rate limit exceeded… in github.com/golang/go1wWe're in the process of turning on `maintnerd` and other related services now.
We're in the process of turning on `maintnerd` and other related services now.dmitshur commented on x/build: GitHub rate limit exceeded… in github.com/golang/go1wI misread one of the lines as `gi.commentsUpdatedTil = ret`, so I thought it was possible for it to get updated. You're right, it always has the zero value and never gets set to anything else. That w…
I misread one of the lines as `gi.commentsUpdatedTil = ret`, so I thought it was possible for it to get updated. You're right, it always has the zero value and never gets set to anything else. That w…dmitshur commented on cmd/go: go:generate causes unnecess… in github.com/golang/go1wThe `go generate` command accepts the `-tags` flag. One can also do `GOOS=windows go generate`.
> If we made that file `+build windows`, then we couldn't run "go generate" on Linux.
To clarify,…
The `go generate` command accepts the `-tags` flag. One can also do `GOOS=windows go generate`.
> If we made that file `+build windows`, then we couldn't run "go generate" on Linux.
To clarify,…dmitshur commented on x/build: GitHub rate limit exceeded… in github.com/golang/go1wWe've identified this is connected to the incorrect timing information recorded on some GitHub comments posted a few hours ago. GitHub has said the issue has been fixed, and they're in process of cor…
We've identified this is connected to the incorrect timing information recorded on some GitHub comments posted a few hours ago. GitHub has said the issue has been fixed, and they're in process of cor…dmitshur commented on x/build: GitHub rate limit exceeded… in github.com/golang/go1w> repeated error from gopherbot
That might be related to issue #28320.
> repeated error from gopherbot
That might be related to issue #28320.dmitshur commented on cmd/go: "unexpected module path" er… in github.com/golang/go1w@Liamsi There has been a chance in Go tip to make this better, see https://github.com/golang/go/issues/28489#issuecomment-473297974 above. You can try Go tip via [`go get golang.org/dl/gotip`](https:…
@Liamsi There has been a chance in Go tip to make this better, see https://github.com/golang/go/issues/28489#issuecomment-473297974 above. You can try Go tip via [`go get golang.org/dl/gotip`](https:…dmitshur commented on Dep ensure fails in dmitri.shuralyov.com/text/kebabcase1wThe `dep` issue has been fixed (as can be seen [here](https://github.com/golang/dep/issues/2151#issuecomment-490314598)), so I'll close this.
Thanks again for the report.
The `dep` issue has been fixed (as can be seen [here](https://github.com/golang/dep/issues/2151#issuecomment-490314598)), so I'll close this.
Thanks again for the report.dmitshur commented on adding a go-import "mod" meta tag m… in github.com/golang/dep1wThe fix has been merged to `master` branch.
It hasn't been included in a released version yet, but it can be installed right now from source code via `go get -u github.com/golang/dep/cmd/dep` (as …
The fix has been merged to `master` branch.
It hasn't been included in a released version yet, but it can be installed right now from source code via `go get -u github.com/golang/dep/cmd/dep` (as …dmitshur commented on "go get -u github.com/nsf/gocode" d… in github.com/nsf/gocode1w@99zombies This is an old issue. There are different causes that can lead to the same outcome, and it's likely the people above had another instance of this problem.
I suggest looking through the …
@99zombies This is an old issue. There are different causes that can lead to the same outcome, and it's likely the people above had another instance of this problem.
I suggest looking through the …