Activity

This Week
dmitshur pushed to master in github.com/shurcooL/githubv43d
6831e00d857f83854b9207d58a3b5616447b3385regenerate schema for changes by 2021-09-20
Thanks, changes look good. I think it's okay to go with `string` as the underlying type for the new Base64String scalar for now. It's simpler, and gives the caller explicit control over the base64…
dmitshur pushed to bkeyes/update-schema in github.com/bluekeyes/githubv43d
dmitshur starred in github.com/bluekeyes/patch2pr3d
dmitshur starred in github.com/bluekeyes/go-gitdiff3d
Heya! 😀 Sorry that it's via an issue report! 😅 > this is definitely unintentional. Thanks for confirming. > what may be happening is our usage of gofumpt From what I can tell, this …
Consider the following (minified) example program that tries to print a value of type [`font.Metrics`](https://pkg.go.dev/golang.org/x/image/font#Metrics): ```Go package main import ( "fmt" …
dmitshur starred in github.com/magcius/noclip.website4d
Last Week
This issue is likely a subset of #40371. <details><summary>Environment Details</summary> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.17.1 darwin/…
By now, GitHub Discussions are being tried out in the Go project to a limited degree. See https://github.com/golang/go/discussions/47139.
Earlier
dmitshur starred in github.com/mystor/git-revise2w
@ifamakes I've checked the `Distribution` file in go1.17.darwin-arm64.pkg, and it still has `hostArchitectures="arm64"` set, so that hasn't regressed on our side. Since this issue has been closed fo…
I understand the scope of this issue is x/pkgsite, and I don't mean to change that. I'll point out that a similar issue may apply to x/website, though golang.org serves documentation under a signi…
The problem turned out to be a misconfigured use of `autocert` (not enabling `acme.ALPNProto`, and not using `HTTPHandler`), which prevented gerritbot's HTML "hello" page from being served. [CL 34843…
@davidkarlsen Something like this should work: ```Go variables := map[string]interface{}{ "somekey": (*githubv4.String)(nil), // or another concrete type instead of String // ... } ```
With the 5 CLs above, we're in good shape for early in cycle. Removing that label to revisit this closer to the code freeze.
dmitshur pushed to master in github.com/shurcooL/httperror2w
9bb3cabb3d153353a5ca771ba6c403dd0b481764use errors.As instead of type assertion in IsError functions
dmitshur pushed to master in github.com/shurcooL/httperror2w
This seems to happen occasionally, suggesting the test is flaky: ``` --- FAIL: TestParallelism (0.15s) workflow_test.go:122: task sleep #1 : started workflow_test.go:122: task sleep #2…
@timothy-king Correct. Go 1.17 and 1.16 do not have this problem.
Sounds good. Please include a small test in x/crypto that this package doesn't import `fmt`, so this property doesn't accidentally regress without the benefit of go/build's test.
The `curve25519` package imports `fmt` and uses it 3 times: ```Go return nil, fmt.Errorf("bad scalar length: %d, expected %d", l, 32) return nil, fmt.Errorf("bad point length: %d, expected %d", …
Bisection shows this problem is introduced in [CL 338529](https://golang.org/cl/338529): ``` $ (cd cmd; go get -d golang.org/x/tools@3fce476f0a782aeb5034d592c189e63be4ba6c9e && go mod tidy && go …
There is a problem on tip when the vendored x/tools module is updated to its latest master pseudo-version (as part of #36905). ### What did you do? ``` $ git clone https://go.googlesource.com/…
The fix that closed this issue landed into master branch, which is where Go 1.18 development is happening, so moving this issue to the Go1.18 milestone. (The 1.17 backport issue #47854 is in 1.17.1 m…
This issue was closed in NeedsInvestigation state without a fix, but if a fix were to be made, it would need to target Go 1.18 first. Since this isn't a [backport issue](https://golang.org/wiki/Minor…
Also CC @changkun, @hajimehoshi.
cmd/coordinator has been redeployed, so the reverse builder should be able to connect. It’s visible at https://farmer.golang.org now: > host-linux-riscv64-unmatched: 0/0 (1 missing)
Thanks for fixing this @changkun. Closing.
dmitshur starred in github.com/gonutz/d3d93w
Now that Go 1.17 is released (and thus 1.15 has become unsupported), there shouldn't be a reason not to do this. Also see discussion in #47952.
This issue was not really resolved, but `golang.org/x/build/cmd/tip` was deleted in [CL 343449](https://golang.org/cl/343449), so closing.
Now that Go 1.17 is released and Go 1.15 in unsupported per [release policy](https://golang.org/doc/devel/release#policy), we should update documentation of [`golang.org/dl/go1.N` commands](https://p…
Go 1.16 isn't affected, so this backport issue isn't needed.
CC @jayconrod.
dmitshur pushed to master in github.com/shurcooL/home3w
e98364ec944d232c9592f89e7852d36498986f9cindieauth: update for specification changes in 2020
7d2d26741fa3ac8e689c88abdcdb3d649096f368remove repoInfoContextKey
I understand the Go language specification is vague for the reasons Rob suggested, allowing different implementations of the Go language to implement them as most appropriate. The behavior of Go…
I think this issue can be fixed by changing go.dev's playground.js script as follows: ```diff -$.ajax('/compile', { +$.ajax('https://play.golang.org/compile', { ``` _(Source: [go.dev/_conten…
It's likely Go 1.15 was shown because a frontend fetch failed, or JavaScript execution is disabled. The relevant code is: ```JS async function getLatestVersion() { let version = 'go1.15'; //…
@mengzhuo A key's been provided via email. Patch set 2 of [CL 329489](https://golang.org/cl/329489) looks good, please submit it when you're ready, and after the following cmd/coordinator deploy the …
@mengzhuo Excellent, let's proceed then, thank you again. CL 329489 is reviewed, can you address the remaining comment on it, and submit it? After that, I'll redeploy coordinator, which will allow th…
I've repeated this exercise using the `windows-arm64-10` builder, and the green-screens no longer happen reproducibly. I've still observed at least 1 instance out of 5 runs, filed #47965 for that. …
Breaking this out from #47017 as a narrower issue for tracking any investigation purposes. There still seems to be some instances where running all.bash sequentially (i.e., without any sharding) o…
During the 1.18 dev cycle, using the `go` binary not from the tip checkout can cause `go mod tidy` step to fail: ``` > go mod tidy command failed: exit status 1 go mod tidy: go.mod file indicat…
At this time the `updatestd` command updates all golang.org/x versions to latest available when it is run. If run fairly infrequently (e.g., twice per cycle, so every 3 months), there can be many cha…
Thanks for verifying. Closing as fixed (see related issue #47808 which has more details). (Thanks for fixing @rsc!)
CL 344289 will fix the problem due to redirection.
tip.golang.org is served by x/website/cmd/golangorg as of [CL 335049](https://golang.org/cl/335049), and we need to update this health check. It still points to a /_tipstatus URL, which isn't served …
These builders are used by Go releases right now. Go 1.17 and 1.16 are documented to require Windows 7 or newer. Before we can remove the builders, we need to start using a newer builder for releases…
CC @jamalc, @rsc.
Sent [CL 343449](https://golang.org/cl/343449) that deletes the code. I plan to submit it after stopping the service.
There seems to be a problem in `pushIssues` for major releases. It's documented to move issues for major releases: ```Go // pushIssues moves open issues to the milestone of the next release of th…
Thanks for reporting and bisecting @fgm. CC @rsc as the author of [CL 339403](https://golang.org/cl/339403).
This is likely introduced by recent x/website changes. @rsc Can you take a look?
This issue is similar to https://github.com/golang/go/issues/47751#issuecomment-900451045. The problem is also present as of CL 339403, not present in the one before. It's temporarily mitigated be…
Thanks for reporting. The last good version was golang/website@f8f1822, rolled back golang.org to that. The problem is introduced with the following commit, golang/website@ef7fed48ece033b41e88e…
Thanks for reporting. CC @rsc.
The x/website/cmd/golangorg server became able to serve the tip.golang.org website as of CL 335049, and it is actively doing so now that the corresponding DNS change has propagated. (Proof: https:…
dmitshur commented on gerrit: support "mergeable" queries1mo
From looking at other Gerrit instances like https://gerrit-review.googlesource.com/q/is:mergeable, https://chromium-review.googlesource.com/q/is:mergeable, it appears that this option is not generall…
Go 1.17 has been released, and so Go 1.15 is no longer supported per the [release policy](https://golang.org/doc/devel/release#policy). Closing.
Approved as a documentation fix for a new-to-Go-1.17 API. Only 1.17 needs this backport.
If I understand right, the exact issue this report is about is as follows. ### What did you do? ``` $ cd $(mktemp -d) $ cat <<EOF > main.go package main func main() { var s = []int{1…
CC @ianlancetaylor, @rsc.
CC @FiloSottile, @katiehockman, @rolandshoemaker, @kevinburke via [owners](https://dev.golang.org/owners).
dmitshur commented on : Publish to the Snap Store1mo
Please provide more information about this request. What do you suggest be published (Go releases, or something else)? Which Snap Store are you referring to? Link?
Thanks for reporting. I'm not able to reproduce the issue right now (which is 1-2 hours after the report). What about you @rhysh, does it still reproduce for you? I do see in logs there have be…
Approved as a fix for a serious issue without a workaround. This backport applies to both 1.17 (#47688) and 1.16 (this issue).
Approved as a fix for a serious issue without a workaround. This backport applies to both 1.17 (this issue) and 1.16 (#47675).
dmitshur commented on golang.org/x/website: 404 Error1mo
> after click download go file Which file was it? Can you please provide additional information to help reproduce this issue?
Approving as a test-only fix, needed only for Go 1.16.
2021a is still the latest, so we'll be using it for 1.17.
@i353590 Please also note, this would be a good bug report to make in the https://github.com/Peripli/service-manager-cli/issues issue tracker, since the go.mod file in that project needs to be modifi…
> Similarly, at https://build.golang.org, there are many squares with "ok", but none of them are links, so it's not possible to access test logs for successful post-submit builds. This part is res…
@zikaeroh Sure, a new issue would be fine. However, in this case I believe it's just a matter of CSS caching. If you refresh the page it should be okay.
This is now live and submitted to x/build. Notably: [CL 340433](https://golang.org/cl/340433) reconfigured coordinator to use the build.golang.org URL as the dashboard. [CL 336792](https://gola…
The dashboard unification (#34744) just happened. There's some clean up that can happen: - [ ] remove DNS entries for build-ui-test - [ ] stop and delete the build.golang.org App Engine service …
If this offer still stands @mengzhuo, I think we can proceed. Has a builder key already been provided, or does that need to happen? I can review CL 329489 this week.
dmitshur closed an issue access: may-start-trybots1mo
dmitshur commented on access: may-start-trybots1mo
Hi Rhys, Thank you for your contributions, and for requesting trybot access. I've added your Gerrit account to the `may-start-trybots` group, so you should be able to do so now. As you've likel…
The [package comment](https://github.com/golang/net/blob/aaa1db679c0d7765d2b1cb1f92cac8ebf4d94c53/http2/http2.go#L5-L16) is more up to date and also shows up on pkg.go.dev. Maybe the README should ju…
CC @neild, @tombergan via [owners](https://dev.golang.org/owners).
CC @mpvl via [owners](https://dev.golang.org/owners).
Flipping the DNS has been done (in a somewhat bumpy way, see #47580, but it's resolved now). Coordinator needed additional permissions to be able to write build results, which has also been resolv…
https://farmer.golang.org/#health reports: <img src="https://user-images.githubusercontent.com/1924134/128610403-36681b23-c091-4c61-9d57-3e8878c8c784.png" width=400px> Restarting host machine f…