(@hajimehoshi If you want to CC me, my GitHub username is @dmitshur [as of July 2018](https://twitter.com/dmitshur/status/1021266582834634752).)
In case it's helpful to you, please note there's a typo in "Content-Lenght". It should be "Content-Length". There haven't been any reports of serious issues with the `v1.6.0-pre.1` pre-release version (neither in this thread, nor in other issues), so I'm going to proceed with promoting it to `v1.6.0`.
V… The `github.com/russross/blackfriday/v2` import path is intentional. See https://github.com/russross/blackfriday/issues/587#issuecomment-703393820.
Where are you getting a 404? > Perhaps @dmitshur can fill us in on what needs to happen to get access to this machine? I checked `gomote create` and it was listing `windows-arm-zx2c4` as a valid gomote, but `gomote ssh` failed.
… (2 comments)
Add a prefix to the subject, and use lower-case "fix" instead of "Fix":
content/static/doc: fix timestamp format in pseudo-versions
To make this change, edit the Pull Request subj…
I think both approaches are okay and it comes down to preference: I interpret this line as a very short sentence, and prefer to end it with a period. See CL 273126 for a recent example o… Many of the standard library changes that were added before CL 272871
ended up in the "Core library" section. That section is meant for
major changes like new packages, and most of these aren't.
Con… (4 comments)
Thanks! I left very minor comments.
https://tip.golang.org/pkg/time/tzdata/ uses "timezone" without space, maybe that's better for consistency.
Nit: Would it be better to write databa… Sent [CL 272907](https://golang.org/cl/272907).
I went with the following approach:
> - Another option is to modify `relnote` to use the Gerrit API. It should be possible to write a search quer… The additions were generated using golang.org/x/build/cmd/relnote.
For #40700. Apply a trivial code simplification. Tested by re-running relnote, and
its output did not change.
For golang/go#41849. Thanks for reporting, we'll take a look.
CC @golang/release. Closing as fixed. (We still need to document this change in Go 1.16 release notes, but that's tracked separately.)
The code change has happened in x/net in [CL 249440](https://golang.org/cl/249440… (1 comment)
It's quite hard to tell that the issue is open for release notes. Its title is x/net. Let's use RELNOTE=yes here, and close the issue, since the code change has already been done. From https://github.com/golang/go/issues/42082#issuecomment-728301951, I see this issue is already resolved on tip via changes in `dev.link` that were merged into `master`. So I understand this issue… @cherrymui Should this issue target Go1.16 milestone, and once fixed, a backport of it requested via the process described at https://golang.org/wiki/MinorReleases? Or is there a reason not to follow… (1 comment)
There are extra rules for release branches, they are documented at https://golang.org/wiki/MinorReleases. A backport issue must first get to CherryPickApproved state before any CLs for i… Approved as this is a serious issue without a viable workaround. Only 1.15 needs this backport. (1 comment)
Trivial nit: All lines above have a colon after the package name, separating it from the description. (2 comments)
Interesting that it's not included by default.
Add a comment above this line explaining the motivation for netbase. Something like:
# netbase: for net package tests, issue 42750
… I tried the firstname.lastname@example.org repro and I'm able to reproduce on a M1 Mac with 8 GB RAM at:
$ go version
go version devel +7716a2fbb7 Sun Nov 22 11:44:49 2020 -0500 darwin/arm64 # CL 272258 PS … I've run into this failure on darwin/arm64 as well, so it's not just darwin/amd64.
It seems to be quite easy to reproduce when the system is under load with:
$ go version
go version devel… I'm able to reproduce @rolandshoemaker's finding above with `go test io -run='^$' -bench=BenchmarkCopy -count=10`, 5 out of 5 times. It triggers within 5-30 seconds.
Trying out `GODEBUG=asy… > Does `TestExec` in syscall package pass reliably?
I believe it does:
$ go version
go version devel +7716a2fbb7 Sun Nov 22 11:44:49 2020 -0500 darwin/arm64
$ go test -… I think that issue is about running Go darwin/amd64 port under Rosetta 2. This is about running the darwin/arm64 port natively.
I can try it anyway to see what effect it has. > Does CL https://go-review.googlesource.com/c/go/+/272258 help? Thanks!
As others confirmed above, that CL indeed makes it possible to do `go run hello.go` and have it work as usual.
That CL e… [CL 272258](https://golang.org/cl/272258) has made it easy to run `all.bash`, so I ran it a few times. It has passed at least once, but most of the some test will fail due to "signal: illegal instruc…
@jpap Yes, rebooting has an effect. I tried building+signing+execing a novel binary to a non-temporary location, it was killed. After rebooting (and doing nothing else), the same binary started to ru… Ok. I tried PS 4 with a modified program:
# modify p.go to be a new program, one I've definitely never built before
$ GOOS=darwin GOARCH=arm64 go build -o ps4 p.go
$ /tmp… > If you build a fresh binary, don't try to execute it, sign it, then execute, does it work?
In my previous tests, I’ve always done `go build`, then sign, then execute. I may not have cleaned bu… I tried Cherry’s `codesign` again at Patch Sets 1 through 3. If I didn’t make a mistake, it seems they all work if I compress the binary and uncompress it, but not before that. The binaries were … Thanks for double checking my result @jpap. I will try again in a bit. > @dmitshur what about PS3? I just updated the CL again.
@cherrymui Same outcome with PS3. > Just to be sure, could someone confirm that the updated version of codesign.go on https://go-review.googlesource.com/c/scratch/+/271866 works on M1? Thanks.
@cherrymui I tried again with Patch Set… Based on discussion in a release meeting, I understand our current plan is to aim to provide binaries (and installer) for darwin/arm64 in time for the Go 1.16 release.
I'm making this as the track… The @golang/release team has considered the current builders, and we are proposing the following builder changes for the Go 1.16 release:
… (5 comments)
Thanks, this looks good. See inline comments for minor changes.
I checked and this misc-compile TryBot should be passing:
$ ./buildall.bash windows-arm
Building Go cmd/dist using … @alexbrainman Thanks for making this freeze exception request and providing a rationale.
I am approving this for Go 1.16. The change is trivial and should not add significant delay or increase ris… This CL has served its intended purpose and is no longer needed. This CL has served its intended purpose and is no longer needed. Reopening as the `net/http` issue isn't fixed in Go 1.16 yet.
This issue got closed because [CL 253259](https://golang.org/cl/253259) was submitted with the verb "Fixes". However that CL was in x/… Approving as it is a serious issue without a good workaround. This backport applies to both 1.15 (#42753) and 1.14 (this issue). Ah, indeed, go1.5.4 was too old and fails even on simple Go programs for unrelated reasons (not to mention its compiler doesn't support ssa/check/on). Thanks for accurately determining that this regr… It seems this isn't a recent regression, it happens even with Go 1.5.4:
$ go1.5.4 build p.go
fatal error: still in list
/usr/local/go/src/cmd/… Thanks for clarifying.
blog-test.golang.org is not a valid subdomain at this time, and all unknown subdomains get redirected to golang.org. This is working as intended.
I'll close this since th… Given that https://golang.org/doc/devel/release.html#go1.15 was updated to include full description of Go 1.15.5, I agree this can be closed as a duplicate of #42744.
Thanks @AlexRouSg. As an update, this issue has been resolved for the `insecure.go-get-issue-15410.appspot.com` host by granting access to it to the @golang/release team. @FiloSottile Thanks for letting us know. We've discussed this on the release team, and based on the rationale you provided and the external constraints that could not be worked around in advance, we … Thanks for reporting. The website needs to be redeployed after the Go 1.15.5 release.
CC @katiehockman. CC @cherrymui. @cherrymui I got the same result as @rolandshoemaker. In case it helps, some details:
$ export PATH="$PATH:$HOME/go116arm64/bin"
$ GOOS=darwin GOARCH=arm64 go build -o h0 he… (1 comment)
Thanks for fixing. Approving per discussion in a release meeting. Only Go 1.15 needs this backport.
I left a comment on the CL that should be addressed as part of code review. (1 comment)
I left a comment on the upstream CL (https://go-review.googlesource.com/c/go/+/268338/3#message-84a3c0cbf4b123110d8dc4184c023d2f2e5a0ef3), I think it may apply here. (2 comments)
I think this is missing a line to reset value to zero:
value = 0
Without it, the minor component value will be miscalculated when the major version isn't 0.
I understand kernelVe… In `kernelVersion`, after reaching the end of the major version component, the accumulated `value` is used. But it isn't reset to zero after, so the minor version component computation is polluted.
… (1 comment)
To update the commit message text, you need to edit the GitHub Pull Request description. Please see https://golang.org/wiki/CommitMessage#github-pull-requests. Approving per discussion in a release meeting. This backport applies to both 1.15 (#42636) and 1.14 (this issue). Approving per discussion in a release meeting. This backport applies to both 1.15 (this issue) and 1.14 (#42635). CC @golang/release. Thanks for bringing the builder back online.
At this time, we don't have a notification mechanism beyond someone spotting that a builder is missing by looking at [build.golang.org](https://build.g… @tzeejay Thanks. We do use MacStadium, as you can see at https://github.com/golang/build/tree/master/env/darwin/macstadium. @cagedmantis reached out to them on November 10, and we are now waiting for… @marcopeereboom Please be mindful of [Gopher values](https://golang.org/conduct#values) when communicating in the Go issue tracker. Criticism is welcome when it adds new information to the discussion… (2 comments)
Let's add a comment, similar to line 97 above, to help explain this somewhat unusual workaround. Something like:
/* Maintain spacing inside preformatted blocks rendered fr… In Go 1.15, the default value for `GO111MODULE` is auto, which selects GOPATH mode if there isn't a go.mod file in any parent directory. You may need to set `GO111MODULE=on` explicitly.
This doesn… (1 comment)
FWIW, I found that https://html.spec.whatwg.org/multipage/grouping-content.html#the-figcaption-element suggests:
> Contexts in which this element can be used:
> As the first or… (1 comment)
Is it okay that the newly added <figcaption> element doesn't have a <figure> element as a parent? Done. `dev.regabi` is created and currently points to commit 0968d2d599189229145b1000cec55d9df47fbc98.
As a friendly observation, the code freeze is intended to shift focus on completing the Go 1.… (I have a feeling @bcmills may have already filed an issue for this, but I couldn't find it. Maybe it was a comment instead.)
With the progress made on https://github.com/golang/go/issues/37439#is… (1 comment)
Thank you Jay. (1 comment)
TRY=linux-386-longtest, linux-amd64-longtest This reverts CL 269019.
Reason for revert: The TestScript/mod_gonoproxy test is failing
on linux-386-longtest and linux-amd64-longtest builders. Thanks for reporting.
This is another instance of #42572, so I'll merge this issue into that one.