Today
shurcooL starred github.com/jedisct1/piknik51m
Yesterday
shurcooL commented on brotli: implement encoder in github.com/dsnet/compress1d
@dsnet In https://github.com/mholt/caddy/issues/525#issuecomment-174615921, you said: > I'm actually currently working on finishing my own implementation of a RFC 1951 DEFLATE compressor. The comp…
shurcooL deleted branch in github.com/gopherjs/gopherjs1d
README-serve-base
shurcooL commented on How to render readme content as HTM… in github.com/google/go-github1d
Thanks for outlining the approaches so they're easier to compare and discuss! Indeed, it's not easy to tell which is the best one. A part of what makes it harder is that `RepositoryContentGetOptions…
shurcooL pushed to README-serve-base in github.com/gopherjs/gopherjs1d
2e5562ed9b5dd4ac36852e5ce68f1385144df73cBe more specific: "directory" -> "base directory".
shurcooL created branch in github.com/gopherjs/gopherjs1d
README-serve-base
shurcooL commented on README: Document gopherjs serve com… in github.com/gopherjs/gopherjs1d
> but, `{{base}}` not replaced actual filename. I don't know what base value is. "{{base}}.js" was just a way of suggesting that the name of the file is the base of the directory. E.g., if the fi…
shurcooL commented on Migrate IDs to int64 type in github.com/google/go-github1d
@kshitij10496 You'll need to re-run `go generate` after this change to make CI pass.
shurcooL commented on Migrate IDs to int64 type in github.com/google/go-github1d
@bradfitz We (almost always) merge PRs via squash strategy, so the entire diff will be just one commit once it lands to `master` (e.g., see https://github.com/google/go-github/pull/812/commits, which…
shurcooL commented on Fix "sync: inconsistent mutex state… in github.com/gopherjs/gopherjs1d
Thank you again @canning-duck for investigating and fixing this!
shurcooL pushed to master in github.com/gopherjs/gopherjs1d
9b73d051070fd9cbd1843f376fe094fc1e74ce3ecompiler/natives/src/sync: Fix inconsistent mutex state. (#737)
This Week
shurcooL pushed to inconsistent-mutex-state-fix in github.com/canning-duck/gopherjs1d
60a78d269f7e2c0baad92f814353a77343d9b55fcompiler/natives: Regenerate.
shurcooL pushed to master in github.com/shurcooL/vfsgen2d
9b7ff06f1d238b9b71a197c1534c4f4abc2d050dREADME: Add rsrc to Alternatives section.
shurcooL commented on x/tools/go/buildutil: split TagsFla… in github.com/golang/go2d
> The long flag usage line to be split in multiple lines somehow. Just checking, but doesn't your terminal perform automatic wrapping of long lines? For me, I get something like this: ![imag…
shurcooL commented on Add unique ID for each heading in github.com/shurcooL/github_flavored_markdown2d
Thanks for the PR. I'll try to find time this weekend to review.
shurcooL commented on unparam does not support build tags in github.com/mvdan/unparam2d
In case this is helpful, see https://github.com/mdempsky/unconvert/pull/27/files for an example of how this can be implemented.
shurcooL commented on simple: flag unnecessary assignment… in github.com/dominikh/go-tools2d
One thing that immediately comes to mind is that you’ll want to be careful about expressions that may panic. Removing them would change program behavior. There are some false positives to avoid, s…
shurcooL commented on Add a way to supply go/build.Import… in github.com/kisielk/gotool2d
> following the same logic, `go/build` wouldn't need `FindOnly` either. If `gotool` were part of the standard library, I would definitely expect to be consistent with what `go/build` offers. `go/b…
shurcooL commented on Migrate IDs to int64 type in github.com/google/go-github2d
This is a large PR. Thank you again @kshitij10496! I've reviewed the fields that were modified first. They match up with the table in https://github.com/google/go-github/issues/597#issuecomment-35…
shurcooL commented on int64 IDs in github.com/google/go-github2d
Edited the table above to add these fields that were missing in the table but present in PR #816 (and they're valid ID fields): ``` MarketplacePlanAccount.ID ProjectCard.ColumnID Repository.Tea…
shurcooL commented on Migrate IDs to int64 type in github.com/google/go-github2d
Why is this `Number` field changed to `int64`? It's not an ID. I'm guessing this was an accident, right?
shurcooL commented on Same reference for multiple heading in github.com/shurcooL/github_flavored_markdown3d
On the contrary, the bug is still valid, so it's best to keep this issue open in order to track it. A better time to close it is when the PR fixing the bug is merged.
shurcooL commented on utility idea: print code defining a… in github.com/dominikh/go-tools3d
> except we'd support a wider range of identifiers with a better input syntax. Just checking, are you familiar with the input syntax of `go doc` (as opposed to `godoc`)? As of Go 1.5, it was reworke…
shurcooL commented on Is this package meant to be shared … in github.com/oskca/gopherjs-canvas3d
Great! In case you missed it, I'll point to this again: > You might also find this commit interesting, https://github.com/dominikh/go-js-dom/commit/6a8015da13438f4de2c715e781271ab856b4b24c, jus…
shurcooL commented on Add a way to supply go/build.Import… in github.com/kisielk/gotool3d
I really think the best solution here is for you to fork `gotool` and modify your copy as you wish for the needs of your experiment. These options don't make sense in the context of the primary purpo…
shurcooL pushed to master in github.com/shurcooL/vfsgen3d
43205b89421587a39b140735340dc8ec40f03669Generate output in-memory, then write all at once.
shurcooL commented on Support atomic writes in github.com/shurcooL/vfsgen3d
Most generated files should be quite small, a few MB at most. They'll easily fit into memory. So, I've decided to go with this strategy: > One idea to consider is to compute the output file con…
shurcooL pushed to master in github.com/shurcooL/home3d
45a01ba39f6421e54db1dfb8989ec4c25320fca5assets: Regenerate.
31c24b5f4d476139c19de00b6ebb56b80565099babout: 2018 is the Year of the Gopher.
shurcooL pushed to master in github.com/shurcooL/resume3d
310209813bdbf0f358e402e5107eb0cc69b67529frontend: Exclude header and reactions from print media.
a74416b74c37bb0573e7ad9c89a513aaf1a1555cAdd Open Source Contributor experience for 2017.
shurcooL commented on Implicit type conversion of nil val… in github.com/gopherjs/gopherjs4d
It happens with explicit conversion too. https://gopherjs.github.io/playground/#/lPNKCUaPbG
shurcooL commented on staticcheck: flag "defer" in TestMa… in github.com/dominikh/go-tools4d
> A defer in TestMain scope will never execute since TestMain(*testing.M) is expected to use os.Exit. Unless there’s a panic before `os.Exit` runs.
shurcooL commented on Same reference for multiple heading in github.com/shurcooL/github_flavored_markdown4d
Nice! > My question is, should we add prefix `user-content` to `id` just like what GitHub did, or should we leave it as it is ? That's a good question. It's interesting that clicking on anchors in…
shurcooL commented on Same reference for multiple heading in github.com/shurcooL/github_flavored_markdown4d
Thanks for reporting (with good reproduce steps). This is a valid bug. It's a (well-defined) subset of issue #11. Resolving this is likely going to be somewhat involved. It will require keeping trac…
shurcooL pushed to patch-1 in github.com/shurcooL/woff4d
df50bf81f36c0cf42a38d126eaf45bbd9bb1ccf3Fix typo in ReadUIntBase128 pseudo-code.
shurcooL commented on Go 1.10 support. in github.com/gopherjs/gopherjs4d
A few small updates on my progress here. Most notably, I've figured out the Linux issue causing stalls, making CI output completely useless. It was an incorrect implementation of `syscall.Exit` fo…
shurcooL commented on make clean all fails with error in github.com/google/woff25d
This issue has been resolved (via PR #72 and commit c9ad29d3495d201b5fdd6d73e4bcb076eecdb522) and can be closed.
shurcooL commented on c9ad29d3495d201b5fdd6d73e4bcb076eecdb522Correct setup of ARFLAGS in github.com/google/woff25d
Does this change the behavior in any way? Or is it just a style change/refactor?
Last Week
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs6d
42f14a7b473e7e91f3314fc2872015f8fc63fe3dcompiler/natives: Regenerate.
0c9f81a6dd3cf60905702536aa00b9e79ed0399ccompiler/natives/src/bytes: Skip all tests that rely on syscall.Getpagesize.
6a853f3d4930f3fbacc911267d98699db6dda30fWIP: Try a fix for Linux os.Exit stalls.
5dd84adb4a9e29beb092edcfdfd8c7fbe65b6b46compiler/natives/src/runtime: Stop using sys.DefaultGoroot.
f287dbc66ae9b4df550d25d808968b0436c8e4cfTarget Go 1.10 Beta 2.
0cb05c5224374caeb24ee03bd4494030af100ad0WIP: Better solution for method name encoding mismatch.
da23df8262780a0fdf35908aa0c291fe976cd67eRevert "compiler/natives/src/reflect: Don't skip string internalization for types."
shurcooL deleted branch in github.com/gopherjs/gopherjs6d
go1.10-test1
shurcooL created branch in github.com/gopherjs/gopherjs6d
go1.10-test1
shurcooL commented on reflect: avoid dereferencing non-po… in github.com/gopherjs/gopherjs1w
@hajimehoshi Help with maintaining this project would be greatly appreciated, thanks for the offer. I'll want to discuss it in more detail with you on Slack, hopefully soon. But first let's focus …
shurcooL starred github.com/google/uuid1w
shurcooL commented on megacheck: false positive SA4011? in github.com/dominikh/go-tools1w
As a recommendation, if you'd really like to emphasize that the select case is empty, consider using a `// Do nothing.` comment. See https://play.golang.org/p/lB3Tos7DOhq. It makes it clear case is e…
shurcooL commented on Does freetype-go support TTF's embe… in github.com/golang/freetype1w
The README contains the following note, which I suspect answers your question: ``` It is an incomplete port: * It only supports TrueType fonts, and not Type 1 fonts nor bitmap fonts. * It o…
shurcooL pushed to go1.10 in github.com/gopherjs/gopherjs1w
789b864112916abd4763abd323b04689e18ef95ecompiler/natives: Regenerate.
0d1476f7bf4c5be46a3068206254ca93bb0f4b1bcompiler/natives/src/reflect: Implement throw.
shurcooL commented on Fix "sync: inconsistent mutex state… in github.com/gopherjs/gopherjs1w
It would be nice to document what this map tracks.
shurcooL commented on sync: inconsistent mutex state in github.com/gopherjs/gopherjs1w
Hey @canning-duck. Thanks for filing this issue and investigating it! When implementing the changes for Go 1.9, I ran into this issue and didn't have enough time to investigate it fully, that's why…
shurcooL pushed to master in github.com/shurcooL/githubql1w
64ccad5b650f61172b48822ba7ce345127ccce5eRegenerate for 2017-12-15 schema changes.
shurcooL commented on gmlewis offline until late December in github.com/google/go-github1w
I think this can be closed now, right? Welcome back @gmlewis! :)
shurcooL commented on Source map support not working in github.com/gopherjs/gopherjs1w
For me, `node --require "source-map-support/register" --eval ""` produces no output and 0 exit code. You might need to set `NODE_PATH` environment variable, so that node knows where to find packages…
shurcooL deleted branch in github.com/google/go-github1w
hardcode-2017
shurcooL pushed to master in github.com/google/go-github1w
c988f775700b9ab14b5acb7502046fa341daf82dHardcode 2017 as copyright year in github-accessors.go. (#825)
shurcooL commented on Support preview GraphQL API v4 Node… in github.com/google/go-github1w
Merged. Thanks a lot for working on this @anubhakushwaha!
shurcooL pushed to master in github.com/google/go-github1w
cbeb72eaf5a287299bd4eca3de3a77985370d6f5Support preview GraphQL API v4 Node IDs. (#817)
shurcooL commented on Support preview GraphQL API v4 Node… in github.com/google/go-github1w
I've applied this trivial change.
shurcooL pushed to graphQL in github.com/anubhakushwaha/go-github1w
3eab45db5ec9a89bb1420f08418cc0099b510073Continue to use 2017 as the copyright year in github-accessors.go.
shurcooL commented on Support preview GraphQL API v4 Node… in github.com/google/go-github1w
You'll need to revert this change. See #823 for the reason why. Sorry about the trouble.
shurcooL commented on Which year should the generated fil… in github.com/google/go-github1w
Makes sense, thanks Glenn!
shurcooL created branch in github.com/google/go-github1w
hardcode-2017
shurcooL commented on Added examples to the README in github.com/google/go-github1w
The copyright header and the package comment should be separate comments. Like this: ```Go // Copyright 2017 The go-github AUTHORS. All rights reserved. // // Use of this source code is governe…
shurcooL commented on Added examples to the README in github.com/google/go-github1w
Additionally, you should update `doc.go` with the same changes to keep it in sync with README.
shurcooL commented on Added examples to the README in github.com/google/go-github1w
Sounds good.
shurcooL pushed to master in github.com/shurcooL/home1w
83baea195d15c13d39b2fff6b7427fcc7ef6ad9cUpdate for go.uuid API change.
shurcooL commented on Is this package meant to be shared … in github.com/oskca/gopherjs-canvas1w
I see, thanks for answering. You might find this commit interesting, https://github.com/dominikh/go-js-dom/commit/6a8015da13438f4de2c715e781271ab856b4b24c, just FYI.
shurcooL pushed to master in github.com/shurcooL/play1w
51fe0152594c90a86a1920e8437dc0cd7f4fdc70Play with rendering a TrueType font to a CanvasRenderingContext2D (in browser).
3664bd934d404d10eba9eda3b6baeef9e44ab27bPlay with rendering a TrueType font.
shurcooL deleted branch in github.com/dominikh/go-js-dom1w
ImageData-implement-draw.Image
shurcooL pushed to master in github.com/dominikh/go-js-dom1w
6a8015da13438f4de2c715e781271ab856b4b24cMake ImageData implement draw.Image interface (#50)
shurcooL pushed to ImageData-implement-draw.Image in github.com/dominikh/go-js-dom1w
339f7527838b20d05cc85ebd1f88bec7571ed22aMake ImageData implement draw.Image interface
shurcooL created branch in github.com/dominikh/go-js-dom1w
ImageData-implement-draw.Image
shurcooL commented on Is this package meant to be shared … in github.com/oskca/gopherjs-canvas1w
Did you see this question @oskca?
Earlier
shurcooL commented on Do I have to send multiple requests… in github.com/shurcooL/githubql1w
> Say I'm fetching followers, using similar code as the [pagination](https://github.com/shurcooL/githubql#pagination) example. Now, if I have 600 followers, does it mean I have to send 6 requests to …
shurcooL pushed to master in github.com/shurcooL-legacy/Conception-go1w
a57c772cbb6a0b26144c2a199e6fef95b6d5fbbeRename OpenGlStream to OpenGLStream.
shurcooL commented on Add Outside Collaborators API for O… in github.com/google/go-github1w
There is a CI failure after I merged this PR. It's harmless and has nothing to do with the content of this PR, just that this happened to be the first PR merged in 2018. I've filed issue #823 about i…
shurcooL pushed to master in github.com/google/go-github1w
218ecc238cf77bbaa2e16a54cada252ec87e7d6eAdd Outside Collaborators API to OrganizationsService. (#812)
shurcooL pushed to outside_collaborators in github.com/kshitij10496/go-github1w
de0fab78a649b550987f2b25bf455361523552a3Use consistent lower case "status code".
shurcooL commented on Add Outside Collaborators API for O… in github.com/google/go-github1w
Nit; capital "S" in "Status code" here but not anyone else. It should be lowercase for consistency.
shurcooL commented on Migrate IDs to int64 type in github.com/google/go-github1w
> I can't remember now if you also wanted to add a type ID int64 to the code or leave it like this? @gmlewis There was relevant discussion in the issue (#597), specifically this https://github.com…
shurcooL commented on Support preview GraphQL API v4 Node… in github.com/google/go-github2w
Are you still planning to do this? Just checking.
shurcooL commented on Support preview GraphQL API v4 Node… in github.com/google/go-github2w
I think it'd be nicer to either move `NodeID` field up, together with all other fields, or add a blank line after `CommentCount`, since it has a comment saying that "This is only populated for reques…
shurcooL commented on Support preview GraphQL API v4 Node… in github.com/google/go-github2w
Okay, keeping it as is is completely acceptable.
shurcooL commented on Migrate IDs to int64 type in github.com/google/go-github2w
> Also, shouldn't we mention the fact that the client now uses `int64` ID values in the documentation? Sure, if there's a good place for it. Can you think of one? I don't think it's critical fo…