Activity
Yesterday
dmitshur commented on golang.org/x/crypto/ssh: return partial success immediately from publickey auth13h
The trybot failure on that one builder seems like an infrastructure problem; sent crrev.com/c/7842813 (CC @cherryyz@google.com) to start annotating such cases accordingly in the future. Retrying tryb…dmitshur commented on debug/pe: missing saferio validation in ZLIB section decompression13h
CC @golang/windows.dmitshur commented on cmd/go/internal/telemetrystats: add go/platform/target/port:*-* counter13h
Thanks.This Week
dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count1d
One way to keep the function (with possible side effects) executed the same number of times might be to use slices.ContainsFunc with a trivial equality func. That is, if the for range loop is rewritt…dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count1d
@gopherbot Please consider this for backport to Go 1.26. It's needed to prevent `go fix` from incorrectly rewriting code to use `slices.Contains` in some cases when doing so could cause an unintended…dmitshur commented on golang.org/x/crypto/blake2b: merge go125.go into blake2b_test.go2d
Thanks.Last Week
dmitshur reopened an issue runtime: crash in WASM plugins without open file descriptors due to `poll_oneoff` call4d
Reopening since the information in https://github.com/golang/go/issues/78513#issuecomment-4215930937 suggests this can be an enhancement.dmitshur reopened an issue runtime: crash in WASM plugins without open file descriptors due to `poll_oneoff` call4d
Reopening since the information in https://github.com/golang/go/issues/78513#issuecomment-4215930937 suggests this can be an enhancement.dmitshur commented on golang.org/x/benchmarks/go.mod: update golang.org/x dependencies4d
Done in PS 3 by updating to `x/net@v0.54.1-0.20260508232935-23ee2efe81a3`.dmitshur commented on golang.org/x/build/go.mod: update golang.org/x dependencies4d
(1 comment)
I'll update this to v0.54.1-0.20260508232935-23ee2efe81a3 to pull in the fix in CL 776180, needed to break build errors at tip.dmitshur reviewed +2 on golang.org/x/net/http2: avoid API changes when built with go1.274d
Thanks.
(nit) Could get rid of ": removed" here, it's not needed.
Edit: Already resolved in PS 5.
(Same here and the two lines below.)
Edit: Already resolved in PS 5.
We don't want to check in t…dmitshur commented on golang.org/x/benchmarks/go.mod: update golang.org/x dependencies4d
The change itself is good, though trybots are reporting a build breakage at tip because x/net v0.54.0 accidentally included breaking API changes (that affect tip only, not any of the stable Go releas…dmitshur reviewed +2 on golang.org/x/net/http2: avoid API changes when built with go1.274d
Thanks.
There are a few more symbols that also need attention, in case you prefer to handle them in the same CL, though of course it's fine to submit this one as is since it's making forward progres…dmitshur opened an issue cmd/api: run api check on all golang.org/x modules that have reached v1.0.0 or higher4d
The cmd/api check runs in the main Go repo and is generally very helpful there. There are some opportunities to extend it, such as issues #53205 and #56773. I didn't find an existing issue for extend…dmitshur closed an issue cmd/api:check: TestCheck failures4d
Looks like a memory bit flip on a darwin builder that happened exactly once in years. Closing in favor of issue #77515.dmitshur commented on golang.org/x/tools/go.mod: update golang.org/x dependencies4d
(1 comment)
I'm not sure off hand, other than it's plausibly related to https://go.dev/ref/mod#graph-pruning, but a few observations:
1. these records are only for go.mod files of x/crypto modules,…dmitshur commented on golang.org/x/telemetry/x/telemetry/config: add counter for goimports invocation4d
(3 comments)
```suggestion
internal/chartconfig: add counter for goimports invocation
```
(The "x/telemetry" prefix is needed on the issue tracker because it tracks all x/ repos in one place, where…dmitshur fixed an issue golang.org/x/tools/cmd/goimports: add counter for each invocation4d
dmitshur fixed an issue golang.org/x/tools/cmd/goimports: add counter for each invocation4d
Issue #75651 also exists to track adding the telemetry config. So this can proably stay focused on adding the local counter, which was done in [CL 700595](https://go.dev/cl/700595). Closing again.dmitshur commented on golang.org/x/tools/cmd/goimports: add counter for each invocation4d
Issue #75651 also exists to track adding the telemetry config. So this can proably stay focused on adding the local counter, which was done in [CL 700595](https://go.dev/cl/700595). Closing again.dmitshur fixed an issue golang.org/x/telemetry/config: add counter for toolchain VCS usage4d
Thanks for the suggestion to check local counters in `go env GOTELEMETRYDIR`. They seem as expected to me, and "go/vcs" shows up at https://telemetry.go.dev/config now (thanks to [CL 775820](https://…dmitshur commented on cmd/go/internal/telemetrystats: drop go/platform/target/{goos,goarch}:*4d
(1 comment)
This change is ready for review.
Hold submission for a later release, though it's fine to review now.dmitshur commented on cmd/go/internal/telemetrystats: add go/platform/target/port:*-* counter4d
This change is ready for review.dmitshur reviewed +2 on golang.org/x/build/main.star: add configs for sizespecializedmalloc perf_vs_parent builders4d
Thanks. I wasn't very familiar with our perf_vs_parent runmod, but good to learn more about it.
Just noting that I expect (but haven't confirmed) that it will have the GOEXPERIMENT env var set both …dmitshur commented on golang.org/x/build/cmd/gorebuild: log at start of GerritTarGz4d
Thanks.dmitshur opened a change cmd/go/internal/telemetrystats: drop go/platform/target/{goos,goarch}:*4d
They provide a subset of the information that the newer port:*-* counter
provides, making them generally redundant. They were never uploaded, and
there are no plans to start using them, so remove the…dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add go/platform/target/port:*-* counter4d
(1 comment)
Using two brackets for expansions isn't supported. Even if it were supported, we probably don't want to permit unexpected combinations (like aix-386) to be accepted for upload, so I'll c…dmitshur opened a change golang.org/x/telemetry/internal/chartconfig: add go/platform/target/port:*-* counter4d
The accepted GOOS and GOARCH values come from the 49 ports that
includes 2 broken ports (they may still be attempted to be used)
as reported by 'go tool dist list -broken' at tip, Go 1.27 to be.
For…dmitshur opened a change cmd/go/internal/telemetrystats: add go/platform/target/port:*-* counter4d
CL 587115 added separate counters for target GOOS and target GOARCH:
go/platform/target/{goos,goarch}:*
For the purpose of being able to tell usage of each target port
(telemetry proposal go.dev/i…dmitshur closed a change golang.org/x/open2opaque/...: update golang.org/x dependencies4d
This change has been applied as https://go.googlesource.com/open2opaque/+/3d04330bec09d438a41877cf8c354f63a5fab476.dmitshur commented on golang.org/x/crypto/x509roots/fallback/bundle: fix bundle test with Go 1.27+4d
(1 comment)
Since those steps are fairly predictable and might be easier to do now while the context is fresh in memory, prepared CL 775782 and CL 775783 for that in case it helps.dmitshur opened a change golang.org/x/crypto/blake2b: merge go125.go into blake2b_test.go4d
The go1.25 build constraint is guaranteed to always be satisfied because
the go directive is at 1.25.0, so the separated out go125.go file is not
needed. Move the assertion that the *xof type impleme…dmitshur opened a change golang.org/x/crypto/x509roots/fallback/bundle: make subjectsEqual stricter on Go 1.27+4d
This gradual step towards removing/inlining subjectsEqual can happen
after Go 1.27.0 is released and the bundle starts being generated
with it.dmitshur opened a change golang.org/x/crypto/x509roots/fallback/bundle: inline subjectsEqual4d
This final step of removing/inlining subjectsEqual can happen after
Go 1.28.0 is released.dmitshur commented on cmd/go: add -buildversion build flag4d
@thepudds Thanks for mentioning the VERSION files used by the Go toolchain; I was going to do that too since it hadn't come up yet, and it seems good to at minimum consider in this proposal. I'll not…dmitshur reviewed +2 on golang.org/x/telemetry/godev: update telemetry docker versions to 1.254d
Thanks.
```suggestion
With the go.mod go version updates, we need at least Go 1.25 to build
```
Using 1.25 is certainly fine as is, since it meets the minimum requirement of this module. Just notin…dmitshur commented on golang.org/x/build/cmd/gorebuild: log at start of GerritTarGz4d
Friendly ping since it's been a while. Thanks.dmitshur opened a change all: [release-branch.go1.4] update to be compatible with C234d
The 'typedef int bool;' line has become a compile error as of -std=c23
because bool became a reserved keyword. true and iszero are also newly
reserved.
Gain compatibility with C23 by switching to '#…dmitshur reviewed +2 on go/importer: un-deprecate importer.ForCompiler5d
Thanks.dmitshur commented on golang.org/x/build/internal/relui: return an authenticated-only Gitiles URL in ArchiveURL5d
Thanks.dmitshur reviewed +2 on golang.org/x/tools/gopls/internal/analysis/errorsastype: imporove example clarity5d
Thanks.dmitshur commented on golang.org/x/tools/gopls: add errorsastype analyzer5d
@mpoliwczak34@gmail.com Thanks for making this change. I left a small comment inline.
A comment/suggestion on the example, which is used in multiple places.
I recognize that it's intended to show a…dmitshur opened a change golang.org/x/build/internal/relui: return an authenticated-only Gitiles URL in ArchiveURL5d
We're intending to always use authentication here, so the /a/ endpoint
should work. (It would tell us if somehow we're making unauthenticated
requests, and maybe has different quotas associated with …dmitshur commented on cmd/go: add `-test` to `go doc`6d
https://go.dev/doc/comment documents the concept of "Go doc comments" and how to write them. Go users who are looking to document exported APIs rely on the mechanisms there because it has effect on t…dmitshur reviewed +2 on golang.org/x/build/repos: add dot-github to mirror to golang/.github6d
Thanks.
Feel free to submit as soon as as https://go.googlesource.com/dot-github exists. (Submitting it before then would cause x/build/cmd/gitmirror to run into errors if we were to redeploy it, so…dmitshur commented on golang.org/x/open2opaque/...: update golang.org/x dependencies6d
(1 comment)
I almost forgot and somehow remembered this, [again](https://go-review.googlesource.com/c/open2opaque/+/678895/comment/0188ea8c_6055f78a/). This time before this CL is submitted, so Hold…dmitshur opened an issue google.golang.org/open2opaque: Go tip (Go 1.27 to be) runs into "export data version 3 is greater than maximum supported version 2" problem because required x/tools version isn't new enough for Go 1.27 needs6d
As visible on the post-submit dashboard at https://ci.chromium.org/p/golang/g/z-open2opaque-gotip-by-go/console, there are on the order of 400 failing tests at Go tip (Go 1.27 to be), for example:
`…dmitshur opened an issue golang.org/x/build/cmd/golangbuild: add support for test artifacts in LUCI6d
Proposal #71287 to add support for test artifacts was accepted and implemented in Go 1.26. We should update golangbuild accordingly, so that it's possible for us to take advantage of this new feature…> I'm happy to make whatever changes are needed to packages.Load but I'm not sure what they are.
@adonovan The documentation at https://pkg.go.dev/golang.org/x/tools/go/packages#Config.Env includes …dmitshur commented on golang.org/x/telemetry/config: add counter for toolchain VCS usage6d
@h9jiang Given [CL 729480](https://go.dev/cl/729480) is submitted, do you know if it's expected to start to show up at https://telemetry.go.dev/config now? Is it waiting on a redeploy to pick that ch…dmitshur commented on runtime: TestFinalizerOrCleanupDeadlock/Finalizer/Panic failures6d
CC @golang/compiler.dmitshur commented on cmd/compile: known bits and prove constant folding can impede memcombine6d
From triage, this sounds like an enhancement. @Jorropo Are you planning to work on this or did you mean to report it so someone else can pick this up?From triage, we discussed this and believe the go command itself is working as intended. It's expected that the intended version of the go command needs to be first in PATH environment variable. We'r…dmitshur closed an issue runtime:mayMoreStackPreempt: TestNotInGoMetric/CgoCall failures6d
dmitshur commented on runtime: TestBigStackCallbackCgo failures6d
From triage, it seems windows-386 is running into 180 second timeout in some packages like runtime, net/http more frequently recently.dmitshur commented on cmd/asm: don't allow writes outside of a function's stack frame6d
CC @golang/compiler.
From triage, we think this probably cannot be made to fail to compile, but instead can be a vet check.dmitshur commented on go/importer: documentation of lookup parameter of ForCompiler can be clarified6d
The cmd/api checker bug is fixed, and there's no API change involved, so I think this can become a regular issue to improve documentation clarity. Retitled.dmitshur closed an issue crypto/internal/fips140/drbg: backport CL 774221 to Go 1.26 [1.27 backport]6d
This is a false positive due to #27489: the backport request was for 1.26 only, "1.27" happened to be mentioned for an unrelated reason (CC @cherrymui). Though it means the heuristic of ignoring othe…dmitshur closed an issue crypto/internal/fips140/drbg: backport CL 774221 to Go 1.26 [1.27 backport]6d
This is a false positive due to #27489: the backport request was for 1.26 only, "1.27" happened to be mentioned for an unrelated reason (CC @cherrymui). Though it means the heuristic of ignoring othe…dmitshur commented on golang.org/x/telemetry/config: add counter for toolchain VCS usage1w
go/vcs:{git,hg,svn,bzr,fossil} covers all of the VCSes but one: the "mod" pseudo-vcs which represents the "neither Git, Mercurial, etc. was used" case. Given the goal of this proposal is to give insi…dmitshur commented on : setup `.github` repo for default community health files1w
I think it's a good idea at least for the PULL_REQUEST_TEMPLATE file. That template seems pretty general and applies to all Gerrit repositories mirrored to GitHub that accept PRs via [gerritbot](http…dmitshur commented on golang.org/x/telemetry/config: counters for target GOOS/GOARCH1w
I'm supportive of adding these counters.
Some of the Go ports may be commonly targeted via cross-compilation from other host platforms, and some Go ports are only accessible as cross-compilation tar…dmitshur opened an issue cmd/dist: inverted precedence for && and || in exprParser1w
cmd/dist has a small //go:build constraint parser and evaluator for the needs of bootstrapping. Back when it was added ([CL 359314](https://go.dev/cl/359314), CC @rsc), go/build/constraint couldn't b…Earlier
dmitshur opened an issue cmd/go: go mod tidy can automatically maintain toolchain directive when godebug default requires a higher toolchain1w
This is a minor friction report and a suggested feature request to address it, similar to #74739, except it's about the `godebug` directive and its default key.
Consider a module with a `go 1.25.0` …dmitshur closed an issue build: build failure on gotip-linux-loong641w
dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y