Activity
Today
dmitshur opened a change golang.org/x/build/internal/task: check for open documentation-only CLs before moving them11m
If there are in-flight CLs for doc/next, it might make sense to finish
them before moving the release notes into x/website. This is something
the release coordinator may do manually, so add an automa…Yesterday
dmitshur reviewed +2 on golang.org/x/website/...: remove unreachable code16h
Thanks.
This comment refers to the deleted initHandler below. I suppose it’s fine to delete it by now since moving projects will force us to deal with the missing root key one way or another.
Thi…dmitshur closed an issue golang.org/x/crypto/openpgp/clearsign: TestMultiSign failures16h
Duplicate of #70682.dmitshur commented on golang.org/x/mobile/go.mod: update golang.org/x dependencies17h
(1 comment)
Yeah, it looks like it's newly needed by x/tools/go/packages tests as of x/tools v0.28.0:
```
mobile $ go mod why -m github.com/google/go-cmp
# github.com/google/go-cmp
(main module doe…dmitshur reviewed +1 on doc/next: add linker change release notes17h
Thanks.
Since CL 618598 and issue 68678 are now handled, you could remove this line from the 'Needs to be documented and tracked via a release-blocking issue.' section.
It's fine not to worry about…dmitshur commented on io/fs: add ReadLinkFS interface [freeze exception]17h
We considered this freeze exception in a release meeting today. This seems to be a new API that would be safe to land in the next upcoming major Go release, Go 1.25, so that if there are unexpected i…dmitshur commented on doc/next: add release notes for runtime and sync18h
(1 comment)
(CL 633835 improved the test error message.)dmitshur commented on golang.org/x/website/cmd/golangorg: suggest working new issue link in TestAll18h
Thanks.dmitshur opened a change golang.org/x/website/cmd/golangorg: suggest relative links for /issue/ and /wiki/ cases18h
The test already requires "https://go.dev/page" links to be written as
relative "/page" ones; it looks like an oversight not to do that right
away in these two cases.dmitshur opened a change golang.org/x/website/cmd/golangorg: suggest working new issue link in TestAll18h
https://go.dev/issue/new already redirects to GitHub's issue tracker
with the "/choose" suffix, and
https://go.dev/issue/new/choose is 404.
Improve the test to handle this case and suggest the right …dmitshur commented on doc/next: add release notes for runtime and sync19h
(1 comment)
Since https://go.dev/issue/new redirects to https://github.com/golang/go/issues/new/choose and https://go.dev/issue/new/choose is 404, I think what you're looking for is:
```suggestion…dmitshur commented on golang.org/x/crypto/openpgp/clearsign: TestMultiSign fails with "random source is broken" at Go tip19h
Thanks for the quick fix! The monthly golang.org/x tagging workflow ran into this, and the fix enabled it to keep going (https://go.googlesource.com/crypto/+/refs/tags/v0.30.0).dmitshur opened a change golang.org/x/build/internal/task: add detection for repeated task runs19h
The expected happy path is that the "between freeze start and RC 1"
workflow is run once to completion and not again. Still, it might
happen that we run it more than once, intentionally or accidental…dmitshur created repository in github.com/golang/open2opaque19h
dmitshur reviewed +2 on golang.org/x/tools/internal/versions: remove constraint.GoVersion wrapper20h
I'm not familiar with conventions for gopls-release-branch.* branches in x/tools, so feel free to ask Tim to also look, but LGTM since this matches the original CL 632356.
In other places I've seen …dmitshur commented on golang.org/x/website/_content/doc: add merged go1.24.md21h
@mknyszek@google.com suggested waiting a bit and redoing this after a few in flight CLs land, so adding a Hold+1 for that. (We can also close the CL.)dmitshur commented on golang.org/x/build/...: use consistent style for owner, repo parameters [generated]22h
(1 comment)
Indeed, that's a good idea and it would've been better to include it. (I generally [do that](https://go-review.googlesource.com/c/build/+/527016/2//COMMIT_MSG#23), but forgot this time.)dmitshur commented on golang.org/x/build/cmd/relui: add a "between freeze start and RC 1" workflow22h
(3 comments)
This change is ready for review.
Ok, PS 2 should be ready from my side. I tried a brief dry run (i.e., without real Gerrit/GitHub clients) locally and there weren't clear problems visi…dmitshur reviewed +2 on go.dev/wiki/Modules: add go1.24 tools22h
Thanks. I'm not seeing any issues, though Michael would be more familiar with this change than I am.dmitshur opened an issue golang.org/x/crypto/openpgp/clearsign: TestMultiSign fails with "random source is broken" at Go tip23h
At Go tip, TestMultiSign fails when run without -short flag, including on first class ports like linux/amd64:
```
=== RUN TestMultiSign
clearsign_test.go:155: cannot create key: rsa: gener…dmitshur commented on lib/time: update tzdata before release23h
Added okay-after-rc1 since RC 1 is scheduled for [next week](https://go.dev/s/release#june--december-week-2-release-candidate-1-issued) and 2024b is still the latest available version. (CC @mknyszek.…dmitshur opened a change golang.org/x/build/cmd/relui: add a "between freeze start and RC 1" workflow23h
This workflow automates the following sequence that we need to do for
every major Go release cycle sometime between freeze start and RC 1:
• Update the API check.
• cat api/next/*.txt | sort >…dmitshur opened a change golang.org/x/build/internal/task: move "unwait" task to ReleaseCycleTasks, add "apply wait"23h
The new "apply wait" task is analogous to the existing "unwait" one,
and was tested out during the Go 1.24 freeze two weeks ago.
Move both of them into a new release cycle-focused struct where more
…dmitshur opened a change golang.org/x/build/cmd/relnote: let 'path' be implicit, move 'title' up23h
No need to repeat the path when it's implicitly specified via file path
in x/website/_content. Also move the title key to be higher up. This is
to make the generator match what we've been doing in x/…dmitshur opened a change golang.org/x/build/...: use consistent style for owner, repo parameters [generated]23h
Many instances already use the shorter "owner, repo string" form.
Fix a few that didn't. This will get that diff out of future CLs.
For golang/go#70655.
[git-generate]
find . -type f -name '*.go' -…dmitshur deleted branch in github.com/shurcooL/git-branches1d
8weeksdmitshur pushed to
main in github.com/shurcooL/git-branches1d
This Week
dmitshur reviewed +2 on golang.org/x/build/main.star: update go-internal branches1d
Thanks.
I understand it considered that a single regexp can be made to match both, and a list of regexp was chosen anyway because it's deemed more readable.dmitshur commented on golang.org/x/tools/godoc/vfs: ReadDir reports files as directories after Bind was called on a file1d
@seankhliao I don't see a [frozen notice](https://go.dev/wiki/Frozen) convention applied to golang.org/x/tools/godoc nor golang.org/x/tools/godoc/vfs. It doesn't seem to be frozen? Does that still ne…dmitshur opened an issue golang.org/x/build/cmd/relui: add workflows for some remaining manual recurring Go major release cycle tasks2d
In addition to workflows for all of Go release types, relui holds a few workflows for miscellaneous recurring tasks that come up in the release cycle (go.dev/s/release) such as [pinging early-in-cycl…dmitshur commented on golang.org/x/tools/godoc/vfs: path separator character(s) in FileSystem, Opener interfaces is not specified2d
This issue is still valid and relevant to the package, but the package itself is probably less relevant now that io/fs exists. It should probably be deprecated in favor of that as part of #59056.dmitshur commented on golang.org/x/tools/godoc/vfs/zipfs: remove zipfs package2d
By now we have answers to that question from 6 years ago about how to do this: removing a golang.org/x package involves deprecating it, isolating it to its own nested module, tagging that, and then d…dmitshur commented on testing: consider -N suffix after benchmark name optional2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: update github.com/creack/pty to v1.1.232d
The v1.1.20 -> v1.1.23 diff in code is quite small, and reasonable. Thanks. (Note there's also a v1.1.24 out by now.)dmitshur reviewed +2 on golang.org/x/build/internal/coordinator/remote: remove SSH environment setup for swarming2d
Thanks.
(nit) This outer `func()` was unavoidable previously, because there were two function calls in the goroutine. Now that it's down to one, it's viable to skip it if desired.
```suggestion
go…dmitshur opened an issue testing: TestBenchmarkBLoopIterationCorrect fails under GOMAXPROCS=13d
At tip (commit c5adb8216968be46bd11f7b7360a7c8bde1258d9), TestBenchmarkBLoopIterationCorrect succeeds under most conditions.
<details><br>
```
$ go test -run=^TestBenchmarkBLoopIterationCorrec…Last Week
dmitshur starred github.com/randomouscrap98/ardugotools6d
dmitshur reviewed +2 on github.com/golang/groupcache/...: add go.mod, update for Go 1.246d
LGTM. Thanks.dmitshur reviewed +2 on github.com/golang/groupcache/...: add go.mod, update for Go 1.246d
LGTM. Thanks.dmitshur commented on github.com/golang/groupcache/...: add go.mod, update for Go 1.246d
(minor) Oddly, this go-cmp go.mod checksum entry, as well as the xerrors go.mod entry on line 6, do not show up for me after a `go mod tidy` with go1.23.3. But extra lines in go.sum are harmless.dmitshur closed an issue golang.org/x/build: golang.org/x/xerrors repository isn't on build.golang.org dashboard1w
We solved this during the migration to LUCI, golang.org/x/xerrors has post-submit builders visible on its dashboard (e.g., https://ci.chromium.org/p/golang/g/x-xerrors-gotip/console). It's still not …dmitshur fixed an issue sync/atomic: TestNilDeref flaky failure on windows-386 with runtime fatal error1w
The fix is backported and this shouldn't happen on release branches either, now. Closing again.dmitshur commented on golang.org/x/tools/go/packages: gotypesalias=1 does not seem to get used correctly for deps on Go 1.231w
@mvdan This issue can indeed be marked as closed since it's resolved in Go 1.24, but the Go1.24 milestone is right. There are child backport issues that need to refer to this one. We need a parent is…dmitshur commented on os: TestGetwdDeepWithPWDSet failures1w
This is a continuation of https://github.com/golang/go/issues/69234#issuecomment-2501169320. So far, These particular failures seem to only happen on the darwin/amd64 builders with macOS 11.dmitshur pushed to
master in github.com/mdempsky/unconvert1w
dmitshur merged a change github.com/mdempsky/unconvert/...: replace deprecated io/ioutil with os1w
dmitshur reviewed +2 on github.com/mdempsky/unconvert/...: replace deprecated io/ioutil with os1w
Thanks.dmitshur opened an issue cmd/link: document that on ELF, GNU build ID is now generated by default1w
A [comment on CL 618601](https://go-review.git.corp.google.com/c/go/+/618601/comments/3d652992_21d045d6) indicated that the change (which fixed #63934 and #68652) should likely be mentioned in [Go 1.…dmitshur reopened an issue cmd/link: LC_UUID not generated by go linker, resulting in failure to access local network on macOS 151w
A [comment on the CL](https://go-review.googlesource.com/c/go/+/618598/comments/6a1b5da8_513f46c7) suggested that this change should be mentioned in [Go 1.24 release notes](https://github.com/golang/…dmitshur commented on testing/synctest: experimental package for testing concurrent code1w
@neild This change (a package available only when an experiment is set) should be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), otherwise users might not know it ex…dmitshur reopened an issue crypto/tls: automatic CurvePreferences ordering1w
This looks like a change that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Reopening as a release blocker to track that.dmitshur commented on crypto/tls: SecP256r1MLKEM768 and X25519MLKEM7681w
It looks like [CL 630775](https://go.dev/cl/630775) implemented most of this proposal if not all, though it didn't close it. What's left for Go 1.24? Is it just SecP256r1MLKEM768, which according to …dmitshur reopened an issue cmd/go: cache link output binaries in the build cache1w
This cmd/go change might be noteworthy enough¹ to be covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), so reopening with a release blocker to track that.
¹ In additi…dmitshur reopened an issue crypto/x509: generate serial number for nil template SerialNumber1w
@rolandshoemaker There's no API change here, but this still seems like a change that should be covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Mentioning…dmitshur commented on cmd/compile: relax wasm/wasm32 function import signature type constraints1w
@cherrymui Do you think that wasm change (in CL 626615) is something to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)?dmitshur commented on crypto/rand: crash process on error reading randomness1w
@FiloSottile Does this change need to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)? Thanks.dmitshur commented on spec: document promotion of methods from embedded aliases of unnamed types1w
@griesemer Do you think there's anything to be said in [Go 1.24 release notes](https://github.com/golang/go/issues/68545) about this? Or is it fine not to mention it there since this a clarification …dmitshur reopened an issue cmd/vet: warn on 3-clause loops where an iterator variable contains a lock type when GoVersion>=1.221w
This vet change seems like something that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), and it's not mentioned there yet. Reopening as a release blocker…dmitshur reopened an issue cmd/compile: add go:wasmexport directive1w
This looks like a change that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545); that doesn't seem to be done yet. Reopening as a release blocker to track th…dmitshur commented on crypto/ecdsa: generate RFC 6979 signatures if rand is nil1w
@FiloSottile Does this change need to covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)?dmitshur reopened an issue cmd/vet: consider reporting invalid/ignored Go versions in build tags1w
A new check added to vet seems like something that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), and it's not mentioned there yet. Reopening as a releas…dmitshur reopened an issue cmd/vet: report printf calls with non-const format and no args1w
This vet change is new to Go 1.24 and still needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), right? Reopening with a release blocker label to track that.dmitshur reopened an issue cmd/cgo: add #cgo noescape/nocallback annotations1w
This change (enabling these directives in Go 1.24) is documented in cmd/cgo [package docs](https://pkg.go.dev/cmd/cgo@master#hdr-Optimizing_calls_of_C_code), but it seems a note in [Go 1.24 release n…dmitshur commented on testing: normalize line endings in example output comparisons1w
@ianlancetaylor Do you think this needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)? Or should this be considered a minor bug fix on Windows (despite going t…dmitshur reopened an issue cmd/go: stamp the pseudo-version in builds generated by `go build`1w
@samthanawalla This new capability seems noteworthy enough that it should be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Reopening as a release blo…dmitshur commented on cmd/go: track tool dependencies in go.mod1w
Adding a release blocker to track mentioning this new cmd/go feature in the [Go 1.24 release notes](https://github.com/golang/go/issues/68545).dmitshur reopened an issue spec: generics: permit type parameters on aliases1w
This Go 1.24 language change isn't currently covered in the [Go 1.24 release notes](https://github.com/golang/go/issues/68545) draft, is it? Reopening as a release blocker to track that.dmitshur commented on cmd/vet: printf analyzer fails with generics1w
@adonovan Ack. That'll happen before RC 1 via another round in #36905, or it can be an individual CL sooner.dmitshur fixed an issue os: TestGetwdDeepWithPWDSet failures [consistent failure]1w
The persistent failures were indeed fixed, but now the test seems to flake with "file name too long" only on darwin/amd64 builders with macOS 11. Since that looks like a different failure mode, I'll …dmitshur fixed an issue golang.org/x/build: OOM on windows-arm64 builder1w
The latest batch is resolved by restarting these. This is likely to happen again in about a month while the root issue (#66962) is unresolved.dmitshur reopened an issue crypto/x509: reject SHA-1 signatures in Verify1w
Thanks. Reopening this with a release blocker so it's tracked.dmitshur commented on testing: benchmark unit properties1w
@aclements Is there anything here that should be included in the Go 1.24 release notes? I also commented on the unsubmitted [CL 357590](https://go.dev/cl/357590).dmitshur commented on crypto/x509: reject SHA-1 signatures in Verify1w
@rolandshoemaker This is documented in godebug.md, but not in the Go 1.24 release notes. Do you think this should be documented there?dmitshur commented on golang.org/x/crypto/cryptotest: new package1w
> It's useful to expose it in x/crypto for external implementations of the interface to use it. It will be vendored back.
If I understand right, it's currently added to the main Go repo as the int…dmitshur commented on cmd/go: define HTTP authentication extension mechanism1w
Adding release-blocker to track updating release notes.Earlier
dmitshur commented on cmd/go: remove test dependency on gopkg.in service1w
This hasn't happened in a while, and it's just being bumped from release to release. Moving to Backlog. (If someone starts working on this, feel free to move to the corresponding release milestone.)dmitshur commented on cmd/dist: trying to build Go from source at tip on Windows / WSL incorrectly tries to download a go1.24.0 toolchain1w
From your description, it sounds like there's something going wrong when you're building Go from source.
I'm not sure if you're running into some problem that only affects the combination of Windo…dmitshur commented on net/http: TestTransportRemovesH2ConnsAfterIdle/h2 failures1w
These "Error enabling Transport HTTP/2 support: protocol https already registered" errors may be fairly new, and if so maybe related to recent net/http changes. Also seeing them in #70299. CC @neild.dmitshur opened an issue all: reopen tree for Go 1.25 development1w
### Current Tree Status: Release freeze for Go 1.24 (see [golang-dev announcement](https://groups.google.com/g/golang-dev/c/JkRenbsSBv4/m/dhcurHI5CwAJ))
Now that we've entered the freeze for Go 1.…dmitshur commented on encoding/binary: Write does not optimise the case of native-format slices1w
CC @griesemer.dmitshur fixed an issue cmd/compile: refactor inline interleaving + very high budget for single-called closures1w
dmitshur commented on cmd/compile: refactor inline interleaving + very high budget for single-called closures [freeze exception]1w
Thanks. It looks like both of those CLs made it in before the freeze started, so a freeze exception isn't needed.dmitshur commented on golang.org/x/tools/go/analysis/passes/copylock: Test failures1w
Happened again in trybots for CL 629635 today (see [build 8730612819953883601](https://ci.chromium.org/b/8730612819953883601)).dmitshur fixed an issue github.com/golang/protobuf/google.golang.org/protobuf/types/known/structpb: TestToStruct fails at Go tip after the runtime map change in Go CL 6277161w
This failure no longer happens at Go tip as of https://go.dev/cl/630279.dmitshur reopened an issue cmd/go: `go get` should give a clearer error with `GO111MODULE=off`1w
Both Go 1.23.3 and Go tip (commit c4e6ab9750e9d673a29203a9f41a517bcdc7a64c) have same behavior as in the original report. @seankhliao It doesn't seem that this is complete.dmitshur commented on crypto/rsa: reimplement GenerateKey per FIPS 186-5 with bigmod [freeze exception]1w
Thanks for letting us know ahead of the freeze. We discussed this and will approve the freeze exception bit here. Please be ready to update your plan if there turn out to be more complications than o…dmitshur closed an issue crypto/des:gofips140: unrecognized failures1w
Merged into #70496.dmitshur closed an issue crypto/cipher:gofips140: unrecognized failures [consistent failure]1w
Merged into #70496.dmitshur commented on : AIX build broken with SIGSEGV2w
CC @golang/aix.dmitshur commented on golang.org/x/mobile: go mobile bind, SIGSYS crash on older Android versions2w
CC @hajimehoshi.dmitshur commented on sync/atomic: TestNilDeref flaky failure on windows-386 with runtime fatal error2w
@gopherbot Please consider this issue for backport. It appears to be a case of stack corruption during fault handling, and we're now seeing this failure on both 1.23 and 1.22 release branches (e.g., …dmitshur closed an issue sync/atomic: TestNilDeref failures2w
It's happening on the Go 1.23 release branch now.
Closing in favor of #70288 again. I relaxed the pattern there and removed this issue from Test Flakes project, so watchflakes sends its reports th…dmitshur commented on os/signal: TestSignalTrace is flaky on openbsd/arm642w
CC @golang/openbsd.dmitshur commented on golang.org/x/text/message: catalog.Var between two substitutions2w
CC @mpvl.dmitshur commented on net/http/cgi: should accept "INCLUDED" as protocol for server side includes2w
Thanks for the report. Note that the net/http/cgi package comment includes "This package is intended primarily for compatibility with existing systems." but it sounds like this issue might affect exi…dmitshur fixed an issue syscall: SyscallN always escapes the variadic argument [1.22 backport]2w
Closed by merging [CL 630215](https://go.dev/cl/630215) (commit 6f05fa7a4f632fee7fadada8d31cf8755c709610) to release-branch.go1.22.dmitshur fixed an issue syscall: SyscallN always escapes the variadic argument [1.23 backport]2w
Closed by merging [CL 630196](https://go.dev/cl/630196) (commit 847cb6f9ca43da48cb10e98808a74a40b41242fa) to release-branch.go1.23.dmitshur opened an issue github.com/golang/protobuf/google.golang.org/protobuf/types/known/structpb: TestToStruct fails at Go tip after the runtime map change in Go CL 6277162w
The TestToStruct test in `google.golang.org/protobuf/types/known/structpb` package has started to fail at Go tip, as of [go.dev/cl/627716](https://go.dev/cl/627716) (CC @randall77):
```
=== RUN …dmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time5mo
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch7mo