Yesterday
dmitshur commented on x/build: many repeating js-wasm bui… in github.com/golang/go7h
Not sure how relevant this is, but both commits exist: - https://github.com/golang/go/commit/dea961ebd9f871b39b3bdaab32f952037f28cd71 - https://github.com/golang/go/commit/3dced519cbabc213df369d9…
dmitshur commented on x/build/cmd/coordinator: ssh proxy … in github.com/golang/go8h
This is one of the issues I'm looking at. In trying to envision how it would work, the following question came up. Given that we have `gomote put`, is scp support going to be needed and helpful? D…
dmitshur commented on Setting go version to "1.10.x" inst… in github.com/travis-ci/travis-ci14h
I believe this issue is resolved as of https://github.com/travis-ci/travis-build/pull/1442#issuecomment-413131247. @cezarsa Please restart your builds and confirm, then feel free to close this issue …
dmitshur commented on gimme 1.x is selecting a beta relea… in github.com/travis-ci/gimme14h
@FiloSottile This issue should be resolved as of https://github.com/travis-ci/travis-build/pull/1442#issuecomment-413131247. Try restarting your failed builds. If it's resolved for you too, this issu…
dmitshur commented on Update gimme to support `.x` Go ver… in github.com/travis-ci/travis-build14h
Confirmed! I’ve restarted [the same build](https://travis-ci.org/shurcooL/home/jobs/416164962) again, and this time I see: ``` Updating gimme … $ gimme version v1.5.1 $ go version go ver…
dmitshur deleted branch in github.com/shurcooL/home16h
try-travis-ci
This Week
dmitshur created branch in github.com/shurcooL/Go-Package-Store1d
cleanup
dmitshur commented on Update gimme to support `.x` Go ver… in github.com/travis-ci/travis-build1d
@cotsog Thanks for following up. I created a new branch in one of my repos, which triggered a new build. Its output is here: https://travis-ci.org/shurcooL/home/jobs/416164962 You can see th…
dmitshur created branch in github.com/shurcooL/home1d
try-travis-ci
dmitshur commented on x/build: fix gomote ssh to COS-base… in github.com/golang/go1d
[CL 129356](https://golang.org/cl/129356) and deploying the new version of `cmd/buildlet` were sufficient to resolve the issue. We just needed to move the SSH server being started to a non-22 port to…
dmitshur commented on godoc/dl: go-import meta tag isn't … in github.com/golang/2d
Yes, this is a very minor issue. Anyone just doing `go get golang.org/dl/gox.y.z` isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).
dmitshur commented on godoc/dl: go-import meta tag isn't … in github.com/golang/2d
Yes, this is a very minor issue. Anyone just doing `go get golang.org/dl/gox.y.z` isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).
dmitshur commented on all: subrepos need to be green in github.com/golang/go2d
The x/tools subrepo tests are currently passing on tip but failing on 1.10 and 1.9 according to https://build.golang.org/. The failures are related to the new `x/tools/go/packages` package have start…
dmitshur commented on gimme 1.x is selecting a beta relea… in github.com/travis-ci/gimme2d
In addition to what @AlekSi mentioned above, there is also issue https://github.com/travis-ci/travis-ci/issues/9652 tracking this. It seems the only remaining step to resolve this is for Travis CI…
dmitshur commented on Update gimme to support `.x` Go ver… in github.com/travis-ci/travis-build3d
> We'll try to get [a gimme v1.5.1 release](https://github.com/travis-ci/gimme/pull/156) and it should be incorporated in a build automatically. Following up on this. The gimme [v1.5.1 release](ht…
dmitshur pushed to master in github.com/shurcooL/home3d
b174fcddb9788ef98b87d0ccc943fe8402ed9330Regenerate assets; update testdata.
247eff08b649dc7c8958f53383a63e6828bad05fUpdate shurcooL username to dmitshur.
dmitshur pushed to master in github.com/shurcooL/resume3d
6097cdf3248d2ed17b38b2e53c09116d9e4da57cAdd new job at Google; update previous date.
025d774ee28f5a414f8a2a7925229b8392fe4c2aUpdate GitHub profile link to dmitshur.
dmitshur commented on Mr Dimitri in github.com/shurcooL/github_flavored_markdown3d
Hi there. Thanks for the compliment. If you're interested in the topic of LCD monitors, I'd suggest you check out https://www.testufo.com/ and https://www.blurbusters.com/ websites, as well as fol…
dmitshur pushed to go1.11 in github.com/gopherjs/gopherjs3d
c343bafa509cca3e579af2c6d02d3599507ce791Regenerate.
555f2ebc4fe34e14b49e9aadee8c4a7ccd47f107Target Go 1.10 Beta 3.
c158b45a639e6e0d7a075e515e46453f885b52e0natives/runtime: Add pkgpath method for _type. (#846)
c405896268a3434427f78c89bc94bbe548b514a3Target Go 1.10 Beta 2.
dmitshur pushed to go1.11 in github.com/gopherjs/gopherjs3d
fbc4d22f5f0f61d94340c296400e23036bb891fenatives/runtime: Add pkgpath method for _type. (#846)
dmitshur pushed to go1.11 in github.com/shurcooL/vfsgen3d
7d79cc4a41682753e5af576b2664f20daf82b878Update for Go 1.11 gofmt change.
62bca832be04bd2bcaabd3b68a6b19a7ec044411cmd/vfsgendev: Clean up computeDoc implementation.
dmitshur pushed to go1.11 in github.com/egonelbre/gopherjs3d
95077157f2a95d18a376feb6393efa6ccd081eabcompiler/{gopherjspkg,natives}: Restore previous version.
Last Week
dmitshur commented on x/build/cmd/gopherbot: lock commit … in github.com/golang/go5d
I've looked into this a bit. I think a better place to implement this might be in `x/build/cmd/gitmirror`, the command responsible for mirroring the canonical git repositories from go.googlesource…
dmitshur commented on natives/runtime: add pkgpath method… in github.com/gopherjs/gopherjs6d
Thanks for PR @egonelbre! This looks like the right fix. I’ll try to get to fully reviewing and merging it within the next few days.
dmitshur commented on Go 1.11 support. in github.com/gopherjs/gopherjs6d
@paralin You’ll need the patch from PR https://github.com/gopherjs/gopherjs/pull/846 to fix that. I haven’t had a chance to merge it yet, but the change looks right from a quick look.
dmitshur commented on Panic: reflect.Value.Interface: can… in github.com/shurcooL/githubv41w
I've investigated this, and it's not the same issue as what I thought it might be. Your struct `m` where the results of the mutation get populated contains an unexported field: ```Go var m str…
dmitshur commented on Panic: reflect.Value.Interface: can… in github.com/shurcooL/githubv41w
Thanks a lot for reporting. I suspect this issue is https://github.com/shurcooL/graphql/issues/11. I've already started a fix for it locally, I just need to finish it and push it. I'll confirm whethe…
dmitshur commented on x/build/devapp: duplicate CL lines … in github.com/golang/go1w
I've deployed the new version and confirmed that the bug is fixed in production. ### Before ![image](https://user-images.githubusercontent.com/1924134/43805898-79d952de-9a6f-11e8-8b10-b77b258c5…
dmitshur commented on generator: use go/format to format … in github.com/shurcooL/vfsgen1w
If the output is already `gofmt`ed, running `format.Source` on it is a no-op.
dmitshur commented on Is there any plan to support subscr… in github.com/shurcooL/graphql1w
Yes, it is a long term goal. However, I don't plan to work on this soon. It's not needed for [githubv4](https://github.com/shurcooL/githubv4) because the GitHub GraphQL API v4 doesn't make use of the…
dmitshur commented on use gopkg.in to make buildable with… in github.com/shurcooL/github_flavored_markdown1w
Thanks for reporting this and sending the PR. I'd like to investigate and understand the issue better. Can you post the commands for building this with modules in Go 1.11 and the output you get? I…
dmitshur commented on x/build/devapp: duplicate CL lines … in github.com/golang/go1w
[`maintner.GerritCL`](https://godoc.org/golang.org/x/build/maintner#GerritCL) has a field `GitHubIssueRefs` of type `[]GitHubIssueRef`. Currently, if the CL description mentions the same issue more t…
dmitshur commented on x/build/devapp: duplicate CL lines … in github.com/golang/go1w
This seems to happen when the CL description mentions the same issue more than once. For example, here's a current occurrence of this bug: ![image](https://user-images.githubusercontent.com/192413…
dmitshur commented on Update gimme to support `.x` Go ver… in github.com/travis-ci/travis-build1w
This is strange, but I’ve seen gimme v1.5.0 already used in my previous builds. Additionally, the recent fix ( https://github.com/travis-ci/gimme/pull/153) is not included in gimme v1.5.0, a ne…
dmitshur starred github.com/jroimartin/gocui1w
Earlier
dmitshur commented on x/build/devapp: show GitHub usernam… in github.com/golang/go1w
We also have issue #23964, which is the root problem. When/if that is resolved, this issue will be obsolete. If that issue is lot of work and takes a long while, while this one is quick and easy, …
dmitshur commented on generator: use go/format to format … in github.com/shurcooL/vfsgen1w
Thanks for the PR. (Please ignore the CI failure, it happens due to a current issue on Travis CI (see https://github.com/travis-ci/travis-ci/issues/9652#issuecomment-409789014).) Let's discuss the de…
dmitshur commented on 1.x selects 1.11beta1 in github.com/travis-ci/gimme2w
Thanks for the heads up @philpennock. I reported it to their support email, and afterwards found https://github.com/travis-ci/travis-ci/issues/9652, which looks like a decent issue for the purpose of…
dmitshur commented on Setting go version to "1.10.x" inst… in github.com/travis-ci/travis-ci2w
> `1.x` picking up `go1.11beta1` This was issue https://github.com/travis-ci/gimme/issues/152 in `gimme`. It has recently been resolved. However, as I understand, what's remaining is for Travis CI…
dmitshur commented on go get honnef.co/go/js/dom in github.com/dominikh/go-js-dom2w
Thanks for reporting. This issue has been resolved by now, so closing. See https://github.com/dominikh/go-tools/issues/269#issuecomment-409646894 for some additional context on this.
dmitshur commented on How to serve gzipped bytes? in github.com/shurcooL/vfsgen2w
Yes, there is. What you’re looking for is [`httpgzip.FileServer(assets, ...)`](https://godoc.org/github.com/shurcooL/httpgzip#FileServer)\. [`httpgzip`](https://godoc.org/github.com/shurcooL/httpg…
dmitshur commented on 1.x selects 1.11beta1 in github.com/travis-ci/gimme2w
Thanks for resolving this issue in `gimme`! Is there an existing issue tracking the task of updating the version of `gimme` that travis-ci.org uses? I tried restarting [my build]( https://trav…
dmitshur starred github.com/cortesi/modd2w
dmitshur starred github.com/google/go-cloud3w
dmitshur commented on fix go vet error with go1.11 in github.com/google/go-github3w
I don't think it's appropriate to add this much code in between `got, err := ...` and the `if err != nil ...` statements while keeping the variable name just `err` (see [here](https://dmitri.shuralyo…
dmitshur commented on simple: skip "empty branch" check i… in github.com/dominikh/go-tools3w
> I can't see a simpler/better way to do it, As a data point, the way I got rid of it was by commenting out the entire empty branch, see the diff of `issues.go` in https://github.com/shurcooL/issu…
dmitshur commented on fix go vet error with go1.11 in github.com/google/go-github3w
We'll need to think about a better long term way to deal with gofmt changes. I think the best future proof solution is to have the `diff -u <(echo -n) <(gofmt -d -s .)` check run only for one of t…
dmitshur commented on lint/mutexHat: add a comment for sy… in github.com/go-critic/go-critic3w
To clarify, in that entry, the idea was that the comment was implicit and therefore not required. > So, *without needing to write the comment*, the above is implicitly understood to be equivalent I…
dmitshur commented on Switch to 1.11beta2 in github.com/gopherjs/gopherjs3w
According to the CI failure, the current `go1.11` code is no longer compatible with beta 2. It will need to be updated.
dmitshur pushed to go1.11 in github.com/gopherjs/gopherjs3w
dmitshur commented on Link to demo movie is broken. in github.com/audreylim/go-presenter4w
The domain (and port) has changed. The following updated link should work: http://instantshare.win/1vs4fiwjm924q.mov
dmitshur commented on Handle 1.x as a pattern correctly in github.com/travis-ci/gimme4w
Friendly ping; my Travis build is still failing because of #152, so I'd really like to help fix it if there's anything I can do.
dmitshur commented on Transfer request has incorrect json… in github.com/google/go-github1mo
Thanks for following up on this @juliaferraioli! As an aside, I got a chance to use the Repository Transfer API recently (I changed my GitHub username and wanted to move all my repos under old nam…
dmitshur pushed to master in github.com/google/go-github1mo
e96f1f1b07a5be7cba161bc7c1fd636044bfd75cUse "team_ids" JSON name for TransferRequest.TeamID field (#947)
dmitshur commented on Add support for the repository tran… in github.com/google/go-github1mo
I just noticed now, I think `json:"team_id,omitempty"` should've been `json:"team_ids,omitempty"`, isn't that right? From https://developer.github.com/v3/repos/#transfer-a-repository: ![image](…
dmitshur commented on Issue when using a null parameter in github.com/shurcooL/graphql1mo
Thanks for reporting this. `graphql` shouldn't panic, and I will fix that. But I suspect I see what the issue is. You're not specifying the exact pointer type for the nil variable. You should do t…
dmitshur commented on Handle 1.x as a pattern correctly in github.com/travis-ci/gimme1mo
Issue is #152 is affecting me too, so I'm looking forward to a resolution. What is needed to make progress on this PR? /cc @meatballhat I'm happy to help if there's anything I can do. Thanks!
dmitshur pushed to master in github.com/shurcooL/vfsgen1mo
62bca832be04bd2bcaabd3b68a6b19a7ec044411cmd/vfsgendev: Clean up computeDoc implementation.
dmitshur pushed to master in github.com/shurcooL/cmd1mo
f4d6041a8168fe0eb6558ed6d413e96a71ef94c5gorepogen: Clean up computeDoc implementation.
dmitshur pushed to master in github.com/shurcooL/home1mo
05b5de335638250d907d9bf2decb5dfc219dd76einternal/code: Compute full package documentation automatically.
0c473b6149ddaed0f3937e84aec8635255b1e3dfinternal/code: Add darwin/amd64 fallback env for package loading.
0457bc74a32e2bd03cab9688436c118d10a9765chttputil: Don't gzip for status codes that can't have body.
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
Thank you for working on this PR @yml. It has helped us better understand what it looks like to add Wasm support to this package and how viable it was to reuse the existing `dom` API. We found out th…
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1mo
The import path was concenived with `vgo` in mind, but for now, I pictured it as just a normal directory named `v2` containing a `dom` package in the same repository. If I understand correctly, it s…
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1mo
Agreed. @dominikh How do you feel about a `dom` v2 API at the import path `honnef.co/go/js/dom/v2` (package name `dom`)? The API would be the same as v1, except current `js` fields would be rep…
dmitshur starred github.com/browsh-org/browsh1mo
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
Sorry, I missed that part of your comment.
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1mo
I think I've found a potentially show-stopping problem with implementing this issue. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many obj…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
However, I think I've found a potentially show-stopping problem. This package relies very heavily on the `js` struct field tag feature of GopherJS to access properties of many objects. E.g.: https…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
> I did all the changes mentioned above. Perfect, thanks! > I am wondering if the very exact build target `+build js,!wasm` and `+build js,wasm` is not going to cause issue to code completion a…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
Let's remove the import comment here as well, so it's only in `doc.go` file.
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
The package comment must be immediately preceding the package clause. There can't be a blank line separating them, otherwise it's not parsed as a package comment by `godoc`. So please remove the blan…
dmitshur commented on Error variable naming in dmitri.shuralyov.com/idiomatic-go1mo
That's an interesting approach. I haven't seen that before. Thanks for sharing. I know there are tools such as [`errcheck`](https://github.com/kisielk/errcheck) and [`staticcheck`](https://github.co…
dmitshur commented on Error variable naming in dmitri.shuralyov.com/idiomatic-go1mo
@storozhukBM I guess both are fair style choices. I wanted to pick one, so that all my code would be consistent. `specificError` seemed more natural to me: if the first word is long and written in fu…
dmitshur commented on Net/http package in github.com/gopherjs/gopherjs1mo
`http.Client` in GopherJS has 2 implementations: one based on Fetch API, another based on XMLHttpRequest API. It picks whichever is available in that order. Both of those tend to be available in brow…
dmitshur commented on rpc.Dial not supported in gopherjs? in github.com/gopherjs/gopherjs1mo
Browsers don't provide access to raw TCP sockets, which `net/rpc` uses, so it can't work. This is why the [compatibility table](https://github.com/gopherjs/gopherjs/blob/master/doc/packages.md) says …
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1mo
@dominikh, in PR #59, you said: > Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it. (I wanted to move the discussion here…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
> Well, I'm definitely not a fan of the massive amount of code duplication. That is to say, I'd very much like to avoid it. I would like to avoid it too, but out of all alternatives, it seems the …
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
For now, I'd prefer we avoid duplicating the package comment, since we can avoid it. Let's delete it here and in `dom.go`, and move it to a new file `doc.go` that just has the package comment and pac…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
We do not want to modify the signature. First, it causes the API to differ between GopherJS and Wasm. Second, it causes `*htmlDocument` to no longer satisfy the `Document` interface: ``` panic: i…
dmitshur commented on wasm: Port of the library using `sy… in github.com/dominikh/go-js-dom1mo
> I think this package needs to shift towards being code generated from the HTML spec Such a drastic change would need to be considered for v2 or another package. It’s not in scope of this PR/is…
dmitshur commented on all: WebAssembly ("wasm") support in github.com/golang/go1mo
@omac777 For GopherJS, many people use high-level bindings for various browser APIs rather than the low-level `js` package directly. I suspect a similar approach will be most popular with Wasm too. I…
dmitshur commented on Warnings in MacOS when go-getting a… in github.com/go-gl/gl1mo
I can't reproduce this on my system: ``` ~ $ export GOPATH=/tmp/empty ~ $ go get -u github.com/go-gl/gl/v3.3-core/gl ~ $ ``` What version of Go are you using? I'm on a Mid-2015 15" MBP, macOS 10.…
dmitshur commented on Support GOOS=js GOARCH=wasm. in github.com/dominikh/go-js-dom1mo
@yml Thanks for looking at this and sharing your work. I think that's a great step forward. The approach I'd like us to use for `dom` is going to be slightly different than the one you've used, bu…
dmitshur starred github.com/bradfitz/latlong1mo
dmitshur commented on Report more details about errors in… in github.com/shurcooL/graphql1mo
Hi, thanks for the PR. I'd like to understand it better, so we can implement a better solution. Can you tell me under what conditions a non-200 response code is expected from a GraphQL server? How…
dmitshur commented on "go get -u honnef.co/go/js/dom" fai… in github.com/dominikh/go-js-dom1mo
Thanks for reporting @h8liu! I suspect we’ll have this fixed within 12 hours. /cc @dominikh In the meantime, if someone doesn’t have this package and needs to clone it, a workaround is possibl…
dmitshur commented on Add Reviewers field to ChangeInfo in github.com/andygrunwald/go-gerrit1mo
> Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned. For anyone who doesn't already know, it'…