Activity
Today
dmitshur closed an issue cmd/go/internal: fix copy paste error56m
Thanks for the information. Since [CL 762500](https://go.dev/cl/762500) didn't have an issue associated, I filed #80850 for it retroactively and used it for the backport.dmitshur commented on cmd/go: pseduo #cgo directive FFLAGS value mixed up with CXXFLAGS in Go 1.2657m
@gopherbot Please consider this for backport to Go 1.26. There's a semi-workaround available by using `CXXFLAGS` to control Fortran flags, but that can only be used if C++ flags aren't needed, and a …dmitshur fixed an issue cmd/go: pseduo #cgo directive FFLAGS value mixed up with CXXFLAGS in Go 1.2659m
dmitshur fixed an issue cmd/go: pseduo #cgo directive FFLAGS value mixed up with CXXFLAGS in Go 1.2659m
dmitshur opened an issue cmd/go: pseduo #cgo directive FFLAGS value mixed up with CXXFLAGS in Go 1.261h
https://pkg.go.dev/cmd/cgo#hdr-Using_cgo_with_the_go_command documents the behavior:
> CFLAGS, CPPFLAGS, CXXFLAGS, FFLAGS and LDFLAGS may be defined with pseudo #cgo directives within these comments…Yesterday
dmitshur commented on golang.org/x/build/cmd/watchflakes: stop posting flakes to the issue tracker16h
CC @golang/release, @cherrymui.dmitshur commented on cmd/go/internal: fix copy paste error17h
Please see https://go.dev/wiki/MinorReleases for the backport process.
We'll need more information to consider a backport request, anything that would help us understand why a backport might be warr…dmitshur closed an issue golang.org/x/crypto: cut a new release18h
dmitshur reviewed +2 on cmd/dist: build one more toolchain when GOEXPERIMENT is set18h
Thanks.
Consider requiring at least one builder that's running into this, e.g.:
```suggestion
Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Cq-Include-Trybots: luci.golang.try:gotip-linux-am…dmitshur commented on cmd/compile: [release-branch.go1.25] fix up backport of CL 80324020h
linux-arm passed in patch set 3.
Temporary hold while release branches are frozen for https://groups.google.com/g/golang-announce/c/8tdz5l-ccTs.dmitshur commented on cmd/compile: [release-branch.go1.26] fix up backport of CL 80324020h
linux-arm passed in patch set 2.
Temporary hold while release branches are frozen for https://groups.google.com/g/golang-announce/c/8tdz5l-ccTs.dmitshur commented on golang.org/x/build/cmd/relui: automate security comms inputs using security metadata21h
One of the remaining enhancements here is to re-check for any updates to the release notes when sending the announcement, so that it'd pick up any improvements to the release notes that may happen. (…dmitshur commented on cmd/compile: mips/mips64, multiply/divide results spilled from HI/LO corrupted w/ big stack frames23h
It was noted at https://groups.google.com/g/golang-dev/c/jMWTCiV0aSk/m/Qo6ozI0dBQAJ:
> Any CLs that land after CL 800721 ("internal/goversion: update Version to 1.28") but target go1.27.0 must be ch…dmitshur reviewed +2 on cmd/dist: don't rebuild the toolchain with a clean cache1d
Thanks.
Thanks for checking. I asked because keeping these comments up to date will help with future maintenance of this sequence, and it seemed worth some extra attention.
This part seems out of d…dmitshur commented on golang.org/x/mobile/cmd/gomobile: Android archives use backslashes in nested asset paths on Windows1d
CC @hajimehoshi.dmitshur commented on net: BenchmarkTCP4OneShot produces bimodal results across repeated runs1d
CC @ianlancetaylor, @neild, @nicholashusin.dmitshur commented on golang.org/x/mobile/cmd/gomobile: bind does not apply source overlays consistently1d
CC @hajimehoshi.dmitshur commented on proxy.golang.org: go mod download fails with 403 Forbidden from proxy.golang.org1d
CC @golang/tools-team.dmitshur commented on net/http: ParseSetCookie fails to parse Path values accepted by Cookie.Valid1d
CC @neild, @nicholashusin.dmitshur commented on cmd/internal/quoted: Join does not preserve empty arguments1d
CC @golang/command-line.dmitshur commented on mime: FormatMediaType emits duplicate parameters for keys differing only by case1d
CC @neild.dmitshur commented on crypto/tls: could save 45 bytes on the default ClientHello when `MinVersion` is `3`1d
CC @golang/security.dmitshur commented on net/http: HTTP/2 read loop spins at 100% CPU on a StreamError cached by tls.Conn1d
CC @neild, @nicholashusin.dmitshur commented on encoding/xml: unrecognized failures1d
CC @golang/mips.dmitshur commented on golang.org/x/crypto: cut a new release1d
Yes, this month's 'Tag x/ repos' relui workflow (#48523) is running this week, and it will tag the next golang.org/x/crypto version.dmitshur fixed an issue build: build failure on gotip-linux-amd64_c4dh96-perf_vs_release [consistent failure]1d
Other than that one failure, gotip-linux-amd64_c4dh96-perf_vs_release has been green, so closing again.This Week
dmitshur commented on cmd/compile/internal/test: TestMergeLocalsIntegration failures [consistent failure]1d
CC @golang/release, @thatnealpatel.dmitshur commented on internal/stringslite: [release-branch.go1.27] fix performance regression in index1d
Go 1.27 RC 3 will be released alongside Go 1.26/1.25 minor releases with some [pre-announced](https://groups.google.com/g/golang-announce/c/8tdz5l-ccTs) PRIVATE-track security fixes. Unfortunately, t…dmitshur commented on encoding/json/v2: [release-branch.go1.27] modify documentation1d
A temporary hold for after Go 1.27 RC 3 is out.dmitshur commented on cmd/compile: [release-branch.go1.27] do not home mul/div results in HI/LO1d
Go 1.27 RC 3 will be released alongside Go 1.26/1.25 minor releases with some [pre-announced](https://groups.google.com/g/golang-announce/c/8tdz5l-ccTs) PRIVATE-track security fixes. Unfortunately, t…dmitshur commented on encoding/json/v2: [release-branch.go1.27] add MarshalerTo and UnmarshalerFrom examples1d
Go 1.27 RC 3 will be released alongside Go 1.26/1.25 minor releases with some [pre-announced](https://groups.google.com/g/golang-announce/c/8tdz5l-ccTs) PRIVATE-track security fixes. This didn't make…dmitshur commented on encoding/json/v2: [release-branch.go1.27] make Deterministic doc more approachable1d
Go 1.27 RC 3 will be released alongside Go 1.26/1.25 minor releases with some [pre-announced](https://groups.google.com/g/golang-announce/c/8tdz5l-ccTs) PRIVATE-track security fixes. This didn't make…dmitshur commented on encoding/json/jsontext: [release-branch.go1.27] clarify safety of AvailableBuffer1d
RC 3 will be released alongside 1.26/1.25 minors with some [pre-announced](https://groups.google.com/g/golang-announce/c/8tdz5l-ccTs) PRIVATE-track security fixes. This didn't make it in time, so add…dmitshur commented on simd/archsimd: generate unifier values for SVE1d
@sunny@golang.org The description of the Code-Review submit requirement says:
> At least one Code-Review+2 is required. Self review is not allowed.
"Self review is not allowed" in this context mean…dmitshur closed an issue cmd/fix: fails to make progress after printing "applied 3 of 4 fixes; 1 file updated. (Re-run the command to apply more.)"1d
This issue seems to be the same as #77482. Merging them into one.dmitshur commented on encoding/json/v2: remove detection of cyclic data structures1d
Pinging this issue since it's very late in the [Go 1.27 release cycle](https://go.dev/s/release#timeline), and this is one of the few remaining open Go 1.27 release blockers. Is there a planned time …dmitshur commented on cmd/vet: warn about copying a time.Timer value1d
I'm realizing now this is currently an open proposal. Does it still need to go through the proposal process? If so, perhaps it should be in the Proposal milestone until that's done.dmitshur commented on cmd/vet: warn about copying a time.Timer value1d
@prattmic Would you like to submit that CL now that we're early in Go 1.28 development cycle? Moving this to Go1.28 milestone, otherwise feel to update it to Backlog.dmitshur fixed an issue all: the tree is highly flaky1d
There's been work to address this and I think we're no longer in the "highly flaky" state, so closing.
In general, highly flaky tests affecting [first-class ports](https://go.dev/wiki/PortingPolicy#…dmitshur commented on runtime: add runtime/pprof goroutine labels to tracebacks1d
It looks like there's been a good amount of progress on this issue in the Go 1.27 milestone, and it's documented at http://go.dev/doc/go1.27#runtime. This issue is still open and in the Go1.27 milest…dmitshur fixed an issue testing: t.Failed() returns false during panic1d
Closing as fixed by [CL 794541](https://go.dev/cl/794541) per https://github.com/golang/go/issues/49929#issuecomment-1883911440.dmitshur commented on golang.org/x/net/idna: ToUnicode accepts Punycode labels encoding pure ASCII labels1d
> I'm reopening this issue to track updating x/net/idna for older toolchains as well.
@neild Just to confirm, there's nothing actually left to change in the Go 1.27 and newer toolchains, is that rig…dmitshur reviewed +2 on golang.org/x/mobile/cmd/gomobile: emit replace directives without a version2d
Thanks.dmitshur commented on golang.org/x/net/html: preserve attribute ordering2d
@roland@golang.org Pinging this since it seems close to submission, if that's still your plan here, and may have gotten lost. Thanks.dmitshur reviewed +2 on golang.org/x/exp/shiny/driver/x11driver: remove unused buffer map2d
Thanks.Last Week
dmitshur commented on cmd/dist: don't rebuild the toolchain with a clean cache5d
(2 comments)
s/usersn/users/
Is the block comment above still up to date?dmitshur closed a change make.bash: update default bootstrap version1w
This change has already been applied via CL 804523.dmitshur reviewed +2 on make.bash: update default bootstrap version1w
Thanks.
Since this has a tracking issue (the one mentioned in the comment below), please include it here too:
For #77341.
CL 804523 is submitted by now and it makes a similar change. I'll rebase t…Earlier
dmitshur fixed an issue golang.org/x/telemetry/godev/internal/content: TestServer_ServeHTTP//noindex/ failures1w
Fixed by [CL 567136](https://go.dev/cl/567136).dmitshur commented on cmd/fix: [release-branch.go1.27] improve strings{cut,seq} and slicesbackward modernizers1w
Thanks.dmitshur opened an issue golang.org/x/telemetry/godev/internal/content: TestServer_ServeHTTP//noindex/ fails at Go tip as of CL 7955601w
It seems this particular test relies on the exact output of http.FileServer, which changed in [CL 795560](https://go.dev/cl/795560) for issue #80208:
```
$ go test -run=^TestServer_ServeHTTP//noinde…dmitshur opened a change cmd/fix: [release-branch.go1.27] improve strings{cut,seq} and slicesbackward modernizers1w
Pull in the fixes implemented in CL 805322, CL 805520, and CL 805400.
For #80410.
For #80554.
[git-generate]
updatestd -goroot=$(pwd) -branch=internal-branch.go1.27-vendordmitshur reviewed +2 on golang.org/x/build/internal/task: upgrade dependencies after vscode-go insider minor1w
Thanks.
Optionally, might be more readable to use a named variable:
```suggestion
if minor := release.Patch == 0; !minor || !isVSCodeGoInsiderVersion(release, "") {
```
I see other similar code d…dmitshur reviewed +2 on golang.org/x/vscode-go/tools: run go fix1w
Thanks.dmitshur reviewed +2 on golang.org/x/vscode-go/go.mod: update dependencies following the v0.57.0 release1w
Thanks.
Noting that this zero version that was here previously made the replacement directive highly load-bearing; the new version makes it more optional.dmitshur reviewed +2 on golang.org/x/vscode-go/...: upgrade go directive to at least 1.25.01w
Thanks.
In general, be mindful that going from 1.21 to 1.25 will include a fair number of changes, including the scope of variables in for loops (https://go.dev/doc/go1.22#language) and others at ht…dmitshur reviewed +2 on golang.org/x/build/internal/task: add vscode-go to the go directive update1w
Thanks.
Not seeing this change.
Also, what does the 'X' in `TestSelectGoDirectiveXReposLive` refer to? Previously the 'X' in `TestSelectGolangOrgXReposLive` was a part of "golang.org/x". Now that i…dmitshur commented on golang.org/x/build/internal/task: upgrade dependencies after vscode-go insider minor1w
(1 comment)
I see, so dropping -u and switching to `work` at once indeed doesn't work - `go get work` ends up _not_ doing `go get directdependency@upgrade` at all. Consider keeping `all` and only dr…dmitshur commented on net/url: quadratic complexity in resolvePath when processing backtrack path elements [1.26 backport]1w
CC @golang/release.dmitshur commented on net/url: quadratic complexity in resolvePath when processing backtrack path elements [1.25 backport]1w
CC @golang/release.dmitshur commented on golang.org/x/build/internal/task: add vscode-go to the go directive update1w
(7 comments)
https://go.dev/doc/contribute#commit_messages suggests "Write in complete sentences with correct punctuation, just like for your comments in Go." Perhaps:
```suggestion
This will help …dmitshur reopened an issue net/url: quadratic complexity in resolvePath when processing backtrack path elements1w
Reopening and moving to Go 1.27 milestone to track [cherry-picking](https://groups.google.com/g/golang-dev/c/jMWTCiV0aSk/m/Qo6ozI0dBQAJ) [CL 807700](https://go.dev/cl/807700) onto release-branch.go1.…dmitshur commented on go/types: avoid infinitely recursive instantiation through method signatures1w
@mrkfrmn This issue is in Go1.18 milestone, and it's also frozen/locked due to age. Maybe it's better to file a new one and reference this old issue? (Otherwise we should move it to a future mileston…dmitshur fixed an issue encoding/xml: (*Decoder).DecodeElement bypasses recursion-depth guard1w
Closed by merging [CL 807680](https://go.dev/cl/807680) (commit d5eeaa7de337f01173036096619cba09e31bde1a) to release-branch.go1.27.dmitshur reviewed +2 on encoding/xml: [release-branch.go1.27] fix depth processing in (*Decoder).unmarshal1w
(1 comment)
Since that issue was reopened and updated to track the Go1.27 fix, this could say "Fixes" instead of "Updates" so the issue will get automatically closed when this lands. It's also fine …dmitshur commented on encoding/xml: [release-branch.go1.26] fix depth processing in (*Decoder).unmarshal1w
Retrying trybots since "stream error: stream ID 11; INTERNAL_ERROR" may not happen a second time.dmitshur commented on golang.org/x/build/internal/task: upgrade dependencies after vscode-go insider minor1w
(1 comment)
I think you might want to consider `go get work` instead of `go get -u all` here.
The -u flag means to update not only the direct dependencies of the specified packages, but also their …dmitshur reopened an issue encoding/xml: (*Decoder).DecodeElement bypasses recursion-depth guard1w
Reopening and moving to Go 1.27 milestone to track [cherry-picking](https://groups.google.com/g/golang-dev/c/jMWTCiV0aSk/m/Qo6ozI0dBQAJ) [CL 803320](https://go.dev/cl/803320) onto release-branch.go1.…dmitshur commented on encoding/xml: (*Decoder).DecodeElement bypasses recursion-depth guard [1.25 backport]1w
CC @golang/release.dmitshur commented on encoding/xml: (*Decoder).DecodeElement bypasses recursion-depth guard [1.26 backport]1w
CC @golang/release.dmitshur reopened an issue crypto/tls: escape hatch for FIPS 140-3 mode Extended Master Secret enforcement [freeze exception]2w
Reopening to track [cherry-picking](https://groups.google.com/g/golang-dev/c/jMWTCiV0aSk/m/Qo6ozI0dBQAJ) [CL 804062](https://go.dev/cl/804062) onto release-branch.go1.27.dmitshur reviewed +2 on golang.org/x/build/main.star: remove sizespecializedmalloc builders2w
Thanks.dmitshur closed an issue runtime: js/wasm: "found bad pointer in Go heap" — link-layout-constant value recorded as a pointer in the write-barrier buffer [1.27 backport]2w
Updated milestone of #80472 to Go 1.27; marking this as a duplicate.dmitshur commented on cmd/go: toolchain escape via PATH in covermode when GOTOOLCHAIN auto-switches2w
This may be the same issue as #75031, which is fixed by now. @zccold, does this still reproduce for you with go1.27rc1+, or go1.26.3 or 1.25.10?dmitshur commented on crypto/tls: handshake messages can bypass non-advancing record limit in TLS 1.32w
@nicholashusin Please be aware that without a milestone set, the release-blocker label doesn't block any particular Go release.dmitshur commented on encoding/json/v2: remove detection of cyclic data structures2w
@dsnet Please be aware that without a milestone set, the release-blocker label doesn't block any particular Go release.dmitshur commented on crypto/tls: escape hatch for FIPS 140-3 mode Extended Master Secret enforcement [freeze exception]2w
@hardikmodha Both the freeze exception and backports to Go 1.26 and 1.25 are actively being considered. See https://github.com/golang/go/issues/80516#issuecomment-5071611439.
@gopherbot Please open…dmitshur commented on cmd/go: "run" and "test" behave differently2w
It's documented at https://pkg.go.dev/cmd/go@go1.27rc2#hdr-Test_packages that:
> As part of building a test binary, go test runs go vet on the package and its test source files to identify significa…dmitshur commented on make.bash: use toolchain switching to acquire bootstrap2w
(1 comment)
Please consider adding “Fixes #75143.” here. Or “For” if you think there’s more left to do after this.dmitshur commented on build: LUCI Python update needed for openbsd ppc64 builder?3w
As far as I can tell, the swarming bot code hasn't been updated to be compatible with Python 3.14 yet, and you're among the first to notice and report this. I see that `pkgutil.get_loader` call is st…dmitshur commented on cmd/go: inferred GOAMD64 value in go env should be applied to build3w
It’s documented at https://pkg.go.dev/cmd/go#hdr-Build_constraints - search for “amd64.v3” as the exact name of the build tag, not “GOamd64.v3”; the GO prefix is a part of the environment v…dmitshur commented on cmd/go: check that insecure scheme is permitted by GOINSECURE3w
(1 comment)
I removed it to improve readability of this code. The blank line doesn’t seem helpful. Without the blank line, it’s clear that the value of security is computed to be one of web.Secu…dmitshur commented on doc: write release notes for Go 1.273w
@stefanb It was noted in https://go.dev/doc/go1.25#json_v2, back when the encoding/json/v2 package started its experimental phase, that its design would evolve. I imagine users who have been experime…dmitshur reviewed +2 on cmd/dist: remove unused omitVariant field3w
Thanks.dmitshur fixed an issue golang.org/x/pkgsite/internal/godoc/dochtml/internal/render: TestFormatDocHTML failures3w
Fixed by [CL 801520](https://go.dev/cl/801520).dmitshur reviewed +2 on golang.org/x/playground/...: run go fix ./...3w
Thanks.
I think some of the fixes by default leave code in a way that its readability can be improved when considering the context. I left some minor suggestions.
The variable name "before" is very…dmitshur reviewed +2 on golang.org/x/playground/sandbox: instrument container wait time (queue delay)3w
Thanks.
```suggestion
func getContainer(ctx context.Context) (_ *Container, err error) {
start := time.Now()
```dmitshur commented on golang.org/x/playground/...: turn down go2goplay appengine instance3w
(4 comments)
https://go.dev/doc/contribute#commit_messages suggest to "Write in complete sentences with correct punctuation, just like for your comments in Go." It's probably fine not to even mentio…dmitshur reviewed +2 on go.dev/wiki/Watchflakes: add example for matching all subtests3w
Thanks.
Because of the mandatory '/', this will exclude failures in the top-level TestServeIndexHtml test itself. Maybe it's more common to want to match the test and all its subtests too? If so, co…dmitshur reviewed +2 on Revert "cmd/compile: optimize abi.Type.TFlag loads"3w
Thanks.
I'll also add an optional x_build-gotip-linux-amd64 trybot here so we can see what it reports.
https://go.dev/wiki/CommitMessage#reverts suggests including the CL number.
```suggestion
Thi…dmitshur commented on cmd/compile: "hasUncommon: methods not computed" ICE as of CL 7012993w
It's not a problem for x/build itself, since we generally use stable Go releases there, so no worries there. It's good that it was able to uncover this.
Depending on how much other code this problem…dmitshur opened an issue cmd/compile: "hasUncommon: methods not computed" ICE as of CL 7012993w
At tip, starting with [CL 701299](https://go.dev/cl/701299), building the [golang.org/x/build/internal/relui](https://golang.org/x/build/internal/relui) package has started to fail with:
```
FAIL go…dmitshur commented on html/template: potential XSS caused by wrong JavaScript regexp context tracking after top-level `{`3w
Which release is this a blocker for? (This issue currently has no Milestone, making the release-blocker label a no-op.)dmitshur reviewed +2 on Revert "cmd/compile: on AMD64 use leave instruction for go compiled functions"3w
Thanks.dmitshur reviewed +2 on all: update vendored dependencies3w
Thanks.dmitshur commented on all: update vendored dependencies3w
(1 comment)
I'd expect this version to get maintained, but you may have not picked up the absolute latest updatestd. It's fine since it'll happen in a future run too.dmitshur commented on all: update vendored dependencies3w
The bootstrap on the builders should be go1.26.0 as of CL 801200. There's also been a small updatestd update recently, so consider rebasing and regenerating. I also left a suggestion about git-genera…dmitshur commented on golang.org/x/pkgsite/internal/godoc/dochtml/internal/render: fix tests3w
(1 comment)
```suggestion
For golang/go#76975.
Change-Id: Ibc508c39eb4785515d98b4eaf4fce299831b4924
```
So that this CL shows up in the timeline of that proposal.dmitshur commented on cmd/go/internal/telemetrystats: drop go/platform/target/{goos,goarch}:*3w
Letting this land for Go 1.28.
Thanks.dmitshur commented on reflect: [release-branch.go1.27] extract potentially embedded reflect types before use3w
Trybot failure looks like #76901, retrying it.