Yesterday
dmitshur starred in github.com/koesie10/webauthn4h
dmitshur starred in github.com/duo-labs/webauthn4h
dmitshur commented on github.com/primer/octicons: Unclear how to actually use Octicons in a project5h
@mroc170 I know little about Rails, so I'm not a good person to ask.
In general, I suggest using a medium like Stack Overflow or similar to ask questions. The interface of an issue tracker is better…dmitshur merged a change doc: remove Release History pages (moved to x/website)7h
dmitshur merged a change golang.org/x/website/content/static/doc: copy Release History pages from Go repo8h
dmitshur opened a change doc: remove Release History pages (moved to x/website)10h
dmitshur commented on golang.org/x/build/internal/gophers: add Alexander Rakoczy11h
(1 comment)
This email should be first in the list if you want it to be your Gerrit account.dmitshur reviewed +2 on golang.org/x/build/internal/gophers: add Alexander Rakoczy11h
dmitshur opened a change golang.org/x/website/content/static/doc: copy Release History pages from Go repo11h
dmitshur opened an issue doc: move "Release History" content to x/website12h
I plan to move the Release History page (along with two other pages in https://golang.org/doc/devel/ with pre-Go 1 history) from the main Go repository to the x/website repository. This is a subset o…dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: minor follow-ups from previous CL13h
dmitshur commented on golang.org/x/build/cmd/gopherbot: improve test fake for GitHub issues14h
(1 comment)
Is this CL waiting on anything to be submitted?
This blank line doesn't appear to be consistent with other files. Was it added intentionally?dmitshur reviewed +2 on golang.org/x/build/repos: flesh out package more, use it in maintnerd16h
(3 comments)
Not seeing issues. Minor comments.
Not a big deal, but I liked the previous style better, since it keeps the main code path less indented (https://golang.org/s/style#indent-error-flow)…This Week
dmitshur commented on doc: filename conventions1d
To my knowledge, there isn't a documented convention for .go file names (other than meaningful things like _test.go, leading . or _, trailing _goos_goarch, etc.) anywhere. I've checked https://golang…dmitshur commented on runtime: revert Windows change to boot-time timers1d
> @dmitshur apparent gopherbot failure...
Yeah, the missing keyword was `please`, as @toothrot has successfully demonstrated above. It works even if you're extra polite like I was in https://github.…dmitshur merged a change doc: [release-branch.go1.13] add CherryPickApproved filter to Release History links1d
dmitshur merged a change doc: [release-branch.go1.12] add CherryPickApproved filter to Release History links1d
dmitshur commented on doc: remove conduct.html (moved to x/website)1d
(1 comment)
Friendly ping on this question, Russ.dmitshur commented on golang.org/x/build/repos: flesh out package more, use it in maintnerd1d
(2 comments)
Is it possible for MirroredToGitHub to be true yet GitHubRepo to return an empty string? In what scenario would that happen? Is it useful to have this case?
Edit: The panic in add sugg…dmitshur commented on github.com/golang/gddo: non-master branches not being recognised2d
@raphael For full module support, you should use [pkg.go.dev](https://pkg.go.dev/goa.design/goa/v3). See https://github.com/golang/go/issues/33654#issuecomment-553496652 for more information about it.Last Week
dmitshur commented on cmd/go: go list reports a mangled ImportPath for a relative path that is not a valid Go package5d
/cc @jayconrod @bcmillsdmitshur commented on testing: add TB.TempDir() string5d
> So that's another line.
I think it’s a constant 2 extra lines, I don’t see why a third extra line would be required.
```Go
foo(filepath.Join(t.TempDir(), "foo"))
bar(filepath.Join(t.TempDir()…dmitshur commented on testing: add TB.TempDir() string5d
Since I’m not seeing it mentioned, have you considered a more verbose and explicit API variation that returns a cleanup closure?
Somewhat inspired by `context.WithCancel`, it may look like:
```Go…dmitshur commented on doc: release history webpage contains suboptimal links5d
@gopherbot, could you please be so kind as to open two backport issues: one for Go 1.13 and another for Go 1.12. This is a documentation fix.dmitshur commented on doc: release history webpage contains suboptimal links5d
I went through the release history a bit. We started consistently using the CherryPickCandidate and CherryPickApproved labels with Go 1.9.1 and later. They weren't used before Go 1.9. I fixed up some…dmitshur closed an issue golang.org/x/build/cmd/gopherbot: document gopherbot actions and commands5d
dmitshur commented on golang.org/x/build/cmd/gopherbot: document gopherbot actions and commands5d
@gopherbot's profile now has a link to its wiki page (https://golang.org/wiki/gopherbot).
I'll close this because everything that was mentioned here seems done, but feel free to reopen or make a n…dmitshur commented on mime/multipart: setting `Content-Type` in multipart part prevents it being read in go 1.10 [1.10 backport]5d
This was backported to 1.10 release branch via [CL 121075](https://golang.org/cl/121075). dmitshur commented on doc: release history webpage contains suboptimal links5d
I agree the current link leads to a page that is hard to read. We shouldn't remove issues from that milestone, because then it will be harder to track history and know what was considered but not acc…dmitshur closed an issue golang.org/x/build/cmd/gitmirror: repo build broken for a while6d
dmitshur commented on golang.org/x/build/cmd/gitmirror: repo build broken for a while6d
This issue is the same as #35828.dmitshur reviewed +2 on github.com/google/go-github/v28: Bump major version to v296d
I don’t see any issues. One minor inline comment.
This change doesn’t look intentional.
I suspect it came about from the earlier version of this PR where the scrape/go.mod file was removed, a…dmitshur commented on github.com/google/go-github/v28: Bump major version to v296d
I agree with Will’s comments. We must not remove the scrape/go.mod file as that would change module boundaries. It’s a good idea to keep this PR focused on just one module; updating the scrape mo…dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim1w
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit1w
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl1wdmitshur commented on go/types: include import path in type error messages1w
> may have implications for client code that parses error messages
/cc @neild who worked on defining an internal policy related to that, which can be helpful when making decisions about changing err…dmitshur commented on golang.org/x/website: outdated info about workspace and modules?1w
> could be added in the Modules section
>
> Go Modules: v2 and Beyond
That has already been done in [CL 209038](https://golang.org/cl/209038), and you can see it on [tip.golang.org](https://tip.gola…dmitshur reopened an issue cmd/go: imports fail to resolve in module mode when file contains a leading BOM1w
dmitshur commented on go/types: include import path in type error messages1w
/cc @griesemer per [owners](https://dev.golang.org/owners).dmitshur commented on net/http/httputil: SingleHostReverseProxy escaped paths are decoded1w
/cc @bradfitz per [owners](https://dev.golang.org/owners).dmitshur commented on golang.org/x/website: outdated info about workspace and modules?1w
/cc @jayconrod @jadeklerdmitshur commented on golang.org/x/website: suggestion to define or explain what CL is in contribute.html1w
/cc @andybons @jayconroddmitshur commented on : dep still look like the official package manager1w
/cc @jayconrod @andybonsdmitshur commented on cmd/go: go install should warn when installing outside PATH1w
/cc @bcmills @jayconroddmitshur commented on cmd/go: module go install cmd with relative import path resolved against $GOPATH1w
/cc @jayconrod @bcmillsdmitshur commented on cmd/go: annoying local development workflow for nested modules1w
/cc @bcmills @jayconroddmitshur commented on runtime: HeapSys increases until OOM termination1w
/cc @aclementsdmitshur commented on cmd/go: module dependencies added from different go.mod files of single module at different versions1w
/cc @jayconrod @bcmillsdmitshur commented on : How to instructs the cover command to use the main module's top-level vendor directory to satisfy dependencies? It doesn't recognize -mod flag.1w
/cc @jayconrod @bcmills This may be related to `cmd/go` or `cmd/cover`, but I'm not sure who owns the cover cool.
I don't see `cmd/cover` mentioned in #24661. We should add it there so it's easier…dmitshur commented on crypto/x509: Convenient, efficient way to reload a certificate pool after on-disk changes1w
/cc @FiloSottile @katiehockmandmitshur commented on cmd/go: imports fail to resolve in module mode when file contains a leading BOM1w
@andyTsing Why close this issue? We'd like to improve the go command to report a better error message in this rare situation. Having this issue open is how we can track that work. Do you mind re-open…dmitshur closed a change github.com/gopherjs/gopherjs.github.io/update.sh: fix to work with all shells and gopherjs 1.10-3.1w
dmitshur commented on github.com/gopherjs/gopherjs.github.io/update.sh: fix to work with all shells and gopherjs 1.10-3.1w
Closing because #69 has been resolved. Please let me know if there are any issues. Thanks for the work here.dmitshur deleted branch in github.com/gopherjs/gopherjs.github.io1w
update-latestdmitshur pushed to
master in github.com/gopherjs/gopherjs.github.io1wdmitshur merged a change github.com/gopherjs/gopherjs.github.io/playground: regenerate with GopherJS 1.12-2 and Go 1.12.131w
dmitshur closed an issue github.com/gopherjs/gopherjs.github.io/playground: go generate fails when GOROOT is user-writeable.1w
dmitshur commented on syscall/js: possibility of using String.prototype.* methods on strings1w
Thanks for the explanation.
> I do not yet see why syscall/js should emulate autoboxing.
I agree, I don't think that would be a good change.
It should just be possible to use JavaScript's `t…dmitshur commented on github.com/gopherjs/gopherjs.github.io/playground: regenerate with GopherJS 1.12-2 and Go 1.12.131w
The playground doesn't really need much review (and we don't have much reviewer time available due to https://github.com/gopherjs/gopherjs/issues/894), it just needs to continue to work. I've tested …dmitshur opened a change github.com/gopherjs/gopherjs.github.io/playground: regenerate with GopherJS 1.12-2 and Go 1.12.131w
Also add support for `syscall/js` and start using it in the initial snippet.
Make various modernizations/improvements to the `update.sh` script.
Fixes #69.
/cc @hajimehoshi @slimsag
(See …dmitshur created branch in github.com/gopherjs/gopherjs.github.io1w
update-latestdmitshur commented on github.com/gopherjs/vecty: correctly handle the fact that nodeName is uppercase1w
Do you have a way of checking whether performance is impacted doing this on each `toLower` call, compared to:
```Go
func toLower(s string) string {
return toLowerCase.Call("call", js.ValueOf…dmitshur commented on github.com/gopherjs/vecty: Add support for rendering into non-body DOM nodes1w
About the "syscall/js: call of Value.Call on string" error, I found it happens when using `syscall/js` package with GopherJS but not when using `github.com/gopherjs/gopherjs/js` package. So it's not …dmitshur opened an issue syscall/js: possibility of using String.prototype.* methods on strings1w
With GopherJS, it was possible to call the [`String.prototype.toLowerCase`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toLowerCase) method on a `String`:
…Earlier
dmitshur commented on github.com/gopherjs/vecty: Add support for rendering into non-body DOM nodes1w
I tried the following quick change to see if it would be sufficient to solve the problem:
```diff
diff --git a/dom.go b/dom.go
index 0eb000e..164a5a3 100644
--- a/dom.go
+++ b/dom.go
@@ -2,6 …dmitshur commented on github.com/gopherjs/vecty: Add support for rendering into non-body DOM nodes1w
I believe I'm running into an issue with `nodeName` case sensitivity here (see https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeName and https://johnresig.com/blog/nodename-case-sensitivity/…dmitshur commented on github.com/gopherjs/vecty: RenderBody became blocking (it never returns) after PR #2321w
Thank you very much Stephen!dmitshur opened an issue github.com/shurcooL/home: validate and reject commits that would result in bad module zip1w
Given that `home` implements a [custom git server and module server](https://pkg.go.dev/github.com/shurcooL/home/internal/code), it is both helpful and a novel opportunity to perform some server-side…dmitshur commented on github.com/gopherjs/vecty: RenderBody became blocking (it never returns) after PR #2321w
Friendly ping on this issue to indicate I'm still interested in this (with full understanding this is open source, so there are no expectations of work).
This is blocking me from making updates to…dmitshur pushed to
master in github.com/shurcooL/home1wdmitshur opened an issue github.com/shurcooL/home: add support for signing in via IndieAuth1w
Currently, it is possibly to sign in to `home` only via GitHub. While this has worked well and provides a simple user experience, it has some downsides:
- requires having a GitHub account
- doesn…dmitshur starred in github.com/gbbr/flippo1w
dmitshur commented on github.com/go-gl/glfw: Consider adding release tags2w
We probably wouldn't, but given we just released v3.3/glfw a few days ago, there's some small chance we will learn that some part of the new API has a problem and will need to be fixed.dmitshur opened an issue golang.org/x/build/cmd/gerritbot: didn't close a PR that was submitted2w
We should investigate why gerritbot didn't close a PR that was imported into Gerrit as a CL and submitted.
- PR #35751
- imported as [CL 208318](https://golang.org/cl/208318)
See https://…dmitshur commented on github.com/go-gl/glfw: Consider adding release tags2w
A small suggestion is to start with v0.1.0-alpha first, before getting to v1.0.0. We can always get to v1 after some time passes. The advantage of v0 is that it still permits breaking changes and giv…dmitshur commented on github.com/go-gl/glfw: Consider adding release tags2w
I've never attempted to apply semver on top of another project with semver, so it's unexplored territory for me. I don't have objections to trying it, and going with the proposed scheme seems reasona…dmitshur pushed to
master in github.com/shurcooL/githubv42w
dmitshur merged a change github.com/shurcooL/githubv4: regenerate for schema changes by 2019-11-262w
dmitshur commented on github.com/shurcooL/githubv4: regenerate for schema changes by 2019-11-262w
Fixed in c476f0c1d64e4255a76ab4467fd4ad6553475065.dmitshur pushed to
master in github.com/timetoplatypus/githubv42wremove spurious blank linesdmitshur commented on github.com/shurcooL/githubv4: regenerate for schema changes by 2019-11-262w
This blank line looks like it shouldn't be there.dmitshur opened an issue github.com/go-gl/glfw/v3.3/glfw: CreateWindow crashes after WaitEvents on macOS2w
This is the `golang.org/go-gl/glfw/v3.3/glfw` tracking bug for upstream GLFW issue glfw/glfw#1543. It can be reproduced with the following Go program:
```Go
package main
import (
"log"
"ru…dmitshur commented on golang.org/x/net/http2: cannot create 'MaxConcurrentStreams' streams with a single ClientConn2w
/cc @bradfitz @tombergandmitshur commented on golang.org/x/sys/unix: add support for new fscrypt ioctls from Linux v5.42w
/cc @ianlancetaylor @bradfitz @tklauser per [owners](https://dev.golang.org/owners).dmitshur commented on os: clarify ioutil.WriteFile and os.Mkdir docs re permissions and umask2w
/cc @bradfitz @ianlancetaylor per [owners](https://dev.golang.org/owners).dmitshur commented on runtime: signal: illegal instruction on darwin/arm642w
@cherrymui Thanks. The darwin-arm64-corellium builder was passing for many commits between 01f15b62b3d91c0f7fed54eedeee4123eb04b533 and 67f0f83216930e053441500e2b28c3fa2b667581 (CL 208818). Do you kn…dmitshur commented on : fmt.Print in tests preventing emission of Action:pass event when using `go test -json`2w
/cc @bcmills @jayconrod per [owners](https://dev.golang.org/owners).dmitshur commented on cmd/go: unable to pull from private Bitbucket Server repository (adding "scm" to url)2w
> So it seems as though my internal VCS is actually "Bitbucket Server v5.16.10",
I'm not very familiar with the Bitbucket Server, but does it have any documentation for how to access private Go re…dmitshur commented on cmd/go: unable to pull from private Bitbucket Server repository (adding "scm" to url)2w
/cc @bcmills @jayconrod per [owners](https://dev.golang.org/owners).dmitshur commented on cmd/vet: vet flags for specifying 'analyzer' doesn't work2w
/cc @alandonovan @josharian @mvdan per [owners](https://dev.golang.org/owners).dmitshur commented on cmd/go: "fatal error: concurrent map writes" during go get [1.13 backport]2w
Approving because this is a serious problem without an obvious workaround, and the fix is localized.dmitshur commented on runtime: function textOff returns incorrect value if multiple text sections are present [1.12 backport]2w
@laboger Could you also please provide a rationale here to backport this fix, as described at https://golang.org/wiki/MinorReleases?dmitshur commented on runtime: function textOff returns incorrect value if multiple text sections are present [1.13 backport]2w
@laboger Could you please provide a rationale to backport this fix, as described at https://golang.org/wiki/MinorReleases?dmitshur commented on runtime: function textOff returns incorrect value if multiple text sections are present2w
@laboger [CL 203817](https://golang.org/cl/203817) said "Updates #35207" rather than Fixes. Is there more to do here?dmitshur commented on : HeapIdle is increasing infinitely on big data volume allocations2w
/cc @aclements @mknyszek
(Please let me know if there are other people who are better to ping about an issue like this.)dmitshur commented on runtime: signal: illegal instruction on darwin/arm642w
Strangely, it failed even worse on the next commit (https://build.golang.org/log/186ffe8d4a32f24c719cb49eddf6e37e73957239), but has been passing since then.dmitshur commented on github.com/glfw/glfw: glfwCreateWindow crashes after polling event on mac2w
I just noticed I was looking at the 3.2 docs, not 3.3 as I intended. The “ If no windows exist, this function returns immediately. For synchronization of threads in applications that do not create …dmitshur commented on golang.org/x/tools/internal/lsp: frequent out-of-memory errors on windows-amd64-race builder2w
Looks like the CL above helped; we got our first near-pass of x/tools on `windows-amd64-longtest` builder in [this recent run](https://build.golang.org/log/c3491c162a230b13f18d84c848aa05fcbda5c6fd). …dmitshur opened an issue golang.org/x/tools/go/packages: TestCgoOption fails on Windows because net.cgoLookupHost doesn't exist2w
From a [recent run](https://build.golang.org/log/c3491c162a230b13f18d84c848aa05fcbda5c6fd) of the `windows-amd64-longtest` builder (after increasing its memory in [CL 208500](https://golang.org/cl/20…