Yesterday
shurcooL commented on Removed Inconsistency in documentat… in github.com/google/go-github13h
I think this line also needs to be updated. It says:
```
// The ID (not Number) of the Issue or Pull Request to associate with this card.
```
But GitHub documentation says:
```
The id of …
I think this line also needs to be updated. It says:
```
// The ID (not Number) of the Issue or Pull Request to associate with this card.
```
But GitHub documentation says:
```
The id of …shurcooL commented on time: go1.9rc2 stringifies time.Tim… in github.com/golang/go14hOn the topic of `Round(0)` choice, see relevant issue #18991 for prior discussion.
On the topic of `Round(0)` choice, see relevant issue #18991 for prior discussion.shurcooL commented on tip build fails in github.com/golang/go15hAccording to https://build.golang.org/#short, it looks like [CL 49530](https://golang.org/cl/49530) is the first bad commit. /cc @williamweixiao @cherrymui
According to https://build.golang.org/#short, it looks like [CL 49530](https://golang.org/cl/49530) is the first bad commit. /cc @williamweixiao @cherrymuishurcooL commented on time: go1.9rc2 stringifies time.Tim… in github.com/golang/go15h`Time.String` documentation mentions:
> for a stable serialized representation, use t.MarshalText, t.MarshalBinary, or t.Format with an explicit format string.
`fmt.Stringer` documentation says…
`Time.String` documentation mentions:
> for a stable serialized representation, use t.MarshalText, t.MarshalBinary, or t.Format with an explicit format string.
`fmt.Stringer` documentation says…shurcooL commented on Ability to view other branches/tags… in github.com/shurcooL/gtdo19hThis task is resolved now via #49, and it's possible to view any part of Go standard library (including `cmd` subdirectory with command) at any revision, branch, tag, and even CL.
For example:
…
This task is resolved now via #49, and it's possible to view any part of Go standard library (including `cmd` subdirectory with command) at any revision, branch, tag, and even CL.
For example:
…shurcooL commented on Inconsistency in documentation for … in github.com/google/go-github21hThat sounds very reasonable to me. Thanks for investigating!
I'll just ping @gmlewis on this, since he wrote the original code. If he doesn't have any objections either, then we're good to go.
…
That sounds very reasonable to me. Thanks for investigating!
I'll just ping @gmlewis on this, since he wrote the original code. If he doesn't have any objections either, then we're good to go.
…shurcooL commented on x/tools/go/vcs: vcs.go does not sup… in github.com/golang/go1dYes, you don't need .git suffix for normal `github.com/user/repo` Go packages. You said the issue was with GitHub Enterprise repos. Only those need .git suffix in their import path.
The .git suffi…
Yes, you don't need .git suffix for normal `github.com/user/repo` Go packages. You said the issue was with GitHub Enterprise repos. Only those need .git suffix in their import path.
The .git suffi…shurcooL commented on x/tools/go/vcs: vcs.go does not sup… in github.com/golang/go1dI can't reproduce.
```
$ goexec 'vcs.RepoRootForImportPath("github.examplecompany.org/org/repo.git", false)'
(*vcs.RepoRoot)(&vcs.RepoRoot{
VCS: (*vcs.Cmd)(&vcs.Cmd{
Name: (string)("…
I can't reproduce.
```
$ goexec 'vcs.RepoRootForImportPath("github.examplecompany.org/org/repo.git", false)'
(*vcs.RepoRoot)(&vcs.RepoRoot{
VCS: (*vcs.Cmd)(&vcs.Cmd{
Name: (string)("…shurcooL commented on Fix Google App Engine support and p… in github.com/google/go-github1dThis is one of those rare times where I feel it might be worth breaking the "context is always the first parameter" pattern.
Here, `withContext` is basically a method-as-a-function that adds `ctx`…
This is one of those rare times where I feel it might be worth breaking the "context is always the first parameter" pattern.
Here, `withContext` is basically a method-as-a-function that adds `ctx`…shurcooL commented on Fix Google App Engine support and p… in github.com/google/go-github1dSo a new client must be made for every incoming request? That seems pretty unfortunate.
So a new client must be made for every incoming request? That seems pretty unfortunate.shurcooL commented on Inconsistency in documentation for … in github.com/google/go-github1dThanks!
Feel free to investigate it and post your findings here. If it's pretty straightforward, you could send a PR right away. Otherwise, it's a good idea to discuss it first. See [CONTRIBUTING.…
Thanks!
Feel free to investigate it and post your findings here. If it's pretty straightforward, you could send a PR right away. Otherwise, it's a good idea to discuss it first. See [CONTRIBUTING.…shurcooL commented on vcs.go does not support private rep… in github.com/golang/go1dI see. I'll update the issue title to reflect that.
Can you post the code that you used then? The same question applies, what was the import path you used; did it have a ".git" suffix?
I see. I'll update the issue title to reflect that.
Can you post the code that you used then? The same question applies, what was the import path you used; did it have a ".git" suffix?shurcooL commented on Fix Google App Engine support and p… in github.com/google/go-github1dAlso, now that this func is a no-op for `appengine` case, I think you should add a comment explaining that. E.g.:
```Go
// No-op because appengine doesn't support adding context to a request.
re…
Also, now that this func is a no-op for `appengine` case, I think you should add a comment explaining that. E.g.:
```Go
// No-op because appengine doesn't support adding context to a request.
re…shurcooL commented on Fix Google App Engine support and p… in github.com/google/go-github1dGiven this change, I think you can simplify `withContext` signature to return only `*http.Request` then. Can you?
Given this change, I think you can simplify `withContext` signature to return only `*http.Request` then. Can you?shurcooL commented on Changing status code of cached resp… in github.com/gregjones/httpcache1dThis might be related to https://github.com/gregjones/httpcache/pull/45.
This might be related to https://github.com/gregjones/httpcache/pull/45.shurcooL commented on vcs.go does not support private rep… in github.com/golang/go1dWhat @dcheney-atlassian said was:
> Please try appending .git to the url. Does that work?
Did you try that? What was the command you ran? Was it something like this?
```
go get -u github.<c…
What @dcheney-atlassian said was:
> Please try appending .git to the url. Does that work?
Did you try that? What was the command you ran? Was it something like this?
```
go get -u github.<c…shurcooL commented on Proposal: Include github.com/johanb… in github.com/gopherjs/gopherjs1dI don't have objections. As I understand, you want to use `gopherjs` org namespace for a GopherJS related binding that doesn't already exist here.
But I just want to point out a few things:
> t…
I don't have objections. As I understand, you want to use `gopherjs` org namespace for a GopherJS related binding that doesn't already exist here.
But I just want to point out a few things:
> t…This Week
shurcooL commented on proposal: add a build tag "test" in github.com/golang/go1dI'll expand on @ianlancetaylor's point to say that it'd affect not only the build system, but the experience of Go users. If this is adopted, it could mean that a dependency of a dependency of a depe…
I'll expand on @ianlancetaylor's point to say that it'd affect not only the build system, but the experience of Go users. If this is adopted, it could mean that a dependency of a dependency of a depe…shurcooL commented on Going to tag v2.0.0 in github.com/russross/blackfriday1d> @shurcooL, are you saying that in your radical proposal we would also merge v2 to master?
In that radical proposal, yes, I implied that `v2` would become master.
However, I just realized that…
> @shurcooL, are you saying that in your radical proposal we would also merge v2 to master?
In that radical proposal, yes, I implied that `v2` would become master.
However, I just realized that…shurcooL commented on 
Minor nitpicky suggestion @lunelson, in case you find it helpful. The language is called "JavaScript", not "Javascript", so it might be better to use the canonical spelling.
Reference: https://dev…
52c98102margin tweak in github.com/lunelson/lunelson.github.io1dMinor nitpicky suggestion @lunelson, in case you find it helpful. The language is called "JavaScript", not "Javascript", so it might be better to use the canonical spelling.
Reference: https://dev…shurcooL commented on Accept application/x-www-form-urlen… in github.com/google/go-github1dSince "application/x-www-form-urlencoded" and "application/json" are the only two content types we expect from GitHub, and support, let's explicitly check it's one of those two and return an error ot…
Since "application/x-www-form-urlencoded" and "application/json" are the only two content types we expect from GitHub, and support, let's explicitly check it's one of those two and return an error ot…shurcooL commented on Accept application/x-www-form-urlen… in github.com/google/go-github1dSince you only ever want one value for Content-Type, use `req.Header.Set` rather than `req.Header.Add`. It doesn't make a difference as long as you do it only once, but still, using `Set` is better f…
Since you only ever want one value for Content-Type, use `req.Header.Set` rather than `req.Header.Add`. It doesn't make a difference as long as you do it only once, but still, using `Set` is better f…shurcooL commented on Accept application/x-www-form-urlen… in github.com/google/go-github1dAwesome, thanks, that answers my question. Since GitHub supports both types, it would be a good enhancement for go-github to support them too. Thanks for sending the PR. My next step will be to revie…
Awesome, thanks, that answers my question. Since GitHub supports both types, it would be a good enhancement for go-github to support them too. Thanks for sending the PR. My next step will be to revie…shurcooL commented on Accept application/x-www-form-urlen… in github.com/google/go-github1dThat's a good call. It's better to add a separate test, then we can be more confident the old one still passes without changes.
That's a good call. It's better to add a separate test, then we can be more confident the old one still passes without changes.shurcooL commented on GitHub GraphQL API (v4) support. in github.com/google/go-github1dThanks for adding the reference to the `githubql` repository in a8d73f9e02c9e82697d7bcc7aa8ff2bd23341181 @willnorris! There's a minor typo in the URL that we should fix, as I mentioned in https://git…
Thanks for adding the reference to the `githubql` repository in a8d73f9e02c9e82697d7bcc7aa8ff2bd23341181 @willnorris! There's a minor typo in the URL that we should fix, as I mentioned in https://git…shurcooL commented on 
We should use the canonical casing of the repository link, which is `https://github.com/shurcooL/githubql` with a capital L.
a8d73f9eadd link to shurcooL/gi… in github.com/google/go-github1dWe should use the canonical casing of the repository link, which is `https://github.com/shurcooL/githubql` with a capital L.shurcooL commented on Test post for comments in dmitri.shuralyov.com/blog2d
Another test comment to conclude my testing.
Another test comment to conclude my testing.shurcooL commented on Test post for comments in dmitri.shuralyov.com/blog2dThis is just a test comment to check something...
This is just a test comment to check something...shurcooL commented on cmd/compile: Incorrect column numbe… in github.com/golang/go2d@griesemer This is a feature that's new to Go 1.9, and it has a bug. What's the reason this issue is added to Go 1.10 milestone instead of 1.9?
Is it because the bug is considered to be minor and …
@griesemer This is a feature that's new to Go 1.9, and it has a bug. What's the reason this issue is added to Go 1.10 milestone instead of 1.9?
Is it because the bug is considered to be minor and …shurcooL commented on Add error for no trailing slash in github.com/google/go-github2dI'd suggest using keyed fields here to make the boolean values more readable. Just seeing `true` and `false` on their own is not as clear as:
```Go
{rawurl: "https://example.com/api/v3", wantErro…
I'd suggest using keyed fields here to make the boolean values more readable. Just seeing `true` and `false` on their own is not as clear as:
```Go
{rawurl: "https://example.com/api/v3", wantErro…shurcooL commented on Seems like godoc.org is down in github.com/golang/gddo2dI see. Let me know if I can be of assistance.
(Also, feel free to re-open this issue if you want to use it to track that task. Or file a new one referencing this.)
I see. Let me know if I can be of assistance.
(Also, feel free to re-open this issue if you want to use it to track that task. Or file a new one referencing this.)shurcooL commented on cmd/compile: Incorrect column numbe… in github.com/golang/go2dThis is what a code editor that displays issues inline shows the user:
Note that it…
This is what a code editor that displays issues inline shows the user:
Note that it…shurcooL commented on Summary page for all repos status' in github.com/bradleyfalzon/gopherci2dQuick note, there are some factors to consider when making the comparison above. I use Travis CI to ensure basic functionality and need everything to be passing [95%+ of the time in a year](https://g…
Quick note, there are some factors to consider when making the comparison above. I use Travis CI to ensure basic functionality and need everything to be passing [95%+ of the time in a year](https://g…shurcooL commented on Summary page for all repos status' in github.com/bradleyfalzon/gopherci2dI reacted with 👍 but want to add more details.
I think this could be absolutely great and helpful.
Right now, I know of GopherCI mostly from the status messages it leaves on PRs, etc. Recent…
I reacted with 👍 but want to add more details.
I think this could be absolutely great and helpful.
Right now, I know of GopherCI mostly from the status messages it leaves on PRs, etc. Recent…shurcooL commented on Fix build for wayland in github.com/go-gl/glfw2dThis still needs to be addressed.
This still needs to be addressed.shurcooL commented on Fix build for wayland in github.com/go-gl/glfw2dOkay, thanks.
Here is my suggestion. I think we should change the wiki page to list instructions for installing `wayland-scanner` from packages, and say "or you can install from source if you pref…
Okay, thanks.
Here is my suggestion. I think we should change the wiki page to list instructions for installing `wayland-scanner` from packages, and say "or you can install from source if you pref…shurcooL commented on Add error for no trailing slash in github.com/google/go-github2dI appreciate that you were thoughtful and considered the `c.BaseURL.Path` being empty (i.e., a URL like `https://api.example.com`) case. You're also handling it correctly, because for root URLs, the …
I appreciate that you were thoughtful and considered the `c.BaseURL.Path` being empty (i.e., a URL like `https://api.example.com`) case. You're also handling it correctly, because for root URLs, the …shurcooL commented on compiler: fix handling of struct, a… in github.com/gopherjs/gopherjs2d(Highly agreed with @neelance's remark. Adding unused code IMO is much worse than not handling some cases. Unhandled cases are obvious to spot when it happens, but unused code is not obvious and will…
(Highly agreed with @neelance's remark. Adding unused code IMO is much worse than not handling some cases. Unhandled cases are obvious to spot when it happens, but unused code is not obvious and will…shurcooL commented on goimports: provide own goimports in github.com/dominikh/go-tools2dThe original `goimports` works on a single input .go file at a time, so it has some limitations as a result of that. For example, it can't tell if `fmt.Print` refers to the `fmt` package, or an unexp…
The original `goimports` works on a single input .go file at a time, so it has some limitations as a result of that. For example, it can't tell if `fmt.Print` refers to the `fmt` package, or an unexp…shurcooL commented on Int implemented only by int32 in github.com/neelance/graphql-go2dI'm not sure if this is a valid option in this scenario, but I suspect it is, so let me point it out.
This library could decide to accept types other than `int32` and implicitly convert them/trunc…
I'm not sure if this is a valid option in this scenario, but I suspect it is, so let me point it out.
This library could decide to accept types other than `int32` and implicitly convert them/trunc…shurcooL commented on Going to tag v2.0.0 in github.com/russross/blackfriday3d> Well, apparently, `dep` can perfectly do that today, at least for first-order importers.
I know it can, but the problem is that _we_ do not support/endorse it. Let's discuss only the supported/v…
> Well, apparently, `dep` can perfectly do that today, at least for first-order importers.
I know it can, but the problem is that _we_ do not support/endorse it. Let's discuss only the supported/v…shurcooL commented on Going to tag v2.0.0 in github.com/russross/blackfriday3d> One easy way to get out of it is to remove the `v2.0.0` tag and retag with `v2.0`, i.e. avoid semantic versioning. That would be a pity, though, I wouldn't like to take this course if possible.
…
> One easy way to get out of it is to remove the `v2.0.0` tag and retag with `v2.0`, i.e. avoid semantic versioning. That would be a pity, though, I wouldn't like to take this course if possible.
…
shurcooL commented on Added periods to all missing lines in github.com/avelino/awesome-go4dSee, this title doesn't have a period either. Just pointing it out, nothing to change here.
See, this title doesn't have a period either. Just pointing it out, nothing to change here.shurcooL commented on Added periods to all missing lines in github.com/avelino/awesome-go4dThis looks like a title, not a sentence. No period needed. Maybe make the titles use capital letters to make it clear:
> * Selenium and Browser Control Tools
This looks like a title, not a sentence. No period needed. Maybe make the titles use capital letters to make it clear:
> * Selenium and Browser Control ToolsshurcooL commented on Added periods to all missing lines in github.com/avelino/awesome-go4dThis is more of a title rather than a sentence, so it doesn't need a period. "Relational Databases" above is another title that doesn't have a period.
This is more of a title rather than a sentence, so it doesn't need a period. "Relational Databases" above is another title that doesn't have a period.Last Week
shurcooL commented on Going to tag v2.0.0 in github.com/russross/blackfriday4d@sdboyer wrote a detailed and informative analysis at https://github.com/shurcooL/github_flavored_markdown/issues/12#issuecomment-322005594.
@rtfb, I think that should be enough information for us…
@sdboyer wrote a detailed and informative analysis at https://github.com/shurcooL/github_flavored_markdown/issues/12#issuecomment-322005594.
@rtfb, I think that should be enough information for us…shurcooL commented on Doesn't build in projects that use … in github.com/shurcooL/github_flavored_markdown4dThanks a lot for the detailed and informative response @sdboyer! I think that should be sufficient information for us to find a good upstream solution in blackfriday.
Thanks a lot for the detailed and informative response @sdboyer! I think that should be sufficient information for us to find a good upstream solution in blackfriday.shurcooL commented on Go-Package-Store should know how to… in github.com/shurcooL/Go-Package-Store4dThis is a feature I'd like to implement someday, and I'm using this issue to track the progress towards that. It's not done yet. I'd like to keep it open until it's done, if that's okay with you @Net…
This is a feature I'd like to implement someday, and I'm using this issue to track the progress towards that. It's not done yet. I'd like to keep it open until it's done, if that's okay with you @Net…shurcooL commented on Doesn't build in projects that use … in github.com/shurcooL/github_flavored_markdown4d> I believe, and I might be mistaken, if you add a `Gopkg.toml` like this:
>
> ```toml
> required = ["github.com/russross/blackfriday"]
>
> [[constraint]]
> branch = "master"
> name = "gi…
> I believe, and I might be mistaken, if you add a `Gopkg.toml` like this:
>
> ```toml
> required = ["github.com/russross/blackfriday"]
>
> [[constraint]]
> branch = "master"
> name = "gi…shurcooL commented on Doesn't build with blackfriday v2 in github.com/shurcooL/github_flavored_markdown4dTo clarify, this project has very specific dependency management in place, and my intention is to make it work without any guessing by any tool, after this specific issue is resolved.
To clarify, this project has very specific dependency management in place, and my intention is to make it work without any guessing by any tool, after this specific issue is resolved.shurcooL commented on Fix build for wayland in github.com/go-gl/glfw4dFriendly ping @thomasruiz. Are you still interesting in completing this? If so, did you see my question above?
Friendly ping @thomasruiz. Are you still interesting in completing this? If so, did you see my question above?shurcooL commented on GLFWimage under-documented in github.com/glfw/glfw4dFor posterity, this was also related to #426.
For posterity, this was also related to #426.shurcooL commented on Q: Is the image format for icons im… in github.com/go-gl/glfw4dGLFW (C library) docs state this for both cursor and window icon images:
```
The image data is 32-bit, little-endian, non-premultiplied RGBA, i.e. eight bits
per channel. The pixels are arrange…
GLFW (C library) docs state this for both cursor and window icon images:
```
The image data is 32-bit, little-endian, non-premultiplied RGBA, i.e. eight bits
per channel. The pixels are arrange…shurcooL commented on Q: Is the image format for icons im… in github.com/go-gl/glfw4dI suspect we should be supporting `NRGBA` as well, either instead, or in addition to `RGBA`. Needs investigation.
I suspect we should be supporting `NRGBA` as well, either instead, or in addition to `RGBA`. Needs investigation.shurcooL commented on Doesn't build with blackfriday v2 in github.com/shurcooL/github_flavored_markdown4dAnother possible fix, if I understand things correctly, would be for my `github_flavored_markdown` package to include a `Gopkg.toml` file that requires v1 version of `github.com/russross/blackfriday`…
Another possible fix, if I understand things correctly, would be for my `github_flavored_markdown` package to include a `Gopkg.toml` file that requires v1 version of `github.com/russross/blackfriday`…shurcooL commented on Doesn't build with blackfriday v2 in github.com/shurcooL/github_flavored_markdown4d> What it basically boils down to is, either this repo needs to update to v2 of blackfriday, or it needs to vendor it.
I want to update to v2, but it's not a priority, so it won't be done very soo…
> What it basically boils down to is, either this repo needs to update to v2 of blackfriday, or it needs to vendor it.
I want to update to v2, but it's not a priority, so it won't be done very soo…shurcooL commented on Going to tag v2.0.0 in github.com/russross/blackfriday4dThis tag is causing issues in projects that use dep, and import libraries that import `github.com/russross/blackfriday`.
See https://github.com/shurcooL/github_flavored_markdown/issues/12.
/cc …
This tag is causing issues in projects that use dep, and import libraries that import `github.com/russross/blackfriday`.
See https://github.com/shurcooL/github_flavored_markdown/issues/12.
/cc …shurcooL commented on Doesn't build with blackfriday v2 in github.com/shurcooL/github_flavored_markdown4dThanks for filing. We should report this at blackfriday and/or dep and come up with a solution. The v2 version is supposed to be available at a different import path (`gopkg.in/russross/blackfriday.v…
Thanks for filing. We should report this at blackfriday and/or dep and come up with a solution. The v2 version is supposed to be available at a different import path (`gopkg.in/russross/blackfriday.v…shurcooL commented on Seems like godoc.org is down in github.com/golang/gddo5dI don't know who fixed it, but the issue is resolved.
I don't know who fixed it, but the issue is resolved.shurcooL commented on Fix so that BaseURL can be used wit… in github.com/google/go-github5dSounds good. Thank you @178inaba!
Sounds good. Thank you @178inaba!shurcooL commented on Add cryptographer-preview header to… in github.com/google/go-github5dSorry @RaviTezu, I was mistaken. For some reason, I thought this PR and PR #686 were returning `Repository` and that `License` would now be populated after setting this preview header.
Now I see t…
Sorry @RaviTezu, I was mistaken. For some reason, I thought this PR and PR #686 were returning `Repository` and that `License` would now be populated after setting this preview header.
Now I see t…shurcooL commented on Fix so that BaseURL can be used wit… in github.com/google/go-github5dI would prefer a solution that checks and reports a helpful error message if the BaseURL doesn't have a trailing slash. It's easy, and can be done in `NewRequest` like this:
```Go
if !strings.Has…
I would prefer a solution that checks and reports a helpful error message if the BaseURL doesn't have a trailing slash. It's easy, and can be done in `NewRequest` like this:
```Go
if !strings.Has…shurcooL commented on Fix so that BaseURL can be used wit… in github.com/google/go-github5dI don't think it's valid to change `c.UploadURL` for `c.BaseURL`.
I don't think it's valid to change `c.UploadURL` for `c.BaseURL`.