Today
dmitshur commented on golang.org/x/build: mac builders down2m
Thanks Brad. I'll close this issue since the Mac builder outage is resolved: ![image](https://user-images.githubusercontent.com/1924134/67408908-c2da7e80-f587-11e9-8cc8-93b7100bbf7c.png) > T…
dmitshur closed an issue golang.org/x/build: mac builders down2m
dmitshur commented on wiki: recommended Ubuntu port still does not have security fix release1h
See also #34038 for discussion and proposal for improving the wiki situation.
dmitshur commented on net/http: build tag to disable HTTP/21h
Changing to NeedsFix per https://github.com/golang/go/issues/35082#issuecomment-545239713. Should go back to NeedsDecision if there are complications.
dmitshur commented on golang.org/x/website: golang.org homepage has two different Hello worlds, one is not gofmt-ed2h
I think having the "// You can edit this code!" comment is more useful on initial page load, and less so after, because once users have changed between different snippets, it's more likely they'll un…
dmitshur opened an issue golang.org/x/build: mac builders down2h
All Mac builders are currently down, as reported at https://farmer.golang.org/#health: ![image](https://user-images.githubusercontent.com/1924134/67395969-d3352e00-f574-11e9-8b97-b005e9781236.png)…
Yesterday
dmitshur commented on cmd/go: build for armv7s with -buildmode=c-archive16h
I'm not very familiar with different ARM architectures. The cmd/go documentation at https://golang.org/cmd/go/#hdr-Environment_variables says that the only valid values for `GOARM` environment variab…
dmitshur commented on text/template: pointer receivers methods do not work with non pointer values in templates16h
Thanks for the issue report. Issue #18816 may be somewhat relevant. > Template 3 is just the control for arrays > Template 4 shows that this does work in arrays (presumably because arrays are …
dmitshur reviewed +2 on golang.org/x/build/env/js-wasm: update to Node.js v13.017h
The change so far looks good. Feel free to ask for another review if you make substantial changes by the time this is ready to submit.
dmitshur commented on golang.org/x/build/cmd/gopherbot: fix Gerrit reviewer email addresses18h
> We should file a bug/feature request against Gerrit to be able to resolve this problem more generally, rather than just for the Go project. There are some existing ones: - https://bugs.chromi…
dmitshur commented on golang.org/x/build/cmd/gopherbot: fix Gerrit reviewer email addresses18h
I've run into this too. I've worked around it by changing the name and status in my unwanted Gerrit profile to be the string "DO NOT USE": ![](https://dmitri.shuralyov.com/usercontent/1924134@gith…
dmitshur commented on golang.org/x/website/cmd/golangorg: GoogleCN does not work19h
I'm a little confused by the `curl` example in this issue report. It makes a POST request instead of GET. It targets the `/doc/code.html` page, but the [current `/doc/code.html` page](https://github.…
dmitshur commented on net/http: build tag to disable HTTP/220h
Is it viable to instead make just the HTTP/1 client available in an external package, and use that instead of `net/http`? Similarly to how HTTP/2 exists in `golang.org/x/net/http2` in addition to `ne…
dmitshur commented on net/http: build tag to disable HTTP/220h
/cc @bradfitz
dmitshur commented on golang.org/x/build/dashboard: add FreeBSD arm64 builder21h
(1 comment) Add another Updates line for golang/go#35058.
dmitshur commented on : Go 1.13.3 distribution lacks notarization for macOS Catalina, requiring whitelisting of each binary23h
@andybons Yes. ``` $ csrutil status System Integrity Protection status: enabled. ```
This Week
dmitshur opened an issue golang.org/x/build: add FreeBSD/amd64 builder1d
Creating a tracking issue for the task of adding a `freebsd/arm64` builder, factored out from https://github.com/golang/go/issues/24715#issuecomment-537742727. /cc @dmgk @bradfitz @bcmills
dmitshur merged a change net/http: remove parseURL variable1d
dmitshur commented on net/http: remove unexported parseURL variable1d
Yes. I believe this is the relevant part from https://golang.org/ref/spec#Import_declarations: > The import names an identifier (PackageName) to be used for access and an ImportPath that specifies t…
dmitshur commented on database/sql: remove forced log import from test1d
> You can see my early frustration that probably led to me writing goimports! :) Indeed. FWIW, this CL came to be from someone on r/golang seeing this line and not knowing why it needed to be there…
dmitshur commented on crypto/x509: enable deep copy of x509.CertPool1d
/cc @FiloSottile @frankgreco
dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages1d
When an issue or change has a path that doesn't match any existing directory, it normally gets assigned to the repository root or "other". Such issues and changes are missed when doing a query by imp…
dmitshur commented on golang.org/x/crypto/ssh: Unable to start subsystem without an exec or shell message 1d
/cc @hanwen @FiloSottile per [owners](https://dev.golang.org/owners).
dmitshur commented on runtime: unexpected return pc for os/signal.loop called from 0x01d
Hello, thanks for the report. It will be very helpful to try to create a smaller snippet that can reproduce this issue in order to find the root problem. Are you able to narrow it down further? …
dmitshur commented on doc: update ports list description to reflect current status1d
(1 comment) Suggestion, add: Updates #27689
dmitshur commented on _cgo_export.c:1:0: error: -fPIC ignored for target (all code is position independent) [-Werror]1d
Hello, Setting up your Windows system to enable cross-compilation to Linux can be tricky, and I suspect you're running into a problem due to misconfiguration there. There are some common questions a…
dmitshur commented on cmd/go: malformed module path "xxxx/xxxx/uuid" missing dot in first path element when migrating from GOPATH based dep to go mod1d
There is currently a requirement that the module path must have a dot in the first path element. > Any help in solving this would also be appreciated. The only change you have to make is add a …
dmitshur commented on math: inconsistent conversion from NaN to int on js/wasm2d
I thought there's a chance this could be related to 64-bit vs 32-bit, so I tried on `darwin/386` in addition to `darwin/amd64`, but they both got the same result as `windows/amd64`. So this seems spe…
Last Week
dmitshur pushed to master in github.com/shurcooL/events3d
a1a38c192fa4e17cc3caa42f535f12f731e367c3event: include more context in Event.MarshalJSON error
dmitshur opened a change github.com/irashura/irashura.github.io: set viewport width to device-width4d
This helps when viewing the website on devices with smaller screens.
dmitshur created branch in github.com/irashura/irashura.github.io4d
viewport
dmitshur commented on cmd/go: timestamp of files in module archive unset4d
> We haven't promised those are stable, but changing them would probably surprise some people. I think we should actively document that they're not guaranteed to be stable, so that people don't begi…
dmitshur commented on : Go 1.13.3 distribution lacks notarization for macOS Catalina, requiring whitelisting of each binary4d
I can reproduce on my personal MBP with macOS 10.15 (19A602) when installing from the .pkg installer too, however it's a different (less intrusive) experience. The "macOS cannot verify that this a…
dmitshur commented on all: Go 1.13.3 release status4d
This release is done, see the announcement [here](https://groups.google.com/d/msg/golang-announce/R3XK-Wf-Mtk/B2Hc62kuCgAJ).
dmitshur closed an issue all: Go 1.13.3 release status4d
dmitshur commented on all: Go 1.12.12 release status4d
This release is done, see the announcement [here](https://groups.google.com/d/msg/golang-announce/R3XK-Wf-Mtk/B2Hc62kuCgAJ).
dmitshur closed an issue all: Go 1.12.12 release status4d
dmitshur closed a change doc: document Go 1.13.2 and Go 1.12.115d
dmitshur commented on doc: document Go 1.13.2 and Go 1.12.115d
This change was already merged via CL 201785.
dmitshur commented on doc: document Go 1.13.2 and Go 1.12.115d
(1 comment) There's some missing or disarranged word here.
dmitshur commented on golang.org/x/website/cmd/golangorg: migrate from legacy to split health checks5d
(1 comment) I also don't think it's a problem for them to use the same endpoint, it just means we don't differentiate between the two. A more sophisticated readiness check can report if the server i…
dmitshur commented on golang.org/x/website/cmd/golangorg: migrate from legacy to split health checks5d
(1 comment) This can be any custom HTTP path. I chose to use /_ah/health because we already had that endpoint implemented and serving 200 OK, which is what the liveness check endpoint needs to do: …
dmitshur commented on doc: document Go 1.13.35d
(1 comment) That CL edits a _test.go file only, so it doesn't need to be considered for the purpose of release notes.
dmitshur commented on doc: document Go 1.13.35d
(1 comment) All other releases use "go command" without <code>, so it might be fine to leave it out for consistency.
dmitshur commented on doc: document Go 1.13.35d
(1 comment) Just "doc" isn't real package. Is this coming from CLs that had "doc:" prefix? Those refer to documentation in the top-level doc directory (https://github.com/golang/go/tree/master/doc).…
dmitshur reviewed +2 on misc/boring: [dev.boringcrypto] add go1.13.2b4 and go1.12.11b4 to RELEASES file5d
(1 comment) Just checking, both releases were published (not just the lastest) because CL 200763 is merged and was used, is that right? This can be more specific, if you'd like: s/new releases…
dmitshur edited the wiki5d
dmitshur commented on golang.org/x/tools/cmd/godoc: generate static docs5d
It's not known when this issue will be complete. When there are updates, they'll be posted on this issue.
dmitshur starred in github.com/google/gerritfmt5d
dmitshur commented on cmd/go: timestamp of files in module archive unset5d
> Is this the expected behavior? This is the behavior of `go mod download`: ``` $ cd $(mktemp -d) $ export GOPATH=$(pwd) $ export GO111MODULE=on $ export GOPROXY=direct $ go mod download g…
dmitshur commented on golang.org/x/tools/gopls: go get golang.org/x/tools/gopls@master fails6d
@fsouza Thanks, that explains why builders didn't catch it. The replace directive was used during tests because `go test ./...` ran inside gopls directory and so it was the main module.
dmitshur commented on golang.org/x/tools/gopls: go get golang.org/x/tools/gopls@master fails6d
Thanks for reporting, I can reproduce it too. It's a build problem on https://github.com/golang/tools/commit/846f856e7d713bd2e8112adf3b8649d7bb111cca commit (**edit:** it happens only when gopls isn'…
dmitshur commented on golang.org/x/build/app/appengine: can't deploy anymore6d
Yeah, GO111MODULE=on makes `gcloud app deploy` use the module root as the root, rather than the directory containing app.yaml. It was added to make deploys consistent regardless of who was deploying …
dmitshur commented on golang.org/x/build/app/appengine: update deploy instructions6d
(2 comments) This is being kept, with modifications. See new line 24. If you can't view the GCP console and prefer to just deploy directly to final URL, you can ignore these steps and remove --no-p…
dmitshur commented on golang.org/x/build/app/appengine: can't deploy anymore6d
That's very strange. The deploy took 2~ minutes for me when I tried it just now. The error is similar to an issue we had when deploying the playground was taking too long, and hitting that time limi…
dmitshur commented on golang.org/x/build/app/appengine: can't deploy anymore6d
Docs worked when I deployed last, on Oct 8. I use `--no-promote` flag explicitly and then promote after making sure the new version looks okay, but I don't expect that to cause the difference above. …
dmitshur reviewed +2 on github.com/google/go-github/v28: define a new go module for the scrape package1w
Changes look good, not seeing issues. If you want Travis CI to run tests in the scrape module, you should add an extra line under script, something like: ``` - cd scape && go test ./... ``` …
dmitshur commented on github.com/google/go-github/v28/Discussion: github scraping package1w
Yes, take a look at https://golang.org/wiki/Modules#faqs--multi-module-repositories for more information about it. I would suggest moving the scraping example into `scrape/example/scrape`, that wa…
dmitshur commented on github.com/shurcooL/githubv4: Variable input of type MergePullRequestInput! was provided invalid value1w
I don't see anything wrong in that snippet. Having to create a local variable when optional fields have constant enum values is unfortunate (and maybe should be improved, in a separate issue), but th…
dmitshur commented on net: TestDialerLocalAddr and TestNetpollDeadlock are flaky on macOS 10.121w
In case it's helpful, [this StatCounter Global Stats page](https://gs.statcounter.com/os-version-market-share/macos/desktop/worldwide) suggests 10.12 is currently at just under 10% use, while 10.13 i…
dmitshur commented on github.com/google/go-github/v28/Discussion: github scraping package1w
I think it's reasonable to include it in this repository, but it may make sense to keep it in a separate module. That way, its dependencies wouldn't affect the main module, and it can be versioned se…
dmitshur commented on github.com/ejcx/passgo/v2: motivation for removing password vault git history1w
Yes, this was a question. I think it's answered now, so I'll close. If I think of concrete suggestions, I'll make a new issue. Thanks.
dmitshur commented on os: open stdin read-only and stdout/stderr write-only1w
Here's a playground snippet writing to `os.Stdin`: https://play.golang.org/p/KRsTZeUNDrx It reports an error on the playground: ``` write /dev/stdin: Bad file number ``` But works witho…
dmitshur commented on golang.org/x/website: document query strings for /dl more prominently1w
If we decide to document these more prominently, we'd need to be very clear about the stability and reliability of the APIs. Them being documented only in internal packages is a signal they're primar…
dmitshur commented on github.com/FiloSottile/age/.travis.yml: enable Travis-CI1w
Is using arm64 instead of amd64 intentional?
Earlier
dmitshur commented on cmd/go: do not update 'go.mod' automatically if the changes are only cosmetic1w
Would it be an accurate analogy to say this is like running the `go build` command on poorly formatted Go code. The `go build` command successfully builds such code but does not automatically apply f…
dmitshur opened an issue golang.org/x/tools/gopls/internal/hooks: TestDiff is failing1w
The `TestDiff` test in `golang.org/x/tools/gopls/internal/hooks` package is failing on latest x/tools commit (in module mode, on Go master and 1.13 release branches), as caught by post-submit builder…
dmitshur closed an issue proxy.golang.org: 1w
dmitshur commented on proxy.golang.org: 1w
This isn't an issue with the module mirror. You can confirm by trying the same command with `GOPROXY` set to "direct": ``` $ cd $(mktemp -d) $ export GOPATH=$(pwd) $ export GO111MODULE=on $ ex…
dmitshur opened an issue all: either enforce prefix for non-master branches with a bot, or remove the requirement1w
The process for making changes to branches other than `master` is described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls. It requires adding a "[branch-name]" prefix to the commit …
dmitshur commented on golang.org/x/build: skip `darwin-386-10_14` builder on release-branch.go1.122w
@bcmills That is correct. I think it is a low priority enough wart that it can wait a few weeks (compared to the master branch of the main Go repo, I didn't think that could wait as long), but let…
dmitshur commented on cmd/link: minimum macOS version changed going from 1.12.5 to 1.12.92w
I'll move this issue to WaitingForInfo state, because we can't proceed with investigating it without more information. I'll also remove release-blocker, as it doesn't need to block the release of Go …
dmitshur commented on golang.org/x/build: where'd the Go 1.13 nacl builders go?2w
I deployed [CL 199800](https://golang.org/cl/199800) and it was sufficient to resolve this issue. ![image](https://user-images.githubusercontent.com/1924134/66415223-1dd97680-e9c9-11e9-87eb-3b87dd…
dmitshur commented on doc: document that Go 1.14 is last to support darwin/arm?2w
Thanks for providing that information Elias. I was thinking about watchOS and tvOS but wasn't sure what their state of 32->64-bit migration was. From looking over https://en.wikipedia.org/wiki/Apple…
dmitshur commented on doc: document that Go 1.14 is last to support darwin/386?2w
Brad, do you have an idea of the benefits of removing `darwin/386`? Alternatively, what are the costs of keeping it? I'm aware of: - needing to have builders for it - keeping them functional (human…
dmitshur commented on doc: document that Go 1.14 is last to support darwin/386?2w
> an easy way to hack on the 386 port Does hacking on a port require being able to run the binaries, or just test that it compiles? If the latter, it'll still be possible to use something like `li…
dmitshur opened an issue doc: document that Go 1.14 is last to support darwin/arm?2w
iOS 13 (and iPadOS 13) does not support running 32-bit apps. iOS 10 was the last version that supported 32-bit apps (with very visible warnings), and it's 3 years old. Is it time to remove `darwin…
dmitshur commented on golang.org/x/build: add macOS Catalina builder2w
Just a 64-bit one, right? macOS Catalina does not support running 32-bit apps.
dmitshur commented on golang.org/x/build: keep test result logs available after success2w
I think coordinator still needs to be deployed with the change; re-opening to track that.
dmitshur commented on golang.org/x/build: where'd the Go 1.13 nacl builders go?2w
The problem turned out to be an incompatible intersection of behaviors across `cmd/coordinator` and `app/appengine` (and serves as further motivation to merge the two codebases into one, made issue #…
dmitshur opened an issue x/build/{cmd/coordinator,app/appengine}: combine codebases2w
We've discussed and agreed wanting to merge `app/appengine` into `cmd/coordinator`. The motivation is to have a single codebase, share more code, fewer separate deployments, and tests with more inclu…
dmitshur commented on golang.org/x/build: where'd the Go 1.13 nacl builders go?2w
They're also not running on release-branch.go1.12, last run was on Sep 6. Coordinator was last deployed 19 days ago (Sep 18~). The last run on master branch was on Aug 30 (https://build.golang.…
dmitshur commented on golang.org/x/net/http2/h2demo: contains expired certificates2w
I thought there'd be no warnings in browser because the README suggested to "install [root CA] to Firefox". If there are warnings, then the above rationale makes sense.
dmitshur edited the wiki2w