Activity

Today
(1 comment) I'm not seeing a change here. Is that intentional?
(4 comments) Thanks a lot for improving the documentation for this process, this is very clear and helpful. I left very minor comments inline. Nit, a runaway capital letter. Add "or newer" unless…
Tested the CL above, it worked as expected: ![image](https://user-images.githubusercontent.com/1924134/78098327-c1ba4280-73ac-11ea-9585-a467fb1663a8.png) No more flakiness, refreshing the page …
This is deployed, and it worked as intended to resolve the health check flakiness problem. I'll submit this now. We can follow this up with more changes/issues based on answers to my previous comment.
Yesterday
(1 comment) Thanks for reviewing! > I would prefer we did something a little bigger as a more complete fix for the bug, or as a follow up All 3 of those suggestions sound like improvements to me. …
> to improve the health check so that it checks all the pods I've sent [CL 226678](https://golang.org/cl/226678) that implements this.
There are 2 gitmirror instances running since 2017 (CL 36801). The gitmirror health check has been relying on fetching the HTML status page from the gitmirror service via its load balancer. If one o…
@bradfitz Thanks for the update, that is understandable. Also thank you for the offer, but maintaining a builder for the riscv64 architecture is not something I have the bandwidth or interest to d…
@bradfitz Friendly ping, do you know if you'll be able to look into this, or is there a better person to talk to about the `host-linux-riscv64-unleashed` builder?
This Week
This issue is happening again now. Refreshing farmer.golang.org sometimes shows that Git mirroring is okay, other times it's showing "repo go: hung? no activity since last success 8h41m49.610989692s …
Do you know if making its opacity 0 a viable alternative?
### What is the URL of the page with the issue? https://pkg.go.dev/cmd/link?tab=doc ### What is your user agent? `Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, l…
(3 comments) Thanks for sending this change. I'm not spotting any issues, some minor comments. s/becomed/became/ If you don't mind fixing an outdated name while you're here, s/runMake/RunMake/. (r…
(1 comment) See previous discussion at https://go-review.googlesource.com/c/go/+/226204/2/src/net/http/roundtrip_js.go#113.
(1 comment) Great. I wasn't sure if it was safe to release while the function is in the middle of running. The documentation currently says: > Func.Release must be called to free up resources when…
The documentation for [`js.Func`](https://pkg.go.dev/syscall/js#Func) currently says: > Func.Release must be called to free up resources when the function will not be used any more. > Release f…
(1 comment) Patch set 2 is ready for review again. TRY=wasm-js This idea seems to have worked out. Implemented it in patch set 2.
Last Week
(1 comment) Hmm, AbortController is supported on almost all modern browsers by now (https://caniuse.com/#search=AbortController), but if we're supporting browsers where it's not, then this approach …
Previously, details about the underlying fetch error were not visible in the net/http error text: net/http: fetch() failed: <object> When using the message property, they are: net/http: fetch() …
When the request context was canceled, the Transport.RoundTrip method could return before the fetch promise resolved. This would cause the success and failure callback functions to get called after t…
I investigated whether the deploy instructions in x/build/cmd/tip (which have the auto-deploy feature) can still be used today, but they have atrophied and cannot be used without making changes to ge…
(Factoring this out from #36825 to describe this problem in more detail, without derailing the higher level decision in that issue.) The deploy instructions for talks.golang.org that are in the x/…
An update on this issue. I brought it up and discussed it while talking with @rsc today. We were in agreement that doing this should be reasonable, given some pre-conditions: - we should create…
This fix has been deployed and it's working as expected. For example, see: - https://pkg.go.dev/testing#hdr-Benchmarks - https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source - ht…
When writing up this issue, I also initially hesitated about suggesting using the `Notes` field, because I noticed all the linux builders don't specify it either. However, the main point of this i…
It should be easy to find out whether the filesystem is case sensitive or insensitive (macOS offers both options). We can put this information in the [`Notes`](https://github.com/golang/build/blob…
During most release types (all other than beta), `releasebot` needs to create a Gerrit CL that update the content of the [`VERSION`](https://github.com/golang/go/blob/release-branch.go1.14/VERSION) f…
I meant to compare with golang.org (powered by x/tools/godoc). godoc.org (powered by github.com/golang/gddo) doesn't implement this feature. Some implementation notes. golang.org renders (via […
### What is the URL of the page with the issue? https://pkg.go.dev/cmd/go ### Screenshot ![image](https://user-images.githubusercontent.com/1924134/77559693-da999400-6e92-11ea-9958-d2444b044…
This should be done. In order to be able to publish new v2 versions, a blocking task is to resolve the current lack of clarity about what import path should be suggested and continued to be used f…
Hi @kolyshkin, thanks for reporting this issue. There seem to be a few different things here. > Apparently (golang/go#26456) golang doesn't like Uppercased letters in package names. This isn…
/cc @ianlancetaylor @thanm @cherrymui @trex58 per [owners](https://dev.golang.org/owners).
/cc @matloob @bcmills @jayconrod
I've sent a CL that should fix this issue once it is deployed. We can keep this issue open to confirm everything is working as expected.
/cc @hanwen @FiloSottile per [owners](https://dev.golang.org/owners).
@FiloSottile Yes, to release-branch.go1.14, since the modified file is in the main Go repository.
@andybons The failure is expected. See #37937 for context. I enabled the builder a few days in advance of it being needed so that it would be available for SlowBots at the time the CL is ready, and …
> For my package, in order to support Go Modules and non-modules users, I need to use a build tag so that I can use `github.com/cenkalti/backoff/v4` for go modules users and `gopkg.in/cenkalti/backof…
This is already implemented! 🎉 It was implemented 2 years ago in the original [CL 114515](https://golang.org/cl/114515). See [here](https://github.com/golang/go/blob/9a2db7c41ba5b1f9498d5354e6c…
We should implement HTTP request cancellation via request context cancellation on `js/wasm` now that `AbortSignal` has become part of the [DOM living standard](https://dom.spec.whatwg.org/#abortsigna…
Earlier
[CL 216765](https://golang.org/cl/216765) was reverted via [CL 217723](https://golang.org/cl/217723), so re-opening.
https://farmer.golang.org says: ``` host-linux-riscv64-unleashed: 0/0 (1 missing) ``` /cc @bradfitz as builder owner per https://farmer.golang.org/builders. Are you able to look into this?
[CL 224078](https://golang.org/cl/224078) is deployed now, and the linux-amd64-staticlockranking builder has started running. It is currently failing, as expected, because the experiment hasn't lande…
The URL of image https://blog.golang.org/go-programming-language-turns-two_gophers.jpg has changed to https://blog.golang.org/2years/2years-gophers.jpg in [CL 223599](https://golang.org/cl/223599). …
Relevant code: https://github.com/golang/net/blob/a8b05e9114ab0cb08faec337c959aed24b68bf50/http2/h2demo/h2demo.go#L326-L329 `log.Fatal` explains this.
Its pod was restarted 3 hours ago, and is currently in CrashLoopBackOff state. The log just has: ``` 2020/03/20 21:40:03 Error fetching https://blog.golang.org/go-programming-language-turns-tw…
As a follow-up to #37953, we can improve the `atLeastGo1` and `atMostGo1` helpers so that they operate closer to what the name suggests, and report only whether the Go version meets a certain number.…
Thanks for providing more information and having the discussion. It has helped me understand the current situation better, and I think [CL 223381](https://golang.org/cl/223381) is a safe change to…
No problem Austin, it'll make its way into the next minor release. Thank you!
@ulikunitz Yes, the review needs to be completed. The CL will then get submitted, backported, and be a part of the next minor release. I've left a ping for @aclements on the CL in case the notificat…
@Shurikken Please open a new issue, with information how to reproduce this problem with Go 1.14.1, so we can investigate. Thank you.
dmitshur pushed to master in github.com/shurcooL/home1w
5610814f1d218827074edcc6cab0c6ab3cad11ceinternal/exp/service/activity/gerrit: set body in open change events
I'll remove Soon label and unpin because https://farmer.golang.org/#health reports healthy status by now.
dmitshur starred in github.com/luruke/browser-20201w
Looking at our current builder configuration more, I see that we already build most dev.* branches on most builders. For example, the dev.link branch specifically has many post-submit builders: ht…
Thanks for filing the issue. > Cherry created a preliminary [CL 223381](https://golang.org/cl/223381) to do this, but there were concerns that this might not be a way to go. To clarify, the con…
Sounds good. Thinking about it more, it should be useful to get the builder up and running starting with the latest existing commit on master, and ensure it's passing. Then, when you're ready to l…
I see. For those CLs, it'll be possible to run the new builder via [SlowBots](https://golang.org/wiki/SlowBots) by asking for that builder specifically with something like `TRY=linux-amd64-staticlock…
@danscales Do you think just a post-submit builder (not a part of the default trybot set) is sufficient, or do you think including this builder in trybots would be helpful too?
Manually removing the `pkg` subdirectory with `sudo rm -rf ./pkg` resolved the problem for me. [CL 223924](https://golang.org/cl/223924) looks like a good change. Thanks!
It doesn't reproduce with a fresh checkout: ``` ok cmd/internal/moddeps 8.331s ``` `$HOME/gotip` is my normal checkout of the main Go repo for development. I constantly switch branches and …
I'll try making a new temporary directory, clone https://go.googlesource.com/go, and see if it reproduces there.
``` $ sudo ls -al /Users/dmitshur/gotip/pkg/obj/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20190325161752-5a8dccf5b48a/go.mod -r--r--r-- 1 dmitshur primarygroup 87 Mar 25 2019 /Users/dmitshur/gotip…
Also see [CL 72890](https://golang.org/cl/72890) for related work. It is an attempt to split documentation rendering into smaller and more flexible building blocks. An updated copy of that package is…
Thanks for sending that change, @JAicewizard. It will be helpful to have that prototype when discussing and considering this change. The `go/doc` package is low level and in the standard library. …
### What version of Go are you using (`go version`)? <pre> $ go version go version devel +6412750f32 Wed Mar 18 01:03:36 2020 +0000 darwin/amd64 </pre> ### Does this …
The SlowBot run is stuck in waiting_on_machine state, meaning it's waiting for a builder to become available and get scheduled to run that build. There's only one plan9-386-0intro reverse builder,…
Restarted the server via [Packet UI](https://github.com/golang/build/blob/1e42a94bc4f581883a689d2d139f5b79839c2b49/env/linux-arm64/packet/README#L3) to fix it.
From https://farmer.golang.org/: ![image](https://user-images.githubusercontent.com/1924134/76963954-4199d480-68f8-11ea-9b24-d3e0ed663056.png) Previously: - #37371 (last occurrence, 25 days …
@gopherbot, please consider this issue for backport to Go 1.13. This is a test fix. It is needed to resolve a test failure in the `cmd/compile/internal/syntax` package on windows-amd64-longtest build…
@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a test failure in the `os` package on windows-amd64-longtest builder, which could be masking other problems (du…
@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a failure in the `net/http` package on windows-amd64-longtest builder, which could be masking other problems an…
> A direct server (not a proxy) probably don't know the package-to-repository mapping. I don't understand this point. Given the server needs to serve responses to `?go-get=1` requests, wouldn't it h…
As @tbpg said, they are not in the build, but they are in the module graph and so they still need to be written down. Also see the `cmd/go` proposal https://github.com/golang/go/issues/36460. It is …
[CL 223381](https://golang.org/cl/223381) is related. It's a request to start running post-submit builders on new commits on `dev.*` branches.
dmitshur pushed to dev in github.com/shurcooL/home2w
d824e020b56131f0e79fbecc3fd57cb2204e0e33internal/exp/app/issuesapp/frontend: switch to Go 1.14 syscall/js API
61f52dfd98e8a7d221b6d7d813a1e49997c27b4binternal/exp/app/issuesapp: remove State.CurrentUser field
42937cfaff4a3f641ea6510d51b1ae3c76954681internal/exp/app/issuesapp: remove Options.Notifications field
e005547414dbe6802d2383576bcad901a089ffceinternal/exp/app/issuesapp: remove Options.DisableReactions field
9d529c656a1a233af8272c4629b53f8054fb7ad6internal/exp/app/issuesapp: simplify Options.BodyPre field
5d06b9bc070cfb27de0aa236160fff2ba97eaf3finternal/exp/app/issuesapp: remove state.ForceIssuesApp field
21e9ca37f43180ca9f50274d677e621de50375c5internal/exp/service/issue: delete State, reuse state.Issue
f829068906a89a7e68fbb426e391c97d8385a136internal/exp/service/issue/httpclient: add path parameter to client
7b76512358bd900914b338d57bdcca67edc9602cinternal/exp/app/issuesapp: delete internal error handler
475d9a2ec5aacdaf5d15dd11070c5559d2904fafinternal/exp/...issue...: add Create issue API endpoint, use in app
619daee9346ca4b660273bdc8247b3381f7b9218internal/exp/...issue...: move ListTimeline into Service, delete List{Comments,Events}
09fdc29730b1ada458af719cc7e26f6ede75a2bainternal/exp/{service,app}: add copies of github.com/shurcooL/issues{,app}/...
00df5691e674df1a3ad87a5562dce3415caa2a70add Gateway KB-2961 keyboard to setup section
pkg.go.dev interprets versions in the same way as the `go` command in module mode. The problem here seems to be that repository doesn't publish versions that are compatible to be used with the `go` c…
I suspect the behavior differs depending whether module mode or GOPATH mode is used. The documentation you're quoting there was written for GOPATH mode. /cc @jayconrod @bcmills @matloob per [owner…
dmitshur pushed to master in github.com/shurcooL/home2w
00df5691e674df1a3ad87a5562dce3415caa2a70add Gateway KB-2961 keyboard to setup section
> Gopherbot opened for 1.12 and 1.13, reopening this issue for 1.14. @toothrot has opened a new backport issue for 1.14 (#37471), and this issue is already fixed on master via [CL 220587](https://…
We've discussed this cherry pick candidate in a release meeting. To recap the latest status of this candidate, we know this is a serious problem and we have been investigating to see if there is a…