Today
shurcooL starred github.com/cweill/gotests25m
shurcooL commented on 651680c71b22b1164ee36398b009b2da5839e694Remove tests against Go… in github.com/cweill/gotests26m
> so it doesn't make sense for it to potentially break the build. FYI, @cweill, if you want to still run against master in order to potentially get notified about upcoming issues earlier, without …
Yesterday
shurcooL pushed to master in github.com/shurcooL/githubql20h
43170daf2ddf49261bd8a1c7b0978eb40a760bc7Regenerate for 2017-11-18 schema changes.
shurcooL commented on Refrain from setting 200 OK on cach… in github.com/gregjones/httpcache20h
Minor, the period at end of sentence after "replaced" is missing here.
shurcooL commented on Support MarketeplacePurchaseEvent in github.com/google/go-github21h
Additionally, you'll need to add an implicit `Installation *Installation `json:"installation,omitempty"` field. Its existence is documented at https://developer.github.com/webhooks/#payloads. Put it …
shurcooL commented on Support MarketeplacePurchaseEvent in github.com/google/go-github21h
You'll need to break the fields into two sections. The event API payload fields (of which, there's only one, `action`): ![image](https://user-images.githubusercontent.com/1924134/32993806-5c53e4e8…
shurcooL commented on Support MarketeplacePurchaseEvent in github.com/google/go-github21h
We don't use `time.Time` directly in go-github, we have a custom [`Timestamp`](https://godoc.org/github.com/google/go-github/github#Timestamp) type defined that handles some inconsistencies in time f…
shurcooL commented on vfsutil: Remove dependency on godoc… in github.com/shurcooL/httpfs21h
Resolved in 809beceb23714880abc4a382a00c05f89d13b1cc. Compare package imports [before](https://gotools.org/github.com/shurcooL/httpfs/vfsutil?rev=809beceb23714880abc4a382a00c05f89d13b1cc^&tab=imports…
shurcooL pushed to master in github.com/shurcooL/httpfs21h
809beceb23714880abc4a382a00c05f89d13b1ccvfsutil: Remove x/tools/godoc/vfs dependency.
shurcooL commented on vfsutil: Remove dependency on godoc… in github.com/shurcooL/httpfs21h
That looks like a good idea. Thank you for finding and reporting this opportunity to improve the code @johanbrandhorst!
shurcooL commented on unrecognized import path "neugram.i… in github.com/shurcooL/gtdo22h
I've confirmed, the issue is indeed external. Reported it at https://github.com/neugram/ng/issues/102.
shurcooL commented on unrecognized import path "neugram.i… in github.com/shurcooL/gtdo23h
Thank you very much for reporting the issue, I’ll investigate it and try to resolve it soon. However, expect a high chance that this issue is on the `neugram.io` side, and will need to be fixed th…
shurcooL commented on error comparing declarations: missi… in github.com/bradleyfalzon/apicompat1d
Oh, ok, gotcha. Yeah, that’s the latest. I just wanted to make sure the original issue wasn’t caused due to version skew or something.
Last Week
shurcooL commented on Bug fix PUT /repos/:owner/:repo/bra… in github.com/google/go-github1d
Good catch. I think we can still work around it. The slices will need to be changed to pointers to slices, keeping `omitempty`. Then `nil` means omit, but empty slice is preserved. See https://pla…
shurcooL commented on travis: why is it saying the build … in github.com/neugram/ng1d
> Maybe we hit a time limit. Given I don't know the exact cause, it could be a time limit, but the following evidence makes me think otherwise. In the latest build failure log on 1.9 available at ht…
shurcooL commented on travis: why is it saying the build … in github.com/neugram/ng1d
In case this is helpful, I've seen seemingly similar `signal: killed` errors in Travis at https://github.com/go-gl/gl/pull/73. Unfortunately, we never really figured out the exact problem or found a …
shurcooL commented on error comparing declarations: missi… in github.com/bradleyfalzon/apicompat1d
> The issue is the string in this case is: > > ```Go > package expr > type ExternalService interface{ > MarkRead(ctx context.Context, appID string, repo github.com/shurcooL/notifications.Repo…
shurcooL commented on error comparing declarations: missi… in github.com/bradleyfalzon/apicompat1d
> Thanks for the issue, I'll work on a fix for this. No problem, I'm happy if it's helpful. :) Thanks for describing what the issue appears to be, it's interesting for me to learn about. Just for …
shurcooL commented on Bug fix PUT /repos/:owner/:repo/bra… in github.com/google/go-github2d
I've prototyped how it can look like (this is not necessarily the final version and can be adjusted further) for dismissal_restrictions, which has one of 3 modes: empty JSON object to disable, JSON o…
shurcooL commented on Bug fix PUT /repos/:owner/:repo/bra… in github.com/google/go-github2d
> I think the omitempty strategy won't work. If we want to disable the dismissal_restrictions then the strategy works because it generates an empty JSON object (that's neat I like the approach). The …
shurcooL commented on Add support for the repository tran… in github.com/google/go-github2d
Why is `transfer` a `*TransferRequest` pointer rather than value? That means user can pass `nil`, but that wouldn't be meaningful, would it?
shurcooL commented on Add support for the repository tran… in github.com/google/go-github2d
According to GitHub API docs, `new_owner` is required, so I don't think `omitempty` is appropriate here.
shurcooL deleted branch in github.com/shurcooL/isFileGenerated2d
use-new-generated-pkg
shurcooL pushed to master in github.com/shurcooL/go2d
004faa6b0118cf52635363b72b51cdcc297800a2analysis: Remove deprecated package.
shurcooL starred github.com/gocelery/gocelery2d
shurcooL commented on Raw GetBlob() support in github.com/google/go-github2d
Another similar change that was recently added was #767. It was for downloading commits in diff or patch format.
shurcooL commented on Support MarketplacePurchaseEvent su… in github.com/google/go-github2d
Why close this PR? I think we just need to rebase the commit on latest master, and regenerate the Go package. See my https://github.com/google/go-github/issues/704#issuecomment-345373248 in the issue…
shurcooL commented on Add support for MarketplacePurchase… in github.com/google/go-github2d
You need to look at the Travis CI output to find out what the issue is. If you look at one of the build logs, e.g., https://travis-ci.org/google/go-github/jobs/302917277, it says: ``` The command…
shurcooL commented on Removes global test client and call… in github.com/google/go-github2d
Agreed, named returned values would help readability. Seeing `string` and `func()` doesn't say much.
shurcooL commented on Sharing a similar utility as a web … in github.com/emojisum/emojisum2d
> i would love if your project used the same mapping. I would suggest you consider my project a small prototype as inspiration, and instead of modifying it, create your own version for emojisum-sp…
shurcooL starred github.com/emojisum/emojisum2d
shurcooL commented on OpenGL 4.6 support. in github.com/go-gl/glow2d
We can make it a requirement to supply a github token to get the authenticated rate limit of 5000 per hour.
shurcooL commented on Refrain from setting 200 OK on cach… in github.com/gregjones/httpcache3d
Minor, but I'd suggest moving the comment out to be on top of the entire test. It describes what the entire test does. E.g., compare with: https://github.com/gregjones/httpcache/blob/cdafe69ab9c9f…
shurcooL starred github.com/google/puffs4d
shurcooL commented on Repository: missing `has_projects` … in github.com/google/go-github4d
Yes, looks like it should be there. Thanks for reporting.
shurcooL commented on repos: add archived boolean field t… in github.com/google/go-github4d
No worries. > got confused by looking at the existing fields (in `Repository`) of type `*bool` some of which have `,omitempty` while others don't. The reason is very relevant. It's primarily to…
shurcooL commented on Replace use of deprecated package a… in github.com/gopherci/isFileGenerated4d
No problem about the delay at all. I'm just pinging to make it easier for you to track active PRs, that's all.
shurcooL commented on repos: add archived boolean field t… in github.com/google/go-github4d
Why doesn't this field have `,omitempty` like the other fields above?
shurcooL commented on Refrain from setting 200 OK on cach… in github.com/gregjones/httpcache4d
Friendly ping @gregjones (see comment above). I've been testing this the last 2 weeks, haven't spotted any issues.
shurcooL commented on Replace use of deprecated package a… in github.com/gopherci/isFileGenerated4d
Friendly ping (after 7+ days).
shurcooL commented on Bug fix PUT /repos/:owner/:repo/bra… in github.com/google/go-github4d
> I think the omitempty strategy won't work. If we want to disable the dismissal_restrictions then the strategy works because it generates an empty JSON object (that's neat I like the approach). The …
shurcooL commented on Bug fix PUT /repos/:owner/:repo/bra… in github.com/google/go-github5d
> the API requires sending an empty JSON object If so, it might be possible to achieve in a simpler way by removing the `,omitempty` option. > I'll take a fresh look at it tomorrow. 👍
shurcooL commented on cmd/gofmt: document that tools must… in github.com/golang/go5d
> Gofmt output must be expected to change in minor ways from time to time. The implication is that people must either (1) not build systems that care which version of gofmt is being used, or (2) make…
shurcooL commented on Bug fix PUT /repos/:owner/:repo/bra… in github.com/google/go-github5d
Now that it's no longer neccessary to send empty arrays to GitHub, this entire `MarshalJSON` method and a lot of other related code can be deleted. The end result will be much simpler. I suggest l…
shurcooL commented on Bug fix PUT /repos/:owner/:repo/bra… in github.com/google/go-github5d
This is closely related to #664 (the issue tracking this) and #703 (an attempt to resolve this in the past, containing relevant information). > I think this is pretty straightforward? This issu…
shurcooL pushed to master in github.com/shurcooL/issues5d
49abdd1dc0438f4a578696a49a82cf72c9cd2811githubapi: Fix time used for predicted event during issue edit.
shurcooL commented on RepositoriesService.ReplaceAllTopic… in github.com/google/go-github5d
Thanks for noting that @sahildua2305, you're right. Closing, this is resolved via #771.
shurcooL commented on gen-accessors should skip Client, s… in github.com/google/go-github5d
Thanks! I think adding a list of blacklisted structs is the way to go.
shurcooL commented on cmd/gofmt: document that tools must… in github.com/golang/go5d
> I also can't think of anything. Suggestions welcome. Like @dsnet, I don't quite understand how the proposed solution ("We should document that tools that write code files that will be checked in s…
shurcooL commented on #720 Initial commit for listing Pla… in github.com/google/go-github6d
Merged. Thank you @lackerman!
shurcooL pushed to master in github.com/google/go-github6d
8b3951c83275136717a7f5e993075b8ba9d09a7eAdd MarketplaceService for listing Plans and Plan Accounts. (#732)
shurcooL commented on size truncation hides some legitima… in github.com/golang/gddo6d
It looks that way to me, yes. I'm not seeing the "The documentation displayed here is incomplete." text anymore. The commit that resolved this might've been 95a6c634fc4948a832d26a56e029b7f709cab14…
shurcooL commented on cmd/gofmt: document that tools must… in github.com/golang/go6d
> We should document that tools that write code files that will be checked in should run gofmt (the program) over their output, not assume that their copy of go/printer matches. A downside of that…
shurcooL commented on website: binary download links invo… in github.com/golang/go6d
@bradfitz Makes sense. Thanks for confirming!
shurcooL commented on #720 Initial commit for listing Pla… in github.com/google/go-github1w
We have some issues with gen-accessors right now, I've filed #778 for it. But fixing that is out of scope of this PR, so just re-generate the package, and it should be fine.
shurcooL commented on #720 Initial commit for listing Pla… in github.com/google/go-github1w
@gmlewis Does that sound good to you? If so, I can apply it and merge.
Earlier
shurcooL commented on Can we assign custom names to enum … in github.com/campoy/jsonenums1w
> I also need to implement stringer for my type There exists [`stringer`](https://golang.org/x/tools/cmd/stringer) for that task. (But I don’t think it’s output is customizable.)
shurcooL commented on live code reloading (asset package … in github.com/gopherjs/vecty1w
Perhaps worth noting, something I want to find a chance to force myself to do is rewrite the `vfsgen` README significantly. Right now, it reads from lowest-level usage details at the top, to highest-…
shurcooL commented on github-accessors.go: Missing access… in github.com/google/go-github1w
The type of that particular field `CurrentUserOrganizationURLs` is `[]string`. It’s not a pointer. Not having an accessor for it seems reasonable, since the accessors exist for pointer fields to h…
shurcooL commented on website: binary download links invo… in github.com/golang/go1w
Looking at https://github.com/golang/tools/commit/9c477bae194915bfd4bc8c314e90e28b9ec1c831 more closely, I see that what's been modified is the redirect URL that `https://golang.org/dl/...` returns (…
shurcooL commented on website: binary download links invo… in github.com/golang/go1w
> We used to have really nice download links that just worked. @bradfitz, what I've always used (for the last 4-6~ major releases) was: ``` curl -L https://golang.org/dl/go1.9.2.linux-amd64.ta…
shurcooL deleted branch in github.com/dustin/go-humanize1w
rello
shurcooL commented on Fix off by one error in RelTime in github.com/dustin/go-humanize1w
> Yeah, I started using the non-mono one. We don't have hard line length limitations at work, and go doesn't do very fancy alignment, so I gave it a shot to see how I'd like it. It's not that bad, …
shurcooL commented on Fix off by one error in RelTime in github.com/dustin/go-humanize1w
> > Not sure about the tests, though. I'd've hoped a lot would break changing a `>=` to a `>` > > I'm guessing it's related to that PR #26 being merged as df564ff1a922025fc8284d8894b701033dbff46b …
shurcooL commented on Fix off by one error in RelTime in github.com/dustin/go-humanize1w
> Heh, I've been using the go font for go code, so I don't remember what alignment looks like. :) Me too! Wait, do you mean you use the actual "Go" font, the non-monospaced one? I use "Go Mono". …
shurcooL pushed to master in github.com/shurcooL/issues1w
aa4ff8c7f44a417f95954447fadbb0c4b5cfde6bgithubapi: Increase page size to maximum allowed.
e60451465bdabaecc6b6d94f6b10605fdfe2d9a7githubapi: Implement CommentDeletedEvent.
shurcooL commented on 904a49491cd5fb5cba832fac98e7e87d56b690a4Special case Comma(math… in github.com/dustin/go-humanize1w
> There's also a typo in "minin64". This has been fixed in #64.
shurcooL commented on Fix off by one error in RelTime in github.com/dustin/go-humanize1w
Tiny nitpick, I'd be tempted to write "1w±0" here to have the rest of the line aligned. And "2w±0" below.
shurcooL commented on Add support for vendoring gopherjs in github.com/gopherjs/gopherjs1w
The status of this PR is "open". To make progress, the PR needs to be reviewed and tested. There would either be changes requested, or it'd be approved and merged. Unfortunately, I don't have an o…
shurcooL commented on Fix off by one error in RelTime in github.com/dustin/go-humanize1w
Can you add two more test cases, `time.Unix(7*24*60*60, -1)` and `time.Unix(14*24*60*60, -1)`, for complete coverage of the boundary?
shurcooL commented on False positives with syscall.Stdin in github.com/mdempsky/unconvert1w
According to https://github.com/alecthomas/gometalinter/blob/0262fb20957a4c2d3bb7c834a6a125ae3884a2c6/linters.go#L373, it looks like `gometalinter` invokes `unconvert` without `-all` or any other fla…
shurcooL deleted branch in github.com/shurcooL/transcripts1w
patch-2
shurcooL deleted branch in github.com/shurcooL/transcripts1w
patch-3
shurcooL deleted branch in github.com/shurcooL/transcripts1w
patch-1
shurcooL commented on Call $get only when possible at ref… in github.com/gopherjs/gopherjs1w
Since the bug and the fix are in `reflect` package, can we make the test lower level and use `reflect` directly? Relying on `encoding/JSON` is not optimal, because its internal implementation details…
shurcooL commented on x/tools/cmd/stringer: add a -trimpr… in github.com/golang/go1w
> Whoops, I forgot to use golang/go#N when closing this issue. Are you using the latest version of [`git-codereview`](https://godoc.org/golang.org/x/review/git-codereview) binary? I'm pretty sure …
shurcooL commented on Reconsider 'expanded' naming scheme… in github.com/gopherjs/vecty1w
There is another option to consider. It may not be a good idea, but I'll toss it out for consideration anyway. There could be two `elem`-type packages (not sure about their location). One would offe…
shurcooL commented on Reconsider 'expanded' naming scheme… in github.com/gopherjs/vecty1w
There is another option to consider. It may not be a good idea, but I'll toss it out for consideration anyway. There could be two `elem`-type packages (not sure about their location). One would offe…
shurcooL commented on Call $get only when possible at ref… in github.com/gopherjs/gopherjs1w
In order for me to approve this, I'll have to gain understanding of the context of the problem, and the change, in order to have confidence that this is the optimal fix. It's going to take me some ti…
shurcooL commented on Use alecthomas/chroma for syntax hi… in github.com/shurcooL/github_flavored_markdown1w
I see, thanks for investigating that. The size increase is definitely substantial enough to say that it's not going to be possible to add `chroma` highlighting support unconditionally. In order to…
shurcooL commented on Reconsider 'expanded' naming scheme… in github.com/gopherjs/vecty1w
> Full list I see, that helps. I like the full names, but given it's very unlikely you'll be able to take on CSS and other places where the abbreviated names will come up, and fix them all ever…
shurcooL commented on Add OpenGL4.6 support. in github.com/go-gl/gl1w
Thanks for the PR and contributing. This will be blocked on https://github.com/go-gl/glow/issues/90, we can't merge this until we decide how to proceed there. We need to keep `gl` and `glow` in sy…
shurcooL commented on OpenGL 4.6 support in github.com/go-gl/gl1w
We need to decide to how to proceed in https://github.com/go-gl/glow/issues/90 to make progress on this issue.
shurcooL opened an issue in github.com/go-gl/glow1w
shurcooL pushed to master in github.com/go-gl/glow1w
2e48385387a721f8db8f82520b3cba4e043f2ac3Revert "Add OpenGL 4.6 support. (#89)"
shurcooL commented on Add OpenGL 4.6 support. in github.com/go-gl/glow1w
I'm going to revert what I merged for now, because the commit message is too misleading. That change updates to latest XML from our cvs source, but it doesn't add OpenGL 4.6 support. We should figure…
shurcooL commented on Add OpenGL 4.6 support. in github.com/go-gl/glow1w
Looks like I jumped too quickly with this. It seems the latest XML files from that cvs source do not yet contain definitions for OpenGL 4.6. That's why you used a difference source in https://github.…
shurcooL commented on Reconsider 'expanded' naming scheme… in github.com/gopherjs/vecty1w
I'm okay with both, as long as it's consistent. I find it pretty easy to get used to the long-form names. I might have to look up that it's `Anchor` the first time I use that element from vecty, b…
shurcooL pushed to master in github.com/go-gl/glow1w
38ff64296b6ecec737673c4a2175ca2c88e4625cAdd OpenGL 4.6 support. (#89)
shurcooL merged a pull request in github.com/go-gl/glow1w