Activity

Today
(3 comments) Yes, we should at least document it. I wanted to also include a code check to catch swapped input, but it wasn't as easy as it should be without an existing Go version parser handy …
Not restarting TryBots since they passed on Patch Set 1, and the only change in PS 2 is in the commit message.
Thanks for pointing that out. We can proceed with the backport CL, as only 1.17 needs the fix then.
The failure is unrelated. (In the unlikely case a real failure is masked, it'll be spotted by a post-submit run and release tests.)
This change is ready for review.
On wasm, the wasm_exec.js helper passes the command line arguments and environment variables via a reserved space in the wasm linear memory. Increase this reserved space from 4096 to 8192 bytes so mo…
On wasm, the wasm_exec.js helper passes the command line arguments and environment variables via a reserved space in the wasm linear memory. Increase this reserved space from 4096 to 8192 bytes so mo…
The backport policy requires both supported releases, Go 1.17 and 1.16 at this time, to be supported equally (see https://golang.org/issue/34536#issuecomment-572188389). So to proceed here we need to…
Yesterday
Does it happen reproducibly for you, or only occasionally? It didn't reproduce locally on macOS 11.6 darwin/amd64 @ commit 749f6e9eb6d101ef2ea4b7228a966391a80aa89b for me, at least not on the firs…
@rolandshoemaker Can you please prepare two backport CL (here, and for #48991) following https://golang.org/wiki/MinorReleases#making-cherry-pick-cls? Thanks.
> The easy fix is to regenerate the definitions on a supported release - however, this will obviously mean that it will stop working on 6.8 and earlier (which are no longer supported releases). Th…
Closed by merging 3a03ddf735f0e8eff3f8325a496f28b71d3dbe39 to release-branch.go1.17.
Closed by merging 1a6281d9501763b1457abe99f142f0efe435fe29 to release-branch.go1.16.
Unrelated failure, and chance of a real failure being masked is low enough to proceed (this builder will be run again on post-submit and during release tests). Was done.
Unrelated failure, and chance of a real failure being masked is low enough to proceed (this builder will be run again on post-submit and during release tests). Was done.
Closed by merging cfe182c67328f852d33ff00c9dc876765f19e546 to release-branch.go1.16.
Closed by merging 644555d34e5154215e4599610d861ec598bfbef2 to release-branch.go1.17.
What version of macOS are you using? macOS 12 has one known issue #49138. Is this happening with an older tip commit?
(1 comment) It seems this is where it fetches the playground example from. If modified to 'https://golang.org/doc/play/', as long as CORS is set up to allow such requests, this may be one wa…
If I understand correctly, this copies files that are served and available at https://golang.org/doc/play/ into go.dev, so they're also available at https://go.dev/doc/play/. This seems fine to …
(1 comment) I considered that, but I thought that if we wanted to modify how we use the Twitter API, we'd likely need to test it against the real Twitter API (e.g., using a staging set of creden…
(1 comment) Sorry but I'm not sure if I understand what the suggestion to "log the tweet at the end of the message" means specifically. It's true that the input to TweetRelease is f…
(1 comment) I expect this task can be improved to accept release archives as input when we're further along with completing more release automation tasks, and this use of the golang.org/dl/ API …
This is a subset of #49076 and will be resolved by [CL 356988](https://golang.org/cl/356988).
This is a subset of #49077 and will be resolved by [CL 357683](https://golang.org/cl/357683).
From reading #49122 I understand that this was a regression in 1.17, so 1.16 doesn't need this backport since it doesn't have the bug (please correct if that's not the case).
Friendly ping on this issue as it's currently marked as a release-blocker. Also CC @bufflig in case you're able to take a look.
[CL 344629](https://golang.org/cl/344629) updated the index for 1.17, so moving this to next milestone (with early-in-cycle) so this gets pinged when 1.18 is out.
Thanks for taking a look. I haven’t looked at the C FreeType code, so I don’t know which it uses offhand. I wouldn’t mind trying to look later on if it can help.
This Week
dmitshur starred in github.com/esimov/stackblur-go1d
(1 comment) It may seem odd that a generic "too long" message is printed instead of saying how many characters over the limit it is, or even checking that as a precondition. The reason for …
(1 comment) This is version "1.0.1", but it appears as a pseduo-version because "v" prefix was missed in the tag name. I filed https://github.com/esimov/stackblur-go/issues/4 about t…
Hello, thanks for offering this excellent Go package! There are two releases published at https://github.com/esimov/stackblur-go/releases, 1.0.1 and 1.0.0, but the tag for 1.0.1 is missing the "v"…
This allows exercising (and benefiting from improvements offered by) the programmatic tweet creation tasks as soon as the next minor release. The same task will be added and used by relui when possib…
Thanks for the quick fix! Minor suggestion from golang.org/wiki/CommitMessage: > • there is no trailing period [in the commit subject] s/For/Fixes/ Since it seems this is enough to fix and c…
dmitshur merged a change all: update vendored golang.org/x/tools2d
This test passes on tip but not 1.17/1.16—filed issue #49160. Is 'true ||' an accidental left-over from local development, not meant to be included in the final version of this CL?
As of [CL 358696](https://golang.org/cl/358696), `Test` passes on tip but fails with Go 1.17 and 1.16 (as detected on build.golang.org, see [log](https://build.golang.org/log/1ccc300775d5dcc1d1f71b92…
Opened #49159 for tracking purposes and sent CL 358620 (a simple fix that may be sufficient).
TRY=longtest
dmitshur opened a change all: update vendored golang.org/x/tools2d
Pull in CL 358034 (and some more changes with passing tests) with: go get -d golang.org/x/tools@f916b54 go mod tidy go mod vendor This teaches x/tools/cmd/bundle and the package loader it uses a…
> Perhaps the x/tools version required in src/cmd/go.mod needs to be updated to include [CL 358034](https://golang.org/cl/358034), That seems to do the trick. Will send a CL.
dmitshur opened an issue go/types: 2d
As of [CL 357049](https://golang.org/cl/357049), `moddeps.TestAllDependencies` fails in non-short mode (as detected on the linux-amd64-longtest builder, see [log](https://build.golang.org/log/3e2831d…
@gopherbot Please open backport tracking issues. This is a follow-up to the security fix included in Go 1.17.2 and 1.16.9 for issue #48797; without it some programs are unable to run.
Thanks for reporting this issue. I'm not sure whether it's possible/preferable for `Chain` to be improved so this internal limit is removed, or maybe just documenting it is the better fix. CC @mpv…
I'm not sure whether it's in scope of `x/perf/storage` package to support environments other than what's needed for Go's own needs at perfdata.golang.org. There isn't an [owner entry](https://dev.gol…
CC @0intro via [builder owners](https://farmer.golang.org/builders). There's a similarity to [CL 354752](https://golang.org/cl/354752). CC @bcmills. It looks like it's been fixed recently (than…
(1 comment) Minor and optional comment: this link works, but it might be better to link directly to https://go.dev/blog/survey2020-results to skip a redirect.
Minor suggestion. Maybe it's better to reverse the order so the latest version (1.17) is tested and listed first, and the oldest version 1.12 is at the bottom (since it's least important and soones…
Last Week
With this change, the computation of the scale factor becomes identical across the freetype and truetype packages, removing deviations in the font metrics that are derived from scale. The roundi…
dmitshur created branch in github.com/golang/freetype4d
scale-nearest
I noticed there's sometimes a tiny discrepancy in font metrics as computed by `freetype.Context` and `truetype.NewFace`. As a reproducible example, using the Go Mono font of size 86.4 exactly, at …
Thanks—this is a duplicate of #60.
Looks reasonable to me. One minor comment/question. Is "/usr/X11R6/include" considered a standard include directory on OpenBSD?
Updated the milestone to Go 1.18 since that's the version this proposal was implemented. This change is significant enough to warrant being mentioned in the [1.18 release notes](https://tip.golang…
dmitshur commented on syscall/js: remove Wrapper interface1w
RELNOTE=yes
This is a 32-bit architecture, so increasing machine RAM size beyond 4 GB is unlikely to help. Going with CL 357370 instead.
This is a 32-bit architecture, so increasing RAM of the machine to 16 GB probably won't help (thanks @cagedmantis for catching this). I think the right next step here is #49090.
OpenBSD 6.4 is not supported by now. Fixes golang/go#49090. Fixes golang/go#36563. Fixes golang/go#38413. Fixes golang/go#46080.
Indeed, OpenBSD 6.2 is not supported, closing.
At this time, OpenBSD 7.0 (released 6 days ago) and 6.9 are the supported releases of OpenBSD per their support policy of maintaining the last 2 releases. OpenBSD 6.4 stopped being supported on Octob…
Thank you for letting us know. We have discussed this on the team and agreed that this exception is okay to make for 1.18, especially since this is a part of overall generics work that is in scope of…
@bcmills Based on a recent test failure (e.g., https://build.golang.org/log/3d50d2e41477382548e0b84905d5dff6ea05f2f2) and the test code, to me it looks like the problem may be that the test code trie…
(1 comment) In case there are 2 or more PATH variables in env, only one of them (previously the first, now the last) will be removed. If the goal of this fix is to allow setPathEnv to operate corre…
RELNOTE=yes
This line looks off: ``` } `graphql:"node(id: $repoId")` ``` Perhaps it should be: ``` } `graphql:"node(id: $repoId)"` ```
Earlier
dmitshur starred in github.com/gotify/server/v21w
Both command line arguments and environment variables are currently passed to WebAssembly by writing them to linear memory, and [CL 354571](https://golang.org/cl/354571) added a fixed limit of 4096 b…