Activity
Yesterday
dmitshur commented on golang.org/x/tour: offline version of 'A Tour of Go' broken with modules10h
> It's possible to fix this either by adjusting the code to look for tour files in module cache, or by embedding them in the binary. I chose with the latter and sent [CL 291849](https://golang.org/cl…dmitshur closed an issue golang.org/x/build: M1 builders are offline15h
dmitshur commented on golang.org/x/build: M1 builders are offline15h
The builders are back, so closing.dmitshur reviewed +2 on github.com/go-gl/glfw: Add scripts/grab-upstream.sh16h
That sounds reasonable to me, I think this is good to merge as long as it's working, and we can optionally improve it in the future.dmitshur closed an issue cmd/go: mkdir C:\Program Files\Go: Access is denied.18h
dmitshur commented on cmd/go: mkdir C:\Program Files\Go: Access is denied.18h
You can find instructions to uninstall a previous version at https://golang.org/doc/manage-install#uninstalling, and instructions to install a new version at https://golang.org/doc/install.
See http…dmitshur commented on cmd/go: mkdir C:\Program Files\Go: Access is denied.19h
The `go env` output includes:
```
set GOPATH=C:\Go\bin
```
That probably needs to be changed.dmitshur commented on cmd/go: mkdir C:\Program Files\Go: Access is denied.19h
I think a good next step here would be to determine if Go is installed properly and it's able to build programs. For example, does the `go run .` command in step 4 of https://golang.org/doc/tutorial/…dmitshur commented on golang.org/x/build: dragonfly builders acting up19h
Looking at it now, I see both builders are in use:
```
host-dragonfly-amd64-5_8: 1/1
host-dragonfly-amd64-master: 1/1
```
```
dragonfly-amd64 rev 3e524ee6 (sub-repo review rev 2465c8e7); ru…dmitshur opened an issue golang.org/x/build: M1 builders are offline19h
From https://farmer.golang.org:
```
host-darwin-arm64-11_0-toothrot: 0/0 (2 missing)
```
CC @toothrot.dmitshur commented on cmd/go: -mod flag doesn't work with module-mode go get19h
CC @bcmills, @jayconrod, @matloob.dmitshur commented on golang.org/x/build: misc-compile TryBots are too slow20h
I observed a case where `misc-compile-openbsd` was the slowest run:
<img src="https://user-images.githubusercontent.com/1924134/109840518-34afe700-7c16-11eb-8605-cb96423dd1f1.png" width=305px>
…dmitshur commented on golang.org/x/build/cmd/coordinator: understand why TryBot runs sometimes fail to complete after reaching 0 builds remaining20h
I think I understand this now.
TryBot completion happens as part of a loop inside `findTryWork`. This is why TryBots take at least a few seconds after reaching 0 builds left, and why when `findTry…This Week
dmitshur commented on golang.org/x/build/cmd/coordinator: understand why TryBot runs sometimes fail to complete after reaching 0 builds remaining1d
Observed this again now. There were 6 trybot runs at https://farmer.golang.org/#trybots just now, and they were stuck at "Builds remaining: 0" for at least 5-10 minutes. Afterwards, most of them comp…dmitshur commented on net/http: TestCancelRequestWhenSharingConnection failures on longtest builders1d
@networkimprov Yes, see https://github.com/golang/go/issues/42935#issuecomment-789056758.dmitshur commented on golang.org/x/playground: web app runtime error with file/dir name conflicts in the txtar1d
CC @golang/release.dmitshur commented on doc: darwin install instructions need PATH modification for < 1.141d
> That's not happening with the 1.14 installer.
It should be, so if it isn't, that's unexpected. Can you check if the file `/etc/paths.d/go` exists after running the installer? It should contain "…dmitshur commented on net/http: Transport race condition by Content-Length == 0 response [1.15 backport]1d
I've mailed [CL 297909](https://golang.org/cl/297909) and [CL 297910](https://golang.org/cl/297910) that will resolve this issue.dmitshur opened an issue golang.org/x/build/devapp: automate burndown chart to track current major Go release2d
The dev.golang.org/release page shows an issue burndown chart, tracking the current major Go release milestone. This chart needs to be updated to target Go 1.(N+1) milestone every 6 months (see previ…dmitshur commented on cmd/link: fail to build when using time/tzdata on ARM2d
@cherrymui Does this issue also exist in Go 1.15, or only 1.16?dmitshur commented on cmd/go: warning message when getting a retracted module version is missing a trailing newline [1.16 backport]2d
Approved. This is improving the readability of user-facing documentation for a newly added feature, and the fix is very safe. Only Go 1.16 needs this backport.dmitshur opened an issue cmd/go: go list reports net as "stale" right after ./make.bash (but only inside GOROOT/src)2d
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.16 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What opera…dmitshur commented on cmd/link: runtime crash, unexpected fault address 0xffffffffffffffff, h2_bundle.go, when using plugin [1.16 backport]2d
Approved. Only Go 1.16 needs this backport.dmitshur commented on runtime: marked free object in span [1.15 backport]2d
Approving as a serious issue without a workaround. This backport applies to both 1.16 (#44659) and 1.15 (this issue).dmitshur commented on runtime: marked free object in span [1.16 backport]2d
Approving as a serious issue without a workaround. This backport applies to both 1.16 (this issue) and 1.15 (#44658).dmitshur commented on time: LoadLocationFromTZData with slim tzdata uses incorrect zone [1.15 backport]2d
Approving as a serious issue without a workaround. This backport applies to both 1.16 (#44618) and 1.15 (this issue).dmitshur commented on time: LoadLocationFromTZData with slim tzdata uses incorrect zone [1.16 backport]2d
Approving as a serious issue without a workaround. This backport applies to both 1.16 (this issue) and 1.15 (#44617).dmitshur commented on golang.org/x/build/cmd/gopherbot: may exceed GitHub API rate limit2d
This is happening today too, affecting the "close cherry pick issues" task.
```
2021/03/01 20:54:36 close cherry pick issues: GET https://api.github.com/repos/golang/go/issues/44464/comments?per_…dmitshur commented on cmd/go: "malformed import path" in Go 1.16 for packages with path elements containing a leading dot [1.16 backport]2d
Approving as a serious issue without a workaround. Only Go 1.16 needs this backport.dmitshur commented on cmd/go: 'go mod edit -exclude' erroneously rejects '+incompatible' versions [1.16 backport]2d
There's an unresolved comment in CL 295930 that needs to resolved, then it can be submitted.dmitshur commented on golang.org/x/playground: cgo: exec gcc: exec: "gcc": executable file not found in $PATH2d
We've recently changed PATH as part of fixing for Go 1.16, maybe this is relevant.
CC @toothroot.dmitshur pushed to
master in github.com/shurcooL/github_flavored_markdown3d
dmitshur commented on github.com/shurcooL/github_flavored_markdown: Doesn't build in projects that use `dep` Go dependency management tool due to issue with blackfriday v2.0.0 tag.3d
Dep is [deprecated](https://github.com/golang/go/issues/38158) by now, so there's nothing more to do here.Last Week
dmitshur commented on vendor: update golang.org/x/* dependencies5d
(1 comment)
Issue #36905 is relevant.dmitshur commented on golang.org/x/build/cmd/gitmirror: 10 minute timeout on git fetch is incorrectly implemented, so git fetch may still block forever6d
February, 2021 edition:
2 months 17 days since last. Fixed with `kubectl delete po…dmitshur opened an issue golang.org/x/build/cmd/tip: fails to serve website at CL 293412 or newer6d
https://farmer.golang.org/#health reports a problem with the [tip.golang.org](https://tip.golang.org) website.
[CL 293412](https://golang.org) removed the -index and -index_interval flags. `cmd/ti…dmitshur closed an issue golang.org/x/build/dashboard: remove darwin-386-10_14 builder when Go 1.14 stops being supported1w
dmitshur commented on golang.org/x/build/dashboard: remove darwin-386-10_14 builder when Go 1.14 stops being supported1w
Resolved in [CL 293771](https://golang.org/cl/293771).dmitshur commented on golang.org/x/build: use new name for release branches in golang.org/x repos starting with Go 1.161w
We've updated our release process to start creating branches that follow the new internal naming scheme, and it has been used with the Go 1.16 release.
We've also updated permissions in [CL 283262…dmitshur closed an issue golang.org/x/build: use new name for release branches in golang.org/x repos starting with Go 1.161w
dmitshur starred in github.com/evanw/esbuild1w
dmitshur commented on golang.org/x/build: misc-compile TryBots are too slow1w
I too have observed this:
<img src="https://user-images.githubusercontent.com/1924134/108784909-5f2ae180-753e-11eb-88e6-f93311e9c182.png" width=303px>
When these trybots take the longest, they …dmitshur closed an issue all: reopen tree for Go 1.17 development1w
dmitshur commented on all: reopen tree for Go 1.17 development1w
The "Current Tree Status" was updated from "Open for bug fixes only" to "Open for Go 1.17 development". I've sent an announcement to [golang-dev](https://groups.google.com/g/golang-dev/c/VNJFUxHWLHo/…dmitshur opened an issue doc: write Go 1.17 release notes1w
Tracking bug for writing the Go 1.17 Release Notes.
The latest state on tip can be viewed at https://tip.golang.org/doc/go1.17 (the page doesn't exist yet, so it's currently 404; that'll be fixed …dmitshur commented on cmd/internal/moddeps: confusing error message when difference is due to a "replace" directive1w
Can this be fixed by changing `t.Errorf("cannot check consistency for filesystem-local replacement in module ...` into `t.Fatalf`? It seems the rest of the test doesn't produce a helpful output if th…dmitshur closed an issue golang.org/x/website: show search box on smaller viewports1w
dmitshur commented on golang.org/x/website: show search box on smaller viewports1w
Indeed, this isn't relevant by now, closing.dmitshur closed an issue golang.org/x/website: remove search box from golang.org1w
dmitshur commented on golang.org/x/website: remove search box from golang.org1w
Fixed by [CL 292590](https://golang.org/cl/292590), closing. (It didn't get closed automatically because the "golang/go" prefix wasn't included.)
@magical The commit message suggests that the migr…Earlier
dmitshur starred in github.com/aarzilli/gdlv1w
dmitshur opened an issue golang.org/x/build/cmd/gerritbot: possible panic in getFullPR1w
Observed this panic from 43 days ago:
```
2021/02/04 06:15:49 Retrieving PR golang/blog#34 from GitHub using Etag "W/\"8a7ebf3c8163c89f842d22ec8a135ec89f9af0061f034bbd6a13ad716abff05b\"" ...
pan…dmitshur commented on golang.org/x/build/cmd/gopherbot: may exceed GitHub API rate limit1w
Based on https://github.com/golang/crypto/pull/143#issuecomment-782377386, this issue might be affecting more services than just GopherBot.dmitshur commented on golang.org/x/crypto/autocert: Include the domain in the SAN of the CSR1w
It should work now. But, from GerritBot logs:
```
2021/02/19 21:40:32 GitHub: 0/5000 calls remaining; Reset in 7m52.975721092s
```
It likely shares rate limit with GopherBot, so issue #44406 …dmitshur commented on golang.org/x/crypto/autocert: Include the domain in the SAN of the CSR1w
@FiloSottile [GerritBot](http://golang.org/wiki/GerritBot) waits for @googlebot to add a "cla: yes" label before starting work. For some reason that hasn't happened here yet.dmitshur commented on golang.org/x/build: Add FreeBSD 11.4 and 12.2 builders1w
CC @golang/release.dmitshur commented on golang.org/x/playground: 1.16 not available1w
Thanks for reporting.
CC @golang/release.dmitshur commented on golang.org/x/build: freebsd-amd64-race builder should be updated to use a newer FreeBSD version1w
For now I'll resolve this specific issue by updating freebsd-amd64-race to use the available FreeBSD version, 12.0.
Please file a separate issue about adding new builders that target newer version…dmitshur closed an issue golang.org/x/build: freebsd-amd64-10_3 trybot took over 20 minutes1w
dmitshur commented on golang.org/x/build: freebsd-amd64-10_3 trybot took over 20 minutes1w
The `freebsd-amd64-10_3` builder is long gone (removed in [CL 246639](https://golang.org/cl/246639)), so this specific issue can be closed. (The general tracking issue for TryBot speed is #17104.)dmitshur commented on golang.org/x/website: webside 404 issue1w
Thanks, we'll deploy today. @toothrot is already on it, please close this issue when done.dmitshur commented on golang.org/x/website: #go-install anchor in mod reference doesn't exist but is used in a few places1w
Yes, I'm doing a deploy now (also for #44414).dmitshur commented on : GO 1.16 Program do not compile on raspberry pi1w
Thank you for the feedback. I've filed #44426 about improving the Linux installation instructions.dmitshur commented on golang.org/x/website: highlight removal of previous Go install in Linux installation instructions1w
Given how important the step of removing the previous /usr/local/go directory before extracting, I think we must include it in the numbered steps.
The current instructions link to https://golang.o…dmitshur opened an issue golang.org/x/website: highlight removal of previous Go install in Linux installation instructions1w
Experience and feedback in #44320 (thank you @jpmieville, @davecheney, @agnivade) suggests that the current Linux installation instructions are prone to a user mistake: missing the step of removing t…dmitshur commented on all: reopen tree for Go 1.17 development1w
@thanm Yes, as Russ said that CL is a follow up to the dev.regabi merge and is okay. Thanks.dmitshur opened an issue golang.org/x/build/cmd/gopherbot: GopherBot may exceed rate limit1w
While investigating x, I noticed in GopherBot's logs that it was failing to take some actions due to exceeding GitHub API rate limit quota:
```
$ kubectl logs -f gopherbot-deployment-6c6d86d5b9-s…dmitshur commented on golang.org/x/build/cmd/gopherbot: mark Gerrit comments as CI-generated1w
This may have been resolved by placing the Go Bot account (and Gerrit Bot) in a "Service Users" group for Gerrit's Attention Set feature (documented [here](https://gerrit-review.googlesource.com/Docu…dmitshur opened an issue golang.org/x/build/cmd/releasebot: should also create the next minor release milestone1w
I noticed that GopherBot hadn't closed #44346 even though [CL 293411](https://golang.org/cl/293411) was submitted. I figured out the problem by looking at its logs and seeing:
```
2021/02/19 00:2…dmitshur commented on doc: Broken image in readme1w
@gopherbot Please backport this to Go 1.16. It is a safe documentation fix needed to restore the gopher image at https://pkg.go.dev/std#section-readme (and any other place that displays the README of…dmitshur commented on access: add zpavlinovic to go-assignees and go-approvers1w
CC @golang/release.dmitshur commented on golang.org/x/tools/internal/imports: update stdlib index after every major Go release1w
@heschik Yep, that makes sense. The reason I've used this early-in-cycle path for now is the same reason I closed https://github.com/golang/go/issues/27155#issuecomment-779940755: we currently don't …dmitshur commented on golang.org/x/tools/internal/imports: automatically update stdlib index every major release1w
As a first step, let's make this a recurring early-in-cycle release-blocking issue, similar to #40705 and #36905, so that this task isn't missed.
I'll place it in Go 1.17 milestone now, and when […dmitshur commented on cmd/link: -buildmode=c-shared exports many functions, not just //export functions [1.15 backport]1w
We've discussed this in a release meeting and it didn't seem like this is needed for #43592. CC @ianlancetaylor, @jeremyfaller.
@networkimprov If you still think that [CL 262797](https://golang.or…dmitshur commented on cmd/link: "x86_64-w64-mingw32/bin/ld.exe: Error: export ordinal too large" after upgrading to Go 1.15 [1.15 backport]1w
Approving per discussion in a release meeting as a serious issue without a good workaround (setting -buildmode=exe is a workaround, but this doesn't scale across developers). Only Go 1.15 needs this …dmitshur closed an issue database/sql: deadlock on transaction stmt context cancel [1.14 backport]1w
dmitshur commented on database/sql: deadlock on transaction stmt context cancel [1.14 backport]1w
Closing because Go 1.16 is out, and there will not be a Go 1.14.16 minor release per [release policy](https://golang.org/doc/devel/release.html#policy).dmitshur closed an issue cmd/compile: miscompilation of some arithmetic and conditionals on arm [1.14 backport]1w
dmitshur commented on cmd/compile: miscompilation of some arithmetic and conditionals on arm [1.14 backport]1w
Closing because Go 1.16 is out, and there will not be a Go 1.14.16 minor release per [release policy](https://golang.org/doc/devel/release.html#policy).dmitshur commented on net/http: Transport race condition by Content-Length == 0 response [1.14 backport]1w
Closing because Go 1.16 is out, and there will not be a Go 1.14.16 minor release per [release policy](https://golang.org/doc/devel/release.html#policy).dmitshur closed an issue net/http: Transport race condition by Content-Length == 0 response [1.14 backport]1w
dmitshur commented on net/http: ServeContent()/ServeFile() doesn't return expected response when WriteTimeout happens [1.14 backport]1w
Closing because Go 1.16 is out, and there will not be a Go 1.14.16 minor release per [release policy](https://golang.org/doc/devel/release.html#policy).dmitshur commented on golang.org/x/website: various mistakes in documentation on modules2w
Thank you for reporting this and sending a CL.
CC @stevetraut.dmitshur commented on golang.org/dl: provide a command to set up $PATH with each Go version2w
@AlexRouSg The existing subcommands of `goX.Y.Z` already do that, see [CL 143545](https://golang.org/cl/143545). They don't need any changes made. This proposal is about adding a new subcommand to be…dmitshur commented on golang.org/x/build: reopen tree for Go 1.17 development2w
Merging dev.regabi into master (issue #44224) was resolved (thank you @cherrymui). The next item currently in the list is:
- dev.typeparam branch will be merged to master assuming the [proposal](h…dmitshur closed an issue cmd/compile: crash in type loop detection2w
dmitshur commented on cmd/compile: crash in type loop detection2w
Thanks, I can confirm the ICE no longer reproduces on tip.
Closing, fixed by [CL 292709](https://golang.org/cl/292709).dmitshur commented on github.com/Homebrew/homebrew-core: go 1.162w
> > If godoc really is needed maybe the other "official" way of installing it could be an option? I'm thinking of go get -u golang.org/x/tools/... or even go get -u golang.org/x/tools/godoc.
>
> If…dmitshur commented on : GO 1.16 Program do not compile on raspberry pi2w
We can try, but we'll need to narrow down where the source of the problem was.
@jpmieville Which installation instructions did you follow when you ran into this issue? Was it https://golang.org/doc/…dmitshur commented on golang.org/x/website: golang.org/doc/articles/wiki is broken2w
I'm not sure what's the best thing to do here. If we continue to use `//go:embed`, we can't place any files named "go.mod" in _content. Maybe we shouldn't do that regardless.
I've drafted [CL 2928…dmitshur commented on golang.org/x/website: golang.org/doc/articles/wiki is broken2w
The problem is because the wiki directory in x/website contains a file named "go.mod":
https://github.com/golang/website/blob/master/_content/doc/articles/wiki/go.mod
Despite being inside a _co…dmitshur commented on github.com/shurcooL/graphql: [Feature reqeust] Add possiblity to load query from string / .gql file2w
Yes, a GraphQL query → Go type tool (with a UI similar to https://mholt.github.io/json-to-go/; CC @mholt) is very possible and likely a good idea, as it'd help eliminate the manual work involved. I…dmitshur commented on all: merge dev.regabi to master when tree reopens2w
This issue is ready to proceed, see https://github.com/golang/go/issues/44222#issuecomment-780122220. After this is done, please update that umbrella issue and let the next people in the list know. T…dmitshur commented on golang.org/x/build: reopen tree for Go 1.17 development2w
The "Current Tree Status" was just changed from "Frozen for Go 1.16 changes only" to "Accepting early Go 1.17 changes only (see list below)". I've sent a [message](https://groups.google.com/g/golang-…dmitshur commented on golang.org/x/build: reopen tree for Go 1.17 development2w
It's planned by @golang/release for this issue to begin progressing after the Go 1.16 release is issued.dmitshur closed an issue all: write release blog post2w
dmitshur commented on all: write release blog post2w
@pearring and I have a Go 1.16 blog post draft ready and will be publishing it as part of the Go 1.16 release.
Because this issue is marked as a release-blocker, @golang/release ends up seeing it …dmitshur commented on golang.org/x/website: merge module doc changes as part of Go 1.16 release2w
I left a [comment](https://go-review.googlesource.com/c/website/+/284812/2#message-e25b50802019ecb160605484bd532c2efa186dea) on CL 284812, the first unmerged CL in that stack, noting that it's safe t…