Activity

Today
The build dashboard is merging into the coordinator codebase in #34744, so maybe we should unify the header. It would help navigation between the build dashboard and the farmer status page, especiall…
This Week
This nested module hasn't been updated in a while. Update go version, dependencies to pull in latest fixes and make future updates smaller.
(1 comment) Using -d (and no -u) makes sense to me. Thanks!
@ianlancetaylor Should the follow up change [CL 337309](https://golang.org/cl/337309) also be cherry-picked to 1.16?
The newly selected versions look good to me, just wanted to ask a question. I'm wondering, have you also considered leaving out -u and instead only updating to @latest versions of golang.org/x d…
Ack. Those packages don't make use of any features that are not available in Go 1.15, so I don't have a need to make changes to them at this time.
dmitshur deleted branch in github.com/go-gl/glfw3d
update-3.3.4
dmitshur pushed to master in github.com/go-gl/glfw3d
0db043d8d5be8de18ce39aa7407778d752544b7cv3.3/glfw: update to GLFW 3.3.4
During the minor release process, towards the end, an announcement tweet is posted. For example, https://twitter.com/golang/status/1414721238224838666. (The tweet text and image are generated via a t…
I don't see anything wrong in the snippets you posted. I tried putting them together into a complete program, and can't reproduce the problem with it. It seems to work fine: <details><br> ``…
(We should also update https://github.com/go-gl/glfw/wiki/Development#updating-glfw-c-source for the new grab-upstream process.)
GLFW 3.3.4 was released on April 8, 2021. See https://github.com/glfw/glfw/releases/tag/3.3.4. Done with scripts/grab-upstream.sh (albeit with edits): echo 'b3e0aae393ef6c5cda7dcad0cba06bef23…
dmitshur created branch in github.com/go-gl/glfw4d
update-3.3.4
(2 comments) Please note that https://golang.org/doc/contribute#commit_messages suggests: &gt; Write in complete sentences with correct punctuation, just like for your comments in Go. Don&#39;t use…
dmitshur pushed to master in github.com/shurcooL/frontend4d
4ab50a35b5e50c53bc35d4f06e1d2992d04f4c06reactionsmenu: handle PointerEvent type in "click" handler
dmitshur deleted branch in github.com/dominikh/go-js-dom4d
rebase-pointerevent
dmitshur pushed to master in github.com/dominikh/go-js-dom4d
f030747120f2bf279a88308f7e808d790b4fcfb5rebase PointerEvent on top of MouseEvent
dmitshur pushed to master in github.com/shurcooL/githubv44d
83ba7b4c9228d93b438cd13cb01655d5b239934aregenerate for schema changes by 2021-07-25
Thanks. The breaking changes should be fine, this package follows the GitHub API and inherits its breaking changes. I'll deal with adding a go.mod file separately later.
This is motivated by Chrome changing "click" events to send PointerEvent rather than MouseEvent, as described at https://groups.google.com/a/chromium.org/g/blink-dev/c/bta50W_Hg24/m/YAYeAzCZAAAJ.
According to documentation on MDN¹, the PointerEvent interface inherits properties from MouseEvent, which in turn inherits from UIEvent, and that inherits from Event. Embed MouseEvent in Pointe…
dmitshur created branch in github.com/dominikh/go-js-dom4d
rebase-pointerevent
Last Week
Closing as duplicate of https://github.com/go-gl/glfw/issues/319. Also please be aware that it's possible to clear the build cache with `go clean -cache`, as documented at https://pkg.go.dev/cmd/g…
As a first step, try v3.3, since v3.2 is an old version of GLFW and not really supported. If it still doesn't work, that likely means support for Raspberry Pi has not been added.
dmitshur commented on golang.org/x/text: add a comment5d
(1 comment) Per https://golang.org/doc/contribute.html#design, please open an issue on the issue tracker and describe the problem there first. We can get to reviewing this PR after the issue gets in…
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.17rc1 darwin/arm64 </pre> (It also reproduces with latest master commit, 0914646ab91a3157666d845d74d8d9…
dmitshur pushed to master in dmitri.shuralyov.com/website/gido5d
f460621dc784d8a8f3a1593a068115b62baf214dadd support for multiple comma-separated import path patterns
be77a538f6a64b287e073b59d1b9f7e1314cf3a9upgrade to go-git v5
b5ce3c19e6b977800ee3c80bc722192f96ef657breplace mention of godoc.org with pkg.go.dev
Thanks for the report. The `dl` package implements `fileOrder` sorting, and `versionLess` is used to compare two versions. When both are pre-release versions with same major, minor components, the…
dmitshur reviewed +2 on .github: update IRC server6d
Thank you for catching and updating this file.
dmitshur reviewed +2 on doc/1.17: fix two dead rfc links6d
(1 comment) As far as I can tell, the original links do work if the schema is changed to HTTPS (they give 404 if HTTP is used). They redirect to datatracker.ietf.org as implemented in this CL, but a…
Thanks for the CL. It&#39;s a little hard to tell how this is related to the upstream issue. Is this still relevant, or it it safe to drop?
Done with: cp -r ./app/appengine ./cmd/coordinator/internal/legacydash DO NOT SUBMIT: This CL exists temporarily to make diff of next CL easier to review. Before submission, it&#39;ll be squashed …
Add a copy of x/build/app/appengine while making minimal modifications to make it a package that coordinator can import instead of a command. It&#39;ll be integrated into cmd/coordinator in the next…
Serve a copy of the build dashboard (including its remaining HTTP API endpoints) at build.golang.org directly from coordinator. This makes it so that both the dashboard and the coordinator are a sing…
dmitshur opened a change golang.org/x/build/app/appengine: delete1w
The appengine command is no longer needed since the coordinator is serving the build dashboard. The key package is now unused. For golang/go#34744. DO NOT SUBMIT: Wait until the coordinator starts…
I've been able to pick this up and make good progress this week. My focus is on getting this to a point where the build dashboard is served by cmd/coordinator, so that it's a single deploy rather tha…
This refactor looks great, thank you. I left inline comments, many of them are minor and optional. Why is this being removed in this CL? (From reading the commit message, I&#39;m not sure if it&#39;…
(1 comment) It’s likely this should be Fprintln instead.
dmitshur opened an issue all: reopen tree for Go 1.18 development1w
### Current Tree Status: Frozen for Go 1.17 changes only 🥶 (working towards Go 1.17 RC 2) This is a tracking issue for the [upcoming task](https://golang.org/s/release#timeline) of reopening th…
Sure, let's use it as a tracking issue then.
Thanks for suggesting this. Unfortunately, I don't think we're on a plan that supports this feature. If that changes we should consider this.
As visible on the [build dashboard](https://build.golang.org/?repo=golang.org%2fx%2fwebsite), `TestGolden` is failing starting with [CL 335669](https://golang.org/cl/335669): ``` --- FAIL: TestGo…
Earlier
By default, a modern version of Go should install the `tour` binary in module mode and use the module mirror (https://proxy.golang.org) to download the module zip, so `git` shouldn't be required. …
@jfesler Thanks for that information. Indeed, looking for content in the module cache can only work on a machine where Go is installed. Go 1.17 will come out pretty [soon](https://groups.google.co…
Is this marked as a 1.18 release blocker because it's okay to fix this after 1.17 is released? I can't reproduce with `git version 2.30.1 (Apple Git-130)` either.
I understand why this is happening and can confirm both the go command and module mirror are working as expected. Specifically, https://golang.org/ref/mod#resolve-pkg-mod specifies that: > If one or…
Hmm, this doesn't seem to happen in GOPROXY=direct mode, so maybe the module mirror is playing a role. I'll check again later.
A reasonable way to install the latest version of the `tour` binary from its latest location is by using `go install`: ``` go install golang.org/x/website/tour@latest ``` However, doing so cu…
Added early-in-cycle so this issue gets a reminder when the tree reopens. If we're going to do this, doing it earlier gives the greatest opportunity to find out what needs updating (outside of the Go…
@tuxillo Friendly ping. [CL 332129](https://golang.org/cl/332129) just had 3 minor commit message comments and can be submitted. Are you still planning to create a tracking issue for the 6_0 build…
dmitshur commented on : x/website:2w
Thanks for reporting. I suspect this might be a duplicate of #46416.
Is the comma-okay not needed? Won't the type conversion panic when `acceptError` returns a nil error?
Thinking about this more (sorry I missed it earlier), this workaround should probably not return `invalidValue` from `Init`, but rather handle it internally. That is, most callers of `glfw.Init` l…
LGTM. There's a typo in the commit message/PR subject, s/GLFW_INVLAID_VALUE /GLFW_INVALID_VALUE/.
Given it is a serious issue, I think "backporting" the GLFW (C library) fix for it in go-glfw would be reasonable to do. It looks like a small patch that just removes those lines that send `GLFW_INVA…
Possibly related issue #36238. Also CC @stamblerre.
dmitshur closed an issue all: Go 1.15.14 release status2w
dmitshur closed an issue all: Go 1.16.6 release status2w
dmitshur commented on all: Go 1.16.6 release status2w
Done!
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: drwxr-xr-x gocache/b6/ 2021/07/12 15:53:31 remote: -rw-r--r-- gocache/b6/b6046dcbfff97545125b0862039c0814e2a2026c30db502865006bc47f4dcecf-a 175 2021-07-12T19:53:13…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- gocache/50/50ad3b0cd460fae7b7d9cab48e1697a6ca0c3b2ce3b96770c64f6765b69e2134-a 175 2021-07-12T19:53:10Z 2021/07/12 15:53:31 remote: drwxr-xr-x gocache/51…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- go/test/recover5.go 408 2021-07-12T19:51:28Z 2021/07/12 15:53:31 remote: -rw-r--r-- go/test/reflectmethod1.go 578 2021-07-12T19:51:28Z 2021/07/12 15…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- go/test/fixedbugs/issue33158.dir/a.go 478 2021-07-12T19:51:28Z 2021/07/12 15:53:31 remote: -rw-r--r-- go/test/fixedbugs/issue33158.dir/b.go 217 2021-07-…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- go/test/fixedbugs/issue14646.go 484 2021-07-12T19:51:28Z 2021/07/12 15:53:31 remote: -rw-r--r-- go/test/fixedbugs/issue14651.go 1961 2021-07-12T19:51:28…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- go/test/fixedbugs/bug097.go 1157 2021-07-12T19:51:28Z 2021/07/12 15:53:31 remote: -rw-r--r-- go/test/fixedbugs/bug098.go 582 2021-07-12T19:51:28Z 20…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- go/src/syscall/ztypes_netbsd_amd64.go 6314 2021-07-12T19:51:28Z 2021/07/12 15:53:31 remote: -rw-r--r-- go/src/syscall/ztypes_netbsd_arm.go 6273 2021-07-…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- go/src/runtime/signal_dragonfly_amd64.go 2063 2021-07-12T19:51:28Z 2021/07/12 15:53:31 remote: -rw-r--r-- go/src/runtime/signal_freebsd.go 2255 2021-07-…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:31 remote: -rw-r--r-- go/src/runtime/asm_386.s 41088 2021-07-12T19:51:28Z 2021/07/12 15:53:31 remote: -rw-r--r-- go/src/runtime/asm_amd64.s 49523 2021-07-12T19:51:28Z 202…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/src/math/nextafter.go 1233 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: -rw-r--r-- go/src/math/pow.go 3231 2021-07-12T19:51:28Z 2021/07/12 15…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/src/image/jpeg/writer.go 17566 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: -rw-r--r-- go/src/image/jpeg/writer_test.go 7391 2021-07-12T19:51:28Z…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/src/debug/pe/testdata/vmlinuz-4.15.0-47-generic 474 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: drwxr-xr-x go/src/debug/plan9obj/ 2021/07/12…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/src/compress/flate/testdata/huffman-pi.dyn.expect 1696 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: -rw-r--r-- go/src/compress/flate/testdata/huf…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: drwxr-xr-x go/src/cmd/vendor/golang.org/x/sys/internal/unsafeheader/ 2021/07/12 15:53:30 remote: -rw-r--r-- go/src/cmd/vendor/golang.org/x/sys/internal/unsafeheade…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/src/cmd/internal/obj/plist.go 9197 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: drwxr-xr-x go/src/cmd/internal/obj/ppc64/ 2021/07/12 15:53:30…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/src/cmd/go/testdata/script/build_test_only.txt 463 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: -rw-r--r-- go/src/cmd/go/testdata/script/build_tr…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/src/cmd/compile/internal/ssa/writebarrier.go 18074 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: -rw-r--r-- go/src/cmd/compile/internal/ssa/writeb…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: drwxr-xr-x go/pkg/darwin_amd64_race/vendor/golang.org/x/text/unicode/ 2021/07/12 15:53:30 remote: -rw-r--r-- go/pkg/darwin_amd64_race/vendor/golang.org/x/text/unic…
dmitshur commented on all: Go 1.15.14 release status2w
2021/07/12 15:53:30 remote: -rw-r--r-- go/misc/cgo/testshared/testdata/depBase/gccgo.go 221 2021-07-12T19:51:28Z 2021/07/12 15:53:30 remote: -rw-r--r-- go/misc/cgo/testshared/testdata/depBase…
dmitshur commented on all: Go 1.15.14 release status2w
## Latest build: go1\.15\.14 - src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.15.14/go1.15.14.src.tar.gz)) - linux\-386 ([tar\.gz](https://golang-release-staging.storage.g…
dmitshur commented on all: Go 1.16.6 release status2w
## Latest build: go1\.16\.6 - src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.16.6/go1.16.6.src.tar.gz)) - linux\-386 ([tar\.gz](https://golang-release-staging.storage.goog…
dmitshur commented on all: Go 1.16.6 release status2w
## Latest build: go1\.16\.6 - src - not started - linux\-386 - not started - linux\-armv6l - not started - linux\-amd64 - not started - linux\-arm64 - not started - freebsd\-386 - not started - fre…