Activity
Yesterday
dmitshur commented on github.com/shurcooL/graphql: Mutation and Query structs are parsed unreliably/depend on how they are declared6h
The documentation for `Query` currently includes:
> q should be a pointer to struct that corresponds to the GraphQL schema.
To make the snippet you've shown work as is, that would need to chang…dmitshur commented on golang.org/x/build: add LUCI linux-riscv64 builder10h
@mengzhuo If your builder continues to be in "Quarantined—Had 2 consecutive BOT_DIED tasks" state for a prolonged amount of time (I see that status [here](https://chromium-swarm.appspot.com/bot?id=…dmitshur closed an issue host-windows-amd64-2016-oldcc (VM Image: windows-amd64-server-2016-v7)11h
*-oldcc hosts were for Go 1.19 and older. This isn't needed anymore.dmitshur reviewed +2 on golang.org/x/build/main.star: run longtest builders in presubmit if vendor is modified11h
Thanks.
Checking my understanding: is this intentionally being removed because of "For builders with `experiment_percentage` or `location_filters`, don't specify `includable_only`." from https://chr…dmitshur reviewed +2 on doc/go_spec.html: rename golang.org to go.dev14h
Thanks.
(nit) This can be shortened to "Fixes #64513." if you want since this is CL is for the main repo.
If you want, consider backporting the same change to this 1.17 copy while it exists.
We pr…dmitshur closed a change golang.org/x/build/internal/relui: wait more before starting Google Docker build15h
This hypothesis turned out not to be the one: waiting on 'uploaded' should be fine, and the problem seems to be elsewheredmitshur commented on golang.org/x/build/internal/relui: wait more before starting Google Docker build15h
> ...oops.
Hmm, no, the go.dev/dl/ endpoint redirects without checking (https://cs.opensource.google/go/x/website/+/master:internal/dl/server.go;l=257-265;drc=2ad1d0f28107903728b0f3d281515e94dd7fa1d…dmitshur opened a change golang.org/x/build/internal/relui: wait more before starting Google Docker build15h
The build script fetches Go release archives from https://go.dev/dl/
as part of its work, so the "Publish to website" step needs to be
completed before the dependencies for this step are satisfied.dmitshur commented on golang.org/x/website/internal/history: document Go 1.21.5 and 1.20.12 releases15h
(1 comment)
FWIW I think it's fine, but up to you.dmitshur reviewed +2 on golang.org/x/website/internal/history: document Go 1.21.5 and 1.20.12 releases15h
Thanks.
(nit) The alignment here is different from other entries, but it still works.dmitshur closed an issue runtime: add GOEXPERIMENT=rangefunc package with Seq, Pull [freeze exception]16h
dmitshur reviewed +2 on golang.org/x/build/main.star: formalize default host suffixes (OS versions)16h
Thanks.
I notice a bit of inconsistency in that we have this field in define_environment, but all 3 calls to it use the same LOW_CAPACITY_HOSTS global, and some places (e.g., dimensions_of) use the …dmitshur commented on runtime: add GOEXPERIMENT=rangefunc package with Seq, Pull [freeze exception]17h
Is #64277 different from this?dmitshur reviewed +2 on net/http: limit chunked data overhead17h
dmitshur commented on github.com/shurcooL/graphql: Mutation and Query structs are parsed unreliably/depend on how they are declared18h
Thanks for reporting this. I'll take a look.This Week
dmitshur commented on golang.org/x/build/main.star: add protoc_with_conformance dependency for protobuf repo1d
(1 comment)
In PS 2, I've changed this project-wide dictionary to instead be a list of "extra dep" special cases that apply under matching conditions. PTAL.dmitshur commented on golang.org/x/build/main.star: add protoc_with_conformance dependency for protobuf repo1d
(1 comment)
This CIPD package is only built for linux/amd64 now, so I shouldn't try to fetch it on the darwin-amd64 builder for example.
Also, since the integration test doesn't run in -short mode,…dmitshur commented on math/rand/v2: submit chacha8 and runtime code [freeze exception]1d
We will leave an explicit comment soon. I left a reaction to express my opinion even sooner. Thanks.dmitshur commented on golang.org/x/build/main.star: add protoc_with_conformance dependency for protobuf repo1d
(1 comment)
When we want to give more control to golangbuild, we end up with very inflexible input properties like xcode_version, node_version, etc., that let the caller control just the version, bu…dmitshur opened a change golang.org/x/build/main.star: add protoc_with_conformance dependency for protobuf repo1d
This dependency is needed for running the protobuf integration test.
For golang/go#64066.dmitshur commented on golang.org/x/build/main.star: add nocgo builders1d
(1 comment)
Yep, please feel free to proceed. Thanks for considering this, and your suggestion (making dimensions_of responsible only for remapping a short suffix to dimensions, not having to handle…dmitshur commented on golang.org/x/build: consider opting-in to longtest builders by default for cmd/go changes, if/when they're under 15 min1d
I agree with the non-cmd/go-related suggestion in https://github.com/golang/go/issues/42661#issuecomment-1116274332. That is, I suggest opting into longtest on at least linux/amd64 when any of these …dmitshur commented on golang.org/x/build/main.star: add nocgo builders1d
(1 comment)
Oh, maybe the relevant factor is that Mac builders are a low-capacity host right now (lines 566-568).dmitshur reviewed +2 on golang.org/x/build/main.star: add nocgo builders1d
(2 comments)
Thanks. See another comment inline.
Can the handling of "darwin-amd64" → "darwin-amd64" + os: "Mac-14" be done here (dimensions_of) instead of in split_builder_type? This seems to be…dmitshur reviewed +2 on golang.org/x/build/main.star: add the staticlockranking builder1d
Thanks. This is awesome!
It's fantastic how easy we can do this with LUCI now!
There's been demand for this kind of thing (e.g., #42661).
Is the internal host intentionally not being matched here, …dmitshur reviewed +2 on golang.org/x/build/main.star: add nocgo builders1d
Thanks.
Can it work well to add it as "darwin-amd64-nocgo", that is, without specifying _14 here, since the important bit is that it's testing the darwin/amd64 port without cgo, and the exact major …Last Week
dmitshur reviewed +1 on cmd/compile: update PGO profile3d
dmitshur commented on golang.org/x/text/encoding/charmap: maketable.go fails because of old URLs4d
Thanks for reporting and sending a fix. CC @mpvl.dmitshur reviewed +2 on golang.org/x/build/main.star: make all low-capacity builders ALL_MODE builders4d
Thanks. I didn't spot problems.
Thanks for writing down the motivation of this change.
lucicfg fmt. (Edit: Done in PS 2.)dmitshur reviewed +2 on doc: remove encoding/binary.NativeEndian release note placeholder4d
Thanks.dmitshur commented on golang.org/x/website/_content: add blog link to go.dev/rebuild4d
(1 comment)
Whoops, Markdown won't render since this page is .html. Sent CL 546695.dmitshur opened a change golang.org/x/website/_content: fix Markdown link in rebuild.html4d
This page has .html extension, not .md, so use an HTML link.dmitshur commented on cmd/go: change go test to FAIL if `-run` is specified but no tests match4d
CC @bcmills, @matloob.
Slightly related, but in the opposite direction: `go test` and `go vet` currently print a warning and also exit with a fatal error when an import path pattern matches 0 pack…dmitshur commented on cmd/compile: Fix generics error message for mismatch of number of type params and arguments4d
(3 comments)
(nit) The verb after the colon customarily starts with a lower-case letter. See https://go.dev/wiki/CommitMessage (third bullet point). So "fix", not "Fix".
(nit) No need for a colon a…dmitshur commented on database/sql: possible deadlock on Rows.awaitDone()/Rows.Err()/Rows.Close() after RawBytes change4d
CC @bradfitz, @kardianos, @kevinburke.dmitshur commented on cmd/compile: pgo support for external Linux perf profiles and perf_data_converter4d
CC @golang/compiler.dmitshur commented on cmd/compile: pgo weighted merge support4d
CC @golang/compiler.dmitshur commented on golang.org/x/net/html: removing first child node of pre causes doubling of newline at beginning of following text node4d
CC @neild, @ianlancetaylor.dmitshur commented on cmd/link: package doc contains outdated linker flags4d
Thanks for reporting. I added Suggested since this seems like a good issue for someone looking to send a CL to fix.
CC @golang/compiler.dmitshur commented on all: user-facing golang.org/x repos need to stay green4d
Using-facing x/ repos seem green at this point, with one failure mode in x/tools that is being tracked in #64488.dmitshur commented on lib/time: update tzdata before release4d
2023c is still the latest by now. Adding okay-after-rc1. If a new version comes out before the final go1.22.0 release, we'll have a chance to update to it.dmitshur reviewed +2 on golang.org/x/build/cmd/makemac: keep-alive service for MacService leases5d
Thanks.
makemac makes a [return](https://go.dev/cl/28584) in 2023! 😅
s/ /=/
Like already done on line 6.
(If you want, also fix this in cmd/pubsubhelper/Dockerfile and cmd/gerritbot/Dockerfile…dmitshur reviewed +2 on golang.org/x/build/main.star: unpin golangbuild and clean up5d
Thanks.dmitshur commented on golang.org/x/build: add LUCI netbsd-arm builder5d
Here's the resulting certificate: [netbsd-arm-bsiegert-1701367164.cert.txt](https://github.com/golang/go/files/13516881/netbsd-arm-bsiegert-1701367164.cert.txt).
The builder definitions have been …dmitshur commented on golang.org/x/build: add LUCI openbsd-riscv64 builder5d
Here's the resulting certificate: [openbsd-riscv64-mengzhuo-1701367184.cert.txt](https://github.com/golang/go/files/13516851/openbsd-riscv64-mengzhuo-1701367184.cert.txt).
The builder definitions …dmitshur commented on cmd/compile: document PGO policy regarding explicit user optimization hint behavior5d
CC @golang/compiler.dmitshur commented on runtime: test timeouts on ios-arm64-corellium5d
CC @golang/ios.dmitshur opened a change golang.org/x/build/internal/workflow: preserve prefix in Definition.shallowClone5d
It seems this was missed in the initial implementation of expansions,
but we never noticed until CL 541379 started using them for advisory
builders in minor release workflows.
For golang/go#63147.dmitshur commented on all: announce end of support for old Linux versions6d
Thanks for the suggestion above.
We've entered the release freeze for 1.22 and there aren't announcements to make for this release, moving to the next for now.dmitshur reviewed +2 on golang.org/x/build/internal/relui: add task to update test repo with go release6d
Thanks.
Same suggestion here:
```suggestion
wf.Task1(wd, "update-proxy-test", version.UpdateProxyTestRepo, published)
```
Since the `currPublished` Value is already an input to `UpdateProxyTest…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle6d
[CL 546055](https://go.dev/cl/546055) did the start-of-freeze update for the 1.22 cycle.
Moving to the Go 1.23 milestone and adding early-in-cycle.dmitshur closed an issue : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.206d
The revert was done in [CL 545995](https://go.dev/cl/545995).
This wasn't caught via LUCI trybots because we have only setup Windows 10, not older, in it so far. See [here](https://cs.opensource.g…dmitshur closed an issue crypto/rand: Legacy RtlGenRandom use on Windows [1.20 backport]6d
This cherry-pick doesn't apply to Go 1.20 because it supports older Windows versions where ProcessPrng isn't available. The change was rolled back in [CL 545995](https://go.dev/cl/545995). Re-closing…dmitshur opened a change all: update vendored dependencies6d
The Go 1.22 code freeze has recently started. This is a time to update
all golang.org/x/... module versions that contribute packages to the
std and cmd modules in the standard library to latest maste…dmitshur reviewed +2 on Revert "[release-branch.go1.20] crypto/rand: switch RtlGenRandom for ProcessPrng"6d
TestCancelRequestWithChannelBeforeDo_Cancel failure looks like another instance of #59494. TryBot-Result+1 means it passed on Windows 7, the important bit.
I think you can rearrange this:
```
[rele…dmitshur closed an issue access: request to add myself as a member to port-maintainers/s390x team.6d
Glad this is sorted out. Thank you for your help maintaining the s390x architecture.dmitshur reviewed +2 on Revert "[release-branch.go1.20] crypto/rand: switch RtlGenRandom for ProcessPrng"6d
Thanks.
Please edit the description to add the Gerrit CL number being rolled back next to or instead of the Git revision number. (https://go.dev/wiki/CommitMessage#reverts)dmitshur commented on net/http: context deadline can cause surprising errors6d
CC @neild.dmitshur commented on : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.206d
Go 1.20 is the last release that still supports Windows 7 and up (https://go.dev/doc/go1.20#windows), whereas Go 1.21 started to require Windows 10/Windows Server 2016 and higher (https://go.dev/doc/…dmitshur commented on : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.206d
Two differences I'm spotting to note:
1. In old infra, go1.20.6 is being used as the bootstrap version. In LUCI, go1.17.13 is the bootstrap version, which is the minimum required for Go 1.20.
2…dmitshur opened an issue : windows/386 and windows/amd64 fail to build on tip of release-branch.go1.206d
From https://build.golang.org/?branch=release-branch.go1.20:
<img width="272" alt="image" src="https://github.com/golang/go/assets/1924134/c82df06a-fa07-4cca-930f-b297eb3b9f69">
Starting with […dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.6d
> Yes.. I requested the golang organization request and I am part of that now..
Can you share a screenshot of what that looks like from your end? Is "Vishwanatha-HD" the right username? I'm not se…dmitshur commented on crypto/x509: using a parsed certificate as a Template and clearing PolicyIdentifiers might not remove them6d
This is currently a blocker for the RC 1, scheduled in about two weeks. Can someone from @golang/security take a look. Thanks.dmitshur commented on internal/trace/v2: TestTraceStacks failures with `inconsistent status`6d
This is currently a blocker for the RC 1, scheduled in about two weeks. What is the latest status here?dmitshur commented on golang.org/x/crypto/x509roots/fallback: update bundle6d
Friendly ping @roland@golang.org. Unless it's intended for this CL to be waiting.dmitshur commented on golang.org/x/debug/cmd/viewcore: viewcore panic:Error while trying to run command "histo --top 10": runtime error: integer divide by zero6d
Thanks for reporting. Does this also happen with Go 1.21 or 1.20? Go 1.19 is not supported.
CC @golang/runtime.dmitshur commented on cmd/cgo/internal/test: consistently failing with `segmentation fault` on `linux-arm-aws` since CL 5452776d
CC @golang/compiler.dmitshur commented on debug/elf: slice out of bounds in DynValue6d
CC @golang/compiler.dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.6d
Hmm, I'm not entirely sure about GitHub invitation process details. Perhaps you need to accept the golang organization invite first, which will then enable you to join the team? If that doesn't work,…dmitshur closed an issue cmd/compile/internal/base: GODEBUG=zerocopy=0 tag doesn't seem to work6d
dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.6d
The GitHub team https://github.com/orgs/golang/teams/s390x is where I've sent the invite.
It currently shows "1 pending member", and your GitHub account is listed:
<img width="577" alt="image" sr…dmitshur commented on access: request to add myself as a member to port-maintainers/s390x team.6d
Thanks, I've sent a pending invitation to rejoin that you'll need to accept.dmitshur opened a change golang.org/x/build/main.star: add netbsd-arm, netbsd-arm64, openbsd-riscv64 builders1w
For golang/go#63698.
For golang/go#63614.
For golang/go#64176.dmitshur commented on golang.org/x/build: add LUCI linux-riscv64 builder1w
It looks like the builder has passed some times by now, e.g., there are recent "SUCCESS" entries at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-riscv64 and https://ci.chromium.org/ui/…dmitshur commented on debug/elf: viewcore cannot read s390x z/Linux Go coredump: decoding dwarf section info at offset 0x0: too short1w
CC @golang/s390x, @golang/compiler.dmitshur commented on golang.org/x/sys/unix: Missing Netfilter and NFTables constants1w
CC @tklauser, @golang/runtime.dmitshur commented on cmd/compile/internal/base: GODEBUG=zerocopy=0 tag doesn't seem to work1w
CC @golang/compiler.dmitshur commented on golang.org/x/build/main.star: fix console_ids for dl and protobuf repos1w
Thanks.dmitshur opened a change golang.org/x/build/main.star: fix console_ids for dl and protobuf repos1w
CL 539280 changed console names in order to improve their sort order,
but missed one more place that needed updating.dmitshur reviewed +2 on runtime: [release-branch.go1.21] call enableMetadataHugePages and its callees on the systemstack1w
dmitshur commented on sort: add available godoc link1w
Thanks.dmitshur reviewed +2 on cmd/compile: [release-branch.go1.21] fix findIndVar so it does not match disjointed loop headers1w
(1 comment)
Done in PS 2.dmitshur commented on cmd/compile: [release-branch.go1.20] fix findIndVar so it does not match disjointed loop headers1w
(1 comment)
Done in PS 3.dmitshur commented on cmd/go: TestScript/cgo_stale_precompiled fail in windows with clang 14.0.61w
CC @golang/windows, @bcmills.dmitshur reviewed +2 on cmd/compile: [release-branch.go1.20] fix findIndVar so it does not match disjointed loop headers1w
dmitshur reviewed +2 on golang.org/x/build/Revert "main.star: unpin golangbuild and clean up"1w
Thanks.dmitshur reviewed +2 on cmd/compile: fix findIndVar so it does not match disjointed loop headers1w
dmitshur reviewed +2 on cmd/compile: fix findIndVar so it does not match disjointed loop headers1w
Thanks.
Please add "[release-branch.go1.20]" prefix to the CL subject, since this is CL targets that branch.
It looks like #59494.
I'll also rebase this so that the fix for #63988 is included.dmitshur reviewed +2 on cmd/compile: fix findIndVar so it does not match disjointed loop headers1w
Thanks.
Please add "[release-branch.go1.21]" prefix to the CL subject, since this is CL targets that branch.dmitshur reopened a change path/filepath: [release-branch.go1.20] consider \\?\c: as a volume on Windows1w
dmitshur commented on path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows1w
Gerrit wouldn't let me create a new CL with the same Change-Id value, so I reopened and reused this one.dmitshur reopened a change path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows1w
dmitshur commented on path/filepath: Clean removes ending slash for volume on Windows in Go 1.21.41w
Minor releases are planned for the beginning of each month. I expect the next month's (December) minor releases to follow that pattern.dmitshur closed a change : Test HTTP Concurrency1w
Thanks for trying to prepare a cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at th…dmitshur closed a change path/filepath: [release-branch.go1.20] consider \\?\c: as a volume on Windows1w
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur closed a change path/filepath: [release-branch.go1.20] consider \\?\c: as a volume on Windows1w
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur closed a change path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows1w
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur closed a change path/filepath: [release-branch.go1.21] consider \\?\c: as a volume on Windows1w
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…dmitshur reviewed +2 on golang.org/x/build/main.star: unpin golangbuild and clean up1w
Looks good to try again. Thanks.dmitshur commented on maps: inconsistent panic in Copy with nil dst1w
CC @eliben, @Deleplace.