Activity
Yesterday
dmitshur reviewed +2 on golang.org/x/build/main.star: add a goamd64v4 builder9h
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add noavx512 builders running on n2d-standard-16 machines9h
Thanks.dmitshur reviewed +2 on cmd/dist: drop sharding for testdir tests9h
Thanks.
This variant name is the same as the package name, which doesn't convey much information about how this particular test variant differs from the nominal "go test cmd/internal/testdir" invoca…dmitshur commented on cmd/dist: run testdir tests in initial go test run10h
(1 comment)
(Sorry, I meant to post this comment in CL 853365 but accidentally posted it the wrong CL. Feel free to apply it anywhere, or even better all this "drop unused sharding" functionality fe…dmitshur commented on cmd/dist: run testdir tests in initial go test run10h
(1 comment)
Remove these since you're removing the only reason these still exist?dmitshur commented on cmd/dist: run testdir tests in initial go test run10h
(1 comment)
Oh, I see how I misread it - this continues to skip this test on mobile platforms; the reason this special registerTest call is still left behind here is for Wasm targets. That's unfortu…dmitshur commented on cmd/dist: run testdir tests in initial go test run10h
(2 comments)
Consider upstreaming this skip into cmd/internal/testdir itself by adding a `//go:build !race` constraint (similar to [here](https://cs.opensource.google/go/go/+/master:src/sync/pool_te…dmitshur reviewed +2 on cmd/dist: consolidate maxbg logic12h
dmitshur commented on cmd/dist: drop sharding for testdir tests13h
(5 comments)
This CL is a bit hard to review because it removes partial support for sharding cmd/internal/testdir and leaves some unneeded parts of the mechanism behind. It'd be easier to review the…dmitshur reviewed +2 on cmd/dist: consolidate maxbg logic13h
LGTM % remove accidental binary. Thanks.dmitshur commented on cmd/dist: consolidate maxbg logic13h
(1 comment)
Please do not check in an unneeded 4.6 MB binary file. Also added a Hold+1 for that.dmitshur reviewed +2 on golang.org/x/build/env: install podman on Debian 12 images13h
Thanks.dmitshur reviewed +2 on golang.org/x/build/env: allow using podman instead of docker to build images13h
Thanks.
Have you also considered migrating to using Cloud Build to build images? That should be more predictable and requires less local tools installed; we already switched to using Cloud Build for…dmitshur reviewed +2 on golang.org/x/build/main.star: remove freebsd 15.0 builder from known issue list14h
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: remove avx512 builders14h
Thanks.dmitshur reviewed +2 on golang.org/x/build/Revert "main.star: wait for capacity for docker instances"14h
Thanks.
```suggestion
This reverts CL 852985.
```
(As suggested at https://go.dev/wiki/CommitMessage#reverts.)This Week
dmitshur commented on golang.org/x/build/main.star: wait for capacity for docker instances1d
(1 comment)
Also, expiration_timeout for linux-amd64_docker can probably stay at 6 hours (for the same reason it's 6 hrs for all other builders on GCE). But it's not a big deal either way in the sho…dmitshur reviewed +2 on golang.org/x/build/main.star: wait for capacity for docker instances1d
Thanks.
To comment to this part of the commit message:
> (I'm not sure why we don't always wait for capacity in case the builder isn't available).
This part of the comment motivates why.
If we fi…dmitshur commented on golang.org/x/build: upgrade freebsd builders to 14.5 and 15.11d
CC @golang/freebsd, @golang/release.dmitshur commented on golang.org/x/build: add OpenBSD 8.0 builder1d
CC @golang/openbsd, @golang/release.dmitshur reviewed +2 on golang.org/x/build/env/openbsd-amd64: mount filesystem as async1d
Thanks.dmitshur commented on golang.org/x/build/main.star: remove sharding for non-misccompile builders1d
(1 comment)
Yeah. We can go with whichever of "one make.bash but many network copies + synchronization" and "many make.bash invocations" we find more optimal for what we're optimizing for (latency, …dmitshur reviewed +2 on golang.org/x/build/main.star: remove sharding for non-misccompile builders1d
(1 comment)
(Leaving this as unresolved to be sure this wasn't accidentally missed. Please feel free to ack after you see it; no action is needed in this CL.)dmitshur reviewed +2 on golang.org/x/build/main.star: add openbsd-amd64_8.0 to SLOW_HOSTS1d
Thanks.
```suggestion
main.star: add openbsd-amd64_8.0 to SLOW_HOSTS
For golang/go#82400.
```dmitshur reviewed +2 on golang.org/x/build/internal/task: checkout release tag in publishPackageExtension1d
Thanks.dmitshur commented on golang.org/x/build/main.star: update freebsd and openbsd builders to later versions1d
(1 comment)
Related, I see that SLOW_HOSTS already has `"openbsd-amd64": struct(scale = 4)`.
It seems to maybe not be propagating somehow? For example, I don't see `test_timeout_scale: 4` at https:…dmitshur reviewed +2 on golang.org/x/build/main.star: remove sharding for non-misccompile builders1d
Thanks.
These 2 variables seem to be left unused, can delete.
Seems unused.
After some time passes, we can come back to this and evaluate this speed vs duplicate work tradeoff, and see if we want …dmitshur reviewed +2 on golang.org/x/build/main.star: update freebsd and openbsd builders to later versions1d
Thanks.
This one seems to be timing out unlike the previous, right? Compare https://ci.chromium.org/ui/p/golang/builders/ci/gotip-openbsd-amd64_8.0 (new) and https://ci.chromium.org/ui/p/golang/buil…dmitshur reviewed +2 on golang.org/x/build/main.star: add wasip1-wasm_wasmtime-stackswitch postsubmit builder2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/env/freebsd-amd64: add 14.5 and 15.1 versions with GVNIC2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/env/openbsd-amd64: increase thread limits2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add n4d freebsd 14.5 and 15.1 builders2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add OpenBSD 8.0 builders for testing2d
Thanks.
```suggestion
For golang/go#82400
```dmitshur reviewed +2 on golang.org/x/build/env: update openbsd-amd64 README to set version to 8.02d
Thanks.
In general, it's a good idea to have a tracking issue whenever changing builder versions, so it can be used as a central place for anything that might come up. The issue description can be a…dmitshur commented on golang.org/x/build/main.star: add project-specific dry-runner and committer ACLs2d
Thanks.dmitshur commented on golang.org/x/build/internal/releasetargets: update list for Go 1.283d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: migrate default linux-amd64 builders to Debian 123d
Thanks.
Some mixup here, right? (This CL has nothing to do with Debian 13.) Probably fine to just drop this line.dmitshur reviewed +2 on golang.org/x/build/main.star: add linux-amd64_debian11 builder and rename sid to 133d
Thanks.
(nit) Maybe it can be made slightly more clear here this refers to the current version on of the http://gcr.io/symbolic-datum-552/linux-x86-sid image.
```suggestion
currently have Debian 13…dmitshur commented on golang.org/x/build/main.star: remove sharding for non-misccompile builders3d
(1 comment)
If I understand correctly, trouble with moving some of the BSD builders means this'll be adjusted, right?dmitshur commented on golang.org/x/build/cmd/makemac: increase arm64 allocation3d
Thanks.dmitshur fixed an issue golang.org/x/build/internal/installer/darwinpkg: unclear purpose and effect of "Fixing permissions" step during postinstall3d
The "Fixing permissions" step removal in Go 1.27 didn't seem to uncover anything unexpected, so closing this as done.
<details><summary>Confirmation of removal details</summary>
```shell
$ pkgutil …dmitshur fixed an issue golang.org/x/build/internal/installer/darwinpkg: unclear purpose and effect of "Fixing permissions" step during postinstall3d
The "Fixing permissions" step removal in Go 1.27 didn't seem to uncover anything unexpected, so closing this as done.
<details><summary>Confirmation of removal details</summary>
```shell
$ pkgutil …dmitshur commented on golang.org/x/build/main.star: move darwin-arm64 default to macOS 26 (from macOS 15)3d
Thanks.dmitshur commented on golang.org/x/build/cmd/makemac: increase arm64 allocation3d
(1 comment)
Given that darwin/arm64 has a newer macOS version available and it should be more representative of most macOS uses, it probably makes sense to move it over. Sent CL 851512 to update the…dmitshur opened a change golang.org/x/build/main.star: move darwin-arm64 default to macOS 26 (from macOS 15)3d
macOS 26 has more telemetry reports¹ than macOS 15, so perhaps it's
time to update the default darwin/arm64 builder version accordingly.
¹ https://telemetry.go.dev/#charts%3acmd%2fgo%3ago%2fplatfo…dmitshur opened a change golang.org/x/build/cmd/makemac: increase arm64 allocation3d
Use up all of the newly available quota for darwin/arm64 builders.dmitshur commented on golang.org/x/build: add GOAMD64=v3 perf builders3d
There were GOAMD64=v3 perf builders added above, and they're running. It's also added to the perf dashboard.
@matloob Should this be closed as done or was there something specific still left to do h…dmitshur reviewed +2 on golang.org/x/build/main.star: switch builders with available shapes to n4dh323d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: remove redundant _n4ah32/_n4dh32 builders3d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: switch presubmit builders to n4dh32/n4ah323d
Thanks.dmitshur commented on golang.org/x/build/cmd/makemac: increase amd64 allocation3d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/gophers: make pjw@google.com Peter's primary Gerrit email3d
Thanks.dmitshur pushed to
master in github.com/mdempsky/unconvert3ddmitshur merged a change github.com/mdempsky/unconvert/...: update go and dependency versions- #703d
dmitshur reviewed +2 on github.com/mdempsky/unconvert/...: update go and dependency versions- #703d
Thanks.
Note that in the general case, it's not necessary to include the -u flag in the "go get" invocation in order to update dependencies. The -u flag means to update indirect dependencies (depend…dmitshur closed a change golang.org/x/vscode-go/extension/package.json: [release-v0.58] update version to 0.58.04d
Empty change, replaced by CL 850745.dmitshur opened a change golang.org/x/build/cmd/relui: disable race detector4d
For better or worse, the race detector has been on for some time since
CL 827824 and it generally works. It hasn't found any races in workflows
running in prod, and so it hasn't helped make progress …dmitshur opened a change golang.org/x/build/cmd/makemac: increase amd64 allocation4d
Use up all of the newly available quota for darwin/amd64 builders.dmitshur commented on golang.org/x/build/main.star: switch builders with available shapes to n4dh324d
A few comments from an initial look. This generally looks good, will look again later on.
Are these still needed?
And this?
It seems undesirable to maintain a list of certain OS versions to assign…dmitshur commented on golang.org/x/build/main.star: fix multi-suffix bug for Windows OS version4d
(1 comment)
A more general purpose fix would be doing the suffix split above this block, and checking all suffixes in DEFAULT_HOST_SUFFIX. As long as we keep them unique, there shouldn't be false ma…dmitshur reviewed +2 on golang.org/x/build/main.star: fix multi-suffix bug for Windows OS version4d
Thanks.dmitshur fixed an issue golang.org/x/build: linux-amd64-race is taking about 5 minutes too long for pre-submit purposes4d
dmitshur fixed an issue golang.org/x/build: linux-amd64-race is taking about 5 minutes too long for pre-submit purposes4d
dmitshur commented on golang.org/x/build: linux-amd64-race is taking about 5 minutes too long for pre-submit purposes4d
linux-amd64-race trybots are now consistently averaging 5-6 minute completion time (with around 7 minutes in the worst case) after @matloob's work in #82017. That's well within 15 minutes. Calling th…dmitshur reviewed +2 on golang.org/x/build/main.star: add misccompile and longtest n4dh32 builders4d
Copied votes on follow-up patch sets have been updated:
* Code-Review+2 has been copied to patch set 3 (copy condition: "is:ANY").
(4 comments)
(typo)
```suggestion
a longtest builder running on a…dmitshur reviewed +2 on golang.org/x/build/main.star: add n4dh32 variants for 386, wasm, windows, and debian134d
Thanks.
Given the suffix was already slightly overloaded and used both for OS version and CPU version, I suppose it was fairly inevitable for us to at some point start needing mixing multiple of the…dmitshur reviewed +2 on cmd/dist: fix build only dist test portions not respecting -json4d
Nice find. Thanks.Last Week
dmitshur reviewed +2 on golang.org/x/build/devapp/owners: remove stale modproxy owner1w
Thanks.
This line can be deleted too since it became unused.dmitshur reviewed +2 on golang.org/x/build/main.star: pass machine_type in expected_dimensions for Windows builders1w
Thanks.dmitshur commented on golang.org/x/build/internal/task: make 'Publish changes' more fault tolerant1w
(2 comments)
I'm not sure I understand. I agree that tasks can get interrupted midway if say k8s restarts relui or something like that, and PublicizePrivateChanges needs to be written with that in m…dmitshur reviewed +2 on cmd/dist: add -artifacts-dir flag to dist test1w
Thanks.dmitshur commented on cmd/compile: ICE "Int64Val(uint64(9223372036854775808))" when ranging over an unsigned constant ≥ 2^63 in a clear loop (`for i := range uint64(1<<63) { s[i] = 0 }`)1w
CC @golang/compiler.dmitshur reviewed +2 on cmd/internal/obj/x86: [release-branch.go1.26] clear forward-jump list on PCALIGN1w
Thanks.dmitshur reviewed +2 on cmd/internal/obj/x86: [release-branch.go1.27] clear forward-jump list on PCALIGN1w
Thanks.dmitshur commented on golang.org/x/build/main.star: enable go test artifacts on main go repo builders1w
(1 comment)
This change looks like the right next step, but it needs to land no sooner than golangbuild's been updated and we expect it to work. I left comments on crrev.com/c/8589819.
Leaving this…dmitshur reviewed +2 on golang.org/x/build/main.star: reroute linux ppc64{,le} power8 builds1w
Thanks.
To confirm my understanding: the reason it helps to run these builders on on power9 or power10 hardware, instead of just not running them at all in favor of the power9/10 builders that do st…dmitshur reviewed +2 on golang.org/x/website/_content/tour: build and run code snippets as go1.26 modules1w
Thanks.
In cases like this, where it's an existing already-released major version rather than a future version still in development (e.g., 1.28 right now), I wonder whether a major release version l…dmitshur reviewed +2 on golang.org/x/website/_content/js: reset survey banner state on /#survey-reset1w
Thanks.
If this is only needed for testing by few people, have you also considered using browser's console and manually clearing the local storage key for testing needs? The advantage of that is avo…dmitshur reviewed +2 on golang.org/x/build/main.star: use n4dh32 for standard linux-amd64 builders1w
Thanks.
Please take into account the need to pay attention to these builders on release-branch.go1.27 and 1.26 in addition to the main branch. Since release branches change only when approved cherry…dmitshur opened an issue golang.org/x/build: frequent builder infra failures, including linux/amd64 and linux/arm64, on 2026-10-151w
We're aware of an issue most visible on the [Go tip post-submit dashboard](https://ci.chromium.org/p/golang/g/go-gotip/console), where many of the linux/amd64 and linux/arm64 builds are frequently ru…dmitshur commented on golang.org/x/sys/windows: remove MemoryBasicInformation.PartitionId field on windows/3861w
(1 comment)
Thanks.dmitshur commented on golang.org/x/website/_content/solutions: add Temporal to companies using Go1w
Thanks for preparing this change. I'm not familiar with the criteria for adding a new entry to https://go.dev/solutions/case-studies page, but it's something @cbalahan@google.com might have more cont…dmitshur reviewed +2 on Revert "runtime: match deferring function when looking for linked defers in nextFrame"1w
Thanks.
```suggestion
This reverts CL 844565.
```
Thanks for preparing the revert CL. Since it's still running into the infra failures, it might not be the culprit. Adding a Hold for now.dmitshur reviewed +2 on golang.org/x/build/main.star: enable go test artifacts on all builders1w
Thanks.
If you think it'd be worth landing the buildSpace.distTestCmd change behind an experiment first, this can be made into `if project != "go"` for now. But it's also fine to make that change di…dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4a go repo postsubmit builder1w
Thanks. See inline comments.
Oh, the problem seems to be that these lines are currently in the "if goarch amd64" section but should be in the "arm64" one.dmitshur commented on golang.org/x/build/main.star: add an experimental n4a go repo postsubmit builder1w
(2 comments)
(nit) Since this is an x/ repo, these need "golang/go" before '#'.
```suggestion
For golang/go#82017
```
(It makes a bigger difference when it's Fixes instead of just For, but still.)…dmitshur reviewed +2 on golang.org/x/build/main.star: switch linux-amd64-race builders to n4dh32 machines1w
Trying this is indeed a good way to make progress and seeing if something unexpected comes up. Thanks.
For golang/go#82017.dmitshur commented on golang.org/x/build/cmd/golangbuild: add support for test artifacts in LUCI1w
The latest status here is that functionality is enabled in x/pkgsite, for docker builder. What's left is enabling it for the remaining Go repositories and probably posting something in golang-dev so …dmitshur starred github.com/qmuntal/gobuilder1w
dmitshur opened a change golang.org/x/build/main.star: add project-specific dry-runner and committer ACLs1w
The project-golang-may-start-trybots and project-golang-approvers CRIA
groups are used for access across the entire Go project. There are some
projects on the go Gerrit host that are co-owned by the …dmitshur opened a change golang.org/x/build/cmd/gopherbot: extract auto-submit for x/build into dedicated deployment1w
Earlier
dmitshur commented on golang.org/x/vulndb/...: update x/net1w
@nsh@golang.org If you don't mind, since it's been created by now, let's go with the relui-generated CL 847790. It includes the x/net@v0.61.0 update as done here along with a few more.dmitshur commented on cmd/link/internal/ppc64: genpltstub panics instead of reporting a link error when the caller symbol has no data1w
CC @golang/ppc64.dmitshur reviewed +2 on golang.org/x/crypto/openpgp: delete module2w
Thanks.
Carved out module now has a release version.
```
$ go mod init test
go: creating new go.mod: module test
$ go get golang.org/x/crypto/openpgp@latest
go: downloading golang.org/x/crypto v0.5…dmitshur commented on golang.org/x/crypto/openpgp: tidy module2w
Thanks.dmitshur commented on golang.org/x/review/git-codereview: add -ready flag2w
Thanks.dmitshur reviewed +2 on golang.org/x/crypto/openpgp: tidy module2w
Thanks. This should be the version that can be tagged as v0.1.0-deprecated.dmitshur opened a change golang.org/x/build/internal/releasetargets: update list for Go 1.282w
The release freeze for Go 1.28 is a bit over a month away.
Do a preliminary update of the release target list.
So far its diff compared to that of Go 1.27 is as follows:
- No changes.
We'll revisit…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: add 2026 Go Developer Survey banner2w
Thanks. I left some suggestions, mostly minor and optional.
Consider filing a tracking issue for this and adding "For golang/go#nnn." In case there are some issues with this functionality, having a …dmitshur reviewed +2 on spec: fix EBNF for composite literals2w
Thanks.