Yesterday
dmitshur commented on Feature request: allow manually set… in github.com/shurcooL/vfsgen12h
Have you read the documentation for `vfsgendev` at https://github.com/shurcooL/vfsgen#vfsgendev-usage? You may also need to read the section above, at https://github.com/shurcooL/vfsgen#go-generate-u…
dmitshur commented on x/build: plan9-386 builder fails in github.com/golang/go15h
I'm not sure if it's related to this issue, or a separate issue, but there haven't been any plan9 builder results for any of the subrepos recently. I.e., https://build.golang.org/?repo=golang.org%2fx…
dmitshur commented on Refactor testcases in github.com/shurcooL/markdownfmt16h
Thanks for the offer to help! I will need to think more about this, and will get back to you, just after this week. :)
dmitshur commented on Refactor testcases in github.com/shurcooL/markdownfmt16h
Hi @achew22, thanks for the pings, they are helpful. This is on my radar, but I have some more pressing and time-sensitive work to complete first. I hope I'll be able to get to this next weekend o…
dmitshur commented on x/tools/cmd/godoc: boolean logic bu… in github.com/golang/go19h
This is a regression from [CL 153869](https://golang.org/cl/153869), where the logic for incorrect usage detection was modified to be friendlier after CLI removal. It wasn't caught because we didn't …
dmitshur commented on x/tools/cmd/godoc: url flag races a… in github.com/golang/go19h
This is a regression from [CL 141397](https://golang.org/cl/141397), where the logic for whether to init corpus synchronously was modified. It was partially fixed for writing index mode in [CL 141397…
dmitshur commented on x/tools/cmd/godoc: url flag's respo… in github.com/golang/go19h
This is a regression from [CL 141417](https://golang.org/cl/141417), where the `httptest. ResponseRecorder` type was replaced with a custom implementation in order to fix #28138. It wasn't caught bec…
dmitshur commented on Ability to add custom headers to th… in github.com/shurcooL/graphql20h
The code in `golang.org/x/oauth2` is more complex because it seeks to provide a general solution (rather than a very specific one) with a high degree of flexibility. E.g., it supports various token s…
This Week
dmitshur commented on Fix function comments based on best… in github.com/ejcx/passgo1d
If you’d like, this can be improved further: ``` // GetEncryptedFilesDir returns the directory that ... ``` Because it’s preferable to be more direct when describing what a function does.…
dmitshur commented on doc, x/tools/cmd/godoc: move golang… in github.com/golang/go1d
> So if you have a chance to try out the website and let me know what problems you find it would be much appreciated I've spotted a minor difference in the HTML that the new website renders compar…
Last Week
dmitshur commented on U1000 false positive on nested anon… in github.com/dominikh/go-tools2d
Related issues: #262, #203.
dmitshur commented on Fix own misspellings in github.com/client9/misspell3d
Friendly ping.
dmitshur commented on x/build/cmd/gerritbot: Gerrit asks … in github.com/golang/go3d
I thought we had a similar issue. It was #27533 and it's closed now. Is this the same problem, or subtly different?
dmitshur closed a change in go.googlesource.com/build3d
dmitshur pushed to master in github.com/google/go-github3d
4e1a504644bfd34564773b2f8c4c2ba91c8e21ecAdd support for Draft Pull Requests Preview API
dmitshur commented on stylecheck: consider requiring line… in github.com/dominikh/go-tools4d
I have a style suggestion entry for this [here](https://dmitri.shuralyov.com/idiomatic-go#comments-for-humans-always-have-a-single-space-after-the-slashes). One relevant part from there is that: >…
dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github4d
Another step that needs to be done is to re-generate one of the files in this Go package by running the `go generate github.com/google/go-github/github` command. This is mentioned in step 5 of [CONTR…
dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github4d
As mentioned earlier, this is out of place, let's get rid of it.
dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github4d
Based on what I see at https://developer.github.com/v3/pulls/, it seems that the field is named exactly `draft`, not `is_draft`. Do you have another source suggesting it should be `is_draft` instead?…
dmitshur commented on Support draft pull requests api pub… in github.com/google/go-github4d
Thanks, this is a great start! It looks like this PR currently includes commit 31ef9b1 that shouldn't be here. It's removing some code and isn't related to issue #1120. You should also update t…
dmitshur commented on Support Draft Pull Requests API Pub… in github.com/google/go-github4d
> I am really new to Go and this repo but I tried to take a shot on this. I am sorry if there's anything wrong. @joshuabezaleel Thank you for doing that! You don't have to worry, we have code revi…
dmitshur commented on x/build/cmd/gopherbot: sometimes do… in github.com/golang/4d
The fix is deployed now, and it's working as intended. See [here](https://go-review.googlesource.com/c/crypto/+/111335/7#message-17b9a455d2a4c994b44e36a167e9d631f514e0d2).
dmitshur commented on x/build/cmd/gopherbot: sometimes do… in github.com/golang/4d
The fix is deployed now, and it's working as intended. See [here](https://go-review.googlesource.com/c/crypto/+/111335/7#message-17b9a455d2a4c994b44e36a167e9d631f514e0d2).
dmitshur commented on x/website: tracking bug for tip.gol… in github.com/golang/go4d
@cnoellekb Are you planning on working on this? If so, I'm happy to be a reviewer for the CLs. Otherwise I can take this and you can be a reviewer.
dmitshur commented on x/build/cmd/coordinator: some subre… in github.com/golang/go4d
I see two ways this can be implemented: - a more lightweight way (i.e., without having to run all tests twice) by adding a new GOPATH mode builder for just one GOOS/GOARCH, similar to how we do th…
dmitshur commented on x/website: tracking bug for tip.gol… in github.com/golang/go4d
As part of the changes of moving website into x/website, we have to make a decision about the future scope of tip.golang.org. Previously, tip.golang.org served two purposes: it served the latest c…
dmitshur commented on Add include/exclude example to docs in github.com/shurcooL/vfsgen5d
Hi, thanks for the suggestion. > not sure if this is the best way of doing this. That's a reasonable way of doing it. I've also done this using the `github.com/shurcooL/httpfs/filter` packag…
dmitshur commented on Feature request: allow manually set… in github.com/shurcooL/vfsgen6d
Thanks. The relevant part in the snippet is here: ```Go vfsgen.Generate(http.Dir(*dir) ``` That means you're currently using `http.Dir` as the `http.FileSystem` interface implementation th…
dmitshur closed a change in go.googlesource.com/tools6d
dmitshur closed a change in go.googlesource.com/tools6d
dmitshur commented on x/build/cmd/release: go1.12rc1 sour… in github.com/golang/go6d
@bradfitz You're absolutely right, that's what happened. I didn't know about that behavior of Archive Utility.app on macOS. I also confirmed the "go" directory is indeed top-level in `go1.12rc1.sr…
dmitshur commented on Feature request: allow manually set… in github.com/shurcooL/vfsgen1w
Can you share how you're using `vfsgen` right now? If so, it'll be easier for me to show you what I mean. If not, I can try to explain anyway by coming up with an example.
dmitshur commented on x/build/cmd/gopherbot: keeps repeat… in github.com/golang/go1w
There's a new addition, as of #30182: ``` 2019/02/12 01:45:58 got corpus update after 24.897577657s freeze https://golang.org/issue/23772 x/build/cmd/gerritbot: <fill this in> 2019/02/12 01:…
dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go1w
The current fix adds to the plate of "actions gopherbot keeps taking without any effect" (issue #28320): ``` freeze https://golang.org/issue/23772 x/build/cmd/gerritbot: <fill this in> ``` …
dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go1w
I've deployed the fix in the aforementioned CL, which is why gopherbot woke up. The CL still needs to be reviewed before it can be merged.
dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go1w
Since this isn't resolved yet, I have to manually say that I've sent a fix for the "soon" part of this issue as [CL 161906](https://golang.org/cl/161906).
dmitshur commented on x/build/cmd/gopherbot: gopherbot is… in github.com/golang/go1w
Issue #23772 was an empty/spam issue that was closed a year ago. It's showing up as 404 now, which gopherbot can't handle. There are two things we need to fix here: 1. This specific problem in …
dmitshur commented on x/build/cmd/gopherbot: sometimes do… in github.com/golang/go1w
It's a logic problem in `gopherbot` code related to how it does author comparisons, and how Gerrit sometimes represents authors as "Firstname Lastname <1234@...>", but other times as "Gerrit User 123…
dmitshur commented on unsupported GOOS/GOARCH pair darwin… in github.com/goxjs/gl1w
I'm glad I was helpful with this. :) If you don't mind, I'll reopen this issue and use it to update the README with the new instructions.
dmitshur commented on unsupported GOOS/GOARCH pair darwin… in github.com/goxjs/gl1w
It is related to your project using modules. Unfortunately, the version of GopherJS on the `master` branch does not yet have support for modules. This is issue https://github.com/gopherjs/gopherjs/is…
dmitshur commented on unsupported GOOS/GOARCH pair darwin… in github.com/goxjs/gl1w
The intention behind that command was to fetch the GopherJS dependencies of `gl`. I think the `go` command has gotten stricter about rejecting unsupported GOOS/GOARCH combinations. In the past, it…
dmitshur pushed to master in dmitri.shuralyov.com/website/gido1w
936a915e8b34147229aba3aafbf629d42e850fcfget CL subject via Subject method
dmitshur commented on Feature request: allow manually set… in github.com/shurcooL/vfsgen1w
Hi @veqryn, Thanks for the feature request. Fortunately, this is already possible to achieve without changes to `vfsgen`. `vfsgen` was designed to enable this kind of customization (and more) thro…
Earlier
dmitshur commented on x/build: trybots should rebase when… in github.com/golang/go1w
This would've helped catch a problem in [CL 161497](https://golang.org/cl/161497), where the tests passed with an older commit as a parent, but started to fail after being rebased on latest master. …
dmitshur closed a change in go.googlesource.com/build1w
dmitshur commented on xerrors: adds IsOneOf in github.com/golang/xerrors1w
> First, Go development is done with Gerrit (see https://go-review.googlesource.com). We don't accept GitHub PRs. To clarify, we do accept GitHub PRs (they get imported into Gerrit via [GerritBot]…
dmitshur commented on x/build/maintner: GitHub issue even… in github.com/golang/go1w
> Without logs that I could investigate on what's happening this is an insanely hard task with my code base knowledge. > > Sorry, I couldn't help out. Understandable, and no problem. On the c…
dmitshur commented on ST1017: possible false positive in … in github.com/dominikh/go-tools1w
I see. I thought it would be `<const> <binop> <non-const>`.
dmitshur commented on x/build/devapp: doesn't make it cle… in github.com/golang/go1w
This is deployed to https://dev.golang.org/release by now.
dmitshur commented on x/build/cmd/gopherbot: don’t comm… in github.com/golang/go1w
Thanks for clarifying.
dmitshur commented on httputil/header: ParseValueAndParam… in github.com/golang/gddo1w
I am not familiar with the semantics of ParseValueAndParams to have opinions. If it's within spec and doesn't break gddo, it should be fine. That said, I would like to see this package move in the d…
dmitshur commented on x/build/cmd/gopherbot: don’t comm… in github.com/golang/go1w
There's not enough information here for me to understand this issue. Could you please clarify. Per https://golang.org/wiki/CodeReview (and [Interim Code Review and Issue Tracker Conventions](https…
dmitshur commented on x/build/maintner: GerritCL.Subject … in github.com/golang/go1w
> According to git behavior, [...] I could've been more convincing and brief by referencing git documentation, rather than trying to demonstrate behavior. It's documented at https://git-scm.com/do…
dmitshur commented on Fix golint import path in github.com/klauspost/asmfmt1w
For posterity, this change has already been merged as part of commit 9ff68f32955e896453b502001b8266c9aeb20399.
dmitshur commented on x/build/maintner: isTempError impro… in github.com/golang/go1w
> if `Sync` is called, and any repository sync operation fails, the entire error group will exit > ... > a single temporary error in the `Sync` call will always abort all other routines in the grou…