Today
Last Week
shurcooL commented on js: Consider adding Wasm support. in github.com/gopherjs/gopherjs2d
I have nothing against that. The two packages perform different non-overlapping tasks:
- gopherwasm helps future Go programs that target WebAssembly and its `syscall/js` API to *also* compile with G…
I have nothing against that. The two packages perform different non-overlapping tasks:
- gopherwasm helps future Go programs that target WebAssembly and its `syscall/js` API to *also* compile with G…shurcooL commented on x/build/version: promote to /v in github.com/golang/go4dSome reasons why we might want to include a /v/ (or another name) path element:
1. The alternative precludes placing all the individual `go...` commands in a single git repository. Each command wo…
Some reasons why we might want to include a /v/ (or another name) path element:
1. The alternative precludes placing all the individual `go...` commands in a single git repository. Each command wo…shurcooL commented on x/build/version: promote to /v in github.com/golang/go4dWorth thinking through: what will https://golang.org/go1.11beta1 serve? A 404? A redirect to the godoc.org page?
I expect the latter, since https://golang.org/x/build/version/go1.10beta1 redirects…
Worth thinking through: what will https://golang.org/go1.11beta1 serve? A 404? A redirect to the godoc.org page?
I expect the latter, since https://golang.org/x/build/version/go1.10beta1 redirects…shurcooL commented on Packages which normalize casing in … in github.com/golang/gddo4dI have an idea for how to deal with the catch-22.
If my memory of how gddo works is right, I recall there's github.com-specific logic that first checks if the `user/repo` casing is canonical, and …
I have an idea for how to deal with the catch-22.
If my memory of how gddo works is right, I recall there's github.com-specific logic that first checks if the `user/repo` casing is canonical, and …shurcooL commented on x/tools/cmd/tip: migrate beta.golan… in github.com/golang/go4dI have some comments/questions to understand this better. I'm not against this, you're in a better position to know if the work maintaining beta isn't justified.
If I understand this issue, once r…
I have some comments/questions to understand this better. I'm not against this, you're in a better position to know if the work maintaining beta isn't justified.
If I understand this issue, once r…shurcooL commented on Check for fields in externalize, in… in github.com/gopherjs/gopherjs4dSorry about the delay.
The code in `jsmapping.go` looks good.
There have been changes to how prelude is stored by now, so we'll need to rebase and regenerate it (as was mentioned in comments ab…
Sorry about the delay.
The code in `jsmapping.go` looks good.
There have been changes to how prelude is stored by now, so we'll need to rebase and regenerate it (as was mentioned in comments ab…shurcooL commented on Ability to print query string befor… in github.com/shurcooL/githubv45d> you can **copy** the constructQuery() code from graphql library
The keyword is *copy*. It's unexported because it's low-level internal functionality and not a part of the public `graphql` API. You…
> you can **copy** the constructQuery() code from graphql library
The keyword is *copy*. It's unexported because it's low-level internal functionality and not a part of the public `graphql` API. You…shurcooL commented on net/http.Cookie is being rendered i… in github.com/golang/gddo5dWhat browser are you using? I see something different in Chrome 67.0.3396.87 on macOS:
…
What browser are you using? I see something different in Chrome 67.0.3396.87 on macOS:
…Earlier
shurcooL commented on syscall/js: comparing two number ob… in github.com/golang/go2wI’m not completely sure if two distinct `js.Value` values should report positively for equality, even if their underlying values are equal.
A similar situation I can think of is `reflect.Value`,…
I’m not completely sure if two distinct `js.Value` values should report positively for equality, even if their underlying values are equal.
A similar situation I can think of is `reflect.Value`,…shurcooL created repository dmitri.shuralyov.com/gpu/mtl2w
Package mtl provides access to Apple's Metal API (https://developer.apple.com/documentation/metal).
shurcooL commented on all: Go 1.10.3 release status in github.com/golang/go2w@publicarray This issue is about version 1.10.3, but the URL you posted has 1.10.4 in it.
@publicarray This issue is about version 1.10.3, but the URL you posted has 1.10.4 in it.shurcooL commented on build error under OSX 10.12.6 in github.com/vulkan-go/vulkan2wHave you tried following the instructions at https://github.com/vulkan-go/demos#how-to-run-on-desktops? It has some special instructions for building on macOS.
Have you tried following the instructions at https://github.com/vulkan-go/demos#how-to-run-on-desktops? It has some special instructions for building on macOS.shurcooL commented on self-hosting git clone support in github.com/shazow/ssh-chat2wIn case it's helpful as a reference, [here](https://godoc.org/github.com/shurcooL/play/231)'s a proof of concept SSH git server.
In case it's helpful as a reference, [here](https://godoc.org/github.com/shurcooL/play/231)'s a proof of concept SSH git server.shurcooL commented on presentation mode query parameters … in github.com/golang/gddo2wThat query parameter applies to `godoc`, the command you can run locally. godoc.org doesn’t have it.
That query parameter applies to `godoc`, the command you can run locally. godoc.org doesn’t have it.shurcooL commented on unsafe.Pointer workaround in github.com/gopherjs/gopherjs2wThat happens because GopherJS represents `int64` internally using two JavaScript numbers: the low and high components of the `int64`. An `int` is represented by a single JavaScript number that direct…
That happens because GopherJS represents `int64` internally using two JavaScript numbers: the low and high components of the `int64`. An `int` is represented by a single JavaScript number that direct…shurcooL commented on unsafe.Pointer workaround in github.com/gopherjs/gopherjs3w> states that unsafe package isn’t available
To clarify, that document states the `unsafe` package isn't _fully supported_. Parts of it may work, but there are no guarantees. Also, `js.InternalO…
> states that unsafe package isn’t available
To clarify, that document states the `unsafe` package isn't _fully supported_. Parts of it may work, but there are no guarantees. Also, `js.InternalO…
shurcooL commented on net/http: consider implementing htt… in github.com/golang/go3w> I'm more concerned with more code working by default without changes, so I think this is okay to violate for now in Go 1.11. We can revisit in Go 1.12 & later.
I've recently realized an importan…
> I'm more concerned with more code working by default without changes, so I think this is okay to violate for now in Go 1.11. We can revisit in Go 1.12 & later.
I've recently realized an importan…shurcooL commented on net/http: consider implementing htt… in github.com/golang/go3w> wouldn't we still need a custom Transport implementation? If we defined a js,wasm specific client presumably it'd still need to have all the same fields as the normal client.
I think we'll need …
> wouldn't we still need a custom Transport implementation? If we defined a js,wasm specific client presumably it'd still need to have all the same fields as the normal client.
I think we'll need …shurcooL commented on Why panic instead of returning erro… in github.com/neelance/go3wIf that were the case, the user would have to check the returned error value after each call to `Call`. Would that be better?
If that were the case, the user would have to check the returned error value after each call to `Call`. Would that be better?shurcooL commented on Dep ensure fails on this package in dmitri.shuralyov.com/text/kebabcase3w
I tried installing the latest version of `dep`, then did `dep init` followed by `dep ensure` in a project that uses kebabcase. Both commands ran successfully and produced expected output. I didn’t …
I tried installing the latest version of `dep`, then did `dep init` followed by `dep ensure` in a project that uses kebabcase. Both commands ran successfully and produced expected output. I didn’t …shurcooL commented on Dep ensure fails on this package in dmitri.shuralyov.com/text/kebabcase3wThanks for reporting. I am not aware of anything being wrong with the repo, but it seems we’ll need to investigate.
Were you using the latest version of `dep`? How can I reproduce this?
Thanks for reporting. I am not aware of anything being wrong with the repo, but it seems we’ll need to investigate.
Were you using the latest version of `dep`? How can I reproduce this?shurcooL commented on Improvement of design in github.com/shurcooL/gtdo3w> Although, I noticed everything is okay on my PC.
I'm guessing you used Chrome in that screenshot, right? Chrome seems to display things differently (the scrollbar doesn't cover up the content).
…
> Although, I noticed everything is okay on my PC.
I'm guessing you used Chrome in that screenshot, right? Chrome seems to display things differently (the scrollbar doesn't cover up the content).
…shurcooL commented on Ability to print query string befor… in github.com/shurcooL/githubv43wI will need some time to think about how this can be implemented in a simple and clean way, if at all, because it's not immediately clear to me.
I know people prefer to use different solutions for l…
I will need some time to think about how this can be implemented in a simple and clean way, if at all, because it's not immediately clear to me.
I know people prefer to use different solutions for l…shurcooL commented on Improvement of design in github.com/shurcooL/gtdo3w> OS: Windows 10
> Browser: main browser is Yandex Browser.
>
> But I checked other browsers. There's the same bug.
Thanks. I can reproduce it now too.
It turns out it wasn't related so much…
> OS: Windows 10
> Browser: main browser is Yandex Browser.
>
> But I checked other browsers. There's the same bug.
Thanks. I can reproduce it now too.
It turns out it wasn't related so much…shurcooL commented on Improvement of design in github.com/shurcooL/gtdo3wThat looks like a bug, there shouldn't be disabled scrollbars visible. This is what it should look like:
` is not implemented, see #41.
This is because `window.History()` is not implemented, see #41.shurcooL commented on document standard way to recognize … in github.com/golang/go1mo> in #13560 (comment) bradfitz said the wiki would be edited but I can't seem to find anything on the wiki
He said:
> The wiki seems like it would just be edited by somebody without discussion.…
> in #13560 (comment) bradfitz said the wiki would be edited but I can't seem to find anything on the wiki
He said:
> The wiki seems like it would just be edited by somebody without discussion.…shurcooL commented on Robust Header Check in github.com/bradleyfalzon/ghinstallation1moI still see 3 lines of comments in `transport.go` file that don't have a space after `//`, but that's a minor thing. I don't have any other comments, I think this is just waiting on a review from @br…
I still see 3 lines of comments in `transport.go` file that don't have a space after `//`, but that's a minor thing. I don't have any other comments, I think this is just waiting on a review from @br…shurcooL commented on Suggestion: Allow `[]float32` or ot… in github.com/neelance/go1moFor posterity, it's issue golang/go#25532.
For posterity, it's issue golang/go#25532.shurcooL commented on runtime: implement timers, JavaScri… in github.com/golang/go1moAs far as I know, all modern browsers support the basic Fetch API by now, but not all of them support streams, which are required for streaming the response body. E.g., see https://caniuse.com/#searc…
As far as I know, all modern browsers support the basic Fetch API by now, but not all of them support streams, which are required for streaming the response body. E.g., see https://caniuse.com/#searc…shurcooL commented on runtime: implement timers, JavaScri… in github.com/golang/go1moI'm happy to offer help with implementing and/or reviewing here as well.
I'm the author of the original Fetch API-based `http.RoundTripper` implementation [in GopherJS](https://github.com/gopherjs…
I'm happy to offer help with implementing and/or reviewing here as well.
I'm the author of the original Fetch API-based `http.RoundTripper` implementation [in GopherJS](https://github.com/gopherjs…shurcooL commented on Support Preview hovercard API (#87… in github.com/google/go-github1moIt would be good to place `Hovercard` on top of `UserContext`. The general pattern is higher level identifiers should come first. They are easier to understand, and they set context for the lower lev…
It would be good to place `Hovercard` on top of `UserContext`. The general pattern is higher level identifiers should come first. They are easier to understand, and they set context for the lower lev…shurcooL commented on cannot convert math.MaxInt64 in github.com/gopherjs/gopherjs1mo> `int(math.MaxInt64)` will never work, anywhere
Not sure what you mean, but it would work on a 64-bit environment where `int` is 64 bits.
> `int(math.MaxInt64)` will never work, anywhere
Not sure what you mean, but it would work on a 64-bit environment where `int` is 64 bits.shurcooL commented on cannot convert math.MaxInt64 in github.com/gopherjs/gopherjs1moGopherJS emulates a 32-bit environment. `int` is 32 bits, so the `math.MaxInt64` constant is too large for it. It will fit into a `int64` variable though.
See https://github.com/gopherjs/gopherjs#ge…
GopherJS emulates a 32-bit environment. `int` is 32 bits, so the `math.MaxInt64` constant is too large for it. It will fit into a `int64` variable though.
See https://github.com/gopherjs/gopherjs#ge…shurcooL commented on Cannot go get install in github.com/gopherjs/gopherjs1moIt looks like your `golang.org/x/tools` history has diverged from upstream for some reason. Either you made some local changes to it, or the upstream has force-pushed an incompatible commit (less lik…
It looks like your `golang.org/x/tools` history has diverged from upstream for some reason. Either you made some local changes to it, or the upstream has force-pushed an incompatible commit (less lik…shurcooL commented on Proposal: Official GopherJS Docker … in github.com/gopherjs/gopherjs1moI personally don't need this myself at this time. But if you want to do it (for yourself and for others), I don't see why you shouldn't.
It might be a good idea to start this in a place where it's e…
I personally don't need this myself at this time. But if you want to do it (for yourself and for others), I don't see why you shouldn't.
It might be a good idea to start this in a place where it's e…shurcooL commented on js.ValueOf(0).Length() returns -429… in github.com/neelance/go1moFor precedent, https://godoc.org/reflect#Value.Len says:
> Len returns v's length. It panics if v's Kind is not Array, Chan, Map, Slice, or String.
Panicking (and documenting the panic) seems most …
For precedent, https://godoc.org/reflect#Value.Len says:
> Len returns v's length. It panics if v's Kind is not Array, Chan, Map, Slice, or String.
Panicking (and documenting the panic) seems most …shurcooL commented on Avoid unused method receiver names in dmitri.shuralyov.com/idiomatic-go1mo@ilius, not to my knowledge. It can be implemented at the AST-level, type information isn't needed.
It might be a good fit into either [`unused`](https://github.com/dominikh/go-tools/tree/master/cmd…
@ilius, not to my knowledge. It can be implemented at the AST-level, type information isn't needed.
It might be a good fit into either [`unused`](https://github.com/dominikh/go-tools/tree/master/cmd…shurcooL commented on unused exported function not report… in github.com/dominikh/go-tools1moTo be more precise, it’s a method. Its existence makes the `Abc` type implement the following interface:
```Go
type Func1er interface {
Func1()
}
```
If this were a library rather than command, …
To be more precise, it’s a method. Its existence makes the `Abc` type implement the following interface:
```Go
type Func1er interface {
Func1()
}
```
If this were a library rather than command, …shurcooL commented on exclude vendor dir from matching `.… in github.com/kisielk/errcheck1moThat's right. As of https://github.com/kisielk/gotool/issues/16 being resolved, `gotool` will not include `vendor` when expanding `...` on Go 1.9 and later.
That's right. As of https://github.com/kisielk/gotool/issues/16 being resolved, `gotool` will not include `vendor` when expanding `...` on Go 1.9 and later.shurcooL commented on Utilizing Same API Client Pattern i… in github.com/google/go-github1moAs Glenn said, Will is indeed the person who can give you a good answer.
I personally hope you do apply the best practices of making a high quality Go package to your API client library.
I've contr…
As Glenn said, Will is indeed the person who can give you a good answer.
I personally hope you do apply the best practices of making a high quality Go package to your API client library.
I've contr…shurcooL commented on Unmarshal data field only if presen… in github.com/shurcooL/graphql1moThanks for checking, @mwilli31.
Thanks for checking, @mwilli31.shurcooL commented on Panic when calling "getReader" on a… in github.com/neelance/go1moYeah, just checked latest Firefox Nightly, and Streams API is simply not supported (with default settings). Compare Firefox Nightly (62.0a1):
. Compare Firefox Nightly (62.0a1):
![image](https://user-images.githubusercontent.com/192…shurcooL commented on Panic when calling "getReader" on a… in github.com/neelance/go1moDid you check if the same functionality in JavaScript works?
Does that version of Firefox support streams API by now? https://caniuse.com/#search=ReadableStream Last time I checked (some time ago), …
Did you check if the same functionality in JavaScript works?
Does that version of Firefox support streams API by now? https://caniuse.com/#search=ReadableStream Last time I checked (some time ago), …