Today
Yesterday
shurcooL starred github.com/XProger/OpenLara8h
shurcooL commented on RepositoriesService: Return nil sli… in github.com/google/go-github9h
Perhaps we should also update documentation to reflect this. ``` // GetRequiredStatusChecks gets the required status checks for a given protected branch, // or nil if the branch is not protected…
shurcooL commented on RepositoriesService: Return nil sli… in github.com/google/go-github10h
How do you feel about checking if `len(contexts) != 0` instead? I'm not sure if we should verify whether the method returns `nil` slice or `[]string{}` empty slice. Do you think we should?
shurcooL commented on RepositoriesService: Return nil sli… in github.com/google/go-github11h
How do you feel about verifying that `len(checks) == 0` instead?
shurcooL created branch in github.com/gopherjs/gopherjs11h
build-document-ignored
shurcooL commented on panic: nil package for unexported q… in github.com/gopherjs/gopherjs11h
I've fixed #559 just now. Is it possible for you to check if this issue still occurs with latest GopherJS?
shurcooL commented on Building tags not work as thought f… in github.com/gopherjs/gopherjs11h
I've fixed #559 just now. That may or may not be sufficient to resolve this issue too. Is it possible for you to check if this issue still occurs with latest GopherJS?
shurcooL commented on Wrongly reusing cached precompiled … in github.com/gopherjs/gopherjs11h
I've fixed #559 just now. Is it possible for you to check if this issue still occurs with latest GopherJS?
shurcooL commented on Add a wrapper around the 'in' opera… in github.com/gopherjs/jsbuiltin11h
Thanks for creating this, @flimzy!
shurcooL deleted branch in github.com/gopherjs/gopherjs12h
stale-calculation-shadow-bug
shurcooL pushed to github.com/gopherjs/gopherjs12h
9659c814build: Fix shadowing bug in staleness calculation. (#635)
shurcooL created branch in github.com/gopherjs/gopherjs13h
stale-calculation-shadow-bug
shurcooL commented on e3a9838frefactored build packag… in github.com/gopherjs/gopherjs13h
The new `pkg` variable here shadows the `pkg` in parent scope. As a result, `if impModeTime.After(pkg.SrcModTime) {` is always false, that's not what's intended.
shurcooL commented on Support new Community Health previe… in github.com/google/go-github15h
It can be a struct, something like this: ```Go type CommunityHealthMetrics struct { HealthPercentage int `json:"health_percentage"` Files struct { CodeOfConduct struct { Nam…
shurcooL commented on RepositoriesService: Return nil sli… in github.com/google/go-github15h
I think it'd be more readable to handle the error completely here, rather than continuing: ```Go if err != nil { // if it's just a 404, don't return that as an error _, err = parseBoolRespons…
shurcooL commented on RepositoriesService: Return nil sli… in github.com/google/go-github15h
This last line can remain the success case: ```Go return p, resp, nil ``` It'd also be consistent with https://github.com/google/go-github/blob/e8d46665e050742f457a58088b1e6b794b2ae966/github…
shurcooL commented on RepositoriesService: Return nil sli… in github.com/google/go-github16h
Also here, s/_unprotected_branch/_unprotectedBranch.
shurcooL commented on Branch protection status checks ret… in github.com/google/go-github16h
This is strange, but I'm getting 404 even for a seemingly protected branch. Are you able to get a 200 OK response still? I tried it on two repos I know have protected master branches, and I get 40…
shurcooL commented on Incorrect directory list in github.com/golang/gddo16h
Yes, the behavior is definitely not the most user friendly. With work and computing resources available (because it'd be more expensive to refresh directories recursively), it can be improved. But it…
shurcooL commented on Incorrect directory list in github.com/golang/gddo16h
It would've been helpful if you posted a screenshot of what you're seeing, so I could compare it to what I'm seeing. But I think I know what's going on. The current behavior of godoc.org is that i…
shurcooL commented on working on gfm compat (helps #1224) in github.com/avelino/awesome-go1d
Feel free to merge then, it has my LGTM.
shurcooL commented on working on gfm compat (helps #1224) in github.com/avelino/awesome-go1d
> So, it'd make sense to rephrase this PR as "Helps #1224." or "Updates #1224." for now. I see you've done that by now. Are we ready to merge this now?
shurcooL commented on copy sanitized_anchor_name to black… in github.com/russross/blackfriday1d
> Independent of the future plans for `sanitized_anchor_name`, I support @russross in copying the function. I'll just say this, I don't like that option because it creates the burden of maintainin…
shurcooL closed an issue in github.com/gopherjs/gopherjs1d
shurcooL commented on docs for js tags in github.com/gopherjs/gopherjs1d
I don't see value in leaving this issue open. It looks like a mental note @neelance made for himself in 2014, I don't think it's relevant anymore. #79 itself can track that. I'll close this. If so…
shurcooL commented on Interface implementation errors are… in github.com/gopherjs/gopherjs1d
Thanks for posting an update here. I get the same output for the program you posted above. However, I'm still seeing the same output as in https://github.com/gopherjs/gopherjs/issues/200#issuecomm…
shurcooL commented on API for accelerometer/gyroscope/ori… in github.com/glfw/glfw1d
> instead of planning forever My guess is that progress on this issue is blocked not on planning/designing the API, but rather on someone having time to work on it, and it being the highest priori…
This Week
shurcooL commented on simple: flag ranging over []rune(s)… in github.com/dominikh/go-tools1d
This check is inspired by suboptimal Go code I wrote 3 years ago: https://github.com/shurcooL/sanitized_anchor_name/blame/79c90efaf01eddc01945af5bc1797859189b830b/main.go#L16 For reference, the…
shurcooL commented on simple: S1015 is questionable in github.com/dominikh/go-tools1d
> I suggest that this check be restricted to the case that the input is already an int. That sounds reasonable to me, and probably intended.
shurcooL commented on copy sanitized_anchor_name to black… in github.com/russross/blackfriday1d
I was just thinking about the reason for all this difficulty in finding a solution that's optimal without compromises is that there's no specification, and as a result, the implementation is the only…
shurcooL commented on copy sanitized_anchor_name to black… in github.com/russross/blackfriday1d
@adg Thanks, that's helpful. > Dependencies have costs. They introduce fragility and complexity. When adding a dependency on another repository, we must weigh up whether that cost is justified. …
shurcooL commented on Large file sizes in github.com/gopherjs/gopherjs1d
@myitcv I explained why I reopened this issue in https://github.com/gopherjs/gopherjs/issues/136#issuecomment-240919591. Just checking, did you see that comment?
shurcooL commented on copy sanitized_anchor_name to black… in github.com/russross/blackfriday1d
@adg Can you elaborate on the motivation to do this? I can certainly guess, but it'd be helpful if you made it explicit. What problem are we trying to resolve?
shurcooL commented on copy sanitized_anchor_name to black… in github.com/russross/blackfriday1d
Previous discussion is at #139. The reason it's in a separate repo is https://github.com/russross/blackfriday/issues/139#issuecomment-69132907. But we can reconsider this issue. I'm going to think…
shurcooL commented on cmd/go: go get -u behaves as if -f … in github.com/golang/go1d
Somewhat relevant, #20115. /cc @josharian
shurcooL commented on cmd/go: go get fails on non-ASCII g… in github.com/golang/go1d
Although, I'm not sure if this really needs a live go get test, I think some offline testcases for `vcsPath` path regexp matching will be sufficient.
shurcooL commented on cmd/go: go get fails on non-ASCII g… in github.com/golang/go1d
#20115 provides further support for the choice of not allowing Unicode for GitHub usernames and repository names needlessly. That way, only the directory names will be susceptible, but not the actual…
shurcooL commented on Support for user's permissions endp… in github.com/google/go-github1d
I'm seeing it here: https://godoc.org/github.com/google/go-github/github#RepositoriesService.GetPermissionLevel Is that the one you're looking for?
shurcooL commented on cmd/go: go get fails on non-ASCII g… in github.com/golang/go1d
I think I can apply a similar solution to fix this as I did for golang/gddo#468: > gosrc.IsValidRemotePath reports false for such import paths because validPathElement regexp only allows ASCII le…
shurcooL deleted branch in github.com/avelino/awesome-go2d
vendor
shurcooL commented on x/tools/cmd/godoc: TestCLI test fai… in github.com/golang/go2d
Ok, that'll work. Will send a CL soon, right after dinner.
shurcooL commented on x/tools/cmd/godoc: TestCLI test fai… in github.com/golang/go2d
What you suggested exactly doesn't work, because package-level variables are initialized before `init` gets a chance to run (https://golang.org/ref/spec#Package_initialization). So when `condStr(!isG…
shurcooL commented on Support generating multiple variabl… in github.com/shurcooL/vfsgen2d
This is a duplicate of #23, I'll rename that issue to be more discoverable and redirect you there. Worth nothing is that there's an open PR #25 that implements a fix.
shurcooL commented on simple: multiple sequential boolean… in github.com/dominikh/go-tools2d
> this kind of code is very unlikely to happen I agree. But see https://github.com/golang/go/issues/5598 and imagine `staticcheck`s output for a laugh. 😆
shurcooL commented on x/tools/cmd/godoc: TestCLI test fai… in github.com/golang/go2d
I have a better understanding (it's more subtle than what I wrote [above](https://github.com/golang/go/issues/20122#issuecomment-297172523)). [CL 33158](https://golang.org/cl/33158) changed behavi…
shurcooL commented on x/tools/cmd/godoc: TestCLI test fai… in github.com/golang/go2d
> Broken for Go 1.7 and Go 1.6 (but not tip) with. @bradfitz, did you mean it's broken for Go 1.8 and Go 1.7 (but not tip)? That would make more sense, given what I'm seeing (I expect it to fail f…
shurcooL commented on x/tools/cmd/godoc: TestCLI test fai… in github.com/golang/go2d
Thanks for reporting, I'll work on fixing this. I only tested using latest Go version when I sent that CL. The test failure is simply I was fairly aggressive about removing accepted error message …
shurcooL commented on "go get -u github.com/nsf/gocode" d… in github.com/nsf/gocode2d
It's probably even better to uninstall some older version rather than sweep it under the rug. My instructions were for a clean Linux installation that does not have Go installed.
shurcooL commented on simple: multiple sequential boolean… in github.com/dominikh/go-tools2d
Yes, but it's worth pointing out it finds distinct issues. The line number is the same, but column is not.
shurcooL pushed to github.com/shurcooL/home2d
3acaa68aRemove note saying godoc.org doesn't work.
shurcooL commented on simple: multiple sequential boolean… in github.com/dominikh/go-tools2d
Output of `staticcheck` on your sample above: ``` $ staticcheck main.go:9:14: negating a boolean twice has no effect; is this a typo? (SA4013) main.go:9:15: negating a boolean twice has no effe…
shurcooL commented on Fails to display docs for package w… in github.com/golang/gddo2d
I've created [CL 41750](https://go-review.googlesource.com/c/41750/) which fixes this bug.
shurcooL starred github.com/faiface/pixel2d
shurcooL commented on delete custom media type 'applicati… in github.com/google/go-github2d
Friendly ping @ahmedhagii. Did you see my review question above?
shurcooL pushed to github.com/google/go-github2d
e8d46665Add Organization Blocking Users preview API. (#620)
shurcooL commented on No way to set base http.Transport/h… in github.com/Ableton/go-travis2d
@nsh-ableton, it looks like @broady made a commit that nearly resolves the issue, see https://github.com/broady/go-travis/commit/bd5bbab6364d388ce9b0a3e4f3f5496bf657af4a. You could take it, amend it …
shurcooL pushed to github.com/shurcooL/reactions3d
bf956202Document Sorted, Position.
shurcooL starred github.com/adtac/commento3d
shurcooL deleted branch in github.com/gregjones/httpcache3d
README-adjust-formatting
shurcooL pushed to github.com/gregjones/httpcache3d
0d2297f2README: More consistent formatting with other Go packages. (#68)
shurcooL pushed to github.com/gregjones/httpcache3d
29e7c21dTravis: Add Go 1.8; use latest minor version.
592c2d59Remove CancelRequest implementation, tracking of request copies.
af915bfaRemove unused resp values. (#66)
558fd8fbMerge branch 'master' into README-adjust-formatting
shurcooL deleted branch in github.com/gregjones/httpcache3d
unused-resp
shurcooL pushed to github.com/gregjones/httpcache3d
af915bfaRemove unused resp values. (#66)
shurcooL pushed to github.com/gregjones/httpcache3d
73bb220fRemove unused resp values.
shurcooL pushed to github.com/gregjones/httpcache3d
29e7c21dTravis: Add Go 1.8; use latest minor version.
592c2d59Remove CancelRequest implementation, tracking of request copies.
caa5ea30Merge branch 'master' into unused-resp
shurcooL deleted branch in github.com/gregjones/httpcache3d
remove-CancelRequest
shurcooL pushed to github.com/gregjones/httpcache3d
29e7c21dTravis: Add Go 1.8; use latest minor version.
592c2d59Remove CancelRequest implementation, tracking of request copies.
shurcooL pushed to github.com/gregjones/httpcache3d
592c2d59Remove CancelRequest implementation, tracking of request copies.
shurcooL pushed to github.com/gregjones/httpcache3d
9eee5002README: Fix link to LICENSE.txt.
shurcooL commented on README: More consistent formatting … in github.com/gregjones/httpcache3d
You're right, banks for catching this, will fix.
shurcooL commented on #569 part 2 : Add Organization Bloc… in github.com/google/go-github3d
This should be changed to `"orgs/%v/blocks/%v"`.
shurcooL commented on add fileb0x in Alternatives in github.com/shurcooL/vfsgen3d
Thanks @siongui. I've fixed the nit and merged this as 19580f3bc1ae808cb84586bc9aa6e6a7e43d1e96.
shurcooL closed a pull request in github.com/shurcooL/vfsgen3d
shurcooL pushed to github.com/shurcooL/vfsgen3d
19580f3bREADME: Add fileb0x to Alternatives section.
01646938Tweak "Code generated by" comment to match new standard.
shurcooL pushed to github.com/shurcooL/vfsgen3d
862d91ddUpdate to latest stable Go (1.8 at this time).
shurcooL pushed to github.com/shurcooL/issuesapp3d
d063b581Improve user spec comparisons.
637efe8dWhen post is edited by non-author, display it more prominently.
shurcooL commented on rate limit exceeded: funky error me… in github.com/google/go-github3d
I'm okay with omitting leading zeros, but I think it's probably better to keep the ones in middle. E.g.: - 5m54s - 25m07s - 19s My opinion on this is not strong. That said, I'd prefer somethi…
shurcooL commented on Question: Dealing with slice of str… in github.com/gopherjs/gopherjs3d
No problem. Glad you figured it out. There are things we can do to improve the situation on the GopherJS side too, so fewer people run into these things in the future. We have some open issues tracki…
shurcooL commented on No fast way to check for presence o… in github.com/gopherjs/gopherjs3d
From a discussion with @neelance and @myitcv, we didn't see this as something that's critical to warrant being added to `js` package itself. The bar for adding things there is really high. Instead…
shurcooL pushed to github.com/shurcooL/frontend4d
662770adTravis: Update to latest stable Go (1.8 at this time).
shurcooL pushed to github.com/shurcooL/frontend4d
2cd3db40Add license name, use consistent wrapping.
shurcooL pushed to github.com/shurcooL/sanitized_anchor_name4d
79c90efaAdd license name, use consistent wrapping.
shurcooL starred github.com/albrow/jobs4d
shurcooL commented on rate limit exceeded: funky error me… in github.com/google/go-github4d
That looks very reasonable, I think. About the time, I like the `58m41s` format. It's compact and informative. I think we could get away displaying that even when it's less than 1 minute left, I d…