Activity
Yesterday
dmitshur reviewed +2 on golang.org/x/build/cmd/gomote: add executable bits for make.bash and make.rc on Windows1d
Thanks.
I'm surprised about the following: on Windows, there are .bat files provided, such as make.bat, all.bat, and so on. If this is about Windows, what's the reason this list doesn't include .bat…dmitshur reviewed +2 on golang.org/x/tools/gopls/doc/features: fix two stray backticks1d
Thanks.dmitshur commented on golang.org/x/tools: various flakes on ppc (linux OOM-kills)1d
No objections to 3 instances with 16 GB RAM, and in general having fewer instances with more memory, from my side. Issue #33986 tracks deciding and documenting the memory requirement for running test…dmitshur commented on golang.org/x/build/internal/task: announce releases on bluesky1d
This comment thread seems to be empty.
You'll need to resolve a small merge conflict with CL 687558 which also updated some dependencies.
Since this CL adds the flag, let's also set its value for t…This Week
dmitshur closed an issue golang.org/x/build/cmd/relui: clone workflow2d
Moving this out of planned for now since there hasn't been high demand for this. Can revisit if it becomes needed.dmitshur commented on cmd/go: built-in tools built on demand don't respect most of the build settings3d
CC @golang/command-line.dmitshur commented on golang.org/x/image/bmp: decode 1, 2 and 4 bits-per-pixel palettes3d
See https://go.dev/wiki/LUCI#trybots.dmitshur starred github.com/soypat/colorspace3d
dmitshur reviewed +2 on golang.org/x/pkgsite-metrics/...: switch to log/slog4d
Thanks.
`go mod tidy` should remove these lines, as checksums for that version are no longer relevant.Last Week
dmitshur opened a change golang.org/x/pkgsite-metrics/...: update golang.org/x dependencies1w
Update golang.org/x dependencies to their latest versions.
Leave out 'go get golang.org/x/exp/event@upgrade' from this change
because including it causes errors. Filed golang/go#74596 for that,
and …dmitshur opened an issue golang.org/x/pkgsite-metrics: module fails to tidy after upgrading golang.org/x/exp/event to its latest version1w
Attempting the following sequence to upgrade one of the dependencies and then tidying this module fails:
```sh
$ cd $(mktemp -d)
$ git clone https://go.googlesource.com/pkgsite-metrics
Cloning into …dmitshur reviewed +2 on golang.org/x/build/go.mod: update golang.org/x dependencies1w
(3 comments)
(This is coming from x/perf requiring the higher version [here](https://cs.opensource.google/go/x/perf/+/master:go.mod;l=25;drc=7b7c2de18447122afb45241f2ca525b4dd19df7b).)
(This is als…dmitshur reviewed +2 on golang.org/x/build/cmd/gomoteserver: add a deployment target that uses commit SHA1w
Thanks. Not seeing any issues. Have you had a chance to try it out yet?
Sounds reasonable. (We do that for previous deploy approaches too.)
Would it be a matter of adding something like https://cs.…dmitshur reviewed +2 on runtime: turn off large memmove tests under asan/msan1w
Thanks.dmitshur commented on golang.org/x/build/internal/relui: add the announce blog post workflow1w
(1 comment)
(That first link was meant to be https://hachyderm.io/@golang/114535620148888941.)dmitshur commented on golang.org/x/build/internal/relui: add the announce blog post workflow1w
Thanks for working on adding this workflow, it will be very helpful to have it! See inline comments.
A nice touch to pass in only the social media tasks instead of all of communication tasks (viable…dmitshur commented on golang.org/x/build/internal/task: announce releases on bluesky1w
Thanks very much for getting it this far Todd, this is a great start! Great timing too, as once this is done, @carlos@golang.org will be able to take advantage of it in the upcoming blog-post-announc…dmitshur closed an issue cmd/go/internal/vcweb/vcstest: TestScripts/git/vgotest1.txt failures1w
dmitshur reviewed +2 on golang.org/x/crypto/go.mod: update golang.org/x dependencies1w
(1 comment)
@roland@golang.org FYI, the tagging workflow is now capable of doing best-effort updates for these (i.e., using whatever is the latest released version available at the start of the work…dmitshur commented on golang.org/x/build/internal/task: don't wait for ignored dependencies1w
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg/testdata: tweak gopls assertions yet again1w
Thanks.
I think it might be the one! 🤞
I take it this'll need to be updated when eventually uncommenting these.
Well, now that it's covered in this test case, you can no longer change it to be …dmitshur commented on golang.org/x/telemetry/go.mod: update golang.org/x dependencies1w
@rfindley@google.com You seem to be most familiar with the [godev nested module](https://go-review.googlesource.com/q/project:telemetry+dir:godev) here. It has some additional golang.org/x dependency…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg/testdata: use tip for gopls tests, for now1w
Thanks.dmitshur reviewed +2 on golang.org/x/mod/go.mod: update golang.org/x dependencies1w
(1 comment)
This is working as intended after #73264. The x/tools is waiting on x/mod to be tagged first, so x/mod can't wait on x/tools's future v0.35.0 version. But it can be updated to its latest…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: make assertions work with dummy and real data1w
Thanks. There might be some follow up (see inline comments), but the changes here are good and will get it closer to working.
Note that for links to pages on the Go website itself, using a relative …dmitshur commented on golang.org/x/build: test failures are hard to discover1w
Issue #74323 might be relevant here.
It appears that the reason the package `golang.org/x/tools/gopls/internal/test/marker` tests are reported as failed is because of the data race that came up duri…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg/cloudbuild.yaml: copy x/tools/gopls into _content1w
Thanks. The directories line up as expected.
FWIW, I think this could say "For" (or "Updates" if you prefer that) since this step to copy x/tools @ HEAD data into x/website's initial _content to imp…dmitshur opened a change golang.org/x/build/internal/task: don't wait on ignored dependencies1w
Prior to CL 681439, the loop over module requirements in readRepo
was skipping non-golang.org/x dependencies, as well as golang.org/x
dependencies that are marked as "ignored". Those skips were repla…dmitshur commented on : go1.23.11 segmentation fault in test1w
CC @golang/runtime.dmitshur commented on crypto/tls: empty server_name conf. ext. from server1w
(1 comment)
@daniel@binaryparadox.net Please note (for future CLs) that one of conventions for Go commit messages is to use "Fixes" to mark issues as resolved. From https://go.dev/wiki/CommitMessage…dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls1w
(1 comment)
I remembered this now. The deploy does this to provide a reasonable fallback (as stated in the comment) for wiki. Not sure if you've seen it, but if not, consider if the gopls endpoint w…dmitshur commented on golang.org/x/website/cmd/golangorg: assert that builders do not use GOTOOLCHAIN1w
(1 comment)
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls1w
(1 comment)
(Might reduce confusion for future readers.)
```suggestion
the tip.golang.org/gopls endpoint serves the latest
```dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: assert that builders do not use GOTOOLCHAIN1w
Thanks. I think this is worthwhile to include for now, since it eliminates a path for the automatic deploys to go awry without us easily noticing it.
Please include `err` from os.Stat in the t.Fatal…dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls1w
(1 comment)
Note that that builder running at patch set 10 did run the test (i.e., it didn't skip it), suggesting it has GOROOT/doc as expected: https://ci.chromium.org/ui/p/golang/builders/try/x_we…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls1w
(1 comment)
Can you please include a direct link to where you saw this? I only found that builder failing at earlier patch sets, for reasons unrelated to this. Does it still happen at patch set 10+?dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls1w
Thanks.
s/This/The/
Please add a https://go.dev/doc/contribute#copyright comment and a blank line before the package comment.
tip.golang.org. We only provide tip. at the golang.org alias, not go.d…dmitshur reviewed +1 on golang.org/x/tools/gopls/doc: add default.tmpl for x/website1w
dmitshur reviewed +2 on golang.org/x/website/internal/history: remove empty entries1w
Thanks.dmitshur commented on cmd/go: disable support for multiple vcs in one module1w
(1 comment)
Consider updating this to the newer wording (as used in the cherry pick CLs).dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls1w
The test failure is likely real - when I tried it locally at PS 6, visiting localhost:6060/go.dev/gopls/ displayed a directory listing rather than a page.
There's no policy requiring this. I wanted …dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls1w
In general this looks very reasonable to me, extending the approach used for /wiki/ pages with details specific to gopls (e.g., defaulting to latest published gopls tag on go.dev; HEAD on tip.go.dev)…dmitshur reopened an issue cmd/compile/internal/ssa: TestStmtLines fails due to auto-generated crypto code1w
Reopening to track removal of the [test skip](https://cs.opensource.google/go/go/+/master:src/cmd/compile/internal/ssa/stmtlines_test.go;l=106-108;drc=4a3cef2036097d323b6cc0bbe90fc4d8c7588660). (CC @…dmitshur commented on golang.org/x/website/_content/blog/generic-interfaces: new blog post1w
Alan, leaving this in your attention set to re-add your votes. Thanks.dmitshur commented on golang.org/x/website/_content/blog/generic-interfaces: new blog post1w
(1 comment)
Please also [keep](https://go-review.googlesource.com/c/website/+/614595/13..14) the date set to today (2025-07-07), and we'll re-add the votes after they reset. Thanks.Earlier
dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines2w
Take a closer look at the 'Submit Requirements' panel, it should show that the CL currently has 3 out of 4 submit requirements satisfied. As soon as the 4th one is satisfied, it'll get auto-submitted…dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines2w
misccompile failure is not persistent and unrelated; bypassing.dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines2w
(1 comment)
Is it known to you why this doesn't seem to reproduce on builders?dmitshur commented on golang.org/x/pkgsite/internal/postgres: Apply bypassLicenseCheck to IsRedistributable column.2w
(1 comment)
(nit) Please note that the Go commit message style uses a lower case letter after the colon, and no period at the end, because it's intended to complete the sentence "This change modifie…dmitshur commented on golang.org/x/build/main.star: update security release branch pattern to match RCs2w
Thanks.dmitshur opened a change golang.org/x/build/main.star: update security release branch pattern to match RCs2w
The previous pattern 'internal-release-branch.go1.24.\d+' works for
minor releases as intended, but doesn't work for release candidates.
RCs can have PRIVATE-track security fixes included too (for ex…dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too2w
Thanks.dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too2w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too2w
(1 comment)
Thanks. Done.dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too2w
(1 comment)
@roland@golang.org This getting pretty long, so maybe worth shortening? Dropping 'and' at least?
"go1.5rc1-go1.4.2-go1.3.2-checkpoint"
I can include some change in this CL if you prefe…dmitshur opened a change golang.org/x/build/internal/task: build internal security branch for next RC too2w
In the second half of the go.dev/s/release cycle, after entering the
release freeze and before releasing the first pre-release (RC 1), a
release branch for the next major Go release is cut.
Security…dmitshur commented on cmd/cgo/internal/testsanitizers: skip asan tests when FIPS140 mode is on2w
Yes, it's generally okay to apply test fixes during the freeze, that's a large part part of what it's for. The text fix needs to be safe, and this looks safe.dmitshur commented on encoding/json/v2: add security section to doc2w
cmd/go.TestScript/list_empty_importpath is #73976.dmitshur commented on runtime: update skips for TestGdbBacktrace2w
Thanks.dmitshur closed an issue sum.golang.org: Update hash of github.com/xmppo/go-xmpp2w
In the general case, the moment a tag is published, it's not viable to modify its contents without potentially causing problems. Instead, it's possible for you to publish a newer version that correct…dmitshur reviewed +2 on runtime: remove arbitrary 5-second timeout in TestNeedmDeadlock3w
Thanks.dmitshur commented on runtime: TestNeedmDeadlock failures3w
The only potentially relevant recent builder change I can think of is [crrev.com/c/6641842](https://crrev.com/c/6641842) (CC @mknyszek) which rebalanced test sharding strategy for #65814. Its timing …dmitshur commented on runtime: TestNeedmDeadlock failures3w
This test has started to fail very often on the gotip-linux-arm64-asan-clang15 linux specifically recently. As visible in its [history](https://ci.chromium.org/ui/test/golang/runtime.TestNeedmDeadloc…dmitshur commented on cmd/doc: fix -http on Windows3w
(1 comment)
(minor) These 2 spaces seem out of place.dmitshur fixed an issue access: approvers3w
Hi Julian,
Thank you for contributing to the Go project, and for your work of being a maintainer of the MIPS ports. We've discussed this request on the team and agreed to grant you this access. I've…dmitshur commented on : Clang 18+ does not support the '-arch' switch (Android NDK binaries)3w
CC @golang/android.dmitshur commented on cmd/link: duplicated definition of symbol github.com/ebitengine/purego.syscall15XABI0 when running with ASAN [1.24 backport]3w
We discussed this and agreed to proceed with the backport. Thanks.dmitshur commented on runtime: [release-branch.go1.24] set mspan limit field early and eagerly3w
The were a number of errors in tests hitting the Go website because during a traffic spike. Retrying.dmitshur commented on cmd/compile: devirtualized type switch causes temporary allocation to escape3w
CC @golang/compiler.dmitshur commented on reflect: TypeAssert[T] is not identical to Interface().(T)3w
CC @golang/runtime.dmitshur commented on slices: TestIssue68488 seems sensitive to minor stack perturbations3w
CC @Jorropo, @randall77.dmitshur commented on cmd/go: go tool does not accept -mod=3w
CC @golang/command-line.dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.3w
If more time is desired and the trade-offs are appropriate, also consider the path of reverting the change that caused this regression, reopening #52745, and trying again in a future cycle.dmitshur commented on runtime: skip GDB "no such process" case3w
(2 comments)
Based on the log in the issue report, and the regexp pattern, is the missing 's' here in the commit message a typo? (Otherwise the regexp won't match.)
```suggestion
"Couldn't get NT_P…dmitshur pushed to
main in rsc.io/rf3w
dmitshur merged a change rsc.io/rf/...: fix detection of unused variable3w
dmitshur reviewed +2 on rsc.io/rf/...: fix detection of unused variable3w
The check fails for reasons unrelated to the change here. The module requires Go 1.20 but the check tries to test with Go 1.16 (which is before [go.dev/doc/toolchain](https://go.dev/doc/toolchain#sel…dmitshur pushed to
main in rsc.io/rf3wdmitshur merged a change rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile3w
dmitshur reviewed +2 on rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile3w
LGTM. Thanks.dmitshur commented on cmd/compile/internal/escape: optimization wrongly affecting panics3w
CC @golang/compiler.dmitshur commented on reflect: Value.Seq|Seq2 documentation and unexported value3w
CC @golang/runtime.dmitshur commented on doc: write release notes for Go 1.253w
The Go 1.25 release notes draft is complete by now, and there doesn't seem to be any remaining known TODOs to resolve. Thanks everyone.
It's okay for this to be open to track any further refinement …dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.3w
Pinging as this is a release blocker for Go 1.25.dmitshur commented on cmd/doc: -http fails on Windows with invalid port3w
Pinging as this is a release blocker for Go 1.25.dmitshur commented on crypto/tls: TLS handshake timeout consistently on Windows VM LTSC2019 with private IP3w
Thanks for the report. So the problem happens with the same Go program in an older Windows LTSC and doesn't happen in a newer Windows LTSC. Is the crypto/tls implementation in Go doing something diff…dmitshur commented on context: fix typo in context_test.go3w
Bypass since trybots already passed on PS 3.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)3w
Thanks.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)3w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)3w
(3 comments)
Hmm, this is the first time I'm encountering this suggestion. I have seen many instances of short inline comments not being a complete sentence (e.g., `N int64 // bytes remaining` rathe…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)3w
Yes, I gave a heads up via chat and I saw that @adonovan@google.com gave it a thumbs up, so I think that's done (Alan, please let me know if you have questions or concerns). I'll copy from https://go…dmitshur reviewed +2 on encoding/json: use zstd compressed testdata3w
Thanks. (The cmd/go.TestScript/list_empty_importpath failure looks unrelated to the changes here.)dmitshur commented on cmd/cover: wrong coverage reported when func fields in struct3w
CC @thanm, @golang/compiler.dmitshur commented on encoding/json/v2: report error on time.Duration without explicit format3w
Indeed, Auto-Submit does what it says on the tin as soon as all submit requirements are satisfied. :) Fortunately there weren't any hidden test failures so it worked out.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)3w
Friendly ping.dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv23w
Thanks.
(nit) Not a big deal, but mentioning for future reference: https://www.w3.org/TR/wasm-core-2/#wasm.
Please include something to connect this CL with a tracking issue. This is [always useful…dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv23w
Thanks.
Both forms are interchangeable and okay. This is described in a bit more detail at [go.dev/wiki/CommitMessage](https://go.dev/wiki/CommitMessage#:~:text=To%20link%20a,or%20vice%20versa.).dmitshur commented on net/http: punycode labels ending with hyphen (xn--example-) should be rejected per updated UTS-463w
Thanks for filing the issue. Someone familiar with this package may have more specific comments, but in general please see https://go.dev/doc/contribute on how to send a code change. I added a mentio…dmitshur commented on golang.org/x/sys/windows: fix filetime conversions and deprecate Nanoseconds3w
CC @golang/windows.dmitshur commented on internal/goexperiment: user facing documentation for GOEXPERIMENT points to internal source for list of supported values3w
CC @golang/command-line, @golang/runtime.