+2 but feel free to also wait for Michael's review.
Fixing the API check needs a new line here:
```
pkg runtime, type MemStats struct, Lookups //deprecated #55915
```
Or in next/api/55915.txt if t…
@rolandshoemaker With `SetFallbackRoots` present and documented in Go 1.20, and `golang.org/x/crypto/x509roots/fallback` being recently added as part of #57792, is it time to move this issue to Go1.2…
(1 comment)
FWIW, from https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source:
> The go generate tool also sets the build tag "generate" so that files may be examined by go generate b…
@cuonglm Thanks for letting us know, but I don't see what aspect of this needs a freeze exception and why. This seems to be a recently reported bug.
Please see https://golang.org/s/release#freeze-…
@FiloSottile I'm unsure this needs one, and we're already tracking this since it has a release-blocker label in the Go1.21 milestone (but thanks for flagging anyway).
Fixing a new Go 1.21 API soun…
We discussed this earlier and there was agreement the high-confidence vet coverage will almost certainly warrant doing this now, just need to sort out some of the small implementation details here.
CL 499680 made findGoogleGroupsThread wait for the fetch to complete
before starting to parse HTML. This was only so that it'd be easy to
detect if reading resp.Body fails (as opposed to parsing its …
(1 comment)
Good idea to write that down, thanks.
What you describe matches my understanding. There's no change in meaning of go.mod/go.work files, only new directory paths eventually allowed and n…
Writing down the compatibility notes for this bug fix.
There are known callers of IsDirectoryPath in x/mod itself and in cmd/go in the main repo, which is what I considered in scope below. For oth…
DO NOT SUBMIT: The ".." path (without a trailing slash) can't be used
today due to golang/go#60572. It can only be used after that bug is
fixed in all supported versions of Go. For example, if it's f…
(1 comment)
It occur whenever at least one label is removed from the issue. Typically the "telemetry" label itself (since that's the one gopherbot will add the quickest), but any other would also ge…
(1 comment)
Is it intentional to leave out the `|| gi.HasEvent("unlabeled")` condition for overriding this task, that other similar tasks have? (Okay if that's your intent, just confirming.)
macOS 14 (macOS Sonoma) was announced today during WWDC23 and is described to be "Coming this fall". (https://www.apple.com/macos/sonoma-preview/)
This is the tracking issue (that can be split int…
(2 comments)
This link needs a '/pkg' prefix (`/pkg/os/#Getenv`) to avoid being 404.
If you'd like, this link can point directly to the release policy section on that page by adding a `#policy` fra…
I spotted this issue only recently, and wanted to follow up here. Also CC @golang/release. (I realize it's from 2018 so it might not be relevant to you or not something you can easily verify now.)
…
Closing because this PR has been merged via [CL 500656](https://go.dev/cl/500656) as commit ff98eae2a0cc3ace67e30e3e41908d279a7c13cb.
(Normally `gerritbot` does this, but sometimes it needs help d…
(2 comments)
This subject accurately describes patch set 1, but now needs updating.
A real datastore.Get returns datastore.ErrInvalidKey when given a nil key, so this fake should too.
Also, it see…
(1 comment)
```suggestion
// If f returns nil, the transaction attempts to commit and then return nil.
```
I think return (not returns) was right.
That is, the transaction does an atomic attempt …
Tested with the most recent Go tip version:
```
$ go version
go version devel go1.21-6260049fa2 Fri Jun 2 19:54:05 2023 +0000 darwin/arm64
$ cd $(mktemp -d) && go mod init example && cat <<EOF …
An error text suggests a directory path needs to start with ./ or ../
if it's a relative path, but in reality relative paths with .\ and ..\
prefix (such as those that are used on Windows) are also a…
In https://github.com/golang/go/issues/51448#issuecomment-1057713459, Bryan wrote:
> The argument `.` should trigger `modfile.IsDirectoryPath` here:
https://cs.opensource.google/go/go/+/ce427cf96…
As spotted in CL 499981, 3 out of 51 of the api/next/*.txt files
ended up with a blank line at the end. It's possible it would've
been more if human reviewers didn't catch them.
Since there's no for…
(1 comment)
(nit) FWIW it will continue to fail with "package golang.org/x/tools/go/pointer is not a main package". 😅 Of course removing replace directives before tagging+deleting is definitely w…
(1 comment)
While here, please delete this magic comment too. It's intended for automated tagging, and there's no automated tagging for modules holding deleted packages.
The experiment has graduated to default behavior in crrev.com/c/4558786
and can be removed here. (This undoes the change applied in CL 497695.)
For golang/go#59990.
Looking for a Google Groups thread means fetching from a remote server
over an internet connection, so impermanent failures are guaranteed to
happen some of the time. relui is already well-equipped t…
The new gomote SSH implementation doesn't rely on knowing the user's
GitHub account and its public SSH keys, there's no more need for the
GitHubOfGomoteUser function and its maintenance.
For golang/…
This has been flipped on and running in LUCI since last week. Some examples:
- https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-amd64/b8779655559291129265/overview - a successful build …
@thediveo I think what you're pointing to is an example of a function call whose return value is being assigned to the blank identifier. That shouldn't and wouldn't change behavior. The original issu…
[CL 10492](https://go.dev/cl/10492) in 2015 applied a change to have all.bash skip testing Go packages in the standard library (those matched by `go list std cmd`) that have no tests. Sadly, the comm…
@gopherbot Please consider this as a backport to Go 1.20 and 1.19.
This is a documentation-only fix to document a Go 1.19 feature added to `go test` and `go generate`. It'll be easier for users wh…
`watchdogTimer` is currently initialized to a timer that cancels the TaskContext's context when it times out:
```Go
func runTask(ctx context.Context, workflowID uuid.UUID, listener Listener, stat…
Advisory TryBots are causing much less friction compared to previously now that #57725 has been resolved. Filing this for some followup improvements that we can apply to how they handle timeouts.
…
https://build.golang.org/log/a1da7514866e849d7af09fd7ff1af7fc8d11030f looks like the first build using a builder image rebuilt with wasmtime v9.0.1 ([CL 496920](https://go.dev/cl/496920)).
It made…
Thanks for filing this. It's unfortunate that #57001 only gained the release-blocker label late in the cycle and we couldn't do more to help with the timeline for a significant feature planned for Go…
The proposal was approved just today and this just missed the freeze by half an hour but is otherwise ready, so I can trivially approve this. Please feel free to go ahead with the CL, and thanks for …
That CL has some comments that need to be resolved. It also says "Updates #59719"—is there more that needs to happen for that proposal or is that CL fine to submit now and leave further changes for…
Also copying @bradfitz's rationale from #60420:
> I forgot to submit https://go-review.googlesource.com/c/go/+/486715 this morning after getting @bcmills's approval. I was going to spend the eveni…
This got closed but the proposal is still in progress. Reopening so it can get to a resolution (and if it doesn't make it to accepted state, to revert the CL).
This got closed but the proposal is still in progress. Reopening so it can get to a resolution (and if it doesn't make it to accepted state, to revert the CL).
This PR is currently targeting the "release-branch.go1.17" branch. Go 1.17 is no longer supported per the [release policy](https://go.dev/doc/devel/release#policy) and so we don't use the `release-br…
This PR is currently targeting the "release-branch.go1.17" branch. Go 1.17 is no longer supported per the [release policy](https://go.dev/doc/devel/release#policy) and so we don't use the `release-br…
It's worth taking into account that Gerrit itself has fairly thorough documentation (e.g., see https://gerrit-review.googlesource.com/Documentation/index.html).
For example, https://gerrit-review.…
Everything captured in https://github.com/golang/go/issues/57631#issuecomment-1480227646 looks good to me.
I found a few more things, but they're very minor.
In [`maintapi.parseInternalBranchVers…
> not sure why gopherbot didn't close the issue.
The one time it _doesn't_ fight humans is the time it would've been helpful. [😅](https://cs.opensource.google/go/x/build/+/refs/heads/master:cmd…
Is this resolved by the "Origin" JSON key added to the output of `go list -json -m` (and `go mod download -json`) in Go 1.19? (See #53644, [CL 411397](https://go.dev/cl/411397), https://pkg.go.dev/cm…