Yesterday
dmitshur starred in github.com/koesie10/webauthn4h
dmitshur starred in github.com/duo-labs/webauthn4h
@mroc170 I know little about Rails, so I'm not a good person to ask. In general, I suggest using a medium like Stack Overflow or similar to ask questions. The interface of an issue tracker is better…
(1 comment) This email should be first in the list if you want it to be your Gerrit account.
I plan to move the Release History page (along with two other pages in https://golang.org/doc/devel/ with pre-Go 1 history) from the main Go repository to the x/website repository. This is a subset o…
(1 comment) Is this CL waiting on anything to be submitted? This blank line doesn't appear to be consistent with other files. Was it added intentionally?
(3 comments) Not seeing issues. Minor comments. Not a big deal, but I liked the previous style better, since it keeps the main code path less indented (https://golang.org/s/style#indent-error-flow)…
This Week
dmitshur commented on doc: filename conventions1d
To my knowledge, there isn't a documented convention for .go file names (other than meaningful things like _test.go, leading . or _, trailing _goos_goarch, etc.) anywhere. I've checked https://golang…
> @dmitshur apparent gopherbot failure... Yeah, the missing keyword was `please`, as @toothrot has successfully demonstrated above. It works even if you're extra polite like I was in https://github.…
(1 comment) Friendly ping on this question, Russ.
(2 comments) Is it possible for MirroredToGitHub to be true yet GitHubRepo to return an empty string? In what scenario would that happen? Is it useful to have this case? Edit: The panic in add sugg…
@raphael For full module support, you should use [pkg.go.dev](https://pkg.go.dev/goa.design/goa/v3). See https://github.com/golang/go/issues/33654#issuecomment-553496652 for more information about it.
Last Week
dmitshur commented on testing: add TB.TempDir() string5d
> So that's another line. I think it’s a constant 2 extra lines, I don’t see why a third extra line would be required. ```Go foo(filepath.Join(t.TempDir(), "foo")) bar(filepath.Join(t.TempDir()…
dmitshur commented on testing: add TB.TempDir() string5d
Since I’m not seeing it mentioned, have you considered a more verbose and explicit API variation that returns a cleanup closure? Somewhat inspired by `context.WithCancel`, it may look like: ```Go…
@gopherbot, could you please be so kind as to open two backport issues: one for Go 1.13 and another for Go 1.12. This is a documentation fix.
I went through the release history a bit. We started consistently using the CherryPickCandidate and CherryPickApproved labels with Go 1.9.1 and later. They weren't used before Go 1.9. I fixed up some…
@gopherbot's profile now has a link to its wiki page (https://golang.org/wiki/gopherbot). I'll close this because everything that was mentioned here seems done, but feel free to reopen or make a n…
This was backported to 1.10 release branch via [CL 121075](https://golang.org/cl/121075).
I agree the current link leads to a page that is hard to read. We shouldn't remove issues from that milestone, because then it will be harder to track history and know what was considered but not acc…
This issue is the same as #35828.
I don’t see any issues. One minor inline comment. This change doesn’t look intentional. I suspect it came about from the earlier version of this PR where the scrape/go.mod file was removed, a…
I agree with Will’s comments. We must not remove the scrape/go.mod file as that would change module boundaries. It’s a good idea to keep this PR focused on just one module; updating the scrape mo…
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl1w
d42048ed14fdc83bd0e48f4b2a5e13c593e88cb6link to CoreGraphics framework
11308bd612348edeca0d8fddca07bc5a4dfbb35cexample/movingtriangle/internal/{ns,ca}: rename to appkit, coreanim
9364696d8c28dc804dcd7e099f0b7c6cb58ac824example/movingtriangle: remove unsafe.Unsafe conversion
> may have implications for client code that parses error messages /cc @neild who worked on defining an internal policy related to that, which can be helpful when making decisions about changing err…
> could be added in the Modules section > > Go Modules: v2 and Beyond That has already been done in [CL 209038](https://golang.org/cl/209038), and you can see it on [tip.golang.org](https://tip.gola…
/cc @griesemer per [owners](https://dev.golang.org/owners).
/cc @bradfitz per [owners](https://dev.golang.org/owners).
/cc @jayconrod @jadekler
/cc @jayconrod @andybons
/cc @bcmills @jayconrod
/cc @bcmills @jayconrod
/cc @aclements
/cc @jayconrod @bcmills This may be related to `cmd/go` or `cmd/cover`, but I'm not sure who owns the cover cool. I don't see `cmd/cover` mentioned in #24661. We should add it there so it's easier…
@andyTsing Why close this issue? We'd like to improve the go command to report a better error message in this rare situation. Having this issue open is how we can track that work. Do you mind re-open…
Closing because #69 has been resolved. Please let me know if there are any issues. Thanks for the work here.
dmitshur deleted branch in github.com/gopherjs/gopherjs.github.io1w
update-latest
dmitshur pushed to master in github.com/gopherjs/gopherjs.github.io1w
bc5ba08279ae8de6dac3c66a7a6e251d36d3e774playground: regenerate with GopherJS 1.12-2 and Go 1.12.13
0aede165a0e2bf1c24d34d06c1d02dedd9dc53e1playground/internal/imports: add syscall/js identifiers
353fe544cde2f6586a950e43bab2e866e8a4f3a0playground: make update.sh work when GOROOT is user-writable
83a7ce439b42a9ec52baa636b94d8b33c6ce496fplayground: add support for syscall/js package
Thanks for the explanation. > I do not yet see why syscall/js should emulate autoboxing. I agree, I don't think that would be a good change. It should just be possible to use JavaScript's `t…
The playground doesn't really need much review (and we don't have much reviewer time available due to https://github.com/gopherjs/gopherjs/issues/894), it just needs to continue to work. I've tested …
Also add support for `syscall/js` and start using it in the initial snippet. Make various modernizations/improvements to the `update.sh` script. Fixes #69. /cc @hajimehoshi @slimsag (See …
dmitshur created branch in github.com/gopherjs/gopherjs.github.io1w
update-latest
Do you have a way of checking whether performance is impacted doing this on each `toLower` call, compared to: ```Go func toLower(s string) string { return toLowerCase.Call("call", js.ValueOf…
About the "syscall/js: call of Value.Call on string" error, I found it happens when using `syscall/js` package with GopherJS but not when using `github.com/gopherjs/gopherjs/js` package. So it's not …
With GopherJS, it was possible to call the [`String.prototype.toLowerCase`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toLowerCase) method on a `String`: …
Earlier
I tried the following quick change to see if it would be sufficient to solve the problem: ```diff diff --git a/dom.go b/dom.go index 0eb000e..164a5a3 100644 --- a/dom.go +++ b/dom.go @@ -2,6 …
I believe I'm running into an issue with `nodeName` case sensitivity here (see https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeName and https://johnresig.com/blog/nodename-case-sensitivity/…
Given that `home` implements a [custom git server and module server](https://pkg.go.dev/github.com/shurcooL/home/internal/code), it is both helpful and a novel opportunity to perform some server-side…
Friendly ping on this issue to indicate I'm still interested in this (with full understanding this is open source, so there are no expectations of work). This is blocking me from making updates to…
dmitshur pushed to master in github.com/shurcooL/home1w
ebebcaa7af0b3ca608f7b431ab797db35828c790move to URL-based sign in flow, support GitHub profile URLs
aba3cf9e079c2885a0b12eba1eb5343c2dc5e61binclude entire URL, not just path in warning
Currently, it is possibly to sign in to `home` only via GitHub. While this has worked well and provides a simple user experience, it has some downsides: - requires having a GitHub account - doesn…
dmitshur starred in github.com/gbbr/flippo1w
We probably wouldn't, but given we just released v3.3/glfw a few days ago, there's some small chance we will learn that some part of the new API has a problem and will need to be fixed.
We should investigate why gerritbot didn't close a PR that was imported into Gerrit as a CL and submitted. - PR #35751 - imported as [CL 208318](https://golang.org/cl/208318) See https://…
A small suggestion is to start with v0.1.0-alpha first, before getting to v1.0.0. We can always get to v1 after some time passes. The advantage of v0 is that it still permits breaking changes and giv…
I've never attempted to apply semver on top of another project with semver, so it's unexplored territory for me. I don't have objections to trying it, and going with the proposed scheme seems reasona…
dmitshur pushed to master in github.com/shurcooL/githubv42w
8f68eb5628d0dbb03412bd231eafafb208d0c185regenerate for schema changes by 2019-11-26
Fixed in c476f0c1d64e4255a76ab4467fd4ad6553475065.
dmitshur pushed to master in github.com/timetoplatypus/githubv42w
c476f0c1d64e4255a76ab4467fd4ad6553475065remove spurious blank lines
This blank line looks like it shouldn't be there.
This is the `golang.org/go-gl/glfw/v3.3/glfw` tracking bug for upstream GLFW issue glfw/glfw#1543. It can be reproduced with the following Go program: ```Go package main import ( "log" "ru…
/cc @ianlancetaylor @bradfitz @tklauser per [owners](https://dev.golang.org/owners).
/cc @bradfitz @ianlancetaylor per [owners](https://dev.golang.org/owners).
@cherrymui Thanks. The darwin-arm64-corellium builder was passing for many commits between 01f15b62b3d91c0f7fed54eedeee4123eb04b533 and 67f0f83216930e053441500e2b28c3fa2b667581 (CL 208818). Do you kn…
/cc @bcmills @jayconrod per [owners](https://dev.golang.org/owners).
> So it seems as though my internal VCS is actually "Bitbucket Server v5.16.10", I'm not very familiar with the Bitbucket Server, but does it have any documentation for how to access private Go re…
/cc @bcmills @jayconrod per [owners](https://dev.golang.org/owners).
/cc @alandonovan @josharian @mvdan per [owners](https://dev.golang.org/owners).
Approving because this is a serious problem without an obvious workaround, and the fix is localized.
@laboger Could you also please provide a rationale here to backport this fix, as described at https://golang.org/wiki/MinorReleases?
@laboger Could you please provide a rationale to backport this fix, as described at https://golang.org/wiki/MinorReleases?
@laboger [CL 203817](https://golang.org/cl/203817) said "Updates #35207" rather than Fixes. Is there more to do here?
/cc @aclements @mknyszek (Please let me know if there are other people who are better to ping about an issue like this.)
Strangely, it failed even worse on the next commit (https://build.golang.org/log/186ffe8d4a32f24c719cb49eddf6e37e73957239), but has been passing since then.
I just noticed I was looking at the 3.2 docs, not 3.3 as I intended. The “ If no windows exist, this function returns immediately. For synchronization of threads in applications that do not create …
Looks like the CL above helped; we got our first near-pass of x/tools on `windows-amd64-longtest` builder in [this recent run](https://build.golang.org/log/c3491c162a230b13f18d84c848aa05fcbda5c6fd). …
From a [recent run](https://build.golang.org/log/c3491c162a230b13f18d84c848aa05fcbda5c6fd) of the `windows-amd64-longtest` builder (after increasing its memory in [CL 208500](https://golang.org/cl/20…