Activity
Today
dmitshur reviewed +2 on golang.org/x/crypto/openpgp: delete module1h
Thanks.
Carved out module now has a release version.
```
$ go mod init test
go: creating new go.mod: module test
$ go get golang.org/x/crypto/openpgp@latest
go: downloading golang.org/x/crypto v0.5…dmitshur commented on golang.org/x/crypto/openpgp: tidy module1h
Thanks.dmitshur commented on golang.org/x/review/git-codereview: add -ready flag1h
Thanks.dmitshur reviewed +2 on golang.org/x/crypto/openpgp: tidy module2h
Thanks. This should be the version that can be tagged as v0.1.0-deprecated.dmitshur opened a change golang.org/x/build/internal/releasetargets: update list for Go 1.283h
The release freeze for Go 1.28 is a bit over a month away.
Do a preliminary update of the release target list.
So far its diff compared to that of Go 1.27 is as follows:
- No changes.
We'll revisit…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: add 2026 Go Developer Survey banner3h
Thanks. I left some suggestions, mostly minor and optional.
Consider filing a tracking issue for this and adding "For golang/go#nnn." In case there are some issues with this functionality, having a …dmitshur reviewed +2 on spec: fix EBNF for composite literals3h
Thanks.dmitshur reviewed +2 on golang.org/x/crypto/openpgp: carve out openpgp as a module3h
Thanks.
Unfortunately, it seems very hard¹ to avoid breaking trybots for everyone in x/crypto with this CL, so it'd be good to be able to update and submit CL 848205 very soon after this one. I'll …dmitshur reviewed +2 on golang.org/x/crypto/openpgp: make carved out openpgp module fetchable3h
Thanks.
Leaving an unresolved comment for actually doing this.dmitshur commented on golang.org/x/exp/sumdb: delete4h
Yeah, I left a comment in CL 838545 about it. Adding TryBot-Bypass here since everything else passes.dmitshur commented on spec: document composite literals with omitted types4h
(1 comment)
Note that golang.org/x/exp/ebnflint.TestSpec [reports a finding](https://ci.chromium.org/ui/p/golang/builders/ci/x_exp-gotip-linux-amd64/b8668444157200869681/test-results?q=ExactID%3A…dmitshur reviewed +2 on golang.org/x/exp/sumdb: delete4h
Since this is x/exp and this code already graduated to another x/ repo, this deletion seems fine without needing an accepted proposal. Thanks.
Indeed.dmitshur reviewed +2 on golang.org/x/mod/sumdb/tlog: use recorded responses in TestCertificateTransparency4h
Thanks.
Leaving a general thought that this makes me think of, already resolved since it's not specific to this CL.
I wonder if at some point it would make sense to start defaulting to embedding te…dmitshur commented on golang.org/x/mod/sumdb/tlog: TestCertificateTransparency failures5h
There are new failures today that look like:
```
=== RUN TestCertificateTransparency
http://ct.googleapis.com/logs/argon2020/ct/v1/get-sth
<html><head><meta http-equiv="content-type" content="tex…Yesterday
dmitshur reviewed +2 on golang.org/x/crypto/openpgp: delete module22h
Thanks.
Adding a hold for a tagged version of the carved out module being available. That is, something like the following should be made to work before proceeding with the deletion:
```
go get gol…dmitshur commented on golang.org/x/crypto/openpgp: carve out openpgp as a module22h
(1 comment)
Right now there are only two CLs in this stack. This one carves out the module, but it still has a replace directive. The second CL deletes the module.
But we want a step in between tha…dmitshur opened a change cmd/internal/moddeps: [release-branch.go1.26] restore tests1d
By now PRIVATE-track security fixes involving a vendored/bundled package
have been released, and these tests can be made to run again as before.
[git-generate]
updatestd -goroot=$(pwd) -branch=inter…dmitshur commented on encoding/json: UnsupportedValueError.Value is invalid for cycles in Go 1.271d
CC @dsnet, @bradfitz, @mvdan.dmitshur opened an issue all: end support for macOS 13 in Go 1.291d
### Proposal Details
Apple continues a yearly major macOS release cadence, and the last accepted proposal to drop the very oldest macOS version was #75836, a year ago. Since neither the macOS nor Go…dmitshur reviewed +2 on golang.org/x/build/...: improve documentation for security releasing1d
(1 comment)
Thanks for clarifying this.dmitshur commented on golang.org/x/build/internal/task: make 'Publish changes' more fault tolerant1d
Thanks. See inline comment.
I think this change was a good way to unblock today's release from proceeding, but maybe we don't need it longer term? After fixing the submit type, presumably there shou…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lint trusted DeploymentMap CLs against their manifest1d
Thanks.dmitshur commented on golang.org/x/build/internal/relui: lint manually deployed CL descriptions1d
(1 comment)
I just noticed this TODO - perhaps the code below addresses it.dmitshur reviewed +2 on golang.org/x/build/internal/task: ignore PUBLIC track issues during preflight checks1d
Thanks.dmitshur commented on net/http/internal/http2: avoid excessive work on initial window changes1d
The failing gotip-linux-amd64-boringcrypto trybot failed in the runtime package with "fatal error: gp.xRegState.p != nil on async preempt". This CL is only touching net/http, so it doesn't seem relat…dmitshur opened a change net/http: limit the size of range headers parsed in ServeContent1d
Set a limit on the number of ranges in a Range header,
avoiding excessive allocations/CPU when parsing a header
containing a large number of small ranges.
The limit is controlled by GODEBUG=httpserv…dmitshur reviewed +2 on golang.org/x/build/internal/relui: use time.Tick directly1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: improve documentation for security releasing1d
Thanks.
Asking a few questions to improve my understanding of what this refers to.
What is an example of confusion? Is an example of that when a security fix cannot be automatically cherry-picked f…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lint manually deployed CL descriptions1d
Thanks.dmitshur reviewed +2 on golang.org/x/website/internal/gitfs: require caller to pass http.Client1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: make HTTPClient required1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: add documentation, better nil semantics1d
Thanks.
This part of the method documentation is being made obsolete by the implementation change below.dmitshur commented on golang.org/x/website/internal/history: document Go 1.27.2 and Go 1.26.91d
Thanks.dmitshur opened a change golang.org/x/website/internal/history: document Go 1.27.2 and Go 1.26.91d
dmitshur commented on cmd/go: go get go can write a language version as the toolchain line1d
CC @matloob.This Week
dmitshur commented on net/http: concurrent response body Read and Close can deadlock with automatic draining in Go 1.27 [1.27 backport]2d
Moved Critical label to the upstream issue.dmitshur commented on net/http: readLoop reads Response.ContentLength after Body.Close returns [1.27 backport]2d
Moved Critical label to the upstream issue.dmitshur commented on net/http: Response.Body.Close returns the earlier Read error after a non-EOF Read failure [1.27 backport]2d
Moved Critical label to the upstream issue.dmitshur commented on net/http: Response.Trailer race due to response body draining [1.27 backport]2d
Moved Critical label to the upstream issue.dmitshur reviewed +2 on golang.org/x/build/main.star: switch gotip-linux-amd64_n4dh32 to Debian 11, in worker pool2d
Thanks.dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder2d
Thanks.
Note for next time, since this isn't the main repo, this generally needs to include the 'golang/go' prefix.
```suggestion
For golang/go#82017
```
It's not a big deal this time, and the lin…dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder2d
Thanks.
You'd probably want to set a known issue for this experimental builder type to start out with, right?
The commit message says the intent is to add a postsubmit builder, but it's currently b…dmitshur commented on cmd/compile: regalloc reloads a value from a narrower phi's stack slot, losing its upper bits3d
From triage meeting, this is likely not a regalloc bug but elsewhere. @cherrymui said that @randall77 had a suggested approach for this might work for this.dmitshur commented on cmd/dist: `{CC,CXX}_FOR_TARGET` is incorrectly embedded into output when cross-compiling3d
CC @golang/compiler.dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.27 backport]3d
We discussed this in a release meeting. Approved the already-created backport CL.dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.26 backport]3d
We discussed this in a release meeting. Approved the already-created backport CL.dmitshur commented on cmd/compile: generic shift-by-constant canonicalization gives Const64 the wrong type [1.26 backport]3d
Approving the backport to Go 1.26 for CL 795240 and CL 837245.dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.27 backport]3d
The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.26 backport]3d
The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.dmitshur commented on cmd/compile: loong64 spills a byte-sized inlined result with an 8-byte MOVD, clobbering adjacent stack slots [1.26 backport]3d
@abner-chenc Can you please include a backport rationale for this request. Also, is this a problem for Go 1.26 only, or is 1.27 also affected?dmitshur commented on crypto/tls: IPv4 public names are allowed in ECH3d
CC @golang/security, @cpu.dmitshur commented on mime: avoid panicking when reading globs2 files3d
CC @neild.dmitshur commented on net: maxListenerBacklog panics on empty somaxconn input3d
CC @ianlancetaylor, @neild, @nicholashusin.dmitshur commented on cmd/compile: hoist slice allocations out of a loop3d
CC @golang/compiler.dmitshur closed an issue : x/pkgsite:3d
Empty issue.dmitshur commented on : x/pkgsite:3d
Empty issue.dmitshur commented on cmd/compile: regalloc reloads a value from a narrower phi's stack slot, losing its upper bits3d
CC @golang/compile.dmitshur commented on cmd/compile: specialize instantiations of "certain" generic functions3d
CC @golang/compile.dmitshur commented on cmd/compile: linker panic "R_USEIFACE ... references type:.eqfunc... which is not a type or itab" with reflect.TypeFor[T]().Comparable()3d
CC @golang/compile.dmitshur commented on cmd/compile: CSE of OpLocalAddr across calls lets GC free objects still reachable from a local array3d
CC @golang/compile.dmitshur commented on runtime: g is allocated from the 480-byte size class on amd64, arm64 and loong643d
CC @golang/runtime.dmitshur commented on runtime: bound overtakes of lock2 sleepers3d
CC @golang/runtime.dmitshur commented on runtime: allocation profile is stale when collected multiple times before GC happens3d
CC @golang/runtime.dmitshur commented on runtime: random memory allocation errors on AIX3d
CC @golang/aix, @golang/runtime.dmitshur commented on net/http: HTTP/2 server re-arms a connection's idle timer after its serve loop ends, retaining the connection for IdleTimeout (and the client read loop never stops its health-check timer)3d
CC @neild, @nicholashusin.dmitshur commented on math: Exp returns +Inf for finite results on amd64 (709.436 <= x < 709.783)3d
CC @griesemer, @rsc, @thatnealpatel.dmitshur commented on hash/maphash: WriteComparable loses input on a zero-value Hash3d
CC @randall77.dmitshur commented on runtime: windows: a fault while printing an exception hangs the process instead of exiting3d
CC @golang/windows, @golang/runtime.dmitshur commented on runtime: windows/386: suspending a thread inside NtContinue crashes recovery from a fault3d
CC @golang/windows, @golang/runtime.dmitshur commented on golang.org/x/sys/windows: MemoryBasicInformation has the wrong layout on windows/3863d
CC @golang/windows.dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: stditerators produces non-compiling code when the loop does not use the element3d
CC @madelinekalil, @adonovan.dmitshur commented on golang.org/x/crypto/ssh: OpenChannel can block forever when the connection dies concurrently3d
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/MichaelWittgreffe3d
CC @golang/pkgsite.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/arsham6ix/Xray-core3d
CC @golang/pkgsite.dmitshur commented on golang.org/x/text/language: Parse accepts a tag that repeats an extension singleton3d
CC @mpvl.dmitshur commented on golang.org/x/website/tour: add four community translations and update four URLs3d
CC @golang/tools-team, @ALTree.dmitshur commented on golang.org/x/vuln: govulncheck -format=sarif generates invalid SARIF with duplicate stacks, violating SARIF v2.1.03d
CC @golang/vulndb.dmitshur commented on image/draw: finding the closest palette color is slow for large palettes3d
CC @nigeltao.dmitshur commented on golang.org/x/build/cmd/relui: unexplained instance of a workflow stall3d
During this month's release workflow, we saw relui get restarted due to OOM. It's quite possible that enabling the race detector contributed to more memory usage, enough to exceed its current 8 GB al…dmitshur commented on runtime: native SEH unwinding faults in mcall on windows/amd64 since Go 1.254d
CC @golang/runtime, @golang/windows.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/sebastienrousseau/scout, scout-mcp, scout-reporting, scout-action4d
CC @golang/pkgsite.dmitshur commented on encoding/xml: Marshal and EncodeToken emit ill-formed element/attribute names with nil error4d
CC @rsc.dmitshur commented on go/types: types.Error.go116end end position derived from placeholder Ident.Name is garbage4d
CC @griesemer, @mrkfrmn.dmitshur commented on go/types: Interface.Method and ExplicitMethod are not ordered by Id, contra docs4d
CC @griesemer, @mrkfrmn.dmitshur commented on net/http: FileServer issues incorrect redirect to regular file given multiple trailing slashes4d
CC @neild, @nicholashusin.dmitshur closed an issue : Add minia2a — x402 marketplace for agent monetization via API4d
dmitshur commented on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder4d
(2 comments)
> If we can use 12 for the default builders I think that would be better.
We're already using 12 for linux/arm64 (CL 622318), but still 11 for linux/amd64. Changing the version comes w…dmitshur commented on golang.org/x/build: evaluate switching default builders to a newer architecture4d
CC @golang/release.dmitshur reviewed +2 on golang.org/x/build/internal/relui: make poll-wait for submit less spammy4d
Thanks.
(nit) Given a not very self-descriptive type like `chan string`, 'ch' is not a very descriptive variable name for it. Since it's being used to log notable state changes, consider naming it s…dmitshur commented on security: fix CVE-2026-568614d
Removing release-blocker for clarity. Since this issue was moved to the Unreleased milestone, that label has no effect. It can be re-added if this needs to block a specific release.dmitshur commented on net/http: Transport reuses cached unencrypted HTTP/2 connection for https:// request4d
Removing release-blocker for clarity. Since this issue was moved to the Unreleased milestone, that label has no effect. It can be re-added if this needs to block a specific release.dmitshur commented on cmd/go: go vet -fix does not apply fixes in std packages, and -tags turns unsafeptr back on4d
CC @adonovan, @matloob.dmitshur reviewed +2 on golang.org/x/build/internal/relui: transition WIP CLs to Ready4d
Thanks.
https://go.dev/doc/comment suggests "Every exported (capitalized) name should have a doc comment."
I wonder if it could work out slightly better to do the mark ready step as soon as the con…dmitshur reviewed +2 on golang.org/x/build/gerrit: fix incorrect return schema for SetCommitMessage4d
Thanks.
It's kinda surprising to see that given it's [not documented](https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-message) in the Gerrit API REST docs, and [this](…dmitshur reviewed +2 on golang.org/x/crypto/acme: prefer test log helpers in test contexts4d
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: don't require credentials when debugging one build or script4d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: do not fail on cherry-pick merge conflicts4d
Thanks.
What is the effect and motivation of having a sleep here and on line 961 (above)? They're in the same goroutine, so as far as I can tell they have no effect inside synctest.Test. If they hav…dmitshur reviewed +2 on golang.org/x/build/internal/task: add observability to MoveAndRebase4d
Thanks.
By this line, ci has been assigned to movedCI. Will its Branch field be the new branch by then? If so, perhaps something like:
```suggestion
prevBranch := ci.Branch
ci = &movedCI
ctx.…Last Week
dmitshur commented on golang.org/x/build/relmeta: add Symbols to SecurityPatch1w
Another tool to consider is cmp.Diff, since its output on failure can be easier to read.dmitshur reviewed +2 on golang.org/x/build/relmeta: add Symbols to SecurityPatch1w
Thanks.
I'll note that it seems a bit unexpected that DeploymentMap would have this effect on Symbols, where an empty map causes p.Symbols to be used as is, whereas a non-empty map causes some filte…