Today
shurcooL commented on test: flaky snapshot test in github.com/upspin/upspin8h
Another local failure I saw. It looks like it happened due to being out of memory.
https://gist.github.com/anonymous/e7db6b8c1205f594af9bc73adac69270
This was on a Linux VM with 2 GB.
Travis…
Another local failure I saw. It looks like it happened due to being out of memory.
https://gist.github.com/anonymous/e7db6b8c1205f594af9bc73adac69270
This was on a Linux VM with 2 GB.
Travis…shurcooL commented on test: flaky snapshot test in github.com/upspin/upspin9hI've looked into this a bit, and wanted to share some small findings.
I tried to reproduce locally, with very little luck on macOS and Linux. The tests kept passing pretty much every time (one exc…
I've looked into this a bit, and wanted to share some small findings.
I tried to reproduce locally, with very little luck on macOS and Linux. The tests kept passing pretty much every time (one exc…Yesterday
shurcooL commented on x/build/cmd/coordinator: use maintn… in github.com/golang/go16h> It runs every 60 minutes
60 seconds, yes?
> It runs every 60 minutes
60 seconds, yes?shurcooL commented on Wrongly reports local revisions are… in github.com/shurcooL/Go-Package-Store16hI think I found a way to use [`git for-each-ref`](https://www.kernel.org/pub/software/scm/git/docs/git-for-each-ref.html) command, which is low-level plumbing command. 🎉
Can you give https://gi…
I think I found a way to use [`git for-each-ref`](https://www.kernel.org/pub/software/scm/git/docs/git-for-each-ref.html) command, which is low-level plumbing command. 🎉
Can you give https://gi…shurcooL commented on Wrongly reports local revisions are… in github.com/shurcooL/Go-Package-Store18hI know, I always try to use those (low-level/plumbing) types of commands when possible, but I didn't find one so far, so I had to make do. If/when I find a viable replacement, I'll gladly switch to i…
I know, I always try to use those (low-level/plumbing) types of commands when possible, but I didn't find one so far, so I had to make do. If/when I find a viable replacement, I'll gladly switch to i…shurcooL commented on Wrongly reports local revisions are… in github.com/shurcooL/Go-Package-Store18hThanks a lot, that's very helpful and I can see where the issue is right away (hint, it's [here](https://github.com/shurcooL/vcsstate/blob/4a1c1cc2526e60097c9ecd36600ba93c372e6e7f/git28.go#L113-L114)…
Thanks a lot, that's very helpful and I can see where the issue is right away (hint, it's [here](https://github.com/shurcooL/vcsstate/blob/4a1c1cc2526e60097c9ecd36600ba93c372e6e7f/git28.go#L113-L114)…shurcooL commented on Wrongly reports local revisions are… in github.com/shurcooL/Go-Package-Store19hNot really able to reproduce this as easily as I thought.
Can you `cd $GOPATH/src/golang.org/x/sys` and tell me the output of running this command there:
```
git branch --remotes --contains fb…
Not really able to reproduce this as easily as I thought.
Can you `cd $GOPATH/src/golang.org/x/sys` and tell me the output of running this command there:
```
git branch --remotes --contains fb…shurcooL commented on Wrongly reports local revisions are… in github.com/shurcooL/Go-Package-Store1dThanks. I'll try to reproduce it and work on a fix.
Thanks. I'll try to reproduce it and work on a fix.shurcooL commented on Wrongly reports local revisions are… in github.com/shurcooL/Go-Package-Store1dI also highly suspect the issue is that I'm not running `git remote update` (or equivalent) before I call `repo.VCS.RemoteContains`.
Can you try to manually run `git remote update` in one of the r…
I also highly suspect the issue is that I'm not running `git remote update` (or equivalent) before I call `repo.VCS.RemoteContains`.
Can you try to manually run `git remote update` in one of the r…shurcooL commented on Wrongly reports local revisions are… in github.com/shurcooL/Go-Package-Store1dThanks for reporting. I highly suspect this is a bug in a recent change I did to detect when branches have diverged in f0f8894a76cd8c20b23d054f167e82226907d138.
To confirm, which version of Go Pac…
Thanks for reporting. I highly suspect this is a bug in a recent change I did to detect when branches have diverged in f0f8894a76cd8c20b23d054f167e82226907d138.
To confirm, which version of Go Pac…shurcooL commented on Installing with the tip version of … in github.com/gopherjs/gopherjs1dThat's because the `master` branch of GopherJS compiler requires Go 1.8, and tip contains a beta version of Go 1.9.
There is a `go1.9` branch, which is a work in progress to add support for Go 1.9…
That's because the `master` branch of GopherJS compiler requires Go 1.8, and tip contains a beta version of Go 1.9.
There is a `go1.9` branch, which is a work in progress to add support for Go 1.9…shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs1dAll tests are passing! ✅ 🎉
There are known TODOs in the PR that can be looked at next. There are some things that require investigation. Help with that is always appreciated.
Aside from th…
All tests are passing! ✅ 🎉
There are known TODOs in the PR that can be looked at next. There are some things that require investigation. Help with that is always appreciated.
Aside from th…shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs1dI've investigated the `crypto/x509` failure. I was able to easily reproduce it on a Linux VM. Figuring the cause was easy when I used `-v` flag. There's a new Linux-only `TestEnvVars` test in Go 1.9 …
I've investigated the `crypto/x509` failure. I was able to easily reproduce it on a Linux VM. Figuring the cause was easy when I used `-v` flag. There's a new Linux-only `TestEnvVars` test in Go 1.9 …This Week
shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs1dAll tests are now passing after the 4 commits above, except the mysterious index out of range panic in `crypto/x509` that only happens in CI and not for me locally. ¯\\\_(ツ)\_/¯
I guess I'll s…
All tests are now passing after the 4 commits above, except the mysterious index out of range panic in `crypto/x509` that only happens in CI and not for me locally. ¯\\\_(ツ)\_/¯
I guess I'll s…Last Week
shurcooL commented on wasm: New package in github.com/go-interpreter/wagon2dJust wondering, but why not simply merge this PR via squash strategy? That way, it'll be merged to `master` branch as a single commit, but all the commits and the associated review comments in this P…
Just wondering, but why not simply merge this PR via squash strategy? That way, it'll be merged to `master` branch as a single commit, but all the commits and the associated review comments in this P…shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs3dStrange, `crypto/x509` tests pass for me locally:
```
$ gopherjs test --short crypto/x509
PASS
ok crypto/x509 46.429s
```
But fail in CI:
```
/home/ubuntu/gopherjs/test.035766589:1480…
Strange, `crypto/x509` tests pass for me locally:
```
$ gopherjs test --short crypto/x509
PASS
ok crypto/x509 46.429s
```
But fail in CI:
```
/home/ubuntu/gopherjs/test.035766589:1480…shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs3dI've narrowed down the `encoding/gob` test failure with `dst.$set is not a function` to a single new struct field. It's a map with key and value being arrays. For now, I've disabled the failing struc…
I've narrowed down the `encoding/gob` test failure with `dst.$set is not a function` to a single new struct field. It's a map with key and value being arrays. For now, I've disabled the failing struc…shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs3dThe [6 commits above](https://github.com/gopherjs/gopherjs/compare/71f605b028432679631270607e521234b3c47eca...c0827ba1aefbafb15fce9a55e8d6925795be90f8) implement an initial version of `sync.Map` for …
The [6 commits above](https://github.com/gopherjs/gopherjs/compare/71f605b028432679631270607e521234b3c47eca...c0827ba1aefbafb15fce9a55e8d6925795be90f8) implement an initial version of `sync.Map` for …shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs3dThe [4 commits above](https://github.com/gopherjs/gopherjs/compare/31e62b3115f7b67ce0443cb9cd99c761e42bb4ec...71f605b028432679631270607e521234b3c47eca) have fixed the issue in https://github.com/goph…
The [4 commits above](https://github.com/gopherjs/gopherjs/compare/31e62b3115f7b67ce0443cb9cd99c761e42bb4ec...71f605b028432679631270607e521234b3c47eca) have fixed the issue in https://github.com/goph…shurcooL commented on Go 1.9 support. in github.com/gopherjs/gopherjs3dA very common test failure right now is:
```
Error: runtime error: native function not implemented: os/signal.signal_enable
```
<details>
```
/home/ubuntu/gopherjs/test.449611240:4
Error…
A very common test failure right now is:
```
Error: runtime error: native function not implemented: os/signal.signal_enable
```
<details>
```
/home/ubuntu/gopherjs/test.449611240:4
Error…shurcooL commented on Add direct support for gamecontroll… in github.com/glfw/glfw4d> Also, how does this relate to the existing "joystick" API of GLFW?
I think I see it now:
```C
int glfwJoystickIsGamepad(int jid);
```
In that case, going with gamepad is more accurate an…
> Also, how does this relate to the existing "joystick" API of GLFW?
I think I see it now:
```C
int glfwJoystickIsGamepad(int jid);
```
In that case, going with gamepad is more accurate an…shurcooL commented on Add direct support for gamecontroll… in github.com/glfw/glfw4d> Also, should it be gamepad or controller?
From https://en.wikipedia.org/wiki/Game_controller:
> A game controller is a device used with games or entertainment systems to provide input to a vi…
> Also, should it be gamepad or controller?
From https://en.wikipedia.org/wiki/Game_controller:
> A game controller is a device used with games or entertainment systems to provide input to a vi…shurcooL commented on logging/v1beta3 missing in github.com/golang/gddo4dIf you want, you can/should report the issue of the GitHub mirror repo not being synced properly, but I don't know who/where to report that. Maybe one of the owners of the `google.golang.org/api/...`…
If you want, you can/should report the issue of the GitHub mirror repo not being synced properly, but I don't know who/where to report that. Maybe one of the owners of the `google.golang.org/api/...`…shurcooL commented on logging/v1beta3 missing in github.com/golang/gddo4dThere's no issue in gddo project.
godoc.org displays "Not Found" for `google.golang.org/api/logging/v1beta3` import path because that package no longer exists:
https://code.googlesource.com/goo…
There's no issue in gddo project.
godoc.org displays "Not Found" for `google.golang.org/api/logging/v1beta3` import path because that package no longer exists:
https://code.googlesource.com/goo…shurcooL commented on Can not view gddo page for a large … in github.com/golang/gddo4dResolved by 95a6c63, closing.
Resolved by 95a6c63, closing.shurcooL commented on test: flaky snapshot test in github.com/upspin/upspin5dAnother one: https://travis-ci.org/AugieBot/upspin/builds/245587250.
Another one: https://travis-ci.org/AugieBot/upspin/builds/245587250.shurcooL commented on all: some things will fail for user… in github.com/upspin/upspin5d> I think in [that case](https://github.com/upspin/upspin/blob/9a1c34f678566d3f62638c4c2b46b219aac1573c/cloud/https/https.go#L57-L58) an attempt to use `build.Import` to find package `"upspin.io/rpc"…
> I think in [that case](https://github.com/upspin/upspin/blob/9a1c34f678566d3f62638c4c2b46b219aac1573c/cloud/https/https.go#L57-L58) an attempt to use `build.Import` to find package `"upspin.io/rpc"…shurcooL commented on 
@kovetskiy You should post code review comments in the CL itself, at https://go-review.googlesource.com/c/46235/. https://github.com/golang/tools is a mirror repository, not the canonical source, so …
cd6e398dcmd/git-contrib-init: s… in github.com/golang/tools5d@kovetskiy You should post code review comments in the CL itself, at https://go-review.googlesource.com/c/46235/. https://github.com/golang/tools is a mirror repository, not the canonical source, so …shurcooL commented on GitHub GraphQL API (v4) support. in github.com/google/go-github5dI've made some progress, creating a generator for enum.go in https://github.com/shurcooL/githubql/pull/7. In doing so, I discovered a problem of many name collisions, because different enum types sha…
I've made some progress, creating a generator for enum.go in https://github.com/shurcooL/githubql/pull/7. In doing so, I discovered a problem of many name collisions, because different enum types sha…shurcooL commented on wasm: New package in github.com/go-interpreter/wagon6dReference: https://dmitri.shuralyov.com/idiomatic-go#error-variable-naming.
Reference: https://dmitri.shuralyov.com/idiomatic-go#error-variable-naming.shurcooL commented on Variables object Go type. in github.com/shurcooL/githubql1wThis decision has been made in 78a7455460db3b5f51a2ec5640d7e47326a9ef12.
Closing this issue. It exists here for posterity, so the decision and the reasoning behind it can be seen, and if needed, r…
This decision has been made in 78a7455460db3b5f51a2ec5640d7e47326a9ef12.
Closing this issue. It exists here for posterity, so the decision and the reasoning behind it can be seen, and if needed, r…shurcooL commented on v2: API Enhancement: Why is RenderN… in github.com/russross/blackfriday1w> Removing `RenderNode` also seems reasonable at the surface. @Ambrevar, @shurcooL, do you have a take on the `RenderNode` issue?
I don't have insights on this at the moment. I haven't used v2 or …
> Removing `RenderNode` also seems reasonable at the surface. @Ambrevar, @shurcooL, do you have a take on the `RenderNode` issue?
I don't have insights on this at the moment. I haven't used v2 or …shurcooL commented on Referencing a footnote multiple tim… in github.com/russross/blackfriday1w> needs to be forward ported to v2
@rtfb, did you forget to add this issue to #348?
> needs to be forward ported to v2
@rtfb, did you forget to add this issue to #348?shurcooL commented on Raw GetBlob() support in github.com/google/go-github1wThere was a related issue/PR to add support for fetching raw content of a pull request at https://github.com/google/go-github/pull/481.
I think a solution to this issue is most likely to follow th…
There was a related issue/PR to add support for fetching raw content of a pull request at https://github.com/google/go-github/pull/481.
I think a solution to this issue is most likely to follow th…shurcooL commented on Add support for durations. in github.com/dustin/go-humanize1wThis came up in the past as:
- https://github.com/dustin/go-humanize/issues/52
- https://github.com/dustin/go-humanize/issues/48
- https://github.com/dustin/go-humanize/issues/24
This came up in the past as:
- https://github.com/dustin/go-humanize/issues/52
- https://github.com/dustin/go-humanize/issues/48
- https://github.com/dustin/go-humanize/issues/24