Activity
Today
dmitshur commented on all: Go 1.14.4 release status41m
## Log
2020/06/01 13:16:41 starting
2020/06/01 13:16:41 working in /Users/dmitshur/go-releasebot-work/go1.14.4
2020/06/01 13:16:41 $ git clone https://go.googlesource.com/go /Users/dmit…dmitshur commented on all: Go 1.13.12 release status44m
## Log
2020/06/01 13:15:40 starting
2020/06/01 13:15:40 working in /Users/dmitshur/go-releasebot-work/go1.13.12
2020/06/01 13:15:40 $ git fetch origin master
2020/06/01 13:15:41 $ g…dmitshur opened a change : [release-branch.go1.14] go1.14.41h
dmitshur opened an issue all: Go 1.14.4 release status1h
Issue tracking the go1.14.4 release by releasebot.dmitshur opened a change : [release-branch.go1.13] go1.13.121h
dmitshur opened an issue all: Go 1.13.12 release status1h
Issue tracking the go1.13.12 release by releasebot.dmitshur commented on cmd/test2json: attribute output to the correct test2h
(1 comment)
Replace this with golang.org/cl/113177, it's shorter and more future proof.
Reference: https://golang.org/wiki/CommitMessage.dmitshur merged a change golang.org/x/build/cmd/releasebot: use same master commit for beta releases3h
dmitshur commented on golang.org/x/build/cmd/releasebot: add check for beta1 release blockers3h
(1 comment)
PTAL.
Fixed via CL 235937. w.Milestone will be set for all release types.dmitshur opened an issue golang.org/x/build/cmd/releasebot: add a check for beta1 release blockers3h
We can add a check to have releasebot report an error and refuse to proceed with a beta1 release, there is an issue deemed to be a release blocker for the given milestone, and is not deemed to be oka…dmitshur created branch in github.com/shurcooL/home13h
devYesterday
dmitshur deleted branch in github.com/shurcooL/home18h
devdmitshur reviewed +2 on golang.org/x/tools/cmd/godoc: support automatic vendoring1d
(4 comments)
Thanks for the ping.
I'm not seeing issues. Left minor comments.
This TODO can be resolved right now by changing it to context.Background().
I found that https://golang.org/ref/mod#v…dmitshur opened an issue golang.org/x/tools/internal/gocommand: documentation doesn't state what Run{,Piped,Raw} do and what they returns1d
There are 3 exported identifiers with the word "Run" in package [`golang.org/x/tools/internal/gocommand`](https://pkg.go.dev/golang.org/x/tools/internal/gocommand). None of them say what the identifi…Last Week
dmitshur reviewed +2 on Revert "cmd/go: group 'go get' update messages together near the end of output"1d
(1 comment)
Please also include the CL number. See https://golang.org/wiki/CommitMessage#reverts and https://golang.org/issue/30530 for context.dmitshur commented on golang.org/x/build/cmd/releasebot: add check for beta1 release blockers2d
(1 comment)
This won't quite work as-is because w.Milestone is not set for beta releases.
I'll fix that.dmitshur opened a change golang.org/x/build/cmd/releasebot: add check for beta1 release blockers2d
We now have a way of telling which release blocker issues apply to
a beta1 release, so start checking for such issues, and prevent
the release from proceeding if any of them are open.dmitshur commented on golang.org/x/build/cmd/releasebot: release step may (small chance) use a different commit than prepare step2d
I think this issue is best split into two. One for beta releases (where master branch is used), and another for all other releases (where release-branches are used).
For beta releases, there is a …dmitshur opened an issue golang.org/x/build/cmd/releasebot: a possibility of an unexpected backport CL being merged to release branch between -mode=prepare and -mode=release2d
Currently, the release process involves running `releasebot` first in prepare mode, then again in release mode.
For release types other than beta, a CL that updates the VERSION file is created in …dmitshur commented on golang.org/x/build/cmd/releasebot: include long tests in release process2d
(1 comment)
Done.dmitshur reviewed +2 on doc: update Go 1.15 release notes using relnote2d
+2 modulo previous comments and trybots passing.dmitshur commented on doc: update Go 1.15 release notes using relnote2d
(4 comments)
Nit, we generally use "doc/go1.15:" prefix for changes touching this file.
All is not a real package. Both these CLs were about removing darwin/386 port, which is already documented in…dmitshur commented on cmd/vet: update for new number formats2d
The version of the golang.org/x/tools module is specified in the src/cmd/go.mod files on the release branches for Go 1.14 and 1.13:
- https://github.com/golang/go/blob/release-branch.go1.14/src/cm…dmitshur commented on : package to get the runtime/debug.BuildInfo data 3d
Have you considered the [`rsc.io/goversion/version`](https://pkg.go.dev/rsc.io/goversion/version) package?dmitshur commented on github.com/shurcooL/githubv4: PullRequest lacks IsDraft field3d
> I'm running GHE 2.20.7
You should use the Versions dropdown to select documentation for that version:
dmitshur commented on golang.org/x/tools/go/packages: race detected during execution of various tests3d
The race in `go/types` API was fixed in #36689. /cc @matloob
I believe this issue should be resolved now. We can watch it for 2 weeks and close if nothing new happens.dmitshur commented on encoding/json: revert "reuse values when decoding map elements"3d
We've looked over this issue in a release meeting. Based on the discussion above, though it was a close call in either direction, the decision we're making is to proceed with a rollback, which is imp…dmitshur commented on cmd/compile/internal/ssa: apparent deadlock in TestNexting3d
I've closed #37050 as a duplicate of this issue. See that issue for more investigation and discussion.
I've also edited the original issue to make all the links say "linux-amd64-longtest" rather t…dmitshur closed an issue cmd/compile/internal/ssa: test TestNexting failing3d
dmitshur commented on cmd/compile/internal/ssa: test TestNexting failing3d
I've looked into how the `linux-386-longtest` builder is passing on tip, and found a similar (or duplicate) issue #37404. It's passing on tip because [CL 227587](https://golang.org/cl/227587) has add…dmitshur opened an issue cmd/compile/internal/ssa: TestNexting/dlv-dbg-hist failing on linux/386 because it tries to use dlv, which only supports linux/amd643d
(Factoring out this specific problem from #37050.)
The TestNexting/dlv-dbg-hist test is failing on `linux-386-longtest` builder on release-branch.go1.14 and release-branch.go1.13:
- https://bui…dmitshur merged a change doc/go1.15: document no language changes3d
dmitshur commented on doc/go1.15: document no language changes3d
(1 comment)
I checked at https://github.com/golang/go/commits/master/doc/go_spec.html and there haven't been changes since Jan 15, 2020. But you're right that the specification itself might still se…dmitshur opened a change doc/go1.15: document no language changes4d
There are no language changes in Go 1.15, so document that.
For #37419.dmitshur reviewed +2 on golang.org/x/tools/godoc/static: replace innerHTML with textContent4d
(2 comments)
Maybe add a sentence motivating the change¹. Like, setting innerHTML is a more heavyweight operation that supports HTML. What's being done here doesn't use HTML, so it's viable to use …dmitshur commented on golang.org/x/build: Expose more ReviewInfo fields in the Go Gerrit client4d
I'm not sure if you're already aware of it or not, so I want to point out there exists another general purpose Gerrit API client at https://pkg.go.dev/github.com/andygrunwald/go-gerrit. Its scope is …dmitshur merged a change math/big: [release-branch.go1.13] make Rat.Denom side-effect free4d
dmitshur merged a change math/big: [release-branch.go1.13] normalize unitialized denominators ASAP4d
dmitshur commented on cmd/compile/internal/ssa: test TestNexting failing4d
Upon further testing, it seems the problem was not the version of dlv, but the fact that the installed `dlv` binary was built with GOOS=linux GOARCH=amd64, and the same binary is being used for GOHOS…dmitshur commented on cmd/compile/internal/ssa: test TestNexting failing4d
I just remembered @bcmills's https://github.com/golang/go/issues/37050#issuecomment-582914424 from earlier, that seems like another good option to consider, as it would make the test depend on the en…dmitshur commented on cmd/compile/internal/ssa: test TestNexting failing4d
The version of `dlv` installed on the `linux-386-longtest` builder is:
```
root@buildlet-linux-stretch-morecpu-rn5eea3af:~# dlv version
Delve Debugger
Version: 1.2.0
Build: $Id: 068e2451004e95…dmitshur commented on cmd/compile/internal/ssa: test TestNexting failing4d
It is also happening on the release-branch.go1.13 branch. See the post-submit failure [here](https://build.golang.org/log/95c7870d8f07053a3a68e2d4e3967f46f5e38304), and the SlowBot run [here](https:/…dmitshur commented on math/big: [release-branch.go1.13] make Rat.Denom side-effect free4d
TRY=linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-race
The linux-386-longtest failure is in TestNexting/dlv-dbg-hist, which is …dmitshur commented on math/big: [release-branch.go1.13] make Rat.Denom side-effect free4d
TRY=linux-386-longtest, linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-racedmitshur merged a change encoding/json: [release-branch.go1.14] don't mangle strings in an edge case when decoding4d
dmitshur commented on golang.org/x/build/cmd/gomote: 502 Bad Gateway error4d
As @bcmills noted in https://github.com/golang/go/issues/37001#issuecomment-581691898, there's a chance this is the same issue as #37001, which has been resolved on Feb 6, 2020. /cc @toothrot
The …dmitshur merged a change encoding/json: [release-branch.go1.14] properly encode strings with ",string" again4d
dmitshur commented on encoding/json: [release-branch.go1.14] properly encode strings with ",string" again5d
TRY=linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-race
The linux-386-longtest failure is in TestNexting/dlv-dbg-hist, which is …dmitshur commented on cmd/compile/internal/ssa: test TestNexting failing5d
This seems to be happening on `linux-386-longtest` builder specifically more often. It has happened on the post-submit builder on release-branch.go1.14 [here](https://build.golang.org/log/db8f1224d3e…dmitshur commented on golang.org/x/build/cmd/coordinator: active gomote sessions and coordinator deploys are mutually exclusive5d
An ultimate solution would be a mechanism that makes it possible to redeploy coordinator without losing gomote sessions, or at least makes it possible to re-connect to them without their state gettin…dmitshur opened an issue golang.org/x/build/cmd/coordinator: active gomote sessions and coordinator deploys are mutually exclusive5d
There are times when people need to investigate issues that require configuration or environment that is hard to reproduce locally, and they use [gomote](https://golang.org/wiki/Gomote) instances for…dmitshur commented on encoding/json: [release-branch.go1.14] properly encode strings with ",string" again5d
TRY=linux-386-longtest, linux-amd64-longtest, windows-amd64-longtest, darwin-amd64-race, freebsd-amd64-race, linux-amd64-race, windows-amd64-racedmitshur merged a change golang.org/x/build/dashboard: update test data to Go 1.145d
dmitshur opened a change golang.org/x/build/dashboard: update windows-amd64-race builder to Windows Server 2016 image5d
The purpose of the -race builder is to check for bugs on the Go side,
so use the newer available Windows version with the expectation that
there should be fewer unfixed bugs left in it.
Take this ea…dmitshur commented on doc: update contribution guide to make it friendlier for x/ repos5d
(2 comments)
This change isn't quite right, the freeze does apply to some golang.org/x repos partially. Specifically, it applies to packages that are vendored in the main Go repository, and their tr…dmitshur commented on golang.org/x/build/cmd/coordinator: include -longtest and -race builders for trybots on release branches5d
There's agreement from release team, and this is needed for #29252.
I'll start with adding just the longtest builders first. Sent [CL 234531](https://golang.org/cl/234531) for that.dmitshur opened a change golang.org/x/build/dashboard: update test data to Go 1.145d
This test data will be modified to match a change in behavior
in the next commit. Update it to a supported Go version first.
For golang/go#37827.dmitshur commented on run.bat: use ..\bin\go instead of "go" to install std and cmd5d
(1 comment)
It is used by builders (all.bat calls run.bat), but it's called with --no-rebuild flag, so the affected section is skipped.dmitshur reviewed +2 on run.bat: use ..\bin\go instead of "go" to install std and cmd5d
dmitshur commented on golang.org/x/build/cmd/gopherbot: released things get marked Unreleased5d
Issue #32441 was unfortunate in that it both had a "x/" prefix, yet it didn't match a real package "x/net/http2" that exists and is vendored.
One way to make that task of adding "Unreleased" miles…dmitshur reviewed +2 on golang.org/x/build/cmd/gerritbot: abandon CLs imported from PRs that have been closed6d
dmitshur commented on golang.org/x/build/cmd/gerritbot: abandon CLs imported from PRs that have been closed6d
(1 comment)
Also, if abandonCL fails (e.g., due to a network issue), this line won't be executed. Since it can never fail, it should be better to swap their order so this happens first, and abandonC…dmitshur commented on golang.org/x/build/cmd/gerritbot: abandon CLs imported from PRs that have been closed6d
(2 comments)
I've tested this in dry-run (after CL 234889) and live, it's working well. The time between each checkPullRequests loop is a minute or two, so it's very unlikely a CL would be abandoned…dmitshur commented on github.com/golang/vscode-go: another test PR for https://github.com/golang/go/issues/238506d
Reopening for testing purposes.dmitshur reopened a change github.com/golang/vscode-go: another test PR for https://github.com/golang/go/issues/238506d
dmitshur commented on golang.org/x/tools/all: replace build tags in tests with testenv helper6d
(2 comments)
Also see https://github.com/golang/build/blob/4872bffdeec51d5c4128a3c0c189cec944515603/dashboard/builders.go#L2573-L2599 for the naming strategy of similar helpers in x/build. They migh…dmitshur commented on golang.org/x/tools/all: replace build tags in tests with testenv helper6d
(2 comments)
Needs documentation please.
Major?
Go version naming deviates from semver in that Go 1.14.1 is a minor release, and Go 1.14 is a major release.
See https://golang.org/s/release#relea…dmitshur starred in github.com/Soldat/soldat6d
Earlier
dmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.1w
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.1w
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur opened an issue go/printer: CommentedNode behavior is partially undocumented1w
### What did you do?
I read the documentation of package `go/printer` in order to understand how to use `printer.CommentedNode`.
### What did you expect to see?
Documentation that would allo…dmitshur commented on go.dev: const block comment not rendered in some cases1w
Thanks for reporting.
This is due to a limitation of the algorithm used to trim excessively large string literals and slices (see relevant code [here](https://github.com/golang/gddo/blob/a4ebd2f7e57…dmitshur merged a change golang.org/x/build/cmd/gerritbot: use secret manager only when run in GCE1w
dmitshur commented on Gerrit: references to GitHub PRs should be linkified for all valid GitHub repo names, even ones with a dash character1w
I don't know exactly without first looking more, but it should be somewhere in the repository's Gerrit configuration. E.g., see https://gerrit-review.googlesource.com/Documentation/config-gerrit.html…dmitshur commented on golang.org/x/build/cmd/gerritbot: CLs mirrored from PRs should have links back to the PR1w
This already works for most repositories. For example, [CL 234658](https://golang.org/cl/234658) was imported from https://github.com/golang/go/pull/39176, and Gerrit correctly linkifies the PR menti…dmitshur commented on golang.org/x/build/cmd/gerritbot: use secret manager only when run in GCE1w
(1 comment)
I don't know why I keep thinking it's called this; it should be secret manager¹.
¹ https://cloud.google.com/secret-managerdmitshur opened a change golang.org/x/build/cmd/gerritbot: use secret keeper only when run in GCE1w
Restore the ability to test gerritbot locally in dry-run mode.
Update some references to compute metadata with secret keeper,
since that is what's used now.
Also add a safety check at the top of po…dmitshur commented on x/build/cmd/release{,bot}: include long tests in pre-release testing1w
[CL 234531](https://golang.org/cl/234531) adds automatic long tests to the release process. Once submitted, `releasebot -mode=prepare` will run tests on the linux-amd64-longtest and windows-amd64-lon…dmitshur commented on encoding/json: [release-branch.go1.14] properly encode strings with ",string" again1w
Thanks for reviewing.
To clarify, a backport CL doesn't necessarily need to be reviewed by the original author, it just needs to be reviewed by someone who is qualified to review the change. Usually…dmitshur commented on encoding/json: [release-branch.go1.14] don't mangle strings in an edge case when decoding1w
Friendly ping. This CL needs a code review. It is fixing a backport issue that has been approved.dmitshur commented on encoding/json: [release-branch.go1.14] properly encode strings with ",string" again1w
Friendly ping. This CL needs a code review. It is fixing a backport issue that has been approved.dmitshur commented on golang.org/x/tools: frequent "out of memory" errors on windows-amd64-race builder1w
The `windows-amd64-race` builder is already using `n1-highcpu-16` machine type (16 vCPUs, 14.4 GB mem), same as the `windows-amd64-longtest` builder. So, there isn't an easy opportunity to increase t…dmitshur closed an issue golang.org/x/build: vcs-test.golang.org is inaccessible and causes tests that rely on it to fail1w
dmitshur commented on golang.org/x/build: vcs-test.golang.org is inaccessible and causes tests that rely on it to fail1w
The longtest builders are passing, so this is confirmed to be resolved.dmitshur edited the wiki1w
dmitshur commented on golang.org/x/build: support an x/tools SlowBot for platforms other than linux-amd641w
SlowBots are intended to allow custom and slow testing, so I believe this is in scope. It's a matter of figuring out a syntax for it and implementing the feature.
As a starting point, I'll suggest…dmitshur commented on golang.org/x/build/cmd/coordinator: run TryBots for older versions of Go on x/tools1w
As @stamblerre mentioned above (I was too slow to comment), we should consider how this would affect the support window for builders, if at all. At this time, we're able to stop supporting a builder …dmitshur commented on golang.org/x/build: vcs-test.golang.org is inaccessible and causes tests that rely on it to fail1w
This issue is resolved now. Removing Soon label. I'll keep it open to confirm the next longtest builder run is successful.dmitshur opened an issue : vcs-test.golang.org is inaccessible and causes tests that rely on it to fail1w
There has been a firewall misconfiguration affecting the vcs-test.golang.org service. It is causing longtest builders to fail on tests that need to access vcs-test.golang.org.
For example:
http…dmitshur commented on golang.org/x/build/cmd/gerritbot: abandon CLs imported from PRs that have been closed1w
(1 comment)
This check should stay in the ghr.ForeachIssue function as before, where there's enough context to see that abandonCL is only called on Gerrit CLs that are still open.
This helper shoul…dmitshur commented on golang.org/x/build/cmd/gerritbot: abandon CLs imported from PRs that have been closed1w
(3 comments)
In general, this looks good. I left some comments. I think we should test it to confirm it's working as expected and not causing issues before submitting the CL.
One other scenario to …dmitshur merged a change golang.org/x/website/cmd/golangorg: update GCP console UI link1w
dmitshur merged a change golang.org/x/website/cmd/golangorg: update GCP console UI link1w
dmitshur commented on golang.org/x/build/cmd/releasebot: include long tests in release process1w
(3 comments)
Thanks for reviewing.
It can be. I thought it was a reasonable opportunity to save on vertical space, since the GOOS/GOARCH pair is often considered one piece of information.
I'll lea…dmitshur opened a change golang.org/x/website/cmd/golangorg: update GCP console UI link1w
The URL format has changed slightly, update it so that the Flexible
environment filter continues to be active.
Also, avoid printing directions at the end of the publish step in the
Makefile. Doing s…dmitshur merged a change golang.org/x/website/cmd/golangorg: add golang.org/x/pkgsite repository1w
dmitshur opened a change golang.org/x/website/cmd/golangorg: add golang.org/x/pkgsite repository1w
Allow golang.org/x repos to opt-in to use pkg.go.dev for documentation.
The golang.org/x/pkgsite repository is the first one to use it.
Update to current golang.org/x/build version and regenerate:
…dmitshur merged a change golang.org/x/build/repos: add API for opting-in to use pkg.go.dev for documentation1w
dmitshur opened a change golang.org/x/build/repos: add API for opting-in to use pkg.go.dev for documentation1w
The golang.org/x/pkgsite is the first repository that needs it now.
Fixes golang/go#39150.
For golang/go#36747.
For golang/go#36106.