Activity
Today
dmitshur commented on golang.org/x/playground/latestgo: Update latestgo to use Gerrit to retrieve latest Go version1h
Thanks. Just adding a couple style suggestions.
(nit) The "Update latestgo to " prefix here doesn't need to be included because Go commit subjects implicitly complete the sentence "This change modif…dmitshur commented on golang.org/x/website/_content/doc: ensure database example code compiles2h
Thanks.dmitshur commented on golang.org/x/build/env: add wasip1/wasm wasmtime builder2h
(1 comment)
(minor) Since this isn't the main Go repository, issues in the main Go issue tracker need to be fully qualified by adding the 'golang/go' prefix before '#'. (See https://go.dev/wiki/Comm…Yesterday
dmitshur commented on testing: quote -test.v=test2json output when logging it20h
(1 comment)
Thanks.dmitshur reviewed +2 on testing: quote -test.v=test2json output when logging it20h
Thanks.
If I understand correctly, this is saying that it is in fact possible to change the cmd/go command in a way that would permit normal Go tests to emit ^V characters without breaking go test -…dmitshur commented on golang.org/x/build/internal/releasetargets: formalize minimum macOS version, bump for 1.2121h
(1 comment)
Great, thanks.dmitshur reviewed +2 on golang.org/x/build/internal/releasetargets: formalize minimum macOS version, bump for 1.2121h
Thanks.
Thanks.
Part of my point was that by now I'm not sure that setting CGO_CFLAGS is needed at all on either architecture, given the lack of a known repro case of what breaks if its unset and h…dmitshur reviewed +2 on golang.org/x/build/internal/task/releaselet: update for 1.2122h
(1 comment)
This looks to be equivalent to '-dGoMajorVersion=1' until Go 2 is out, which I don't think is your intention here. (https://go.dev/play/p/koczj41XviY)dmitshur reviewed +2 on golang.org/x/build/internal/task/releaselet: update for 1.2123h
dmitshur commented on golang.org/x/build/internal/task/releaselet: update for 1.2123h
Thanks.
(nit) The trailing '/' is not included in the canonical URL on go.dev anymore and can be left out.
(minor) Maybe add 'Go' prefix here to improve readability, since there are various things …dmitshur commented on golang.org/x/build/internal/releasetargets: formalize minimum macOS version, bump for 1.2123h
(3 comments)
Is there evidence that setting this field has a positive effect, or any observable effect?
(It was previously intentionally left out on the new macOS architecture until such evidence e…This Week
dmitshur commented on golang.org/x/build/internal/relui: add .0 to major versions1d
Thanks for working on this. A few comments from an initial look.
Now that the ".0" is there, is VersionNoPatch still needed or is it just the same as "Version"?
https://go.dev/issue/57631#issuecomm…dmitshur commented on cmd/dist: add json output support1d
I used CL 478155 to get a not-fully-complete but fairly representative all.bash run with `go test -json` output, and converted it to some basic HTML to visualize the data. I intentionally added 2 fai…dmitshur opened an issue testing: duplicate "pass" action from `TestFlag/-test.v=test2json` when run with `go test -json`1d
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel go1.21-ac881545ce Tue Mar 21 12:44:04 2023 -0400 darwin/arm64
</pre>
### Does this issue reproduce wi…dmitshur commented on golang.org/x/website/tour: call 'done' callback after Run, on message Kind 'system'2d
It looks like a network error while fetching dependencies.
Let's see if it reproduces on second run.dmitshur reviewed +2 on golang.org/x/website/tour: call 'done' callback after Run, on message Kind 'system'2d
Thanks.
Thanks for updating the docs here.
I'll just point out that it seems there's also a copy (or two, though I hope x/tools owners will tag+delete the godoc copy soon) in x/tools, but 'system' …dmitshur commented on github.com/shurcooL/githubv4/feat: create automation for schema updates3d
Thanks for suggesting and implementing this, and sorry I didn't get a chance to comment sooner. I've had the idea of doing something like this for some time and I've seen it successfully used in http…dmitshur closed an issue golang.org/x/build/cmd/gerritbot: Gerrit comment content should be posted to GitHub PRs3d
This is #38689.dmitshur commented on golang.org/x/build/cmd/gerritbot: Gerrit comment content should be posted to GitHub PRs3d
This is #38689.dmitshur commented on github: branch protections3d
We can do all golang.org/x GitHub mirrors too (and the special case without x, golang.org/dl). At least I can't think of a downside to treating them the same as the main Go repo mirror for the purpos…dmitshur starred github.com/daafu/sokoban4d
Last Week
dmitshur closed an issue golang.org/x/website: broken link to system requirements1w
Fixed by [CL 469975](https://go.dev/cl/469975). (CC @jamalc.)dmitshur commented on github.com/go-gl/glfw: Build fail on macOS ventura 13.2.11w
It does seem likely that there was some incompatibility in your local build environment setup. If the problem doesn't reproduce with a functional latest version of Xcode, I don't think there's anythi…dmitshur reviewed +2 on github.com/sourcegraph/go-diff: remove unnecessary dependencies1w
Thanks.dmitshur commented on robpike.io/ivy: Ivy iOS App Broken as of iOS 16 +1w
Issue #115 is related.Earlier
dmitshur pushed to
master in github.com/shurcooL/githubv42w
dmitshur opened an issue golang.org/x/build: linux-amd64-perf continuously failing on x/tools with "error committing perfdata file: upload failed: 500 Internal Server Error no valid benchmark lines found"2w
Looking at https://build.golang.org/?repo=golang.org%2fx%2ftools, the linux-amd64-perf builder column has some "ok" rows but most are empty.
At https://farmer.golang.org/#completed right now there…dmitshur commented on golang.org/x/build/cmd/gerritbot: didn't close a PR that was submitted2w
Another case affected PR #58779. It was submitted on Gerrit 5 days ago and the PR wasn't marked as closed.
It once again got stuck on `Changes for PR golang/go#58779 have yet to be mirrored in the…dmitshur closed a change io/ioutil: add doc links for deprecated function2w
dmitshur commented on io/ioutil: add doc links for deprecated function2w
Closing because this PR has been merged via [CL 471915](https://go.dev/cl/471915) as commit dfe4591fc4d2d66da7740de18b32761e7a20691c.
(Normally `gerritbot` does this, but sometimes it needs help d…dmitshur opened an issue cmd/dist: "unexpected fault address 0x200732d00" during bootstrap2w
Starting with [CL 462035](https://go.dev/cl/462035) (CC @randall77), the aix-ppc64 builder is failing during bootstrap:
```
Building Go cmd/dist using /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go…dmitshur opened an issue cmd/gopherbot: move "ping-early-issues" task to relui2w
Pinging issues with "early-in-cycle" is a task that we do once every 6 months, after the development of a new major Go version starts. Right now it's implemented as a task in `gopherbot` that needs t…dmitshur closed an issue access: gerrit approvers2w
dmitshur commented on access: gerrit approvers2w
Hello,
Thanks for your contributions and making this access request. The "approvers" access permits reviewing and submitting CLs across the entire Go project as documented https://go.dev/wiki/Gerr…dmitshur closed an issue cmd/compile: incorrect type set intersection computation [1.18 backport]3w
dmitshur closed a change golang.org/x/tour: Update basics.article3w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur closed a change golang.org/x/tour/...: fix wrong arguments order for image.Rect3w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur commented on golang.org/x/tour/Resolves golang/tour#1062: Add explanation of semicolons to if-else slide3w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur closed a change golang.org/x/tour: Clarify founding date3w
dmitshur commented on golang.org/x/tour: Clarify founding date3w
Closing because x/tour content moved to x/website (see [CL 324309](https://go.dev/cl/324309)), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle3w
[CL 467297](https://go.dev/cl/467297) and a few others took care of this for early in cycle.
Removing that label to revisit this at the start of freeze.dmitshur commented on cmd/go: replace use of "main module" in help docs & error messages 3w
CC @bcmills, @matloob.dmitshur commented on golang.org/x/text: building as a plugin failure on darwin/arm643w
CC @mpvl, @golang/runtime.dmitshur commented on internal/fuzz: go test -fuzz= outputs failing input which contains wrong datatypes3w
CC @golang/fuzzing.dmitshur commented on golang.org/x/crypto: error parsing even large ASN.1 identifiers3w
CC @golang/security.dmitshur closed an issue crypto/x509: TestSystemVerify consistently failing3w
dmitshur commented on crypto/x509: TestSystemVerify consistently failing3w
Thanks watchflakes, but commit 600d37 is before the fix in commit [21e451e](https://go.googlesource.com/go/+/21e451ec446724c9f3f124139e07d88ff812a1bc).dmitshur commented on slices: Delete is an attractive nuisance3w
CC @ianlancetaylor, @eliben.dmitshur commented on cmd/compile: bad DWARF location for variable3w
CC @golang/compiler.dmitshur commented on golang.org/x/tools/go/pointer: internal error in pointer analysis: node has no enclosing object3w
CC @timothy-king, @alandonovan.dmitshur commented on plugin: /usr/bin/ld: failed to set dynamic section sizes: bad value3w
CC @golang/runtime.dmitshur commented on Go 2: start using semantic versions for Go releases3w
At some point between filing this proposal and now, I've realized that the "v" part in a string like "v1.2.3" is not a part of SemVer 2.0.0. See https://semver.org/spec/v2.0.0.html#is-v123-a-semantic…dmitshur commented on crypto/x509: TestSystemVerify consistently failing [1.19 backport]3w
Confirmed that the problem reproduces on an updated Windows 11 device, and the patch fixes it.dmitshur commented on crypto/x509: TestSystemVerify consistently failing [1.19 backport]3w
This test is not failing on Windows builders on release-branch.go1.19. Either there's no problem (i.e., TestSystemVerify was modified in a way that needed the fix only in Go 1.20) or perhaps it's bec…dmitshur opened an issue crypto/x509: TestSystemVerify has started to fail on darwin-amd64-10_153w
As of [CL 472295](https://go.dev/cl/472295) (which fixed #58791), `TestSystemVerify` is failing on darwin-amd64-10_15 (only) with:
```
--- FAIL: TestIssue51759 (0.32s)
--- FAIL: TestIssue517…dmitshur commented on cmd/compile: ICE on method value involving imported anonymous interface [1.20 backport]3w
@mdempsky Please add a short backport rationale to this backport issue (see https://go.dev/wiki/MinorReleases; "The issue should include a link to the original issue and a short rationale about why t…dmitshur commented on crypto/x509: TestSystemVerify consistently failing3w
@gopherbot Please backport at minimum the Windows text fix aspect of this issue.
This is needed to fix failing tests on release branches.dmitshur commented on crypto/x509: Incorrect documentation for `ParsePKCS8PrivateKey` [1.20 backport]3w
No backport needed for Go 1.19 because this issue isn't present in that version.dmitshur commented on github.com/shurcooL/home/internal/exp/service/activity/github: walkSegMail can fail with EOF3w
This was observed again on 2023-02-28 19:38:
```
GitHub Activity Service: ok
Gerrit Activity Service: walkSegMail(gerrit.fileSeg{file:"/2023-03.reclog", skip:0, size:4096}): truncated record at …dmitshur commented on crypto/x509: Certificate.Verify rejects self-signed leaf3w
CC @golang/security.dmitshur commented on golang.org/x/build: macOS PKG installer shows misleading error when installing for the wrong architecture 3w
Thanks for reporting.
We're using Xcode tooling to create a fairly standard macOS installer (see [here](https://cs.opensource.google/go/x/build/+/master:internal/task/buildrelease.go;l=298;drc=f03…dmitshur commented on golang.org/x/build/cmd/runqemubuildlet: qemu failed to find an available port: address already in use3w
CC @golang/release.dmitshur reopened an issue cmd/link: linker fails on linux/amd64 when gcc's lto options are used3w
dmitshur reopened an issue cmd/link: linker fails on linux/amd64 when gcc's annobin plugin is used3w
dmitshur commented on crypto/x509: Incorrect documentation for `ParsePKCS8PrivateKey`3w
CC @golang/security.dmitshur commented on encoding/json: json.Decoder Token method is two times slow than Decode 3w
CC @dsnet, @bradfitz, @mvdan.dmitshur commented on hash/crc32: data leaks to heap3w
CC @golang/security.dmitshur commented on golang.org/x/net/idna: VerifyDNSLength is not rejecting empty labels3w
CC @neild, @ianlancetaylor.dmitshur opened an issue golang.org/x/build: darwin-amd64-10_15 builder missing, no builds for some time3w
Currently at https://farmer.golang.org/#pools:
```
host-darwin-amd64-10_15-aws: 0/0 (2 missing)
```
And there are no builds on the last 30 commits in the main Go repo. Although the most recen…dmitshur commented on crypto/x509: Certificate.Verify does not consistently return UnknownAuthorityError3w
Thanks for catching and reporting this.
CC @golang/security.dmitshur commented on cmd/go: TestDocsUpToDate is incompatible with android emu builder environment3w
The problem seems to be that `testGo` is only set when `testenv.HasGoBuild()` reports positively, but when GOOS=android it returns false. The test currently doesn't check `testenv.HasGoBuild()` nor `…dmitshur commented on misc/cgo/test: link failure with atomics on arm643w
CC @ianlancetaylor, @cherrymui.dmitshur commented on debug/macho: over allocation in NewFile3w
CC @golang/compiler, @ianlancetaylor.dmitshur commented on debug/buildinfo: over allocation in Read through xcoff.NewFile3w
CC @golang/compiler, @ianlancetaylor.dmitshur commented on runtime: malloc instancing generic function seems to deadlock(ish) during benchmark3w
CC @golang/runtime.dmitshur commented on golang.org/x/tools/go/packages: "files=" queries don't seem to work3w
CC @matloob, @golang/tools-team.dmitshur opened an issue cmd/go: TestDocsUpToDate is incompatible with android emu builder environment3w
[CL 468636](https://go.dev/cl/468636) (CC @bcmils) recently improved TestDocsUpToDate to invoke `go help documentation` directly, without the mkalldocs.sh script, but it's not able to run at least in…dmitshur commented on github.com/go-gl/glfw: Old module name in README installation instructions3w
These are two different modules.
Module `github.com/go-gl/glfw/v3.3/glfw` contains v3.3.
Module `github.com/go-gl/glfw` contains older versions: v3.0, v3.1, and v3.2.dmitshur commented on rsc.io/2fa: How to generate codes after moving disk to the new computer?3w
2fa documentation states:
> The keychain is stored unencrypted in the text file `$HOME/.2fa`.dmitshur commented on : use a zero for third digit for major release, such as 'go1.23.0'4w
At least some code that parses Go versions and/or tags may have code that explicitly handles ".0" as a special case, and that would to change (for example, see [here](https://cs.opensource.google/go/…dmitshur deleted branch in github.com/gopherjs/snippet-store1mo
masterdmitshur created branch in github.com/gopherjs/snippet-store1mo
maindmitshur pushed to
master in github.com/gopherjs/snippet-store1modmitshur starred github.com/psilva261/opossum1mo
dmitshur closed an issue golang.org/x/tools/go/analysis/internal/facts: importMap incorrectly handling *types.Named1mo
dmitshur commented on golang.org/x/tools/go/analysis/internal/facts: importMap incorrectly handling *types.Named1mo
Closing as fixed by [CL 362414](https://go.dev/cl/362414).
(Not sure why it didn't get closed automatically via the "Fixes" line in https://github.com/golang/tools/commit/8111118043894a9c0eab886fc…dmitshur closed an issue golang.org/x/build: macOS PKG installer doesn't tell where Go is being installed1mo
dmitshur commented on golang.org/x/build: macOS PKG installer doesn't tell where Go is being installed1mo
Thanks for reporting this.
The Go installer on macOS adds the installed `go` and `gofmt` binaries to `PATH` by placing a file containing the "/usr/local/go/bin" path to the /etc/paths.d directory.…dmitshur pushed to
master in github.com/shurcooL/githubv41modmitshur commented on golang.org/x/website: go.dev/dl was temporarily missing some port downloads1mo
The /dl/upload endpoint has some logic to clear the cache at the end ([here](https://cs.opensource.google/go/x/website/+/master:internal/dl/server.go;l=195;drc=71c2d285b86a517fbac3e662cbf461d326846b4…dmitshur closed an issue security: fix CVE-2022-41727 [1.19 backport]1mo
dmitshur closed an issue security: fix CVE-2022-41727 [1.20 backport]1mo
dmitshur commented on golang.org/x/build: darwin/amd64 builders unexpectedly skipping `cmd/link.TestBuildForTvOS`1mo
Xcode completes its installation on its first launch, showing a prompt that looks like this (in a recent version):
<img width="612" alt="image" src="https://user-images.githubusercontent.com/19241…dmitshur commented on test: add JSON output support to the run.go program1mo
A few more things for me not to forget to update:
- in main repo: test/codegen directory README has instructions for running all codegen tests beyond that what all.bash runs on linux-amd64 builder…dmitshur deleted branch in github.com/mdempsky/unconvert1mo
depsdmitshur commented on golang.org/x/build: failure to build on linux/riscv641mo
x/build is exempt from Go 1 compat and even the release policy as documented at the top of README; if the failing platform isn't something we want to go out our way to support (e.g. we only support c…dmitshur commented on : end support for macOS 10.13 and 10.14 in Go 1.211mo
> older hardware, such as my 2015 mac book pro
Is there a typo in that example? 2015 MacBook Pro models can run up to macOS 12 Monterey (released in 2021), see https://support.apple.com/en-us/HT21…dmitshur commented on cmd/dist: make `--compile-only` actually only compile test binaries and not run them1mo
For context, this [comment thread](https://go-review.git.corp.google.com/c/go/+/448802/4..7/src/cmd/dist/test.go#b359) captures some of the reasons why `-run=^$` was chosen over test -c at the time, …dmitshur commented on golang.org/x/tools/internal/imports: update stdlib index after every major Go release1mo
[CL 464342](https://go.dev/cl/464342) and [CL 464875](https://go.dev/cl/464875) regenerated the index after the Go 1.20 release.
Moving to the next milestone since this won't need attention until Go…dmitshur opened an issue golang.org/x/tools/internal/imports: zstdlib.go fails to generate with Go 1.201mo
Doing `go generate golang.org/x/tools/internal/imports` is fine with Go 1.19 and older, but fails when using Go 1.20:
```
$ go version
go version go1.20 darwin/arm64
$ go generate
2023/02/02…