Activity
Today
dmitshur reviewed +2 on golang.org/x/build/internal/gcsfs: handle explicit GCS folders54m
Thanks.dmitshur commented on cmd/dist: add a --debug-trace flag to dist bootstrap1h
This functionality seems useful; I left some initial comments.
How does the new startSpan and debugTrace functionality compare to this pre-existing timelog and GOBUILDTIMELOGFILE functionality? They…Yesterday
dmitshur commented on dmitri.shuralyov.com/website/gido: Support proposals19h
Proposals are already supported, in the sense they're listed as issues at https://goissues.org/ with a "Proposal" label.
See [prefixtitle.ParseIssue](https://pkg.go.dev/dmitri.shuralyov.com/go/prefi…Last Week
dmitshur reviewed +2 on internal/syslist: do cleanups post deleting cmd/dist custom build system2d
Thanks.dmitshur commented on build: build failure on x_pkgsite-gotip-linux-amd64-misccompile2d
Yes, it it failed while fetching dependencies because a GET request to the module mirror returned 502 Bad Gateway.dmitshur reviewed +2 on cmd/dist: remove the custom build system2d
Nice!
(If you want, while here, delete the blank line so the comment above becomes recognized as a package comment.)
You can now delete this line.dmitshur reviewed +2 on cmd/dist: build go_bootstrap together with toolchain12d
Thanks. Some minor comments.
Minor suggestion to state that those packages aren't needed, which gives a better rationale for why it's not desired to copy/build them.
```suggestion
vcweb/vcstest pac…dmitshur reviewed +2 on cmd/go: remove dependency on being built with its own stdlib3d
Thanks.
Is this part of the commit message out of date?
Do you think it might help to keep the comment explaining the motivation to not include non-default GOEXPERIMENTs in the hash salt?
```sugge…dmitshur commented on golang.org/x/website: tour: add maintained Chinese, French, German, and Korean translations4d
Is https://github.com/shuijingwan/go-tour-i18n/issues the right issue tracker where reports related to the translated tours should be filed? If so, please update the "submit feedback" button in the t…dmitshur closed an issue golang.org/x/build: Microsoft store release4d
dmitshur closed an issue encoding/json: Marshal now honors MarshalText for string-kind map keys [1.26 backport]6d
dmitshur closed an issue encoding/json: Marshal now honors MarshalText for string-kind map keys [1.26 backport]6d
Earlier
dmitshur commented on testing: TestArtifactDirectoryPaths fails in GOPATH mode (no module context)1w
It may be helpful to hear back on the question above, but I'll note that testing standard library packages with GO111MODULE=off is documented as not something that's expected to work - see `go help …dmitshur opened an issue cmd/go: go test std should give a clearer error with GO111MODULE=off1w
### Go version
go version go1.27.1 darwin/arm64
### What did you do?
Prior to filing this issue, I forgot that it was already decided and documented that testing the Go standard library with GO111…dmitshur opened an issue golang.org/x/build/internal/gcsfs: handle explicit GCS folders1w
When working with GCS, one can end up with folders that are either implicit (aka "simulated"?) or explicit (aka "zero-byte object whose name ends with a trailing / delimiter"). Currently the gcsfs.Ne…dmitshur commented on golang.org/x/build/cmd/relui: unexplained instance of a workflow stall1w
In addition to the above, perhaps we could enable the race detector and see if that uncovers something we're not seeing locally? [CL 827824](https://go.dev/cl/827824).dmitshur commented on access: qiulaidongfeng approvers1w
CC @golang/release.Bisected the failure to [CL 814681](https://go.dev/cl/814681), which updated cloud.google.com/go/storage from v1.31.0 to v1.59.2. Bisected that further to v1.50.0 as the last version that works while…dmitshur opened an issue golang.org/x/build/internal/gcsfs: walking a filesystem stopped working, produces errors like "doesn't exist: googleapi: Error 404: No such object: golang-release-staging/relui-scratch/build-outputs/script-build-8525853265259187891, notFound"1w
On August 27, we noticed a case where `buildToOutputs` panicked during a relui workflow execution. The panic revealed a missing error check, which [CL 823324](https://go.dev/cl/823324) has since fixe…dmitshur opened an issue golang.org/x/build/cmd/relui: unexplained instance of a workflow stall1w
During one of the workflow runs for Go minor releases on August 11, 2026, we ran into an unexplained relui behavior:
> [...] something up with relui - some of its tasks have appeared to stall, not m…dmitshur starred github.com/go-git/go-git/v61w
dmitshur closed an issue cmd/fix: embedlit: moving field assignments produces duplicate field name in struct literal [1.26 backport]2w
dmitshur commented on cmd/go: TestScript/gotoolchain_path broken on openbsd2w
CC @golang/openbsd.dmitshur commented on cmd/go: TestScript/cover_atomic_pkgall broken on riscv642w
CC @golang/riscv64.dmitshur commented on cmd/go: TestScript/cgo_path_space_quote is broken on ppc64/ppc64le2w
CC @golang/ppc64.dmitshur commented on golang.org/x/build/cmd/relui: automate process of upstreaming private-track security CLs on release day (for release branches)2w
We've had a chance to test out this functionality over the last several releases, both in cases where there were 1+ PRIVATE-track security fix CLs to upstream and when there weren't any, and it's bee…dmitshur fixed an issue golang.org/x/build/cmd/relui: improve security release automation2w
dmitshur commented on golang.org/x/build/cmd/relui: improve security release automation2w
There's been a lot of progress on this, and the "automate assembling the internal commits into a branch, and exporting the changes from that branch on release day" bar is certainly met. Closing in fa…dmitshur reopened an issue golang.org/x/mobile: type aliases no longer export2w
dmitshur commented on database/sql: closingMutex lost wakeup deadlocks Rows.Next against concurrent Rows.Close2w
CC @neild, @bradfitz, @kardianos.dmitshur starred github.com/rsc/cmd2w
dmitshur commented on sort: add //go:fix inline directives for slices forwarding functions (and consider whether to also deprecate it at the same time, or after a delay, or to stop at go:fix inline without deprecating)2w
Thanks for making this suggestion too. Updated [CL 783580](https://go.dev/cl/783580) to mention this issue.
https://go.dev/wiki/Deprecated is clear that deprecating an exported symbol requires a pro…dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time2y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability4y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change4ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes5y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur pushed to
master in dmitri.shuralyov.com/route/github6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages7y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries7y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido7ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes7ydmitshur opened an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries7y
dmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)7y
Commit [5275a64a](https://dmitri.shuralyov.com/website/gido$commit/5275a64acd14885a8d67315e2b66570347b757af) has made this better. Directories are now determined by walking Go repositories at process…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes7ydmitshur pushed to
master in dmitri.shuralyov.com/service/change7ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido7ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle7ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido7y