Activity
Today
dmitshur commented on golang.org/x/build/repos: add dot-github to mirror to golang/.github2h
Thanks. The Gerrit repo has been created, so submitting.dmitshur commented on golang.org/x/build/internal/access: add IAP context to HTTP requests3h
Thanks. Sent CL 781282 that adds tests and improved docs based on what you've done here.
Done in CL 666496.dmitshur opened a change golang.org/x/build/internal/access: improve docs and tests3h
Michael initially authored CL 461961 to allow HTTP handlers to access
the IAP user in January 2023, though that same functionality ended up
being submitted in August 2024 via CL 593915, with a follow…dmitshur commented on internal/strconv: work around escape analysis bug7h
(1 comment)
Is this meant to be [79547](https://go.dev/issue/79547)?Yesterday
dmitshur commented on cmd/link: enable FIPS 140-3 mode for Wasm15h
A few minor suggestions from reading over this.
It's good that this documents that these two parameters are optional. It'd be good to also say what they represent, too. Issue #79497 describes them, …dmitshur commented on archive/zip: fix reader-side Zip64 edge cases15h
Note that archive/zip tests on linux/386 (without -short flag) have started to fail as of this change. See https://ci.chromium.org/ui/test/golang/archive%2Fzip?q=V%3Abuilder%3Dgotip-linux-386-longtes…dmitshur closed a change golang.org/x/net/idna: upgrade to Unicode 15.1.016h
Thanks for working on this. The code has been updated for Unicode 17 and issue #65141 is closed, so closing this CL too.dmitshur closed a change golang.org/x/text/...: upgrade to Unicode 15.1.016h
Thanks for working on this. The code has been updated for Unicode 17 and issue #65141 is closed, so closing this CL too.dmitshur closed a change all: upgrade to Unicode 15.1.016h
Thanks for working on this. The code has been updated for Unicode 17 and issue #65141 is closed, so closing this CL too.dmitshur commented on net: use readable JSON marshaling for IPNet, IPMask, HardwareAddr16h
Unresolving this for visibility and removing Hold.dmitshur reviewed +2 on golang.org/x/tools/gopls/go.mod: update dependencies following the v0.22.0 release17h
Thanks.
Noting that the -u flag causes 'go get' to update not only the direct dependencies, but indirect dependencies of dependencies too. If you don't want that to be managing indirect dependencies…dmitshur reviewed +2 on golang.org/x/build/internal/task: re-generate license after update dependency18h
Thanks.
Not for this CL, of course, but noting that this can happen by now (issue #65917 is resolved).
```suggestion
// master branch to simulate license changes.
```dmitshur reviewed +2 on internal/testenv: make MustHaveSource detect missing source18h
Thanks.dmitshur commented on golang.org/x/build/internal/task: expand x-repo workflow to handle more than one change19h
(2 comments)
The parameter was there to make it possible to automatically add reviewers, by specifying them in the parameter.
There's a comment below:
> // We don't typically specify reviews in th…dmitshur reviewed +2 on golang.org/x/build/internal/task: add additional lint for CVE and GitHub issue references19h
dmitshur reviewed +2 on golang.org/x/build/internal/task: crystallize security-metadata derived security releasing19h
dmitshur reviewed +2 on golang.org/x/build/internal/task: use x-repo specific formatting for CLs19h
Thanks.
'For golang/go#79034.' maybe.
FWIW, Gerrit has URLs that redirect from a CL number to any project, if you leave out the '{proj}/+' part. E.g., https://go-review.googlesource.com/c/780821 (w…dmitshur fixed an issue cmd/link/internal/ld: TestAbstractOriginSanity failures22h
dmitshur fixed an issue cmd/link/internal/ld: TestAbstractOriginSanity failures22h
The original failure from Jan 8 was likely due to #77515,
and today's failures were handled by [CL 780760](https://go.dev/cl/780760)
(issue #79547 tracks the problem and removing the skip; CC @prattm…dmitshur commented on cmd/link/internal/ld: TestAbstractOriginSanity failures22h
The original failure from Jan 8 was likely due to #77515,
and today's failures were handled by [CL 780760](https://go.dev/cl/780760)
(issue #79547 tracks the problem and removing the skip; CC @prattm…dmitshur commented on os: notify testlog from (*File).Chdir23h
(1 comment)
Is the reason there isn't something like `testlog.Open(f.name) // observe likely non-existent directory` line here, similar to how it's there in os.Chdir, because that must've already ha…dmitshur commented on internal/strconv: use fast unrounded scaling for floating-point23h
Note that cmd/link/internal/ld.TestAbstractOriginSanity fails as of this change. See [here](https://ci.chromium.org/b/8681268550621413985) and #77120.dmitshur commented on cmd/go: clean should honor the -o flag as a build parameter so it can remove the final built artifacts1d
@matloob Is this intended to be a [proposal](https://go.dev/s/proposal)? It's in the Proposal milestone, but doesn't have a "proposal: " prefix in the title nor Proposal label. I fixed that assuming …dmitshur commented on cmd/dist: all.bash does not fail when run.bash fails1d
As a baseline, the `go test` command does return a non-zero exit code on Ctrl+C (SIGINT):
```shell
src $ go test all
ok archive/tar (cached)
ok archive/zip (cached)
ok bufio (cached)
^C
src $ …dmitshur opened an issue cmd/go: sending an interrupt signal (SIGINT) to a go tool invocation of a tool causes it to return with a zero exit code1d
Here's a small reproducer for `go tool` itself, found while looking into #79535:
```shell
$ cd $(mktemp -d)
$ go mod init test && go get go@1.26.0
$ mkdir -p cmd/importantwork && echo 'package main;…dmitshur commented on cmd/compile: Bug in rewrite rules for AMD64 causes SHL instruction overflow and miscompilation [1.25 backport]1d
The Critical label tracks upstream issues; it was applied there (https://github.com/golang/go/issues/79182#event-25767278742) so removing it here.dmitshur commented on cmd/compile: Bug in rewrite rules for AMD64 causes SHL instruction overflow and miscompilation [1.26 backport]1d
The Critical label tracks upstream issues; it was applied there (https://github.com/golang/go/issues/79182#event-25767278742) so removing it here.This Week
dmitshur reviewed +2 on golang.org/x/build/internal/task: expand x-repo workflow to handle more than one change1d
Thanks.
I left some inline comments. In general this looks like a good step to move #79034 forward. I understand there may be future enhancements, and it might be better to leave them out of scope h…dmitshur reviewed +2 on golang.org/x/build/internal/task: refactor closures in x-repo workflow1d
Thanks.
Nice catch that this error message was accidentally including the clNumber parameter definition rather than the value as was intended. (It could go unnoticed while this was a closure because…dmitshur reviewed +2 on golang.org/x/build/internal/task: add additional lint for CVE and GitHub issue references1d
dmitshur reviewed +2 on golang.org/x/build/internal/task: crystallize security-metadata derived security releasing1d
Thanks.
milestoneYAML was previously defined inside testSecurityReleaseCoalesceTask, the only place where it was being used.
It's still used only in that one place, inside testSecurityReleaseCoales…dmitshur reviewed +2 on doc: document new ppc64/linux features1d
Other than being rebased, nothing changed between PS 3 and PS 5, so re-adding bypass. This is a documentation-only change and the only possible failure here is bad link or Markdown or so, but [an ear…dmitshur reviewed +2 on lib/time: update to 2026b/2026b2d
Thanks.dmitshur commented on cmd/trace: add -nobrowser flag3d
(3 comments)
Note there's a list of flags manually enumerated here. It'll need to be updated to include the new flag.
(Maybe a future CL can refactor the flag.Usage function to print the part above…dmitshur commented on net/netip: inline single-use Addr.string{4,6,4In6} methods4d
(1 comment)
This probably needs something like ", appends the result to the byte slice, and returns the updated slice." added here (similarly to how https://pkg.go.dev/fmt#Append has it).dmitshur commented on golang.org/x/build/internal/access: add IAP context to HTTP requests4d
@mpratt@google.com Did CL 666496 replace this CL, so it can be closed? Or is there something more left here?Last Week
dmitshur commented on runtime: throw if a timespec64 can't be converted to a timespec324d
(1 comment)
The new code matches my understanding, thanks.dmitshur commented on runtime: throw if a timespec64 can't be converted to a timespec324d
(2 comments)
'mustDowncastTo32bits' seems to refer to this very method, but the method's name is slightly different.
```suggestion
// mustDowncastToTimespec32 converts a 64-bit timespec to a 32-bit…dmitshur reviewed +2 on cmd/go: sort subcommands in help output4d
Thanks.dmitshur commented on runtime: implement stackcheck for arm646d
(I meant to say macOS 26; here: https://ci.chromium.org/b/8682262972831779137.)dmitshur commented on runtime: implement stackcheck for arm646d
The darwin trybot with macOS 16 seemed to stall, is that unrelated? I started it again to get more data points.dmitshur commented on doc: document new ppc64/linux features6d
The net/http:nethttpomithttp2 failure may be issue #79387 or related. Not caused by this change, so bypassing.dmitshur commented on net/http: deflake HTTP/3 tests6d
[CL 777921](https://go.dev/cl/777921) added a test skip for now, so removing release-blocker label (for Go 1.27) and moving to early-in-cycle Go 1.28.dmitshur commented on golang.org/x/text/unicode/bidi: DefaultDirection(LeftToRight) is silently ignored6d
@qsq8t65pxs It's important for backport requests to include a rationale - please see https://go.dev/wiki/MinorReleases. This issue is about a package in x/text; is there involvement of the standard l…dmitshur reviewed +2 on doc: document new ppc64/linux features6d
dmitshur commented on golang.org/x/crypto: tag v1.0.06d
I agree that x/crypto behaves as if it’s already tagged v1.0.0, both when this was filed and now, it just hasn’t been tagged v1 yet, and it should. This issue hasn’t been progressing as is, and…dmitshur commented on cmd/api: run api check on all golang.org/x modules that have reached v1.0.0 or higher6d
Yes, that’s true. They should probably be tagged v1, their owners just haven’t done it yet. See issue #56325 (CC @FiloSottile) for example. We can still include them in scope of this issue.
I ti…dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-146d
I intended to leave it pinned for some time after closing in case people whose CLs ran into this tried to look here. It’s probably fine to unpin by now. Thanks.dmitshur reviewed +2 on doc: document new ppc64/linux features6d
Thanks.
```suggestion
### Linux {#linux}
```
Also, if there was a tracking issue, it'd be helpful to mention it here in an HTML comment (similar to line 5 above). If not, then nothing to do.
```s…dmitshur reviewed +2 on net/http: disable HTTP/3 tests prior to freeze6d
Thanks.
The "task did not start, no resource" infrastructure failures were due to issue #79410, which is resolved, so starting trybots again.dmitshur commented on golang.org/x/mobile/bind: align Objective-C setter selectors with sanitized property names6d
The "task did not start, no resource" infrastructure failures were due to issue #79410, which is resolved, so starting trybots again.dmitshur fixed an issue golang.org/x/build: widespread builder unavailability, including linux/amd64, on 2026-05-146d
dmitshur fixed an issue golang.org/x/build: widespread builder unavailability, including linux/amd646d
dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd646d
It's still working; "Bots: 102" as if this posting. Closing this as resolved, and I'll follow up in other issues on what's left to do.dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd646d
It seems to be helping so far, linux/amd64 builders are showing up:
<img width="478" height="393" alt="Image" src="https://github.com/user-attachments/assets/062662f0-cfab-4270-a045-c9f22b523b78" />…dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd646d
A likely cause is found, trying a fix.dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd641w
Those Debian 13 builder machines above are for the linux-amd64_debiansid builder and may be unrelated.dmitshur commented on golang.org/x/build: widespread builder unavailability, including linux/amd641w
The linux/amd64 builder query at https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Alinux-amd64&f=machine_type%3An1-standard-16&f=os%3ADebian-11&f=pool%3Aluci.golang.try-workers finds 0 bot…dmitshur commented on all: the tree is horribly flaky1w
@nicholashusin Thanks, that seems like a separate builder infrastructure problem. I filed #79410 for it.dmitshur opened an issue golang.org/x/build: widespread builder unavailability, including linux/amd641w
We're aware of an issue where many of the builders involved in the default trybot set are unavailable. For example, as visible at https://ci.chromium.org/ui/p/golang/builders/try-workers/gotip-linux-…dmitshur commented on all: the tree is horribly flaky1w
TestTransportBodyReadError and other net/http flakes are likely related to the known flakes tracked in issue #78737 (CC @neild, @nicholashusin). There have been recent changes that helped, like https…dmitshur fixed an issue net/http:nethttpomithttp2: TestTransportClosesBodyOnError/h3 failures1w
Closed by [CL 777740](https://go.dev/cl/777740) (commit c22f92a751ed649cd5face58a576d0b13e3d6db7).dmitshur commented on net/http:nethttpomithttp2: TestTransportClosesBodyOnError/h3 failures1w
Closed by [CL 777740](https://go.dev/cl/777740) (commit c22f92a751ed649cd5face58a576d0b13e3d6db7).dmitshur commented on golang.org/x/sys/unix: merge Linux readv/writev implementation with Darwin/OpenBSD1w
(1 comment)
The symbol name and doc comment are slightly different (d vs D). Maybe the doc comment name better and it's worth renaming this unexported function, but in general they should match one …dmitshur reviewed +1 on net/http: fix hang in TestTransportClosesBodyOnError/h31w
Thanks! Leaving to Damien.dmitshur commented on net/http:nethttpomithttp2: TestTransportClosesBodyOnError/h3 failures1w
CC @nicholashusin.dmitshur commented on golang.org/x/crypto/ssh: return partial success immediately from publickey auth1w
The trybot failure on that one builder seems like an infrastructure problem; sent crrev.com/c/7842813 (CC @cherryyz@google.com) to start annotating such cases accordingly in the future. Retrying tryb…dmitshur commented on debug/pe: missing saferio validation in ZLIB section decompression1w
CC @golang/windows.dmitshur commented on cmd/go/internal/telemetrystats: add go/platform/target/port:*-* counter1w
Thanks.dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count1w
One way to keep the function (with possible side effects) executed the same number of times might be to use slices.ContainsFunc with a trivial equality func. That is, if the for range loop is rewritt…dmitshur commented on cmd/fix: x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count1w
@gopherbot Please consider this for backport to Go 1.26. It's needed to prevent `go fix` from incorrectly rewriting code to use `slices.Contains` in some cases when doing so could cause an unintended…dmitshur commented on golang.org/x/crypto/blake2b: merge go125.go into blake2b_test.go1w
Thanks.Earlier
dmitshur reopened an issue runtime: crash in WASM plugins without open file descriptors due to `poll_oneoff` call1w
Reopening since the information in https://github.com/golang/go/issues/78513#issuecomment-4215930937 suggests this can be an enhancement.dmitshur commented on golang.org/x/benchmarks/go.mod: update golang.org/x dependencies1w
Done in PS 3 by updating to `x/net@v0.54.1-0.20260508232935-23ee2efe81a3`.dmitshur commented on golang.org/x/build/go.mod: update golang.org/x dependencies1w
(1 comment)
I'll update this to v0.54.1-0.20260508232935-23ee2efe81a3 to pull in the fix in CL 776180, needed to break build errors at tip.dmitshur reviewed +2 on golang.org/x/net/http2: avoid API changes when built with go1.271w
Thanks.
(nit) Could get rid of ": removed" here, it's not needed.
Edit: Already resolved in PS 5.
(Same here and the two lines below.)
Edit: Already resolved in PS 5.
We don't want to check in t…dmitshur commented on golang.org/x/benchmarks/go.mod: update golang.org/x dependencies1w
The change itself is good, though trybots are reporting a build breakage at tip because x/net v0.54.0 accidentally included breaking API changes (that affect tip only, not any of the stable Go releas…dmitshur reviewed +2 on golang.org/x/net/http2: avoid API changes when built with go1.271w
Thanks.
There are a few more symbols that also need attention, in case you prefer to handle them in the same CL, though of course it's fine to submit this one as is since it's making forward progres…dmitshur opened an issue cmd/api: run api check on all golang.org/x modules that have reached v1.0.0 or higher1w
The cmd/api check runs in the main Go repo and is generally very helpful there. There are some opportunities to extend it, such as issues #53205 and #56773. I didn't find an existing issue for extend…dmitshur closed an issue cmd/api:check: TestCheck failures1w
Looks like a memory bit flip on a darwin builder that happened exactly once in years. Closing in favor of issue #77515.dmitshur commented on golang.org/x/tools/go.mod: update golang.org/x dependencies1w
(1 comment)
I'm not sure off hand, other than it's plausibly related to https://go.dev/ref/mod#graph-pruning, but a few observations:
1. these records are only for go.mod files of x/crypto modules,…dmitshur commented on golang.org/x/telemetry/x/telemetry/config: add counter for goimports invocation1w
(3 comments)
```suggestion
internal/chartconfig: add counter for goimports invocation
```
(The "x/telemetry" prefix is needed on the issue tracker because it tracks all x/ repos in one place, where…dmitshur fixed an issue golang.org/x/tools/cmd/goimports: add counter for each invocation1w
Issue #75651 also exists to track adding the telemetry config. So this can proably stay focused on adding the local counter, which was done in [CL 700595](https://go.dev/cl/700595). Closing again.dmitshur fixed an issue golang.org/x/telemetry/config: add counter for toolchain VCS usage1w
Thanks for the suggestion to check local counters in `go env GOTELEMETRYDIR`. They seem as expected to me, and "go/vcs" shows up at https://telemetry.go.dev/config now (thanks to [CL 775820](https://…dmitshur commented on cmd/go/internal/telemetrystats: drop go/platform/target/{goos,goarch}:*1w
(1 comment)
This change is ready for review.
Hold submission for a later release, though it's fine to review now.dmitshur commented on cmd/go/internal/telemetrystats: add go/platform/target/port:*-* counter1w
This change is ready for review.dmitshur reviewed +2 on golang.org/x/build/main.star: add configs for sizespecializedmalloc perf_vs_parent builders1w
Thanks. I wasn't very familiar with our perf_vs_parent runmod, but good to learn more about it.
Just noting that I expect (but haven't confirmed) that it will have the GOEXPERIMENT env var set both …dmitshur commented on golang.org/x/build/cmd/gorebuild: log at start of GerritTarGz1w
Thanks.dmitshur opened a change cmd/go/internal/telemetrystats: drop go/platform/target/{goos,goarch}:*1w
They provide a subset of the information that the newer port:*-* counter
provides, making them generally redundant. They were never uploaded, and
there are no plans to start using them, so remove the…dmitshur commented on golang.org/x/telemetry/internal/chartconfig: add go/platform/target/port:*-* counter1w
(1 comment)
Using two brackets for expansions isn't supported. Even if it were supported, we probably don't want to permit unexpected combinations (like aix-386) to be accepted for upload, so I'll c…dmitshur opened a change golang.org/x/telemetry/internal/chartconfig: add go/platform/target/port:*-* counter1w
The accepted GOOS and GOARCH values come from the 49 ports that
includes 2 broken ports (they may still be attempted to be used)
as reported by 'go tool dist list -broken' at tip, Go 1.27 to be.
For…dmitshur opened a change cmd/go/internal/telemetrystats: add go/platform/target/port:*-* counter1w
CL 587115 added separate counters for target GOOS and target GOARCH:
go/platform/target/{goos,goarch}:*
For the purpose of being able to tell usage of each target port
(telemetry proposal go.dev/i…dmitshur closed a change golang.org/x/open2opaque/...: update golang.org/x dependencies1w
This change has been applied as https://go.googlesource.com/open2opaque/+/3d04330bec09d438a41877cf8c354f63a5fab476.dmitshur commented on golang.org/x/crypto/x509roots/fallback/bundle: fix bundle test with Go 1.27+1w
(1 comment)
Since those steps are fairly predictable and might be easier to do now while the context is fresh in memory, prepared CL 775782 and CL 775783 for that in case it helps.dmitshur opened a change golang.org/x/crypto/blake2b: merge go125.go into blake2b_test.go1w
The go1.25 build constraint is guaranteed to always be satisfied because
the go directive is at 1.25.0, so the separated out go125.go file is not
needed. Move the assertion that the *xof type impleme…dmitshur opened a change golang.org/x/crypto/x509roots/fallback/bundle: make subjectsEqual stricter on Go 1.27+1w
This gradual step towards removing/inlining subjectsEqual can happen
after Go 1.27.0 is released and the bundle starts being generated
with it.dmitshur opened a change golang.org/x/crypto/x509roots/fallback/bundle: inline subjectsEqual1w
This final step of removing/inlining subjectsEqual can happen after
Go 1.28.0 is released.dmitshur commented on cmd/go: add -buildversion build flag1w
@thepudds Thanks for mentioning the VERSION files used by the Go toolchain; I was going to do that too since it hadn't come up yet, and it seems good to at minimum consider in this proposal. I'll not…dmitshur reviewed +2 on golang.org/x/telemetry/godev: update telemetry docker versions to 1.251w
Thanks.
```suggestion
With the go.mod go version updates, we need at least Go 1.25 to build
```
Using 1.25 is certainly fine as is, since it meets the minimum requirement of this module. Just notin…