Activity

Last Week
One of the tests in the new package is failing, but it seems to happen only on one Go port. Filed #66804 for it.
[CL 550215](https://go.dev/cl/550215) added a new package. One of its tests, `TestPQCrystalsAccumulated`, is failing on the linux/s390x port: ``` --- FAIL: TestPQCrystalsAccumulated (0.07s) …
@panjf2000 The Auto-Submit+1 vote is documented at https://go.dev/wiki/GerritAccess#auto-submit. I meant you can ask the person who left the Code-Review+2 vote to either submit or leave Auto-Submit+1…
For golang/go#65913. For golang/go#63471.
Pull in CL 578338: db050b07 http2: send correct LastStreamID in stream-caused GOAWAY For #66668. Fixes #66698.
Pull in CL 578336: ef58d90f http2: send correct LastStreamID in stream-caused GOAWAY For #66668. Fixes #66697.
dmitshur starred fyshos.com/fynedesk2d
dmitshur closed an issue access: may-start-trybots and approvers2d
Hi @panjf2000, thanks for contributing to the Go project and asking for approvers access again. We considered this request. As documented at https://go.dev/wiki/GerritAccess, Gerrit "approvers" ac…
This is fixed via [CL 568339](https://go.dev/cl/568339), which removed the duplication.
dmitshur closed an issue access: go-assignees and go-editors2d
Hi @qiulaidongfeng, thanks for your interest and contributions to Go. We considered this request. Similarly to https://github.com/golang/go/issues/66611#issuecomment-2052070282, when considering g…
Remove the suggestion to include "CC @golang/release" because it silently has no effect if the GitHub account posting it does not already have some access within the 'golang' GitHub organization. We'…
dmitshur closed an issue access: +2 approval in CLs2d
dmitshur commented on access: +2 approval in CLs2d
Hi @mauri870, thanks for contributing to the Go project and asking for this access. We considered this request and felt your contribution history demonstrates enough signals for us to be close to …
dmitshur closed an issue access: approvers2d
Hi @qiulaidongfeng, thanks for your interest and contributions to Go. We considered this request (previously considered in #64255). As documented at https://go.dev/wiki/GerritAccess, Gerrit "appro…
Hi @raghvenders, thanks for your contributions to Go so far. We discussed this request. We generally look for contributors to have a more established track record of contributions before consideri…
This test causes the server to send a GOAWAY and close a connection. The server GOAWAY path writes a GOAWAY frame asynchronously, and closes the connection if the write doesn't complete within 1s. Th…
This test causes the server to send a GOAWAY and close a connection. The server GOAWAY path writes a GOAWAY frame asynchronously, and closes the connection if the write doesn't complete within 1s. Th…
(1 comment) You were right in that it was a concern. It motivated me starting with a non-zero known issue until I found out whether it worked. I looked at the old coordinator builder, and it was re…
The `TestTraceGCStress` failure is unrelated to this documentation change.
Thanks. You'll need to rebase past the CL that converted go1.22 release notes from HTML to Markdown.
Add these to replace the old coordinator equivalents. Set a known issue because I don't know if they'll pass right away or need a bit more work.
This is resolved as of [CL 569875](https://go.dev/cl/569875). (It didn't get closed automatically because the Fixes line didn't specify the `golang/go` repo quite right.)
Thanks. I think this `godoc` mention is out of date and worth removing too. In the earlier days, x/tools/cmd/godoc was bundled into the toolchain, and available as `GOROOT/bin/godoc` (next to `GORO…
(1 comment) What's the motivation to remove this error check; is it intentional?
dmitshur starred github.com/aclements/go-obj4d
(1 comment) I checked on a gomote, it seems to reproduce reliably there with https://chrome-infra-packages.appspot.com/p/infra/3pp/tools/wasmtime/linux-amd64/+/version:2@15.0.0 and newer wasmtimes, …
Thanks for doing this. LGTM.
Thanks. No need for backticks here in the commit message (see https://go.dev/wiki/CommitMessage). As heads up, CL 577775 will soon convert this from .html to .md, so you might need to resolve a mer…
Thanks.
(1 comment) Does this need to be updated to a newer version that'll include CL 577295 and other recent improvements there?
@jub0bs Yes, your understanding is right and generally it's good to allow some time for discussion on the issue first, though it's still okay to send a change sooner. There are some more details abou…
(1 comment) Whoops, that wasn't intended. I'll [update](https://go.dev/cl/577855) its permissions, and in the meantime here are the two failing tests in package `os`: ``` === RUN TestAppend o…
(1 comment) I was thinking of doing that too; thanks. :) How does patch set 2 look?
We'd like to be able to show the results of a shadow build to anyone, and they're not expected to have anything private—we'd use something else for that if needed.
(1 comment) Yeah, we have a way of testing LUCI builder configuration changes by taking inputs to a real build, applying an edit to its configuration (in this case, swapping out its wasmtime_version…
Thanks. Sounds good, thanks. I kicked off test builds with wazero_version set to "2@1.7.0": - on release-branch.go1.22 at https://ci.chromium.org/b/8751097293146812081 - on release-branch.go1.21 a…
Thanks. (nit) Seems like this comment talks about the case below, not the code above. That should be easier to see if its indentation is reduced by 1 level: ```suggestion // Currently we don't su…
Thanks. Having test cases for cases we wish not to regress certainly helps with applying a refactor like this. s/if/of/ (nit) Often a blank line at the end of a function body can be removed without…
dmitshur reviewed +2 on cmd/api: handle types.Alias5d
I understand this makes `GODEBUG=gotypesalias=1 go test cmd/api -check` behave identically to how `GODEBUG=gotypesalias=0 go test cmd/api -check` currently behaves, i.e., just fixes the panic due to …
Thanks for asking. We're nearing the latter stages of the migration and will soon start shutting down the old coordinator-based builders for first-class ports on our side, and send an update to gola…
Thanks. (minor) Likely needs a `go mod tidy`.
dmitshur reviewed +2 on misc/wasm: drop wasmtime < 14 support1w
Thanks. Do you think this is worth leaving a note for in the Go 1.23 release notes, or fine not to talk about it there? You can add it while you're here if it's worth including. Up to you.
(1 comment) Similar comment/question as on CL 577136: will the newer wazero version work on 1.21 and 1.22 release branches as well? Okay if so.
Thanks. Everything looks right—see one inline question/comment about wheter you intended to apply this to 1.23 only or 1.23+1.22. Just noting that wasmtime version "2@19.0.1" indeed exists in CIPD…
Thanks. Confirming a few details. `GOARCH` should be `wasm32` instead of `wasm`, is that right? Related to the above—will `GOROOT/misc/wasm` be used for both `wasm` and `wasm32` exec helpers? Tha…
Thanks for the CL. This change was applied a year later for Go 1.19 via CL 395918, so if this CL were to be rebased it'd become empty. Closing.
Earlier
(Temporarily rebased onto a slightly older commit to work around `TestCrashWhileTracing` failing as of CL 572095.)
(1 comment) Done.
dmitshur closed an issue access: may-start-trybots1w
Hi abner chenc, Thanks for your contributions and helping maintain the linux/loong64 port. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybot…
> via 509315 Err, I meant to say via CL 514635 there.
Thanks for sending this fix. This change has been merged via CL 509315. Closing.
dmitshur closed a change bytes: tweak example_test outputs1w
Thanks for sending this fix. The same change has already been applied in CL 568135. Closing.
Note, some longtest builders (linux/386, linux/arm64) are failing in one test: - https://ci.chromium.org/b/8751464291004279729/test-results - https://ci.chromium.org/b/8751464288659678625/test-resul…
> should backport the fix as well To clarify, do you think the fix to be backported should include changes in [CL 576756](https://go.dev/cl/576756) and [CL 576895](https://go.dev/cl/576895)?
(1 comment) It's probably slightly more accurate to write: ``` For #66668. Fixes #60636. ``` I'll update the commit message after trybots finish running.
dmitshur opened a change all: update vendored golang.org/x/net1w
Pull in CL 576895: ec05fdcd http2: don't retry the first request on a connection on GOAWAY error For #65051. For #66668.
Thanks.
@mknyszek@google.com I suspect you might be aware, but noting just in case: `golang.org/x/exp/trace.TestFlightRecorder` and several related tests in x/exp/trace are failing at Go tip as of this CL.
CC @griesemer, @findleyr.
Thanks for reporting this. CC @rsc.
CC @golang/compiler.
CC @golang/compiler.
CC @griesemer, @findleyr.
@aktau@google.com The Code-Review submit requirement description is "At least one Code-Review+2 is required. Self review is not allowed.". Since you're the CL author, your Code-Review+2 vote has no e…
dmitshur opened a change all: update vendored golang.org/x/net1w
Pull in CL 576756: b67a0f05 http2: send correct LastStreamID in stream-caused GOAWAY It comes with newer x/crypto and x/sys requirements via CL 576516. For #65051. Fixes #66668.
For golang/go#66701.
Here's the certificate: [linux-ppc64-power8-1712341779.cert.txt](https://github.com/golang/go/files/14889449/linux-ppc64-power8-1712341779.cert.txt). I'll also work on another CL needed for that h…
@pmur Should this issue also be closed, or is there more to do for it?
Thank you very much @pmur. I've mailed you [go.dev/cl/576917](https://go.dev/cl/576917) to remove its known issue.
They've connected and started running. See https://ci.chromium.org/b/8751480727881152721 and https://ci.chromium.org/b/8751480728981608321. For golang/go#66667. For golang/go#64660.
The same failure happened prior to this CL (visible [here](https://ci.chromium.org/p/golang/g/x-vuln-gotip/console)). I think it's issue #60687.
We're still seeing instances where runOnce takes significantly longer to complete than usual. Add a hard timeout to get more information and maybe act as a stop-gap to reduce how often build results …
The `pollLoop` method that runs in a loop usually takes a minute, but sometimes seems to get stuck and eventually completes in just over 24 hours without any error. This is a tracking issue to sort t…
(1 comment) This call to `checkBuilder` calls `testing.Short`, which needs flags to be parsed, but they're not parsed yet causing `panic: testing: Short called before Parse`. (For example, see [log]…
The definition/embed.txt, definition/misc.txt, and hover/sizeoffset.txt cases of `Test` are failing on linux/arm (32-bit) since they were introduced in [CL 573076](https://go.dev/cl/573076). For e…
The two instances above were on release-branch.go1.22.
CC @golang/openbsd, @ianlancetaylor, @neild.