Activity
Today
dmitshur commented on cmd/compile: regalloc reloads a value from a narrower phi's stack slot, losing its upper bits2h
From triage meeting, this is likely not a regalloc bug but elsewhere. @cherrymui said that @randall77 had a suggested approach for this might work for this.dmitshur commented on cmd/dist: `{CC,CXX}_FOR_TARGET` is incorrectly embedded into output when cross-compiling2h
CC @golang/compiler.dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.27 backport]4h
We discussed this in a release meeting. Approved the already-created backport CL.dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.26 backport]4h
We discussed this in a release meeting. Approved the already-created backport CL.dmitshur commented on cmd/compile: generic shift-by-constant canonicalization gives Const64 the wrong type [1.26 backport]4h
Approving the backport to Go 1.26 for CL 795240 and CL 837245.dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.27 backport]4h
The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.26 backport]4h
The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.dmitshur commented on cmd/compile: loong64 spills a byte-sized inlined result with an 8-byte MOVD, clobbering adjacent stack slots [1.26 backport]4h
@abner-chenc Can you please include a backport rationale for this request. Also, is this a problem for Go 1.26 only, or is 1.27 also affected?dmitshur commented on crypto/tls: IPv4 public names are allowed in ECH5h
CC @golang/security, @cpu.dmitshur commented on mime: avoid panicking when reading globs2 files5h
CC @neild.dmitshur commented on net: maxListenerBacklog panics on empty somaxconn input5h
CC @ianlancetaylor, @neild, @nicholashusin.dmitshur commented on cmd/compile: hoist slice allocations out of a loop5h
CC @golang/compiler.dmitshur closed an issue : x/pkgsite:7h
Empty issue.dmitshur commented on : x/pkgsite:7h
Empty issue.Yesterday
dmitshur commented on cmd/compile: regalloc reloads a value from a narrower phi's stack slot, losing its upper bits22h
CC @golang/compile.dmitshur commented on cmd/compile: specialize instantiations of "certain" generic functions22h
CC @golang/compile.dmitshur commented on cmd/compile: linker panic "R_USEIFACE ... references type:.eqfunc... which is not a type or itab" with reflect.TypeFor[T]().Comparable()22h
CC @golang/compile.dmitshur commented on cmd/compile: CSE of OpLocalAddr across calls lets GC free objects still reachable from a local array22h
CC @golang/compile.dmitshur commented on runtime: g is allocated from the 480-byte size class on amd64, arm64 and loong6422h
CC @golang/runtime.dmitshur commented on runtime: bound overtakes of lock2 sleepers22h
CC @golang/runtime.dmitshur commented on runtime: allocation profile is stale when collected multiple times before GC happens22h
CC @golang/runtime.dmitshur commented on runtime: random memory allocation errors on AIX22h
CC @golang/aix, @golang/runtime.dmitshur commented on net/http: HTTP/2 server re-arms a connection's idle timer after its serve loop ends, retaining the connection for IdleTimeout (and the client read loop never stops its health-check timer)22h
CC @neild, @nicholashusin.dmitshur commented on math: Exp returns +Inf for finite results on amd64 (709.436 <= x < 709.783)22h
CC @griesemer, @rsc, @thatnealpatel.dmitshur commented on hash/maphash: WriteComparable loses input on a zero-value Hash22h
CC @randall77.dmitshur commented on runtime: windows: a fault while printing an exception hangs the process instead of exiting22h
CC @golang/windows, @golang/runtime.dmitshur commented on runtime: windows/386: suspending a thread inside NtContinue crashes recovery from a fault22h
CC @golang/windows, @golang/runtime.dmitshur commented on golang.org/x/sys/windows: MemoryBasicInformation has the wrong layout on windows/38622h
CC @golang/windows.dmitshur commented on golang.org/x/tools/go/analysis/passes/modernize: stditerators produces non-compiling code when the loop does not use the element22h
CC @madelinekalil, @adonovan.dmitshur commented on golang.org/x/crypto/ssh: OpenChannel can block forever when the connection dies concurrently22h
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/MichaelWittgreffe22h
CC @golang/pkgsite.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/arsham6ix/Xray-core22h
CC @golang/pkgsite.dmitshur commented on golang.org/x/text/language: Parse accepts a tag that repeats an extension singleton22h
CC @mpvl.dmitshur commented on golang.org/x/website/tour: add four community translations and update four URLs22h
CC @golang/tools-team, @ALTree.dmitshur commented on golang.org/x/vuln: govulncheck -format=sarif generates invalid SARIF with duplicate stacks, violating SARIF v2.1.022h
CC @golang/vulndb.dmitshur commented on image/draw: finding the closest palette color is slow for large palettes22h
CC @nigeltao.dmitshur commented on golang.org/x/build/cmd/relui: unexplained instance of a workflow stall22h
During this month's release workflow, we saw relui get restarted due to OOM. It's quite possible that enabling the race detector contributed to more memory usage, enough to exceed its current 8 GB al…dmitshur commented on runtime: native SEH unwinding faults in mcall on windows/amd64 since Go 1.2523h
CC @golang/runtime, @golang/windows.dmitshur commented on golang.org/x/pkgsite: package removal request for github.com/sebastienrousseau/scout, scout-mcp, scout-reporting, scout-action23h
CC @golang/pkgsite.dmitshur commented on encoding/xml: Marshal and EncodeToken emit ill-formed element/attribute names with nil error23h
CC @rsc.dmitshur commented on go/types: types.Error.go116end end position derived from placeholder Ident.Name is garbage23h
CC @griesemer, @mrkfrmn.dmitshur commented on go/types: Interface.Method and ExplicitMethod are not ordered by Id, contra docs1d
CC @griesemer, @mrkfrmn.dmitshur commented on net/http: FileServer issues incorrect redirect to regular file given multiple trailing slashes1d
CC @neild, @nicholashusin.dmitshur closed an issue : Add minia2a — x402 marketplace for agent monetization via API1d
dmitshur commented on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder1d
(2 comments)
> If we can use 12 for the default builders I think that would be better.
We're already using 12 for linux/arm64 (CL 622318), but still 11 for linux/amd64. Changing the version comes w…dmitshur commented on golang.org/x/build: evaluate switching default builders to a newer architecture1d
CC @golang/release.dmitshur reviewed +2 on golang.org/x/build/internal/relui: make poll-wait for submit less spammy1d
Thanks.
(nit) Given a not very self-descriptive type like `chan string`, 'ch' is not a very descriptive variable name for it. Since it's being used to log notable state changes, consider naming it s…dmitshur commented on security: fix CVE-2026-568611d
Removing release-blocker for clarity. Since this issue was moved to the Unreleased milestone, that label has no effect. It can be re-added if this needs to block a specific release.dmitshur commented on net/http: Transport reuses cached unencrypted HTTP/2 connection for https:// request1d
Removing release-blocker for clarity. Since this issue was moved to the Unreleased milestone, that label has no effect. It can be re-added if this needs to block a specific release.dmitshur commented on cmd/go: go vet -fix does not apply fixes in std packages, and -tags turns unsafeptr back on1d
CC @adonovan, @matloob.dmitshur reviewed +2 on golang.org/x/build/internal/relui: transition WIP CLs to Ready1d
Thanks.
https://go.dev/doc/comment suggests "Every exported (capitalized) name should have a doc comment."
I wonder if it could work out slightly better to do the mark ready step as soon as the con…dmitshur reviewed +2 on golang.org/x/build/gerrit: fix incorrect return schema for SetCommitMessage1d
Thanks.
It's kinda surprising to see that given it's [not documented](https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-message) in the Gerrit API REST docs, and [this](…dmitshur reviewed +2 on golang.org/x/crypto/acme: prefer test log helpers in test contexts1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/watchflakes: don't require credentials when debugging one build or script1d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: do not fail on cherry-pick merge conflicts1d
Thanks.
What is the effect and motivation of having a sleep here and on line 961 (above)? They're in the same goroutine, so as far as I can tell they have no effect inside synctest.Test. If they hav…dmitshur reviewed +2 on golang.org/x/build/internal/task: add observability to MoveAndRebase1d
Thanks.
By this line, ci has been assigned to movedCI. Will its Branch field be the new branch by then? If so, perhaps something like:
```suggestion
prevBranch := ci.Branch
ci = &movedCI
ctx.…Last Week
dmitshur commented on golang.org/x/build/relmeta: add Symbols to SecurityPatch4d
Another tool to consider is cmp.Diff, since its output on failure can be easier to read.dmitshur reviewed +2 on golang.org/x/build/relmeta: add Symbols to SecurityPatch4d
Thanks.
I'll note that it seems a bit unexpected that DeploymentMap would have this effect on Symbols, where an empty map causes p.Symbols to be used as is, whereas a non-empty map causes some filte…dmitshur reviewed +2 on golang.org/x/build/relmeta: add escape hatch for manual deployment4d
dmitshur commented on image/draw: speed up finding the closest palette color4d
The net/http.TestTransportMaxConnsPerHostDialCancellation/h1 failure is an unrelated flaky test (tracked in issue #69182), and everything else passed.dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.27.md: add two late release notes4d
Thanks.dmitshur fixed an issue golang.org/x/build: migrate low-capacity (reverse) builders to LUCI5d
This migration is done, closing out this umbrella issue. Any other builder-specific work can be tracked in individual issues.dmitshur opened an issue golang.org/x/build: add darwin/arm64 builders with macOS 27 Golden Gate5d
This is a tracking issue for adding darwin/arm64 builders with macOS 27 Golden Gate. (There's no need for amd64 ones since macOS 27 drops support for amd64.) Issue #76798 was for previous year's vers…dmitshur commented on golang.org/x/vgo/Automated: Migrate go/vgo from gsutil to gcloud storage6d
Thanks for preparing this change. As noted in the [README](https://go.googlesource.com/vgo#obsolete), this repository is an archive, preserved for historical interest only. It's not actively used nor…dmitshur reviewed +2 on golang.org/x/build/relmeta: add escape hatch for manual deployment6d
Thanks.
I see a lot of uses of DeploymentMap in this CL, but I'm having a hard time finding any one place that gives it a clear description. Given it's a map of A to B, what do A and B represent? I …dmitshur reviewed +2 on golang.org/x/build/internal/relui: factor upstreaming private-track CLs tasks into methods6d
Thanks.
Noting that this whole "Confirm PRIVATE-track security CLs" step was meant to be temporarily guard against human release coordinators accidentally pasting in the wrong ref until the metadata…dmitshur reviewed +2 on golang.org/x/build/internal/relui: split off privXMilestoneParameter6d
Yep, relui parameter definitions are basically free so it's good to specialize them to be more precise when applicable (such as here). Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: return milestones by pointer6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: remove indirections where possible6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift CL conversion in ReleaseMilestone6d
Thanks.
This is a general comment. I see a pattern across various CLs to convert some method-based tasks into function-based tasks and provide dependencies to them as parameters (wf.Const since they…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift checkpoint branch creation6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift await for disclosed security patches6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift public branch head guards6d
I wished (for purposes of readability of the CL stack) this was a part of CL 826666 rather than happening later, but maybe these couldn't be moved earlier until some of the refactors in between.
Tha…dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift submission of security patches6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/task: lift linting of security patches6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: lift API for applying security riders6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: dilineate between allowed riders6d
This is a bit unfortunate because it sets a slightly confusing precedent, and one would expect this to be something that's easier to do programmatically than to expect humans to do it. But I think it…dmitshur reviewed +2 on golang.org/x/build/internal/task: disclose x-repo patches atomically6d
Thanks.
The '%' is needed before the first [push option](https://gerrit-review.googlesource.com/Documentation/user-upload.html#push_options), and ',' separates multiple options. So I think as writte…dmitshur reviewed +2 on golang.org/x/build/internal/task: lift atomic disclosure of security patches6d
Thanks.
I think fairly modern versions of `git` support fetching a revision directly via a `--revision` flag, so it might be viable to completely remove the need for callers to specify a ref. But th…dmitshur reviewed +2 on golang.org/x/build/internal/task: wire 'Wait to disclose' correct in privx.go6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: remove redundant no-milestone-approval gate6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: add runMinorReleaseToFailure helper6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: fold publicize test fixtures into helper6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/workflowtest: fold helpers for workflow Start/Run6d
Thanks.
Please document that a nil `listener` means to use a basic verbose listener, so that callers don't need to read implementation details of this helper to be able to rely on it.dmitshur reviewed +2 on golang.org/x/build/internal/relui: fold security setup into a test helper6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: refactor testing to use synctest6d
Very nice to see this. Thanks.
(I guess we can't do this for any tests that depend on a real database dependency, but those are a small subset; most release-related tests just use the workflow packa…dmitshur commented on golang.org/x/build/internal/workflowtest: fold remaining test fixtures6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/workflowtest: fold remaining test fixtures6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/task: remove TCP from test fakes6d
Thanks.
Note that the canonical source of this package is in x/website; this is an x/build copy.
The API change below is fine to make, but please also send it to x/website to keep them in sync and …dmitshur reviewed +2 on golang.org/x/build/internal/relui: refactor to use http.Client everywhere6d
Thanks.
While looking at this line (that this CL happens to touch), it's noticeable that this too can eventually be simplified by taking advantage of either `http.FileServerFS` or `http.Dir`.
Pleas…dmitshur reviewed +2 on golang.org/x/build/internal/task: switch FakeGerrit to use in-memory listener6d
Thanks.
We're deploying relui [with Go 1.27](https://cs.opensource.google/go/x/build/+/master:cmd/relui/Dockerfile;l=5;drc=de126992084793ed2efd31a4babdf01684b03c10), and if it's really worthwhile to…dmitshur reviewed +2 on golang.org/x/build/internal/relui: use synctest in TestAwaitFunc6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal: honor errors returned by workflow6d
Thanks.
I'm not sure how easy it'll be for a person seeing this to tell what "handler" refers to. Maybe mention OnStall more explicitly.dmitshur reviewed +2 on golang.org/x/build/internal/relui: fold remaining test fixtures6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/workflowtest: add package and fold in abstractions6d
This seems fine. I expect there will still be some instances where it's easier to create a dedicated testing helper, so not absolutely everything has to be de-duplicated and made general purpose, but…dmitshur reviewed +2 on golang.org/x/build/...: apply security patch riders programatically6d
Thanks.
Nice to see this.
As a side note, this is the first time I'm seeing the term "riders". The closest I knew of was git commit message footers/trailers, but I guess "riders" refer to the "Fixe…dmitshur reviewed +2 on golang.org/x/build/internal/relui: build backport issue manifest6d
Thanks.
Should this return a non-nil error if the issue doesn't exist? Similarly to GetIssue above.
```
if !ok {
return nil, fmt.Errorf("the issue %v does not exist", number)
}
```dmitshur reviewed +2 on golang.org/x/build/relmeta: remove VulnReport field from SecurityPatch6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: update GitHub issues post-disclosure6d
Thanks.
It might help to note which type is the input to this template. For example, that'd make it easier to get to the definition of "{{.ID}}" and look up its [meaning](https://pkg.go.dev/golang.o…dmitshur reviewed +2 on golang.org/x/build/internal/relui: enforce 1:1 map of security patches to release blockers6d
Thanks.
Is it viable (and helpful) to have CheckSecurityIssues also check that when rm is nil, there are exactly 0 security issues?