Activity

Yesterday
Bisection shows the duplicate bg.png file was introduced in the change we made to fix issue #44239, in Feb 2021. The .pkg installer for go1.15.8 (released just before that change) has one bg.png, but…
As it was helpfully pointed out, this may be related to our .pkg having a duplicate file in its table of content: ``` $ xar -t -f ./go1.17.6.darwin-arm64.pkg [...] Resources/bg.png Resources/b…
This Week
> TBD? In addition to production and staging, I suggest having a third semi-environment, "dry-run mode". It would be intended for local execution and wouldn't need to be deployed anywhere. It woul…
From `gopherbot` logs: ``` 2022/01/20 19:15:16 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/374434 2022/01/20 19:15:16 Setting review on https://go-review.googlesource.com/c/…
I found that [grr](https://github.com/google/grr) has a .pkg installer for macOS at https://grr-doc.readthedocs.io/en/latest/deploying-grr-clients/overview.html#downloading-clients, although it seems…
Thanks for testing and confirming this Cherry. Can you try some other macOS installers (e.g., Chrome) and see if they're also affected, or it it only happening to the Go installer? Given how generic…
dmitshur pushed to master in github.com/goxjs/websocket3d
dmitshur pushed to master in github.com/goxjs/glfw3d
I tried on macOS 12.1 (21C52) and on macOS 11.6.2 (20G314), and this issue doesn't reproduce. The installer shows up as correctly signed with a Google certificate, and opens okay. So this may be e…
Yeah, as far as I can tell, because of how package → module resolution works (documented at https://go.dev/ref/mod#resolve-pkg-mod), in module mode it appears to be sufficient as long as ?go-get=1 …
It seems the relevant parsing/conversion happens in [`present.Style`](https://pkg.go.dev/golang.org/x/tools/present#Style): ```Go // Style returns s with HTML entities escaped and font indicators…
https://go.dev/talks hosts some Go talks, many of which use the [legacy present syntax](https://pkg.go.dev/golang.org/x/tools/present#hdr-Legacy_Present_Syntax) (rather than the newer [Markdown synta…
dmitshur starred github.com/tdewolff/canvas6d
Last Week
dmitshur pushed to master in github.com/shurcooL/githubv41w
a14260e6f8a2c38187a2e19c074b338f5ffd6cebREADME: say client rather than s.clQL
dmitshur starred bintris1w
> Would you welcome a PR including a section providing an example of this to avoid confusion from other users? I believe this should be covered by https://github.com/shurcooL/githubv4#pagination; ca…
Ah, that snippet assumed that `endCursor` was of type `string`, but in your code its type is `*string`. In that case, you can just [convert](https://go.dev/ref/spec#Conversions) it to a `*graphql.Str…
From what you've shared, I'm fairly confident the problem is with the `variables` map you're providing to the `Query` call, specifically this code: ```Go query := new(reposQuery) variables := map[st…
Yes, if it's an optional GraphQL type, using a Go pointer makes sense. That is also what's done in the code example I linked above. The [`NewString`](https://pkg.go.dev/github.com/shurcooL/githubv4#N…
If you look at GitHub's [`RepositoryOwner`](https://docs.github.com/en/graphql/reference/interfaces#repositoryowner) interface, the `after` argument of the `repositories` field has type [`String`](ht…
dmitshur commented on 2d2c5b4894764be69ac85e6cc43bd51bb957b487github.com/terraform-providers/terraform-provider-github: Adding BypassPullRequestActorIDs to branch protection1w
@jtyr The `BranchProtectionRule` struct looks to be used for querying the [BranchProtectionRule](https://docs.github.com/en/graphql/reference/objects#branchprotectionrule) GitHub GraphQL object. That…
The generated code includes enums in enum.go, and convenience input structs in input.go. The field `bypassForcePushActorIds` was added to `CreateBranchProtectionRuleInput` and `UpdateBranchProtection…
Earlier
I've looked into the panic in `golang.org/x/build/maintner`, and it seems the panic cannot happen under normal situations, only if Gerrit is misbehaving somehow. Since it only happened that one time …
Inside the `GerritMeta.LabelVotes` method, there's code like: ```Go oldCommit := m.CL.Project.GitCommit(lastCommit) newCommit := m.CL.Project.GitCommit(commit) if !oldCommit.SameDiffStat(newCom…
dmitshur starred filippo.io/intermediates2w
dmitshur pushed to master in github.com/shurcooL/githubv42w
0707a5a905430565886a6e4994b0f6b926874b0eregenerate for schema changes by 2022-01-05
Sure, I'll regenerate today. I'm not ready to start making tags here yet, that will happen later.
@FiloSottile Sounds good. Please feel free to update the `x/crypto` entry (and/or nested ones) in https://dev.golang.org/owners accordingly, so other people doing CCing will know as well.
dmitshur closed an issue os/exec: TestLookPath fails on Windows2w
Thanks @iwdgo, closing. Please comment if we missed something, or file a new issue if there's a new problem.
Not panicking seems like a good change. Do you know if RFC 5988 permits the relation-type to be quoted with a single quote in addition to double quote?
(Reporting in case it is helpful.) The following input causes `Parse` to panic: ```Go link.Parse(`</example.png>;rel=preload;as=image`) ``` (Playground link: https://go.dev/play/p/yZcgx_-7…
Thank you @changkun. Not having 1 of 3 iOS builders is an okay state, since builds can complete with the 2 builders even if at a slightly reduced rate. For example, it helped make progress in [CL 369…
Since this issue is resolved on tip, I'll move it to that milestone and close it as fixed. It can still be considered for [backport](https://go.dev/wiki/MinorReleases) to 1.17 and 1.16 (if 1.16 is af…
I see, thanks for more context. It seems like we can close this issue as a duplicate of #37158, do you agree? Note that proposal #47257 has been accepted by now, so that will affect this situat…
Thanks for the report. CC @FiloSottile, @katiehockman, @rolandshoemaker.
cgo needs a C compiler is needed to build C code, this is working as expected. If you prefer to disable cgo, you can configure that with the `CGO_ENABLED` environment option. If your C compiler…
Does the same problem happen if using `go` from the command line? If not, it looks like the problem is with in `nvim` and how it uses Go, and so this report would need to be made in its issue tracker…
Is it because the label in x/vulndb doesn't have a space ([NeedsTriage](https://github.com/golang/vulndb/labels?q=NeedsTriage)), but in [worker.go](https://github.com/golang/vulndb/blob/552ce2251f…
Thanks. In general it looks good, I left minor comments. As I mentioned on the CL, I expect this change to not to be disruptive, and one that we can make, but it's hard to know for sure in advance…
@randall77 Is the reason the backport request was made for 1.17 only because 1.16 doesn't have this problem?
It looks like these builders have gone missing recently. As visible at https://farmer.golang.org/#pools: ``` host-android-arm64-corellium-android: 0/0 (3 missing) host-ios-arm64-corellium-ios: 0…
Thanks for clarifying. I'm still not seeing the same difference you're describing on my machine, at least not with Go 1.18 Beta 1: ``` $ go run . | grep "handshake end" 184.652292ms handshake…
This problem doesn't reproduce when I build Go from source at that commit: <details> ``` gotip $ git status HEAD detached at becaeea119 nothing to commit, working tree clean gotip $ cd src …
> consistently 100-200ms slower Can you clarify how you're getting to that number? From your log, it looked like all 3 requests got first byte within 20 ms, not 100-200 ms.
In the test performed, `client := &http.Client{}` looks suspicious. From https://pkg.go.dev/net/http#Client.Transport: ```Go // Transport specifies the mechanism by which individual // HTTP requ…
dmitshur commented on 1d41a85fcad3dcca8459052402206262f6c41c09github.com/FiloSottile/passage/...: update README and split extensions1mo
Nit: Line 35 needs one more dash for alignment. :)
> If it's hard to find the optimal choice, we can default to the simpler option of removing the custom contact link. Okay, let's do this for now to resolve this issue.
Since the suggestion here is to make &include=all give versions in sorted order, I think that means #47367 needs to be fixed first. Otherwise when there's more than 1 pre-release version, it won't be…
Issue #47148 is a data point involving fairly verbose output, spanning 20 comments. Perhaps it can help make a decision here. As a straw proposal, how about if `len(bodyParts) <= 4`, post them all…
Releasebot looks for the release milestone for the current release, and uses it for various things during the release process. GitHub allows for multiple milestones to have the same title that dif…
Approved as a test-only fix. Only 1.16 needs this backport, since the fix is already present in Go 1.17.
This was done in other cases, for example https://tip.golang.org/pkg redirects to https://pkg.go.dev/std@master. Looks like this is an edge case that was missed, and just needs to be fixed. Thanks fo…
Both https://docs.github.com/en/rest/reference/checks#list-check-runs-for-a-git-reference and https://docs.github.com/en/rest/reference/checks#list-check-suites-for-a-git-reference endpoints documen…
dmitshur starred golang.org/x/website1mo
``` Get "https://sum.golang.org/lookup/...": ...: no route to host ``` Failures resolving the checksum database means the checked in go.sum is missing entries for dependencies that are being dow…
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now. Done in PS 3. I'm following the Go style for commit messages, which chooses…
In case it's helpful here, reports in https://github.com/glfw/glfw/issues/1990 suggest this issue may be fixed in macOS 12.1 (21C52), released today.
I can confirm @GameParrot's finding. I've retested an OpenGL application mentioned in https://github.com/glfw/glfw/issues/1990#issuecomment-968177486 right before, while on macOS 12.0.1 (21A559), …
> (We should also update https://github.com/go-gl/glfw/wiki/Development#updating-glfw-c-source for the new grab-upstream process.) Done in [wiki commit `f28edba4`](https://github.com/go-gl/glfw/wi…
dmitshur pushed to master in github.com/go-gl/glfw1mo
748e38ca8aecd6b0646cba97eed16259a4af568fv3.3/glfw: update to GLFW 3.3.6
Looks good, thank you.
Shortened 'golang.org' to 'go.dev' here, and on line 24.
Thanks! It's true there aren't dedicated tests, but it still helps to at least run `go test ./...` since it confirms there aren't build errors, and runs some high-confidence vet checks. (Plus if a…
Indeed. @Jacalz, if you'd like and are able to, please feel free to send a PR. The last update was in PR #329, and its commit message should have helpful information. Improvements to make the grab-up…
dmitshur edited the wiki1mo
CC @Lyoness, @pearring via [owners](https://dev.golang.org/owners).
CC @Lyoness, @pearring via [owners](https://dev.golang.org/owners).
Thanks, indeed, it shows up now. Closing.
Now that #34744 is complete, this became much easier. Fix for this and another issue incoming.
All looks ready for Go 1.18 Beta 1, so moving this recurring issue to the next milestone.
Confirmed, it should be okay and helpful! As I understand, fuzz targets don't run automatically during all.bash, so this is really low-risk for the stability of the release.
We've discussed macOS today and agreed to use macOS 12 releaselets both for amd64 and arm64 architectures starting with Go 1.18 Beta 1. Send [CL 369958](https://go.dev/cl/369958).
> not tracking health To expand on this, the "macOS ARM64 (M1 Mac minis)" health item in https://farmer.golang.org/#health is tracking the health of `host-darwin-arm64-12_0-toothrot` (this builder),…
Thanks Cherry. We'll wait for the 1.17 workaround to land. I think it can be removed from builder configuration when 1.18 is released and 1.16 stops being supported. So waiting on that.
> This timeout-and-retry behavior @bcmills Is the issue here that there's an unbounded number of transparent retries, or that you consider even a bounded number of retries, like 3, problematic? (O…
We haven't been able to find a way to reproduce this, and by now, Go 1.14 is unsupported, so I'll close this issue. If this problem occurs on supported releases of Go (1.17 and 1.16 at this time), pl…
dmitshur pushed to master in github.com/go-gl/glfw1mo
caad923f49f49da6834c183daae7b59e7fc2e4fcv3.3/glfw: add netbsd support
Thanks, this change looks reasonable, so I'll merge it to move it forward. I think it's fine both to leave out `wayland` tags until they're supported, but also okay to include them proactively giv…
Closed. Thanks ver much for everyone's help resolving this.
With the builder updates that @changkun performed, and as of CL 368054 landing, the iOS builder is passing. If I understand correctly, there's nothing more to do for this issue, right? If so, I'll…
If the blog entries won't be inlined, it seems reasonable to display more entries. It doesn't need to show all, since that's what https://go.dev/blog/all is for. Unless /blog simply replaces the need…