Today
dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3h
Thank you for the PR and for elaborating on the motivation for wanting this, and how it affects you.
It's reasonable to mark the current `sanitized_anchor_name` as v1.0.0. It's very stable and has…
Thank you for the PR and for elaborating on the motivation for wanting this, and how it affects you.
It's reasonable to mark the current `sanitized_anchor_name` as v1.0.0. It's very stable and has…dmitshur commented on Add go.mod file in github.com/shurcooL/sanitized_anchor_name3hWhere is this "go" directive documented? What are the consequences of using it? I'd rather avoid adding it until I understand the implications.
Where is this "go" directive documented? What are the consequences of using it? I'd rather avoid adding it until I understand the implications.dmitshur commented on Move "Recently Installed Updates" s… in github.com/shurcooL/Go-Package-Store3h> I can extract the useful implementation cleanups from this change
Done in 00930cb77276442831a58fe4da42af6a1cb6db2e.
> I can extract the useful implementation cleanups from this change
Done in 00930cb77276442831a58fe4da42af6a1cb6db2e.dmitshur commented on Move "Recently Installed Updates" s… in github.com/shurcooL/Go-Package-Store4hI've evaluated this approach extensively in my local testing over the last few weeks, and did not find it to be an overall improvement. I didn't get used to it, and it kept feeling awkward and strang…
I've evaluated this approach extensively in my local testing over the last few weeks, and did not find it to be an overall improvement. I didn't get used to it, and it kept feeling awkward and strang…Yesterday
dmitshur commented on generate: Sometimes generates longe… in github.com/ejcx/passgo1dAfter reading the [`pc.GeneratePassword`](https://github.com/ejcx/passgo/blob/833999f9aa7e85c20c99a1c3615f0a7f7d5c3429/pc/pc.go#L193-L229) code, I suspect I understand what's happening.
It keeps a…
After reading the [`pc.GeneratePassword`](https://github.com/ejcx/passgo/blob/833999f9aa7e85c20c99a1c3615f0a7f7d5c3429/pc/pc.go#L193-L229) code, I suspect I understand what's happening.
It keeps a…Last Week
dmitshur commented on cmd/go: module-mode import path che… in github.com/golang/go3d> As of #18660, `go get` in `GOPATH` mode allows any Unicode letter
To be more precise, #18660 was about allowing Unicode letters within the "subdir" part of github.com import paths like "github.c…
> As of #18660, `go get` in `GOPATH` mode allows any Unicode letter
To be more precise, #18660 was about allowing Unicode letters within the "subdir" part of github.com import paths like "github.c…dmitshur commented on Add ForceAllTypes to Options in github.com/shurcooL/vfsgen1wHi @kenshaw,
Thank you for the PR and for the detailed rationale for why you want this.
Added a thinking label because I'd like to take some time before making a decision here, but let me tell …
Hi @kenshaw,
Thank you for the PR and for the detailed rationale for why you want this.
Added a thinking label because I'd like to take some time before making a decision here, but let me tell …dmitshur commented on Read doesn't write to slice. in github.com/shurcooL/vfsgen1wHi @kinghunter58,
It looks like there might be a bug in your code to read from `f`.
The [`io.Reader`](https://godoc.org/io#Reader) interface documentation notes:
> Read reads up to len(p) by…
Hi @kinghunter58,
It looks like there might be a bug in your code to read from `f`.
The [`io.Reader`](https://godoc.org/io#Reader) interface documentation notes:
> Read reads up to len(p) by…
dmitshur commented on Add MIT License in github.com/shurcooL/vfsgen1wHi @andrewmostello.
> I'd like to use vfsgen in our projects
Great!
> was hoping you could add a license. I've added the MIT license here
`vfsgen` is already licensed using the MIT licens…
Hi @andrewmostello.
> I'd like to use vfsgen in our projects
Great!
> was hoping you could add a license. I've added the MIT license here
`vfsgen` is already licensed using the MIT licens…dmitshur commented on Add include/exclude options in github.com/shurcooL/vfsgen1wAlso, in case you haven't seen it, you should consider https://godoc.org/github.com/shurcooL/httpfs/filter which is a package that offers similar functionality.
Also, in case you haven't seen it, you should consider https://godoc.org/github.com/shurcooL/httpfs/filter which is a package that offers similar functionality.dmitshur commented on Add include/exclude options in github.com/shurcooL/vfsgen1wHi @rasa,
Thank you for the PR, and sorry it took me a while to get back to you.
I think users should absolutely have access to this kind of functionality. However, it can be done without needi…
Hi @rasa,
Thank you for the PR, and sorry it took me a while to get back to you.
I think users should absolutely have access to this kind of functionality. However, it can be done without needi…dmitshur commented on x/build: clean download fails in github.com/golang/go1w@bradfitz I think this is closer to https://github.com/go4org/go4/issues/30, which has been resolved a year ago.
@bradfitz I think this is closer to https://github.com/go4org/go4/issues/30, which has been resolved a year ago.Earlier
dmitshur commented on 
.github: don't render a… in github.com/golang/go1wFor consistency with lines 16 and 19.
.github: don't render a… in github.com/golang/go1wFor consistency with lines 16 and 19.dmitshur commented on go/doc: example for syscall/js.NewC… in github.com/golang/go1wI noticed something in [`os/exec`](https://godoc.org/os/exec) package documentation related to this issue. Namely, it includes the following paragraph in the package documentation:
> Note that the…
I noticed something in [`os/exec`](https://godoc.org/os/exec) package documentation related to this issue. Namely, it includes the following paragraph in the package documentation:
> Note that the…dmitshur commented on cmd/go/internal/modfetch: TestCodeR… in github.com/golang/go1wRelated issue #27692. It's another instance of the cmd/go tests relying on an external live repository.
Related issue #27692. It's another instance of the cmd/go tests relying on an external live repository.dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go1wI believe this issue is now fully resolved by [CL 150057](https://golang.org/cl/150057), redeploying golang.org, and @andybons taking measures to prevent future Gerrit CL numbers from overlapping wit…
I believe this issue is now fully resolved by [CL 150057](https://golang.org/cl/150057), redeploying golang.org, and @andybons taking measures to prevent future Gerrit CL numbers from overlapping wit…dmitshur commented on x/build/cmd/coordinator: use cmd/go… in github.com/golang/go1wIsn't the build cache tied to a specific compiler version? As soon as the compiler changes just a bit, every package would need to be rebuilt.
Can you elaborate on how the build cache could be use…
Isn't the build cache tied to a specific compiler version? As soon as the compiler changes just a bit, every package would need to be rebuilt.
Can you elaborate on how the build cache could be use…dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go1wThanks Brad.
It looks like it has made good progress, the [build dashboard](https://build.golang.org/) is mostly filled in by now. Closing as fixed.
Thanks Brad.
It looks like it has made good progress, the [build dashboard](https://build.golang.org/) is mostly filled in by now. Closing as fixed.dmitshur commented on Remove sourcegraph.com vanity impor… in github.com/sourcegraph/go-diff2w> My thinking was that the long term goal here would be:
>
> 1. Remove vanity imports for all github.com/sourcegraph packages
> 2. Eventually remove support for vanity import paths in Sourcegraph its…
> My thinking was that the long term goal here would be:
>
> 1. Remove vanity imports for all github.com/sourcegraph packages
> 2. Eventually remove support for vanity import paths in Sourcegraph its…dmitshur commented on GOARCH=arm support. in github.com/go-gl/gl2wMost of the work would be figuring out why it doesn't work, and what needs to be done to make it work. It's hard to estimate it other by starting to do it and seeing how it goes.
I think most ARM-ba…
Most of the work would be figuring out why it doesn't work, and what needs to be done to make it work. It's hard to estimate it other by starting to do it and seeing how it goes.
I think most ARM-ba…dmitshur commented on [Windows] A tutorial to install gcc… in github.com/go-gl/glfw2wGiven how often this comes up, and how difficult it is to figure out on one's own, I agree it would be helpful to say something.
We shouldn't maintain such tutorials ourselves, but linking to some r…
Given how often this comes up, and how difficult it is to figure out on one's own, I agree it would be helpful to say something.
We shouldn't maintain such tutorials ourselves, but linking to some r…dmitshur commented on transport: use golang.org/x/net/con… in github.com/dbmedialab/go-graphql-client2w@warpfork Friendly ping. Feel free to let me know if this PR isn't helpful.
@warpfork Friendly ping. Feel free to let me know if this PR isn't helpful.dmitshur commented on Remove sourcegraph.com vanity impor… in github.com/sourcegraph/go-diff2wChanging an import path of a package has some cost, which should be taken into account when making a decision like this.
Note that the `diff` package imports `sourcegraph.com/sqs/pbtypes`, which is …
Changing an import path of a package has some cost, which should be taken into account when making a decision like this.
Note that the `diff` package imports `sourcegraph.com/sqs/pbtypes`, which is …dmitshur commented on 
[WIP] Add Metal impleme… in github.com/hajimehoshi/ebiten2wI don't think it works with Metal. [`glfwSwapInterval` documentation](http://www.glfw.org/docs/latest/group__context.html#ga6d4e0cdf151b5e579bd67f13202994ed) says:
> This function sets the swap in…
[WIP] Add Metal impleme… in github.com/hajimehoshi/ebiten2wI don't think it works with Metal. [`glfwSwapInterval` documentation](http://www.glfw.org/docs/latest/group__context.html#ga6d4e0cdf151b5e579bd67f13202994ed) says:
> This function sets the swap in…dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2w@tklauser Thanks for reporting. @bradfitz mentioned remembering that at least one service needs to be restarted after a force push. https://build.golang.org/ not showing the latest commits is definit…
@tklauser Thanks for reporting. @bradfitz mentioned remembering that at least one service needs to be restarted after a force push. https://build.golang.org/ not showing the latest commits is definit…dmitshur commented on x/tools/cmd/godoc: add support for … in github.com/golang/go2w@dsnet has created a prototype for this, and this proposal is accepted, so it will be integrated into `x/tools/cmd/godoc` code. It hasn't happened yet, but updates will be posted here when there's pr…
@dsnet has created a prototype for this, and this proposal is accepted, so it will be integrated into `x/tools/cmd/godoc` code. It hasn't happened yet, but updates will be posted here when there's pr…dmitshur commented on x/tools/godoc/redirect: offer Gerri… in github.com/golang/go2wgolang.org has been redeployed with the [CL 150057](https://golang.org/cl/150057) change applied, so short links like https://golang.org/cl/150057 are correctly pointing to Gerrit CLs now.
golang.org has been redeployed with the [CL 150057](https://golang.org/cl/150057) change applied, so short links like https://golang.org/cl/150057 are correctly pointing to Gerrit CLs now.dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2wgolang-dev announcement: https://groups.google.com/d/msg/golang-dev/8JmYrD3DWY0/oNVcA29FBgAJ.
Closing since this is done.
golang-dev announcement: https://groups.google.com/d/msg/golang-dev/8JmYrD3DWY0/oNVcA29FBgAJ.
Closing since this is done.dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2wOr `--force-with-lease`.
Or `--force-with-lease`.dmitshur commented on x/tools/godoc: backport Flex change… in github.com/golang/go2wThis is done now. [Twelve CLs](https://github.com/golang/tools/compare/927e5423272fee7c3fdca1c32a2a700d8bc6c7e2%5E...f1c3f9758cfa55baca3eeb5caf8b723ca47643b4) have been backported.
This is done now. [Twelve CLs](https://github.com/golang/tools/compare/927e5423272fee7c3fdca1c32a2a700d8bc6c7e2%5E...f1c3f9758cfa55baca3eeb5caf8b723ca47643b4) have been backported.dmitshur commented on cmd/vendor/golang.org/x/tools: vet … in github.com/golang/go2wI'm in favor of rewriting the history to drop the binary for the following reasons:
- This is the main `go` repo, not a subrepo, so only Go developers have a copy. Had it been a subrepo, it would …
I'm in favor of rewriting the history to drop the binary for the following reasons:
- This is the main `go` repo, not a subrepo, so only Go developers have a copy. Had it been a subrepo, it would …dmitshur commented on x/build: stop testing dev.boringcry… in github.com/golang/go3wSounds like the decision is to use `windows/386`. I'll proceed with that for now, but happy to change it if there's further feedback.
Sounds like the decision is to use `windows/386`. I'll proceed with that for now, but happy to change it if there's further feedback.dmitshur commented on x/build: stop testing dev.boringcry… in github.com/golang/go3wTesting on at least one other builder in addition to `linux/amd64` itself sounds reasonable. Which one (or ones)?
Some possibilities:
- Just `windows/amd64`?
- All first class ports: `linux/{3…
Testing on at least one other builder in addition to `linux/amd64` itself sounds reasonable. Which one (or ones)?
Some possibilities:
- Just `windows/amd64`?
- All first class ports: `linux/{3…dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom3wI see, thanks for clarifying. Then let's keep this as is. If we discover evidence that there are reproducible cases where it's nil and needs to be handled, we can address it then.
I see, thanks for clarifying. Then let's keep this as is. If we discover evidence that there are reproducible cases where it's nil and needs to be handled, we can address it then.dmitshur pushed to 
server/play: Use golang.org/x/net/context/ctxhttp package
patch-1 in github.com/dmitshur/jsgo3wserver/play: Use golang.org/x/net/context/ctxhttp packagedmitshur commented on Can shurcooL/go/ctxhttp dependency … in github.com/shurcooL/graphql3wIssue https://github.com/golang/go/issues/21358 has been resolved today, so I can finally resolve this issue! 🎉 /cc @gmlewis
Issue https://github.com/golang/go/issues/21358 has been resolved today, so I can finally resolve this issue! 🎉 /cc @gmlewisdmitshur commented on x/build/cmd/gopherbot: follow-up ba… in github.com/golang/go3wAlso happened in https://github.com/golang/go/issues/28688#issuecomment-438326787.
Also happened in https://github.com/golang/go/issues/28688#issuecomment-438326787.dmitshur commented on cmd/compile: inline multiplication … in github.com/golang/go3w@josharian You're hitting the known issue #25574. Gopherbot already responded to a backport command earlier in this issue, so until #25574 is resolved, it never listens to follow up backport requests.
@josharian You're hitting the known issue #25574. Gopherbot already responded to a backport command earlier in this issue, so until #25574 is resolved, it never listens to follow up backport requests.dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go3wFWIW, explicitly setting the maximum acceptable TLS version to 1.2 in that test makes it pass:
```
diff --git a/http2/server_test.go b/http2/server_test.go
index e5be1a6..3cd398f 100644
--- a/h…
FWIW, explicitly setting the maximum acceptable TLS version to 1.2 in that test makes it pass:
```
diff --git a/http2/server_test.go b/http2/server_test.go
index e5be1a6..3cd398f 100644
--- a/h…dmitshur commented on x/net/http2: TestServer_Rejects_TLS… in github.com/golang/go3wBisected this test failure to [CL 147638](https://golang.org/cl/147638) (crypto/tls: enable TLS 1.3 and update tests), which makes a lot of sense. /cc @FiloSottile
Bisected this test failure to [CL 147638](https://golang.org/cl/147638) (crypto/tls: enable TLS 1.3 and update tests), which makes a lot of sense. /cc @FiloSottiledmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go3wWoohoo! CL incoming.
Woohoo! CL incoming.dmitshur commented on x/net/context/ctxhttp: replace "gol… in github.com/golang/go3w@bradfitz, we've been removing support for Go 1.6 and replacing `golang.org/x/net/context` with `context` in many packages recently (e.g., https://github.com/golang/net/commit/04ba8c85dd55b4ee6099abb…
@bradfitz, we've been removing support for Go 1.6 and replacing `golang.org/x/net/context` with `context` in many packages recently (e.g., https://github.com/golang/net/commit/04ba8c85dd55b4ee6099abb…dmitshur commented on x/build/maintner: GitHubIssue.Close… in github.com/golang/go3w> We have the issue events synced anyway, so the data's in the corpus. We just need to track the oldest close event per issue.
That's a great idea, then no need for extra queries. The close event ha…
> We have the issue events synced anyway, so the data's in the corpus. We just need to track the oldest close event per issue.
That's a great idea, then no need for extra queries. The close event ha…dmitshur commented on 
Refactored to use Graph… in github.com/davidoram/ght3wYou can omit the empty brackets if you want, e.g., just `graphql:"tag: node"`.
Refactored to use Graph… in github.com/davidoram/ght3wYou can omit the empty brackets if you want, e.g., just `graphql:"tag: node"`.dmitshur commented on Refactored to use Graph… in github.com/davidoram/ght3wIn case it's helpful, you can probably simplify this further. Instead of using `edges` and then accessing the `node` inside, you could access the list of nodes directly via `nodes`. See the second fi…
Refactored to use Graph… in github.com/davidoram/ght3wIn case it's helpful, you can probably simplify this further. Instead of using `edges` and then accessing the `node` inside, you could access the list of nodes directly via `nodes`. See the second fi…dmitshur commented on access: request for increased Githu… in github.com/gopherjs/gopherjs3wWe've added you. Thank you Paul!
We've added you. Thank you Paul!dmitshur commented on IsoGoApp: Does not find and load th… in github.com/gopherjs/gopherjs3w/cc @EngineerKamesh
/cc @EngineerKameshdmitshur commented on gopher build error in github.com/gopherjs/gopherjs3wIf you look at the [import graph](https://godoc.org/github.com/EngineerKamesh/igb/igweb/client?import-graph&hide=2) of that package, you'll see that it imports `go.isomorphicgo.org/go/isok`, which im…
If you look at the [import graph](https://godoc.org/github.com/EngineerKamesh/igb/igweb/client?import-graph&hide=2) of that package, you'll see that it imports `go.isomorphicgo.org/go/isok`, which im…dmitshur commented on Remove Cgo dependency on Windows in github.com/go-gl/glow3wAdd a `// TODO: Use syscall.Syscall18 when Go 1.12 is the minimum supported version.` perhaps?
Add a `// TODO: Use syscall.Syscall18 when Go 1.12 is the minimum supported version.` perhaps?dmitshur commented on remove dependency on cgo in github.com/go-gl/gl4wI think we did reach agreement. We talked on slack and I left some comments on the proposal document. As long as you're willing to help maintain the Windows cgo-free version, we're happy to accept it.
I think we did reach agreement. We talked on slack and I left some comments on the proposal document. As long as you're willing to help maintain the Windows cgo-free version, we're happy to accept it.dmitshur commented on How to encode GraphQL Aliases in github.com/shurcooL/githubv44w@davidoram Thanks for asking. Aliases are supported, but I haven't documented them yet (see #22). I hope to fix that soon.
The answer is as follows. A GraphQL query like this:
```GraphQL
query…
@davidoram Thanks for asking. Aliases are supported, but I haven't documented them yet (see #22). I hope to fix that soon.
The answer is as follows. A GraphQL query like this:
```GraphQL
query…dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom4wQuestion, do you know if `e.Get("content")` always returns a non-nil value?
Question, do you know if `e.Get("content")` always returns a non-nil value?dmitshur commented on Add HTMLTemplateElement in github.com/dominikh/go-js-dom4wPlease use a keyed field in this composite literal, for consistency with other elements.
```suggestion
return &HTMLTemplateElement{BasicHTMLElement: el}
```
Please use a keyed field in this composite literal, for consistency with other elements.
```suggestion
return &HTMLTemplateElement{BasicHTMLElement: el}
```