Activity
Last Week
dmitshur commented on net/http: Request.Form field data may include HTML entities1d
CC @bradfitz, @neild, @empijei.dmitshur commented on io/fs: document how hard and symbolic links in a fs.FS should work1d
As I understand this, the `fs.FS` interface represents an abstract hierarchical file system. It's up to the implementation to define this, and there may be multiple valid implementations that provide…dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: only milestone new vscode-go issues as Untriaged1d
Thanks. I think with this workaround and CL 308790, we have enough rate limit budget to re-enable that task, so LGTM.
I'll keep an eye on it to make sure it's working as we expect.dmitshur opened an issue golang.org/x/build/cmd/gopherbot: backport requests inside main issue body are ignored1d
In https://github.com/golang/go/issues/45480#issue-854860512 a backport request was made, but gopherbot ignored it because it currently looks only inside issue comments, not the main issue body. It w…dmitshur commented on golang.org/x/build/cmd/gopherbot: handle transferred issues1d
This issue also affected a recently added "set vscode-go milestones" task. There is more information available in #45461.dmitshur closed an issue golang.org/x/build/cmd/gopherbot: doesn't skip issues that were transferred1d
dmitshur commented on golang.org/x/build/cmd/gopherbot: doesn't skip issues that were transferred1d
Closing as duplicate of #40640.dmitshur commented on cmd/go: a package that ends with `_test` cannot have an internal test package1d
It may be relevant here that it's possible to have a "test-only" package: one that has tests but no code. In that case, the package name can only inferred from package tests. Consider:
```
-- go.…dmitshur merged a change golang.org/x/build/cmd/gopherbot: add more deleted issues to deletedIssues map1d
dmitshur merged a change golang.org/x/build/cmd/gopherbot: disable "set vscode-go milestones" task1d
dmitshur commented on golang.org/x/build/cmd/gopherbot: add more deleted issues to deletedIssues map1d
(1 comment)
Thanks, fixed.dmitshur closed an issue github.com/gopherjs/gopherjs: Consider embedding Go standard library into GopherJS binary.1d
dmitshur commented on github.com/gopherjs/gopherjs: Consider embedding Go standard library into GopherJS binary.1d
This proposal ended up being considered in #941 (as "Alternative 2"), but ultimately [not chosen](https://github.com/gopherjs/gopherjs/issues/941#issuecomment-583767534). The alternative solution of …dmitshur commented on github.com/gopherjs/gopherjs: Detect when gopherjs binary Go version != GOROOT version, exit with helpful error.1d
Yes, this ended up being a subset of #941 and got implemented in #966 in Feb 2020.dmitshur reviewed +2 on cmd/go/internal/modload: actually set the depth field passed to newRequirements2d
Will there be tests that catch this in the future?dmitshur opened a change golang.org/x/build/cmd/gopherbot: disable "set vscode-go milestones" task2d
The maintner data model doesn't expose when an issue gets transferred
from one repo to another (that's golang.org/issue/37370), so GopherBot
currently doesn't skip transferred issues when…dmitshur opened an issue golang.org/x/build/cmd/gopherbot: doesn't skip issues that were transferred2d
GopherBot doesn't skip issues that were transferred from one GitHub repository to another when processing them. The "set vscode-go milestones" task recently added in [CL 308350](https://golang.org/cl…dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: configure all vscode-go issues to be marked Untriaged2d
dmitshur reviewed +1 on golang.org/x/website/_content/doc: fix grammar in mod.md2d
Thank you.dmitshur reviewed +2 on golang.org/x/build/buildlet: use plan9LogWriter only on GCE2d
(2 comments)
Add 'cmd/' in front of buildlet.
It sounds like we've narrowed this down, so let's update the name and comment accordingly to provide more information, something like:
…dmitshur commented on golang.org/x/build/cmd/makemac: add changes to enable a migration to a new cluster2d
(1 comment)
The comment says Done but point 2 isn't addressed (the '/*' suffix is still there in patch set 5), is that unintentional?dmitshur commented on time: Europe/Dublin timezone handling broken with embedded timezone database [1.15 backport]2d
Approving per discussion in a release meeting. This backport applies to both 1.16 (#45385) and 1.15 (this issue).dmitshur commented on time: Europe/Dublin timezone handling broken with embedded timezone database [1.16 backport]2d
Approving per discussion in a release meeting. This backport applies to both 1.16 (this issue) and 1.15 (#45384).dmitshur commented on runtime: timeout in TestNeedmDeadlock on darwin-amd64-10_12 builder2d
Friendly ping after 2 weeks since it's a release blocking issue for Go 1.17.dmitshur commented on runtime: TestSelectStackAdjust "failed to trigger concurrent GC"2d
There's a new occurrence today.dmitshur commented on os: TestDirFS failing on plan9 since CL 2963912d
@rsc Can you please take a look since this is a release blocking issue in NeedsDecision state?dmitshur reviewed +1 on golang.org/x/build/cmd/makemac: add changes to enable a migration to a new cluster2d
These are the only remaining comments I have, I'm happy with this. +1 because I didn't review this as thoroughly since Alex did. Thanks.
Since the suggestion on line 13 was used, update this…dmitshur commented on golang.org/x/build/cmd/makemac: add changes to enable a migration to a new cluster2d
(6 comments)
Is it intentional that 10-15 uses a dash while the 10_11 and the rest use an underscore?
While here, maybe also s/osx_version/macos_version/ or so.
Nit: Maybe this can be shortened to…dmitshur commented on golang.org/x/build/cmd/gopherbot: configure all vscode-go issues to be marked Untriaged2d
This looks good, minor comments.
Since the milestones from different repos are separate namespaces, consider s/untriaged/vscodeUntriaged/ to make it stand out more.
Maybe move this into a separate …dmitshur commented on sync: misleading comment in map.go about entry type while p == nil2d
I noticed the comment in the `golang.org/x/sync/syncmap` package is in a `pre_go19.go` file, since after Go 1.9 it just does `type Map = sync.Map`. So it's probably not a big deal to leave it as is.dmitshur reviewed +2 on golang.org/x/build/dashboard: rename plan9-amd64-9front builder to plan9-386-0intro2d
David, are you able to leave a Trust+1 and submit this when it's ready from your side?dmitshur commented on runtime/cgo: document Handle better3d
CC @oakad, @changkun, @ianlancetaylor.dmitshur closed an issue golang.org/x/blog: Recursive link on Developer Survey Results 20203d
dmitshur commented on golang.org/x/blog: Recursive link on Developer Survey Results 20203d
Thanks @dtchanpura and @qmuntal. The latest x/blog commit has been deployed now, so I'll close this.dmitshur commented on misc/wasm: wasm_exec.js not protected against growth in a few try/catch cases3d
CC @neelance, @cherrymui via [owners](https://dev.golang.org/owners).dmitshur commented on golang.org/x/website/internal/dl: remove mac osx file regexp3d
(3 comments)
The regexp still exists, we're just making it shorter, so:
internal/dl: simplify featured macOS file regexp
It's helpful to add a body that provides the motivation for mak…dmitshur commented on golang.org/x/website/internal/dl: remove mac osx file regexp3d
Thanks, this looks good. I made suggestions to improve the test.
Since this is using 1.16.3, let's include all releases available on golang.org/dl today to make this test even more useful:
```
…dmitshur reviewed +2 on Revert "internal/poll: implement a pipe pool for splice() call"3d
(1 comment)
From https://golang.org/wiki/CommitMessage#reverts:
> Edit the description to add the Gerrit CL number being rolled back next to or instead of the Git revision number.
Maybe it'…dmitshur commented on golang.org/x/build/cmd/gitmirror: 10 minute timeout on git fetch is incorrectly implemented, so git fetch may still block forever3d
April 7, 2021 edition:
1 month 13 days since last. Fixed with `kubectl delete pod …dmitshur commented on sync: misleading comment in map.go about entry type while p == nil3d
I believe this comment was originally added in [CL 37342](https://golang.org/cl/37342), and it also exists in `golang.org/x/sync/syncmap`.
CC @bcmills in case this is still familiar to you.dmitshur commented on testing: add more support to automatically cleanup temporary resources or temporary changes to the global environment3d
Adding `TB.Setenv` was an accepted proposal #41260.dmitshur reviewed +2 on golang.org/x/build/dashboard: rename plan9-amd64-9front builder to plan9-386-0intro3d
Just to point out, renaming a builder means previously built commits will need to be processed again, so builder renames are best done when there's a good reason. This rename makes sense to me an…dmitshur commented on testing: add more support to automatically cleanup temporary resources or temporary changes to the global environment3d
Most API additions to the `testing` package would likely need to go through the proposal process and get approved before being added. It is better to wait until the proposal is approved before sendin…dmitshur commented on golang.org/x/build/dashboard: rename plan9-amd64-9front builder to plan9-386-0intro3d
(1 comment)
I suspect this needs to be a builder name, it can't be a slowbot alias.dmitshur commented on golang.org/x/build/dashboard: remove known issue from darwin-arm64-11_0 builder3d
(1 comment)
s/arm64/amd64/
Here, and on line 9.dmitshur reviewed +2 on golang.org/x/build/dashboard: remove known issue from darwin-arm64-11_0 builder3d
dmitshur starred in github.com/adonovan/spaghetti4d
dmitshur edited the wiki4d
dmitshur commented on : golang path eroor visual studio4d
If this is an issue with the VS Code Go extension, please take a look at the [troubleshooting](https://github.com/golang/vscode-go/blob/master/docs/troubleshooting.md) and [help](https://github.com/g…dmitshur closed an issue : golang path eroor visual studio4d
dmitshur commented on golang.org/x/build/cmd/gopherbot: may exceed GitHub API rate limit4d
I'm going to retitle this issue to be about adding a health check and metrics to improve visibility into this issue, and close it since it's done.
We can file new issues for future improvements to…dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: update the count for amd64 Mac Hosts4d
dmitshur reviewed +2 on golang.org/x/build/dashboard: reconfigure host counts for darwin amd64 builders4d
dmitshur commented on testing: add more support to automatically cleanup temporary resources or temporary changes to the global environment4d
CC @mpvl via [owners](https://dev.golang.org/owners).dmitshur commented on : go eroor visual studio4d
Closing as the issue is empty.dmitshur closed an issue : go eroor visual studio4d
dmitshur commented on golang.org/x/website/internal/dl: ?mode=json&include=all don't list older unstable releases when there are newer stable releases5d
This is fixed. Old pre-release Go versions are now considered archived rather than not being included at all, and they show up both at the bottom of https://golang.org/dl/#archive and in the API with…dmitshur merged a change golang.org/x/website/_content/doc: fix go mod edit link in mod.md5d
dmitshur merged a change golang.org/x/website/internal/dl: include old unstable release in archive5d
dmitshur reviewed +2 on golang.org/x/website/_content/doc: fix go mod edit link in mod.md5d
dmitshur starred in github.com/peterhellberg/gfx6d
dmitshur pushed to
master in github.com/shurcooL/frontend6d
Earlier
dmitshur commented on golang.org/x/exp/cmd/gorelease: failing to build all of a sudden1w
I can't reproduce this with Go 1.16.3. Are you sure there aren't local changes causing it? Does `git status` show a clean working directory? What about `git clean -dx --dry-run`?dmitshur commented on golang.org/x/exp/x/exp: run 'go mod tidy'1w
(2 comments)
'x/' prefix is for issue titles, no need in CL subjects.
I can't reproduce this with go mod tidy, using Go 1.16.3. When I run 'go mod tidy' on commit 85be41e4509f41…dmitshur commented on golang.org/x/tools/go/analysis/passes/nilness: fixed slice not being considered as non-nil1w
(1 comment)
Please word wrap and don't use backticks (Markdown syntax), since the commit message is meant to be readable as plain text. See https://golang.org/wiki/CommitMessage and https://gola…dmitshur commented on cmd/cgo: pass end position info for C function arguments.1w
(2 comments)
Nit: This line is quite long and would be nice to word-wrap a bit, as described at https://golang.org/wiki/CommitMessage.
This likely can be simplified to just cmd since *exec.Cmd is a…dmitshur commented on golang.org/x/tools/cmd/bundle: de-duplicating identical imports1w
(1 comment)
This will work if the package name is the same as the last import path element, but that isn't always true. See the last paragraph of https://golang.org/issue/37689#issuecomment-5965…dmitshur commented on release: look for CLs with +2 but no Trust+11w
Ian came up with an idea for us to add a weekly task for someone on the Go team (we have a weekly rotation we can make use of) to look for CLs that have been reviewed but just need trust to become su…dmitshur closed a change golang.org/x/website/content/static/doc/tutorial: fix a typo in add-a-test.html1w
dmitshur commented on golang.org/x/website/content/static/doc/tutorial: fix a typo in add-a-test.html1w
This change is already submitted via CL 276772.dmitshur closed a change golang.org/x/website/content/static: remove internal/gen1w
dmitshur commented on golang.org/x/website/content/static: remove internal/gen1w
Closing as this is superseded by CL 291690 and related CLs in that stack.dmitshur reviewed +2 on golang.org/x/website/_content/doc: fix typos in modules reference1w
Thanks.dmitshur reviewed +2 on golang.org/x/website/internal/dl: include old unstable release in archive1w
Thank you. Let's hold off on submitting/deploying this since it's a Friday; I will take care of it next week.dmitshur commented on golang.org/x/image/image: bump x/text@v0.3.51w
I think this change is okay to submit if there's still desire.
It's waiting on outstanding code comments to be addressed (e.g., the signed-off line needs to be removed).
Optionally update t…dmitshur closed a change golang.org/x/website: internal/dl fix missing unstable releases when there are newer versions1w
dmitshur commented on golang.org/x/website: internal/dl fix missing unstable releases when there are newer versions1w
Thanks for the change. The change to behavior isn't the right way to fix the issue: old unstable releases should be considered archived instead. I'll close this in favor of https://golang.org…dmitshur commented on golang.org/x/website/internal/dl: include old unstable release in archive1w
(2 comments)
Maybe it's worth updating this test to check that the old unstable is a part of archived versions:
_, unstable, archive := filesToReleases(fs)
...
if got, want := list(…dmitshur commented on golang.org/x/website/internal/dl: include old unstable release in archive1w
(1 comment)
I also considered that with this change the JSON payload size goes from 470 KB to 650 KB (but becomes smaller after being compressed), which should be okay for now.dmitshur commented on golang.org/x/website/internal/dl: include old unstable release in archive1w
Thanks. I think we can proceed with this, see comments.
Let's add an updates line here pointing to an issue that lead to non-latest pre-release versions no longer appearing. (To make it visible …dmitshur closed an issue all: Go 1.15.11 release status1w
dmitshur closed an issue all: Go 1.16.3 release status1w
dmitshur commented on all: Go 1.16.3 release status1w
This release is done.dmitshur opened a change golang.org/dl/dl: add go1.16.3 and go1.15.111w
For golang/go#45334.
For golang/go#45333.dmitshur opened a change golang.org/x/website/internal/history: document Go 1.16.3 and Go 1.15.111w
For golang/go#45334.
For golang/go#45333.dmitshur commented on all: Go 1.16.3 release status1w
## Latest build: go1\.16\.3
- src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.16.3/go1.16.3.src.tar.gz))
- linux\-386 ([tar\.gz](https://golang-release-staging.storage.goog…dmitshur commented on all: Go 1.16.3 release status1w
## PROBLEMS WITH RELEASE
- RELEASE BUILD FAILED
- **Found errors during release. Stopping!**
## Latest build: go1\.16\.3
- src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/…dmitshur commented on all: Go 1.15.11 release status1w
## Latest build: go1\.15\.11
- src ([tar\.gz](https://golang-release-staging.storage.googleapis.com/go1.15.11/go1.15.11.src.tar.gz))
- linux\-386 ([tar\.gz](https://golang-release-staging.storage.g…dmitshur commented on all: Go 1.16.3 release status1w
## Log
2021/04/01 11:27:00 starting
2021/04/01 11:27:00 working in /Users/dmitshur/go-releasebot-work/go1.16.3
2021/04/01 11:27:00 $ git clone https://go.googlesource.com/go /Users/dmit…dmitshur merged a change golang.org/x/build/cmd/coordinator: add health check for M1 Mac minis1w
dmitshur opened a change golang.org/x/build/cmd/coordinator: add health check for M1 Mac minis1w
Make the health dashboard more useful by displaying
the status of the darwin/arm64 reverse builders.
For golang/go#39782.
For golang/go#45336.dmitshur opened an issue golang.org/x/build: M1 builders are offline1w
From https://farmer.golang.org:
```
host-darwin-arm64-11_0-toothrot: 0/0 (2 missing)
```
CC @toothrot, @golang/release.dmitshur reviewed +2 on : [release-branch.go1.15] go1.15.111w
dmitshur reviewed +2 on : [release-branch.go1.16] go1.16.31w
dmitshur commented on golang.org/x/website: fixed "go edit" command1w
That is not expected, since there is a '=' character in the replace value.
Please file an issue at https://golang.org/issue/new and fill in the template so we can try to reproduce it. Thanks.dmitshur starred in github.com/mmcloughlin/mathfmt1w
dmitshur pushed to
master in github.com/golang/groupcache1w
dmitshur merged a change github.com/golang/groupcache: add back Context type as alias to context.Context1w