Yesterday
dmitshur commented on golang.org/x/tools/cmd/godoc: TestNoMainModule failing at head3h
The problem was that the behavior of `go list -m all` when executed in outside of any module (i.e., when `go env GOMOD` reports `os.DevNull`) has changed between 1.13 and tip, so `buildList` started …
dmitshur opened an issue cmd/go: 'go list -m all' and 'go list -m ...' started to produce different results on tip3h
With Go 1.13, both `go list -m all` and `go list -m ...` return the same results when executed outside of a module (i.e., when `go env GOMOD` reports `os.DevNull`): ``` $ cd $(mktemp -d) $ expor…
dmitshur commented on golang.org/x/website/internal/dl: redirect to downloadBaseURL for GPG signatures5h
I've redeployed the website with this fix, so it's live now. $ curl -Ls https://golang.org/dl/go1.13.4.src.tar.gz.asc | head -n 1 -----BEGIN PGP SIGNATURE-----
dmitshur commented on golang.org/x/tools/imports: ability to customize behavior without needing to fork7h
As an update from my side, I made this feature request 4 years ago only because the GopherJS Playground needed to fork this package. I haven't had any other need for it since then, and the GopherJS P…
dmitshur commented on golang.org/x/build/dashboard: add macOS 10.15 Catalina builder9h
(3 comments) Nit: Other sentences begin with a past tense verb, so perhaps change this to "Added" for conistency. In general, prefer using the shortlink format https://golang.org/issue/35698 over a…
dmitshur commented on golang.org/x/tools/txtar/archive: add unit test function for Format10h
(1 comment) Minor note for future CLs to improve consistency of commit messages. One of the guidelines at https://golang.org/wiki/CommitMessage is: > • the text should be wrapped to ~76 character…
dmitshur commented on golang.org/x/build/dashboard: add macOS 10.15 Catalina builder11h
(1 comment) Can you add a small test for this? It would just take all the Mac builders, add test that their ExpectNum sum is 20. That way it's more clear which builders are included, and tests will …
dmitshur commented on golang.org/x/build: trybot-result-changers Gerrit group doesn't allow removing TryBot-Result votes11h
The current status of the issue is: > I'll leave this issue open to decide what to do with trybot-result-changers group, but otherwise I believe this is resolved now. If we don't need an open issue…
dmitshur commented on golang.org/x/build: "website", "build" not on dashboard15h
No worries. I just don't want us to lose track of this.
dmitshur commented on golang.org/x/build: "website", "build" not on dashboard15h
[CL 207852](https://golang.org/cl/207852) said "Fixes" but https://build.golang.org/ doesn't have x/build repo yet. Re-opening until it shows up so we don't lose track of this.
dmitshur commented on golang.org/x/build/buildlet: add context argument to Client.Exec15h
(2 comments) I leave nitpicky improvement suggestions sometimes, but they're always optional. I recall from previous conversations about it that x/build is primarily for our use and has looser supp…
dmitshur reviewed +2 on golang.org/x/build/app/appengine: add x/build to the build dashboard15h
(1 comment) From doing CL 177658, I know it'll take more to get it to actually start building. I think we lost/forgot what it takes to bootstrap a new repo so that it starts getting tested due to co…
dmitshur commented on golang.org/x/build: make trybots post their status report upon cancelation1d
@bradfitz Now that `trySet.cancelBuilds` is implemented as of [CL 207842](https://golang.org/cl/207842), does "trybots cancel themselves due to a new patchset version" happen? This is related to @agn…
This Week
dmitshur commented on golang.org/x/build: give a few people access to delete TryBot-Result label, but not change it1d
/cc @FiloSottile FYI, since you're changing or considering changing Gerrit permissions.
dmitshur commented on golang.org/x/build: trybot-result-changers Gerrit group doesn't allow removing TryBot-Result votes1d
/cc @FiloSottile FYI, since you're changing or considering changing Gerrit permissions.
dmitshur commented on golang.org/x/build: all Packet linux/arm64 builders down1d
Same outcome as https://github.com/golang/go/issues/32543#issuecomment-500649475 and https://github.com/golang/go/issues/32543#issuecomment-500651162. The server was unreachable; restarting it via Pa…
dmitshur commented on golang.org/x/build/cmd/coordinator: implement trybot set cancellation1d
I understand what's implemented now is that when a "Run-TryRun" vote is deleted in Gerrit, the try run is canceled. For example, see https://go-review.googlesource.com/c/sys/+/207858/3#message-dfc5c6…
dmitshur reviewed +2 on golang.org/x/build/buildlet: add context argument to Client.Exec1d
(2 comments) Not seeing issues, but this should be submitted carefully. Not sure what's up with all trybots being in waiting_for_machine state. I filed #35708 for the Packet builder outage, but tha…
dmitshur opened an issue golang.org/x/build: all Packet linux/arm64 builders down1d
From https://farmer.golang.org/#health: <img src="https://user-images.githubusercontent.com/1924134/69208155-8ebf9280-0b20-11ea-8476-fd9509aa4245.png" width=358px> Previously: - #35524 - #3…
dmitshur reviewed +2 on golang.org/x/build/cmd/coordinator: implement trybot set cancellation1d
(1 comment) Not seeing issues, but I'm not very clear on the use of mutexes here, so I asked a question inline. Question regarding the comment on top: // LOCK ORDER: // statusMu, buildSt…
dmitshur commented on golang.org/x/build/cmd/coordinator: implement trybot set cancellation1d
(2 comments) This comment is becoming out of date as the new field is added. Based on position where the canceled field is added to trySet (under trySet.mu), I'd expect ts.mu to need to be locked. …
dmitshur commented on golang.org/x/build/cmd/coordinator: trybot (slowbot) was in a "running" state for 2+ hours1d
Ok, so the situation was that the AIX builder was already occupied doing another build, so the slowbot was waiting for the builder to free up. That does sound like things are working as intended. …
dmitshur opened an issue golang.org/x/build/cmd/coordinator: trybot (slowbot) was in a "running" state for 2+ hours1d
While in the process of deploying a new version of coordinator with @cagedmantis, one of the active trybot runs was a slowbot run for patch set 2 of [CL 207858](https://golang.org/cl/207858). What st…
dmitshur commented on golang.org/x/sys/unix: use same TestSelect on all Unices1d
(I stopped the slowbots because they already ran, and the new patch set is just a commit message edit.)
dmitshur reviewed +2 on golang.org/x/build/dashboard: add macOS 10.15 Catalina builder1d
(2 comments) LGTM, just minor comments. Nit: I think the word "builder" is missing here. This one too. You can fix both.
dmitshur commented on golang.org/x/build/dashboard: add macOS 10.15 Catalina builder1d
(3 comments) Can you elaborate a bit or point to some resource as to why that is? It seems unexpected to me, so I'd like to learn. It doesn't need to be very detailed. Without context, this may loo…
dmitshur commented on all: cleanup repository root2d
While working on #32011, I found that x/tools/cmd/godoc currently depends on favicon.ico existing in GOROOT. We need to resolve that to be able to proceed with removing it from the Go repo.
dmitshur commented on golang.org/x/tools/cmd/godoc: reduce scope to display documentation only, remove the rest of golang.org website2d
As I was prototyping a fix for this, it became more clear it should be viable to move more quickly and simply remove the /doc/ tree altogether, without any kind of intermediate message. The reason th…
dmitshur commented on golang.org/x/tools/cmd/present: support play snippets in module mode2d
To clarify, since you're running `GO111MODULE=on present` without any flags, this issue is about the local play execution mode (rather than using play.golang.org), without using Native Client (which …
dmitshur opened an issue golang.org/x/tools/cmd/present: remove/hide/disable Native Client for Go 1.14 or newer2d
Go 1.13 is the last release that runs on Native Client (NaCl), as mentioned at https://golang.org/doc/go1.13#ports. `present` has a flag and mode to use Native Client: ``` $ present -help ...…
dmitshur commented on : Bug multiplying a float32(variable(int)) with a float32 variable2d
`float32` has lower precision than `float64`, and may not be enough to represent the result of the multiplication with enough precision: ```Go package main import ( "fmt" ) func main() {…
dmitshur commented on golang.org/x/build/cmd/coordinator: tar file entry [...] contained unsupported file type Lrwxrwxrwx2d
> Btw., what's the reason that some of the golang.org/x/* subrepos are missing from the Dashboard? Some of the golang.org/x repos are new-ish and it hasn't been done yet. Some weren't possible to te…
dmitshur commented on wiki: recommended Ubuntu port still does not have security fix release3d
Thanks. I'll close this because the original issue is resolved by now (and so the title has become misleading) and there's nothing left to do here. Moving mature wiki content behind gerrit is already…
dmitshur commented on cmd: vendor in new version of x/tools3d
(1 comment) > How did non-gofmt'd get checked into x/tools? It is gofmt'd according to gofmt in Go 1.13.4 and current tip (2bde3c13, Nov 18).
dmitshur deleted branch in github.com/shurcooL/home3d
notifv2
dmitshur pushed to master in github.com/shurcooL/home3d
8ee97aee1d51c0af4c98f7bc0c4c08d2b4c81ab9regenerate assets
7e5b644ccfa8e7aab6791c9b490ea97b92f528e2start using new notification v2 service and app
de299fb51c4abb1143e28e80afda5e838282938achange dmitshurSeesGitHubNotifications to support Gerrit notifications
ff4a7a38f74da19df1da99788f457b4ab03973f8make homeRouter and dmitshurSeesHomeRouter implement gerrit.Router
e575f39873a404af4162f85aeaaa0f70fe92548einternal/exp/app: add initial notifications app v2 implementation
67ded33ee2fdf32b48e7c4cff70167316f6fe179internal/exp/service: begin the notification service v2 initiative
4d1b3ecaf0d67a1dde7238802338e699f5238cfdadd http.Flusher support to http.ResponseWriter implementations
dmitshur opened a change github.com/shurcooL/home: begin the notification service and app v2 initiative3d
I'm very used to visualizing notifications from GitHub (and lately, Gerrit) in the form of threads. Each issue/PR/CL with new activity shows up as a single entry, grouped by repo: <details><summar…
dmitshur created branch in github.com/shurcooL/home3d
notifv2
dmitshur pushed to master in github.com/shurcooL/home3d
021485b828e73be3a41feea288c331ff12c51974add invalid dmitri.shuralyov.com/test/modtest2 test module
dmitshur starred in github.com/jondot/goweight3d
dmitshur pushed to master in github.com/shurcooL/markdownfmt4d
21fe95c248e9e736a338d45003c31c29b46b69deREADME: add Flowmark to list of alternatives
dmitshur reviewed +2 on github.com/shurcooL/markdownfmt: Add link to Flowmark4d
Thank you. LGTM.
Last Week
dmitshur commented on net/http: rename tests for Redirect and StripPrefix4d
This change is ready for review.
dmitshur commented on github.com/shurcooL/vfsgen: vfsgen broken after upgrading to golang 1.134d
`vfsgen` itself doesn't do `go get`. Are you using the [`vfsgendev`](https://github.com/shurcooL/vfsgen#vfsgendev-usage) command? I suspect the problem is that the `vfsgendev` command was designed…
dmitshur commented on golang.org/x/tools/blog: fix swallowed error4d
> I'm running Debian Linux. I didn't pump in 34 spaces, just a newline. Ok. What browser? The change looks good aside from the commit message formatting. I can either fix it by editing the GitHub P…
dmitshur commented on doc: remove conduct.html (moved to x/website)5d
(1 comment) What is the motivation for making this change? It will affect https://tip.golang.org. Links on it will point to https://golang.org/conduct instead of https://tip.golang.org/conduct. Is …
dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: update README5d
(1 comment) Thank you for sending this update. All of the changes look good, and I believe it addresses all staleness issues. If you don't mind, could you fix a small typo (from a recent CL) here a…
dmitshur reviewed +2 on golang.org/x/website/static/doc: copy Code of Conduct, static/doc/conduct.html, from Go repo5d
(1 comment) See one question in an inline comment. LGTM. Should this phrase be updated, since there are now two project stewards rather than one, or is it okay to leave as is?
dmitshur commented on golang.org/x/website/static/doc: copy Code of Conduct, static/doc/conduct.html, from Go repo5d
(1 comment) Are you planning to also send a CL to Go repo to remove the copy there that will no longer be used? See CL 199117 and CL 199057 as past examples. The motivation for doing this is so peop…
dmitshur commented on golang.org/x/website/content: update README5d
(1 comment) Done.
dmitshur commented on golang.org/x/tools/cmd/godoc: don't execute go mod download when GOMOD is /dev/null5d
Since there isn't any new feedback and this already has a +2, I plan to submit soon.
dmitshur opened an issue golang.org/x/build/cmd/coordinator: trybots don't work on golang.org/dl repo1w
There are two issues: 1. The trybot builds start, fail, and keep retrying indefinitely. It's been 2 hours since https://go-review.googlesource.com/c/dl/+/207097/1#message-2732030f20d3db705eb32433dda…
dmitshur commented on golang.org/dl/gotip: command should override GOROOT with its tip packages location1w
Which version of `gotip` are you using? Is it the latest? I believe this exact change was very recently implemented via [CL 206537](https://golang.org/cl/206537) and issue #35507. Please let me know…
dmitshur commented on golang.org/x/tools/cmd/godoc: reduce scope to display documentation only, remove the rest of golang.org website1w
This is the current godoc web server tree: http://localhost:6060/ main landing page http://localhost:6060/doc/ serve from $GOROOT/doc - spec, mem, etc. http://localhost:6060/src/ serve files…
dmitshur pushed to master in github.com/shurcooL/home1w
afe2cda33e5ffbbbd9cabe08cbe6162172f4f731add IssueEventURL and PullRequestEventURL methods
dmitshur pushed to master in dmitri.shuralyov.com/route/github1w
7e79d56078638d1d7d4d6853af037d67de3f9589add IssueEventURL and PullRequestEventURL to Router
dmitshur commented on cmd/doc: module documentation1w
Thanks for making this proposal. I have considered this problem space in the past and wrote a proposal draft related to "module comments", but upon review and thinking more about it, I've realized…
dmitshur commented on : define module comment convention for module documentation1w
I am closing this issue because this is a proposal draft that I am withdrawing at the time; I don't actually propose we make this change now. It was posted to make information and relevant considerat…
dmitshur opened an issue : define module comment convention for module documentation1w
**Note:** This was a draft of a proposal that I decided against proposing at the time. I'm posting it at this time to share information and considerations relevant to this topic. See [comment below](…
dmitshur commented on github.com/go4org/go4: Go 1.13 doesn't like this lib1w
The upstream issue was fixed, see https://github.com/moov-io/ofac/issues/167#issuecomment-553019500. > Closing this issue then. That sounds like the right thing to do. (It hasn't been done yet.)
dmitshur commented on github.com/go4org/go4: Go 1.13 doesn't like this lib1w
The issue is in the ofac library. The canonical pseudo-version for commit 94abd6928b1da39b1d757b60c93fb2419c409fa1 is `v0.0.0-20190313082347-94abd6928b1d`: ``` $ cd $(mktemp -d) $ GO111MODULE…
dmitshur opened an issue github.com/moov-io/ofac: latest version requires an invalid go4.org version1w
In commit 9844e58018f379b5bc948813edba6ff91df80449, the go4.org module requirement was updated to an invalid pseudo-version. In commit 6e70f243f0c77aab203053a0d91edfba36a534e1, a replace directive wa…
dmitshur commented on github.com/go4org/go4: Go 1.13 doesn't like this lib1w
> I'm using a library that uses "go4.org/syncutil" > > The author also included this in the go.mod file: replace go4.org v0.0.0-20190430205326-94abd6928b1d => go4.org v0.0.0-20190313082347-94abd6928b…
dmitshur commented on golang.org/x/tools/internal/imports: TestScanNestedModuleInLocalReplace and 3 more failing on Go tip1w
> Tip go needs to be the first thing on $PATH. All other `golang.org/dl/go...` binaries arrange for that to happen, as @bcmills just said. `golang.org/dl/gotip` needs to be fixed to do the same. F…
dmitshur opened an issue golang.org/dl/gotip: needs to add its go binary to PATH1w
I tested with a small program: <details><summary>main.go source</summary><br> ```Go package main import ( "fmt" "log" "os/exec" ) func main() { goBin, err := exec.LookPath("go")…
dmitshur opened an issue golang.org/x/tools/internal/imports: TestScanNestedModuleInLocalReplace and 3 more failing on Go tip1w
From https://build.golang.org and https://go-review.googlesource.com/c/go/+/204830/4#message-7c1298f605c9bae9bf98fc61fbd88c2b029bdcb1: ``` --- FAIL: TestScanNestedModuleInLocalReplace (0.03s) …
Earlier
dmitshur commented on 82ea753aa2a8050fc7799c18afc81300d8547d1cgithub.com/FiloSottile/mkcert/analysis.go: use x/tools/go/analysis/multichecker to run analysis tools1w
Yeah, only the "2019" part of "2019.2.3" refers to the year. The other numbers are like minor and patch components of semver, except they are omitted when 0 (similar to Go's versioning scheme).
dmitshur commented on 82ea753aa2a8050fc7799c18afc81300d8547d1cgithub.com/FiloSottile/mkcert/analysis.go: use x/tools/go/analysis/multichecker to run analysis tools1w
From https://golang.org/cmd/go/#hdr-Package_lists_and_patterns: > As a special case, if the package list is a list of .go files from a single directory, the command is applied to a single synthesi…
dmitshur commented on 82ea753aa2a8050fc7799c18afc81300d8547d1cgithub.com/FiloSottile/mkcert/analysis.go: use x/tools/go/analysis/multichecker to run analysis tools1w
Staticcheck project has [releases](https://github.com/dominikh/go-tools/releases), although they are implemented as pre-release versions. Have you considered using the latest release version ([`v0.0.…
dmitshur commented on github.com/shurcooL/githubv4: BodyHTML doesn't exist on type Issue1w
```Go BodyHTML github.String `json:"bodyHTML"` ``` You should use "graphql" tag, not "json", to specify the name of the GraphQL field: ```Go BodyHTML github.String `graphql:"bodyHTML"` ```
dmitshur commented on golang.org/x/build/cmd/gerritbot: Gerrit edits are immediately overwritten by older GitHub commits1w
From https://github.com/golang/go/issues/35464#issue-520171770: > When I want to take over a CL in Gerrit, I can forge the author and work in peace. > > If I want to take over a CL in Gerrit tha…
dmitshur opened an issue golang.org/x/tools/cmd/godoc: better output when running with GOMOD=/dev/null1w
When running `godoc` in module mode while outside of any module (i.e., where `go env GOMOD` reports `/dev/null`), `godoc` displays only the Go packages that are available in the standard library. How…
dmitshur commented on golang.org/x/tools/cmd/godoc: module support1w
For those who are following this issue because you are waiting for module support in the `godoc` command ([golang.org/x/tools/cmd/godoc](https://golang.org/x/tools/cmd/godoc)), please note that it ha…
dmitshur commented on go test -args Tips flag provided but not defined: -test.timeout1w
The Go 1.13 release notes mention a change that affects the `testing` package at https://golang.org/doc/go1.13#testing: <blockquote><!-- CL 173722 -->Testing flags are now registered in the new <a…
dmitshur commented on golang.org/x/tools/cmd/godoc: add module support1w
Thanks for pointing that out and the comments on the CL Bryan. I'd like to track that in a separate issue, since it's specific to Go 1.14, which isn't out yet. I want this issue to be available fo…
dmitshur opened an issue golang.org/x/tools/cmd/godoc: support automatic vendoring in Go 1.141w
Quoting @bcmills from https://github.com/golang/go/issues/33655#issuecomment-551202512: > [godoc] doesn't play nicely with automatic vendoring in 1.14 (#33848): > > ``` > ~/go/src/cmd$ go versi…
dmitshur commented on golang.org/x/tools/cmd/godoc: add module support1w
[CL 196983](https://golang.org/cl/196983), which will resolve this issue, is now ready and I plan to submit it later today. It implements the behavior described above.
dmitshur commented on golang.org/x/tools/internal/lsp: frequent out-of-memory errors on windows-amd64-race builder2w
Bryan, how does n1-highcpu-8 for -longtest and n1-standard-4 for the rest (normal and -race) sound?
dmitshur commented on golang.org/x/tools/internal/lsp: frequent out-of-memory errors on windows-amd64-race builder2w
I agree we should increase the memory for the -race builder at the very least. In order to do that, we need to make a decision about the machine type to use next. Right now all the windows/amd64 h…
dmitshur commented on golang.org/x/build/app/appengine: deploying with dirty working tree affects the deploy2w
@bradfitz Is there more to do here, or did [CL 205597](https://golang.org/cl/205597) fix this by adding the `.cloudignore` file?