Activity
Today
dmitshur reviewed +2 on golang.org/x/review/git-codereview: make hooks command report conflicting hooks4m
See inline comments for tests, otherwise I think this is okay to submit. Thanks.
This `TestHooksOverwriteOldCommitMsg` test is supposed to be testing that the old commit-msg hook is still being rewr…dmitshur commented on golang.org/x/build/main.star: enable Mac builders1h
(1 comment)
This seems viable to drop since all Mac builders specify an exact OS version now.
(No action needed now, just mentioning.)dmitshur opened a change golang.org/x/build/main.star: format and correct a few dates1h
Apply lucicfg fmt.
Doesn't matter much, but macOS 11 was released in Nov 2020 (along
with the first Apple silicon Macs). In June it was only announced.dmitshur reviewed +2 on golang.org/x/build/main.star: enable ARM64 Macs1h
Woohoo!dmitshur reviewed +1 on golang.org/x/build/dashboard: clean up at least 1.20 conditions1h
Thanks, nice cleanup. LGTM % unresolved comment.dmitshur reviewed +1 on golang.org/x/build/dashboard: clean up at most 1.19 builders1h
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/buildlet: add support for the gomote server1h
Thanks.
(optional) Right now the 'dialServer' path is being taken in swarming bot mode by modifying the if statement on line 249.
Since it seems the swarming bot mode is more like reverse than non-…dmitshur reviewed +1 on golang.org/x/build/devapp/owners: explain how reviews are assigned5h
Thanks.dmitshur reviewed +2 on golang.org/x/build/devapp/owners: link paths to Gerrit5h
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/relui: fix broken signing workflow6h
Thanks.
I see, thanks for explaining the context. I agree the copy is justified given it avoids that complexity now.
Using runBuildStep looks like a good improvement, thanks.
```suggestion
func (b…Yesterday
dmitshur opened an issue cmd/go: toolchain selection interacts unexpectedly with non-standard toolchains1d
dmitshur commented on golang.org/x/build: builder issues bringing up new ports1d
@4a6f656c Friendly ping (trying on GitHub too) on [CL 521356](https://go.dev/cl/521356). Otherwise I can try to carry it forward next week. Thanks.This Week
dmitshur commented on golang.org/x/tools/go/ssa: panic: type param without replacement encountered [1.21 backport]1d
The release-blocker here is inherited from the upstream issue (https://github.com/golang/go/issues/63260#event-10501492244 + https://github.com/golang/go/issues/63260#event-10501491205). (CC @findley…dmitshur commented on golang.org/x/tools/go/ssa: panic: type param without replacement encountered1d
Moving this to the Go 1.22 milestone to track the fix at tip, and copying @rfindley's release-blocker label to the backport issue (which now tracks the fix for Go 1.21.3). Please feel free to remove …dmitshur commented on golang.org/x/build/internal/relui: fix broken signing workflow1d
(5 comments)
Yep. FWIW, moving signed results next to unsigned ones is indeed how it used to work during the releasebot era. It was only with relui that we wanted to avoid different tasks/services w…dmitshur merged a change golang.org/x/website/cmd/locktrigger: migrate to cloud.google.com message types2d
dmitshur merged a change golang.org/x/website/internal/{gitfs,webtest}: use strings.Cut2d
dmitshur commented on golang.org/x/website/cmd/{adminapp,adminredirect,googlegolangorg}: update App Engine runtime2d
Unlike the main website, the deployment of these 3 services is manual. I happen to be on interrupts next week, so I'll come back to this then.dmitshur commented on golang.org/x/exp/container: support generics2d
Thanks for creating the CL. Since proposal #63235 is now closed (not accepted), adding wait-issue hashtag and moving reviewers to CC.dmitshur opened a change cmd/dist: emphasize when all tests are excluded2d
As observed in https://go.dev/issue/61666#issuecomment-1739476954,
if a -run flag value matches no tests, dist test output doesn't do much
to help users notice that was what happened. It is valid and…dmitshur commented on cmd/go/internal/modfetch: show real URL in error3d
This change is ready for review.dmitshur opened a change cmd/go/internal/modfetch: show real URL in error3d
CL 233437 added a redactedURL field to proxyRepo, a struct that already
had a field named 'url'. Neither fields were documented, so the similar
names suggest the most natural interpretation that prox…dmitshur opened a change cmd/go/internal/modfetch: avoid path.Join in URL errors, part 23d
CL 406675 added more detail to bare errors from net/http in two places.
CL 461682 improved one of the two places to stop folding "//" into "/".
This CL applies the same change to the other place.
Fo…dmitshur opened a change golang.org/x/build/internal/relui: use strings.CutPrefix3d
Delete some code in favor of std lib now that Go 1.19 is unsupported.dmitshur opened a change golang.org/x/review/git-codereview: use strings.Cut3d
Basic cut functionality is available in the standard library as of
Go 1.18, so today's supported Go versions (1.21 & 1.20) can use it.
Also simplify some slice and map code while here.dmitshur opened a change golang.org/x/website/internal/{gitfs,webtest}: use strings.Cut3d
Basic cut functionality is available in the standard library as of
Go 1.18, so today's supported Go versions (1.21 & 1.20) can use it.
Also delete cutAny since it was unused.Last Week
dmitshur opened a change golang.org/x/website/cmd/{adminapp,adminredirect,googlegolangorg}: update App Engine runtime6d
Keep them up with the times.dmitshur commented on github.com/shurcooL/githubv4: Add support for the GitHub security advisory endpoint in orgs and repos1w
The page you linked to is a part of the GitHub REST API. If that's what you're looking for, see https://pkg.go.dev/github.com/google/go-github/v55/github#SecurityAdvisoriesService. This repository ha…dmitshur commented on golang.org/x/build/cmd/gerritbot: avoid changing the content of comment sync messages1w
Sorry you ran into this, and thanks for adding the comment. It’s sometimes possible to catch these types of issues via the dry-run mode, but even that can only so far.Earlier
dmitshur commented on golang.org/x/build/main.star: use cipd_platform instead of os/arch where possible1w
(2 comments)
```suggestion
# TODO(mknyszek): Consider adding "_suffix" to the end of this.
```
`lucicfg fmt`?dmitshur reviewed +1 on golang.org/x/image/font/sfnt: support early version 0 OS/2 tables1w
dmitshur commented on golang.org/x/build/cmd/bootstrapswarm: default token file path to LUCI_MACHINE_TOKEN1w
Thanks.dmitshur commented on golang.org/x/build/cmd/bootstrapswarm: default token file path to LUCI_MACHINE_TOKEN1w
@heschi@google.com Is this going in the direction you intended given the discussion in #61666? Happy to adjust this or close if not.dmitshur commented on golang.org/x/build/main.star: start adding a js-wasm builder1w
(1 comment)
Updated both CLs. Done.dmitshur commented on golang.org/x/build/main.star: start adding a js-wasm builder1w
(1 comment)
We already use the 'os:Linux' dimension for coordinator builders (where, like here, any Linux is fine). It seems I can resolve this TODO by changing the expected_dimensions["os"] in crre…dmitshur reviewed +2 on golang.org/x/build/internal/task: fix cloud build support1w
Thanks.
If you haven't already, you could consider %q over %v, which might help if there are filenames with spaces in the future.
(minor)
The ServiceAccount field [docs](https://pkg.go.dev/cloud.g…dmitshur opened a change golang.org/x/build/cmd/bootstrapswarm: default token file path to LUCI_MACHINE_TOKEN1w
If LUCI_MACHINE_TOKEN is set in the environment (intended for the
swarming bot; added in crrev.com/i/6478812), also recognize it here
and use it as the default token file path flag value.dmitshur commented on golang.org/x/build: add LUCI solaris-amd64 builder1w
> `2023/09/22 11:24:17 unable to read file "/var/lib/luci_machine_tokend/token.json": open /var/lib/luci_machine_tokend/token.json: no such file or directory`
@rorth Sorry, that may have been a ty…dmitshur closed an issue log/slog: JSONHandler generates invalid JSON with empty Attr [1.21 backport]2w
dmitshur closed an issue cmd/go: error text for missing package import becomes confusing after toolchain selection2w
Thanks. I can confirm:
```
$ GOTOOLCHAIN=go1.20.7 go build
p.go:3:8: import "": import of unknown directory
$ GOTOOLCHAIN=go1.20.8 go build
go: downloading go1.20.8 (darwin/arm64)
p.go:3:8: p…dmitshur starred github.com/Antonio-R1/engine-sound-generator3w
dmitshur pushed to
master in github.com/shurcooL/gofontwoff3w
dmitshur starred artyom.dev/gofontweb3w
dmitshur opened an issue golang.org/x/build/cmd/gorebuild: expects go1.21.1.linux-armv6l.tar.gz and v0.0.1-go1.21.1.linux-arm.zip to be rebuildable without explicitly setting GOARM=63w
As visible at https://go.dev/rebuild, `gorebuild` has uncovered the possibility of non-reproducibility on go1.21.1.linux-armv6l.tar.gz (and its module zip version, v0.0.1-go1.21.1.linux-arm.zip) in t…dmitshur commented on golang.org/x/build/internal/task: provide a release archive with all the syso files, or release the files separately3w
The decision to not ship race detector syso files for other platforms was made in 2018 in cmd/release ([CL 144281](https://go.dev/cl/144281)), to reduce archive binary size. It was ported to cmd/relu…dmitshur closed an issue golang.org/x/build/internal/task: TestTagXRepos failures3w
Hasn't happened since the increased timeout.dmitshur closed an issue golang.org/x/build/internal/task: track TestGetDevelVersion failures3w
So far the data points suggest the flake rate is at an acceptable (to me) rate. At least it's not unreasonably high.
Closing since doesn't need active work and watchflakes will still post results.dmitshur reviewed +2 on github.com/mdempsky/unconvert: update deps, fixing support for Go 1.223w
LGTM. Thanks.dmitshur commented on golang.org/x/review/git-codereview: hooks does not re-install hooks3w
@BerndCzech Thanks for looking to contribute to Go. There is indeed an existing CL here, and a next step before it can be submitted is for it to be [reviewed](https://go.dev/doc/contribute#review). I…dmitshur commented on golang.org/x/build: turn down vcs-test.golang.org4w
This was waiting on #62076. Now that the off-cycle Go 1.19.13 release is published, I think this is unblocked.
This isn't urgent and probably a good task for someone who's on interrupts and has ti…dmitshur commented on golang.org/x/build/cmd/relui: go1.19.13 is tagged at wrong commit4w
The current relui logic is as follows:
```Go
publishingHead := wf.Task4(wd, "Check branch state matches source archive", build.checkSourceMatch, distpackVal, branchVal, versionFile, source, wf.Af…dmitshur closed an issue cmd/go: go get -u && go mod tidy behaves differently starting with Go 1.21.0, leading to unknown directive toolchain errors1mo
Yes, that appears to be what's happening.
As far as I can see, the root problem is that as of https://github.com/gofiber/fiber/pull/2588, the go.mod of the module github.com/gofiber/fiber/v2 state…dmitshur commented on image/jpeg: unsupported JPEG feature: luma/chroma subsampling ratio1mo
Issues #13614 and #2362 seem related.dmitshur commented on golang.org/x/mobile: ambiguous import error when running `go mod tidy`1mo
Sorry it's a bit confusing. There's a good description at https://go.dev/ref/mod#graph-pruning. Given this is only relevant to older Go versions that aren't supported by now, I don't think there's an…dmitshur commented on golang.org/x/mobile: ambiguous import error when running `go mod tidy`1mo
The go directive in x/mobile is set to 1.17. Given by now only Go 1.21 and 1.20 release, let's fix this by bumping to a newer Go language for the module: one of 18, 19 or 20.dmitshur commented on golang.org/x/mobile: support OpenGL ES 3 on Android1mo
To clarify, is this proposal to replace OpenGL ES 2 on Android with OpenGL ES 3? That is, to drop 2 and add 3 in its place?
Given Android 5 was released in 2014 and is unsupported since 2016, I ca…dmitshur commented on cmd/go: modules are rejected if any filename has a trailing `.`1mo
Oh, it does seem to match the documented behavior. [CheckFilePath](https://pkg.go.dev/golang.org/x/mod/module#CheckFilePath) docs say:
> The definition of a valid file path is the same as the defi…dmitshur commented on cmd/go: go mod tidy errors with `trailing dot in path element` if any filename has a trailing `.`1mo
Here's a smaller reproducer:
```
$ cd $(mktemp -d)
$ go mod init test
$ GOPATH=$(mktemp -d) GOPROXY=direct GOSUMDB=off go get github.com/chinmayb/notepad@v0.0.1
go: downloading github.com/chin…dmitshur commented on cmd/go: go get -u && go mod tidy behaves differently starting with Go 1.21.0, leading to unknown directive toolchain errors1mo
Thanks for reporting this. CC @bcmills, @matloob.
I wanted to clarify a part of the "What did you do?" section. Specifically, when you start out with a go.mod file with support for Go 1.17 through…dmitshur closed an issue os: Stdin.Stat().Size() always returns 0 with GOOS=wasip1 GOARCH=wasm1mo
CC @golang/wasm.dmitshur closed an issue security: fix CVE-2023-39320 [1.20 backport]1mo
dmitshur commented on spec: update unification rules1mo
@griesemer Sorry, I just noticed this issue in the Go1.21.1 milestone now. It was missed earlier because it didn't have the usual CherryPickCandidate label and "[1.21 backport]" suffix (see https://g…dmitshur commented on net/http: http client regression building with js/wasm and running on Chrome: `net::ERR_H2_OR_QUIC_REQUIRED` [1.21 backport]1mo
Approving after discussing with @neild and @johanbrandhorst. There's no workaround, and the fix is a safe revert to affecting only GOOS=js files.dmitshur commented on golang.org/x/crypto/pkcs12: unknown digest algorithm 2.16.840.1.101.3.4.2.11mo
CC @golang/security.dmitshur commented on runtime: documentation on runtime.Pinner and cgo slightly conflicting or confusing1mo
CC @golang/runtime.dmitshur commented on : extended forwards compatibility for Go1mo
@gaby Thanks for reporting, but this is a closed issue and it's not appropriate to investigate here. Both `go mod tidy` and `govulncheck` should be working successfully even with the default auto. Gi…dmitshur commented on golang.org/x/term: Cannot differentiate a CTRL+C from CTRL+D1mo
CC @tklauser, @hyangah.dmitshur commented on golang.org/x/crypto/ssh: investigate support for ping@openssh.com protocol extension1mo
CC @FiloSottile.dmitshur edited the wiki1mo
dmitshur commented on encoding/binary: add var NativeEndian; also x/sys/cpu.IsBigEndian1mo
Also moving back to Go1.21 milestone, since that's when this was completed.
(Gopherbot automatically moved it to the next milestone because it was still open.)dmitshur commented on cmd/go: `go mod download` needs to support toolchain upgrades [1.21 backport]1mo
@bcmills The release branches are planned to be frozen today. Given the upstream issue isn't resolved yet, and you said it might be better to let it slip to Go 1.21.2 instead of holding back the Go 1…dmitshur commented on github.com/shurcooL/Hover: hover--format of the “track1.dat” terrain???1mo
The track1.dat is an internal format of the game whose source code is located in this repository. You can refer to the Go reimplementation [track/track.go](https://github.com/shurcooL/Hover/blob/HEAD…dmitshur closed an issue cmd/compile: slight reorder of conditions in loop results in much slower code1mo
dmitshur edited the wiki1mo
dmitshur commented on cmd/go: go build -json1mo
Thanks for the detailed proposal.
I noticed currently there's no discussion of exit codes here. It's a small detail, but still fairly important in that each future consumer of the JSON will need t…dmitshur commented on golang.org/x/pkgsite: set up automated updating of x-repo dependencies1mo
Also see #56530, which I think this is either a subset or a duplicate of. It was waiting for the next friction fixit week, but we've discussed and agreed to up its priority, so I'm resuming work on i…dmitshur closed an issue golang.org/x/build/cmd/golangbuild: possibility of false-negatives in detecting successful command execution1mo
We discussed this and plan to let the fix land in the affected component. Nothing to do in golangbuild.dmitshur closed an issue golang.org/x/build: add gomote functionality to LUCI1mo
dmitshur commented on golang.org/x/build: update x/ dependencies in untagged x/ repos when applying tags1mo
One more data point: x/pkgsite is untagged so its x/mod dependency wasn't automatically updated. If this issue were resolved, #62031 might've been resolved sooner or avoided.dmitshur commented on golang.org/x/build: darwin-amd64-longtest builds are slow1mo
Revision 1081f8c0 has completed by now: https://build.golang.org/log/b6794b36aae821c21ac4dd69b38f795c412fabe0.
The other two are still running, but spent most of the 20 hours waiting for a builder…dmitshur commented on cmd/go: `-help` and `go version` are broken when go.mod contains non-standard version1mo
This issue still needs to be investigated. It it's determined that the current behavior is buggy, the fix will need to be developed for Go 1.22 first before it can be considered for backport.
To m…dmitshur opened an issue : "downloading go1.22"1mo
<!--
Please answer these questions before submitting your issue. Thanks!
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
</pre>
### Does this issue reproduc…dmitshur commented on golang.org/x/tools/gopls: latest gopls install fails on MacOS1mo
It's good that the workaround of disabling cgo works.
I'm not sure what's causing the problem when cgo is left enabled. It might be something about the environment you're running this on. Has inst…dmitshur starred github.com/nf/nux1mo
dmitshur created tag in github.com/go-gl/mathgl1mo
v1.1.0dmitshur commented on golang.org/x/tools/go/analysis/passes/nilness: wrong internal code comment // "x is nil, y is unknown"1mo
Thanks Siddharth, please feel free to mail a code change. See https://go.dev/doc/contribute for more information on the process.dmitshur commented on go/types: nil pointer dereference in go/types.(*StdSizes).Sizeof1mo
CC @cuonglm.dmitshur commented on golang.org/x/build/cmd/relui: go1.21.0.linux-armv6l built with GOARM=71mo
Indeed, thanks for reporting.
It was set to GOARM=6 in 1.20 and older because the release target used the [linux-arm-aws builder](https://cs.opensource.google/go/x/build/+/master:internal/releaset…dmitshur commented on golang.org/x/tools/gopls: gopls was broken with the latest tip version1mo
Can you elaborate on what you mean by "vim-go deosn't work with gopls."? In what way does it not work? If there's an error printed, what is its text? Or is there no error, just no functionality?
C…dmitshur commented on golang.org/x/tools/gopls: latest gopls install fails on MacOS1mo
What is your Xcode version? I think `xcodebuild -version` should print it. If it's Xcode 15 (beta), there are some known issues that are being worked on, e.g., see #61229, although this failure mode …dmitshur commented on cmd/compile: backward incompatible change in Go 1.21 type inference with channels1mo
CC @golang/compiler.dmitshur commented on cmd/link: index out of range at cmd/link/internal/ld.decodetypeKind1mo
Thanks for reporting.
CC @mdempsky.dmitshur commented on cmd/go: Backward incompatible change in Go 1.21 type inference with channels1mo
Thanks for reporting. Can you check if this is the same issue as #61903, which was recently resolved at tip, or not the same issue?dmitshur commented on os: stop special-casing Android and iOS in UserHomeDir1mo
> android was special-cased to return / in https://go.dev/cl/139717.
> The commit message and code-review comments do not explain why, as far as I can tell, and no code comment was added explaining …dmitshur closed an issue cmd/compile: IncompatibleAssign spreading slice of interface compliant types into variadic function accepting interface1mo
What does the Go language specification say about this?
I expect this is working as intended, and the https://go.dev/doc/faq#convert_slice_with_same_underlying_type entry covers this situation.
…dmitshur commented on log/slog: JSONHandler generates invalid JSON with empty Attr1mo
CC @jba.dmitshur commented on runtime: checkdead runnable g on RISC-V1mo
I might be able to help a bit sooner too. :)
Sent [CL 520900](https://go.dev/cl/520900).
FWIW, if you think it has a chance to help more, it's also fine to use go1.21.0 as the bootstrap for thi…dmitshur commented on go.dev: provide redirects to pkg.go.dev for popular repository names1mo
CC @golang/tools-team.dmitshur edited the wiki1mo