Activity
Today
dmitshur commented on golang.org/x/website/cmd/golangorg: use _goroot.zip during deploy tests too1h
Thanks.
I tested locally and it seems like it should do what's intended. I'll keep an eye on the next few deploys, too.dmitshur fixed an issue security: fix CVE-2026-27140 [1.26 backport]1h
Closed by merging [CL 763549](https://go.dev/cl/763549) (commit 096f21b1c50fe62bc54c1fb1ede60fca63239123) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-27140 [1.25 backport]1h
Closed by merging [CL 763556](https://go.dev/cl/763556) (commit abaa0cbb259e059ee60c33a7507eddc1fe7d20fa) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-32283 [1.25 backport]1h
Closed by merging [CL 763555](https://go.dev/cl/763555) (commit 02f574a8303560a4a79a42834f3092ce7c9a57cc) to release-branch.go1.25.dmitshur commented on security: fix CVE-2026-32283 [1.25 backport]1h
Closed by merging [CL 763555](https://go.dev/cl/763555) (commit 02f574a8303560a4a79a42834f3092ce7c9a57cc) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-32283 [1.26 backport]1h
Closed by merging [CL 763548](https://go.dev/cl/763548) (commit 7cafb4140d5616f1a0316a194a977b0794cd7d7c) to release-branch.go1.26.dmitshur commented on security: fix CVE-2026-32283 [1.26 backport]1h
Closed by merging [CL 763548](https://go.dev/cl/763548) (commit 7cafb4140d5616f1a0316a194a977b0794cd7d7c) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-27143 [1.26 backport]1h
Closed by merging [CL 763546](https://go.dev/cl/763546) (commit c4b4bd7b3aefeb67a541912df0733bde68333bfc) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-27143 [1.25 backport]1h
Closed by merging [CL 763553](https://go.dev/cl/763553) (commit 7d2dd3488cdfbddda14c18c455d3263df75a46fc) to release-branch.go1.25.dmitshur commented on security: fix CVE-2026-27143 [1.25 backport]1h
Closed by merging [CL 763553](https://go.dev/cl/763553) (commit 7d2dd3488cdfbddda14c18c455d3263df75a46fc) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-27144 [1.25 backport]1h
Closed by merging [CL 763552](https://go.dev/cl/763552) (commit 72cc33629a3b26e68f6e6e5564618a1d763896f3) to release-branch.go1.25.dmitshur commented on security: fix CVE-2026-27144 [1.25 backport]1h
Closed by merging [CL 763552](https://go.dev/cl/763552) (commit 72cc33629a3b26e68f6e6e5564618a1d763896f3) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-27144 [1.26 backport]1h
Closed by merging [CL 763545](https://go.dev/cl/763545) (commit 3a4577a2687ad46d2a00305ddb68733283ea0720) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-33810 [1.26 backport]1h
Closed by merging [CL 763544](https://go.dev/cl/763544) (commit ceb4da6626ce94d75b2aefd0f24c6d0fd74f45f9) to release-branch.go1.26.dmitshur commented on security: fix CVE-2026-33810 [1.26 backport]1h
Closed by merging [CL 763544](https://go.dev/cl/763544) (commit ceb4da6626ce94d75b2aefd0f24c6d0fd74f45f9) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-32289 [1.26 backport]1h
Closed by merging [CL 763543](https://go.dev/cl/763543) (commit babb1c32c2e7ee7a1147e7e587d35c553fb693ad) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-32289 [1.25 backport]1h
Closed by merging [CL 763551](https://go.dev/cl/763551) (commit 3ed316924408a02b256544eb40607e73702f2d0c) to release-branch.go1.25.dmitshur commented on security: fix CVE-2026-32289 [1.25 backport]1h
Closed by merging [CL 763551](https://go.dev/cl/763551) (commit 3ed316924408a02b256544eb40607e73702f2d0c) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-32282 [1.25 backport]1h
Closed by merging [CL 763550](https://go.dev/cl/763550) (commit 4c79c4223e42b4727d1600e71ad6983cfb21f534) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-32282 [1.25 backport]1h
Closed by merging [CL 763550](https://go.dev/cl/763550) (commit 4c79c4223e42b4727d1600e71ad6983cfb21f534) to release-branch.go1.25.dmitshur fixed an issue security: fix CVE-2026-32282 [1.26 backport]1h
Closed by merging [CL 763542](https://go.dev/cl/763542) (commit b6176f459ad7b84ea7fb8daab983f4cef644a119) to release-branch.go1.26.dmitshur commented on security: fix CVE-2026-32282 [1.26 backport]1h
Closed by merging [CL 763542](https://go.dev/cl/763542) (commit b6176f459ad7b84ea7fb8daab983f4cef644a119) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-32288 [1.26 backport]1h
Closed by merging [CL 763547](https://go.dev/cl/763547) (commit a34b5e4d55e39efc9af0d803969e9399a553acf3) to release-branch.go1.26.dmitshur fixed an issue security: fix CVE-2026-32288 [1.25 backport]1h
Closed by merging [CL 763554](https://go.dev/cl/763554) (commit 82b0cdb7411ea2cf02d3a45e6983cc7c8c009d9e) to release-branch.go1.25.dmitshur commented on security: fix CVE-2026-32288 [1.25 backport]1h
Closed by merging [CL 763554](https://go.dev/cl/763554) (commit 82b0cdb7411ea2cf02d3a45e6983cc7c8c009d9e) to release-branch.go1.25.dmitshur commented on golang.org/x/build: add Debian Trixie builders3h
The linux/arm64 trixie builder is also running into issue #66005 in x/arch:
https://ci.chromium.org/ui/p/golang/builders/ci/x_arch-gotip-linux-arm64_debian13 (e.g., https://ci.chromium.org/b/8685087…dmitshur commented on golang.org/x/build/env/netbsd-386: make anita-2.10.tar.gz.sha1 a plain file3h
Thanks.Yesterday
dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies failures during migration to pkgbits.{V3,V4}15h
The new failures happened during the migration to V4, and they should be fixed now by [CL 763770](https://go.dev/cl/763770). (CC @mrkfrmn.)dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies failures during migration to pkgbits.{V3,V4}15h
The new failures happened during the migration to V4, and they should be fixed now by [CL 763770](https://go.dev/cl/763770). (CC @mrkfrmn.)dmitshur reviewed +2 on doc/next: move 78137.md to the correct directory15h
Thanks.dmitshur commented on all: update to x/tools@f6476fbaabd396b58618b473e4eb71e1f532b49517h
Thanks.
In this case longtest builders got added automatically, so this would be more useful in future CLs where that doesn't happen rather than this particular one.dmitshur commented on all: update to x/tools@f6476fbaabd396b58618b473e4eb71e1f532b49518h
(1 comment)
Requiring a longtest builder (using "blocking" syntax from https://go.dev/wiki/SlowBots#using-slowbots) can be handy in cases like this:
```suggestion
Change-Id: Ib4a24dc214f58e77dfd299…dmitshur commented on cmd/compile/internal/noder: use UIR V419h
> a matter of pulling in CL 763122 into the main Go repo, similar to last time
That already happened in CL 763181, so there's more to it.dmitshur commented on cmd/compile/internal/noder: use UIR V419h
Longtest builders seem to break as of this change:
https://ci.chromium.org/b/8685147421891164545
Probably a matter of pulling in CL 763122 into the main Go repo, similar to last time when this was …dmitshur opened a change golang.org/x/website/cmd/golangorg: use _goroot.zip during deploy tests too20h
The deploy process constructs a _goroot.zip file which is used as the
source of main Go repository content when serving go.dev. Start using
the same _goroot.zip file when running tests in Cloud Build…dmitshur commented on golang.org/x/website/cmd/golangorg: temporarily skip check for "{{raw <code>" bad escaping21h
Thanks, and sorry about the breakage.dmitshur opened a change golang.org/x/website/cmd/golangorg: catch instances of bad escaping due to template use21h
Even though the deployed version of go.dev/doc/godebug no longer has
the "{{raw <code>" bad escaping, TestAll still fails during the deploy
process. This is because it turns out that it doesn't us…dmitshur commented on golang.org/x/website/internal/history: document Go 1.26.2 and 1.25.9 releases22h
(1 comment)
Since in general (and below) these tend to get given component names rather than using their import path, you could do that here (and for 1.25.9 below):
```suggestion
Components: []t…dmitshur commented on golang.org/x/website/internal/history: document Go 1.26.2 and 1.25.9 releases22h
(1 comment)
Since in general (and below) these tend to get given component names rather than using their import path, you could do that here (and for 1.25.9 below):
```suggestion
Components: []t…dmitshur commented on cmd/internal/testdir: do not fail fast when running asmcheck1d
Yes, in general purple failures are due to something going wrong with the infrastructure, rather than a problem found in the CL. See https://go.dev/wiki/LUCI#infra-failed--purple-failure.
There was …dmitshur reviewed +2 on all: update to x/tools@b36d1d12a1a724eb9be6609c9789aec3d99e60301d
Thanks.dmitshur commented on crypto/internal/fips140/mldsa: add accumulated field functions test1d
(1 comment)
A style question: it seems in this case the code would compile both if expected is a variable (as is now) and if it's changed to a `const`. Is there a reason to prefer a variable here ev…This Week
dmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: PostEmptyEvent crashes if called first on non-main thread on macOS2d
The upstream GLFW issue https://github.com/glfw/glfw/issues/1649 was resolved in GLFW 3.4, and we now have v3.4/glfw package offering that version as of PR #414.
I've re-tested the original report, …dmitshur fixed an issue github.com/go-gl/glfw: v3.4 and supporting GLFW_MOUSE_PASSTHROUGH2d
dmitshur fixed an issue github.com/go-gl/glfw: v3.4 and supporting GLFW_MOUSE_PASSTHROUGH2d
The `MousePassthrough` hint was added in PR #414, and should be available now:
https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw#MousePassthrough
Closing as done in commit 8479a9b4422aab8f9d581ef4…dmitshur commented on github.com/go-gl/glfw: v3.4 and supporting GLFW_MOUSE_PASSTHROUGH2d
The `MousePassthrough` hint was added in PR #414, and should be available now:
https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw#MousePassthrough
Closing as done in commit 8479a9b4422aab8f9d581ef4…dmitshur commented on github.com/go-gl/glfw/README.md: remove -u flag from go get2d
Thanks.dmitshur opened a change github.com/go-gl/glfw/README.md: remove -u flag from go get2d
The -u flag was needed back in GOPATH mode to reliably fetch the latest version of the target package and its dependencies. There's no need for it in module mode, since the default [version query](ht…dmitshur created branch in github.com/go-gl/glfw2d
go-get-no-udmitshur commented on github.com/go-gl/glfw: Consider adding release tags2d
Made the first pre-release tag as discussed above:
https://pkg.go.dev/github.com/go-gl/glfw/v3.4/glfw?tab=versionsdmitshur fixed an issue github.com/go-gl/glfw/v3.4/glfw: add support for GLFW version 3.4 (and future 3.4.x versions)2d
dmitshur closed a change github.com/go-gl/glfw: GLFW v3.42d
dmitshur pushed to
master in github.com/go-gl/glfw2ddmitshur merged a change github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)2d
dmitshur commented on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)2d
Done in commit cc44bab941ad35dfd2c2c7e34ba6ffb21519d7e7.dmitshur commented on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)2d
Done in commit fb51f1547102b67bbc96e40e0ed733a125c2dc49.dmitshur pushed to
master in github.com/go-gl/glfw2ddmitshur pushed to
master in github.com/go-gl/glfw2ddmitshur commented on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)2d
Marking as resolved; this note isn't meant to be in scope of this PR.dmitshur reviewed +2 on github.com/go-gl/glfw: Complete GLFW v3.4 integration and fix TODOs (supersedes #400)2d
Thanks very much @alexballas for getting this PR prepared and addressing remaining comments that were left on PR #400. Thank you @Geo25rey for getting PR #400 very far.
I've reviewed and been testin…Last Week
dmitshur commented on golang.org/x/build/env/netbsd-amd64: update build VM to 10.13d
(1 comment)
Sounds good. I sent you CL 762720 to fix a broken symlink in the meantime. Tools that try to read all files in this repository (such as 'gcloud builds submit' used during the [deploy pro…dmitshur opened a change golang.org/x/build/env/netbsd-386: make anita-2.10.tar.gz.sha1 a plain file3d
A file containing the expected sha1 for anita-2.10.tar.gz in
the netbsd-386 directory was a symbolic link pointing to the
same file that the netbsd-amd64 directory used to have until
that file was de…dmitshur commented on path/filepath: clarify Dir and Clean documentation for Windows4d
(1 comment)
Thanks for preparing this change. Issue #77314 has now been fixed. Is there anything more to do here, or okay to close this?dmitshur commented on path/filepath: document Dir behavior for Windows volume-only paths5d
Thanks.dmitshur reviewed +2 on golang.org/x/vulndb/report: export minimal Report definition as required by Go Security Releasing6d
Thanks.dmitshur commented on github.com/go-gl/gl: Which version of GLES is supported?1w
CC @hackbar.dmitshur pushed to
master in github.com/go-gl/gl1wdmitshur merged a change github.com/go-gl/gl: Add support for gles2 3.2.1w
dmitshur reviewed +2 on github.com/go-gl/gl: Add support for gles2 3.2.1w
It would've been better to keep the change that re-generates everything with the latest glow and XML files as a separate PR from the change add the OpenGL ES 3.2 support. But they're separate commits…dmitshur commented on github.com/go-gl/gl/update: README.md1w
The change to document Fedora/RHEL-based system requirements seems reasonable. See an inline comment about the other change.
Let's not include this. It wouldn't compile anyway because it doesn't hav…dmitshur pushed to
master in github.com/go-gl/glow1wdmitshur merged a change github.com/go-gl/glow: Add support for OpenGLES 3.21w
dmitshur reviewed +2 on github.com/go-gl/glow: Add support for OpenGLES 3.21w
Thanks.dmitshur reviewed +2 on cmd/go/internal/doc: follow up to CL 7332001w
(1 comment)
You probably want to either rebase past CL 761620 or use trybot-bypass given the only failures are unrelated to this change.dmitshur reviewed +2 on cmd/go: add more go tool documentation and show tool aliases in go tool1w
Thanks.
I'd expect this to be noAlias per https://go.dev/s/style#mixed-caps. Or is it meant to be a single word?
Aside that, maybe it could work well to name the map 'ambiguous' or something like t…dmitshur commented on golang.org/x/build/cmd/golangbuild: update code search link1w
This change is ready for review.dmitshur opened a change golang.org/x/build/cmd/golangbuild: update code search link1w
The previous link is shorter, but it's no longer indexed. Point to the
new view to golangbuild source code where search indexing is available.dmitshur closed an issue build: build failure on x_vulndb-gotip-linux-amd64-race1w
dmitshur closed an issue build: build failure on x_net-gotip-linux-arm64_debian131w
dmitshur reviewed +2 on golang.org/x/build/relmeta: add ReleaseMilestone and SecurityPatch definitions1w
Thanks.
I'll note that it's somewhat unclear how exactly values would be represented in some of the fields because they're not documented: for example, `Changelists []string` might be a slice of URL…dmitshur commented on go/types: [release-branch.go1.26] handle unconstrained type parameters correctly in a few places1w
The release branch is currently frozen until the [Go 1.26.2 release](https://groups.google.com/g/golang-announce/c/2UyQAnUQKwc) is complete, added a temporary Hold+1.dmitshur closed an issue build: build failure on x_net-gotip-linux-arm64_debian131w
dmitshur reviewed +2 on golang.org/x/website/_content: in managing dependencies doc '-u' flag and mention '-modfile'1w
Thanks.dmitshur commented on golang.org/x/build/cmd/relui: update to ltbsky v0.4.21w
Thanks.dmitshur commented on github.com/go-gl/glow: Add support for OpenGLES 3.21w
This generally looks reasonable, thanks for working on it.
Have you had a chance to try generating the gles bindings afterwards, and does the generated output seem okay? I think it'd be a matter o…dmitshur reviewed +2 on golang.org/x/website/ref/mod: add more documentation for 'go tool' features.1w
Thanks. Minor comments.
Nit, https://go.dev/doc/contribute#first_line suggests leaving out the period; the period is a part of the "This change modifies Go to _____." sentence being completed.
```s…dmitshur reviewed +2 on image/jpeg: reject RGB and non-standard chroma subsampling1w
Thanks.
```suggestion
add support for non-standard chroma subsampling ratios" (CL 738280).
```
So that it's easier to get to if desired. Gerrit linkifies such CL mentions, and it's also possible to…Earlier
dmitshur commented on test/codegen: fix ppc64x rldicl bit test1w
It was another test failing, rangegen.go. It might've just been unlucky, it happens fairly often based on its history: https://ci.chromium.org/ui/test/golang/cmd%2Finternal%2Ftestdir%3A6_10.Test%2Fra…dmitshur opened a change golang.org/x/build/cmd/relui: update to ltbsky v0.4.21w
Pull in https://github.com/fflewddur/ltbsky/pull/5.dmitshur commented on simd/archsimd: Load*SlicePart panics with "checkptr: converted pointer straddles multiple allocations"1w
CC @golang/compiler.dmitshur commented on cmd/fix: `go fix` inline producing conflicting var names1w
Thanks for the report.
CC @golang/tools-team.dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip1w
(1 comment)
This isn't right: the known issue should keep this an optional security trybot. Done in PS 2.dmitshur commented on golang.org/x/build/main.star: remove known issue for linux-arm64_debian13 at tip1w
Thanks.dmitshur commented on cmd/internal/testdir:1_10: Test/codegen/bits.go failures [consistent failure]1w
This consistent failure on ppc64 and loong64 is due to https://go-review.googlesource.com/c/go/+/750200/comments/58cbcdce_f20cfeba.
CC @Jorropo, @golang/ppc64, @golang/loong64.dmitshur commented on crypto: disallow RegisterHash with hash value 01w
(1 comment)
FWIW since its value is actually 20, I understand this means "just use its value by picking a value that's higher than maxHash by some reasonable margin so that it'll be some time before…dmitshur reviewed +2 on cmd/go: specify full path to go command when running go tool covdata1w
Thanks.
Thanks for the clarification.