The documentation for `Query` currently includes:
> q should be a pointer to struct that corresponds to the GraphQL schema.
To make the snippet you've shown work as is, that would need to chang…
@mengzhuo If your builder continues to be in "Quarantined—Had 2 consecutive BOT_DIED tasks" state for a prolonged amount of time (I see that status [here](https://chromium-swarm.appspot.com/bot?id=…
Thanks.
Checking my understanding: is this intentionally being removed because of "For builders with `experiment_percentage` or `location_filters`, don't specify `includable_only`." from https://chr…
Thanks.
(nit) This can be shortened to "Fixes #64513." if you want since this is CL is for the main repo.
If you want, consider backporting the same change to this 1.17 copy while it exists.
We pr…
> ...oops.
Hmm, no, the go.dev/dl/ endpoint redirects without checking (https://cs.opensource.google/go/x/website/+/master:internal/dl/server.go;l=257-265;drc=2ad1d0f28107903728b0f3d281515e94dd7fa1d…
The build script fetches Go release archives from https://go.dev/dl/
as part of its work, so the "Publish to website" step needs to be
completed before the dependencies for this step are satisfied.
Thanks.
I notice a bit of inconsistency in that we have this field in define_environment, but all 3 calls to it use the same LOW_CAPACITY_HOSTS global, and some places (e.g., dimensions_of) use the …
(1 comment)
In PS 2, I've changed this project-wide dictionary to instead be a list of "extra dep" special cases that apply under matching conditions. PTAL.
(1 comment)
This CIPD package is only built for linux/amd64 now, so I shouldn't try to fetch it on the darwin-amd64 builder for example.
Also, since the integration test doesn't run in -short mode,…
(1 comment)
When we want to give more control to golangbuild, we end up with very inflexible input properties like xcode_version, node_version, etc., that let the caller control just the version, bu…
(1 comment)
Yep, please feel free to proceed. Thanks for considering this, and your suggestion (making dimensions_of responsible only for remapping a short suffix to dimensions, not having to handle…
I agree with the non-cmd/go-related suggestion in https://github.com/golang/go/issues/42661#issuecomment-1116274332. That is, I suggest opting into longtest on at least linux/amd64 when any of these …
(2 comments)
Thanks. See another comment inline.
Can the handling of "darwin-amd64" → "darwin-amd64" + os: "Mac-14" be done here (dimensions_of) instead of in split_builder_type? This seems to be…
Thanks. This is awesome!
It's fantastic how easy we can do this with LUCI now!
There's been demand for this kind of thing (e.g., #42661).
Is the internal host intentionally not being matched here, …
Thanks.
Can it work well to add it as "darwin-amd64-nocgo", that is, without specifying _14 here, since the important bit is that it's testing the darwin/amd64 port without cgo, and the exact major …
CC @bcmills, @matloob.
Slightly related, but in the opposite direction: `go test` and `go vet` currently print a warning and also exit with a fatal error when an import path pattern matches 0 pack…
(3 comments)
(nit) The verb after the colon customarily starts with a lower-case letter. See https://go.dev/wiki/CommitMessage (third bullet point). So "fix", not "Fix".
(nit) No need for a colon a…
2023c is still the latest by now. Adding okay-after-rc1. If a new version comes out before the final go1.22.0 release, we'll have a chance to update to it.
Thanks.
makemac makes a [return](https://go.dev/cl/28584) in 2023! 😅
s/ /=/
Like already done on line 6.
(If you want, also fix this in cmd/pubsubhelper/Dockerfile and cmd/gerritbot/Dockerfile…
Here's the resulting certificate: [netbsd-arm-bsiegert-1701367164.cert.txt](https://github.com/golang/go/files/13516881/netbsd-arm-bsiegert-1701367164.cert.txt).
The builder definitions have been …
Here's the resulting certificate: [openbsd-riscv64-mengzhuo-1701367184.cert.txt](https://github.com/golang/go/files/13516851/openbsd-riscv64-mengzhuo-1701367184.cert.txt).
The builder definitions …
It seems this was missed in the initial implementation of expansions,
but we never noticed until CL 541379 started using them for advisory
builders in minor release workflows.
For golang/go#63147.
Thanks for the suggestion above.
We've entered the release freeze for 1.22 and there aren't announcements to make for this release, moving to the next for now.
Thanks.
Same suggestion here:
```suggestion
wf.Task1(wd, "update-proxy-test", version.UpdateProxyTestRepo, published)
```
Since the `currPublished` Value is already an input to `UpdateProxyTest…
The revert was done in [CL 545995](https://go.dev/cl/545995).
This wasn't caught via LUCI trybots because we have only setup Windows 10, not older, in it so far. See [here](https://cs.opensource.g…
This cherry-pick doesn't apply to Go 1.20 because it supports older Windows versions where ProcessPrng isn't available. The change was rolled back in [CL 545995](https://go.dev/cl/545995). Re-closing…
The Go 1.22 code freeze has recently started. This is a time to update
all golang.org/x/... module versions that contribute packages to the
std and cmd modules in the standard library to latest maste…
TestCancelRequestWithChannelBeforeDo_Cancel failure looks like another instance of #59494. TryBot-Result+1 means it passed on Windows 7, the important bit.
I think you can rearrange this:
```
[rele…
Thanks.
Please edit the description to add the Gerrit CL number being rolled back next to or instead of the Git revision number. (https://go.dev/wiki/CommitMessage#reverts)
Go 1.20 is the last release that still supports Windows 7 and up (https://go.dev/doc/go1.20#windows), whereas Go 1.21 started to require Windows 10/Windows Server 2016 and higher (https://go.dev/doc/…
Two differences I'm spotting to note:
1. In old infra, go1.20.6 is being used as the bootstrap version. In LUCI, go1.17.13 is the bootstrap version, which is the minimum required for Go 1.20.
2…
From https://build.golang.org/?branch=release-branch.go1.20:
<img width="272" alt="image" src="https://github.com/golang/go/assets/1924134/c82df06a-fa07-4cca-930f-b297eb3b9f69">
Starting with […
> Yes.. I requested the golang organization request and I am part of that now..
Can you share a screenshot of what that looks like from your end? Is "Vishwanatha-HD" the right username? I'm not se…
Hmm, I'm not entirely sure about GitHub invitation process details. Perhaps you need to accept the golang organization invite first, which will then enable you to join the team? If that doesn't work,…
The GitHub team https://github.com/orgs/golang/teams/s390x is where I've sent the invite.
It currently shows "1 pending member", and your GitHub account is listed:
<img width="577" alt="image" sr…
It looks like the builder has passed some times by now, e.g., there are recent "SUCCESS" entries at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-riscv64 and https://ci.chromium.org/ui/…
Thanks.
Please add "[release-branch.go1.20]" prefix to the CL subject, since this is CL targets that branch.
It looks like #59494.
I'll also rebase this so that the fix for #63988 is included.
Thanks for trying to prepare a cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at th…
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…
Thanks for trying to prepare this cherry-pick. As mentioned at the bottom of https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, using Pull Requests is unfortunately not a supported workflow at…