Activity
Yesterday
dmitshur commented on reflect: Value.Seq|Seq2 documentation and unexported value15h
CC @golang/runtime.dmitshur commented on doc: write release notes for Go 1.2518h
The Go 1.25 release notes draft is complete by now, and there doesn't seem to be any remaining known TODOs to resolve. Thanks everyone.
It's okay for this to be open to track any further refinement …dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.19h
Pinging as this is a release blocker for Go 1.25.dmitshur commented on cmd/doc: -http fails on Windows with invalid port19h
Pinging as this is a release blocker for Go 1.25.dmitshur commented on crypto/tls: TLS handshake timeout consistently on Windows VM LTSC2019 with private IP20h
Thanks for the report. So the problem happens with the same Go program in an older Windows LTSC and doesn't happen in a newer Windows LTSC. Is the crypto/tls implementation in Go doing something diff…This Week
dmitshur commented on context: fix typo in context_test.go1d
Bypass since trybots already passed on PS 3.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1d
Thanks.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1d
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1d
(3 comments)
Hmm, this is the first time I'm encountering this suggestion. I have seen many instances of short inline comments not being a complete sentence (e.g., `N int64 // bytes remaining` rathe…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1d
Yes, I gave a heads up via chat and I saw that @adonovan@google.com gave it a thumbs up, so I think that's done (Alan, please let me know if you have questions or concerns). I'll copy from https://go…dmitshur reviewed +2 on encoding/json: use zstd compressed testdata1d
Thanks. (The cmd/go.TestScript/list_empty_importpath failure looks unrelated to the changes here.)dmitshur commented on cmd/cover: wrong coverage reported when func fields in struct1d
CC @thanm, @golang/compiler.dmitshur commented on encoding/json/v2: report error on time.Duration without explicit format1d
Indeed, Auto-Submit does what it says on the tin as soon as all submit requirements are satisfied. :) Fortunately there weren't any hidden test failures so it worked out.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)1d
Friendly ping.dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv22d
Thanks.
(nit) Not a big deal, but mentioning for future reference: https://www.w3.org/TR/wasm-core-2/#wasm.
Please include something to connect this CL with a tracking issue. This is [always useful…dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv22d
Thanks.
Both forms are interchangeable and okay. This is described in a bit more detail at [go.dev/wiki/CommitMessage](https://go.dev/wiki/CommitMessage#:~:text=To%20link%20a,or%20vice%20versa.).dmitshur commented on net/http: punycode labels ending with hyphen (xn--example-) should be rejected per updated UTS-462d
Thanks for filing the issue. Someone familiar with this package may have more specific comments, but in general please see https://go.dev/doc/contribute on how to send a code change. I added a mentio…dmitshur commented on golang.org/x/sys/windows: fix filetime conversions and deprecate Nanoseconds2d
CC @golang/windows.dmitshur commented on internal/goexperiment: user facing documentation for GOEXPERIMENT points to internal source for list of supported values2d
CC @golang/command-line, @golang/runtime.dmitshur commented on runtime: passing a JS pointer to Go-Wasm runtime causes memory leak2d
CC @golang/wasm.dmitshur commented on runtime: add missing unlock in sysReserveAlignedSbrk2d
(1 comment)
Is this the right issue for this?
```suggestion
unlocked at one of the return path. Add the missing unlock.
Fixes #74339.
```dmitshur commented on cmd/go: clean doesn't respect workspace vendoring2d
CC @golang/command-line.dmitshur commented on cmd/go/internal/test: "go help testflag" refers to legacy options of pprof2d
CC @golang/command-line, @cherrymui.dmitshur commented on encoding/json/jsontext: consistently use JSON terminology2d
No legacy slowbots were requested.dmitshur commented on encoding/json/v2: report error on time.Duration without explicit format2d
No legacy slowbots were requested.dmitshur commented on encoding/json/v2: test that trybots work2d
LUCI trybots by default run a rough equivalent of all.bash on various ports. If all.bash doesn't fail for you when you run it locally, LUCI trybots shouldn't fail either.
If you'd like to have all.b…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2d
Thanks.dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2d
Hmm, can you confirm you’ve done this part?
> (Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving …Last Week
dmitshur opened an issue cmd/go: "test timed out after ... running tests: ..." attached to one of many subtests in JSON mode, can be less visible compared to non-JSON output5d
Consider the output from `go test` without `-json` flag in a situation where a test timeout happens while multiple subtests are still running (as happened in #74279):
```sh
$ go version
go version g…dmitshur commented on golang.org/x/build/main.star: increase openbsd-amd64 timeout scaling to 45d
Thanks.dmitshur opened a change golang.org/x/build/main.star: increase openbsd-amd64 timeout scaling to 45d
Looking at recent build completion times for x_tools-gotip-openbsd-amd64
shows it often takes around 20 minutes, while x_tools-gotip-linux-amd64
often takes around 5 minutes. Even in the main Go repo…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)5d
This change is ready for review.dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host5d
Copied Votes:
* Code-Review+1 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforcement` or `label…dmitshur starred github.com/jamesshenjian/jpegsl6d
dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host6d
Of course. In theory you can use a regular ./make.bash and create the .tar.gz archive of the result, but it might be easier to use ./make.bash with -distpack flag—just like the real release process…dmitshur commented on github.com/shurcooL/home/internal/exp/service/activity/{github,gerrit}: walkSegMail can fail with EOF1w
There was another instance, but this time it was with a non-zero offset in the middle of a month:
```
2025/06/18 14:21:34 service/activity/github: mailLoop: walkSegMail(github.fileSeg{file:"/2025-06…dmitshur closed an issue golang.org/x/build: add longtest builder for darwin/arm641w
This is done. Closing in favor of the newer issue #73488.dmitshur fixed an issue golang.org/x/build: have darwin/arm64 builders on macOS 13 (Ventura)1w
This was done a while back ([CL 532579](https://go.dev/cl/532579)).dmitshur reviewed +2 on golang.org/x/build/internal/installer/darwinpkg: speed up find command significantly1w
Thanks.
Sounds good, it's tracked in #74287 now.dmitshur opened an issue golang.org/x/build/internal/installer/darwinpkg: unclear purpose and effect of "Fixing permissions" step during postinstall1w
The Go macOS installer currently runs a sequence of commands described as "Fixing permissions":
```bash
GOROOT=/usr/local/go
echo "Fixing permissions"
cd $GOROOT
find . -exec chmod ugo+r \{\} \;
fin…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host1w
(Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving it a .darwin-amd64.tar.gz toolchain.)dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host1w
It sounds like you were testing the change with a go1.24.4 toolchain. The change is set to apply on versions go1.25rc2 and newer only, so seeing the installation proceed as before is working as inten…dmitshur commented on golang.org/x/build/main.star: add dev.simd branch1w
(1 comment)
Oh, almost but not quite — it's still needed in `enabled` so that 'builders_to_trigger_after_toolchain_build' isn't set to non-existing dev.simd x/ repo builders.dmitshur reviewed +2 on golang.org/x/build/main.star: add dev.simd branch1w
(3 comments)
Yes, config groups define presubmit. But I expect we'd need to make more changes to make it useful. As is, this arch_repo_dev-simd config group matches only "internal-branch.dev-simd-.+…dmitshur commented on cmd/dist: always include variant in package names1w
It occurs to me now that one of the effects of dropping omitVariant for test directory tests is that the corresponding test ID will now always have some shard. Previously, if fixedbugs/issue68525.go …dmitshur reviewed +2 on cmd/dist: always include variant in package names1w
Thanks.
directory
I see, it's impossible to distinguish their timing. For example, if you do run both the go/version package tests as well as its racebench variant in JSON mode, you get both:
```
…dmitshur opened a change golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host1w
Both of our installers are correctly annotated for the intended host
architecture. That is, the hostArchitectures option is set to x86_64
on .darwin-amd64.pkg installers, and to arm64 on .darwin-arm6…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: speed up find command significantly1w
(1 comment)
Whoops, the "Fixing permissions" postinstall file existed even earlier, I'm now finding CL 11970 from 2015, and it might be present in even earlier Go macOS installers. So higher chances…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: speed up find command significantly1w
Thanks for finding this and sending the CL. It does look like a good improvement.
I think it's a good time to try this for Go 1.25 since there are still opportunities to get wider signal from pre-re…Earlier
dmitshur fixed an issue golang.org/x/build: gotip-linux-arm builder has no disk space left1w
I terminated the bot via swarming UI:
<img width="892" alt="Image" src="https://github.com/user-attachments/assets/21ce9cd4-5236-479d-aedd-fd341aeba18a" />
After it came back, it had a successful …dmitshur fixed an issue golang.org/x/tools: frequent out-of-memory errors on linux-arm builder1w
The Scaleway linux/arm builders are no more, and there haven't been recent reports here. If this comes up on the newer linux/arm builders, watchflakes will file a report. Closing.dmitshur starred github.com/firstrow/mcwig1w
dmitshur commented on cmd/compile: update compiler's PGO profile as part of rc1 relui flow2w
> At this point it might help to separate out work on making relui do this automatically into a dedicated x/build/cmd/relui issue, since that can happen independently of the Go release cycle.
Made #…dmitshur opened an issue golang.org/x/build/cmd/relui: update compiler's PGO profile2w
This is a tracking issue to create a task for updating the compiler's PGO profile, something that we currently typically do for every major Go release, so about once every 6 months (issue #60234).
I…dmitshur fixed an issue all: end support for macOS 11 in Go 1.252w
I think we can close this now - I'm not aware of anything more left to do for this for Go 1.25.
If there's anything still in the tree that exists only because of needing to support macOS 11, then th…dmitshur commented on cmd/dist: re-expose pack command in Go 1.252w
Thanks for the report. The corresponding release note for this is https://tip.golang.org/doc/go1.25#go-command (second paragraph, "The Go distribution will include fewer prebuilt tool binaries. …")…dmitshur fixed an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs2w
Permission change applied.dmitshur closed an issue os: TestRootRemoveDot failing on Plan 92w
dmitshur reopened an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs2w
Need to grant the gobot account a permission for the TryBot-Bypass label, since it is being used by it now. Reopening for that.dmitshur opened an issue golang.org/x/build: extend main Go repo's "every vet check is forcibly made high-confidence" behavior to golang.org/x packages that are vendored (or exclude vendored packages from it)2w
The `go test` command normally runs a select subset of vet checks, and fails the test if any of them fail.
In the main Go repo, to aid development, that behavior is forcibly modified to have all vet…dmitshur opened an issue golang.org/x/exp/rand: isolate into nested module, tag, delete3w
This issue tracks a remaining subset of the accepted proposal #61716. Specifically:
> Once math/rand/v2 has shipped, we would tag and delete x/exp/rand. This would keep programs that already use x/e…dmitshur commented on testing: add missing Output method to testing.TB3w
Indeed—freeze exceptions would be needed for changes that aren't in scope of the freeze (and ideally they need to be filed and approved before the freeze), but finding and resolving issues in new-t…dmitshur commented on access: please add new email to existing account3w
Great! I've also updated your email in the approvers group now, so everything should continue to work.
Just as a reminder, please be familiar with the rules for voting and submitting changes as desc…dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies/std(thorough) failures [consistent failure]3w
Latest instance fixed in [CL 663975](https://go.dev/cl/663975).dmitshur commented on golang.org/x/build: add darwin-arm64 longtest and race builders3w
The darwin-arm64-longtest builder is passing at tip and on the Go 1.24 release branch, but it has one failing test on the Go 1.23 release branch. I filed #73922 for it.
The darwin-arm64-race builder…dmitshur opened an issue cmd/go: TestScript/build_trimpath_cgo fails to decode dwarf on release-branch.go1.233w
### Go version
This affects Go 1.23.x only. The test passes on Go 1.24.x and at tip.
### Output of `go env` in your module/workspace:
```shell
GOOS='darwin'
GOARCH='arm64'
```
### What did you do…dmitshur opened an issue golang.org/x/build/cmd/watchflakes: no reports after May 19, 20253w
The problem appears to be due to a regression in the result_adapter command in [crrev.com/c/6554882](https://crrev.com/c/6554882) from May 19, 2025, which has a pending fix in [crrev.com/c/6598395](h…dmitshur commented on access: please add new email to existing account4w
@ysmolski Glad to hear that you were able to update the email in your Gerrit account! It indeed shows up as expected at https://go-review.googlesource.com/dashboard/26536.
About the CLA page, in the…dmitshur commented on access: approvers4w
CC @4a6f656c, @Rongronggg9, @milanknezevic, @mengzhuo Since you're also members of [golang/mips](https://github.com/orgs/golang/teams/mips) and [golang/riscv64](https://github.com/orgs/golang/teams/r…dmitshur pushed to
main in dmitri.shuralyov.com/service/change1modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time11mo
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability2y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido3ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl4ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y