Activity
Today
dmitshur closed a change golang.org/x/vuln: update x/tools/{,go/packages/packagestest,go/expect}2h
This update is already applied as part of CL 687555.dmitshur commented on golang.org/x/vuln: update x/tools/{,go/packages/packagestest,go/expect}2h
@adonovan@google.com Thanks for making this CL. It seems no one got around to reviewing it, and by now relui has already applied these updates in CL 687555.dmitshur commented on golang.org/x/vuln/internal/buildinfo: windows/arm subtest of TestStrippedBinary and TestExtractPackagesAndSymbols fails consistently2h
Oh, I just noticed the failure mode changed from older failures to most recent one, which makes the problem more apparent:
```
go: unsupported GOOS/GOARCH pair windows/arm
```
I didn't realize the …dmitshur opened a change golang.org/x/vuln/internal/buildinfo: stop testing the windows/arm port2h
The windows/arm port was marked broken and is removed in Go 1.26.
For #71671.
Fixes #74934.dmitshur commented on golang.org/x/vuln/go.mod: update golang.org/x dependencies4h
A preexisting failure. Filed #74934 for it.dmitshur opened an issue golang.org/x/vuln/internal/buildinfo: windows/arm subtest of TestStrippedBinary and TestExtractPackagesAndSymbols fails consistently4h
These failures happen at Go tip:
```
=== RUN TestExtractPackagesAndSymbols/windows/arm
# internal/runtime/syscall/windows
../../../../../goroot/src/internal/runtime/syscall/windows/asm_windows_arm…dmitshur commented on github.com/gopherjs/gopherjs: Bug in overflow multiplication of uint type.5h
> Not sure why @dmitshur saw an output of `1` from Go. Maybe he was testing on a 32-bit system?
Yes, I think so. I should've written it down explicitly, but it makes sense to compare gc behavior on …dmitshur reviewed +2 on golang.org/x/website/_content/doc/go1.25: minor formatting fix6h
Thanks.dmitshur commented on golang.org/x/arch/riscv64: fix the path to the RISC-V extensions in spec.go10h
(1 comment)
This isn't necessarily in scope of this CL, but while here I noticed this.
It should probably check if len(os.Args) < 2 and then log.Fatal, right? Or if flag package were used, then …dmitshur reviewed +2 on golang.org/x/net/http2: remove references to defunct http2.golang.org test server13h
Thanks.dmitshur reviewed +2 on time: skip TestLongAdjustTimers on plan9 (too slow)13h
Thanks.Yesterday
dmitshur commented on golang.org/x/build: bot freebsd-riscv64-mengzhuo--megrez-3 reported as broken22h
Thanks.
About deleting bots that are no longer needed: there is a delete button next to "Last Seen" in the UI, though I think currently it requires LUCI admin permissions. Maybe there's something we…dmitshur fixed an issue golang.org/x/build: *-linux-arm builders have no disk space left23h
Closing since this hasn't happened for some time. It's been idling at around 40% disk usage, similar to its prior steady state in https://github.com/golang/go/issues/74169#issuecomment-2971994775.dmitshur fixed an issue golang.org/x/build: bot linux-arm-aws--dev-3e01 reported as broken23h
dmitshur commented on golang.org/x/build/internal/workflow: convert unexpected panics in tasks to task errors1d
Thanks.
Yeah, the intention here is to recover from panic only if it happens when invoking `fv` (which is the task function, `state.def.f`), and assign it to `taskPanic` if so. The rest of runTask s…dmitshur closed an issue runtime: TestGdbConst failures [consistent failure]1d
This might be a duplicate of #74910 and already fixed.dmitshur commented on cmd/cgo/internal/testsanitizers: failures with `signal: segmentation fault` or `exit status 66`1d
@yhlee-tw Thanks for reporting. If you think the fix for that issue meets the bar for backporting, please request it using the process documented at https://go.dev/wiki/MinorReleases and include a ra…dmitshur commented on golang.org/x/build: bot linux-riscv64-mengzhuo--megrez-2 reported as broken1d
@mengzhuo There were 20 consecutive failures due to #74893, causing the bot to be moved to qurantined state. Now that #74893 is resolved, this should be a matter of restarting the swarming bot. Thank…dmitshur commented on golang.org/x/build: bot freebsd-riscv64-mengzhuo--megrez-3 reported as broken1d
@mengzhuo There were 20 consecutive failures due to #74893, causing the bot to be moved to qurantined state. Now that #74893 is resolved, this should be a matter of restarting the swarming bot. Thank…dmitshur fixed an issue build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"1d
This issue is resolved. Closing and unpinning.dmitshur commented on golang.org/x/build/cmd/relui: add support for making release announcement posts on Bluesky1d
We saw this functionality in action during today's release:
https://bsky.app/profile/golang.org/post/3lvqxp673aw2l
https://bsky.app/profile/golang.org/post/3lvqxmfabea2sdmitshur reviewed +2 on all: remove support for windows/arm1d
(1 comment)
Thank you.dmitshur commented on build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"1d
This is now fully rolled out, for all Go port builders.
In case you spot problems that seem related to this in builds started after this comment, please let us know here. Keeping it open for some ti…dmitshur commented on golang.org/x/website/internal/history: document Go 1.24.6 and 1.23.12 releases1d
Thanks.dmitshur opened a change database/sql: avoid closing Rows while scan is in progress1d
A database/sql/driver.Rows can return database-owned data
from Rows.Next. The driver.Rows documentation doesn't explicitly
document the lifetime guarantees for this data, but a reasonable
expectation…dmitshur commented on golang.org/x/website/internal/history: document Go 1.24.6 and 1.23.12 releases1d
No need to bypass trybots; I included it in case it might still be needed due to #74893 but the mitigation has rolled out.dmitshur opened a change golang.org/x/website/internal/history: document Go 1.24.6 and 1.23.12 releases1d
dmitshur opened a change database/sql: [release-branch.go1.23] avoid closing Rows while scan is in progress1d
A database/sql/driver.Rows can return database-owned data
from Rows.Next. The driver.Rows documentation doesn't explicitly
document the lifetime guarantees for this data, but a reasonable
expectation…dmitshur opened a change database/sql: [release-branch.go1.24] avoid closing Rows while scan is in progress1d
A database/sql/driver.Rows can return database-owned data
from Rows.Next. The driver.Rows documentation doesn't explicitly
document the lifetime guarantees for this data, but a reasonable
expectation…dmitshur commented on golang.org/x/build/internal/access: run gofmt on the package1d
I think windows-amd64 should be propagated too by now, trying again.dmitshur reviewed +2 on golang.org/x/build/internal/access: run gofmt on the package1d
Thanks.dmitshur commented on build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"1d
The propagation is partially complete (including for darwin/arm64, linux/amd64) and working, for example:
- https://ci.chromium.org/ui/p/golang/builders/ci/gotip-darwin-arm64_15/b8707269894361154625…dmitshur closed a change : [release-branch.go1.23] empty change1d
I'm done trying this out, closing.dmitshur opened a change : [release-branch.go1.23] empty change1d
DO NOT REVIEW.
DO NOT SUBMIT.
I'm using this CL to try out trybots.dmitshur commented on build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"1d
A suspected change that might be causing this has been [rolled back](https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6824203), currently waiting on propagation.dmitshur closed an issue build: build failure on gotip-linux-arm1d
dmitshur closed an issue build: build failure on gotip-solaris-amd641d
dmitshur closed an issue build: build failure on gotip-netbsd-arm641d
dmitshur closed an issue build: build failure on gotip-windows-arm641d
dmitshur closed an issue build: build failure on gotip-darwin-amd64_141d
dmitshur closed an issue build: build failure on gotip-darwin-amd64-race1d
dmitshur reopened an issue build: build failure on gotip-darwin-amd64-race1d
dmitshur closed an issue build: build failure on gotip-darwin-amd64-race1d
dmitshur closed an issue build: build failure on gotip-darwin-arm64_121d
dmitshur closed an issue build: build failure on gotip-darwin-arm64-race1d
This Week
dmitshur commented on fyne.io/fyne/v2/ld: warning: ignoring duplicate libraries: '-lobjc'2d
The upstream Go tracking issue for this is https://github.com/golang/go/issues/67799.dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: support multiple backport requests2d
Thanks.
```
_, err := time.Parse(time.DateOnly, "2025-08-1")
fmt.Println(err)
// Output:
// parsing time "2025-08-1" as "2006-01-02": cannot parse "1" as "02"
```
(https://go.dev/play/p/4kxZrSxt64…dmitshur commented on all: remove support for windows/arm2d
(1 comment)
This picked up a minor merge conflict (likely with CL 691835) that needs resolving, then this can be submitted. Thanks again.dmitshur reviewed +2 on all: remove support for windows/arm2d
Thanks.dmitshur reviewed +2 on golang.org/x/website/_content/js: fix table of contents for markdown files2d
Thanks.dmitshur commented on internal/coverage/cfile: TestIssue59563TruncatedCoverPkgAll failures [consistent failure]2d
Started with [CL 681937](https://go.dev/cl/681937). CC @randall77.dmitshur commented on cmd/compile: allow multi-field structs to be stored directly in interfaces2d
Note that TestIssue59563TruncatedCoverPkgAll in internal/coverage/cfile has started to fail as of this CL. That test is skipped with -short flag, so it's visible on longtest builders. For example, h…dmitshur commented on encoding/csv: inconsistent number of fields constraint between Writer and Reader2d
CC @dsnet, @bradfitz, @rsc.dmitshur commented on gollvm: build fails with llvm latest and release/16.x2d
CC @thanm, @cherrymui.dmitshur commented on golang.org/x/net/route: ParseRIB errors with RTM_ADD and RTM_DELETE2d
CC @mikioh, @neild, @ianlancetaylor.dmitshur commented on golang.org/x/net/idna: StrictDomainName doesn't work with Profile.ToASCII2d
CC @neild, @ianlancetaylor.dmitshur commented on proxy.golang.org: problematic 302 redirects to www.google.com/sorry/... URLs2d
CC @golang/tools-team.dmitshur commented on golang.org/x/sys/windows: drop arm2d
Since Go 1.25 is the last release that contains the broken windows/arm port, and the port is removed in Go 1.26, perhaps for now we should add a `//go:build !go1.26` constraint here? (Later on, once …dmitshur commented on all: remove support for windows/arm2d
(2 comments)
Done in PS 11.
This was applied at first, but reverted in the latest patch set (PS 11). Was that unintentional?dmitshur commented on crypto/internal/boring: make dst allocation for AES-GCM more efficient2d
Thanks for the change, but I'm not sure whether code behind //go:build boringcrypto code is accepting optimization changes. If so, this needs a crypto owner to review.Last Week
dmitshur opened a change golang.org/x/build/internal/workflow: convert unexpected panics in tasks to task errors6d
Relui tries to be as resilient to failure as possible, enabling the
release coordinators to restart individual tasks when they fail and
move forward.
Tasks are the smallest unit of work that can be …dmitshur commented on all: remove support for windows/arm6d
Thanks for reviewing this Quim! The release note and cmd/dist changes look good to me. I think it might still be useful for another person familiar with the linker and runtime to give it another look…dmitshur commented on golang.org/x/build/cmd/gopherbot: support multiple backport requests6d
Thanks for taking this on! See an inline comment about old issues that you might want to resolve first, and otherwise I think the general approach should work well.
s/was/way/
Trying out in -dry-ru…dmitshur commented on golang.org/x/build/internal/task: add suggestion to opt in to Go toolchain telemetry in RCs6d
(2 comments)
Added "Please", thanks.
(I didn't apply the go.dev change; I think that's a separate issue. We generally stay with tip.golang.org in pre-release communication. We have started making t…dmitshur commented on golang.org/x/build/internal/task: update announce-rc test case to use go1.25rc16d
(1 comment)
Clarified offline that this suggestion was about every RC release announcement specifically. In general to me that seems worth pursuing carefully. Added CL 692375 at the end of this stac…dmitshur opened a change golang.org/x/build/internal/task: add suggestion to opt in to Go toolchain telemetry in RCs6d
We've experimented with including a suggestion to opt in to Go toolchain
telemetry in the Go 1.23 RC 1 release announcement. That was a one-off
inclusion, but it has worked well. Rob has suggested we…dmitshur opened a change golang.org/x/build/internal/task: update announce-rc test case to use go1.25rc11w
The announce-rc.md template has a section that was used for go1.23rc1.
It has no effect on future RC announcements, so I'll delete it in the
next CL. Update its test case to target a newer RC version…dmitshur opened a change golang.org/x/build/internal/task: support security field in the announce-rc template1w
We want to make it clear to users who start testing and using release
candidate versions in production that they can receive security fixes
while continuing to use RCs. So when RCs have security fixe…dmitshur commented on os/exec: LookPath bug: incorrect expansion of "", "." and ".." in some PATH configurations1w
Yeah, that was already done above (https://github.com/golang/go/issues/74466#issuecomment-3134040404), and the fix is submitted for Go 1.26, so it was only Go 1.25 that was seemingly missed.dmitshur commented on os/exec: LookPath bug: incorrect expansion of "", "." and ".." in some PATH configurations1w
@neild This still needs to be cherry-picked for Go 1.25 since it landed after [CL 689877](https://go.dev/cl/689877), right? See second paragraph of https://groups.google.com/g/golang-dev/c/_GfEaCcy7v…dmitshur commented on cmd/go: `go tool -n` can point to a file that doesn't exist1w
The reason this particular CL landed right after the tree reopened for 1.26 development is because @matloob marked it with the `wait-release` hashtag on [July 18th](https://go-review.googlesource.com…Earlier
dmitshur starred github.com/tchayen/triangolatte1w
dmitshur starred github.com/rclancey/go-earcut1w
dmitshur opened an issue cmd/go: version stamping from VCS no longer works in Go 1.25 when in a nested module and repo root has no go.mod file1w
The issue appears to reproduce whenever the repository root doesn't have a go.mod file. From a quick look, the relevant change is likely [CL 661875](https://go.dev/cl/661875) (CC @samthanawalla) give…dmitshur commented on os/user:nolibgcc: TestGroupIdsTestUser failures1w
@gopherbot Please backport to Go 1.24. This is a test-only fix to resolve flaky test failures whose frequency increased recently after a different scheduling of parallel test execution. No need for G…dmitshur fixed an issue cmd/cgo/internal/testsanitizers: failures with `signal: segmentation fault` or `exit status 66`1w
dmitshur commented on cmd/cgo/internal/testsanitizers: failures with `signal: segmentation fault` or `exit status 66`1w
Closing again. Fixed by [CL 623956](https://go.dev/cl/623956) and its backport [CL 690035](https://go.dev/cl/690035).dmitshur reopened an issue golang.org/x/build: bot netbsd-arm-bsiegert reported as broken1w
The two builders visible at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-netbsd-arm are currently missing. The last incomplete build was yesterday, https://ci.chromium.org/b/8708470930646754…dmitshur fixed an issue : Update membership list of @golang/riscv642w
Thanks! All 4 should have pending invites that you'll need to accept. Please comment if there's anything else.dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle2w
I'll take this alongside #69315 for this cycle. I have some automation for bootstrap preparation that I'd like to incorporate into relui. We'll either use the current latest Go 1.24 minor release, Go…dmitshur commented on cmd/cgo/internal/testsanitizers: failures with `signal: segmentation fault` or `exit status 66`2w
@gopherbot Please consider this for backport to Go 1.23. These tests are now flaky only on release-branch.go1.23, and it's a test-only fix.dmitshur starred github.com/fflewddur/ltbsky2w
dmitshur fixed an issue debug/macho: Mach-O format's truncation of DWARF section names longer than 16 chars makes some sections unrecognizable to debug/dwarf2w
Retitled this to be about the darwin/macho problem (we didn't have an existing issue for it), and closing as fixed by [CL 608995](https://go.dev/cl/608995).dmitshur commented on cmd/go: TestScript/build_trimpath_cgo fails to decode dwarf on release-branch.go1.232w
Thanks @cherrymui, that was it. I can confirm that release-branch.go1.23 with CL 608995 applied fixes the "DW_FORM_strx with no .debug_str_offsets section" error, though the test doesn't pass right a…dmitshur closed an issue golang.org/x/build: bot linux-ppc64-power8--05 reported as broken2w
dmitshur closed an issue golang.org/x/build: bot linux-ppc64-power8--04 reported as broken2w
Thanks, removed the --04 and --05 dead bots since we don't expect them to reconnect, leaving the 3 active bots at https://chromium-swarm.appspot.com/botlist?f=cpu%3Appc64-64-POWER8&k=cpu&s=id. Closin…dmitshur starred honnef.co/go/wgpu2w
dmitshur commented on golang.org/x/tools: various flakes on ppc (linux OOM-kills)3w
No objections to 3 instances with 16 GB RAM, and in general having fewer instances with more memory, from my side. Issue #33986 tracks deciding and documenting the memory requirement for running test…dmitshur closed an issue golang.org/x/build/cmd/relui: clone workflow3w
Moving this out of planned for now since there hasn't been high demand for this. Can revisit if it becomes needed.dmitshur starred github.com/soypat/colorspace3w
dmitshur opened an issue golang.org/x/pkgsite-metrics: module fails to tidy after upgrading golang.org/x/exp/event to its latest version3w
Attempting the following sequence to upgrade one of the dependencies and then tidying this module fails:
```sh
$ cd $(mktemp -d)
$ git clone https://go.googlesource.com/pkgsite-metrics
Cloning into …dmitshur closed an issue cmd/go/internal/vcweb/vcstest: TestScripts/git/vgotest1.txt failures4w
dmitshur commented on golang.org/x/build: test failures are hard to discover4w
Issue #74323 might be relevant here.
It appears that the reason the package `golang.org/x/tools/gopls/internal/test/marker` tests are reported as failed is because of the data race that came up duri…dmitshur commented on : go1.23.11 segmentation fault in test4w
CC @golang/runtime.dmitshur pushed to
main in dmitri.shuralyov.com/service/change2modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.