Dmitri Shuralyov

Activity

Today

dmitshur reviewed +2 on golang.org/x/build/devapp/owners: remove stale modproxy owner2h

Thanks. This line can be deleted too since it became unused.

dmitshur reviewed +2 on golang.org/x/build/main.star: pass machine_type in expected_dimensions for Windows builders2h

Thanks.

dmitshur commented on golang.org/x/build/internal/task: make 'Publish changes' more fault tolerant2h

(2 comments) I'm not sure I understand. I agree that tasks can get interrupted midway if say k8s restarts relui or something like that, and PublicizePrivateChanges needs to be written with that in m…

dmitshur reviewed +2 on cmd/dist: add -artifacts-dir flag to dist test3h

Thanks.

dmitshur commented on cmd/compile: ICE "Int64Val(uint64(9223372036854775808))" when ranging over an unsigned constant ≥ 2^63 in a clear loop (`for i := range uint64(1<<63) { s[i] = 0 }`)3h

CC @golang/compiler.

dmitshur reviewed +2 on cmd/internal/obj/x86: [release-branch.go1.26] clear forward-jump list on PCALIGN4h

Thanks.

dmitshur reviewed +2 on cmd/internal/obj/x86: [release-branch.go1.27] clear forward-jump list on PCALIGN4h

Thanks.

dmitshur commented on golang.org/x/build/main.star: enable go test artifacts on main go repo builders6h

(1 comment) This change looks like the right next step, but it needs to land no sooner than golangbuild's been updated and we expect it to work. I left comments on crrev.com/c/8589819. Leaving this…

dmitshur reviewed +2 on golang.org/x/build/main.star: reroute linux ppc64{,le} power8 builds8h

Thanks. To confirm my understanding: the reason it helps to run these builders on on power9 or power10 hardware, instead of just not running them at all in favor of the power9/10 builders that do st…

dmitshur reviewed +2 on golang.org/x/website/_content/tour: build and run code snippets as go1.26 modules8h

Thanks. In cases like this, where it's an existing already-released major version rather than a future version still in development (e.g., 1.28 right now), I wonder whether a major release version l…

dmitshur reviewed +2 on golang.org/x/website/_content/js: reset survey banner state on /#survey-reset8h

Thanks. If this is only needed for testing by few people, have you also considered using browser's console and manually clearing the local storage key for testing needs? The advantage of that is avo…

dmitshur reviewed +2 on golang.org/x/build/main.star: use n4dh32 for standard linux-amd64 builders8h

Thanks. Please take into account the need to pay attention to these builders on release-branch.go1.27 and 1.26 in addition to the main branch. Since release branches change only when approved cherry…

Yesterday

dmitshur opened an issue golang.org/x/build: frequent builder infra failures, including linux/amd64 and linux/arm64, on 2026-10-151d

We're aware of an issue most visible on the [Go tip post-submit dashboard](https://ci.chromium.org/p/golang/g/go-gotip/console), where many of the linux/amd64 and linux/arm64 builds are frequently ru…

dmitshur commented on golang.org/x/sys/windows: remove MemoryBasicInformation.PartitionId field on windows/3861d

(1 comment) Thanks.

dmitshur commented on golang.org/x/website/_content/solutions: add Temporal to companies using Go1d

Thanks for preparing this change. I'm not familiar with the criteria for adding a new entry to https://go.dev/solutions/case-studies page, but it's something @cbalahan@google.com might have more cont…

dmitshur reviewed +2 on Revert "runtime: match deferring function when looking for linked defers in nextFrame"1d

Thanks. ```suggestion This reverts CL 844565. ``` Thanks for preparing the revert CL. Since it's still running into the infra failures, it might not be the culprit. Adding a Hold for now.

dmitshur reviewed +2 on golang.org/x/build/main.star: enable go test artifacts on all builders1d

Thanks. If you think it'd be worth landing the buildSpace.distTestCmd change behind an experiment first, this can be made into `if project != "go"` for now. But it's also fine to make that change di…

dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4a go repo postsubmit builder1d

Thanks. See inline comments. Oh, the problem seems to be that these lines are currently in the "if goarch amd64" section but should be in the "arm64" one.

dmitshur commented on golang.org/x/build/main.star: add an experimental n4a go repo postsubmit builder1d

(2 comments) (nit) Since this is an x/ repo, these need "golang/go" before '#'. ```suggestion For golang/go#82017 ``` (It makes a bigger difference when it's Fixes instead of just For, but still.)…

dmitshur reviewed +2 on golang.org/x/build/main.star: switch linux-amd64-race builders to n4dh32 machines1d

Trying this is indeed a good way to make progress and seeing if something unexpected comes up. Thanks. For golang/go#82017.

dmitshur commented on golang.org/x/build/cmd/golangbuild: add support for test artifacts in LUCI1d

The latest status here is that functionality is enabled in x/pkgsite, for docker builder. What's left is enabling it for the remaining Go repositories and probably posting something in golang-dev so …

This Week

dmitshur starred github.com/qmuntal/gobuilder2d

dmitshur opened a change golang.org/x/build/main.star: add project-specific dry-runner and committer ACLs3d

The project-golang-may-start-trybots and project-golang-approvers CRIA groups are used for access across the entire Go project. There are some projects on the go Gerrit host that are co-owned by the …

dmitshur opened a change golang.org/x/build/cmd/gopherbot: extract auto-submit for x/build into dedicated deployment3d

Last Week

dmitshur commented on golang.org/x/vulndb/...: update x/net6d

@nsh@golang.org If you don't mind, since it's been created by now, let's go with the relui-generated CL 847790. It includes the x/net@v0.61.0 update as done here along with a few more.

dmitshur commented on cmd/link/internal/ppc64: genpltstub panics instead of reporting a link error when the caller symbol has no data6d

CC @golang/ppc64.

dmitshur reviewed +2 on golang.org/x/crypto/openpgp: delete module1w

Thanks. Carved out module now has a release version. ``` $ go mod init test go: creating new go.mod: module test $ go get golang.org/x/crypto/openpgp@latest go: downloading golang.org/x/crypto v0.5…

dmitshur commented on golang.org/x/crypto/openpgp: tidy module1w

Thanks.

dmitshur commented on golang.org/x/review/git-codereview: add -ready flag1w

Thanks.

dmitshur reviewed +2 on golang.org/x/crypto/openpgp: tidy module1w

Thanks. This should be the version that can be tagged as v0.1.0-deprecated.

dmitshur opened a change golang.org/x/build/internal/releasetargets: update list for Go 1.281w

The release freeze for Go 1.28 is a bit over a month away. Do a preliminary update of the release target list. So far its diff compared to that of Go 1.27 is as follows: - No changes. We'll revisit…

dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: add 2026 Go Developer Survey banner1w

Thanks. I left some suggestions, mostly minor and optional. Consider filing a tracking issue for this and adding "For golang/go#nnn." In case there are some issues with this functionality, having a …

dmitshur reviewed +2 on spec: fix EBNF for composite literals1w

Thanks.

dmitshur reviewed +2 on golang.org/x/crypto/openpgp: carve out openpgp as a module1w

Thanks. Unfortunately, it seems very hard¹ to avoid breaking trybots for everyone in x/crypto with this CL, so it'd be good to be able to update and submit CL 848205 very soon after this one. I'll …

dmitshur reviewed +2 on golang.org/x/crypto/openpgp: make carved out openpgp module fetchable1w

Thanks. Leaving an unresolved comment for actually doing this.

dmitshur commented on golang.org/x/exp/sumdb: delete1w

Yeah, I left a comment in CL 838545 about it. Adding TryBot-Bypass here since everything else passes.

dmitshur commented on spec: document composite literals with omitted types1w

(1 comment) Note that golang.org/x/exp/ebnflint.TestSpec [reports a finding](https://ci.chromium.org/ui/p/golang/builders/ci/x_exp-gotip-linux-amd64/b8668444157200869681/test-results?q=ExactID%3A…

dmitshur reviewed +2 on golang.org/x/exp/sumdb: delete1w

Since this is x/exp and this code already graduated to another x/ repo, this deletion seems fine without needing an accepted proposal. Thanks. Indeed.

dmitshur reviewed +2 on golang.org/x/mod/sumdb/tlog: use recorded responses in TestCertificateTransparency1w

Thanks. Leaving a general thought that this makes me think of, already resolved since it's not specific to this CL. I wonder if at some point it would make sense to start defaulting to embedding te…

dmitshur commented on golang.org/x/mod/sumdb/tlog: TestCertificateTransparency failures1w

There are new failures today that look like: ``` === RUN TestCertificateTransparency http://ct.googleapis.com/logs/argon2020/ct/v1/get-sth <html><head><meta http-equiv="content-type" content="tex…

dmitshur reviewed +2 on golang.org/x/crypto/openpgp: delete module1w

Thanks. Adding a hold for a tagged version of the carved out module being available. That is, something like the following should be made to work before proceeding with the deletion: ``` go get gol…

dmitshur commented on golang.org/x/crypto/openpgp: carve out openpgp as a module1w

(1 comment) Right now there are only two CLs in this stack. This one carves out the module, but it still has a replace directive. The second CL deletes the module. But we want a step in between tha…

dmitshur opened a change cmd/internal/moddeps: [release-branch.go1.26] restore tests1w

By now PRIVATE-track security fixes involving a vendored/bundled package have been released, and these tests can be made to run again as before. [git-generate] updatestd -goroot=$(pwd) -branch=inter…

dmitshur commented on encoding/json: UnsupportedValueError.Value is invalid for cycles in Go 1.271w

CC @dsnet, @bradfitz, @mvdan.

dmitshur opened an issue all: end support for macOS 13 in Go 1.291w

### Proposal Details Apple continues a yearly major macOS release cadence, and the last accepted proposal to drop the very oldest macOS version was #75836, a year ago. Since neither the macOS nor Go…

dmitshur reviewed +2 on golang.org/x/build/...: improve documentation for security releasing1w

(1 comment) Thanks for clarifying this.

dmitshur commented on golang.org/x/build/internal/task: make 'Publish changes' more fault tolerant1w

Thanks. See inline comment. I think this change was a good way to unblock today's release from proceeding, but maybe we don't need it longer term? After fixing the submit type, presumably there shou…

dmitshur reviewed +2 on golang.org/x/build/internal/relui: lint trusted DeploymentMap CLs against their manifest1w

Thanks.

dmitshur commented on golang.org/x/build/internal/relui: lint manually deployed CL descriptions1w

(1 comment) I just noticed this TODO - perhaps the code below addresses it.

dmitshur reviewed +2 on golang.org/x/build/internal/task: ignore PUBLIC track issues during preflight checks1w

Thanks.

dmitshur commented on net/http/internal/http2: avoid excessive work on initial window changes1w

The failing gotip-linux-amd64-boringcrypto trybot failed in the runtime package with "fatal error: gp.xRegState.p != nil on async preempt". This CL is only touching net/http, so it doesn't seem relat…

dmitshur opened a change net/http: limit the size of range headers parsed in ServeContent1w

Set a limit on the number of ranges in a Range header, avoiding excessive allocations/CPU when parsing a header containing a large number of small ranges. The limit is controlled by GODEBUG=httpserv…

dmitshur reviewed +2 on golang.org/x/build/internal/relui: use time.Tick directly1w

Thanks.

dmitshur reviewed +2 on golang.org/x/build/...: improve documentation for security releasing1w

Thanks. Asking a few questions to improve my understanding of what this refers to. What is an example of confusion? Is an example of that when a security fix cannot be automatically cherry-picked f…

dmitshur reviewed +2 on golang.org/x/build/internal/relui: lint manually deployed CL descriptions1w

Thanks.

dmitshur reviewed +2 on golang.org/x/website/internal/gitfs: require caller to pass http.Client1w

Thanks.

dmitshur reviewed +2 on golang.org/x/build/...: make HTTPClient required1w

Thanks.

dmitshur reviewed +2 on golang.org/x/build/internal/relui: add documentation, better nil semantics1w

Thanks. This part of the method documentation is being made obsolete by the implementation change below.

dmitshur commented on golang.org/x/website/internal/history: document Go 1.27.2 and Go 1.26.91w

Thanks.

dmitshur opened a change golang.org/x/website/internal/history: document Go 1.27.2 and Go 1.26.91w

dmitshur commented on cmd/go: go get go can write a language version as the toolchain line1w

CC @matloob.

dmitshur commented on net/http: concurrent response body Read and Close can deadlock with automatic draining in Go 1.27 [1.27 backport]1w

Moved Critical label to the upstream issue.

dmitshur commented on net/http: readLoop reads Response.ContentLength after Body.Close returns [1.27 backport]1w

Moved Critical label to the upstream issue.

dmitshur commented on net/http: Response.Body.Close returns the earlier Read error after a non-EOF Read failure [1.27 backport]1w

Moved Critical label to the upstream issue.

dmitshur commented on net/http: Response.Trailer race due to response body draining [1.27 backport]1w

Moved Critical label to the upstream issue.

dmitshur reviewed +2 on golang.org/x/build/main.star: switch gotip-linux-amd64_n4dh32 to Debian 11, in worker pool1w

Thanks.

dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder1w

Thanks. Note for next time, since this isn't the main repo, this generally needs to include the 'golang/go' prefix. ```suggestion For golang/go#82017 ``` It's not a big deal this time, and the lin…

dmitshur reviewed +2 on golang.org/x/build/main.star: add an experimental n4d go repo postsubmit builder1w

Thanks. You'd probably want to set a known issue for this experimental builder type to start out with, right? The commit message says the intent is to add a postsubmit builder, but it's currently b…

dmitshur commented on cmd/compile: regalloc reloads a value from a narrower phi's stack slot, losing its upper bits1w

From triage meeting, this is likely not a regalloc bug but elsewhere. @cherrymui said that @randall77 had a suggested approach for this might work for this.

dmitshur commented on cmd/dist: `{CC,CXX}_FOR_TARGET` is incorrectly embedded into output when cross-compiling1w

CC @golang/compiler.

dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.27 backport]1w

We discussed this in a release meeting. Approved the already-created backport CL.

dmitshur commented on cmd/asm: amd64 assembler loops forever on a forward jump to a labelled PCALIGN when a branch needs widening [1.26 backport]1w

We discussed this in a release meeting. Approved the already-created backport CL.

dmitshur commented on cmd/compile: generic shift-by-constant canonicalization gives Const64 the wrong type [1.26 backport]1w

Approving the backport to Go 1.26 for CL 795240 and CL 837245.

dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.27 backport]1w

The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.

dmitshur commented on cmd/compile: branchelim optimization can eliminate result of store [1.26 backport]1w

The upstream issue was fixed by CL 841425, so approving that for backport. Please comment if that's not right.