Activity
Today
dmitshur commented on golang.org/x/net/http2: fix race condition when disabling goroutine debugging for one test34m
(1 comment)
Please report this at [go.dev/issue/new](https://go.dev/issue/new) and include in the issue what version of Go you used, as well as the x/net version (or commit). That doesn't seem to re…dmitshur commented on golang.org/x/build/main.star: add presubmit for build in go-internal1h
Thanks.dmitshur commented on spec: [release-branch.go1.25] update spec date to match release date2h
(2 comments)
Done.
Fix applied.dmitshur commented on golang.org/x/net/http2: fix race condition when disabling goroutine debugging for one test2h
(1 comment)
I commented on TestGoroutineLock too in https://go-review.googlesource.com/c/net/+/701836/comment/d94eaf1c_c8b62623/. Please take a look at whether what you're seeing is different.dmitshur commented on spec: [release-branch.go1.25] update spec date to match release date3h
(1 comment)
A reminder for me to add this (after trybots finish running):
```suggestion
This is a roll forward of CL 709515 which was rolled back by CL 709535.
For #75743.
```dmitshur opened a change spec: [release-branch.go1.25] update spec date to match release date3h
Ths spec date in the 1.25 release branch dates back to Feb 2025
which is rather confusing. Moving it forward to 1.25 release date.
For #75743.
Fixes #75777.dmitshur commented on golang.org/x/build/internal/relui: add release/security team to ACLs3h
(1 comment)
Ok. I suspect it might be less overhead if whoever plans to own/run the actual x/ repo security fix publication workflow to also handles its pre-announcement, but no objections to adding…dmitshur commented on golang.org/x/build/internal/relui: add release/security team to ACLs3h
(1 comment)
Hmm, maybe one of the reasons we didn't have this previously was to help make it clear who owns running this workflow. Just checking, are there cases where it makes sense to have release…dmitshur reviewed +2 on golang.org/x/build/internal/relui: add release/security team to ACLs3h
Thanks.Yesterday
dmitshur opened a change golang.org/x/build/main.star: add presubmit for build in go-internal22h
dmitshur commented on golang.org/x/build/internal/workflow: correct type for constant, taskResult, expansionResult1d
Thanks.dmitshur closed an issue golang.org/x/tools/gopls: converge gopls support window with top-level Go support window1d
This Week
dmitshur fixed an issue spec: Go1.25 spec should be dated closer to actual release date1d
Closing this since there's nothing more to do for the Go 1.26 milestone - the language version and its date are for Go 1.26 there. The change on release-branch.go1.25 will be tracked in #75777.dmitshur commented on spec: Go1.25 spec should be dated closer to actual release date1d
I'll request a backport issue so this can go through the [usual backporting process](https://go.dev/wiki/MinorReleases).
@gopherbot Please backport to Go 1.25. This is a documentation-only change to…dmitshur commented on golang.org/x/build/internal/workflow: use reflect.TypeFor2d
(1 comment)
Sent CL 709516.dmitshur opened a change golang.org/x/build/internal/workflow: correct type for constant, taskResult, expansionResult2d
The type was already correct for parameter and slice, but these three
had an extra slice on top of T. Thanks to Alan for noticing this during
the review of CL 709155.
Also switch to reflect.TypeFor …dmitshur commented on Revert "[release-branch.go1.25] spec: update spec date to match release date"2d
(1 comment)
```suggestion
[release-branch.go1.25] spec: revert "update spec date to match release date"
```
That'll satisfy the 'Matching-Subject-Prefix' submit requirement.dmitshur reviewed +2 on Revert "[release-branch.go1.25] spec: update spec date to match release date"2d
Thanks.
```suggestion
This reverts CL 709515 (commit d6f274124871dbc3e55b9101e2891785500a178c).
```
Based on the suggestion at https://go.dev/wiki/CommitMessage#reverts.dmitshur commented on golang.org/x/build/internal/workflow: use reflect.TypeFor2d
(1 comment)
If this change was generated by a modernizer, should it have also applied an analogous change here? The only difference of this case I'm seeing is that it has type T here instead of []T.…dmitshur commented on golang.org/x/build/internal/workflow: use reflect.TypeFor2d
(1 comment)
Nicely spotted. That seems like a copy-paste mistake in CL 411198; it just happened to go unnoticed because we rely on the Type method primarily on Params and less so on others types of …dmitshur reviewed +2 on golang.org/x/build/internal/workflow: use reflect.TypeFor3d
dmitshur reviewed +2 on golang.org/x/build/internal/workflow: use reflect.TypeFor3d
Thanks.
Please use the suggested convention for mentioning issues as noted at https://go.dev/wiki/CommitMessage:
```suggestion
For golang/go#60088.
```Last Week
dmitshur commented on golang.org/x/website/tour: point to main Go issue tracker5d
(1 comment)
Thanks for catching this, done.dmitshur opened a change golang.org/x/website/tour: point to main Go issue tracker5d
At this point, if we're going to have a feedback button on the tour
pages, it should probably point to the main Go issue tracker and not
the separate issue tracker in the tour repository. After all, …dmitshur commented on golang.org/x/build/cmd: build Docker images via Cloud Build instead of local Docker6d
TryBot failure is unrelated, and doesn't seem to reproduce locally now. If it keeps coming up, another CL can deal with it.dmitshur commented on golang.org/x/build/cmd: build Docker images via Cloud Build instead of local Docker6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/env/linux-arm64-trixie: add Debian Trixie images6d
Thanks.
```suggestion
# nano: for interactive debugging convenience
# netbase: for net package tests, issue 42750
```dmitshur closed a change runtime: [release-branch.go1.24] skip doInit of plugins in runtime.main1w
Thanks for preparing the backport CL. Closing since the decision in issue #75146 was not to backport.dmitshur closed a change runtime: [release-branch.go1.25] skip doInit of plugins in runtime.main1w
Thanks for preparing the backport CL. Closing since the decision in issue #75147 was not to backport.dmitshur reviewed +2 on golang.org/x/build/env/linux-arm64-trixie: add Debian Trixie images1w
Thanks.
Left some optional comments. Feel free to include them or leave to a future CL, whichever works out better.
This Makefile determinutes the image name from the name of the directory it's in,…dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: use strings.FieldsFuncSeq1w
Thanks.dmitshur reviewed +2 on internal/syscall/windows: regenerate GetFileSizeEx1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/cmd/gopherbot: use strings.FieldsFuncSeq1w
Thanks.
The change itself is fine, but this commit message is quite verbose. I suggest shortening it. There's not much benefit to repeating the benchmark here, especially since there's no containsDo…Earlier
dmitshur fixed an issue all: remove support for windows/arm3w
The main bulk of the code for the windows/arm port has been removed from the main tree in time for Go 1.26, and the port removal is [documented](https://tip.golang.org/doc/go1.26#windows) in the rele…dmitshur starred github.com/Soreil/arw3w
dmitshur reopened an issue golang.org/x/crypto/x509roots: regeneration fails with "404 Not Found"3w
Reopening since this seems to continue to reproduce at least 1-2 days over the last few weeks.dmitshur commented on net: TestDialContextCancelRace failures [consistent failure]3w
This consistent failure started with [CL 699256](https://go.dev/cl/699256). CC @database64128, @seankhliao, @dneil.dmitshur commented on golang.org/x/build: extend main Go repo's "every vet check is forcibly made high-confidence" behavior to golang.org/x packages that are vendored (or exclude vendored packages from it)4w
Another instance of this happened in https://github.com/golang/go/issues/73998#issuecomment-3275332889. Though in this case it happens that the unreachable check isn't enabled in all.bash, but is bei…dmitshur commented on golang.org/x/tools/go/analysis/unitchecker: TestVetStdlib failures4w
> Separately, I thought a vet failure in stdlib would be reported by all.bash, is that not the case or did something break?
Oh, I see. The unreachable vet check is one of the two explicitly disabled…dmitshur closed an issue : a placeholder issue4w
dmitshur opened an issue : a placeholder issue4w
dmitshur opened an issue golang.org/x/build: "gomin" builders that test golang.org/x modules at their minimum Go toolchain version (using linux/amd64 only to start with)4w
This new-builder issue is a new opportunity enabled by work in #69095: it relies on golang.org/x modules now always having a requirement on a supported Go toolchain version. It is also based on findi…dmitshur pushed to
main in dmitri.shuralyov.com/service/change4modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl4ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments5y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust5y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle5ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages5y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)5y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes5ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim5y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit5y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/service/change5ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase5ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit5ydmitshur pushed to
master in dmitri.shuralyov.com/state5ydmitshur pushed to
master in dmitri.shuralyov.com/scratch5ydmitshur pushed to
master in dmitri.shuralyov.com/app/changes5ydmitshur pushed to
master in dmitri.shuralyov.com/route/github5ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt5ydmitshur pushed to
master in dmitri.shuralyov.com/route/github5ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
I’m glad that it helped. Don’t hesitate to let me know if the issue happens again.dmitshur commented on dmitri.shuralyov.com/app/changes: https fetch: Get https://dmitri.shuralyov.com/app/changes?go-get=1: x509: certificate signed by unknown authority6y
Hello, thanks for the report.
Is this problem reproducible for you? If so, can you share commands for me to run so I can try to reproduce it too?
For question 1, this is the canonical source, but y…dmitshur opened an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur closed an issue dmitri.shuralyov.com/website/gido: same issue or CL may appear multiple times for pattern queries6y