Dmitri Shuralyov

(1 comment) Yeah, it might be more useful when a subset of a large stack is generated, less so for one-off standalone CLs. I'll consider this more for future CLs. Thanks.

dmitshur commented on golang.org/x/mobile/...: delete obsolete import comments1d

Thanks. Yes, it's likely when that line was added it was much earlier, but moving it higher up is likely an improvement by now. If you'd like, feel free to send an issue or CL. Thanks.

dmitshur commented on syscall: disable O_DIRECTORY on Windows for js/wasm1d

(1 comment) Please run `gofmt -w .` to make this file formatted.

dmitshur commented on golang.org/x/tools/...: upgrade go directive to at least 1.23.0 [generated]1d

Thanks. Done. CL 650095 drops the comment. Thanks. CL 650095 takes care of the comment, and as you mentioned the other aspect of this has been considered.

dmitshur commented on golang.org/x/mobile/...: delete obsolete import comments1d

(1 comment) As I realize now, this is documented in the second last sentence of https://pkg.go.dev/cmd/go#hdr-Import_path_checking.

dmitshur commented on golang.org/x/exp/cmd/{apidiff,gorelease}: delete redundant //go:debug gotypesalias=1 directives [generated]1d

Thanks.

dmitshur commented on golang.org/x/tools/...: delete redundant //go:debug gotypesalias=1 directives [generated]1d

(1 comment) I've intended for it to be a hint that the contents of the change are entirely generated by the git-generate script (i.e., re-running `git-generate` on the commit should produce a zero d…

dmitshur commented on runtime: check LSE support on ARM64 at runtime init2d

Sure. Thanks.

dmitshur opened an issue github.com/immersive-web/webxr-samples: broken link to WebXR/WebGPU bindings on WebXR Report page2d

Hello, I'm reporting that the 'WebXR/WebGPU bindings' link at https://immersive-web.github.io/webxr-samples/report/ is broken: https://github.com/immersive-web/webxr-samples/blob/082da254f525a9ec077…

dmitshur fixed an issue golang.org/x/tools/gopls/internal/telemetry/cmd/stacks: go build within TestReadPCLineTable fails with "go: unknown GOEXPERIMENT synctest"2d

The recent failures are not the original "unknown GOEXPERIMENT synctest" error, but a different problem, that just happens to be in the same test. Narrowed down the watchflakes query to let it file a…

dmitshur reviewed +2 on golang.org/x/build/...: fix links to Go wiki2d

Thanks.

dmitshur starred github.com/dominikh/gutter3d

dmitshur commented on cmd/go: packages with non root vendor elements excluded from module3d

Issue #37397 was about some packages whose import path _ends_ with "/vendor" being treated as if they're vendored, and being left out of module zips. It looks like what you're running into isn't tha…

dmitshur commented on github.com/mdempsky/unconvert: Internal error3d

@JetSetIlly Does `go version -m $(which unconvert)` print v0.0.0-20250216222326-4a038b3d31f5 or an older version? The latest tag cache might not have worn off yet, meaning you'd need to do `go instal…

dmitshur deleted branch in github.com/mdempsky/unconvert3d

go-124-123

dmitshur pushed to master in github.com/mdempsky/unconvert3d

4a038b3d31f56ff5ba511953b745c80a2317e4aeall: update go and dependency versions [generated]

dmitshur fixed an issue github.com/mdempsky/unconvert: Internal error3d

dmitshur merged a change github.com/mdempsky/unconvert/...: update go and dependency versions [generated]3d

dmitshur commented on github.com/mdempsky/unconvert/...: update go and dependency versions [generated]3d

Thanks.

dmitshur opened a change github.com/mdempsky/unconvert/...: update go and dependency versions [generated]3d

Fixes #66. [git-generate] go get go@1.23.0 toolchain@none golang.org/x/tools@v0.30.0 golang.org/x/text@v0.22.0 go mod tidy sed -i '' 's/21/24/' .github/workflows/test.yml sed -i '' 's/20/23/' .…

dmitshur created branch in github.com/mdempsky/unconvert3d

go-124-123

dmitshur opened a change golang.org/x/net/context: delete lone example3d

This is motivated by a few reasons. One, the upstream package has more examples, and no one should be looking at this old package to learn how to use it. Seeing an example might make it seem like the…

dmitshur commented on golang.org/x/net/context: deprecate package or symbols in package3d

There's also a [context fix](https://cs.opensource.google/go/go/+/master:src/cmd/fix/context.go;l=15-21;drc=bf90da97c1aaec78d2f8ad8b74a506d3b6f0ee75) available to aid with the migration, so [`go fix`…

dmitshur opened a change golang.org/x/exp/cmd/{apidiff,gorelease}: delete redundant //go:debug gotypesalias=1 directives [generated]3d

The module's go directive is >= 1.23 now, so these files no longer have any effect. For golang/go#70695. For golang/go#69772. [git-generate] find . -type f -name gotypesalias.go -exec rm {} +

dmitshur opened a change golang.org/x/tools/...: delete redundant //go:debug gotypesalias=1 directives [generated]3d

The module's go directive is >= 1.23 now, so these files no longer have any effect. For golang/go#69772. [git-generate] find . -type f -name gotypesalias.go -exec rm {} +

Last Week

dmitshur commented on golang.org/x/mobile/bind: pin go/types to not produce types.Alias types4d

Thanks.

dmitshur opened a change golang.org/x/mobile/...: make copyright headers consistent4d

The standard copyright header at https://go.dev/doc/contribute#copyright has a single space (also see CL 20022). Also, add it to a files where it was missed.

dmitshur opened a change golang.org/x/mobile/bind: pin go/types to not produce types.Alias types4d

Bind currently targets the earlier go/types semantics (gotypesalias=0), and needs to be updated to be compatible with the new (gotypesalias=1). This is the only way in which the module isn't compati…

dmitshur opened a change golang.org/x/mobile/...: delete obsolete import comments4d

Import comments were initially used to specify the canonical import path of a package, to prevent it from being used with a non-canonical path by accident. The module path in the go.mod file serves t…

dmitshur commented on golang.org/x/exp/sumdb: bump golang.org/x/crypto dependency4d

@roland@golang.org, if you're okay with rebasing this change, [CL 649376](https://go-review.googlesource.com/c/exp/+/649376/1/sumdb/go.mod) upgrades the go directive and is ready to be submitted a…

dmitshur commented on golang.org/x/exp/...: upgrade go directive to at least 1.23.0 [generated]4d

The trybot failures turned out to have been due to #71759 in the main Go repo, which is fixed now.

dmitshur commented on cmd/go/internal: use pathpkg name more5d

Thanks.

dmitshur commented on os: add Root.Chown5d

Thanks, this is fixed in CL 649636 now. @dneil@google.com A solaris/amd64 builder is available in LUCI infra, see https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-solaris-amd64 for …

dmitshur fixed an issue access: approvers5d

Hi @cpu, Thank your for contributing to the Go project and all of your work on packages related to Go's security and cryptography. We've discussed this request on the team and agreed to grant you th…

dmitshur commented on github.com/dgraph-io/badger/v4/fix(aix): add aix directory synchronization support5d

In case it's helpful, I'll point out that you can get some signal from compile-only testing via cross-compilation. For example, `GOOS=aix GOARCH=ppc64 go test -c -o=/dev/null` can be run on any platf…

dmitshur reviewed +2 on golang.org/x/build/main.star: add presubmit for oauth2 in go-internal5d

Thanks.

dmitshur reviewed +2 on golang.org/x/exp/sumdb: bump golang.org/x/crypto dependency5d

Thanks. Indeed, from [x/exp's by Go commit](https://ci.chromium.org/p/golang/g/x-exp-gotip-by-go/console) view it looks like it's introduced by CL 629256. (FYI @khr@golang.org.) This'll be bumped …

dmitshur commented on cmd/internal/obj/x86: add support for the endbr64 instruction on amd645d

(1 comment) FWIW the spaces here are different; not sure it matters much.

dmitshur reviewed +2 on golang.org/x/crypto/...: bump golang.org/x/crypto dependencies of asm generators5d

Thanks.

dmitshur commented on golang.org/x/tools/...: upgrade go directive to at least 1.23.0 [generated]5d

(2 comments) I've reviewed the CL and everything here looks right to me. The gopls module is left as is, it's already on a higher vrsion. The top-level x/tools module is updated to language version …

dmitshur commented on golang.org/x/debug/...: upgrade go directive to at least 1.23.0 [generated]5d

(1 comment) This is nearly a no-op, but it have some beneficial effect that e.g. someone accidentally still using go1.23rc1 (instead of the final stable 1.23 release) would get upgraded.

dmitshur commented on golang.org/x/build/...: upgrade go directive to at least 1.23.0 [generated]5d

(1 comment) I looked into this brifly too, and found that moving this module to language 1.21 is enough for the new lines to get added. I don't see a specific reason for it in https://go.dev/doc/go1…

dmitshur commented on golang.org/x/crypto/...: upgrade go directive to at least 1.23.0 [generated]5d

(1 comment) CL 649716.

dmitshur opened a change golang.org/x/crypto/x509roots/fallback: drop obsolete build constraint5d

The go directive is at go1.23.0 and this build constraint was previously working to set a minimum supported version, but now it lowers it.

dmitshur commented on golang.org/x/crypto/...: upgrade go directive to at least 1.23.0 [generated]5d

(2 comments) Hmm, this build constraint is no longer needed, the go directive in go.mod is enough now that all supported Go versions treat it as a minimum rather than advisory. (That is, Go 1.20 doe…

dmitshur commented on golang.org/x/benchmarks/...: upgrade go directive to at least 1.23.0 [generated]5d

(1 comment) These old-style // +build lines aren't needed as of Go 1.18 and they're being removed automatically, as mentioned at https://go.dev/doc/go1.18#go-build-lines: > Since the release of Go …

dmitshur opened a change golang.org/x/build/repos: add AutoTagNextMinorVersion and AutoMaintainGoDirective5d

Originally, the ShowOnDashboard property controlled whether a given repo was displayed in the list of golang.org/x repositories at the bottom of the build.golang.org dashboard. Because that page was …

dmitshur commented on cmd/go/internal: remove duplicate imported packages5d

(1 comment) It's not a big deal, but if you'd like to change it, I can suggest something like this: ```suggestion cmd/go/internal: use pathpkg name more The package "path" is already imported unde…

dmitshur commented on cmd/go/internal: remove duplicate imported packages5d

(1 comment) Note that a package can either be imported (one time) or not (zero times). It's not possible for a Go package to import another package more than once. It is possible to refer to an impo…

dmitshur commented on cmd/go: stamped (pseudo) version on build does not work for module in subdirectory5d

CC @matloob, @samthanawalla.

dmitshur commented on cmd/go: go run and go tool are still quite slow (50ms on Mac M1 Max with warm caches)5d

CC @matloob, @samthanawalla.

dmitshur opened a change net/http: unskip TestDisableContentLength/h26d

h2_bundle.go has been updated.

dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle6d

With CL 648735, CL 648916, and CL 649296, everything's updated for the early-in-cycle round. Removing that label to revisit this when the release freeze starts.

dmitshur reviewed +2 on net/http: add httpcommon package6d

Thanks. Indeed, that's right.

dmitshur reviewed +2 on net/http: add httpcommon package6d

Thanks for arranging this, everything looks good, one optional comment. I wish bundle wasn't trying to take on the responsibility of including the //go:generate directive in the generated output fil…

dmitshur reviewed +2 on golang.org/x/oauth2/endpoints: add links/provider for Discord6d

Thanks.

dmitshur commented on golang.org/x/oauth2/endpoints: add links/provider for Discord6d

(1 comment) This is an exported identifier. See https://go.dev/doc/comment: > Every exported (capitalized) name should have a doc comment.

dmitshur commented on net: Resolver leads to too many DNS queries6d

CC @ianlancetaylor, @neild.

dmitshur commented on crypto/tls: wrong error returned in ECHConfig parsing6d

CC @golang/security.

dmitshur reviewed +2 on golang.org/x/build/internal/task: add workflow to pre-announce x fixes6d

Thanks. If it becomes desired to document, add example values, or a quick validation check for these inputsin the future, keep in mind you can do that via [Doc, Example, Check fields](https://pkg.go…

dmitshur opened a change cmd/pprof: update vendored github.com/google/pprof [generated]1w

Pull in the latest published version of github.com/google/pprof as part of the continuous process of keeping Go's dependencies up to date. For #36905. [git-generate] cd src/cmd go get github.com/go…

dmitshur commented on golang.org/x/build: gotip-linux-amd64-misccompile builder fails with no space left on device1w

Oh, so the $HOME/.cache isn't being cleaned by anything? Yeah, using a cache directory in a per-build work directory that is cleaned sounds good. Did you mean XDG_CACHE_HOME (s/_DIR/_HOME)? Setting …

dmitshur commented on golang.org/x/build: gotip-linux-amd64-misccompile builder fails with no space left on device1w

Thanks for filing an issue to track this. Oddly, as Michael K. pointed out, it seems this isn't happening in post-submit so far, yet fairly often in pre-submit recently. Compare with: https://ci.ch…

dmitshur reviewed +2 on cmd/go: [release-branch.go1.24] initialize req.Header when loading git credential1w

Cherry pick looks good. One of the misccompile shards failed due to running out of disk space (issue #57902), bypassing it.

dmitshur commented on golang.org/x/tools/cmd/goimports: add a flag to skip generated files1w

CC @golang/tools-team.

dmitshur commented on encoding/asn1: ObjectIdentifier Unmarshal error if SubOID > MaxInt32 on 64bit machine too1w

CC @golang/security.

dmitshur commented on runtime: recover calls in loop body of ranging over iterators doesn't take effect1w

CC @golang/runtime.

dmitshur commented on runtime: recover added in range-over-func loop body doesn't stop panic propagation / segfaults printing error1w

CC @golang/runtime.

dmitshur reviewed +2 on golang.org/x/website/_content/doc/modules/managing-dependencies: remove unneeded '-u' flag and mention '-modfile'1w

Thanks.

dmitshur commented on all: update vendored dependencies [generated]1w

Thanks.

dmitshur commented on os: MkdirAll fails when a parent folder contains trailing spaces 1w

@qmuntal If I understand right, when you applied the release-blocker label in Nov 2024 it was meant to be to track reverting CL 618496 in time for Go 1.24, is that right? Note that when using that la…

dmitshur commented on all: update vendored dependencies [generated]1w

(1 comment) Now that the typeutil vet issue is resolved, all that's left is for someone more familiar with vet to review this file. @adonovan@google.com Is this vet test change expected and okay?

dmitshur commented on all: update vendored dependencies [generated]1w

Copied Votes: * Code-Review+2 (copy condition\*: "**is:ANY**") Outdated Votes: * LUCI-TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE") \* The label has `labelCopyEnforcement` or `label…

dmitshur commented on golang.org/x/tools/go/types/typeutil: avoid shifting uintptr by 32 on 32-bit archs1w

Copied Votes: * Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**") * LUCI-TryBot-Result+1 (copy condition: "**changekind:NO_CODE_CHANGE**") \* The label has `labelCopyEnforcement` or `lab…

dmitshur commented on golang.org/x/tools/go/types/typeutil: avoid shifting uintptr by 32 on 32-bit archs1w

Thanks.

dmitshur commented on golang.org/x/tools/go/types/typeutil: avoid shiftint uintptr by 32 on 32-bit archs1w

Outdated Votes: * Code-Review+1 (forced copy restriction\*: "**changeis:review-enforced_gerrit** AND NOT changekind:TRIVIAL_REBASE_WITH_MESSAGE_UPDATE AND NOT (**uploaderin:trusted-users_gerrit** AND…

dmitshur commented on golang.org/x/tools/go/types/typeutil: avoid shiftint uintptr by 32 on 32-bit archs1w

(1 comment) > I wonder why nothing in our CI process causes the go test set of vet checks to run on this package on a 32-bit OS, because presumably it would continue to fail even after this change, …

dmitshur commented on all: update vendored dependencies [generated]1w

Reported the problem on [the upstream CL](https://go-review.googlesource.com/c/tools/+/612496/comment/97413f32_a97e66d3/), sent CL 648895 as a potential fix. (FYI @adonovan@google.com.)

dmitshur commented on golang.org/x/tools/go/types/typeutil: use maphash.Comparable in Go 1.24+1w

(The context for this change is [here](https://go-review.googlesource.com/c/tools/+/612496/comment/97413f32_a97e66d3/).)

dmitshur commented on golang.org/x/tools/go/types/typeutil: make Hasher stateless1w

(1 comment) linux/386 is a first-class port where uintptr is 32-bit, causing vet to report the finding: ``` $ GOOS=linux GOARCH=386 go vet golang.org/x/tools/go/types/typeutil # golang.org/x/tools/…

dmitshur opened a change golang.org/x/tools/go/types/typeutil: use maphash.Comparable in Go 1.24+1w

This resolves a TODO, and also coincidentally dodges vet's check for shifts that equal or exceed the width of the integer from triggering on the hash >> 32 shift on 32-bit architectures. For example,…

dmitshur commented on all: update vendored dependencies [generated]1w

TryBots uncovered a problem on linux/386, I'll look.

dmitshur opened a change all: update vendored dependencies [generated]1w

The Go 1.25 development tree has opened. This is a good time to update all golang.org/x/... module versions that contribute packages to the std and cmd modules in the standard library to latest maste…

dmitshur commented on golang.org/x/build/main.star: clean up after dropping release-branch.go1.221w

Thanks.

dmitshur commented on golang.org/x/build/main.star: remove known issues for -tiplang builder in x/crypto, x/tools1w

Thanks.

dmitshur commented on golang.org/x/build/main.star: update supported Go versions and drop release-branch.go1.221w

Thanks. Thanks for the suggestion. If it's a comment like '# NEXTUP_GO should be added here after release-branch.go1.25 is created.', it's a bit easy to miss it in the INTERNAL_GO_BRANCHES section b…

dmitshur opened a change golang.org/x/build/main.star: stop running typesalias builder beyond Go 1.241w

Based on the issue, these builders weren't intended to stick around beyond Go 1.24. Update 'exists' to take into account that Go tip is at 1.25, and x/tools will soon be upgraded to language version …

dmitshur commented on golang.org/x/build/main.star: clean up after dropping release-branch.go1.221w

Copied Votes: * Code-Review+1 (copy condition\*: "**is:ANY**") Outdated Votes: * LUCI-TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE") \* The label has `labelCopyEnforcement` or `label…

dmitshur opened a change golang.org/x/build/main.star: clean up after dropping release-branch.go1.221w

Delete code that became dead as of CL 648675. Generated files unchanged.

dmitshur opened a change golang.org/x/build/main.star: remove known issues for -tiplang builder in x/crypto, x/tools1w

They're both fixed. For golang/go#71612. For golang/go#71613.

dmitshur commented on build: windows/arm (32-bit ARM) port is broken1w

@mcandre go tool dist list already leaves out broken ports by default. Broken ports can be listed too by passing in the `-broken` flag. <details><br> ``` $ go version go version go1.24.0 darwin/arm…

dmitshur commented on golang.org/x/tools/internal/stdlib: update stdlib index for Go 1.24.01w

Thanks for updating it earlier in CL 636835 for 1.24 pre-releases as well! If you think it's helpful, feel free expand this relui task to run for RCs in addition the .0 final by changing [this line](…