Activity
Yesterday
dmitshur commented on github.com/yifanwu/blanknewtab: Get it to support Dark Mode17h
In case it helps, I've found the following 3 very simple files to work well in my testing. They support both light and dark modes, switching between them based on the OS-wide (or browser-wide) prefer…dmitshur reviewed +2 on golang.org/x/build/internal/gophers: add mkalil18h
Thanks.dmitshur commented on golang.org/x/build: LUCI support for plan918h
Great! Yes, as long as you're taking care of the swarming_bot instance separation carefully as you mentioned and you're not seeing problems as a result of it, reusing a single Linux machine as the pr…This Week
dmitshur pushed to
main in github.com/gopherjs/snippet-store1ddmitshur closed a change go/doc: update url matcher to exclude trailing chars1d
Closing because issue #37640 is resolved by now.dmitshur commented on go/doc: URL at end of sentence inside brackets causes trailing period to get incorrectly included in the URL1d
Indeed. Likely fixed during the Go 1.19 doc comment changes (https://go.dev/doc/go1.19#go-doc, issue #51082).dmitshur commented on golang.org/dl/gotip: enable configuring install path1d
I believe this is the same as issue #26520, except that one is about all of the golang.org/dl/go1.N.M commands, not just the gotip one. In that issue, one of the suggested names for a environment var…dmitshur commented on golang.org/x/build: LUCI support for plan91d
Ok, the [plan9-arm](https://chromium-swarm.appspot.com/bot?id=plan9-arm) bot has the target_ dimensions applied now, and I've submitted [CL 637437](https://go.dev/cl/637437). You should be able to pr…dmitshur commented on golang.org/x/build/main.star: match plan9 builders by new target_go{os,arch} dimensions1d
That's done now.
Thanks.dmitshur commented on golang.org/x/build: LUCI support for plan91d
Ok, we should have a way to move forward. Instead of matching the individual Plan 9 builders for each of the GOARCH values by swarming bot id, which doesn't scale beyond 1 bot, we'll match by new tar…dmitshur commented on golang.org/x/build/main.star: match plan9 builders by new target_go{os,arch} dimensions1d
This change is ready for review.dmitshur closed an issue golang.org/x/build: use cloud build to deploy x/build services1d
Issue #70913 supersedes this.dmitshur commented on net/http: TestTransportIdleConnTimeout failures1d
@rsc The fix pending refers to [CL 633275](https://go.dev/cl/633275) from 2 weeks ago (via https://github.com/golang/go/issues/67450#issuecomment-2515255872 above; you might need to expand timeline).…dmitshur commented on crypto/ecdsa: fix condition for fips140=only check2d
To clarify about the release process: while we're in the [freeze](https://groups.google.com/g/golang-dev/c/JkRenbsSBv4) for Go 1.24 now, all changes submitted to the main branch are for the eventual …dmitshur reviewed +2 on cmd/dist: skip fips140test in exe mode on Android2d
Thanks.
I think this is good now, and in the future, if there turns out to be more per-OS cases or this logic needs to be used in more places, this can be factored out into a "supported" helper.dmitshur commented on golang.org/x/build/main.star: display open2opaque as a google.golang.org repo2d
Thanks.dmitshur commented on golang.org/x/build/main.star: display open2opaque as a google.golang.org repo2d
This change is ready for review.dmitshur opened a change golang.org/x/build/main.star: display open2opaque as a google.golang.org repo2d
It's not a golang.org/x one.dmitshur opened a change golang.org/x/build/main.star: match plan9 builders by new target_go{os,arch} dimensions2d
This makes it possible for their builder owners to run more than one
bot instance per target GOOS/GOARCH pair to test.
For golang/go#62025.dmitshur commented on golang.org/x/build: LUCI support for plan92d
You're doing the "--02" suffix part right, but running into a limitation of the approach we used in https://github.com/golang/go/issues/62025#issuecomment-2135813578 that currently relies on the "id"…dmitshur reviewed +2 on golang.org/x/build/cmd/gitmirror: switch to cloud build3d
Indeed, thanks!
Optionally, consider switching to using the version.sh helper here:
```suggestion
VERSION := $(shell ../coordinator/version.sh)
```
It provides additional information about the sta…dmitshur commented on govulncheck-action: Support using a later patch release than what's in go.mod3d
@kaovilai Thanks. I agree that absent of a toolchain directive, it's viable to pick either exactly the minimum toolchain that meets the 'go' directive requirement, or the latest minor release of the…dmitshur commented on govulncheck-action: Support using a later patch release than what's in go.mod3d
I'm not sure I understand that point. The toolchain directive, in contrast to the go directive, applies only to the current module (the one defined by the go.mod file). It suggests the toolchain to b…dmitshur commented on govulncheck-action: Support using a later patch release than what's in go.mod3d
The original issue reports:
> 1.22.0 go.mod results in 1.22.0 being used and no option to use later 1.22
I have a question about that – what is the behavior for the following go.mod file:
…dmitshur commented on golang.org/x/build/cmd/watchflakes: periodically restarts3d
Watchflakes currently implements retries at the process level. That is, it has many code paths that handle errors with a log.Fatal (see [here](https://cs.opensource.google/search?q=fatal&ss=go%2Fx%2F…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder3d
Thank you for offering to provide the builders, and apologies for the delay in getting back to these questions.
> Therefore it's hard to get any decent powerful hardware for CI stuff. Should those…dmitshur reviewed +2 on golang.org/x/build/relnote: fix the typo in links.go3d
Thanks.dmitshur commented on golang.org/x/tools/cmd/stringer: place test package files in a test module4d
Thanks.dmitshur closed a change golang.org/x/build/internal/gophers: add Veronica4d
Closing since this ended up not being used.dmitshur commented on golang.org/x/tools/cmd/stringer: place test package files in a test module4d
Friendly ping @mvdan@mvdan.cc.dmitshur pushed to
pointer-and-data in honnef.co/go/js/dom5ddmitshur opened a change honnef.co/go/js/dom: add PointerID and PointerType to PointerEvent, as well as DataTransfer.SetData5d
I plan to merge this in a few days. This PR exists so that it's possible to leave review comments before then, but a review is not required. Thanks.
References:
- https://developer.mozilla.org/…dmitshur created branch in honnef.co/go/js/dom5d
pointer-and-dataLast Week
dmitshur commented on golang.org/x/website: automatic URL fragments for sub-sections of 'Minor changes to the library' are overly repetitive6d
These headings are automatically generated rather than hand-written, and it's likely they got more repetitive after we switched to using Markdown for release notes instead of raw HTML (e.g., issue #6…dmitshur commented on golang.org/x/build: set a maintenance window for the kubernetes instance1w
We've now set a maintenance window to be during early weekday mornings, skipping Friday. We can wait a bit to see how it goes, adjusting further if needed.dmitshur commented on cmd/go: add fips140 module selection mechanism1w
Given #69536 and #70123 are in Go1.24 milestone, it seems this should be too, right?dmitshur commented on github.com/GoogleCloudPlatform/gsutil: gsutil 5.31 doesn't work with Python 3.12.7 in alpine 1w
The comment at https://github.com/GoogleCloudPlatform/gsutil/issues/1776#issuecomment-2538018415 says that gsutil version 5.32 and above supports Python 3.12.dmitshur fixed an issue build: build failure on darwin builders since CL 536399 [consistent failure]1w
Failures above were on release-branch.go1.24 prior to [CL 634237](https://go.dev/cl/634237).dmitshur commented on golang.org/x/build: add LUCI openbsd-riscv64 builder1w
Checking in on the status here. Did the comment above resolve the need to make further changes, or would you still like to pursue that?
The builder appears to be missing now (https://ci.chromium.o…dmitshur commented on crypto/internal/fips140test:exe_external: unrecognized failures1w
It does look consistent to me, at least the last few pages of gotip-linux-riscv64 results ignoring the unrelated failure in build 8728977600951940513.dmitshur commented on crypto/internal/fips140test:exe_external: unrecognized failures1w
CC @mengzhuo.dmitshur commented on robpike.io/ivy/...: add @ operator modifier1w
Interestingly, that's different from https://go.dev/s/style#declaring-empty-slices which suggests the var style for empty slices.Earlier
dmitshur opened an issue syscall: fs_js.go accesses a fs.O_DIRECTORY constant that's not defined in browsers1w
At Go tip, js/wasm programs inside a browser run into a panic during init of syscall package:
```
panic: syscall/js: call of Value.Int on undefined
goroutine 1 [running]:
syscall/js.Value.flo…dmitshur commented on golang.org/x/build: add doas package on NetBSD systems2w
There are LUCI builders for netbsd/arm and netbsd/arm64 ports (#63698 and #63614). They're remote, so this change is something their builder owner can consider applying (CC @bsiegert).dmitshur closed an issue golang.org/x/build: add builder for netbsd/arm642w
I don't believe there are active plans to pursue a non-reverse netbsd/arm64 builder now, and a newer reverse builder for LUCI was added: https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/go…dmitshur fixed an issue golang.org/x/build: add LUCI netbsd-arm builder2w
I think we can close this now – the builder is added and its known issue is removed. Thanks!dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle2w
[CL 634041](https://go.dev/cl/634041), [CL 631336](https://go.dev/cl/631336), and [CL 626995](https://go.dev/cl/626995) took care of the start-of-freeze updates for the Go 1.24 cycle. There may still…dmitshur commented on golang.org/x/build/internal/releasetargets: evaluate for each upcoming major Go release2w
[CL 612555](https://go.dev/cl/612555) regenerated the list for Go 1.24. It's the same list as for Go 1.23 but without windows/arm (32-bit), and that's noted at https://go.dev/doc/go1.24#windows.
I…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle2w
Anything other "pick latest versions of all x/ repos" does need some manual intervention. You could still use updatestd, just followed by a `go get golang.org/x/net@{pseudo-version before CL 632816}`…dmitshur commented on testing: integer divide by zero in predictN2w
Also reproduces on an M1 Pro machine.
> Looking through the code some codepaths sanitize the nanoseconds before calling predictN, others don't. I'll send a fix.
I did that locally (in B.stopOrScale…dmitshur opened an issue testing: integer divide by zero in predictN2w
`go test -count=1000 -run=^TestBLoopHasResults$ testing` reliably reproduces this on this machine, a MacBook Pro with M4 Pro, macOS 15.1.1 (24B2091).dmitshur commented on golang.org/x/build: add doas package on FreeBSD and NetBSD systems2w
Now that #61095 is nearly done, I think this should be a matter of adding the right package to [this line](https://cs.opensource.google/go/x/build/+/master:env/freebsd-amd64/make.bash;l=249;drc=a0b63…dmitshur opened an issue golang.org/x/build/cmd/relnote: improve experience for documenting new standard library packages2w
The cmd/relnote test requires that all new APIs have a corresponding entry in doc/next/\*-stdlib/\*-minor. This works as intended for most APIs, but some new APIs are entirely new packages. Those are…dmitshur opened an issue build: windows/arm (32-bit ARM) port is broken2w
The Go porting policy has a section on broken ports, https://go.dev/wiki/PortingPolicy#broken-ports. The GOOS=windows GOARCH=arm (not arm64) port was marked broken in August 2024 ([CL 601777](https:/…dmitshur closed an issue golang.org/x/crypto/openpgp/clearsign: TestMultiSign failures2w
Duplicate of #70682.dmitshur commented on io/fs: add ReadLinkFS interface [freeze exception]2w
We considered this freeze exception in a release meeting today. This seems to be a new API that would be safe to land in the next upcoming major Go release, Go 1.25, so that if there are unexpected i…dmitshur commented on golang.org/x/crypto/openpgp/clearsign: TestMultiSign fails with "random source is broken" at Go tip2w
Thanks for the quick fix! The monthly golang.org/x tagging workflow ran into this, and the fix allowed it to keep going (https://go.googlesource.com/crypto/+/refs/tags/v0.30.0).dmitshur created repository in google.golang.org/open2opaque2w
dmitshur opened an issue golang.org/x/crypto/openpgp/clearsign: TestMultiSign fails with "random source is broken" at Go tip2w
At Go tip, TestMultiSign fails when run without -short flag, including on first class ports like linux/amd64:
```
=== RUN TestMultiSign
clearsign_test.go:155: cannot create key: rsa: gener…dmitshur commented on lib/time: update tzdata before release2w
Added okay-after-rc1 since RC 1 is scheduled for [next week](https://go.dev/s/release#june--december-week-2-release-candidate-1-issued) and 2024b is still the latest. (CC @mknyszek.) We'll keep this …dmitshur deleted branch in github.com/shurcooL/git-branches2w
8weeksdmitshur pushed to
main in github.com/shurcooL/git-branches2wdmitshur commented on golang.org/x/tools/godoc/vfs: ReadDir reports files as directories after Bind was called on a file2w
@seankhliao I don't see a [frozen notice](https://go.dev/wiki/Frozen) convention applied to golang.org/x/tools/godoc nor golang.org/x/tools/godoc/vfs. It doesn't seem to be frozen? Does that still ne…dmitshur opened an issue golang.org/x/build/cmd/relui: add workflows for some remaining manual recurring Go major release cycle tasks2w
In addition to workflows for all of Go release types, relui holds a few workflows for miscellaneous recurring tasks that come up in the release cycle (go.dev/s/release) such as [pinging early-in-cycl…dmitshur commented on golang.org/x/tools/godoc/vfs: path separator character(s) in FileSystem, Opener interfaces is not specified2w
This issue is still valid and relevant to the package, but the package itself is probably less relevant now that io/fs exists. It should probably be deprecated in favor of that as part of #59056.dmitshur commented on golang.org/x/tools/godoc/vfs/zipfs: remove zipfs package2w
By now we have answers to those questions from 6 years ago: removing a golang.org/x package involves deprecating it, isolating it to its own nested module, tagging that, and then deleting from main b…dmitshur opened an issue testing: TestBenchmarkBLoopIterationCorrect fails under GOMAXPROCS=12w
At tip (commit c5adb8216968be46bd11f7b7360a7c8bde1258d9), TestBenchmarkBLoopIterationCorrect succeeds under most conditions.
<details><br>
```
$ go test -run=^TestBenchmarkBLoopIterationCorrec…dmitshur starred github.com/randomouscrap98/ardugotools3w
dmitshur reviewed +2 on github.com/golang/groupcache/...: add go.mod, update for Go 1.243w
LGTM. Thanks.dmitshur reviewed +2 on github.com/golang/groupcache/...: add go.mod, update for Go 1.243w
LGTM. Thanks.dmitshur commented on github.com/golang/groupcache/...: add go.mod, update for Go 1.243w
(minor) Oddly, this go-cmp go.mod checksum entry, as well as the xerrors go.mod entry on line 6, do not show up for me after a `go mod tidy` with go1.23.3. But extra lines in go.sum are harmless.dmitshur closed an issue golang.org/x/build: golang.org/x/xerrors repository isn't on build.golang.org dashboard3w
We solved this during the migration to LUCI, golang.org/x/xerrors has post-submit builders visible on its dashboard (e.g., https://ci.chromium.org/p/golang/g/x-xerrors-gotip/console). It's still not …dmitshur fixed an issue sync/atomic: TestNilDeref flaky failure on windows-386 with runtime fatal error3w
The fix is backported and this shouldn't happen on release branches either, now. Closing again.dmitshur commented on golang.org/x/tools/go/packages: gotypesalias=1 does not seem to get used correctly for deps on Go 1.233w
@mvdan This issue can indeed be marked as closed since it's resolved in Go 1.24, but the Go1.24 milestone is right. There are child backport issues that need to refer to this one. We need a parent is…dmitshur commented on os: TestGetwdDeepWithPWDSet failures3w
This is a continuation of https://github.com/golang/go/issues/69234#issuecomment-2501169320. So far, These particular failures seem to only happen on the darwin/amd64 builders with macOS 11.dmitshur pushed to
master in github.com/mdempsky/unconvert3w
dmitshur merged a change github.com/mdempsky/unconvert/...: replace deprecated io/ioutil with os3w
dmitshur reviewed +2 on github.com/mdempsky/unconvert/...: replace deprecated io/ioutil with os3w
Thanks.dmitshur opened an issue cmd/link: document that on ELF, GNU build ID is now generated by default3w
A [comment on CL 618601](https://go-review.git.corp.google.com/c/go/+/618601/comments/3d652992_21d045d6) indicated that the change (which fixed #63934 and #68652) should likely be mentioned in [Go 1.…dmitshur reopened an issue cmd/link: LC_UUID not generated by go linker, resulting in failure to access local network on macOS 153w
A [comment on the CL](https://go-review.googlesource.com/c/go/+/618598/comments/6a1b5da8_513f46c7) suggested that this change should be mentioned in [Go 1.24 release notes](https://github.com/golang/…dmitshur commented on testing/synctest: experimental package for testing concurrent code3w
@neild This change (a package available only when an experiment is set) should be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), otherwise users might not know it ex…dmitshur reopened an issue crypto/tls: automatic CurvePreferences ordering3w
This looks like a change that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Reopening as a release blocker to track that.dmitshur commented on crypto/tls: SecP256r1MLKEM768 and X25519MLKEM7683w
It looks like [CL 630775](https://go.dev/cl/630775) implemented most of this proposal if not all, though it didn't close it. What's left for Go 1.24? Is it just SecP256r1MLKEM768, which according to …dmitshur reopened an issue cmd/go: cache link output binaries in the build cache3w
This cmd/go change might be noteworthy enough¹ to be covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), so reopening with a release blocker to track that.
¹ In additi…dmitshur reopened an issue crypto/x509: generate serial number for nil template SerialNumber3w
@rolandshoemaker There's no API change here, but this still seems like a change that should be covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), is that right? Mentioning…dmitshur commented on cmd/compile: relax wasm/wasm32 function import signature type constraints3w
@cherrymui Do you think that wasm change (in CL 626615) is something to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)?dmitshur commented on crypto/rand: crash process on error reading randomness3w
@FiloSottile Does this change need to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)? Thanks.dmitshur commented on spec: document promotion of methods from embedded aliases of unnamed types3w
@griesemer Do you think there's anything to be said in [Go 1.24 release notes](https://github.com/golang/go/issues/68545) about this? Or is it fine not to mention it there since this a clarification …dmitshur reopened an issue cmd/vet: warn on 3-clause loops where an iterator variable contains a lock type when GoVersion>=1.223w
This vet change seems like something that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), and it's not mentioned there yet. Reopening as a release blocker…dmitshur reopened an issue cmd/compile: add go:wasmexport directive3w
This looks like a change that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545); that doesn't seem to be done yet. Reopening as a release blocker to track th…dmitshur commented on crypto/ecdsa: generate RFC 6979 signatures if rand is nil3w
@FiloSottile Does this change need to covered in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)?dmitshur reopened an issue cmd/vet: consider reporting invalid/ignored Go versions in build tags3w
A new check added to vet seems like something that needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), and it's not mentioned there yet. Reopening as a releas…dmitshur reopened an issue cmd/vet: report printf calls with non-const format and no args3w
This vet change is new to Go 1.24 and still needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545), right? Reopening with a release blocker label to track that.dmitshur reopened an issue cmd/cgo: add #cgo noescape/nocallback annotations3w
This change (enabling these directives in Go 1.24) is documented in cmd/cgo [package docs](https://pkg.go.dev/cmd/cgo@master#hdr-Optimizing_calls_of_C_code), but it seems a note in [Go 1.24 release n…dmitshur commented on testing: normalize line endings in example output comparisons3w
@ianlancetaylor Do you think this needs to be mentioned in [Go 1.24 release notes](https://github.com/golang/go/issues/68545)? Or should this be considered a minor bug fix on Windows (despite going t…dmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time5mo
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch7modmitshur created package in dmitri.shuralyov.com/scratch/quine7mo
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine7mo
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine7mo
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.