Activity
Today
dmitshur commented on cmd/internal/testdir: testenv.go:166: skipping test: 'go build' not compatible with setting $GO_GCFLAGS45m
Is this the same as issue #18222?dmitshur commented on cmd/go: cache confuses package with different build tags when using CGO with pkg-config7h
CC @matloob, @samthanawalla.dmitshur commented on golang.org/x/vuln: expose vulnerability feed as rss7h
CC @golang/vulndb.dmitshur commented on crypto/x509: accepts invalid AKI extension in CRL7h
CC @golang/security.dmitshur commented on crypto/x509: incorrect handling of the CRL Number field7h
CC @golang/security.dmitshur commented on crypto/x509: unexpected handling of escape characters7h
In the issue report you mention "I use Go to parse this CRL file, Go interprets". Can you please provide a snippet of code for that? In particular, that code will help determine if the problem is in …Yesterday
dmitshur commented on golang.org/x/benchmarks/sweet: add typescript-go to go-build benchmark1d
(1 comment)
Should this entry be annotated somehow and skipped when the toolchain being tested is Go 1.23.x?
That particular commit of typescript-go has a go.mod file with a ['go 1.24.0' directive]…dmitshur commented on internal/godebugs: [release-branch.go1.23] fix changed version for winsymlink and winreadlinkvolume to 1.231d
Stopping these legacy trybots, they're not the ones I meant to start.dmitshur commented on testing: b.StopTimer breaks b.Loop [1.24 backport]1d
@JunyangShao Since you authored the original CL, would you like to create the cherry-pick CL for it too? The process is documented at https://go.dev/wiki/MinorReleases#making-cherry-pick-cls. Thanks.dmitshur commented on crypto/x509: accepts DN with all empty values1d
CC @golang/security.dmitshur commented on cmd/internal/obj/arm64: move register encoding into opldrr/opstrr1d
(1 comment)
In CL 471518, the default case of `oprrr` included an early `return 0` after the Diag call.
Here (and in `opstrr` below), it doesn't.
I'm not sure how much it matters, but asking anywa…dmitshur commented on cmd/compile: don't evaluate side effects of range over array1d
(1 comment)
Adding visibility to this in case it was missed. (It's fine if there's a reason not to do the doc/next file in this CL.)Last Week
dmitshur commented on golang.org/x/net/http2: fix flakiness from t.Log when GOOS=js3d
Note that one of TestServerMaxHandlerGoroutines or TestConfigPingTimeoutServer has been failing in every js/wasm build starting with this CL. See the [x/net (gotip)](https://ci.chromium.org/p/golang/…dmitshur closed a change : Fix issue with preemption on Windows ARM324d
This change has been applied as part of CL 657815, so closing. Thanks.dmitshur starred github.com/rudransh61/Physix-go5d
dmitshur commented on net/http/httputil: ReverseProxy calls WriteHeader after hijacking connection5d
@neild Both this issue (#72954) and issue #72140 say:
> This is a regression in 1.24 caused by CL 637939 for #35892.
And they both request a backport to 1.24, but as far I can tell, CL 637939 is on…dmitshur reviewed +2 on doc: go 1.26 remove support for windows/arm5d
Thanks.dmitshur commented on testing: structured output for test attributes6d
To clarify, is it intentional that the test2json line would exclude remaining TestEvent fields like "Time", "Package" (in contrast to https://github.com/golang/go/issues/71287#issuecomment-2737759645…dmitshur commented on doc: go 1.26 remove support for windows/arm6d
(1 comment)
Since the windows/arm port was marked broken in Go 1.23, I don't think we should say Go 1.25 will be the last release to support it. We can say it's the last release that contains it or …dmitshur closed an issue golang.org/x/build/env: host-freebsd-amd64-12_3 (VM Image: freebsd-amd64-123-stable-20211230)6d
FreeBSD 12.3 is EOL'ed as noted in https://github.com/golang/go/issues/61095#issuecomment-2334940821. We ended up adding a newer FreeBSD 14.1 as part of that issue, so there's nothing more to do for …dmitshur commented on golang.org/x/build/env: host-openbsd-386-* (VM Image: openbsd-386-*)6d
It was possible to successfully build the image, and its swarming bot client successfully connects with `cipd_platform:openbsd-386`:
https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Aopen…dmitshur commented on golang.org/x/build/main.star: set openbsd-386 as not low-capacity1w
Thanks.dmitshur opened a change golang.org/x/build/main.star: set openbsd-386 as not low-capacity1w
It's being added to the GCP pool rather than the shared pool.
For golang/go#61122.dmitshur commented on golang.org/x/tools/gopls/internal/test/integration: skip x_tools-gotip-openbsd-amd64 (7.6)1w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/tools/gopls/internal/test/integration: skip x_tools-gotip-openbsd-amd64 (7.6)1w
Thanks.
Done in PS 2.dmitshur commented on golang.org/x/build/main.star: finish upgrading openbsd-amd64 to OpenBSD 7.61w
Thanks.dmitshur commented on golang.org/x/build/cmd/buildlet{,stage0}: use go version in go.mod via go.dev/doc/toolchain1w
Thanks.dmitshur commented on golang.org/x/build/cmd/buildlet{,stage0}: use go version in go.mod via go.dev/doc/toolchain1w
(1 comment)
Yes, that's right.
`GOTOOLCHAIN=auto` (which is short for `GOTOOLCHAIN=local+auto`) is already the default, so in most cases we don't need to force it. And if someone decies to set it t…dmitshur commented on golang.org/x/tools/gopls/internal/test/integration: skip x_tools-gotip-openbsd-amd64_7.61w
(2 comments)
This change is ready for review.
Context for this at https://go.dev/issues/72145#issuecomment-2730478453.
OpenBSD 6.4 and 6.8 builders don't exist by now, and #42789 is resolved, so I…dmitshur commented on golang.org/x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 after OpenBSD 7.2 → 7.6 upgrade1w
The flakes in #54461 seem to happen on OpenBSD 7.2 builders only. [CL 654676](https://go.dev/cl/654676) replaces the previous OpenBSD 7.2 builders with the new 7.6 ones, so those those will go away.
…dmitshur commented on golang.org/x/build/internal/relui: merge run+await Cloud Build tasks into 1 retryable task1w
Thanks.dmitshur commented on golang.org/x/build/internal/task: use relui service account instead of secret for git authn1w
Thanks.dmitshur reviewed +2 on doc/next: add release note for work package pattern1w
Thanks.Earlier
dmitshur opened a change golang.org/x/build/internal/task: use relui service account instead of secret for git authn1w
Remove reliance on the secret in Secret Manager in one more place. This
is easier to do now that the GenerateAutoSubmitChange implementation is
done and handles all of the intended edge cases; it was…dmitshur closed a change golang.org/x/scratch/gopherbot: reorder words1w
Test of CloudBuild.GenerateAutoSubmitChange is complete. Closing.dmitshur closed a change golang.org/x/scratch/gopherbot: reorder words1w
Test of CloudBuild.GenerateAutoSubmitChange is complete. Closing.dmitshur fixed an issue golang.org/x/build: bot netbsd-arm64-bsiegert reported as broken1w
The builder is currently operational. Thanks for resolving this @bsiegert. Closing.dmitshur fixed an issue golang.org/x/build: bot solaris-amd64 reported as broken1w
The builder is currently operational. Thanks for resolving this. Closing.dmitshur commented on golang.org/x/build: bot solaris-amd64 reported as broken1w
The builder is currently operational. Thanks for resolving this. Closing.dmitshur commented on golang.org/x/build: bot openbsd-ppc64-n2vi reported as broken1w
The builder is currently operational. Thanks for resolving this @n2vi. Closing.dmitshur fixed an issue golang.org/x/build: bot openbsd-ppc64-n2vi reported as broken1w
dmitshur closed an issue golang.org/x/build: bot aix-ppc64-power8 reported as broken1w
This bot doesn't exist now. It existed briefly (see https://github.com/golang/go/issues/67299#issuecomment-2276610972) but has since been deleted because its cipd_platform was incorrectly computed.
…dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--03 reported as broken1w
Fixed alongside #72851.dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--05 reported as broken1w
CC @golang/release.
Fixed alongside #72851.dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--04 reported as broken1w
Fixed alongside #72851.dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--02 reported as broken1w
Fixed alongside #72851.dmitshur fixed an issue golang.org/x/build: bot linux-ppc64le-power8--01 reported as broken1w
Thanks!dmitshur deleted branch in rsc.io/rf1w
drop-go116dmitshur pushed to
main in rsc.io/rf1w
dmitshur merged a change rsc.io/rf/git-generate: modernize slightly1w
dmitshur commented on rsc.io/rf/git-generate: modernize slightly1w
Thanks.dmitshur commented on golang.org/x/build/main.star: finish upgrading openbsd-amd64 to OpenBSD 7.61w
Outdated Votes:
* Code-Review+1, Code-Review+2 (forced copy restriction\*: "**changeis:review-enforced_gerrit** AND NOT changekind:TRIVIAL_REBASE_WITH_MESSAGE_UPDATE AND NOT (**uploaderin:trusted-use…dmitshur opened a change golang.org/x/build/main.star: don't hide openbsd-amd64_7.6 from presubmit1w
Otherwise it's not possible to test that a fix (or skip) for the known
issue works, as I ran into in CL 658015:
Failed to compute tryjob requirement. Reason:
builder "golang/try/x_tools-gotip-ope…dmitshur opened a change golang.org/x/tools/gopls/internal/test/integration: skip x_tools-gotip-openbsd-amd64_7.61w
The new openbsd/amd64 7.6 builder is generally working well everywhere
but this one place. Add a skip for now to buy time to investigate this
issue.
For golang/go#72145.dmitshur opened a change golang.org/x/build/cmd/buildlet{,stage0}: use go version in go.mod via go.dev/doc/toolchain1w
Both go1.22.8 and go1.19 are old and need to be updated to go1.23+.
As of Go 1.21, instead of doing:
go install golang.org/dl/go1.n.m@latest
go1.n.m download
to get a specific Go toolchain versi…dmitshur commented on golang.org/x/build/cmd/gomote: linux-loong64 gomote creation fails with "HTTP Error 403: Forbidden"1w
Whoops, that file wasn't present in the GCS bucket. (Thanks @cagedmantis for spotting the issue!) I've sent [CL 657995](https://go.dev/cl/657995) that adds it as a target and uploaded it now.
Gomote…dmitshur opened a change golang.org/x/build/cmd/buildlet: add linux-loong64 targets1w
Fixes golang/go#72869.dmitshur commented on go.dev/wiki/DashboardBuilders: document required connectivity to Google Cloud Storage1w
Thanks.dmitshur commented on golang.org/x/build/devapp/owners: add hajimehoshi as x/mobile owner1w
That is okay. You do have approver access which gives you permission to leave Code-Review+2 and Auto-Submit+1 votes - see https://go.dev/wiki/GerritAccess#approving-cls-approvers.
Googlers will take…dmitshur opened a change go.dev/wiki/DashboardBuilders: document required connectivity to Google Cloud Storage1w
Gomote creation cannot work without, so include it in the list.
For golang/go#72869.dmitshur reviewed +2 on golang.org/x/build/cmd/racebuild: add linux/loong64 support1w
(1 comment)
Filed #72869 for the gomote creation issue with some details.dmitshur opened an issue golang.org/x/build/cmd/gomote: linux-loong64 gomote creation fails with "HTTP Error 403: Forbidden"1w
Create a gotip-linux-loong64 gomote results in an error. Filing this as a tracking issue.
A swarming task is successfully created, but the task fails. https://chromium-swarm.appspot.com/task?id=6fad…dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--01 reported as broken1w
CC @golang/ppc64.dmitshur commented on golang.org/x/build/devapp/owners: remove outdated x/mobile owner1w
Thanks.dmitshur commented on golang.org/x/build/devapp/owners: add hajimehoshi as x/mobile owner1w
Hi @hajimehoshi@gmail.com,
I created this CL to find out if you'd be interested in being added as the x/mobile owner, if you're still looking to help maintain it. No problem if your priorities have …dmitshur opened a change golang.org/x/build/devapp/owners: add hajimehoshi as x/mobile owner1w
dmitshur opened a change golang.org/x/build/devapp/owners: remove outdated x/mobile owner1w
Thank you Hana for owning and helping maintain x/mobile.
This CL updates the entry to reflect the current status.dmitshur commented on golang.org/x/build: add LUCI openbsd-riscv64 builder1w
@4a6f656c The CL above implements the change you requested, please feel free to review it when you get a chance. Leaving this to you, but please ping this issue if there's something we can do to help…dmitshur commented on golang.org/x/oscar/internal/goreviews: reject CLs with wait-author or wait-issue tag1w
(1 comment)
Optionally, for whenever it's conveniently to apply:
```suggestion
// the change has the wait-author, wait-issue, or wait-release tag.
```dmitshur reviewed +2 on golang.org/x/oscar/internal/goreviews: reject CLs with wait-author or wait-issue tag1w
Thanks.dmitshur reviewed +2 on doc/next: add release note for new toolchain line behavior1w
Thanks.
On the other hand, this link to the issue is helpful for anyone seeking out details of the underlying discussion.
The general guidance for Go release notes is that they should link to Go do…dmitshur commented on cmd/go: don't write own toolchain line when updating go line1w
(1 comment)
This change seems noteworthy enough to be mentioned, is that right? Is the plan to do that in a future separate CL instead of this one? (I realize [updating go.dev/ref/mod](https://cs.op…dmitshur opened a change golang.org/x/build/internal/relui: merge run+await Cloud Build tasks into 1 retryable task1w
Having a dedicated task that starts a Cloud Build invocation without
awaiting it to successfully complete means that if the Cloud Build run
fails for any reason, there's no way to retry it. (It's onl…dmitshur closed a change testing: mention the "_test" package idiom1w
Issue #25223 has been resolved by CL 420415 by now, so closing. Thanks.dmitshur commented on golang.org/x/build: automate consequences of go.mod go directive maintenance2w
We can add tasks that run after the go directive maintenance happens as part of the major Go release relui workflow, here: https://cs.opensource.google/go/x/build/+/master:internal/relui/workflows.go…dmitshur commented on github.com/KhronosGroup/WebGL: Add drawingBufferStorage test from @ccameron-chromium .2w
This `contextVersion` parameter is unused, which prevents runTest(1) and runTest(2) from testing both WebGL 1 and 2 contexts. I filed #3719 for this and another issue related to RGBA16F that I spot…dmitshur opened an issue github.com/KhronosGroup/WebGL: drawingBufferStorage Conformance Tests test webgl1 instead of webgl2, skip RGBA16F in webgl1 without EXT_color_buffer_float extension2w
Consider the following two pages:
- WebGL drawingBufferStorage Conformance Tests - https://registry.khronos.org/webgl/sdk/tests/conformance/canvas/drawingbuffer-storage-test.html
- WebGL2 drawingBuf…dmitshur commented on golang.org/x/tools/refactor/eg: Using `./...` only matches one file even though there are many more2w
This issue might be the same as #10142.dmitshur closed an issue iter: add `Push` function2w
dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-072w
I didn't spot problems in the client code, and based on what @aarzilli observed, it seems we can't discount the possibility of GitHub returning an incomplete issue list without also reporting an erro…dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-072w
Timing seems to align with https://www.githubstatus.com/incidents/lb0d8kp99f2v:
> Issues is experiencing degraded performance.
> Searches for issues and pull-requests may be slower than normal and…dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-072w
The problem doesn't reproduce when running watchflakes locally now:
```
[…]
watchflakes: 2025/03/07 11:24:53 readComments 60085
watchflakes: 2025/03/07 11:24:53 readComments 70602
watchflakes: 202…dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.62w
From looking at https://ci.chromium.org/ui/p/golang/builders?q=openbsd-amd64_7.6, the openbsd/amd64 builder with OpenBSD 7.6 is still running into what looks like #66474, possibly less frequently aft…dmitshur opened an issue golang.org/x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 after OpenBSD 7.2 → 7.6 upgrade2w
As visible at https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64_7.6 (comparing it with https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64), there ar…dmitshur commented on cmd/go: provide a convenient way to iterate all packages in go.work workspace2w
Given the change in #71294 is now implemented, we can't release Go 1.25 without having it also be documented and mentioned in release notes. Since that issue is already closed but this one's still op…dmitshur commented on golang.org/x/build/cmd/relui: add support for making release announcement posts on Bluesky2w
@fflewddur To clarify, that time when you saw it already posted, it must've been posted manually by someone else. The work of automating this hasn't been done yet, but this issue tracks progress on d…dmitshur commented on cmd/go: removed godebug settings cause errors2w
I’m not familiar the specifics of why the `tlskyber` godebug was added in Go 1.23 and removed in 1.24, but I’ll note that https://go.dev/doc/godebug includes:
> GODEBUG settings added for compat…dmitshur commented on cmd/go: test failures due to dependency downloads running into "close <path>: file already closed" errors2w
Also seeing at least one instance of this in #65482, and I most recently ran into it in the first trybot run of [CL 655037](https://logs.chromium.org/logs/golang/buildbucket/cr-buildbucket/8721234441…dmitshur closed an issue cmd/go: TestScript/mod_tidy_diff failures2w
dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.63w
Trying it again without any changes resulted in no errors this time:
<details>
```
[…]
+ pkg_add -iv -I bash curl git python%3 sudo--gettext
[…]
git-2.46.1 (installing)
Shell /usr/local/bin/git…dmitshur starred github.com/takara-ai/go-attention3w
dmitshur closed an issue image: add `(*Uniform).SubImage`3w
dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.63w
@4a6f656c Thanks for the hint, it was right on. The output from my run of `VERSION=7.6 ARCH=amd64 ./make.bash` indeed included a line "pkg_add: Installation of python-3.11.10p1 failed, partial instal…dmitshur fixed an issue net/textproto: canonicalMIMEHeaderKey returns a "malformed MIME header line:" for header containing /3w
dmitshur commented on net/textproto: canonicalMIMEHeaderKey returns a "malformed MIME header line:" for header containing /3w
Closed by merging [CL 601555](https://go.dev/cl/601555) (commit 3b9d10cce787a6ab358a489b604edccb5414baf2).dmitshur commented on cmd/compile: out of memory [1.23 backport]3w
> is it because I've said 1.23.6 in the body ?
Yes; we should fix #27489.dmitshur closed an issue : add date to release notes3w
dmitshur closed an issue : Release Notes should be dated3w