Activity
Yesterday
dmitshur commented on golang.org/x/sys/windows: reject overlong inputs in NewNTString11h
CC @golang/windows.dmitshur commented on cmd/compile: internal compiler error invalid heap allocated var without Heapaddr11h
CC @golang/compiler.dmitshur commented on cmd/compile: reduce allocations by reusing SSA scratch state11h
CC @golang/compiler.dmitshur commented on golang.org/x/arch/x86/x86avxgen: TestOutput failure11h
CC @cherrymui, @golang/windows.dmitshur commented on golang.org/x/pkgsite: improve openapi.yaml12h
CC @golang/pkgsite.dmitshur commented on golang.org/x/image/bmp: add 1, 2 and 4 bits-per-pixel palette encoding support12h
CC @nigeltao, @robpike.Last Week
dmitshur commented on net/http/internal/http2: remove "Host" header from Request.Header3d
@kidnamedcudilovedrake-dot You've been posting on many issues recently. The issue tracker is used for discussing the issue, code changes are better handled as part of CLs (which is where a [CLA](http…dmitshur commented on golang.org/x/crypto/ssh: RSA parameter moduli maximum should be increased3d
CC @drakkan, @golang/security.dmitshur commented on golang.org/x/build/cmd/relnote: improve experience for documenting new standard library packages4d
Thanks, feel free to send a CL. See https://go.dev/doc/contribute.dmitshur opened an issue cmd/compile: cmd/compile/internal/gc fails to build (as part of running tests) under GOEXPERIMENT=newinliner4d
As of [CL 792120](https://go.dev/cl/792120), the gotip-linux-amd64-newinliner builder which tests with `GOEXPERIMENT=newinliner` fails to build cmd/compile/internal/gc:
```
FAIL cmd/compile [build f…dmitshur opened an issue github.com/actions/setup-go: Support release candidate alias ("nextstable"?) as a moving target4d
**Description:**
Currently setup-go supports "stable" and "oldstable" aliases. They are moving targets, so they make it convenient for repositories to target those versions, without needing to edit a…dmitshur commented on golang.org/x/exp/cmd/apidiff: non-deterministic output for "no longer implements"4d
CC @jba, @adonovan.dmitshur commented on github.com/go-openapi/testify/v2: didPanic relies on "panic called with nil argument" Error string equality, changes behavior in Go 1.274d
Thanks very much for resolving this!dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan4d
Thanks for confirming @noahbjohnson. That suggests govulncheck owners may consider temporarily working around by using an older x/tools while #80055 is investigated and resolved.dmitshur commented on golang.org/x/arch/loong64/loong64asm: TestObjdumpLoong64TestDecodeGoSyntaxdata failures4d
CC @golang/loong64.dmitshur commented on cmd/go: support quotes in `GOENV` file4d
CC @golang/command-line.dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan4d
If someone who's able to reproduce this wants to try building govulncheck from source, modifying it with `go get golang.org/x/tools@v0.44.0` (plus v0.45.0 is worth trying too), please see whether tha…dmitshur commented on golang.org/x/tools/go/ssa: RuntimeTypes panics on a parameterized type boxed in a generic method's closure4d
Thanks for reporting and bisecting this.
CC @golang/tools-team, @mrkfrmn, @griesemer.dmitshur commented on cmd/compile: inconsistent errors for init expr mismatches for vars and consts4d
CC @golang/compiler.dmitshur commented on golang.org/x/vuln/cmd/govulncheck: govulncheck v1.4.0 runs into a Panic during scan4d
Thanks for reporting.
CC @golang/vulndb.dmitshur opened an issue github.com/go-openapi/testify/v2: didPanic relies on "panic called with nil argument" Error string equality, changes behavior in Go 1.274d
**Describe the bug**
The `didPanic` function in `internal/assertions/panic.go` seems to try to detect instances of [`*runtime.PanicNilError`](https://pkg.go.dev/runtime#PanicNilError) error by checki…dmitshur commented on runtime: possible bug in moveSliceNoCap [1.26 backport]5d
@abtuteja Go minor releases are scheduled monthly, near the beginning of each month. So early July. See https://go.dev/wiki/MinorReleases.dmitshur commented on runtime: version parsing fails5d
Ping @bradfitz.dmitshur commented on golang.org/x/tools/go/analysis/passes: analyzer for removing canonical import comments5d
There's precedent for something along these lines in the "plusbuild" analyzer.
Do you suggest this analyzer should remove import comments only when the import math matches the actual import path of …dmitshur commented on golang.org/x/tools/go/analysis/passes: analyzer for removing canonical import comments5d
CC @adonovan, @matloob, @madelinekalil.dmitshur closed an issue build: build failure on go1.26-linux-amd64-misccompile5d
The LUCI infrastructure ran into a "i/o timeout" while invoking its own APIs. Nothing for Go to do here.dmitshur commented on golang.org/x/pkgsite: transient 500 errors on frontend during DB replica maintenance5d
CC @golang/pkgsite.dmitshur opened an issue cmd/compile: 2.29% regression in Dgeev/Circulant10-16 sec/op on linux/arm64 at 0252b4b5d
Discovered a regression in sec/op of 2.29% for benchmark Dgeev/Circulant10-16.
https://perf.golang.org/dashboard/?benchmark=Dgeev/Circulant10-16&platform=linux/arm64&repository=go&branch=master
http…dmitshur opened an issue cmd/compile: 5.10% regression in RepeatNew-88 sec/op on linux/amd64 at c59ae5c5d
Discovered a regression in sec/op of 5.10% for benchmark RepeatNew-88. Not quite clear which commit.
https://perf.golang.org/dashboard/?benchmark=RepeatNew-88&platform=linux/amd64&repository=go&bran…dmitshur commented on os/signal: TestCtrlBreak failures5d
From a triage meeting, @prattmic points out this test has a time.Sleep(1 * time.Second) so this might be a flake due to the subprocess not starting in that constant time.dmitshur commented on cmd/cgo/internal/test:external-g0: Test9400 failures5d
CC @golang/compiler.dmitshur commented on cmd/go: spurious leading blank line before `ok` when a passing test writes unterminated output5d
Thanks for the report. Would you like to send a CL? https://go.dev/doc/contributedmitshur commented on cmd/cgo/internal/test:external-g0: unrecognized failures5d
CC @golang/compiler.dmitshur commented on cmd/cgo/internal/test:auto-pie: Test9400 failures5d
CC @golang/compiler.dmitshur commented on runtime: concurrent map read and map write with sync.RWMutex on ppc64le [1.26 backport]5d
Thanks for making this backport request @Jorropo. It's approved now. Since you're the author of the fix CL, if you don't mind, please create backport CLs for this and #79878 following https://go.dev/…dmitshur fixed an issue all: switch to Go 1.27 as default inside Google5d
In a release meeting, we reviewed this blocker for the public Go 1.27 RC 1 and consider it complete. Closing.dmitshur commented on all: switch to Go 1.27 as default inside Google5d
In a release meeting, we reviewed this blocker for the public Go 1.27 RC 1 and consider it complete. Closing.dmitshur commented on os/signal: TestCtrlBreak failures5d
CC @golang/runtime, @golang/windows.dmitshur commented on golang.org/x/build/internal/task: TestFindGoogleGroupsThread/[security]_golang.org/x/crypto_fix_pre-announcement failures5d
This test reaches out over the internet to a service (Google Groups), runs a search query and checks that the algorithm still works as expected. Every so often it seems the response doesn't include t…dmitshur reopened an issue cmd/fix: reflecttypefor replaced TypeOf(f) with TypeFor[func(...)](), losing relationship with symbol f5d
This is a cmd/fix issue in Go1.27 milestone, but so far it was closed by a CL in the x/tools repo. Reopening to make sure this change makes its way into cmd/fix in time for Go 1.27.0. This still need…dmitshur commented on golang.org/x/build: update gopls version requirements as part of the Go toolchain release workflow6d
I think the sections "Why not bump on each minor release?" at [go.dev/design/69095-x-repo-continuous-go#rationale](https://go.dev/design/69095-x-repo-continuous-go#rationale) is moderately relevant. …dmitshur commented on golang.org/x/build: automate maintenance of pinned Go toolchain/runtime versions in Dockerfile and app.yaml files6d
In addition to the 4 x/ repos already mentioned in the original issue, here are some more that also have Dockerfile and/or .yaml files that would benefit from automatic maintenance:
x/vulndb: https:…dmitshur commented on crypto/tls: only set LocalCertificate when a certificate is presented6d
@sin99xx Thanks for sending this change. As noted in https://github.com/golang/go/pull/79968#issuecomment-4684498141, it was successfully imported in Gerrit, and by now there are some review comments…dmitshur commented on golang.org/x/tools/go/packages: TestAdHocOverlays/GO111MODULE=auto failures6d
The failure above happened because package-level timeouts were reached. This was a darwin-arm64 race builder, which normally takes around 10 minutes to run on x/tools (https://ci.chromium.org/ui/p/go…dmitshur commented on crypto/mldsa: Verify accepts uninitialized PublicKey with empty signature6d
Thanks for trying out the package ahead of the release and reporting this finding. CC @golang/security.
Tentatively marking as a release blocker since this package is new to Go 1.27.dmitshur commented on crypto/tls: provide a way to access local certificate used to set up a connection [freeze exception]6d
Issue #79967 reported a problem with the new code. @rolandshoemaker Is it preferable to fix forward and proceed with it for 1.27, instead of reverting and trying again for 1.28? Given it seems like a…dmitshur commented on crypto/tls: LocalCertificate is populated on resumed TLS <=1.2 server connections6d
CC @rolandshoemaker, @golang/security.dmitshur commented on crypto/tls: TLS 1.3 post-handshake alerts not surfaced to the client6d
CC @golang/security.dmitshur commented on cmd/gofmt: comment alignment chunking behaviour different on MacOS vs Linux6d
Thanks for reporting.
It's expected that exact gofmt formatting nuances will change over time, across major Go releases, so a check like `go fmt ./...` needs to be arranged to run with a single cons…dmitshur commented on time: TestAfterQueuing/impl=func failures6d
The test contains a comment:
```Go
// This test flakes out on some systems,
// so we'll try it a few times before declaring it a failure.
const attempts = 5
```
So it seems this failure is expected…dmitshur commented on os: TestRootConsistencyStat/Lstat failures on XFS due to size of directories not being the same6d
Thanks for the report. Please note that Go 1.24 is no longer supported per https://go.dev/doc/devel/release#policy. Does this still happen with Go 1.26/1.25 or at tip?
CC @neild.Earlier
dmitshur pushed to
main in dmitri.shuralyov.com/service/change1ydmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch2ydmitshur created package in dmitri.shuralyov.com/scratch/quine2y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine2y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt2ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine2y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file2y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl3ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change4ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes5y
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido5ydmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/html/belt6ydmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.6y
dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.6y
Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).dmitshur commented on dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
I've decided to publish this post on the [blog front page](https://dmitri.shuralyov.com/blog) now, so re-opening.dmitshur reopened an issue dmitri.shuralyov.com/blog: Replacing WordPress with GitHub Issues-like blog comments6y
dmitshur opened an issue dmitri.shuralyov.com/blog: A half-hour to learn Rust, except it's Go instead of Rust6y
dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur pushed to
master in dmitri.shuralyov.com/go/prefixtitle6ydmitshur closed an issue dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
dmitshur commented on dmitri.shuralyov.com/website/gido: matching by import path pattern misses many packages6y
This is a valid issue, but the root cause analysis was incorrect.
> This happens because they're added using the original paths, without checking that those paths correspond to any existing director…dmitshur pushed to
master in dmitri.shuralyov.com/website/gido6ydmitshur commented on dmitri.shuralyov.com/website/gido: dynamically maintain list of packages (directories)6y
Another place that can be made better is the list of release branches in `initExistingDirectories`. It's currently hard-coded, but should be automated:
```Go
func initExistingDirectories() error {
…dmitshur pushed to
master in dmitri.shuralyov.com/app/changes6ydmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/coreanim6y
Package coreanim provides access to Apple's Core Animation API (https://developer.apple.com/documentation/quartzcore).
dmitshur created package in dmitri.shuralyov.com/gpu/mtl/example/movingtriangle/internal/appkit6y
Package appkit provides access to Apple's AppKit API (https://developer.apple.com/documentation/appkit).
dmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/gpu/mtl6ydmitshur pushed to
master in dmitri.shuralyov.com/service/change6ydmitshur pushed to
master in dmitri.shuralyov.com/text/kebabcase6ydmitshur pushed to
master in dmitri.shuralyov.com/route/gerrit6ydmitshur pushed to
master in dmitri.shuralyov.com/state6ydmitshur pushed to
master in dmitri.shuralyov.com/scratch6y