The previous pattern 'internal-release-branch.go1.24.\d+' works for
minor releases as intended, but doesn't work for release candidates.
RCs can have PRIVATE-track security fixes included too (for ex…
(1 comment)
@roland@golang.org This getting pretty long, so maybe worth shortening? Dropping 'and' at least?
"go1.5rc1-go1.4.2-go1.3.2-checkpoint"
I can include some change in this CL if you prefe…
In the second half of the go.dev/s/release cycle, after entering the
release freeze and before releasing the first pre-release (RC 1), a
release branch for the next major Go release is cut.
Security…
Yes, it's generally okay to apply test fixes during the freeze, that's a large part part of what it's for. The text fix needs to be safe, and this looks safe.
In the general case, the moment a tag is published, it's not viable to modify its contents without potentially causing problems. Instead, it's possible for you to publish a newer version that correct…
The only potentially relevant recent builder change I can think of is [crrev.com/c/6641842](https://crrev.com/c/6641842) (CC @mknyszek) which rebalanced test sharding strategy for #65814. Its timing …
This test has started to fail very often on the gotip-linux-arm64-asan-clang15 linux specifically recently. As visible in its [history](https://ci.chromium.org/ui/test/golang/runtime.TestNeedmDeadloc…
Hi Julian,
Thank you for contributing to the Go project, and for your work of being a maintainer of the MIPS ports. We've discussed this request on the team and agreed to grant you this access. I've…
If more time is desired and the trade-offs are appropriate, also consider the path of reverting the change that caused this regression, reopening #52745, and trying again in a future cycle.
(2 comments)
Based on the log in the issue report, and the regexp pattern, is the missing 's' here in the commit message a typo? (Otherwise the regexp won't match.)
```suggestion
"Couldn't get NT_P…
The check fails for reasons unrelated to the change here. The module requires Go 1.20 but the check tries to test with Go 1.16 (which is before [go.dev/doc/toolchain](https://go.dev/doc/toolchain#sel…
The Go 1.25 release notes draft is complete by now, and there doesn't seem to be any remaining known TODOs to resolve. Thanks everyone.
It's okay for this to be open to track any further refinement …
Thanks for the report. So the problem happens with the same Go program in an older Windows LTSC and doesn't happen in a newer Windows LTSC. Is the crypto/tls implementation in Go doing something diff…
(3 comments)
Hmm, this is the first time I'm encountering this suggestion. I have seen many instances of short inline comments not being a complete sentence (e.g., `N int64 // bytes remaining` rathe…
Yes, I gave a heads up via chat and I saw that @adonovan@google.com gave it a thumbs up, so I think that's done (Alan, please let me know if you have questions or concerns). I'll copy from https://go…
Indeed, Auto-Submit does what it says on the tin as soon as all submit requirements are satisfied. :) Fortunately there weren't any hidden test failures so it worked out.
Thanks.
(nit) Not a big deal, but mentioning for future reference: https://www.w3.org/TR/wasm-core-2/#wasm.
Please include something to connect this CL with a tracking issue. This is [always useful…
Thanks.
Both forms are interchangeable and okay. This is described in a bit more detail at [go.dev/wiki/CommitMessage](https://go.dev/wiki/CommitMessage#:~:text=To%20link%20a,or%20vice%20versa.).
Thanks for filing the issue. Someone familiar with this package may have more specific comments, but in general please see https://go.dev/doc/contribute on how to send a code change. I added a mentio…
LUCI trybots by default run a rough equivalent of all.bash on various ports. If all.bash doesn't fail for you when you run it locally, LUCI trybots shouldn't fail either.
If you'd like to have all.b…
Hmm, can you confirm you’ve done this part?
> (Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving …
Consider the output from `go test` without `-json` flag in a situation where a test timeout happens while multiple subtests are still running (as happened in #74279):
```sh
$ go version
go version g…
Looking at recent build completion times for x_tools-gotip-openbsd-amd64
shows it often takes around 20 minutes, while x_tools-gotip-linux-amd64
often takes around 5 minutes. Even in the main Go repo…
Of course. In theory you can use a regular ./make.bash and create the .tar.gz archive of the result, but it might be easier to use ./make.bash with -distpack flag—just like the real release process…
There was another instance, but this time it was with a non-zero offset in the middle of a month:
```
2025/06/18 14:21:34 service/activity/github: mailLoop: walkSegMail(github.fileSeg{file:"/2025-06…
The Go macOS installer currently runs a sequence of commands described as "Fixing permissions":
```bash
GOROOT=/usr/local/go
echo "Fixing permissions"
cd $GOROOT
find . -exec chmod ugo+r \{\} \;
fin…
(Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving it a .darwin-amd64.tar.gz toolchain.)
It sounds like you were testing the change with a go1.24.4 toolchain. The change is set to apply on versions go1.25rc2 and newer only, so seeing the installation proceed as before is working as inten…
(1 comment)
Oh, almost but not quite — it's still needed in `enabled` so that 'builders_to_trigger_after_toolchain_build' isn't set to non-existing dev.simd x/ repo builders.
(3 comments)
Yes, config groups define presubmit. But I expect we'd need to make more changes to make it useful. As is, this arch_repo_dev-simd config group matches only "internal-branch.dev-simd-.+…
It occurs to me now that one of the effects of dropping omitVariant for test directory tests is that the corresponding test ID will now always have some shard. Previously, if fixedbugs/issue68525.go …
Thanks.
directory
I see, it's impossible to distinguish their timing. For example, if you do run both the go/version package tests as well as its racebench variant in JSON mode, you get both:
```
…
Both of our installers are correctly annotated for the intended host
architecture. That is, the hostArchitectures option is set to x86_64
on .darwin-amd64.pkg installers, and to arm64 on .darwin-arm6…
(1 comment)
Whoops, the "Fixing permissions" postinstall file existed even earlier, I'm now finding CL 11970 from 2015, and it might be present in even earlier Go macOS installers. So higher chances…
Thanks for finding this and sending the CL. It does look like a good improvement.
I think it's a good time to try this for Go 1.25 since there are still opportunities to get wider signal from pre-re…
I terminated the bot via swarming UI:
<img width="892" alt="Image" src="https://github.com/user-attachments/assets/21ce9cd4-5236-479d-aedd-fd341aeba18a" />
After it came back, it had a successful …
The Scaleway linux/arm builders are no more, and there haven't been recent reports here. If this comes up on the newer linux/arm builders, watchflakes will file a report. Closing.
> At this point it might help to separate out work on making relui do this automatically into a dedicated x/build/cmd/relui issue, since that can happen independently of the Go release cycle.
Made #…
This is a tracking issue to create a task for updating the compiler's PGO profile, something that we currently typically do for every major Go release, so about once every 6 months (issue #60234).
I…
I think we can close this now - I'm not aware of anything more left to do for this for Go 1.25.
If there's anything still in the tree that exists only because of needing to support macOS 11, then th…
Thanks for the report. The corresponding release note for this is https://tip.golang.org/doc/go1.25#go-command (second paragraph, "The Go distribution will include fewer prebuilt tool binaries. …")…
The `go test` command normally runs a select subset of vet checks, and fails the test if any of them fail.
In the main Go repo, to aid development, that behavior is forcibly modified to have all vet…
This issue tracks a remaining subset of the accepted proposal #61716. Specifically:
> Once math/rand/v2 has shipped, we would tag and delete x/exp/rand. This would keep programs that already use x/e…