Activity
Yesterday
dmitshur commented on golang.org/x/sys/...: simplify code by using modern Go constructs8h
(1 comment)
Noting here that if [for range](https://go.dev/ref/spec#For_range) is being used, this could also be written as:
```
for i := range sa.Addr {
```
Which has the same behavior but is arg…dmitshur commented on crypto/tls: ECH decodeInnerClientHello incorrectly rejects ClientHello with GREASE values in supportedVersions [1.24 backport]12h
Can you please clarify if the request to backport to the 1.24 branch is because the problem only exists in 1.24 but not 1.23? Or does this problem affect 1.23 too? We need this information because th…dmitshur reviewed +2 on api: move go1.25 to next/7025013h
dmitshur reviewed +2 on api: move go1.25 to next/7025013h
(1 comment)
Noting that [normally](https://cs.opensource.google/go/go/+/master:doc/README.md) each proposal gets its own individual fragment file. If you're interested in updating the test to detect…dmitshur reviewed +2 on api: move go1.25 to next/7025013h
dmitshur reviewed +2 on api: move go1.25 to next/7025013h
Thanks. As TestCheckAPIFragments reports, new APIs need a corresponding release note.This Week
dmitshur commented on cmd/link/internal/ld: introduce -funcalign=N option1d
(1 comment)
Oh, based on https://go.dev/issue/72130#issuecomment-2710961286, maybe this just needs to say "For" instead of "Fixes".dmitshur commented on cmd/link/internal/ld: introduce -funcalign=N option1d
(1 comment)
Issue #72130 is a proposal in 'Incoming' state. Should this CL wait for the proposal to be accepted before being submitted? Or should the issue be taken out of the proposal process?dmitshur commented on golang.org/x/vuln: expose vulnerability feed as rss1d
@zpavlinovic This issue is closed as "completed", is that the right status? Or should it be closed as "not planned"?dmitshur reviewed +2 on golang.org/x/build/internal/buildgo: fix use of wrong error1d
Thanks.dmitshur reviewed +2 on cmd/vet: add waitgroup analyzer2d
Thanks.dmitshur reviewed +2 on cmd/vendor: update golang.org/x/tools to v0.31.1-0.20250328151535-a857356d5cc52d
(1 comment)
Thanks. It works out well since we want to update all golang.org/x dependencies regularly anyway (#36905).dmitshur reviewed +2 on cmd/vendor: update golang.org/x/tools to v0.31.1-0.20250328151535-a857356d5cc52d
(1 comment)
Is this revert to v0.30.0 unintentional? If intentional, it needs to also be done for the cmd module to keep them both using the same x/sys version.dmitshur commented on golang.org/x/build/buildgo: fix use wrong error2d
In your other comments you said "Fix applied". In order to apply that change, it does require adding a new "patch set". A patch set is what Gerrit refers to revisions, and a new one is needed to make…dmitshur reviewed +2 on golang.org/x/website/internal/history: document Go 1.24.2 and 1.23.8 releases2d
Thanks.
"net/http" is already listed under Security.Packages for the #72011 security fix.
But "net/http" also has a bug (non-security) fix for issue #72103. Add it to the Bug.Packages list too?
No…dmitshur commented on golang.org/x/build/buildgo: fix use wrong error3d
No problem. Note there's still no patch set 2 available. If you have it as a draft, it there's a button you need to press to publish it.dmitshur fixed an issue golang.org/x/text: test results fail to be uploaded to ResultDB3d
Fixed via [crrev.com/c/6414930](https://crrev.com/c/6414930), which adds escaping for this character on the side of result_adapter.
Filed #73116 in case there's something the go command can do bette…dmitshur commented on golang.org/x/text: test results fail to be uploaded to ResultDB3d
Fixed via [crrev.com/c/6414930](https://crrev.com/c/6414930), which adds escaping for this character on the side of result_adapter.
Filed #73116 in case there's something the go command can do bette…dmitshur opened an issue cmd/go: consider shrinking set of characters allowed/passed through in subtest names3d
This issue is meant to capture a small finding from #73086, and it's related to the cluster of proposals like #67562 (and its earlier version #45549), #27896, possibly more like #44970, #20209, #2021…dmitshur commented on golang.org/x/build/buildgo: fix use wrong error3d
(1 comment)
Did you mean to upload a new patch set, or do you mean something different by "Acknowledged"?dmitshur reviewed +2 on golang.org/x/build/buildgo: fix use wrong error3d
Thanks.
```suggestion
internal/buildgo: fix use of wrong error
```
```suggestion
err has been checked, it is nil now, here should call sp.Done with
remoteErr.
```
(See go.dev/wiki/CommitMessage.)dmitshur commented on cmd/compile/internal/ssa: replace uses of interface{} with Sym/Aux3d
Thanks.Last Week
dmitshur reviewed +2 on cmd/vet: add waitgroup analyzer6d
Thanks.
This CL enables the implementation for this feature, documents it, and closes the issue in the Go1.25 milestone (via 'Fixes #18022'). That's 3 out of 4 things we need to be able to release G…dmitshur reviewed +2 on cmd/vendor: update golang.org/x/tools to v0.31.1-0.20250328151535-a857356d5cc56d
Yes, both of those approaches would work.
Since the golang.org/x/tools/go/analysis/passes/waitgroup package is small (2 .go files), to me it seems fine to get it vendored in the next CL (i.e., the s…dmitshur commented on golang.org/x/build/env/freebsd-amd64: let swarming user call /sbin/shutdown -r now6d
Thanks.dmitshur commented on golang.org/x/build/env/freebsd-amd64: upgrade to FreeBSD 14.26d
Thanks.dmitshur commented on golang.org/x/mobile: gobind adds local paths to .so file even with -trimpath6d
CC @hajimehoshi.dmitshur commented on golang.org/x/build/main.star: enable freebsd-amd64_14.2 for x/ repos6d
Ready to take this step now, dropping hold.dmitshur opened a change golang.org/x/build/env/freebsd-amd64: let swarming user call /sbin/shutdown -r now6d
One of Swarming Bot requirements is to have passwordless
sudo reboot enabled.
While here, also install unzip for x/build/cmd/racebuild,
and nano for some interactive debugging convenience.
For gola…dmitshur opened a change golang.org/x/text/message: quote fmt and val in subtest names6d
For golang/go#73086.dmitshur opened an issue golang.org/x/text: test results fail to be uploaded to ResultDB6d
The x/text dashboard has turned red:
https://ci.chromium.org/p/golang/g/x-text-gotip-by-go/console
The text execution itself passes, but LUCI builds (for example, https://ci.chromium.org/b/87191676…dmitshur commented on runtime/cgo: naming a DLL exported function as "CloseHandle" causes all DLL exported functions to deadlock6d
CC @golang/runtime, @golang/windows.dmitshur commented on net: ResolveTCPAddr fails with error when resolving a link-local IPv4 address containing a zone6d
CC @ianlancetaylor, @neild.dmitshur starred github.com/venkat1017/Opengit6d
dmitshur reviewed +2 on internal/syscall/windows: run go generate1w
dmitshur reviewed +2 on internal/syscall/windows: run go generate1w
Thanks.dmitshur commented on debug/buildinfo: fall back code for when there's no .go.buildinfo is wrong1w
CC @matloob, @samthanawalla.dmitshur commented on crypto/x509: accepts CRL with two AKI extension1w
CC @golang/security.dmitshur commented on crypto/x509: unexpected handling of escape characters1w
Thanks. The value of `crl.Issuer.Organization` contains only one backslash character:
```
Organization:[]string{`VeriSign\`}
```
And the String method prints that one backslash in escaped format. H…dmitshur reviewed +2 on log/slog: Handler doc points to handler guide1w
Thanks.
go.dev is newer and shorter compared to golang.org. While they both work, it seems we should prefer writing down the former in new code and documentation.
```suggestion
// Before implementi…dmitshur reviewed +2 on golang.org/x/example/slog-handler-guide: warn against embedding1w
Thanks.dmitshur commented on golang.org/x/build/main.star: enable freebsd-amd64_14.2 for x/ repos1w
Hold for now. This is meant to be submitted later, after we're done iterating on the image and ready to proceed.dmitshur commented on golang.org/x/build/main.star: add freebsd-amd64_14.21w
Thanks.dmitshur commented on golang.org/x/tools/gopls/internal/settings: enable more staticcheck passes1w
> What is that subset?
As noted at https://staticcheck.dev/docs/configuration/, "Staticcheck tries to provide a good out-of-the-box experience, [...]", that is, this question is already being consid…dmitshur commented on golang.org/x/build/env/freebsd-amd64: upgrade to FreeBSD 14.21w
This change is ready for review.dmitshur opened a change golang.org/x/build/main.star: finish upgrading freebsd-amd64 to FreeBSD 14.21w
For golang/go#72030.dmitshur opened a change golang.org/x/build/main.star: add freebsd-amd64_14.21w
For golang/go#72030.dmitshur opened a change golang.org/x/build/main.star: enable freebsd-amd64_14.2 for x/ repos1w
For golang/go#72030.dmitshur commented on cmd/internal/testdir: testenv.go:166: skipping test: 'go build' not compatible with setting $GO_GCFLAGS1w
Is this the same as issue #18222?dmitshur opened a change golang.org/x/build/env/freebsd-amd64: upgrade to FreeBSD 14.21w
For golang/go#72030.dmitshur commented on cmd/go: cache confuses package with different build tags when using CGO with pkg-config1w
CC @matloob, @samthanawalla.dmitshur commented on golang.org/x/vuln: expose vulnerability feed as rss1w
CC @golang/vulndb.dmitshur commented on crypto/x509: accepts invalid AKI extension in CRL1w
CC @golang/security.dmitshur commented on crypto/x509: incorrect handling of the CRL Number field1w
CC @golang/security.dmitshur commented on crypto/x509: unexpected handling of escape characters1w
In the issue report you mention "I use Go to parse this CRL file, Go interprets". Can you please provide a snippet of code for that? In particular, that code will help determine if the problem is in …dmitshur commented on testing: b.StopTimer breaks b.Loop [1.24 backport]1w
@JunyangShao Since you authored the original CL, would you like to create the cherry-pick CL for it too? The process is documented at https://go.dev/wiki/MinorReleases#making-cherry-pick-cls. Thanks.dmitshur commented on crypto/x509: accepts DN with all empty values1w
CC @golang/security.Earlier
dmitshur starred github.com/rudransh61/Physix-go2w
dmitshur commented on net/http/httputil: ReverseProxy calls WriteHeader after hijacking connection2w
@neild Both this issue (#72954) and issue #72140 say:
> This is a regression in 1.24 caused by CL 637939 for #35892.
And they both request a backport to 1.24, but as far I can tell, CL 637939 is on…dmitshur commented on testing: structured output for test attributes2w
To clarify, is it intentional that the test2json line would exclude remaining TestEvent fields like "Time", "Package" (in contrast to https://github.com/golang/go/issues/71287#issuecomment-2737759645…dmitshur closed an issue golang.org/x/build/env: host-freebsd-amd64-12_3 (VM Image: freebsd-amd64-123-stable-20211230)2w
FreeBSD 12.3 is EOL'ed as noted in https://github.com/golang/go/issues/61095#issuecomment-2334940821. We ended up adding a newer FreeBSD 14.1 as part of that issue, so there's nothing more to do for …dmitshur commented on golang.org/x/build/env: host-openbsd-386-* (VM Image: openbsd-386-*)2w
It was possible to successfully build the image, and its swarming bot client successfully connects with `cipd_platform:openbsd-386`:
https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Aopen…dmitshur commented on golang.org/x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 after OpenBSD 7.2 → 7.6 upgrade2w
The flakes in #54461 seem to happen on OpenBSD 7.2 builders only. [CL 654676](https://go.dev/cl/654676) replaces the previous OpenBSD 7.2 builders with the new 7.6 ones, so those those will go away.
…dmitshur fixed an issue golang.org/x/build: bot netbsd-arm64-bsiegert reported as broken2w
The builder is currently operational. Thanks for resolving this @bsiegert. Closing.dmitshur fixed an issue golang.org/x/build: bot solaris-amd64 reported as broken2w
dmitshur commented on golang.org/x/build: bot solaris-amd64 reported as broken2w
The builder is currently operational. Thanks for resolving this. Closing.dmitshur fixed an issue golang.org/x/build: bot openbsd-ppc64-n2vi reported as broken2w
The builder is currently operational. Thanks for resolving this @n2vi. Closing.dmitshur closed an issue golang.org/x/build: bot aix-ppc64-power8 reported as broken2w
This bot doesn't exist now. It existed briefly (see https://github.com/golang/go/issues/67299#issuecomment-2276610972) but has since been deleted because its cipd_platform was incorrectly computed.
…dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--03 reported as broken2w
Fixed alongside #72851.dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--05 reported as broken2w
CC @golang/release.
Fixed alongside #72851.dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--04 reported as broken2w
Fixed alongside #72851.dmitshur closed an issue golang.org/x/build: bot linux-ppc64le-power8--02 reported as broken2w
Fixed alongside #72851.dmitshur fixed an issue golang.org/x/build: bot linux-ppc64le-power8--01 reported as broken2w
Thanks!dmitshur deleted branch in rsc.io/rf2w
drop-go116dmitshur pushed to
main in rsc.io/rf2w
dmitshur merged a change rsc.io/rf/git-generate: modernize slightly2w
dmitshur commented on rsc.io/rf/git-generate: modernize slightly2w
Thanks.dmitshur opened an issue golang.org/x/build/cmd/gomote: linux-loong64 gomote creation fails with "HTTP Error 403: Forbidden"2w
Whoops, that file wasn't present in the GCS bucket. (Thanks @cagedmantis for spotting the issue!) I've sent [CL 657995](https://go.dev/cl/657995) that adds it as a target and uploaded it now.
Gomote…dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--01 reported as broken3w
CC @golang/ppc64.dmitshur commented on golang.org/x/build: add LUCI openbsd-riscv64 builder3w
@4a6f656c The CL above implements the change you requested, please feel free to review it when you get a chance. Leaving this to you, but please ping this issue if there's something we can do to help…dmitshur commented on golang.org/x/build: automate consequences of go.mod go directive maintenance3w
We can add tasks that run after the go directive maintenance happens as part of the major Go release relui workflow, here: https://cs.opensource.google/go/x/build/+/master:internal/relui/workflows.go…dmitshur commented on github.com/KhronosGroup/WebGL: Add drawingBufferStorage test from @ccameron-chromium .3w
This `contextVersion` parameter is unused, which prevents runTest(1) and runTest(2) from testing both WebGL 1 and 2 contexts. I filed #3719 for this and another issue related to RGBA16F that I spotte…dmitshur opened an issue github.com/KhronosGroup/WebGL: drawingBufferStorage Conformance Tests test webgl1 instead of webgl2, skip RGBA16F in webgl1 without EXT_color_buffer_float extension3w
Consider the followin two pages:
- WebGL drawingBufferStorage Conformance Tests - https://registry.khronos.org/webgl/sdk/tests/conformance/canvas/drawingbuffer-storage-test.html
- WebGL2 drawingBuff…dmitshur commented on golang.org/x/tools/refactor/eg: Using `./...` only matches one file even though there are many more3w
This issue might be the same as #10142.dmitshur closed an issue iter: add `Push` function3w
dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-073w
I didn't spot problems in the client code, and based on what @aarzilli observed, it seems we can't discount the possibility of GitHub returning an incomplete issue list without also reporting an erro…dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-073w
Timing seems to align with https://www.githubstatus.com/incidents/lb0d8kp99f2v:
> Issues is experiencing degraded performance.
> Searches for issues and pull-requests may be slower than normal and…dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-073w
The problem doesn't reproduce when running watchflakes locally now:
```
[…]
watchflakes: 2025/03/07 11:24:53 readComments 60085
watchflakes: 2025/03/07 11:24:53 readComments 70602
watchflakes: 202…dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.64w
From looking at https://ci.chromium.org/ui/p/golang/builders?q=openbsd-amd64_7.6, the openbsd/amd64 builder with OpenBSD 7.6 is still running into what looks like #66474, possibly less frequently aft…dmitshur opened an issue golang.org/x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 after OpenBSD 7.2 → 7.6 upgrade4w
As visible at https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64_7.6 (comparing it with https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64), there ar…dmitshur commented on cmd/go: provide a convenient way to iterate all packages in go.work workspace4w
Given the change in #71294 is now implemented, we can't release Go 1.25 without having it also be documented and mentioned in release notes. Since that issue is already closed but this one's still op…dmitshur commented on golang.org/x/build/cmd/relui: add support for making release announcement posts on Bluesky4w
@fflewddur To clarify, that time when you saw it already posted, it must've been posted manually by someone else. The work of automating this hasn't been done yet, but this issue tracks progress on d…dmitshur commented on cmd/go: removed godebug settings cause errors4w
I’m not familiar the specifics of why the `tlskyber` godebug was added in Go 1.23 and removed in 1.24, but I’ll note that https://go.dev/doc/godebug includes:
> GODEBUG settings added for compat…dmitshur commented on cmd/go: test failures due to dependency downloads running into "close <path>: file already closed" errors4w
Also seeing at least one instance of this in #65482, and I most recently ran into it in the first trybot run of [CL 655037](https://logs.chromium.org/logs/golang/buildbucket/cr-buildbucket/8721234441…dmitshur closed an issue cmd/go: TestScript/mod_tidy_diff failures4w
dmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time9mo
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch11modmitshur created package in dmitri.shuralyov.com/scratch/quine11mo