Activity
This Week
dmitshur starred github.com/makeworld-the-better-one/dither/v23d
Last Week
dmitshur commented on golang.org/x/tour/tutorial: fix 404 link in web-service-gin1w
The change in this CL is intended to fix the interactive tutorial you mentioned, so marking this thread as resolved.dmitshur reviewed +2 on golang.org/x/tour/tutorial: fix 404 link in web-service-gin1w
Thanks.
Done in PS 4.dmitshur commented on cmd/go: behaviour of "go doc" in module mode is not documented1w
CC @golang/command-line.dmitshur commented on golang.org/x/build: add LUCI linux-mips64le builder1w
That hostname should work well, thanks. Here is the corresponding certificate: [linux-mips64le-cip-united-1761320497.cert.txt](https://github.com/user-attachments/files/23127740/linux-mips64le-cip-un…dmitshur commented on golang.org/x/build: add LUCI linux-mipsle builder1w
@Rongronggg9 Thank you for offering that builder to test the linux/mipsle port. Its hardware should work as long as it provides useful signal. Does all.bash pass on it as is (or prior to CL 675235) o…dmitshur commented on runtime: add ppc and s390 to linux 32 bits syscall build constraints for gccgo1w
Not for this CL, but in general: if some of these build constraints are intended only for the gccgo compiler, since that compiler gets [its own build constraint](https://cs.opensource.google/go/go/+/…dmitshur commented on golang.org/x/text/...: use reflect.TypeFor instead of reflect.TypeOf1w
(1 comment)
Thanks.dmitshur commented on golang.org/x/review/git-codereview: fix some comments1w
(1 comment)
Thanks.dmitshur commented on golang.org/x/review/git-codereview: fix some comments1w
(1 comment)
This is marked as done, but not seeing any change. What was done?
I also think the original wording was generally better. There's no well defined concept of a "valid" email that everyon…dmitshur commented on golang.org/x/build/internal/task: add suggestion to opt in to Go toolchain telemetry in RCs1w
Adding a Hold for some time.dmitshur commented on golang.org/x/build/internal/task: update announce-rc test case to use go1.25rc11w
Thanks.dmitshur commented on golang.org/x/build/internal/task: add suggestion to opt in to Go toolchain telemetry in RCs1w
Thanks.dmitshur commented on golang.org/x/build/internal/task: support security field in the announce-rc template1w
Thanks.
Yes, so far RC releases are not covered at all by the security policy. Now that our RC release timing is generally aligned with that of minor releases, and since we include security fixes in…dmitshur reviewed +2 on net/url: speed up escape and unescape1w
Thanks. Readded Code-Review vote from PS 4.dmitshur commented on golang.org/x/build/internal/releasetargets: update list for Go 1.261w
Thanks.dmitshur opened an issue cmd/dist: test -json emits some non-JSON lines for packages without tests1w
When the -json flag is used with `go tool dist test` (added in #37486), it's expected to only write JSON lines.
There seems to be a path where some non-JSON is written to stdout too, which is a bug:…dmitshur commented on net/url: speed up escape and unescape1w
(1 comment)
What's the reason to unconditionally print gen_encoding_table.go content to stdout? It's probably better not to do this since the caller can do `cat gen_encoding_table.go && go generate`…dmitshur commented on golang.org/x/text/...: use reflect.TypeFor instead of reflect.TypeOf1w
(1 comment)
It looks like in this case replacing TypeOf with TypeFor as is isn't a clear improvement.
Consider that this change makes the `ct colltab.ContractTrieSet` parameter completely unused. F…dmitshur commented on path/filepath: [release-branch.go1.24] return cleaned path from Rel1w
(1 comment)
Hold+1 because this is currently in CherryPickCandidate state.dmitshur commented on path/filepath: [release-branch.go1.25] return cleaned path from Rel1w
(1 comment)
Hold+1 because this is currently in CherryPickCandidate state.dmitshur closed an issue cmd/compile: any(func(){})==any(func(){}) does not panic but should [1.24 backport]1w
dmitshur closed a change runtime: [release-branch.go1.24] use one more address bit for tagged pointers1w
This CL is not needed anymore. We're not proceeding with the 1.24 backport, and issue #75774 is closed.dmitshur commented on runtime: [release-branch.go1.24] use one more address bit for tagged pointers1w
Thanks. I'll closing this CL.
As mentioned in the other thread, not proceeding with this CL.dmitshur fixed an issue golang.org/x/build/internal/relui: TestRelease/major failures1w
Fixed in [CL 711920](https://go.dev/cl/711920).dmitshur closed an issue riscv64: can't build on FreeBSD with cgo [1.24 backport]1w
Closing for now because the freebsd/riscv64 port is [marked broken](https://cs.opensource.google/go/go/+/master:src/cmd/dist/build.go;l=1830;drc=6f4c63ba63fdec6e4a42e2e19ac71937973dedef) at tip and […dmitshur commented on path/filepath: Rel returns non-Clean'ed path. [1.24 backport]1w
Asked for a more detailed backport rationale in https://github.com/golang/go/issues/75763#issuecomment-3433007301.dmitshur commented on path/filepath: Rel returns non-Clean'ed path. [1.25 backport]1w
Asked for a more detailed backport rationale in https://github.com/golang/go/issues/75763#issuecomment-3433007301.dmitshur commented on path/filepath: Rel returns non-Clean'ed path1w
@kolyshkin What's the reason to suggest backporting this issue? We'd need a bit more information to review the backport request.
Our backporting criteria is documented at https://go.dev/wiki/Porting…dmitshur commented on builders: linux-mipsle/linux-mips64le builders are missing1w
@MingcongBai Yes, please do.
In general, you could reuse an existing open issue for a given GOOS/GOARCH pair and move on to step 2 at https://go.dev/wiki/DashboardBuilders#how-to-set-up-a-builder (g…dmitshur commented on path/filepath: reword documentation for Rel1w
The one trybot failure in TestIssue69912 is unrelated (issue #75963), everything else passed, bypassing.dmitshur opened a change golang.org/x/build/internal/releasetargets: update list for Go 1.261w
The release freeze for Go 1.26 is a bit over a month away.
Do a preliminary update of the release target list.
So far it is the same as for Go 1.25, with the following diff:
- The freebsd/riscv64 po…dmitshur reviewed +2 on all: gofmt -w1w
Thanks.dmitshur reviewed +2 on golang.org/x/build/...: fix some comments1w
dmitshur commented on golang.org/x/build/internal/relui: include a package in fake golang.org/x/build module1w
Thanks.
It's a bit of a question of what _should_ happen when taking an action on a package pattern, when a pattern that may match 0 or more packages (depending on the context where it runs) ends up…dmitshur reviewed +2 on path/filepath: reword documentation for Rel1w
Thanks. Readded votes.dmitshur commented on runtime: use timer_settime64 on 32-bit Linux1w
(1 comment)
(nit) This file should be run through `gofmt -w`.dmitshur commented on path/filepath: reword documentation for Rel1w
(1 comment)
(minor) This sentence is missing a period.
```suggestion
// [Join](basePath, Rel(basePath, targPath)) is equivalent to targPath itself.
```dmitshur reviewed +2 on golang.org/x/build/...: fix some comments1w
Thanks.
Trybot failure is pre-existing and will be fixed CL 711920.dmitshur commented on builders: linux-mipsle/linux-mips64le builders are missing1w
Also see tracking issues #67304 and #67306.Earlier
dmitshur commented on runtime: [release-branch.go1.24] use one more address bit for tagged pointers2w
(1 comment)
This change is ready for review.
The 1.25 cherry pick was clean, but there's a conflict on 1.24 release branch.
It looks like it's because CL 667715, where defaultAddrBits was added, i…dmitshur opened a change runtime: [release-branch.go1.24] use one more address bit for tagged pointers2w
We use one extra bit to placate systems which simulate amd64 binaries on
an arm64 host. Allocated arm64 addresses could be as high as 1<<48-1,
which would be invalid if we assumed 48-bit sign-e…dmitshur opened a change runtime: [release-branch.go1.25] use one more address bit for tagged pointers2w
We use one extra bit to placate systems which simulate amd64 binaries on
an arm64 host. Allocated arm64 addresses could be as high as 1<<48-1,
which would be invalid if we assumed 48-bit sign-e…dmitshur commented on go/types: change and enforce lifecycle of Named.fromRHS and Named.underlying fields2w
Filed issue #75963 for it.dmitshur opened an issue cmd/compile/internal/importer: data race in TestIssue69912 as of CL 6959772w
This is being reported by race builders across various ports at tip:
```
=== RUN TestIssue69912
==================
WARNING: DATA RACE
Write at 0x00c0001aa098 by goroutine 1118:
cmd/compile/inter…dmitshur commented on go/types: change and enforce lifecycle of Named.fromRHS and Named.underlying fields2w
Note that as of submission of this CL, there's a data race reported fairly consistently on race builders in cmd/compile/internal/importer.TestIssue69912. For example, https://ci.chromium.org/b/870082…dmitshur opened a change golang.org/x/exp/cmd/gorelease: remove redundant fmt.Sprintf call2w
setNotValid already accepts a format string and uses
fmt.Sprintf internally so its caller doesn't need to.
Caught by the improved vet check as of CL 707135:
$ go vet ./cmd/gorelease
cmd/gorelease/r…dmitshur opened a change golang.org/x/website/cmd/screentest: escape % in format string2w
Caught by the improved vet check as of CL 707135:
$ go vet ./cmd/screentest
cmd/screentest/screentest.go:169:33: p format % o reads arg #1, but call has 0 argsdmitshur commented on cmd/compile/internal/ssa: add codegen for Zicond extension on riscv642w
@joel@sing.id.au Note that a Run-TryBot+1 vote by itself doesn't do anything by now, it only exists to be able to request legacy TRY= SlowBots. Removing it. For normal trybots, Commit-Queue+1 is the …dmitshur commented on golang.org/x/pkgsite: still no update for > 2h and counting after a new tag is available on proxy and requested2w
CC @golang/pkgsite.dmitshur commented on cmd/go: `go tool` doesn't list nm, objdump and pprof2w
CC @golang/command-line.dmitshur commented on cmd/pprof: incorrect CPU profile graph2w
CC @golang/runtime, @cherrymui.dmitshur commented on cmd/compile/internal/inline/inlheur: dumpscores test failure2w
Thanks for the report. Does the failure happen reproducibly or intermittently for you?
It seems not to happen on the linux/amd64 builder ([here](https://ci.chromium.org/ui/p/golang/builders/ci/gotip…dmitshur commented on cmd/go: work edit -json doesn't include the toolchain2w
CC @golang/command-line.dmitshur commented on compress/flate: size optimization of final deflate block (btype 0 -> btype 1)2w
CC @dsnet, @mdempsky.dmitshur commented on net/http/httputil: ReverseProxy stuck forever when handling request with expect: 100-continue header and upstream connection creation fails2w
CC @neild, @thatnealpatel.dmitshur commented on cmd/go: env should report GOPACKAGESDRIVER2w
CC @golang/command-line.dmitshur commented on os: on windows RemoveAll removing directories containing read-only files errors with `unlinkat ... Access is denied`2w
CC @golang/windows, @griesemer, @neild.dmitshur commented on path/filepath: improve `Rel`'s documentation2w
CC @robpike, @rsc.dmitshur commented on github.com/actions/setup-go: Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang2w
Thanks for doing that!
From my perspective, changing download URLs from `https://storage.googleapis.com/golang/{file}` to `https://go.dev/dl/{file}` is the right thing to do, so I'll leave further…dmitshur commented on github.com/actions/setup-go: Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang2w
Consider using https://go.dev/dl/ itself and following the redirects. It's likely that https://dl.google.com/go/ will remain current for a long time, but if it ends up changing in the future, this wi…dmitshur commented on github.com/actions/setup-go: storage.googleapis.com/golang no longer allows anonymous access causing 403 on Golang download fallback2w
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur commented on github.com/microsoft/azure-pipelines-tasks/[BUG]: gotooling task cannot download go distribution2w
The official Go downloads page (https://go.dev/dl/) contains the most up-to-date URLs for individual Go release files. They follow the pattern `https://go.dev/dl/{file name}`, so for example the go1.…dmitshur commented on golang.org/x/build: add Debian Trixie builders2w
The linux/arm64 trixie builder is up (with a known issue) and seems to be running into some problem with its C toolchain. Some of the packages fail with "running gcc failed [...] cannot find ‘ld’…dmitshur commented on go/version: does not support the `X:` suffix from `go env GOVERSION`2w
Package [go/version](https://pkg.go.dev/go/version) is documented to operate on Go versions in Go toolchain name syntax, which is defined at https://go.dev/doc/toolchain#name as:
> The standard Go t…dmitshur commented on golang.org/x/build/main.star: add linux-arm64_debian13 builder2w
Thanks.dmitshur commented on github.com/coder/internal/flake: macOS Go setup failure - illegal byte sequence during tar extraction2w
Note that the official Go distributions can be downloaded (following redirects) using URLs at https://go.dev/dl/, which follow the pattern `https://go.dev/dl/{file name}`. Attempting to download thos…dmitshur commented on github.com/google/oss-fuzz: base images not building2w
Yes, "getgo" was an experimental tool that was deprecated and removed in 2024, see Go proposal golang/go#60951. It should work to download (following redirects) using the URLs at https://go.dev/dl/, …dmitshur opened a change golang.org/x/build/main.star: add linux-arm64_debian13 builder2w
For golang/go#74985.dmitshur opened an issue golang.org/x/build: update Debian sid builder past trixie2w
Our current Debian sid builders were last updated at a time when they were close to Debian Trixie's release, and their reported OS dimension value is "Debian-13". This prevents us from adding stable …dmitshur commented on golang.org/x/build: add Debian Trixie builders2w
I started [crrev.com/i/8675857](https://crrev.com/i/8675857) to add internal configuration for the new Debian Trixie builder images, and ran into an issue that our current Debian sid builder reports …dmitshur commented on golang.org/x/net/internal/quic/cmd/interop: support ChaCha20 interop test (server)2w
CC @neild.dmitshur commented on govulncheck-action: pin action dependencies by sha2w
CC @golang/vulndb.dmitshur commented on golang.org/x/vuln: govulncheck -format=sarif generates invalid sarif with duplicate tags2w
CC @golang/vulndb.dmitshur closed an issue golang.org/x/mobile: fatal error: bulkBarrierPreWrite: unaligned arguments2w
If this issue is already fixed by [CL 692935](https://go.dev/cl/692935), there's nothing more to do here. Let's use #46893 as the canonical issue for this problem.
Go 1.26 is expected to be released…dmitshur opened an issue golang.org/x/build/cmd/relui: use http.CrossOriginProtection2w
[`http.CrossOriginProtection`](https://pkg.go.dev/net/http#CrossOriginProtection) was added in Go 1.25 and relui should take advantage of it to reject non-safe cross-origin browser requests. This is …dmitshur commented on golang.org/x/tools: make API changes visible during code review2w
The scope of the [proposal process](https://github.com/golang/proposal#scope) includes "API changes in the main repo and all* golang.org/x repos" (almost all, there are some x/ repos that are not in …dmitshur pushed to
main in dmitri.shuralyov.com/service/change5modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now.
Done in PS 3.
I'm following the Go style for commit messages, which chooses…dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
Shortened 'golang.org' to 'go.dev' here, and on line 24.dmitshur pushed to
master in dmitri.shuralyov.com/website/gido4ydmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y