Activity
This Week
dmitshur commented on golang.org/x/build/cmd/relui: add a Mailjet-based SendMail implementation2d
Thanks.dmitshur commented on golang.org/x/build/cmd/relui: add a Mailjet-based SendMail implementation2d
(2 comments)
Done.
Ack. I realize this Go constant is unused, but it's still helpful to use this space to document the secret name and its format: specifically, that its a JSON encoded `MailjetCred…dmitshur opened an issue cmd/dist: let go in PATH select a newer toolchain to satisfy minimum bootstrap version requirement2d
We regularly bump the minimum Go bootstrap version, once every year (see proposal #54265). One of the common ways that a bootstrap toolchain is provided to make.bash and related scripts is by having …Last Week
dmitshur commented on os/exec: [release-branch.go1.25] fix incorrect expansion of ".." in LookPath on plan94d
(1 comment)
Done in PS 4.dmitshur commented on os/exec: [release-branch.go1.24] fix incorrect expansion of ".." in LookPath on plan95d
(1 comment)
```suggestion
[release-branch.go1.24] os/exec: fix incorrect expansion of ".." in LookPath on plan9
```dmitshur commented on os/exec: [release-branch.go1.25] fix incorrect expansion of ".." in LookPath on plan95d
(1 comment)
This will cause the Matching-Subject-Prefix submit requirement to become satisfied:
```suggestion
[release-branch.go1.25] os/exec: fix incorrect expansion of ".." in LookPath on plan9
`…dmitshur commented on os/exec: fix incorrect expansion of ".." in LookPath on plan95d
Backport issues #75008 and #75007 are now in CherryPickApproved state, so the next step there is to create [backport CLs](https://go.dev/wiki/MinorReleases#making-cherry-pick-cls).dmitshur commented on golang.org/x/build/internal/task: skip updating x/exp/event dep in x/pkgsite-metrics5d
Thanks.dmitshur opened a change golang.org/x/build/internal/task: skip updating x/exp/event dep in x/pkgsite-metrics5d
For golang/go#73264.
For golang/go#74596.dmitshur commented on golang.org/x/net/quic: TestStreamTransfer failures5d
CC @qmuntal, @golang/windows.dmitshur commented on golang.org/x/pkgsite-metrics/...: update golang.org/x dependencies6d
Thanks.dmitshur commented on golang.org/x/pkgsite-metrics/...: migrate x/exp/{maps,slices} uses to maps and slices in std lib6d
Thanks.dmitshur reviewed +2 on golang.org/x/build/internal/task: use milestone metadata to derive security patch changelists6d
Thanks.
There will likely more related CLs, and it'd be quite helpful to file something on [go.dev/issue/new](https://go.dev/issue/new) and include "For golang/go#nnn." here. That'll make it easier …dmitshur reviewed +2 on runtime: remove remaining windows/arm files and comments6d
Thanks.dmitshur fixed an issue github.com/immersive-web/webxr-samples: broken link to WebXR/WebGPU bindings on WebXR Report page1w
The originally reported issue here appears to be fixed, likely by PR https://github.com/immersive-web/WebXR-WebGPU-Binding/pull/15 and some followup: the 'WebXR/WebGPU bindings' link at https://immer…dmitshur commented on github.com/immersive-web/WebXR-WebGPU-Binding: Rename repo to lowercase `webxr-webgpu-binding`1w
Issue https://github.com/immersive-web/webxr-samples/issues/208 is somewhat related to this.dmitshur closed an issue os: File.Seek doesn't set the correct offset with Windows overlapped handles [1.24 backport]1w
dmitshur commented on golang.org/x/pkgsite-metrics: module fails to tidy after upgrading golang.org/x/exp/event to its latest version1w
From looking into this a bit, the x/exp/event module was updated to a newer version of Open Telemetry in [CL 551275](https://go.dev/cl/551275), a change that involves adapting to some upstream API ch…dmitshur commented on golang.org/x/crypto/x509roots: regeneration fails with "404 Not Found"1w
Happened again this morning. As of posting this, it reproduces with:
```sh
$ date
Mon Aug 18 12:23:43 EDT 2025
$ go generate ./x509roots
2025/08/18 12:23:45 got non-200 OK status code: 404 Not Found…Earlier
dmitshur commented on internal/goversion: increment Version at start of cycle1w
Done for Go 1.26 in [CL 689877](https://go.dev/cl/689877).dmitshur commented on golang.org/x/build/cmd/golangbuild: use existing rdb/bb/cas binaries in environment when they're provided1w
Done in [crrev.com/c/6829788](https://crrev.com/c/6829788) and [crrev.com/c/6854660](https://crrev.com/c/6854660).dmitshur fixed an issue cmd/go/internal/test: test concurrency limited by sequential printing1w
Thanks. Closing as fixed by [CL 668035](https://go.dev/cl/668035).
(It didn't close automatically because the commit message didn't have "Fixes" in front of "#61233"; each issue being closed needs i…dmitshur commented on .github: issue template doesn't describe toolchain selection1w
The `GODEBUG=toolchaintrace=1` feature which is already added in [Go 1.24](https://go.dev/doc/go1.24#go-command) sounds pretty close to the behavior suggested above.
Perhaps `GOTOOLCHAIN=local go ve…dmitshur commented on cmd/go/internal/test: test concurrency limited by sequential printing1w
@jsm Did you intend for [CL 668035](https://go.dev/cl/668035) to mark this issue as fixed, or should it stay open?dmitshur closed an issue cmd/go: setting GOEXPERIMENT=jsonv2 causes "go env -json" to crash1w
It sounds this happens when the [toolchain selection](https://go.dev/doc/toolchain#select) is involved, as it doesn't happen with a local go1.25.0 toolchain. Can you try it again with `GODEBUG=toolch…dmitshur fixed an issue golang.org/x/website/internal/gitfs: unrecognized failures2w
As visible on the [x/website (gotip) by go commit](https://ci.chromium.org/p/golang/g/x-website-gotip-by-go/console) view, this was resolved by [CL 695196](https://go.dev/cl/695196) (a revert CL). CC…dmitshur commented on all: update standard-library dependencies at the start and end of each development cycle2w
With [CL 694536](https://go.dev/cl/694536) and [CL 696015](https://go.dev/cl/696015) (mentioned above), everything's updated for the early-in-cycle round.
Removing that label to revisit this when the…dmitshur commented on build: adopt Go 1.24 as bootstrap toolchain for Go 1.262w
The builders are updated to provide a go1.24.6 bootstrap, and cmd/dist is updated to require it. A corresponding [release note](https://tip.golang.org/doc/next#bootstrap) is in place.
This is still …dmitshur opened an issue doc: write release notes for Go 1.262w
This is the tracking issue for writing the Go 1.26 Release Notes. The version at tip will soon be viewable at https://tip.golang.org/doc/go1.26.
When the Go 1.26 Release Notes are complete, includin…dmitshur opened an issue golang.org/x/build/cmd/golangbuild: use existing rdb/bb/cas binaries in enviornment when they're provided2w
dmitshur commented on riscv64: can't build on FreeBSD with cgo [1.24 backport]2w
Copying @mengzhuo's [comment](https://github.com/golang/go/issues/74734#issuecomment-3138318850) from the (now closed) 1.23 backport issue here for visibility:
> hi, the builder has back online rece…dmitshur closed an issue net: `WriteMsgUDPAddrPort` should accept IPv4-mapped IPv6 destination addresses on IPv4 UDP sockets [1.23 backport]2w
With the recent release of Go 1.25.0, the two latest supported major Go releases are 1.25 and 1.24 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.23 backport iss…dmitshur closed an issue riscv64: can't build on FreeBSD with cgo [1.23 backport]2w
With the recent release of Go 1.25.0, the two latest supported major Go releases are 1.25 and 1.24 per the [Go release policy](https://go.dev/doc/devel/release#policy). Closing this 1.23 backport iss…dmitshur commented on golang.org/x/net/quic: TestStreamTransfer failures2w
CC @neild.dmitshur starred github.com/AndreRenaud/gore2w
dmitshur commented on golang.org/x/build: add linux/amd64 builder that supports AVX-5122w
@Jorropo Yes, see the "amd64_avx512" column on the [go-gotip](https://ci.chromium.org/p/golang/g/go-gotip/console) console, for example. It's also visible on build.golang.org if you search for "avx51…dmitshur opened an issue golang.org/x/tools/gopls/internal/test/integration/completion: TestFuzzFunc/default fails after regenerating x/tools/internal/stdlib with 1.25.02w
Regenerating the golang.org/x/tools/internal/stdlib package with Go 1.25.0 (as done in [CL 695417](https://go.dev/cl/695417)) causes one of the test cases, specifically the "a_test.go" file in the `T…dmitshur fixed an issue doc: write release notes for Go 1.252w
[CL 695375](https://go.dev/cl/695375) removed the draft notice and updated the introduction section. Moving this back to Go1.25 milestone and closing.dmitshur commented on build: "SIGBUS: bus error" on darwin builders2w
CC @golang/darwin, @prattmic.dmitshur opened an issue golang.org/x/crypto/x509roots: regeneration fails with "404 Not Found"2w
Attempting to regenerate this package currently fails with:
```sh
$ go generate golang.org/x/crypto/x509roots
2025/08/11 15:34:05 got non-200 OK status code: 404 Not Found body: "\nerror: security/n…dmitshur commented on net/http: the server-side parse form returns inaccurate error2w
CC @neild.dmitshur closed an issue cmd/dist: re-expose pack command in Go 1.252w
It sounds like there are no changes planned in cmd/dist for Go 1.25, so closing. Thanks.dmitshur commented on go 1.25rc3: volume handles with FILE_FLAG_OVERLAPPED fail when calling ReadAt2w
Thanks for the report.
CC @golang/windows.dmitshur commented on encoding/json/v2: UnmarshalDecode EOF regression2w
Okay, glad to hear that. Leaving this in Go 1.26 milestone then, and there's plenty of time to resolve it before the 1.26 release freeze. Please be sure to follow the [release timeline](https://go.de…dmitshur commented on encoding/json/v2: UnmarshalDecode EOF regression2w
Is [CL 689919](https://go.dev/cl/689919) included in 1.25? I'm not seeing it in Go 1.25 RC 3 nor any of the previous release candidates. It looks like it landed after the tree [reopened](https://grou…dmitshur commented on database/sql/driver: allow driver to entirely override Scan2w
@neild FYI in case of a connection with issue #74831 here.dmitshur commented on encoding/json/v2: UnmarshalDecode EOF regression2w
Given it's still an [experimental package](http://go.dev/doc/go1.25#json_v2) and under active development, it's expected that there will be known issues, and it's not viable to block the 1.25 release…dmitshur commented on encoding/json/v2: UnmarshalDecode EOF regression2w
@dsnet In general, if something needs to happen before a given release is made, it should be marked as a release-blocker. Otherwise it may be missed. That said, it is probably too late to include thi…dmitshur fixed an issue golang.org/x/vuln/internal/buildinfo: windows/arm subtest of TestStrippedBinary and TestExtractPackagesAndSymbols fails consistently2w
Closing as fixed by [CL 694215](https://go.dev/cl/694215). (It didn't auto-close because I forgot the golang/go prefix in the Fixes line.)dmitshur commented on golang.org/x/build: bot linux-arm-aws--dev-3e01 reported as broken2w
There were 20 consecutive failures due to #74893, causing the bot to be moved to quarantined state. Now that #74893 is resolved, just needed to restart the swarming bot. Done.dmitshur fixed an issue golang.org/x/build: bot windows-arm64-azure--03 reported as broken2w
dmitshur commented on golang.org/x/build: bot windows-arm64-azure--03 reported as broken2w
There were 20 consecutive failures due to #74893, causing the bot to be moved to quarantined state. Now that #74893 is resolved, just needed to restart the swarming bot. Done.dmitshur fixed an issue os/user:pie_internal: TestImpersonated failures2w
dmitshur commented on js/wasm: wrong `this` argument passed in wasm_exec::_makeFuncWrapper2w
Thanks for reporting. What is the `./bootstrap.bash` script? Does this also happen if you build a wasm binary with `GOOS=js GOARCH=wasm go build`?
CC @golang/js, @golang/wasm.dmitshur commented on os/exec: TestLookPath fails on plan9 after CL 6857552w
CC @dolmen, @neild, @golang/plan9.dmitshur closed an issue golang.org/x/vuln: issue title2w
The issue is empty.dmitshur commented on golang.org/x/build: bot freebsd-riscv64-mengzhuo--megrez-3 reported as broken3w
Thanks.
About deleting bots that are no longer needed: there is a delete button next to "Last Seen" in the UI, though I think currently it requires LUCI admin permissions. Maybe there's something we…dmitshur fixed an issue golang.org/x/build: *-linux-arm builders have no disk space left3w
Closing since this hasn't happened for some time. It was idling at around 40% disk usage, similar to prior its steady state in https://github.com/golang/go/issues/74169#issuecomment-2971994775.dmitshur fixed an issue golang.org/x/build: bot linux-arm-aws--dev-3e01 reported as broken3w
dmitshur closed an issue runtime: TestGdbConst failures [consistent failure]3w
This might be a duplicate of #74910 and already fixed.dmitshur commented on cmd/cgo/internal/testsanitizers: failures with `signal: segmentation fault` or `exit status 66`3w
@yhlee-tw Thanks for reporting. If you think the fix for that issue meets the bar for backporting, please request it using the process documented at https://go.dev/wiki/MinorReleases and include a ra…dmitshur commented on golang.org/x/build: bot linux-riscv64-mengzhuo--megrez-2 reported as broken3w
@mengzhuo There were 20 consecutive failures due to #74893, causing the bot to be moved to qurantined state. Now that #74893 is resolved, this should be a matter of restarting the swarming bot. Thank…dmitshur commented on golang.org/x/build: bot freebsd-riscv64-mengzhuo--megrez-3 reported as broken3w
@mengzhuo There were 20 consecutive failures due to #74893, causing the bot to be moved to qurantined state. Now that #74893 is resolved, this should be a matter of restarting the swarming bot. Thank…dmitshur fixed an issue build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"3w
This issue is resolved. Closing and unpinning.dmitshur commented on golang.org/x/build/cmd/relui: add support for making release announcement posts on Bluesky3w
We saw this functionality in action during today's release:
https://bsky.app/profile/golang.org/post/3lvqxp673aw2l
https://bsky.app/profile/golang.org/post/3lvqxmfabea2sdmitshur commented on build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"3w
This is now fully rolled out, for all Go port builders.
In case you spot problems that seem related to this in builds started after this comment, please let us know here. Keeping it open for some ti…dmitshur commented on build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"3w
The propagation is partially complete (including for darwin/arm64, linux/amd64) and working, for example:
- https://ci.chromium.org/ui/p/golang/builders/ci/gotip-darwin-arm64_15/b8707269894361154625…dmitshur commented on build: LUCI builds failing with "bad request: invocation: module_id: module_variant: unspecified"3w
A suspected change that might be causing this has been [rolled back](https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6824203), currently waiting on propagation.dmitshur closed an issue build: build failure on gotip-linux-arm3w
dmitshur closed an issue build: build failure on gotip-solaris-amd643w
dmitshur closed an issue build: build failure on gotip-netbsd-arm643w
dmitshur closed an issue build: build failure on gotip-windows-arm643w
dmitshur closed an issue build: build failure on gotip-darwin-amd64_143w
dmitshur closed an issue build: build failure on gotip-darwin-amd64-race3w
dmitshur reopened an issue build: build failure on gotip-darwin-amd64-race3w
dmitshur closed an issue build: build failure on gotip-darwin-amd64-race3w
dmitshur closed an issue build: build failure on gotip-darwin-arm64_123w
dmitshur closed an issue build: build failure on gotip-darwin-arm64-race3w
dmitshur commented on fyne.io/fyne/v2/ld: warning: ignoring duplicate libraries: '-lobjc'3w
The upstream Go tracking issue for this is https://github.com/golang/go/issues/67799.dmitshur commented on internal/coverage/cfile: TestIssue59563TruncatedCoverPkgAll failures [consistent failure]3w
Started with [CL 681937](https://go.dev/cl/681937). CC @randall77.dmitshur pushed to
main in dmitri.shuralyov.com/service/change3modmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y
July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)dmitshur pushed to
main in dmitri.shuralyov.com/scratch1ydmitshur created package in dmitri.shuralyov.com/scratch/quine1y
dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y
LGTM. Thanks, and congrats on your first new Go package here!
Done in PS 2.
Patch set 2 seems to resolve this.dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! If it's ready to be submitted from your side, I can do that now.dmitshur pushed to
main in dmitri.shuralyov.com/html/belt1ydmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …dmitshur pushed to
main in dmitri.shuralyov.com/go/generated2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur pushed to
main in dmitri.shuralyov.com/gpu/mtl2ydmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …dmitshur pushed to
master in dmitri.shuralyov.com/service/change3ydmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y
dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y