As the title of this issue says, when it was originally filed, the "Download" button at https://go.dev/doc/install was quite misleading. [CL 480955](https://go.dev/cl/480955) made it point to the htt…
https://pkg.go.dev/runtime/debug#ParseBuildInfo is has no documentation. (https://go.dev/s/style#doc-comments and https://go.dev/doc/comment say that every exported identifier should have a doc comme…
Sounds great, I’m in agreement. This change will be transparent for users of the Go package, so only those who have a pre-existing git checkout for development purposes will need to migrate. FWIW, …
[CL 618635](https://go.dev/cl/618635) changes the order to be:
```
setAnchors is being scheduled
generateTOC is being scheduled
generateTOC is starting
setAnchors is starting
```
<img widt…
[CL 601055](https://go.dev/cl/601055) added made the change to start using `node.firstChild.textContent` as the TOC item text, instead of `$(node).text()`. It looks like it was trying not to include …
Gaby didn't include it in https://github.com/golang/go/issues/69772#issuecomment-2392352550, but issue #67791 is also related here. If there are tests in x/ repos that would fail when switching to th…
Are the OOMs in/tools ongoing? If it was just that burst around September 20-22, I added some more detail in https://github.com/golang/go/issues/66962#issuecomment-2391753139 that's likely relevant.
Recording here that there was another instance of the builders disconnecting and needing to be restarted around September 20-23:
<img width="37" alt="image" src="https://github.com/user-attachment…
@timothy-king You're running into friction issue #25574 – there was already a backport request in https://github.com/golang/go/issues/68658#issuecomment-2313617202. As a workaround, you can create …
Added release-blocker for now so we can track this better. (It's a documentation only issue for a secondary port, so it wouldn't block the release in practice.)
The most recent failures here since this was reopened are all due to a core file being left behind, and the pattern isn't narrow enough to match anything else specific. So closing this in favor of #6…
This can be reproduced locally by running the test in the x/vulndb module located in the module cache, rather than a git repository checkout. For example:
```
$ cd $(mktemp -d)
$ go mod init exa…
Based on issue #69457, the watchflakes change described in https://github.com/golang/go/issues/65977#issuecomment-1969407349 above is done. It sounds like there's nothing more to do here, and we can …
Checking in on the status. @Geo25rey, would you like to keep pushing this forward? If so, there are some unresolved review comments that need to be addressed, otherwise this seems close. I've been us…
Another instance reported at https://ci.chromium.org/b/8735636356859002161/infra, this time on windows/amd64. So this likely applies to all platforms rather than linux/ppc64le specifically.
Fixed in [crrev.com/c/5873674](https://crrev.com/c/5873674).
As a simple demonstration, [CL 615681](https://go.dev/cl/615681) contains a test that intentionally reaches across module boundary and …
One way to test it would be to run it locally; it should no longer run into the "repo mismatch" error.
You'll also know it works when you [deploy watchflakes with it](https://go.googlesource.com/bui…
Watchflakes is currently in a continuous crashloop:
```
$ kubectl logs -p watchflakes-deployment-7dd687d899-8rf75
watchflakes: 2024/09/24 12:12:43 ListBuilders
watchflakes: 2024/09/24 12:12:4…
In [build 8736249311634815793](https://ci.chromium.org/b/8736249311634815793) (a shard of a real linux-amd64 build on [CL 614296](https://go.dev/cl/614296), whose no_network property is true) TestCre…
It's likely related that linux-386 and linux-amd64 builders are configured to run with a no-network check:
https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=527-532;drc=c29a1893e55…
### Go version
go version go1.23.1 darwin/arm64
### Output of `go env -changed` in your module/workspace
<details><br>
```sh
GOPROXY='http://127.0.0.1'
```
</details>
### What did…
Fixed in [crrev.com/c/5869577](https://crrev.com/c/5869577).
Specifically, release branch builders (e.g. x_example-go1.22-linux-amd64) will now skip testing modules that have a go directive that's…
Gerrit now provides an ability to rebase on behalf of the original CL author, which doesn't require Forge Author permission. See [here](https://groups.google.com/g/repo-discuss/c/NeSb-YI5mQM). Can yo…
Closing this again since the original problem with write_go_bootstrap_tar failing with 404 is resolved, the only currently connected legacy plan9 builder (plan9-arm) is working okay with a go1.22.6 b…
> I sent [CL 608155](https://go.dev/cl/608155) to [remove known issue], and [CL 607656](https://go.dev/cl/607656) to mark them as migrated [which stops coordinator from sending them work].
I haven…
I don't think anyone has plans to resume work on this, and there is a working plan9/386 LUCI builder tracked in #63599. Closing this in favor of that issue.
It is possible the builder resource limits are not sufficient for the increased demands. Increasing memory (if it's viable, given it's 32-bit) might help, but that kind of builder maintenance work is…
Thanks for reporting.
It looks like this builder provides its own bootstrap at /var/root/go-ios-arm64-bootstrap, and its version go1.20.6 is too low for tip. Go tip (1.24 to be) has a minimum boot…
Adding some relevant notes here.
[CIPD](https://chromium.googlesource.com/infra/luci/luci-go/+/refs/heads/main/cipd/README.md) as used by LUCI builders already has an existing package providing No…
Agreed – if achieving x/playground's testing needs can be made to work without the Docker dependency, that path would be great. Recently @hyangah is exploring a similar direction for vscode-go's te…
@mengzhuo Thanks for requesting this backport. We already reviewed it, but a note for future: https://go.dev/wiki/MinorReleases says "The [backport] issue should include a link to the original issue …
Based on https://www.freebsd.org/releases/, FreeBSD 13.0 is EOL, and its most recent releases are 13.3, 14.0, and 14.1.
CC @mengzhuo Is it right that https://ci.chromium.org/ui/p/golang/builders/l…
One of the nested modules in x/example can't be tested on the Go 1.22 release branch, not without upgrading to a Go 1.23 toolchain, as reported by its LUCI builders here (added recently in [CL 608495…
A sketch of how this can be implemented:
- add an input property to [`golangbuild`](https://cs.opensource.google/go/x/build/+/master:cmd/golangbuild/README.md), something like `upgrade_go_directiv…
Thanks for filing an issue.
Since this is about deciding a long-term strategy, I think it's important to consider #56986 here. That work was implemented fairly recently in Go 1.21 and its effect m…
They are. Although Go can make them too easy via `go:embed`.
See some initial comments.
I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…
Thanks! Congrats on your first change. :D
See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …
I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …