Activity
Today
dmitshur opened an issue golang.org/x/build/cmd/golangbuild: provide more useful signal when testing broken ports by using -force flag1h
This is a tracking issue to port the behavior implemented in coordinator for #61925 to the LUCI side in [golangbuild](https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/experimental…dmitshur closed an issue security: fix CVE-2023-393242h
dmitshur closed an issue security: fix CVE-2023-39324 [1.20 backport]2h
dmitshur closed an issue security: fix CVE-2023-39324 [1.21 backport]2h
dmitshur opened an issue build: make.bash fails for GOOS=plan9 GOARCH=3864h
As reported by the plan9-386-0intro builder and legacy misc-compile-plan9-386 trybot, the plan9/386 port fails to bootstrap:
```
gotip $ git rev-parse HEAD
e7bf9959fd9ea649e1513cef16f91f81b13604…dmitshur reviewed +2 on golang.org/x/mobile/...: replace ALooper_pollAll with ALooper_pollOnce5h
Thanks.
Note that Run-TryBot+1 triggers legacy trybots only. It's necessary to use Commit-Queue+1 to satisfy the 'TryBots-Pass' submit requirement.Yesterday
dmitshur closed an issue golang.org/x/build/cmd/coordinator: build dashboard for subrepos is confusing23h
Our migration to [LUCI](https://go.dev/wiki/LUCI) should make a meaningful improvement for golang.org/x repo result views.
Using a recent issue #67439 as an example, where CL 546676 introduced a n…dmitshur commented on net/http: TestServerReadAfterWriteHeader100Continue/h1 failures23h
Adding a few investigative notes.
As visible by comparing [here](https://ci.chromium.org/ui/test/golang/net%2Fhttp.TestServerReadAfterWriteHeader100Continue%2Fh1) and [here](https://ci.chromium.or…dmitshur commented on hash: use more internal/byteorder functions to simplify the code23h
Thanks.dmitshur commented on hash: use more internal/byteorder functions to simplify the code1d
(1 comment)
Would it be better to apply the same change here as in sum32a.Sum?
```suggestion
return byteorder.BeAppendUint32(in, v)
```dmitshur commented on golang.org/x/net/ipv4: SetTOS should return errNotImplemented on Windows1d
CC @golang/windows, @ianlancetaylor.dmitshur closed an issue access: may-start-trybots1d
Thanks for your contributions and helping maintain the ppc64 and ppc64le ports. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybots](https://go.…dmitshur closed a change sync/atomic: revert "public And/Or ops and race instrumentation"1d
One additional CL would also need to be reverted to fix the build. The fix forward in CL 586516 was prepared quickly and is submitted now. Closing.dmitshur commented on sync/atomic: public And/Or ops and race instrumentation1d
Thanks. I'll prepare the rollback in CL 586515.dmitshur opened a change sync/atomic: revert "public And/Or ops and race instrumentation"1d
This reverts CL 544455.
Reason for revert: Breaks linux/arm and 9 more ports.
For #61395.dmitshur commented on sync/atomic: public And/Or ops and race instrumentation1d
linux/arm and a number of secondary ports are failing to make.bash as of this CL. Please comment if you think the fix is small and can be done soon, otherwise let's revert.dmitshur closed a change golang.org/x/build/buildlet: don't rely on io.Copy error to be context.DeadlineExceeded1d
Issue #67439 is fixed by CL 586315, so this change is no longer needed. I think the original implementation is marginally better, and it relies on intended net/http behavior that shouldn't regress.dmitshur commented on cmd/dist: Go tip leaving pkg/mod/golang.org/x/telemetry read-only files behind1d
This doesn't reproduce each time for me, but I saw it happen again today after running these commands in my development GOROOT directory today:
```
src $ git-branches
| Branch | …dmitshur commented on : CVEs still showing up in latest version of Go 1.22.21d
Note that Go 1.22.2 is not the current latest version. That version is Go 1.22.3, released 10 days: https://groups.google.com/g/golang-announce/c/wkkO4P9stm0. Go 1.22.3 includes fixes for CVE-2024-24…dmitshur commented on golang.org/x/build: add LUCI freebsd-riscv64 builder1d
From looking at https://ci.chromium.org/ui/p/golang/g/port-freebsd-riscv64/builders, the builder seems to be producing good testing signal. @mengzhuo Would you like to remove its [known issue](https:…dmitshur closed an issue access: Application to join golang/mips maintainer team1d
dmitshur commented on golang.org/x/build/cmd/golangbuild: reduce network bandwidth requirements for builders accessing through LUCI1d
Thanks for reporting. CC @golang/release, @mknyszek.
Are you able to narrow down more specifics of where the additional bandwidth utilization comes from? Is it uplink or downlink?
The testing s…dmitshur commented on time: time.Parse accepts out of range value for offsets, and can't always be roundtripped1d
CC @rsc, @ianlancetaylor.dmitshur commented on unsafe: document a difference in behavior between unsafe.Sizeof(x) and reflect.TypeOf(x).Size()1d
CC @griesemer.dmitshur commented on golang.org/x/review/git-codereview: set git config commit.gpgsign to false1d
Thanks for reporting this.
The git configuration surface is quite large, and this appears to be a case where one of the configuration values conflicts with the expectations of git-codereview, caus…dmitshur commented on cmd/dist: Go tip leaving pkg/mod/golang.org/x/telemetry read-only files behind1d
Thanks for reporting. Some notes from when I briefly looked in case they're helpful.
cmd/dist sets GOPATH env var (which in turn sets the module cache location) to $GOROOT/pkg/obj/gopath during the …dmitshur commented on crypto/tls: move defaults into defaults.go and defaults_boring.go1d
Let's use Commit-Queue+1 to trigger trybots in this CL. See https://go.dev/wiki/LUCI#trybots.dmitshur reviewed +2 on golang.org/x/tools/...: fix function names in comment1d
Thanks.
@imcusg@gmail.com Please see https://go.dev/wiki/LUCI#trybots for current information on how to trigger trybots. In most cases you should use Commit-Queue+1 vote, not the legacy Run-TryBot+1…dmitshur commented on gerrit: unable to select specific builder to execute tryjobs via "Choose tryjobs" dialog's Add button1d
Thanks for reporting. CC @golang/release.
First, can you try and see if you're able to start slowbots by including a `Cq-Include-Trybots: luci.golang.try:gotip-linux-loong64` git footer in the com…dmitshur commented on access: merge my Gerrit accounts1d
Sorry for the trouble, I didn't realize it wouldn't have effect on your newer CLs.
Since it's only two of them and both haven't begun code review yet (and one of them needs a merge conflict resolu…dmitshur commented on golang.org/x/build: add LUCI illumos-amd64 builder1d
Thanks for getting to this point.
The bot is visible at https://chromium-swarm.appspot.com/bot?id=illumos-amd64-jclulow. As you noted, it's identifying itself as having a cipd_platform value of "s…This Week
dmitshur commented on golang.org/x/build: LUCI support for plan91d
Thank you for working on this and your patience. I'd like to try to help move this forward. Apologies for not commenting here sooner.
We don't quite have an ideal existing builder that we can poin…dmitshur commented on golang.org/x/build/env: host-linux-amd64-androidemu (Container Image: android-amd64-emu:bff27c0c9263)1d
This particular issue tracks the Android emulator-based builder. I've had a chance to prototype it earlier, and will update it as further progress is made.
@changkun, at this time this issue doesn…dmitshur commented on net/http: return correct error when reading from a canceled request body1d
(1 comment)
Consider adding a `Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest` footer (detailed instructions [here](https://go.dev/wiki/SlowBots#using-slowbots)) so trybot signal wo…dmitshur commented on net/http: return correct error when reading from a canceled request body1d
(1 comment)
I retitled the issue to be about net/http.dmitshur reviewed +1 on net/http: return correct error when reading from a canceled request body1d
Looks good to me, but I'll leave it to Jonathan to look, so +1. Left a few minor comments that I spotted. Thanks.
(nit) https://go.dev/wiki/Spelling suggests using a different spelling for this part…dmitshur commented on golang.org/x/build/buildlet: don't rely on io.Copy error to be context.DeadlineExceeded1d
Hold because CL 586315 will restore the net/http behavior, and this shouldn't be needed.dmitshur commented on golang.org/x/sys/windows: uintptr(unsafe.Pointer) calls outside of syscalls1d
CC @golang/runtime, @alexbrainman.dmitshur commented on cmd/go: go test -cover fails when loading plugin built without coverage1d
CC @thanm.
dmitshur commented on golang.org/x/net/ipv4: calling SetTOS and SetTTL doesn't work as expected on MacOS1d
CC @golang/darwin, @ianlancetaylor.dmitshur commented on golang.org/x/playground: corrupted output on long slice printing1d
CC @golang/tools-team.dmitshur commented on golang.org/x/build/buildlet: don't rely on io.Copy error to be context.DeadlineExceeded1d
(1 comment)
This is dead code now; removed.dmitshur closed an issue golang.org/x/build/buildlet: add context support1d
We can call this done. At least no use in tracking this via an open issue anymore.dmitshur commented on net/http: wrong error returned when request canceled via context after CL 546676 ("net/http: simplify HTTP/1 request cancelation"); detected via x/build/buildlet.TestExecTimeoutError failing1d
I sent [CL 586077](https://go.dev/cl/586077) which fixes the immediate problem on the x/build side. It'd be good for Damien to check if this is working as expected.dmitshur opened a change golang.org/x/build/buildlet: don't rely on io.Copy error to be context.DeadlineExceeded1d
Previously it worked for Exec to detect that the context deadline
exceeded by inspecting the io.Copy error. As of CL 546676 that no
longer works, so add an explicit check if the context exceeded if
i…dmitshur commented on net/http: simplify HTTP/1 request cancelation1d
FYI an old test in x/build has started to fail with this change. I filed #67439 and will see if I can spot a problem on the x/build side.dmitshur opened an issue net/http: wrong error returned when request canceled via context after CL 546676 ("net/http: simplify HTTP/1 request cancelation"); detected via x/build/buildlet.TestExecTimeoutError failing1d
As visible on the [x/build by Go commit](https://ci.chromium.org/p/golang/g/x-build-gotip-by-go/console) view, `TestExecTimeoutError` has started to fail consistently at Go tip starting with [CL 5466…dmitshur reviewed +2 on crypto/x509: [release-branch.go1.22] remove TestPlatformVerifierLegacy tests2d
Thanks.dmitshur reviewed +2 on crypto/x509: [release-branch.go1.21] remove TestPlatformVerifierLegacy tests2d
Thanks.dmitshur commented on golang.org/x/build: add LUCI illumos-amd64 builder2d
Thank you for starting to work on this builder. Here's the certificate:
[illumos-amd64-jclulow-1715889249.cert.txt](https://github.com/golang/go/files/15340192/illumos-amd64-jclulow-1715889249.cert…dmitshur commented on golang.org/x/build/cmd/gopherbot: add task to label access issues2d
Thanks.dmitshur commented on crypto/x509: cleanup signature generation2d
Note that the parent commit is almost 1k commits old, which is much for a bigger change like this, causing trybot results to be less very representative. I'll rebase and restart trybots, just in case…dmitshur closed an issue access: merge my Gerrit accounts2d
In this case, we can merge your two accounts into one. That is done now.
Specifically, both of your emails are now associated with your older Gerrit account (ID 61713, created Mar 10, 2023), https…dmitshur commented on cmd/go: unexport loadImport2d
(1 comment)
Since GOPATH-based "go get" is no more, should this be removed?dmitshur commented on access: may-start-trybots2d
To confirm, you are able to leave a Commit-Queue+1 vote using your account, is that right? I see [here](https://go-review.googlesource.com/c/go/+/544435/1#message-07e9ce8108aeb839e2e9be291985b79117b0…dmitshur reviewed +2 on doc/next/64910.md: reword release note2d
Thanks.dmitshur reviewed +2 on doc/README.md: give example of package-less symbol link2d
Thanks.dmitshur reviewed +2 on doc: make symbol links simpler for relnotes2d
Thanks.
Great. That is simpler.dmitshur commented on doc: make symbol links simpler for relnotes2d
Thanks, this looks good, just wanted to ask one question first.
Do you know if this would link correctly if this is written as [encoding.BinaryMarshaler]? (You can check by looking at `relnote gener…dmitshur commented on access: may-start-trybots2d
The gerrit account `chenguoqi@loongson.cn` is still present in the `project-golang-may-start-trybots` group, so you should be able to. Are you logged in with that account and following the directions…dmitshur commented on access: Application to join golang/mips maintainer team2d
Thank you for contributing, and sorry this access request took us a while to process. You should have a pending invite to join the golang/mips team.dmitshur opened a change golang.org/x/build/cmd/gopherbot: add task to label access issues2d
This label will be used to automatically add new access issues to the
incoming queue.
Tested with go run . -dry-run -only-run='label access issues', result
is as expected.dmitshur commented on crypto/x509: cleanup signature generation2d
(1 comment)
FYI you can now write this in a simpler way as [CreateCertificateRequest]. It will be auto-linked as an identifier in this same package, like in godoc.
See [doc/README.md](https://cs.op…dmitshur commented on net/http: TestServerReadAfterWriteHeader100Continue/h1 failures2d
CC @neild.dmitshur opened a change golang.org/x/build/internal/relui/sign: re-enable non-existent signing request test2d
Take measures to wait for fakeSigningServerClient to complete before
returning from a test (so it can't call t.Logf after the test exited).
Also avoid calling t.FailNow inside goroutines other than t…dmitshur closed an issue golang.org/x/build/internal/relui/sign: TestUpdateSigningStatus failures2d
Fixed by [CL 504495](https://go.dev/cl/504495).dmitshur opened a change golang.org/x/build/internal/task: delete constant timeouts to deflake tests2d
The motivation is the same as described in the commit message
of https://go.dev/cl/504495.
For golang/go#64110.
Fixes golang/go#66282.dmitshur closed an issue build: build failure on x_vulndb-gotip-darwin-amd64_132d
Duplicate of #67404dmitshur closed an issue build: build failure on x_tools-gotip-solaris-amd642d
Duplicate of #67404dmitshur closed an issue build: build failure on x_tools-gotip-darwin-amd64-longtest2d
Duplicate of #67404dmitshur closed an issue build: build failure on x_vulndb-gotip-darwin-amd64_122d
Duplicate of #67404dmitshur closed an issue build: make.bash build failure with "cannot use debug.SetCrashOutput"2d
Fixed by [CL 585818](https://go.dev/cl/585818).dmitshur commented on net/http: avoid panic when writing 100-continue after handler done2d
(1 comment)
This test appears to be flaky. See #67382.dmitshur commented on golang.org/x/build: add LUCI freebsd-riscv64 builder2d
There's now a fully passing build at https://ci.chromium.org/b/8747907145247685825!dmitshur closed an issue golang.org/x/build/cmd/watchflakes: opens duplicate issues2d
We've made two changes to help with this:
- there's now an auto-archive workflow in the Test Flakes project
- it archives closed issues after 4 weeks of inactivity; we can adjust the exact ti…dmitshur closed an issue net/http: flaky test timeout2d
This issue isn't in the Test Flakes project, so it's not receiving further updates from watchflakes. If there are matches, they're being reported elsewhere. Closing this as there's nothing more to do…dmitshur commented on github.com/golang/protobuf: Set go.mod Go language version to oldest supported Go version (1.21 currently)3d
@jhump Thanks for your comment. I want to address the second paragraph in https://github.com/golang/protobuf/issues/1613#issuecomment-2113378587: the golang.org/x/... modules are only tested with the…dmitshur commented on cmd/cgo: a type alias of unsafe.Pointer is not treated as unsafe.Pointer3d
@ianlancetaylor Assigned it to you for now, please feel free to update.dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur closed an issue runtime:cpu4: TestUsingVDSO failures3d
Duplicate of #67383dmitshur commented on golang.org/x/build: add LUCI openbsd-ppc64 builder3d
Thanks for working on this.
> I'm not illuminated by looking at the Ended Builds list either.
I failed to realizer this sooner, but our configuration intends to make it possible for you to see …dmitshur commented on crypto/x509: TestPlatformVerifier failures on Windows due to broken connections [1.22 backport]3d
This is now approved for backporting. @rolandshoemaker Is it convenient for you to mail the backport CLs? Thanks.dmitshur commented on net/http: nil pointer dereference panic for httputil.ReverseProxy users [1.21 backport]3d
See https://github.com/golang/go/issues/67375#issuecomment-2113061816.dmitshur commented on net/http: nil pointer dereference panic for httputil.ReverseProxy users [1.22 backport]3d
We've discussed this candidate and are currently leaning towards rejection: this is an issue that has existed since at least Go 1.18, with difficulty in reliably reproducing it and not many users run…dmitshur commented on golang.org/x/build/cmd/watchflakes: opens duplicate issues3d
I've stopped it from running as a short-term workaround. Removing Soon label.
We've applied to https://github.blog/changelog/2024-02-12-github-issues-projects-projects-without-limits-private-beta/…dmitshur commented on golang.org/x/build/cmd/watchflakes: opens duplicate issues3d
Logs show it's running into a limit of items that can be added to a GitHub project:
```
# new issue: runtime:cpu4: TestUsingVDSO failures
2024-05-15 13:52 gotip-linux-ppc64_power8 go@6ccd8e4c ru…dmitshur opened an issue golang.org/x/build/cmd/watchflakes: opens duplicate issues3d
watchflakes is opening many duplicate issues recently, like "runtime:cpu4: TestUsingVDSO failures" is #67392 and #67391 and others.
I suspect the problem is that they're not added to the [Test Fla…dmitshur commented on golang.org/x/build/cmd/relnote: missed API changes3d
@jba Checking on from a weekly release meeting. Is there more to do before considering this resolved? Thanks.dmitshur commented on cmd/go: list confuses imports3d
@matloob Are there updates on this? This is currently a blocker for Go 1.23 RC 1. Is this important enough to be considered a release blocker for Go 1.23?dmitshur opened an issue x/build/internal/installer/{darwinpkg,windowsmsi}: report if GOTOOLCHAIN in environment is set to an older version than one being installed3d
When an installer for a certain Go version runs, it can check if the environment is configured such that `go version` would select select an older toolchain than the one being installed, and potentia…dmitshur starred github.com/gen2brain/raylib-go3d
dmitshur commented on golang.org/x/build: add LUCI freebsd-riscv64 builder3d
Looking at https://chromium-swarm.appspot.com/bot?id=freebsd-riscv64-mengzhuo, the bot seems to be running well in many x/ repos. It passes all but 2 tests at tip (e.g., https://ci.chromium.org/b/874…dmitshur commented on golang.org/x/build/cmd/golangbuild: LUCI builders run into result_adapter fail to parse FAIL message when there's a build failure3d
The problem appears to be in `result_adapter`, which is what's used to parse `go test -json` output and upload it to ResultDB. See:
https://source.chromium.org/chromium/infra/infra/+/main:go/src/i…