Activity
Yesterday
dmitshur closed an issue cmd/go/internal/vcweb/vcstest: TestScripts/git/vgotest1.txt failures7h
This Week
dmitshur reviewed +2 on golang.org/x/crypto/go.mod: update golang.org/x dependencies1d
(1 comment)
@roland@golang.org FYI, the tagging workflow is now capable of doing best-effort updates for these (i.e., using whatever is the latest released version available at the start of the work…dmitshur commented on golang.org/x/build/internal/task: don't wait for ignored dependencies1d
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg/testdata: tweak gopls assertions yet again1d
Thanks.
I think it might be the one! 🤞
I take it this'll need to be updated when eventually uncommenting these.
Well, now that it's covered in this test case, you can no longer change it to be …dmitshur commented on golang.org/x/telemetry/go.mod: update golang.org/x dependencies1d
@rfindley@google.com You seem to be most familiar with the [godev nested module](https://go-review.googlesource.com/q/project:telemetry+dir:godev) here. It has some additional golang.org/x dependency…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg/testdata: use tip for gopls tests, for now1d
Thanks.dmitshur reviewed +2 on golang.org/x/mod/go.mod: update golang.org/x dependencies1d
(1 comment)
This is working as intended after #73264. The x/tools is waiting on x/mod to be tagged first, so x/mod can't wait on x/tools's future v0.35.0 version. But it can be updated to its latest…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: make assertions work with dummy and real data1d
Thanks. There might be some follow up (see inline comments), but the changes here are good and will get it closer to working.
Note that for links to pages on the Go website itself, using a relative …dmitshur commented on golang.org/x/build: test failures are hard to discover1d
Issue #74323 might be relevant here.
It appears that the reason the package `golang.org/x/tools/gopls/internal/test/marker` tests are reported as failed is because of the data race that came up duri…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg/cloudbuild.yaml: copy x/tools/gopls into _content1d
Thanks. The directories line up as expected.
FWIW, I think this could say "For" (or "Updates" if you prefer that) since this step to copy x/tools @ HEAD data into x/website's initial _content to imp…dmitshur opened a change golang.org/x/build/internal/task: don't wait on ignored dependencies1d
Prior to CL 681439, the loop over module requirements in readRepo
was skipping non-golang.org/x dependencies, as well as golang.org/x
dependencies that are marked as "ignored". Those skips were repla…dmitshur commented on : go1.23.11 segmentation fault in test1d
CC @golang/runtime.dmitshur commented on crypto/tls: empty server_name conf. ext. from server1d
(1 comment)
@daniel@binaryparadox.net Please note (for future CLs) that one of conventions for Go commit messages is to use "Fixes" to mark issues as resolved. From https://go.dev/wiki/CommitMessage…dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls2d
(1 comment)
I remembered this now. The deploy does this to provide a reasonable fallback (as stated in the comment) for wiki. Not sure if you've seen it, but if not, consider if the gopls endpoint w…dmitshur commented on golang.org/x/website/cmd/golangorg: assert that builders do not use GOTOOLCHAIN2d
(1 comment)
Thanks.dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls2d
(1 comment)
(Might reduce confusion for future readers.)
```suggestion
the tip.golang.org/gopls endpoint serves the latest
```dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: assert that builders do not use GOTOOLCHAIN2d
Thanks. I think this is worthwhile to include for now, since it eliminates a path for the automatic deploys to go awry without us easily noticing it.
Please include `err` from os.Stat in the t.Fatal…dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls2d
(1 comment)
Note that that builder running at patch set 10 did run the test (i.e., it didn't skip it), suggesting it has GOROOT/doc as expected: https://ci.chromium.org/ui/p/golang/builders/try/x_we…dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls2d
(1 comment)
Can you please include a direct link to where you saw this? I only found that builder failing at earlier patch sets, for reasons unrelated to this. Does it still happen at patch set 10+?dmitshur reviewed +2 on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls2d
Thanks.
s/This/The/
Please add a https://go.dev/doc/contribute#copyright comment and a blank line before the package comment.
tip.golang.org. We only provide tip. at the golang.org alias, not go.d…dmitshur reviewed +1 on golang.org/x/tools/gopls/doc: add default.tmpl for x/website2d
dmitshur reviewed +2 on golang.org/x/website/internal/history: remove empty entries2d
Thanks.dmitshur commented on cmd/go: disable support for multiple vcs in one module2d
(1 comment)
Consider updating this to the newer wording (as used in the cherry pick CLs).dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls2d
The test failure is likely real - when I tried it locally at PS 6, visiting localhost:6060/go.dev/gopls/ displayed a directory listing rather than a page.
There's no policy requiring this. I wanted …dmitshur commented on golang.org/x/website/cmd/golangorg: serve gopls docs at go.dev/gopls2d
In general this looks very reasonable to me, extending the approach used for /wiki/ pages with details specific to gopls (e.g., defaulting to latest published gopls tag on go.dev; HEAD on tip.go.dev)…dmitshur reopened an issue cmd/compile/internal/ssa: TestStmtLines fails due to auto-generated crypto code3d
Reopening to track removal of the [test skip](https://cs.opensource.google/go/go/+/master:src/cmd/compile/internal/ssa/stmtlines_test.go;l=106-108;drc=4a3cef2036097d323b6cc0bbe90fc4d8c7588660). (CC @…dmitshur commented on golang.org/x/website/_content/blog/generic-interfaces: new blog post3d
Alan, leaving this in your attention set to re-add your votes. Thanks.dmitshur commented on golang.org/x/website/_content/blog/generic-interfaces: new blog post3d
(1 comment)
Please also [keep](https://go-review.googlesource.com/c/website/+/614595/13..14) the date set to today (2025-07-07), and we'll re-add the votes after they reset. Thanks.Last Week
dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines6d
Take a closer look at the 'Submit Requirements' panel, it should show that the CL currently has 3 out of 4 submit requirements satisfied. As soon as the 4th one is satisfied, it'll get auto-submitted…dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines6d
misccompile failure is not persistent and unrelated; bypassing.dmitshur commented on cmd/compile/internal/ssa: skip EndSequence entries in TestStmtLines6d
(1 comment)
Is it known to you why this doesn't seem to reproduce on builders?dmitshur commented on golang.org/x/pkgsite/internal/postgres: Apply bypassLicenseCheck to IsRedistributable column.6d
(1 comment)
(nit) Please note that the Go commit message style uses a lower case letter after the colon, and no period at the end, because it's intended to complete the sentence "This change modifie…dmitshur commented on golang.org/x/build/main.star: update security release branch pattern to match RCs1w
Thanks.dmitshur opened a change golang.org/x/build/main.star: update security release branch pattern to match RCs1w
The previous pattern 'internal-release-branch.go1.24.\d+' works for
minor releases as intended, but doesn't work for release candidates.
RCs can have PRIVATE-track security fixes included too (for ex…dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too1w
Thanks.dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too1w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too1w
(1 comment)
Thanks. Done.dmitshur commented on golang.org/x/build/internal/task: build internal security branch for next RC too1w
(1 comment)
@roland@golang.org This getting pretty long, so maybe worth shortening? Dropping 'and' at least?
"go1.5rc1-go1.4.2-go1.3.2-checkpoint"
I can include some change in this CL if you prefe…dmitshur opened a change golang.org/x/build/internal/task: build internal security branch for next RC too1w
In the second half of the go.dev/s/release cycle, after entering the
release freeze and before releasing the first pre-release (RC 1), a
release branch for the next major Go release is cut.
Security…dmitshur commented on cmd/cgo/internal/testsanitizers: skip asan tests when FIPS140 mode is on1w
Yes, it's generally okay to apply test fixes during the freeze, that's a large part part of what it's for. The text fix needs to be safe, and this looks safe.dmitshur commented on encoding/json/v2: add security section to doc1w
cmd/go.TestScript/list_empty_importpath is #73976.dmitshur commented on runtime: update skips for TestGdbBacktrace1w
Thanks.dmitshur closed an issue sum.golang.org: Update hash of github.com/xmppo/go-xmpp1w
In the general case, the moment a tag is published, it's not viable to modify its contents without potentially causing problems. Instead, it's possible for you to publish a newer version that correct…Earlier
dmitshur reviewed +2 on runtime: remove arbitrary 5-second timeout in TestNeedmDeadlock1w
Thanks.dmitshur commented on runtime: TestNeedmDeadlock failures1w
The only potentially relevant recent builder change I can think of is [crrev.com/c/6641842](https://crrev.com/c/6641842) (CC @mknyszek) which rebalanced test sharding strategy for #65814. Its timing …dmitshur commented on runtime: TestNeedmDeadlock failures1w
This test has started to fail very often on the gotip-linux-arm64-asan-clang15 linux specifically recently. As visible in its [history](https://ci.chromium.org/ui/test/golang/runtime.TestNeedmDeadloc…dmitshur commented on cmd/doc: fix -http on Windows1w
(1 comment)
(minor) These 2 spaces seem out of place.dmitshur fixed an issue access: approvers1w
Hi Julian,
Thank you for contributing to the Go project, and for your work of being a maintainer of the MIPS ports. We've discussed this request on the team and agreed to grant you this access. I've…dmitshur commented on : Clang 18+ does not support the '-arch' switch (Android NDK binaries)1w
CC @golang/android.dmitshur commented on cmd/link: duplicated definition of symbol github.com/ebitengine/purego.syscall15XABI0 when running with ASAN [1.24 backport]1w
We discussed this and agreed to proceed with the backport. Thanks.dmitshur commented on runtime: [release-branch.go1.24] set mspan limit field early and eagerly1w
The were a number of errors in tests hitting the Go website because during a traffic spike. Retrying.dmitshur commented on cmd/compile: devirtualized type switch causes temporary allocation to escape1w
CC @golang/compiler.dmitshur commented on reflect: TypeAssert[T] is not identical to Interface().(T)1w
CC @golang/runtime.dmitshur commented on slices: TestIssue68488 seems sensitive to minor stack perturbations1w
CC @Jorropo, @randall77.dmitshur commented on cmd/go: go tool does not accept -mod=1w
CC @golang/command-line.dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.2w
If more time is desired and the trade-offs are appropriate, also consider the path of reverting the change that caused this regression, reopening #52745, and trying again in a future cycle.dmitshur commented on runtime: skip GDB "no such process" case2w
(2 comments)
Based on the log in the issue report, and the regexp pattern, is the missing 's' here in the commit message a typo? (Otherwise the regexp won't match.)
```suggestion
"Couldn't get NT_P…dmitshur pushed to
main in rsc.io/rf2w
dmitshur merged a change rsc.io/rf/...: fix detection of unused variable2w
dmitshur reviewed +2 on rsc.io/rf/...: fix detection of unused variable2w
The check fails for reasons unrelated to the change here. The module requires Go 1.20 but the check tries to test with Go 1.16 (which is before [go.dev/doc/toolchain](https://go.dev/doc/toolchain#sel…dmitshur pushed to
main in rsc.io/rf2wdmitshur merged a change rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile2w
dmitshur reviewed +2 on rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile2w
LGTM. Thanks.dmitshur commented on cmd/compile/internal/escape: optimization wrongly affecting panics2w
CC @golang/compiler.dmitshur commented on reflect: Value.Seq|Seq2 documentation and unexported value2w
CC @golang/runtime.dmitshur commented on doc: write release notes for Go 1.252w
The Go 1.25 release notes draft is complete by now, and there doesn't seem to be any remaining known TODOs to resolve. Thanks everyone.
It's okay for this to be open to track any further refinement …dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.2w
Pinging as this is a release blocker for Go 1.25.dmitshur commented on cmd/doc: -http fails on Windows with invalid port2w
Pinging as this is a release blocker for Go 1.25.dmitshur commented on crypto/tls: TLS handshake timeout consistently on Windows VM LTSC2019 with private IP2w
Thanks for the report. So the problem happens with the same Go program in an older Windows LTSC and doesn't happen in a newer Windows LTSC. Is the crypto/tls implementation in Go doing something diff…dmitshur commented on context: fix typo in context_test.go2w
Bypass since trybots already passed on PS 3.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)2w
Thanks.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)2w
Copied Votes:
* Code-Review+1, Code-Review+2 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforce…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)2w
(3 comments)
Hmm, this is the first time I'm encountering this suggestion. I have seen many instances of short inline comments not being a complete sentence (e.g., `N int64 // bytes remaining` rathe…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)2w
Yes, I gave a heads up via chat and I saw that @adonovan@google.com gave it a thumbs up, so I think that's done (Alan, please let me know if you have questions or concerns). I'll copy from https://go…dmitshur reviewed +2 on encoding/json: use zstd compressed testdata2w
Thanks. (The cmd/go.TestScript/list_empty_importpath failure looks unrelated to the changes here.)dmitshur commented on cmd/cover: wrong coverage reported when func fields in struct2w
CC @thanm, @golang/compiler.dmitshur commented on encoding/json/v2: report error on time.Duration without explicit format2w
Indeed, Auto-Submit does what it says on the tin as soon as all submit requirements are satisfied. :) Fortunately there weren't any hidden test failures so it worked out.dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)2w
Friendly ping.dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv22w
Thanks.
(nit) Not a big deal, but mentioning for future reference: https://www.w3.org/TR/wasm-core-2/#wasm.
Please include something to connect this CL with a tracking issue. This is [always useful…dmitshur reviewed +2 on cmd/dist: test encoding/json/... with GOEXPERIMENT=jsonv22w
Thanks.
Both forms are interchangeable and okay. This is described in a bit more detail at [go.dev/wiki/CommitMessage](https://go.dev/wiki/CommitMessage#:~:text=To%20link%20a,or%20vice%20versa.).dmitshur commented on net/http: punycode labels ending with hyphen (xn--example-) should be rejected per updated UTS-462w
Thanks for filing the issue. Someone familiar with this package may have more specific comments, but in general please see https://go.dev/doc/contribute on how to send a code change. I added a mentio…dmitshur commented on golang.org/x/sys/windows: fix filetime conversions and deprecate Nanoseconds2w
CC @golang/windows.dmitshur commented on internal/goexperiment: user facing documentation for GOEXPERIMENT points to internal source for list of supported values2w
CC @golang/command-line, @golang/runtime.dmitshur commented on runtime: passing a JS pointer to Go-Wasm runtime causes memory leak2w
CC @golang/wasm.dmitshur commented on runtime: add missing unlock in sysReserveAlignedSbrk2w
(1 comment)
Is this the right issue for this?
```suggestion
unlocked at one of the return path. Add the missing unlock.
Fixes #74339.
```dmitshur commented on cmd/go: clean doesn't respect workspace vendoring2w
CC @golang/command-line.dmitshur commented on cmd/go/internal/test: "go help testflag" refers to legacy options of pprof2w
CC @golang/command-line, @cherrymui.dmitshur commented on encoding/json/jsontext: consistently use JSON terminology2w
No legacy slowbots were requested.dmitshur commented on encoding/json/v2: report error on time.Duration without explicit format2w
No legacy slowbots were requested.dmitshur commented on encoding/json/v2: test that trybots work2w
LUCI trybots by default run a rough equivalent of all.bash on various ports. If all.bash doesn't fail for you when you run it locally, LUCI trybots shouldn't fail either.
If you'd like to have all.b…dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
Thanks.dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
Hmm, can you confirm you’ve done this part?
> (Also please be sure that the darwinpkg.InstallerOptions.GOARCH value is “amd64” in your construct installer call on line 28 when you’re giving …dmitshur opened an issue cmd/go: "test timed out after ... running tests: ..." attached to one of many subtests in JSON mode, can be less visible compared to non-JSON output2w
Consider the output from `go test` without `-json` flag in a situation where a test timeout happens while multiple subtests are still running (as happened in #74279):
```sh
$ go version
go version g…dmitshur commented on golang.org/x/build/main.star: increase openbsd-amd64 timeout scaling to 42w
Thanks.dmitshur opened a change golang.org/x/build/main.star: increase openbsd-amd64 timeout scaling to 42w
Looking at recent build completion times for x_tools-gotip-openbsd-amd64
shows it often takes around 20 minutes, while x_tools-gotip-linux-amd64
often takes around 5 minutes. Even in the main Go repo…dmitshur commented on golang.org/x/build/internal/task: extend best-effort updating to nested modules (part 2 of 2)2w
This change is ready for review.dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host2w
Copied Votes:
* Code-Review+1 (copy condition\*: "**is:ANY**")
Outdated Votes:
* LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")
\* The label has `labelCopyEnforcement` or `label…dmitshur starred github.com/jamesshenjian/jpegsl3w
dmitshur commented on golang.org/x/build/internal/installer/darwinpkg: detect amd64 installer on arm64 host3w
Of course. In theory you can use a regular ./make.bash and create the .tar.gz archive of the result, but it might be easier to use ./make.bash with -distpack flag—just like the real release process…dmitshur commented on github.com/shurcooL/home/internal/exp/service/activity/{github,gerrit}: walkSegMail can fail with EOF3w
There was another instance, but this time it was with a non-zero offset in the middle of a month:
```
2025/06/18 14:21:34 service/activity/github: mailLoop: walkSegMail(github.fileSeg{file:"/2025-06…