@Jacalz and I discussed https://github.com/go-gl/glfw/issues/188#issuecomment-1982945940 offline; I believe we agreed it's not something we can pursue in a way that works with the [Go module](https:/…
Thanks for getting it this far. I've been using this locally on macOS and haven't spotted any more issues on this platform and in my usage.
---
> Forgot to mention, @dmitshur can you test with …
Thanks. I'll David look since he's more familiar with this, but to me it seems fine to submit since this change is only affecting a port that you maintain and https://storage.googleapis.com/go-build-…
Noting here that the maintner service's [`ListGoReleases`](https://pkg.go.dev/golang.org/x/build/maintner/maintnerd/apipb#MaintnerServiceClient.ListGoReleases) API call might be useful for this.
<…
This issue tracks turning this on in the coordinator codebase (see [here](https://cs.opensource.google/go/x/build/+/master:dashboard/builders.go;l=1484-1486;drc=4ee487b137da815f5e68acb20a18dc0e6f9693…
The plan/386 port doesn't bootstrap at this time. Remove it from the
current misc-compile trybot set to get them passing while the Plan 9
issue is being investigated and fixed.
For golang/go#67502.
(1 comment)
(nit) The lines in this list are sorted; if you don't mind please apply that to the new lines too. It's not a big deal and can happen in a future CL instead.
This is a tracking issue to port the behavior implemented in coordinator for #61925 to the LUCI side in [golangbuild](https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/experimental…
As reported by the plan9-386-0intro builder and legacy misc-compile-plan9-386 trybot, the plan9/386 port fails to bootstrap:
```
gotip $ git rev-parse HEAD
e7bf9959fd9ea649e1513cef16f91f81b13604…
Our migration to [LUCI](https://go.dev/wiki/LUCI) should make a meaningful improvement for golang.org/x repo result views.
Using a recent issue #67439 as an example, where CL 546676 introduced a n…
Adding a few investigative notes.
As visible by comparing [here](https://ci.chromium.org/ui/test/golang/net%2Fhttp.TestServerReadAfterWriteHeader100Continue%2Fh1) and [here](https://ci.chromium.or…
Thanks for your contributions and helping maintain the ppc64 and ppc64le ports. We've added you to the `project-golang-may-start-trybots` group, so you should be able to trigger [trybots](https://go.…
linux/arm and a number of secondary ports are failing to make.bash as of this CL. Please comment if you think the fix is small and can be done soon, otherwise let's revert.
Issue #67439 is fixed by CL 586315, so this change is no longer needed. I think the original implementation is marginally better, and it relies on intended net/http behavior that shouldn't regress.
This doesn't reproduce each time for me, but I saw it happen again today after running these commands in my development GOROOT directory today:
```
src $ git-branches
| Branch | …
Note that Go 1.22.2 is not the current latest version. That version is Go 1.22.3, released 10 days: https://groups.google.com/g/golang-announce/c/wkkO4P9stm0. Go 1.22.3 includes fixes for CVE-2024-24…
From looking at https://ci.chromium.org/ui/p/golang/g/port-freebsd-riscv64/builders, the builder seems to be producing good testing signal. @mengzhuo Would you like to remove its [known issue](https:…
Thanks for reporting. CC @golang/release, @mknyszek.
Are you able to narrow down more specifics of where the additional bandwidth utilization comes from? Is it uplink or downlink?
The testing s…
Thanks for reporting this.
The git configuration surface is quite large, and this appears to be a case where one of the configuration values conflicts with the expectations of git-codereview, caus…
Thanks for reporting. Some notes from when I briefly looked in case they're helpful.
cmd/dist sets GOPATH env var (which in turn sets the module cache location) to $GOROOT/pkg/obj/gopath during the …
Thanks.
@imcusg@gmail.com Please see https://go.dev/wiki/LUCI#trybots for current information on how to trigger trybots. In most cases you should use Commit-Queue+1 vote, not the legacy Run-TryBot+1…
Thanks for reporting. CC @golang/release.
First, can you try and see if you're able to start slowbots by including a `Cq-Include-Trybots: luci.golang.try:gotip-linux-loong64` git footer in the com…
Sorry for the trouble, I didn't realize it wouldn't have effect on your newer CLs.
Since it's only two of them and both haven't begun code review yet (and one of them needs a merge conflict resolu…
Thanks for getting to this point.
The bot is visible at https://chromium-swarm.appspot.com/bot?id=illumos-amd64-jclulow. As you noted, it's identifying itself as having a cipd_platform value of "s…
Thank you for working on this and your patience. I'd like to try to help move this forward. Apologies for not commenting here sooner.
We don't quite have an ideal existing builder that we can poin…
This particular issue tracks the Android emulator-based builder. I've had a chance to prototype it earlier, and will update it as further progress is made.
@changkun, at this time this issue doesn…
(1 comment)
Consider adding a `Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest` footer (detailed instructions [here](https://go.dev/wiki/SlowBots#using-slowbots)) so trybot signal wo…
Looks good to me, but I'll leave it to Jonathan to look, so +1. Left a few minor comments that I spotted. Thanks.
(nit) https://go.dev/wiki/Spelling suggests using a different spelling for this part…
I sent [CL 586077](https://go.dev/cl/586077) which fixes the immediate problem on the x/build side. It'd be good for Damien to check if this is working as expected.
Previously it worked for Exec to detect that the context deadline
exceeded by inspecting the io.Copy error. As of CL 546676 that no
longer works, so add an explicit check if the context exceeded if
i…
As visible on the [x/build by Go commit](https://ci.chromium.org/p/golang/g/x-build-gotip-by-go/console) view, `TestExecTimeoutError` has started to fail consistently at Go tip starting with [CL 5466…
Thank you for starting to work on this builder. Here's the certificate:
[illumos-amd64-jclulow-1715889249.cert.txt](https://github.com/golang/go/files/15340192/illumos-amd64-jclulow-1715889249.cert…
Note that the parent commit is almost 1k commits old, which is much for a bigger change like this, causing trybot results to be less very representative. I'll rebase and restart trybots, just in case…
In this case, we can merge your two accounts into one. That is done now.
Specifically, both of your emails are now associated with your older Gerrit account (ID 61713, created Mar 10, 2023), https…
To confirm, you are able to leave a Commit-Queue+1 vote using your account, is that right? I see [here](https://go-review.googlesource.com/c/go/+/544435/1#message-07e9ce8108aeb839e2e9be291985b79117b0…
Thanks, this looks good, just wanted to ask one question first.
Do you know if this would link correctly if this is written as [encoding.BinaryMarshaler]? (You can check by looking at `relnote gener…
The gerrit account `chenguoqi@loongson.cn` is still present in the `project-golang-may-start-trybots` group, so you should be able to. Are you logged in with that account and following the directions…
This label will be used to automatically add new access issues to the
incoming queue.
Tested with go run . -dry-run -only-run='label access issues', result
is as expected.
(1 comment)
FYI you can now write this in a simpler way as [CreateCertificateRequest]. It will be auto-linked as an identifier in this same package, like in godoc.
See [doc/README.md](https://cs.op…
Take measures to wait for fakeSigningServerClient to complete before
returning from a test (so it can't call t.Logf after the test exited).
Also avoid calling t.FailNow inside goroutines other than t…
We've made two changes to help with this:
- there's now an auto-archive workflow in the Test Flakes project
- it archives closed issues after 4 weeks of inactivity; we can adjust the exact ti…
This issue isn't in the Test Flakes project, so it's not receiving further updates from watchflakes. If there are matches, they're being reported elsewhere. Closing this as there's nothing more to do…
@jhump Thanks for your comment. I want to address the second paragraph in https://github.com/golang/protobuf/issues/1613#issuecomment-2113378587: the golang.org/x/... modules are only tested with the…