Dmitri Shuralyov

Testing "paste image" new functionality!

August 21, 2016
dmitshur

First pasted image!

Just take a screenshot (e.g., Ctrl+Cmd+Shift+4 on OS X, then drag a selection box), then place the cursor in the comment box and hit Cmd+V (or Ctrl+V on Linux/Windows) to paste.

Relevant code changes:

https://github.com/shurcooL/home/pull/1 (backend part)
https://github.com/shurcooL/issuesapp/blob/da67698f07a50129f557cd26e3d549a8bb1453ee/assets/script/upload.go (frontend part)

Comments

dmitshur closed this 10 years ago

carlisia commented 10 years ago

dmitshur commented 10 years ago

Whoa, awesome! :) Thanks a lot @carlisia.

bep commented 10 years ago

Does not work for me ... MacBook.

ScottMansfield commented 10 years ago

Screen Shot 2016-08-20 at 6.34.06 PM.png

bep commented 10 years ago

dmitshur commented 10 years ago

Looks like it doesn't work in Firefox yet (a frontend issue):

TypeError: e is undefined
    

...oardData.items;c[0]=null;f=0;case 1:if(!(f<$parseInt(e.length))){$s=2;continue;}...

I'll look into that. I'm guessing it's related to the clipboard event APIs I'm using to access the pasted image.

Thanks to @bep for reporting.

Update: I tried in Firefox (developer edition, version 50) and could not reproduce... Maybe your firefox version was too old?

bep commented 10 years ago

I'm at Firefox 46 waiting for something newer than 47 is released (there is a bug in 47 that I want to avoid), which is now the case, so yes, that is a likely explanation. I will update now and test.

dmitshur commented 10 years ago

@bep Got it, thanks. I am happy to try to support latest official release of Firefox (version 48), but I won't be able to support older ones (I'm only one person). :)

Let me know how it looks like with the latest official release.

to comment.