Fixed this in 9181e9
.
I just checked https://src.sourcegraph.com/sourcegraph/.tracker/18#comment-0 and I can see the effect.
It seems to wrap the pre-formatted text or code. I think that's suboptimal (e.g. the diff
becomes hard to read). We should have it appear with a horizontal scroll bar and preserve lines as they are originally written. Do you agree that'd be better?
Another problem is that some text still goes outside of the area.
https://src.sourcegraph.com/sourcegraph/.tracker/51#comment-1
The fix will be using the right CSS. /cc @renfredxh
Fixed this in 9181e9.
I just noticed this can still happen in the preview comment view; I think that was missed. /cc @renfredxh
Another instance of this still happening:
https://src.sourcegraph.com/sourcegraph/.tracker/327#comment-3
Another instance reported by @slimsag in #34.
I believe this issue has been fully resolved now as of https://github.com/shurcooL/issuesapp/commit/3c28bdba09fcf83b7cc784c7428d750b6b98f903. At least I haven't seen it happen anytime recently.
Closing since it appears to be fixed. If any reproducible issues are found again, this can be reopened (or just use a new issue).
Seeing this happen again at:
https://dmitri.shuralyov.com/issues/github.com/shurcooL/notificationsapp/2#comment-0
I think this time it's for a different reason, and has to do with display: flex
being used.
E.g.:
https://src.sourcegraph.com/sourcegraph/.tracker/18#comment-0