github.com/shurcooL/notificationsapp/...

Notification RepoSpec is an `issues.RepoSpec` github.com/shurcooL/notificationsapp#5

Closedkeegancsmith opened this issue 10 years ago
keegancsmith commented 10 years ago

Weird to have a dep on the issues app in this app. Was this just for convenience. Also sourcegraph.RepoSpec seems like the more generic struct to use.

Write Preview Markdown
dmitshur commented 10 years ago

Same reason as described in https://src.sourcegraph.com/apps/tracker/.tracker/30.

I think I had a TODO about "finding the best place to define RepoSpec". Yeah, it's here.

I saw platform apps as an opportunity to be more independent and take the chance to improve on various aspects; that includes not pulling in so many unneeded dependencies for basic struct definitions.

A short term solution I can think of is a go-sourcegraph-like package but for sourcegraph platform apps, so both tracker and notifications can use it. A more long term solution might be factoring out type definitions into a smaller package out of go-sourcegraph, and having everyone import that.

I'm okay with just leaving it as a TODO for the time being.

Write Preview Markdown
keegancsmith commented 10 years ago

Cool :)

I very much like the idea of go-sourcegraph being less monolithic so pulling it in makes sense.

Write Preview Markdown
keegancsmith closed this 10 years ago
to comment.