API to handle sending Slack and Email notifications github.com/shurcooL/notificationsapp#7

We need to think about the API so that it can handle other sort of notifications. Some decent context is the changesets adding Slack to Threads + adding NC to CS. https://src.sourcegraph.com/sourcegraph/.changes/593 https://src.sourcegraph.com/apps/tracker/.changes/10

I think this API is pretty close to perfect for what the notification center is currently responsible for: Storing need to read states for a set of subscribers. However, it is missing a lot of info for sending good notifications via slack or email.

My gut says this API should remain as is and a new API which speaks to both this and slack should be designed. Maybe that API is just based off events that get fired? Not sure. It may make sense to take this current API and make it like a store in the usual sourcegraph pattern, and expose something else as the service. Just some random thoughts quickly written down. Would love to hear your comments. cc @shurcool

I think this API is pretty close to perfect for what the notification center is currently responsible for: Storing need to read states for a set of subscribers.

Makes sense. It's the primary actionable/testable use case I've designed it for so far, and I planned to make further changes when there are concrete needs.

However, it is missing a lot of info for sending good notifications via slack or email.

Can you elaborate on this, what other info is it missing?

My gut says this API should remain as is and a new API which speaks to both this and slack should be designed. Maybe that API is just based off events that get fired? Not sure. It may make sense to take this current API and make it like a store in the usual sourcegraph pattern, and expose something else as the service.

I'll want to get more familiar with what it takes to send good Slack messages and its API to be able to give a response here. We should discuss this, I'm very interested in finding a great solution. :+1:

I'll close this now because I didn't get an answer to my question above, and this issue is old and not actionable by now.

When a new concrete need arises, we can refer to discussion here.