github.com/shurcooL/notificationsapp/...

User gets notified of his own actions from Changesets app. github.com/shurcooL/notificationsapp#8

Closeddmitshur opened this issue 10 years ago
dmitshur commented 10 years ago

@keegancsmith, the above logic doesn't work for Changesets app. The reason is that it relies on figuring out the current user from the given context. This works for Tracker app since all Tracker notifications come from actions on the website.

However, with Changesets, it's possible for me to push a commit to a branch, which could cause Changesets app to detect that a CS is merged, and notify all subscribers (including the author) of an update.

But that feels like a false positive to me. I've merged the CS myself (even if indirectly), should I really be notified about it via Notification Center?

Write Preview Markdown
keegancsmith commented 10 years ago

Yes, you shouldn't be notified. So the issue here is that for pushes we don't have a currentUser set in the context?

Write Preview Markdown
dmitshur commented 10 years ago

Yes, I think so. The context used in that case is likely a background CLI context.

Maybe we should be adding a user to it, since we know who the user doing the git operation is.

Write Preview Markdown
dmitshur commented 10 years ago

Closing because this issue was only relevant in the context of the Changesets app, and that app has been deprecated.

Write Preview Markdown
dmitshur closed this 10 years ago
to comment.