Dmitri Shuralyov

Oh, trying the same repro on a different darwin/arm64 machine, this reproduced within a minute 3 out of 3 times. Unless it's a coincidence, the only difference is that the no-repro machine has M1 Pro…

dmitshur an issue net/url: ipv4 mapped ipv6 addresses should be valid in square brackets3d

dmitshur an issue golang.org/x/net/http2: data race in TestGoroutineLock3d

Thanks for the report. How quickly does it typically reproduce for you? Also, to confirm, does `git status` print that there are no local code changes for you? In my case, 10 minutes of running didn'…

dmitshur commented on golang.org/x/net/http2: data race in TestGoroutineLock3d

Thanks for the report. How quickly does it typically reproduce for you? Also, to confirm, does `git status` print that there are no local code changes for you? In my case, 10 minutes of running didn'…

dmitshur commented on golang.org/x/net/http2: fix race condition when disabling goroutine debugging for one test4d

(1 comment) Please report this at [go.dev/issue/new](https://go.dev/issue/new) and include in the issue what version of Go you used, as well as the x/net version (or commit). That doesn't seem to re…

dmitshur commented on golang.org/x/build/main.star: add presubmit for build in go-internal4d

Thanks.

dmitshur an issue runtime: aix-ppc64 hangs after CL 7063954d

dmitshur commented on spec: [release-branch.go1.25] update spec date to match release date4d

(2 comments) Done. Fix applied.

dmitshur commented on golang.org/x/net/http2: fix race condition when disabling goroutine debugging for one test4d

(1 comment) I commented on TestGoroutineLock too in https://go-review.googlesource.com/c/net/+/701836/comment/d94eaf1c_c8b62623/. Please take a look at whether what you're seeing is different.

dmitshur an issue os: tests fail on ext4 with 128byte inodes due to insufficient time precision4d

dmitshur commented on spec: [release-branch.go1.25] update spec date to match release date4d

(1 comment) A reminder for me to add this (after trybots finish running): ```suggestion This is a roll forward of CL 709515 which was rolled back by CL 709535. For #75743. ```

dmitshur opened a change spec: [release-branch.go1.25] update spec date to match release date4d

Ths spec date in the 1.25 release branch dates back to Feb 2025 which is rather confusing. Moving it forward to 1.25 release date. This is a roll forward of CL 709515 which was rolled back by CL 709…

dmitshur commented on golang.org/x/build/internal/relui: add release/security team to ACLs4d

(1 comment) Ok. I suspect it might be less overhead if whoever plans to own/run the actual x/ repo security fix publication workflow to also handles its pre-announcement, but no objections to adding…

dmitshur commented on golang.org/x/build/internal/relui: add release/security team to ACLs4d

(1 comment) Hmm, maybe one of the reasons we didn't have this previously was to help make it clear who owns running this workflow. Just checking, are there cases where it makes sense to have release…

dmitshur reviewed +2 on golang.org/x/build/internal/relui: add release/security team to ACLs4d

Thanks.

dmitshur opened a change golang.org/x/build/main.star: add presubmit for build in go-internal4d

dmitshur an issue crypto/internal/fips140/subtle: Go 1.25 subtle.xorBytes panic on MIPS4d

dmitshur an issue golang.org/x/net/html: ParseFragment out of memory on specially crafted input4d

dmitshur an issue golang.org/x/net/html: various quadratic parsing behaviors4d

dmitshur an issue golang.org/x/net/html: ParseFragment out of memory on specially crafted input4d

dmitshur commented on golang.org/x/build/internal/workflow: correct type for constant, taskResult, expansionResult5d

Thanks.

dmitshur closed an issue golang.org/x/tools/gopls: converge gopls support window with top-level Go support window5d

dmitshur an issue cmd/gofmt: change -d to exit 1 if diffs exist5d

dmitshur fixed an issue spec: Go1.25 spec should be dated closer to actual release date5d

Closing this since there's nothing more to do for the Go 1.26 milestone - the language version and its date are for Go 1.26 there. The change on release-branch.go1.25 will be tracked in #75777.

dmitshur fixed an issue spec: Go1.25 spec should be dated closer to actual release date5d

Closing this since there's nothing more to do for the Go 1.26 milestone - the language version and its date are for Go 1.26 there. The change on release-branch.go1.25 will be tracked in #75777.

dmitshur an issue spec: Go1.25 spec should be dated closer to actual release date [1.25 backport]5d

dmitshur commented on spec: Go1.25 spec should be dated closer to actual release date5d

I'll request a backport issue so this can go through the [usual backporting process](https://go.dev/wiki/MinorReleases). @gopherbot Please backport to Go 1.25. This is a documentation-only change to…

dmitshur commented on golang.org/x/build/internal/workflow: use reflect.TypeFor6d

(1 comment) Sent CL 709516.

dmitshur opened a change golang.org/x/build/internal/workflow: correct type for constant, taskResult, expansionResult6d

The type was already correct for parameter and slice, but these three had an extra slice on top of T. Thanks to Alan for noticing this during the review of CL 709155. Also switch to reflect.TypeFor …

dmitshur commented on spec: [release-branch.go1.25] revert "update spec date to match release date"6d

(1 comment) ```suggestion [release-branch.go1.25] spec: revert "update spec date to match release date" ``` That'll satisfy the 'Matching-Subject-Prefix' submit requirement.

dmitshur reviewed +2 on spec: [release-branch.go1.25] revert "update spec date to match release date"6d

Thanks. ```suggestion This reverts CL 709515 (commit d6f274124871dbc3e55b9101e2891785500a178c). ``` Based on the suggestion at https://go.dev/wiki/CommitMessage#reverts.

dmitshur an issue testing/synctest: remove Run in Go 1.266d

dmitshur an issue golang.org/x/website/tour: automatic save of the last accessed tour page1w

dmitshur an issue runtime: debug.decoratemappings don't work as expected1w

dmitshur an issue sync/atomic: comment for Uintptr.Or incorrectly describes return value [1.25 backport]1w

dmitshur an issue sync/atomic: comment for Uintptr.Or incorrectly describes return value [1.24 backport]1w

dmitshur an issue cmd/compile: internal compiler error with GOEXPERIMENT=cgocheck2 on github.com/leodido/go-urn1w

dmitshur an issue crypto/tls: ALPN negotiation error contains attacker controlled information1w

dmitshur starred github.com/hickford/git-credential-oauth1w

dmitshur an issue runtime: TestScavengedBitsCleared failures1w

dmitshur an issue cmd/internal/moddeps: TestAllDependencies/std(thorough) failures [consistent failure]1w

dmitshur an issue golang.org/x/crypto/ssh: panic stating scalarBaseMult was not 32 bytes on FIPS enabled host with curve255192w

dmitshur an issue net/http: internal error: connCount underflow3w

dmitshur an issue net: race where Dialer.DialContext returns connections with altered write deadlines3w

dmitshur an issue crypto/internal/fips140/rsa: requires a panic if self-tests fail3w

dmitshur an issue net: TestDialContextCancelRace failures [consistent failure]3w

dmitshur fixed an issue all: remove support for windows/arm3w

The main bulk of the code for the windows/arm port has been removed from the main tree in time for Go 1.26, and the port removal is [documented](https://tip.golang.org/doc/go1.26#windows) in the rele…

dmitshur an issue net: TestDialContextCancelRace failures [consistent failure]3w

dmitshur starred github.com/Soreil/arw3w

dmitshur reopened an issue golang.org/x/crypto/x509roots: regeneration fails with "404 Not Found"3w

Reopening since this seems to continue to reproduce at least 1-2 days out of a week, fairly consistently over the last few weeks.

dmitshur an issue net: TestDialContextCancelRace failures [consistent failure]3w

dmitshur commented on net: TestDialContextCancelRace failures [consistent failure]3w

This consistent failure started with [CL 699256](https://go.dev/cl/699256). CC @database64128, @seankhliao, @dneil.

dmitshur an issue net: broken windows-race builder1mo

dmitshur pushed to main in dmitri.shuralyov.com/service/change5mo

6140fdcb140798fe4fda313c57be133bf235e796maintner, gerritapi: handle draft status

ce8900dcd6898d396808d962fd777dcf7be445e9gerritapi: pass context to Gerrit calls

96ed021e15235cb4abcdaa86b88cc271e47f04c1add minimal go.mod

dmitshur commented on dmitri.shuralyov.com/blog: Trying out the Oculus Rift CV1 for the first time1y

July 4, 2024. Today I got a chance to try out the Apple Vision Pro. :)

dmitshur pushed to main in dmitri.shuralyov.com/scratch1y

5eb48b5f5d31d39777719edb35d37b724f183dc8quine: add load-bearing trailing space

dmitshur created package in dmitri.shuralyov.com/scratch/quine1y

dmitshur merged a change dmitri.shuralyov.com/scratch: quine: add package quine1y

dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: quine: add package quine1y

LGTM. Thanks, and congrats on your first new Go package here! Done in PS 2. Patch set 2 seems to resolve this.

dmitshur merged a change dmitri.shuralyov.com/scratch: add AUTHORS.md file1y

dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y

Thanks! If it's ready to be submitted from your side, I can do that now.

dmitshur pushed to main in dmitri.shuralyov.com/html/belt1y

d8009a3578d1be4dafb93e9ee4894d2bbd2b5e3badd OnClick field to CommitID

63f3644d8635396fd13789affe363ee9f693e8ecadd dark mode support in Reference

dmitshur commented on dmitri.shuralyov.com/scratch: main: add package quine1y

They are. Although Go can make them too easy via `go:embed`. See some initial comments. I suggest either adding a quite that can be licensed via the existing BSD-3-Clause LICENSE at the top level o…

dmitshur reviewed +2 on dmitri.shuralyov.com/scratch: add AUTHORS.md file1y

Thanks! Congrats on your first change. :D See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload …

dmitshur pushed to main in dmitri.shuralyov.com/go/generated2y

e1de015411532fa144166aada4201ee443800425add test case with no final newline

6904a2a3d88d6c3ad39737a7c5bf226f5ebbd482modernize test code slightly

dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl2y

85de2813cf6bd8d6d2f0240fdebf943cbffc2b8afix "supportsFamily not found" warning on macOS 10.13 and 10.14

dmitshur pushed to main in dmitri.shuralyov.com/gpu/mtl2y

b78c9fe623cca0431d866c9e206d3f83665bcf8bdeprecate FeatureSet and Device.SupportsFeatureSet

2a3c46a829b92964146abf7f6c2d649cd66cce97add GPUFamily and Device.SupportsFamily

dmitshur closed an issue dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y

dmitshur commented on dmitri.shuralyov.com/idiomatic-go: Use defer if its overhead is relatively negligible, or it buys meaningful readability3y

I agree with the points made above. This entry tried to say "use this language feature when it's appropriate; don't use it when it's not", which can be said for any language feature. I'll close this …

dmitshur pushed to master in dmitri.shuralyov.com/service/change3y

67e22b2f18a260a33a98c6a7d601726a58c53767maintner: update for GitCommit API change

dmitshur closed an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y

dmitshur merged a change dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y

dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y

Go fuzzing support is out of beta and no longer uses this build constraint. It should be replaced with `go1.18` by now. Done in PS 3. I'm following the Go style for commit messages, which chooses…

dmitshur commented on dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes3y

Shortened 'golang.org' to 'go.dev' here, and on line 24.

dmitshur pushed to master in dmitri.shuralyov.com/website/gido4y

f460621dc784d8a8f3a1593a068115b62baf214dadd support for multiple comma-separated import path patterns

be77a538f6a64b287e073b59d1b9f7e1314cf3a9upgrade to go-git v5

b5ce3c19e6b977800ee3c80bc722192f96ef657breplace mention of godoc.org with pkg.go.dev

dmitshur opened an issue dmitri.shuralyov.com/go/generated: update implementation for 2020 spec changes4y

dmitshur pushed to master in dmitri.shuralyov.com/gpu/mtl4y

28db891af037715d8c1deec7652485a173c60e25all: add darwin/arm64 (macOS) support

dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y

d2c7b7eec450806980d4eefb626ccf6df2ef99dcupdate release branches to be for Go 1.15 and 1.14

dmitshur pushed to master in dmitri.shuralyov.com/website/gido5y

a78bd3c7abc465e1864ecadce67a826711a27caeadd support for "golang.org/x/pkgsite/..." issues

dmitshur pushed to master in dmitri.shuralyov.com/html/belt5y

f19ad8cb3e56f0fce6b45d5b68d7130214a0470aadd OnClick field

dmitshur closed an issue github.com/shurcooL/issuesapp: Improve use of http.Error.5y

dmitshur commented on github.com/shurcooL/issuesapp: Improve use of http.Error.5y

Resolved a while ago in [commit `431bb22d`](https://github.com/shurcooL/issuesapp/commit/431bb22d86ad0a95db0780e27ab6221b49238464).

Activity