dmitri.shuralyov.com/scratch/...

add AUTHORS.md file dmitri.shuralyov.com/scratch#1

Mergedjohanbrandhorst opened this change 6 months ago
johanbrandhorst commented 6 months ago

To make sure the authors are properly attributed

Write Preview Markdown
dmitshur reviewed +2 6 months ago

Thanks! Congrats on your first change. :D

See one inline comment that's unresolved (yellow border). You can leave a draft comment like "Done." and mark the 'Resolved' checkbox, then when you upload the next patch set that resolves it, it should auto-post the comment.

AUTHORS.md:1 (Patch Set 1) · 6 months ago · edited

never forget

Hah, a blast from the past. :)

I've been using dmitshur since 2018. Mind doing s/shurcooL/dmitshur/ mostly to see if you can upload patch set 2, and mark this thread as resolved?

Write Preview Markdown
Commit Message:9 (Patch Set 1) · 6 months ago

My stance on manually-maintained files like this matches that of the Go project, i.e., https://go.dev/AUTHORS. This information can be found via git log and such.

But this is scratch, so it's fine to add it.

Write Preview Markdown
johanbrandhorst uploaded Patch Set 2 6 months ago
AUTHORS.md:1 (Patch Set 1) · 6 months ago

I fixed it!

Write Preview Markdown
dmitshur reviewed +2 6 months ago

Thanks! If it's ready to be submitted from your side, I can do that now.

jbrandhorst.com commented 6 months ago

Go for it

dmitshur merged commit 91a3f527650ec98bb3712db0b53877af0ea4360f into main 6 months ago
Write Preview Markdown